[PATCH] selftests/run_kselftest.sh: Use readlink if realpath is not available

2025-03-18 Thread Yosry Ahmed
'realpath' is not always available, fallback to 'readlink -f' if is not available. They seem to work equally well in this context. Signed-off-by: Yosry Ahmed --- tools/testing/selftests/run_kselftest.sh | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/testing/se

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-18 Thread Maximilian Immanuel Brandtner
On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > wrote: > > According to the virtio spec[0] the virtio console resize struct > > defines > > cols before rows. In the kernel implementation it is the other way > > around > > resu

[PATCH 2/2] rcu: Robustify rcu_is_cpu_rrupt_from_idle()

2025-03-18 Thread Frederic Weisbecker
RCU relies on the context tracking nesting counter in order to determine if it is running in extended quiescent state. However the context tracking nesting counter is not completely synchronized with the actual context tracking state: * The nesting counter is set to 1 or incremented further _afte

[PATCH 1/2] rcu: Comment on the extraneous delta test on rcu_seq_done_exact()

2025-03-18 Thread Frederic Weisbecker
The numbers used in rcu_seq_done_exact() lack some explanation behind their magic. Especially after the commit: 85aad7cc4178 ("rcu: Fix get_state_synchronize_rcu_full() GP-start detection") which reported a subtle issue where a new GP sequence snapshot was taken on the root node state while

[PATCH 0/2] rcu: Random updates

2025-03-18 Thread Frederic Weisbecker
Hi, Just a bunch of things I had lagging in my local queue. Thanks. Frederic Weisbecker (2): rcu: Comment on the extraneous delta test on rcu_seq_done_exact() rcu: Robustify rcu_is_cpu_rrupt_from_idle() kernel/rcu/rcu.h | 7 +++ kernel/rcu/tree.c | 27 +-- 2 f

Re: [PATCH net 4/7] selftests/net: Add mixed select()+polling mode to TCP-AO tests

2025-03-18 Thread Paolo Abeni
On 3/12/25 10:10 AM, Dmitry Safonov wrote: > Currently, tcp_ao tests have two timeouts: TEST_RETRANSMIT_SEC and > TEST_TIMEOUT_SEC [by default 1 and 5 seconds]. The first one, > TEST_RETRANSMIT_SEC is used for operations that are expected to succeed > in order for a test to pass. It is usually not

Re: [PATCH PATCH 2/2] selftests: livepatch: test if ftrace can trace a livepatched function

2025-03-18 Thread Filipe Xavier
On 3/17/25 6:07 AM, Miroslav Benes wrote: On Fri, 14 Mar 2025, Filipe Xavier wrote: On 3/14/25 10:14 AM, Miroslav Benes wrote: Hi, +start_test "trace livepatched function and check that the live patch remains in effect" + +FUNCTION_NAME="livepatch_cmdline_proc_show" + +load_lp $MOD_LIVEPAT

[PATCH net-next 4/4] virtio_net: Allocate rss_hdr with devres

2025-03-18 Thread Akihiko Odaki
virtnet_probe() lacks the code to free rss_hdr in its error path. Allocate rss_hdr with devres so that it will be automatically freed. Fixes: 86a48a00efdf ("virtio_net: Support dynamic rss indirection table size") Signed-off-by: Akihiko Odaki --- drivers/net/virtio_net.c | 10 -- 1 file

[PATCH net-next 0/4] virtio_net: Fixes and improvements

2025-03-18 Thread Akihiko Odaki
+++- include/uapi/linux/virtio_net.h | 13 + 2 files changed, 56 insertions(+), 76 deletions(-) --- base-commit: d082ecbc71e9e0bf49883ee4afd435a77a5101b6 change-id: 20250318-virtio-6559d69187db Best regards, -- Akihiko Odaki

[PATCH] rcu/nocb: Dump gp state even if rdp gp itself is not offloaded

2025-03-18 Thread Frederic Weisbecker
When a stall is detected, the state of each NOCB CPU is dumped along with the state of each NOCB group. The latter part however is incidentally ignored if the NOCB group leader happens not to be offloaded itself. Fix this to make sure related precious informations aren't lost over a stall report.

Re: [PATCH 3/3] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

2025-03-18 Thread neil . armstrong
Hi, On 18/03/2025 00:24, Rob Herring (Arm) wrote: Use the newly added of_reserved_mem_region_to_resource() and of_reserved_mem_region_count() functions to handle "memory-region" properties. The error handling is a bit different in some cases. Often "memory-region" is optional, so failed lookup

Re: [PATCH 10/13] selftests/bpf: test_xsk: Split xskxceiver

2025-03-18 Thread Maciej Fijalkowski
On Thu, Mar 13, 2025 at 11:48:08AM +0100, Bastien Curutchet (eBPF Foundation) wrote: > AF_XDP features are tested by the test_xsk.sh script but not by the > test_progs framework. The tests used by the script are defined in > xksxceiver.c which can't be integrated in the test_progs framework as is.

Re: [PATCH] rseq/selftests: ensure the rseq abi TLS is actually 1024 bytes

2025-03-18 Thread Mark Brown
On Tue, Mar 18, 2025 at 10:50:58AM -0400, Michael Jeanson wrote: > On 2025-03-18 10:01, Mark Brown wrote: > > On Tue, Mar 11, 2025 at 03:21:45PM -0400, Michael Jeanson wrote: > > > > > Adding the aligned(1024) attribute to the definition of __rseq_abi did > > > not increase its size to 1024, for t

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-18 Thread Amit Shah
On Mon, 2025-03-10 at 14:04 +0100, Maximilian Immanuel Brandtner wrote: [...] > Just to make sure that everyone here is one the same page there is > indeed a difference between the ordering of the control resize > message > and the kernel implementation; however as this bug has been around > for

Re: [PATCHv4 RESEND net-next 0/2] selftests: wireguards: use nftables for testing

2025-03-18 Thread Hangbin Liu
Hi Jason, I saw the patch status[1] is still "Awaiting Upstream". Is there anything I need to do? https://patchwork.kernel.org/project/netdevbpf/patch/20250106081043.2073169-2-liuhang...@gmail.com/ Thanks Hangbin On Mon, Jan 06, 2025 at 08:10:41AM +, Hangbin Liu wrote: > This patch set conve

Re: [PATCH v4 0/4] Properly handle module_kobject creation

2025-03-18 Thread Shyam Saini
Hi Greg, > On 2/27/25 19:49, Shyam Saini wrote: > > Hi Everyone, > > > > This patch series fixes handling of module_kobject creation. > > A driver expect module_kset list populated with its corresponding > > module_kobject to create its /sys/module//drivers > > directory. > > > > Since, > > [1]

Re: [PATCH 3/3] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

2025-03-18 Thread Daniel Baluta
On Tue, Mar 18, 2025 at 1:25 AM Rob Herring (Arm) wrote: > > Use the newly added of_reserved_mem_region_to_resource() and > of_reserved_mem_region_count() functions to handle "memory-region" > properties. > > The error handling is a bit different in some cases. Often > "memory-region" is optional,

Re: [PATCH 2/3] arm64: dts: qcom: sm6350: Add OPP table support to UFSHC

2025-03-18 Thread Konrad Dybcio
On 3/17/25 1:12 PM, Luca Weiss wrote: > Hi Konrad, > > On Fri Mar 14, 2025 at 11:08 PM CET, Konrad Dybcio wrote: >> On 3/14/25 10:17 AM, Luca Weiss wrote: >>> UFS host controller, when scaling gears, should choose appropriate >>> performance state of RPMh power domain controller along with clock >

Re: [PATCH bpf-next 0/2] selftests/bpf: Migrate test_xdp_vlan.sh into test_progs

2025-03-18 Thread Bastien Curutchet
Hi all, On 2/24/25 5:10 PM, Stanislav Fomichev wrote: On 02/21, Bastien Curutchet (eBPF Foundation) wrote: Hi all, This patch series continues the work to migrate the script tests into prog_tests. test_xdp_vlan.sh tests the ability of an XDP program to modify the VLAN ids on the fly. This isn

Re: [PATCH 1/3] of: reserved_mem: Add functions to parse "memory-region"

2025-03-18 Thread Daniel Baluta
On Tue, Mar 18, 2025 at 1:24 AM Rob Herring (Arm) wrote: > > Drivers with "memory-region" properties currently have to do their own > parsing of "memory-region" properties. The result is all the drivers > have similar patterns of a call to parse "memory-region" and then get > the region's address

Re: [PATCH v6 0/4] Add virtio_rtc module

2025-03-18 Thread Peter Hilber
On Tue, Mar 18, 2025 at 10:04:07AM +0800, Lei Yang wrote: > QE tested this series of patches v6 with virtio-net regression tests, > everything works fine. > > Tested-by: Lei Yang > Hi Lei, thanks for the reply! However, I am not sure which virtio-net regression tests you are referring to, and

[PATCH net-next 2/4] virtio_net: Fix endian with virtio_net_ctrl_rss

2025-03-18 Thread Akihiko Odaki
Mark the fields of struct virtio_net_ctrl_rss as little endian as they are in struct virtio_net_rss_config, which it follows. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Signed-off-by: Akihiko Odaki --- drivers/net/virtio_net.c | 30 +++--- 1

[PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-18 Thread Akihiko Odaki
The new RSS configuration structures allow easily constructing data for VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly follow the order of data for the command. Signed-off-by: Akihiko Odaki --- drivers/net/virtio_net.c | 117 +-- 1 file changed, 43 ins

Re: [PATCH] rseq/selftests: ensure the rseq abi TLS is actually 1024 bytes

2025-03-18 Thread Michael Jeanson
On 2025-03-18 10:01, Mark Brown wrote: On Tue, Mar 11, 2025 at 03:21:45PM -0400, Michael Jeanson wrote: Adding the aligned(1024) attribute to the definition of __rseq_abi did not increase its size to 1024, for this attribute to impact the size of __rseq_abi it would need to be added to the decl

Re: [PATCH 10/13] selftests/bpf: test_xsk: Split xskxceiver

2025-03-18 Thread Bastien Curutchet
Hi Maciej, On 3/18/25 2:16 PM, Maciej Fijalkowski wrote: On Thu, Mar 13, 2025 at 11:48:08AM +0100, Bastien Curutchet (eBPF Foundation) wrote: AF_XDP features are tested by the test_xsk.sh script but not by the test_progs framework. The tests used by the script are defined in xksxceiver.c which

[PATCH bpf-next] selftests/bpf: Sanitize pointer prior fclose()

2025-03-18 Thread Björn Töpel
From: Björn Töpel There are scenarios where env.{sub,}test_state->stdout_saved, can be NULL, e.g. sometimes when the watchdog timeout kicks in, or if the open_memstream syscall is not available. Avoid crashing test_progs by adding an explicit NULL check prior the fclose() call. Signed-off-by: B

Re: [PATCH v2] openrisc: Add cacheinfo support

2025-03-18 Thread Stafford Horne
Hi Sahil, On Tue, Mar 18, 2025 at 12:06:30AM +0530, Sahil Siddiq wrote: > Hello Stafford and Geert, > > Thank you for the reviews. > > On 3/17/25 1:55 PM, Geert Uytterhoeven wrote: > > On Sun, 16 Mar 2025 at 07:59, Stafford Horne wrote: > > > [...] > > > > +struct cache_desc { > > > > + u32

[PATCH net-next v24 16/23] ovpn: implement keepalive mechanism

2025-03-18 Thread Antonio Quartulli
OpenVPN supports configuring a periodic keepalive packet. message to allow the remote endpoint detect link failures. This change implements the keepalive sending and timer expiring logic. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/io.c | 74 drivers/net/ovpn/i

Re: [PATCH bpf-next 09/11] bpf: Return PTR_ERR from push_stack()

2025-03-18 Thread Luis Gerhorst
Eduard Zingerman writes: > Could you please point me to a location, where exact error code > returned by updated push_stack() matters? > I checked push_stack() callgraph (in the attachment), but can't find > anything. Only with the final patch 11 ("bpf: Fall back to nospec for spec path verifica

Re: [PATCH] rcu/nocb: Dump gp state even if rdp gp itself is not offloaded

2025-03-18 Thread Paul E. McKenney
On Tue, Mar 18, 2025 at 10:23:36AM +0100, Frederic Weisbecker wrote: > When a stall is detected, the state of each NOCB CPU is dumped along > with the state of each NOCB group. The latter part however is > incidentally ignored if the NOCB group leader happens not to be > offloaded itself. > > Fix

Re: [PATCH] selftests/pidfd: align stack to fix SP alignment exception

2025-03-18 Thread Shuai Xue
+ ARM maintainers for review. 在 2025/3/12 14:15, Shuai Xue 写道: The pidfd_test fails on the ARM64 platform with the following error: Bail out! pidfd_poll check for premature notification on child thread exec test: Failed When exception-trace is enabled, the kernel logs the details:

[PATCH v2] rust: sync: rcu: Mark Guard methods as inline

2025-03-18 Thread I Hsin Cheng
Currently the implementation of "Guard" methods are basically wrappers around rcu's function within kernel. Building the kernel with llvm 18.1.8 on x86_64 machine will generate the following symbols: $ nm vmlinux | grep ' _R'.*Guard | rustfilt 817b6c90 T ::new 817b6cb0 T ::unlock f

Re: [PATCH 1/3] of: reserved_mem: Add functions to parse "memory-region"

2025-03-18 Thread Jonathan Cameron
On Mon, 17 Mar 2025 18:24:21 -0500 "Rob Herring (Arm)" wrote: > Drivers with "memory-region" properties currently have to do their own > parsing of "memory-region" properties. The result is all the drivers > have similar patterns of a call to parse "memory-region" and then get > the region's addr

Re: [PATCH bpf-next 11/11] bpf: Fall back to nospec for spec path verification

2025-03-18 Thread Alexei Starovoitov
On Thu, Mar 13, 2025 at 10:57 AM Luis Gerhorst wrote: > > This trades verification complexity for runtime overheads due to the > nospec inserted because of the EINVAL. > > With increased limits this allows applying mitigations to large BPF > progs such as the Parca Continuous Profiler's prog. Howe

[PATCH net-next v2 3/7] selftests/net: Fetch and check TCP-MD5 counters

2025-03-18 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> There are related TCP-MD5 <=> TCP and TCP-MD5 <=> TCP-AO tests that can benefit from checking the related counters, not only from validating operations timeouts. It also prepares the code for introduction of mixed select()+poll mode, see the follow-up p

[PATCH net-next v2 2/7] selftests/net: Provide tcp-ao counters comparison helper

2025-03-18 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Rename __test_tcp_ao_counters_cmp() into test_assert_counters_ao() and test_tcp_ao_key_counters_cmp() into test_assert_counters_key() as they are asserts, rather than just compare functions. Provide test_cmp_counters() helper, that's going to be used to

[PATCH net-next v2 5/7] selftests/net: Print the testing side in unsigned-md5

2025-03-18 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> As both client and server print the same test name on failure or pass, add "[server]" so that it's more obvious from a log which side printed "ok" or "not ok". Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- tools/testing/selftests/net/tcp_ao/

Re: [PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-18 Thread Jason Wang
On Tue, Mar 18, 2025 at 5:57 PM Akihiko Odaki wrote: > > The new RSS configuration structures allow easily constructing data for > VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly follow the order of data > for the command. > > Signed-off-by: Akihiko Odaki > --- > drivers/net/virtio_net.c | 117 >

[PATCH net-next v2 7/7] selftests/net: Drop timeout argument from test_client_verify()

2025-03-18 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> It's always TEST_TIMEOUT_SEC, with an unjustified exception in rst test, that is more paranoia-long timeout rather than based on requirements. Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- tools/testing/selftests/net/tcp_ao/connect.c

[PATCH net-next v2 6/7] selftests/net: Delete timeout from test_connect_socket()

2025-03-18 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Unused: it's always either the default timeout or asynchronous connect(). Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- tools/testing/selftests/net/tcp_ao/lib/aolib.h| 8 tools/testing/selftests/net/tcp_ao/lib/sock.c | 19 +

[PATCH net-next v2 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests

2025-03-18 Thread Dmitry Safonov via B4 Relay
Should fix flaky tcp-ao/connect-deny-ipv6 test. Begging pardon for the delay since the report and for sending it this late in the release cycle. To: David S. Miller To: Eric Dumazet To: Jakub Kicinski To: Paolo Abeni To: Simon Horman To: Shuah Khan Cc: net...@vger.kernel.org Cc: linux-kselft

[PATCH net-next v2 1/7] selftests/net: Print TCP flags in more common format

2025-03-18 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Before: ># 13145[lib/ftrace-tcp.c:427] trace event filter tcp_ao_key_not_found >[2001:db8:1::1:-1 => 2001:db8:254::1:7010, L3index 0, flags: !FS!R!P!., keyid: >100, rnext: 100, maclen: -1, sne: -1] = 1 After: ># 13487[lib/ftrace-tcp.c:427] trace event

[PATCH net-next v2 4/7] selftests/net: Add mixed select()+polling mode to TCP-AO tests

2025-03-18 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Currently, tcp_ao tests have two timeouts: TEST_RETRANSMIT_SEC and TEST_TIMEOUT_SEC [by default 1 and 5 seconds]. The first one, TEST_RETRANSMIT_SEC is used for operations that are expected to succeed in order for a test to pass. It is usually not consum

Re: [PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests

2025-03-18 Thread Dmitry Safonov
On Wed, 19 Mar 2025 at 03:20, Dmitry Safonov <0x7f454...@gmail.com> wrote: > > On Wed, 12 Mar 2025 at 09:11, Dmitry Safonov via B4 Relay > wrote: > > > > Should fix flaky tcp-ao/connect-deny-ipv6 test. > > Begging pardon for the delay since the report and for sending it this > > late in the releas

Re: [PATCH 2/5] rcu/exp: Remove confusing needless full barrier on task unblock

2025-03-18 Thread Paul E. McKenney
On Fri, Mar 14, 2025 at 03:36:39PM +0100, Frederic Weisbecker wrote: > A full memory barrier in the RCU-PREEMPT task unblock path advertizes > to order the context switch (or rather the accesses prior to > rcu_read_unlock()) with the expedited grace period fastpath. > > However the grace period ca

Re: [PATCH 4/5] rcu/exp: Warn on QS requested on dying CPU

2025-03-18 Thread Paul E. McKenney
On Fri, Mar 14, 2025 at 03:36:41PM +0100, Frederic Weisbecker wrote: > It is not possible to send an IPI to a dying CPU that has passed the > CPUHP_TEARDOWN_CPU stage. Remaining unhandled IPIs are handled later at > CPUHP_AP_SMPCFD_DYING stage by stop machine. This is the last > opportunity for RCU

[PATCH v2] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-03-18 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Some DSP firmware requires a FW_READY signal before proceeding, while others do not. Therefore, add support to handle i.MX DSP-specific features. Implement handle_rsc callback to handle resource table parsing and to process DSP-specific resource, to determine if waiting is n

Re: [PATCH net-next 1/4] virtio_net: Split struct virtio_net_rss_config

2025-03-18 Thread Jason Wang
On Tue, Mar 18, 2025 at 5:57 PM Akihiko Odaki wrote: > > struct virtio_net_rss_config was less useful in actual code because of a > flexible array placed in the middle. Add new structures that split it > into two to avoid having a flexible array in the middle. > > Suggested-by: Jason Wang > Signe

Re: [PATCH net-next 2/4] virtio_net: Fix endian with virtio_net_ctrl_rss

2025-03-18 Thread Jason Wang
On Tue, Mar 18, 2025 at 5:57 PM Akihiko Odaki wrote: > > Mark the fields of struct virtio_net_ctrl_rss as little endian as > they are in struct virtio_net_rss_config, which it follows. > > Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") > Signed-off-by: Akihiko Odaki Ack

[RFC -next 04/10] splice: Add SPLICE_F_ZC and attach ubuf

2025-03-18 Thread Joe Damato
Add the SPLICE_F_ZC flag and when it is set, allocate a ubuf and attach it to generate zerocopy notifications. Signed-off-by: Joe Damato --- fs/splice.c| 20 include/linux/splice.h | 3 ++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/fs/splice

Re: [PATCH net-next v2] vsock/test: Add test for null ptr deref when transport changes

2025-03-18 Thread Michal Luczaj
On 3/14/25 10:27, Luigi Leonardi wrote: > Add a new test to ensure that when the transport changes a null pointer > dereference does not occur[1]. > > Note that this test does not fail, but it may hang on the client side if > it triggers a kernel oops. > > This works by creating a socket, trying

[RFC -next 03/10] splice: Factor splice_socket into a helper

2025-03-18 Thread Joe Damato
splice_socket becomes a wrapper around splice_socket_generic which takes a ubuf pointer to prepare for zerocopy notifications. Signed-off-by: Joe Damato --- fs/splice.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/fs/splice.c b/fs

Re: [PATCH 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-18 Thread Josh Poimboeuf
On Tue, Mar 18, 2025 at 01:14:40PM -0700, Song Liu wrote: > > > > See for example all the error conditions in the x86 version of > > arch_stack_walk_reliable() and in arch/x86/kernel/unwind_frame.c. > > I guess I missed this part: > > diff --git i/arch/arm64/kernel/stacktrace.c w/arch/arm64/kerne

Re: [PATCH net 4/7] selftests/net: Add mixed select()+polling mode to TCP-AO tests

2025-03-18 Thread Dmitry Safonov
Hi Paolo, On Tue, 18 Mar 2025 at 14:47, Paolo Abeni wrote: > > On 3/12/25 10:10 AM, Dmitry Safonov wrote: [..] > > Reported-by: Jakub Kicinski > > Closes: https://lore.kernel.org/netdev/20241205070656.6ef34...@kernel.org/ > > Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> > > Could you ple

Re: [PATCH 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-18 Thread Song Liu
On Tue, Mar 18, 2025 at 4:00 PM Josh Poimboeuf wrote: > > On Tue, Mar 18, 2025 at 01:14:40PM -0700, Song Liu wrote: > > > > > > See for example all the error conditions in the x86 version of > > > arch_stack_walk_reliable() and in arch/x86/kernel/unwind_frame.c. > > > > I guess I missed this part:

[PATCH 0/4] Describe MT8188's SCP as dual-core

2025-03-18 Thread Nícolas F . R . A . Prado
ase-commit: 04b0d54949f9660384ceefc6f707e40daba6bf3e change-id: 20250318-scp-dual-core-mt8390-8ef1b02f2d92 Best regards, -- Nícolas F. R. A. Prado

Re: [PATCH 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-18 Thread Josh Poimboeuf
On Tue, Mar 18, 2025 at 04:38:20PM -0700, Song Liu wrote: > On Tue, Mar 18, 2025 at 4:00 PM Josh Poimboeuf wrote: > > - even in the -ENOENT case the unreliable bit has already been set > > right before the call to kunwind_next_frame_record_meta(). > > For this one, do you mean we set state-

Re: [PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-18 Thread Xuan Zhuo
On Tue, 18 Mar 2025 18:56:53 +0900, Akihiko Odaki wrote: > The new RSS configuration structures allow easily constructing data for > VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly follow the order of data > for the command. > > Signed-off-by: Akihiko Odaki > --- > drivers/net/virtio_net.c | 117

Re: [PATCH 5/5] rcu/exp: Warn on CPU lagging for too long within hotplug IPI's blindspot

2025-03-18 Thread Paul E. McKenney
On Fri, Mar 14, 2025 at 03:36:42PM +0100, Frederic Weisbecker wrote: > A CPU within hotplug operations can make the RCU exp kworker lagging if: > > * The dying CPU is running after CPUHP_TEARDOWN_CPU but before > rcutree_report_cpu_dead(). It is too late to send an IPI but RCU is > still watch

Re: [PATCH 1/5] rcu/exp: Protect against early QS report

2025-03-18 Thread Paul E. McKenney
On Fri, Mar 14, 2025 at 03:36:38PM +0100, Frederic Weisbecker wrote: > When a grace period is started, the ->expmask of each node is set up > from sync_exp_reset_tree(). Then later on each leaf node also initialize > its ->exp_tasks pointer. > > This means that the initialization of the quiescent

Re: [PATCH 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-18 Thread Josh Poimboeuf
On Fri, Mar 07, 2025 at 05:27:41PM -0800, Song Liu wrote: > With proper exception boundary detection, it is possible to implment > arch_stack_walk_reliable without sframe. > > Note that, arch_stack_walk_reliable does not guarantee getting reliable > stack in all scenarios. Instead, it can reliably

Re: [PATCH 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-18 Thread Song Liu
Hi Josh, Thanks for the review! On Tue, Mar 18, 2025 at 11:45 AM Josh Poimboeuf wrote: > > On Fri, Mar 07, 2025 at 05:27:41PM -0800, Song Liu wrote: > > With proper exception boundary detection, it is possible to implment > > arch_stack_walk_reliable without sframe. > > > > Note that, arch_stack

[PATCH net-next v24 21/23] ovpn: notify userspace when a peer is deleted

2025-03-18 Thread Antonio Quartulli
Whenever a peer is deleted, send a notification to userspace so that it can react accordingly. This is most important when a peer is deleted due to ping timeout, because it all happens in kernelspace and thus userspace has no direct way to learn about it. Signed-off-by: Antonio Quartulli --- dr

[RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-18 Thread Joe Damato
Greetings: Welcome to the RFC. Currently, when a user app uses sendfile the user app has no way to know if the bytes were transmit; sendfile simply returns, but it is possible that a slow client on the other side may take time to receive and ACK the bytes. In the meantime, the user app which call

[RFC -next 07/10] fs: Add sendfile2 which accepts a flags argument

2025-03-18 Thread Joe Damato
Add sendfile2 which is similar to sendfile64, but takes a flags argument. Signed-off-by: Joe Damato --- fs/read_write.c | 17 + 1 file changed, 17 insertions(+) diff --git a/fs/read_write.c b/fs/read_write.c index 03d2a93c3d1b..057e5f37645d 100644 --- a/fs/read_write.c +++ b/fs/

[RFC -next 06/10] fs: Extend do_sendfile to take a flags argument

2025-03-18 Thread Joe Damato
Extend the internal do_sendfile to take a flags argument, which will be used in future commits to signal that userland wants zerocopy notifications. This commit does not change anything about sendfile or sendfile64. Signed-off-by: Joe Damato --- fs/read_write.c | 18 +- 1 file c

[RFC -next 09/10] fs: Add sendfile2 syscall

2025-03-18 Thread Joe Damato
The sendfile2 system call is similar to sendfile64, but takes a flags argument allowing the user to select either a default sendfile or for sendfile to generate zerocopy notifications similar to MSG_ZEROCOPY and sendmsg. Signed-off-by: Joe Damato --- arch/alpha/kernel/syscalls/syscall.tbl |

[RFC -next 02/10] splice: Add helper that passes through splice_desc

2025-03-18 Thread Joe Damato
Add do_splice_from_sd which takes splice_desc as an argument. This helper is just a wrapper around splice_write but will be extended. Use the helper from existing splice code. Signed-off-by: Joe Damato --- fs/splice.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --g

[RFC -next 08/10] fs: Add sendfile flags for sendfile2

2025-03-18 Thread Joe Damato
Add a default flag (SENDFILE_DEFAULT) and a flag for requesting zerocopy notifications (SENDFILE_ZC). do_sendfile is updated to pass through the corresponding splice flag to enable zerocopy notifications. Signed-off-by: Joe Damato --- fs/read_write.c | 5 + include/linux/sendfile.h

[RFC -next 10/10] selftests: Add sendfile zerocopy notification test

2025-03-18 Thread Joe Damato
Extend the existing the msg_zerocopy test to allow testing sendfile to ensure that notifications are generated. Signed-off-by: Joe Damato --- tools/testing/selftests/net/msg_zerocopy.c | 54 - tools/testing/selftests/net/msg_zerocopy.sh | 5 ++ 2 files changed, 58 insertion

[RFC -next 05/10] fs: Add splice_write_sd to file operations

2025-03-18 Thread Joe Damato
Introduce splice_write_sd to file operations and export a new helper for sockets splice_to_socket_sd to pass through the splice_desc context allowing the allocated ubuf to be attached. Signed-off-by: Joe Damato --- fs/splice.c| 22 ++ include/linux/fs.h | 2 +

[RFC -next 01/10] splice: Add ubuf_info to prepare for ZC

2025-03-18 Thread Joe Damato
Update struct splice_desc to include ubuf_info to prepare splice for zero copy notifications. Signed-off-by: Joe Damato --- include/linux/splice.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/splice.h b/include/linux/splice.h index 9dec4861d09f..7477df3916e2 100644 --- a/i

Re: [PATCH v6 2/4] virtio_rtc: Add PTP clocks

2025-03-18 Thread kernel test robot
Hi Peter, kernel test robot noticed the following build warnings: [auto build test WARNING on 9d8960672d63db4b3b04542f5622748b345c637a] url: https://github.com/intel-lab-lkp/linux/commits/Peter-Hilber/virtio_rtc-Add-module-and-driver-core/20250314-014130 base: 9d8960672d63db4b3b04542f56227

Re: [PATCH v6 0/4] Add virtio_rtc module

2025-03-18 Thread Lei Yang
QE tested this series of patches v6 with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Fri, Mar 14, 2025 at 1:38 AM Peter Hilber wrote: > > This series implements a driver for a virtio-rtc device conforming to spec > proposal v8 [1]. It includes a PTP clock driver a

Re: [PATCH v4 08/16] rust: kunit: refactor to use `&raw [const|mut]`

2025-03-18 Thread David Gow
On Sun, 16 Mar 2025 at 14:20, Antonio Hickey wrote: > > Replacing all occurrences of `addr_of!(place)` and `addr_of_mut!(place)` > with `&raw const place` and `&raw mut place` respectively. > > This will allow us to reduce macro complexity, and improve consistency > with existing reference syntax

Re: [PATCH v8 0/3] rust: kunit: Support KUnit tests with a user-space like syntax

2025-03-18 Thread David Gow
On Fri, 7 Mar 2025 at 17:01, David Gow wrote: > > Hi all, > > This is v8 of the Rust/KUnit integration patch. I think all of the > suggestions have at least been responded to (even if there are a few I'm > leaving as either future projects or matters of taste). Hopefully this > is good-to-go for 6

Re: [PATCH] rseq/selftests: ensure the rseq abi TLS is actually 1024 bytes

2025-03-18 Thread Mark Brown
On Tue, Mar 11, 2025 at 03:21:45PM -0400, Michael Jeanson wrote: > Adding the aligned(1024) attribute to the definition of __rseq_abi did > not increase its size to 1024, for this attribute to impact the size of > __rseq_abi it would need to be added to the declaration of 'struct > rseq_abi'. We o

[PATCH net-next 1/4] virtio_net: Split struct virtio_net_rss_config

2025-03-18 Thread Akihiko Odaki
struct virtio_net_rss_config was less useful in actual code because of a flexible array placed in the middle. Add new structures that split it into two to avoid having a flexible array in the middle. Suggested-by: Jason Wang Signed-off-by: Akihiko Odaki --- include/uapi/linux/virtio_net.h | 13

Re: [PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests

2025-03-18 Thread Dmitry Safonov
On Wed, 12 Mar 2025 at 09:11, Dmitry Safonov via B4 Relay wrote: > > Should fix flaky tcp-ao/connect-deny-ipv6 test. > Begging pardon for the delay since the report and for sending it this > late in the release cycle. > > Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> I think patchwork can'

Re: [PATCH 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-18 Thread Josh Poimboeuf
On Tue, Mar 18, 2025 at 08:58:52PM -0700, Song Liu wrote: > On a closer look, I think we also need some logic in unwind_find_stack() > so that we can see when the unwinder hits the exception boundary. For > this reason, we may still need unwind_state.unreliable. I will look into > fixing this and s

Re: [PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-18 Thread Akihiko Odaki
On 2025/03/19 10:22, Xuan Zhuo wrote: On Tue, 18 Mar 2025 18:56:53 +0900, Akihiko Odaki wrote: The new RSS configuration structures allow easily constructing data for VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly follow the order of data for the command. Signed-off-by: Akihiko Odaki --- d

Re: [PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-18 Thread Akihiko Odaki
On 2025/03/19 10:43, Jason Wang wrote: On Tue, Mar 18, 2025 at 5:57 PM Akihiko Odaki wrote: The new RSS configuration structures allow easily constructing data for VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly follow the order of data for the command. Signed-off-by: Akihiko Odaki --- driv

Re: [PATCH net-next 4/4] virtio_net: Allocate rss_hdr with devres

2025-03-18 Thread Jason Wang
On Tue, Mar 18, 2025 at 5:57 PM Akihiko Odaki wrote: > > virtnet_probe() lacks the code to free rss_hdr in its error path. > Allocate rss_hdr with devres so that it will be automatically freed. > > Fixes: 86a48a00efdf ("virtio_net: Support dynamic rss indirection table size") > Signed-off-by: Akih

Re: [PATCH 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-18 Thread Song Liu
On Tue, Mar 18, 2025 at 6:03 PM Josh Poimboeuf wrote: > > On Tue, Mar 18, 2025 at 04:38:20PM -0700, Song Liu wrote: > > On Tue, Mar 18, 2025 at 4:00 PM Josh Poimboeuf wrote: > > > - even in the -ENOENT case the unreliable bit has already been set > > > right before the call to kunwind_next_

[PATCH v2 2/2] selftests: livepatch: test if ftrace can trace a livepatched function

2025-03-18 Thread Filipe Xavier
This new test makes sure that ftrace can trace a function that was introduced by a livepatch. Signed-off-by: Filipe Xavier --- tools/testing/selftests/livepatch/test-ftrace.sh | 34 1 file changed, 34 insertions(+) diff --git a/tools/testing/selftests/livepatch/test-ftr

[PATCH v2 1/2] selftests: livepatch: add new ftrace helpers functions

2025-03-18 Thread Filipe Xavier
Add new ftrace helpers functions cleanup_tracing, trace_function and check_traced_functions. Signed-off-by: Filipe Xavier --- tools/testing/selftests/livepatch/functions.sh | 49 ++ 1 file changed, 49 insertions(+) diff --git a/tools/testing/selftests/livepatch/functions

[PATCH v2 0/2] selftests: livepatch: test if ftrace can trace a livepatched function

2025-03-18 Thread Filipe Xavier
This patchset add ftrace helpers functions and add a new test makes sure that ftrace can trace a function that was introduced by a livepatch. Signed-off-by: Filipe Xavier Suggested-by: Marcos Paulo de Souza Reviewed-by: Marcos Paulo de Souza --- Changes in v2: - functions.sh: change check trace

Re: [PATCH 1/2] rcu: Comment on the extraneous delta test on rcu_seq_done_exact()

2025-03-18 Thread Paul E. McKenney
On Tue, Mar 18, 2025 at 02:56:18PM +0100, Frederic Weisbecker wrote: > The numbers used in rcu_seq_done_exact() lack some explanation behind > their magic. Especially after the commit: > > 85aad7cc4178 ("rcu: Fix get_state_synchronize_rcu_full() GP-start > detection") > > which reported a su

Re: [PATCH 3/3] rcu/exp: Remove needless CPU up quiescent state report

2025-03-18 Thread Paul E. McKenney
On Fri, Mar 14, 2025 at 03:39:05PM +0100, Frederic Weisbecker wrote: > Le Mon, Mar 03, 2025 at 12:10:50PM -0800, Paul E. McKenney a écrit : > > On Fri, Feb 14, 2025 at 12:25:59AM +0100, Frederic Weisbecker wrote: > > > A CPU coming online checks for an ongoing grace period and reports > > > a quies

[PATCH 1/4] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195

2025-03-18 Thread Nícolas F . R . A . Prado
Both MT8192 and MT8195 have an L1TCM memory, so it should be described in reg, and therefore reg's minItems should be 3, as is already implicit by reg-names. Override minItems to 3 for MT8192 and MT8195. Fixes: 6b55b1e2fd7f ("dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP") Signe

[PATCH 3/4] arm64: dts: mediatek: mt8188: Describe SCP as a cluster with two cores

2025-03-18 Thread Nícolas F . R . A . Prado
The SCP is currently described in the Devicetree as a single-core processor, but really it is a cluster with two cores. Describe the full cluster but enable only core0 on the current mt8188 platforms since that's the only one usable with the upstream firmware. Co-developed-by: Tinghan Shen Signed

[PATCH 2/4] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP

2025-03-18 Thread Nícolas F . R . A . Prado
The SCP present on MT8188 does not have an L1TCM memory region, but the binding incorrectly requires one for the dual-core description of the MT8188 SCP. Remove that requirement. Also update the minimum number of reg and reg-names to 1, since as this is a multi-core SCP with no L1TCM memory, only t

[PATCH 4/4] arm64: dts: mediatek: mt8390-genio-common: Add firmware-name for scp0

2025-03-18 Thread Nícolas F . R . A . Prado
Add the firmware-name property for SCP core0 so the firmware can be loaded from its canonical location in the linux-firmware repository. Signed-off-by: Nícolas F. R. A. Prado --- arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/