Re: [PATCH 00/32] kselftest harness and nolibc compatibility

2025-03-04 Thread Willy Tarreau
Hi Thomas, On Tue, Mar 04, 2025 at 08:10:30AM +0100, Thomas Weißschuh wrote: > Nolibc is useful for selftests as the test programs can be very small, > and compiled with just a kernel crosscompiler, without userspace support. > Currently nolibc is only usable with kselftest.h, not the more > conve

Re: [PATCH net-next v2 2/3] ieee802154: ca8210: Get platform data via dev_get_platdata()

2025-03-04 Thread Miquel Raynal
On 03/03/2025 at 18:49:09 +02, Andy Shevchenko wrote: > Access to platform data via dev_get_platdata() getter to make code cleaner. Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH v9 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()

2025-03-04 Thread Hugh Dickins
On Wed, 26 Feb 2025, Zi Yan wrote: > This is a preparation patch, both added functions are not used yet. > > The added __split_unmapped_folio() is able to split a folio with its > mapping removed in two manners: 1) uniform split (the existing way), and > 2) buddy allocator like split. > > The ad

selftests: cgroup: Failures – Timeouts & OOM Issues Analysis

2025-03-04 Thread Naresh Kamboju
As part of LKFT’s re-validation of known issues, we have observed that the selftests: cgroup suite is consistently failing across almost all LKFT-supported devices due to: - Test timeouts (45 seconds limit reached) - OOM-killer invocation ## Key Questions for Discussion: - Would it be beneficia

Re: [PATCH v21 20/24] ovpn: implement key add/get/del/swap via netlink

2025-03-04 Thread Sabrina Dubroca
2025-03-04, 01:33:50 +0100, Antonio Quartulli wrote: > int ovpn_nl_key_new_doit(struct sk_buff *skb, struct genl_info *info) > { ... > + pkr.slot = nla_get_u8(attrs[OVPN_A_KEYCONF_SLOT]); > + pkr.key.key_id = nla_get_u16(attrs[OVPN_A_KEYCONF_KEY_ID]); > + pkr.key.cipher_alg = nla_get_

[PATCHv4 net 0/3] bond: fix xfrm offload issues

2025-03-04 Thread Hangbin Liu
The first patch fixes the incorrect locks using in bond driver. The second patch fixes the xfrm offload feature during setup active-backup mode. The third patch add a ipsec offload testing. v4: hold xs->lock for bond_ipsec_{del, add}_sa_all (Cosmin Ratiu) use the defer helpers in lib.sh for se

Re: [PATCH net-next v3 3/3] ieee802154: ca8210: Switch to using gpiod API

2025-03-04 Thread Miquel Raynal
On 04/03/2025 at 13:22:34 +02, Andy Shevchenko wrote: > This updates the driver to gpiod API, and removes yet another use of > of_get_named_gpio(). > > With this, invert the logic of the reset pin which is active low > and add a quirk for the legacy and incorrect device tree descriptions. > > Re

Re: KASAN: global-out-of-bounds Read in srcu_gp_start_if_needed

2025-03-04 Thread Steven Rostedt
On Mon, 3 Mar 2025 22:57:32 -0500 Joel Fernandes wrote: > > > > The lock taken is from the passed in rcu_pending pointer. > > > > > [ 92.322655][ T28] rcu_pending_enqueue+0x686/0xd30 > > > [ 92.322676][ T28] ? __pfx_rcu_pending_enqueue+0x10/0x10 > > > [ 92.322693][ T28] ? trace

Re: [PATCH net-next v5 3/4] virtio-net: Map NAPIs to queues

2025-03-04 Thread Joe Damato
On Mon, Mar 03, 2025 at 04:03:55PM -0800, Jakub Kicinski wrote: > On Mon, 3 Mar 2025 13:33:10 -0500 Joe Damato wrote: > > > > @@ -2880,6 +2880,13 @@ static void refill_work(struct work_struct *work) > > > > bool still_empty; > > > > int i; > > > > > > > > + spin_lock(&vi->ref

Re: KASAN: global-out-of-bounds Read in srcu_gp_start_if_needed

2025-03-04 Thread Joel Fernandes
On 3/4/2025 10:11 AM, Steven Rostedt wrote: > On Mon, 3 Mar 2025 22:57:32 -0500 > Joel Fernandes wrote: > >>> >>> The lock taken is from the passed in rcu_pending pointer. >>> [ 92.322655][ T28] rcu_pending_enqueue+0x686/0xd30 [ 92.322676][ T28] ? __pfx_rcu_pending_enque

Re: [PATCH v15 3/8] remoteproc: Introduce load_fw and release_fw optional operation

2025-03-04 Thread Bjorn Andersson
On Wed, Feb 12, 2025 at 02:48:30PM +0100, Arnaud POULIQUEN wrote: > > > On 2/12/25 04:54, Bjorn Andersson wrote: > > On Tue, Dec 10, 2024 at 11:33:31AM +0100, Arnaud POULIQUEN wrote: > >> > >> > >> On 12/10/24 00:14, Bjorn Andersson wrote: > >>> On Thu, Nov 28, 2024 at 09:42:10AM GMT, Arnaud Poul

[PATCHv4 net 1/3] bonding: move IPsec deletion to bond_ipsec_free_sa

2025-03-04 Thread Hangbin Liu
The fixed commit placed mutex_lock() inside spin_lock_bh(), which triggers a warning: BUG: sleeping function called from invalid context at... Fix this by moving the IPsec deletion operation to bond_ipsec_free_sa, which is not held by spin_lock_bh(). Additionally, delete the IPsec list in bond

[PATCHv4 net 3/3] selftests: bonding: add ipsec offload test

2025-03-04 Thread Hangbin Liu
This introduces a test for IPSec offload over bonding, utilizing netdevsim for the testing process, as veth interfaces do not support IPSec offload. The test will ensure that the IPSec offload functionality remains operational even after a failover event occurs in the bonding configuration. Here i

[PATCHv4 net 2/3] bonding: fix xfrm offload feature setup on active-backup mode

2025-03-04 Thread Hangbin Liu
The active-backup bonding mode supports XFRM ESP offload. However, when a bond is added using command like `ip link add bond0 type bond mode 1 miimon 100`, the `ethtool -k` command shows that the XFRM ESP offload is disabled. This occurs because, in bond_newlink(), we change bond link first and reg

Re: selftests: cgroup: Failures – Timeouts & OOM Issues Analysis

2025-03-04 Thread Michal Koutný
Hello Naresh. On Tue, Mar 04, 2025 at 05:26:45PM +0530, Naresh Kamboju wrote: > As part of LKFT’s re-validation of known issues, we have observed that > the selftests: cgroup suite is consistently failing across almost all > LKFT-supported devices due to: > - Test timeouts (45 seconds limit rea

[syzbot] [virt?] KCSAN: data-race in virtqueue_disable_cb / virtqueue_enable_cb_delayed (9)

2025-03-04 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:99fa936e8e4f Merge tag 'affs-6.14-rc5-tag' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1462946458 kernel config: https://syzkaller.appspot.com/x/.config?x=523b0e2f15224775 das

Re: [PATCH] selftests/pcie_bwctrl: Add "set_pcie_speed.sh" to TEST_PROGS

2025-03-04 Thread Bjorn Helgaas
On Fri, Feb 28, 2025 at 03:00:59PM +0800, Yi Lai wrote: > The test shell script "set_pcie_speed.sh" is not installed in > INSTALL_PATH. Attempting to execute set_pcie_cooling_state.sh shows > warning: > > " > ./set_pcie_cooling_state.sh: line 119: ./set_pcie_speed.sh: No such file or > directory

Re: [PATCH v21 19/24] ovpn: implement peer add/get/dump/delete via netlink

2025-03-04 Thread Sabrina Dubroca
2025-03-04, 01:33:49 +0100, Antonio Quartulli wrote: > @@ -1317,11 +1336,16 @@ void ovpn_peer_keepalive_work(struct work_struct > *work) > > /* prevent rearming if the interface is being destroyed */ > if (next_run > 0 && ovpn->registered) { > + time64_t delta = next_run

Re: [PATCH v1 2/2] mm/slab/kvfree_rcu: Switch to WQ_MEM_RECLAIM wq

2025-03-04 Thread Paul E. McKenney
On Mon, Mar 03, 2025 at 11:08:24AM -0500, Joel Fernandes wrote: > On Fri, Feb 28, 2025 at 01:13:56PM +0100, Uladzislau Rezki (Sony) wrote: > > Currently kvfree_rcu() APIs use a system workqueue which is > > "system_unbound_wq" to driver RCU machinery to reclaim a memory. > > > > Recently, it has b

Re: [PATCH 2/3] net: ipa: Fix QSB data for v4.7

2025-03-04 Thread Alex Elder
On 2/27/25 4:33 AM, Luca Weiss wrote: As per downstream reference, max_writes should be 12 and max_reads should be 13. Fixes: b310de784bac ("net: ipa: add IPA v4.7 support") Signed-off-by: Luca Weiss Looks good. Reviewed-by: Alex Elder --- drivers/net/ipa/data/ipa_data-v4.7.c | 4 ++--

Re: [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem

2025-03-04 Thread Bjorn Andersson
On Sat, 22 Feb 2025 14:00:46 +0100, Luca Weiss wrote: > The main objective is setting firmware-name for the remoteprocs and > enabling the modem. > > The first two patches are just some cleanups to align the dts style with > contemporary style. > > > [...] Applied, thanks! [1/4] arm64: dts:

Re: [PATCH 3/3] net: ipa: Enable checksum for IPA_ENDPOINT_AP_MODEM_{RX,TX} for v4.7

2025-03-04 Thread Alex Elder
On 2/27/25 4:33 AM, Luca Weiss wrote: Enable the checksum option for these two endpoints in order to allow mobile data to actually work. Without this, no packets seem to make it through the IPA. Fixes: b310de784bac ("net: ipa: add IPA v4.7 support") Signed-off-by: Luca Weiss This makes sense.

Re: [PATCH 1/3] net: ipa: Fix v4.7 resource group names

2025-03-04 Thread Alex Elder
On 2/27/25 4:33 AM, Luca Weiss wrote: In the downstream IPA driver there's only one group defined for source and destination, and the destination group doesn't have a _DPL suffix. Fixes: b310de784bac ("net: ipa: add IPA v4.7 support") Signed-off-by: Luca Weiss FYI, I used this to check what y

[PATCH v2 0/3] media: i2c: lc898217xc: initial driver

2025-03-04 Thread Vasiliy Doylov
Rische Signed-off-by: Antonio Rische Signed-off-by: Vasiliy Doylov --- Changes in v2: - PM functions annotated as __maybe_unused. - Fixed dt bindings documentation commit message - Added v4l2 events (now v4l2-compliance shows no failed tests) - Link to v1: https://lore.kernel.org/r/20250304-media

Re: [PATCH 15/32] tools/nolibc: use intmax definitions from compiler

2025-03-04 Thread Willy Tarreau
On Tue, Mar 04, 2025 at 12:08:56PM +0100, Thomas Weißschuh wrote: > On Tue, Mar 04, 2025 at 08:37:42AM +0100, Willy Tarreau wrote: > > Hi Thomas, > > > > On Tue, Mar 04, 2025 at 08:10:45AM +0100, Thomas Weißschuh wrote: > > > The printf format checking in the compiler uses the intmax types from >

Re: [PATCH v9 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()

2025-03-04 Thread Andrew Morton
On Tue, 04 Mar 2025 11:20:53 -0500 Zi Yan wrote: > Do you mind folding Hugh’s fixes to this patch? Let me know if you prefer > a V10. Thanks. I think a new series, please. I'll remove the current version from mm.git. Can I suggest that you repeat Hugh's testing, hopefully see the same failures

Re: [PATCH 0/3] Fixes for IPA v4.7

2025-03-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 27 Feb 2025 11:33:39 +0100 you wrote: > During bringup of IPA v4.7 unfortunately some bits were missed, and it > couldn't be tested much back then due to missing features in tqftpserv > which caused the modem to n

Re: [PATCH v21 20/24] ovpn: implement key add/get/del/swap via netlink

2025-03-04 Thread Antonio Quartulli
On 05/03/2025 00:09, Sabrina Dubroca wrote: 2025-03-04, 13:11:28 +0100, Antonio Quartulli wrote: On 04/03/2025 13:00, Sabrina Dubroca wrote: 2025-03-04, 01:33:50 +0100, Antonio Quartulli wrote: int ovpn_nl_key_new_doit(struct sk_buff *skb, struct genl_info *info) { ... + pkr.slot

Re: [PATCH] vduse: add virtio_fs to allowed dev id

2025-03-04 Thread Jason Wang
On Tue, Feb 25, 2025 at 8:31 PM Michael S. Tsirkin wrote: > > On Tue, Feb 25, 2025 at 01:17:02PM +0100, Eugenio Perez Martin wrote: > > On Mon, Feb 24, 2025 at 10:51 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jan 21, 2025 at 11:33:46AM +0100, Eugenio Pérez wrote: > > > > A VDUSE device that

[PATCH v3] arch/x86: Fix size overflows in sgx_encl_create()

2025-03-04 Thread Jarkko Sakkinen
The total size calculated for EPC can overflow u64 given the added up page for SECS. Further, the total size calculated for shmem can overflow even when the EPC size stays within limits of u64, given that it adds the extra space for 128 byte PCMD structures (one for each page). Address this by pr

Re: [PATCH v2 1/3] MAINTAINERS: Add entry for Onsemi LC898217XC lens voice coil driver

2025-03-04 Thread Krzysztof Kozlowski
On Tue, Mar 04, 2025 at 10:32:18PM +0300, Vasiliy Doylov wrote: > Add entry for Onsemi LC898217XC lens voice coil driver > > Signed-off-by: Vasiliy Doylov > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index > 29e1a423eee5bcf9df

Re: [PATCH 24/32] tools/nolibc: add getopt()

2025-03-04 Thread Thomas Weißschuh
On Tue, Mar 04, 2025 at 08:54:29AM +0100, Willy Tarreau wrote: > On Tue, Mar 04, 2025 at 08:10:54AM +0100, Thomas Weißschuh wrote: > > diff --git a/tools/include/nolibc/getopt.h b/tools/include/nolibc/getopt.h > > new file mode 100644 > > index > > ..35aee58

Re: [PATCH v2 2/3] media: dt-bindings: Add LC898217XC documentation

2025-03-04 Thread Krzysztof Kozlowski
On Tue, Mar 04, 2025 at 10:32:19PM +0300, Vasiliy Doylov wrote: > +required: > + - compatible > + - reg > + - vcc-supply > + > +additionalProperties: false > + > +examples: > + - | > + If there is going to be resend/new version: drop above blank line. Reviewed-by: Krzysztof Kozlowski ---

Re: [PATCH net-next v2 3/3] ieee802154: ca8210: Switch to using gpiod API

2025-03-04 Thread Linus Walleij
On Tue, Mar 4, 2025 at 12:13 PM Andy Shevchenko wrote: > On Tue, Mar 04, 2025 at 01:03:41AM +0100, Linus Walleij wrote: > > On Mon, Mar 3, 2025 at 9:39 PM Andy Shevchenko > > wrote: > > > > > > Maybe add a comment in the code that this is wrong and the > > > > driver and DTS files should be fixed

[PATCH] arch/x86: Fix size overflows in sgx_encl_create()

2025-03-04 Thread Jarkko Sakkinen
The total size calculated for EPC can overflow u64 given the added up page for SECS. Further, the total size calculated for shmem can overflow even when the EPC size stays within limits of u64, given that it adds the extra space for 128 byte PCMD structures (one for each page). Address this by ad

Re: [PATCH v21 20/24] ovpn: implement key add/get/del/swap via netlink

2025-03-04 Thread Sabrina Dubroca
2025-03-04, 13:11:28 +0100, Antonio Quartulli wrote: > On 04/03/2025 13:00, Sabrina Dubroca wrote: > > 2025-03-04, 01:33:50 +0100, Antonio Quartulli wrote: > > > int ovpn_nl_key_new_doit(struct sk_buff *skb, struct genl_info *info) > > > { > > ... > > > + pkr.slot = nla_get_u8(attrs[OVPN_A_KEYC

Re: [RFC PATCH 27/39] KVM: guest_memfd: Allow mmapping guest_memfd files

2025-03-04 Thread Peter Xu
On Tue, Sep 10, 2024 at 11:43:58PM +, Ackerley Tng wrote: > @@ -790,6 +791,9 @@ static long kvm_gmem_punch_hole(struct inode *inode, > loff_t offset, loff_t len) >*/ > filemap_invalidate_lock(inode->i_mapping); > > + /* TODO: Check if even_cows should be 0 or 1 */ > + u

Re: [PATCH v21 18/24] ovpn: add support for peer floating

2025-03-04 Thread Antonio Quartulli
On 04/03/2025 19:37, Sabrina Dubroca wrote: 2025-03-04, 01:33:48 +0100, Antonio Quartulli wrote: A peer connected via UDP may change its IP address without reconnecting (float). Should that trigger a reset of the peer->dst_cache? And same when userspace updates the remote address? Otherwise it

Re: [PATCH] arch/x86: Fix size overflows in sgx_encl_create()

2025-03-04 Thread Dave Hansen
On 3/4/25 14:56, Jarkko Sakkinen wrote: > The total size calculated for EPC can overflow u64 given the added up page > for SECS. Further, the total size calculated for shmem can overflow even > when the EPC size stays within limits of u64, given that it adds the extra > space for 128 byte PCMD str

Re: [PATCH v21 09/24] ovpn: implement packet processing

2025-03-04 Thread Antonio Quartulli
On 04/03/2025 20:02, Sabrina Dubroca wrote: 2025-03-04, 01:33:39 +0100, Antonio Quartulli wrote: +struct crypto_aead *ovpn_aead_init(const char *title, const char *alg_name, + const unsigned char *key, + unsigned int keylen) nit

Re: [PATCH RFC] sched: Disable DL server if sysctl_sched_rt_runtime is -1

2025-03-04 Thread Joel Fernandes
On Tue, Mar 04, 2025 at 03:06:32PM -0500, Steven Rostedt wrote: > On Tue, 4 Mar 2025 15:01:16 -0500 > Joel Fernandes wrote: > > > Currently, RCU boost testing in rcutorture is broken because it relies on > > having RT throttling disabled. This means the test will always pass (or > > rarely fail)

Re: [PATCH] arch/x86: Fix size overflows in sgx_encl_create()

2025-03-04 Thread Jarkko Sakkinen
On Tue, Mar 04, 2025 at 03:30:54PM -0800, Dave Hansen wrote: > On 3/4/25 14:56, Jarkko Sakkinen wrote: > > The total size calculated for EPC can overflow u64 given the added up page > > for SECS. Further, the total size calculated for shmem can overflow even > > when the EPC size stays within limi

Re: [PATCH net-next v5 3/4] virtio-net: Map NAPIs to queues

2025-03-04 Thread Jason Wang
On Tue, Mar 4, 2025 at 11:09 PM Joe Damato wrote: > > On Mon, Mar 03, 2025 at 04:03:55PM -0800, Jakub Kicinski wrote: > > On Mon, 3 Mar 2025 13:33:10 -0500 Joe Damato wrote: > > > > > @@ -2880,6 +2880,13 @@ static void refill_work(struct work_struct > > > > > *work) > > > > > bool still_e

Re: [PATCH net-next v3 3/3] ieee802154: ca8210: Switch to using gpiod API

2025-03-04 Thread Krzysztof Kozlowski
On Tue, Mar 04, 2025 at 01:22:34PM +0200, Andy Shevchenko wrote: > This updates the driver to gpiod API, and removes yet another use of > of_get_named_gpio(). > > With this, invert the logic of the reset pin which is active low > and add a quirk for the legacy and incorrect device tree description

Re: [PATCH v4 3/3] rcu: Use _full() API to debug synchronize_rcu()

2025-03-04 Thread Uladzislau Rezki
> > Did I get that right? > > > > Other than I'm unable to follow what do you mean "WH has not been > injected, so nothing to wait on", maybe because I am missing some > terminology from you ;-) I think it's a good analysis, thank you! > > > I think this is a real bug AFAICS, hoping all the memo

Re: [PATCH RFC v2 00/10] SLUB percpu sheaves

2025-03-04 Thread Vlastimil Babka
On 2/25/25 21:26, Suren Baghdasaryan wrote: > On Mon, Feb 24, 2025 at 1:12 PM Suren Baghdasaryan wrote: >> >> > >> > > The values represent the total time it took to perform mmap syscalls, >> > > less is >> > > better. >> > > >> > > (1) baseline control >> > > Little core

Re: [PATCH v4 3/3] rcu: Use _full() API to debug synchronize_rcu()

2025-03-04 Thread Uladzislau Rezki
On Tue, Mar 04, 2025 at 11:52:26AM +0100, Uladzislau Rezki wrote: > > > Did I get that right? > > > > > > > Other than I'm unable to follow what do you mean "WH has not been > > injected, so nothing to wait on", maybe because I am missing some > > terminology from you ;-) I think it's a good anal

Re: [PATCH v2 4/4] KVM: riscv: selftests: Allow number of interrupts to be configurable

2025-03-04 Thread Andrew Jones
On Mon, Mar 03, 2025 at 02:53:09PM -0800, Atish Patra wrote: > It is helpful to vary the number of the LCOFI interrupts generated > by the overflow test. Allow additional argument for overflow test > to accommodate that. It can be easily cross-validated with > /proc/interrupts output in the host. >

Re: [PATCHv3 net 1/3] bonding: move IPsec deletion to bond_ipsec_free_sa

2025-03-04 Thread Hangbin Liu
Hi Cosmin, On Fri, Feb 28, 2025 at 10:31:58AM +, Cosmin Ratiu wrote: > On Fri, 2025-02-28 at 02:20 +, Hangbin Liu wrote: > > On Thu, Feb 27, 2025 at 03:31:01PM +0200, Nikolay Aleksandrov wrote: > > > > > One more thing - note I'm not an xfrm expert by far but it > > > > > seems to me here y

[PATCH] selftests/bpf: Move test_lwt_ip_encap to test_progs

2025-03-04 Thread Bastien Curutchet (eBPF Foundation)
test_lwt_ip_encap.sh isn't used by the BPF CI. Add a new file in the test_progs framework to migrate the tests done by test_lwt_ip_encap.sh. It uses the same network topology and the same BPF programs located in progs/test_lwt_ip_encap.c. Rework the GSO part to avoid using nc and dd. Remove test_

Re: [PATCH 15/32] tools/nolibc: use intmax definitions from compiler

2025-03-04 Thread Thomas Weißschuh
On Tue, Mar 04, 2025 at 08:37:42AM +0100, Willy Tarreau wrote: > Hi Thomas, > > On Tue, Mar 04, 2025 at 08:10:45AM +0100, Thomas Weißschuh wrote: > > The printf format checking in the compiler uses the intmax types from > > the compiler, not libc. This can lead to compiler errors. > > > > Instead

Re: [PATCH v8 1/7] rust: str: implement `PartialEq` for `BStr`

2025-03-04 Thread Fiona Behrens
Andreas Hindborg writes: > Implement `PartialEq` for `BStr` by comparing underlying byte slices. > > Reviewed-by: Alice Ryhl > Reviewed-by: Gary Guo > Reviewed-by: Daniel Almeida > Tested-by: Daniel Almeida > Signed-off-by: Andreas Hindborg Reviewed-by: Fiona Behrens > --- > rust/kernel/

Re: [PATCH 25/32] tools/nolibc: allow different write callbacks in printf

2025-03-04 Thread Thomas Weißschuh
On Tue, Mar 04, 2025 at 08:59:23AM +0100, Willy Tarreau wrote: > On Tue, Mar 04, 2025 at 08:10:55AM +0100, Thomas Weißschuh wrote: > > Decouple the formatting logic from the writing logic to later enable > > writing straight to a buffer in sprintf(). > > > > Signed-off-by: Thomas Weißschuh > > --

Re: [PATCH v8 3/7] rust: str: implement `AsRef` for `[u8]` and `BStr`

2025-03-04 Thread Fiona Behrens
Andreas Hindborg writes: > Implement `AsRef` for `[u8]` and `BStr` so these can be used > interchangeably for operations on `BStr`. > > Reviewed-by: Gary Guo > Tested-by: Daniel Almeida > Reviewed-by: Daniel Almeida > Signed-off-by: Andreas Hindborg Reviewed-by: Fiona Behrens > --- > rust

Re: [PATCH net-next v2 3/3] ieee802154: ca8210: Switch to using gpiod API

2025-03-04 Thread Andy Shevchenko
On Tue, Mar 04, 2025 at 01:03:41AM +0100, Linus Walleij wrote: > On Mon, Mar 3, 2025 at 9:39 PM Andy Shevchenko > wrote: > > > > Maybe add a comment in the code that this is wrong and the > > > driver and DTS files should be fixed. > > > > Or maybe fix in the driver and schema and add a quirk to

Re: [PATCH 4/4] KVM: riscv: selftests: Allow number of interrupts to be configurable

2025-03-04 Thread Andrew Jones
On Mon, Mar 03, 2025 at 01:27:47PM -0800, Atish Kumar Patra wrote: > On Thu, Feb 27, 2025 at 12:16 AM Andrew Jones wrote: > > > > On Wed, Feb 26, 2025 at 12:25:06PM -0800, Atish Patra wrote: ... > I will change the default value to 0 to avoid ambiguity for now. > Please let me know if you strongly

[PATCH net-next v3 3/3] ieee802154: ca8210: Switch to using gpiod API

2025-03-04 Thread Andy Shevchenko
This updates the driver to gpiod API, and removes yet another use of of_get_named_gpio(). With this, invert the logic of the reset pin which is active low and add a quirk for the legacy and incorrect device tree descriptions. Reviewed-by: Linus Walleij Signed-off-by: Andy Shevchenko --- .../bi

[PATCH net-next v3 2/3] ieee802154: ca8210: Get platform data via dev_get_platdata()

2025-03-04 Thread Andy Shevchenko
Access to platform data via dev_get_platdata() getter to make code cleaner. Reviewed-by: Linus Walleij Reviewed-by: Miquel Raynal Signed-off-by: Andy Shevchenko --- drivers/net/ieee802154/ca8210.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/ieee

[PATCH net-next v3 1/3] ieee802154: ca8210: Use proper setter and getters for bitwise types

2025-03-04 Thread Andy Shevchenko
Sparse complains that the driver doesn't respect the bitwise types: drivers/net/ieee802154/ca8210.c:1796:27: warning: incorrect type in assignment (different base types) drivers/net/ieee802154/ca8210.c:1796:27:expected restricted __le16 [addressable] [assigned] [usertype] pan_id drivers/net/

[PATCH net-next v3 0/3] ieee802154: ca8210: Sparse fix and GPIOd conversion

2025-03-04 Thread Andy Shevchenko
The main part is the patch 3 that converts the driver to GPIO descriptor APIs, the first one is just an ad-hoc fix WRT sparse complains on the bitwise types misuse. The second one is a small cleanup that helps patch 3 to be nicer. In v3: - inverted polarity of the reset line in accordance with dat

[PATCH v2 5/5] tools/nolibc: mark more test functions as static

2025-03-04 Thread Louis Taylor
It was mentioned that a new test_ function should be static, so go back over existing functions and mark those static as well. Signed-off-by: Louis Taylor --- tools/testing/selftests/nolibc/nolibc-test.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/tes

Re: [PATCH v2 1/5] tools/nolibc: add support for openat(2)

2025-03-04 Thread Willy Tarreau
Hi Louis, On Tue, Mar 04, 2025 at 07:58:15AM +, Louis Taylor wrote: > openat is useful to avoid needing to construct relative paths, so expose > a wrapper for using it directly. Reviewed the whole series, no comments from me. Let's wait for Thomas to double-check but for me it's OK: Acked-by

Re: [PATCHv3 net 1/3] bonding: move IPsec deletion to bond_ipsec_free_sa

2025-03-04 Thread Cosmin Ratiu
On Tue, 2025-03-04 at 09:18 +, Hangbin Liu wrote: > > Just to make sure I added the lock in correct place, would you please > help > confirm. > > diff --git a/drivers/net/bonding/bond_main.c > b/drivers/net/bonding/bond_main.c > index e85878b12376..c59ad3a5cf43 100644 > --- a/drivers/net/bond

Re: [PATCH net-next v8 0/8] Some pktgen fixes/improvments (part II)

2025-03-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Thu, 27 Feb 2025 14:55:56 +0100 you wrote: > While taking a look at '[PATCH net] pktgen: Avoid out-of-range in > get_imix_entries' ([1]) and '[PATCH net v2] pktgen: Avoid out-of-bounds > access in get_imix_entries' (

Re: [PATCH 27/32] tools/nolibc: add snprintf() and friends

2025-03-04 Thread Willy Tarreau
On Tue, Mar 04, 2025 at 08:10:57AM +0100, Thomas Weißschuh wrote: > +static int _sprintf_cb(intptr_t _state, const char *buf, size_t size) So logically we should have "nolibc" in that name as well. Willy

Re: [PATCH v21 20/24] ovpn: implement key add/get/del/swap via netlink

2025-03-04 Thread Antonio Quartulli
On 04/03/2025 13:00, Sabrina Dubroca wrote: 2025-03-04, 01:33:50 +0100, Antonio Quartulli wrote: int ovpn_nl_key_new_doit(struct sk_buff *skb, struct genl_info *info) { ... + pkr.slot = nla_get_u8(attrs[OVPN_A_KEYCONF_SLOT]); + pkr.key.key_id = nla_get_u16(attrs[OVPN_A_KEYCONF_

Re: [PATCH v15 2/8] remoteproc: Add TEE support

2025-03-04 Thread Bjorn Andersson
On Wed, Feb 12, 2025 at 02:42:28PM +0100, Arnaud POULIQUEN wrote: > Hello, > > On 2/12/25 04:18, Bjorn Andersson wrote: > > On Tue, Dec 10, 2024 at 09:57:40AM +0100, Arnaud POULIQUEN wrote: > >> Hello Bjorn, > >> > >> On 12/6/24 23:07, Bjorn Andersson wrote: > >>> On Thu, Nov 28, 2024 at 09:42:09A

Re: [PATCH v9 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()

2025-03-04 Thread Zi Yan
On 4 Mar 2025, at 6:49, Hugh Dickins wrote: > On Wed, 26 Feb 2025, Zi Yan wrote: > >> This is a preparation patch, both added functions are not used yet. >> >> The added __split_unmapped_folio() is able to split a folio with its >> mapping removed in two manners: 1) uniform split (the existing way

Re: [PATCH v9 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()

2025-03-04 Thread Zi Yan
On 4 Mar 2025, at 15:29, Andrew Morton wrote: > On Tue, 04 Mar 2025 11:20:53 -0500 Zi Yan wrote: > >> Do you mind folding Hugh’s fixes to this patch? Let me know if you prefer >> a V10. Thanks. > > I think a new series, please. I'll remove the current version from mm.git. > > Can I suggest that y

Re: [PATCH] selftests: proofreading bpf module

2025-03-04 Thread Armin Mahdilou
On Mon, 2025-02-10 at 04:04 +0100, Armin wrote: > Fixed multiple spelling issues in the kselftests bpf modules. > > Signed-off-by: Armin > --- Hi, Just a kind reminder about this patch. Thanks in advance. Regards, Armin

Re: [PATCH v21 19/24] ovpn: implement peer add/get/dump/delete via netlink

2025-03-04 Thread Antonio Quartulli
On 04/03/2025 15:35, Sabrina Dubroca wrote: 2025-03-04, 01:33:49 +0100, Antonio Quartulli wrote: @@ -1317,11 +1336,16 @@ void ovpn_peer_keepalive_work(struct work_struct *work) /* prevent rearming if the interface is being destroyed */ if (next_run > 0 && ovpn->registered) { +

[PATCH RFC] sched: Disable DL server if sysctl_sched_rt_runtime is -1

2025-03-04 Thread Joel Fernandes
Currently, RCU boost testing in rcutorture is broken because it relies on having RT throttling disabled. This means the test will always pass (or rarely fail). This occurs because recently, RT throttling was replaced by DL server which boosts CFS tasks even when rcutorture tried to disable throttli

Re: [PATCH RFC v2 00/10] SLUB percpu sheaves

2025-03-04 Thread Suren Baghdasaryan
On Tue, Mar 4, 2025 at 2:55 AM Vlastimil Babka wrote: > > On 2/25/25 21:26, Suren Baghdasaryan wrote: > > On Mon, Feb 24, 2025 at 1:12 PM Suren Baghdasaryan > > wrote: > >> > >> > > >> > > The values represent the total time it took to perform mmap syscalls, > >> > > less is > >> > > better. >

Re: [PATCH v21 18/24] ovpn: add support for peer floating

2025-03-04 Thread Sabrina Dubroca
2025-03-04, 01:33:48 +0100, Antonio Quartulli wrote: > A peer connected via UDP may change its IP address without reconnecting > (float). Should that trigger a reset of the peer->dst_cache? And same when userspace updates the remote address? Otherwise it seems we could be stuck with a cached dst t

Re: [PATCH v21 09/24] ovpn: implement packet processing

2025-03-04 Thread Sabrina Dubroca
2025-03-04, 01:33:39 +0100, Antonio Quartulli wrote: > +struct crypto_aead *ovpn_aead_init(const char *title, const char *alg_name, > +const unsigned char *key, > +unsigned int keylen) nit: static? I don't see it used outside this fil

[PATCH v2 1/3] MAINTAINERS: Add entry for Onsemi LC898217XC lens voice coil driver

2025-03-04 Thread Vasiliy Doylov
Add entry for Onsemi LC898217XC lens voice coil driver Signed-off-by: Vasiliy Doylov --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 29e1a423eee5bcf9df7938aaffe5bd3e2f6a2bbe..c15223f063357a8f89cf12f46ebcb7bd062903f3 100644 --- a/MAINT

[PATCH v2 2/3] media: dt-bindings: Add LC898217XC documentation

2025-03-04 Thread Vasiliy Doylov
Add device tree bindings documentation for ON Semiconductor LC898217XC voice coil motor. Signed-off-by: Vasiliy Doylov --- .../bindings/media/i2c/onnn,lc898217xc.yaml| 54 ++ 1 file changed, 54 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/on

[PATCH v2 3/3] media: i2c: Add driver for LC898217XC VCM

2025-03-04 Thread Vasiliy Doylov
LC898217XC is a 11 bit DAC, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus. Tested on Oneplus 6 (oneplus-enchilada) Signed-off-by: Vasiliy Doylov --- drivers/media/i2c/Kconfig | 11 ++ drivers/media/i2c/M

Re: [PATCH RFC v2 00/10] SLUB percpu sheaves

2025-03-04 Thread Liam R. Howlett
* Vlastimil Babka [250304 05:55]: > On 2/25/25 21:26, Suren Baghdasaryan wrote: > > On Mon, Feb 24, 2025 at 1:12 PM Suren Baghdasaryan > > wrote: > >> > >> > > >> > > The values represent the total time it took to perform mmap syscalls, > >> > > less is > >> > > better. > >> > > > >> > > (1)

Re: [PATCH net-next 0/5] mptcp: improve code coverage and small optimisations

2025-03-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 28 Feb 2025 15:38:34 +0100 you wrote: > This small series have various unrelated patches: > > - Patch 1 and 2: improve code coverage by validating mptcp_diag_dump_one > thanks to a new tool displaying MPTC

[PATCH rcu 03/10] rcu: Fix get_state_synchronize_rcu_full() GP-start detection

2025-03-04 Thread Boqun Feng
From: "Paul E. McKenney" The get_state_synchronize_rcu_full() and poll_state_synchronize_rcu_full() functions use the root rcu_node structure's ->gp_seq field to detect the beginnings and ends of grace periods, respectively. This choice is necessary for the poll_state_synchronize_rcu_full() func

[PATCH rcu 02/10] rcu: Remove READ_ONCE() for rdp->gpwrap access in __note_gp_changes()

2025-03-04 Thread Boqun Feng
From: Zilin Guan There is one access to the per-CPU rdp->gpwrap field in the __note_gp_changes() function that does not use READ_ONCE(), but all other accesses do use READ_ONCE(). When using the 8*TREE03 and CONFIG_NR_CPUS=8 configuration, KCSAN found no data races at that point. This is becaus

[PATCH rcu 01/10] rcu: Split rcu_report_exp_cpu_mult() mask parameter and use for tracing

2025-03-04 Thread Boqun Feng
From: "Paul E. McKenney" This commit renames the rcu_report_exp_cpu_mult() function from "mask" to "mask_in" and introduced a "mask" local variable to better support upcoming event-tracing additions. Signed-off-by: Paul E. McKenney Cc: Frederic Weisbecker Signed-off-by: Boqun Feng --- kernel

[PATCH rcu 00/10] Miscellaneous RCU changes for v6.15

2025-03-04 Thread Boqun Feng
Hi, Please find the upcoming miscellaneous RCU changes. The changes can also be found at: git://git.kernel.org/pub/scm/linux/kernel/git/rcu/linux.git misc.2025.03.04a Regards, Boqun Paul E. McKenney (6): rcu: Split rcu_report_exp_cpu_mult() mask parameter and use for tracing rc

[PATCH rcu 08/10] rcutorture: Allow a negative value for nfakewriters

2025-03-04 Thread Boqun Feng
From: "Uladzislau Rezki (Sony)" Currently "nfakewriters" parameter can be set to any value but there is no possibility to adjust it automatically based on how many CPUs a system has where a test is run on. To address this, if the "nfakewriters" is set to negative it will be adjusted to num_onlin

[PATCH rcu 05/10] rcu/nocb: Print segment lengths in show_rcu_nocb_gp_state()

2025-03-04 Thread Boqun Feng
From: "Paul E. McKenney" Analysis of an rcutorture callback-based forward-progress test failure was hampered by the lack of ->cblist segment lengths. This commit therefore adds this information, so that what would have been ".W85620.N." (there are some callbacks waiting for grace period sequence

[PATCH rcu 07/10] Flush console log from kernel_power_off()

2025-03-04 Thread Boqun Feng
From: "Paul E. McKenney" Kernels built with CONFIG_PREEMPT_RT=y can lose significant console output and shutdown time, which hides shutdown-time RCU issues from rcutorture. Therefore, make pr_flush() public and invoke it after then last print in kernel_power_off(). [ paulmck: Apply John Ogness f

[PATCH rcu 06/10] context_tracking: Make RCU watch ct_kernel_exit_state() warning

2025-03-04 Thread Boqun Feng
From: "Paul E. McKenney" The WARN_ON_ONCE() in ct_kernel_exit_state() follows the call to ct_state_inc(), which means that RCU is not watching this WARN_ON_ONCE(). This can (and does) result in extraneous lockdep warnings when this WARN_ON_ONCE() triggers. These extraneous warnings are the oppos

[PATCH rcu 09/10] rcu: Update TREE05.boot to test normal synchronize_rcu()

2025-03-04 Thread Boqun Feng
From: "Uladzislau Rezki (Sony)" Add extra parameters for rcutorture module. One is the "nfakewriters" which is set -1. There will be created number of test-kthreads which correspond to number of CPUs in a test system. Those threads randomly invoke synchronize_rcu() call. Apart of that "rcu_norma

[PATCH rcu 10/10] rcu: Use _full() API to debug synchronize_rcu()

2025-03-04 Thread Boqun Feng
From: "Uladzislau Rezki (Sony)" Switch for using of get_state_synchronize_rcu_full() and poll_state_synchronize_rcu_full() pair to debug a normal synchronize_rcu() call. Just using "not" full APIs to identify if a grace period is passed or not might lead to a false-positive kernel splat. It can

Re: [PATCH v21 18/24] ovpn: add support for peer floating

2025-03-04 Thread Antonio Quartulli
On 05/03/2025 00:19, Antonio Quartulli wrote: On 04/03/2025 19:37, Sabrina Dubroca wrote: 2025-03-04, 01:33:48 +0100, Antonio Quartulli wrote: A peer connected via UDP may change its IP address without reconnecting (float). Should that trigger a reset of the peer->dst_cache? And same when

Re: [PATCH] vhost: fix VHOST_*_OWNER documentation

2025-03-04 Thread Jason Wang
On Mon, Mar 3, 2025 at 5:29 PM Eugenio Perez Martin wrote: > > On Mon, Mar 3, 2025 at 9:52 AM Stefano Garzarella wrote: > > > > VHOST_OWNER_SET and VHOST_OWNER_RESET are used in the documentation > > instead of VHOST_SET_OWNER and VHOST_RESET_OWNER respectively. > > > > To avoid confusion, let's

Re: [PATCH v4 3/3] rcu: Use _full() API to debug synchronize_rcu()

2025-03-04 Thread Boqun Feng
On Tue, Mar 04, 2025 at 11:56:18AM +0100, Uladzislau Rezki wrote: > On Tue, Mar 04, 2025 at 11:52:26AM +0100, Uladzislau Rezki wrote: > > > > Did I get that right? > > > > > > > > > > Other than I'm unable to follow what do you mean "WH has not been > > > injected, so nothing to wait on", maybe b