Re: [PATCH 2/2] Input: goodix_berlin - Add support for Berlin-A series

2025-02-03 Thread Luca Weiss
On Mon Feb 3, 2025 at 6:43 PM CET, Jens Reidel wrote: > The current implementation of the goodix_berlin driver lacks support for > revisions A and B of the Berlin IC. This change adds support for the > gt9897 IC, which is a Berlin-A revision part. > > The differences between revision D and A are ra

Re: [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

2025-02-03 Thread Christoph Hellwig
> +static inline struct module_kobject * __init > lookup_or_create_module_kobject(const char *name) Crazily unreadable line. Either way this is not a function that should be inline in a header. Both due to sheer size, but also due to what it does and what it pulls in. > +{ > + struct module

Re: [PATCH 00/16] selftests: vDSO: parse_vdso: Make compatible with nolibc

2025-02-03 Thread Christophe Leroy
Le 03/02/2025 à 14:50, Thomas Weißschuh a écrit : On Mon, Feb 03, 2025 at 12:23:29PM +0100, Christophe Leroy wrote: Le 03/02/2025 à 10:05, Thomas Weißschuh a écrit : For testing the functionality of the vDSO, it is necessary to build userspace programs for multiple different architectures. I

Re: [PATCH RFC net-next] netconsole: selftest: Add test for fragmented messages

2025-02-03 Thread Breno Leitao
On Mon, Feb 03, 2025 at 02:21:02PM +, Simon Horman wrote: > On Mon, Feb 03, 2025 at 03:00:37AM -0800, Breno Leitao wrote: > > Hello Simon, > > > > On Mon, Feb 03, 2025 at 10:48:55AM +, Simon Horman wrote: > > > On Fri, Jan 31, 2025 at 04:39:38AM -0800, Breno Leitao wrote: > > > > > > +# V

Re: [PATCH 0/6] selftests/nolibc: wire up riscv32

2025-02-03 Thread patchwork-bot+linux-riscv
Hello: This series was applied to riscv/linux.git (fixes) by Thomas Weißschuh : On Sat, 21 Dec 2024 15:44:27 +0100 you wrote: > Nolibc has support for riscv32. But the testsuite did not allow to test > it so far. Add a test configuration. > > Signed-off-by: Thomas Weißschuh > --- > Thomas Weißs

[v1 0/3] Properly handle module_kboject creation

2025-02-03 Thread Shyam Saini
Hi Everyone, This patch series fixes handling of module_kboject creation. A driver expect module_kset list populated with its corresponding module_kboject to create its /sys/module//drivers directory. Since, [1] commit 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_init

[v1 1/3] kernel: param: rename locate_module_kobject

2025-02-03 Thread Shyam Saini
locate_module_kobject() look up for existing module_kobject For given module name locate_module_kobject() look up for corresponding module_kobject if it exists. If it coudln't find its corresponding module_kobject then it creates one for the given name. Rename locate_module_kobject() to lookup_or_c

[v1 3/3] drivers: base: handle module_kboject creation

2025-02-03 Thread Shyam Saini
module_add_driver() relies on module_kset list for /sys/module//drivers directory creation. Since, commit 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time") drivers which are initialized from subsys_initcall() or any other higher precedence initcall couldn't

[v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

2025-02-03 Thread Shyam Saini
Move the following to module.h to allow common usages: - lookup_or_create_module_kobject() - to_module_attr - to_module_kobject This makes lookup_or_create_module_kobject() as inline. Signed-off-by: Shyam Saini --- include/linux/module.h | 39 +++ kernel/p

[PATCH net-next] netconsole: selftest: Add test for fragmented messages

2025-02-03 Thread Breno Leitao
Add a new selftest to verify netconsole's handling of messages that exceed the packet size limit and require fragmentation. The test sends messages with varying sizes and userdata, validating that: 1. Large messages are correctly fragmented and reassembled 2. Userdata fields are properly preserved

[PATCH AUTOSEL 6.13 4/5] selftests: gpio: gpio-sim: Fix missing chip disablements

2025-02-03 Thread Sasha Levin
From: Koichiro Den [ Upstream commit f8524ac33cd452aef5384504b3264db6039a455e ] Since upstream commit 8bd76b3d3f3a ("gpio: sim: lock up configfs that an instantiated device depends on"), rmdir for an active virtual devices been prohibited. Update gpio-sim selftest to align with the change. Rep

[PATCH AUTOSEL 6.12 3/4] selftests: gpio: gpio-sim: Fix missing chip disablements

2025-02-03 Thread Sasha Levin
From: Koichiro Den [ Upstream commit f8524ac33cd452aef5384504b3264db6039a455e ] Since upstream commit 8bd76b3d3f3a ("gpio: sim: lock up configfs that an instantiated device depends on"), rmdir for an active virtual devices been prohibited. Update gpio-sim selftest to align with the change. Rep

[PATCH AUTOSEL 6.6 2/3] selftests: gpio: gpio-sim: Fix missing chip disablements

2025-02-03 Thread Sasha Levin
From: Koichiro Den [ Upstream commit f8524ac33cd452aef5384504b3264db6039a455e ] Since upstream commit 8bd76b3d3f3a ("gpio: sim: lock up configfs that an instantiated device depends on"), rmdir for an active virtual devices been prohibited. Update gpio-sim selftest to align with the change. Rep

[PATCH AUTOSEL 6.1 2/2] selftests: gpio: gpio-sim: Fix missing chip disablements

2025-02-03 Thread Sasha Levin
From: Koichiro Den [ Upstream commit f8524ac33cd452aef5384504b3264db6039a455e ] Since upstream commit 8bd76b3d3f3a ("gpio: sim: lock up configfs that an instantiated device depends on"), rmdir for an active virtual devices been prohibited. Update gpio-sim selftest to align with the change. Rep

[PATCH] gendwarfksyms: Add a separate pass to resolve FQNs

2025-02-03 Thread Sami Tolvanen
Using dwarf_getscopes_die to resolve fully-qualified names turns out to be rather slow, and also results in duplicate scopes being processed, which doesn't help. Simply adding an extra pass to resolve names for all DIEs before processing exports is noticeably faster. For the object files with the

Re: [RFC PATCH 1/4] perf: arm_pmuv3: Introduce module param to partition the PMU

2025-02-03 Thread Colton Lewis
Colton Lewis writes: Marc Zyngier writes: On Tue, 28 Jan 2025 22:08:27 +, Colton Lewis wrote: >> + bitmap_set(cpu_pmu->cntr_mask, 0, pmcr_n); >> + >> + if (reserved_guest_counters > 0 && reserved_guest_counters < pmcr_n) { >> + cpu_pmu->hpmn = reserved_guest_c

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-03 Thread Song Liu
On Mon, Feb 3, 2025 at 1:45 AM Yafang Shao wrote: [...] > > If you’re managing a large fleet of servers, this issue is far from > negligible. > > > > > > Can you provide examples of companies that use atomic replacement at > > > scale in their production environments? > > > > At least SUSE uses i

Re: [syzbot] [net?] general protection fault in add_wait_queue

2025-02-03 Thread Michal Luczaj
On 2/3/25 10:57, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:c2933b2befe2 Merge tag 'net-6.14-rc1' of git://git.kernel... > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=16f676b058 > kernel config: https://syzkall

Re: [PATCH 1/2] dt-bindings: input: goodix,gt9916: Document gt9897 compatible

2025-02-03 Thread Rob Herring (Arm)
On Mon, 03 Feb 2025 18:43:08 +0100, Jens Reidel wrote: > Document the Goodix GT9897 which is a Berlin-A series touchscreen > controller IC by Goodix. > > Signed-off-by: Jens Reidel > --- > .../devicetree/bindings/input/touchscreen/goodix,gt9916.yaml | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH 0/4] ucount: Simplify refcounting with rcuref_t.

2025-02-03 Thread Paul E. McKenney
On Mon, Feb 03, 2025 at 04:05:21PM +0100, Sebastian Andrzej Siewior wrote: > I noticed that the atomic_dec_and_lock_irqsave() in put_ucounts() loops > sometimes even during boot. Something like 2-3 iterations but still. > This series replaces the refcounting with rcuref_t and adds a RCU > lookup. >

Re: [PATCH net-next v2 2/2] selftests: drv-net: Test queue xsk attribute

2025-02-03 Thread Jakub Kicinski
On Mon, 3 Feb 2025 18:58:23 + Joe Damato wrote: > +/** > + * this is a simple helper program that creates an XDP socket and does the > + * minimum necessary to get bind() to succeed. > + * > + * this test program is not intended to actually process packets, but could > be > + * extended in th

Re: [PATCH net-next v18 20/25] ovpn: implement peer add/get/dump/delete via netlink

2025-02-03 Thread Antonio Quartulli
On 03/02/2025 00:07, Sabrina Dubroca wrote: 2025-01-13, 10:31:39 +0100, Antonio Quartulli wrote: +static int ovpn_nl_attr_sockaddr_remote(struct nlattr **attrs, + struct sockaddr_storage *ss) +{ + struct sockaddr_in6 *sin6; + struct sockaddr_in *

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-03 Thread Yafang Shao
On Fri, Jan 31, 2025 at 9:18 PM Miroslav Benes wrote: > > > > > > > + What exactly is meant by frequent replacements (busy loop?, once a > > > minute?) > > > > The script: > > > > #!/bin/bash > > while true; do > > yum install -y ./kernel-livepatch-6.1.12-0.x86_64.rpm > > ./appl

[syzbot] [net?] general protection fault in add_wait_queue

2025-02-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c2933b2befe2 Merge tag 'net-6.14-rc1' of git://git.kernel... git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=16f676b058 kernel config: https://syzkaller.appspot.com/x/.config?x=d033b14aeef39158 das

Re: [PATCH net-next v18 08/25] ovpn: implement basic RX path (UDP)

2025-02-03 Thread Antonio Quartulli
On 03/02/2025 10:30, Sabrina Dubroca wrote: 2025-01-13, 10:31:27 +0100, Antonio Quartulli wrote: +/** + * ovpn_opcode_from_skb - extract OP code from skb at specified offset + * @skb: the packet to extract the OP code from + * @offset: the offset in the data buffer where the OP code is locate

Re: [PATCH net-next v18 07/25] ovpn: implement basic TX path (UDP)

2025-02-03 Thread Sabrina Dubroca
2025-01-13, 10:31:26 +0100, Antonio Quartulli wrote: > +static void ovpn_encrypt_post(struct sk_buff *skb, int ret) > +{ > + struct ovpn_peer *peer = ovpn_skb_cb(skb)->peer; > + > + if (unlikely(ret < 0)) > + goto err; > + > + skb_mark_not_on_list(skb); > + > + switch (p

Re: [PATCH net-next v18 17/25] ovpn: implement keepalive mechanism

2025-02-03 Thread Antonio Quartulli
On 03/02/2025 10:20, Sabrina Dubroca wrote: 2025-01-13, 10:31:36 +0100, Antonio Quartulli wrote: +void ovpn_xmit_special(struct ovpn_peer *peer, const void *data, + const unsigned int len) +{ + struct ovpn_priv *ovpn; + struct sk_buff *skb; + + ovpn = peer-

Re: [PATCH net-next v18 12/25] ovpn: implement TCP transport

2025-02-03 Thread Sabrina Dubroca
2025-01-13, 10:31:31 +0100, Antonio Quartulli wrote: > +static void ovpn_tcp_rcv(struct strparser *strp, struct sk_buff *skb) > +{ [...] > + /* we need the first byte of data to be accessible > + * to extract the opcode and the key ID later on > + */ > + if (!pskb_may_pull(skb, 1)

Re: [PATCH v3 net] udp: gso: do not drop small packets when PMTU reduces

2025-02-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Fri, 31 Jan 2025 00:31:39 -0800 you wrote: > Commit 4094871db1d6 ("udp: only do GSO if # of segs > 1") avoided GSO > for small packets. But the kernel currently dismisses GSO requests only > after checking MTU/PMTU on

Re: [PATCH RFC net-next] netconsole: selftest: Add test for fragmented messages

2025-02-03 Thread Simon Horman
On Fri, Jan 31, 2025 at 04:39:38AM -0800, Breno Leitao wrote: > Add a new selftest to verify netconsole's handling of messages that > exceed the packet size limit and require fragmentation. The test sends > messages with varying sizes and userdata, validating that: > > 1. Large messages are correc

Re: [PATCH net-next v18 20/25] ovpn: implement peer add/get/dump/delete via netlink

2025-02-03 Thread Sabrina Dubroca
2025-02-03, 10:46:19 +0100, Antonio Quartulli wrote: > On 03/02/2025 00:07, Sabrina Dubroca wrote: > > 2025-01-13, 10:31:39 +0100, Antonio Quartulli wrote: > > > + NL_SET_ERR_MSG_FMT_MOD(info->extack, > > > +"unexpected remote IP address for non > > > UDP so

Re: [PATCH RFC net-next] netconsole: selftest: Add test for fragmented messages

2025-02-03 Thread Breno Leitao
Hello Simon, On Mon, Feb 03, 2025 at 10:48:55AM +, Simon Horman wrote: > On Fri, Jan 31, 2025 at 04:39:38AM -0800, Breno Leitao wrote: > > +# Validate the message, which has two messages glued together. > > +# unwrap them to make sure all the characters were transmitted. > > +# File will look

Re: [PATCH] scanf: convert self-test to KUnit

2025-02-03 Thread Geert Uytterhoeven
Hi Andy, On Fri, 31 Jan 2025 at 19:06, Andy Shevchenko wrote: > P.S. The test modules in defconfig is something which puzzling me. I would > remove all of them at once, if somebody wants debug configuration, they would > specify it and use with help of merge_config or alike. I really like having

Re: [PATCH] scanf: convert self-test to KUnit

2025-02-03 Thread Geert Uytterhoeven
On Fri, 31 Jan 2025 at 16:48, Tamir Duberstein wrote: > Convert the scanf() self-test to a KUnit test. > > In the interest of keeping the patch reasonably-sized this doesn't > rename the file in accordance with usual kunit conventions nor does it > refactor the tests into proper parameterized test

Re: [PATCH net-next v18 15/25] ovpn: implement multi-peer support

2025-02-03 Thread Antonio Quartulli
On 03/02/2025 00:00, Sabrina Dubroca wrote: 2025-01-13, 10:31:34 +0100, Antonio Quartulli wrote: static int ovpn_newlink(struct net *src_net, struct net_device *dev, struct nlattr *tb[], struct nlattr *data[], struct netlink_ext_ack *extack) {

[PATCH 04/16] elf, uapi: Add definitions for VER_FLG_BASE and VER_FLG_WEAK

2025-02-03 Thread Thomas Weißschuh
The definitions are used by tools/testing/selftests/vDSO/parse_vdso.c. To be able to build the vDSO selftests without a libc dependency, add the definitions to the kernels own UAPI headers. Link: https://docs.oracle.com/cd/E19683-01/816-1386/chapter6-80869/index.html Signed-off-by: Thomas Weißschu

[PATCH 00/16] selftests: vDSO: parse_vdso: Make compatible with nolibc

2025-02-03 Thread Thomas Weißschuh
For testing the functionality of the vDSO, it is necessary to build userspace programs for multiple different architectures. It is additional work to acquire matching userspace cross-compilers with full C libraries and then building root images out of those. The kernel tree already contains nolibc,

[PATCH 01/16] MAINTAINERS: Add vDSO selftests

2025-02-03 Thread Thomas Weißschuh
These currently have no maintainer besides the default kselftest ones. Add the general vDSO maintainers, too. Signed-off-by: Thomas Weißschuh --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 896a307fa06545e2861abe46ea7029f9b4d3628e..959c8a86844

[PATCH 02/16] elf, uapi: Add definition for STN_UNDEF

2025-02-03 Thread Thomas Weißschuh
The definition is used by tools/testing/selftests/vDSO/parse_vdso.c. To be able to build the vDSO selftests without a libc dependency, add the definition to the kernels own UAPI headers. Link: https://refspecs.linuxfoundation.org/elf/gabi4+/ch4.symtab.html Signed-off-by: Thomas Weißschuh --- inc

[PATCH 03/16] elf, uapi: Add definition for DT_GNU_HASH

2025-02-03 Thread Thomas Weißschuh
The definition is used by tools/testing/selftests/vDSO/parse_vdso.c. To be able to build the vDSO selftests without a libc dependency, add the define to the kernels own UAPI headers. Link: https://refspecs.linuxbase.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/libc-ddefs.html Signed-off-by: Th

[PATCH 07/16] tools/include: Add uapi/linux/elf.h

2025-02-03 Thread Thomas Weißschuh
It will be used by the vDSO selftests. Signed-off-by: Thomas Weißschuh --- tools/include/uapi/linux/elf.h | 524 + 1 file changed, 524 insertions(+) diff --git a/tools/include/uapi/linux/elf.h b/tools/include/uapi/linux/elf.h new file mode 100644 index 0

[PATCH 09/16] selftests: vDSO: vdso_standalone_test_x86: Use vdso_init_form_sysinfo_ehdr

2025-02-03 Thread Thomas Weißschuh
vdso_standalone_test_x86 is the only user of vdso_init_from_auxv(). Instead of combining the parsing the aux vector with the parsing of the vDSO, split them apart into getauxval() and the regular vdso_init_from_sysinfo_ehdr(). The implementation of getauxval() is taken from tools/include/nolibc/st

[PATCH 05/16] elf, uapi: Add type ElfXX_Versym

2025-02-03 Thread Thomas Weißschuh
The types are used by tools/testing/selftests/vDSO/parse_vdso.c. To be able to build the vDSO selftests without a libc dependency, add the types to the kernels own UAPI headers. As documented by elf(5). Signed-off-by: Thomas Weißschuh --- include/uapi/linux/elf.h | 2 ++ 1 file changed, 2 inser

[PATCH 11/16] selftests: vDSO: parse_vdso: Use UAPI headers instead of libc headers

2025-02-03 Thread Thomas Weißschuh
To allow the usage of parse_vdso.c together with a limited libc like nolibc, use the kernels own elf.h and auxvec.h headers. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/vDSO/Makefile | 3 +++ tools/testing/selftests/vDSO/parse_vdso.c | 3 ++- 2 files changed, 5 insertions(+),

[PATCH 06/16] elf, uapi: Add types ElfXX_Verdef and ElfXX_Veraux

2025-02-03 Thread Thomas Weißschuh
The types are used by tools/testing/selftests/vDSO/parse_vdso.c. To be able to build the vDSO selftests without a libc dependency, add the types to the kernels own UAPI headers. Link: https://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/symversion.html#VERDEFEXTS Signe

[PATCH 08/16] selftests: Add headers target

2025-02-03 Thread Thomas Weißschuh
Some selftests need access to a full UAPI headers tree, for example when building with nolibc which heavily relies on UAPI headers. A reference to such a tree is available in the KHDR_INCLUDES variable, but there is currently no way to populate such a tree automatically. Provide a target that the

[PATCH 16/16] selftests: vDSO: vdso_standalone_test_x86: Switch to nolibc

2025-02-03 Thread Thomas Weißschuh
vdso_standalone_test_x86 provides its own ASM syscall wrappers and _start() implementation. The in-tree nolibc library already provides this functionality for multiple architectures. By making use of nolibc, the standalone testcase can be built from the exact same codebase as the non-standalone ver

[PATCH 10/16] selftests: vDSO: parse_vdso: Drop vdso_init_from_auxv()

2025-02-03 Thread Thomas Weißschuh
There are no users left. Also remove the usage of ElfXX_auxv_t, which is not formally standardized. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/vDSO/parse_vdso.c | 14 -- tools/testing/selftests/vDSO/parse_vdso.h | 1 - 2 files changed, 15 deletions(-) diff --git a

[PATCH 15/16] selftests: vDSO: vdso_test_gettimeofday: Make compatible with nolibc

2025-02-03 Thread Thomas Weißschuh
nolibc does not provide these headers, instead those definitions are available unconditionally. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/vDSO/vdso_test_gettimeofday.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/vDSO/vdso_test_gettimeofday.c b

[PATCH 12/16] selftests: vDSO: parse_vdso: Test __SIZEOF_LONG__ instead of ULONG_MAX

2025-02-03 Thread Thomas Weißschuh
According to limits.h(2) ULONG_MAX is only guaranteed to expand to an expression, not a symbolic constant which can be evaluated by the preprocessor. Specifically the definition of ULONG_MAX from nolibc can no be evaluated by the preprocessor. To provide compatibility with nolibc, check with __SIZE

[PATCH 14/16] selftests: vDSO: vdso_test_gettimeofday: Clean up includes

2025-02-03 Thread Thomas Weißschuh
Some unnecessary headers are included, remove them. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/vDSO/vdso_test_gettimeofday.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/vDSO/vdso_test_gettimeofday.c b/tools/testing/selftests/vDSO/vdso_test_getti

[PATCH 13/16] selftests: vDSO: parse_vdso: Make compatible with nolibc

2025-02-03 Thread Thomas Weißschuh
nolibc does not provide this header, instead its definitions are available unconditionally. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/vDSO/parse_vdso.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/vDSO/parse_vdso.c b/tools/testing/selftests/vDS

Re: [PATCH net-next v18 17/25] ovpn: implement keepalive mechanism

2025-02-03 Thread Sabrina Dubroca
2025-01-13, 10:31:36 +0100, Antonio Quartulli wrote: > +void ovpn_xmit_special(struct ovpn_peer *peer, const void *data, > +const unsigned int len) > +{ > + struct ovpn_priv *ovpn; > + struct sk_buff *skb; > + > + ovpn = peer->ovpn; > + if (unlikely(!ovpn)) > +

Re: [PATCH RFC net-next] netconsole: selftest: Add test for fragmented messages

2025-02-03 Thread Simon Horman
On Mon, Feb 03, 2025 at 03:00:37AM -0800, Breno Leitao wrote: > Hello Simon, > > On Mon, Feb 03, 2025 at 10:48:55AM +, Simon Horman wrote: > > On Fri, Jan 31, 2025 at 04:39:38AM -0800, Breno Leitao wrote: > > > > +# Validate the message, which has two messages glued together. > > > +# unwrap

Re: [PATCH RFCv2 09/13] iommufd: Add IOMMU_OPTION_SW_MSI_START/SIZE ioctls

2025-02-03 Thread Nicolin Chen
On Thu, Jan 23, 2025 at 10:07:13AM +, Tian, Kevin wrote: > > From: Nicolin Chen > > Sent: Saturday, January 11, 2025 11:32 AM > > > > @@ -294,7 +294,9 @@ struct iommu_ioas_unmap { > > > > /** > > * enum iommufd_option - ioctl(IOMMU_OPTION_RLIMIT_MODE) and > > - * ioc

Re: [PATCH bpf-next 2/3] bpf: selftests: Test constant key extraction on irrelevant maps

2025-02-03 Thread Eduard Zingerman
On Sat, 2025-02-01 at 12:58 -0700, Daniel Xu wrote: > Test that very high constant map keys are not interpreted as an error > value by the verifier. This would previously fail. > > Signed-off-by: Daniel Xu > --- Acked-by: Eduard Zingerman [...]

[PATCH net-next v2 2/2] selftests: drv-net: Test queue xsk attribute

2025-02-03 Thread Joe Damato
Test that queues which are used for AF_XDP have the xsk nest attribute. The attribute is currently empty, but its existence means the AF_XDP is being used for the queue. Signed-off-by: Joe Damato Suggested-by: Jakub Kicinski --- v2: - Updated the Python test after changes to patch 1 which ex

[PATCH net-next v2 0/2] netdevgenl: Add an xsk attribute to queues

2025-02-03 Thread Joe Damato
Greetings: This is an attempt to followup on something Jakub asked me about [1], adding an xsk attribute to queues and more clearly documenting which queues are linked to NAPIs... After the RFC [2], Jakub suggested creating an empty nest for queues which have a pool, so I've adjusted this version

[PATCH v2 2/2] get_maintainer: stop reporting subsystem status as maintainer role

2025-02-03 Thread Vlastimil Babka
After introducing the --substatus option, we can stop adjusting the reported maintainer role by the subsystem's status. For compatibility with the --git-chief-penguins option, keep the "chief penguin" role. Signed-off-by: Vlastimil Babka --- scripts/get_maintainer.pl | 21 ++---

[PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status

2025-02-03 Thread Vlastimil Babka
The subsystem status is currently reported with --role(stats) by adjusting the maintainer role for any status different from Maintained. This has two downsides: - if a subsystem has only reviewers or mailing lists and no maintainers, the status is not reported (i.e. typically, Orphan subsystems

[PATCH v2 0/2] get_maintainer: report subsystem status separately from maintainer role

2025-02-03 Thread Vlastimil Babka
The subsystem status (S: field) can inform a patch submitter if the subsystem is well maintained or e.g. maintainers are missing. In get_maintainer, it is currently reported with --role(stats) by adjusting the maintainer role for any status different from Maintained. This has two downsides: - if

Re: [PATCH 00/16] selftests: vDSO: parse_vdso: Make compatible with nolibc

2025-02-03 Thread Christophe Leroy
Le 03/02/2025 à 10:05, Thomas Weißschuh a écrit : For testing the functionality of the vDSO, it is necessary to build userspace programs for multiple different architectures. It is additional work to acquire matching userspace cross-compilers with full C libraries and then building root images

[PATCH 2/2] Input: goodix_berlin - Add support for Berlin-A series

2025-02-03 Thread Jens Reidel
The current implementation of the goodix_berlin driver lacks support for revisions A and B of the Berlin IC. This change adds support for the gt9897 IC, which is a Berlin-A revision part. The differences between revision D and A are rather minor, a handful of address changes and a slightly larger

[PATCH 1/2] dt-bindings: input: goodix,gt9916: Document gt9897 compatible

2025-02-03 Thread Jens Reidel
Document the Goodix GT9897 which is a Berlin-A series touchscreen controller IC by Goodix. Signed-off-by: Jens Reidel --- .../devicetree/bindings/input/touchscreen/goodix,gt9916.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/good

Re: [PATCH RFCv2 05/13] iommu: Turn fault_data to iommufd private pointer

2025-02-03 Thread Nicolin Chen
Hi Eric, On Wed, Jan 29, 2025 at 01:40:54PM +0100, Eric Auger wrote: > On 1/11/25 4:32 AM, Nicolin Chen wrote: > > A "fault_data" was added exclusively for the iommufd_fault_iopf_handler() > > used by IOPF/PRI use cases, along with the attach_handle. Now, the iommufd > > version of sw_msi function

Re: [PATCH] virtio: Remove virtio devices on device_shutdown()

2025-02-03 Thread Michael S. Tsirkin
On Fri, Jan 31, 2025 at 10:53:15AM +0100, Eric Auger wrote: > Hi Kirill, Michael > > On 8/8/24 9:51 AM, Kirill A. Shutemov wrote: > > Hongyu reported a hang on kexec in a VM. QEMU reported invalid memory > > accesses during the hang. > > > > Invalid read at addr 0x102877002, size 2, region '(

[PATCH 0/2] Add Goodix Berlin-A series support

2025-02-03 Thread Jens Reidel
This series adds support for the Goodix Berlin-A series touch ICs (gt9897). This was tested on a Xiaomi 11 Lite 5G NE (xiaomi-lisa), which uses the gt9897 IC connected over SPI. I am not aware of any device that has gt9897 connected over I2C and therefore could not test it, so I didn't add a compat

Re: [PATCH RFCv2 06/13] iommufd: Make attach_handle generic

2025-02-03 Thread Nicolin Chen
On Wed, Jan 29, 2025 at 02:14:47PM +0100, Eric Auger wrote: > > @@ -352,6 +352,111 @@ iommufd_device_attach_reserved_iova(struct > > iommufd_device *idev, > > return 0; > > } > > > > +/* The device attach/detach/replace helpers for attach_handle */ > > + > > +static int iommufd_hwpt_attach_

Re: [PATCH 1/2] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable display

2025-02-03 Thread Konrad Dybcio
On 2.02.2025 11:45 PM, Luca Weiss wrote: > Configure the MDSS nodes for the phone and add the panel node. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

[PATCH v2] scanf: convert self-test to KUnit

2025-02-03 Thread Tamir Duberstein
Convert the scanf() self-test to a KUnit test. In the interest of keeping the patch reasonably-sized this doesn't refactor the tests into proper parameterized tests - it's all one big test case. Signed-off-by: Tamir Duberstein Acked-by: Geert Uytterhoeven # m68k --- This is one of just 3 remain

Re: [PATCH bpf-next v4 12/14] selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests

2025-02-03 Thread Bastien Curutchet
Hi Martin, On 2/1/25 2:33 AM, Martin KaFai Lau wrote: On 1/30/25 11:21 PM, Bastien Curutchet (eBPF Foundation) wrote: +#define BROADCAST_REDIRECT_SKEL_NB    2 +static void xdp_veth_broadcast_redirect(u32 attach_flags, u64 [...] + +    group_map = bpf_map__fd(xdp_redirect_multi_kern->maps.ma

Re: [PATCH 00/16] selftests: vDSO: parse_vdso: Make compatible with nolibc

2025-02-03 Thread Thomas Weißschuh
On Mon, Feb 03, 2025 at 12:23:29PM +0100, Christophe Leroy wrote: > Le 03/02/2025 à 10:05, Thomas Weißschuh a écrit : > > For testing the functionality of the vDSO, it is necessary to build > > userspace programs for multiple different architectures. > > It is additional work to acquire matching us

[PATCH net-next v3 05/10] net: pktgen: fix 'ratep 0' error handling (return -EINVAL)

2025-02-03 Thread Peter Seiderer
Given an invalid 'ratep' command e.g. 'ratep 0' the return value is '1', leading to the following misleading output: - the good case $ echo "ratep 100" > /proc/net/pktgen/lo\@0 $ grep "Result:" /proc/net/pktgen/lo\@0 Result: OK: ratep=100 - the bad case (before the patch)

[PATCH net-next v3 00/10] Some pktgen fixes/improvments

2025-02-03 Thread Peter Seiderer
While taking a look at '[PATCH net] pktgen: Avoid out-of-range in get_imix_entries' ([1]) and '[PATCH net v2] pktgen: Avoid out-of-bounds access in get_imix_entries' ([2], [3]) and doing some tests and code review I detected that the /proc/net/pktgen/... parsing logic does not honour the user given

[PATCH net-next v3 01/10] net: pktgen: replace ENOTSUPP with EOPNOTSUPP

2025-02-03 Thread Peter Seiderer
Replace ENOTSUPP with EOPNOTSUPP, fixes checkpatch hint WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP and e.g. $ echo "clone_skb 1" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Unknown error 524 Signed-off-by: Peter Seiderer --- Changes v2 -> v3 - no changes Cha

[PATCH net-next v3 02/10] net: pktgen: enable 'param=value' parsing

2025-02-03 Thread Peter Seiderer
Enable additional to 'parm value' the 'param=value' parsing (otherwise skipping '=' in count_trail_chars() is useless). Tested with: $ echo "min_pkt_size 999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size=999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size =999" > /proc/net

[PATCH net-next v3 09/10] net: pktgen: fix mpls reset parsing

2025-02-03 Thread Peter Seiderer
Fix mpls list reset parsing to work as describe in Documentation/networking/pktgen.rst: pgset "mpls 0"turn off mpls (or any invalid argument works too!) - before the patch $ echo "mpls 0001,0002" > /proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0

[PATCH net-next v3 10/10] selftest: net: add proc_net_pktgen

2025-02-03 Thread Peter Seiderer
Add some test for /proc/net/pktgen/... interface. - enable 'CONFIG_NET_PKTGEN=m' in tools/testing/selftests/net/config Signed-off-by: Peter Seiderer --- Changes v2 -> v3: - fix typo in change description ('v1 -> v1' and tyop) - rename some vars to better match usage add_loopback_0 -> thr

[PATCH net-next v3 03/10] net: pktgen: fix hex32_arg parsing for short reads

2025-02-03 Thread Peter Seiderer
Fix hex32_arg parsing for short reads (here 7 hex digits instead of the expected 8), shift result only on successful input parsing. - before the patch $ echo "mpls 123" > /proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0 mpls: 1230 Result: OK:

[PATCH net-next v3 04/10] net: pktgen: fix 'rate 0' error handling (return -EINVAL)

2025-02-03 Thread Peter Seiderer
Given an invalid 'rate' command e.g. 'rate 0' the return value is '1', leading to the following misleading output: - the good case $ echo "rate 100" > /proc/net/pktgen/lo\@0 $ grep "Result:" /proc/net/pktgen/lo\@0 Result: OK: rate=100 - the bad case (before the patch)

[PATCH net-next v3 07/10] net: pktgen: fix access outside of user given buffer in pktgen_thread_write()

2025-02-03 Thread Peter Seiderer
Honour the user given buffer size for the strn_len() calls (otherwise strn_len() will access memory outside of the user given buffer). Signed-off-by: Peter Seiderer --- Changes v2 -> v3: - no changes Changes v1 -> v2: - no changes --- net/core/pktgen.c | 7 --- 1 file changed, 4 inserti

[PATCH net-next v3 08/10] net: pktgen: fix access outside of user given buffer in pktgen_if_write()

2025-02-03 Thread Peter Seiderer
Honour the user given buffer size for the hex32_arg(), num_arg(), strn_len(), get_imix_entries() and get_labels() calls (otherwise they will access memory outside of the user given buffer). In hex32_arg(), num_arg(), strn_len() error out in case no characters are available (maxlen = 0), in num_arg

[PATCH net-next v3 06/10] net: pktgen: fix ctrl interface command parsing

2025-02-03 Thread Peter Seiderer
Enable command writing without trailing '\n': - the good case $ echo "reset" > /proc/net/pktgen/pgctrl - the bad case (before the patch) $ echo -n "reset" > /proc/net/pktgen/pgctrl -bash: echo: write error: Invalid argument - with patch applied $ echo -n "reset

[PATCH 2/4] ucount: Replace get_ucounts_or_wrap() with atomic_inc_not_zero().

2025-02-03 Thread Sebastian Andrzej Siewior
get_ucounts_or_wrap() increments the counter and if the counter is negative then it decrements it again in order to reset the previous increment. This statement can be replaced with atomic_inc_not_zero() to only increment the counter if it is not yet 0. This simplifies the get function because the

[PATCH 1/4] rcu: Provide a static initializer for hlist_nulls_head.

2025-02-03 Thread Sebastian Andrzej Siewior
Provide a static initializer for hlist_nulls_head so that it can be used in statically defined data structures. Signed-off-by: Sebastian Andrzej Siewior --- include/linux/list_nulls.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/list_nulls.h b/include/linux/list_nulls.h inde

[PATCH 4/4] ucount: Use rcuref_t for reference counting.

2025-02-03 Thread Sebastian Andrzej Siewior
Use rcuref_t for reference counting. This eliminates the cmpxchg loop in the get and put path. This also eliminates the need to acquire the lock in the put path because once the final user returns the reference, it can no longer be obtained anymore. Use rcuref_t for reference counting. Signed-off

[PATCH 0/4] ucount: Simplify refcounting with rcuref_t.

2025-02-03 Thread Sebastian Andrzej Siewior
I noticed that the atomic_dec_and_lock_irqsave() in put_ucounts() loops sometimes even during boot. Something like 2-3 iterations but still. This series replaces the refcounting with rcuref_t and adds a RCU lookup. This allows a lockless lookup in alloc_ucounts() if the entry is available and a cmp

[PATCH 3/4] ucount: Use RCU for ucounts lookups.

2025-02-03 Thread Sebastian Andrzej Siewior
The ucounts element is looked up under ucounts_lock. This can be optimized by using RCU for a lockless lookup and return and element if the reference can be obtained. Replace hlist_head with hlist_nulls_head which is RCU compatible. Let find_ucounts() search for the required item within a RCU sect

Re: [PATCH 8/8] arm64: Enable livepatch for ARM64

2025-02-03 Thread Steven Rostedt
On Fri, 31 Jan 2025 21:38:46 +0530 Prasanna Kumar T S M wrote: > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -271,6 +271,8 @@ config ARM64 > > select HAVE_SOFTIRQ_ON_OWN_STACK > > select USER_STACKTRACE_SUPPORT > > select VDSO_GETRANDOM > > + select HAVE_RELIABLE_

Re: [syzbot] [net?] general protection fault in add_wait_queue

2025-02-03 Thread Michal Luczaj
On 2/3/25 10:57, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:c2933b2befe2 Merge tag 'net-6.14-rc1' of git://git.kernel... > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=16f676b058 > kernel config: https://syzkall

Re: [PATCH net-next v18 12/25] ovpn: implement TCP transport

2025-02-03 Thread Antonio Quartulli
On 03/02/2025 11:05, Sabrina Dubroca wrote: 2025-01-13, 10:31:31 +0100, Antonio Quartulli wrote: +static void ovpn_tcp_rcv(struct strparser *strp, struct sk_buff *skb) +{ [...] + /* we need the first byte of data to be accessible +* to extract the opcode and the key ID later on +

Re: [syzbot] linux-next build error (19)

2025-02-03 Thread Aleksandr Nogikh
On Thu, Jan 30, 2025 at 5:28 PM 'Sami Tolvanen' via syzkaller-bugs wrote: > > On Thu, Jan 30, 2025 at 5:20 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:a13f6e0f405e Add linux-next specific files for 20250130 > > git tree: linux-next

Re: [PATCH 00/16] selftests: vDSO: parse_vdso: Make compatible with nolibc

2025-02-03 Thread Thomas Weißschuh
On Mon, Feb 03, 2025 at 04:43:22PM +0100, Christophe Leroy wrote: > Do you have any plan to get it work with nolibc for all test programs in > selftests/vDSO, not only the standalone x86 test ? Not directly as next step. I am focussing on some other work which will integrate (vDSO) selftests wit

Re: [PATCH] bpf: Fix mix-up of 4096 and page size.

2025-02-03 Thread Saket Kumar Bhaskar
On Tue, Jan 28, 2025 at 04:03:11PM +0100, Alexander Lobakin wrote: > From: Alexei Starovoitov > Date: Thu, 23 Jan 2025 21:14:04 -0800 > > > On Wed, Jan 22, 2025 at 10:38 AM Saket Kumar Bhaskar > > wrote: > >> > >> For platforms on powerpc architecture with a default page size greater > >> than 4

Re: [RFC PATCH 00/39] 1G page support for guest_memfd

2025-02-03 Thread Ackerley Tng
Amit Shah writes: > Hey Ackerley, Hi Amit, > On Tue, 2024-09-10 at 23:43 +, Ackerley Tng wrote: >> Hello, >> >> This patchset is our exploration of how to support 1G pages in >> guest_memfd, and >> how the pages will be used in Confidential VMs. > > We've discussed this patchset at LPC and

Re: [PATCH net-next v18 05/25] ovpn: introduce the ovpn_peer object

2025-02-03 Thread Antonio Quartulli
On 02/02/2025 23:56, Sabrina Dubroca wrote: 2025-01-13, 10:31:24 +0100, Antonio Quartulli wrote: +static int ovpn_peer_del_p2p(struct ovpn_peer *peer, +enum ovpn_del_peer_reason reason) +{ + struct ovpn_peer *tmp; + + lockdep_assert_held(&peer->ovpn->lock)

Re: [PATCH net-next v18 08/25] ovpn: implement basic RX path (UDP)

2025-02-03 Thread Sabrina Dubroca
2025-01-13, 10:31:27 +0100, Antonio Quartulli wrote: > +/** > + * ovpn_opcode_from_skb - extract OP code from skb at specified offset > + * @skb: the packet to extract the OP code from > + * @offset: the offset in the data buffer where the OP code is located > + * > + * Note: this function assumes