Re: [PATCH bpf-next v5 4/5] bpf: verifier: Support eliding map lookup nullness

2024-12-13 Thread Eduard Zingerman
On Sat, 2024-12-14 at 00:10 +0100, Kumar Kartikeya Dwivedi wrote: [...] > > @@ -11199,10 +11266,17 @@ static int check_helper_call(struct > > bpf_verifier_env *env, struct bpf_insn *insn > > "kernel subsystem misconfigured > > verifier\n"); > >

Re: [PATCH bpf-next v5 4/5] bpf: verifier: Support eliding map lookup nullness

2024-12-13 Thread Eduard Zingerman
On Fri, 2024-12-13 at 15:14 -0800, Eduard Zingerman wrote: [...] > Great point, I'm sure this does not happen. I mean, mark_chain_precision() does not happen at the moment.

Re: [RFC 1/1] sched: defer completion task to online CPU

2024-12-13 Thread Frederic Weisbecker
Le Fri, Dec 13, 2024 at 08:33:45PM +, Usama Arif a écrit : > The following warning is being encountered at boot time: > >WARNING: CPU: 94 PID: 588 at kernel/time/hrtimer.c:1086 > hrtimer_start_range_ns+0x289/0x2d0 >Modules linked in: >CPU: 94 UID: 0 PID: 58

Re: [PATCH bpf-next v5 4/5] bpf: verifier: Support eliding map lookup nullness

2024-12-13 Thread Andrii Nakryiko
On Thu, Dec 12, 2024 at 3:23 PM Daniel Xu wrote: > > This commit allows progs to elide a null check on statically known map > lookup keys. In other words, if the verifier can statically prove that > the lookup will be in-bounds, allow the prog to drop the null check. > > This is useful for two rea

Re: [PATCH rcu 1/2] rcu/nocb: Use switch/case on NOCB timer state machine

2024-12-13 Thread Paul E. McKenney
On Sat, Dec 14, 2024 at 12:08:42AM +0100, Frederic Weisbecker wrote: > Le Thu, Dec 12, 2024 at 10:42:13AM -0800, Paul E. McKenney a écrit : > > From: Frederic Weisbecker > > > > It's more convenient to benefit from the fallthrough feature of > > switch / case to handle the timer state machine. Al

[PATCH] KVM: selftests: Add printf attribute to _no_printf()

2024-12-13 Thread Reinette Chatre
From: Isaku Yamahata Annotate the KVM selftests' _no_printf() with the printf format attribute so that the compiler can help check parameters provided to pr_debug() and pr_info() irrespective of DEBUG and QUIET being defined. [reinette: move attribute right after storage class, rework changelog]

Re: [PATCH 2/4] platform/x86: wmi-bmof: Switch to sysfs_bin_attr_simple_read()

2024-12-13 Thread Thomas Weißschuh
Hi Armin, On 2024-12-13 01:21:37+0100, Armin Wolf wrote: > Am 05.12.24 um 18:35 schrieb Thomas Weißschuh: > > > The generic function from the sysfs core can replace the custom one. > > Sorry for taking quite a bit to respond, i totally overlooked this patch. > > This patch is superseded by a pa

Re: [PATCH v2 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests

2024-12-13 Thread Maxime Ripard
Hi, On Wed, Dec 11, 2024 at 04:31:41PM -0800, Brian Norris wrote: > We recently updated these device_match*() (and therefore, various > *find_device_by*()) functions to return a consistent 'false' value when > trying to match a NULL handle. Add tests for this. > > This provides regression-testing

Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property

2024-12-13 Thread Bryan O'Donoghue
On 13/12/2024 11:54, Vladimir Zapolskiy wrote: New additions should include this bus-type number as we will need it when we add CPHY support and the subsequently move to the PHY API for CAMSS PHYs. This particular reason is invalid IMO, since dtb changes are not relied on drivers and shall be

Re: [PATCH 2/2] media: qcom: camss: Restrict endpoint bus-type to D-PHY

2024-12-13 Thread Vladimir Zapolskiy
On 12/13/24 13:22, Luca Weiss wrote: On Fri Dec 13, 2024 at 12:02 PM CET, Vladimir Zapolskiy wrote: On 12/9/24 14:32, Bryan O'Donoghue wrote: On 09/12/2024 12:01, Luca Weiss wrote: Currently the Qualcomm CAMSS driver only supports D-PHY while the hardware on most SoCs also supports C-PHY. Unti

Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property

2024-12-13 Thread Vladimir Zapolskiy
On 12/13/24 13:34, Bryan O'Donoghue wrote: On 13/12/2024 11:24, Luca Weiss wrote: On Fri Dec 13, 2024 at 11:50 AM CET, Vladimir Zapolskiy wrote: On 12/13/24 11:34, Krzysztof Kozlowski wrote: On Mon, Dec 09, 2024 at 01:01:05PM +0100, Luca Weiss wrote: The CSIPHY of Qualcomm SoCs support both D

Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property

2024-12-13 Thread Krzysztof Kozlowski
On Mon, Dec 09, 2024 at 01:01:05PM +0100, Luca Weiss wrote: > The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for > CSI-2, but not any others so restrict the bus-type property describing > this to the supported values. > > The only exception here is MSM8916 which only supports D

[PATCH v5 0/3] rust: kunit: Support KUnit tests with a user-space like syntax

2024-12-13 Thread David Gow
Hi all, v5 here is a small set of fixes and a rebase of the previous versions. If there are no major issues, I'd like to land this soon so it can be used and tested ready for 6.14. This series was originally written by José Expósito, and has been modified and updated by Matt Gilbride and myself.

[PATCH v5 1/3] rust: kunit: add KUnit case and suite macros

2024-12-13 Thread David Gow
From: José Expósito Add a couple of Rust const functions and macros to allow to develop KUnit tests without relying on generated C code: - The `kunit_unsafe_test_suite!` Rust macro is similar to the `kunit_test_suite` C macro. It requires a NULL-terminated array of test cases (see below).

[PATCH v5 2/3] rust: macros: add macro to easily run KUnit tests

2024-12-13 Thread David Gow
From: José Expósito Add a new procedural macro (`#[kunit_tests(kunit_test_suit_name)]`) to run KUnit tests using a user-space like syntax. The macro, that should be used on modules, transforms every `#[test]` in a `kunit_case!` and adds a `kunit_unsafe_test_suite!` registering all of them. The

[PATCH v5 3/3] rust: kunit: allow to know if we are in a test

2024-12-13 Thread David Gow
From: José Expósito In some cases, we need to call test-only code from outside the test case, for example, to mock a function or a module. In order to check whether we are in a test or not, we need to test if `CONFIG_KUNIT` is set. Unfortunately, we cannot rely only on this condition because: -

Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property

2024-12-13 Thread Vladimir Zapolskiy
On 12/13/24 11:34, Krzysztof Kozlowski wrote: On Mon, Dec 09, 2024 at 01:01:05PM +0100, Luca Weiss wrote: The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for CSI-2, but not any others so restrict the bus-type property describing this to the supported values. The only exceptio

Re: [PATCH v3 01/57] KVM: x86: Use feature_bit() to clear CONSTANT_TSC when emulating CPUID

2024-12-13 Thread Vitaly Kuznetsov
Sean Christopherson writes: > When clearing CONSTANT_TSC during CPUID emulation due to a Hyper-V quirk, > use feature_bit() instead of SF() to ensure the bit is actually cleared. > SF() evaluates to zero if the _host_ doesn't support the feature. I.e. > KVM could keep the bit set if userspace ad

Re: [PATCH 2/2] media: qcom: camss: Restrict endpoint bus-type to D-PHY

2024-12-13 Thread Vladimir Zapolskiy
On 12/9/24 14:32, Bryan O'Donoghue wrote: On 09/12/2024 12:01, Luca Weiss wrote: Currently the Qualcomm CAMSS driver only supports D-PHY while the hardware on most SoCs also supports C-PHY. Until this support is added, check for D-PHY to make it somewhat explicit that C-PHY won't work. Signed-o

Re: [PATCH 2/2] media: qcom: camss: Restrict endpoint bus-type to D-PHY

2024-12-13 Thread Luca Weiss
On Fri Dec 13, 2024 at 12:02 PM CET, Vladimir Zapolskiy wrote: > On 12/9/24 14:32, Bryan O'Donoghue wrote: > > On 09/12/2024 12:01, Luca Weiss wrote: > >> Currently the Qualcomm CAMSS driver only supports D-PHY while the > >> hardware on most SoCs also supports C-PHY. Until this support is added, >

Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property

2024-12-13 Thread Luca Weiss
On Fri Dec 13, 2024 at 11:50 AM CET, Vladimir Zapolskiy wrote: > On 12/13/24 11:34, Krzysztof Kozlowski wrote: > > On Mon, Dec 09, 2024 at 01:01:05PM +0100, Luca Weiss wrote: > >> The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for > >> CSI-2, but not any others so restrict the b

Re: [PATCH v2 0/4] sched: Move task_mm_cid_work to mm delayed work

2024-12-13 Thread Gabriele Monaco
On Fri, 2024-12-13 at 10:54 +0100, Gabriele Monaco wrote: > OVERHEAD COMPARISON > > [..] > > I will post another email with the scripts used to retrieve the data > and > more details about the runtime distribution. This message contains the performance results produced by my scripts, which are at

[RFC PATCH] get_maintainer: decouple subsystem status from maintainer role

2024-12-13 Thread Vlastimil Babka
The script currently uses the subystem's status (S: field) to change how maintainers are reported. One prominent example is when the status is Supported, the maintainers are reported as "(supporter:SUBSYSTEM)". This is misleading, as the Supported status defined as "Someone is actually paid to loo

Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property

2024-12-13 Thread Bryan O'Donoghue
On 13/12/2024 11:24, Luca Weiss wrote: On Fri Dec 13, 2024 at 11:50 AM CET, Vladimir Zapolskiy wrote: On 12/13/24 11:34, Krzysztof Kozlowski wrote: On Mon, Dec 09, 2024 at 01:01:05PM +0100, Luca Weiss wrote: The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for CSI-2, but not

Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property

2024-12-13 Thread Luca Weiss
On Fri Dec 13, 2024 at 10:34 AM CET, Krzysztof Kozlowski wrote: > On Mon, Dec 09, 2024 at 01:01:05PM +0100, Luca Weiss wrote: > > The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for > > CSI-2, but not any others so restrict the bus-type property describing > > this to the support

[PATCH v2 0/4] sched: Move task_mm_cid_work to mm delayed work

2024-12-13 Thread Gabriele Monaco
This patchset moves the task_mm_cid_work to a preemptible and migratable context. This reduces the impact of this task to the scheduling latency of real time tasks. The change makes the recurrence of the task a bit more predictable. We also add optimisation and fixes to make sure the task_mm_cid_wo

[PATCH v2 2/4] sched: Remove mm_cid_next_scan as obsolete

2024-12-13 Thread Gabriele Monaco
The checks for the scan time in task_mm_cid_work are now superfluous since the task runs in a delayed_work and the minimum periodicity is already implied. This patch removes those checks and the field from the mm_struct. Additionally, we include a simple check to quickly terminate the function if

[PATCH v2 3/4] sched: Compact RSEQ concurrency IDs with reduced threads and affinity

2024-12-13 Thread Gabriele Monaco
From: Mathieu Desnoyers When a process reduces its number of threads or clears bits in its CPU affinity mask, the mm_cid allocation should eventually converge towards smaller values. However, the change introduced by: commit 7e019dcc470f ("sched: Improve cache locality of RSEQ concurrency IDs f

[PATCH v2 1/4] sched: Move task_mm_cid_work to mm delayed work

2024-12-13 Thread Gabriele Monaco
Currently, the task_mm_cid_work function is called in a task work triggered by a scheduler tick. This can delay the execution of the task for the entire duration of the function, negatively affecting the response of real time tasks. This patch runs the task_mm_cid_work in a new delayed work connec

[PATCH v2 4/4] rseq/selftests: Add test for mm_cid compaction

2024-12-13 Thread Gabriele Monaco
A task in the kernel (task_mm_cid_work) runs somewhat periodically to compact the mm_cid for each process, this test tries to validate that it runs correctly and timely. The test spawns 1 thread pinned to each CPU, then each thread, including the main one, run in short bursts for some time. During

Re: [PATCH v3 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-13 Thread Shijith Thotton
>> >> Added support to read the vendor-specific PCI capability to identify the >> type of device being emulated. >> >> Reviewed-by: Dan Carpenter >> Signed-off-by: Shijith Thotton >> --- >> drivers/vdpa/octeon_ep/octep_vdpa.h | 20 ++ >> drivers/vdpa/octeon_ep/octep_vdpa_hw.c

Re: [PATCH v3 3/4] virtio-pci: define type and header for PCI vendor data

2024-12-13 Thread Shijith Thotton
>> Added macro definition for VIRTIO_PCI_CAP_VENDOR_CFG to identify the >PCI >> vendor data type in the virtio_pci_cap structure. Defined a new struct >> virtio_pci_vndr_data for the vendor data capability header as per the >> specification. >> >> Signed-off-by: Shijith Thotton >> --- >> include/

Re: [PATCH v3 0/4] rust: extend `module!` macro with integer parameter support

2024-12-13 Thread Andreas Hindborg
Hi Luis, Petr, Sami, Dani, I just noticed that I failed in email and forgot to add you to the recipient list of this series. Do you want a resend, or is this sufficient? Best regards, Andreas Hindborg "Andreas Hindborg" writes: > This series extends the `module!` macro with support module p

Re: [PATCH net-next v15 03/22] ovpn: add basic interface creation/destruction/management routines

2024-12-13 Thread Donald Hunter
On Wed, 11 Dec 2024 at 21:32, Antonio Quartulli wrote: > > static int ovpn_newlink(struct net *src_net, struct net_device *dev, > struct nlattr *tb[], struct nlattr *data[], > struct netlink_ext_ack *extack) > { > - return -EOPNOTSUPP; > +

Re: [PATCH net-next v15 03/22] ovpn: add basic interface creation/destruction/management routines

2024-12-13 Thread Antonio Quartulli
On 13/12/2024 13:32, Donald Hunter wrote: On Wed, 11 Dec 2024 at 21:32, Antonio Quartulli wrote: static int ovpn_newlink(struct net *src_net, struct net_device *dev, struct nlattr *tb[], struct nlattr *data[], struct netlink_ext_ack *extack)

[PATCH] kunit: platform: Resolve 'struct completion' warning

2024-12-13 Thread Brian Norris
If the header is included in a test without certain other headers, it produces compiler warnings like: In file included from [...] ../include/kunit/platform_device.h:15:57: warning: ‘struct completion’ declared inside parameter list will not be visible outside of this definition or declaration

Re: [RFC v2 02/13] rust: sync: Add basic atomic operation mapping framework

2024-12-13 Thread Boqun Feng
On Fri, Dec 13, 2024 at 03:37:13PM +0100, Alice Ryhl wrote: [...] > > > > @@ -0,0 +1,19 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > + > > > > +//! Atomic primitives. > > > > +//! > > > > +//! These primitives have the same semantics as their C counterparts: > > > > and the precise defi

Re: [PATCH 1/4] KVM: VMX: read the PML log in the same order as it was written

2024-12-13 Thread Sean Christopherson
On Fri, Dec 13, 2024, Maxim Levitsky wrote: > On Thu, 2024-12-12 at 22:19 -0800, Sean Christopherson wrote: > > On Thu, Dec 12, 2024, Maxim Levitsky wrote: > > > On Wed, 2024-12-11 at 16:44 -0800, Sean Christopherson wrote: > > > > But, I can't help but wonder why KVM bothers emulating PML. I can

Re: [PATCH 2/2] media: qcom: camss: Restrict endpoint bus-type to D-PHY

2024-12-13 Thread Vladimir Zapolskiy
Hi Luca. On 12/9/24 14:01, Luca Weiss wrote: Currently the Qualcomm CAMSS driver only supports D-PHY while the hardware on most SoCs also supports C-PHY. Until this support is added, check for D-PHY to make it somewhat explicit that C-PHY won't work. Signed-off-by: Luca Weiss --- drivers/med

Re: [PATCH v2 3/6] KVM: VMX: Handle vectoring error in check_emulate_instruction

2024-12-13 Thread Ivan Orlov
On Thu, Dec 12, 2024 at 11:42:37AM -0800, Sean Christopherson wrote: > Gah, I got my enums mixed up. I conflated RET_PF_WRITE_PROTECTED with > EMULTYPE_WRITE_PF_TO_SP. Ignore the above. > > FWIW, KVM _can't_ unprotect and retry in the EMULTYPE_WRITE_PF_TO_SP case. > From > kvm_unprotect_and_re

Re: [PATCH v3] vdpa: solidrun: Replace deprecated PCI functions

2024-12-13 Thread Philipp Stanner
On Fri, 2024-12-13 at 16:10 +0100, Stefano Garzarella wrote: > On Wed, Dec 11, 2024 at 11:47:05AM +0100, Philipp Stanner wrote: > > The PCI functions > > > > pcim_iomap_regions() > > pcim_iounmap_regions() > > pcim_iomap_table() > > > > have been deprecated by the PCI subsystem. > >

[RFC 1/1] sched: defer completion task to online CPU

2024-12-13 Thread Usama Arif
The following warning is being encountered at boot time: WARNING: CPU: 94 PID: 588 at kernel/time/hrtimer.c:1086 hrtimer_start_range_ns+0x289/0x2d0 Modules linked in: CPU: 94 UID: 0 PID: 588 Comm: migration/94 Not tainted Stopper: multi_cpu_stop+0x0/0x1

[RFC 0/1] sched: defer completion task to online CPU

2024-12-13 Thread Usama Arif
We (meta) are running 6.12 release kernel in production and are encoutering the below warning, mostly at boot time, reported by Vlad Poenaru. [ cut here ] WARNING: CPU: 94 PID: 588 at kernel/time/hrtimer.c:1086 hrtimer_start_range_ns+0x289/0x2d0

Re: [PATCH v3 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-13 Thread Michael S. Tsirkin
On Fri, Dec 13, 2024 at 02:20:24PM +, Shijith Thotton wrote: > >>> > >>> Added support to read the vendor-specific PCI capability to identify the > >>> type of device being emulated. > >>> > >>> Reviewed-by: Dan Carpenter > >>> Signed-off-by: Shijith Thotton > >>> --- > >>> drivers/vdpa/octe

Re: [PATCH bpf-next v5 4/5] bpf: verifier: Support eliding map lookup nullness

2024-12-13 Thread Daniel Xu
On Thu, Dec 12, 2024 at 08:04:45PM GMT, Eduard Zingerman wrote: > On Thu, 2024-12-12 at 16:22 -0700, Daniel Xu wrote: > > I think these changes are fine in general, but see below. > > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > > index 58b36cc96bd5..4947ef884a18 100644 > > ---

Re: [PATCH v3 0/4] rust: extend `module!` macro with integer parameter support

2024-12-13 Thread Luis Chamberlain
On Fri, Dec 13, 2024 at 01:28:27PM +0100, Andreas Hindborg wrote: > > Hi Luis, Petr, Sami, Dani, > > I just noticed that I failed in email and forgot to add you to the > recipient list of this series. Do you want a resend, or is this > sufficient? If the patches didn't go to linux-modules, then

[PATCH RFC v2 rcu] Fix get_state_synchronize_rcu_full() GP-start detection

2024-12-13 Thread Paul E. McKenney
The get_state_synchronize_rcu_full() and poll_state_synchronize_rcu_full() functions use the root rcu_node structure's ->gp_seq field to detect the beginnings and ends of grace periods, respectively. This choice is necessary for the poll_state_synchronize_rcu_full() function because (give or take

Re: [PATCH bpf-next v5 3/5] bpf: verifier: Refactor helper access type tracking

2024-12-13 Thread Daniel Xu
On Thu, Dec 12, 2024 at 08:04:28PM GMT, Eduard Zingerman wrote: > On Thu, 2024-12-12 at 16:22 -0700, Daniel Xu wrote: > > Previously, the verifier was treating all PTR_TO_STACK registers passed > > to a helper call as potentially written to by the helper. However, all > > calls to check_stack_range

Re: [PATCH 1/4] KVM: VMX: read the PML log in the same order as it was written

2024-12-13 Thread Maxim Levitsky
On Thu, 2024-12-12 at 22:19 -0800, Sean Christopherson wrote: > On Thu, Dec 12, 2024, Maxim Levitsky wrote: > > On Wed, 2024-12-11 at 16:44 -0800, Sean Christopherson wrote: > > > But, I can't help but wonder why KVM bothers emulating PML. I can > > > appreciate > > > that avoiding exits to L1 wo

Re: [PATCH v2 3/6] KVM: VMX: Handle vectoring error in check_emulate_instruction

2024-12-13 Thread Sean Christopherson
On Fri, Dec 13, 2024, Ivan Orlov wrote: > On Thu, Dec 12, 2024 at 11:42:37AM -0800, Sean Christopherson wrote: > > Unprotect and re-execute is fine, what I'm worried about is *successfully* > > emulating the instruction. E.g. > > > > 1. CPU executes instruction X and hits a #GP. > > 2. While

Re: [RFC v2 04/13] rust: sync: atomic: Add generic atomics

2024-12-13 Thread Boqun Feng
On Fri, Dec 13, 2024 at 03:32:47PM +0100, Alice Ryhl wrote: > On Thu, Dec 12, 2024 at 6:34 PM Boqun Feng wrote: > > > > On Thu, Dec 12, 2024 at 11:57:07AM +0100, Alice Ryhl wrote: > > [...] > > > > diff --git a/rust/kernel/sync/atomic/generic.rs > > > > b/rust/kernel/sync/atomic/generic.rs > > >

Re: [PATCH v2 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests

2024-12-13 Thread Brian Norris
Hi Maxime, On Fri, Dec 13, 2024 at 12:59:57PM +0100, Maxime Ripard wrote: > On Wed, Dec 11, 2024 at 04:31:41PM -0800, Brian Norris wrote: > > --- a/drivers/base/test/platform-device-test.c > > +++ b/drivers/base/test/platform-device-test.c > > @@ -217,7 +219,45 @@ static struct kunit_suite > > p

[PATCH v4 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-12-13 Thread Shijith Thotton
Updated the driver to utilize all the MSI-X interrupt vectors supported by each OCTEON endpoint VF, instead of relying on a single vector. Enabling more interrupts allows packets from multiple rings to be distributed across multiple cores, improving parallelism and performance. Reviewed-by: Dan Ca

[PATCH v4 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-13 Thread Shijith Thotton
Added support to read the vendor-specific PCI capability to identify the type of device being emulated. Reviewed-by: Dan Carpenter Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa.h | 20 + drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 36 ++

[PATCH v4 2/4] vdpa/octeon_ep: handle device config change events

2024-12-13 Thread Shijith Thotton
From: Satha Rao The first interrupt of the device is used to notify the host about device configuration changes, such as link status updates. The ISR configuration area is updated to indicate a config change event when triggered. Signed-off-by: Satha Rao Reviewed-by: Dan Carpenter Acked-by: Ja

[PATCH v4 3/4] virtio-pci: define type and header for PCI vendor data

2024-12-13 Thread Shijith Thotton
Added macro definition for VIRTIO_PCI_CAP_VENDOR_CFG to identify the PCI vendor data type in the virtio_pci_cap structure. Defined a new struct virtio_pci_vndr_data for the vendor data capability header as per the specification. Signed-off-by: Shijith Thotton --- include/uapi/linux/virtio_pci.h

Re: [PATCH v3 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-13 Thread Shijith Thotton
>> >>> Added support to read the vendor-specific PCI capability to identify the >> >>> type of device being emulated. >> >>> >> >>> Reviewed-by: Dan Carpenter >> >>> Signed-off-by: Shijith Thotton >> >>> --- >> >>> drivers/vdpa/octeon_ep/octep_vdpa.h | 20 ++ >> >>> drivers/vdpa

Re: [PATCH bpf-next v5 5/5] bpf: selftests: verifier: Add nullness elision tests

2024-12-13 Thread Eduard Zingerman
On Thu, 2024-12-12 at 16:22 -0700, Daniel Xu wrote: > Test that nullness elision works for common use cases. For example, we > want to check that both full and subreg stack slots are recognized. As > well as when there's both const and non-const values of R2 leading up to > a lookup. And obviously

RE: [PATCH v3 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-13 Thread Shijith Thotton
>>> >>> Added support to read the vendor-specific PCI capability to identify the >>> type of device being emulated. >>> >>> Reviewed-by: Dan Carpenter >>> Signed-off-by: Shijith Thotton >>> --- >>> drivers/vdpa/octeon_ep/octep_vdpa.h | 20 ++ >>> drivers/vdpa/octeon_ep/octep_vdp

Re: [PATCH net-next v15 02/22] ovpn: add basic netlink support

2024-12-13 Thread Donald Hunter
On Wed, 11 Dec 2024 at 21:32, Antonio Quartulli wrote: > > +name: peer > +type: nest > +doc: | > + The peer object containing the attributed of interest for the > specific typo: attributes > + operation > +nested-attributes: peer I also spotted

Re: [PATCH net-next v15 02/22] ovpn: add basic netlink support

2024-12-13 Thread Antonio Quartulli
On 13/12/2024 17:45, Donald Hunter wrote: On Wed, 11 Dec 2024 at 21:32, Antonio Quartulli wrote: +name: peer +type: nest +doc: | + The peer object containing the attributed of interest for the specific typo: attributes + operation +nested-

Re: [PATCH v2 1/4] sched: Move task_mm_cid_work to mm delayed work

2024-12-13 Thread Mathieu Desnoyers
On 2024-12-13 04:54, Gabriele Monaco wrote: Currently, the task_mm_cid_work function is called in a task work triggered by a scheduler tick. This can delay the execution of the task for the entire duration of the function, negatively affecting the response of real time tasks. This patch runs the

Re: [PATCH v2 4/4] rseq/selftests: Add test for mm_cid compaction

2024-12-13 Thread Gabriele Monaco
On Fri, 2024-12-13 at 09:29 -0500, Mathieu Desnoyers wrote: > On 2024-12-13 04:54, Gabriele Monaco wrote: > > A task in the kernel (task_mm_cid_work) runs somewhat periodically > > to > > compact the mm_cid for each process, this test tries to validate > > that > > it runs correctly and timely. >

[PATCH bpf-next v2 0/2] selftests: bpf: Migrate test_xdp_meta.sh to test_progs

2024-12-13 Thread Bastien Curutchet
Hi all, This patch series continues the work to migrate the script tests into prog_tests. test_xdp_meta.sh uses the BPF programs defined in progs/test_xdp_meta.c to do a simple XDP/TC functional test that checks the metadata allocation performed by the bpf_xdp_adjust_meta() helper. This is alrea

[PATCH bpf-next v2 1/2] selftests/bpf: test_xdp_meta: Rename BPF sections

2024-12-13 Thread Bastien Curutchet
SEC("t") and SEC("x") can't be loaded by the __load() helper. Rename these sections SEC("tc") and SEC("xdp") so they can be interpreted by the __load() helper in upcoming patch. Update the test_xdp_meta.sh to fit these new names. Signed-off-by: Bastien Curutchet (eBPF Foundation) --- tools/tes

[PATCH bpf-next v2 2/2] selftests/bpf: Migrate test_xdp_meta.sh into xdp_context_test_run.c

2024-12-13 Thread Bastien Curutchet
test_xdp_meta.sh can't be used by the BPF CI. Migrate test_xdp_meta.sh in a new test case in xdp_context_test_run.c. It uses the same BPF programs located in progs/test_xdp_meta.c and the same network topology. Remove test_xdp_meta.sh and its Makefile entry. Signed-off-by: Bastien Curutchet (eBPF

Re: [PATCH v3] vdpa: solidrun: Replace deprecated PCI functions

2024-12-13 Thread Stefano Garzarella
On Wed, Dec 11, 2024 at 11:47:05AM +0100, Philipp Stanner wrote: The PCI functions pcim_iomap_regions() pcim_iounmap_regions() pcim_iomap_table() have been deprecated by the PCI subsystem. Replace these functions with their successors pcim_iomap_region() and pcim_iounma

Re: [PATCH v2 2/4] sched: Remove mm_cid_next_scan as obsolete

2024-12-13 Thread Mathieu Desnoyers
On 2024-12-13 04:54, Gabriele Monaco wrote: The checks for the scan time in task_mm_cid_work are now superfluous since the task runs in a delayed_work and the minimum periodicity is already implied. This patch removes those checks and the field from the mm_struct. Additionally, we include a sim

Re: [PATCH v2 3/4] sched: Compact RSEQ concurrency IDs with reduced threads and affinity

2024-12-13 Thread Mathieu Desnoyers
On 2024-12-13 04:54, Gabriele Monaco wrote: From: Mathieu Desnoyers When a process reduces its number of threads or clears bits in its CPU affinity mask, the mm_cid allocation should eventually converge towards smaller values. I target v6.13 for this patch. As it fixes a commit which was rece

Re: [RFC v2 02/13] rust: sync: Add basic atomic operation mapping framework

2024-12-13 Thread Alice Ryhl
On Thu, Dec 12, 2024 at 6:07 PM Boqun Feng wrote: > > On Thu, Dec 12, 2024 at 11:51:23AM +0100, Alice Ryhl wrote: > > On Fri, Nov 1, 2024 at 7:03 AM Boqun Feng wrote: > > > > > > Preparation for generic atomic implementation. To unify the > > > ipmlementation of a generic method over `i32` and `i

Re: [PATCH v2 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc

2024-12-13 Thread Rafael J. Wysocki
On Thu, Dec 12, 2024 at 1:32 AM Brian Norris wrote: > > of_find_device_by_node(), bus_find_device_by_of_node(), > bus_find_device_by_fwnode(), ..., all produce arbitrary results when > provided with a NULL of_node, fwnode, ACPI handle, etc. This is > counterintuitive, and the source of a few bugs,

Re: [PATCH v2] kselftest/arm64: abi: fix SVCR detection

2024-12-13 Thread Catalin Marinas
On Wed, 11 Dec 2024 19:16:39 +0800, Weizhao Ouyang wrote: > When using svcr_in to check ZA and Streaming Mode, we should make sure > that the value in x2 is correct, otherwise it may trigger an Illegal > instruction if FEAT_SVE and !FEAT_SME. > > Applied to arm64 (for-next/fixes), thanks! [1/1]

Re: [RFC v2 04/13] rust: sync: atomic: Add generic atomics

2024-12-13 Thread Alice Ryhl
On Thu, Dec 12, 2024 at 6:34 PM Boqun Feng wrote: > > On Thu, Dec 12, 2024 at 11:57:07AM +0100, Alice Ryhl wrote: > [...] > > > diff --git a/rust/kernel/sync/atomic/generic.rs > > > b/rust/kernel/sync/atomic/generic.rs > > > new file mode 100644 > > > index ..204da38e2691 > > > --- /d

Re: [PATCH v2 4/4] rseq/selftests: Add test for mm_cid compaction

2024-12-13 Thread Mathieu Desnoyers
On 2024-12-13 04:54, Gabriele Monaco wrote: A task in the kernel (task_mm_cid_work) runs somewhat periodically to compact the mm_cid for each process, this test tries to validate that it runs correctly and timely. The test spawns 1 thread pinned to each CPU, then each thread, including the main

Re: [PATCH v2 1/4] sched: Move task_mm_cid_work to mm delayed work

2024-12-13 Thread Gabriele Monaco
On Fri, 2024-12-13 at 09:14 -0500, Mathieu Desnoyers wrote: > On 2024-12-13 04:54, Gabriele Monaco wrote: > > Currently, the task_mm_cid_work function is called in a task work > > triggered by a scheduler tick. This can delay the execution of the > > task > > for the entire duration of the functi

Re: [PATCH bpf-next v5 4/5] bpf: verifier: Support eliding map lookup nullness

2024-12-13 Thread Kumar Kartikeya Dwivedi
On Fri, 13 Dec 2024 at 00:24, Daniel Xu wrote: > > This commit allows progs to elide a null check on statically known map > lookup keys. In other words, if the verifier can statically prove that > the lookup will be in-bounds, allow the prog to drop the null check. > > This is useful for two reaso

Re: [PATCH rcu 2/2] rcu/nocb: Fix rcuog wake-up from offline softirq

2024-12-13 Thread Frederic Weisbecker
Le Thu, Dec 12, 2024 at 10:42:14AM -0800, Paul E. McKenney a écrit : > From: Frederic Weisbecker > > After a CPU has set itself offline and before it eventually calls > rcutree_report_cpu_dead(), there are still opportunities for callbacks > to be enqueued, for example from an IRQ. When that happ

Re: [PATCH rcu 1/2] rcu/nocb: Use switch/case on NOCB timer state machine

2024-12-13 Thread Frederic Weisbecker
Le Thu, Dec 12, 2024 at 10:42:13AM -0800, Paul E. McKenney a écrit : > From: Frederic Weisbecker > > It's more convenient to benefit from the fallthrough feature of > switch / case to handle the timer state machine. Also a new state is > about to be added that will take advantage of it. > > No i

Re: [PATCH bpf-next v5 4/5] bpf: verifier: Support eliding map lookup nullness

2024-12-13 Thread Daniel Xu
On Fri, Dec 13, 2024 at 03:02:11PM GMT, Andrii Nakryiko wrote: > On Thu, Dec 12, 2024 at 3:23 PM Daniel Xu wrote: > > > > This commit allows progs to elide a null check on statically known map > > lookup keys. In other words, if the verifier can statically prove that > > the lookup will be in-boun

Re: [PATCH bpf-next v5 4/5] bpf: verifier: Support eliding map lookup nullness

2024-12-13 Thread Eduard Zingerman
On Fri, 2024-12-13 at 19:44 -0700, Daniel Xu wrote: [...] > > > + /* First handle precisely tracked STACK_ZERO, up to BPF_REG_SIZE > > > */ > > > + stype = state->stack[spi].slot_type; > > > + for (i = 0; i < BPF_REG_SIZE && stype[i] == STACK_ZERO; i++) > > > > it's Friday and

Re: [PATCH net 0/2] bond: fix xfrm offload feature during init

2024-12-13 Thread Jakub Kicinski
On Fri, 13 Dec 2024 07:18:08 + Hangbin Liu wrote: > On Thu, Dec 12, 2024 at 06:27:34AM -0800, Jakub Kicinski wrote: > > On Wed, 11 Dec 2024 07:11:25 + Hangbin Liu wrote: > > > The first patch fixes the xfrm offload feature during setup active-backup > > > mode. The second patch add a ipse