Re: [PATCH net-next v12 11/22] ovpn: implement TCP transport

2024-12-09 Thread Antonio Quartulli
On 09/12/2024 11:46, Matthieu Baerts wrote: Hi Antonio, Thank you for working on this, and sharing your work here! On 05/12/2024 00:09, Antonio Quartulli wrote: On 04/12/2024 23:52, Antonio Quartulli wrote: Paolo, On 04/12/2024 12:15, Antonio Quartulli wrote: [...] +    mutex_lock(&tcp6

[PATCH v7 2/2] selftests/resctrl: Discover SNC kernel support and adjust messages

2024-12-09 Thread Maciej Wieczor-Retman
Resctrl selftest prints a message on test failure that Sub-Numa Clustering (SNC) could be enabled and points the user to check their BIOS settings. No actual check is performed before printing that message so it is not very accurate in pinpointing a problem. When there is SNC support for kernel's

[PATCH v7 0/2] selftests/resctrl: SNC kernel support discovery

2024-12-09 Thread Maciej Wieczor-Retman
Changes v7: - Include fallthrough in resctrlfs.c. - Check fp after opening empty cpus file. - Correct a comment and merge strings in snprintf(). Changes v6: - Rebase onto latest kselftest-next. - Looking at the two patches with a fresh eye decided to make a split along the lines of: - Pa

[PATCH v7 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled

2024-12-09 Thread Maciej Wieczor-Retman
Sub-NUMA Cluster divides CPUs sharing an L3 cache into separate NUMA nodes. Systems may support splitting into either two, three, four or six nodes. When SNC mode is enabled the effective amount of L3 cache available for allocation is divided by the number of nodes per L3. It's possible to detect

Re: [PATCH RT 0/1] Linux v4.19.324-rt139-rc1

2024-12-09 Thread Daniel Wagner
Hi Pavel, On 12/5/24 12:28 PM, Pavel Machek wrote: Hi! This is the RT stable review cycle of patch 4.19.324-rt139-rc1. Please scream at me if I messed something up. Please test the patches too. 4.19.324-rt139 would be very useful for our -cip-rt release, can we hope to get it soon? :-). A

Re: [PATCH net-next v12 11/22] ovpn: implement TCP transport

2024-12-09 Thread Matthieu Baerts
On 09/12/2024 11:58, Antonio Quartulli wrote: > On 09/12/2024 11:46, Matthieu Baerts wrote: >> Hi Antonio, >> >> Thank you for working on this, and sharing your work here! >> >> On 05/12/2024 00:09, Antonio Quartulli wrote: >>> On 04/12/2024 23:52, Antonio Quartulli wrote: Paolo, On

[PATCH v2] vdpa: solidrun: Replace deprecated PCI functions

2024-12-09 Thread Philipp Stanner
The PCI functions pcim_iomap_regions() pcim_iounmap_regions() pcim_iomap_table() have been deprecated by the PCI subsystem. Replace these functions with their successors pcim_iomap_region() and pcim_iounmap_region(). Signed-off-by: Philipp Stanner --- Changes in v2: -

Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property

2024-12-09 Thread Bryan O'Donoghue
On 09/12/2024 12:01, Luca Weiss wrote: The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for CSI-2, but not any others so restrict the bus-type property describing this to the supported values. The only exception here is MSM8916 which only supports D-PHY. C-PHY was introduced wi

Re: [PATCH V3] selftests: livepatch: add test cases of stack_order sysfs interface

2024-12-09 Thread Petr Mladek
On Thu 2024-10-24 16:35:30, Wardenjohn wrote: > Add selftest test cases to sysfs attribute 'stack_order'. > > Suggested-by: Petr Mladek > Signed-off-by: Wardenjohn JFYI, I have pushed this patch into livepatching.git, branch for-6.14/stack-order. Note that I have substituted /sys/kernel/livepa

Re: [PATCH] kselftest/arm64: abi: fix SVCR detection

2024-12-09 Thread Mark Brown
On Mon, Dec 09, 2024 at 06:52:37PM +0800, Weizhao Ouyang wrote: > When using svcr_in to check ZA and Streaming Mode, we should make sure > that the value in x2 is correct, otherwise it may trigger an Illegal > instruction if FEAT_SVE and !FEAT_SME. > // Set SVCR if we're doing SME > - c

Re: [PATCH] kselftest/arm64: abi: fix SVCR detection

2024-12-09 Thread Weizhao Ouyang
On Mon, Dec 9, 2024 at 8:36 PM Mark Brown wrote: > > On Mon, Dec 09, 2024 at 06:52:37PM +0800, Weizhao Ouyang wrote: > > > When using svcr_in to check ZA and Streaming Mode, we should make sure > > that the value in x2 is correct, otherwise it may trigger an Illegal > > instruction if FEAT_SVE and

Re: [PATCH V5 1/1] livepatch: Add stack_order sysfs attribute

2024-12-09 Thread Petr Mladek
On Tue 2024-10-08 09:48:56, Wardenjohn wrote: > Add "stack_order" sysfs attribute which holds the order in which a live > patch module was loaded into the system. A user can then determine an > active live patched version of a function. > > cat /sys/kernel/livepatch/livepatch_1/stack_order -> 1 >

Re: [PATCH 2/2] media: qcom: camss: Restrict endpoint bus-type to D-PHY

2024-12-09 Thread Bryan O'Donoghue
On 09/12/2024 12:01, Luca Weiss wrote: Currently the Qualcomm CAMSS driver only supports D-PHY while the hardware on most SoCs also supports C-PHY. Until this support is added, check for D-PHY to make it somewhat explicit that C-PHY won't work. Signed-off-by: Luca Weiss --- drivers/media/plat

[PATCH net-next v14 02/22] ovpn: add basic netlink support

2024-12-09 Thread Antonio Quartulli
This commit introduces basic netlink support with family registration/unregistration functionalities and stub pre/post-doit. More importantly it introduces the YAML uAPI description along with its auto-generated files: - include/uapi/linux/ovpn.h - drivers/net/ovpn/netlink-gen.c - drivers/net/ovpn

[PATCH net-next v14 00/22] Introducing OpenVPN Data Channel Offload

2024-12-09 Thread Antonio Quartulli
Notable changes since v13: * included linux/ipv6.h in 07/22 to fix build on nios2 (reported by kernel test robot) Please note that some patches were already reviewed by Andre Lunn, Donald Hunter and Shuah Khan. They have retained the Reviewed-by tag since no major code modification has happened

[PATCH net-next v14 08/22] ovpn: implement basic RX path (UDP)

2024-12-09 Thread Antonio Quartulli
Packets received over the socket are forwarded to the user device. Implementation is UDP only. TCP will be added by a later patch. Note: no decryption/decapsulation exists yet, packets are forwarded as they arrive without much processing. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/i

[PATCH net-next v14 05/22] ovpn: introduce the ovpn_peer object

2024-12-09 Thread Antonio Quartulli
An ovpn_peer object holds the whole status of a remote peer (regardless whether it is a server or a client). This includes status for crypto, tx/rx buffers, napi, etc. Only support for one peer is introduced (P2P mode). Multi peer support is introduced with a later patch. Along with the ovpn_pee

[PATCH net-next v14 07/22] ovpn: implement basic TX path (UDP)

2024-12-09 Thread Antonio Quartulli
Packets sent over the ovpn interface are processed and transmitted to the connected peer, if any. Implementation is UDP only. TCP will be added by a later patch. Note: no crypto/encapsulation exists yet. Packets are just captured and sent. Signed-off-by: Antonio Quartulli --- drivers/net/Kconf

[PATCH net-next v14 06/22] ovpn: introduce the ovpn_socket object

2024-12-09 Thread Antonio Quartulli
This specific structure is used in the ovpn kernel module to wrap and carry around a standard kernel socket. ovpn takes ownership of passed sockets and therefore an ovpn specific objects is attached to them for status tracking purposes. Initially only UDP support is introduced. TCP will come in a

[PATCH net-next v14 04/22] ovpn: keep carrier always on for MP interfaces

2024-12-09 Thread Antonio Quartulli
An ovpn interface configured in MP mode will keep carrier always on and let the user decide when to bring it administratively up and down. This way a MP node (i.e. a server) will keep its interface always up and running, even when no peer is connected. Signed-off-by: Antonio Quartulli --- drive

[PATCH net-next v14 12/22] ovpn: implement multi-peer support

2024-12-09 Thread Antonio Quartulli
With this change an ovpn instance will be able to stay connected to multiple remote endpoints. This functionality is strictly required when running ovpn on an OpenVPN server. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/main.c | 67 - drivers/net/ovpn/ovpnstruct.

[PATCH net-next v14 13/22] ovpn: implement peer lookup logic

2024-12-09 Thread Antonio Quartulli
In a multi-peer scenario there are a number of situations when a specific peer needs to be looked up. We may want to lookup a peer by: 1. its ID 2. its VPN destination IP 3. its transport IP/port couple For each of the above, there is a specific routing table referencing all peers for fast look u

[PATCH net-next v14 17/22] ovpn: implement peer add/get/dump/delete via netlink

2024-12-09 Thread Antonio Quartulli
This change introduces the netlink command needed to add, delete and retrieve/dump known peers. Userspace is expected to use these commands to handle known peer lifecycles. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/netlink.c | 631 - driver

[PATCH net-next v14 16/22] ovpn: add support for peer floating

2024-12-09 Thread Antonio Quartulli
A peer connected via UDP may change its IP address without reconnecting (float). Add support for detecting and updating the new peer IP/port in case of floating. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/bind.c | 9 +- drivers/net/ovpn/io.c | 4 + drivers/net/ovpn/peer.c | 243

[PATCH net-next v14 20/22] ovpn: notify userspace when a peer is deleted

2024-12-09 Thread Antonio Quartulli
Whenever a peer is deleted, send a notification to userspace so that it can react accordingly. This is most important when a peer is deleted due to ping timeout, because it all happens in kernelspace and thus userspace has no direct way to learn about it. Signed-off-by: Antonio Quartulli --- dr

[PATCH net-next v14 01/22] net: introduce OpenVPN Data Channel Offload (ovpn)

2024-12-09 Thread Antonio Quartulli
OpenVPN is a userspace software existing since around 2005 that allows users to create secure tunnels. So far OpenVPN has implemented all operations in userspace, which implies several back and forth between kernel and user land in order to process packets (encapsulate/decapsulate, encrypt/decrypt

[PATCH net-next v14 03/22] ovpn: add basic interface creation/destruction/management routines

2024-12-09 Thread Antonio Quartulli
Add basic infrastructure for handling ovpn interfaces. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/Makefile | 1 + drivers/net/ovpn/io.c | 22 + drivers/net/ovpn/io.h | 24 ++ drivers/net/ovpn/main.c | 102 ++

[PATCH net-next v14 09/22] ovpn: implement packet processing

2024-12-09 Thread Antonio Quartulli
This change implements encryption/decryption and encapsulation/decapsulation of OpenVPN packets. Support for generic crypto state is added along with a wrapper for the AEAD crypto kernel API. Signed-off-by: Antonio Quartulli --- drivers/net/Kconfig| 4 + drivers/net/ovpn/Makefile

[PATCH net-next v14 10/22] ovpn: store tunnel and transport statistics

2024-12-09 Thread Antonio Quartulli
Byte/packet counters for in-tunnel and transport streams are now initialized and updated as needed. To be exported via netlink. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/Makefile | 1 + drivers/net/ovpn/io.c | 12 +++- drivers/net/ovpn/peer.c | 2 ++ drivers/net/ovpn

[PATCH net-next v14 14/22] ovpn: implement keepalive mechanism

2024-12-09 Thread Antonio Quartulli
OpenVPN supports configuring a periodic keepalive packet. message to allow the remote endpoint detect link failures. This change implements the keepalive sending and timer expiring logic. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/io.c | 77 + drivers/net/ovp

[PATCH net-next v14 18/22] ovpn: implement key add/get/del/swap via netlink

2024-12-09 Thread Antonio Quartulli
This change introduces the netlink commands needed to add, get, delete and swap keys for a specific peer. Userspace is expected to use these commands to create, inspect (non sensitive data only), destroy and rotate session keys for a specific peer. Signed-off-by: Antonio Quartulli --- drivers/n

[PATCH net-next v14 15/22] ovpn: add support for updating local UDP endpoint

2024-12-09 Thread Antonio Quartulli
In case of UDP links, the local endpoint used to communicate with a given peer may change without a connection restart. Add support for learning the new address in case of change. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/peer.c | 45 + dr

[PATCH net-next v14 19/22] ovpn: kill key and notify userspace in case of IV exhaustion

2024-12-09 Thread Antonio Quartulli
IV wrap-around is cryptographically dangerous for a number of ciphers, therefore kill the key and inform userspace (via netlink) should the IV space go exhausted. Userspace has two ways of deciding when the key has to be renewed before exhausting the IV space: 1) time based approach: after X se

[PATCH net-next v14 22/22] testing/selftests: add test tool and scripts for ovpn module

2024-12-09 Thread Antonio Quartulli
The ovpn-cli tool can be compiled and used as selftest for the ovpn kernel module. [NOTE: it depends on libmedtls for decoding base64-encoded keys] ovpn-cli implements the netlink and RTNL APIs and can thus be integrated in any script for more automated testing. Along with the tool, 4 scripts ar

[PATCH net-next v14 21/22] ovpn: add basic ethtool support

2024-12-09 Thread Antonio Quartulli
Implement support for basic ethtool functionality. Note that ovpn is a virtual device driver, therefore various ethtool APIs are just not meaningful and thus not implemented. Signed-off-by: Antonio Quartulli Reviewed-by: Andrew Lunn --- drivers/net/ovpn/main.c | 15 +++ 1 file chan

[PATCH net-next v14 11/22] ovpn: implement TCP transport

2024-12-09 Thread Antonio Quartulli
With this change ovpn is allowed to communicate to peers also via TCP. Parsing of incoming messages is implemented through the strparser API. Note that ovpn redefines sk_prot and sk_socket->ops for the TCP socket used to communicate with the peer. For this reason it needs to access inet6_stream_op

RE: [PATCH v2 4/4] vdpa/octeon_ep: add interrupt handler for virtio crypto device

2024-12-09 Thread Shijith Thotton
>>> Introduced an interrupt handler for the virtio crypto device, as its >>> queue usage differs from that of network devices. While virtio network >>> device receives packets only on even-indexed queues, virtio crypto >>> device utilize all available queues for processing data. >> >>I'm not sure I

Re: [PATCH v2 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-12-09 Thread Shijith Thotton
>> > >> > Updated the driver to utilize all the MSI-X interrupt vectors supported >> > by each OCTEON endpoint VF, instead of relying on a single vector. >> > Enabling more interrupts allows packets from multiple rings to be >> > distributed across multiple cores, improving parallelism and >> > per

[PATCH 14/14] selftests/mm: Remove X permission from sigaltstack mapping

2024-12-09 Thread Kevin Brodsky
There is no reason why the alternate signal stack should be mapped as RWX. Map it as RW instead. Signed-off-by: Kevin Brodsky --- tools/testing/selftests/mm/pkey_sighandler_tests.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/pkey_sighandler_

Re: [PATCH livepatch/master v1 2/2] selftests/livepatch: Replace hardcoded module name with variable in test-callbacks.sh

2024-12-09 Thread Petr Mladek
On Mon 2024-11-25 19:28:12, George Guo wrote: > From: George Guo > > Replaced the hardcoded module name test_klp_callbacks_demo in the > pre_patch_callback log message with the variable $MOD_LIVEPATCH. > > Signed-off-by: George Guo JFYI, this patch has been committed into livepatching.git, bra

[PATCH 2/2] media: qcom: camss: Restrict endpoint bus-type to D-PHY

2024-12-09 Thread Luca Weiss
Currently the Qualcomm CAMSS driver only supports D-PHY while the hardware on most SoCs also supports C-PHY. Until this support is added, check for D-PHY to make it somewhat explicit that C-PHY won't work. Signed-off-by: Luca Weiss --- drivers/media/platform/qcom/camss/camss.c | 9 + 1 f

[PATCH 0/2] Some small preparations around CAMSS D-PHY / C-PHY support

2024-12-09 Thread Luca Weiss
, 142 insertions(+) --- base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4 change-id: 20241209-camss-dphy-8bf46e251291 Best regards, -- Luca Weiss

[PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property

2024-12-09 Thread Luca Weiss
The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for CSI-2, but not any others so restrict the bus-type property describing this to the supported values. The only exception here is MSM8916 which only supports D-PHY. C-PHY was introduced with newer SoCs. Do note, that currently t

[PATCH 13/14] selftests/mm: Skip pkey_sighandler_tests if support is missing

2024-12-09 Thread Kevin Brodsky
The pkey_sighandler_tests are bound to fail if either the kernel or CPU doesn't support pkeys. Skip the tests if pkeys support is missing. Signed-off-by: Kevin Brodsky --- tools/testing/selftests/mm/pkey_sighandler_tests.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/self

[PATCH 10/14] selftests/mm: Ensure non-global pkey symbols are marked static

2024-12-09 Thread Kevin Brodsky
The pkey tests define a whole lot of functions and some global variables. A few are truly global (declared in pkey-helpers.h), but the majority are file-scoped. Make sure those are labelled static. Some of the pkey_{access,write}_{allow,deny} helpers are not called, or only called when building fo

[PATCH 00/14] pkeys kselftests improvements

2024-12-09 Thread Kevin Brodsky
This series brings various cleanups and fixes for the mm (mostly pkeys) kselftests. The original goal was to make the pkeys tests work out of the box and without build warning - it turned out to be more involved than expected. The most important change is enabling -O2 when building all mm kselftes

[PATCH 01/14] selftests/mm: Fix condition in uffd_move_test_common()

2024-12-09 Thread Kevin Brodsky
area_src and area_dst are saved at the beginning of the function if chunk_size > page_size. The intention is quite clearly to restore them at the end based on the same condition, but step_size is considered instead of chunk_size. Considering that step_size is a number of pages, the condition is lik

[PATCH 08/14] selftests/mm: Ensure pkey-*.h define inline functions only

2024-12-09 Thread Kevin Brodsky
Headers should not define non-inline functions, as this prevents them from being included more than once in a given program. pkey-helpers.h and the arch-specific headers it includes currently define multiple such non-inline functions. In most cases those functions can simply be made inline - this

[PATCH 03/14] selftests/mm: Fix strncpy() length

2024-12-09 Thread Kevin Brodsky
GCC complains (with -O2) that the length is equal to the destination size, which is indeed invalid. Subtract 1 from the size of the array to leave room for '\0'. Signed-off-by: Kevin Brodsky --- tools/testing/selftests/mm/write_to_hugetlbfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 04/14] selftests/mm: Fix -Warray-bounds warnings in pkey_sighandler_tests

2024-12-09 Thread Kevin Brodsky
GCC doesn't like dereferencing a pointer set to 0x1 (when building at -O2): pkey_sighandler_tests.c:166:9: warning: array subscript 0 is outside array bounds of 'int[0]' [-Warray-bounds=] 166 | *(int *) (0x1) = 1; | ^~ cc1: note: source object is likely at addr

[PATCH 02/14] selftests/mm: Fix -Wmaybe-uninitialized warnings

2024-12-09 Thread Kevin Brodsky
A few -Wmaybe-uninitialized warnings show up when building the mm tests with -O2. None of them looks worrying; silence them by initialising the problematic variables. Signed-off-by: Kevin Brodsky --- tools/testing/selftests/mm/ksm_tests.c | 2 +- tools/testing/selftests/mm/mremap_test.c

[PATCH 05/14] selftests/mm: Build with -O2

2024-12-09 Thread Kevin Brodsky
The mm kselftests are currently built with no optimisation (-O0). It's unclear why, and besides being obviously suboptimal, this also prevents the pkeys tests from working as intended. Let's build all the tests with -O2. Signed-off-by: Kevin Brodsky --- tools/testing/selftests/mm/Makefile | 2 +-

[PATCH 06/14] selftests/mm: Remove unused pkey helpers

2024-12-09 Thread Kevin Brodsky
Commit 5f23f6d082a9 ("x86/pkeys: Add self-tests") introduced a number of helpers and functions that don't seem to have ever been used. Let's remove them. Signed-off-by: Kevin Brodsky --- tools/testing/selftests/mm/pkey-helpers.h| 34 tools/testing/selftests/mm/protection

[PATCH 11/14] selftests/mm: Use sys_pkey helpers consistently

2024-12-09 Thread Kevin Brodsky
sys_pkey_alloc, sys_pkey_free and sys_mprotect_pkey are currently used in protections_keys.c, while pkey_sighandler_tests.c calls the libc wrappers directly (e.g. pkey_mprotect()). This is probably ok when using glibc (those symbols appeared a while ago), but Musl does not currently provide them. T

[PATCH 12/14] selftests/mm: Rename pkey register macro

2024-12-09 Thread Kevin Brodsky
PKEY_ALLOW_ALL is meant to represent the pkey register value that allows all accesses (enables all pkeys). However its current naming suggests that the value applies to *one* key only (like PKEY_DISABLE_ACCESS for instance). Rename PKEY_ALLOW_ALL to PKEY_REG_ALLOW_ALL to avoid such misunderstandin

[PATCH 09/14] selftests/mm: Remove empty pkey helper definition

2024-12-09 Thread Kevin Brodsky
Some of the functions declared in pkey-helpers.h are actually defined in protections_keys.c, meaning they can only be called from protections_keys.c. This is less than ideal, but it is hard to avoid as these helpers are themselves called from inline functions in pkey-.h. Let's at least add a commen

[PATCH 07/14] selftests/mm: Define types using typedef in pkey-helpers.h

2024-12-09 Thread Kevin Brodsky
Using #define to define types should be avoided. Use typedef instead. Also ensure that __u* types are actually defined by including . Signed-off-by: Kevin Brodsky --- tools/testing/selftests/mm/pkey-helpers.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/te

Re: [PATCH net-next v12 11/22] ovpn: implement TCP transport

2024-12-09 Thread Matthieu Baerts
Hi Antonio, Thank you for working on this, and sharing your work here! On 05/12/2024 00:09, Antonio Quartulli wrote: > On 04/12/2024 23:52, Antonio Quartulli wrote: >> Paolo, >> >> On 04/12/2024 12:15, Antonio Quartulli wrote: >> [...] > +    mutex_lock(&tcp6_prot_mutex); > +    i

[PATCH] kselftest/arm64: abi: fix SVCR detection

2024-12-09 Thread Weizhao Ouyang
When using svcr_in to check ZA and Streaming Mode, we should make sure that the value in x2 is correct, otherwise it may trigger an Illegal instruction if FEAT_SVE and !FEAT_SME. Fixes: 43e3f85523e4 ("kselftest/arm64: Add SME support to syscall ABI test") Signed-off-by: Weizhao Ouyang --- tools/

Re: [PATCH] kselftest/arm64: abi: fix SVCR detection

2024-12-09 Thread Mark Brown
On Mon, Dec 09, 2024 at 08:51:28PM +0800, Weizhao Ouyang wrote: > On Mon, Dec 9, 2024 at 8:36 PM Mark Brown wrote: > > > // Set SVCR if we're doing SME > > > - cbz x1, 1f > > > adrpx2, svcr_in > > > ldr x2, [x2, :lo12:svcr_in] > > > + cbz x1, 1f > > >

Re: [PATCH] kselftest/arm64: abi: fix SVCR detection

2024-12-09 Thread Weizhao Ouyang
On Mon, Dec 9, 2024 at 9:12 PM Mark Brown wrote: > > On Mon, Dec 09, 2024 at 08:51:28PM +0800, Weizhao Ouyang wrote: > > On Mon, Dec 9, 2024 at 8:36 PM Mark Brown wrote: > > > > > // Set SVCR if we're doing SME > > > > - cbz x1, 1f > > > > adrpx2, svcr_in > > > > ldr

Re: [PATCH v2] vdpa: solidrun: Replace deprecated PCI functions

2024-12-09 Thread Stefano Garzarella
On Mon, Dec 09, 2024 at 12:51:18PM +0100, Philipp Stanner wrote: The PCI functions pcim_iomap_regions() pcim_iounmap_regions() pcim_iomap_table() have been deprecated by the PCI subsystem. Replace these functions with their successors pcim_iomap_region() and pcim_iounma

Re: [PATCH v2] vdpa: solidrun: Replace deprecated PCI functions

2024-12-09 Thread Philipp Stanner
On Mon, 2024-12-09 at 14:31 +0100, Stefano Garzarella wrote: > On Mon, Dec 09, 2024 at 12:51:18PM +0100, Philipp Stanner wrote: > > The PCI functions > > > > pcim_iomap_regions() > > pcim_iounmap_regions() > > pcim_iomap_table() > > > > have been deprecated by the PCI subsystem. > >

Re: [PATCH] kselftest/arm64: abi: fix SVCR detection

2024-12-09 Thread Mark Brown
On Mon, Dec 09, 2024 at 09:26:01PM +0800, Weizhao Ouyang wrote: > > If we don't have SME we should be skipping over all the SME code and > > never even looking at the value of SVCR. Looking at the current version > > of the code it does that, it branches to check_sve_in if SME is not > > enabled.

Re: [PATCH] kselftest/arm64: abi: fix SVCR detection

2024-12-09 Thread Weizhao Ouyang
On Mon, Dec 9, 2024 at 9:51 PM Mark Brown wrote: > > On Mon, Dec 09, 2024 at 09:26:01PM +0800, Weizhao Ouyang wrote: > > > > If we don't have SME we should be skipping over all the SME code and > > > never even looking at the value of SVCR. Looking at the current version > > > of the code it does

Re: [PATCH net-next v12 11/22] ovpn: implement TCP transport

2024-12-09 Thread Antonio Quartulli
On 09/12/2024 12:31, Matthieu Baerts wrote: On 09/12/2024 11:58, Antonio Quartulli wrote: On 09/12/2024 11:46, Matthieu Baerts wrote: Hi Antonio, Thank you for working on this, and sharing your work here! On 05/12/2024 00:09, Antonio Quartulli wrote: On 04/12/2024 23:52, Antonio Quartulli wr

[PATCH 0/4] selftest/mm: Remove warnings foun

2024-12-09 Thread Muhammad Usama Anjum
Recently, I reviewed a patch on the mm/kselftest mailing list about a test which had obvious type mismatch fix in it. It was strange why that wasn't caught during development and when patch was accepted. This led me to discover that those extra compiler options to catch these warnings aren't being

[PATCH 1/4] selftests/mm: thp_settings: remove const from return type

2024-12-09 Thread Muhammad Usama Anjum
Remove cost from the return type as it is ignored anyways and generates the warning: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] Signed-off-by: Muhammad Usama Anjum --- Optional fixes tag. Fixes: 00679a183ac6 ("selftests/mm: factor out thp settings managemen

[PATCH 0/4] selftest/mm: Remove warnings found by adding compiler flags

2024-12-09 Thread Muhammad Usama Anjum
Recently, I reviewed a patch on the mm/kselftest mailing list about a test which had obvious type mismatch fix in it. It was strange why that wasn't caught during development and when patch was accepted. This led me to discover that those extra compiler options to catch these warnings aren't being

[PATCH 2/4] selftests/mm: pagemap_ioctl: Fix types mismatches shown by compiler options

2024-12-09 Thread Muhammad Usama Anjum
Fix following warnings caught by compiler: - There are several type mismatches among different variables. - Remove unused variable warnings. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/pagemap_ioctl.c | 108 +++-- tools/testing/selftests/mm/vm_util.c

[PATCH 4/4] selftests/mm: mremap_test: Remove unused variable and type mismatches

2024-12-09 Thread Muhammad Usama Anjum
Remove unused variable and fix type mismatches. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/mremap_test.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.

[PATCH 3/4] selftests/mm: mseal_test: remove unused variables

2024-12-09 Thread Muhammad Usama Anjum
Fix following warnings: - Remove unused variables and fix following warnings: Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/mseal_test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selft

Re: [PATCH v7 2/2] selftests/resctrl: Discover SNC kernel support and adjust messages

2024-12-09 Thread Reinette Chatre
Hi Maciej, On 12/9/24 3:09 AM, Maciej Wieczor-Retman wrote: > Resctrl selftest prints a message on test failure that Sub-Numa > Clustering (SNC) could be enabled and points the user to check their BIOS > settings. No actual check is performed before printing that message so > it is not very accura

Re: [PATCH v5] riscv: selftests: Fix warnings pointer masking test

2024-12-09 Thread Andrew Jones
On Fri, Dec 06, 2024 at 09:52:11AM -0800, Charlie Jenkins wrote: > When compiling the pointer masking tests with -Wall this warning > is present: > > pointer_masking.c: In function ‘test_tagged_addr_abi_sysctl’: > pointer_masking.c:203:9: warning: ignoring return value of ‘pwrite’ > declared with

Re: [PATCH net-next v12 11/22] ovpn: implement TCP transport

2024-12-09 Thread Matthieu Baerts
On 09/12/2024 15:08, Antonio Quartulli wrote: > On 09/12/2024 12:31, Matthieu Baerts wrote: >> On 09/12/2024 11:58, Antonio Quartulli wrote: >>> On 09/12/2024 11:46, Matthieu Baerts wrote: Hi Antonio, Thank you for working on this, and sharing your work here! On 05/12/2024

Re: [PATCH 3/4] btf: Switch vmlinux BTF attribute to sysfs_bin_attr_simple_read()

2024-12-09 Thread Andrii Nakryiko
On Thu, Dec 5, 2024 at 9:35 AM Thomas Weißschuh wrote: > > The generic function from the sysfs core can replace the custom one. > > Signed-off-by: Thomas Weißschuh > > --- > This is a replacement for [0], as Alexei was not happy about > BIN_ATTR_SIMPLE_RO() > > [0] > https://lore.kernel.org/lkm

Re: [PATCH v7 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled

2024-12-09 Thread Reinette Chatre
Hi Maciej, On 12/9/24 3:09 AM, Maciej Wieczor-Retman wrote: > Sub-NUMA Cluster divides CPUs sharing an L3 cache into separate NUMA > nodes. Systems may support splitting into either two, three, four or six > nodes. When SNC mode is enabled the effective amount of L3 cache > available for allocatio

Re: [PATCH v7 0/2] selftests/resctrl: SNC kernel support discovery

2024-12-09 Thread Reinette Chatre
Hi Maciej, On 12/9/24 3:09 AM, Maciej Wieczor-Retman wrote: > > Sub-Numa Clustering (SNC) allows splitting CPU cores, caches and memory > into multiple NUMA nodes. When enabled, NUMA-aware applications can > achieve better performance on bigger server platforms. > > SNC support in the kernel was

[PATCH v3 2/4] vdpa/octeon_ep: handle device config change events

2024-12-09 Thread Shijith Thotton
From: Satha Rao The first interrupt of the device is used to notify the host about device configuration changes, such as link status updates. The ISR configuration area is updated to indicate a config change event when triggered. Signed-off-by: Satha Rao Reviewed-by: Dan Carpenter Acked-by: Ja

[PATCH v3 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-12-09 Thread Shijith Thotton
Updated the driver to utilize all the MSI-X interrupt vectors supported by each OCTEON endpoint VF, instead of relying on a single vector. Enabling more interrupts allows packets from multiple rings to be distributed across multiple cores, improving parallelism and performance. Reviewed-by: Dan Ca

[PATCH v3 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-09 Thread Shijith Thotton
Added support to read the vendor-specific PCI capability to identify the type of device being emulated. Reviewed-by: Dan Carpenter Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa.h | 20 ++ drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 33 +

[PATCH v3 3/4] virtio-pci: define type and header for PCI vendor data

2024-12-09 Thread Shijith Thotton
Added macro definition for VIRTIO_PCI_CAP_VENDOR_CFG to identify the PCI vendor data type in the virtio_pci_cap structure. Defined a new struct virtio_pci_vndr_data for the vendor data capability header as per the specification. Signed-off-by: Shijith Thotton --- include/uapi/linux/virtio_pci.h

Re: [PATCH 4/4] btf: Switch module BTF attribute to sysfs_bin_attr_simple_read()

2024-12-09 Thread Andrii Nakryiko
On Thu, Dec 5, 2024 at 9:35 AM Thomas Weißschuh wrote: > > The generic function from the sysfs core can replace the custom one. > > Signed-off-by: Thomas Weißschuh > --- > kernel/bpf/btf.c | 15 ++- > 1 file changed, 2 insertions(+), 13 deletions(-) > LGTM Acked-by: Andrii Nakryiko

Re: [PATCH] selftests/bpf: Fix fill_link_info selftest on powerpc

2024-12-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Mon, 9 Dec 2024 12:27:20 +0530 you wrote: > With CONFIG_KPROBES_ON_FTRACE enabled on powerpc, ftrace_location_range > returns ftrace location for bpf_fentry_test1 at offset of 4 bytes from > function entry. This i

Re: [PATCH v3] selftests/vDSO: support DT_GNU_HASH

2024-12-09 Thread Shuah
On 12/6/24 06:07, Xi Ruoyao wrote: From: Fangrui Song glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been obsoleted for more than one decade in many Linux distributions. Many vDSOs support DT_GNU_HASH. This patch adds selftests support. Signed-off-by: Fangrui Song Tested-by: Xi

Re: [PATCH net v4 0/6] virtio_net: correct netdev_tx_reset_queue() invocation points

2024-12-09 Thread Xuan Zhuo
For the series, Reviewed-by: Xuan Zhuo Thanks On Fri, 6 Dec 2024 10:10:41 +0900, Koichiro Den wrote: > When virtnet_close is followed by virtnet_open, some TX completions can > possibly remain unconsumed, until they are finally processed during the > first NAPI poll after the netdev_tx_re

Re: [PATCH v15 3/8] remoteproc: Introduce load_fw and release_fw optional operation

2024-12-09 Thread Bjorn Andersson
On Thu, Nov 28, 2024 at 09:42:10AM GMT, Arnaud Pouliquen wrote: > This patch updates the rproc_ops structures to include two new optional > operations. > > - The load_fw() op is responsible for loading the remote processor > non-ELF firmware image before starting the boot sequence. This ops will >