Re: [PATCH v3 4/9] vhost: Add kthread support in function vhost_worker_create

2024-11-26 Thread michael . christie
On 11/5/24 1:25 AM, Cindy Lu wrote: > static struct vhost_worker *vhost_worker_create(struct vhost_dev *dev) > { > struct vhost_worker *worker; > - struct vhost_task *vtsk; > + struct vhost_task *vtsk = NULL; > + struct task_struct *task = NULL; > char name[TASK_COMM_LEN];

Re: [PATCH v6 17/18] kbuild: Add gendwarfksyms as an alternative to genksyms

2024-11-26 Thread Masahiro Yamada
On Fri, Nov 22, 2024 at 5:43 AM Sami Tolvanen wrote: > > When MODVERSIONS is enabled, allow selecting gendwarfksyms as the > implementation, but default to genksyms. > > Signed-off-by: Sami Tolvanen > --- > kernel/module/Kconfig | 25 - > scripts/Makefile | 2 +- >

Re: [PATCH net] selftests: rds: move test.py to TEST_FILES

2024-11-26 Thread Allison Henderson
On Sun, 2024-11-24 at 07:32 +, Hangbin Liu wrote: > The test.py should not be run separately. It should be run via run.sh, > which will do some sanity checks first. Move the test.py from TEST_PROGS > to TEST_FILES. This looks fine to me. Thanks for the catch! Reviewed-by: Allison Henderson

Re: [RFC PATCH 1/3] module: Split module_enable_rodata_ro()

2024-11-26 Thread Luis Chamberlain
On Sat, Nov 09, 2024 at 11:35:35AM +0100, Christophe Leroy wrote: > module_enable_rodata_ro() is called twice, once before module init > to set rodata sections readonly and once after module init to set > rodata_after_init section readonly. > > The second time, only the rodata_after_init section n

[GIT PULL] virtio: features, fixes, cleanups

2024-11-26 Thread Michael S. Tsirkin
I was hoping to get vhost threading compat fixes in but no luck. A very quiet merge cycle - I guess it's a sign we got a lot merged last time, and everyone is busy testing. Right, guys? The following changes since commit 83e445e64f48bdae3f25013e788fcf592f142576: vdpa/mlx5: Fix error path duri

Re: [linus:master] [sched, x86] 476e8583ca: WARNING:at_kernel/rcu/update.c:#torture_sched_setaffinity

2024-11-26 Thread Paul E. McKenney
On Tue, Nov 26, 2024 at 03:30:24PM +0100, Sebastian Andrzej Siewior wrote: > On 2024-11-25 22:29:09 [+0800], kernel test robot wrote: > > Hello, > Hi, > > > by this commit, we see the config has below diff: > > > > --- > > /pkg/linux/x86_64-randconfig-161-20241120/gcc-12/35772d627b55cc7fb4f33bae

[GIT PULL] remoteproc updates for v6.13

2024-11-26 Thread Bjorn Andersson
The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc: Linux 6.12-rc1 (2024-09-29 15:06:19 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git tags/rproc-v6.13 for you to fetch changes up to 44024ebf259

[PATCH] selftests: hid: fix typo and exit code

2024-11-26 Thread Maximilian Heyne
The correct exit code to mark a test as skipped is 4. Fixes: ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests") Signed-off-by: Maximilian Heyne --- .../testing/selftests/hid/run-hid-tools-tests.sh | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/

Re: [PATCH v6 01/18] tools: Add gendwarfksyms

2024-11-26 Thread Luis Chamberlain
On Tue, Nov 26, 2024 at 12:50:48PM +0900, Masahiro Yamada wrote: > On Tue, Nov 26, 2024 at 8:30 AM Luis Chamberlain wrote: > > > > On Thu, Nov 21, 2024 at 08:42:22PM +, Sami Tolvanen wrote: > > > Add a basic DWARF parser, which uses libdw to traverse the debugging > > > information in an objec

Re: [PATCH v4 0/3] selftests/lam: get_user additions and LAM enabled check

2024-11-26 Thread Shuah Khan
On 11/26/24 06:34, Maciej Wieczor-Retman wrote: Recent change in how get_user() handles pointers [1] has a specific case for LAM. It assigns a different bitmask that's later used to check whether a pointer comes from userland in get_user(). While currently commented out (until LASS [2] is merged

[GIT PULL] rpmsg updates for v6.13

2024-11-26 Thread Bjorn Andersson
The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc: Linux 6.12-rc1 (2024-09-29 15:06:19 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git tags/rpmsg-v6.13 for you to fetch changes up to 06c59d97f63

Re: [PATCH v6 00/18] Implement DWARF modversions

2024-11-26 Thread Luis Chamberlain
On Thu, Nov 21, 2024 at 08:42:21PM +, Sami Tolvanen wrote: > If you also want to test the series with actual Rust modules, this > branch adds Matt's latest modversion_info series: The merge window for v6.13 is now open so this is too late for that, so this is all work to be queued up after, so

Re: [PATCH] kmod: verify module name before invoking modprobe

2024-11-26 Thread Luis Chamberlain
On Mon, Nov 18, 2024 at 01:54:14PM +0100, Petr Pavlu wrote: > I'm however not sure about rejecting empty strings as is also done by > the patch. Consider a call to request_module("mod%s", suffix) where the > suffix could be empty to select the default variant, or non-empty to > select e.g. some opt

Re: [linus:master] [sched, x86] 476e8583ca: WARNING:at_kernel/rcu/update.c:#torture_sched_setaffinity

2024-11-26 Thread Sebastian Andrzej Siewior
On 2024-11-25 22:29:09 [+0800], kernel test robot wrote: > Hello, Hi, > by this commit, we see the config has below diff: > > --- > /pkg/linux/x86_64-randconfig-161-20241120/gcc-12/35772d627b55cc7fb4f33bae57c564a25b3121a9/.config >2024-11-22 17:03:32.458344665 +0800 > +++ > /pkg/linux/x86_6

Re: [PATCH v3 4/9] vhost: Add kthread support in function vhost_worker_create

2024-11-26 Thread Cindy Lu
On Wed, Nov 27, 2024 at 5:20 AM wrote: > > On 11/5/24 1:25 AM, Cindy Lu wrote: > > static struct vhost_worker *vhost_worker_create(struct vhost_dev *dev) > > { > > struct vhost_worker *worker; > > - struct vhost_task *vtsk; > > + struct vhost_task *vtsk = NULL; > > + struct tas

Re: [PATCH v3 3/9] vhost: Add the cgroup related function

2024-11-26 Thread Cindy Lu
On Mon, Nov 25, 2024 at 11:22 PM Mike Christie wrote: > > On 11/5/24 1:25 AM, Cindy Lu wrote: > > +static int vhost_attach_cgroups(struct vhost_dev *dev) > > +{ > > + struct vhost_worker *worker; > > + unsigned long i; > > + int ret; > > + > > + /* > > + * Free the default wor

[GIT PULL] Modules changes for v6.13-rc1

2024-11-26 Thread Luis Chamberlain
The following changes since commit 8e929cb546ee42c9a61d24fae60605e9e3192354: Linux 6.12-rc3 (2024-10-13 14:33:32 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/modules/linux.git/ tags/modules-6.13-rc1 for you to fetch changes up to 2466b3120142

Re: [PATCH] virtio_net: drain unconsumed tx completions if any before dql_reset

2024-11-26 Thread Jason Wang
On Tue, Nov 26, 2024 at 12:44 PM Koichiro Den wrote: > > On Tue, Nov 26, 2024 at 11:50:17AM +0800, Jason Wang wrote: > > On Tue, Nov 26, 2024 at 10:42 AM Koichiro Den > > wrote: > > > > > > When virtnet_close is followed by virtnet_open, there is a slight chance > > > that some TX completions rem

Re: [PATCH] virtio_net: drain unconsumed tx completions if any before dql_reset

2024-11-26 Thread Koichiro Den
On Wed, Nov 27, 2024 at 11:24:15AM +0800, Jason Wang wrote: > On Tue, Nov 26, 2024 at 12:44 PM Koichiro Den > wrote: > > > > On Tue, Nov 26, 2024 at 11:50:17AM +0800, Jason Wang wrote: > > > On Tue, Nov 26, 2024 at 10:42 AM Koichiro Den > > > wrote: > > > > > > > > When virtnet_close is followed

Re: [PATCH net-next v11 09/23] ovpn: implement basic RX path (UDP)

2024-11-26 Thread Antonio Quartulli
On 26/11/2024 09:49, Antonio Quartulli wrote: [...] The potential issue is tricky since we create it patch-by-patch. Up to this patch the socket releasing procedure looks solid and reliable. E.g. the P2P netdev destroying:    ovpn_netdev_notifier_call(NETDEV_UNREGISTER) ovpn_peer_releas

Re: [GIT PULL] rpmsg updates for v6.13

2024-11-26 Thread pr-tracker-bot
The pull request you sent on Tue, 26 Nov 2024 08:10:05 -0800: > https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git > tags/rpmsg-v6.13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/aaf20f870da056752f6386693cc0d8e25421ef35 Thank you! -- Deet-doot-d

Re: [GIT PULL] remoteproc updates for v6.13

2024-11-26 Thread pr-tracker-bot
The pull request you sent on Tue, 26 Nov 2024 08:05:20 -0800: > https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git > tags/rproc-v6.13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/08906abc8c6e3a64f7d02965b657a3c6c159cd96 Thank you! -- Deet-doot-d

[PATCH v14 2/8] remoteproc: Add TEE support

2024-11-26 Thread Arnaud Pouliquen
Add a remoteproc TEE (Trusted Execution Environment) driver that will be probed by the TEE bus. If the associated Trusted application is supported on secure part this driver offers a client interface to load a firmware by the secure part. This firmware could be authenticated by the secure trusted a

[PATCH v14 3/8] remoteproc: Introduce load_fw and release_fw optional operation

2024-11-26 Thread Arnaud Pouliquen
This patch updates the rproc_ops structures to include two new optional operations. - The load_fw() op is responsible for loading the remote processor non-ELF firmware image before starting the boot sequence. This ops will be used, for instance, to call OP-TEE to authenticate an load the firmware

[PATCH v14 1/8] remoteproc: core: Introduce rproc_pa_to_va helper

2024-11-26 Thread Arnaud Pouliquen
When a resource table is loaded by an external entity such as U-boot or OP-TEE, we do not necessarily get the device address(da) but the physical address(pa). This helper performs similar translation than the rproc_da_to_va() but based on a physical address. Signed-off-by: Arnaud Pouliquen --- d

[PATCH v14 6/8] dt-bindings: remoteproc: Add compatibility for TEE support

2024-11-26 Thread Arnaud Pouliquen
The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration where the Cortex-M4 firmware is loaded by the Trusted Execution Environment (TEE). For instance, this compatible is used in both the Linux and OP-TEE device trees: - In OP-TEE, a node is defined in the device tree with the

[PATCH v14 7/8] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-11-26 Thread Arnaud Pouliquen
To prepare for the support of TEE remoteproc, create sub-functions that can be used in both cases, with and without remoteproc TEE support. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 82 +++- 1 file changed, 49 insertions(+), 33 deletions(-

[PATCH v14 5/8] remoteproc: Make load_segments and load_fw ops exclusive and optional

2024-11-26 Thread Arnaud Pouliquen
The two methods to load the firmware to memory should be exclusive. - make load_segments optional returning 0 if not set in rproc_load_segments(), - ensure that load_segments() and load_fw() are not both set, - do not set default rproc::ops fields if load_fw() is set. Signed-off-by: Arnaud Poul

[PATCH v14 8/8] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-11-26 Thread Arnaud Pouliquen
The new TEE remoteproc driver is used to manage remote firmware in a secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is introduced to delegate the loading of the firmware to the trusted execution context. In such cases, the firmware should be signed and adhere to the image format de

[PATCH v14 4/8] remoteproc: Rename load() operation to load_segments() in rproc_ops struct

2024-11-26 Thread Arnaud Pouliquen
With the introduction of the load_fw() operation in the rproc_ops structure, we need to clarify the difference in the use of the load() and load_fw() ops. The legacy load() is dedicated to loading the ELF segments into memory. Rename this to a more explicit name: load_segments(). Suggested-by: Ma

[PATCH v14 0/8] Introduction of a remoteproc tee to load signed firmware

2024-11-26 Thread Arnaud Pouliquen
Main updates from version V13[1]: - Introduce new rproc_ops operation: load_fw() and release_fw(), - Rename load() operation to load_segments() in rproc_ops structure and drivers. More details are available in each patch commit message. [1] https://lore.kernel.org/linux-arm-kernel/202411041335

Re: [PATCH net-next v11 05/23] ovpn: keep carrier always on

2024-11-26 Thread Antonio Quartulli
On 25/11/2024 22:32, Sergey Ryazanov wrote: [...] FTR, here is the text in the manpage:     --persist-tun    Don't close and reopen TUN/TAP device or run up/down scripts across SIGUSR1 or --ping-restart restarts.    SIGUSR1 is a restart signal similar to SIGHUP, bu

Re: [PATCH net-next v11 12/23] ovpn: implement TCP transport

2024-11-26 Thread Antonio Quartulli
On 26/11/2024 02:05, Sergey Ryazanov wrote: Hi Antonio, the question was addressed to Sabrina, but since I've already touched this topic in the another patch, let me put my 2c here. On 16.11.2024 02:33, Antonio Quartulli wrote: On 31/10/2024 16:25, Sabrina Dubroca wrote: 2024-10-29, 11:47:2

Re: [PATCH net-next v11 09/23] ovpn: implement basic RX path (UDP)

2024-11-26 Thread Antonio Quartulli
On 26/11/2024 01:32, Sergey Ryazanov wrote: On 15.11.2024 17:02, Antonio Quartulli wrote: On 11/11/2024 02:54, Sergey Ryazanov wrote: [...] +/* Called after decrypt to write the IP packet to the device. + * This method is expected to manage/free the skb. + */ +static void ovpn_netdev_write(str

[PATCH v2] selftests: Warn about skipped tests in result summary

2024-11-26 Thread Laura Nao
Update the functions that print the test totals at the end of a selftest to include a warning message when skipped tests are detected. The message advises users that skipped tests may indicate missing configuration options and suggests enabling them to improve coverage. Signed-off-by: Laura Nao -

Re: [PATCHv2 net 0/2] ipv6: fix temporary address not removed correctly

2024-11-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni : On Wed, 20 Nov 2024 09:51:06 + you wrote: > Currently the temporary address is not removed when mngtmpaddr is deleted > or becomes unmanaged. The patch set fixed this issue and add a related > test. > > v2: > 1) delete

Re: [PATCH printk v1] printk: ringbuffer: Add KUnit test

2024-11-26 Thread Petr Mladek
On Thu 2024-11-21 15:56:34, John Ogness wrote: > From: Thomas Weißschuh > > The KUnit test validates the correct operation of the ringbuffer. > A separate dedicated ringbuffer is used so that the global printk > ringbuffer is not touched. Thanks a lot for upstreaming this test! > --- a/init/Kco

Re: [PATCH bpf-next v3 00/14] selftests/bpf: migrate test_flow_dissector.sh to test_progs

2024-11-26 Thread Alexis Lothoré
Hello, On 11/25/24 23:10, patchwork-bot+netdev...@kernel.org wrote: > Hello: > > This series was applied to bpf/bpf-next.git (master) > by Alexei Starovoitov : It may have slipped through when I mentioned the issue a few months ago, but for the record, I am not able to receive the automated mail

Re: [PATCH livepatch/master v1 1/2] selftests/livepatch: Replace hardcoded path with variable in test-syscall.sh

2024-11-26 Thread Petr Mladek
On Mon 2024-11-25 19:28:11, George Guo wrote: > From: George Guo > > Updated test-syscall.sh to replace the path > /sys/kernel/test_klp_syscall/npids with a variable $MOD_SYSCALL. > > Signed-off-by: George Guo This has already been fixed by the commit 59766286b6e54f8ad33 ("selftests: livepatc

Re: [PATCH livepatch/master v1 2/2] selftests/livepatch: Replace hardcoded module name with variable in test-callbacks.sh

2024-11-26 Thread Petr Mladek
On Mon 2024-11-25 19:28:12, George Guo wrote: > From: George Guo > > Replaced the hardcoded module name test_klp_callbacks_demo in the > pre_patch_callback log message with the variable $MOD_LIVEPATCH. > > Signed-off-by: George Guo Reviewed-by: Petr Mladek Best Regards, Petr

[PATCH v4 1/3] selftests/lam: Move cpu_has_la57() to use cpuinfo flag

2024-11-26 Thread Maciej Wieczor-Retman
In current form cpu_has_la57() reports platform's support for LA57 through reading the output of cpuid. A much more useful information is whether 5-level paging is actually enabled on the running system. Presence of the la57 flag in /proc/cpuinfo signifies that 5-level paging was compiled into the

Re: [PATCH v6 01/18] tools: Add gendwarfksyms

2024-11-26 Thread Masahiro Yamada
On Fri, Nov 22, 2024 at 5:42 AM Sami Tolvanen wrote: > > Add a basic DWARF parser, which uses libdw to traverse the debugging > information in an object file and looks for functions and variables. > In follow-up patches, this will be expanded to produce symbol versions > for CONFIG_MODVERSIONS fro

[PATCH v4 3/3] selftests/lam: Test get_user() LAM pointer handling

2024-11-26 Thread Maciej Wieczor-Retman
Recent change in how get_user() handles pointers [1] has a specific case for LAM. It assigns a different bitmask that's later used to check whether a pointer comes from userland in get_user(). Add test case to LAM that utilizes a ioctl (FIOASYNC) syscall which uses get_user() in its implementation

[PATCH v4 2/3] selftests/lam: Skip test if LAM is disabled

2024-11-26 Thread Maciej Wieczor-Retman
Until LASS is merged into the kernel [1], LAM is left disabled in the config file. Running the LAM selftest with disabled LAM only results in unhelpful output. Use one of LAM syscalls() to determine whether the kernel was compiled with LAM support (CONFIG_ADDRESS_MASKING) or not. Skip running the

[PATCH v4 0/3] selftests/lam: get_user additions and LAM enabled check

2024-11-26 Thread Maciej Wieczor-Retman
Recent change in how get_user() handles pointers [1] has a specific case for LAM. It assigns a different bitmask that's later used to check whether a pointer comes from userland in get_user(). While currently commented out (until LASS [2] is merged into the kernel) it's worth making changes to the