Re: [PATCH net-next v11 15/23] ovpn: implement keepalive mechanism

2024-11-22 Thread Antonio Quartulli
On 12/11/2024 14:20, Antonio Quartulli wrote: [...] +static int ovpn_peer_del_nolock(struct ovpn_peer *peer, +    enum ovpn_del_peer_reason reason) +{ +    switch (peer->ovpn->mode) { +    case OVPN_MODE_MP: I think it would be nice to add lockdep_assert_held(&peer->ovpn->peer

[PATCH v3] selftests/lam: Test get_user() LAM pointer handling

2024-11-22 Thread Maciej Wieczor-Retman
Recent change in how get_user() handles pointers [1] has a specific case for LAM. It assigns a different bitmask that's later used to check whether a pointer comes from userland in get_user(). While currently commented out (until LASS [2] is merged into the kernel) it's worth making changes to the

[PATCH 1/2] dt-bindings: remoteproc: Add SM8750 MPSS and CDSP

2024-11-22 Thread Krzysztof Kozlowski
Add remote processor PAS loaders for SM8750 MPSS (modem) and CDSP processors. Both are compatible with earlier SM8650 with minor differences: 1. SM8750 CDSP has one more sixth shutdown interrupt. 2. SM8750 MPSS lacks fifth memory region for Qlink Logging, according to downstream sources. There

[PATCH 2/2] remoteproc: qcom: pas: Add SM8750 MPSS

2024-11-22 Thread Krzysztof Kozlowski
Add remote processor PAS loaders for SM8750 MPSS (modem), which differs from SM8650 by lack of fifth memory region for Qlink Logging. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/qcom_q6v5_pas.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/r

Re: [PATCH] kasan: Remove kasan_record_aux_stack_noalloc().

2024-11-22 Thread Sebastian Andrzej Siewior
On 2024-11-19 20:36:56 [+0100], Andrey Konovalov wrote: > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > index 6310a180278b6..b18b5944997f8 100644 > > --- a/mm/kasan/generic.c > > +++ b/mm/kasan/generic.c > > @@ -521,7 +521,7 @@ size_t kasan_metadata_size(struct kmem_cache *cache, > >

Re: [PATCH net-next v3] af_unix: pass pidfd flags via SCM_PIDFD cmsg

2024-11-22 Thread Christian Brauner
On Thu, Nov 21, 2024 at 01:57:32PM +0100, Alexander Mikhalitsyn wrote: > >Currently SCM_PIDFD cmsg cannot be sent via unix socket > >(returns -EINVAL) and SO_PASSPIDFD doesn't support flags. > >The created pidfd always has flags set to 0. > > > >This patch implements SCM_PIDFD cmsg in AF_UNIX socke

Re: [PATCH v2 net] ipvs: fix UB due to uninitialized stack access in ip_vs_protocol_init()

2024-11-22 Thread Julian Anastasov
Hello, On Thu, 21 Nov 2024, Jinghao Jia wrote: > Under certain kernel configurations when building with Clang/LLVM, the > compiler does not generate a return or jump as the terminator > instruction for ip_vs_protocol_init(), triggering the following objtool > warning during build time:

Re: [PATCH for-next v3] selftests/cpufreq: gitignore output files and clean them in make clean

2024-11-22 Thread Viresh Kumar
On 22-11-24, 15:47, Li Zhijian wrote: > After `make run_tests`, the git status complains: > Untracked files: > (use "git add ..." to include in what will be committed) > cpufreq/cpufreq_selftest.dmesg_cpufreq.txt > cpufreq/cpufreq_selftest.dmesg_full.txt > cpufreq/cpufre

Re: [PATCH net-next v11 07/23] ovpn: introduce the ovpn_socket object

2024-11-22 Thread Sergey Ryazanov
On November 21, 2024 11:36:19 PM, Antonio Quartulli wrote: >On 21/11/2024 00:58, Sergey Ryazanov wrote: >> On 15.11.2024 16:28, Antonio Quartulli wrote: >>> On 10/11/2024 19:26, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: >> >> [...] >> > +static bool ovpn_socke

Re: [PATCH v3] selftests/lam: Test get_user() LAM pointer handling

2024-11-22 Thread Maciej Wieczor-Retman
On 2024-11-22 at 11:13:44 +0200, Kirill A. Shutemov wrote: >On Fri, Nov 22, 2024 at 09:55:20AM +0100, Maciej Wieczor-Retman wrote: >> Recent change in how get_user() handles pointers [1] has a specific case >> for LAM. It assigns a different bitmask that's later used to check >> whether a pointer c

Re: [PATCH v3] selftests/lam: Test get_user() LAM pointer handling

2024-11-22 Thread Kirill A. Shutemov
On Fri, Nov 22, 2024 at 09:55:20AM +0100, Maciej Wieczor-Retman wrote: > Recent change in how get_user() handles pointers [1] has a specific case > for LAM. It assigns a different bitmask that's later used to check > whether a pointer comes from userland in get_user(). > > While currently commente

Re: [PATCH v2 09/13] media: i2c: imx214: Extract format and crop settings

2024-11-22 Thread Sakari Ailus
Hi Ricardo, On Wed, Nov 20, 2024 at 10:22:54PM +0100, Ricardo Ribalda Delgado wrote: > Hi André > > On Wed, Nov 20, 2024 at 9:07 PM André Apitzsch wrote: > > > > Hi Ricardo, > > > > Am Mittwoch, dem 30.10.2024 um 13:10 +0100 schrieb Ricardo Ribalda > > Delgado: > > > Hi > > > > > > Aren't you ch

[PATCH] remoteproc: core: Fix ida_free call while not allocated

2024-11-22 Thread Arnaud Pouliquen
In the rproc_alloc() function, on error, put_device(&rproc->dev) is called, leading to the call of the rproc_type_release() function. An error can occurs before ida_alloc is called. In such case in rproc_type_release(), the condition (rproc->index >= 0) is true as rproc->index has been initialize

Re: [PATCH] selftest: drivers: Add support to check duplicate hwirq

2024-11-22 Thread Bjorn Helgaas
On Mon, Nov 11, 2024 at 03:21:36PM +0800, Joseph Jang wrote: > On 2024/10/19 3:34 AM, Bjorn Helgaas wrote: > > On Tue, Sep 03, 2024 at 06:44:26PM -0700, Joseph Jang wrote: > > > Validate there are no duplicate hwirq from the irq debug > > > file system /sys/kernel/debug/irq/irqs/* per chip name. >

Re: [PATCH] selftests: Warn about skipped tests in result summary

2024-11-22 Thread Shuah
On 11/22/24 08:55, Laura Nao wrote: Update the functions that print the test totals at the end of a selftest to include a warning message when skipped tests are detected. The message advises users that skipped tests may indicate missing configuration options and suggests enabling them to improve

[GIT PULL] NVDIMM and DAX for 6.13

2024-11-22 Thread Ira Weiny
Hi Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git tags/libnvdimm-for-6.13 Changes for the nvdimm tree. Most represent minor cleanups and code removals. One patch fixes potential NULL pointer arithmetic which was benign because the offset of the member

Re: [PATCH printk v1] printk: ringbuffer: Add KUnit test

2024-11-22 Thread kernel test robot
Hi John, kernel test robot noticed the following build errors: [auto build test ERROR on rust/rust-next] [also build test ERROR on linus/master v6.12 next-20241122] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH kselftest] fix single bpf test

2024-11-22 Thread Shuah Khan
On 11/18/24 07:06, Jiayuan Chen wrote: Currently, when testing a certain target in selftests, executing the command 'make TARGETS=XX -C tools/testing/selftests' succeeds for non-BPF, but a similar command fails for BPF: ''' make TARGETS=bpf -C tools/testing/selftests make: Entering directory '/l

Re: [GIT PULL] KUnit update for Linux 6.13-rc1-fixed

2024-11-22 Thread pr-tracker-bot
The pull request you sent on Thu, 21 Nov 2024 17:54:55 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest > tags/linux_kselftest-kunit-6.13-rc1-fixed has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e288c352a4a5716babf2edad4cba10ec6002a20a Tha

Re: [PATCH net] selftests: rds: move include.sh to TEST_FILES

2024-11-22 Thread Hangbin Liu
On Fri, Nov 22, 2024 at 03:01:29PM +, Maximilian Heyne wrote: > Hi Hangbin, > > On Fri, Sep 27, 2024 at 12:13:49PM +0800, Hangbin Liu wrote: > > The include.sh file is generated for inclusion and should not be executable. > > Otherwise, it will be added to kselftest-list.txt. Additionally, add

Re: [PATCH for-next v3] selftests/mm: Add a few missing gitignore files

2024-11-22 Thread John Hubbard
On 11/21/24 11:46 PM, Li Zhijian wrote: Compiled binary files should be added to .gitignore 'git status' complains: Untracked files: (use "git add ..." to include in what will be committed) mm/hugetlb_dio mm/pkey_sighandler_tests_32 mm/pkey_sighandler_tests_6

Re: [PATCH] kasan: Remove kasan_record_aux_stack_noalloc().

2024-11-22 Thread Sebastian Andrzej Siewior
On 2024-11-22 16:01:29 [+0100], Marco Elver wrote: > > Do we need to update the comment saying that it must not be used from > > NMI or do we make it jump over the locked section in the NMI case? > > Good point. It was meant to also be usable from NMI, because it's very > likely to succeed, and sh

Re: [PATCH printk v1] printk: ringbuffer: Add KUnit test

2024-11-22 Thread John Ogness
Hi David, On 2024-11-22, David Gow wrote: > It's a little unusual for a KUnit test -- particularly since it is > time-based and uses lots of threads. This isn't a problem, but it's > definitely a good thing that it's marked as slow. Additionally, KUnit > doesn't track any extra threads spawned, s

Re: [PATCH] kasan: Remove kasan_record_aux_stack_noalloc().

2024-11-22 Thread Marco Elver
On Fri, Nov 22, 2024 at 12:32PM +0100, Sebastian Andrzej Siewior wrote: > On 2024-11-19 20:36:56 [+0100], Andrey Konovalov wrote: > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > index 6310a180278b6..b18b5944997f8 100644 > > > --- a/mm/kasan/generic.c > > > +++ b/mm/kasan/generic.c

Re: [PATCH net] selftests: rds: move include.sh to TEST_FILES

2024-11-22 Thread Maximilian Heyne
Hi Hangbin, On Fri, Sep 27, 2024 at 12:13:49PM +0800, Hangbin Liu wrote: > The include.sh file is generated for inclusion and should not be executable. > Otherwise, it will be added to kselftest-list.txt. Additionally, add the > executable bit for test.py at the same time to ensure proper function

Re: [PATCH net-next v11 15/23] ovpn: implement keepalive mechanism

2024-11-22 Thread Sabrina Dubroca
2024-11-22, 10:41:26 +0100, Antonio Quartulli wrote: > On 12/11/2024 14:20, Antonio Quartulli wrote: > [...] > > > > +static int ovpn_peer_del_nolock(struct ovpn_peer *peer, > > > > +    enum ovpn_del_peer_reason reason) > > > > +{ > > > > +    switch (peer->ovpn->mode) { > > > > +    c

[PATCH v2] kasan: Make kasan_record_aux_stack_noalloc() the default behaviour

2024-11-22 Thread Sebastian Andrzej Siewior
From: Peter Zijlstra kasan_record_aux_stack_noalloc() was introduced to record a stack trace without allocating memory in the process. It has been added to callers which were invoked while a raw_spinlock_t was held. More and more callers were identified and changed over time. Is it a good thing t

[PATCH] selftests: Warn about skipped tests in result summary

2024-11-22 Thread Laura Nao
Update the functions that print the test totals at the end of a selftest to include a warning message when skipped tests are detected. The message advises users that skipped tests may indicate missing configuration options and suggests enabling them to improve coverage. Signed-off-by: Laura Nao -

Re: [PATCH v2 net] ipvs: fix UB due to uninitialized stack access in ip_vs_protocol_init()

2024-11-22 Thread Jinghao Jia
Hi Julian, On 11/22/24 5:43 AM, Julian Anastasov wrote: > > Hello, > > On Thu, 21 Nov 2024, Jinghao Jia wrote: > >> Under certain kernel configurations when building with Clang/LLVM, the >> compiler does not generate a return or jump as the terminator >> instruction for ip_vs_protocol_ini

Re: [PATCH v2] kasan: Make kasan_record_aux_stack_noalloc() the default behaviour

2024-11-22 Thread Waiman Long
On 11/22/24 10:54 AM, Sebastian Andrzej Siewior wrote: From: Peter Zijlstra kasan_record_aux_stack_noalloc() was introduced to record a stack trace without allocating memory in the process. It has been added to callers which were invoked while a raw_spinlock_t was held. More and more callers we