Re: [PATCH v1] selftests/bpf: fix application of sizeof to pointer

2024-11-18 Thread Cong Wang
On Sun, Nov 17, 2024 at 11:18:38AM +0800, guanjing wrote: > sizeof when applied to a pointer typed expression gives the size of > the pointer. > > tools/testing/selftests/bpf/progs/test_tunnel_kern.c:678:41-47: ERROR: > application of sizeof to pointer > > The proper fix in this particular case

Re: [PATCH bpf v4 0/2] bpf: fix recursive lock and add test

2024-11-18 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 18 Nov 2024 11:09:08 +0800 you wrote: > 1. fix recursive lock when ebpf prog return SK_PASS. > 2. add selftest to reproduce recursive lock. > > Note that the test code can reproduce the 'dead-lock' and if just >

Re: [PATCH v2] kunit: string-stream: Fix a UAF bug in kunit_init_suite()

2024-11-18 Thread Kuan-Wei Chiu
On Tue, Nov 12, 2024 at 04:03:14PM +0800, Jinjie Ruan wrote: > In kunit_debugfs_create_suite(), if alloc_string_stream() fails in the > kunit_suite_for_each_test_case() loop, the "suite->log = stream" > has assigned before, and the error path only free the suite->log's stream > memory but not set i

Re: [PATCH] ipvs: fix UB due to uninitialized stack access in ip_vs_protocol_init()

2024-11-18 Thread Jinghao Jia
Hi Julian, Thanks for getting back to us! On 11/18/24 6:41 AM, Julian Anastasov wrote: > > Hello, > > On Mon, 11 Nov 2024, Jinghao Jia wrote: > >> Under certain kernel configurations when building with Clang/LLVM, the >> compiler does not generate a return or jump as the terminator >> in

[PATCH] vduse: relicense under GPL-2.0 OR BSD-3-Clause

2024-11-18 Thread Yongji Xie
Dual-license the vduse kernel header file to dual GPL-2.0 OR BSD-3-Clause license to make it possible to ship it with DPDK (under BSD-3-Clause) for older distros. Signed-off-by: Yongji Xie --- include/uapi/linux/vduse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/

[PATCH v1] selftests: mm: Fix conversion specifiers in transact_test()

2024-11-18 Thread guanjing
Lots of incorrect conversion specifiers. Fix them. Fixes: 46fd75d4a3c9 ("selftests: mm: add pagemap ioctl tests") Signed-off-by: guanjing --- tools/testing/selftests/mm/pagemap_ioctl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/mm/pagem

Re: [PATCH v2] kunit: string-stream: Fix a UAF bug in kunit_init_suite()

2024-11-18 Thread David Gow
On Tue, 12 Nov 2024 at 16:03, 'Jinjie Ruan' via KUnit Development wrote: > > In kunit_debugfs_create_suite(), if alloc_string_stream() fails in the > kunit_suite_for_each_test_case() loop, the "suite->log = stream" > has assigned before, and the error path only free the suite->log's stream > memor

Re: [PATCHv2 net-next] selftests: wireguards: use nft by default

2024-11-18 Thread Hangbin Liu
On Sun, Nov 17, 2024 at 09:09:00PM +0100, Jason A. Donenfeld wrote: > On Mon, Nov 11, 2024 at 04:19:02AM +, Hangbin Liu wrote: > > Use nft by default if it's supported, as nft is the replacement for > > iptables, > > which is used by default in some releases. Additionally, iptables is dropped

[GIT PULL] Kselftest update for Linux 6.13-rc1

2024-11-18 Thread Shuah Khan
Hi Linus, Please pull the following kselftest fixes update for Linux 6.13-rc1. kselftest update for Linux 6.13-rc1 -- timers test - removes duplicates defines -- timers test - fixes to improve error reporting -- rtc test - adds check rtc alarm status to alarm test -- resctrl test - adds array o

Re: [PATCH v5 2/2] module: Block a module by TUXEDO from accessing GPL symbols

2024-11-18 Thread Luis Chamberlain
On Mon, Nov 18, 2024 at 11:10:28AM +0100, Werner Sembach wrote: > Hi, > > Am 15.11.24 um 19:50 schrieb Werner Sembach: > > From: Uwe Kleine-König > > > > TUXEDO has not yet relicensed a module for GPLv2+ as a reply from former > > contributers the committed code under GPLv3+ is awaited. > > > >

Re: [PATCH v5 2/2] module: Block a module by TUXEDO from accessing GPL symbols

2024-11-18 Thread Greg Kroah-Hartman
On Mon, Nov 18, 2024 at 10:05:27AM +0100, Daniel Gomez wrote: > Thomas, Greg, are we using any specific SPDX version for kernel license > identifiers? Why the new identifiers where amended as valid and not > replacing [2] the old ones? Was it to avoid replacing all files with the > old id? Yes it

[PATCH] media: i2c: imx412: Add missing newline to prints

2024-11-18 Thread Luca Weiss
14 +1222,14 @@ static int imx412_probe(struct i2c_client *client) imx412->pad.flags = MEDIA_PAD_FL_SOURCE; ret = media_entity_pads_init(&imx412->sd.entity, 1, &imx412->pad); if (ret) { - dev_err(imx412->dev, "failed to init entity pads: %d", ret); + dev_err(imx412->dev, "failed to init entity pads: %d\n", ret); goto error_handler_free; } ret = v4l2_async_register_subdev_sensor(&imx412->sd); if (ret < 0) { dev_err(imx412->dev, - "failed to register async subdev: %d", ret); + "failed to register async subdev: %d\n", ret); goto error_media_entity; } --- base-commit: ae58226b89ac0cffa05ba7357733776542e40216 change-id: 20241118-imx412-newlines-3b0321da960d Best regards, -- Luca Weiss

Re: [PATCH RFC 6/6] mm, slub: sheaf prefilling for guaranteed allocations

2024-11-18 Thread Hyeonggon Yoo
On Wed, Nov 13, 2024 at 1:39 AM Vlastimil Babka wrote: > > Add three functions for efficient guaranteed allocations in a critical > section (that cannot sleep) when the exact number of allocations is not > known beforehand, but an upper limit can be calculated. > > kmem_cache_prefill_sheaf() retur

Re: [PATCH] kvm: hardware_disable_test: remove unused macro

2024-11-18 Thread Sean Christopherson
On Mon, Nov 18, 2024, Ba Jing wrote: > After reviewing the code, it was found that the macro GUEST_CODE_PIO_PORT > is never referenced in the code. Just remove it. > > Signed-off-by: Ba Jing > --- > tools/testing/selftests/kvm/hardware_disable_test.c | 1 - > 1 file changed, 1 deletion(-) > > d

Re: [PATCH net-next] selftests: net/psock_lib: Handle EINTR and EAGAIN

2024-11-18 Thread Willem de Bruijn
Leo Stone wrote: > Make pair_udp_send_char handle EAGAIN, EINTR, and partial reads or > writes. > > Signed-off-by: Leo Stone Did you observe actual issues or is this based on the comment in the existing code ("Should really handle EINTR and EAGAIN"). AFAIK all the users of psock_lib use default

Re: [PATCH v6 3/3] vsock/test: verify socket options after setting them

2024-11-18 Thread Konstantin Shkolnyy
On 11/14/2024 04:28, Stefano Garzarella wrote: On Wed, Nov 13, 2024 at 08:35:57AM -0600, Konstantin Shkolnyy wrote: [...] diff --git a/tools/testing/vsock/msg_zerocopy_common.c b/tools/ testing/vsock/msg_zerocopy_common.c index 5a4bdf7b5132..8622e5a0f8b7 100644 --- a/tools/testing/vsock/msg_ze

Re: [PATCH RFC 6/6] mm, slub: sheaf prefilling for guaranteed allocations

2024-11-18 Thread Vlastimil Babka
On 11/18/24 14:13, Hyeonggon Yoo wrote: > On Wed, Nov 13, 2024 at 1:39 AM Vlastimil Babka wrote: >> + >> +/* >> + * Allocate from a sheaf obtained by kmem_cache_prefill_sheaf() >> + * >> + * Guaranteed not to fail as many allocations as was the requested count. >> + * After the sheaf is emptied, i

[GIT PULL] KUnit update for Linux 6.13-rc1

2024-11-18 Thread Shuah Khan
Hi Linus, Please pull the following kunit update for Linux 6.13-rc1. kunit update for Linux 6.13-rc1 -- fixes user-after-free (UAF) bug in kunit_init_suite() -- adds option to kunit tool to print just the summary of test results -- adds option to kunit tool to print just the failed test resul

Re: [PATCH] vsock/virtio: Remove queued_replies pushback logic

2024-11-18 Thread Stefano Garzarella
On Fri, Nov 15, 2024 at 4:49 PM Alexander Graf wrote: > > Hi Stefano, > > On 15.11.24 12:59, Stefano Garzarella wrote: > > > > On Fri, Nov 15, 2024 at 10:30:16AM +, Alexander Graf wrote: > >> Ever since the introduction of the virtio vsock driver, it included > >> pushback logic that blocks it

[PATCH kselftest] fix single bpf test

2024-11-18 Thread Jiayuan Chen
Currently, when testing a certain target in selftests, executing the command 'make TARGETS=XX -C tools/testing/selftests' succeeds for non-BPF, but a similar command fails for BPF: ''' make TARGETS=bpf -C tools/testing/selftests make: Entering directory '/linux-kselftest/tools/testing/selftests' m

Re: [PATCH] selftests/bpf: Remove unused variable

2024-11-18 Thread Yonghong Song
On 11/18/24 1:34 AM, Zhu Jun wrote: the variable is never referenced in the code, just remove them. Signed-off-by: Zhu Jun --- tools/testing/selftests/bpf/prog_tests/log_buf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/log_buf.c b/tools/t

Re: [PATCH net-next] mm: page_frag: fix a compile error when kernel is not compiled

2024-11-18 Thread Mark Brown
On Sat, Nov 16, 2024 at 12:23:13PM +0800, Yunsheng Lin wrote: > page_frag test module is an out of tree module, but built > using KDIR as the main kernel tree, the mm test suite is > just getting skipped if newly added page_frag test module > fails to compile due to kernel not yet compiled. > > Fi

Re: [PATCH net-next v11 03/23] ovpn: add basic netlink support

2024-11-18 Thread Sergey Ryazanov
On 15.11.2024 12:05, Antonio Quartulli wrote: On 09/11/2024 00:15, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: @@ -37,7 +41,7 @@ static int ovpn_newlink(struct net *src_net, struct net_device *dev,   }   static struct rtnl_link_ops ovpn_link_ops = { -    .kind = "ovpn"

[ANNOUNCE] 5.10.226-rt118

2024-11-18 Thread Luis Claudio R. Goncalves
Hello RT-list! I'm pleased to announce the 5.10.226-rt118 stable release. This release is just an update to the new stable 5.10.226 version and no RT changes have been made. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git b

[PATCH net-next v2] mm: page_frag: fix a compile error when kernel is not compiled

2024-11-18 Thread Yunsheng Lin
page_frag test module is an out of tree module, but built using KDIR as the main kernel tree, the mm test suite is just getting skipped if newly added page_frag test module fails to compile due to kernel not yet compiled. Fix the above problem by ensuring both kernel is built first and a newer ker

Re: [PATCH net-next] mm: page_frag: fix a compile error when kernel is not compiled

2024-11-18 Thread Jakub Kicinski
On Sat, 16 Nov 2024 13:02:38 +0800 Yunsheng Lin wrote: > It seemed that somehow I missed to add the netdev ML:( Then repost, please.

Re: [GIT PULL] KUnit update for Linux 6.13-rc1

2024-11-18 Thread Kuan-Wei Chiu
Hi Shuah, On Mon, Nov 18, 2024 at 12:19:50PM -0700, Shuah Khan wrote: > Hi Linus, > > Please pull the following kunit update for Linux 6.13-rc1. > > kunit update for Linux 6.13-rc1 > > -- fixes user-after-free (UAF) bug in kunit_init_suite() > > -- adds option to kunit tool to print just the s

Re: [PATCH net-next v11 04/23] ovpn: add basic interface creation/destruction/management routines

2024-11-18 Thread Sergey Ryazanov
On 15.11.2024 16:03, Antonio Quartulli wrote: On 10/11/2024 21:42, Sergey Ryazanov wrote: Missed the most essential note regarding this patch :) On 29.10.2024 12:47, Antonio Quartulli wrote: +static int ovpn_net_open(struct net_device *dev) +{ +    netif_tx_start_all_queues(dev); +    return 0

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-18 Thread Luis Chamberlain
On Mon, Nov 18, 2024 at 04:09:34PM -0800, Matthew Maurer wrote: > > Thinking about this some more, if we're going down enabling a new > > option, it seems to beg the question if the old *two* ksymtab sections > > could just be folded into the a new one where the "gpl only" thing > > becomes just on

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-18 Thread Matthew Maurer
> Thinking about this some more, if we're going down enabling a new > option, it seems to beg the question if the old *two* ksymtab sections > could just be folded into the a new one where the "gpl only" thing > becomes just one "column" as you call it. Reasons I ask, it seems like > we're duplicat

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-18 Thread Luis Chamberlain
On Thu, Nov 07, 2024 at 02:38:13PM -0800, Luis Chamberlain wrote: > The only thing left I think to test is the impact at runtime, and the > only thing I can think of is first we use find_symbol() on resolve_symbol() > which it took me a while to review and realize that this just uses a > completel

Re: [PATCH net-next v11 03/23] ovpn: add basic netlink support

2024-11-18 Thread Sergey Ryazanov
On 15.11.2024 12:19, Antonio Quartulli wrote: On 09/11/2024 00:31, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: +/** + * struct ovpn_struct - per ovpn interface state + * @dev: the actual netdev representing the tunnel + * @dev_tracker: reference tracker for associated d

Re: [PATCH bpf v4 0/2] bpf: fix recursive lock and add test

2024-11-18 Thread Martin KaFai Lau
On 11/17/24 7:09 PM, Jiayuan Chen wrote: 1. fix recursive lock when ebpf prog return SK_PASS. 2. add selftest to reproduce recursive lock. Note that the test code can reproduce the 'dead-lock' and if just the selftest merged without first patch, the test case will definitely fail, because the is

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-18 Thread Sami Tolvanen
Hi, On Sat, Nov 16, 2024 at 9:09 AM Masahiro Yamada wrote: > > On Thu, Nov 14, 2024 at 2:54 AM Sami Tolvanen wrote: > > > > Hi, > > > > On Mon, Nov 11, 2024 at 8:06 PM Masahiro Yamada > > wrote: > > > > > > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen > > > wrote: > > > > > > > > To avoid d

Re: [PATCH RFC 6/6] mm, slub: sheaf prefilling for guaranteed allocations

2024-11-18 Thread Hyeonggon Yoo
On Mon, Nov 18, 2024 at 11:26 PM Vlastimil Babka wrote: > > On 11/18/24 14:13, Hyeonggon Yoo wrote: > > On Wed, Nov 13, 2024 at 1:39 AM Vlastimil Babka wrote: > >> + > >> +/* > >> + * Allocate from a sheaf obtained by kmem_cache_prefill_sheaf() > >> + * > >> + * Guaranteed not to fail as many all

Re: [PATCH] virtio: remove the duplicate might_sleep()

2024-11-18 Thread Xuan Zhuo
On Mon, 18 Nov 2024 20:40:56 +0800, "xiaowuding_jaguarmicro" wrote: > From: Xiaowu Ding > > The virtio_add_status function have done might_sleep(),so we can remove > the duplicate calls. Is there any problem here? If not, I think we can keep it. Thanks. > > Signed-off-by: Xiaowu Ding > ---

[PATCH v1] selftests/bpf: fix application of sizeof to pointer

2024-11-18 Thread guanjing
sizeof when applied to a pointer typed expression gives the size of the pointer. tools/testing/selftests/bpf/progs/test_tunnel_kern.c:678:41-47: ERROR: application of sizeof to pointer The proper fix in this particular case is to code sizeof(*gopt) instead of sizeof(gopt). This issue was detect

Re: [PATCH bpf-next/net 1/5] bpf: Register mptcp common kfunc set

2024-11-18 Thread Geliang Tang
Hi Martin, Thanks for the review. On Mon, Nov 11, 2024 at 04:25:52PM -0800, Martin KaFai Lau wrote: > On 11/8/24 7:52 AM, Matthieu Baerts (NGI0) wrote: > > From: Geliang Tang > > > > MPTCP helper mptcp_sk() is used to convert struct sock to mptcp_sock. > > Helpers mptcp_subflow_ctx() and mptcp_

Re: [PATCH bpf-next/net 2/5] bpf: Add mptcp_subflow bpf_iter

2024-11-18 Thread Geliang Tang
Hi Martin, On Mon, Nov 11, 2024 at 04:50:49PM -0800, Martin KaFai Lau wrote: > On 11/8/24 7:52 AM, Matthieu Baerts (NGI0) wrote: > > From: Geliang Tang > > > > It's necessary to traverse all subflows on the conn_list of an MPTCP > > socket and then call kfunc to modify the fields of each subflow

Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-18 Thread Werner Sembach
Hi, Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: Tuxedo licenses the modules used on their hardware under GPLv3+, to "keep control of the upstream pacing" – and want to re-license the code while upstreaming. They were asked to then at least not use MODULE_LICENSE("GPL") which declares compati

[PATCH] virtio: remove the duplicate might_sleep()

2024-11-18 Thread xiaowuding_jaguarmicro
From: Xiaowu Ding The virtio_add_status function have done might_sleep(),so we can remove the duplicate calls. Signed-off-by: Xiaowu Ding --- drivers/virtio/virtio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index b9095751e..8352dfc1

Re: [PATCH] kmod: verify module name before invoking modprobe

2024-11-18 Thread Petr Pavlu
On 11/13/24 03:15, Song Chen wrote: > 在 2024/11/12 20:56, Petr Pavlu 写道: >> On 11/10/24 12:42, Song Chen wrote: >>> Sometimes when kernel calls request_module to load a module >>> into kernel space, it doesn't pass the module name appropriately, >>> and request_module doesn't verify it as well. >>>

[PATCH v6] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-18 Thread Suraj Sonawane
Fix an issue detected by syzbot with KASAN: BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ core.c:416 [inline] BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0 drivers/acpi/nfit/core.c:459 The issue occurs in cmd_to_func when the call_pkg->nd_reserved2 array i

[syzbot] [virt?] INFO: trying to register non-static key in stats_request

2024-11-18 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0a9b9d17f3a7 Merge tag 'pm-6.12-rc8' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17bf6ce858 kernel config: https://syzkaller.appspot.com/x/.config?x=d2aeec8c0b2e420c das

Re: [PATCH v13 4/7] remoteproc: Introduce release_fw optional operation

2024-11-18 Thread Mathieu Poirier
On Mon, Nov 04, 2024 at 02:35:12PM +0100, Arnaud Pouliquen wrote: > This patch updates the rproc_ops struct to include an optional > release_fw function. > > The release_fw ops is responsible for releasing the remote processor > firmware image. The ops is called in the following cases: > > - An

Re: [PATCH net-next v3] af_unix: pass pidfd flags via SCM_PIDFD cmsg

2024-11-18 Thread Kuniyuki Iwashima
From: Stas Sergeev Date: Sat, 16 Nov 2024 13:11:20 +0300 > Currently SCM_PIDFD cmsg cannot be sent via unix socket > (returns -EINVAL) and SO_PASSPIDFD doesn't support flags. > The created pidfd always has flags set to 0. > > This patch implements SCM_PIDFD cmsg in AF_UNIX socket, which > can be

Re: [PATCHv2 net-next] selftests: wireguards: use nft by default

2024-11-18 Thread Hangbin Liu
On Sun, Nov 17, 2024 at 09:09:00PM +0100, Jason A. Donenfeld wrote: > On Mon, Nov 11, 2024 at 04:19:02AM +, Hangbin Liu wrote: > > Use nft by default if it's supported, as nft is the replacement for > > iptables, > > which is used by default in some releases. Additionally, iptables is dropped

Re: [PATCH v5 2/2] module: Block a module by TUXEDO from accessing GPL symbols

2024-11-18 Thread Daniel Gomez
On Sat Nov 16, 2024 at 6:20 PM CET, Uwe Kleine-König wrote: > On Sat, Nov 16, 2024 at 09:15:55AM +0100, Daniel Gomez wrote: >> On Fri Nov 15, 2024 at 7:50 PM CET, Werner Sembach wrote: >> > From: Uwe Kleine-König >> > >> > TUXEDO has not yet relicensed a module for GPLv2+ as a reply from former >>

Re: [PATCH v5 2/2] module: Block a module by TUXEDO from accessing GPL symbols

2024-11-18 Thread Werner Sembach
Hi, Am 15.11.24 um 19:50 schrieb Werner Sembach: From: Uwe Kleine-König TUXEDO has not yet relicensed a module for GPLv2+ as a reply from former contributers the committed code under GPLv3+ is awaited. Teach the module loader that this module is not GPLv2 compatible despite the declaration to

[PATCH] selftests/bpf: Remove unused variable

2024-11-18 Thread Zhu Jun
the variable is never referenced in the code, just remove them. Signed-off-by: Zhu Jun --- tools/testing/selftests/bpf/prog_tests/log_buf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/log_buf.c b/tools/testing/selftests/bpf/prog_tests/log_buf.c in

[GIT PULL] RCU changes for v6.13

2024-11-18 Thread Frederic Weisbecker
Hello Linus, The following changes since commit f7345ccc62a4b880cf76458db5f320725f28e400: rcu/nocb: Fix rcuog wake-up from offline softirq (2024-10-10 22:18:19 +0530) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rcu/linux.git tags/rcu.release.v6.13

Re: [PATCH] ipvs: fix UB due to uninitialized stack access in ip_vs_protocol_init()

2024-11-18 Thread Julian Anastasov
Hello, On Mon, 11 Nov 2024, Jinghao Jia wrote: > Under certain kernel configurations when building with Clang/LLVM, the > compiler does not generate a return or jump as the terminator > instruction for ip_vs_protocol_init(), triggering the following objtool > warning during build time:

[GIT PULL] livepatching for 6.13

2024-11-18 Thread Petr Mladek
Hi Linus, please pull the latest changes for the kernel livepatching from git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git tags/livepatching-for-6.13 = - A new selftest for livepatching of a kprobed function. ---