Re: [PATCH v13 2/7] remoteproc: Add TEE support

2024-11-15 Thread Arnaud POULIQUEN
Hello Mathieu On 11/14/24 18:59, Mathieu Poirier wrote: > On Mon, Nov 04, 2024 at 02:35:10PM +0100, Arnaud Pouliquen wrote: >> Add a remoteproc TEE (Trusted Execution Environment) driver >> that will be probed by the TEE bus. If the associated Trusted >> application is supported on secure part thi

Re: [PATCH 0/3] remoteproc: qcom: pas: enable ADSP support on Qualcomm SAR2130P

2024-11-15 Thread Dmitry Baryshkov
On Sun, Oct 27, 2024 at 01:09:42AM +0300, Dmitry Baryshkov wrote: > Enable Audio DSP support on the Qualcomm SAR2130P platform. The CDSP, > also present on this SoC, crashes the device during the start and is > thus omitted from the series. > > Signed-off-by: Dmitry Baryshkov > --- > Dmitry Barys

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Werner Sembach
Hello Uwe, Am 15.11.24 um 08:29 schrieb Uwe Kleine-König: Hello Werner, On Fri, Nov 15, 2024 at 07:09:49AM +0100, Werner Sembach wrote: Am 15.11.24 um 05:43 schrieb Greg KH: On Thu, Nov 14, 2024 at 11:49:04AM +0100, Werner Sembach wrote: Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: the ke

Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for page_frag

2024-11-15 Thread Yunsheng Lin
On 2024/11/15 0:02, Mark Brown wrote: > On Mon, Oct 28, 2024 at 07:53:36PM +0800, Yunsheng Lin wrote: >> The testing is done by ensuring that the fragment allocated >> from a frag_frag_cache instance is pushed into a ptr_ring >> instance in a kthread binded to a specified cpu, and a kthread >> bind

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Werner Sembach
Am 15.11.24 um 11:22 schrieb Greg KH: On Fri, Nov 15, 2024 at 10:40:56AM +0100, Werner Sembach wrote: Am 15.11.24 um 10:18 schrieb Greg KH: On Fri, Nov 15, 2024 at 10:00:23AM +0100, Werner Sembach wrote: I guess what I try to convince you and others is that we _are_ taking Open Source licens

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Werner Sembach
Am 15.11.24 um 11:51 schrieb Uwe Kleine-König: Hello Werner, On Fri, Nov 15, 2024 at 10:40:56AM +0100, Werner Sembach wrote: Then why does the proprietary NVIDIA driver exist? Please don't use NVIDIA's behaviour as a blueprint for your actions. INAL, but I would not recommend to deduce from

Re: [PATCH net-next v11 09/23] ovpn: implement basic RX path (UDP)

2024-11-15 Thread Antonio Quartulli
On 11/11/2024 02:54, Sergey Ryazanov wrote: [...] +/* Called after decrypt to write the IP packet to the device. + * This method is expected to manage/free the skb. + */ +static void ovpn_netdev_write(struct ovpn_peer *peer, struct sk_buff *skb) +{ +    unsigned int pkt_len; + +    /* we can't

Re: [PATCH net-next v11 05/23] ovpn: keep carrier always on

2024-11-15 Thread Antonio Quartulli
On 09/11/2024 02:11, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: An ovpn interface will keep carrier always on and let the user decide when an interface should be considered disconnected. This way, even if an ovpn interface is not connected to any peer, it can still ret

Re: [PATCH net-next v11 00/23] Introducing OpenVPN Data Channel Offload

2024-11-15 Thread Antonio Quartulli
On 14/11/2024 23:10, Sergey Ryazanov wrote: On 14.11.2024 17:33, Antonio Quartulli wrote: On 06/11/2024 02:18, Sergey Ryazanov wrote: Regarding "big" topics I have only two concerns: link creation using RTNL and a switch statement usage. In the corresponding thread, I asked Jiri to clarify tha

Re: [PATCH net 1/2] net/ipv6: delete temporary address if mngtmpaddr is removed or un-mngtmpaddr

2024-11-15 Thread David Ahern
On 11/15/24 1:46 PM, Sam Edwards wrote: > Hi Hangbin, > > It took me a while to grasp but the problem seems to be a confusion > about what it means to set a temporary's lifetimes to 0/0: > 1) "The mngtmpaddrs has gone away; this temporary is slated for > deletion by addrconf_verify_rtnl()" > 2) "T

Re: [PATCH net-next v11 12/23] ovpn: implement TCP transport

2024-11-15 Thread Antonio Quartulli
On 31/10/2024 16:25, Sabrina Dubroca wrote: 2024-10-29, 11:47:25 +0100, Antonio Quartulli wrote: +static void ovpn_socket_release_work(struct work_struct *work) +{ + struct ovpn_socket *sock = container_of(work, struct ovpn_socket, work); + + ovpn_socket_detach(sock->sock); + k

[PATCH v5 1/2] module: Put known GPL offenders in an array

2024-11-15 Thread Werner Sembach
From: Uwe Kleine-König Instead of repeating the add_taint_module() call for each offender, create an array and loop over that one. This simplifies adding new entries considerably. Signed-off-by: Uwe Kleine-König Reviewed-by: Greg Kroah-Hartman Reviewed-by: Christoph Hellwig Signed-off-by: Wer

[PATCH v5 2/2] module: Block a module by TUXEDO from accessing GPL symbols

2024-11-15 Thread Werner Sembach
From: Uwe Kleine-König TUXEDO has not yet relicensed a module for GPLv2+ as a reply from former contributers the committed code under GPLv3+ is awaited. Teach the module loader that this module is not GPLv2 compatible despite the declaration to be GPLv2 compatible until the relicensing is comple

Re: [PATCH] kunit: debugfs: Use IS_ERR() for alloc_string_stream() error check

2024-11-15 Thread David Gow
On Fri, 15 Nov 2024 at 00:56, Kuan-Wei Chiu wrote: > > The alloc_string_stream() function only returns ERR_PTR(-ENOMEM) on > failure and never returns NULL. Therefore, switching the error check in > the caller from IS_ERR_OR_NULL to IS_ERR improves clarity, indicating > that this function will ret

Re: LKFT CI: improving Networking selftests results when validating stable kernels

2024-11-15 Thread Matthieu Baerts
Hi Dan, On 15/11/2024 14:07, Dan Carpenter wrote: > On Fri, Nov 15, 2024 at 01:43:14PM +0100, Matthieu Baerts wrote: >> Regarding the other questions from my previous email -- skipped tests >> (e.g. I think Netfilter tests are no longer validated), KVM, >> notifications -- do you know who at Linar

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel

2024-11-15 Thread Rob Herring (Arm)
On Thu, 14 Nov 2024 23:07:18 +0100, Jakob Hauser wrote: > From: Stephan Gerhold > > Add the Samsung S6E88A0-AMS427AP24 panel to the device tree for the > Samsung Galaxy S4 Mini Value Edition. By default the panel displays > everything horizontally flipped, so add "flip-horizontal" to the panel

Re: [PATCH] vsock/virtio: Remove queued_replies pushback logic

2024-11-15 Thread Alexander Graf
Hi Stefano, On 15.11.24 12:59, Stefano Garzarella wrote: On Fri, Nov 15, 2024 at 10:30:16AM +, Alexander Graf wrote: Ever since the introduction of the virtio vsock driver, it included pushback logic that blocks it from taking any new RX packets until the TX queue backlog becomes shallower

Re: [PATCH bpf-next v2 12/13] selftests/bpf: migrate bpf flow dissectors tests to test_progs

2024-11-15 Thread Stanislav Fomichev
On 11/14, Alexis Lothoré (eBPF Foundation) wrote: > test_flow_dissector.sh loads flow_dissector program and subprograms, > creates and configured relevant tunnels and interfaces, and ensure that > the bpf dissection is actually performed correctly. Similar tests exist > in test_progs (thanks to flo

Re: [PATCH bpf-next v2 11/13] selftests/bpf: add network helpers to generate udp checksums

2024-11-15 Thread Stanislav Fomichev
On 11/14, Alexis Lothoré (eBPF Foundation) wrote: > network_helpers.c provides some helpers to generate ip checksums or ip > pseudo-header checksums, but not for upper layers (eg: udp checksums) > > Add helpers for udp checksum to allow manually building udp packets. > > Signed-off-by: Alexis Lot

[PATCH v4 0/2] module: Block some modules by TUXEDO from accessing

2024-11-15 Thread Werner Sembach
Following the meeting I wrote about yesterday, I now changed the license of what we could change spontaniously to prove good faith. I still hope that the rest can be sorted out before anything gets merged. We are working on it. A clear time window would still be helpfull. At Uwe. I don't know how

Re: [PATCH v4] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-15 Thread Dave Jiang
On 11/15/24 9:42 AM, Suraj Sonawane wrote: > Fix an issue detected by syzbot with KASAN: > > BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ > core.c:416 [inline] > BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0 > drivers/acpi/nfit/core.c:459 > > The issue

[PATCH v1] selftest/mm: remove seal_elf

2024-11-15 Thread jeffxu
From: Jeff Xu Remove seal_elf, which is a demo of mseal, we no longer need this. Signed-off-by: Jeff Xu --- tools/testing/selftests/mm/.gitignore | 1 - tools/testing/selftests/mm/Makefile | 1 - tools/testing/selftests/mm/seal_elf.c | 137 -- 3 files changed, 139

Re: [PATCH v2] net/unix: pass pidfd flags via SCM_PIDFD cmsg

2024-11-15 Thread Kuniyuki Iwashima
> [PATCH v2] net/unix: pass pidfd flags via SCM_PIDFD cmsg Please specify the target tree; net for fixes, net-next for others. https://www.kernel.org/doc/html/v6.11/process/maintainer-netdev.html [PATCH net-next v3] af_unix: pass ... From: Stas Sergeev Date: Thu, 14 Nov 2024 12:19:09 +0300 >

Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for page_frag

2024-11-15 Thread Jakub Kicinski
On Fri, 15 Nov 2024 14:12:09 + Mark Brown wrote: > > As above, I am not sure if there is some elegant way to avoid the above > > error > > in the selftest core, one possible way to avoid the above error is to skip > > compiling like below as tools/testing/selftests/mm/test_page_frag.sh already

[PATCH] vsock/virtio: Remove queued_replies pushback logic

2024-11-15 Thread Alexander Graf
Ever since the introduction of the virtio vsock driver, it included pushback logic that blocks it from taking any new RX packets until the TX queue backlog becomes shallower than the virtqueue size. This logic works fine when you connect a user space application on the hypervisor with a virtio-vso

Re: LKFT CI: improving Networking selftests results when validating stable kernels

2024-11-15 Thread Matthieu Baerts
Hi Dan, Thank you for your reply! On 13/11/2024 18:08, Dan Carpenter wrote: > On Fri, Nov 08, 2024 at 07:21:59PM +0100, Matthieu Baerts wrote: >> KSelftests from the same version >> >> >> According to the doc [2], kselftests should support all previous kernel >> v

Re: [PATCH net-next v11 04/23] ovpn: add basic interface creation/destruction/management routines

2024-11-15 Thread Antonio Quartulli
On 09/11/2024 02:01, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: Add basic infrastructure for handling ovpn interfaces. Signed-off-by: Antonio Quartulli ---   drivers/net/ovpn/main.c   | 115 --   drivers/net/ovpn/main.h   

[PATCH v2 0/2] module: Block some modules by TUXEDO from accessing

2024-11-15 Thread Werner Sembach
Following the meeting I wrote about yesterday, I now changed the license of what we could change spontaniously to prove good faith. I still hope that the rest can be sorted out before anything gets merged. We are working on it. A clear time window would still be helpfull. At Uwe. I don't know how

[PATCH v3 1/2] module: Put known GPL offenders in an array

2024-11-15 Thread Werner Sembach
From: Uwe Kleine-König Instead of repeating the add_taint_module() call for each offender, create an array and loop over that one. This simplifies adding new entries considerably. Signed-off-by: Uwe Kleine-König Reviewed-by: Greg Kroah-Hartman Reviewed-by: Christoph Hellwig Signed-off-by: Wer

[PATCH v3 2/2] module: Block some modules by TUXEDO from accessing GPL symbols

2024-11-15 Thread Werner Sembach
From: Uwe Kleine-König TUXEDO has not yet relicensed all modules for GPLv2+ as former contributer need to be contacted that comited code under GPLv3+. So teach the module loader that these modules are proprietary despite their declaration to be GPLv2 compatible until the relicensing is complete.

Re: [PATCH v3 0/2] module: Block some modules by TUXEDO from accessing

2024-11-15 Thread Werner Sembach
Am 15.11.24 um 13:58 schrieb Werner Sembach: Following the meeting I wrote about yesterday, I now changed the license of what we could change spontaniously to prove good faith. I still hope that the rest can be sorted out before anything gets merged. We are working on it. A clear time window wou

Re: LKFT CI: improving Networking selftests results when validating stable kernels

2024-11-15 Thread Dan Carpenter
On Fri, Nov 15, 2024 at 01:43:14PM +0100, Matthieu Baerts wrote: > Regarding the other questions from my previous email -- skipped tests > (e.g. I think Netfilter tests are no longer validated), KVM, > notifications -- do you know who at Linaro could eventually look at them? > The skip tests were

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Uwe Kleine-König
Hello Werner, On Fri, Nov 15, 2024 at 10:40:56AM +0100, Werner Sembach wrote: > Then why does the proprietary NVIDIA driver exist? Please don't use NVIDIA's behaviour as a blueprint for your actions. INAL, but I would not recommend to deduce from "NVIDIA does it and wasn't tried to stop" (for any

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Greg KH
On Fri, Nov 15, 2024 at 11:59:47AM +0100, Werner Sembach wrote: > > Am 15.11.24 um 11:22 schrieb Greg KH: > > On Fri, Nov 15, 2024 at 10:40:56AM +0100, Werner Sembach wrote: > > > Am 15.11.24 um 10:18 schrieb Greg KH: > > > > On Fri, Nov 15, 2024 at 10:00:23AM +0100, Werner Sembach wrote: > > > >

Re: [RFC][PATCH 0/8] module: Strict per-modname namespaces

2024-11-15 Thread Peter Zijlstra
On Tue, Nov 12, 2024 at 08:52:26PM +0100, Peter Zijlstra wrote: > On Tue, Nov 12, 2024 at 09:56:20AM -0800, Sean Christopherson wrote: > > > This likely needs to be addressed in whatever chunk of code is enforcing the > > namespaces. The s/-/_ behavior (and vice versa!) is *very* baked into the

[PATCH v2 0/2] module: Block some modules by TUXEDO from accessing

2024-11-15 Thread Werner Sembach
Following the meeting I wrote about yesterday, I now changed the license of what we could change spontaniously to prove good faith. I still hope that the rest can be sorted out before anything gets merged. We are working on it. A clear time window would still be helpfull. At Uwe. I don't know how

[PATCH v2 1/2] module: Put known GPL offenders in an array

2024-11-15 Thread Werner Sembach
From: Uwe Kleine-König Instead of repeating the add_taint_module() call for each offender, create an array and loop over that one. This simplifies adding new entries considerably. Signed-off-by: Uwe Kleine-König Reviewed-by: Greg Kroah-Hartman Reviewed-by: Christoph Hellwig Signed-off-by: Wer

[PATCH v2 2/2] module: Block some modules by TUXEDO from accessing GPL symbols

2024-11-15 Thread Werner Sembach
From: Uwe Kleine-König TUXEDO has not yet relicend all modules for GPLv2+ as former contributer need to be contacted that comited code under GPLv3+. So teach the module loader that these modules are proprietary despite their declaration to be GPLv2 compatible until the relicensing is complete.

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Greg KH
On Fri, Nov 15, 2024 at 10:00:23AM +0100, Werner Sembach wrote: > I guess what I try to convince you and others is that we _are_ taking Open > Source licenses seriously, but still there are mistakes to be made, > especially with complex projects like the Linux kernel, e.g. I'm not aware > of any ot

Re: [RFC][PATCH 1/8] module: Prepare for script

2024-11-15 Thread Peter Zijlstra
On Mon, Nov 11, 2024 at 01:55:29PM +0100, Peter Zijlstra wrote: > On Mon, Nov 11, 2024 at 03:36:25AM -0800, Christoph Hellwig wrote: > > On Mon, Nov 11, 2024 at 11:54:31AM +0100, Peter Zijlstra wrote: > > > Since sed doesn't like multi-line make sure all EXPORT_SYMBOL_NS > > > things are a single l

Re: [PATCH] vsock/virtio: Remove queued_replies pushback logic

2024-11-15 Thread Stefano Garzarella
On Fri, Nov 15, 2024 at 10:30:16AM +, Alexander Graf wrote: Ever since the introduction of the virtio vsock driver, it included pushback logic that blocks it from taking any new RX packets until the TX queue backlog becomes shallower than the virtqueue size. This logic works fine when you co

Re: [PATCH net-next v11 04/23] ovpn: add basic interface creation/destruction/management routines

2024-11-15 Thread Antonio Quartulli
On 10/11/2024 21:42, Sergey Ryazanov wrote: Missed the most essential note regarding this patch :) On 29.10.2024 12:47, Antonio Quartulli wrote: +static int ovpn_net_open(struct net_device *dev) +{ +    netif_tx_start_all_queues(dev); +    return 0; +} + +static int ovpn_net_stop(struct net_dev

[PATCH] selftests/mount_setattr: Fix failures on 64K PAGE_SIZE kernels

2024-11-15 Thread Michael Ellerman
Currently the mount_setattr_test fails on machines with a 64K PAGE_SIZE, with errors such as: # RUN mount_setattr_idmapped.invalid_fd_negative ... mkfs.ext4: No space left on device while writing out and closing file system # mount_setattr_test.c:1055:invalid_fd_negative:Expected

Re: [PATCH net-next v11 04/23] ovpn: add basic interface creation/destruction/management routines

2024-11-15 Thread Antonio Quartulli
On 14/11/2024 23:57, Sergey Ryazanov wrote: On 14.11.2024 10:07, Antonio Quartulli wrote: On 12/11/2024 17:47, Sabrina Dubroca wrote: 2024-11-09, 03:01:21 +0200, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: +/* When the OpenVPN protocol is ran in AEAD mode, use + * the

Re: [PATCH net-next v11 07/23] ovpn: introduce the ovpn_socket object

2024-11-15 Thread Antonio Quartulli
On 10/11/2024 19:26, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: This specific structure is used in the ovpn kernel module to wrap and carry around a standard kernel socket. ovpn takes ownership of passed sockets and therefore an ovpn specific objects is attached to the

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-15 Thread Antonio Quartulli
On 11/11/2024 00:54, Sergey Ryazanov wrote: Another one forgotten question, sorry about this. Please find the question inlined. On 29.10.2024 12:47, Antonio Quartulli wrote:   /* Send user data to the network    */   netdev_tx_t ovpn_net_xmit(struct sk_buff *skb, struct net_device *dev)   { + 

Re: [PATCH net-next v11 03/23] ovpn: add basic netlink support

2024-11-15 Thread Antonio Quartulli
On 09/11/2024 00:31, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: This commit introduces basic netlink support with family registration/unregistration functionalities and stub pre/post-doit. More importantly it introduces the YAML uAPI description along with its auto-gen

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Greg KH
On Fri, Nov 15, 2024 at 10:40:56AM +0100, Werner Sembach wrote: > > Am 15.11.24 um 10:18 schrieb Greg KH: > > On Fri, Nov 15, 2024 at 10:00:23AM +0100, Werner Sembach wrote: > > > I guess what I try to convince you and others is that we _are_ taking Open > > > Source licenses seriously, but still

Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for page_frag

2024-11-15 Thread Mark Brown
On Fri, Nov 15, 2024 at 05:03:34PM +0800, Yunsheng Lin wrote: > On 2024/11/15 0:02, Mark Brown wrote: > > On Mon, Oct 28, 2024 at 07:53:36PM +0800, Yunsheng Lin wrote: > > This is breaking the build in -next on at least arm64 and x86_64 since > > it's trying to build an out of tree kernel module w

Re: LKFT CI: improving Networking selftests results when validating stable kernels

2024-11-15 Thread Matthieu Baerts
Hi Shuah, Greg, Thank you for your reply! On 13/11/2024 19:33, Shuah Khan wrote: > On 11/8/24 11:21, Matthieu Baerts wrote: >> Hello LKFT maintainers, CI operators, >> >> First, I would like to say thank you to the people behind the LKFT >> project for validating stable kernels (and more), and in

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Werner Sembach
Am 15.11.24 um 10:18 schrieb Greg KH: On Fri, Nov 15, 2024 at 10:00:23AM +0100, Werner Sembach wrote: I guess what I try to convince you and others is that we _are_ taking Open Source licenses seriously, but still there are mistakes to be made, especially with complex projects like the Linux k

Re: [PATCH net-next v11 03/23] ovpn: add basic netlink support

2024-11-15 Thread Antonio Quartulli
On 09/11/2024 00:15, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: This commit introduces basic netlink support with family registration/unregistration functionalities and stub pre/post-doit. More importantly it introduces the YAML uAPI description along with its auto-gen

Re: [PATCH bpf-next v2 09/13] selftests/bpf: move ip checksum helper to network helpers

2024-11-15 Thread Stanislav Fomichev
On 11/14, Alexis Lothoré (eBPF Foundation) wrote: > xdp_metadata test has a small helper computing ipv checksums to allow > manually building packets. > > Move this helper to network_helpers to share it with other tests. > > Signed-off-by: Alexis Lothoré (eBPF Foundation) > --- > Changes in v2:

Re: [PATCH net-next v11 09/23] ovpn: implement basic RX path (UDP)

2024-11-15 Thread Antonio Quartulli
On 12/11/2024 01:16, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: +static void ovpn_netdev_write(struct ovpn_peer *peer, struct sk_buff *skb) +{ +    unsigned int pkt_len; + +    /* we can't guarantee the packet wasn't corrupted before entering the + * VPN, therefo

Re: [PATCH] virtio-fs: Query rootmode during mount

2024-11-15 Thread Miklos Szeredi
On Fri, 15 Nov 2024 at 15:51, Hanna Czenczek wrote: > Now that I look at it once again (because I was wondering why to check fm, > and not fm->fc), do we even need to check fm or fm->fc? fuse_mount_destroy() > assumes both are non-NULL, so I assume sb->s_root || fm->fc->initialized > should b

Re: [PATCH bpf-next v2 01/13] selftests/bpf: add a macro to compare raw memory

2024-11-15 Thread Stanislav Fomichev
On 11/14, Alexis Lothoré (eBPF Foundation) wrote: > We sometimes need to compare whole structures in an assert. It is > possible to use the existing macros on each field, but when the whole > structure has to be checked, it is more convenient to simply compare the > whole structure memory > > Add

Re: [PATCH bpf-next v2 07/13] selftests/bpf: migrate flow_dissector namespace exclusivity test

2024-11-15 Thread Stanislav Fomichev
On 11/14, Alexis Lothoré (eBPF Foundation) wrote: > Commit a11c397c43d5 ("bpf/flow_dissector: add mode to enforce global BPF > flow dissector") is currently tested in test_flow_dissector.sh, which is > not part of test_progs. Add the corresponding test to flow_dissector.c, > which is part of test_p

[PATCH v4 1/2] module: Put known GPL offenders in an array

2024-11-15 Thread Werner Sembach
From: Uwe Kleine-König Instead of repeating the add_taint_module() call for each offender, create an array and loop over that one. This simplifies adding new entries considerably. Signed-off-by: Uwe Kleine-König Reviewed-by: Greg Kroah-Hartman Reviewed-by: Christoph Hellwig Signed-off-by: Wer

Re: [PATCH bpf-next v2 10/13] selftests/bpf: rename pseudo headers checksum computation

2024-11-15 Thread Stanislav Fomichev
On 11/14, Alexis Lothoré (eBPF Foundation) wrote: > network_helpers.h provides helpers to compute checksum for pseudo > headers but no helpers to compute the global checksums. > > Before adding those, rename the pseudo header checksum helper to clarify > their role. Same here: let's keep the old

Re: [PATCH bpf-next v2 04/13] selftests/bpf: re-split main function into dedicated tests

2024-11-15 Thread Stanislav Fomichev
On 11/14, Alexis Lothoré (eBPF Foundation) wrote: > The flow_dissector runs plenty of tests over diffent kind of packets, > grouped into three categories: skb mode, non-skb mode with direct > attach, and non-skb with indirect attach. > > Re-split the main function into dedicated tests. Each test n

Re: [PATCH v3 0/2] module: Block some modules by TUXEDO from accessing

2024-11-15 Thread Werner Sembach
Hello, Am 15.11.24 um 17:40 schrieb Uwe Kleine-König: Hello Werner, On Fri, Nov 15, 2024 at 02:03:27PM +0100, Werner Sembach wrote: Am 15.11.24 um 13:58 schrieb Werner Sembach: Following the meeting I wrote about yesterday, I now changed the license of what we could change spontaniously to pr

Re: [PATCH v3] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-15 Thread Suraj Sonawane
On 14/11/24 21:12, Dave Jiang wrote: On 11/14/24 2:19 AM, Suraj Sonawane wrote: On 13/11/24 22:32, Dave Jiang wrote: On 11/13/24 5:51 AM, Suraj Sonawane wrote: Fix an issue detected by syzbot with KASAN: BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ core.c:416 [inlin

[PATCH] selftests: acct: Add ksft_exit_fail if not running as root

2024-11-15 Thread Shivam Chaudhary
If the selftest is not running as root, it should fail and give an appropriate warning to the user. This patch adds ksft_exit_fail_msg() if the test is not running as root. Logs: Before change: TAP version 13 1..1 ok 1 # SKIP This test needs root to run! After change: TAP version 13 1..1 Bail

[PATCH v5 2/2] module: Block a module by TUXEDO from accessing GPL symbols

2024-11-15 Thread Werner Sembach
The situation was less severe then I feared. I'm awaiting replys regarding this: https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/merge_requests/17 and this: https://github.com/tuxedocomputers/tuxedo-keyboard/pull/155 (via mail as the GitHub repo is archived). This is t

Re: [PATCH v3 0/2] module: Block some modules by TUXEDO from accessing

2024-11-15 Thread Uwe Kleine-König
Hello Werner, On Fri, Nov 15, 2024 at 02:03:27PM +0100, Werner Sembach wrote: > Am 15.11.24 um 13:58 schrieb Werner Sembach: > > Following the meeting I wrote about yesterday, I now changed the license > > of what we could change spontaniously to prove good faith. > > > > I still hope that the re

Re: [PATCH net 1/2] net/ipv6: delete temporary address if mngtmpaddr is removed or un-mngtmpaddr

2024-11-15 Thread Sam Edwards
On Wed, Nov 13, 2024 at 11:38 PM Hangbin Liu wrote: > > On Wed, Nov 13, 2024 at 01:03:13PM -0800, Sam Edwards wrote: > > On Wed, Nov 13, 2024 at 4:52 AM Hangbin Liu wrote: > > > > > > RFC8981 section 3.4 says that existing temporary addresses must have their > > > lifetimes adjusted so that no te

Re: [PATCH net 2/2] selftests/rtnetlink.sh: add mngtempaddr test

2024-11-15 Thread Sam Edwards
On Thu, Nov 14, 2024 at 12:46 AM Hangbin Liu wrote: > > Hi Sam, > > On Wed, Nov 13, 2024 at 12:43:00PM -0800, Sam Edwards wrote: > > > +# If the mngtmpaddr or tempaddr missing, return 0 and stop waiting > > > +check_tempaddr_exists() > > > +{ > > > + local start=${1-"1"} > > > + addr_l

[PATCH v4] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-15 Thread Suraj Sonawane
Fix an issue detected by syzbot with KASAN: BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ core.c:416 [inline] BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0 drivers/acpi/nfit/core.c:459 The issue occurs in cmd_to_func when the call_pkg->nd_reserved2 array i

[PATCH v4 2/2] module: Block some modules by TUXEDO from accessing GPL symbols

2024-11-15 Thread Werner Sembach
From: Uwe Kleine-König TUXEDO has not yet relicensed all modules for GPLv2+ as former contributer need to be contacted that comited code under GPLv3+. So teach the module loader that these modules are proprietary despite their declaration to be GPLv2 compatible until the relicensing is complete.

Re: [PATCH v4] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-15 Thread Ira Weiny
Suraj Sonawane wrote: > Fix an issue detected by syzbot with KASAN: > > BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ > core.c:416 [inline] > BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0 > drivers/acpi/nfit/core.c:459 > > The issue occurs in cmd_to_func w

[PATCH net-next] mm: page_frag: fix a compile error when kernel is not compiled

2024-11-15 Thread Yunsheng Lin
page_frag test module is an out of tree module, but built using KDIR as the main kernel tree, the mm test suite is just getting skipped if newly added page_frag test module fails to compile due to kernel not yet compiled. Fix the above problem by ensuring both kernel is built first and a newer ker

Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for page_frag

2024-11-15 Thread Yunsheng Lin
On 11/16/2024 6:34 AM, Jakub Kicinski wrote: On Fri, 15 Nov 2024 14:12:09 + Mark Brown wrote: As above, I am not sure if there is some elegant way to avoid the above error in the selftest core, one possible way to avoid the above error is to skip compiling like below as tools/testing/selftes

Re: [PATCH net-next] mm: page_frag: fix a compile error when kernel is not compiled

2024-11-15 Thread Yunsheng Lin
It seemed that somehow I missed to add the netdev ML:( On 11/16/2024 12:23 PM, Yunsheng Lin wrote: page_frag test module is an out of tree module, but built using KDIR as the main kernel tree, the mm test suite is just getting skipped if newly added page_frag test module fails to compile due to

Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for page_frag

2024-11-15 Thread Yunsheng Lin
On 11/15/2024 10:12 PM, Mark Brown wrote: ... make -C tools/testing/selftests/livepatch/test_modules/ Ah, this one is actually using some framework support for building modules - it's putting the modules in a separate directory and using TEST_GEN_MODS_DIR. Crucially, though, it has guards