Re: [PATCH net-next] net: netconsole: selftests: Check if netdevsim is available

2024-11-11 Thread Simon Horman
On Fri, Nov 08, 2024 at 06:59:25AM -0800, Breno Leitao wrote: > The netconsole selftest relies on the availability of the netdevsim module. > To ensure the test can run correctly, we need to check if the netdevsim > module is either loaded or built-in before proceeding. > > Update the netconsole s

Re: [PATCH 0/8] RCU fixes for v6.13

2024-11-11 Thread Neeraj Upadhyay
On 11/6/2024 8:29 PM, Frederic Weisbecker wrote: > Hello, > > Please find below the general RCU fixes targeted for the upcoming > merge window. > > Michal Schmidt (1): > rcu/srcutiny: don't return before reenabling preemption > > Paul E. McKenney (6): > doc: Add rcuog kthreads to kernel-per-

Re: [PATCH 0/2] RCU NOCB for v6.13

2024-11-11 Thread Neeraj Upadhyay
On 11/6/2024 9:02 PM, Frederic Weisbecker wrote: > Hello, > > Please find below the RCU NOCB patches targeted for the upcoming > merge window. > > Yue Haibing (1): > rcu: Remove unused declaration rcu_segcblist_offload() > > Zqiang (1): > rcu/nocb: Fix missed RCU barrier on deoffloading > >

Re: [PATCH 0/6] RCU torture for v6.13

2024-11-11 Thread Neeraj Upadhyay
On 11/6/2024 9:32 PM, Frederic Weisbecker wrote: > Hello, > > Please find below the RCU NOCB patches targeted for the upcoming > merge window. > > Paul E. McKenney (4): > torture: Add --no-affinity parameter to kvm.sh > refscale: Correct affinity check > rcuscale: Add guest_os_delay module

Re: [PATCH rcu 08/15] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-11 Thread Andrii Nakryiko
On Mon, Nov 11, 2024 at 7:17 AM Paul E. McKenney wrote: > > On Mon, Nov 11, 2024 at 04:47:49PM +0530, Neeraj Upadhyay wrote: > > > > > +/** > > > + * srcu_read_unlock_lite - unregister a old reader from an > > > SRCU-protected structure. > > > + * @ssp: srcu_struct in which to unregister the old

Re: [RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-11-11 Thread Alexandre Belloni
Lee, I'm happy taking this patch, I guess you are going to take 1/2 ? On 12/10/2024 21:31:39+0200, Karel Balej wrote: > RTC lives on the chip's base register page. Add the relevant register > definitions and implement a basic set/read time functionality. Tested > with the samsung,coreprimevelte s

Re: (subset) [RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-11-11 Thread Alexandre Belloni
On Sat, 12 Oct 2024 21:31:39 +0200, Karel Balej wrote: > RTC lives on the chip's base register page. Add the relevant register > definitions and implement a basic set/read time functionality. Tested > with the samsung,coreprimevelte smartphone which contains this PMIC and > whose vendor kernel tree

Re: [PATCH net-next v7] ipv6: Fix soft lockups in fib6_select_path under high next hop churn

2024-11-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 5 Nov 2024 17:02:36 -0800 you wrote: > Soft lockups have been observed on a cluster of Linux-based edge routers > located in a highly dynamic environment. Using the `bird` service, these > routers continuousl

Re: [PATCH 2/4] kselftest/arm64: Use a define for SVCR

2024-11-11 Thread Catalin Marinas
On Thu, Nov 07, 2024 at 01:38:05AM +, Mark Brown wrote: > For some reason when we're accessing SVCR in the FP tests we use the raw > numerical version of the register name rather than hiding that behind a > preprocessor macro for readability. Since we already use the generated > defines for sys

Re: [PATCH net-next v11 09/23] ovpn: implement basic RX path (UDP)

2024-11-11 Thread Sergey Ryazanov
On 29.10.2024 12:47, Antonio Quartulli wrote: +static void ovpn_netdev_write(struct ovpn_peer *peer, struct sk_buff *skb) +{ + unsigned int pkt_len; + + /* we can't guarantee the packet wasn't corrupted before entering the +* VPN, therefore we give other layers a chance to che

Re: [PATCH] mac802154: add a check for slave data list before delete

2024-11-11 Thread Lizhi Xu
On Mon, 11 Nov 2024 20:46:57 +0100, Miquel Raynal wrote: > On 08/11/2024 at 22:54:20 +08, Lizhi Xu wrote: > > > syzkaller reported a corrupted list in ieee802154_if_remove. [1] > > > > Remove an IEEE 802.15.4 network interface after unregister an IEEE 802.15.4 > > hardware device from the system.

Re: [PATCH bpf-next/net 1/5] bpf: Register mptcp common kfunc set

2024-11-11 Thread Martin KaFai Lau
On 11/8/24 7:52 AM, Matthieu Baerts (NGI0) wrote: From: Geliang Tang MPTCP helper mptcp_sk() is used to convert struct sock to mptcp_sock. Helpers mptcp_subflow_ctx() and mptcp_subflow_tcp_sock() are used to convert between struct mptcp_subflow_context and sock. They all will be used in MPTCP B

Re: [RFC][PATCH 0/8] module: Strict per-modname namespaces

2024-11-11 Thread Sean Christopherson
On Mon, Nov 11, 2024, Peter Zijlstra wrote: > Hi! > > Implement a means for exports to be available only to an explicit list of > named > modules. By explicitly limiting the usage of certain exports, the abuse > potential/risk is greatly reduced. > > The first three 'patches' clean up the existi

Re: [PATCH bpf-next/net 2/5] bpf: Add mptcp_subflow bpf_iter

2024-11-11 Thread Martin KaFai Lau
On 11/8/24 7:52 AM, Matthieu Baerts (NGI0) wrote: From: Geliang Tang It's necessary to traverse all subflows on the conn_list of an MPTCP socket and then call kfunc to modify the fields of each subflow. In kernel space, mptcp_for_each_subflow() helper is used for this: mptcp_for_each_s

Re: [PATCH net-next v8 00/12] selftests: ncdevmem: Add ncdevmem to ksft

2024-11-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Thu, 7 Nov 2024 10:11:59 -0800 you wrote: > The goal of the series is to simplify and make it possible to use > ncdevmem in an automated way from the ksft python wrapper. > > ncdevmem is slowly mutated into a st

Re: [PATCH net-next v3 0/4] Introduce VLAN support in HSR

2024-11-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 6 Nov 2024 14:47:06 +0530 you wrote: > This series adds VLAN support to HSR framework. > This series also adds VLAN support to HSR mode of ICSSG Ethernet driver. > > Changes from v2 to v3: > *) Modified hsr_

Re: [PATCH rcu 06/12] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-11 Thread Paul E. McKenney
On Mon, Nov 11, 2024 at 10:21:58PM +0530, Neeraj Upadhyay wrote: > On 11/11/2024 8:56 PM, Paul E. McKenney wrote: > > On Mon, Nov 11, 2024 at 06:24:58PM +0530, Neeraj Upadhyay wrote: > >>> /* > >>> - * Returns approximate total of the readers' ->srcu_lock_count[] values > >>> - * for the rank of p

Re: [PATCH net-next v11 14/23] ovpn: implement peer lookup logic

2024-11-11 Thread Sergey Ryazanov
On 04.11.2024 13:26, Sabrina Dubroca wrote: 2024-10-29, 11:47:27 +0100, Antonio Quartulli wrote: struct ovpn_peer *ovpn_peer_get_by_transp_addr(struct ovpn_struct *ovpn, struct sk_buff *skb) { - struct ovpn_peer *peer = NULL; + struc

[PATCH rcu 1/3] srcu: Remove smp_mb() from srcu_read_unlock_lite()

2024-11-11 Thread Paul E. McKenney
The srcu_read_unlock_lite() function invokes __srcu_read_unlock() instead of __srcu_read_unlock_lite(), which means that it is doing an unnecessary smp_mb(). This is harmless other than the performance degradation. This commit therefore switches to __srcu_read_unlock_lite(). Reported-by: Neeraj

[PATCH rcu 3/3] srcu: Unconditionally record srcu_read_lock_lite() in ->srcu_reader_flavor

2024-11-11 Thread Paul E. McKenney
Currently, srcu_read_lock_lite() uses the SRCU_READ_FLAVOR_LITE bit in ->srcu_reader_flavor to communicate to the grace-period processing in srcu_readers_active_idx_check() that the smp_mb() must be replaced by a synchronize_rcu(). Unfortunately, ->srcu_reader_flavor is not updated unless the kern

Re: [RFC PATCH 2/3] module: Don't fail module loading when setting ro_after_init section RO failed

2024-11-11 Thread Petr Pavlu
On 11/9/24 11:35, Christophe Leroy wrote: > Once module init has succeded it is too late to cancel loading. > If setting ro_after_init data section to read-only fails, all we > can do is to inform the user through a warning. Makes sense to me. If I'm looking correctly, set_memory_ro() could mostly

Re: [PATCH net-next v11 18/23] ovpn: implement peer add/get/dump/delete via netlink

2024-11-11 Thread Sabrina Dubroca
2024-10-29, 11:47:31 +0100, Antonio Quartulli wrote: > +static int ovpn_nl_peer_modify(struct ovpn_peer *peer, struct genl_info > *info, > +struct nlattr **attrs) > +{ > + struct sockaddr_storage ss = {}; > + u32 sockfd, interv, timeout; > + struct socket *s

[PATCH rcu 2/3] srcu: Check for srcu_read_lock_lite() across all CPUs

2024-11-11 Thread Paul E. McKenney
If srcu_read_lock_lite() is used on a given srcu_struct structure, then the grace-period processing must to synchronize_rcu() instead of smp_mb() between the scans of the ->srcu_unlock_count[] and ->srcu_lock_count[] counters. Currently, it does that by testing the SRCU_READ_FLAVOR_LITE bit of the

Re: [PATCH 5/6] rcuscale: Do a proper cleanup if kfree_scale_init() fails

2024-11-11 Thread Uladzislau Rezki
On Mon, Nov 11, 2024 at 03:24:38PM +0530, Neeraj Upadhyay wrote: > > > diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c > > index 6d37596deb1f..de7d511e6be4 100644 > > --- a/kernel/rcu/rcuscale.c > > +++ b/kernel/rcu/rcuscale.c > > @@ -890,13 +890,13 @@ kfree_scale_init(void) > >

[PATCH v2 6/6] selftests: KVM: Add test case for MMIO during vectoring

2024-11-11 Thread Ivan Orlov
Extend the 'set_memory_region_test' with a test case which covers the MMIO during vectoring error handling. The test case 1) Sets an IDT descriptor base to point to an MMIO address 2) Generates a #GP in the guest 3) Verifies that we got a correct exit reason and suberror code 4) Verifies that we g

[PATCH v2 4/6] KVM: SVM: Handle MMIO during vectroing error

2024-11-11 Thread Ivan Orlov
Handle MMIO during vectoring error in check_emulate_instruction to prevent infinite loop on SVM and eliminate the difference in how the situation when the guest accesses MMIO during vectoring is handled on SVM and VMX. Signed-off-by: Ivan Orlov --- V1 -> V2: - Detect the unhandleable vectoring er

[PATCH v2 5/6] selftests: KVM: extract lidt into helper function

2024-11-11 Thread Ivan Orlov
Implement a function for setting the IDT descriptor from the guest code. Replace the existing lidt occurrences with calls to this function as `lidt` is used in multiple places. Signed-off-by: Ivan Orlov --- V1 -> V2: - This patch wasn't included in V1. tools/testing/selftests/kvm/include/x86_64

[RFC][PATCH 5/8] module/modpost: Add basename helper

2024-11-11 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- scripts/mod/modpost.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1553,6 +1553,16 @@ static void mod_set_crcs(struct module * free(buf); } +static cons

Re: [PATCH] kunit: string-stream: Fix a UAF bug in kunit_init_suite()

2024-11-11 Thread Jinjie Ruan
On 2024/11/9 21:02, Kuan-Wei Chiu wrote: > On Sat, Nov 09, 2024 at 08:40:30PM +0800, Kuan-Wei Chiu wrote: >> Hi Jinjie, >> >> On Thu, Oct 24, 2024 at 05:43:03PM +0800, Jinjie Ruan wrote: >>> In kunit_debugfs_create_suite(), if alloc_string_stream() fails in the >>> kunit_suite_for_each_test_case

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-11 Thread Andy Shevchenko
On Sun, Nov 10, 2024 at 04:34:30PM -0500, Aren wrote: > On Sun, Nov 10, 2024 at 09:52:32PM +0200, Andy Shevchenko wrote: > > Sun, Nov 10, 2024 at 02:14:24PM -0500, Aren kirjoitti: > > > On Mon, Nov 04, 2024 at 10:40:16AM +0200, Andy Shevchenko wrote: > > > > On Sat, Nov 02, 2024 at 03:50:41PM -0400

Re: [PATCH v4 2/6] iio: light: stk3310: handle all remove logic with devm callbacks

2024-11-11 Thread Andy Shevchenko
On Sun, Nov 10, 2024 at 05:37:56PM -0500, Aren wrote: > On Sun, Nov 10, 2024 at 09:51:04PM +0200, Andy Shevchenko wrote: > > Sun, Nov 10, 2024 at 01:38:39PM -0500, Aren kirjoitti: > > > On Mon, Nov 04, 2024 at 10:32:08AM +0200, Andy Shevchenko wrote: > > > > On Sat, Nov 02, 2024 at 03:50:37PM -0400

Re: [PATCH] kunit: string-stream: Fix a UAF bug in kunit_init_suite()

2024-11-11 Thread Jinjie Ruan
On 2024/11/9 20:40, Kuan-Wei Chiu wrote: > Hi Jinjie, > > On Thu, Oct 24, 2024 at 05:43:03PM +0800, Jinjie Ruan wrote: >> In kunit_debugfs_create_suite(), if alloc_string_stream() fails in the >> kunit_suite_for_each_test_case() loop, the "suite->log = stream" >> has assigned before, and the er

Re: [PATCH 5/6] rcuscale: Do a proper cleanup if kfree_scale_init() fails

2024-11-11 Thread Neeraj Upadhyay
> diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c > index 6d37596deb1f..de7d511e6be4 100644 > --- a/kernel/rcu/rcuscale.c > +++ b/kernel/rcu/rcuscale.c > @@ -890,13 +890,13 @@ kfree_scale_init(void) > if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start < 2 * HZ)) { >

Re: [PATCH vhost 0/2] vdpa/mlx5: Iova mapping related fixes

2024-11-11 Thread Dragos Tatulea
On 21.10.24 15:40, Dragos Tatulea wrote: > Here are 2 fixes from Si-Wei: > - The first one is an important fix that has to be applied as far > back as possible (hence CC'ing linux-stable). > - The second is more of an improvement. That's why it doesn't have the > Fixes tag. > > I'd like to

[PATCH v2 2/6] KVM: x86: Add emulation status for vectoring during MMIO

2024-11-11 Thread Ivan Orlov
Add emulation status for vectoring error due to MMIO. Such a situation can occur if guest sets the IDT descriptor base to point to MMIO region, and triggers an exception after that. Exit to userspace with event delivery error when MMIO happens during vectoring. Signed-off-by: Ivan Orlov --- V1 -

[PATCH v2 3/6] KVM: VMX: Handle vectoring error in check_emulate_instruction

2024-11-11 Thread Ivan Orlov
Move unhandleable vmexit due to MMIO during vectoring error detection into check_emulate_instruction. Implement a function which checks if emul_type indicates MMIO so it can be used for both VMX and SVM. Fix the comment about EMULTYPE_PF as this flag doesn't necessarily mean MMIO anymore: it can a

[PATCH v2 1/6] KVM: x86: Add function for vectoring error generation

2024-11-11 Thread Ivan Orlov
Extract VMX code for unhandleable VM-Exit during vectoring into vendor-agnostic function so that boiler-plate code can be shared by SVM. Report an actual GPA for EPT misconfig or invalid GPA for any other exit code in internal.data[3]. Signed-off-by: Ivan Orlov --- V1 -> V2: - Return GPA for any

[PATCH v2 0/6] Enhance event delivery error handling

2024-11-11 Thread Ivan Orlov
Currently, the situation when guest accesses MMIO during vectoring is handled differently on VMX and SVM: on VMX KVM returns internal error, when SVM goes into infinite loop trying to deliver an event again and again. This patch series eliminates this difference by returning a KVM internal error w

Re: [RFC][PATCH 1/8] module: Prepare for script

2024-11-11 Thread Christoph Hellwig
On Mon, Nov 11, 2024 at 11:54:31AM +0100, Peter Zijlstra wrote: > Since sed doesn't like multi-line make sure all EXPORT_SYMBOL_NS > things are a single line. Eww. Just use coccinelle or another tool not so simplistic. > @@ -375,8 +372,7 @@ int otx2_cptlf_register_done_interrupts( > otx2_c

Re: [RFC][PATCH 8/8] module: Provide EXPORT_SYMBOL*_FOR() helpers

2024-11-11 Thread Christoph Hellwig
On Mon, Nov 11, 2024 at 11:54:38AM +0100, Peter Zijlstra wrote: > +#define EXPORT_SYMBOL_FOR(sym, mods) EXPORT_SYMBOL_NS(sym, "MODULE_" mods) I don't think we need a non-_GPL version of this, as the exports obviously are for in-tree modules only.

Re: [RFC][PATCH 6/8] module: Add module specific symbol namespace support

2024-11-11 Thread Christoph Hellwig
On Mon, Nov 11, 2024 at 11:54:36AM +0100, Peter Zijlstra wrote: > Designate the "MODULE_${modname}" symbol namespace to mean: 'only > export to the named module'. > > Notably, explicit imports of anything in the "MODULE_" space is > forbidden. Modules implicitly get the "MODULE_${modname}" namespa

Re: [PATCH] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-11 Thread kernel test robot
Hi Suraj, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.12-rc7 next-2024] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH rcu 06/12] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-11 Thread Neeraj Upadhyay
> > /* > - * Returns approximate total of the readers' ->srcu_lock_count[] values > - * for the rank of per-CPU counters specified by idx. > + * Computes approximate total of the readers' ->srcu_lock_count[] values > + * for the rank of per-CPU counters specified by idx, and returns true if >

Re: [RFC][PATCH 1/8] module: Prepare for script

2024-11-11 Thread Peter Zijlstra
On Mon, Nov 11, 2024 at 03:36:25AM -0800, Christoph Hellwig wrote: > On Mon, Nov 11, 2024 at 11:54:31AM +0100, Peter Zijlstra wrote: > > Since sed doesn't like multi-line make sure all EXPORT_SYMBOL_NS > > things are a single line. > > Eww. Just use coccinelle or another tool not so simplistic.

[PATCH] kunit: skb: add gfp to kernel doc for kunit_zalloc_skb()

2024-11-11 Thread Dan Carpenter
Kuan-Wei Chiu pointed out that the kernel doc for kunit_zalloc_skb() needs to include the @gfp information. Add it. Reported-by: Kuan-Wei Chiu Closes: https://lore.kernel.org/all/Zy+VIXDPuU613fFd@visitorckw-System-Product-Name/ Signed-off-by: Dan Carpenter --- include/kunit/skbuff.h | 3 ++-

Re: [PATCH rcu 08/15] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-11 Thread Neeraj Upadhyay
> +/** > + * srcu_read_unlock_lite - unregister a old reader from an SRCU-protected > structure. > + * @ssp: srcu_struct in which to unregister the old reader. > + * @idx: return value from corresponding srcu_read_lock(). > + * > + * Exit a light-weight SRCU read-side critical section. > + */ >

[RFC][PATCH 0/8] module: Strict per-modname namespaces

2024-11-11 Thread Peter Zijlstra
Hi! Implement a means for exports to be available only to an explicit list of named modules. By explicitly limiting the usage of certain exports, the abuse potential/risk is greatly reduced. The first three 'patches' clean up the existing export namespace code along the same lines of 33def8498fdd

[RFC][PATCH 1/8] module: Prepare for script

2024-11-11 Thread Peter Zijlstra
Since sed doesn't like multi-line make sure all EXPORT_SYMBOL_NS things are a single line. Signed-off-by: Peter Zijlstra (Intel) --- drivers/crypto/marvell/octeontx2/otx2_cptlf.c | 12 include/kunit/visibility.h|3 +-- sound/soc/codecs/tas2781-fmwlib.c

[RFC][PATCH 3/8] module: Fix up after script

2024-11-11 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- include/linux/export.h |4 ++-- include/linux/module.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) --- a/include/linux/export.h +++ b/include/linux/export.h @@ -67,7 +67,7 @@ #define EXPORT_SYMBOL(sym) _EXPORT_SYMBOL(

[RFC][PATCH 2/8] module: Convert symbol namespace to string literal

2024-11-11 Thread Peter Zijlstra
git grep -l -e MODULE_IMPORT_NS -e EXPORT_SYMBOL_NS | while read file; do sed -i -e 's/MODULE_IMPORT_NS(\([^)]*\))/MODULE_IMPORT_NS("\1")/g' \ -e 's/\(EXPORT_SYMBOL_NS[^(]*\)(\([^,]*\), \([^)]*\))/\1(\2, "\3")/g' $file; done Signed-off-by: Peter Zijlstra (Intel) ---

[RFC][PATCH 8/8] module: Provide EXPORT_SYMBOL*_FOR() helpers

2024-11-11 Thread Peter Zijlstra
Because Christoph and Masahiro-san asked for it :-) Signed-off-by: Peter Zijlstra (Intel) --- include/linux/export.h |3 +++ 1 file changed, 3 insertions(+) --- a/include/linux/export.h +++ b/include/linux/export.h @@ -70,4 +70,7 @@ #define EXPORT_SYMBOL_NS(sym, ns) __EXPORT_SYMBOL(sy

[RFC][PATCH 4/8] module/modpost: Use for() loop

2024-11-11 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- scripts/mod/modpost.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1586,12 +1586,9 @@ static void read_symbols(const char *mod license = get_next_mod

[RFC][PATCH 7/8] module: Extend the MODULE_ namespace parsing

2024-11-11 Thread Peter Zijlstra
Instead of only accepting "MODULE_${name}", extend it with a comma separated list of module names and add tail glob support. That is, something like: "MODULE_foo-*,bar" is now possible. Signed-off-by: Peter Zijlstra (Intel) --- kernel/module/main.c | 39 ++

[RFC][PATCH 6/8] module: Add module specific symbol namespace support

2024-11-11 Thread Peter Zijlstra
Designate the "MODULE_${modname}" symbol namespace to mean: 'only export to the named module'. Notably, explicit imports of anything in the "MODULE_" space is forbidden. Modules implicitly get the "MODULE_${modname}" namespace added. Signed-off-by: Peter Zijlstra (Intel) --- kernel/module/main.

Re: [PATCH 5/6] rcuscale: Do a proper cleanup if kfree_scale_init() fails

2024-11-11 Thread Uladzislau Rezki
On Mon, Nov 11, 2024 at 11:53:45AM +0100, Uladzislau Rezki wrote: > On Mon, Nov 11, 2024 at 03:24:38PM +0530, Neeraj Upadhyay wrote: > > > > > diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c > > > index 6d37596deb1f..de7d511e6be4 100644 > > > --- a/kernel/rcu/rcuscale.c > > > +++ b/kern

[GIT PULL] virtio: bugfixes

2024-11-11 Thread Michael S. Tsirkin
The following changes since commit 59b723cd2adbac2a34fc8e12c74ae26ae45bf230: Linux 6.12-rc6 (2024-11-03 14:05:52 -1000) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 83e445e64f48bdae3f25013

Re: [PATCH] virtio_ring: skip cpu sync when mapping fails

2024-11-11 Thread Jason Wang
On Mon, Nov 11, 2024 at 3:30 PM Michael S. Tsirkin wrote: > > On Mon, Nov 11, 2024 at 10:55:38AM +0800, Jason Wang wrote: > > There's no need to sync DMA for CPU on mapping errors. So this patch > > skips the CPU sync in the error handling path of DMA mapping. > > > > Signed-off-by: Jason Wang >

[PATCH] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-11 Thread Suraj Sonawane
Fix an issue detected by syzbot with KASAN: BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ core.c:416 [inline] BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0 drivers/acpi/nfit/core.c:459 The issue occurs in `cmd_to_func` when the `call_pkg->nd_reserved2` arr

Re: [RFC][PATCH 6/8] module: Add module specific symbol namespace support

2024-11-11 Thread Sean Christopherson
On Mon, Nov 11, 2024, Christoph Hellwig wrote: > On Mon, Nov 11, 2024 at 11:54:36AM +0100, Peter Zijlstra wrote: > > Designate the "MODULE_${modname}" symbol namespace to mean: 'only > > export to the named module'. > > > > Notably, explicit imports of anything in the "MODULE_" space is > > forbid

[PATCH] kselftest/arm64: Enable build of PAC tests with LLVM=1

2024-11-11 Thread Mark Brown
ll -o /dev/null 2>&1) then echo "1"; fi) +endif ifeq ($(pauth_cc_support),1) TEST_GEN_PROGS := pac --- base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354 change-id: 2024-arm64-selftest-pac-clang-cb80de079169 Best regards, -- Mark Brown

Re: [RFC PATCH 3/3] module: pre-test setting ro_after_init data read-only

2024-11-11 Thread Christophe Leroy
Le 09/11/2024 à 22:03, Daniel Gomez a écrit : On Sat Nov 9, 2024 at 11:35 AM CET, Christophe Leroy wrote: To be on the safe side, try to set ro_after_init data section readonly at the same time as rodata. If it fails it will likely fail again later so let's cancel module loading while we stil

Re: [RFC PATCH 2/3] module: Don't fail module loading when setting ro_after_init section RO failed

2024-11-11 Thread Christophe Leroy
Le 09/11/2024 à 23:17, Daniel Gomez a écrit : On Sat Nov 9, 2024 at 11:35 AM CET, Christophe Leroy wrote: Once module init has succeded it is too late to cancel loading. If setting ro_after_init data section to read-only fails, all we can do is to inform the user through a warning. Reported-

[PATCH 0/2] kselftest/arm64: Avoid detecting spurious PAC key collisions

2024-11-11 Thread Mark Brown
--- base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354 change-id: 2024-arm64-pac-test-collisions-5613f5dfe479 Best regards, -- Mark Brown

[PATCH 2/2] kselftest/arm64: Try harder to generate different keys during PAC tests

2024-11-11 Thread Mark Brown
We very intermittently see failures in the single_thread_different_keys PAC test. As noted in the comment in the test the PAC field can be quite narrow so there is a chance of collisions even with different keys with a chance of 5% for 7 bit keys, and the potential for narrower keys. The test tries

[PATCH 1/2] kselftest/arm64: Don't leak pipe fds in pac.exec_sign_all()

2024-11-11 Thread Mark Brown
The PAC exec_sign_all() test spawns some child processes, creating pipes to be stdin and stdout for the child. It cleans up most of the file descriptors that are created as part of this but neglects to clean up the parent end of the child stdin and stdout. Add the missing close() calls. Signed-off

Re: [PATCH] kunit: skb: add gfp to kernel doc for kunit_zalloc_skb()

2024-11-11 Thread Kuan-Wei Chiu
On Mon, Nov 11, 2024 at 01:54:09PM +0300, Dan Carpenter wrote: > Kuan-Wei Chiu pointed out that the kernel doc for kunit_zalloc_skb() > needs to include the @gfp information. Add it. > > Reported-by: Kuan-Wei Chiu > Closes: > https://lore.kernel.org/all/Zy+VIXDPuU613fFd@visitorckw-System-Produc

Re: [PATCH rcu 08/15] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-11 Thread Paul E. McKenney
On Mon, Nov 11, 2024 at 09:46:22AM -0800, Andrii Nakryiko wrote: > On Mon, Nov 11, 2024 at 7:17 AM Paul E. McKenney wrote: > > > > On Mon, Nov 11, 2024 at 04:47:49PM +0530, Neeraj Upadhyay wrote: > > > > > > > +/** > > > > + * srcu_read_unlock_lite - unregister a old reader from an > > > > SRCU-p

Re: [PATCH rcu 08/15] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-11 Thread Paul E. McKenney
On Mon, Nov 11, 2024 at 04:47:49PM +0530, Neeraj Upadhyay wrote: > > > +/** > > + * srcu_read_unlock_lite - unregister a old reader from an SRCU-protected > > structure. > > + * @ssp: srcu_struct in which to unregister the old reader. > > + * @idx: return value from corresponding srcu_read_lock(

Re: [PATCH rcu 06/12] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-11 Thread Paul E. McKenney
On Mon, Nov 11, 2024 at 06:24:58PM +0530, Neeraj Upadhyay wrote: > > > > > /* > > - * Returns approximate total of the readers' ->srcu_lock_count[] values > > - * for the rank of per-CPU counters specified by idx. > > + * Computes approximate total of the readers' ->srcu_lock_count[] values > >

Re: [PATCH] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-11 Thread kernel test robot
Hi Suraj, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.12-rc7 next-2024] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH rcu 06/12] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-11 Thread Neeraj Upadhyay
On 11/11/2024 8:56 PM, Paul E. McKenney wrote: > On Mon, Nov 11, 2024 at 06:24:58PM +0530, Neeraj Upadhyay wrote: >> >>> >>> /* >>> - * Returns approximate total of the readers' ->srcu_lock_count[] values >>> - * for the rank of per-CPU counters specified by idx. >>> + * Computes approximate

Re: [PATCH] mac802154: add a check for slave data list before delete

2024-11-11 Thread Miquel Raynal
Hello, On 08/11/2024 at 22:54:20 +08, Lizhi Xu wrote: > syzkaller reported a corrupted list in ieee802154_if_remove. [1] > > Remove an IEEE 802.15.4 network interface after unregister an IEEE 802.15.4 > hardware device from the system. > > CPU0 CPU1 >

Re: [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

2024-11-11 Thread Karel Balej
Lee Jones, 2024-10-15T09:36:03+01:00: > On Sat, 12 Oct 2024, Karel Balej wrote: > > > Add a MFD cell for the chip's real-time clock. > > > > Signed-off-by: Karel Balej > > --- > > > > Notes: > > RFC v2: > > - Break out the register definitions and reword the commit message > > acco

[PATCH net v2 2/2] selftests: drv-net: rss_ctx: Add test for ntuple rule

2024-11-11 Thread Daniel Xu
Extend the rss_ctx test suite to test that an ntuple action that redirects to an RSS context contains that information in `ethtool -n`. Otherwise the output from ethtool is highly deceiving. This test helps ensure drivers are compliant with the API. Signed-off-by: Daniel Xu --- tools/testing/sel

[PATCH net v2 0/2] bnxt: Fix failure to report RSS context in ntuple rule

2024-11-11 Thread Daniel Xu
This patchset fixes a bug where bnxt driver was failing to report that an ntuple rule is redirecting to an RSS context. First commit is the fix, then second commit extends selftests to detect if other/new drivers are compliant with ntuple/rss_ctx API. Daniel Xu (2): bnxt_en: ethtool: Supply ntup

Re: [PATCH rcu 2/3] srcu: Check for srcu_read_lock_lite() across all CPUs

2024-11-11 Thread Neeraj Upadhyay
On 11/12/2024 7:01 AM, Paul E. McKenney wrote: > If srcu_read_lock_lite() is used on a given srcu_struct structure, then > the grace-period processing must to synchronize_rcu() instead of smp_mb() s/to/do/ > between the scans of the ->srcu_unlock_count[] and ->srcu_lock_count[] > counters. Cu

Re: [PATCH net-next] net: netconsole: selftests: Check if netdevsim is available

2024-11-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 08 Nov 2024 06:59:25 -0800 you wrote: > The netconsole selftest relies on the availability of the netdevsim module. > To ensure the test can run correctly, we need to check if the netdevsim > module is either

Re: [syzbot] [wpan?] [usb?] BUG: corrupted list in ieee802154_if_remove

2024-11-11 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-by: syzbot+985f827280dc3a6e7...@syzkaller.appspotmail.com Tested-by: syzbot+985f827280dc3a6e7...@syzkaller.appspotmail.com Tested on: commit: 2d5404ca Linux 6.12-rc7 git tree: upstr

Re: [PATCH rcu 3/3] srcu: Unconditionally record srcu_read_lock_lite() in ->srcu_reader_flavor

2024-11-11 Thread Neeraj Upadhyay
... > +void __srcu_check_read_flavor(struct srcu_struct *ssp, int read_flavor); > + > +// Record _lite() usage even for CONFIG_PROVE_RCU=n kernels. > +static inline void srcu_check_read_flavor_lite(struct srcu_struct *ssp) > +{ > + struct srcu_data *sdp = raw_cpu_ptr(ssp->sda); > + > + if

Re: [PATCH v3 rcu 0/13] SRCU-lite changes for v6.13

2024-11-11 Thread Neeraj Upadhyay
On 10/15/2024 9:41 PM, Paul E. McKenney wrote: > Hello! > > This v3 series adds support and testing for srcu_read_lock_lite() > and srcu_read_unlock_lite(), which avoid smp_mb(), but add a couple of > synchronize_rcu() calls to the grace-period processing and may only be > used where RCU is watchi

Re: [PATCH rcu 11/15] rcutorture: Add reader_flavor parameter for SRCU readers

2024-11-11 Thread Neeraj Upadhyay
On 10/15/2024 9:41 PM, Paul E. McKenney wrote: > This commit adds an rcutorture.reader_flavor parameter whose bits > correspond to reader flavors. For example, SRCU's readers are 0x1 for > normal and 0x2 for NMI-safe. > > Signed-off-by: Paul E. McKenney > Cc: Alexei Starovoitov > Cc: Andrii Nak

[PATCH v2] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-11 Thread Suraj Sonawane
Fix an issue detected by syzbot with KASAN: BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ core.c:416 [inline] BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0 drivers/acpi/nfit/core.c:459 The issue occurs in `cmd_to_func` when the `call_pkg->nd_reserved2` arr

Re: [PATCH rcu 2/3] srcu: Check for srcu_read_lock_lite() across all CPUs

2024-11-11 Thread Paul E. McKenney
On Tue, Nov 12, 2024 at 08:58:08AM +0530, Neeraj Upadhyay wrote: > On 11/12/2024 7:01 AM, Paul E. McKenney wrote: > > If srcu_read_lock_lite() is used on a given srcu_struct structure, then > > the grace-period processing must to synchronize_rcu() instead of smp_mb() > > s/to/do/ Good eyes, fixed

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-11 Thread Masahiro Yamada
On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen wrote: > > To avoid duplication between host programs, move the crc32 code to a > shared header file. Only the motivation to use this long table is to keep compatibility between genksyms and gendwarfksyms. I do not think this should be exposed to oth

Re: [PATCH v5 18/19] kbuild: Add gendwarfksyms as an alternative to genksyms

2024-11-11 Thread Masahiro Yamada
On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen wrote: > > When MODVERSIONS is enabled, allow selecting gendwarfksyms as the > implementation, but default to genksyms. > > Signed-off-by: Sami Tolvanen > Acked-by: Neal Gompa > --- > kernel/module/Kconfig | 25 - > scripts/

Re: [PATCH rcu 06/12] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-11 Thread Neeraj Upadhyay
I am trying to understand the (unlikely) case where synchronize_srcu() is done before any srcu reader lock/unlock lite call is done. Can new SRCU readers fail to observe the updates? >>> >>> If a SRCU reader fail to observe the index flip, then isn't it the case >>> t

Re: [PATCH rcu 1/3] srcu: Remove smp_mb() from srcu_read_unlock_lite()

2024-11-11 Thread Neeraj Upadhyay
On 11/12/2024 7:01 AM, Paul E. McKenney wrote: > The srcu_read_unlock_lite() function invokes __srcu_read_unlock() instead > of __srcu_read_unlock_lite(), which means that it is doing an unnecessary > smp_mb(). This is harmless other than the performance degradation. > > This commit therefore

Re: [PATCH] kunit: skb: add gfp to kernel doc for kunit_zalloc_skb()

2024-11-11 Thread David Gow
On Mon, 11 Nov 2024 at 18:54, Dan Carpenter wrote: > > Kuan-Wei Chiu pointed out that the kernel doc for kunit_zalloc_skb() > needs to include the @gfp information. Add it. > > Reported-by: Kuan-Wei Chiu > Closes: > https://lore.kernel.org/all/Zy+VIXDPuU613fFd@visitorckw-System-Product-Name/ >