On Tue, Nov 05, 2024 at 10:26:40AM -0800, Chris Lew wrote:
> On 11/4/2024 9:08 PM, Johan Hovold wrote:
> > On Mon, Nov 04, 2024 at 04:26:15PM -0800, Chris Lew wrote:
> >> This looks like the null pointer would happen if qrtr tried to send
> >> before mhi_channel_prepare() is called.
> >> I think
There is a bunch of places where error() calls look out of place.
Use the same error(1, errno, ...) pattern everywhere.
Reviewed-by: Mina Almasry
Reviewed-by: Joe Damato
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/net/ncdevmem.c | 16
1 file changed, 8 insert
So we can plug the other ones in the future if needed.
Reviewed-by: Mina Almasry
Reviewed-by: Joe Damato
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/net/ncdevmem.c | 203 +++--
1 file changed, 119 insertions(+), 84 deletions(-)
diff --git a/tools/testing/
In the next patch the hard-coded queue numbers are gonna be removed.
So introduce some initial support for ethtool YNL and use
it to enable header split.
Also, tcp-data-split requires latest ethtool which is unlikely
to be present in the distros right now.
(ideally, we should not shell out to eth
This will be used as a 'probe' mode in the selftest to check whether
the device supports the devmem or not. Use hard-coded queue layout
(two last queues) and prevent user from passing custom -q and/or -t.
Reviewed-by: Mina Almasry
Reviewed-by: Joe Damato
Signed-off-by: Stanislav Fomichev
---
t
Only RX side for now and small message to test the setup.
In the future, we can extend it to TX side and to testing
both sides with a couple of megs of data.
make \
-C tools/testing/selftests \
TARGETS="drivers/hw/net" \
install INSTALL_PATH=~/tmp/ksft
scp ~/tmp/ksft $
That should make it possible to do expected payload validation on
the caller side.
Reviewed-by: Mina Almasry
Reviewed-by: Joe Damato
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/net/ncdevmem.c | 61 +-
1 file changed, 30 insertions(+), 31 deletions(-)
Support 3-tuple filtering by making client_ip optional. When -c is
not passed, don't specify src-ip/src-port in the filter.
Reviewed-by: Mina Almasry
Reviewed-by: Joe Damato
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/net/ncdevmem.c | 12 +---
1 file changed, 9 insert
To make it clear what's required and what's not. Also, some of the
values don't seem like a good defaults; for example eth1.
Move the invocation comment to the top, add missing -s to the client
and cleanup the client invocation a bit to make more readable.
Reviewed-by: Mina Almasry
Reviewed-by:
Use dualstack socket to support both v4 and v6. v4-mapped-v6 address
can be used to do v4.
Reviewed-by: Mina Almasry
Reviewed-by: Joe Damato
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/net/ncdevmem.c | 97 ++
1 file changed, 68 insertions(+), 29 deleti
Use single last queue of the device and probe it dynamically.
Reviewed-by: Mina Almasry
Reviewed-by: Joe Damato
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/net/ncdevmem.c | 40 --
1 file changed, 38 insertions(+), 2 deletions(-)
diff --git a/tools/tes
ntuple off/on might be not enough to do it on all NICs.
Add a bunch of shell crap to explicitly remove the rules.
Reviewed-by: Mina Almasry
Reviewed-by: Joe Damato
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/net/ncdevmem.c | 19 ---
1 file changed, 12 insertio
This is where all the tests that depend on the HW functionality live in
and this is where the automated test is gonna be added in the next
patch.
Reviewed-by: Mina Almasry
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/drivers/net/hw/.gitignore | 1 +
tools/testing/selfte
On Thu, Nov 7, 2024 at 2:21 PM Colin Ian King wrote:
>
> The boolean variable has_affinity is true when desc is non-null and
> ops->set_vq_affinity is non-null. Hence the call to create_affinity_masks
> does not need to check for desc being non-null is redundant when
> has_affinity is true, so it
On 07.11.24 13:18, Miklos Szeredi wrote:
On Thu, 7 Nov 2024 at 11:00, Hanna Czenczek wrote:
It isn’t much, but I believe it’s most of fuse_fill_super_common()
(without restructuring the code so flags returned by INIT are put into a
separate structure and then re-joined into sb and fc later).
P
The goal of the series is to simplify and make it possible to use
ncdevmem in an automated way from the ksft python wrapper.
ncdevmem is slowly mutated into a state where it uses stdout
to print the payload and the python wrapper is added to
make sure the arrived payload matches the expected one.
On Thu, Nov 07, 2024 at 02:01:17PM +, Zilin Guan wrote:
> On Wed, Nov 06, 2024 at 12:18:25PM -0800, Paul E. McKenney wrote:
> > Good eyes!!!
> >
> > But did you find this with KCSAN, or by visual inspection?
> >
> > The reason that I ask is that the __note_gp_changes() should be
> > invoked w
On Thu, Nov 07, 2024 at 04:55:46PM +0900, Masahiro Yamada wrote:
> > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> > index 107393a8c48a..d1de3044ee03 100644
> > --- a/scripts/mod/modpost.c
> > +++ b/scripts/mod/modpost.c
> > @@ -1553,8 +1553,19 @@ static void mod_set_crcs(struct modu
On Thu, Nov 07, 2024 at 10:12:11AM -0800, Stanislav Fomichev wrote:
> Only RX side for now and small message to test the setup.
> In the future, we can extend it to TX side and to testing
> both sides with a couple of megs of data.
>
> make \
> -C tools/testing/selftests \
> TARGETS=
On Thu, 07 Nov 2024 01:39:19 +, Mark Brown wrote:
> Currently we test signal delivery to the programs run by fp-stress but
> our signal handlers simply count the number of signals seen and don't do
> anything with the floating point state. The original fpsimd-test and
> sve-test programs had s
On Wed, 30 Oct 2024 00:02:01 +, Mark Brown wrote:
> One of the things that fp-stress does to stress the floating point
> context switching is send signals to the test threads it spawns.
> Currently we do this once per second but as suggested by Mark Rutland if
> we increase this we can improve
On Thu, Nov 07, 2024 at 10:11:59AM -0800, Stanislav Fomichev wrote:
> The goal of the series is to simplify and make it possible to use
> ncdevmem in an automated way from the ksft python wrapper.
>
> ncdevmem is slowly mutated into a state where it uses stdout
> to print the payload and the pytho
vhost: Add kthread support in function
> vhost_worker_queue()
> config: x86_64-randconfig-161-20241106
> (https://download.01.org/0day-ci/archive/20241107/202411071251.tqlg8k6c-...@intel.com/config)
> compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project
> ab51eccf88f53
Fixed coding style issues reported by checkpatch script
---
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
index 6caf09a1907b..0705aff74cf3 100644
--- a/driv
On Wed, Nov 6, 2024 at 10:27 PM Lucas De Marchi
wrote:
>
> On Wed, Nov 06, 2024 at 02:19:38PM -0800, Matthew Maurer wrote:
> >>
> >> > If booted against an old kernel, it will
> >> > behave as though there is no modversions information.
> >>
> >> Huh? This I don't get. If you have the new libkmod
On Wed, 6 Nov 2024 at 23:04, Andrii Nakryiko wrote:
> I'm sorry, but unfortunately it's too late now to move those patches
> as it's now been more than a month since they landed. For the future,
> please let us know ASAP if you think patches were misrouted. I think
> we are stuck with the need to
On Sun, Nov 3, 2024 at 6:35 AM Yunsheng Lin wrote:
>
> On 11/1/2024 9:10 PM, Mina Almasry wrote:
>
> ...
>
> >>
> >> Isn't it a little odd that old and new are not following the same
> >> pattern?
> >
> > Hi Yunsheng,
> >
> > The intention is that page_pool_alloc_pages is mirrored by
> > page_pool
Jan Kara wrote:
> On Wed 06-11-24 11:59:44, Dan Williams wrote:
> > Jan Kara wrote:
> > [..]
> > > > This WARN still feels like the wrong thing, though. Right now it is the
> > > > only thing in DAX code complaining on a page size/block size mismatch
> > > > (at least for virtiofs). If this is so i
Asahi Lina wrote:
[..]
> I don't think that's how it actually works, at least on arm64.
> arch_wb_cache_pmem() calls dcache_clean_pop() which is either dc cvap or
> dc cvac. Those are trapped by HCR_EL2, and that is never set by KVM.
>
> There was some discussion of this here:
> https://lore.kerne
On Wed, Sep 04, 2024 at 10:11:14AM -0500, Carlos Bilbao wrote:
> From: Carlos Bilbao
>
> Initialize the speed and duplex fields in virtio_net_config to UNKNOWN.
> This is needed because mlx5_vdpa vDPA devices currently do not support the
> VIRTIO_NET_F_SPEED_DUPLEX feature which reports speed and
On Wed, Nov 06, 2024 at 02:19:38PM -0800, Matthew Maurer wrote:
> >
> > > If booted against an old kernel, it will
> > > behave as though there is no modversions information.
> >
> > Huh? This I don't get. If you have the new libkmod and boot
> > an old kernel, that should just not break becauase w
On Wed, Nov 06, 2024 at 06:46:48PM +, Sami Tolvanen wrote:
> Hi Luis,
>
> On Wed, Nov 6, 2024 at 12:24 AM Luis Chamberlain wrote:
> >
> > Use 0 for the values as we use them for the return value on init
> > to keep the test modules simple. This fixes a splat reported
> >
> > do_init_module: '
Adding Lucas DeMarchi to the thread after voicing an interest in the
modpost patch.
On Thu, Oct 31, 2024 at 12:49 AM Luis Chamberlain wrote:
>
> On Wed, Oct 30, 2024 at 10:06:12PM -0700, Matthew Maurer wrote:
> > On Wed, Oct 30, 2024 at 9:37 PM Luis Chamberlain wrote:
> > >
> > > On Thu, Oct 31,
On Tue, Nov 05, 2024 at 09:16:40AM +1100, Dave Chinner wrote:
> The DAX infrastructure needs the same changes for fsb > page size
> support. We have a limited number bits we can use for DAX entry
> state:
>
> /*
> * DAX pagecache entries use XArray value entries so they can't be mistaken
> * for
On Wed, Nov 06, 2024 at 12:18:25PM -0800, Paul E. McKenney wrote:
> Good eyes!!!
>
> But did you find this with KCSAN, or by visual inspection?
>
> The reason that I ask is that the __note_gp_changes() should be
> invoked with the leaf rnp->lock held, which should exclude writes to
> the rdp->gpw
On 11/8/24 6:24 AM, Dan Williams wrote:
> Asahi Lina wrote:
> [..]
>> I don't think that's how it actually works, at least on arm64.
>> arch_wb_cache_pmem() calls dcache_clean_pop() which is either dc cvap or
>> dc cvac. Those are trapped by HCR_EL2, and that is never set by KVM.
>>
>> There was
On 07.11.24 09:58, Miklos Szeredi wrote:
On Thu, 24 Oct 2024 at 18:47, Hanna Czenczek wrote:
To be able to issue INIT (and GETATTR), we need to at least partially
initialize the super_block structure, which is currently done via
fuse_fill_super_common().
What exactly is needed to be initializ
On Wed 06-11-24 11:59:44, Dan Williams wrote:
> Jan Kara wrote:
> [..]
> > > This WARN still feels like the wrong thing, though. Right now it is the
> > > only thing in DAX code complaining on a page size/block size mismatch
> > > (at least for virtiofs). If this is so important, I feel like there
On Thu, Nov 07, 2024 at 03:12:49PM +0800, Cindy Lu wrote:
On Tue, Nov 5, 2024 at 6:32 PM Stefano Garzarella wrote:
On Tue, Nov 05, 2024 at 03:25:26PM +0800, Cindy Lu wrote:
>Add a new UAPI to enable setting the vhost device to task mode.
>The userspace application can use VHOST_SET_INHERIT_FRO
Le Thu, Nov 07, 2024 at 10:10:37AM +0100, Thorsten Leemhuis a écrit :
> On 05.11.24 08:17, Mingcong Bai wrote:
> > (CC-ing the laptop's owner so that she might help with further testing...)
> > 在 2024-10-23 18:22，Linux regression tracking (Thorsten Leemhuis) 写道：
> >> On 23.10.24 12:09, Frederic Wei
On Thu, Nov 07, 2024 at 12:58:19PM +0100, Peter Zijlstra wrote:
> Anyway, let me see about doing that whole ',' parsing thing people seem
> to want.
git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git module/namespace
Seems to work with very limited testing.
On Wed, Oct 30, 2024 at 12:02:01AM +, Mark Brown wrote:
> One of the things that fp-stress does to stress the floating point
> context switching is send signals to the test threads it spawns.
> Currently we do this once per second but as suggested by Mark Rutland if
> we increase this we can im
-ci/archive/20241107/202411071945.exiehgox-...@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project
ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add
On 11/5/24 21:31, Joe Damato wrote:
> On Mon, Nov 04, 2024 at 04:57:06PM +0800, Philo Lu wrote:
>> RSS configuration should be updated with queue number. In particular, it
>> should be updated when (1) rss enabled and (2) default rss configuration
>> is used without user modification.
>>
>> During
The boolean variable has_affinity is true when desc is non-null and
ops->set_vq_affinity is non-null. Hence the call to create_affinity_masks
does not need to check for desc being non-null is redundant when
has_affinity is true, so it can be removed as well as the now unused
default_affd.
Signed-o
Hello:
This series was applied to netdev/net.git (main)
by Paolo Abeni :
On Mon, 4 Nov 2024 16:57:02 +0800 you wrote:
> With this patch set, RSS updates with queue_pairs changing:
> - When virtnet_probe, init default rss and commit
> - When queue_pairs changes _without_ user rss configuration, u
On 05.11.24 08:17, Mingcong Bai wrote:
> (CC-ing the laptop's owner so that she might help with further testing...)
> 在 2024-10-23 18:22，Linux regression tracking (Thorsten Leemhuis) 写道：
>> On 23.10.24 12:09, Frederic Weisbecker wrote:
>>> Le Wed, Oct 23, 2024 at 10:27:18AM +0200, Linux regression
On Thu, Nov 7, 2024 at 6:03 PM Stefano Garzarella wrote:
>
> On Thu, Nov 07, 2024 at 03:12:49PM +0800, Cindy Lu wrote:
> >On Tue, Nov 5, 2024 at 6:32 PM Stefano Garzarella
> >wrote:
> >>
> >> On Tue, Nov 05, 2024 at 03:25:26PM +0800, Cindy Lu wrote:
> >> >Add a new UAPI to enable setting the vho
On Wed, Nov 06, 2024 at 04:37:57AM -0500, Michael S. Tsirkin wrote:
> On Fri, Jul 12, 2024 at 07:59:14PM +0530, Manivannan Sadhasivam wrote:
> > Virtio spec has so far only supported MSI-X and INTX for receiving the
> > interrupts from the virtio device on PCI transport. But this becomes a
> > limi
Hi all,
在 2024-11-07 18:04，Frederic Weisbecker 写道：
Le Thu, Nov 07, 2024 at 10:10:37AM +0100, Thorsten Leemhuis a écrit :
On 05.11.24 08:17, Mingcong Bai wrote:
> (CC-ing the laptop's owner so that she might help with further testing...)
> 在 2024-10-23 18:22，Linux regression tracking (Thorsten L
-ci/archive/20241107/202411071251.tqlg8k6c-...@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project
ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following
On Thu, 7 Nov 2024 at 11:00, Hanna Czenczek wrote:
> It isn’t much, but I believe it’s most of fuse_fill_super_common()
> (without restructuring the code so flags returned by INIT are put into a
> separate structure and then re-joined into sb and fc later).
Probably not worth it.
> fuse_send_ini
On 11/7/24 7:01 PM, Jan Kara wrote:
> On Wed 06-11-24 11:59:44, Dan Williams wrote:
>> Jan Kara wrote:
>> [..]
This WARN still feels like the wrong thing, though. Right now it is the
only thing in DAX code complaining on a page size/block size mismatch
(at least for virtiofs). If
On Thu, Nov 7, 2024 at 2:46 PM Christoph Hellwig wrote:
>
> On Wed, Nov 06, 2024 at 03:42:03PM -0800, Luis Chamberlain wrote:
> > > This allows exports targeted at specific modules and no others -- one
> > > random example included. I've hated the various kvm exports we've had
> > > for a while, a
Hi Liu Hangbin,
On Thu, Nov 07, 2024 at 02:54:38AM +, Hangbin Liu wrote:
> Use nft by default if it's supported, as nft is the replacement for iptables,
> which is used by default in some releases. Additionally, iptables is dropped
> in some releases.
>
> Signed-off-by: Hangbin Liu
> ---
> C
Hi Jason,
Le 01/09/2024 à 15:22, Jason A. Donenfeld a écrit :
Hi Christophe,
Hmm, I'm not so sure I like this very much. I think it's important for
these tests to fail when an arch tries to hook up the function to the
vDSO, but it's still not exported for some reason. This also regresses
the AR
On Thu, 24 Oct 2024 at 18:47, Hanna Czenczek wrote:
> To be able to issue INIT (and GETATTR), we need to at least partially
> initialize the super_block structure, which is currently done via
> fuse_fill_super_common().
What exactly is needed to be initialized?
> @@ -1762,18 +1801,12 @@ int fus
Add an epoll busy poll test using netdevsim.
This test is comprised of:
- busy_poller (via busy_poller.c)
- busy_poll_test.sh which loads netdevsim, sets up network namespaces,
and runs busy_poller to receive data and socat to send data.
The selftest tests two different scenarios:
- bus
On 11/07, Joe Damato wrote:
> On Thu, Nov 07, 2024 at 10:11:59AM -0800, Stanislav Fomichev wrote:
> > The goal of the series is to simplify and make it possible to use
> > ncdevmem in an automated way from the ksft python wrapper.
> >
> > ncdevmem is slowly mutated into a state where it uses stdou
This happens on 64-bit big-endian machines.
SO_RCVLOWAT requires an int parameter. However, instead of int, the test
uses unsigned long in one place and size_t in another. Both are 8 bytes
long on 64-bit machines. The kernel, having received the 8 bytes, doesn't
test for the exact size of the param
Change parameters of SO_VM_SOCKETS_* to unsigned long long as documented
in the vm_sockets.h, because the corresponding kernel code requires them
to be at least 64-bit, no matter what architecture. Otherwise they are
too small on 32-bit machines.
Fixes: 5c338112e48a ("test/vsock: rework message bo
Replace setsockopt() calls with calls to functions that follow
setsockopt() with getsockopt() and check that the returned value and its
size are the same as have been set.
Signed-off-by: Konstantin Shkolnyy
---
tools/testing/vsock/Makefile | 8 +-
tools/testing/vsock/control.c
Parameters were created using wrong C types, which caused them to be of
wrong size on some architectures, causing problems.
The problem with SO_RCVLOWAT was found on s390 (big endian), while x86-64
didn't show it. After the fix, all tests pass on s390.
Then Stefano Garzarella pointed out that SO_V
Add an epoll busy poll test using netdevsim.
This test is comprised of:
- busy_poller (via busy_poller.c)
- busy_poll_test.sh which loads netdevsim, sets up network namespaces,
and runs busy_poller to receive data and socat to send data.
The selftest tests two different scenarios:
- bus
64 matches
Mail list logo
