Re: [PATCH v2 2/2] kunit: enable hardware acceleration when available

2024-11-05 Thread Kristina Martsenko
On 02/11/2024 12:09, Tamir Duberstein wrote: > Use KVM or HVF if supported by the QEMU binary and available on the > system. > > This produces a nice improvement on my Apple M3 Pro running macOS 14.7: > > Before: > ./tools/testing/kunit/kunit.py exec --arch arm64 > [HH:MM:SS] Elapsed time: 10.145

Re: [PATCH RESEND v13 00/12] Initial Marvell PXA1908 support

2024-11-05 Thread Rob Herring (Arm)
On Mon, 04 Nov 2024 17:37:02 +0100, Duje Mihanović wrote: > Hello, > > This series adds initial support for the Marvell PXA1908 SoC and > "samsung,coreprimevelte", a smartphone using the SoC. > > USB works and the phone can boot a rootfs from an SD card, but there are > some warnings in the dme

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-05 Thread Sabrina Dubroca
2024-10-30, 21:47:58 +0100, Antonio Quartulli wrote: > On 30/10/2024 17:37, Sabrina Dubroca wrote: > > 2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote: > > > +static void ovpn_peer_release(struct ovpn_peer *peer) > > > +{ > > > + ovpn_bind_reset(peer, NULL); > > > + > > > + dst_cache_destroy(&p

[PATCH v3 6/9] vhost: Add kthread support in function vhost_worker_destroy()

2024-11-05 Thread Cindy Lu
The function vhost_worker_destroy() will use struct vhost_task_fn and selects the different mode based on the value of inherit_owner. Signed-off-by: Cindy Lu --- drivers/vhost/vhost.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/

[PATCH v3 4/9] vhost: Add kthread support in function vhost_worker_create

2024-11-05 Thread Cindy Lu
Restored the previous functions kthread_wakeup and kthread_stop. Also add a new structure, vhost_task_fn. The function vhost_worker_create Will initializes this structure based on the value of inherit_owner. Signed-off-by: Cindy Lu --- drivers/vhost/vhost.c | 71 +

[PATCH v3 9/9] vhost: Expose the modparam inherit_owner_default

2024-11-05 Thread Cindy Lu
Expose the inherit_owner_default modparam by module_param(). Signed-off-by: Cindy Lu --- drivers/vhost/vhost.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 70c793b63905..1a4ccf4f7316 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vh

Re: [PATCH v2 2/2] kunit: enable hardware acceleration when available

2024-11-05 Thread David Gow
On Sat, 2 Nov 2024 at 20:10, Tamir Duberstein wrote: > > Use KVM or HVF if supported by the QEMU binary and available on the > system. > > This produces a nice improvement on my Apple M3 Pro running macOS 14.7: > > Before: > ./tools/testing/kunit/kunit.py exec --arch arm64 > [HH:MM:SS] Elapsed tim

Re: [PATCH v2 1/2] kunit: add fallback for os.sched_getaffinity

2024-11-05 Thread David Gow
On Sat, 2 Nov 2024 at 20:10, Tamir Duberstein wrote: > > Python 3.13 added os.process_cpu_count as a cross-platform alternative > for the Linux-only os.sched_getaffinity. Use it when it's available and > provide a fallback when it's not. > > This allows kunit to run on macOS. > > Signed-off-by: Ta

[PATCH v3 8/9] vhost_scsi: Add check for inherit_owner status

2024-11-05 Thread Cindy Lu
The vhost_scsi VHOST_NEW_WORKER requires the inherit_owner setting to be true. So we need to implement a check for this. Signed-off-by: Cindy Lu --- drivers/vhost/scsi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 006ffacf1c56..05290

Re: [PATCH v3 7/9] vhost: Add new UAPI to support change to task mode

2024-11-05 Thread Jason Wang
On Tue, Nov 5, 2024 at 3:28 PM Cindy Lu wrote: > > Add a new UAPI to enable setting the vhost device to task mode. > The userspace application can use VHOST_SET_INHERIT_FROM_OWNER > to configure the mode if necessary. > This setting must be applied before VHOST_SET_OWNER, as the worker > will be c

Testing Quality Call notes - 2024-10-31

2024-11-05 Thread Laura Nao
Hello, KernelCI is hosting a bi-weekly call on Thursday to discuss improvements to existing upstream tests, the development of new tests to increase kernel testing coverage, and the enablement of these tests in KernelCI. In recent months, we at Collabora have focused on various kernel areas, ass

Re: [PATCH net-next v2 4/4] selftests: hsr: Add test for VLAN

2024-11-05 Thread MD Danish Anwar
On 31/10/24 8:11 pm, Paolo Abeni wrote: > On 10/24/24 12:30, MD Danish Anwar wrote: >> @@ -183,9 +232,21 @@ trap cleanup_all_ns EXIT >> setup_hsr_interfaces 0 >> do_complete_ping_test >> >> +# Run VLAN Test >> +if $vlan; then >> +setup_vlan_interfaces >> +hsr_vlan_ping >> +fi >> + >>

Re: [syzbot] [lvs?] possible deadlock in start_sync_thread

2024-11-05 Thread Pablo Neira Ayuso
Hi, I am Cc'ing SHARED MEMORY COMMUNICATIONS (SMC) SOCKETS maintainers. Similar issue already reported by syzkaller here: https://lore.kernel.org/netdev/ZyIgRmJUbnZpzXNV@calendula/T/#mf1f03a65108226102d8567c9fb6bab98c072444c related to smc->clcsock_release_lock. I think this is a false possibl

Re: [PATCH bpf-next 1/2] libbpf: Add missing per-arch include path

2024-11-05 Thread Kexy Biscuit
On 9/27/2024 9:13 PM, Björn Töpel wrote: From: Björn Töpel libbpf does not include the per-arch tools include path, e.g. tools/arch/riscv/include. Some architectures depend those files to build properly. Include tools/arch/$(SUBARCH)/include in the libbpf build. Fixes: 6d74d178fe6e ("tools: A

[syzbot] [acpi?] [nvdimm?] KASAN: vmalloc-out-of-bounds Read in acpi_nfit_ctl (2)

2024-11-05 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:2e1b3cc9d7f7 Merge tag 'arm-fixes-6.12-2' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12418e3058 kernel config: https://syzkaller.appspot.com/x/.config?x=11254d3590b16717 das

Re: [PATCH v5 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled

2024-11-05 Thread Reinette Chatre
Hi Maciej, On 10/29/24 6:00 AM, Maciej Wieczor-Retman wrote: > Sub-NUMA Cluster divides CPUs sharing an L3 cache into separate NUMA > nodes. Systems may support splitting into either two, three or four > nodes. > > When SNC mode is enabled the effective amount of L3 cache available > for allocati

Re: [PATCH v5 2/2] selftests/resctrl: Adjust SNC support messages

2024-11-05 Thread Reinette Chatre
Hi Maciej, On 10/29/24 6:00 AM, Maciej Wieczor-Retman wrote: > Resctrl selftest prints a message on test failure that Sub-Numa > Clustering (SNC) could be enabled and points the user to check their BIOS > settings. No actual check is performed before printing that message so > it is not very accur

[PATCH v3 0/9] vhost: Add support of kthread API

2024-11-05 Thread Cindy Lu
In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), The vhost now use vhost_task and workers working as a child of the owner thread, which aligns with containerization principles. However, this change has caused confusion for some legacy userspace applications. Therefore, we are

Re: [PATCH v3 1/9] vhost: Add a new parameter to allow user select kthread

2024-11-05 Thread Jason Wang
On Tue, Nov 5, 2024 at 3:27 PM Cindy Lu wrote: > > The vhost now uses vhost_task and workers as a child of the owner thread. > While this aligns with containerization principles,it confuses some legacy > userspace app, Therefore, we are reintroducing kthread API support. > > Introduce a new parame

Re: [PATCH v3 4/9] vhost: Add kthread support in function vhost_worker_create

2024-11-05 Thread Jason Wang
On Tue, Nov 5, 2024 at 3:27 PM Cindy Lu wrote: > > Restored the previous functions kthread_wakeup and kthread_stop. > Also add a new structure, vhost_task_fn. The function vhost_worker_create > Will initializes this structure based on the value of inherit_owner. > > Signed-off-by: Cindy Lu > ---

Re: [PATCH v3 5/9] vhost: Add kthread support in function vhost_worker_queue()

2024-11-05 Thread Jason Wang
On Tue, Nov 5, 2024 at 3:27 PM Cindy Lu wrote: > > The function vhost_worker_queue() uses vhost_task_fn and > selects the different mode based on the value of inherit_owner. > > Signed-off-by: Cindy Lu > --- > drivers/vhost/vhost.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) >

Re: [PATCH net v6] ipv6: Fix soft lockups in fib6_select_path under high next hop churn

2024-11-05 Thread Paolo Abeni
On 10/31/24 15:10, David Ahern wrote: > On 10/31/24 4:13 AM, Paolo Abeni wrote: >> Given the issue is long-standing, and the fix is somewhat invasive, I >> suggest steering this patch on net-next. > > FWIW, I think net-next is best. Should I count the above as a formal ack? :-P FWIW, I went thro

Re: [PATCH net-next v11 19/23] ovpn: implement key add/get/del/swap via netlink

2024-11-05 Thread Sabrina Dubroca
2024-10-29, 11:47:32 +0100, Antonio Quartulli wrote: > This change introduces the netlink commands needed to add, get, delete > and swap keys for a specific peer. > > Userspace is expected to use these commands to create, inspect (non > sensible data only), destroy and rotate session keys for a sp

Re: [PATCH net-next v11 20/23] ovpn: kill key and notify userspace in case of IV exhaustion

2024-11-05 Thread Sabrina Dubroca
2024-10-29, 11:47:33 +0100, Antonio Quartulli wrote: > +int ovpn_nl_key_swap_notify(struct ovpn_peer *peer, u8 key_id) > +{ [...] > + > + nla_nest_end(msg, k_attr); > + genlmsg_end(msg, hdr); > + > + genlmsg_multicast_netns(&ovpn_nl_family, dev_net(peer->ovpn->dev), msg, > +

Re: [PATCH v3 7/9] vhost: Add new UAPI to support change to task mode

2024-11-05 Thread Stefano Garzarella
On Tue, Nov 05, 2024 at 03:25:26PM +0800, Cindy Lu wrote: Add a new UAPI to enable setting the vhost device to task mode. The userspace application can use VHOST_SET_INHERIT_FROM_OWNER to configure the mode if necessary. This setting must be applied before VHOST_SET_OWNER, as the worker will be c

Re: [PATCH net-next v6 6/7] selftests: net: Add busy_poll_test

2024-11-05 Thread Joe Damato
On Mon, Nov 04, 2024 at 07:50:21PM -0800, Stanislav Fomichev wrote: > On 11/04, Joe Damato wrote: > > Add an epoll busy poll test using netdevsim. > > > > This test is comprised of: > > - busy_poller (via busy_poller.c) > > - busy_poll_test.sh which loads netdevsim, sets up network namespaces,

[PATCH] vdpa/mlx5: Fix error path during device add

2024-11-05 Thread Dragos Tatulea
In the error recovery path of mlx5_vdpa_dev_add(), the cleanup is executed and at the end put_device() is called which ends up calling mlx5_vdpa_free(). This function will execute the same cleanup all over again. Most resources support being cleaned up twice, but the recent mlx5_vdpa_destroy_mr_res

Re: [PATCH v2 2/2] kunit: enable hardware acceleration when available

2024-11-05 Thread Tamir Duberstein
On Tue, Nov 5, 2024 at 8:36 AM Kristina Martsenko wrote: > > On 02/11/2024 12:09, Tamir Duberstein wrote: > > Use KVM or HVF if supported by the QEMU binary and available on the > > system. > > > > This produces a nice improvement on my Apple M3 Pro running macOS 14.7: > > > > Before: > > ./tools/

Re: [PATCH net-next v11 15/23] ovpn: implement keepalive mechanism

2024-11-05 Thread Sabrina Dubroca
2024-10-29, 11:47:28 +0100, Antonio Quartulli wrote: > @@ -105,6 +132,9 @@ void ovpn_decrypt_post(void *data, int ret) > goto drop; > } > > + /* keep track of last received authenticated packet for keepalive */ > + peer->last_recv = ktime_get_real_seconds(); It doesn'

Re: qrtr/mhi: NULL-deref with in-kernel pd-mapper

2024-11-05 Thread Chris Lew
On 11/4/2024 9:08 PM, Johan Hovold wrote: On Mon, Nov 04, 2024 at 04:26:15PM -0800, Chris Lew wrote: On 11/1/2024 8:01 AM, Johan Hovold wrote: [8.825593] Unable to handle kernel NULL pointer dereference at virtual address 0034 . [9.002030] CPU: 10 UID: 0 PID: 11 Comm

Re: [PATCH net-next v7 06/12] selftests: ncdevmem: Switch to AF_INET6

2024-11-05 Thread Stanislav Fomichev
On 11/04, Stanislav Fomichev wrote: > On 11/04, Jakub Kicinski wrote: > > On Mon, 4 Nov 2024 10:14:24 -0800 Stanislav Fomichev wrote: > > > -static int configure_flow_steering(void) > > > +static int configure_flow_steering(struct sockaddr_in6 *server_sin) > > > { > > > - return run_command("sudo

[PATCH v4 2/2] selftests: tmpfs: Add kselftest support to tmpfs

2024-11-05 Thread Shivam Chaudhary
Replace direct error handling with 'ksft_test_result_*', 'ksft_print_msg' and KSFT_SKIP macros for better reporting. Test logs: Before change: - Without root error: unshare, errno 1 - With root No, output After change: - Without root TAP version 13 1..1 ok 1 # SKIP This test needs root

[PATCH v4 0/2] kselftest: tmpfs: Add ksft macros and skip if no root

2024-11-05 Thread Shivam Chaudhary
This version 4 patch series replace direct error handling methods with ksft macros, which provide better reporting.Currently, when the tmpfs test runs, it does not display any output if it passes,and if it fails (particularly when not run as root),it simply exits without any warning or message.

Re: [PATCH net 3/4] virtio_net: Sync rss config to device when virtnet_probe

2024-11-05 Thread Joe Damato
On Mon, Nov 04, 2024 at 04:57:05PM +0800, Philo Lu wrote: > During virtnet_probe, default rss configuration is initialized, but was > not committed to the device. This patch fix this by sending rss command > after device ready in virtnet_probe. Otherwise, the actual rss > configuration used by devi

Re: [PATCH net 2/4] virtio_net: Add hash_key_length check

2024-11-05 Thread Joe Damato
On Mon, Nov 04, 2024 at 04:57:04PM +0800, Philo Lu wrote: > Add hash_key_length check in virtnet_probe() to avoid possible out of > bound errors when setting/reading the hash key. > > Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") > Signed-off-by: Philo Lu > Signed-off-b

Re: [PATCH net 1/4] virtio_net: Support dynamic rss indirection table size

2024-11-05 Thread Joe Damato
On Mon, Nov 04, 2024 at 04:57:03PM +0800, Philo Lu wrote: > When reading/writing virtio_net_ctrl_rss, we get the indirection table > size from vi->rss_indir_table_size, which is initialized in > virtnet_probe(). However, the actual size of indirection_table was set > as VIRTIO_NET_RSS_MAX_TABLE_LEN

[PATCH v4 1/2] selftests:tmpfs: Add Skip test if not run as root

2024-11-05 Thread Shivam Chaudhary
Add skip test if not run as root, with an appropriate Warning. Add 'ksft_print_header()' and 'ksft_set_plan()' to structure test outputs more effectively. Test logs : Before change: - Without root error: unshare, errno 1 - With root No, output After change: - Without root TAP version 13 1

Re: [PATCH net 4/4] virtio_net: Update rss when set queue

2024-11-05 Thread Joe Damato
On Mon, Nov 04, 2024 at 04:57:06PM +0800, Philo Lu wrote: > RSS configuration should be updated with queue number. In particular, it > should be updated when (1) rss enabled and (2) default rss configuration > is used without user modification. > > During rss command processing, device updates que

Re: [PATCH net-next v1 6/7] net: fix SO_DEVMEM_DONTNEED looping too long

2024-11-05 Thread Stanislav Fomichev
On 11/05, Mina Almasry wrote: > On Wed, Oct 30, 2024 at 8:07 AM Stanislav Fomichev > wrote: > > > > On 10/30, Mina Almasry wrote: > > > On Wed, Oct 30, 2024 at 7:33 AM Stanislav Fomichev > > > wrote: > > > > > > > > On 10/29, Mina Almasry wrote: > > > > > Check we're going to free a reasonable

Re: [PATCH v5 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled

2024-11-05 Thread Reinette Chatre
Hi Maciej, On 10/29/24 6:00 AM, Maciej Wieczor-Retman wrote: > diff --git a/tools/testing/selftests/resctrl/resctrl.h > b/tools/testing/selftests/resctrl/resctrl.h > index 2dda56084588..851b37c9c38a 100644 > --- a/tools/testing/selftests/resctrl/resctrl.h > +++ b/tools/testing/selftests/resctrl/r

Re: [PATCH net-next v1 6/7] net: fix SO_DEVMEM_DONTNEED looping too long

2024-11-05 Thread Mina Almasry
On Wed, Oct 30, 2024 at 8:07 AM Stanislav Fomichev wrote: > > On 10/30, Mina Almasry wrote: > > On Wed, Oct 30, 2024 at 7:33 AM Stanislav Fomichev > > wrote: > > > > > > On 10/29, Mina Almasry wrote: > > > > Check we're going to free a reasonable number of frags in token_count > > > > before sta

Re: [PATCH net-next v1 6/7] net: fix SO_DEVMEM_DONTNEED looping too long

2024-11-05 Thread Mina Almasry
On Tue, Nov 5, 2024 at 1:46 PM Stanislav Fomichev wrote: > > > > Also, the information is useless to the user. If the user sees 'frag > > > > 128 failed to free'. There is nothing really the user can do to > > > > recover at runtime. Only usefulness that could come is for the user to > > > > log t

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-05 Thread Matthew Maurer
On Fri, Nov 1, 2024 at 2:10 PM Luis Chamberlain wrote: > > On Thu, Oct 31, 2024 at 01:00:28PM -0700, Matthew Maurer wrote: > > > The question is, if only extended moversions are used, what new tooling > > > requirements are there? Can you test using only extended modversions? > > > > > > Luis >

Re: [PATCH net-next v1 6/7] net: fix SO_DEVMEM_DONTNEED looping too long

2024-11-05 Thread Stanislav Fomichev
On 11/05, Mina Almasry wrote: > On Tue, Nov 5, 2024 at 1:46 PM Stanislav Fomichev > wrote: > > > > > Also, the information is useless to the user. If the user sees 'frag > > > > > 128 failed to free'. There is nothing really the user can do to > > > > > recover at runtime. Only usefulness that co

Re: [PATCH v3] selftests: add new kallsyms selftests

2024-11-05 Thread Luis Chamberlain
On Tue, Oct 29, 2024 at 09:24:30AM -0700, Sami Tolvanen wrote: > Hi Luis, > > On Mon, Oct 21, 2024 at 12:33 PM Luis Chamberlain wrote: > > > > diff --git a/lib/tests/module/gen_test_kallsyms.sh > > b/lib/tests/module/gen_test_kallsyms.sh > > new file mode 100755 > > index ..e85f10dc1

[PATCH] tests/module/gen_test_kallsyms.sh: use 0 value for variables

2024-11-05 Thread Luis Chamberlain
Use 0 for the values as we use them for the return value on init to keep the test modules simple. This fixes a splat reported do_init_module: 'test_kallsyms_b'->init suspiciously returned 255, it should follow 0/-E convention do_init_module: loading module anyway... CPU: 5 UID: 0 PID: 1873 Comm:

Re: [PATCH net-next] selftests: net: include lib/sh/*.sh with lib.sh

2024-11-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 04 Nov 2024 12:34:26 +0100 you wrote: > Recently, the net/lib.sh file has been modified to include defer.sh from > net/lib/sh/ directory. The Makefile from net/lib has been modified > accordingly, but not the

Re: [PATCH net 4/4] virtio_net: Update rss when set queue

2024-11-05 Thread Philo Lu
On 2024/11/6 04:31, Joe Damato wrote: On Mon, Nov 04, 2024 at 04:57:06PM +0800, Philo Lu wrote: RSS configuration should be updated with queue number. In particular, it should be updated when (1) rss enabled and (2) default rss configuration is used without user modification. During rss comm

[PATCH net-next v7] ipv6: Fix soft lockups in fib6_select_path under high next hop churn

2024-11-05 Thread Omid Ehtemam-Haghighi
Soft lockups have been observed on a cluster of Linux-based edge routers located in a highly dynamic environment. Using the `bird` service, these routers continuously update BGP-advertised routes due to frequently changing nexthop destinations, while also managing significant IPv6 traffic. The lock

Re: [PATCH net-next v11 00/23] Introducing OpenVPN Data Channel Offload

2024-11-05 Thread Sergey Ryazanov
Hi Antonio, On 29.10.2024 12:47, Antonio Quartulli wrote: Notable changes from v10: * extended commit message of 23/23 with brief description of the output * Link to v10: https://lore.kernel.org/r/20241025-b4-ovpn-v10-0-b87530777...@openvpn.net Please note that some patches were already review

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-05 Thread Luis Chamberlain
On Tue, Nov 05, 2024 at 04:26:51PM -0800, Matthew Maurer wrote: > On Fri, Nov 1, 2024 at 2:10 PM Luis Chamberlain wrote: > > > > On Thu, Oct 31, 2024 at 01:00:28PM -0700, Matthew Maurer wrote: > > > > The question is, if only extended moversions are used, what new tooling > > > > requirements are

Re: [PATCH] vdpa/mlx5: Fix error path during device add

2024-11-05 Thread Jason Wang
On Wed, Nov 6, 2024 at 2:52 AM Dragos Tatulea wrote: > > In the error recovery path of mlx5_vdpa_dev_add(), the cleanup is > executed and at the end put_device() is called which ends up calling > mlx5_vdpa_free(). This function will execute the same cleanup all over > again. Most resources support

Re: [PATCH v3 7/9] vhost: Add new UAPI to support change to task mode

2024-11-05 Thread Michael S. Tsirkin
On Tue, Nov 05, 2024 at 03:25:26PM +0800, Cindy Lu wrote: > index b95dd84eef2d..1e192038633d 100644 > --- a/include/uapi/linux/vhost.h > +++ b/include/uapi/linux/vhost.h > @@ -235,4 +235,6 @@ > */ > #define VHOST_VDPA_GET_VRING_SIZE_IOWR(VHOST_VIRTIO, 0x82, \ >

Re: [PATCH v3 7/9] vhost: Add new UAPI to support change to task mode

2024-11-05 Thread Michael S. Tsirkin
On Tue, Nov 05, 2024 at 03:25:26PM +0800, Cindy Lu wrote: > Add a new UAPI to enable setting the vhost device to task mode. > The userspace application can use VHOST_SET_INHERIT_FROM_OWNER > to configure the mode if necessary. > This setting must be applied before VHOST_SET_OWNER, as the worker > w