Re: [PATCH net-next v11 14/23] ovpn: implement peer lookup logic

2024-11-04 Thread Sabrina Dubroca
2024-10-29, 11:47:27 +0100, Antonio Quartulli wrote: > struct ovpn_peer *ovpn_peer_get_by_transp_addr(struct ovpn_struct *ovpn, > struct sk_buff *skb) > { > - struct ovpn_peer *peer = NULL; > + struct ovpn_peer *tmp, *peer = NULL; > struc

Re: [PATCH net-next v2 2/4] net: hsr: Add VLAN CTAG filter support

2024-11-04 Thread MD Danish Anwar
Hi Paolo, On 31/10/24 8:07 pm, Paolo Abeni wrote: > > > On 10/24/24 12:30, MD Danish Anwar wrote: >> From: Murali Karicheri >> >> This patch adds support for VLAN ctag based filtering at slave devices. >> The slave ethernet device may be capable of filtering ethernet packets >> based on VLAN ID

Re: [PATCH net-next v11 17/23] ovpn: add support for peer floating

2024-11-04 Thread Sabrina Dubroca
2024-10-29, 11:47:30 +0100, Antonio Quartulli wrote: > +static int ovpn_peer_reset_sockaddr(struct ovpn_peer *peer, > + const struct sockaddr_storage *ss, > + const u8 *local_ip) > + __must_hold(&peer->lock) > +{ > + struct ovp

[PATCH net-next] selftests: net: include lib/sh/*.sh with lib.sh

2024-11-04 Thread Matthieu Baerts (NGI0)
../lib.sh \ + $(wildcard ../lib/sh/*.sh) --- base-commit: ecf99864ea6b1843773589a935bb026951bf12dd change-id: 20241104-net-next-selftests-lib-sh-deps-cc359ca5602f Best regards, -- Matthieu Baerts (NGI0)

Re: [PATCH bpf-next 1/2] libbpf: Add missing per-arch include path

2024-11-04 Thread Alexandre Ghiti
Hi Bjorn, On 27/09/2024 15:13, Björn Töpel wrote: From: Björn Töpel libbpf does not include the per-arch tools include path, e.g. tools/arch/riscv/include. Some architectures depend those files to build properly. Include tools/arch/$(SUBARCH)/include in the libbpf build. Fixes: 6d74d178fe6e

[PATCH AUTOSEL 6.1 07/11] selftests/watchdog-test: Fix system accidentally reset after watchdog-test

2024-11-04 Thread Sasha Levin
From: Li Zhijian [ Upstream commit dc1308bee1ed03b4d698d77c8bd670d399dcd04d ] When running watchdog-test with 'make run_tests', the watchdog-test will be terminated by a timeout signal(SIGTERM) due to the test timemout. And then, a system reboot would happen due to watchdog not stop. see the dm

[PATCH AUTOSEL 5.15 07/10] selftests/watchdog-test: Fix system accidentally reset after watchdog-test

2024-11-04 Thread Sasha Levin
From: Li Zhijian [ Upstream commit dc1308bee1ed03b4d698d77c8bd670d399dcd04d ] When running watchdog-test with 'make run_tests', the watchdog-test will be terminated by a timeout signal(SIGTERM) due to the test timemout. And then, a system reboot would happen due to watchdog not stop. see the dm

Re: [PATCH net-next v11 18/23] ovpn: implement peer add/get/dump/delete via netlink

2024-11-04 Thread Sabrina Dubroca
2024-10-29, 11:47:31 +0100, Antonio Quartulli wrote: > +static int ovpn_nl_peer_precheck(struct ovpn_struct *ovpn, > + struct genl_info *info, > + struct nlattr **attrs) > +{ > + if (NL_REQ_ATTR_CHECK(info->extack, info->attrs[OVPN_A_PEE

Re: [PATCH v3] selftests: clone3: Use the capget and capset syscall directly

2024-11-04 Thread zhouyuhang
在 2024/11/1 06:59, Shuah Khan 写道: On 10/29/24 20:50, zhouyuhang wrote: From: zhouyuhang The libcap commit aca076443591 ("Make cap_t operations thread safe.") added a __u8 mutex at the beginning of the struct _cap_struct, it changes the offset of the members in the structure that breaks th

[PATCH v4 1/2] selftests:tmpfs: Add Skip test if not run as root

2024-11-04 Thread Shivam Chaudhary
- Add skip test if not run as root, with an appropriate Warning. - Add 'ksft_print_header()' and 'ksft_set_plan()' to structure test outputs more effectively. Test logs : Before change: - Without root error: unshare, errno 1 - With root No, output After change: - Without root TAP versi

[PATCH] rcu: Use READ_ONCE() for rdp->gpwrap access in __note_gp_changes()

2024-11-04 Thread Zilin Guan
In function __note_gp_changes(), rdp->gpwrap is read using READ_ONCE() in line 1307: 1307if (IS_ENABLED(CONFIG_PROVE_RCU) && READ_ONCE(rdp->gpwrap)) 1308WRITE_ONCE(rdp->last_sched_clock, jiffies); while read directly in line 1305: 1305if (ULONG_CMP_LT(rdp->gp_seq_needed, rnp-

Re: [PATCH] dax: Allow block size > PAGE_SIZE

2024-11-04 Thread Asahi Lina
On 11/4/24 7:57 PM, Jan Kara wrote: > On Fri 01-11-24 21:22:31, Asahi Lina wrote: >> For virtio-dax, the file/FS blocksize is irrelevant. FUSE always uses >> large DAX blocks (2MiB), which will work with all host page sizes. Since >> we are mapping files into the DAX window on the host, the unde

Re: [PATCH] dt-bindings: remoteproc: qcom,sm8550-pas: Add SM8750 ADSP

2024-11-04 Thread Rob Herring (Arm)
On Fri, 01 Nov 2024 18:03:09 +0100, Krzysztof Kozlowski wrote: > Document compatible for Qualcomm SM8750 SoC ADSP PAS which looks fully > compatible with SM8550 variant. The only difference from bindings point > of view is one more interrupt ("shutdown-ack"). Marking devices as > compatible, us

[PATCH RESEND v13 06/12] clk: mmp: Add Marvell PXA1908 APBCP driver

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add driver for the APBCP controller block found on Marvell's PXA1908 SoC. Signed-off-by: Duje Mihanović --- drivers/clk/mmp/Makefile| 2 +- drivers/clk/mmp/clk-pxa1908-apbcp.c | 82 + 2 files changed, 83 insertions(+), 1 del

[PATCH RESEND v13 12/12] MAINTAINERS: add myself as Marvell PXA1908 maintainer

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add myself as the maintainer for Marvell PXA1908 SoC support. Signed-off-by: Duje Mihanović --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c27f3190737f8b85779bde5489639c8b899f4fd8..8d50cb7457924e3290810eaf7d3c4

[PATCH RESEND v13 01/12] clk: mmp: Switch to use struct u32_fract instead of custom one

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Andy Shevchenko The struct mmp_clk_factor_tbl repeats the generic struct u32_fract. Kill the custom one and use the generic one instead. Signed-off-by: Andy Shevchenko Tested-by: Duje Mihanović Reviewed-by: Linus Walleij Reviewed-by: Stephen Boyd Signed-off-by: Duje Mihanović --- dri

[PATCH RESEND v13 07/12] clk: mmp: Add Marvell PXA1908 APMU driver

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add driver for the APMU controller block found on Marvell's PXA1908 SoC. This driver is incomplete, lacking support for (at least) GPU, VPU, DSI and CCIC (camera related) clocks. Signed-off-by: Duje Mihanović --- drivers/clk/mmp/Makefile | 2 +- drivers/clk/mmp

[PATCH RESEND v13 09/12] dt-bindings: marvell: Document PXA1908 SoC and samsung,coreprimevelte

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add dt bindings for the Marvell PXA1908 SoC and the Samsung Galaxy Core Prime VE LTE phone (model number SM-G361F) using the SoC. The SoC comes with 4 Cortex-A53 cores clocked up to ~1.2GHz and a Vivante GC7000UL GPU. The phone also has a 4.5" 480x800 touchscreen, 8GB eMMC a

[PATCH RESEND v13 10/12] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add ARCH_MMP configuration option for Marvell PXA1908 SoC. Signed-off-by: Duje Mihanović --- arch/arm64/Kconfig.platforms | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 6c6d11536b42ec6e878db8d3

[PATCH AUTOSEL 5.10 3/6] selftests/watchdog-test: Fix system accidentally reset after watchdog-test

2024-11-04 Thread Sasha Levin
From: Li Zhijian [ Upstream commit dc1308bee1ed03b4d698d77c8bd670d399dcd04d ] When running watchdog-test with 'make run_tests', the watchdog-test will be terminated by a timeout signal(SIGTERM) due to the test timemout. And then, a system reboot would happen due to watchdog not stop. see the dm

[PATCH AUTOSEL 5.4 3/6] selftests/watchdog-test: Fix system accidentally reset after watchdog-test

2024-11-04 Thread Sasha Levin
From: Li Zhijian [ Upstream commit dc1308bee1ed03b4d698d77c8bd670d399dcd04d ] When running watchdog-test with 'make run_tests', the watchdog-test will be terminated by a timeout signal(SIGTERM) due to the test timemout. And then, a system reboot would happen due to watchdog not stop. see the dm

[PATCH AUTOSEL 4.19 3/5] selftests/watchdog-test: Fix system accidentally reset after watchdog-test

2024-11-04 Thread Sasha Levin
From: Li Zhijian [ Upstream commit dc1308bee1ed03b4d698d77c8bd670d399dcd04d ] When running watchdog-test with 'make run_tests', the watchdog-test will be terminated by a timeout signal(SIGTERM) due to the test timemout. And then, a system reboot would happen due to watchdog not stop. see the dm

Re: [syzbot] [mm?] WARNING: locking bug in __rmqueue_pcplist

2024-11-04 Thread Peter Zijlstra
On Mon, Nov 04, 2024 at 12:25:03PM +0100, Vlastimil Babka wrote: > On 11/4/24 12:11, Vlastimil Babka wrote: > >> __alloc_pages_noprof+0x292/0x710 mm/page_alloc.c:4771 > >> alloc_pages_mpol_noprof+0x3e8/0x680 mm/mempolicy.c:2265 > >> stack_depot_save_flags+0x666/0x830 lib/stackdepot.c:627 > >>

Re: [PATCH bpf-next 1/2] libbpf: Add missing per-arch include path

2024-11-04 Thread Björn Töpel
patchwork-bot+netdev...@kernel.org writes: > Hello: > > This series was applied to bpf/bpf-next.git (master) > by Andrii Nakryiko : > > On Fri, 27 Sep 2024 15:13:52 +0200 you wrote: >> From: Björn Töpel >> >> libbpf does not include the per-arch tools include path, e.g. >> tools/arch/riscv/inclu

[PATCH] kunit: skb: use "gfp" variable instead of hardcoding GFP_KERNEL

2024-11-04 Thread Dan Carpenter
The intent here was clearly to use the gfp variable flags instead of hardcoding GFP_KERNEL. All the callers pass GFP_KERNEL as the gfp flags so this doesn't affect runtime. Fixes: b3231d353a51 ("kunit: add a convenience allocation wrapper for SKBs") Signed-off-by: Dan Carpenter --- include/kuni

[PATCH RESEND v13 11/12] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add DTS for Marvell PXA1908 SoC and Samsung Galaxy Core Prime Value Edition LTE, a smartphone based on said SoC. Signed-off-by: Duje Mihanović --- arch/arm64/boot/dts/marvell/Makefile | 3 + .../dts/marvell/pxa1908-samsung-coreprimevelte.dts | 336 +

[PATCH RESEND v13 05/12] clk: mmp: Add Marvell PXA1908 APBC driver

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add driver for the APBC controller block found on Marvell's PXA1908 SoC. Signed-off-by: Duje Mihanović --- drivers/clk/mmp/Makefile | 2 +- drivers/clk/mmp/clk-pxa1908-apbc.c | 130 + 2 files changed, 131 insertions(+), 1 del

[PATCH RESEND v13 00/12] Initial Marvell PXA1908 support

2024-11-04 Thread Duje Mihanović via B4 Relay
Hello, This series adds initial support for the Marvell PXA1908 SoC and "samsung,coreprimevelte", a smartphone using the SoC. USB works and the phone can boot a rootfs from an SD card, but there are some warnings in the dmesg: During SMP initialization: [0.006519] CPU features: SANITY CHECK:

[PATCH RESEND v13 08/12] clk: mmp: Add Marvell PXA1908 MPMU driver

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add driver for the MPMU controller block on Marvell's PXA1908 SoC. The driver is incomplete, currently only supporting the fixed PLL1; dynamic PLLs 2-4 and CPU/DDR/AXI clock support is missing. Signed-off-by: Duje Mihanović --- drivers/clk/mmp/Makefile | 2 +-

[PATCH RESEND v13 04/12] dt-bindings: clock: Add Marvell PXA1908 clock bindings

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add dt bindings and documentation for the Marvell PXA1908 clock controller. Reviewed-by: Conor Dooley Reviewed-by: Stephen Boyd Signed-off-by: Duje Mihanović --- .../devicetree/bindings/clock/marvell,pxa1908.yaml | 48 include/dt-bindings/clock/marvell,pxa19

[PATCH RESEND v13 02/12] dt-bindings: pinctrl: pinctrl-single: add marvell,pxa1908-padconf compatible

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add the "marvell,pxa1908-padconf" compatible to allow migrating to a separate pinctrl driver later. Reviewed-by: Rob Herring Acked-by: Linus Walleij Signed-off-by: Duje Mihanović --- Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 1 file changed,

[PATCH RESEND v13 03/12] pinctrl: single: add marvell,pxa1908-padconf compatible

2024-11-04 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add the "marvell,pxa1908-padconf" compatible to allow migrating to a separate pinctrl driver later. Acked-by: Linus Walleij Signed-off-by: Duje Mihanović --- drivers/pinctrl/pinctrl-single.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-singl

[PATCH net-next v7 01/12] selftests: ncdevmem: Redirect all non-payload output to stderr

2024-11-04 Thread Stanislav Fomichev
That should make it possible to do expected payload validation on the caller side. Reviewed-by: Mina Almasry Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/net/ncdevmem.c | 61 +- 1 file changed, 30 insertions(+), 31 deletions(-) diff --git a/tools/testin

[PATCH net-next v7 02/12] selftests: ncdevmem: Separate out dmabuf provider

2024-11-04 Thread Stanislav Fomichev
So we can plug the other ones in the future if needed. Reviewed-by: Mina Almasry Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/net/ncdevmem.c | 203 +++-- 1 file changed, 119 insertions(+), 84 deletions(-) diff --git a/tools/testing/selftests/net/ncdevmem.c

[PATCH net-next v7 03/12] selftests: ncdevmem: Unify error handling

2024-11-04 Thread Stanislav Fomichev
There is a bunch of places where error() calls look out of place. Use the same error(1, errno, ...) pattern everywhere. Reviewed-by: Mina Almasry Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/net/ncdevmem.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH net-next v7 12/12] selftests: ncdevmem: Add automated test

2024-11-04 Thread Stanislav Fomichev
Only RX side for now and small message to test the setup. In the future, we can extend it to TX side and to testing both sides with a couple of megs of data. make \ -C tools/testing/selftests \ TARGETS="drivers/hw/net" \ install INSTALL_PATH=~/tmp/ksft scp ~/tmp/ksft $

[PATCH net-next v7 11/12] selftests: ncdevmem: Move ncdevmem under drivers/net/hw

2024-11-04 Thread Stanislav Fomichev
This is where all the tests that depend on the HW functionality live in and this is where the automated test is gonna be added in the next patch. Reviewed-by: Mina Almasry Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/drivers/net/hw/.gitignore | 1 + tools/testing/selfte

[PATCH net-next v7 04/12] selftests: ncdevmem: Make client_ip optional

2024-11-04 Thread Stanislav Fomichev
Support 3-tuple filtering by making client_ip optional. When -c is not passed, don't specify src-ip/src-port in the filter. Reviewed-by: Mina Almasry Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/net/ncdevmem.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)

[PATCH net-next v7 06/12] selftests: ncdevmem: Switch to AF_INET6

2024-11-04 Thread Stanislav Fomichev
Use dualstack socket to support both v4 and v6. v4-mapped-v6 address can be used to do v4. Reviewed-by: Mina Almasry Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/net/ncdevmem.c | 99 ++ 1 file changed, 71 insertions(+), 28 deletions(-) diff --git a/tool

[PATCH net-next v7 07/12] selftests: ncdevmem: Properly reset flow steering

2024-11-04 Thread Stanislav Fomichev
ntuple off/on might be not enough to do it on all NICs. Add a bunch of shell crap to explicitly remove the rules. Reviewed-by: Mina Almasry Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/net/ncdevmem.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) di

[PATCH net-next v7 08/12] selftests: ncdevmem: Use YNL to enable TCP header split

2024-11-04 Thread Stanislav Fomichev
In the next patch the hard-coded queue numbers are gonna be removed. So introduce some initial support for ethtool YNL and use it to enable header split. Also, tcp-data-split requires latest ethtool which is unlikely to be present in the distros right now. (ideally, we should not shell out to eth

[PATCH net-next v7 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided

2024-11-04 Thread Stanislav Fomichev
This will be used as a 'probe' mode in the selftest to check whether the device supports the devmem or not. Use hard-coded queue layout (two last queues) and prevent user from passing custom -q and/or -t. Reviewed-by: Mina Almasry Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/ne

[PATCH net-next v7 09/12] selftests: ncdevmem: Remove hard-coded queue numbers

2024-11-04 Thread Stanislav Fomichev
Use single last queue of the device and probe it dynamically. Reviewed-by: Mina Almasry Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/net/ncdevmem.c | 40 -- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/ncdevm

[PATCH net-next v7 00/12] selftests: ncdevmem: Add ncdevmem to ksft

2024-11-04 Thread Stanislav Fomichev
The goal of the series is to simplify and make it possible to use ncdevmem in an automated way from the ksft python wrapper. ncdevmem is slowly mutated into a state where it uses stdout to print the payload and the python wrapper is added to make sure the arrived payload matches the expected one.

Re: [PATCH v3 2/9] KVM: selftests: Add a basic SNP smoke test

2024-11-04 Thread Pratik R. Sampat
On 11/4/2024 5:47 PM, Sean Christopherson wrote: > On Mon, Nov 04, 2024, Pratik R. Sampat wrote: >> >> >> On 10/31/2024 11:27 AM, Sean Christopherson wrote: >>> On Thu, Oct 31, 2024, Pratik R. Sampat wrote: Hi Sean, On 10/30/2024 12:57 PM, Sean Christopherson wrote: > On Wed,

Re: [PATCH] kvm: selftest: fix noop test in guest_memfd_test.c

2024-11-04 Thread Sean Christopherson
On Thu, Oct 31, 2024, Sean Christopherson wrote: > On Thu, 24 Oct 2024 10:59:53 +0100, Patrick Roy wrote: > > The loop in test_create_guest_memfd_invalid that is supposed to test > > that nothing is accepted as a valid flag to KVM_CREATE_GUEST_MEMFD was > > initializing `flag` as 0 instead of BIT(0

Re: [PATCH] KVM: selftests: memslot_perf_test: increase guest sync timeout

2024-11-04 Thread Sean Christopherson
On Wed, Oct 09, 2024, Sean Christopherson wrote: > On Fri, 04 Oct 2024 18:01:53 -0400, Maxim Levitsky wrote: > > When memslot_perf_test is run nested, first iteration of > > test_memslot_rw_loop > > testcase, sometimes takes more than 2 seconds due to build of shadow page > > tables. > > > > Fol

Re: [PATCH net-next v7 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided

2024-11-04 Thread Stanislav Fomichev
On 11/04, Joe Damato wrote: > On Mon, Nov 04, 2024 at 10:14:28AM -0800, Stanislav Fomichev wrote: > > This will be used as a 'probe' mode in the selftest to check whether > > the device supports the devmem or not. Use hard-coded queue layout > > (two last queues) and prevent user from passing custo

[PATCH net 3/4] virtio_net: Sync rss config to device when virtnet_probe

2024-11-04 Thread Philo Lu
During virtnet_probe, default rss configuration is initialized, but was not committed to the device. This patch fix this by sending rss command after device ready in virtnet_probe. Otherwise, the actual rss configuration used by device can be different with that read by user from driver, which may

Re: [PATCH v4 2/6] iio: light: stk3310: handle all remove logic with devm callbacks

2024-11-04 Thread Andy Shevchenko
On Sat, Nov 02, 2024 at 03:50:37PM -0400, Aren Moynihan wrote: > Using devm callbacks helps to make the ordering of probe / remove > operations easier to reason about and removes some duplicate code > between the probe error path and driver remove. Where is SoB? ... > + ret = devm_add_action

Re: [PATCH v4 3/6] iio: light: stk3310: Implement vdd and leda supplies

2024-11-04 Thread Andy Shevchenko
On Sat, Nov 02, 2024 at 03:50:39PM -0400, Aren Moynihan wrote: > The vdd and leda supplies must be powered on for the chip to function > and can be powered off during system suspend. > > This was originally based on a patch by Ondrej Jirman[1], but has been > rewritten since. > > 1: > https://co

Re: [PATCH v4 3/6] iio: light: stk3310: Implement vdd and leda supplies

2024-11-04 Thread Andy Shevchenko
On Sun, Nov 03, 2024 at 11:11:13AM -0500, Aren wrote: > On Sun, Nov 03, 2024 at 11:31:03AM +, Jonathan Cameron wrote: > > On Sat, 2 Nov 2024 15:50:39 -0400 > > Aren Moynihan wrote: ... > > For this Andy was asking for consistency. Generally we don't insist on a > > particular ordering in I

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-04 Thread Andy Shevchenko
On Sat, Nov 02, 2024 at 03:50:41PM -0400, Aren Moynihan wrote: > Using dev_err_probe instead of dev_err and return makes the errors > easier to understand by including the error name, and saves a little > code. ... > #define STK3310_REGFIELD(name) >

Re: [PATCH v4 5/6] iio: light: stk3310: log error if reading the chip id fails

2024-11-04 Thread Andy Shevchenko
On Sat, Nov 02, 2024 at 03:50:43PM -0400, Aren Moynihan wrote: > If the chip isn't powered, this call is likely to return an error. > Without a log here the driver will silently fail to probe. Potential > errors include ENXIO (when the chip isn't powered) and ETIMEDOUT (when > the i2c bus isn't pow

[PATCH net 2/4] virtio_net: Add hash_key_length check

2024-11-04 Thread Philo Lu
Add hash_key_length check in virtnet_probe() to avoid possible out of bound errors when setting/reading the hash key. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Signed-off-by: Philo Lu Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 6 ++ 1 file changed

[PATCH net 0/4] virtio_net: Make RSS interact properly with queue number

2024-11-04 Thread Philo Lu
With this patch set, RSS updates with queue_pairs changing: - When virtnet_probe, init default rss and commit - When queue_pairs changes _without_ user rss configuration, update rss with the new queue number - When queue_pairs changes _with_ user rss configuration, keep rss as user configured

[PATCH net 4/4] virtio_net: Update rss when set queue

2024-11-04 Thread Philo Lu
RSS configuration should be updated with queue number. In particular, it should be updated when (1) rss enabled and (2) default rss configuration is used without user modification. During rss command processing, device updates queue_pairs using rss.max_tx_vq. That is, the device updates queue_pair

[PATCH net 1/4] virtio_net: Support dynamic rss indirection table size

2024-11-04 Thread Philo Lu
When reading/writing virtio_net_ctrl_rss, we get the indirection table size from vi->rss_indir_table_size, which is initialized in virtnet_probe(). However, the actual size of indirection_table was set as VIRTIO_NET_RSS_MAX_TABLE_LEN=128. This collision may cause issues if the vi->rss_indir_table_s

Re: qrtr/mhi: NULL-deref with in-kernel pd-mapper

2024-11-04 Thread Chris Lew
On 11/1/2024 8:01 AM, Johan Hovold wrote: Hi, I just ran into a NULL-deref in a qrts/mhi path during boot of the x1e80100 CRD for the second time. First time was with a 6.11 kernel (but I never got around to reporting it) and today it happened again with 6.12-rc5. Both times I was using the

Re: [PATCH V4 00/15] selftests/resctrl: Support diverse platforms with MBM and MBA tests

2024-11-04 Thread Shuah Khan
On 11/4/24 16:14, Reinette Chatre wrote: On 11/4/24 2:28 PM, Shuah Khan wrote: On 11/4/24 15:16, Reinette Chatre wrote: Hi Shuah, On 10/24/24 3:36 PM, Shuah Khan wrote: On 10/24/24 15:18, Reinette Chatre wrote: Is this patch series ready to be applied? It is now ready after receiving an

Re: [PATCH net-next v7 09/12] selftests: ncdevmem: Remove hard-coded queue numbers

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:27AM -0800, Stanislav Fomichev wrote: > Use single last queue of the device and probe it dynamically. > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/net/ncdevmem.c | 40 -- > 1 file changed,

Re: [PATCH net-next v7 12/12] selftests: ncdevmem: Add automated test

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:30AM -0800, Stanislav Fomichev wrote: > Only RX side for now and small message to test the setup. > In the future, we can extend it to TX side and to testing > both sides with a couple of megs of data. > > make \ > -C tools/testing/selftests \ > TARGETS=

Re: [PATCH rcu 08/15] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-04 Thread Paul E. McKenney
On Tue, Nov 05, 2024 at 12:27:42AM +0100, Frederic Weisbecker wrote: > Le Tue, Oct 15, 2024 at 09:11:05AM -0700, Paul E. McKenney a écrit : > > This patch adds srcu_read_lock_lite() and srcu_read_unlock_lite(), which > > dispense with the read-side smp_mb() but also are restricted to code > > regio

Re: [PATCH net-next v7 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:28AM -0800, Stanislav Fomichev wrote: > This will be used as a 'probe' mode in the selftest to check whether > the device supports the devmem or not. Use hard-coded queue layout > (two last queues) and prevent user from passing custom -q and/or -t. > > Reviewed-by: Mi

Re: [PATCH V4 00/15] selftests/resctrl: Support diverse platforms with MBM and MBA tests

2024-11-04 Thread Reinette Chatre
On 11/4/24 4:07 PM, Shuah Khan wrote: > On 11/4/24 16:14, Reinette Chatre wrote: >> >> >> On 11/4/24 2:28 PM, Shuah Khan wrote: >>> On 11/4/24 15:16, Reinette Chatre wrote: Hi Shuah, On 10/24/24 3:36 PM, Shuah Khan wrote: > On 10/24/24 15:18, Reinette Chatre wrote: > >

[PATCH net-next v7 05/12] selftests: ncdevmem: Remove default arguments

2024-11-04 Thread Stanislav Fomichev
To make it clear what's required and what's not. Also, some of the values don't seem like a good defaults; for example eth1. Move the invocation comment to the top, add missing -s to the client and cleanup the client invocation a bit to make more readable. Reviewed-by: Mina Almasry Signed-off-by

Re: [PATCH net-next v7 06/12] selftests: ncdevmem: Switch to AF_INET6

2024-11-04 Thread Jakub Kicinski
On Mon, 4 Nov 2024 10:14:24 -0800 Stanislav Fomichev wrote: > -static int configure_flow_steering(void) > +static int configure_flow_steering(struct sockaddr_in6 *server_sin) > { > - return run_command("sudo ethtool -N %s flow-type tcp4 %s %s dst-ip %s > %s %s dst-port %s queue %d >&2", > +

[PATCH net-next v6 6/7] selftests: net: Add busy_poll_test

2024-11-04 Thread Joe Damato
Add an epoll busy poll test using netdevsim. This test is comprised of: - busy_poller (via busy_poller.c) - busy_poll_test.sh which loads netdevsim, sets up network namespaces, and runs busy_poller to receive data and socat to send data. The selftest tests two different scenarios: - bus

Re: [PATCH] dax: Allow block size > PAGE_SIZE

2024-11-04 Thread Dave Chinner
On Tue, Nov 05, 2024 at 12:31:22AM +0900, Asahi Lina wrote: > > > On 11/4/24 7:57 PM, Jan Kara wrote: > > On Fri 01-11-24 21:22:31, Asahi Lina wrote: > >> For virtio-dax, the file/FS blocksize is irrelevant. FUSE always uses > >> large DAX blocks (2MiB), which will work with all host page sizes.

Re: [PATCH V4 00/15] selftests/resctrl: Support diverse platforms with MBM and MBA tests

2024-11-04 Thread Reinette Chatre
Hi Shuah, On 10/24/24 3:36 PM, Shuah Khan wrote: > On 10/24/24 15:18, Reinette Chatre wrote: > > Is this patch series ready to be applied? > It is now ready after receiving anticipated tags. Could you please consider it for inclusion? Thank you very much. Reinette

Re: [PATCH V4 00/15] selftests/resctrl: Support diverse platforms with MBM and MBA tests

2024-11-04 Thread Shuah Khan
On 11/4/24 15:16, Reinette Chatre wrote: Hi Shuah, On 10/24/24 3:36 PM, Shuah Khan wrote: On 10/24/24 15:18, Reinette Chatre wrote: Is this patch series ready to be applied? It is now ready after receiving anticipated tags. Could you please consider it for inclusion? yes. I will apply t

Re: [PATCH net-next] ptp: Remove 'default y' for VMCLOCK PTP device

2024-11-04 Thread Jakub Kicinski
On Sat, 02 Nov 2024 16:52:17 -0500 David Woodhouse wrote: > From: David Woodhouse > > The VMCLOCK device gives support for accurate timekeeping even across > live migration, unlike the KVM PTP clock. To help ensure that users can > always use ptp_vmclock where it's available in preference to ptp

Re: [PATCH net-next] ptp: Remove 'default y' for VMCLOCK PTP device

2024-11-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sat, 02 Nov 2024 16:52:17 -0500 you wrote: > From: David Woodhouse > > The VMCLOCK device gives support for accurate timekeeping even across > live migration, unlike the KVM PTP clock. To help ensure that users c

Re: [PATCH net-next v7 12/12] selftests: ncdevmem: Add automated test

2024-11-04 Thread Jakub Kicinski
On Mon, 4 Nov 2024 16:15:10 -0800 Joe Damato wrote: > > +with bkg(listen_cmd) as nc: > > +wait_port_listen(port) > > +cmd(f"echo -e \"hello\\nworld\"| nc {cfg.v6} {port}", > > host=cfg.remote, shell=True) > > FWIW, in the v3 of the series I submit, Jakub asked me to replace

Re: [PATCH v3 2/9] KVM: selftests: Add a basic SNP smoke test

2024-11-04 Thread Pratik R. Sampat
On 10/31/2024 11:27 AM, Sean Christopherson wrote: > On Thu, Oct 31, 2024, Pratik R. Sampat wrote: >> Hi Sean, >> >> On 10/30/2024 12:57 PM, Sean Christopherson wrote: >>> On Wed, Oct 30, 2024, Pratik R. Sampat wrote: On 10/30/2024 8:46 AM, Sean Christopherson wrote: > +/* Minimum firmw

Re: [PATCH V4 00/15] selftests/resctrl: Support diverse platforms with MBM and MBA tests

2024-11-04 Thread Reinette Chatre
On 11/4/24 2:28 PM, Shuah Khan wrote: > On 11/4/24 15:16, Reinette Chatre wrote: >> Hi Shuah, >> >> On 10/24/24 3:36 PM, Shuah Khan wrote: >>> On 10/24/24 15:18, Reinette Chatre wrote: >>> >>> Is this patch series ready to be applied? >>> >> >> It is now ready after receiving anticipated tags. C

Re: [PATCH rcu 08/15] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-11-04 Thread Frederic Weisbecker
Le Tue, Oct 15, 2024 at 09:11:05AM -0700, Paul E. McKenney a écrit : > This patch adds srcu_read_lock_lite() and srcu_read_unlock_lite(), which > dispense with the read-side smp_mb() but also are restricted to code > regions that RCU is watching. If a given srcu_struct structure uses > srcu_read_l

Re: [PATCH net-next v7 01/12] selftests: ncdevmem: Redirect all non-payload output to stderr

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:19AM -0800, Stanislav Fomichev wrote: > That should make it possible to do expected payload validation on > the caller side. > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/net/ncdevmem.c | 61 +-

Re: [PATCH net-next v7 02/12] selftests: ncdevmem: Separate out dmabuf provider

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:20AM -0800, Stanislav Fomichev wrote: > So we can plug the other ones in the future if needed. > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/net/ncdevmem.c | 203 +++-- > 1 file changed, 119 in

Re: [PATCH net-next v7 03/12] selftests: ncdevmem: Unify error handling

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:21AM -0800, Stanislav Fomichev wrote: > There is a bunch of places where error() calls look out of place. > Use the same error(1, errno, ...) pattern everywhere. > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/net/n

Re: [PATCH v3 2/9] KVM: selftests: Add a basic SNP smoke test

2024-11-04 Thread Sean Christopherson
On Mon, Nov 04, 2024, Pratik R. Sampat wrote: > > > On 10/31/2024 11:27 AM, Sean Christopherson wrote: > > On Thu, Oct 31, 2024, Pratik R. Sampat wrote: > >> Hi Sean, > >> > >> On 10/30/2024 12:57 PM, Sean Christopherson wrote: > >>> On Wed, Oct 30, 2024, Pratik R. Sampat wrote: > On 10/30/2

Re: [PATCH net-next v7 04/12] selftests: ncdevmem: Make client_ip optional

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:22AM -0800, Stanislav Fomichev wrote: > Support 3-tuple filtering by making client_ip optional. When -c is > not passed, don't specify src-ip/src-port in the filter. > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/n

Re: [PATCH net-next v7 06/12] selftests: ncdevmem: Switch to AF_INET6

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:24AM -0800, Stanislav Fomichev wrote: > Use dualstack socket to support both v4 and v6. v4-mapped-v6 address > can be used to do v4. > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/net/ncdevmem.c | 99 ++

Re: [PATCH net-next v7 07/12] selftests: ncdevmem: Properly reset flow steering

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:25AM -0800, Stanislav Fomichev wrote: > ntuple off/on might be not enough to do it on all NICs. > Add a bunch of shell crap to explicitly remove the rules. > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/net/ncdevme

Re: [PATCH net-next v7 05/12] selftests: ncdevmem: Remove default arguments

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:23AM -0800, Stanislav Fomichev wrote: > To make it clear what's required and what's not. Also, some of the > values don't seem like a good defaults; for example eth1. > > Move the invocation comment to the top, add missing -s to the client > and cleanup the client inv

Re: [PATCH net-next v7 08/12] selftests: ncdevmem: Use YNL to enable TCP header split

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:26AM -0800, Stanislav Fomichev wrote: > In the next patch the hard-coded queue numbers are gonna be removed. > So introduce some initial support for ethtool YNL and use > it to enable header split. > > Also, tcp-data-split requires latest ethtool which is unlikely > t

Re: [PATCH net-next v7 06/12] selftests: ncdevmem: Switch to AF_INET6

2024-11-04 Thread Stanislav Fomichev
On 11/04, Jakub Kicinski wrote: > On Mon, 4 Nov 2024 10:14:24 -0800 Stanislav Fomichev wrote: > > -static int configure_flow_steering(void) > > +static int configure_flow_steering(struct sockaddr_in6 *server_sin) > > { > > - return run_command("sudo ethtool -N %s flow-type tcp4 %s %s dst-ip %s

Re: [PATCH RESEND v13 10/12] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform

2024-11-04 Thread kernel test robot
base: 9852d85ec9d492ebef56dc5f229416c925758edc patch link: https://lore.kernel.org/r/20241104-pxa1908-lkml-v13-10-e050609b8d6c%40skole.hr patch subject: [PATCH RESEND v13 10/12] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform config: arm64-kismet-CONFIG_I2C_GPIO

[PATCH v4] selftests: clone3: Use the capget and capset syscall directly

2024-11-04 Thread zhouyuhang
From: zhouyuhang The libcap commit aca076443591 ("Make cap_t operations thread safe.") added a __u8 mutex at the beginning of the struct _cap_struct, it changes the offset of the members in the structure that breaks the assumption made in the "struct libcap" definition in clone3_cap_checkpoint_re

Re: [PATCH net-next v7 12/12] selftests: ncdevmem: Add automated test

2024-11-04 Thread Stanislav Fomichev
On 11/04, Joe Damato wrote: > On Mon, Nov 04, 2024 at 10:14:30AM -0800, Stanislav Fomichev wrote: > > Only RX side for now and small message to test the setup. > > In the future, we can extend it to TX side and to testing > > both sides with a couple of megs of data. > > > > make \ > > -C to

Re: qrtr/mhi: NULL-deref with in-kernel pd-mapper

2024-11-04 Thread Johan Hovold
igs > enabled so not sure the offset is still valid. > > WARN_ON(buf_info->used); > buf_info->pre_mapped = info->pre_mapped; > > This looks like the null pointer would happen if qrtr tried to send > before mhi_channel_prepare() is called. I didn't look clo

[PATCH v3 2/9] vhost: Add the vhost_worker to support kthread

2024-11-04 Thread Cindy Lu
Add the previously removed function vhost_worker() back to support the kthread and rename it to vhost_run_work_kthread_list. The old function vhost_worker was change to support task in commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads") change to xarray in commit 1cdaafa1b8b4 ("vhost

[PATCH v3 5/9] vhost: Add kthread support in function vhost_worker_queue()

2024-11-04 Thread Cindy Lu
The function vhost_worker_queue() uses vhost_task_fn and selects the different mode based on the value of inherit_owner. Signed-off-by: Cindy Lu --- drivers/vhost/vhost.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index

Re: [Regression] wifi problems since tg3 started throwing rcu stall warnings

2024-11-04 Thread Mingcong Bai
Hi Frederic and Thorston, (CC-ing the laptop's owner so that she might help with further testing...) 在 2024-10-23 18:22,Linux regression tracking (Thorsten Leemhuis) 写道: On 23.10.24 12:09, Frederic Weisbecker wrote: Le Wed, Oct 23, 2024 at 10:27:18AM +0200, Linux regression tracking (Thorste

[PATCH v3 3/9] vhost: Add the cgroup related function

2024-11-04 Thread Cindy Lu
Add back the previously removed cgroup function to support the kthread The biggest change for this part is in vhost_attach_cgroups() and vhost_worker_cgroups_kthread(). This is because of the change in struct dev->worker_xa. The old function was remove in commit 6e890c5d5021 ("vhost: use vhost_tas

[PATCH v3 7/9] vhost: Add new UAPI to support change to task mode

2024-11-04 Thread Cindy Lu
Add a new UAPI to enable setting the vhost device to task mode. The userspace application can use VHOST_SET_INHERIT_FROM_OWNER to configure the mode if necessary. This setting must be applied before VHOST_SET_OWNER, as the worker will be created in the VHOST_SET_OWNER function Signed-off-by: Cindy

[PATCH v3 1/9] vhost: Add a new parameter to allow user select kthread

2024-11-04 Thread Cindy Lu
The vhost now uses vhost_task and workers as a child of the owner thread. While this aligns with containerization principles,it confuses some legacy userspace app, Therefore, we are reintroducing kthread API support. Introduce a new parameter to enable users to choose between kthread and task mode

Re: [PATCH net-next v7 03/12] selftests: ncdevmem: Unify error handling

2024-11-04 Thread Stanislav Fomichev
On 11/04, Joe Damato wrote: > On Mon, Nov 04, 2024 at 10:14:21AM -0800, Stanislav Fomichev wrote: > > There is a bunch of places where error() calls look out of place. > > Use the same error(1, errno, ...) pattern everywhere. > > > > Reviewed-by: Mina Almasry > > Signed-off-by: Stanislav Fomichev

Re: [PATCH net-next v6 6/7] selftests: net: Add busy_poll_test

2024-11-04 Thread Stanislav Fomichev
On 11/04, Joe Damato wrote: > Add an epoll busy poll test using netdevsim. > > This test is comprised of: > - busy_poller (via busy_poller.c) > - busy_poll_test.sh which loads netdevsim, sets up network namespaces, > and runs busy_poller to receive data and socat to send data. > > The sel

Re: [PATCH] virtio: Remove virtio devices on device_shutdown()

2024-11-04 Thread Kirill A. Shutemov
On Thu, Aug 08, 2024 at 06:28:02PM +0300, Kirill A. Shutemov wrote: > On Thu, Aug 08, 2024 at 11:03:30AM -0400, Michael S. Tsirkin wrote: > > On Thu, Aug 08, 2024 at 04:15:25PM +0300, Kirill A. Shutemov wrote: > > > On Thu, Aug 08, 2024 at 08:10:34AM -0400, Michael S. Tsirkin wrote: > > > > On Thu,

  1   2   >