Re: [PATCH rcu] srcu: Guarantee non-negative return value from srcu_read_lock()

2024-10-22 Thread Peter Zijlstra
On Mon, Oct 21, 2024 at 08:30:43PM -0700, Paul E. McKenney wrote: > Thoughts? Thanks Paul! Acked-by: Peter Zijlstra (Intel) > > > commit 4433b7d3785d8d2a700f5ed5ca234c64bc63180e > Author: Paul E. McKenney > Date: Mon O

Re: [PATCH rcu] srcu: Guarantee non-negative return value from srcu_read_lock()

2024-10-22 Thread Peter Zijlstra
On Mon, Oct 21, 2024 at 11:51:40PM -0700, Christoph Hellwig wrote: > On Mon, Oct 21, 2024 at 03:13:05PM -0700, Paul E. McKenney wrote: > > For almost 20 years, the int return value from srcu_read_lock() has > > been always either zero or one. This commit therefore documents the > > fact that it wi

Re: [PATCH rcu] srcu: Guarantee non-negative return value from srcu_read_lock()

2024-10-22 Thread Christoph Hellwig
On Tue, Oct 22, 2024 at 09:06:35AM +0200, Peter Zijlstra wrote: > What is returned is an array index -- and SRCU is currently built using > an array of size 2. Using larger arrays is conceivable (IIRC some > versions of preemptible RCU used up to 4 or something). > > So while the values 0,1 are po

Re: [PATCH rcu] srcu: Guarantee non-negative return value from srcu_read_lock()

2024-10-22 Thread Peter Zijlstra
On Tue, Oct 22, 2024 at 12:07:35AM -0700, Christoph Hellwig wrote: > On Tue, Oct 22, 2024 at 09:06:35AM +0200, Peter Zijlstra wrote: > > What is returned is an array index -- and SRCU is currently built using > > an array of size 2. Using larger arrays is conceivable (IIRC some > > versions of pree

Re: [PATCH net-next v5 2/3] connector/cn_proc: Kunit tests for threads hash table

2024-10-22 Thread Anjali Kulkarni
> On Oct 17, 2024, at 5:55 PM, Stanislav Fomichev wrote: > > On 10/18, Anjali Kulkarni wrote: >> >> >>> On Oct 17, 2024, at 5:13 PM, Stanislav Fomichev >>> wrote: >>> >>> On 10/17, Anjali Kulkarni wrote: Kunit tests to test hash table add, delete, duplicate add and delete. Add fo

Re: [PATCH 1/1] softirq: Use a dedicated thread for timer wakeups on PREEMPT_RT.

2024-10-22 Thread Frederic Weisbecker
Le Tue, Oct 22, 2024 at 05:34:21PM +0200, Sebastian Andrzej Siewior a écrit : > On 2024-10-22 15:28:56 [+0200], Frederic Weisbecker wrote: > > > Once the ksoftirqd is marked as pending (or is running) it will collect > > > all raised softirqs. This in turn means that a softirq which would have > >

Re: [PATCH V13 03/14] KVM: x86: Fix Intel PT Host/Guest mode when host tracing also

2024-10-22 Thread Sean Christopherson
On Tue, Oct 22, 2024, Adrian Hunter wrote: > On 22/10/24 19:30, Sean Christopherson wrote: > >>> LOL, yeah, this needs to be burned with fire. It's wildly broken. So > >>> for stable@, > >> > >> It doesn't seem wildly broken. Just the VMM passing invalid CPUID > >> and KVM not validating it. >

[PATCH 1/2] selftests/intel_pstate: fix operand expected

2024-10-22 Thread Alessandro Zanni
Running "make kselftest TARGETS=intel_pstate" results in the following errors: - ./run.sh: line 90: / 1000: syntax error: operand expected (error token is "/ 1000") - ./run.sh: line 92: / 1000: syntax error: operand expected (error token is "/ 1000") This fix allows to have cross-platform compatib

Re: [PATCH V13 03/14] KVM: x86: Fix Intel PT Host/Guest mode when host tracing also

2024-10-22 Thread Adrian Hunter
On 22/10/24 19:30, Sean Christopherson wrote: > On Tue, Oct 22, 2024, Adrian Hunter wrote: >> On 14/10/24 21:25, Sean Christopherson wrote: Fixes: 2ef444f1600b ("KVM: x86: Add Intel PT context switch for each vcpu") Cc: sta...@vger.kernel.org >>> >>> This is way, way too big for stable@.

Re: [PATCH] kunit: Introduce autorun option

2024-10-22 Thread Rae Moar
On Thu, Oct 17, 2024 at 5:34 PM Stanislav Kinsburskii wrote: > > The new option controls tests run on boot or module load. With the new > debugfs "run" dentry allowing to run tests on demand, an ability to disable > automatic tests run becomes a useful option in case of intrusive tests. > > The op

[PATCH] kselftest/arm64: Log fp-stress child startup errors to stdout

2024-10-22 Thread Mark Brown
Currently if we encounter an error between fork() and exec() of a child process we log the error to stderr. This means that the errors don't get annotated with the child information which makes diagnostics harder and means that if we miss the exit signal from the child we can deadlock waiting for o

Re: [PATCH V13 03/14] KVM: x86: Fix Intel PT Host/Guest mode when host tracing also

2024-10-22 Thread Andi Kleen
> > Out of curiosity, how much is Intel PT used purely for control flow tracing, > i.e. > without caring _at all_ about perceived execution time? It is very common, e.g. one major use of PT is control flow discovery in feedback fuzzers. -Andi

Re: [PATCH net-next v5 2/3] connector/cn_proc: Kunit tests for threads hash table

2024-10-22 Thread Stanislav Fomichev
On 10/22, Anjali Kulkarni wrote: > > > > On Oct 17, 2024, at 5:55 PM, Stanislav Fomichev > > wrote: > > > > On 10/18, Anjali Kulkarni wrote: > >> > >> > >>> On Oct 17, 2024, at 5:13 PM, Stanislav Fomichev > >>> wrote: > >>> > >>> On 10/17, Anjali Kulkarni wrote: > Kunit tests to test

Re: [PATCH v4 1/4] pidfd: extend pidfd_get_pid() and de-duplicate pid lookup

2024-10-22 Thread Shakeel Butt
On Thu, Oct 17, 2024 at 10:05:49PM GMT, Lorenzo Stoakes wrote: > The means by which a pid is determined from a pidfd is duplicated, with > some callers holding a reference to the (pid)fd, and others explicitly > pinning the pid. > > Introduce __pidfd_get_pid() which narrows this to one approach of

Re: [PATCH] rcu/nocb: Fix rcuog wake-up from offline softirq

2024-10-22 Thread Paul E. McKenney
On Thu, Oct 10, 2024 at 06:36:09PM +0200, Frederic Weisbecker wrote: > After a CPU has set itself offline and before it eventually calls > rcutree_report_cpu_dead(), there are still opportunities for callbacks > to be enqueued, for example from a softirq. When that happens on NOCB, > the rcuog wake

Re: [PATCH rcu] srcu: Guarantee non-negative return value from srcu_read_lock()

2024-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2024 at 7:26 AM Paul E. McKenney wrote: > > On Tue, Oct 22, 2024 at 12:13:12AM -0700, Christoph Hellwig wrote: > > On Tue, Oct 22, 2024 at 09:10:18AM +0200, Peter Zijlstra wrote: > > > Ah, well, the thing that got us here is that we (Andrii and me) wanted > > > to use -1 as an 'inv

[PATCH v2] selftests: tc-testing: Fix typo error

2024-10-22 Thread Karan Sanghavi
Correct the typo errors in json files - "diffferent" is corrected to "different". - "muliple" and "miltiple" is corrected to "multiple". Reviewed-by: Simon Horman Reviewed-by: Shuah Khan Signed-off-by: Karan Sanghavi --- Changes in v2: - Rewrote short log and commit message - Link to v1: http

Re: [PATCH v4 2/4] pidfd: add PIDFD_SELF_* sentinels to refer to own thread/process

2024-10-22 Thread Shakeel Butt
On Thu, Oct 17, 2024 at 10:05:50PM GMT, Lorenzo Stoakes wrote: > It is useful to be able to utilise the pidfd mechanism to reference the > current thread or process (from a userland point of view - thread group > leader from the kernel's point of view). > > Therefore introduce PIDFD_SELF_THREAD to

Re: [PATCH 2/2] soc: qcom: pmic_glink: Handle GLINK intent allocation rejections

2024-10-22 Thread Johan Hovold
On Tue, Oct 22, 2024 at 04:17:12AM +, Bjorn Andersson wrote: > Some versions of the pmic_glink firmware does not allow dynamic GLINK > intent allocations, attempting to send a message before the firmware has > allocated its receive buffers and announced these intent allocations > will fail. Whe

Re: [PATCH v2 1/2] selftest: rtc: Add to check rtc alarm status for alarm related test

2024-10-22 Thread Alexandre Belloni
On 20/10/2024 20:22:13-0700, Joseph Jang wrote: > In alarm_wkalm_set and alarm_wkalm_set_minute test, they use different > ioctl (RTC_ALM_SET/RTC_WKALM_SET) for alarm feature detection. They will > skip testing if RTC_ALM_SET/RTC_WKALM_SET ioctl returns an EINVAL error > code. This design may miss

Re: [PATCH v2 1/2] mm/damon/vaddr: Fix issue in damon_va_evenly_split_region()

2024-10-22 Thread SeongJae Park
Hi Zheng, We Cc kunit folks for any DAMON kunit test changes, so I Cc-ed them. On Tue, 22 Oct 2024 16:39:26 +0800 Zheng Yejian wrote: > According to the logic of damon_va_evenly_split_region(), currently > following split case would not meet the expectation: > > Suppose DAMON_MIN_REGION=0x

Re: [PATCH v2 2/2] mm/damon/vaddr: Add 'nr_piece == 1' check in damon_va_evenly_split_region()

2024-10-22 Thread SeongJae Park
Hi Zheng, Cc-ed kunit folks, as we usually do for DAMON kunit test changes. On Tue, 22 Oct 2024 16:39:27 +0800 Zheng Yejian wrote: > As discussed in [1], damon_va_evenly_split_region() is called to > size-evenly split a region into 'nr_pieces' small regions, > when nr_pieces == 1, no actual s

Re: [PATCH V13 03/14] KVM: x86: Fix Intel PT Host/Guest mode when host tracing also

2024-10-22 Thread Sean Christopherson
On Tue, Oct 22, 2024, Adrian Hunter wrote: > On 14/10/24 21:25, Sean Christopherson wrote: > >> Fixes: 2ef444f1600b ("KVM: x86: Add Intel PT context switch for each vcpu") > >> Cc: sta...@vger.kernel.org > > > > This is way, way too big for stable@. Given that host/guest mode is > > disabled by

Re: [PATCH] selftests/sched: add basic test for psi

2024-10-22 Thread Pintu Agarwal
Hi Johannes, On Tue, 22 Oct 2024 at 19:36, Johannes Weiner wrote: > > On Tue, Oct 22, 2024 at 05:51:58PM +0530, Pintu Kumar wrote: > > There is a psi module that exists under kernel/sched/psi. > > Add a basic test to test the psi. > > I'm not sure this is a valuable use of test cycles. The mere e

Re: [PATCH 1/1] softirq: Use a dedicated thread for timer wakeups on PREEMPT_RT.

2024-10-22 Thread Sebastian Andrzej Siewior
On 2024-10-22 15:28:56 [+0200], Frederic Weisbecker wrote: > Le Fri, Oct 04, 2024 at 12:17:04PM +0200, Sebastian Andrzej Siewior a écrit : > > A timer/ hrtimer softirq is raised in-IRQ context. With threaded > > interrupts enabled or on PREEMPT_RT this leads to waking the ksoftirqd > > for the proc

Re: [PATCH v11 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-10-22 Thread Mathieu Poirier
On Wed, Oct 09, 2024 at 10:01:08AM +0200, Arnaud Pouliquen wrote: > The new TEE remoteproc driver is used to manage remote firmware in a > secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is > introduced to delegate the loading of the firmware to the trusted > execution context. In s

Re: [PATCH v5 0/3] selftests: livepatch: test livepatching a kprobed function

2024-10-22 Thread Petr Mladek
On Thu 2024-10-17 22:01:29, Michael Vetter wrote: > Thanks for all the reviews. > > V5: > Replace /sys/kernel/livepatch also in other/already existing tests. > Improve commit message of 3rd patch. JFYI, I have committed the patchset into livepatching.git, branch for-6.13/selftests-kprobe. I have

Re: [PATCH 1/2] rpmsg: glink: Handle rejected intent request better

2024-10-22 Thread Johan Hovold
On Tue, Oct 22, 2024 at 04:17:11AM +, Bjorn Andersson wrote: > The initial implementation of request intent response handling dealt > with two outcomes; granted allocations, and all other cases being > considered -ECANCELLED (likely from "cancelling the operation as the > remote is going down")

Re: [PATCH V13 03/14] KVM: x86: Fix Intel PT Host/Guest mode when host tracing also

2024-10-22 Thread Adrian Hunter
On 14/10/24 21:25, Sean Christopherson wrote: > On Mon, Oct 14, 2024, Adrian Hunter wrote: >> Ensure Intel PT tracing is disabled before VM-Entry in Intel PT Host/Guest >> mode. >> >> Intel PT has 2 modes for tracing virtual machines. The default is System >> mode whereby host and guest output to t

Re: [PATCH] kselftest/arm64: Fail the overall fp-stress test if any test fails

2024-10-22 Thread Catalin Marinas
On Thu, 17 Oct 2024 18:43:31 +0100, Mark Brown wrote: > Currently fp-stress does not report a top level test result if it runs to > completion, it always exits with a return code 0. Use the ksft_finished() > helper to ensure that the exit code for the top level program reports a > failure if any of

Re: [PATCH v4 05/19] gendwarfksyms: Add a cache for processed DIEs

2024-10-22 Thread Petr Pavlu
On 10/8/24 20:38, Sami Tolvanen wrote: > Basic types in DWARF repeat frequently and traversing the DIEs using > libdw is relatively slow. Add a simple hashtable based cache for the > processed DIEs. > > Signed-off-by: Sami Tolvanen > Acked-by: Neal Gompa Looks ok to me, free free to add: Revie

Re: [PATCH net-next v3 1/3] selftests: nic_link_layer: Add link layer selftest for NIC driver

2024-10-22 Thread Paolo Abeni
On 10/16/24 23:50, Mohan Prasad J wrote: > Add selftest file for the link layer tests of a NIC driver. > Test for auto-negotiation is added. > Add LinkConfig class for changing link layer configs. > Selftest makes use of ksft modules and ethtool. > Include selftest file in the Makefile. > > Signed

Re: [PATCH v8 3/3] irqchip/loongson-eiointc: Add extioi virt extension support

2024-10-22 Thread maobibo
Got it, thanks. Regards Bibo Mao On 2024/10/22 下午5:45, Huacai Chen wrote: On Tue, Oct 22, 2024 at 5:17 PM maobibo wrote: Hi Huacai/Thomas, Sorry for the ping message :( Can this patch be applied int next RC version? Queued for the next release. Huacai Regards Bibo Mao On 2024/10/2

Re: [PATCH net-next v3 3/3] selftests: nic_performance: Add selftest for performance of NIC driver

2024-10-22 Thread Paolo Abeni
On 10/16/24 23:50, Mohan Prasad J wrote: > Add selftest case to check the send and receive throughput. > Supported link modes between local NIC driver and partner > are varied. Then send and receive throughput is captured > and verified. Test uses iperf3 tool. > > Signed-off-by: Mohan Prasad J >

Re: [PATCH v8 3/3] irqchip/loongson-eiointc: Add extioi virt extension support

2024-10-22 Thread Huacai Chen
On Tue, Oct 22, 2024 at 5:17 PM maobibo wrote: > > Hi Huacai/Thomas, > > Sorry for the ping message :( > > Can this patch be applied int next RC version? Queued for the next release. Huacai > > Regards > Bibo Mao > > On 2024/10/2 下午9:42, Thomas Gleixner wrote: > > On Wed, Sep 11 2024 at 17:11, H

[PATCH] rcu/kvfree: Fix data-race in __mod_timer / kvfree_call_rcu

2024-10-22 Thread Uladzislau Rezki (Sony)
KCSAN reports a data race when access the krcp->monitor_work.timer.expires variable in the schedule_delayed_monitor_work() function: BUG: KCSAN: data-race in __mod_timer / kvfree_call_rcu read to 0x888237d1cce8 of 8 bytes by task 10149 on cpu 1: schedule_delayed_monitor_work kernel/rcu/tree

Re: [PATCH 1/1] softirq: Use a dedicated thread for timer wakeups on PREEMPT_RT.

2024-10-22 Thread Frederic Weisbecker
Le Fri, Oct 04, 2024 at 12:17:04PM +0200, Sebastian Andrzej Siewior a écrit : > A timer/ hrtimer softirq is raised in-IRQ context. With threaded > interrupts enabled or on PREEMPT_RT this leads to waking the ksoftirqd > for the processing of the softirq. It took me some time to understand the actu

Re: [PATCH v4 02/11] iommufd: Introduce IOMMUFD_OBJ_VIOMMU and its related struct

2024-10-22 Thread Baolu Lu
On 2024/10/22 21:15, Jason Gunthorpe wrote: On Tue, Oct 22, 2024 at 04:59:07PM +0800, Baolu Lu wrote: Is it feasible to make vIOMMU object more generic, rather than strictly tying it to nested translation? For example, a normal paging domain that translates gPAs to hPAs could also have a vIOMMU

[PATCH v7 1/3] modules: Support extended MODVERSIONS info

2024-10-22 Thread Matthew Maurer
Adds a new format for MODVERSIONS which stores each field in a separate ELF section. This initially adds support for variable length names, but could later be used to add additional fields to MODVERSIONS in a backwards compatible way if needed. Any new fields will be ignored by old user tooling, un

[PATCH v7 2/3] modpost: Produce extended MODVERSIONS information

2024-10-22 Thread Matthew Maurer
Generate both the existing modversions format and the new extended one when running modpost. Presence of this metadata in the final .ko is guarded by CONFIG_EXTENDED_MODVERSIONS. We no longer generate an error on long symbols in modpost if CONFIG_EXTENDED_MODVERSIONS is set, as they can now be app

[PATCH v7 3/3] rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS

2024-10-22 Thread Matthew Maurer
From: Sami Tolvanen Previously, two things stopped Rust from using MODVERSIONS: 1. Rust symbols are occasionally too long to be represented in the original versions table 2. Rust types cannot be properly hashed by the existing genksyms approach because: * Looking up type definitions

Re: [PATCH v2 0/3] modules: few of alignment fixes

2024-10-22 Thread Masahiro Yamada
On Tue, Oct 22, 2024 at 5:07 AM Helge Deller wrote: > > On 10/21/24 21:22, Luis Chamberlain wrote: > > On Fri, Feb 02, 2024 at 10:23:21AM -0800, Luis Chamberlain wrote: > >> On Sat, Feb 03, 2024 at 12:20:38AM +0900, Masahiro Yamada wrote: > >>> On Fri, Feb 2, 2024 at 3:05 AM Luis Chamberlain wrot

Re: [PATCH 1/1] softirq: Use a dedicated thread for timer wakeups on PREEMPT_RT.

2024-10-22 Thread Sebastian Andrzej Siewior
On 2024-10-23 00:27:34 [+0200], Frederic Weisbecker wrote: > > Try again without the "ksoftirqd will collect it all" since this won't > > happen since the revert I mentioned. > > I still don't get it, this makes: > > """ > Once the ksoftirqd is marked as pending (or is running), a softirq which >

Re: [PATCH rcu] srcu: Guarantee non-negative return value from srcu_read_lock()

2024-10-22 Thread Christoph Hellwig
On Tue, Oct 22, 2024 at 10:29:13AM -0700, Andrii Nakryiko wrote: > > > > Would this work? > > > > #define SRCU_INVALID_INDEX -1 > > > > But why? Becaue it very clearly documents what is going on. >It's a nice property to have an int-returning API where valid > values are only >= 0, so callers ar

Re: [PATCH net-next v5 2/3] connector/cn_proc: Kunit tests for threads hash table

2024-10-22 Thread Anjali Kulkarni
> On Oct 22, 2024, at 4:50 PM, Stanislav Fomichev wrote: > > On 10/22, Anjali Kulkarni wrote: >> >> >>> On Oct 17, 2024, at 5:55 PM, Stanislav Fomichev >>> wrote: >>> >>> On 10/18, Anjali Kulkarni wrote: > On Oct 17, 2024, at 5:13 PM, Stanislav Fomichev > wrote: >

Re: [PATCH net-next v5 2/3] connector/cn_proc: Kunit tests for threads hash table

2024-10-22 Thread Anjali Kulkarni
[…snip…] Yes, make sure all required options are picked up by "./tools/testing/kunit/kunit.py run" instead of manually adding options and doing modprobe. >>> >>> The environment issues are resolved and I am able to run kunit.py, but my >>> tests >>> are not invoked without g

Re: [syzbot] [virt?] KCSAN: data-race in virtqueue_disable_cb / virtqueue_disable_cb (5)

2024-10-22 Thread Jason Wang
On Tue, Oct 22, 2024 at 6:07 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:3d5ad2d4eca3 Merge tag 'bpf-fixes' of git://git.kernel.org.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=154b748798 > kernel config:

[PATCH v7 0/3] Extended MODVERSIONS Support

2024-10-22 Thread Matthew Maurer
/modpost.c | 65 +++-- 9 files changed, 266 insertions(+), 17 deletions(-) --- base-commit: 2295cf87ed5a6da4564034e4f8ebcce0a0a021ed change-id: 20241022-extended-modversions-a7b44dfbfff1 prerequisite-message-id: <20241008183823.36676-21-samitolva...@googl

Re: [PATCH] selftests: livepatch: add test cases of stack_order sysfs interface

2024-10-22 Thread zhang warden
> On Oct 11, 2024, at 23:11, Wardenjohn wrote: > > Add selftest test cases to sysfs attribute 'stack_order'. > > Signed-off-by: Wardenjohn > --- > .../testing/selftests/livepatch/test-sysfs.sh | 74 +++ > 1 file changed, 74 insertions(+) > > diff --git a/tools/testing/selftes

Re: [PATCH] remoteproc: qcom: pas: Make remoteproc name human friendly

2024-10-22 Thread Dmitry Baryshkov
On Tue, Oct 22, 2024 at 04:21:03AM +, Bjorn Andersson wrote: > The remoteproc "name" property is supposed to present the "human > readable" name of the remoteproc, while using the device name is > readable, it's not "friendly". > > Instead, use the "sysmon_name" as the identifier for the remot

[syzbot] [virt?] KCSAN: data-race in virtqueue_disable_cb / virtqueue_disable_cb (5)

2024-10-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:3d5ad2d4eca3 Merge tag 'bpf-fixes' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=154b748798 kernel config: https://syzkaller.appspot.com/x/.config?x=fd83253b74c9c570 das

Re: [PATCH v4 02/11] iommufd: Introduce IOMMUFD_OBJ_VIOMMU and its related struct

2024-10-22 Thread Jason Gunthorpe
On Tue, Oct 22, 2024 at 04:59:07PM +0800, Baolu Lu wrote: > Is it feasible to make vIOMMU object more generic, rather than strictly > tying it to nested translation? For example, a normal paging domain that > translates gPAs to hPAs could also have a vIOMMU object associated with > it. > > While

[PATCH] selftests/sched: add basic test for psi

2024-10-22 Thread Pintu Kumar
There is a psi module that exists under kernel/sched/psi. Add a basic test to test the psi. This test just add the basic support to check cpu/memory/io interface. Further test will be added on top of this. Signed-off-by: Pintu Kumar --- MAINTAINERS | 2 + tools/test

Re: [PATCH v5 2/3] selftests: livepatch: save and restore kprobe state

2024-10-22 Thread Miroslav Benes
Hi, On Thu, 17 Oct 2024, Michael Vetter wrote: > Save the state of /sys/kernel/debug/kprobes/enabled > during setup_config() and restore it during cleanup(). > > This is in preparation for a future commit that will add a test > that should confirm that we cannot livepatch a kprobed function > if

Re: [PATCH v5 3/3] selftests: livepatch: test livepatching a kprobed function

2024-10-22 Thread Miroslav Benes
On Thu, 17 Oct 2024, Michael Vetter wrote: > The test proves that a function that is being kprobed and uses a > post_handler cannot be livepatched. > > Only one ftrace_ops with FTRACE_OPS_FL_IPMODIFY set may be registered > to any given function at a time. > > Note that the conflicting kprobe co

Re: [PATCH] KVM: selftests: Fix build on on non-x86 architectures

2024-10-22 Thread Vitaly Kuznetsov
Mark Brown writes: > Commit 9a400068a158 ("KVM: selftests: x86: Avoid using SSE/AVX > instructions") unconditionally added -march=x86-64-v2 to the CFLAGS used > to build the KVM selftests which does not work on non-x86 architectures: > > cc1: error: unknown value ‘x86-64-v2’ for ‘-march’ > > Fi

Re: [PATCH] selftests/sched: add basic test for psi

2024-10-22 Thread Johannes Weiner
On Tue, Oct 22, 2024 at 05:51:58PM +0530, Pintu Kumar wrote: > There is a psi module that exists under kernel/sched/psi. > Add a basic test to test the psi. I'm not sure this is a valuable use of test cycles. The mere existence and basic format of the files is very unlikely to be buggy, and such a

Re: [PATCH v2] rcu/nocb: Fix the WARN_ON_ONCE() in rcu_nocb_rdp_deoffload()

2024-10-22 Thread Frederic Weisbecker
Le Tue, Oct 22, 2024 at 11:41:17AM +0800, Zqiang a écrit : > Currently, running rcutorture test with torture_type=rcu fwd_progress=8 > n_barrier_cbs=8 nocbs_nthreads=8 nocbs_toggle=100 onoff_interval=60 > test_boost=2, will trigger the following warning: > > WARNING: CPU: 19 PID: 100 at kernel/rcu

Re: [PATCH rcu] srcu: Guarantee non-negative return value from srcu_read_lock()

2024-10-22 Thread Paul E. McKenney
On Tue, Oct 22, 2024 at 12:13:12AM -0700, Christoph Hellwig wrote: > On Tue, Oct 22, 2024 at 09:10:18AM +0200, Peter Zijlstra wrote: > > Ah, well, the thing that got us here is that we (Andrii and me) wanted > > to use -1 as an 'invalid' value to indicate SRCU is not currently in > > use. > > > >

Re: [PATCH rcu] srcu: Guarantee non-negative return value from srcu_read_lock()

2024-10-22 Thread Paul E. McKenney
On Tue, Oct 22, 2024 at 09:07:17AM +0200, Peter Zijlstra wrote: > On Mon, Oct 21, 2024 at 08:30:43PM -0700, Paul E. McKenney wrote: > > Thoughts? > > Thanks Paul! > > Acked-by: Peter Zijlstra (Intel) Thank you, Peter! I will apply this on my next rebase.

Re: [PATCH v4 14/19] gendwarfksyms: Add support for kABI rules

2024-10-22 Thread Petr Pavlu
On 10/8/24 20:38, Sami Tolvanen wrote: > Distributions that want to maintain a stable kABI need the ability > to make ABI compatible changes to kernel without affecting symbol > versions, either because of LTS updates or backports. > > With genksyms, developers would typically hide these changes f

Re: [PATCH v4 02/11] iommufd: Introduce IOMMUFD_OBJ_VIOMMU and its related struct

2024-10-22 Thread Baolu Lu
On 2024/10/22 12:40, Nicolin Chen wrote: On Tue, Oct 22, 2024 at 10:28:30AM +0800, Baolu Lu wrote: On 2024/10/22 8:19, Nicolin Chen wrote: + * @viommu_alloc: Allocate an iommufd_viommu on a physical IOMMU instance behind + *the @dev, as the set of virtualization resources shar

Re: [PATCH v5 0/3] selftests: livepatch: test livepatching a kprobed function

2024-10-22 Thread Petr Mladek
On Thu 2024-10-17 22:01:29, Michael Vetter wrote: > Thanks for all the reviews. > > V5: > Replace /sys/kernel/livepatch also in other/already existing tests. > Improve commit message of 3rd patch. With the syntax error fixed by Joe: Reviewed-by: Petr Mladek Tested-by: Petr Mladek Note: I coul

Re: [PATCH v4 09/19] gendwarfksyms: Expand structure types

2024-10-22 Thread Petr Pavlu
On 10/8/24 20:38, Sami Tolvanen wrote: > Recursively expand DWARF structure types, i.e. structs, unions, and > enums. Also include relevant DWARF attributes in type strings to > encode structure layout, for example. > > Example output with --dump-dies: > > subprogram ( > formal_parameter st

Re: [PATCH v4 13/19] gendwarfksyms: Add symbol versioning

2024-10-22 Thread Petr Pavlu
On 10/8/24 20:38, Sami Tolvanen wrote: > Calculate symbol versions from the fully expanded type strings in > type_map, and output the versions in a genksyms-compatible format. > > Signed-off-by: Sami Tolvanen > Acked-by: Neal Gompa > --- > scripts/gendwarfksyms/dwarf.c | 25 +- > s

Re: [PATCH v8 3/3] irqchip/loongson-eiointc: Add extioi virt extension support

2024-10-22 Thread maobibo
Hi Huacai/Thomas, Sorry for the ping message :( Can this patch be applied int next RC version? Regards Bibo Mao On 2024/10/2 下午9:42, Thomas Gleixner wrote: On Wed, Sep 11 2024 at 17:11, Huacai Chen wrote: Hi, Thomas, On Fri, Aug 30, 2024 at 5:32 PM Bibo Mao wrote: Interrupts can be route

Re: [PATCH rcu] srcu: Guarantee non-negative return value from srcu_read_lock()

2024-10-22 Thread Christoph Hellwig
On Tue, Oct 22, 2024 at 09:10:18AM +0200, Peter Zijlstra wrote: > Ah, well, the thing that got us here is that we (Andrii and me) wanted > to use -1 as an 'invalid' value to indicate SRCU is not currently in > use. > > So it all being int is really rather convenient :-) Then please document that