Hi,
On Thu, 5 Sep 2024, zhang warden wrote:
>
> Hi, Miroslav
> > On Sep 5, 2024, at 18:10, Miroslav Benes wrote:
> >
> > Hi,
> >
> > the subject is missing "livepatch: " prefix and I would prefer something
> > like
> >
> > "livepatch: Move struct klp_ops to struct klp_func"
> >
> > On Wed,
Hi Shuah,
Thank you for fixing it.
On 9/5/24 11:02 PM, Shuah Khan wrote:
> When resctrl is built on architectures without __cpuid_count()
> support, build fails. resctrl uses __cpuid_count() defined in
> kselftest.h.
>
> Even though the problem is seen while building resctrl on aarch64,
> this e
The testing is done by ensuring that the fragment allocated
from a frag_frag_cache instance is pushed into a ptr_ring
instance in a kthread binded to a specified cpu, and a kthread
binded to a specified cpu will pop the fragment from the
ptr_ring and free the fragment.
CC: Alexander Duyck
Signed-
Inspired by [1], move the page fragment allocator from page_alloc
into its own c file and header file, as we are about to make more
change for it to replace another page_frag implementation in
sock.c
As this patchset is going to replace 'struct page_frag' with
'struct page_frag_cache' in sched.h,
Use appropriate frag_page API instead of caller accessing
'page_frag_cache' directly.
CC: Alexander Duyck
Signed-off-by: Yunsheng Lin
Reviewed-by: Alexander Duyck
Acked-by: Chuck Lever
---
drivers/vhost/net.c | 2 +-
include/linux/page_frag_cache.h
Add testing for the newly added prepare API, for both aligned
and non-aligned API, also probe API is also tested along with
prepare API.
CC: Alexander Duyck
Signed-off-by: Yunsheng Lin
---
.../selftests/mm/page_frag/page_frag_test.c | 66 +--
tools/testing/selftests/mm/run_vmt
On Thu, 5 Sep 2024, Reinette Chatre wrote:
> On 9/5/24 4:45 AM, Ilpo Järvinen wrote:
> > On Wed, 4 Sep 2024, Reinette Chatre wrote:
> > > On 9/4/24 4:43 AM, Ilpo Järvinen wrote:
> > > > On Fri, 30 Aug 2024, Reinette Chatre wrote:
> > > > > On 8/30/24 4:42 AM, Ilpo Järvinen wrote:
> > > > > > On Thu
On Fri, 6 Sept 2024 at 09:15, Jingyi Wang wrote:
>
> Hi Dmitry,
>
> On 9/6/2024 11:18 AM, Dmitry Baryshkov wrote:
> > On Thu, Sep 05, 2024 at 12:54:35PM GMT, Jingyi Wang wrote:
> >>
> >>
> >> On 9/4/2024 5:39 PM, Krzysztof Kozlowski wrote:
> >>> On 04/09/2024 10:33, Jingyi Wang wrote:
> Enabl
Hi, John & Miroslav
>>
>> Would it be possible to just use klp_transition_patch and implement the
>> logic just in using_show()?
>
> Yes, containing the logic to the sysfs file sounds a lot better.
Maybe I can try to use the state of klp_transition_patch to update the
function's state instead
The current implementation of the waiting mechanism in probe() waits for
the 'released_from_reset' flag to be set which is done in
k3_r5_rproc_prepare() as part of rproc_fw_boot(). This causes unexpected
failures in cases where the firmware is unavailable at boot time,
resulting in probe failure an
Hi Miroslav
>
> node member. You removed the global list, hence this member is not needed
> anymore.
OK, I got it.
>
>>>
+ struct list_head func_stack;
+ struct ftrace_ops fops;
+};
+
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
>>
Note: Xuan Zhuo, if you figure out all the issues, pls post an alternative
patch.
Note2: untested, Darren, pls test and confirm.
Turns out unconditionally enabling premapped
virtio-net leads to a regression on VM with no ACCESS_PLATFORM, and with
sysctl net.core.high_order_alloc_disable=1
where
This reverts commit 99c861b44eb1fb9dfe8776854116a6a9064c19bb.
leads to crashes with no ACCESS_PLATFORM when
sysctl net.core.high_order_alloc_disable=1
Cc: Xuan Zhuo
Reported-by: Si-Wei Liu
Signed-off-by: Michael S. Tsirkin
---
drivers/net/virtio_net.c | 144 ---
This reverts commit a4e7ba7027012f009f22a68bcfde670f9298d3a4.
leads to crashes with no ACCESS_PLATFORM when
sysctl net.core.high_order_alloc_disable=1
Cc: Xuan Zhuo
Reported-by: Si-Wei Liu
Signed-off-by: Michael S. Tsirkin
---
drivers/net/virtio_net.c | 198 ---
This reverts commit e9f3962441c0a4d6f16c656e6c8aa02a3ccdd568.
leads to crashes with no ACCESS_PLATFORM when
sysctl net.core.high_order_alloc_disable=1
Cc: Xuan Zhuo
Reported-by: Si-Wei Liu
Signed-off-by: Michael S. Tsirkin
---
drivers/net/virtio_net.c | 70 +++-
This reverts commit 09d2b3182c8e3a215a9b2a1834f81dd07305989f.
leads to crashes with no ACCESS_PLATFORM when
sysctl net.core.high_order_alloc_disable=1
Cc: Xuan Zhuo
Reported-by: Si-Wei Liu
Signed-off-by: Michael S. Tsirkin
---
drivers/net/virtio_net.c | 134 ---
This reverts commit defd28aa5acb0fd7c15adc6bc40a8ac277d04dea.
leads to crashes with no ACCESS_PLATFORM when
sysctl net.core.high_order_alloc_disable=1
Cc: Xuan Zhuo
Reported-by: Si-Wei Liu
Signed-off-by: Michael S. Tsirkin
---
drivers/net/virtio_net.c | 89 +++-
This reverts commit a377ae542d8d0a20a3173da3bbba72e045bea7a9.
leads to crashes with no ACCESS_PLATFORM when
sysctl net.core.high_order_alloc_disable=1
Cc: Xuan Zhuo
Reported-by: Si-Wei Liu
Signed-off-by: Michael S. Tsirkin
---
drivers/net/virtio_net.c | 4 ++--
1 file changed, 2 insertions(+)
This reverts commit f9dac92ba9081062a6477ee015bd3b8c5914efc4.
leads to crashes with no ACCESS_PLATFORM when
sysctl net.core.high_order_alloc_disable=1
Cc: Xuan Zhuo
Reported-by: Si-Wei Liu
Signed-off-by: Michael S. Tsirkin
---
drivers/virtio/virtio_ring.c | 7 ++-
1 file changed, 6 insert
On Thu, 5 Sep 2024, Reinette Chatre wrote:
> On 9/5/24 5:10 AM, Ilpo Järvinen wrote:
> > On Wed, 4 Sep 2024, Reinette Chatre wrote:
> > > On 9/4/24 4:57 AM, Ilpo Järvinen wrote:
> > > > On Fri, 30 Aug 2024, Reinette Chatre wrote:
> > > > > On 8/30/24 3:56 AM, Ilpo Järvinen wrote:
> > > > > > On Thu
On Fri, 6 Sep 2024 05:52:36 -0400, "Michael S. Tsirkin" wrote:
> This reverts commit defd28aa5acb0fd7c15adc6bc40a8ac277d04dea.
>
> leads to crashes with no ACCESS_PLATFORM when
> sysctl net.core.high_order_alloc_disable=1
>
> Cc: Xuan Zhuo
> Reported-by: Si-Wei Liu
> Signed-off-by: Michael S. Ts
On Fri, Sep 06, 2024 at 06:02:50PM +0800, Xuan Zhuo wrote:
> On Fri, 6 Sep 2024 05:52:36 -0400, "Michael S. Tsirkin"
> wrote:
> > This reverts commit defd28aa5acb0fd7c15adc6bc40a8ac277d04dea.
> >
> > leads to crashes with no ACCESS_PLATFORM when
> > sysctl net.core.high_order_alloc_disable=1
> >
On Thu, 5 Sep 2024, Shuah Khan wrote:
> When resctrl is built on architectures without __cpuid_count()
> support, build fails. resctrl uses __cpuid_count() defined in
> kselftest.h.
>
> Even though the problem is seen while building resctrl on aarch64,
> this error can be seen on any platform tha
On Wed, Sep 04, 2024 at 09:44:29AM -0700, Josh Poimboeuf wrote:
> Not that I know of, since the compiler usually doesn't have visibility
> to these sections.
>
> It might be possible to specify "entsize" in the .pushsection flags,
> which is an ELF section header attribute which objtool could read
Hi Maintainer,
I have update the patch base on your feedback, please help review again.
V3:
-Fix initial value;
-Remove unnecessary checks about mod->sects_attrs
-Check sysfs_creat_* return value as error code
-Reorder the reveral of successful operations before exiting
We will use the informati
When insmod a kernel module, if fails in add_notes_attrs or
add_sysfs_attrs such as memory allocation fail, mod_sysfs_setup
will still return success, but we can't access user interface
on android device.
Patch for make mod_sysfs_setup can check the error of
add_notes_attrs and add_sysfs_attrs
Ac
On Fri, Sep 06, 2024 at 06:45:53AM +, mohan.pra...@microchip.com wrote:
> Hello Andrew,
>
> Thank you for your review comments.
>
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> > content is safe
> >
> > On Wed, Sep 04, 2024 at 03:45:46AM +0530, Mohan Prasad
Hi
There is a long-standing problem whereby running Intel PT on host and guest
in Host/Guest mode, causes VM-Entry failure.
The motivation for this patch set is to provide a fix for stable kernels
prior to the advent of the "Mediated Passthrough vPMU" patch set:
https://lore.kernel.org/k
Fix KVM IA32_RTIT_CTL MSR validation logic so that if RTIT_CTL_TRACEEN
bit is cleared, then other bits are allowed to change also. For example,
writing 0 to IA32_RTIT_CTL in order to stop tracing, is valid.
Fixes: bf8c55d8dc09 ("KVM: x86: Implement Intel PT MSRs read/write emulation")
Cc: sta...@v
Ensure Intel PT tracing is disabled before VM-Entry in Intel PT Host/Guest
mode.
Intel PT has 2 modes for tracing virtual machines. The default is System
mode whereby host and guest output to the host trace buffer. The other is
Host/Guest mode whereby host and guest output to their own buffers.
Ho
Add a test that starts Intel PT traces on host and guest. The test requires
support for Intel PT and having Host/Guest mode enabled i.e. kvm_intel
module parameter pt_mode=1.
Signed-off-by: Adrian Hunter
---
tools/testing/selftests/kvm/Makefile | 1 +
.../selftests/kvm/include/x86_64/
On 9/6/24 04:12, Ilpo Järvinen wrote:
On Thu, 5 Sep 2024, Shuah Khan wrote:
When resctrl is built on architectures without __cpuid_count()
support, build fails. resctrl uses __cpuid_count() defined in
kselftest.h.
Even though the problem is seen while building resctrl on aarch64,
this error ca
On 9/6/24 01:35, Muhammad Usama Anjum wrote:
Hi Shuah,
Thank you for fixing it.
On 9/5/24 11:02 PM, Shuah Khan wrote:
When resctrl is built on architectures without __cpuid_count()
support, build fails. resctrl uses __cpuid_count() defined in
kselftest.h.
Even though the problem is seen while
rxq contains a pointer to the device from where
the redirect happened. Currently, the BPF program
that was executed after a redirect via BPF_MAP_TYPE_DEVMAP*
does not have it set.
Add bugfix and related selftest.
Signed-off-by: Florian Kauer
---
Changes in v2:
- changed fixes tag
- added selftes
The current xdp_devmap_attach test attaches a program
that redirects to another program via devmap.
It is, however, never executed, so do that to catch
any bugs that might occur during execution.
Also, execute the same for a veth pair so that we
also cover the non-generic path.
Warning: Running
rxq contains a pointer to the device from where
the redirect happened. Currently, the BPF program
that was executed after a redirect via BPF_MAP_TYPE_DEVMAP*
does not have it set.
This is particularly bad since accessing ingress_ifindex, e.g.
SEC("xdp")
int prog(struct xdp_md *pkt)
{
retu
On Fri, Sep 06 2024 at 10:19, zhangji...@cmss.chinamobile.com wrote:
> @@ -362,6 +363,7 @@ int main(int argc, char *argv[])
> {
> char *test_name;
> int c, ret;
> + bool is_static = false;
what means is_static? It's not connected to test_name in any way and
please use reverse fir
On 9/5/24 20:52, zhangjiao2 wrote:
From: zhang jiao
By readind the code, I found the macro NSEC_PER_SEC
reading
is never referenced in the code. Just remove it.
Signed-off-by: zhang jiao
Running checkpatch can catch spelling errors.
---
v1->v2:
Put together files with similar
commit ac3b43283923 ("module: replace module_layout with module_memory")
introduced a set of memory regions for the module layout sharing the
same attributes but didn't update the kmemleak scanned areas which
intended to limit kmemleak scan to sections containing writable data.
This means sections
Hello RT-list!
I'm pleased to announce the 5.10.224-rt116 stable release.
This release is just an update to the new stable 5.10.224 version and
no RT-specific changes have been made.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt
On Thu 2024-09-05 12:23:20, Miroslav Benes wrote:
> Hi,
>
> On Wed, 28 Aug 2024, Wardenjohn wrote:
>
> > One system may contains more than one livepatch module. We can see
> > which patch is enabled. If some patches applied to one system
> > modifing the same function, livepatch will use the func
On Fri 2024-09-06 17:39:46, zhang warden wrote:
> Hi, John & Miroslav
>
> >>
> >> Would it be possible to just use klp_transition_patch and implement the
> >> logic just in using_show()?
> >
> > Yes, containing the logic to the sysfs file sounds a lot better.
>
> Maybe I can try to use the sta
On Fri, Sep 06, 2024 at 03:10:45PM +0530, Beleswar Padhi wrote:
> The current implementation of the waiting mechanism in probe() waits for
> the 'released_from_reset' flag to be set which is done in
> k3_r5_rproc_prepare() as part of rproc_fw_boot(). This causes unexpected
If you are looking at rp
On Fri, Sep 06, 2024 at 12:19:09PM +0200, Borislav Petkov wrote:
> Right, I was talking to Michael about it yesterday, CCed.
>
> He suggested that you might be better off creating these annotations by
> sticking the required info in a section instead of generating symbols.
>
> I.e.,
>
> .pushsec
On Fri, Sep 06, 2024 at 09:56:06AM -0400, Joe Lawrence wrote:
> In the case of klp-diff.c, adding #include will provide the
> memmem prototype. For both files, I needed to #define _GNU_SOURCE for
> that prototype though.
>
> For the other complaint, I just set struct instruction *dest_insn = NUL
On Fri, Sep 6, 2024 at 7:29 AM Shuah Khan wrote:
> On 9/5/24 20:52, zhangjiao2 wrote:
> > diff --git a/tools/testing/selftests/timers/skew_consistency.c
> > b/tools/testing/selftests/timers/skew_consistency.c
> > index c8e6bffe4e0a..83450145fe65 100644
> > --- a/tools/testing/selftests/timers/ske
Hi Mathieu,
On 06-09-2024 22:17, Mathieu Poirier wrote:
On Fri, Sep 06, 2024 at 03:10:45PM +0530, Beleswar Padhi wrote:
The current implementation of the waiting mechanism in probe() waits for
the 'released_from_reset' flag to be set which is done in
k3_r5_rproc_prepare() as part of rproc_fw_bo
Patches here add 'time=ms' in the diagnostic data of the TAP output,
e.g.
ok 1 - pm_netlink: defaults addr list # time=9ms
This addition is useful to quickly identify which subtests are taking a
longer time than the others, or more than expected.
Note that there are no specific formats to foll
It adds 'time=ms' in the diagnostic data of the TAP output, e.g.
ok 1 - pm_netlink: defaults addr list # time=9ms
This addition is useful to quickly identify which subtests are taking a
longer time than the others, or more than expected.
Note that there are no specific formats to follow to sho
It is now added by the MPTCP lib automatically, see the parent commit.
The time in the TAP output might be slightly different from the one
displayed before, but that's OK.
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
v2:
- Fixed typo in the commit message (Jakub)
---
Just to slightly improve the precision of the duration of the first
test.
In mptcp_join.sh, the last append_prev_results is now done as soon as
the last test is over: this will add the last result in the list, and
get a more precise time for this last test.
Reviewed-by: Mat Martineau
Signed-off-
It doesn't need to be there, and it can cause some issues with TAP
parsers expecting only one space around the directive delimiter (#).
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/diag.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/te
It is nice to have a visual alignment in the test output to present the
different results, but it makes less sense in the TAP output that is
there for computers.
It sounds then better to remove the duplicated whitespaces in the TAP
output, also because it can cause some issues with TAP parsers exp
On 9/6/24 11:02, John Stultz wrote:
On Fri, Sep 6, 2024 at 7:29 AM Shuah Khan wrote:
On 9/5/24 20:52, zhangjiao2 wrote:
diff --git a/tools/testing/selftests/timers/skew_consistency.c
b/tools/testing/selftests/timers/skew_consistency.c
index c8e6bffe4e0a..83450145fe65 100644
--- a/tools/testin
On 9/4/24 23:56, Dev Jain wrote:
On 9/4/24 22:35, Shuah Khan wrote:
On 9/3/24 22:52, Dev Jain wrote:
On 9/4/24 03:14, Shuah Khan wrote:
On 8/30/24 10:29, Dev Jain wrote:
On 8/27/24 17:16, Dev Jain wrote:
On 8/27/24 17:14, Shuah Khan wrote:
On 8/22/24 06:14, Dev Jain wrote:
Rename sigal
If an error occurs after the k3_dsp_rproc_request_mbox() call,
mbox_free_channel() must be called, as already done in the remove function.
Instead of adding an error handling path in the probe and changing all
error handling in the function, add a new devm_add_action_or_reset() and
simplify the .r
On 09/06, Florian Kauer wrote:
> The current xdp_devmap_attach test attaches a program
> that redirects to another program via devmap.
>
> It is, however, never executed, so do that to catch
> any bugs that might occur during execution.
>
> Also, execute the same for a veth pair so that we
> also
On 09/06, Stanislav Fomichev wrote:
> On 09/06, Florian Kauer wrote:
> > The current xdp_devmap_attach test attaches a program
> > that redirects to another program via devmap.
> >
> > It is, however, never executed, so do that to catch
> > any bugs that might occur during execution.
> >
> > Also
Hi Linus,
Please pull the following KUnit fixes second update for Linux 6.11-rc7.
This KUnit fixes update for Linux 6.11-rc7 consists of a fix to
missing function parameter warning found during documentation
build in linux-next.
diff is attached.
thanks,
-- Shuah
-
On Fri, Sep 06, 2024 at 10:00:08AM -0700, Josh Poimboeuf wrote:
> On Fri, Sep 06, 2024 at 09:56:06AM -0400, Joe Lawrence wrote:
> > In the case of klp-diff.c, adding #include will provide the
> > memmem prototype. For both files, I needed to #define _GNU_SOURCE for
> > that prototype though.
> >
Padding is not included in UDP and TCP checksums. Therefore, reduce the
length of the checksummed data to include only the data in the IP
payload. This fixes spurious reported checksum failures like
rx: pkt: sport=33000 len=26 csum=0xc850 verify=0xf9fe
pkt: bad csum
Technically it is possible for
On 9/6/24 3:12 PM, Christophe JAILLET wrote:
If an error occurs after the k3_dsp_rproc_request_mbox() call,
mbox_free_channel() must be called, as already done in the remove function.
Instead of adding an error handling path in the probe and changing all
error handling in the function, add a new
On Fri, Sep 06, 2024 at 05:01:51PM -0400, Joe Lawrence wrote:
> On Fri, Sep 06, 2024 at 10:00:08AM -0700, Josh Poimboeuf wrote:
> > On Fri, Sep 06, 2024 at 09:56:06AM -0400, Joe Lawrence wrote:
> > > In the case of klp-diff.c, adding #include will provide the
> > > memmem prototype. For both file
On Fri, Sep 06, 2024 at 07:57:48PM +0800, Chunhui Li wrote:
> When insmod a kernel module, if fails in add_notes_attrs or
> add_sysfs_attrs such as memory allocation fail, mod_sysfs_setup
> will still return success, but we can't access user interface
> on android device.
>
> Patch for make mod_sy
On Fri, Sep 06, 2024 at 04:38:56PM +0100, Vincent Donnefort wrote:
> commit ac3b43283923 ("module: replace module_layout with module_memory")
> introduced a set of memory regions for the module layout sharing the
> same attributes but didn't update the kmemleak scanned areas which
> intended to lim
Hi Ilpo,
On 9/6/24 3:00 AM, Ilpo Järvinen wrote:
On Thu, 5 Sep 2024, Reinette Chatre wrote:
On 9/5/24 5:10 AM, Ilpo Järvinen wrote:
On Wed, 4 Sep 2024, Reinette Chatre wrote:
On 9/4/24 4:57 AM, Ilpo Järvinen wrote:
On Fri, 30 Aug 2024, Reinette Chatre wrote:
On 8/30/24 3:56 AM, Ilpo Järvine
Hi Ilpo,
On 9/6/24 1:44 AM, Ilpo Järvinen wrote:
On Thu, 5 Sep 2024, Reinette Chatre wrote:
On 9/5/24 4:45 AM, Ilpo Järvinen wrote:
On Wed, 4 Sep 2024, Reinette Chatre wrote:
On 9/4/24 4:43 AM, Ilpo Järvinen wrote:
On Fri, 30 Aug 2024, Reinette Chatre wrote:
On 8/30/24 4:42 AM, Ilpo Järvine
The pull request you sent on Fri, 6 Sep 2024 14:46:31 -0600:
> git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
> tags/linux_kselftest-kunit-fixes-6.11-rc7-2
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b31c4492884252a8360f312a0ac2049349ddf603
Th
On Fri, Sep 06, 2024 at 09:56:06AM -0400, Joe Lawrence wrote:
> A few minor build complaints on my system:
>
> $ make tools/objtool/check.o
> CALLscripts/checksyscalls.sh
> DESCEND objtool
> INSTALL libsubcmd_headers
> CC /home/jolawren/src/linux/tools/objtool/check.o
>
Sean Anderson wrote:
> Padding is not included in UDP and TCP checksums. Therefore, reduce the
> length of the checksummed data to include only the data in the IP
> payload. This fixes spurious reported checksum failures like
>
> rx: pkt: sport=33000 len=26 csum=0xc850 verify=0xf9fe
> pkt: bad csu
On Fri, Sep 06, 2024 at 06:51:32AM +, Weinan Liu wrote:
> I'm observing multiple compilation errors when using clang-16 after applying
> this particular patch.
>
> # CC init/main.o
> :4:1: error: symbol '__bug_table_0' is already defined
> __bug_table_0:
Thanks for the report. So far m
If an error occurs after the k3_dsp_rproc_request_mbox() call,
mbox_free_channel() must be called, as already done in the remove function.
Instead of adding an error handling path in the probe and changing all
error handling in the function, add a new devm_add_action_or_reset() and
simplify the .r
On Tue, Sep 03, 2024 at 10:32:00AM -0700, Song Liu wrote:
> +++ w/tools/objtool/elf.c
> @@ -468,10 +468,8 @@ static void elf_add_symbol(struct elf *elf,
> struct symbol *sym)
> *
> * TODO: is this still true?
> */
> -#if 0
> - if (sym->type == STT_NOTYPE && !sym->le
On Wed, 4 Sept 2024 at 21:43, 'Zhen Lei' via KUnit Development
wrote:
>
> Test cases cover all possible situations:
> 1. The cut number is invalid: zero or negative
> 2. Partially cut.
> 3. Cut all.
> 4. The cut number is greater than the number of nodes in the old list.
> 5. The old list is empty
74 matches
Mail list logo
