Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 11:08:48AM GMT, Jason Wang wrote: On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella wrote: On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote: >On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella wrote: >> >> Hi Cindy, Jason, >> >> On Mon, Jul 08, 2024 at 03:59:34P

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-10 Thread Jason Wang
On Wed, Jul 10, 2024 at 3:19 PM Stefano Garzarella wrote: > > On Wed, Jul 10, 2024 at 11:08:48AM GMT, Jason Wang wrote: > >On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella > >wrote: > >> > >> On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote: > >> >On Mon, Jul 8, 2024 at 4:15 PM Stefano

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-10 Thread Petr Pavlu
On 6/17/24 19:58, Sami Tolvanen wrote: > Hi folks, > > This series implements CONFIG_MODVERSIONS for Rust, an important > feature for distributions like Android that want to ship Rust > kernel modules, and depend on modversions to help ensure module ABI > compatibility. Thanks for working on this

Re: [PATCH] test/vsock: add install target

2024-07-10 Thread Stefano Garzarella
On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: From: Peng Fan Add install target for vsock to make Yocto easy to install the images. Signed-off-by: Peng Fan --- tools/testing/vsock/Makefile | 12 1 file changed, 12 insertions(+) diff --git a/tools/testing/vsock/Mak

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 03:28:31PM GMT, Jason Wang wrote: On Wed, Jul 10, 2024 at 3:19 PM Stefano Garzarella wrote: On Wed, Jul 10, 2024 at 11:08:48AM GMT, Jason Wang wrote: >On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella wrote: >> >> On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrot

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Jason Wang
On Wed, Jul 10, 2024 at 2:16 PM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:23:20AM +0800, Jason Wang wrote: > > On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > > > > > QEMU implemented the configuration > > > VIRTIO_BALLOON_F_REPORTING && ! VIRTIO_BALLOON_F_FREE

RE: [PATCH] test/vsock: add install target

2024-07-10 Thread Peng Fan
> Subject: Re: [PATCH] test/vsock: add install target > > On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: > >From: Peng Fan > > > >Add install target for vsock to make Yocto easy to install the images. > > > >Signed-off-by: Peng Fan > >--- > > tools/testing/vsock/Makefile | 12

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-07-10 Thread Takaya Saeki
Hello Matthew, I'd appreciate it if you could comment on this. Thank you.

[PATCH RFC 0/1] Support CMA regions

2024-07-10 Thread Shun-yi Wang
From: "shun-yi.wang" In order to reserve specific Contiguous Memory Allocator (CMA) regions for hardware use. When the name of the reserved region contains "cma", then a corresponding CMA heap is added. In the DTS (Device Tree Source), we may have several memory regions with different names,

[PATCH RFC 1/1] remoteproc: mediatek: Support reserved CMA regions

2024-07-10 Thread Shun-yi Wang
From: "shun-yi.wang" In order to reserve specific Contiguous Memory Allocator (CMA) regions for hardware use. When the name of the reserved region contains "cma", then a corresponding CMA heap is added. Signed-off-by: shun-yi.wang --- drivers/remoteproc/mtk_scp.c | 38 +

[PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

2024-07-10 Thread Menglong Dong
After the commit 5ad2f102 ("tracing/kprobe: bpf: Compare instruction pointer with original one"), "bpf_kprobe_override" is not used anywhere anymore, and we can remove it now. Signed-off-by: Menglong Dong --- include/linux/trace_events.h | 1 - 1 file changed, 1 deletion(-) diff --git a/inc

Re: [PATCH] test/vsock: add install target

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 08:11:32AM GMT, Peng Fan wrote: Subject: Re: [PATCH] test/vsock: add install target On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: >From: Peng Fan > >Add install target for vsock to make Yocto easy to install the images. > >Signed-off-by: Peng Fan >--- >

[PATCH] tracing: Fix overflow in get_free_elt()

2024-07-10 Thread Tze-nan Wu
"tracing_map->next_elt" in get_free_elt() is at risk of overflowing. Once it overflows, new elements can still be inserted into the tracing_map even though the maximum number of elements (`max_elts`) has been reached. Continuing to insert elements after the overflow could result in the tracing_map

Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-07-10 Thread Borislav Petkov
On Tue, Jul 09, 2024 at 01:27:25AM -0500, Naik, Avadhut wrote: > IIUC, its an abbreviation of a Latin word and is used as a synonym for > "namely" > or "that is to say". > Might not be the best choice in this case. Will change it. I learn new stuff every day: https://en.wikipedia.org/wiki/Viz.

Re: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-10 Thread Cindy Lu
On Wed, 10 Jul 2024 at 14:10, Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:05:48AM +0800, Jason Wang wrote: > > On Tue, Jul 9, 2024 at 8:42 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 09, 2024 at 02:19:19PM +0800, Cindy Lu wrote: > > > > On Tue, 9 Jul 2024 at 11:59, Parav Pan

RE: [EXTERNAL] [PATCH net-next v10 04/15] mm: page_frag: add '_va' suffix to page_frag API

2024-07-10 Thread Subbaraya Sundeep Bhatta
From: Yunsheng Lin Sent: Tuesday, July 9, 2024 6:57 PM To: da...@davemloft.net; k...@kernel.org; pab...@redhat.com Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Yunsheng Lin ; Alexander Duyck ; Jeroen de Borst ; Praveen Kaligineedi ; Shailend Chand ; Eric Dumazet ; Tony Nguyen

RE: [PATCH] test/vsock: add install target

2024-07-10 Thread Peng Fan
> Subject: Re: [PATCH] test/vsock: add install target > > On Wed, Jul 10, 2024 at 08:11:32AM GMT, Peng Fan wrote: > >> Subject: Re: [PATCH] test/vsock: add install target > >> > >> On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: > >> >From: Peng Fan > >> > > >> >Add install target f

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 03:37:49PM +0800, Jason Wang wrote: > On Wed, Jul 10, 2024 at 2:16 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 10, 2024 at 11:23:20AM +0800, Jason Wang wrote: > > > On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > > > > > > > QEMU implemented the configura

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-10 Thread Peter Zijlstra
On Tue, Jul 09, 2024 at 10:50:00AM -0700, Andrii Nakryiko wrote: > On Tue, Jul 9, 2024 at 3:11 AM Peter Zijlstra wrote: > > > > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > > +#ifdef CONFIG_UPROBES > > > +/* > > > + * Heuristic-based check if uprobe is installed at the func

[PATCH v2 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Michael S. Tsirkin
QEMU implemented the configuration VIRTIO_BALLOON_F_REPORTING && ! VIRTIO_BALLOON_F_FREE_PAGE_HINT incorrectly: it then uses vq3 for reporting, spec says it is always 4. This is masked by a corresponding bug in driver: add a work around as I'm going to try and fix the driver bug. Message-

[PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Michael S. Tsirkin
virtio balloon communicates to the core that in some configurations vq #s are non-contiguous by setting name pointer to NULL. Unfortunately, core then turned around and just made them contiguous again. Result is that driver is out of spec. Implement what the API was supposed to do in the 1st plac

Re: [PATCH] test/vsock: add install target

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 11:34:05AM GMT, Peng Fan wrote: Subject: Re: [PATCH] test/vsock: add install target On Wed, Jul 10, 2024 at 08:11:32AM GMT, Peng Fan wrote: >> Subject: Re: [PATCH] test/vsock: add install target >> >> On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: >> >From:

[PATCH V2] test/vsock: add install target

2024-07-10 Thread Peng Fan (OSS)
From: Peng Fan Add install target for vsock to make Yocto easy to install the images. Signed-off-by: Peng Fan --- V2: Use VSOCK_INSTALL_PATH, drop INSTALL_PATH tools/testing/vsock/Makefile | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/testing/vsock/Makefile b/tool

Re: [PATCH V2] test/vsock: add install target

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 08:27:28PM GMT, Peng Fan (OSS) wrote: From: Peng Fan Add install target for vsock to make Yocto easy to install the images. Signed-off-by: Peng Fan --- LGTM! This is a net-next material, so next time better to specify it (e.g. [PATCH net-next]). If not queued with

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-10 Thread Peter Hilber
On 08.07.24 11:27, David Woodhouse wrote: > From: David Woodhouse > > The vmclock "device" provides a shared memory region with precision clock > information. By using shared memory, it is safe across Live Migration. > > Like the KVM PTP clock, this can convert TSC-based cross timestamps into >

Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

2024-07-10 Thread Jiri Olsa
On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote: > After the commit 5ad2f102 ("tracing/kprobe: bpf: Compare instruction should be in Fixes: tag probably ? > pointer with original one"), "bpf_kprobe_override" is not used anywhere > anymore, and we can remove it now. > > Signed-o

Re: [PATCH v3] init: staging: Fix missing warning/taint on builtin code

2024-07-10 Thread Greg Kroah-Hartman
On Sat, Jul 06, 2024 at 12:15:01AM -0300, Ágatha Isabelle Chris Moreira Guedes wrote: > Fix the absence of warning message and kernel tainting when initializing > drivers from the `drivers/staging` subtree from initcalls (when > configured as built-in). > > When such a driver is built as module a

Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

2024-07-10 Thread Google
On Wed, 10 Jul 2024 15:13:07 +0200 Jiri Olsa wrote: > On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote: > > After the commit 5ad2f102 ("tracing/kprobe: bpf: Compare instruction > > should be in Fixes: tag probably ? Yes, I'll add a Fixed tag. > > > pointer with original one")

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 4:39 AM Peter Zijlstra wrote: > > On Tue, Jul 09, 2024 at 10:50:00AM -0700, Andrii Nakryiko wrote: > > On Tue, Jul 9, 2024 at 3:11 AM Peter Zijlstra wrote: > > > > > > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > > > +#ifdef CONFIG_UPROBES > > > > +

Re: [PATCH v4 1/3] x86/sgx: Split SGX_ENCL_PAGE_BEING_RECLAIMED into two flags

2024-07-10 Thread Haitao Huang
On Fri, 05 Jul 2024 02:45:22 -0500, Dmitrii Kuvaiskii wrote: SGX_ENCL_PAGE_BEING_RECLAIMED flag is set when the enclave page is being reclaimed (moved to the backing store). This flag however has two logical meanings: 1. Don't attempt to load the enclave page (the page is busy). 2. Don't att

Re: [PATCH v4 3/3] x86/sgx: Resolve EREMOVE page vs EAUG page data race

2024-07-10 Thread Haitao Huang
On Fri, 05 Jul 2024 02:45:24 -0500, Dmitrii Kuvaiskii wrote: Two enclave threads may try to add and remove the same enclave page simultaneously (e.g., if the SGX runtime supports both lazy allocation and MADV_DONTNEED semantics). Consider some enclave page added to the enclave. User space dec

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Mathieu Poirier
On Wed, 10 Jul 2024 at 05:43, Michael S. Tsirkin wrote: > > virtio balloon communicates to the core that in some > configurations vq #s are non-contiguous by setting name > pointer to NULL. > > Unfortunately, core then turned around and just made them > contiguous again. Result is that driver is o

Re: [PATCH 0/1] Support multiple reserved memory regions

2024-07-10 Thread Mathieu Poirier
Good morning, On Wed, Jul 03, 2024 at 07:53:07PM +0800, Shun-yi Wang wrote: > From: "shun-yi.wang" > > Besides the reserved memory region for SCP, there are additional > reserved memory regions for specific hardware use. > Currently, only a single memory region is supported. > Modifications are

Re: [PATCH v3 1/9] dt-bindings: interconnect: qcom: Add Qualcomm MSM8976 NoC

2024-07-10 Thread Rob Herring
On Tue, Jul 09, 2024 at 12:22:46PM +0200, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski > --- > .../bindings/interconnect/qcom,msm8939.yaml | 15 ++- > .../dt-bindings/interconnect/qcom,msm8976.h | 97 +

Re: [PATCH v3 3/9] dt-bindings: interconnect: qcom: Add Qualcomm MSM8937 NoC

2024-07-10 Thread Rob Herring
On Tue, Jul 09, 2024 at 12:22:48PM +0200, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices. That is obvious. What would be useful is detailing how 8937 is similar to the existing devices. > > Signed-off-by: Adam Skladowski > --- > .../bindings/in

Re: [PATCH 1/1] remoteproc: mediatek: Support multiple reserved memory regions

2024-07-10 Thread Mathieu Poirier
On Wed, Jul 03, 2024 at 07:53:08PM +0800, Shun-yi Wang wrote: > From: "shun-yi.wang" > > SCP supports multiple reserved memory regions, intended for > specific hardwards. > > Signed-off-by: shun-yi.wang > --- > drivers/remoteproc/mtk_scp.c | 25 + > 1 file changed, 17 in

Re: [PATCH v3 3/9] dt-bindings: interconnect: qcom: Add Qualcomm MSM8937 NoC

2024-07-10 Thread Rob Herring (Arm)
On Tue, 09 Jul 2024 12:22:48 +0200, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski > --- > .../bindings/interconnect/qcom,msm8939.yaml | 8 +- > .../dt-bindings/interconnect/qcom,msm8937.h | 93 ++

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-10 Thread David Woodhouse
On Wed, 2024-07-10 at 15:07 +0200, Peter Hilber wrote: > On 08.07.24 11:27, David Woodhouse wrote: > > From: David Woodhouse > > > > The vmclock "device" provides a shared memory region with precision clock > > information. By using shared memory, it is safe across Live Migration. > > > > Like t

Re: [PATCH v3 7/9] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-07-10 Thread Rob Herring (Arm)
On Tue, 09 Jul 2024 12:22:52 +0200, Adam Skladowski wrote: > For now example list snoc_mm as children of bimc which is obviously > not valid, drop bimc and move snoc_mm into snoc. > > Signed-off-by: Adam Skladowski > --- > .../devicetree/bindings/interconnect/qcom,msm8939.yaml | 6 --

Re: [PATCH v3 9/9] dt-bindings: interconnect: qcom: msm8953: Fix 'See also' in description

2024-07-10 Thread Rob Herring (Arm)
On Tue, 09 Jul 2024 12:22:54 +0200, Adam Skladowski wrote: > "See also" in description seems to be wrongly defined, > make it inline with other yamls. > > Fixes: 791ed23f735b ("dt-bindings: interconnect: qcom: Add Qualcomm MSM8953 > NoC") > Signed-off-by: Adam Skladowski > --- > .../devicetre

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-10 Thread Josh Poimboeuf
On Wed, Jul 10, 2024 at 08:11:57AM -0700, Andrii Nakryiko wrote: > On Wed, Jul 10, 2024 at 4:39 AM Peter Zijlstra wrote: > > On Tue, Jul 09, 2024 at 10:50:00AM -0700, Andrii Nakryiko wrote: > > > You can see it replaced the first byte, the following 3 bytes are > > > remnants of endb64 (gdb says i

[PATCH 0/3] uprobes: future cleanups for review

2024-07-10 Thread Oleg Nesterov
On 07/10, Oleg Nesterov wrote: > > Peter, these simple cleanups should not conflict with your changes, > but I can resend them later if it causes any inconvenience. In fact I would like to push 2 more cleanups before the more significant changes, but they certainly conflict with your ongoing work,

[PATCH 1/3] uprobes: kill uprobe_register_refctr()

2024-07-10 Thread Oleg Nesterov
It doesn't make any sense to have 2 versions of _register(). Note that trace_uprobe_enable(), the only user of uprobe_register(), doesn't need to check tu->ref_ctr_offset to decide which one should be used, it could safely pass ref_ctr_offset == 0 to uprobe_register_refctr(). Add this argument to

[PATCH 2/3] uprobes: simplify error handling for alloc_uprobe()

2024-07-10 Thread Oleg Nesterov
From: Andrii Nakryiko Return -ENOMEM instead of NULL, which makes caller's error handling just a touch simpler. Signed-off-by: Andrii Nakryiko Signed-off-by: Oleg Nesterov --- kernel/events/uprobes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/events/uprobes.

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Jiri Olsa
On Wed, Jul 10, 2024 at 06:31:33PM +0200, Oleg Nesterov wrote: SNIP > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > index 467f358c8ce7..7571811127a2 100644 > --- a/kernel/trace/bpf_trace.c > +++ b/kernel/trace/bpf_trace.c > @@ -3157,6 +3157,7 @@ struct bpf_uprobe { > lo

[PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Oleg Nesterov
This way uprobe_unregister() and uprobe_apply() do not need find_uprobe() + put_uprobe(). And to me this change simplifies the code a bit. Signed-off-by: Oleg Nesterov --- include/linux/uprobes.h | 14 ++-- kernel/events/uprobes.c | 45 - kerne

Re: [PATCH 1/3] uprobes: kill uprobe_register_refctr()

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 9:32 AM Oleg Nesterov wrote: > > It doesn't make any sense to have 2 versions of _register(). Note that > trace_uprobe_enable(), the only user of uprobe_register(), doesn't need > to check tu->ref_ctr_offset to decide which one should be used, it could > safely pass ref_ctr

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Daniel Verkamp
On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > virtio balloon communicates to the core that in some > configurations vq #s are non-contiguous by setting name > pointer to NULL. > > Unfortunately, core then turned around and just made them > contiguous again. Result is that driver is

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 9:33 AM Oleg Nesterov wrote: > > This way uprobe_unregister() and uprobe_apply() do not need find_uprobe() + > put_uprobe(). And to me this change simplifies the code a bit. > > Signed-off-by: Oleg Nesterov > --- > include/linux/uprobes.h | 14 ++-- > kernel/e

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 9:49 AM Jiri Olsa wrote: > > On Wed, Jul 10, 2024 at 06:31:33PM +0200, Oleg Nesterov wrote: > > SNIP > > > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > > index 467f358c8ce7..7571811127a2 100644 > > --- a/kernel/trace/bpf_trace.c > > +++ b/kernel/trace/

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > > > virtio balloon communicates to the core that in some > > configurations vq #s are non-contiguous by setting name > > pointer to NULL. > > > > Unfortunately, core then

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > > > virtio balloon communicates to the core that in some > > configurations vq #s are non-contiguous by setting name > > pointer to NULL. > > > > Unfortunately, core then

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Oleg Nesterov
On 07/10, Jiri Olsa wrote: > > > @@ -3180,10 +3181,8 @@ static void bpf_uprobe_unregister(struct path *path, > > struct bpf_uprobe *uprobes, > > { > > u32 i; > > > > - for (i = 0; i < cnt; i++) { > > - uprobe_unregister(d_real_inode(path->dentry), uprobes[i].offset, > > -

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 9:24 AM Josh Poimboeuf wrote: > > On Wed, Jul 10, 2024 at 08:11:57AM -0700, Andrii Nakryiko wrote: > > On Wed, Jul 10, 2024 at 4:39 AM Peter Zijlstra wrote: > > > On Tue, Jul 09, 2024 at 10:50:00AM -0700, Andrii Nakryiko wrote: > > > > You can see it replaced the first byt

Re: [PATCH 1/3] uprobes: kill uprobe_register_refctr()

2024-07-10 Thread Oleg Nesterov
On 07/10, Andrii Nakryiko wrote: > > LGTM with few nits below. > > Acked-by: Andrii Nakryiko Thanks for looking at this. > > @@ -3477,7 +3477,7 @@ int bpf_uprobe_multi_link_attach(const union bpf_attr > > *attr, struct bpf_prog *pr > > &bpf_uprobe_multi_link_lops, prog); >

[PATCH v5] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-10 Thread Andrii Nakryiko
When tracing user functions with uprobe functionality, it's common to install the probe (e.g., a BPF program) at the first instruction of the function. This is often going to be `push %rbp` instruction in function preamble, which means that within that function frame pointer hasn't been established

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Jiri Olsa
On Wed, Jul 10, 2024 at 11:23:10AM -0700, Andrii Nakryiko wrote: > On Wed, Jul 10, 2024 at 9:49 AM Jiri Olsa wrote: > > > > On Wed, Jul 10, 2024 at 06:31:33PM +0200, Oleg Nesterov wrote: > > > > SNIP > > > > > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > > > index 467f358c8ce

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 12:38 PM Jiri Olsa wrote: > > On Wed, Jul 10, 2024 at 11:23:10AM -0700, Andrii Nakryiko wrote: > > On Wed, Jul 10, 2024 at 9:49 AM Jiri Olsa wrote: > > > > > > On Wed, Jul 10, 2024 at 06:31:33PM +0200, Oleg Nesterov wrote: > > > > > > SNIP > > > > > > > diff --git a/kernel

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Daniel Verkamp
On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > > On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > > > > > virtio balloon communicates to the core that in some > > > configurations vq #s are non-contiguo

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Oleg Nesterov
On 07/10, Andrii Nakryiko wrote: > > On Wed, Jul 10, 2024 at 9:33 AM Oleg Nesterov wrote: > > > > This way uprobe_unregister() and uprobe_apply() do not need find_uprobe() + > > put_uprobe(). And to me this change simplifies the code a bit. > > > > Signed-off-by: Oleg Nesterov > > --- > > includ

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 12:58:11PM -0700, Daniel Verkamp wrote: > On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin wrote: > > > > On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > > > On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin > > > wrote: > > > > > > > > virtio balloo

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 1:18 PM Oleg Nesterov wrote: > > On 07/10, Andrii Nakryiko wrote: > > > > On Wed, Jul 10, 2024 at 9:33 AM Oleg Nesterov wrote: > > > > > > This way uprobe_unregister() and uprobe_apply() do not need find_uprobe() > > > + > > > put_uprobe(). And to me this change simplifie

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Daniel Verkamp
On Wed, Jul 10, 2024 at 1:39 PM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 12:58:11PM -0700, Daniel Verkamp wrote: > > On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > > > > On Wed, Jul 10, 2024 at

Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-07-10 Thread Naik, Avadhut
On 7/10/2024 04:38, Borislav Petkov wrote: > On Tue, Jul 09, 2024 at 01:27:25AM -0500, Naik, Avadhut wrote: > >> Userspace error decoding tools like the rasdaemon gather related hardware >> error >> information through the tracepoints. As such, its important to have these two >> registers in t

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 03:54:22PM -0700, Daniel Verkamp wrote: > On Wed, Jul 10, 2024 at 1:39 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 10, 2024 at 12:58:11PM -0700, Daniel Verkamp wrote: > > > On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Jul 1

[PATCH] bootconfig: Remove duplicate included header file linux/bootconfig.h

2024-07-10 Thread Thorsten Blum
The header file linux/bootconfig.h is included whether __KERNEL__ is defined or not. Include it only once before the #ifdef/#else/#endif preprocessor directives and remove the following make includecheck warning: linux/bootconfig.h is included more than once Signed-off-by: Thorsten Blum ---

[ANNOUNCE] 5.10.220-rt112

2024-07-10 Thread Luis Claudio R. Goncalves
Hello RT-list! I'm pleased to announce the 5.10.220-rt112 stable release. This release is just an update to the new stable 5.10.220 version and no RT specific changes have been made. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt

Re: [PATCH] bootconfig: Remove duplicate included header file linux/bootconfig.h

2024-07-10 Thread Google
On Thu, 11 Jul 2024 02:21:53 +0200 Thorsten Blum wrote: > The header file linux/bootconfig.h is included whether __KERNEL__ is > defined or not. > > Include it only once before the #ifdef/#else/#endif preprocessor > directives and remove the following make includecheck warning: > > linux/boot

Re: [PATCH] test/vsock: add install target

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 13:58:39 +0200 Stefano Garzarella wrote: > There is a comment there: > > # Avoid changing the rest of the logic here and lib.mk. > > Added by commit 17eac6c2db8b2cdfe33d40229bdda2acd86b304a. > > IIUC they re-used INSTALL_PATH, just to avoid too many changes in that > fi