Re: [PATCH v3 1/2] rust: add static_key_false

2024-06-27 Thread Alice Ryhl
On Tue, Jun 25, 2024 at 6:18 PM Boqun Feng wrote: > > Hi Alice, > > On Fri, Jun 21, 2024 at 10:35:26AM +, Alice Ryhl wrote: > > Add just enough support for static key so that we can use it from > > tracepoints. Tracepoints rely on `static_key_false` even though it is > > deprecated, so we add

Re: [PATCH v4] tracing/net_sched: NULL pointer dereference in perf_trace_qdisc_reset()

2024-06-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 25 Jun 2024 02:33:23 +0900 you wrote: > From: Yunseong Kim > > In the TRACE_EVENT(qdisc_reset) NULL dereference occurred from > > qdisc->dev_queue->dev ->name > > This situation simulated from bunch of veths and

Re: [PATCH v4] tracing/net_sched: NULL pointer dereference in perf_trace_qdisc_reset()

2024-06-27 Thread Paolo Abeni
On Tue, 2024-06-25 at 02:33 +0900, ysk...@gmail.com wrote: > From: Yunseong Kim > > In the TRACE_EVENT(qdisc_reset) NULL dereference occurred from > > qdisc->dev_queue->dev ->name > > This situation simulated from bunch of veths and Bluetooth disconnection > and reconnection. > > During qdis

Re: [PATCH v9 1/8] remoteproc: qcom: Add PRNG proxy clock

2024-06-27 Thread Gokul Sriram P
On 6/27/2024 12:47 AM, Dmitry Baryshkov wrote: On Tue, Jun 25, 2024 at 11:03:30AM GMT, Gokul Sriram P wrote: On 6/22/2024 2:38 AM, Dmitry Baryshkov wrote: On Fri, Jun 21, 2024 at 05:16:52PM GMT, Gokul Sriram Palanisamy wrote: PRNG clock is needed by the secure PIL, support for the same is ad

Re: [PATCH net-next v3 1/3] vsock: add support for SIOCOUTQ ioctl for all vsock socket types.

2024-06-27 Thread kernel test robot
Hi Luigi, kernel test robot noticed the following build warnings: [auto build test WARNING on 50b70845fc5c22cf7e7d25b57d57b3dca1725aa5] url: https://github.com/intel-lab-lkp/linux/commits/Luigi-Leonardi-via-B4-Relay/vsock-add-support-for-SIOCOUTQ-ioctl-for-all-vsock-socket-types/20240627

[PATCH V3 0/2] Use of devname for interrupt descriptions and tracepoint support for smp2p

2024-06-27 Thread Sudeepgoud Patil
This commit enhances the smp2p driver by adding support for using the device name in interrupt descriptions and introducing tracepoint functionality. These improvements facilitate more effective debugging of smp2p-related issues. The devname patch, along with the callback to print the irq chip nam

[PATCH V3 1/2] soc: qcom: smp2p: Use devname for interrupt descriptions

2024-06-27 Thread Sudeepgoud Patil
From: Chris Lew When using /proc/interrupts to collect statistics on smp2p interrupt counts, it is hard to distinguish the different instances of smp2p from each other. For example to debug a processor boot issue, the ready and handover interrupts are checked for sanity to ensure the firmware rea

[PATCH V3 2/2] soc: qcom: smp2p: Introduce tracepoint support

2024-06-27 Thread Sudeepgoud Patil
This commit introduces tracepoint support for smp2p, enabling logging of communication between local and remote processors. These tracepoints include information about the remote subsystem name, negotiation details, supported features, bit change notifications, and ssr activity. These logs are usef

Re: [PATCH v9 1/8] remoteproc: qcom: Add PRNG proxy clock

2024-06-27 Thread Dmitry Baryshkov
On Thu, Jun 27, 2024 at 03:31:01PM GMT, Gokul Sriram P wrote: > > On 6/27/2024 12:47 AM, Dmitry Baryshkov wrote: > > On Tue, Jun 25, 2024 at 11:03:30AM GMT, Gokul Sriram P wrote: > > > On 6/22/2024 2:38 AM, Dmitry Baryshkov wrote: > > > > On Fri, Jun 21, 2024 at 05:16:52PM GMT, Gokul Sriram Palani

Re: [PATCH v9 3/8] remoteproc: qcom: Add support for split q6 + m3 wlan firmware

2024-06-27 Thread Dmitry Baryshkov
On Fri, Jun 21, 2024 at 05:16:54PM GMT, Gokul Sriram Palanisamy wrote: > IPQ8074 supports split firmware for q6 and m3 as well. > So add support for loading the m3 firmware before q6. > Now the drivers works fine for both split and unified > firmwares. Right now linux-firmware ships both q6 and m3

Re: [PATCH v9 1/8] remoteproc: qcom: Add PRNG proxy clock

2024-06-27 Thread Gokul Sriram P
On 6/27/2024 4:38 PM, Dmitry Baryshkov wrote: On Thu, Jun 27, 2024 at 03:31:01PM GMT, Gokul Sriram P wrote: On 6/27/2024 12:47 AM, Dmitry Baryshkov wrote: On Tue, Jun 25, 2024 at 11:03:30AM GMT, Gokul Sriram P wrote: On 6/22/2024 2:38 AM, Dmitry Baryshkov wrote: On Fri, Jun 21, 2024 at 05:1

Re: [PATCH v9 8/8] arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC

2024-06-27 Thread kernel test robot
/scm/linux/kernel/git/remoteproc/linux.git rproc-next patch link: https://lore.kernel.org/r/20240621114659.2958170-9-quic_gokulsri%40quicinc.com patch subject: [PATCH v9 8/8] arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC config: arm64-randconfig-051-20240627 (https://download.01.org/0day-

[PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Name the regulators

2024-06-27 Thread Luca Weiss
-name = "vreg_l10e"; regulator-min-microvolt = <300>; regulator-max-microvolt = <3401000>; regulator-initial-mode = ; }; vreg_l11e: ldo11 { + regulator-name = "vreg_l11e"; regulator-min-microvolt = <300>; regulator-max-microvolt = <3401000>; regulator-initial-mode = ; }; vreg_bob: bob { + regulator-name = "vreg_bob"; regulator-min-microvolt = <162>; regulator-max-microvolt = <5492000>; regulator-initial-mode = ; --- base-commit: 1ce80da8c5d0c297c4e7db33e36abe0262f86b23 change-id: 20240627-fp4-regulator-name-aa86b983f162 Best regards, -- Luca Weiss

Re: [PATCH v9 1/8] remoteproc: qcom: Add PRNG proxy clock

2024-06-27 Thread Dmitry Baryshkov
On Thu, Jun 27, 2024 at 04:59:38PM GMT, Gokul Sriram P wrote: > > On 6/27/2024 4:38 PM, Dmitry Baryshkov wrote: > > On Thu, Jun 27, 2024 at 03:31:01PM GMT, Gokul Sriram P wrote: > > > On 6/27/2024 12:47 AM, Dmitry Baryshkov wrote: > > > > On Tue, Jun 25, 2024 at 11:03:30AM GMT, Gokul Sriram P wrot

Re: [PATCH] uprobe: Do not use UPROBE_SWBP_INSN as static initializer

2024-06-27 Thread Jiri Olsa
On Fri, Jun 21, 2024 at 03:17:58PM +0200, Jiri Olsa wrote: > On Fri, Jun 21, 2024 at 02:01:50PM +0200, Oleg Nesterov wrote: > > On 06/20, Andrii Nakryiko wrote: > > > > > > On Thu, Jun 20, 2024 at 12:40 PM Oleg Nesterov wrote: > > > > > > > > But I can't understand what does it do, it calls emit_b

Re: [RFC PATCH v3 0/7] Add virtio_rtc module and related changes

2024-06-27 Thread Peter Hilber
On 21.06.24 10:45, David Woodhouse wrote: > On Thu, 2024-06-20 at 17:19 +0100, David Woodhouse wrote: >> >>> + +   /* Counter frequency, and error margin. Units of (second >> 64) */ +   uint64_t counter_period_frac_sec; >>> >>> AFAIU this might limit the precision in case of

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-27 Thread Peter Hilber
On 25.06.24 21:01, David Woodhouse wrote: > From: David Woodhouse > > The vmclock "device" provides a shared memory region with precision clock > information. By using shared memory, it is safe across Live Migration. > > Like the KVM PTP clock, this can convert TSC-based cross timestamps into >

Re: [PATCH] uprobe: Do not use UPROBE_SWBP_INSN as static initializer

2024-06-27 Thread Google
On Thu, 27 Jun 2024 15:44:16 +0200 Jiri Olsa wrote: > On Fri, Jun 21, 2024 at 03:17:58PM +0200, Jiri Olsa wrote: > > On Fri, Jun 21, 2024 at 02:01:50PM +0200, Oleg Nesterov wrote: > > > On 06/20, Andrii Nakryiko wrote: > > > > > > > > On Thu, Jun 20, 2024 at 12:40 PM Oleg Nesterov wrote: > > > >

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-27 Thread David Woodhouse
On Thu, 2024-06-27 at 15:50 +0200, Peter Hilber wrote: > On 25.06.24 21:01, David Woodhouse wrote: > > From: David Woodhouse > > > > The vmclock "device" provides a shared memory region with precision clock > > information. By using shared memory, it is safe across Live Migration. > > > > Like t

[PATCH v5 1/8] cleanup.h: Header include guard should match header name

2024-06-27 Thread Mathieu Desnoyers
The include guard should match the header name. Rename __LINUX_GUARDS_H to __LINUX_CLEANUP_H. Signed-off-by: Mathieu Desnoyers Cc: Peter Zijlstra (Intel) Cc: Ingo Molnar --- include/linux/cleanup.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/cleanup.

[PATCH v5 3/8] cleanup.h: Introduce DEFINE_INACTIVE_GUARD and activate_guard

2024-06-27 Thread Mathieu Desnoyers
To cover scenarios where the scope of the guard differs from the scope of its activation, introduce DEFINE_INACTIVE_GUARD() and activate_guard(). Here is an example use for a conditionally activated guard variable: void func(bool a) { DEFINE_INACTIVE_GUARD(preempt_notrace, myguard);

[PATCH v5 0/8] Faultable Tracepoints

2024-06-27 Thread Mathieu Desnoyers
Wire up the system call tracepoints with Tasks Trace RCU to allow the ftrace, perf, and eBPF tracers to handle page faults. This series does the initial wire-up allowing tracers to handle page faults, but leaves out the actual handling of said page faults as future work. I have tested this agains

[PATCH v5 4/8] tracing: Introduce faultable tracepoints

2024-06-27 Thread Mathieu Desnoyers
When invoked from system call enter/exit instrumentation, accessing user-space data is a common use-case for tracers. However, tracepoints currently disable preemption around iteration on the registered tracepoint probes and invocation of the probe callbacks, which prevents tracers from handling pa

[PATCH v5 2/8] cleanup.h guard: Rename DEFINE_ prefix to DECLARE_

2024-06-27 Thread Mathieu Desnoyers
The convention used in other kernel headers (e.g. wait.h, percpu-defs.h) is to use "DECLARE_" prefix for macros emitting externs, static inlines and type definitions. The "DEFINE_" prefix is used for variable definitions. In preparation to introduce a "DEFINE_INACTIVE_GUARD()" to actually define

[PATCH v5 6/8] tracing/bpf-trace: Add support for faultable tracepoints

2024-06-27 Thread Mathieu Desnoyers
In preparation for converting system call enter/exit instrumentation into faultable tracepoints, make sure that bpf can handle registering to such tracepoints by explicitly disabling preemption within the bpf tracepoint probes to respect the current expectations within bpf tracing code. This chang

[PATCH v5 5/8] tracing/ftrace: Add support for faultable tracepoints

2024-06-27 Thread Mathieu Desnoyers
In preparation for converting system call enter/exit instrumentation into faultable tracepoints, make sure that ftrace can handle registering to such tracepoints by explicitly disabling preemption within the ftrace tracepoint probes to respect the current expectations within ftrace ring buffer code

[PATCH v5 7/8] tracing/perf: Add support for faultable tracepoints

2024-06-27 Thread Mathieu Desnoyers
In preparation for converting system call enter/exit instrumentation into faultable tracepoints, make sure that perf can handle registering to such tracepoints by explicitly disabling preemption within the perf tracepoint probes to respect the current expectations within perf ring buffer code. Thi

[PATCH v5 8/8] tracing: Convert sys_enter/exit to faultable tracepoints

2024-06-27 Thread Mathieu Desnoyers
Convert the definition of the system call enter/exit tracepoints to faultable tracepoints now that all upstream tracers handle it. This allows tracers to fault-in userspace system call arguments such as path strings within their probe callbacks. Link: https://lore.kernel.org/lkml/20231002202531.

Re: [PATCH] uprobe: Do not use UPROBE_SWBP_INSN as static initializer

2024-06-27 Thread Oleg Nesterov
On 06/27, Masami Hiramatsu wrote: > > On Thu, 27 Jun 2024 15:44:16 +0200 > Jiri Olsa wrote: > > > Oleg, do you want to send formal patch? > > > > thanks, > > jirka > > Yes, can you send v2 patch? I was waiting for the comments from loongarch maintainers... OK, will do today, but the patch won't

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-27 Thread David Woodhouse
I've updated the tree at https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/vmclock (but not yet the qemu one). I think I've taken into account all your comments apart from the one about non-64-bit counters wrapping. I reduced the seq_count to 32 bit to make room for a 32-bit fla

[PATCH] LoongArch: uprobes: make UPROBE_SWBP_INSN/UPROBE_XOLBP_INSN constant

2024-06-27 Thread Oleg Nesterov
LoongArch defines UPROBE_SWBP_INSN as a function call and this breaks arch_uprobe_trampoline() which uses it to initialize a static variable. Fixes: ff474a78cef5 ("uprobe: Add uretprobe syscall to speed up return probe") Reported-by: Nathan Chancellor Closes: https://lore.kernel.org/all/202406141

Re: [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

2024-06-27 Thread Yazen Ghannam
On Wed, Jun 26, 2024 at 08:20:13PM +0200, Borislav Petkov wrote: > On Wed, Jun 26, 2024 at 01:00:30PM -0500, Naik, Avadhut wrote: > > > > > > Why are you clearing it if you're overwriting it immediately? > > > > > Since its a local variable, wanted to ensure that the memory is zeroed out > > to

Re: [PATCH v3 1/2] rust: add static_key_false

2024-06-27 Thread Boqun Feng
On Thu, Jun 27, 2024 at 10:34:39AM +0200, Alice Ryhl wrote: > On Tue, Jun 25, 2024 at 6:18 PM Boqun Feng wrote: > > > > Hi Alice, > > > > On Fri, Jun 21, 2024 at 10:35:26AM +, Alice Ryhl wrote: > > > Add just enough support for static key so that we can use it from > > > tracepoints. Tracepoin

Re: [PATCH] LoongArch: uprobes: make UPROBE_SWBP_INSN/UPROBE_XOLBP_INSN constant

2024-06-27 Thread Andrii Nakryiko
On Thu, Jun 27, 2024 at 9:04 AM Oleg Nesterov wrote: > > LoongArch defines UPROBE_SWBP_INSN as a function call and this breaks > arch_uprobe_trampoline() which uses it to initialize a static variable. > > Fixes: ff474a78cef5 ("uprobe: Add uretprobe syscall to speed up return probe") > Reported-by:

[PATCH][next] firewire: core: Fix spelling mistakes in tracepoint messages

2024-06-27 Thread Colin Ian King
There are two spelling mistakes in the tracepoint message text. Fix them. Signed-off-by: Colin Ian King --- include/trace/events/firewire.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h index d9158a134beb

Re: [PATCH] LoongArch: uprobes: make UPROBE_SWBP_INSN/UPROBE_XOLBP_INSN constant

2024-06-27 Thread Oleg Nesterov
On 06/27, Andrii Nakryiko wrote: > > Acked-by: Andrii Nakryiko Thanks! > > --- a/arch/loongarch/kernel/uprobes.c > > +++ b/arch/loongarch/kernel/uprobes.c > > @@ -7,6 +7,14 @@ > > > > #define UPROBE_TRAP_NR UINT_MAX > > > > +static __init int check_emit_break(void) > > +{ > > + BUG_ON(UPR

Re: [PATCH -fixes] riscv: patch: Flush the icache right after patching to avoid illegal insns

2024-06-27 Thread Palmer Dabbelt
On Mon, 24 Jun 2024 01:21:41 PDT (-0700), alexgh...@rivosinc.com wrote: We cannot delay the icache flush after patching some functions as we may have patched a function that will get called before the icache flush. The only way to completely avoid such scenario is by flushing the icache as soon

Re: [PATCH -fixes] riscv: patch: Flush the icache right after patching to avoid illegal insns

2024-06-27 Thread patchwork-bot+linux-riscv
Hello: This patch was applied to riscv/linux.git (fixes) by Palmer Dabbelt : On Mon, 24 Jun 2024 10:21:41 +0200 you wrote: > We cannot delay the icache flush after patching some functions as we may > have patched a function that will get called before the icache flush. > > The only way to comple

Re: [PATCH v4 00/11] riscv: Memory Hot(Un)Plug support

2024-06-27 Thread patchwork-bot+linux-riscv
Hello: This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt : On Wed, 5 Jun 2024 13:40:43 +0200 you wrote: > From: Björn Töpel > > > Memory Hot(Un)Plug support (and ZONE_DEVICE) for the RISC-V port > ==

[PATCH v6] remoteproc: xlnx: add attach detach support

2024-06-27 Thread Tanmay Shah
It is possible that remote processor is already running before linux boot or remoteproc platform driver probe. Implement required remoteproc framework ops to provide resource table address and connect or disconnect with remote processor in such case. Signed-off-by: Tanmay Shah --- Changes in v6:

[PATCH v2 0/2] ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

2024-06-27 Thread Raymond Hackley
Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the other Samsung devices based on MSM8226 with only a few minor differences. The device trees contain initial support with: - GPIO keys - Regulator haptic - SDHCI (internal and external storage) - UART (on USB connector via t

[PATCH v2 2/2] ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

2024-06-27 Thread Raymond Hackley
Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the other Samsung devices based on MSM8226 with only a few minor differences. The device trees contain initial support with: - GPIO keys - Regulator haptic - SDHCI (internal and external storage) - UART (on USB connector via t

[PATCH v2 1/2] dt-bindings: arm: qcom: Document samsung,ms013g

2024-06-27 Thread Raymond Hackley
Document samsung,ms013g for Galaxy Grand 2. Signed-off-by: Raymond Hackley --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index ec1c10a12470

[PATCH] remoteproc: mediatek: Don't attempt to remap l1tcm memory if missing

2024-06-27 Thread Nícolas F . R . A . Prado
else { scp_cluster->l1tcm_size = resource_size(res); scp_cluster->l1tcm_phys = res->start; } --- base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed change-id: 20240627-scp-invalid-resource-l1tcm-9f7cf45c17e6 Best regards, -- Nícolas F. R. A. Prado

Re: [PATCH v4] tracing/net_sched: NULL pointer dereference in perf_trace_qdisc_reset()

2024-06-27 Thread Yunseong Kim
Hi Paolo, On 6/27/24 6:14 오후, Paolo Abeni wrote: > On Tue, 2024-06-25 at 02:33 +0900, ysk...@gmail.com wrote: >> From: Yunseong Kim >> >> In the TRACE_EVENT(qdisc_reset) NULL dereference occurred from >> >> qdisc->dev_queue->dev ->name >> >> This situation simulated from bunch of veths and Blue

Re: [PATCH][next] firewire: core: Fix spelling mistakes in tracepoint messages

2024-06-27 Thread Takashi Sakamoto
On Thu, Jun 27, 2024 at 06:08:47PM +0100, Colin Ian King wrote: > There are two spelling mistakes in the tracepoint message text. Fix them. > > Signed-off-by: Colin Ian King > --- > include/trace/events/firewire.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to for-next b

Re: [PATCH v9 8/8] arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC

2024-06-27 Thread kernel test robot
Hi Gokul, kernel test robot noticed the following build warnings: [auto build test WARNING on remoteproc/rproc-next] [also build test WARNING on clk/clk-next robh/for-next linus/master v6.10-rc5 next-20240627] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH] remoteproc: mediatek: Don't attempt to remap l1tcm memory if missing

2024-06-27 Thread Tzung-Bi Shih
On Thu, Jun 27, 2024 at 05:20:55PM -0400, Nícolas F. R. A. Prado wrote: > The current code doesn't check whether platform_get_resource_byname() > succeeded to get the l1tcm memory, which is optional, before attempting > to map it. This results in the following error message when it is > missing: >

Re: [PATCH] LoongArch: uprobes: make UPROBE_SWBP_INSN/UPROBE_XOLBP_INSN constant

2024-06-27 Thread Google
On Thu, 27 Jun 2024 19:38:06 +0200 Oleg Nesterov wrote: > On 06/27, Andrii Nakryiko wrote: > > > > Acked-by: Andrii Nakryiko > > Thanks! > > > > --- a/arch/loongarch/kernel/uprobes.c > > > +++ b/arch/loongarch/kernel/uprobes.c > > > @@ -7,6 +7,14 @@ > > > > > > #define UPROBE_TRAP_NR UINT_MAX

Re: [PATCH net-next v3 1/3] vsock: add support for SIOCOUTQ ioctl for all vsock socket types.

2024-06-27 Thread kernel test robot
Hi Luigi, kernel test robot noticed the following build warnings: [auto build test WARNING on 50b70845fc5c22cf7e7d25b57d57b3dca1725aa5] url: https://github.com/intel-lab-lkp/linux/commits/Luigi-Leonardi-via-B4-Relay/vsock-add-support-for-SIOCOUTQ-ioctl-for-all-vsock-socket-types/20240627