Re: [PATCH V1] vdpa: suspend and resume require DRIVER_OK

2024-02-12 Thread Michael S. Tsirkin
On Fri, Feb 09, 2024 at 02:29:59PM -0800, Steve Sistare wrote: > Calling suspend or resume requires VIRTIO_CONFIG_S_DRIVER_OK, for all > vdpa devices. > > Suggested-by: Eugenio Perez Martin " > Signed-off-by: Steve Sistare I don't think failing suspend or resume makes sense though - e.g. practic

[ANNOUNCE] 4.19.306-rt132

2024-02-12 Thread Daniel Wagner
Hello RT-list! I'm pleased to announce the 4.19.306-rt132 stable release. This is an update to the v4.19.306 stable release. There is a small RT related changed due to the backport of f8f261f9ade2 ("crypto: scompress - Use per-CPU struct instead multiple variables") I had to drop a downstrea

Re: [PATCH v16 2/6] ring-buffer: Introducing ring-buffer mapping functions

2024-02-12 Thread Vincent Donnefort
[...] > > +static void rb_update_meta_page(struct ring_buffer_per_cpu *cpu_buffer) > > +{ > > + struct trace_buffer_meta *meta = cpu_buffer->meta_page; > > + > > + meta->reader.read = cpu_buffer->reader_page->read; > > + meta->reader.id = cpu_buffer->reader_page->id; > > + meta->reader.los

Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-12 Thread Pavel Machek
Hi! > > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > > but I did best I could. > > > > Signed-off-by: Pavel Machek > > > > You miss proper diffstat which makes reviewing difficult. > Actually entire patch is corrupted and impossible to apply. Sorry about that. > Any

Re: [PATCH v3] ARM: dts: qcom: msm8974: correct qfprom node size

2024-02-12 Thread Konrad Dybcio
On 10.02.2024 17:45, Luca Weiss wrote: > From: Craig Tatlor > > The qfprom actually is bigger than 0x1000, so adjust the reg. > > Note that the non-ECC-corrected qfprom can be found at 0xfc4b8000 > (-0x4000). The current reg points to the ECC-corrected qfprom block > which should have equivalent

Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-12 Thread Krzysztof Kozlowski
On 12/02/2024 12:02, Pavel Machek wrote: > Hi! >>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >>> but I did best I could. >>> >>> Signed-off-by: Pavel Machek >>> >> >> You miss proper diffstat which makes reviewing difficult. > >> Actually entire patch is corrupted and i

[GIT PULL] tracing/tools: Fixes for 6.8-rc4

2024-02-12 Thread Daniel Bristot de Oliveira
Steven, Tracing tooling updates for 6.8-rc4 RTLA: - rtla tools are exiting with a positive value when usage() is called. Make them return 0 if the usage was called via -h/--help. - the -P priority sets the sched priority for rtla workload. When the

Re: [PATCH V1] vdpa: suspend and resume require DRIVER_OK

2024-02-12 Thread Steven Sistare
On 2/12/2024 3:19 AM, Michael S. Tsirkin wrote: > On Fri, Feb 09, 2024 at 02:29:59PM -0800, Steve Sistare wrote: >> Calling suspend or resume requires VIRTIO_CONFIG_S_DRIVER_OK, for all >> vdpa devices. >> >> Suggested-by: Eugenio Perez Martin " >> Signed-off-by: Steve Sistare > > I don't think f

Re: [PATCH v2] tracing: Fix wasted memory in saved_cmdlines logic

2024-02-12 Thread Google
On Fri, 9 Feb 2024 06:36:22 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > While looking at improving the saved_cmdlines cache I found a huge amount > of wasted memory that should be used for the cmdlines. > > The tracing data saves pids during the trace. At sched switch, if

Re: [PATCH V1] vdpa: suspend and resume require DRIVER_OK

2024-02-12 Thread Michael S. Tsirkin
On Mon, Feb 12, 2024 at 09:56:31AM -0500, Steven Sistare wrote: > On 2/12/2024 3:19 AM, Michael S. Tsirkin wrote: > > On Fri, Feb 09, 2024 at 02:29:59PM -0800, Steve Sistare wrote: > >> Calling suspend or resume requires VIRTIO_CONFIG_S_DRIVER_OK, for all > >> vdpa devices. > >> > >> Suggested-by:

Re: [PATCH V1] vdpa: suspend and resume require DRIVER_OK

2024-02-12 Thread Steven Sistare
On 2/12/2024 10:56 AM, Michael S. Tsirkin wrote: > On Mon, Feb 12, 2024 at 09:56:31AM -0500, Steven Sistare wrote: >> On 2/12/2024 3:19 AM, Michael S. Tsirkin wrote: >>> On Fri, Feb 09, 2024 at 02:29:59PM -0800, Steve Sistare wrote: Calling suspend or resume requires VIRTIO_CONFIG_S_DRIVER_OK,

[PATCH v2 0/3] remoteproc: qcom_q6v5_pas: Add aDSP and cDSP for X1E80100

2024-02-12 Thread Abel Vesa
Signed-off-by: Abel Vesa --- Changes in v2: - Added Krzysztof's R-b tag to bindings patch - Added Dmitry's R-b tag to the X1E80100 related patch - Dropped the comment about the comment from adsp_load about lite version - Link to v1: https://lore.kernel.org/r/20240129-x1e80100-remoteproc-v1-0-15

[PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the X1E80100 aDSP & cDSP

2024-02-12 Thread Abel Vesa
Document the aDSP and cDSP Peripheral Authentication Service on the X1E80100 Platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Abel Vesa --- Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetr

[PATCH v2 2/3] remoteproc: qcom_q6v5_pas: Add support for X1E80100 ADSP/CDSP

2024-02-12 Thread Abel Vesa
From: Sibi Sankar Add support for PIL loading on ADSP and CDSP on X1E80100 SoCs. Signed-off-by: Sibi Sankar Reviewed-by: Dmitry Baryshkov Signed-off-by: Abel Vesa --- drivers/remoteproc/qcom_q6v5_pas.c | 41 ++ 1 file changed, 41 insertions(+) diff --git

[PATCH v2 3/3] remoteproc: qcom_q6v5_pas: Unload lite firmware on ADSP

2024-02-12 Thread Abel Vesa
From: Sibi Sankar The UEFI loads a lite variant of the ADSP firmware to support charging use cases. The kernel needs to unload and reload it with the firmware that has full feature support for audio. This patch arbitarily shutsdown the lite firmware before loading the full firmware. Signed-off-b

Re: [syzbot] [fs?] [trace?] BUG: unable to handle kernel paging request in tracefs_apply_options

2024-02-12 Thread syzbot
syzbot suspects this issue was fixed by commit: commit ad579864637af46447208254719943179b69d41a Author: Steven Rostedt (Google) Date: Tue Jan 2 20:12:49 2024 + tracefs: Check for dentry->d_inode exists in set_gid() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17659d241

[PATCH V2 0/3] flush workers on suspend

2024-02-12 Thread Steve Sistare
Flush to guarantee no workers are running when suspend returns, for vdpa, vpa_sim, and vduse. (mlx5 already does so, via the path mlx5_vdpa_suspend -> unregister_link_notifier -> flush_workqueue.) Steve Sistare (3): vhost-vdpa: flush workers on suspend vduse: suspend vdpa_sim: flush workers

[PATCH V2 3/3] vdpa_sim: flush workers on suspend

2024-02-12 Thread Steve Sistare
Flush to guarantee no workers are running when suspend returns. Signed-off-by: Steve Sistare --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c index be2925d0d283..a662b90357c

[PATCH V2 1/3] vhost-vdpa: flush workers on suspend

2024-02-12 Thread Steve Sistare
Flush to guarantee no workers are running when suspend returns. Signed-off-by: Steve Sistare --- drivers/vhost/vdpa.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index bc4a51e4638b..a3b986c24805 100644 --- a/drivers/vhost/vdpa.c +++ b/driver

[PATCH V2 2/3] vduse: suspend

2024-02-12 Thread Steve Sistare
Support the suspend operation. There is little to do, except flush to guarantee no workers are running when suspend returns. Signed-off-by: Steve Sistare --- drivers/vdpa/vdpa_user/vduse_dev.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/vdpa/vdpa_user/v

Re: [PATCH v2] tracing: Fix wasted memory in saved_cmdlines logic

2024-02-12 Thread Steven Rostedt
On Tue, 13 Feb 2024 00:40:38 +0900 Masami Hiramatsu (Google) wrote: > > Now, instead of saving only 128 comms by default, by using this wasted > > space at the end of the structure it can save over 8000 comms and even > > saves space by removing the need for allocating the other array. > > Thi

Re: [PATCH v11] bus: mhi: host: Add tracing support

2024-02-12 Thread Steven Rostedt
On Tue, 6 Feb 2024 15:01:10 +0530 Manivannan Sadhasivam wrote: > > Bot will check sparse warnings/errors mostly. But these checkpatch issues > > can be > > fixed easily. If you don't do it now, then someone will send a patch for it > > later. > > > > Hmm, seems like we should ignore these ch

Re: [PATCH v11] bus: mhi: host: Add tracing support

2024-02-12 Thread Steven Rostedt
On Tue, 6 Feb 2024 10:02:05 +0530 Krishna chaitanya chundru wrote: > diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c > index abb561db9ae1..2d38f6005da6 100644 > --- a/drivers/bus/mhi/host/main.c > +++ b/drivers/bus/mhi/host/main.c > @@ -15,6 +15,7 @@ > #include > #incl

Re: [PATCH] tracing: use ring_buffer_record_is_set_on() in tracer_tracing_is_on()

2024-02-12 Thread Steven Rostedt
On Thu, 8 Feb 2024 11:25:50 +0100 Mete Durlu wrote: > I have been only able to reliably reproduce this issue when the system > is under load from stressors. But I am not sure if it can be considered > as *really stressed*. > > system : 8 cpus (4 physical cores) > load : stress-ng --fanotify 1

Re: [PATCH v8 01/15] cgroup/misc: Add per resource callbacks for CSS events

2024-02-12 Thread Jarkko Sakkinen
On Fri Feb 2, 2024 at 6:34 PM EET, Haitao Huang wrote: > On Thu, 01 Feb 2024 17:24:40 -0600, Jarkko Sakkinen > wrote: > > > On Tue Jan 30, 2024 at 4:09 AM EET, Haitao Huang wrote: > >> From: Kristen Carlson Accardi > >> > >> The misc cgroup controller (subsystem) currently does not perform > >>

Re: [PATCH v9 08/15] x86/sgx: Implement EPC reclamation flows for cgroup

2024-02-12 Thread Jarkko Sakkinen
On Mon Feb 5, 2024 at 11:06 PM EET, Haitao Huang wrote: > From: Kristen Carlson Accardi > > Implement the reclamation flow for cgroup, encapsulated in the top-level > function sgx_epc_cgroup_reclaim_pages(). It does a pre-order walk on its > subtree, and make calls to sgx_reclaim_pages() at each n

Re: [PATCH v9 09/15] x86/sgx: Charge mem_cgroup for per-cgroup reclamation

2024-02-12 Thread Jarkko Sakkinen
On Mon Feb 5, 2024 at 11:06 PM EET, Haitao Huang wrote: > Enclave Page Cache(EPC) memory can be swapped out to regular system "Enclave Page Cache (EPC)" ~ > memory, and the consumed memory should be charged to a proper > mem_cgroup. Currently the selection of mem_cgroup to char

Re: [PATCH v9 10/15] x86/sgx: Add EPC reclamation in cgroup try_charge()

2024-02-12 Thread Jarkko Sakkinen
On Mon Feb 5, 2024 at 11:06 PM EET, Haitao Huang wrote: > From: Kristen Carlson Accardi > > When the EPC usage of a cgroup is near its limit, the cgroup needs to > reclaim pages used in the same cgroup to make room for new allocations. > This is analogous to the behavior that the global reclaimer

Re: [PATCH v9 11/15] x86/sgx: Abstract check for global reclaimable pages

2024-02-12 Thread Jarkko Sakkinen
On Mon Feb 5, 2024 at 11:06 PM EET, Haitao Huang wrote: > From: Kristen Carlson Accardi > > To determine if any page available for reclamation at the global level, > only checking for emptiness of the global LRU is not adequate when pages > are tracked in multiple LRUs, one per cgroup. For this pu

Re: [PATCH v9 12/15] x86/sgx: Expose sgx_epc_cgroup_reclaim_pages() for global reclaimer

2024-02-12 Thread Jarkko Sakkinen
On Mon Feb 5, 2024 at 11:06 PM EET, Haitao Huang wrote: > From: Kristen Carlson Accardi > > When cgroup is enabled, all reclaimable pages will be tracked in cgroup > LRUs. The global reclaimer needs to start reclamation from the root > cgroup. Expose the top level cgroup reclamation function so th

Re: [PATCH v2] x86/sgx: fix kernel-doc comment misuse

2024-02-12 Thread Jarkko Sakkinen
On Sun Feb 11, 2024 at 8:24 AM EET, Randy Dunlap wrote: > Don't use "/**" for a non-kernel-doc comment. This prevents a warning > from scripts/kernel-doc: > > main.c:740: warning: expecting prototype for A section metric is concatenated > in a way that @low bits 12(). Prototype was for sgx_calc_se

Re: [PATCH v16 2/6] ring-buffer: Introducing ring-buffer mapping functions

2024-02-12 Thread Steven Rostedt
On Mon, 12 Feb 2024 10:44:26 + Vincent Donnefort wrote: > > > static void > > > rb_reset_cpu(struct ring_buffer_per_cpu *cpu_buffer) > > > { > > > @@ -5204,6 +5227,9 @@ rb_reset_cpu(struct ring_buffer_per_cpu *cpu_buffer) > > > cpu_buffer->lost_events = 0; > > > cpu_buffer->last_overru

Re: [PATCH] tracing: Fix wasted memory in saved_cmdlines logic

2024-02-12 Thread Tim Chen
On Thu, 2024-02-08 at 10:53 -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > While looking at improving the saved_cmdlines cache I found a huge amount > of wasted memory that should be used for the cmdlines. > > The tracing data saves pids during the trace. At sched switch, if

Re: [PATCH] tracing: Fix wasted memory in saved_cmdlines logic

2024-02-12 Thread Steven Rostedt
On Mon, 12 Feb 2024 14:08:29 -0800 Tim Chen wrote: > > Now, instead of saving only 128 comms by default, by using this wasted > > space at the end of the structure it can save over 8000 comms and even > > saves space by removing the need for allocating the other array. > > The change looks goo

Re: [PATCH] tracing: use ring_buffer_record_is_set_on() in tracer_tracing_is_on()

2024-02-12 Thread Mete Durlu
On 2/12/24 19:53, Steven Rostedt wrote: Right, it will definitely force the race window to go away. Can you still trigger this issue with just Sven's patch and not this change? Sven's patch makes the test cases much more resilient. I needed to ramp up the load up to 4 stressors on a 4 core sys

[PATCH] tracing: Have saved_cmdlines arrays all in one allocation

2024-02-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The saved_cmdlines have three arrays for mapping PIDs to COMMs: - map_pid_to_cmdline[] - map_cmdline_to_pid[] - saved_cmdlines The map_pid_to_cmdline[] is PID_MAX_DEFAULT in size and holds the index into the other arrays. The map_cmdline_to_pid[] is a mapping

Re: [PATCH] tracing: use ring_buffer_record_is_set_on() in tracer_tracing_is_on()

2024-02-12 Thread Steven Rostedt
On Mon, 12 Feb 2024 23:54:00 +0100 Mete Durlu wrote: > On 2/12/24 19:53, Steven Rostedt wrote: > > > > Right, it will definitely force the race window to go away. > > > > Can you still trigger this issue with just Sven's patch and not this > > change? > Sven's patch makes the test cases much

Re: [PATCH v9 10/15] x86/sgx: Add EPC reclamation in cgroup try_charge()

2024-02-12 Thread Haitao Huang
Hi Jarkko On Mon, 12 Feb 2024 13:55:46 -0600, Jarkko Sakkinen wrote: On Mon Feb 5, 2024 at 11:06 PM EET, Haitao Huang wrote: From: Kristen Carlson Accardi When the EPC usage of a cgroup is near its limit, the cgroup needs to reclaim pages used in the same cgroup to make room for new allo

Re: [PATCH] tracing: Have saved_cmdlines arrays all in one allocation

2024-02-12 Thread Google
On Mon, 12 Feb 2024 18:09:41 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > The saved_cmdlines have three arrays for mapping PIDs to COMMs: > > - map_pid_to_cmdline[] > - map_cmdline_to_pid[] > - saved_cmdlines > > The map_pid_to_cmdline[] is PID_MAX_DEFAULT in size and

Re: [PATCH] tracing: Have saved_cmdlines arrays all in one allocation

2024-02-12 Thread Tim Chen
On Mon, 2024-02-12 at 18:09 -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > The saved_cmdlines have three arrays for mapping PIDs to COMMs: > > - map_pid_to_cmdline[] > - map_cmdline_to_pid[] > - saved_cmdlines > > The map_pid_to_cmdline[] is PID_MAX_DEFAULT in size and ho

Re: [PATCH] tracing: Fix wasted memory in saved_cmdlines logic

2024-02-12 Thread Tim Chen
On Thu, 2024-02-08 at 10:53 -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > While looking at improving the saved_cmdlines cache I found a huge amount > of wasted memory that should be used for the cmdlines. > > The tracing data saves pids during the trace. At sched switch, if

Re: [PATCH V1] vdpa: suspend and resume require DRIVER_OK

2024-02-12 Thread Michael S. Tsirkin
On Mon, Feb 12, 2024 at 11:37:12AM -0500, Steven Sistare wrote: > On 2/12/2024 10:56 AM, Michael S. Tsirkin wrote: > > On Mon, Feb 12, 2024 at 09:56:31AM -0500, Steven Sistare wrote: > >> On 2/12/2024 3:19 AM, Michael S. Tsirkin wrote: > >>> On Fri, Feb 09, 2024 at 02:29:59PM -0800, Steve Sistare w

Re: [PATCH] tracing: Have saved_cmdlines arrays all in one allocation

2024-02-12 Thread Steven Rostedt
On Mon, 12 Feb 2024 15:39:03 -0800 Tim Chen wrote: > > diff --git a/kernel/trace/trace_sched_switch.c > > b/kernel/trace/trace_sched_switch.c > > index e4fbcc3bede5..210c74dcd016 100644 > > --- a/kernel/trace/trace_sched_switch.c > > +++ b/kernel/trace/trace_sched_switch.c > > @@ -201,7 +201,7 @

Re: [PATCH v9 09/15] x86/sgx: Charge mem_cgroup for per-cgroup reclamation

2024-02-12 Thread Haitao Huang
On Mon, 12 Feb 2024 13:46:06 -0600, Jarkko Sakkinen wrote: On Mon Feb 5, 2024 at 11:06 PM EET, Haitao Huang wrote: Enclave Page Cache(EPC) memory can be swapped out to regular system "Enclave Page Cache (EPC)" ~ Will fix. [...] int sgx_encl_alloc_backing(struct sgx_e

Re: [PATCH V1] vdpa: suspend and resume require DRIVER_OK

2024-02-12 Thread Eugenio Perez Martin
On Mon, Feb 12, 2024 at 9:20 AM Michael S. Tsirkin wrote: > > On Fri, Feb 09, 2024 at 02:29:59PM -0800, Steve Sistare wrote: > > Calling suspend or resume requires VIRTIO_CONFIG_S_DRIVER_OK, for all > > vdpa devices. > > > > Suggested-by: Eugenio Perez Martin " > > Signed-off-by: Steve Sistare >