On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote:
> From: Iuliana Prodan
>
> Add the reserve-memory nodes used by DSP when the rpmsg
> feature is enabled.
> These can be later used in a dsp node, like:
> dsp: dsp@3b6e8000 {
> compatible = "fsl,imx8mp-dsp";
> reg = <0x3b6e8000 0x88000>;
From: Wang Yong
The ltp test prompts the following bug information under the 5.10 kernel:
BUG: sleeping function called from invalid context at
kernel/locking/rtmutex.c:969
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 796, name: cat
Preemption disabled at:
[] do_debug_exception+0x60/0x
Hi Justin,
Thanks for your patch!
On Mon, Sep 11, 2023 at 7:53 PM Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> `gate_buf` should always be NUL-terminated and does not require
> NUL-padding. It is used as a string arg inside an argv array gi
On Mon, Sep 11, 2023 at 11:39:38PM -0400, Nayna wrote:
>
> On 9/7/23 13:32, Michal Suchánek wrote:
> > Adding more CC's from the original patch, looks like get_maintainers is
> > not that great for this file.
> >
> > On Thu, Sep 07, 2023 at 06:52:19PM +0200, Michal Suchanek wrote:
> > > No other
On Tue, Sep 12, 2023 at 12:45:35AM +0300, Jarkko Sakkinen wrote:
> On Thu Sep 7, 2023 at 7:52 PM EEST, Michal Suchanek wrote:
> > No other platform needs CA_MACHINE_KEYRING, either.
> >
> > This is policy that should be decided by the administrator, not Kconfig
>
> s/administrator/distributor/ ?
In the header file arch/csky/abiv2/inc/abi/fpu.h, lines 30-64 refer to
a series of configuration options starting with "OPEN_FPU" for conditional
compilation,
but these configuration options are not defined in any kconfig files,
which means the "#ifdef CONFIG_OPEN_FPU_xxx" condition contains de
On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote:
On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote:
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
These can be later used in a dsp node, like:
dsp: dsp@3b6e8000 {
compatible = "fsl,imx8mp-
On 12/09/2023 10:13, Iuliana Prodan wrote:
> On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote:
>> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote:
>>> From: Iuliana Prodan
>>>
>>> Add the reserve-memory nodes used by DSP when the rpmsg
>>> feature is enabled.
>>> These can be later used in a dsp n
From: Tomas Glozar
nd_region_acquire_lane uses get_cpu, which disables preemption. This is
an issue on PREEMPT_RT kernels, since btt_write_pg and also
nd_region_acquire_lane itself take a spin lock, resulting in BUG:
sleeping function called from invalid context.
Fix the issue by replacing get_c
On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote:
On 12/09/2023 10:13, Iuliana Prodan wrote:
On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote:
On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote:
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
The
On 12/09/2023 10:49, Iuliana Prodan wrote:
>>> Should I test this on other tree(s)?
>> You test the patch on the tree you send it. What is the point to test it
>> on some old code, cherry-pick with bugs and then send?
>>
>> If you have cross-tree dependencies between subsystem, isn't linux-next
>>
On Tue Sep 12, 2023 at 1:32 AM EEST, Justin M. Forbes wrote:
> Commit d2e8071bed0be ("tpm: make all 'class' structures const")
> unfortunately had a typo for the name on tpmrm.
>
> Fixes: d2e8071bed0b ("tpm: make all 'class' structures const")
> Signed-off-by: Justin M. Forbes
> ---
> drivers/cha
On Tue, 2023-08-08 at 16:30 +0800, Kuan-Ying Lee wrote:
> Add lx-symbols command to support add specific
> ko module.
I'm not sure how this was supposed to work? It should have updated the
documentation, but more importantly, it shouldn't have broken the
documented usage of this command:
T
On Tue Sep 12, 2023 at 10:51 AM EEST, Michal Suchánek wrote:
> On Tue, Sep 12, 2023 at 12:45:35AM +0300, Jarkko Sakkinen wrote:
> > On Thu Sep 7, 2023 at 7:52 PM EEST, Michal Suchanek wrote:
> > > No other platform needs CA_MACHINE_KEYRING, either.
> > >
> > > This is policy that should be decided
On Tue Sep 12, 2023 at 10:41 AM EEST, Michal Suchánek wrote:
> On Mon, Sep 11, 2023 at 11:39:38PM -0400, Nayna wrote:
> >
> > On 9/7/23 13:32, Michal Suchánek wrote:
> > > Adding more CC's from the original patch, looks like get_maintainers is
> > > not that great for this file.
> > >
> > > On Th
On Tue, Sep 12, 2023 at 12:46:32PM +0300, Jarkko Sakkinen wrote:
> On Tue Sep 12, 2023 at 10:51 AM EEST, Michal Suchánek wrote:
> > On Tue, Sep 12, 2023 at 12:45:35AM +0300, Jarkko Sakkinen wrote:
> > > On Thu Sep 7, 2023 at 7:52 PM EEST, Michal Suchanek wrote:
> > > > No other platform needs CA_MA
On 9/12/2023 12:36 PM, Krzysztof Kozlowski wrote:
On 12/09/2023 10:49, Iuliana Prodan wrote:
Should I test this on other tree(s)?
You test the patch on the tree you send it. What is the point to test it
on some old code, cherry-pick with bugs and then send?
If you have cross-tree dependencies
On Tue, Sep 12, 2023 at 12:54 PM Iuliana Prodan wrote:
>
> On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote:
> > On 12/09/2023 10:13, Iuliana Prodan wrote:
> >> On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote:
> >>> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote:
> From: Iuliana Prodan
> >
Hi Iuliana,
On 23-09-12, Iuliana Prodan (OSS) wrote:
> From: Iuliana Prodan
>
> Add the reserve-memory nodes used by DSP when the rpmsg
> feature is enabled.
> These can be later used in a dsp node, like:
> dsp: dsp@3b6e8000 {
> compatible = "fsl,imx8mp-dsp";
> reg = <0x3b6e8000 0x88
On 9/12/2023 2:30 PM, Marco Felsch wrote:
Hi Iuliana,
On 23-09-12, Iuliana Prodan (OSS) wrote:
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
These can be later used in a dsp node, like:
dsp: dsp@3b6e8000 {
compatible = "fsl,imx8mp-dsp
On 23-09-12, Iuliana Prodan wrote:
> On 9/12/2023 2:30 PM, Marco Felsch wrote:
> > Hi Iuliana,
> >
> > On 23-09-12, Iuliana Prodan (OSS) wrote:
> > > From: Iuliana Prodan
> > >
> > > Add the reserve-memory nodes used by DSP when the rpmsg
> > > feature is enabled.
> > > These can be later used i
On Tue, 2023-09-12 at 02:00 +, Eric Snowberg wrote:
>
> > On Sep 11, 2023, at 5:08 PM, Mimi Zohar wrote:
> >
> > On Mon, 2023-09-11 at 22:17 +, Eric Snowberg wrote:
> >>
> >>> On Sep 11, 2023, at 10:51 AM, Mickaël Salaün wrote:
> >>>
> >>> On Mon, Sep 11, 2023 at 09:29:07AM -0400, Mim
After the recent cleanups ([1], [2]) some in-tree abusers that directly
accessed the RPM bus clocks, effectively circumventing and working
against the efforts of the interconnect framework, were found.
Patches 1-5 drop deprecated references and the rest attempt to stop
direct bus clock abuses.
De
These clocks are now handled from within the icc framework and are
no longer registered from within the CCF. Remove them.
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 9 -
1 file changed, 9 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi
b/ar
These clocks are now handled from within the icc framework and are
no longer registered from within the CCF. Remove them.
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 27 ---
1 file changed, 4 insertions(+), 23 deletions(-)
diff --git a/arch/a
These clocks are now handled from within the icc framework and are
no longer registered from within the CCF. Remove them.
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 9 -
1 file changed, 9 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi
b/arch
SDM660 was abusingly referencing one of the internal bus clocks, that
were recently dropped from Linux (because the original implementation
did not make much sense), circumventing the interconnect framework.
Drop it.
Signed-off-by: Konrad Dybcio
---
Documentation/devicetree/bindings/usb/qcom,dw
SDM630 was abusingly referencing one of the internal bus clocks, that
were recently dropped from Linux (because the original implementation
did not make much sense), circumventing the interconnect framework.
Fix it by dropping the bus-mm clock (which requires separating 630 from
similar entries) a
The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from
within the interconnect driver. Attaching it to SLPI was a total hack.
Get rid of it.
Signed-off-by: Konrad Dybcio
---
.../devicetree/bindings/remoteproc/qcom,adsp.yaml| 20 ++--
1 file changed, 2 insertions(
These clocks are now handled from within the icc framework and are
no longer registered from within the CCF. Remove them.
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/msm8939.dtsi | 12
1 file changed, 12 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi
These clocks are now handled from within the icc framework and are
no longer registered from within the CCF. Remove them.
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/sdm630.dtsi | 49 +++-
1 file changed, 9 insertions(+), 40 deletions(-)
diff --git
The PNoC clock is a clock for the entire PNoC bus, managed from
within the interconnect driver. Attaching it to MSS was a total hack.
Get rid of it.
Signed-off-by: Konrad Dybcio
---
drivers/remoteproc/qcom_q6v5_mss.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5
The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from
within the interconnect driver. Attaching it to SLPI was a total hack.
Get rid of it.
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
The PNoC clock is a clock for the entire PNoC bus, managed from
within the interconnect driver. Attaching it to MSS was a total hack.
Get rid of it.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Konrad Dybcio
---
Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml | 2 --
1 fi
The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from
within the interconnect driver. Attaching it to SLPI was a total hack.
Get rid of it.
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/msm8998.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
The last 2 clock-names entries for the USB2 controller were swapped,
resulting in schema warnings:
['cfg_noc', 'core', 'mock_utmi', 'sleep'] is too short
'iface' was expected
'sleep' was expected
'mock_utmi' was expected
Fix it and take the liberty to make the clock-names
The PNoC clock is a clock for the entire PNoC bus, managed from
within the interconnect driver. Attaching it to MSS was a total hack.
Get rid of it and take the liberty to make the clock-names entries
more readable.
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 11
Hello Alexander,
Thank you for your mail.
Il giorno lun 11 set 2023 alle ore 16:26 Alexander Lobakin
ha scritto:
>
> From: Alessandro Carminati (Red Hat)
> Date: Mon, 28 Aug 2023 08:04:23 +
>
> > From: Alessandro Carminati
> >
> > It is not uncommon for drivers or modules related to simila
On Tue, Sep 12, 2023 at 01:51:42PM +0300, Iuliana Prodan wrote:
> On 9/12/2023 12:36 PM, Krzysztof Kozlowski wrote:
> > On 12/09/2023 10:49, Iuliana Prodan wrote:
> > > > > Should I test this on other tree(s)?
> > > > You test the patch on the tree you send it. What is the point to test it
> > > >
On Mon, Sep 11, 2023 at 08:19:20AM +, David Laight wrote:
> ...
> > Okay, can you please split the patch so they can be backported
> > separately? Then I'll get them landed, etc.
>
> Since the header with just the extra #endif is badly broken on C++
> isn't it best to ensure they get back-port
From: Iuliana Prodan
These patches are needed in order to support rpmsg on DSP when a
resource table is available.
Changes since v1:
- add missing bracket in dtsi (patch 2/2)
Iuliana Prodan (2):
remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op
arm64: dts: imx8mp: add reser
From: Iuliana Prodan
Add the .find_loaded_rsc_table operation for i.MX DSP.
We need it for inter-process communication between DSP
and main core.
This callback is used to find the resource table (defined
in remote processor linker script) where the address of the
vrings along with the other allo
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
Signed-off-by: Iuliana Prodan
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
b/arch/arm6
On 9/4/23 09:40, Roberto Sassu wrote:
From: Roberto Sassu
Before the security field of kernel objects could be shared among LSMs with
the LSM stacking feature, IMA and EVM had to rely on an alternative storage
of inode metadata. The association between inode metadata and inode is
maintained t
__DECLARE_FLEX_ARRAY(T, member) macro expands to
struct {
struct {} __empty_member;
T member[];
};
which is subtly wrong in C++ because sizeof(struct{}) is 1 not 0,
changing UAPI structures layouts.
This can be fixed by expanding to
T memb
Signed-off-by: Alexey Dobriyan
---
include/uapi/linux/stddef.h |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/include/uapi/linux/stddef.h
+++ b/include/uapi/linux/stddef.h
@@ -50,8 +50,9 @@
TYPE NAME[]; \
}
#endif
-#endif
#ifndef __counted_by
#defi
On Tue, 12 Sep 2023 11:41:29 +0200 Johannes Berg
wrote:
> On Tue, 2023-08-08 at 16:30 +0800, Kuan-Ying Lee wrote:
> > Add lx-symbols command to support add specific
> > ko module.
>
> I'm not sure how this was supposed to work? It should have updated the
> documentation, but more importantly,
Commit d2e8071bed0be ("tpm: make all 'class' structures const")
unfortunately had a typo for the name on tpmrm.
Fixes: d2e8071bed0b ("tpm: make all 'class' structures const")
Signed-off-by: Justin M. Forbes
---
drivers/char/tpm/tpm-chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On Tue Sep 12, 2023 at 6:39 AM EEST, Nayna wrote:
>
> On 9/7/23 13:32, Michal Suchánek wrote:
> > Adding more CC's from the original patch, looks like get_maintainers is
> > not that great for this file.
> >
> > On Thu, Sep 07, 2023 at 06:52:19PM +0200, Michal Suchanek wrote:
> >> No other platform
vmalloc() and vzalloc() functions have now 2-factor multiplication
argument forms vmalloc_array() and vcalloc(), correspondingly.
Add alloc-with-multiplies checks for these new functions.
Link: https://github.com/KSPP/linux/issues/342
Signed-off-by: Gustavo A. R. Silva
---
scripts/checkpatch.pl
On Tue, Sep 12, 2023 at 4:41 AM Jarkko Sakkinen wrote:
>
> On Tue Sep 12, 2023 at 1:32 AM EEST, Justin M. Forbes wrote:
> > Commit d2e8071bed0be ("tpm: make all 'class' structures const")
> > unfortunately had a typo for the name on tpmrm.
> >
> > Fixes: d2e8071bed0b ("tpm: make all 'class' struct
> On Sep 12, 2023, at 5:54 AM, Mimi Zohar wrote:
>
> On Tue, 2023-09-12 at 02:00 +, Eric Snowberg wrote:
>>
>>> On Sep 11, 2023, at 5:08 PM, Mimi Zohar wrote:
>>>
>>> On Mon, 2023-09-11 at 22:17 +, Eric Snowberg wrote:
> On Sep 11, 2023, at 10:51 AM, Mickaël Salaün wrote:
On Tue Sep 12, 2023 at 8:02 PM EEST, Justin M. Forbes wrote:
> Commit d2e8071bed0be ("tpm: make all 'class' structures const")
> unfortunately had a typo for the name on tpmrm.
>
> Fixes: d2e8071bed0b ("tpm: make all 'class' structures const")
> Signed-off-by: Justin M. Forbes
> ---
> drivers/cha
On Tue, 2023-09-12 at 11:04 -0600, Gustavo A. R. Silva wrote:
> vmalloc() and vzalloc() functions have now 2-factor multiplication
> argument forms vmalloc_array() and vcalloc(), correspondingly.
> Add alloc-with-multiplies checks for these new functions.
>
> Link: https://github.com/KSPP/linux/i
Users need to know how to make events persist now that we allow for
that. We also now allow the dynamic_events file to create events by
utilizing the persist flag during event register.
Add back in to documentation how /sys/kernel/tracing/dynamic_events can
be used to create persistent user_events
Now that we have exposed USER_EVENT_REG_PERSIST events can persist both
via the ABI and in the /sys/kernel/tracing/dynamic_events file.
Ensure both the ABI and DYN cases work by calling both during the parse
tests. Add new flags test that ensures only USER_EVENT_REG_PERSIST is
honored and any othe
There are several scenarios that have come up where having a user_event
persist even if the process that registered it exits. The main one is
having a daemon create events on bootup that shouldn't get deleted if
the daemon has to exit or reload. Another is within OpenTelemetry
exporters, they wish
There are several scenarios that have come up where having a user_event
persist even if the process that registered it exits. The main one is
having a daemon create events on bootup that shouldn't get deleted if
the daemon has to exit or reload. Another is within OpenTelemetry
exporters, they wish
DAMON provides damon_aggregated tracepoint, which exposes details of
each region and its access monitoring results. It is useful for
getting whole monitoring results, e.g., for recording purposes.
For investigations of DAMOS, DAMON Sysfs interface provides DAMOS
statistics and tried_regions direc
On Tue, 2023-09-12 at 12:49 +0300, Jarkko Sakkinen wrote:
> On Tue Sep 12, 2023 at 10:41 AM EEST, Michal Suchánek wrote:
> > On Mon, Sep 11, 2023 at 11:39:38PM -0400, Nayna wrote:
> > >
> > > On 9/7/23 13:32, Michal Suchánek wrote:
> > > > Adding more CC's from the original patch, looks like get_m
On Tue Sep 12, 2023 at 10:22 PM EEST, Mimi Zohar wrote:
> On Tue, 2023-09-12 at 12:49 +0300, Jarkko Sakkinen wrote:
> > On Tue Sep 12, 2023 at 10:41 AM EEST, Michal Suchánek wrote:
> > > On Mon, Sep 11, 2023 at 11:39:38PM -0400, Nayna wrote:
> > > >
> > > > On 9/7/23 13:32, Michal Suchánek wrote:
On Tue, 2023-09-12 at 22:32 +0300, Jarkko Sakkinen wrote:
> On Tue Sep 12, 2023 at 10:22 PM EEST, Mimi Zohar wrote:
> > On Tue, 2023-09-12 at 12:49 +0300, Jarkko Sakkinen wrote:
> > > On Tue Sep 12, 2023 at 10:41 AM EEST, Michal Suchánek wrote:
> > > > On Mon, Sep 11, 2023 at 11:39:38PM -0400, Nayn
On Aug 17, 2023 Paul Moore wrote:
>
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_
Merge tag 'for-6.6-rc1-tag' of
git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux (2023-09-12 11:28:00
-0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
tags/tpmdd-v6.6-rc2
for you to fetch changes up to ea72883a3bf1
On Tue, Sep 12, 2023 at 12:36 AM Geert Uytterhoeven
wrote:
>
> Hi Justin,
>
> Thanks for your patch!
>
> On Mon, Sep 11, 2023 at 7:53 PM Justin Stitt wrote:
> > `strncpy` is deprecated for use on NUL-terminated destination strings [1].
> >
> > `gate_buf` should always be NUL-terminated and does n
On Aug 17, 2023 Kees Cook wrote:
>
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_F
On Tue, 2023-09-12 at 17:11 +, Eric Snowberg wrote:
>
> > On Sep 12, 2023, at 5:54 AM, Mimi Zohar wrote:
> >
> > On Tue, 2023-09-12 at 02:00 +, Eric Snowberg wrote:
> >>
> >>> On Sep 11, 2023, at 5:08 PM, Mimi Zohar wrote:
> >>>
> >>> On Mon, 2023-09-11 at 22:17 +, Eric Snowberg w
dex = region_index;
- strncpy(cmd_params->obj_type, obj_type, 16);
- cmd_params->obj_type[15] = '\0';
+ strscpy_pad(cmd_params->obj_type, obj_type, 16);
/* send command to mc*/
err = mc_send_command(mc_io, &cmd);
---
base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
change-id: 20230912-strncpy-drivers-bus-fsl-mc-dprc-c-bc7d818386ec
Best regards,
--
Justin Stitt
dr_info->binfo.type, DEVICE_NAME,
+ strscpy(addr_info->binfo.type, DEVICE_NAME,
sizeof(addr_info->binfo.type));
addr_info->binfo.addr = addr;
addr_info->binfo.platform_data = addr_info;
---
base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
c
e_init(void)
BUG_ON(!cpufreq_global_kobject);
if (!strlen(default_governor))
- strncpy(default_governor, gov->name, CPUFREQ_NAME_LEN);
+ strscpy(default_governor, gov->name, CPUFREQ_NAME_LEN);
return 0;
}
---
base-commit: 2dde18cd1d8fac735875f2e4987
DEVICE_NAME,
> + strscpy(addr_info->binfo.type, DEVICE_NAME,
> sizeof(addr_info->binfo.type));
This one is good.
-corey
> addr_info->binfo.addr = addr;
> addr_info->binfo.platform_data = addr_info;
>
> ---
> base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
> change-id: 20230912-strncpy-drivers-char-ipmi-ipmi-dda47b3773fd
>
> Best regards,
> --
> Justin Stitt
>
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
We should prefer more robust and less ambiguous string interfaces.
A suitable replacement is `strscpy` [2] due to the fact that it guarantees
NUL-termination on the destination buffer. With this, we can also drop
the now u
0644
> > --- a/drivers/char/ipmi/ipmi_ssif.c
> > +++ b/drivers/char/ipmi/ipmi_ssif.c
> > @@ -1940,7 +1940,7 @@ static int new_ssif_client(int addr, char
> > *adapter_name,
> > }
> > }
> >
> > - strncpy(addr_info->binfo.type, DEVICE_NAME,
> > + strscpy(addr_info->binfo.type, DEVICE_NAME,
> > sizeof(addr_info->binfo.type));
>
> This one is good.
>
> -corey
>
> > addr_info->binfo.addr = addr;
> > addr_info->binfo.platform_data = addr_info;
> >
> > ---
> > base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
> > change-id: 20230912-strncpy-drivers-char-ipmi-ipmi-dda47b3773fd
> >
> > Best regards,
> > --
> > Justin Stitt
> >
p += size;
> > >
> > > ipmi_panic_request_and_wait(intf, &addr, &msg);
> > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> > > index 3b921c78ba08..edcb83765dce 100644
> > > --- a/drivers/char/ipmi/
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
We should prefer more robust and less ambiguous string interfaces.
`dax_id->dev_name` is expected to be NUL-terminated and has been zero-allocated.
A suitable replacement is `strscpy` [2] due to the fact that it
guarantee
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
We should prefer more robust and less ambiguous string interfaces.
A suitable replacement is `strscpy_pad` [2] due to the fact that it guarantees
NUL-termination on the destination buffer whilst maintaining the
NUL-padding
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
We should prefer more robust and less ambiguous string interfaces.
A suitable replacement is `strscpy_pad` [2] due to the fact that it guarantees
NUL-termination on the destination buffer whilst maintaining the
NUL-padding
On Tue, Sep 12, 2023 at 6:26 PM Justin Stitt wrote:
>
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> We should prefer more robust and less ambiguous string interfaces.
>
> A suitable replacement is `strscpy_pad` [2] due to the fact that it guarantees
> NUL-termina
DAMON provides damon_aggregated tracepoint, which exposes details of
each region and its access monitoring results. It is useful for
getting whole monitoring results, e.g., for recording purposes.
For investigations of DAMOS, DAMON Sysfs interface provides DAMOS
statistics and tried_regions direc
> On Sep 12, 2023, at 4:47 PM, Mimi Zohar wrote:
>
> On Tue, 2023-09-12 at 17:11 +, Eric Snowberg wrote:
>>
>>> On Sep 12, 2023, at 5:54 AM, Mimi Zohar wrote:
>>>
>>> On Tue, 2023-09-12 at 02:00 +, Eric Snowberg wrote:
> On Sep 11, 2023, at 5:08 PM, Mimi Zohar wrote:
>
From: "Steven Rostedt (Google)"
Add a file in tracefs that shows the "events" allocated entries and the
dentries that are attached to them. This is used to see what dentries have
been dynamically allocated as well as their current ref counts.
~# cat /sys/kernel/tracing/events/sched/sched_switch
The first patch adds a file to tracefs that shows all the event_files
that have been allocated for the dynamic eventfs file system. It also
shows the dentries that were created and their current ref counts. This
is useful for debugging and knowing when a dentry has been created and
freed.
I was su
From: "Steven Rostedt (Google)"
The function that the kprobe_args_char and kprobes_arg_string attaches to
for its test has changed its name once again. Now we need to check for
eventfs_create_dir(), and if it exists, use that, otherwise check for
eventfs_add_dir() and if that exists use that, oth
From: "Steven Rostedt (Google)"
Instead of having a descriptor for every file represented in the eventfs
directory, only have the directory itself represented. Change the API to
send in a list of entries that represent all the files in the directory
(but not other directories). The entry list con
On 9/1/23 3:38 AM, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() complete
SGX EPC memory allocations are separate from normal RAM allocations, and
are managed solely by the SGX subsystem. The existing cgroup memory
controller cannot be used to limit or account for SGX EPC memory, which is
a desirable feature in some environments, e.g., support for pod level
control in a
From: Kristen Carlson Accardi
Consumers of the misc cgroup controller might need to perform separate
actions for Cgroups Subsystem State(CSS) events: cgroup alloc and free.
In addition, writes to the max value may also need separate action. Add
the ability to allow downstream users to setup callb
From: Kristen Carlson Accardi
The SGX driver will need to get access to the root misc_cg object
to do iterative walks and also determine if a charge will be
towards the root cgroup or not.
To manage the SGX EPC memory via the misc controller, the SGX
driver will also need to be able to iterate o
From: Kristen Carlson Accardi
Introduce a data structure to wrap the existing reclaimable list and its
spinlock. Each cgroup later will have one instance of this structure to
track EPC pages allocated for processes associated with the same cgroup.
Just like the global SGX reclaimer (ksgxd), an EP
From: Kristen Carlson Accardi
All EPC pages of enclaves including VA and SECS will be tracked in
sgx_epc_lru_lists structs, one per cgroup. For now just replace the
existing sgx_active_page_list in the reclaimer and its spinlock with a
global sgx_epc_lru_lists struct. VA and SECS pages are still
From: Kristen Carlson Accardi
Replace sgx_mark_page_reclaimable() and sgx_unmark_page_reclaimable()
with sgx_record_epc_page() and sgx_drop_epc_page(). The
sgx_record_epc_page() function adds the epc_page to the "reclaimable"
list in the sgx_epc_lru_lists struct, while sgx_drop_epc_page() removes
From: Kristen Carlson Accardi
Change sgx_reclaim_pages() to use a list rather than an array for
storing the epc_pages which will be reclaimed. This change is needed
to transition to the LRU implementation for EPC cgroup support.
When the EPC cgroup is implemented, the reclaiming process will do
Use the lower 3 bits in the flags field of sgx_epc_page struct to
track EPC states in its life cycle and define an enum for possible
states. More state(s) will be added later.
Signed-off-by: Haitao Huang
---
V4:
- No changes other than required for patch reordering.
V3:
- This is new in V3 to re
In a later patch, when a cgroup has exceeded the max capacity for EPC
pages, it may need to identify and OOM kill a less active enclave to
make room for other enclaves within the same group. Such a victim
enclave would have no active pages other than the unreclaimable Version
Array (VA) and SECS pa
From: Sean Christopherson
Add RECLAIM_IN_PROGRESS state to not rely on list_empty(&epc_page->list)
to determine if an EPC page is selected as a reclaiming candidate.
When a page is being reclaimed from the page pool (sgx_global_lru),
there is an intermediate stage where a page may have been iden
From: Sean Christopherson
Two types of owners of struct sgx_epc_page, 'sgx_encl' for VA pages and
'sgx_encl_page' can be stored in the previously introduced union field.
OOM support for cgroups requires that the owner needs to be identified
when selecting pages from the unreclaimable list. Addre
From: Sean Christopherson
Introduce the OOM path for killing an enclave with a reclaimer that is no
longer able to reclaim enough EPC pages. Find a victim enclave, which
will be an enclave with only "unreclaimable" EPC pages left in the
cgroup LRU lists. Once a victim is identified, mark the encl
From: Sean Christopherson
Adjust and expose the top-level reclaim function as
sgx_reclaim_epc_pages() for use by the upcoming EPC cgroup, which will
initiate reclaim to enforce the max limit.
Make these adjustments to the function signature.
1) To take a parameter that specifies the number of p
Add sgx_can_reclaim() wrapper and encapsulate direct references to the
global LRU list in the reclaimer functions so that they can be called with
an LRU list per EPC cgroup.
Signed-off-by: Sean Christopherson
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Haitao Huang
Cc: Sean Christophe
From: Kristen Carlson Accardi
When an OOM event occurs, all pages associated with an enclave will need
to be freed, including pages that are not currently tracked by the
cgroup LRU lists.
Add a new "unreclaimable" list to the sgx_epc_lru_lists struct and
update the "sgx_record/drop_epc_pages()"
1 - 100 of 105 matches
Mail list logo
