[PATCH 5.10 21/25] netfilter: x_tables: fix compat match/target pad out-of-bound write

2021-04-15 Thread Greg Kroah-Hartman
From: Florian Westphal commit b29c457a6511435960115c0f548c4360d5f4801d upstream. xt_compat_match/target_from_user doesn't check that zeroing the area to start of next rule won't write past end of allocated ruleset blob. Remove this code and zero the entire blob beforehand. Reported-by: syzbot+

[PATCH 5.10 22/25] perf map: Tighten snprintf() string precision to pass gcc check on some 32-bit arches

2021-04-15 Thread Greg Kroah-Hartman
From: Arnaldo Carvalho de Melo commit 77d02bd00cea9f1a87afe58113fa75b983d6c23a upstream. Noticed on a debian:experimental mips and mipsel cross build build environment: perfbuilder@ec265a086e9b:~$ mips-linux-gnu-gcc --version | head -1 mips-linux-gnu-gcc (Debian 10.2.1-3) 10.2.1 20201224

[PATCH 5.10 23/25] net: sfp: relax bitrate-derived mode check

2021-04-15 Thread Greg Kroah-Hartman
From: Russell King commit 7a77233ec6d114322e2c4f71b4e26dbecd9ea8a7 upstream. Do not check the encoding when deriving 1000BASE-X from the bitrate when no other modes are discovered. Some GPON modules (VSOL V2801F and CarlitoxxPro CPGOS03-0490 v2.0) indicate NRZ encoding with a 1200Mbaud bitrate,

[PATCH 5.10 24/25] net: sfp: cope with SFPs that set both LOS normal and LOS inverted

2021-04-15 Thread Greg Kroah-Hartman
From: Russell King commit 624407d2cf14ff58e53bf4b2af9595c4f21d606e upstream. The SFP MSA defines two option bits in byte 65 to indicate how the Rx_LOS signal on SFP pin 8 behaves: bit 2 - Loss of Signal implemented, signal inverted from standard definition in SFP MSA (often called "Sign

[PATCH 5.10 25/25] xen/events: fix setting irq affinity

2021-04-15 Thread Greg Kroah-Hartman
From: Juergen Gross The backport of upstream patch 25da4618af240fbec61 ("xen/events: don't unmask an event channel when an eoi is pending") introduced a regression for stable kernels 5.10 and older: setting IRQ affinity for IRQs related to interdomain events would no longer work, as moving the IR

[PATCH 5.10 03/25] KVM: arm64: Hide system instruction access to Trace registers

2021-04-15 Thread Greg Kroah-Hartman
From: Suzuki K Poulose [ Upstream commit 1d676673d665fd2162e7e466dcfbe5373bfdb73e ] Currently we advertise the ID_AA6DFR0_EL1.TRACEVER for the guest, when the trace register accesses are trapped (CPTR_EL2.TTA == 1). So, the guest will get an undefined instruction, if trusts the ID registers and

[PATCH 5.10 04/25] KVM: arm64: Disable guest access to trace filter controls

2021-04-15 Thread Greg Kroah-Hartman
From: Suzuki K Poulose [ Upstream commit a354a64d91eec3e0f8ef0eed575b480fd75b999c ] Disable guest access to the Trace Filter control registers. We do not advertise the Trace filter feature to the guest (ID_AA64DFR0_EL1: TRACE_FILT is cleared) already, but the guest can still access the TRFCR_EL1

[PATCH 5.10 05/25] drm/imx: imx-ldb: fix out of bounds array access warning

2021-04-15 Thread Greg Kroah-Hartman
From: Arnd Bergmann [ Upstream commit 33ce7f2f95cabb5834cf0906308a5cb6103976da ] When CONFIG_OF is disabled, building with 'make W=1' produces warnings about out of bounds array access: drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': drivers/gpu/drm/imx/imx-ldb.c:186:8

[PATCH 5.10 00/25] 5.10.31-rc1 review

2021-04-15 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.31 release. There are 25 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 17 Apr 2021 14:44:01 +. Anything rec

[PATCH 5.10 09/25] drm/tegra: dc: Dont set PLL clock to 0Hz

2021-04-15 Thread Greg Kroah-Hartman
From: Dmitry Osipenko [ Upstream commit f8fb97c915954fc6de6513cdf277103b5c6df7b3 ] RGB output doesn't allow to change parent clock rate of the display and PCLK rate is set to 0Hz in this case. The tegra_dc_commit_state() shall not set the display clock to 0Hz since this change propagates to the

[PATCH 5.10 07/25] ftrace: Check if pages were allocated before calling free_pages()

2021-04-15 Thread Greg Kroah-Hartman
From: Steven Rostedt (VMware) [ Upstream commit 59300b36f85f254260c81d9dd09195fa49eb0f98 ] It is possible that on error pg->size can be zero when getting its order, which would return a -1 value. It is dangerous to pass in an order of -1 to free_pages(). Check if order is greater than or equal t

[PATCH 5.11 12/23] radix tree test suite: Fix compilation

2021-04-15 Thread Greg Kroah-Hartman
From: Matthew Wilcox (Oracle) [ Upstream commit 7487de534dcbe143e6f41da751dd3ffcf93b00ee ] Commit 4bba4c4bb09a added tools/include/linux/compiler_types.h which includes linux/compiler-gcc.h. Unfortunately, we had our own (empty) compiler_types.h which overrode the one added by that commit, and

[PATCH 5.11 13/23] block: only update parent bi_status when bio fail

2021-04-15 Thread Greg Kroah-Hartman
From: Yufen Yu [ Upstream commit 3edf5346e4f2ce2fa0c94651a90a8dda169565ee ] For multiple split bios, if one of the bio is fail, the whole should return error to application. But we found there is a race between bio_integrity_verify_fn and bio complete, which return io success to application afte

[PATCH 5.10 06/25] gfs2: report "already frozen/thawed" errors

2021-04-15 Thread Greg Kroah-Hartman
From: Bob Peterson [ Upstream commit ff132c5f93c06bd4432bbab5c369e468653bdec4 ] Before this patch, gfs2's freeze function failed to report an error when the target file system was already frozen as it should (and as generic vfs function freeze_super does. Similarly, gfs2's thaw function failed t

[PATCH 5.11 14/23] radix tree test suite: Register the main thread with the RCU library

2021-04-15 Thread Greg Kroah-Hartman
From: Matthew Wilcox (Oracle) [ Upstream commit 1bb4bd266cf39fd2fa711f2d265c558b92df1119 ] Several test runners register individual worker threads with the RCU library, but neglect to register the main thread, which can lead to objects being freed while the main thread is in what appears to be a

[PATCH 5.11 15/23] idr test suite: Take RCU read lock in idr_find_test_1

2021-04-15 Thread Greg Kroah-Hartman
From: Matthew Wilcox (Oracle) [ Upstream commit 703586410da69eb40062e64d413ca33bd735917a ] When run on a single CPU, this test would frequently access already-freed memory. Due to timing, this bug never showed up on multi-CPU tests. Reported-by: Chris von Recklinghausen Signed-off-by: Matthew

[PATCH 5.11 01/23] interconnect: core: fix error return code of icc_link_destroy()

2021-04-15 Thread Greg Kroah-Hartman
From: Jia-Ju Bai [ Upstream commit 715ea61532e731c62392221238906704e63d75b6 ] When krealloc() fails and new is NULL, no error return code of icc_link_destroy() is assigned. To fix this bug, ret is assigned with -ENOMEM hen new is NULL. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Link: h

[PATCH 5.11 11/23] XArray: Fix splitting to non-zero orders

2021-04-15 Thread Greg Kroah-Hartman
From: Matthew Wilcox (Oracle) [ Upstream commit 3012110d71f41410932924e1d188f9eb57f1f824 ] Splitting an order-4 entry into order-2 entries would leave the array containing pointers to 40008000c000 instead of . This is a one-character fix, but enhance the test suite to check t

[PATCH 5.10 08/25] tools/kvm_stat: Add restart delay

2021-04-15 Thread Greg Kroah-Hartman
From: Stefan Raspl [ Upstream commit 75f94ecbd0dfd2ac4e671f165f5ae864b7301422 ] If this service is enabled and the system rebooted, Systemd's initial attempt to start this unit file may fail in case the kvm module is not loaded. Since we did not specify a delay for the retries, Systemd restarts

[PATCH 5.11 18/23] io_uring: dont mark S_ISBLK async work as unbounded

2021-04-15 Thread Greg Kroah-Hartman
From: Jens Axboe [ Upstream commit 4b982bd0f383db9132e892c0c5144117359a6289 ] S_ISBLK is marked as unbounded work for async preparation, because it doesn't match S_ISREG. That is incorrect, as any read/write to a block device is also a bounded operation. Fix it up and ensure that S_ISBLK isn't m

[PATCH 5.11 17/23] null_blk: fix command timeout completion handling

2021-04-15 Thread Greg Kroah-Hartman
From: Damien Le Moal [ Upstream commit de3510e52b0a398261271455562458003b8eea62 ] Memory backed or zoned null block devices may generate actual request timeout errors due to the submission path being blocked on memory allocation or zone locking. Unlike fake timeouts or injected timeouts, the req

[PATCH 5.11 02/23] gfs2: Flag a withdraw if init_threads() fails

2021-04-15 Thread Greg Kroah-Hartman
From: Andrew Price [ Upstream commit 62dd0f98a0e5668424270b47a0c2e973795faba7 ] Interrupting mount with ^C quickly enough can cause the kthread_run() calls in gfs2's init_threads() to fail and the error path leads to a deadlock on the s_umount rwsem. The abridged chain of events is: [mount pa

[PATCH 5.11 20/23] block: dont ignore REQ_NOWAIT for direct IO

2021-04-15 Thread Greg Kroah-Hartman
From: Pavel Begunkov [ Upstream commit f8b78caf21d5bc3fcfc40c18898f9d52ed1451a5 ] If IOCB_NOWAIT is set on submission, then that needs to get propagated to REQ_NOWAIT on the block side. Otherwise we completely lose this information, and any issuer of IOCB_NOWAIT IO will potentially end up blocki

[PATCH 5.11 19/23] riscv,entry: fix misaligned base for excp_vect_table

2021-04-15 Thread Greg Kroah-Hartman
From: Zihao Yu [ Upstream commit ac8d0b901f0033b783156ab2dc1a0e73ec42409b ] In RV64, the size of each entry in excp_vect_table is 8 bytes. If the base of the table is not 8-byte aligned, loading an entry in the table will raise a misaligned exception. Although such exception will be handled by o

[PATCH 5.11 22/23] perf map: Tighten snprintf() string precision to pass gcc check on some 32-bit arches

2021-04-15 Thread Greg Kroah-Hartman
From: Arnaldo Carvalho de Melo commit 77d02bd00cea9f1a87afe58113fa75b983d6c23a upstream. Noticed on a debian:experimental mips and mipsel cross build build environment: perfbuilder@ec265a086e9b:~$ mips-linux-gnu-gcc --version | head -1 mips-linux-gnu-gcc (Debian 10.2.1-3) 10.2.1 20201224

[PATCH 5.11 21/23] netfilter: x_tables: fix compat match/target pad out-of-bound write

2021-04-15 Thread Greg Kroah-Hartman
From: Florian Westphal commit b29c457a6511435960115c0f548c4360d5f4801d upstream. xt_compat_match/target_from_user doesn't check that zeroing the area to start of next rule won't write past end of allocated ruleset blob. Remove this code and zero the entire blob beforehand. Reported-by: syzbot+

[PATCH 5.11 16/23] idr test suite: Create anchor before launching throbber

2021-04-15 Thread Greg Kroah-Hartman
From: Matthew Wilcox (Oracle) [ Upstream commit 094ffbd1d8eaa27ed426feb8530cb1456348b018 ] The throbber could race with creation of the anchor entry and cause the IDR to have zero entries in it, which would cause the test to fail. Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Sasha Lev

[PATCH 5.11 23/23] net: sfp: cope with SFPs that set both LOS normal and LOS inverted

2021-04-15 Thread Greg Kroah-Hartman
From: Russell King commit 624407d2cf14ff58e53bf4b2af9595c4f21d606e upstream. The SFP MSA defines two option bits in byte 65 to indicate how the Rx_LOS signal on SFP pin 8 behaves: bit 2 - Loss of Signal implemented, signal inverted from standard definition in SFP MSA (often called "Sign

[PATCH 5.11 06/23] gfs2: report "already frozen/thawed" errors

2021-04-15 Thread Greg Kroah-Hartman
From: Bob Peterson [ Upstream commit ff132c5f93c06bd4432bbab5c369e468653bdec4 ] Before this patch, gfs2's freeze function failed to report an error when the target file system was already frozen as it should (and as generic vfs function freeze_super does. Similarly, gfs2's thaw function failed t

[PATCH 5.11 05/23] drm/imx: imx-ldb: fix out of bounds array access warning

2021-04-15 Thread Greg Kroah-Hartman
From: Arnd Bergmann [ Upstream commit 33ce7f2f95cabb5834cf0906308a5cb6103976da ] When CONFIG_OF is disabled, building with 'make W=1' produces warnings about out of bounds array access: drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': drivers/gpu/drm/imx/imx-ldb.c:186:8

[PATCH 5.11 08/23] tools/kvm_stat: Add restart delay

2021-04-15 Thread Greg Kroah-Hartman
From: Stefan Raspl [ Upstream commit 75f94ecbd0dfd2ac4e671f165f5ae864b7301422 ] If this service is enabled and the system rebooted, Systemd's initial attempt to start this unit file may fail in case the kvm module is not loaded. Since we did not specify a delay for the retries, Systemd restarts

[PATCH 5.11 04/23] KVM: arm64: Disable guest access to trace filter controls

2021-04-15 Thread Greg Kroah-Hartman
From: Suzuki K Poulose [ Upstream commit a354a64d91eec3e0f8ef0eed575b480fd75b999c ] Disable guest access to the Trace Filter control registers. We do not advertise the Trace filter feature to the guest (ID_AA64DFR0_EL1: TRACE_FILT is cleared) already, but the guest can still access the TRFCR_EL1

[PATCH 5.11 10/23] gpu: host1x: Use different lock classes for each client

2021-04-15 Thread Greg Kroah-Hartman
From: Mikko Perttunen [ Upstream commit a24f98176d1efae2c37d3438c57a624d530d9c33 ] To avoid false lockdep warnings, give each client lock a different lock class, passed from the initialization site by macro. Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding Signed-off-by: Sasha Lev

[Qestion] Is preempt_disable/enable needed in non-preemption code path

2021-04-15 Thread Xu, Yanfei
Hi experts, I am learning rcu mechanism and its codes. When looking at the rcu_blocking_is_gp(), I found there is a pair preemption disable/enable operation in non-preemption code path. And it has been a long time. I can't understand why we need it? Is there some thing I missed? If not, can w

[PATCH 5.11 03/23] KVM: arm64: Hide system instruction access to Trace registers

2021-04-15 Thread Greg Kroah-Hartman
From: Suzuki K Poulose [ Upstream commit 1d676673d665fd2162e7e466dcfbe5373bfdb73e ] Currently we advertise the ID_AA6DFR0_EL1.TRACEVER for the guest, when the trace register accesses are trapped (CPTR_EL2.TTA == 1). So, the guest will get an undefined instruction, if trusts the ID registers and

[PATCH 5.11 00/23] 5.11.15-rc1 review

2021-04-15 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.11.15 release. There are 23 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 17 Apr 2021 14:44:01 +. Anything rec

[PATCH 5.11 09/23] drm/tegra: dc: Dont set PLL clock to 0Hz

2021-04-15 Thread Greg Kroah-Hartman
From: Dmitry Osipenko [ Upstream commit f8fb97c915954fc6de6513cdf277103b5c6df7b3 ] RGB output doesn't allow to change parent clock rate of the display and PCLK rate is set to 0Hz in this case. The tegra_dc_commit_state() shall not set the display clock to 0Hz since this change propagates to the

Re: [PATCH] locking/qrwlock: Fix ordering in queued_write_lock_slowpath

2021-04-15 Thread Will Deacon
On Thu, Apr 15, 2021 at 02:25:52PM +, Ali Saidi wrote: > While this code is executed with the wait_lock held, a reader can > acquire the lock without holding wait_lock. The writer side loops > checking the value with the atomic_cond_read_acquire(), but only truly > acquires the lock when the c

Re: [PATCH] locking/qrwlock: Fix ordering in queued_write_lock_slowpath

2021-04-15 Thread Peter Zijlstra
On Thu, Apr 15, 2021 at 02:25:52PM +, Ali Saidi wrote: > While this code is executed with the wait_lock held, a reader can > acquire the lock without holding wait_lock. The writer side loops > checking the value with the atomic_cond_read_acquire(), but only truly > acquires the lock when the c

Re: [PATCH 1/1] char: hpet: Remove unused local variable 'm' in hpet_interrupt()

2021-04-15 Thread Greg Kroah-Hartman
On Thu, Apr 15, 2021 at 10:24:04PM +0800, Zhen Lei wrote: > Commit 273ef9509b79 ("drivers/char/hpet.c: fix periodic-emulation for > delayed interrupt") removed the reference to local variable 'm', but > forgot to remove the definition and assignment of it. Due to > read_counter() indirectly calls "

Re: [PATCH] PM / EM: Inefficient OPPs detection

2021-04-15 Thread Quentin Perret
On Thursday 15 Apr 2021 at 14:59:54 (+), Quentin Perret wrote: > On Thursday 15 Apr 2021 at 15:34:53 (+0100), Vincent Donnefort wrote: > > On Thu, Apr 15, 2021 at 01:16:35PM +, Quentin Perret wrote: > > > On Thursday 08 Apr 2021 at 18:10:29 (+0100), Vincent Donnefort wrote: > > > > --- a/ke

[PATCH 5.11 07/23] ftrace: Check if pages were allocated before calling free_pages()

2021-04-15 Thread Greg Kroah-Hartman
From: Steven Rostedt (VMware) [ Upstream commit 59300b36f85f254260c81d9dd09195fa49eb0f98 ] It is possible that on error pg->size can be zero when getting its order, which would return a -1 value. It is dangerous to pass in an order of -1 to free_pages(). Check if order is greater than or equal t

Re: [PATCH 00/13] tty.h cleanups

2021-04-15 Thread Greg Kroah-Hartman
On Thu, Apr 15, 2021 at 04:14:33PM +0200, Johan Hovold wrote: > On Thu, Apr 15, 2021 at 10:21:54AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Apr 09, 2021 at 09:32:45AM +0200, Johan Hovold wrote: > > > On Thu, Apr 08, 2021 at 08:01:08PM +0200, Greg Kroah-Hartman wrote: > > > > On Thu, Apr 08, 202

[PATCH 0/2] MCAN: Add support for implementing transceiver as a phy

2021-04-15 Thread Aswath Govindraju
The following series of patches add support for implementing the transceiver as a phy of m_can_platform driver. TCAN1042 has a standby signal that needs to be pulled high for sending/receiving messages[1]. TCAN1043 has a enable signal along with standby signal that needs to be pulled up for sendin

Re: [PATCH] PM / EM: Inefficient OPPs detection

2021-04-15 Thread Quentin Perret
On Thursday 15 Apr 2021 at 15:12:08 (+0100), Vincent Donnefort wrote: > On Thu, Apr 15, 2021 at 01:12:05PM +, Quentin Perret wrote: > > Hi Vincent, > > > > On Thursday 08 Apr 2021 at 18:10:29 (+0100), Vincent Donnefort wrote: > > > Some SoCs, such as the sd855 have OPPs within the same perform

[PATCH 1/2] dt-bindings: net: can: Document transceiver implementation as phy

2021-04-15 Thread Aswath Govindraju
From: Faiz Abbas Some transceivers need a configuration step (for example, pulling the standby or enable lines) for them to start sending messages. The transceiver can be implemented as a phy with the configuration done in the phy driver. The bit rate limitation can the be obtained by the driver

Re: [PATCH v3] PCI: dwc: move dw_pcie_msi_init() to dw_pcie_setup_rc()

2021-04-15 Thread Lorenzo Pieralisi
On Thu, 25 Mar 2021 15:26:04 +0800, Jisheng Zhang wrote: > If the host which makes use of IP's integrated MSI Receiver losts > power during suspend, we need to reinit the RC and MSI Receiver in > resume. But after we move dw_pcie_msi_init() into the core, we have no > API to do so. Usually the dwc

Re: [PATCH] arm64: dts: marvell: armada-37xx: Set linux,pci-domain to zero

2021-04-15 Thread Rob Herring
On Thu, Apr 15, 2021 at 3:45 AM Marek Behun wrote: > > On Thu, 15 Apr 2021 10:36:40 +0200 > Pali Rohár wrote: > > > On Tuesday 13 April 2021 13:17:29 Rob Herring wrote: > > > On Mon, Apr 12, 2021 at 7:41 AM Pali Rohár wrote: > > > > > > > > Since commit 526a76991b7b ("PCI: aardvark: Implement dr

[PATCH 2/2] can: m_can: Add support for transceiver as phy

2021-04-15 Thread Aswath Govindraju
From: Faiz Abbas Add support for implementing transceiver node as phy. The max_bitrate is obtained by getting a phy attribute. Signed-off-by: Faiz Abbas Signed-off-by: Aswath Govindraju --- drivers/net/can/m_can/m_can.c | 10 ++ drivers/net/can/m_can/m_can.h | 2 ++

Re: [PATCH 5.10 12/25] radix tree test suite: Fix compilation

2021-04-15 Thread Matthew Wilcox
On Thu, Apr 15, 2021 at 04:48:06PM +0200, Greg Kroah-Hartman wrote: > From: Matthew Wilcox (Oracle) > > [ Upstream commit 7487de534dcbe143e6f41da751dd3ffcf93b00ee ] > > Commit 4bba4c4bb09a added tools/include/linux/compiler_types.h which > includes linux/compiler-gcc.h. Unfortunately, we had ou

Re: [PATCH v10 03/33] counter: 104-quad-8: Remove pointless comment

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:22PM +0900, William Breathitt Gray wrote: > It is obvious that devm_counter_register() is used to register a Counter > device, so a comment stating such is pointless here. > > Cc: Syed Nayyar Waris > Signed-off-by: William Breathitt Gray > --- > drivers/counter/104

Re: [PATCH] locking/qrwlock: Fix ordering in queued_write_lock_slowpath

2021-04-15 Thread Waiman Long
On 4/15/21 10:25 AM, Ali Saidi wrote: While this code is executed with the wait_lock held, a reader can acquire the lock without holding wait_lock. The writer side loops checking the value with the atomic_cond_read_acquire(), but only truly acquires the lock when the compare-and-exchange is comp

Re: [PATCH v10 04/33] counter: 104-quad-8: Return error when invalid mode during ceiling_write

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:23PM +0900, William Breathitt Gray wrote: > The 104-QUAD-8 only has two count modes where a ceiling value makes > sense: Range Limit and Modulo-N. Outside of these two modes, setting a > ceiling value is an invalid operation -- so let's report it as such by > returning

Re: [PATCH 0/2] MCAN: Add support for implementing transceiver as a phy

2021-04-15 Thread Aswath Govindraju
Hi all, On 15/04/21 8:36 pm, Aswath Govindraju wrote: > The following series of patches add support for implementing the > transceiver as a phy of m_can_platform driver. > > TCAN1042 has a standby signal that needs to be pulled high for > sending/receiving messages[1]. TCAN1043 has a enable signa

Re: [PATCH] PM / EM: Inefficient OPPs detection

2021-04-15 Thread Vincent Donnefort
On Thu, Apr 15, 2021 at 02:59:54PM +, Quentin Perret wrote: > On Thursday 15 Apr 2021 at 15:34:53 (+0100), Vincent Donnefort wrote: > > On Thu, Apr 15, 2021 at 01:16:35PM +, Quentin Perret wrote: > > > On Thursday 08 Apr 2021 at 18:10:29 (+0100), Vincent Donnefort wrote: > > > > --- a/kerne

Re: [PATCH v3 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU

2021-04-15 Thread kernel test robot
Hi Qi, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc7] [cannot apply to next-20210415] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH] PCI: dwc: remove unused function

2021-04-15 Thread Lorenzo Pieralisi
On Thu, 15 Apr 2021 16:32:57 +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused > function 'pcie_app_rd' [-Wunused-function]. Applied to pci/dwc, thanks! [1/1] PCI: dwc/intel-gw: Remove unused function https:

Re: [PATCH v10 05/33] counter: 104-quad-8: Annotate hardware config module parameter

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:24PM +0900, William Breathitt Gray wrote: > When the kernel is running in secure boot mode, we lock down the kernel to > prevent userspace from modifying the running kernel image. Whilst this > includes prohibiting access to things like /dev/mem, it must also prevent

Re: [PATCH v10 06/33] counter: 104-quad-8: Add const qualifiers for quad8_preset_register_set

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:25PM +0900, William Breathitt Gray wrote: > Add some safety by qualifying the quad8_preset_register_set() function > parameters as const. > > Cc: Syed Nayyar Waris > Signed-off-by: William Breathitt Gray > --- > drivers/counter/104-quad-8.c | 4 ++-- > 1 file chang

Re: [PATCH v10 07/33] counter: 104-quad-8: Add const qualifier for functions_list array

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:26PM +0900, William Breathitt Gray wrote: > The struct counter_count functions_list member expects a const enum > counter_count_function array. This patch adds the const qualifier to the > quad8_count_functions_list to match functions_list. > > Cc: Syed Nayyar Waris

Re: [PATCH v10 12/33] counter: 104-quad-8: Add const qualifier for actions_list array

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:31PM +0900, William Breathitt Gray wrote: > The struct counter_synapse actions_list member expects a const enum > counter_synapse_action array. This patch adds the const qualifier to the > quad8_index_actions_list and quad8_synapse_actions_list to match > actions_list.

Re: [PATCH] hwmon: pmbus: pxe1610: don't bail out when not all pages are active

2021-04-15 Thread Guenter Roeck
On 4/15/21 6:34 AM, Paul Fertser wrote: > Certain VRs might be configured to use only the first output channel and > so the mode for the second will be 0. Handle this gracefully. > > Fixes: b9fa0a3acfd8 ("hwmon: (pmbus/core) Add support for vid mode detection > per page bases") > Signed-off-by: P

Re: [PATCH v10 18/33] counter: Return error code on invalid modes

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:37PM +0900, William Breathitt Gray wrote: > Only a select set of modes (function, action, etc.) are valid for a > given device configuration. This patch ensures that invalid modes result > in a return -EINVAL. Such a situation should never occur in reality, but > it's

Re: [PATCH v10 19/33] counter: Standardize to ERANGE for limit exceeded errors

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:38PM +0900, William Breathitt Gray wrote: > ERANGE is a semantically better error code to return when an argument > value falls outside the supported limit range of a device. > > Cc: Syed Nayyar Waris > Cc: Oleksij Rempel > Cc: Fabrice Gasnier > Cc: Maxime Coquelin

Re: [PATCH] PM / EM: Inefficient OPPs detection

2021-04-15 Thread Quentin Perret
On Thursday 15 Apr 2021 at 16:14:46 (+0100), Vincent Donnefort wrote: > On Thu, Apr 15, 2021 at 02:59:54PM +, Quentin Perret wrote: > > On Thursday 15 Apr 2021 at 15:34:53 (+0100), Vincent Donnefort wrote: > > > On Thu, Apr 15, 2021 at 01:16:35PM +, Quentin Perret wrote: > > > > On Thursday

Re: [PATCH v10 20/33] counter: Rename counter_signal_value to counter_signal_level

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:39PM +0900, William Breathitt Gray wrote: > Signal values will always be levels so let's be explicit it about it to > make the intent of the code clear. > > Cc: Syed Nayyar Waris > Cc: Oleksij Rempel > Cc: Kamel Bouhara > Reviewed-by: David Lechner > Signed-off-by

Re: [PATCH v10 21/33] counter: Rename counter_count_function to counter_function

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:40PM +0900, William Breathitt Gray wrote: > The phrase "Counter Count function" is verbose and unintentionally > implies that function is a Count extension. This patch adjusts the > Counter subsystem code to use the more direct "Counter function" phrase > to make the i

Re: [RFC PATCH 3/5] tracing/hwlat: Implement the per-cpu mode

2021-04-15 Thread Steven Rostedt
On Thu, 15 Apr 2021 15:22:52 +0200 Daniel Bristot de Oliveira wrote: > >> --- a/kernel/trace/trace_hwlat.c > >> +++ b/kernel/trace/trace_hwlat.c > >> @@ -34,7 +34,7 @@ > >> * Copyright (C) 2008-2009 Jon Masters, Red Hat, Inc. > >> * Copyright (C) 2013-2016 Steven Rostedt, Red Hat, Inc. > >>

Re: [PATCH v4 4/6] perf arm-spe: Assign kernel time to synthesized event

2021-04-15 Thread Leo Yan
On Thu, Apr 15, 2021 at 05:46:31PM +0300, James Clark wrote: > > > On 12/04/2021 12:10, Leo Yan wrote: > > In current code, it assigns the arch timer counter to the synthesized > > samples Arm SPE trace, thus the samples don't contain the kernel time > > but only contain the raw counter value. >

[PATCH v2] cifs: remove unnecessary copies of tcon->crfid.fid

2021-04-15 Thread Muhammad Usama Anjum
pfid is being set to tcon->crfid.fid and they are copied in each other multiple times. Remove the memcopy between same pointers - memory locations. Addresses-Coverity: ("Overlapped copy") Fixes: 9e81e8ff74b9 ("cifs: return cached_fid from open_shroot") Signed-off-by: Muhammad Usama Anjum --- Chan

Re: [PATCH v10 32/33] counter: 104-quad-8: Replace mutex with spinlock

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:51PM +0900, William Breathitt Gray wrote: > This patch replaces the mutex I/O lock with a spinlock. This is in > preparation for a subsequent patch adding IRQ support for 104-QUAD-8 > devices; we can't sleep in an interrupt context, so we'll need to use a > spinlock in

Re: [PATCH v2 4/7] dt-bindings: soc: mediatek: apusys: Add new document for APU power domain

2021-04-15 Thread Rob Herring
On Thu, Apr 15, 2021 at 01:52:37PM +0800, Flora Fu wrote: > Document the bindings for APU power domain on MediaTek SoC. > > Signed-off-by: Flora Fu > --- > Note: > This patch depends on MT8192 clock[1] patches which haven't yet been accepted. > [1] > https://patchwork.kernel.org/project/linux-me

Re: [PATCH v10 33/33] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8

2021-04-15 Thread Syed Nayyar Waris
On Fri, Mar 19, 2021 at 08:00:52PM +0900, William Breathitt Gray wrote: > The LSI/CSI LS7266R1 chip provides programmable output via the FLG pins. > When interrupts are enabled on the ACCES 104-QUAD-8, they occur whenever > FLG1 is active. Four functions are available for the FLG1 signal: Carry, >

Re: [PATCH] PM / EM: Inefficient OPPs detection

2021-04-15 Thread Vincent Donnefort
On Thu, Apr 15, 2021 at 03:04:34PM +, Quentin Perret wrote: > On Thursday 15 Apr 2021 at 15:12:08 (+0100), Vincent Donnefort wrote: > > On Thu, Apr 15, 2021 at 01:12:05PM +, Quentin Perret wrote: > > > Hi Vincent, > > > > > > On Thursday 08 Apr 2021 at 18:10:29 (+0100), Vincent Donnefort w

Re: [PATCH] locking/qrwlock: Fix ordering in queued_write_lock_slowpath

2021-04-15 Thread Will Deacon
On Thu, Apr 15, 2021 at 05:03:58PM +0200, Peter Zijlstra wrote: > On Thu, Apr 15, 2021 at 02:25:52PM +, Ali Saidi wrote: > > While this code is executed with the wait_lock held, a reader can > > acquire the lock without holding wait_lock. The writer side loops > > checking the value with the a

[PATCH] drm/tegra: Fix shift overflow in tegra_shared_plane_atomic_update

2021-04-15 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/tegra/hub.c:513:11: warning: shift count >= width of type [-Wshift-count-overflow] base |= BIT(39); ^~~ BIT is unsigned long, which is 32-bit on ARCH=arm, hence the overflow warning. Switch to BIT_ULL, which is 64-bit and wi

Re: [PATCH 11/11] mm/page_alloc: Embed per_cpu_pages locking within the per-cpu structure

2021-04-15 Thread Mel Gorman
On Thu, Apr 15, 2021 at 04:53:46PM +0200, Vlastimil Babka wrote: > On 4/14/21 3:39 PM, Mel Gorman wrote: > > struct per_cpu_pages is protected by the pagesets lock but it can be > > embedded within struct per_cpu_pages at a minor cost. This is possible > > because per-cpu lookups are based on offse

Re: [PATCH 3/3] sched: Use cpu_dying() to fix balance_push vs hotplug-rollback

2021-04-15 Thread Peter Zijlstra
On Thu, Apr 15, 2021 at 03:32:11PM +0100, Valentin Schneider wrote: > > So instead, make sure balance_push is enabled between > > sched_cpu_deactivate() and sched_cpu_activate() (eg. when > > !cpu_active()), and gate it's utility with cpu_dying(). > > I'd word that "is enabled below sched_cpu_acti

Re: [PATCH] PM / EM: Inefficient OPPs detection

2021-04-15 Thread Lukasz Luba
Hi Quentin, On 4/15/21 4:20 PM, Quentin Perret wrote: On Thursday 15 Apr 2021 at 16:14:46 (+0100), Vincent Donnefort wrote: On Thu, Apr 15, 2021 at 02:59:54PM +, Quentin Perret wrote: On Thursday 15 Apr 2021 at 15:34:53 (+0100), Vincent Donnefort wrote: On Thu, Apr 15, 2021 at 01:16:35PM

Re: [PATCH RFC 01/22] asm-generic/hyperv: add HV_STATUS_ACCESS_DENIED definition

2021-04-15 Thread Vitaly Kuznetsov
Wei Liu writes: > On Tue, Apr 13, 2021 at 02:26:09PM +0200, Vitaly Kuznetsov wrote: >> From TLFSv6.0b, this status means: "The caller did not possess sufficient >> access rights to perform the requested operation." >> >> Signed-off-by: Vitaly Kuznetsov > > This can be applied to hyperv-next rig

Re: [PATCH 3/3] sched: Use cpu_dying() to fix balance_push vs hotplug-rollback

2021-04-15 Thread Valentin Schneider
On 15/04/21 17:29, Peter Zijlstra wrote: > On Thu, Apr 15, 2021 at 03:32:11PM +0100, Valentin Schneider wrote: >> I'd word that "is enabled below sched_cpu_activate()", since >> sched_cpu_deactivate() is now out of the picture. > > I are confused (again!). Did you mean to say something like: 'is en

Re: [PATCH 02/10] mm/numa: automatically generate node migration order

2021-04-15 Thread Dave Hansen
On 4/14/21 9:07 PM, Wei Xu wrote: > On Wed, Apr 14, 2021 at 1:08 AM Oscar Salvador wrote: >> Fast class/memory are pictured as those nodes with CPUs, while Slow >> class/memory >> are PMEM, right? >> Then, what stands for medium class/memory? > > That is Dave's example. I think David's guess ma

Re: [PATCH] block: remove unused function

2021-04-15 Thread Bart Van Assche
On 4/15/21 1:39 AM, Jiapeng Chong wrote: > Fix the following clang warning: > > block/blk-zoned.c:55:24: warning: unused function 'blk_zone_start' > [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > block/blk-zoned.c | 8 > 1 file changed, 8 dele

Re: [PATCH] locking/qrwlock: Fix ordering in queued_write_lock_slowpath

2021-04-15 Thread Catalin Marinas
On Thu, Apr 15, 2021 at 04:28:21PM +0100, Will Deacon wrote: > On Thu, Apr 15, 2021 at 05:03:58PM +0200, Peter Zijlstra wrote: > > On Thu, Apr 15, 2021 at 02:25:52PM +, Ali Saidi wrote: > > > While this code is executed with the wait_lock held, a reader can > > > acquire the lock without holdin

[PATCH v3] hrtimer: avoid retrigger_next_event IPI

2021-04-15 Thread Marcelo Tosatti
Setting the realtime clock triggers an IPI to all CPUs to reprogram the clock event device. However, only realtime and TAI clocks have their offsets updated (and therefore potentially require a reprogram). Instead of sending an IPI unconditionally, check each per CPU hrtimer base whether it has

Re: [PATCH bpf-next 1/2] bpf: Remove bpf_jit_enable=2 debugging mode

2021-04-15 Thread Quentin Monnet
2021-04-15 16:37 UTC+0200 ~ Daniel Borkmann > On 4/15/21 11:32 AM, Jianlin Lv wrote: >> For debugging JITs, dumping the JITed image to kernel log is discouraged, >> "bpftool prog dump jited" is much better way to examine JITed dumps. >> This patch get rid of the code related to bpf_jit_enable=2 mo

Re: [PATCH] PM / EM: Inefficient OPPs detection

2021-04-15 Thread Quentin Perret
On Thursday 15 Apr 2021 at 16:32:31 (+0100), Lukasz Luba wrote: > Are you sure that the 'policy' can be accessed from compute_energy()? > It can be from schedutil freq switch path, but I'm not use about our > feec().. Right, I was just looking at cpufreq_cpu_get() and we'll have locking issue in t

Re: [Qestion] Is preempt_disable/enable needed in non-preemption code path

2021-04-15 Thread Paul E. McKenney
On Thu, Apr 15, 2021 at 11:04:05PM +0800, Xu, Yanfei wrote: > Hi experts, > > I am learning rcu mechanism and its codes. When looking at the > rcu_blocking_is_gp(), I found there is a pair preemption disable/enable > operation in non-preemption code path. And it has been a long time. I can't > und

Re: [PATCH v2 2/2] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE

2021-04-15 Thread kernel test robot
Hi Niklas, I love your patch! Yet something to improve: [auto build test ERROR on soc/for-next] [also build test ERROR on sparc/master asm-generic/master sparc-next/master v5.12-rc7 next-20210415] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[PATCH v2 1/2] dt-bindings: net: can: Document transceiver implementation as phy

2021-04-15 Thread Aswath Govindraju
From: Faiz Abbas Some transceivers need a configuration step (for example, pulling the standby or enable lines) for them to start sending messages. The transceiver can be implemented as a phy with the configuration done in the phy driver. The bit rate limitation can the be obtained by the driver

[PATCH v2 0/2] MCAN: Add support for implementing transceiver as a phy

2021-04-15 Thread Aswath Govindraju
The following series of patches add support for implementing the transceiver as a phy of m_can_platform driver. TCAN1042 has a standby signal that needs to be pulled high for sending/receiving messages[1]. TCAN1043 has a enable signal along with standby signal that needs to be pulled up for sendin

[PATCH v2 2/2] can: m_can: Add support for transceiver as phy

2021-04-15 Thread Aswath Govindraju
From: Faiz Abbas Add support for implementing transceiver node as phy. The max_bitrate is obtained by getting a phy attribute. Signed-off-by: Faiz Abbas Signed-off-by: Aswath Govindraju --- drivers/net/can/m_can/m_can.c | 10 ++ drivers/net/can/m_can/m_can.h | 2 ++

[PROBLEM] a data race between tcp_set_default_congestion_control() and tcp_set_congestion_control()

2021-04-15 Thread Gong, Sishuai
Hi, We found a data race between tcp_set_default_congestion_control() and tcp_set_congestion_control() in linux-5.12-rc3. In general, when tcp_set_congestion_control() is reading ca->flags with a lock grabbed, tcp_set_default_congestion_control() may be updating ca->flags at the same time, as

Re: [PATCH v3 0/5] mm/memcg: Reduce kmemcache memory accounting overhead

2021-04-15 Thread Masayoshi Mizuma
On Thu, Apr 15, 2021 at 09:17:37AM -0400, Waiman Long wrote: > I was focusing on your kernel module benchmark in testing my patch. I will > try out your pgbench benchmark to see if there can be other tuning that can > be done. Thanks a lot! > BTW, how many numa nodes does your test machine? I did

Re: [PATCH 0/2] MCAN: Add support for implementing transceiver as a phy

2021-04-15 Thread Aswath Govindraju
Hi all, On 15/04/21 8:36 pm, Aswath Govindraju wrote: > The following series of patches add support for implementing the > transceiver as a phy of m_can_platform driver. > > TCAN1042 has a standby signal that needs to be pulled high for > sending/receiving messages[1]. TCAN1043 has a enable signa

Re: [PATCH] drm/tegra: Fix shift overflow in tegra_shared_plane_atomic_update

2021-04-15 Thread Thierry Reding
On Thu, Apr 15, 2021 at 08:29:14AM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/tegra/hub.c:513:11: warning: shift count >= width of > type [-Wshift-count-overflow] > base |= BIT(39); > ^~~ > > BIT is unsigned long, which is 32-bit

Re: [PATCH] locking/qrwlock: Fix ordering in queued_write_lock_slowpath

2021-04-15 Thread Will Deacon
On Thu, Apr 15, 2021 at 04:37:58PM +0100, Catalin Marinas wrote: > On Thu, Apr 15, 2021 at 04:28:21PM +0100, Will Deacon wrote: > > On Thu, Apr 15, 2021 at 05:03:58PM +0200, Peter Zijlstra wrote: > > > diff --git a/kernel/locking/qrwlock.c b/kernel/locking/qrwlock.c > > > index 4786dd271b45..22aecc

Re: [PATCH] arm64: alternatives: Move length validation in alternative_{insn,endif}

2021-04-15 Thread Sami Tolvanen
On Thu, Apr 15, 2021 at 7:02 AM Catalin Marinas wrote: > > On Thu, Apr 15, 2021 at 06:25:57AM -0700, Nathan Chancellor wrote: > > On Thu, Apr 15, 2021 at 10:17:43AM +0100, Catalin Marinas wrote: > > > On Tue, Apr 13, 2021 at 05:08:04PM -0700, Nathan Chancellor wrote: > > > > After commit 2decad92f

Re: [PATCH v2] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-15 Thread Ville Syrjälä
On Wed, Apr 14, 2021 at 02:06:43PM +0800, Jisheng Zhang wrote: > I met below error during boot with i915 builtin if pass > "i915.mitigations=off": > [0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' > > The reason is slab subsystem isn't ready at that time, so kstrdup()

[PATCH v13 00/12] Add AMD SEV guest live migration support

2021-04-15 Thread Ashish Kalra
From: Ashish Kalra The series add support for AMD SEV guest live migration commands. To protect the confidentiality of an SEV protected guest memory while in transit we need to use the SEV commands defined in SEV API spec [1]. SEV guest VMs have the concept of private and shared memory. Private

<    3   4   5   6   7   8   9   10   11   12   >