Re: [PATCH v7 4/7] mm,hugetlb: Split prep_new_huge_page functionality

2021-04-13 Thread Michal Hocko
On Tue 13-04-21 15:24:32, Michal Hocko wrote: > On Tue 13-04-21 12:47:44, Oscar Salvador wrote: > [...] > > +static void prep_new_huge_page(struct hstate *h, struct page *page, int > > nid) > > +{ > > + __prep_new_huge_page(page); > > spin_lock_irq(&hugetlb_lock); > > - h->nr_huge_pages++;

Re: [PATCH v7 4/7] mm,hugetlb: Split prep_new_huge_page functionality

2021-04-13 Thread Michal Hocko
On Tue 13-04-21 12:47:44, Oscar Salvador wrote: [...] > +static void prep_new_huge_page(struct hstate *h, struct page *page, int nid) > +{ > + __prep_new_huge_page(page); > spin_lock_irq(&hugetlb_lock); > - h->nr_huge_pages++; > - h->nr_huge_pages_node[nid]++; > + __prep_accou

Re: [PATCH 01/11] mm/page_alloc: Split per cpu page lists and zone stats

2021-04-13 Thread Mel Gorman
On Mon, Apr 12, 2021 at 07:43:18PM +0200, Vlastimil Babka wrote: > On 4/7/21 10:24 PM, Mel Gorman wrote: > > @@ -6691,7 +6697,7 @@ static __meminit void zone_pcp_init(struct zone *zone) > > * relies on the ability of the linker to provide the > > * offset of a (static) per cpu variable in

Re: [PATCH 1/1] arm: topology: parse the topology from the dt

2021-04-13 Thread Ruifeng Zhang
Thanks for your review. Patch-v2 that solve the capacity issue will be uploaded as soon as possible. : ) Valentin Schneider 于2021年4月13日周二 下午7:40写道: > > On 13/04/21 14:13, Ruifeng Zhang wrote: > > Valentin Schneider 于2021年4月12日周一 下午11:33写道: > >> I'm not fluent at all in armv7 (or most aarch32 com

Re: Linux 5.12-rc7

2021-04-13 Thread Eric Dumazet
On Tue, Apr 13, 2021 at 2:57 PM Michael S. Tsirkin wrote: > > On Mon, Apr 12, 2021 at 06:47:07PM +0200, Eric Dumazet wrote: > > On Mon, Apr 12, 2021 at 6:31 PM Eric Dumazet wrote: > > > > > > On Mon, Apr 12, 2021 at 6:28 PM Linus Torvalds > > > wrote: > > > > > > > > On Sun, Apr 11, 2021 at 10:1

Re: Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-13 Thread Andrew Lunn
On Tue, Apr 13, 2021 at 08:56:30AM +0200, Christian Herber wrote: > Hi Andrew, > > On 4/12/2021 6:52 PM, Andrew Lunn wrote: > > > > So what you are say is, you don't care if the IP is completely > > different, it all goes in one driver. So lets put this driver into > > nxp-tja11xx.c. And then we

Re: [PATCH 4/7] mm: memcontrol: simplify lruvec_holds_page_lru_lock

2021-04-13 Thread Shakeel Butt
On Mon, Apr 12, 2021 at 11:57 PM Muchun Song wrote: > > We already have a helper lruvec_memcg() to get the memcg from lruvec, we > do not need to do it ourselves in the lruvec_holds_page_lru_lock(). So use > lruvec_memcg() instead. And if mem_cgroup_disabled() returns false, the > page_memcg(page)

Re: [PATCH 2/8] MIPS: pci-rt2880: remove unneeded locks

2021-04-13 Thread Sergey Ryazanov
Hello Ilya, On Tue, Apr 13, 2021 at 9:22 AM Ilya Lipnitskiy wrote: > Mirror pci-rt3883 fix from commit e5067c718b3a ("MIPS: pci-rt3883: > Remove odd locking in PCI config space access code"). pci-rt2880 shares > the driver layout with pci-rt3883 and the same reasons apply. > > Caller (generic PCI

Re: [PATCH v3 1/4] i2c: mpc: use device managed APIs

2021-04-13 Thread Andy Shevchenko
On Tue, Apr 13, 2021 at 4:31 PM Andy Shevchenko wrote: > > On Tue, Apr 13, 2021 at 3:21 PM Wolfram Sang wrote: > > > > > > > Yongjun[1] into the original patch. If Wei's patch is applied on top > > > of whats already in i2c/for-next then this patch can be ignored. > > > > I applied We

Re: [PATCH v3 1/4] i2c: mpc: use device managed APIs

2021-04-13 Thread Andy Shevchenko
On Tue, Apr 13, 2021 at 3:21 PM Wolfram Sang wrote: > > > > Yongjun[1] into the original patch. If Wei's patch is applied on top > > of whats already in i2c/for-next then this patch can be ignored. > > I applied Wei's patch instead. It was easier. Where is it? i2c/for-next shows the v

Re: Linux 5.12-rc7

2021-04-13 Thread Eric Dumazet
On Tue, Apr 13, 2021 at 3:27 PM Eric Dumazet wrote: > > On Tue, Apr 13, 2021 at 2:57 PM Michael S. Tsirkin wrote: > > > > On Mon, Apr 12, 2021 at 06:47:07PM +0200, Eric Dumazet wrote: > > > On Mon, Apr 12, 2021 at 6:31 PM Eric Dumazet wrote: > > > > > > > > On Mon, Apr 12, 2021 at 6:28 PM Linus

Re: KASAN: use-after-free Read in cma_cancel_operation, rdma_listen

2021-04-13 Thread Jason Gunthorpe
On Tue, Apr 13, 2021 at 11:36:41AM +0800, Hao Sun wrote: > Hi > > When using Healer(https://github.com/SunHao-0/healer/tree/dev) to fuzz > the Linux kernel, I found two use-after-free bugs which have been > reported a long time ago by Syzbot. > Although the corresponding patches have been merged i

Re: [PATCH 1/2] Revert "iommu/amd: Fix performance counter initialization"

2021-04-13 Thread Suthikulpanit, Suravee
Shuah, On 4/10/2021 12:06 AM, Shuah Khan wrote: diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index 321f5906e6ed..648cdfd03074 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -1729,39 +1728,17 @@ static void __init init_iommu_perf_ctr(struct amd_io

Re: [PATCH] nvme: Drop WQ_MEM_RECLAIM flag from core workqueues

2021-04-13 Thread Jason Gunthorpe
On Tue, Apr 13, 2021 at 10:54:04AM +0200, Daniel Wagner wrote: > Hmm, I am struggling with your last statement. If a worker does an > allocation it might block. I understand this is something which a worker > in a WQ_MEM_RECLAIM context is not allowed to do. > > My aim is still to get rid of the

Re: [PATCH v3 1/4] dt-bindings: pwm: convert pwm-rockchip.txt to YAML

2021-04-13 Thread Rob Herring
On Mon, 12 Apr 2021 22:01:52 +0200, Johan Jonker wrote: > Current dts files with 'pwm' nodes are manually verified. > In order to automate this process pwm-rockchip.txt > has to be converted to yaml. > > Signed-off-by: Johan Jonker > --- > For some SoC nodes this patch serie generates notificatio

Re: [PATCH v5 1/3] dt-bindings: Add Hycon Technology vendor prefix

2021-04-13 Thread Rob Herring
On Mon, Apr 12, 2021 at 10:12 AM Giulio Benetti wrote: > > On 4/12/21 5:05 PM, Rob Herring wrote: > > On Sun, 11 Apr 2021 13:48:02 +0200, Giulio Benetti wrote: > >> Update Documentation/devicetree/bindings/vendor-prefixes.yaml to > >> include "hycon" as a vendor prefix for "Hycon Technology". > >>

Re: [PATCH v3 2/4] dt-bindings: pwm: add more compatible strings to pwm-rockchip.yaml

2021-04-13 Thread Rob Herring
On Mon, 12 Apr 2021 22:01:53 +0200, Johan Jonker wrote: > The compatible strings below are already in use in the Rockchip > dtsi files, but were somehow never added to a document, so add > > "rockchip,rk3328-pwm" > > "rockchip,rk3036-pwm", "rockchip,rk2928-pwm" > > "rockchip,rk3368-pwm", "rockch

[PATCH v2] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-13 Thread chris . chiu
From: Chris Chiu Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71) [ 1

Re: [PATCH v7 5/7] mm: Make alloc_contig_range handle free hugetlb pages

2021-04-13 Thread Michal Hocko
On Tue 13-04-21 12:47:45, Oscar Salvador wrote: > alloc_contig_range will fail if it ever sees a HugeTLB page within the > range we are trying to allocate, even when that page is free and can be > easily reallocated. > This has proved to be problematic for some users of alloc_contic_range, > e.g: C

Re: [PATCH v4 1/3] kunit: make test->lock irq safe

2021-04-13 Thread Brendan Higgins
On Tue, Apr 13, 2021 at 3:07 AM wrote: > > From: Vlastimil Babka > > The upcoming SLUB kunit test will be calling kunit_find_named_resource() from > a context with disabled interrupts. That means kunit's test->lock needs to be > IRQ safe to avoid potential deadlocks and lockdep splats. > > This p

Re: [PATCH] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE

2021-04-13 Thread Arnd Bergmann
On Tue, Apr 13, 2021 at 3:06 PM David Laight wrote: > > From: Arnd Bergmann > > Sent: 13 April 2021 13:58 > ... > > The remaining ones (csky, m68k, sparc32) need to be inspected > > manually to see if they currently support PCI I/O space but in > > fact use address zero as the base (with large res

Re: [PATCH 2/8] MIPS: pci-rt2880: remove unneeded locks

2021-04-13 Thread Sergey Ryazanov
On Tue, Apr 13, 2021 at 4:28 PM Sergey Ryazanov wrote: > On Tue, Apr 13, 2021 at 9:22 AM Ilya Lipnitskiy > wrote: > > Mirror pci-rt3883 fix from commit e5067c718b3a ("MIPS: pci-rt3883: > > Remove odd locking in PCI config space access code"). pci-rt2880 shares > > the driver layout with pci-rt388

Re: [PATCH v2 1/4] KVM: x86: Move FPU register accessors into fpu.h

2021-04-13 Thread Vitaly Kuznetsov
Siddharth Chandrasekaran writes: > Hyper-v XMM fast hypercalls use XMM registers to pass input/output > parameters. To access these, hyperv.c can reuse some FPU register > accessors defined in emulator.c. Move them to a common location so both > can access them. > > While at it, reorder the param

Re: Linux 5.12-rc7

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 03:33:40PM +0200, Eric Dumazet wrote: > On Tue, Apr 13, 2021 at 3:27 PM Eric Dumazet wrote: > > > > On Tue, Apr 13, 2021 at 2:57 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Apr 12, 2021 at 06:47:07PM +0200, Eric Dumazet wrote: > > > > On Mon, Apr 12, 2021 at 6:31 PM E

Re: [PATCH v2 1/1] ACPI: bus: Introduce acpi_dev_get() and reuse it in ACPI code

2021-04-13 Thread Rafael J. Wysocki
On Tue, Apr 13, 2021 at 12:24 AM Andy Shevchenko wrote: > > Introduce acpi_dev_get() to have a symmetrical API with acpi_dev_put() > and reuse both in ACPI code under drivers/acpi folder. > > While at it, use acpi_bus_put_acpi_device() in one place rather than above. > > Signed-off-by: Andy Shevch

Re: Linux 5.12-rc7

2021-04-13 Thread Eric Dumazet
On Tue, Apr 13, 2021 at 3:38 PM Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 03:33:40PM +0200, Eric Dumazet wrote: > > On Tue, Apr 13, 2021 at 3:27 PM Eric Dumazet wrote: > > > > > > On Tue, Apr 13, 2021 at 2:57 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Apr 12, 2021 at

Re: KASAN: use-after-free Read in cma_cancel_operation, rdma_listen

2021-04-13 Thread Hao Sun
Jason Gunthorpe 于2021年4月13日周二 下午9:34写道: > > On Tue, Apr 13, 2021 at 11:36:41AM +0800, Hao Sun wrote: > > Hi > > > > When using Healer(https://github.com/SunHao-0/healer/tree/dev) to fuzz > > the Linux kernel, I found two use-after-free bugs which have been > > reported a long time ago by Syzbot. >

[PATCH v2 3/7] rpmsg: Update rpmsg_chrdev_register_device function

2021-04-13 Thread Arnaud Pouliquen
The rpmsg_chrdev driver has been replaced by the rpmsg_ctrl driver for the /dev/rpmsg_ctrlX devices management. The reference for the driver override is now the rpmsg_ctrl. Update the rpmsg_chrdev_register_device function to reflect the update, and rename the function to use the rpmsg_ctrldev pref

[PATCH v2 7/7] rpmsg: char: Return error if user tries to destroy a default endpoint.

2021-04-13 Thread Arnaud Pouliquen
Using the RPMSG_DESTROY_EPT_IOCTL control, user application can destroy an endpoint. This patch prevents to destroy a default endpoint associated to a channel. This update is needed to manage the "rpmsg-raw" channel. In this case a default endpoint is used and destroying it without the channel doe

[PATCH v2 1/7] rpmsg: char: Export eptdev create an destroy functions

2021-04-13 Thread Arnaud Pouliquen
To prepare the split of the code related to the control (ctrldev) and the endpoint (eptdev) devices in 2 separate files: - Rename and export the functions in rpmsg_char.h. - Suppress the dependency with the rpmsg_ctrldev struct in the rpmsg_chrdev_create_eptdev function. - The rpmsg class is p

[PATCH v2 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel

2021-04-13 Thread Arnaud Pouliquen
update from V1 [1] - fix issues reported by Mathieu Poirier This series is the second step in the division of the series [2]: "Introducing a Generic IOCTL Interface for RPMsg Channel Management". The purpose of this patchset is to: - split the control code related to the control and the end

[PATCH v2 6/7] rpmsg: char: No dynamic endpoint management for the default one

2021-04-13 Thread Arnaud Pouliquen
Do not dynamically manage the default endpoint associated to the rpmsg device. The ept address must not change. This update is needed to manage the rpmsg-raw channel. In this case a default endpoint is used and its address must not change or been reused by another service. Signed-off-by: Arnaud P

[PATCH v2 2/7] rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl

2021-04-13 Thread Arnaud Pouliquen
Create the rpmsg_ctrl.c module and move the code related to the rpmsg_ctrldev device in this new module. Add the dependency between rpmsg_char and rpmsg_ctrl in the kconfig file. Signed-off-by: Arnaud Pouliquen --- update from v1: - keep "rpmsg_chrdev" driver name in rpmsg_ctrl, driver will be r

[PATCH v2 4/7] rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function

2021-04-13 Thread Arnaud Pouliquen
Introduce the __rpmsg_chrdev_create_eptdev internal function that returns the rpmsg_eptdev context structure. This patch prepares the introduction of a rpmsg channel device for the char device. The rpmsg device will need a reference to the context. Signed-off-by: Arnaud Pouliquen --- update fro

[PATCH v2 5/7] rpmsg: char: Introduce a rpmsg driver for the rpmsg char device

2021-04-13 Thread Arnaud Pouliquen
A rpmsg char device allows to probe the endpoint device on a remote name service announcement. With this patch the /dev/rpmsgX interface is created either by a user application or by the remote firmware. Signed-off-by: Arnaud Pouliquen --- update from V1: - add missing unregister_rpmsg_driver

Re: [PATCH 1/1] staging: ipu3-imgu: Move the UAPI header from include under include/uapi

2021-04-13 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Mon, Apr 12, 2021 at 02:11:20PM +0300, Sakari Ailus wrote: > The header defines the user space interface but may be mistaken as > kernel-only header due to its location. Add "uapi" directory under > driver's include directory and move the header there. > >

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-13 Thread Radu Nicolae Pirea (NXP OSS)
On Mon, 2021-04-12 at 10:50 +0100, Russell King - ARM Linux admin wrote: > On Fri, Apr 09, 2021 at 09:41:06PM +0300, Radu Pirea (NXP OSS) wrote: > > +#define B100T1_PMAPMD_CTL  0x0834 > > +#define B100T1_PMAPMD_CONFIG_ENBIT(15) > > +#define B100T1_PMAPMD_MASTER  

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-13 Thread Christian Herber
On 4/13/2021 3:30 PM, Andrew Lunn wrote: On Tue, Apr 13, 2021 at 08:56:30AM +0200, Christian Herber wrote: Hi Andrew, On 4/12/2021 6:52 PM, Andrew Lunn wrote: So what you are say is, you don't care if the IP is completely different, it all goes in one driver. So lets put this driver into n

Re: [PATCH v8] RISC-V: enable XIP

2021-04-13 Thread Alex Ghiti
Le 4/13/21 à 2:35 AM, Alexandre Ghiti a écrit : From: Vitaly Wool Introduce XIP (eXecute In Place) support for RISC-V platforms. It allows code to be executed directly from non-volatile storage directly addressable by the CPU, such as QSPI NOR flash which can be found on many RISC-V platforms.

aoe: kernel crash on blk_update_request: I/O error, BUG: scheduling while atomic

2021-04-13 Thread Valentin Kleibel
Dear Maintainers, It seems we found a race condition in the aoe driver that leads to a kernel crash. It is triggered when an aoe device is unavailable and therefore produces an I/O error in the code that tries to remove the device. (drivers/block/aoe/aoedev.c: aoedev_downdev) I reproduced this b

Re: Linux 5.12-rc7

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 03:42:24PM +0200, Eric Dumazet wrote: > On Tue, Apr 13, 2021 at 3:38 PM Michael S. Tsirkin wrote: > > > > On Tue, Apr 13, 2021 at 03:33:40PM +0200, Eric Dumazet wrote: > > > On Tue, Apr 13, 2021 at 3:27 PM Eric Dumazet wrote: > > > > > > > > On Tue, Apr 13, 2021 at 2:57 PM

Re: KASAN: use-after-free Read in cma_cancel_operation, rdma_listen

2021-04-13 Thread Jason Gunthorpe
On Tue, Apr 13, 2021 at 09:42:43PM +0800, Hao Sun wrote: > Jason Gunthorpe 于2021年4月13日周二 下午9:34写道: > > > > On Tue, Apr 13, 2021 at 11:36:41AM +0800, Hao Sun wrote: > > > Hi > > > > > > When using Healer(https://github.com/SunHao-0/healer/tree/dev) to fuzz > > > the Linux kernel, I found two use-af

Re: [PATCH v2 1/4] KVM: x86: Move FPU register accessors into fpu.h

2021-04-13 Thread Siddharth Chandrasekaran
On Tue, Apr 13, 2021 at 03:40:56PM +0200, Vitaly Kuznetsov wrote: > Siddharth Chandrasekaran writes: > > @@ -0,0 +1,140 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > + > > +#ifndef __KVM_FPU_H_ > > +#define __KVM_FPU_H_ > > + > > +#include > > + > > +typedef u32 __attribute__((vecto

Re: [PATCH v3 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

2021-04-13 Thread Rob Herring
On Fri, Apr 09, 2021 at 10:13:29AM +0700, Quan Nguyen wrote: > Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware > reference platform with Ampere's Altra Processor family. > > Signed-off-by: Quan Nguyen > --- > .../bindings/hwmon/ampere,ac01-hwmon.yaml | 28 + >

Re: [PATCH v2 2/2] ACPI: utils: Capitalize abbreviations in the comments

2021-04-13 Thread Rafael J. Wysocki
On Tue, Apr 13, 2021 at 1:21 AM Andy Shevchenko wrote: > > The DSDT and ACPI should be capitalized. > > Signed-off-by: Andy Shevchenko > --- > v2: split from patch 1 as per Rafael's request > drivers/acpi/utils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/driver

Re: [PATCH v3 2/4] i2c: mpc: Interrupt driven transfer

2021-04-13 Thread Andy Shevchenko
On Tue, Apr 13, 2021 at 8:10 AM Chris Packham wrote: > > The fsl-i2c controller will generate an interrupt after every byte > transferred. Make use of this interrupt to drive a state machine which > allows the next part of a transfer to happen as soon as the interrupt is > received. This is partic

Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS

2021-04-13 Thread Jason Gunthorpe
On Tue, Apr 13, 2021 at 09:29:41AM +0300, Leon Romanovsky wrote: > On Mon, Apr 12, 2021 at 07:58:47PM -0300, Jason Gunthorpe wrote: > > On Wed, Mar 31, 2021 at 08:43:12PM +0200, Håkon Bugge wrote: > > > ib_modify_qp() is an expensive operation on some HCAs running > > > virtualized. This series rem

Re: [PATCH 2/2] iommu/amd: Remove performance counter pre-initialization test

2021-04-13 Thread Suthikulpanit, Suravee
On 4/10/2021 5:03 PM, David Coe wrote: Results for AMD Ryzen 4700U running Ubuntu 21.04β kernel 5.11.0-13 $ sudo dmesg | grep IOMMU [    0.490352] pci :00:00.2: AMD-Vi: IOMMU performance counters supported [    0.491985] pci :00:00.2: AMD-Vi: Found IOMMU cap 0x40 [    0.493732] perf/a

Re: [PATCH v4 2/3] mm/slub, kunit: add a KUnit test for SLUB debugging functionality

2021-04-13 Thread Marco Elver
On Tue, 13 Apr 2021 at 12:07, wrote: > From: Oliver Glitta > > SLUB has resiliency_test() function which is hidden behind #ifdef > SLUB_RESILIENCY_TEST that is not part of Kconfig, so nobody > runs it. KUnit should be a proper replacement for it. > > Try changing byte in redzone after allocation

Re: [PATCH v2 2/4] KVM: hyper-v: Collect hypercall params into struct

2021-04-13 Thread Vitaly Kuznetsov
Siddharth Chandrasekaran writes: > As of now there are 7 parameters (and flags) that are used in various > hyper-v hypercall handlers. There are 6 more input/output parameters > passed from XMM registers which are to be added in an upcoming patch. > > To make passing arguments to the handlers mor

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-13 Thread Andrew Lunn
> Ok, we can agree that there will not be a perfect naming. Would it be a > possibility to rename the existing TJA11xx driver to TJA1100-1-2 or is that > unwanted? It is generally a bad idea. It makes back porting fixing harder if the file changes name. > If nxp-c45.c is to generic (I take from y

[PATCH] ACPI: x86: Call acpi_boot_table_init() after acpi_table_upgrade()

2021-04-13 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Commit 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by ACPI tables") attempted to address an issue with reserving the memory occupied by ACPI tables, but it broke the initrd-based table override mechanism relied on by multiple users. To restore the initrd-bas

Re: Linux 5.12-rc7

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 03:42:24PM +0200, Eric Dumazet wrote: > On Tue, Apr 13, 2021 at 3:38 PM Michael S. Tsirkin wrote: > > > > On Tue, Apr 13, 2021 at 03:33:40PM +0200, Eric Dumazet wrote: > > > On Tue, Apr 13, 2021 at 3:27 PM Eric Dumazet wrote: > > > > > > > > On Tue, Apr 13, 2021 at 2:57 PM

Re: [PATCH RFC v2 1/4] virtio: fix up virtio_disable_cb

2021-04-13 Thread Willem de Bruijn
On Tue, Apr 13, 2021 at 1:47 AM Michael S. Tsirkin wrote: > > virtio_disable_cb is currently a nop for split ring with event index. > This is because it used to be always called from a callback when we know > device won't trigger more events until we update the index. However, > now that we run w

Re: [PATCH] ASoC: cs35l35: Fix an error handling path in 'cs35l35_i2c_probe()'

2021-04-13 Thread Christophe JAILLET
Le 13/04/2021 à 14:43, Mark Brown a écrit : On Sun, Apr 11, 2021 at 02:51:06PM +0200, Christophe JAILLET wrote: If 'devm_regmap_init_i2c()' fails, there is no need to goto err. We should return directly as already done by the surrounding error handling paths. These are stylistic improvements r

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-13 Thread Christian Herber
On 4/13/2021 3:57 PM, Andrew Lunn wrote: Ok, we can agree that there will not be a perfect naming. Would it be a possibility to rename the existing TJA11xx driver to TJA1100-1-2 or is that unwanted? It is generally a bad idea. It makes back porting fixing harder if the file changes name. If n

Re: [PATCH RFC v2 3/4] virtio_net: move tx vq operation under tx queue lock

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 04:54:42PM +0800, Jason Wang wrote: > > 在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: > > It's unsafe to operate a vq from multiple threads. > > Unfortunately this is exactly what we do when invoking > > clean tx poll from rx napi. > > As a fix move everything that deals with

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-13 Thread Andrew Lunn
> nxp-c45-tja11xx is acceptable from my point of view. Great. Enough bike shedding, nxp-c45-tja11xx it is. Andrew

Re: [PATCH][next] scsi: aacraid: Replace one-element array with flexible-array member

2021-04-13 Thread James Bottomley
On Tue, 2021-04-13 at 00:45 -0500, Gustavo A. R. Silva wrote: > Hi Martin, > > On 4/12/21 23:52, Martin K. Petersen wrote: > > > Silencing analyzer warnings shouldn't be done at the expense of > > human > > readers. If it is imperative to switch to flex_array_size() to > > quiesce > > checker war

Re: [PATCH v5 14/16] memory: mtk-smi: Get rid of mtk_smi_larb_get/put

2021-04-13 Thread Krzysztof Kozlowski
On 10/04/2021 11:11, Yong Wu wrote: > After adding device_link between the iommu consumer and smi-larb, > the pm_runtime_get(_sync) of smi-larb and smi-common will be called > automatically. we can get rid of mtk_smi_larb_get/put. > > CC: Matthias Brugger > Signed-off-by: Yong Wu > Reviewed-by:

Re: [PATCH] KVM: arm/arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST read

2021-04-13 Thread Marc Zyngier
On Mon, 12 Apr 2021 17:00:34 +0200, Eric Auger wrote: > When reading the base address of the a REDIST region > through KVM_VGIC_V3_ADDR_TYPE_REDIST we expect the > redistributor region list to be populated with a single > element. > > However list_first_entry() expects the list to be non empty. >

Re: [PATCH] ASoC: Intel: Handle device properties with software node API

2021-04-13 Thread Heikki Krogerus
On Tue, Apr 13, 2021 at 03:20:45PM +0300, Heikki Krogerus wrote: > On Mon, Apr 12, 2021 at 03:36:20PM -0500, Pierre-Louis Bossart wrote: > > I took the code and split it in two for BYT/CHT (modified to remove devm_) > > and SoundWire parts (added as is). > > > > https://github.com/thesofproject/li

Re: [PATCH RFC v2 2/4] virtio_net: disable cb aggressively

2021-04-13 Thread Willem de Bruijn
On Tue, Apr 13, 2021 at 4:53 AM Jason Wang wrote: > > > 在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: > > There are currently two cases where we poll TX vq not in response to a > > callback: start xmit and rx napi. We currently do this with callbacks > > enabled which can cause extra interrupts from

Re: [PATCH] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE

2021-04-13 Thread Guo Ren
On Tue, Apr 13, 2021 at 9:40 PM Arnd Bergmann wrote: > > On Tue, Apr 13, 2021 at 3:06 PM David Laight wrote: > > > > From: Arnd Bergmann > > > Sent: 13 April 2021 13:58 > > ... > > > The remaining ones (csky, m68k, sparc32) need to be inspected > > > manually to see if they currently support PCI

[PATCH] cxl/mem: Add media provisioning required commands

2021-04-13 Thread Ben Widawsky
Some of the commands have already been defined for the support of RAW commands (to be blocked). Unlike their usage in the RAW interface, when used through the supported interface, they will be coordinated and marshalled along with other commands being issued by userspace and the driver itself. That

Re: KASAN: use-after-free Read in cma_cancel_operation, rdma_listen

2021-04-13 Thread Haakon Bugge
> On 13 Apr 2021, at 15:44, Jason Gunthorpe wrote: > > On Tue, Apr 13, 2021 at 09:42:43PM +0800, Hao Sun wrote: >> Jason Gunthorpe 于2021年4月13日周二 下午9:34写道: >>> >>> On Tue, Apr 13, 2021 at 11:36:41AM +0800, Hao Sun wrote: Hi When using Healer(https://github.com/SunHao-0/healer/t

[PATCH v2 1/2] KVM: selftests: Keep track of memslots more efficiently

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" The KVM selftest framework was using a simple list for keeping track of the memslots currently in use. This resulted in lookups and adding a single memslot being O(n), the later due to linear scanning of the existing memslot set to check for the presence of any conflic

Re: [PATCH v2 3/4] KVM: x86: kvm_hv_flush_tlb use inputs from XMM registers

2021-04-13 Thread Vitaly Kuznetsov
Siddharth Chandrasekaran writes: > Hyper-V supports the use of XMM registers to perform fast hypercalls. > This allows guests to take advantage of the improved performance of the > fast hypercall interface even though a hypercall may require more than > (the current maximum of) two input register

[PATCH 1/7] staging: rtl8723bs: replace dump_drv_version usage with netdev_*

2021-04-13 Thread Fabio Aiuto
replace dump_drv_version() usage with netdev_dbg(). The string printed is the same contained in DBG_871X_SEL_NL macro called inside dump_drv_version(). This is just preparation before bulk DBG_871X_SEL_NL macro replacement by coccinelle. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs

[PATCH 0/7] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg()

2021-04-13 Thread Fabio Aiuto
This patchset replaces DGB_871X_SEL_NL macro with the driver recommended log function netdev_dbg(). Macro DBG_871X_SEL_NL indeed executes a raw printk call as default behaviour. The other behaviour is doing a seq_printf() call which never occurs. First patch replace dump_drv_version with a netdev

[PATCH v2 2/2] KVM: selftests: add a memslot-related performance benchmark

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This benchmark contains the following tests: * Map test, where the host unmaps guest memory while the guest writes to it (maps it). The test is designed in a way to make the unmap operation on the host take a negligible amount of time in comparison with the mapping op

[PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()

2021-04-13 Thread Fabio Aiuto
replace DGB_871X_SEL_NL macro with netdev_dbg(). DBG_871X_SEL_NL macro expands to a raw prink call or a seq_printf if selected stream _is not_ a local debug symbol set to null. This second scenario never occurs so replace all macro usages with netdev_dbg(). This is done with the following coccine

[PATCH v2 0/8] KVM: Scalable memslots implementation

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" The current memslot code uses a (reverse) gfn-ordered memslot array for keeping track of them. This only allows quick binary search by gfn, quick lookup by hva is not possible (the implementation has to do a linear scan of the whole memslot array). Because the memslot

[PATCH 3/7] staging: rtl8723bs: remove two unused functions

2021-04-13 Thread Fabio Aiuto
remove dump_drv_version() and dump_log_level() function definitions and prototypes. These two functions incapsulate DBG_871X_SEL_NL macro which does a raw printk call (something to avoid in a driver). The DBG_871X_SEL_NL seq_printf usage is never triggered. So we remove dump_drv_version() which is

[PATCH 2/7] staging: rtl8723bs: remove unnecessary dump_drv_version() usage

2021-04-13 Thread Fabio Aiuto
remove unnecessary dump_drv_version() usage. This prepares dump_drv_version() for removal and further DBG_871X_SEL_NL removal. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_int

[PATCH 5/7] staging: rtl8723bs: put a new line after ';'

2021-04-13 Thread Fabio Aiuto
fix the following post commit hook checkpatch issue: ERROR: space required after that ';' (ctx:VxV) 232: FILE: drivers/staging/rtl8723bs/core/rtw_odm.c:160: + "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg (adapter->pnetdev, This was coccinelle script output

[PATCH v2 1/8] KVM: x86: Cache total page count to avoid traversing the memslot array

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" There is no point in recalculating from scratch the total number of pages in all memslots each time a memslot is created or deleted. Just cache the value and update it accordingly on each such operation so the code doesn't need to traverse the whole memslot array each

[PATCH 6/7] staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration

2021-04-13 Thread Fabio Aiuto
remove DBG_871X_SEL_NL obsolete macro declaration. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_debug.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h index f1b37d5

[PATCH 7/7] staging: rtl8723bs: remove unused argument in function

2021-04-13 Thread Fabio Aiuto
removed unused 'void *sel' argument in rtw_odm_dbg_comp_msg() function, after DBG_871X_SEL_NL replacement. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_odm.c | 2 +- drivers/staging/rtl8723bs/include/rtw_odm.h| 2 +- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c |

[PATCH v2 2/8] KVM: Integrate gfn_to_memslot_approx() into search_memslots()

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" s390 arch has gfn_to_memslot_approx() which is almost identical to search_memslots(), differing only in that in case the gfn falls in a hole one of the memslots bordering the hole is returned. Add this lookup mode as an option to search_memslots() so we don't have two

[PATCH v2 4/8] KVM: Introduce memslots hva tree

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" The current memslots implementation only allows quick binary search by gfn, quick lookup by hva is not possible - the implementation has to do a linear scan of the whole memslots array, even though the operation being performed might apply just to a single memslot. Th

[PATCH v2 3/8] KVM: Resolve memslot ID via a hash table instead of via a static array

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Memslot ID to the corresponding memslot mappings are currently kept as indices in static id_to_index array. The size of this array depends on the maximum allowed memslot count (regardless of the number of memslots actually in use). This has become especially problemat

[PATCH v2 5/8] KVM: s390: Introduce kvm_s390_get_gfn_end()

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" And use it where s390 code would just access the memslot with the highest gfn directly. No functional change intended. Signed-off-by: Maciej S. Szmigiero --- arch/s390/kvm/kvm-s390.c | 2 +- arch/s390/kvm/kvm-s390.h | 12 arch/s390/kvm/pv.c | 4

[PATCH v2 7/8] KVM: Optimize gfn lookup in kvm_zap_gfn_range()

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Introduce a memslots gfn upper bound operation and use it to optimize kvm_zap_gfn_range(). This way this handler can do a quick lookup for intersecting gfns and won't have to do a linear scan of the whole memslot set. Signed-off-by: Maciej S. Szmigiero --- arch/x86/

[PATCH v2 6/8] KVM: Keep memslots in tree-based structures instead of array-based ones

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" The current memslot code uses a (reverse gfn-ordered) memslot array for keeping track of them. Because the memslot array that is currently in use cannot be modified every memslot management operation (create, delete, move, change flags) has to make a copy of the whole

[PATCH v3] staging: media: meson: vdec: declare u32 as static const

2021-04-13 Thread Mitali Borkar
Declared 32 bit unsigned int as static constant inside a function and replaced u32[] {x,y} as canvas3, canvas4 in codec_h264.c This indicates the value of canvas indexes will remain constant throughout execution. Reported-by: kernel test robot Signed-off-by: Mitali Borkar --- Changes from v2:-

[PATCH v2 8/8] KVM: Optimize overlapping memslots check

2021-04-13 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Do a quick lookup for possibly overlapping gfns when creating or moving a memslot instead of performing a linear scan of the whole memslot set. Signed-off-by: Maciej S. Szmigiero --- virt/kvm/kvm_main.c | 65 ++--- 1 file chan

Re: [PATCH v2 2/4] KVM: hyper-v: Collect hypercall params into struct

2021-04-13 Thread Siddharth Chandrasekaran
On Tue, Apr 13, 2021 at 03:53:01PM +0200, Vitaly Kuznetsov wrote: > Siddharth Chandrasekaran writes: > > As of now there are 7 parameters (and flags) that are used in various > > hyper-v hypercall handlers. There are 6 more input/output parameters > > passed from XMM registers which are to be adde

RE: [PATCH] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE

2021-04-13 Thread David Laight
From: Arnd Bergmann > Sent: 13 April 2021 14:40 > > On Tue, Apr 13, 2021 at 3:06 PM David Laight wrote: > > > > From: Arnd Bergmann > > > Sent: 13 April 2021 13:58 > > ... > > > The remaining ones (csky, m68k, sparc32) need to be inspected > > > manually to see if they currently support PCI I/O s

Re: [PATCH 0/7] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg()

2021-04-13 Thread Fabio Aiuto
On Tue, Apr 13, 2021 at 04:10:35PM +0200, Fabio Aiuto wrote: > This patchset replaces DGB_871X_SEL_NL macro with the driver > recommended log function netdev_dbg(). > > Macro DBG_871X_SEL_NL indeed executes a raw printk call as > default behaviour. The other behaviour is doing a seq_printf() > cal

[PATCH net-next] net: Space: remove hp100 probe

2021-04-13 Thread Arnd Bergmann
From: Arnd Bergmann The driver was removed last year, but the static initialization got left behind by accident. Fixes: a10079c66290 ("staging: remove hp100 driver") Signed-off-by: Arnd Bergmann --- drivers/net/Space.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/Space.c b

Re: [PATCH 5/7] mm: memcontrol: simplify the logic of objcg pinning memcg

2021-04-13 Thread Shakeel Butt
On Mon, Apr 12, 2021 at 11:58 PM Muchun Song wrote: > > The obj_cgroup_release() and memcg_reparent_objcgs() are serialized by > the css_set_lock. We do not need to care about objcg->memcg being > released in the process of obj_cgroup_release(). So there is no need > to pin memcg before releasing

Re: KASAN: use-after-free Read in cma_cancel_operation, rdma_listen

2021-04-13 Thread Hao Sun
Jason Gunthorpe 于2021年4月13日周二 下午9:45写道: > > On Tue, Apr 13, 2021 at 09:42:43PM +0800, Hao Sun wrote: > > Jason Gunthorpe 于2021年4月13日周二 下午9:34写道: > > > > > > On Tue, Apr 13, 2021 at 11:36:41AM +0800, Hao Sun wrote: > > > > Hi > > > > > > > > When using Healer(https://github.com/SunHao-0/healer/tre

Re: [PATCH 6/7] mm: memcontrol: move obj_cgroup_uncharge_pages() out of css_set_lock

2021-04-13 Thread Shakeel Butt
On Mon, Apr 12, 2021 at 11:58 PM Muchun Song wrote: > > The css_set_lock is used to guard the list of inherited objcgs. So there > is no need to uncharge kernel memory under css_set_lock. Just move it > out of the lock. > > Signed-off-by: Muchun Song Reviewed-by: Shakeel Butt

Re: [PATCH RFC v2 3/4] virtio_net: move tx vq operation under tx queue lock

2021-04-13 Thread Willem de Bruijn
On Tue, Apr 13, 2021 at 10:03 AM Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 04:54:42PM +0800, Jason Wang wrote: > > > > 在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: > > > It's unsafe to operate a vq from multiple threads. > > > Unfortunately this is exactly what we do when invoking > > >

Re: [PATCH 3/3] rseq: optimise for 64bit arches

2021-04-13 Thread Mathieu Desnoyers
- On Apr 13, 2021, at 6:36 AM, David Laight david.lai...@aculab.com wrote: > From: Peter Zijlstra >> Sent: 13 April 2021 10:10 >> >> On Tue, Apr 13, 2021 at 12:36:57AM -0700, Eric Dumazet wrote: >> > From: Eric Dumazet >> > >> > Commit ec9c82e03a74 ("rseq: uapi: Declare rseq_cs field as unio

Re: [PATCH 1/1] sched/fair:Reduce unnecessary check preempt in the sched tick

2021-04-13 Thread Peter Zijlstra
On Tue, Apr 13, 2021 at 09:18:42PM +0800, qianjun.ker...@gmail.com wrote: > From: jun qian > > If it has been determined that the current cpu need resched in the > early stage of for_each_sched_entity, then there is no need to check > preempt in the subsequent se->parent entity_tick. Right, but

Re: [PATCH v2] staging: media: zoran: moved statement to next line with '*'

2021-04-13 Thread Hans Verkuil
On 09/04/2021 13:40, Mitali Borkar wrote: > Moved the statement to next line and added '*' before it to meet > linux kernel coding style for long(multi-line) comments. > > Signed-off-by: Mitali Borkar > --- > > Changes from v1:- made style changes according to linux kernel coding style > for lon

[PATCH v28 00/13] Introduce Data Access MONitor (DAMON)

2021-04-13 Thread SeongJae Park
From: SeongJae Park Changes from Previous Version (v27) === - Rebase on latest -mm tree (v5.12-rc7-mmots-2021-04-11-20-49) - dbgfs: Fix wrong failure handlings (Stefan Nuernberger) - dbgfs: Change return type of 'dbgfs_fill_ctx_dir()' to void (Greg KH) Introducti

[PATCH v28 02/13] mm/damon/core: Implement region-based sampling

2021-04-13 Thread SeongJae Park
From: SeongJae Park To avoid the unbounded increase of the overhead, DAMON groups adjacent pages that are assumed to have the same access frequencies into a region. As long as the assumption (pages in a region have the same access frequencies) is kept, only one page in the region is required to

<    1   2   3   4   5   6   7   8   9   10   >