Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 03:53:38PM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 3:24:43 PM CEST Julia Lawall wrote: > > On Sat, 10 Apr 2021, Fabio M. De Francesco wrote: > > > On Saturday, April 10, 2021 2:12:28 PM CEST Julia Lawall wrote: > > > > On Sat, 10 Apr 2021, Fabio M.

Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-10 Thread Uwe Kleine-König
Hello, On Sat, Apr 10, 2021 at 06:34:55AM +0900, Nobuhiro Iwamatsu wrote: > > > +static int visconti_pwm_remove(struct platform_device *pdev) > > > +{ > > > + struct visconti_pwm_chip *priv = platform_get_drvdata(pdev); > > > + > > > + return pwmchip_remove(&priv->chip); > > > > I think Uwe would

[PATCH v3] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Mitali Borkar
Fixed pointer error by adding '*' to the function. Reported by Julia. Signed-off-by: Mitali Borkar --- Changes from v2:- modified patch body but writing commit message clearly. Changes from v1:- added pointer to the function. drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- 1 file changed, 1 i

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Julia Lawall
On Sat, 10 Apr 2021, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 3:24:43 PM CEST Julia Lawall wrote: > > On Sat, 10 Apr 2021, Fabio M. De Francesco wrote: > > > On Saturday, April 10, 2021 2:12:28 PM CEST Julia Lawall wrote: > > > > On Sat, 10 Apr 2021, Fabio M. De Francesco wrot

Re: [PATCH v7 4/8] dt-bindings: pwm: Support new PWM_STAGGERING_ALLOWED flag

2021-04-10 Thread Uwe Kleine-König
Hello Thierry, On Fri, Apr 09, 2021 at 02:27:34PM +0200, Thierry Reding wrote: > On Wed, Apr 07, 2021 at 07:33:57AM +0200, Uwe Kleine-König wrote: > > On Tue, Apr 06, 2021 at 06:41:36PM +0200, Clemens Gruber wrote: > > > Add the flag and corresponding documentation for the new PWM staggering > > >

Re: [Outreachy kernel] [PATCH v3] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Julia Lawall
On Sat, 10 Apr 2021, Mitali Borkar wrote: > Fixed pointer error by adding '*' to the function. > Reported by Julia. Actually, there is a proper tag for reported by, like Signed-off-by. Look through the git history to see what to do. julia > > Signed-off-by: Mitali Borkar > --- > Changes fr

[PATCH v1 1/1] ACPI: scan: Utilize match_string() API

2021-04-10 Thread Andy Shevchenko
We have already an API to match a string in the array of strings. Utilize it instead of open coded analogues. Signed-off-by: Andy Shevchenko --- drivers/acpi/scan.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/acpi/scan.c b/drivers/acpi/sca

Re: [PATCH v7 4/8] dt-bindings: pwm: Support new PWM_STAGGERING_ALLOWED flag

2021-04-10 Thread Uwe Kleine-König
Hello Rob, On Tue, Apr 06, 2021 at 06:41:36PM +0200, Clemens Gruber wrote: > Add the flag and corresponding documentation for the new PWM staggering > mode feature. > > Cc: Rob Herring For now reviewing this patch is not necessary, we're discussing a better name for this flag. Best regards Uwe

Re: Bogus struct page layout on 32-bit

2021-04-10 Thread Matthew Wilcox
How about moving the flags into the union? A bit messy, but we don't have to play games with __packed__. diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 1210a8e41fad..f374d2f06255 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -68,16 +68,22 @@ struc

RE: Bogus struct page layout on 32-bit

2021-04-10 Thread David Laight
From: Matthew Wilcox > Sent: 10 April 2021 03:43 > On Sat, Apr 10, 2021 at 06:45:35AM +0800, kernel test robot wrote: > > >> include/linux/mm_types.h:274:1: error: static_assert failed due to > > >> requirement > '__builtin_offsetof(struct page, lru) == __builtin_offsetof(struct folio, > lru)' "o

[PATCH v2] staging: rtl8723bs: remove unnecessary goto jumps

2021-04-10 Thread Bryan Brattlof
The next instruction for both 'goto exit' jump statements is to execute the exit jump instructions regardless. We can safely remove all jump statements from __init rtw_drv_entry() Signed-off-by: Bryan Brattlof --- Changes from: v1: removed unnecessary edit of DBG_871X_LEVEL drivers/staging/rt

[PATCH 00/25] staging: rtl8723bs: remove DBG_8192C tracing macro

2021-04-10 Thread Fabio Aiuto
This patchset remove from rtl8723bs driver the tracing macro DBG_8192C. This macro belongs to a verbose private tracing family, which by default is set to _do nothing_. The only way to activate the tracing is to manually define a symbol in code. First patch applies the following semantic patch:

[PATCH 02/25] staging: rtl8723bs: remove all commented out DBG_8192C logs

2021-04-10 Thread Fabio Aiuto
remove all commented out DBG_8192C logs. Macro DBG_8192C belongs to a family of verbose private tracing macros. The default behaviour is _do nothing_, to activate it one should define DEBUG symbol by hand. So just remove it Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ieee802

[PATCH 01/25] staging: rtl8723bs: remove all DBG_8192C logs

2021-04-10 Thread Fabio Aiuto
remove all DBG_8192C logs. Macro DBG_8192C belongs to a family of verbose private tracing macros. The default behaviour is _do nothing_, to activate it one should define DEBUG symbol by hand. So just remove it with the following semantic patch: @@ expression a, b, c, d, e, f, g, h, i, j, k; con

[PATCH 04/25] staging: rtl8723bs: remove all if-blocks left empty by DBG_8192C-remove coccinelle script

2021-04-10 Thread Fabio Aiuto
remove all empty if blocks left empty by coccinelle script for DBG_8192C macro removal. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_ops.c| 17 - .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 15 +-- 2 files changed, 1 insertion(+), 31

[PATCH 03/25] staging: rtl8723bs: remove DBG_8192C macro definitions

2021-04-10 Thread Fabio Aiuto
remove all DBG_8192C macro definitions. Macro DBG_8192C belongs to a family of verbose private tracing macros. The default behaviour is _do nothing_, to activate it one should define DEBUG symbol by hand. So just remove it Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_d

[PATCH 06/25] staging: rtl8723bs: remove unused code blocks guarded by DEBUG_RTL871X

2021-04-10 Thread Fabio Aiuto
remove unused code blocks guarded by never set DEBUG_RTL871X Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_debug.c| 35 --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 20 --- 2 files changed, 55 deletions(-) diff --git a/drivers/staging/rtl87

[PATCH 05/25] staging: rtl8723bs: put spaces around operators

2021-04-10 Thread Fabio Aiuto
fix following post-commit hook checkpatch issue: CHECK: spaces preferred around that '+' (ctx:VxV) 89: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2431: + rtw_get_wps_ie(pbuf+_FIXED_IE_LENGTH_, ; ^ len-_FIXED_IE_LENGTH_, NULL, &wps_ielen) CHECK: spaces

[PATCH 07/25] staging: rtl8723bs: remove commented out DEBUG_RTL871X definition

2021-04-10 Thread Fabio Aiuto
remove commented out DEBUG_RTL871X definition Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/autoconf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/autoconf.h b/drivers/staging/rtl8723bs/include/autoconf.h index 996198750814..97a937

[PATCH 08/25] staging: rtl8723bs: remove code blocks guarded by DEBUG symbol

2021-04-10 Thread Fabio Aiuto
remove code blocks guarded by DEBUG symbol remove undefinition of DEBUG Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 5 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 25 --- drivers/staging/rtl8723bs/include/autoconf.h | 5 3 files

[PATCH 09/25] staging: rtl8723bs: remove empty code block guarded by DBG_CCX

2021-04-10 Thread Fabio Aiuto
remove code block guarded by DBG_CCX symbol, left empty after DBG_8192C removal. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/ha

[PATCH 10/25] staging: rtl8723bs: remove code block guarded by undefined SDIO_DEBUG_IO

2021-04-10 Thread Fabio Aiuto
remove code block guarded by SDIO_DEBUG_IO symbol. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index 4403

[PATCH 11/25] staging: rtl8723bs: remove commented out SDIO_DEBUG_IO symbol definition

2021-04-10 Thread Fabio Aiuto
remove commented out SDIO_DEBUG_IO symbol definition. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index 24e45f734bdd..a8d8fe54fea

[PATCH 12/25] staging: rtl8723bs: remove empty ifdef blocks conditioned to DEBUG_CFG80211 definition

2021-04-10 Thread Fabio Aiuto
remove empty ifdef blocks conditioned to DEBUG_CFG80211 definition. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/

[PATCH 13/25] staging: rtl8723bs: remove commented out DEBUG_CFG80211 symbol definition

2021-04-10 Thread Fabio Aiuto
remove commented out DEBUG_CFG80211 symbol definition. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/autoconf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/autoconf.h b/drivers/staging/rtl8723bs/include/autoconf.h index 074fee2052c9..9

[PATCH 14/25] staging: rtl8723bs: remove unnecessary bracks

2021-04-10 Thread Fabio Aiuto
remove unnecessary bracks in if-else blocks Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +- drivers/staging/rtl8723bs/hal/hal_com.c | 3 +- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 9 +-- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 63

[PATCH 15/25] staging: rtl8723bs: fix comparison to null

2021-04-10 Thread Fabio Aiuto
fix following post-commit hook checkpatch issues: CHECK: Comparison to NULL could be written "!pmlmepriv->wps_probe_req_ie" 348: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1319: + if (pmlmepriv->wps_probe_req_ie == NULL) CHECK: Comparison to NULL could be writte

[PATCH 16/25] staging: rtl8723bs: put spaces around operators

2021-04-10 Thread Fabio Aiuto
fix following post-commit hook checkpatch issues: CHECK: spaces preferred around that '+' (ctx:VxV) 87: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:746: + if ((_offset+_size_byte) > EFUSE_MAX_MAP_LEN) -- CHECK: spaces preferred around that '+' (ctx:VxV) 105: FILE: drivers/staging

[PATCH 17/25] staging: rtl8723bs: split long line

2021-04-10 Thread Fabio Aiuto
fix following post-commit hook checkpatch issue: WARNING: line length of 103 exceeds 100 columns 168: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:1086: + if (efuse_OneByteRead(padapter, efuse_addr, &efuse_data, bPseudoTest) == false) Signed-off-by: Fabio Aiuto

[PATCH 18/25] staging: rtl8723bs: put constant on the right side of the test

2021-04-10 Thread Fabio Aiuto
fix following post-commit hook checpatch issues: WARNING: Comparisons should place the constant on the right side of the test 287: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:738: + if (_SUCCESS != ret) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2

[PATCH 19/25] staging: rtl8723bs: remove empty if and else blocks

2021-04-10 Thread Fabio Aiuto
remove if and else blocks after DBG_8192C removal Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 1 - .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 - drivers/staging/rtl8723bs/hal/sdio_ops.c | 1 - .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2

[PATCH 21/25] staging: rtl8723bs: remove unnecessary parentheses in os_dep/ioctl_cfg80211.c

2021-04-10 Thread Fabio Aiuto
fix following post-commit hook checkpatch issue: WARNING: braces {} are not necessary for single statement blocks 94: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1225: + if (pwdev_priv->scan_request->wiphy == pwdev_priv->rtw_wdev->wiphy) {

[PATCH 20/25] staging: rtl8723bs: put constant on the right side of a test in os_dep/ioctl_cfg80211.c

2021-04-10 Thread Fabio Aiuto
fix following post-commit hook checkpatch issue: CHECK: Comparison to NULL could be written "psta" 72: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:854: + if (psta != NULL) { Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Hans de Goede
Hi, On 4/10/21 8:56 AM, Guenter Roeck wrote: > On 4/8/21 11:02 PM, Thomas Weißschuh wrote: >> On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote: >>> On 4/8/21 2:36 AM, Hans de Goede wrote: On 4/7/21 9:43 PM, Thomas Weißschuh wrote: > On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote:

[PATCH 22/25] staging: rtl8723bs: remove empty else block in os_dep/ioctl_cfg80211.c

2021-04-10 Thread Fabio Aiuto
remove empty else-block Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 39d0a0d24d2b..9c98820952e4 1006

[PATCH 23/25] staging: rtl8723bs: fix comparison to true issue

2021-04-10 Thread Fabio Aiuto
fix following post-commit hook checkpatch issue: CHECK: Using comparison to true is error prone 136: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: 2497: + if (psta->dot8021xalg != 1 || psta->bpairwise_key_installed == true) { Signed-off-by: Fabio Aiuto --

[PATCH 24/25] staging: rtl8723bs: remove more unnecessary parentheses

2021-04-10 Thread Fabio Aiuto
remove more unnecessary parentheses after DBG_8192C deletion. Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 21 --- .../staging/rtl8723bs/hal/rtl8723bs_recv.c| 4 ++-- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/s

[PATCH 25/25] staging: rtl8723bs: remove more empty if blocks after DBG_8192C deletion

2021-04-10 Thread Fabio Aiuto
remove more empty if-blocks after DBG_8192C deletion. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index 049112a08776

[PATCH v2] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-10 Thread angkery
From: Junlin Yang The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irq', so making 'irq' an int, and change the position to keep the code format. Fixes coccicheck warnings: ./drivers/ata/pata_ixp4x

Re: [PATCH v2] staging: rtl8723bs: remove unnecessary goto jumps

2021-04-10 Thread Greg Kroah-Hartman
On Sat, Apr 10, 2021 at 02:20:19PM +, Bryan Brattlof wrote: > The next instruction for both 'goto exit' jump statements is to > execute the exit jump instructions regardless. We can safely > remove all jump statements from __init rtw_drv_entry() > > Signed-off-by: Bryan Brattlof > --- > Chang

Re: [PATCH 00/10] Convert signal32 to user read access by block

2021-04-10 Thread Michael Ellerman
On Fri, 19 Mar 2021 11:06:49 + (UTC), Christophe Leroy wrote: > Similarly to the work done earlier with writes, this series > converts signal32 to using user_read_access_begin/end and > unsafe_get_user() and friends. > > Applies on to of the signal64 series, ie on merge-test (ca6e327fefb2) >

Re: [PATCH] powerpc: Switch to relative jump labels

2021-04-10 Thread Michael Ellerman
On Tue, 23 Mar 2021 15:47:59 + (UTC), Christophe Leroy wrote: > Convert powerpc to relative jump labels. > > Before the patch, pseries_defconfig vmlinux.o has: > 9074 __jump_table 0003f2a0 01321fa8 > 2**0 > > With the patch, the same config gets: > 9074

Re: [PATCH v3 03/15] powerpc/align: Convert emulate_spe() to user_access_begin

2021-04-10 Thread Michael Ellerman
On Fri, 12 Mar 2021 13:25:11 + (UTC), Christophe Leroy wrote: > This patch converts emulate_spe() to using user_access_begin > logic. > > Since commit 662bbcb2747c ("mm, sched: Allow uaccess in atomic with > pagefault_disable()"), might_fault() doesn't fire when called from > sections where pa

Re: [PATCH v2 00/15] powerpc: Cleanup of uaccess.h and adding asm goto for get_user()

2021-04-10 Thread Michael Ellerman
On Wed, 10 Mar 2021 17:46:39 + (UTC), Christophe Leroy wrote: > This series cleans up uaccess.h and adds asm goto for get_user() > > v2: > - Further clean ups > - asm goto for get_user() > - Move a few patches unrelated to put_user/get_user into another misc series. > > [...] Applied to powe

Re: [PATCH] powerpc/32: Remove powerpc specific definition of 'ptrdiff_t'

2021-04-10 Thread Michael Ellerman
On Mon, 5 Apr 2021 09:57:27 + (UTC), Christophe Leroy wrote: > For unknown reason, old commit d27dfd388715 ("Import pre2.0.8") > changed 'ptrdiff_t' from 'int' to 'long'. > > GCC expects it as 'int' really, and this leads to the following > warning when building KFENCE: > > CC mm/kfenc

Re: [PATCH v2 0/8] Implement EBPF on powerpc32

2021-04-10 Thread Michael Ellerman
On Mon, 22 Mar 2021 16:37:45 + (UTC), Christophe Leroy wrote: > This series implements extended BPF on powerpc32. For the implementation > details, see the patch before the last. > > The following operations are not implemented: > > case BPF_ALU64 | BPF_DIV | BPF_X: /* dst /= sr

Re: [PATCH v2] powerpc: iommu: fix build when neither PCI or IBMVIO is set

2021-04-10 Thread Michael Ellerman
On Sun, 4 Apr 2021 12:26:23 -0700, Randy Dunlap wrote: > When neither CONFIG_PCI nor CONFIG_IBMVIO is set/enabled, iommu.c has a > build error. The fault injection code is not useful in that kernel config, > so make the FAIL_IOMMU option depend on PCI || IBMVIO. > > Prevents this build error (warn

Re: [PATCH] powerpc/pseries: remove unneeded semicolon

2021-04-10 Thread Michael Ellerman
On Tue, 6 Apr 2021 09:33:05 +0800, Yang Li wrote: > Eliminate the following coccicheck warning: > ./arch/powerpc/platforms/pseries/lpar.c:1633:2-3: Unneeded semicolon Applied to powerpc/next. [1/1] powerpc/pseries: remove unneeded semicolon https://git.kernel.org/powerpc/c/01ed0510941ae1350

[PATCH] kconfig: use /boot/config-* etc. as DEFCONFIG_LIST only for native build

2021-04-10 Thread Masahiro Yamada
When the .config file is missing, 'make config', 'make menuconfig', etc. uses a file listed in DEFCONFIG_LIST as base configuration. Ususally, /boot/config-$(uname -r) exists, and is used as default. However, when you are cross-compiling the kernel, it does not make sense to use /boot/config-* fr

Re: [RFC 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked

2021-04-10 Thread Feng Tang
Hi Thomas, On Sat, Apr 10, 2021 at 11:27:11AM +0200, Thomas Gleixner wrote: > On Tue, Mar 30 2021 at 16:25, Feng Tang wrote: > > Normally the tsc_sync will be checked every time system enters idle state, > > but there is still caveat that a system won't enter idle, either because > > it's too busy

[PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Thomas Weißschuh
Changes since v1: * Incorporate feedback from Barnabás Pőcze * Use a WMI driver instead of a platform driver * Let the kernel manage the driver lifecycle * Fix errno/ACPI error confusion * Fix resource cleanup * Document reason for integer casting Changes since v2: * Style cleanups * Tes

[GIT PULL] Please pull powerpc/linux.git powerpc-5.12-6 tag

2021-04-10 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.12: The following changes since commit 53f1d31708f6240e4615b0927df31f182e389e2f: powerpc/mm/book3s64: Use the correct storage key value when calling H_PROTECT (2021-03-26 22:19:39 +1100) are

Re: [PATCH V2 3/4] dt-bindings: mfd: Convert pm8xxx bindings to yaml

2021-04-10 Thread kernel test robot
Hi satya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on abelloni/rtc-next] [also build test WARNING on lee-mfd/for-mfd-next robh/for-next v5.12-rc6 next-20210409] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patc

Re: [RFC 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked

2021-04-10 Thread Feng Tang
Hi Boris, On Sat, Apr 10, 2021 at 11:47:52AM +0200, Borislav Petkov wrote: > On Sat, Apr 10, 2021 at 11:27:11AM +0200, Thomas Gleixner wrote: > > On Tue, Mar 30 2021 at 16:25, Feng Tang wrote: > > > Normally the tsc_sync will be checked every time system enters idle state, > > > but there is still

[syzbot] WARNING in __nf_unregister_net_hook (4)

2021-04-10 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:cc0626c2 net: smsc911x: skip acpi_device_id table when !CO.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=110a3096d0 kernel config: https://syzkaller.appspot.com/x/.config?x=7eff0f22b8563a5f das

Re: [PATCH] staging: rtl8723bs: remove unnecessary goto jumps

2021-04-10 Thread kernel test robot
Hi Bryan, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Bryan-Brattlof/staging-rtl8723bs-remove-unnecessary-goto-jumps/20210410-213334 base: https://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH] x86/msr: Block writes to certain MSRs unconditionally

2021-04-10 Thread Andy Lutomirski
> On Apr 10, 2021, at 5:11 AM, Borislav Petkov wrote: > > From: Borislav Petkov > Date: Sat, 10 Apr 2021 14:08:13 +0200 > > There are a bunch of MSRs which luserspace has no business poking at, > whatsoever. Add a ban list and put the TSC-related MSRs in there. Issue > a big juicy splat to

[PATCH v4 1/2] dw-xdata-pcie: Fix documentation build warns

2021-04-10 Thread Gustavo Pimentel
Fixes documentation build warns related to indentation, text formatting, and missing reference on toc. This fix solves the following warnings: WARNING: Unexpected indentation. WARNING: Block quote ends without a blank line; unexpected unindent. WARNING: document isn't included in any toctree Fix

[PATCH v4 2/2] dw-xdata-pcie: Update outdated info and improve text format

2021-04-10 Thread Gustavo Pimentel
Removes old information related to the stop file interface in sysfs left by mistake during patch revision. Improves the document text format to be more user-friendly and adds basic driver related information, such as support, datasheet, and author. Signed-off-by: Gustavo Pimentel --- Documentat

[PATCH v4 0/2] dw-xdata-pcie: Fix documentation build warns

2021-04-10 Thread Gustavo Pimentel
The first patch of this series fixes the documentation build warns, such as: WARNING: Unexpected indentation. WARNING: Block quote ends without a blank line; unexpected unindent. WARNING: document isn't included in any toctree. The second patch updates outdated and improve documentation informatio

Re: [PATCH v2] staging: rtl8723bs: remove unnecessary goto jumps

2021-04-10 Thread Bryan Brattlof
On Sat, Apr 10, 2021 at 04:28:19PM +0200, Greg Kroah-Hartman wrote: > >On Sat, Apr 10, 2021 at 02:20:19PM +, Bryan Brattlof wrote: >> The next instruction for both 'goto exit' jump statements is to >> execute the exit jump instructions regardless. We can safely >> remove all jump statements fro

[PATCH v4] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Mitali Borkar
Fixed pointer error by adding '*' to the function. Signed-off-by: Mitali Borkar Reported-by: Julia Lawall --- Changes from v3:- added reported by tag in proper manner. Changes from v2:- changed the patch nody to describe changes. Changes from v1:- added pointer to the function. drivers/stagin

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Hans de Goede
Hi, On 4/10/21 4:40 PM, Thomas Weißschuh wrote: > Changes since v1: > * Incorporate feedback from Barnabás Pőcze > * Use a WMI driver instead of a platform driver > * Let the kernel manage the driver lifecycle > * Fix errno/ACPI error confusion > * Fix resource cleanup > * Document reaso

Re: [PATCH] perf session: Dump PERF_RECORD_TIME_CONV event

2021-04-10 Thread Leo Yan
Hi Adrian, On Sat, Apr 10, 2021 at 11:46:10AM +0300, Adrian Hunter wrote: [...] > Hi Leo > > I think there might be some more work related to this. > > Pedantically, shouldn't you cater for backward compatibility and > not assume the following were in the perf.data file: >

[Outreachy kernel] [PATCH v2 0/5] staging: rtl8723bs: Change

2021-04-10 Thread Fabio M. De Francesco
Remove camelcase, correct misspelled words in comments, remove an unused variable, change the type of a variable and its use, change comparisons with 'true' in controlling expressions. Changes from v1: Fix a typo in subject of patch 1/5, add patch 5/5. Fabio M. De Francesco (5): staging: rtl872

[Outreachy kernel] [PATCH v2 1/5] staging: rtl8723bs: Remove camelcase in several files

2021-04-10 Thread Fabio M. De Francesco
Remove camelcase in bFwCurrentInPSMode, a variable used by code of several subdirectories/files of the driver. Issue detected by checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from the beginning of the name. Signed-off-by: Fabio M. De Francesco --- Changes from v1: Fix a typo

[Outreachy kernel] [PATCH v2 3/5] staging: rtl8723bs: core: Remove an unused variable

2021-04-10 Thread Fabio M. De Francesco
Delete local variable "u8 sec_idx" because is declared and set, but never used. Signed-off-by: Fabio M. De Francesco --- Changes from v1: No changes. drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/

[Outreachy kernel] [PATCH v2 2/5] staging: rtl8723bs: include: Fix misspelled words in comments

2021-04-10 Thread Fabio M. De Francesco
Signed-off-by: Fabio M. De Francesco --- Changes from v1: No changes. .../rtl8723bs/include/Hal8192CPhyReg.h| 8 ++--- .../staging/rtl8723bs/include/basic_types.h | 2 +- drivers/staging/rtl8723bs/include/drv_types.h | 2 +- drivers/staging/rtl8723bs/include/hal_com.h | 2 +- ..

[Outreachy kernel] [PATCH v2 5/5] staging: rtl8723bs: core: Change a controlling expression

2021-04-10 Thread Fabio M. De Francesco
Change a controlling expression within an 'if' statement: don't compare with 'true'. Signed-off-by: Fabio M. De Francesco --- Changes from v1: No changes. This related patch is new to this series. drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[Outreachy kernel] [PATCH v2 4/5] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Fabio M. De Francesco
Change the type of fw_current_in_ps_mode from u8 to bool, because it is used everywhere as a bool and, accordingly, it should be declared as a bool. Shorten the controlling expression of an 'if' statement. Signed-off-by: Fabio M. De Francesco --- Changes from v1: No changes. drivers/staging/rt

Re: [PATCH 4.14 00/14] 4.14.230-rc1 review

2021-04-10 Thread Guenter Roeck
Hi Greg, On 4/10/21 6:15 AM, Greg Kroah-Hartman wrote: > On Fri, Apr 09, 2021 at 01:13:06PM -0700, Guenter Roeck wrote: >> On Fri, Apr 09, 2021 at 11:53:25AM +0200, Greg Kroah-Hartman wrote: >>> This is the start of the stable review cycle for the 4.14.230 release. >>> There are 14 patches in this

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Guenter Roeck
On 4/10/21 7:40 AM, Thomas Weißschuh wrote: > Changes since v1: > * Incorporate feedback from Barnabás Pőcze > * Use a WMI driver instead of a platform driver > * Let the kernel manage the driver lifecycle > * Fix errno/ACPI error confusion > * Fix resource cleanup > * Document reason for

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Guenter Roeck
On 4/10/21 7:57 AM, Hans de Goede wrote: > Hi, > > On 4/10/21 4:40 PM, Thomas Weißschuh wrote: >> Changes since v1: >> * Incorporate feedback from Barnabás Pőcze >> * Use a WMI driver instead of a platform driver >> * Let the kernel manage the driver lifecycle >> * Fix errno/ACPI error confu

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Hans de Goede
Hi, On 4/10/21 5:15 PM, Guenter Roeck wrote: > On 4/10/21 7:40 AM, Thomas Weißschuh wrote: >> Changes since v1: >> * Incorporate feedback from Barnabás Pőcze >> * Use a WMI driver instead of a platform driver >> * Let the kernel manage the driver lifecycle >> * Fix errno/ACPI error confusion

Re: [PATCH 2/3] staging: rtl8723bs: Use existing arc4 implementation

2021-04-10 Thread kernel test robot
Hi Christophe, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Christophe-JAILLET/staging-rtl8188eu-Use-existing-arc4-implementation/20210410-213656 base: https://git.kernel.org/pub

[PATCH v3] staging: rtl8723bs: remove unnecessary goto jumps

2021-04-10 Thread Bryan Brattlof
The next instruction for both 'goto exit' jump statements is to execute the exit jump instructions regardless. We can safely remove all jump statements from __init rtw_drv_entry() This will also remove the extra line-break before module_init() that checkpatch.pl was concerned with. Signed-off-by:

[PATCH v3 0/2] staging: media: zoran: aligned the code.

2021-04-10 Thread Mitali Borkar
This patch fix the alignment of code in proper manner Changes from v2:- Aligned the code using tabs. Changes from v1:- Aligned the code using tabs and readjusted the comments line. Mitali Borkar (2): media: zoran: add spaces around '<<' staging: media: zoran: align code appropriately driver

[PATCH -v1.1] x86/msr: Block writes to certain MSRs unconditionally

2021-04-10 Thread Borislav Petkov
On Sat, Apr 10, 2021 at 07:51:58AM -0700, Andy Lutomirski wrote: > Can you add STAR, CSTAR, LSTAR, SYSENTER*, SYSCALL*, and EFER please? Sure. --- From: Borislav Petkov Date: Sat, 10 Apr 2021 14:08:13 +0200 There are a bunch of MSRs which luserspace has no business poking at, whatsoever. Add a

[PATCH v3 1/2] media: zoran: add spaces around '<<'

2021-04-10 Thread Mitali Borkar
Signed-off-by: Mitali Borkar --- Changes from v2:- No changes. Changes from v1:- NO changes. drivers/staging/media/zoran/zr36057.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/zoran/zr36057.h b/drivers/staging/media/zoran/zr36057.h in

[PATCH v3 2/2] staging: media: zoran: align code appropriately

2021-04-10 Thread Mitali Borkar
Aligned the code properly by using tabs to make code neater and improve readability. Signed-off-by: Mitali Borkar --- drivers/staging/media/zoran/zr36057.h | 108 +- 1 file changed, 54 insertions(+), 54 deletions(-) diff --git a/drivers/staging/media/zoran/zr36057.h b/d

Re: [RFC 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked

2021-04-10 Thread Borislav Petkov
On Sat, Apr 10, 2021 at 10:48:56PM +0800, Feng Tang wrote: > And the bigger risk is still BIOS's writing to TSC_ADJUST MSR beneath > kernel. For that we need to do more persuasive work with hw guys. Needs a *lot* of perseverance. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes

Re: [PATCH 3/3] staging: rtl8712: Use existing arc4 implementation

2021-04-10 Thread kernel test robot
Hi Christophe, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Christophe-JAILLET/staging-rtl8188eu-Use-existing-arc4-implementation/20210410-213656 base: https://git.kernel.org/pub

Re: [PATCH 4.14 00/14] 4.14.230-rc1 review

2021-04-10 Thread Guenter Roeck
On 4/10/21 2:21 AM, Naresh Kamboju wrote: > On Sat, 10 Apr 2021 at 01:43, Guenter Roeck wrote: >> >> On Fri, Apr 09, 2021 at 11:53:25AM +0200, Greg Kroah-Hartman wrote: >>> This is the start of the stable review cycle for the 4.14.230 release. >>> There are 14 patches in this series, all will be p

Re: [PATCH net-next v3 2/5] mm: add a signature in struct page

2021-04-10 Thread Matthew Wilcox
On Sat, Apr 10, 2021 at 12:37:58AM +0200, Matteo Croce wrote: > This is needed by the page_pool to avoid recycling a page not allocated > via page_pool. Is the PageType mechanism more appropriate to your needs? It wouldn't be if you use page->_mapcount (ie mapping it to userspace). > Signed-off-

Re: Bogus struct page layout on 32-bit

2021-04-10 Thread Russell King - ARM Linux admin
On Sat, Apr 10, 2021 at 03:06:52PM +0100, Matthew Wilcox wrote: > How about moving the flags into the union? A bit messy, but we don't > have to play games with __packed__. Yes, that is probably the better solution, avoiding the games to try and get the union appropriately placed on 32-bit system

[PATCH] dm verity: fix unaligned block size

2021-04-10 Thread Jaegeuk Kim
From: Jaegeuk Kim When f->roots is 2 and block size is 4096, it will gives unaligned block size length in the scsi command like below. Let's allocate dm_bufio to set the block size length to match IO chunk size. E sd 0: 0:0:0: [sda] tag#30 request not aligned to the logical block size E blk_

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-10 Thread Roy Spliet
Reviving this thread as we have another user (rightfully) complaining on IRC about this. The way I see it there's two issues: 1) snd_hda_intel not allowing runpm (or w/e vgaswitcheroo needs) when there's missing codecs, inhibiting the entire GPU from performing runpm. This needlessly wastes lo

Re: [PATCH 2/3] staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output

2021-04-10 Thread Alexandru Ardelean
On Fri, Apr 9, 2021 at 9:51 PM Lucas Stankus wrote: > > Ditch platform_data fields in favor of device tree properties for > configuring EXCA and EXCB output. > This also removes the fields from the platform_data struct, since they're > not used anymore. > > Signed-off-by: Lucas Stankus > --- > d

Re: [PATCH 2/3] staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output

2021-04-10 Thread Alexandru Ardelean
On Sat, Apr 10, 2021 at 7:12 PM Alexandru Ardelean wrote: > > On Fri, Apr 9, 2021 at 9:51 PM Lucas Stankus > wrote: > > > > Ditch platform_data fields in favor of device tree properties for > > configuring EXCA and EXCB output. > > This also removes the fields from the platform_data struct, sinc

Re: [PATCH net-next v3 2/5] mm: add a signature in struct page

2021-04-10 Thread Ilias Apalodimas
Hi Matthew On Sat, Apr 10, 2021 at 04:48:24PM +0100, Matthew Wilcox wrote: > On Sat, Apr 10, 2021 at 12:37:58AM +0200, Matteo Croce wrote: > > This is needed by the page_pool to avoid recycling a page not allocated > > via page_pool. > > Is the PageType mechanism more appropriate to your needs?

Re: [PATCH 0/3] staging: iio: cdc: ad7746: remove platform_data in favor of device tree bindings

2021-04-10 Thread Alexandru Ardelean
On Fri, Apr 9, 2021 at 9:50 PM Lucas Stankus wrote: > > This patch series aims to replace the platform_struct for the ad7746 driver > in favor of device tree bindings, creating the dt-bindings documentation in > the process. > > Since the header file was only used to define the struct and the exci

Re: [syzbot] WARNING: refcount bug in sk_psock_get

2021-04-10 Thread Cong Wang
On Fri, Apr 9, 2021 at 12:45 PM John Fastabend wrote: > > syzbot wrote: > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:9c54130c Add linux-next specific files for 20210406 > > git tree: linux-next > > console output: https://syzkaller.appspot.com/x/log.txt?x=1

[PATCH] iio: adc: exynos: drop unneeded variable assignment

2021-04-10 Thread Krzysztof Kozlowski
The initialization of 'ret' variable in probe function is shortly after overwritten. This initialization is simply not used. Addresses-Coverity: Unused value Signed-off-by: Krzysztof Kozlowski --- drivers/iio/adc/exynos_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-10 Thread Segher Boessenkool
On Sat, Apr 10, 2021 at 11:42:41AM +0200, Christophe Leroy wrote: > Le 10/04/2021 à 02:04, Michael Ellerman a écrit : > >I think these can all be avoided by defining most of the values > >regardless of what platform we're building for. Only the values that > >overlap need to be kept behind an ifdef

export.c:undefined reference to `atomic64_read_386'

2021-04-10 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d4961772226de3b48a395a26c076d450d7044c76 commit: 3cc55f4434b421d37300aa9a167ace7d60b45ccf nfs: use change attribute for NFS re-exports date: 2 months ago config: um-randconfig-r023-20210410 (attached as

Re: [GIT PULL] USB/Thunderbolt driver fixes for 5.12-rc7

2021-04-10 Thread pr-tracker-bot
The pull request you sent on Sat, 10 Apr 2021 15:06:04 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.12-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/445e09e79743c8ba01f1e9eb6b10faab5a92a5c7 Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] Driver core fix for 5.12-rc7

2021-04-10 Thread pr-tracker-bot
The pull request you sent on Sat, 10 Apr 2021 15:12:30 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > tags/driver-core-5.12-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d5fa1dad75bef69fbff5a193b7a99ada624a0154 Thank you! -- De

Re: [PULL REQUEST] i2c for 5.12

2021-04-10 Thread pr-tracker-bot
The pull request you sent on Sat, 10 Apr 2021 13:00:24 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/12a0cf7241f9ee6b9b62e4c5aad53c43f46817a4 Thank you! -- Deet-doot-dot, I am a bo

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.12-6 tag

2021-04-10 Thread pr-tracker-bot
The pull request you sent on Sun, 11 Apr 2021 00:43:49 +1000: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-5.12-6 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/95c7b07551879c8ad4d6dca10c02de46ddbf55a8 Thank you! -- Deet-doot-d

Re: static_branch/jump_label vs branch merging

2021-04-10 Thread Segher Boessenkool
On Fri, Apr 09, 2021 at 12:33:29PM -0700, Nick Desaulniers wrote: > Since asm goto is implicitly volatile qualified, it sounds like > removing the implicit volatile qualifier from asm goto might help? > Then if there were side effects but you forgot to inform the compiler > that there were via an e

<    1   2   3   4   5   >