Re: [PATCH -next] i2c: omap: fix PM reference leak in omap_i2c_probe()

2021-04-10 Thread Vignesh Raghavendra
Hi. On 4/8/21 6:26 PM, Li Huafei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. Fix > it by replacing it with pm_runtime_resume_and_get to keep usage counter > balanced. > > Reported-by: Hulk Robot

Re: [PATCH v2] kconfig: nconf: stop endless search-up loops

2021-04-10 Thread Mihai Moldovan
* On 4/10/21 7:47 AM, Masahiro Yamada wrote: > On Sun, Mar 28, 2021 at 6:52 PM Mihai Moldovan wrote: >> + if ((index == -1) && (index == match_start)) >> + return -1; > > We know 'index' is -1 in the second comparison. > So, you can also write like this: > >

[PATCH] Documentation: dev-tools: Add Testing Overview

2021-04-10 Thread David Gow
The kernel now has a number of testing and debugging tools, and we've seen a bit of confusion about what the differences between them are. Add a basic documentation outlining the testing tools, when to use each, and how they interact. This is a pretty quick overview rather than the idealised "ker

Re: [PATCH v5] ACPI / APEI: fix the regression of synchronous external aborts occur in user-mode

2021-04-10 Thread Xiaofei Tan
Hi James, Boris a friendly ping.. any comments for this ? On 2021/2/5 20:55, Rafael J. Wysocki wrote: On Tue, Jan 26, 2021 at 2:32 PM tanxiaofei wrote: @James Hi James, please help to review this patch. Thank you very much. :) James, Boris, any comments? On 2020/12/10 20:09, Xiaofei Tan

Re: [PATCH 5.10 00/41] 5.10.29-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:30, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.10.29 release. > There are 41 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

[PATCH v2 2/5] mm/hugeltb: simplify the return code of __vma_reservation_common()

2021-04-10 Thread Miaohe Lin
It's guaranteed that the vma is associated with a resv_map, i.e. either VM_MAYSHARE or HPAGE_RESV_OWNER, when the code reaches here or we would have returned via !resv check above. So it's unneeded to check whether HPAGE_RESV_OWNER is set here. Simplify the return code to make it more clear. Signe

[PATCH v2 5/5] mm/hugetlb: remove unused variable pseudo_vma in remove_inode_hugepages()

2021-04-10 Thread Miaohe Lin
The local variable pseudo_vma is not used anymore. Signed-off-by: Miaohe Lin --- fs/hugetlbfs/inode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index d81f52b87bd7..a2a42335e8fd 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@

[PATCH v2 0/5] Cleanup and fixup for hugetlb

2021-04-10 Thread Miaohe Lin
Hi all, This series contains cleanups to remove redundant VM_BUG_ON() and simplify the return code. Also this handles the error case in hugetlb_fix_reserve_counts() correctly. More details can be found in the respective changelogs. Thanks! v1->v2: collect Reviewed-by tag remove the HPAGE_RESV_

[PATCH v2 1/5] mm/hugeltb: remove redundant VM_BUG_ON() in region_add()

2021-04-10 Thread Miaohe Lin
The same VM_BUG_ON() check is already done in the callee. Remove this extra one to simplify the code slightly. Reviewed-by: Mike Kravetz Signed-off-by: Miaohe Lin --- mm/hugetlb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index c22111f3da20..a03a50b7c410 100

[PATCH v2 4/5] mm/hugeltb: handle the error case in hugetlb_fix_reserve_counts()

2021-04-10 Thread Miaohe Lin
A rare out of memory error would prevent removal of the reserve map region for a page. hugetlb_fix_reserve_counts() handles this rare case to avoid dangling with incorrect counts. Unfortunately, hugepage_subpool_get_pages and hugetlb_acct_memory could possibly fail too. We should correctly handle t

[PATCH v2 3/5] mm/hugeltb: clarify (chg - freed) won't go negative in hugetlb_unreserve_pages()

2021-04-10 Thread Miaohe Lin
The resv_map could be NULL since this routine can be called in the evict inode path for all hugetlbfs inodes and we will have chg = 0 in this case. But (chg - freed) won't go negative as Mike pointed out: "If resv_map is NULL, then no hugetlb pages can be allocated/associated with the file. As

Re: [PATCH] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove

2021-04-10 Thread Michal Hocko
On Fri 09-04-21 16:12:59, Mel Gorman wrote: [...] > If anything, the minimal "fix" is to simply delete IRQ disable/enable on > the grounds that IRQs protect nothing and assume the existing hotplug > paths guarantees the PCP cannot be used after zone_pcp_enable(). That > should be the case already b

Re: [PATCH 5.4 00/23] 5.4.111-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:29, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.111 release. > There are 23 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > This patch series removes camelcases, changes the type and use of a > variable, and correct misspelled words. > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files > > drivers/staging/rtl8723bs/core/rtw_cmd.c

Re: [Outreachy kernel] [Resend Patch 0/3] staging: rtl8723bs: Patchset for rtl8723bs

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 06:39:31PM +0200, Fabio M. De Francesco wrote: > This patch series removes camelcase, changes the type and use of a > variable, and correct misspelled words. > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files I've again, dropped all patches from you fr

Re: [PATCH] mm/frontswap: fix frontswap_register_ops() race with swapon and swapoff

2021-04-10 Thread Miaohe Lin
Hi: On 2021/4/5 18:20, Miaohe Lin wrote: > frontswap_register_ops can race with swapon. Consider the following scene: Any comment or suggestion? Or is this race window too theoretical to fix? Thanks. > > CPU1 CPU2 > > fr

[PATCH] preempt/dynamic: fix typo in macro conditional statement

2021-04-10 Thread Zhouyi Zhou
commit 40607ee97e4e ("preempt/dynamic: Provide irqentry_exit_cond_resched() static call") tried to provide irqentry_exit_cond_resched() static call in irqentry_exit, but has a typo in macro conditional statement. This patch fix this typo. Signed-off-by: Zhouyi Zhou --- kernel/entry/common.c |

[PATCH] drm/nouveau/nvkm: Remove unnecessary assignment

2021-04-10 Thread Wan Jiabing
The declaration with assignment here is confusing. Remove the unnecessary assignment. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c b/driver

Re: [PATCH] hrtimer: avoid retrigger_next_event IPI

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 09 2021 at 13:51, Marcelo Tosatti wrote: > On Fri, Apr 09, 2021 at 04:15:13PM +0200, Thomas Gleixner wrote: >> On Wed, Apr 07 2021 at 10:53, Marcelo Tosatti wrote: >> ---> fail because that newly started timer is on the old offset. > > CPU0

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Fabio M. De Francesco
On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote: > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > > This patch series removes camelcases, changes the type and use of a > > variable, and correct misspelled words. > > > > Patch 1/3: staging: rtl8723bs: Remove came

Re: [PATCH v7 clocksource] Do not mark clocks unstable due to delays for v5.13

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:48, Paul E. McKenney wrote: > Hello! > > If there is a sufficient delay between reading the watchdog clock and the > clock under test, the clock under test will be marked unstable through no > fault of its own. This series checks for this, doing limited retries > to get a

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote: > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > > > This patch series removes camelcases, changes the type and use of a > > > variable, an

Re: [PATCH 1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm Memshare service

2021-04-10 Thread Nikita Travkin
Hi, sorry for a late reply but I couldn't answer earlier. 30.03.2021 19:40, Rob Herring пишет: > On Fri, Mar 19, 2021 at 10:23:20PM +0500, nikitos...@gmail.com wrote: >> From: Nikita Travkin >> >> Add DT bindings for memshare: QMI service that allocates >> memory per remote processor request. >>

Re: [PATCH] ARM: pxa: mainstone: avoid -Woverride-init warning

2021-04-10 Thread Robert Jarzmik
Arnd Bergmann writes: > From: Arnd Bergmann > > On Tue, 23 Mar 2021 14:08:27 +0100, Arnd Bergmann wrote: >> The default initializer at the start of the array causes a warning >> when building with W=1: >> >> In file included from arch/arm/mach-pxa/mainstone.c:47: >> arch/arm/mach-pxa/mainstone.

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192e: replace comparison to NULL by boolean

2021-04-10 Thread Julia Lawall
On Sat, 10 Apr 2021, Mitali Borkar wrote: > Replaced comparison to NULL by boolean expressions > (here used boolean negations). This improves readability of code. > Reported by checkpatch. > > Signed-off-by: Mitali Borkar > --- > drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- > 1

Re: [PATCH 04/12] ARM: pxa: stargate2: Constify the software node

2021-04-10 Thread Robert Jarzmik
Wolfram Sang writes: > On Mon, Mar 29, 2021 at 01:50:39PM +0300, Heikki Krogerus wrote: >> Additional device properties are always just a part of a >> software fwnode. If the device properties are constant, the >> software node can also be constant. >> >> Signed-off-by: Heikki Krogerus >> Cc: J

Re: [PATCH 2/2] iommu/amd: Remove performance counter pre-initialization test

2021-04-10 Thread David Coe
Well, well! This is a promising start to the weekend. Thank you both, Suravee and Paul. Results for AMD Ryzen 4 2400G running Ubuntu 21.04β kernel 5.11.0-13 and Windows 10 2H2 under KVM $ sudo dmesg | grep IOMMU [0.557725] pci :00:00.2: AMD-Vi: IOMMU performance counters supported [

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Julia Lawall
On Sat, 10 Apr 2021, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote: > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > > > This patch series removes camelcases, changes the type and use of a > > > variable, and correct misspel

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Julia Lawall
On Sat, 10 Apr 2021, Greg KH wrote: > On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote: > > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote: > > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > > > > This patch series removes camelcases,

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-10 Thread Xiongwei Song
> On Apr 10, 2021, at 12:14 AM, Christophe Leroy > wrote: > > > > Le 08/04/2021 à 16:07, Xiongwei Song a écrit : >> From: Xiongwei Song >> Create a new header named traps.h, define macros to list ppc interrupt >> types in traps.h, replace the reference of the trap hex values with these >> m

Re: [PATCH 0/6] staging: rtl8192e: cleanup patchset for style issues

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 07:04:23AM +0530, Mitali Borkar wrote: > This patches fix the cleanup style issues. > > Mitali Borkar (6): > staging: rtl8192e: add spaces around binary operators > staging: rtl8192e: remove unnecessary blank line before brace > staging: rtl8192e: remove unncessary bl

Re: [PATCH v2 1/1] efi/dev-path-parser: Switch to use for_each_acpi_dev_match()

2021-04-10 Thread Ard Biesheuvel
On Sun, 4 Apr 2021 at 20:12, Andy Shevchenko wrote: > > Switch to use for_each_acpi_dev_match() instead of home grown analogue. > No functional change intended. > > Signed-off-by: Andy Shevchenko > --- > v2: fixed refcounting > (example from which I took the v1 approach has been broken, fix i

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-10 Thread Xiongwei Song
> On Apr 10, 2021, at 8:04 AM, Michael Ellerman wrote: > > Christophe Leroy writes: >> Le 08/04/2021 à 16:07, Xiongwei Song a écrit : >>> From: Xiongwei Song >>> >>> Create a new header named traps.h, define macros to list ppc interrupt >>> types in traps.h, replace the reference of the trap

Re: [PATCH v6 3/6] w1: ds2438: fixed a coding style issue

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 12:15:30AM -0300, Luiz Sampaio wrote: > Changed the permissions to preferred octal style. > > Signed-off-by: Luiz Sampaio > --- > drivers/w1/slaves/w1_ds2438.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/slaves/w1_ds2438.c b/driver

Re: [PATCH v7 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:49, paulmck wrote: > This commit therefore re-reads the watchdog clock on either side of 'This commit' is not any better than 'This patch' and this sentence makes no sense. I might be missing something, but how exactly does "the commit" re-read the watchdog clock? git g

Re: [PATCH] tty: n_gsm: check error while registering tty devices

2021-04-10 Thread Greg KH
On Wed, Apr 07, 2021 at 04:21:30PM +0800, Hillf Danton wrote: > On Wed, 7 Apr 2021 07:37:53 Jiri Slaby wrote: > > > >Yes, the fix makes sense. > > Thanks for taking a look. > > >But could you elaborate in the commit log when this happens? > >I only wonder how real this is. I assume you inject fau

Re: [PATCH] perf session: Dump PERF_RECORD_TIME_CONV event

2021-04-10 Thread Adrian Hunter
On 10/04/21 6:19 am, Leo Yan wrote: > Now perf tool uses the common stub function process_event_op2_stub() for > dumping TIME_CONV event, thus it doesn't output the clock parameters > contained in the event. > > This patch adds the callback function for dumping the hardware clock > parameters in T

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-10 Thread Sergei Shtylyov
On 10.04.2021 2:38, angkery wrote: On Fri, 9 Apr 2021 20:02:56 +0300 Sergei Shtylyov wrote: On 4/9/21 7:49 PM, Sergei Shtylyov wrote: From: Junlin Yang The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int

Re: [PATCH v1] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-10 Thread Sergei Shtylyov
On 10.04.2021 2:42, angkery wrote: From: Junlin Yang The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irq', so making 'irq' an int, and change the position to keep the code format. Fixes coccich

Re: Bogus struct page layout on 32-bit

2021-04-10 Thread Ilias Apalodimas
+CC Grygorii for the cpsw part as Ivan's email is not valid anymore Thanks for catching this. Interesting indeed... On Sat, 10 Apr 2021 at 09:22, Jesper Dangaard Brouer wrote: > > On Sat, 10 Apr 2021 03:43:13 +0100 > Matthew Wilcox wrote: > > > On Sat, Apr 10, 2021 at 06:45:35AM +0800, kernel t

Re: [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space interface

2021-04-10 Thread Greg KH
On Thu, Apr 08, 2021 at 01:48:48PM +, SeongJae Park wrote: > +static int dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx) > +{ > + const char * const file_names[] = {"attrs", "target_ids"}; > + const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops}; > +

Re: [PATCH v2] of: property: fw_devlink: do not link ".*,nr-gpios"

2021-04-10 Thread Greg Kroah-Hartman
On Tue, Apr 06, 2021 at 06:24:21PM -0700, Saravana Kannan wrote: > On Tue, Apr 6, 2021 at 6:10 PM Rob Herring wrote: > > > > On Tue, Apr 6, 2021 at 7:46 PM Saravana Kannan wrote: > > > > > > On Tue, Apr 6, 2021 at 5:34 PM Rob Herring wrote: > > > > > > > > On Tue, Apr 06, 2021 at 04:09:10PM -070

Re: [PATCH v17 2/2] ufs: sysfs: Resume the proper scsi device

2021-04-10 Thread Adrian Hunter
On 8/04/21 5:49 pm, Asutosh Das wrote: > Resumes the actual scsi device the unit descriptor of which > is being accessed instead of the hba alone. > > Reviewed-by: Can Guo > Signed-off-by: Asutosh Das > --- > drivers/scsi/ufs/ufs-sysfs.c | 30 +- > 1 file changed, 17

Re: [PATCH -next] char: xilinx_hwicap: use DEFINE_MUTEX() for mutex lock

2021-04-10 Thread Greg Kroah-Hartman
On Fri, Apr 09, 2021 at 05:51:36PM +0800, Ye Bin wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Reported-by: Hulk Robot > Signed-off-by: Ye Bin > --- > drivers/char/xilinx_hwicap/xilinx_hwicap.c | 3 +-- > 1 file chang

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:49, paulmck wrote: > > +static void clocksource_verify_percpu_wq(struct work_struct *unused) > +{ > + int cpu; > + struct clocksource *cs; > + int64_t cs_nsec; > + u64 csnow_begin; > + u64 csnow_end; > + u64 delta; Please use reverse fir tree order

Re: [PATCH v3 1/2] dw-xdata-pcie: Fix documentation build warns and update outdated info

2021-04-10 Thread Greg Kroah-Hartman
On Wed, Apr 07, 2021 at 10:31:48PM +0200, Gustavo Pimentel wrote: > Fixes documentation build warnings related to indentation and text > formatting, such as: > > Documentation/misc-devices/dw-xdata-pcie.rst:20: WARNING: Unexpected > indentation. > Documentation/misc-devices/dw-xdata-pcie.rst:24: W

Re: [PATCH v7 clocksource 5/5] clocksource: Do pairwise clock-desynchronization checking

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:49, paulmck wrote: > From: "Paul E. McKenney" > > Although smp_call_function() has the advantage of simplicity, using > it to check for cross-CPU clock desynchronization means that any CPU > being slow reduces the sensitivity of the checking across all CPUs. > And it is n

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Bartosz Golaszewski
On Sat, Apr 10, 2021 at 2:46 AM Marek Vasut wrote: > > On 3/15/21 6:04 PM, Andy Shevchenko wrote: > > On Mon, Mar 15, 2021 at 6:49 PM Bartosz Golaszewski > > wrote: > >> > >> On Mon, Mar 15, 2021 at 3:34 PM Andy Shevchenko > >> wrote: > >>> > >>> On Mon, Mar 15, 2021 at 03:04:37PM +0100, Bartosz

Re: [PATCH 4.19 00/18] 4.19.186-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:27, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.186 release. > There are 18 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

[PATCH stable] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Bartosz Golaszewski
From: Andy Shevchenko On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, see arch/arm/boot/dts/stm32mp151.dtsi. The driver for pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c and iterates over all of its DT subnodes when registering each GPIO bank gpiochip. E

[PATCH v5 00/16] Clean up "mediatek,larb"

2021-04-10 Thread Yong Wu
MediaTek IOMMU block diagram always like below: M4U | smi-common | - | | ... | | larb1 larb2 | | vdec venc All the consumer connect with smi-larb, then connect with smi-common. When the consumer works, it should

[PATCH v5 01/16] dt-binding: mediatek: Get rid of mediatek,larb for multimedia HW

2021-04-10 Thread Yong Wu
After adding device_link between the consumer with the smi-larbs, if the consumer call its owner pm_runtime_get(_sync), the pm_runtime_get(_sync) of smi-larb and smi-common will be called automatically. Thus, the consumer don't need the property. And IOMMU also know which larb this consumer connec

[PATCH v5 02/16] iommu/mediatek: Add probe_defer for smi-larb

2021-04-10 Thread Yong Wu
The iommu consumer should use device_link to connect with the smi-larb(supplier). then the smi-larb should run before the iommu consumer. Here we delay the iommu driver until the smi driver is ready, then all the iommu consumer always is after the smi driver. When there is no this patch, if some c

[PATCH v5 03/16] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-04-10 Thread Yong Wu
MediaTek IOMMU-SMI diagram is like below. all the consumer connect with smi-larb, then connect with smi-common. M4U | smi-common | - | |... | | larb1 larb2 | | vdec venc When the consumer works, it should enab

[PATCH v5 04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common

2021-04-10 Thread Yong Wu
Normally, If the smi-larb HW need work, we should enable the smi-common HW power and clock firstly. This patch adds device-link between the smi-larb dev and the smi-common dev. then If pm_runtime_get_sync(smi-larb-dev), the pm_runtime_get_sync (smi-common-dev) will be called automatically. Also, A

[PATCH v5 05/16] media: mtk-jpeg: Use pm_runtime_resume_and_get for PM get_sync

2021-04-10 Thread Yong Wu
pm_runtime_get_sync will increment pm usage counter even it failed. This patch use pm_runtime_resume_and_get instead of pm_runtime_get to keep usage counter balanced. CC: Xia Jiang Signed-off-by: Yong Wu --- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- 1 file changed, 2 insertions(

[PATCH v5 06/16] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put

2021-04-10 Thread Yong Wu
MediaTek IOMMU has already added device_link between the consumer and smi-larb device. If the jpg device call the pm_runtime_get_sync, the smi-larb's pm_runtime_get_sync also be called automatically. CC: Rick Chang CC: Xia Jiang Signed-off-by: Yong Wu Reviewed-by: Evan Green Acked-by: Rick Cha

[PATCH v5 07/16] media: mtk-mdp: Use pm_runtime_resume_and_get for PM get_sync

2021-04-10 Thread Yong Wu
pm_runtime_get_sync will increment pm usage counter even it failed. This patch use pm_runtime_resume_and_get instead of pm_runtime_get to keep usage counter balanced. Signed-off-by: Yong Wu --- drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v5 08/16] media: mtk-mdp: Get rid of mtk_smi_larb_get/put

2021-04-10 Thread Yong Wu
MediaTek IOMMU has already added the device_link between the consumer and smi-larb device. If the mdp device call the pm_runtime_get_sync, the smi-larb's pm_runtime_get_sync also be called automatically. CC: Minghsiu Tsai CC: Houlong Wei Signed-off-by: Yong Wu Reviewed-by: Evan Green --- driv

[PATCH v5 10/16] drm/mediatek: Add pm runtime support for ovl and rdma

2021-04-10 Thread Yong Wu
From: Yongqiang Niu Display use the dispsys device to call pm_rumtime_get_sync before. This patch add pm_runtime_xx with ovl and rdma device whose nodes has "iommus" property, then display could help pm_runtime_get for smi via ovl or rdma device. This is a preparing patch that smi cleaning up "m

[PATCH v5 09/16] drm/mediatek: Use pm_runtime_resume_and_get for PM get_sync

2021-04-10 Thread Yong Wu
pm_runtime_get_sync will increment pm usage counter even it failed. This patch use pm_runtime_resume_and_get instead of pm_runtime_get to keep usage counter balanced. Signed-off-by: Yong Wu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH v5 11/16] drm/mediatek: Get rid of mtk_smi_larb_get/put

2021-04-10 Thread Yong Wu
MediaTek IOMMU has already added the device_link between the consumer and smi-larb device. If the drm device call the pm_runtime_get_sync, the smi-larb's pm_runtime_get_sync also be called automatically. CC: CK Hu CC: Philipp Zabel Signed-off-by: Yong Wu Reviewed-by: Evan Green Acked-by: Chun-

Re: [PATCH v2] kconfig: nconf: stop endless search-up loops

2021-04-10 Thread Masahiro Yamada
On Sat, Apr 10, 2021 at 4:00 PM Mihai Moldovan wrote: > > * On 4/10/21 7:47 AM, Masahiro Yamada wrote: > > On Sun, Mar 28, 2021 at 6:52 PM Mihai Moldovan wrote: > >> + if ((index == -1) && (index == match_start)) > >> + return -1; > > > > We know 'index' is -1

[PATCH v5 12/16] media: mtk-vcodec: Use pm_runtime_resume_and_get for PM get_sync

2021-04-10 Thread Yong Wu
pm_runtime_get_sync will increment pm usage counter even it failed. This patch use pm_runtime_resume_and_get instead of pm_runtime_get_sync to keep usage counter balanced. Signed-off-by: Yong Wu --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 5 +++-- 1 file changed, 3 insertions(+),

[PATCH v5 13/16] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put

2021-04-10 Thread Yong Wu
MediaTek IOMMU has already added the device_link between the consumer and smi-larb device. If the vcodec device call the pm_runtime_get_sync, the smi-larb's pm_runtime_get_sync also be called automatically. CC: Tiffany Lin CC: Irui Wang Signed-off-by: Yong Wu Reviewed-by: Evan Green Acked-by:

[PATCH v5 15/16] arm: dts: mediatek: Get rid of mediatek,larb for MM nodes

2021-04-10 Thread Yong Wu
After adding device_link between the IOMMU consumer and smi, the mediatek,larb is unnecessary now. CC: Matthias Brugger Signed-off-by: Yong Wu Reviewed-by: Evan Green --- arch/arm/boot/dts/mt2701.dtsi | 2 -- arch/arm/boot/dts/mt7623n.dtsi | 5 - 2 files changed, 7 deletions(-) diff --gi

[PATCH v5 14/16] memory: mtk-smi: Get rid of mtk_smi_larb_get/put

2021-04-10 Thread Yong Wu
After adding device_link between the iommu consumer and smi-larb, the pm_runtime_get(_sync) of smi-larb and smi-common will be called automatically. we can get rid of mtk_smi_larb_get/put. CC: Matthias Brugger Signed-off-by: Yong Wu Reviewed-by: Evan Green --- drivers/memory/mtk-smi.c | 14 -

[PATCH v5 16/16] arm64: dts: mediatek: Get rid of mediatek,larb for MM nodes

2021-04-10 Thread Yong Wu
After adding device_link between the IOMMU consumer and smi, the mediatek,larb is unnecessary now. CC: Matthias Brugger Signed-off-by: Yong Wu Reviewed-by: Evan Green --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 - 2 file

Re: [PATCH stable] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Greg Kroah-Hartman
On Sat, Apr 10, 2021 at 11:09:19AM +0200, Bartosz Golaszewski wrote: > From: Andy Shevchenko > > On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, > see arch/arm/boot/dts/stm32mp151.dtsi. The driver for > pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c > and

Re: [PATCH 4.14 00/14] 4.14.230-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:27, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.230 release. > There are 14 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

Re: [PATCH v1 00/14] Multigenerational LRU

2021-04-10 Thread Yu Zhao
On Tue, Mar 16, 2021 at 02:14:43PM -0700, Dave Hansen wrote: > On 3/16/21 1:30 PM, Yu Zhao wrote: > > On Tue, Mar 16, 2021 at 07:50:23AM -0700, Dave Hansen wrote: > >> I think it would also be very worthwhile to include some research in > >> this series about why the kernel moved away from page tab

Re: [PATCH 4.14 00/14] 4.14.230-rc1 review

2021-04-10 Thread Naresh Kamboju
On Sat, 10 Apr 2021 at 01:43, Guenter Roeck wrote: > > On Fri, Apr 09, 2021 at 11:53:25AM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.230 release. > > There are 14 patches in this series, all will be posted as a response > > to this one. If anyon

Re: [PATCH 4.4 00/28] 4.4.265-rc1 review

2021-04-10 Thread Greg Kroah-Hartman
On Mon, Apr 05, 2021 at 06:30:05PM -0600, Shuah Khan wrote: > On 4/5/21 2:53 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.4.265 release. > > There are 28 patches in this series, all will be posted as a response > > to this one. If anyone has any issues w

[Outreachy kernel] [PATCH 0/4] staging: rtl8723bs: Change several files of the driver

2021-04-10 Thread Fabio M. De Francesco
Remove camelcase, correct misspelled words in comments, remove an unused variable, change type and use of another variable. These changes affect files in different subdirectories of this driver. Fabio M. De Francesco (4): staging: rtl8723bs: Remove camelcase in several files staging: rtl8723b

Re: [PATCH 4.4 00/28] 4.4.265-rc1 review

2021-04-10 Thread Greg Kroah-Hartman
On Tue, Apr 06, 2021 at 01:18:27PM +0530, Naresh Kamboju wrote: > On Mon, 5 Apr 2021 at 14:26, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 4.4.265 release. > > There are 28 patches in this series, all will be posted as a response > > to this one. If an

[Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files

2021-04-10 Thread Fabio M. De Francesco
Remove camelcase in bFwCurrentInPSMode, a variable used by code of several subdirectories/files of the driver. Issue detected by checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from the beginning of the name. Signed-off-by: Fabio M. De Francesco --- Changes from v6: Edit again

[Outreachy kernel] [PATCH 2/4] staging: rtl8723bs: include: Fix misspelled words in comments

2021-04-10 Thread Fabio M. De Francesco
Correct misspelled words in comments of several files. Issue (largely) detected by checkpatch.pl. Signed-off-by: Fabio M. De Francesco --- Changes from v1: Substitute "mispelled" with "misspelled" in the Subject. .../rtl8723bs/include/Hal8192CPhyReg.h| 8 ++--- .../staging/rtl8723bs/i

[Outreachy kernel] [PATCH 3/4] staging: rtl8723bs: core: Remove an unused variable

2021-04-10 Thread Fabio M. De Francesco
Delete local variable "u8 sec_idx" because it is declared and initialised, but never used. Signed-off-by: Fabio M. De Francesco --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c

[Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Fabio M. De Francesco
Change the type of fw_current_in_ps_mode from u8 to bool, because it is used everywhere as a bool and, accordingly, it should be declared as a bool. Shorten the controlling expression of an 'if' statement. Signed-off-by: Fabio M. De Francesco --- drivers/staging/rtl8723bs/hal/hal_intf.c|

Re: [RFC 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked

2021-04-10 Thread Thomas Gleixner
On Tue, Mar 30 2021 at 16:25, Feng Tang wrote: > Normally the tsc_sync will be checked every time system enters idle state, > but there is still caveat that a system won't enter idle, either because > it's too busy or configured purposely to not enter idle. Setup a periodic > timer to make sure the

[tip: x86/core] x86/cpu: Comment Skylake server stepping too

2021-04-10 Thread tip-bot2 for Andrew Cooper
The following commit has been merged into the x86/core branch of tip: Commit-ID: 99cb64de36d5c9397a664808b92943e35bdce25e Gitweb: https://git.kernel.org/tip/99cb64de36d5c9397a664808b92943e35bdce25e Author:Andrew Cooper AuthorDate:Fri, 09 Apr 2021 13:10:27 +01:00 Committer:

Re: [PATCH v24 04/30] x86/cpufeatures: Introduce X86_FEATURE_CET and setup functions

2021-04-10 Thread Borislav Petkov
On Fri, Apr 09, 2021 at 04:14:09PM -0700, Yu, Yu-cheng wrote: > > @@ -53,6 +55,8 @@ static short xsave_cpuid_features[] __initdata = { > > X86_FEATURE_INTEL_PT, > > X86_FEATURE_PKU, > > X86_FEATURE_ENQCMD, > > + X86_FEATURE_CET, /* XFEATURE_CET_USER */ > > + X86_FEATURE_CET, /* XFEA

Re: [PATCH] arch/x86: Encourage rather than discourage x2apic support

2021-04-10 Thread Thomas Gleixner
On Wed, Mar 31 2021 at 05:16, Luke Dashjr wrote: > Multi-core SMP doesn't work on modern Intel CPUs (at least Comet Lake) without > x2apic. Unsure users should say Y. I'd rather make it explicit by also adding default y Thanks, tglx

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote: > Change the type of fw_current_in_ps_mode from u8 to bool, because > it is used everywhere as a bool and, accordingly, it should be > declared as a bool. Shorten the controlling > expression of an 'if' statement. > > Signed-of

Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > Remove camelcase in bFwCurrentInPSMode, a variable used by code > of several subdirectories/files of the driver. Issue detected by > checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from > the beginning of th

Re: [PATCH v4] powerpc/traps: Enhance readability for trap types

2021-04-10 Thread Xiongwei Song
> On Apr 10, 2021, at 8:35 AM, Nicholas Piggin wrote: > > Thanks for working on this, I think it's a nice cleanup and helps > non-powerpc people understand the code a bit better. > My pleasure. > Excerpts from Xiongwei Song's message of April 10, 2021 12:28 am: >> From: Xiongwei Song >> >>

Re: [PATCH 4.4 00/20] 4.4.266-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:25, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.4.266 release. > There are 20 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-10 Thread Christophe Leroy
Le 10/04/2021 à 02:04, Michael Ellerman a écrit : Christophe Leroy writes: Le 08/04/2021 à 16:07, Xiongwei Song a écrit : From: Xiongwei Song Create a new header named traps.h, define macros to list ppc interrupt types in traps.h, replace the reference of the trap hex values with these ma

Re: [PATCH 4.9 00/13] 4.9.266-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:26, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.266 release. > There are 13 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files

2021-04-10 Thread Fabio M. De Francesco
On Saturday, April 10, 2021 11:32:00 AM CEST Greg KH wrote: > On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > > Remove camelcase in bFwCurrentInPSMode, a variable used by code > > of several subdirectories/files of the driver. Issue detected by > > checkpatch.pl. Delete the

Re: [RFC 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked

2021-04-10 Thread Borislav Petkov
On Sat, Apr 10, 2021 at 11:27:11AM +0200, Thomas Gleixner wrote: > On Tue, Mar 30 2021 at 16:25, Feng Tang wrote: > > Normally the tsc_sync will be checked every time system enters idle state, > > but there is still caveat that a system won't enter idle, either because > > it's too busy or configur

[PATCH 0/3] crypto: hisilicon/hpre - add debug log

2021-04-10 Thread Hui Tang
This patchset adds the debug log and cleanup code style. Hui Tang (3): crypto: hisilicon/hpre - delete the rudundant space after return crypto: hisilicon/hpre - use the correct variable type crypto: hisilicon/hpre - add debug log drivers/crypto/hisilicon/hpre/hpre_crypto.c | 11 +--

[PATCH 1/3] crypto: hisilicon/hpre - delete the rudundant space after return

2021-04-10 Thread Hui Tang
There are two spaces after return, just keep one. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 2 +- drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/dr

[PATCH 2/3] crypto: hisilicon/hpre - use the correct variable type

2021-04-10 Thread Hui Tang
The return value of 'le32_to_cpu' is unsigned, so change the variable type from 'int' to 'unsigned int'. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/dr

[PATCH 3/3] crypto: hisilicon/hpre - add debug log

2021-04-10 Thread Hui Tang
When the received sqe is abnormal, the error message in the sqe written back by the hardware is printed to help to analyze the abnormal causes. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH] net: core: sk_buff: zero-fill skb->data in __alloc_skb function

2021-04-10 Thread Phillip Potter
Zero-fill skb->data in __alloc_skb function of net/core/skbuff.c, up to start of struct skb_shared_info bytes. Fixes a KMSAN-found uninit-value bug reported by syzbot at: https://syzkaller.appspot.com/bug?id=abe95dc3e3e9667fc23b8d81f29ecad95c6f106f Reported-by: syzbot+2e406a9ac75bb71d4...@syzkalle

[PATCH] crypto: hisilicon/hpre - fix unmapping invalid dma address

2021-04-10 Thread Hui Tang
Currently, an invalid dma address may be unmapped when calling 'xx_data_clr_all' in error path, so check dma address of sqe in/out whether it has been mapped before calling 'dma_free_coherent' or 'dma_unmap_single'. An abnormal case is as follows: hpre_curve25519_compute_value -> hpre_curv

[PATCH v3] crypto: hisilicon/hpre - delete redundant log and return in advance

2021-04-10 Thread Hui Tang
'hpre_cfg_by_dsm' has checked and printed error path internally. It is not necessary to do it here, so remove it. It should return error immediately when return value of 'hpre_cfg_by_dsm' is non-zero, and no need to execute the remaining sentences. Signed-off-by: Hui Tang --- v1 -> v2: - Ret

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Fabio M. De Francesco
On Saturday, April 10, 2021 11:31:16 AM CEST Greg KH wrote: > On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote: > > Change the type of fw_current_in_ps_mode from u8 to bool, because > > it is used everywhere as a bool and, accordingly, it should be > > declared as a bool. Short

Cant resume from sleep on 5.12-rcx regression?

2021-04-10 Thread Malte Deiseroth
Hey guys. I think, maybe I found a regression in 5.12. TLDK: Screen stays black after resume from sleep on kernel 5.12-rcx but not on 5.11.12 I compiler a 5.11.12 and a 5.12-rc6 Kernel on my  Ubuntu 20.10 T480 Laptop. With the 5.11.12 kernel I can safely boot and put the laptop into sleep

  1   2   3   4   5   >