[PATCH] net: openvswitch: Use 'skb_push_rcsum()' instead of hand coding it

2021-04-04 Thread Christophe JAILLET
'skb_push()'/'skb_postpush_rcsum()' can be replaced by an equivalent 'skb_push_rcsum()' which is less verbose. Signed-off-by: Christophe JAILLET --- net/openvswitch/conntrack.c| 6 ++ net/openvswitch/vport-netdev.c | 7 +++ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git

[PATCH] habanalabs: support DEVICE_UNUSABLE error indication from FW

2021-04-04 Thread Oded Gabbay
From: Koby Elbaz In case of multiple ECC errors, FW will set the DEVICE_UNUSABLE bit. On boot-up, the driver will therefore fail inserting the device. Signed-off-by: Koby Elbaz Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/firmware_if.c| 3 +++

/usr/bin/ld: sock_diag.c:undefined reference to `atomic64_dec_return_386'

2021-04-04 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 2023a53bdf41b7646b1d384b6816af06309f73a5 commit: 92acdc58ab11af66fcaef485433fde61b5e32fac bpf, net: Rework cookie generator as per-cpu one date: 6 months ago config: um-randconfig-r016-20210404 (attached

Re: [RFC v2 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-04-04 Thread Pratik Sampat
Hello Doug, Thanks for your review. On 02/04/21 4:57 am, Doug Smythies wrote: Hi Pratik, On Thu, Apr 1, 2021 at 4:45 AM Pratik Rajesh Sampat wrote: ... To run this test specifically: $ make -C tools/testing/selftests TARGETS="cpuidle" run_tests I have not become any smarter than I was with

Re: [PATCH] PCI: merge slot and bus reset implementations

2021-04-04 Thread Leon Romanovsky
On Thu, Apr 01, 2021 at 10:56:16AM -0600, Alex Williamson wrote: > On Thu, 1 Apr 2021 15:27:37 +0300 > Leon Romanovsky wrote: > > > On Thu, Apr 01, 2021 at 05:37:16AM +, Raphael Norwitz wrote: > > > Slot resets are bus resets with additional logic to prevent a device > > > from being removed

Re: [syzbot] possible deadlock in ovl_maybe_copy_up

2021-04-04 Thread Amir Goldstein
On Sat, Apr 3, 2021 at 10:18 PM syzbot wrote: > > syzbot has found a reproducer for the following issue on: > > HEAD commit:454c576c Add linux-next specific files for 20210401 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1616e07ed0 > kernel confi

[PATCH v6 0/2] hardware-privacy-implementation-for-dell-laptop

2021-04-04 Thread Perry Yuan
From: Perry Yuan Hi All, This patch set is a new driver for Dell mobile platform that has the hardware privacy feature including micmute,camera mute. For micmute led control, the hotkey is Fn + F4, it is a hardware based mute state, and new privacy will prevent micphone void input from hardware

[PATCH v6 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-04-04 Thread Perry Yuan
From: Perry Yuan add support for Dell privacy driver for the Dell units equipped hardware privacy design, which protect users privacy of audio and camera from hardware level. Once the audio or camera privacy mode activated, any applications will not get any audio or video stream when user pressed

[PATCH v6 2/2] ASoC: rt715:add micmute led state control supports

2021-04-04 Thread Perry Yuan
From: Perry Yuan Some new Dell system is going to support audio internal micphone privacy setting from hardware level with micmute led state changing When micmute hotkey pressed by user, soft mute will need to be enabled firstly in case of pop noise, and codec driver need to react to mic mute eve

[RFC v3 0/2] CPU-Idle latency selftest framework

2021-04-04 Thread Pratik Rajesh Sampat
Changelog RFC v2-->v3 Based on comments by Doug Smythies, 1. Changed commit log to reflect the test must be run as super user. 2. Added a comment specifying a method to run the test bash script without recompiling. 3. Enable all the idle states after the experiments are completed so that the syste

[RFC v3 1/2] cpuidle: Extract IPI based and timer based wakeup latency from idle states

2021-04-04 Thread Pratik Rajesh Sampat
Introduce a mechanism to fire directed IPIs from a specified source CPU to a specified target CPU and measure the difference in time incurred on wakeup. Also, introduce a mechanism to queue a HR timer on a specified CPU and subsequently measure the time taken to wakeup the CPU. Finally define a s

[RFC v3 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-04-04 Thread Pratik Rajesh Sampat
The cpuidle latency selftest provides support to systematically extract, analyse and present IPI and timer based wakeup latencies for each CPU and each idle state available on the system. The selftest leverages test-cpuidle_latency module's debugfs interface to interact and extract latency informa

Re: [PATCH v6] RISC-V: enable XIP

2021-04-04 Thread Vitaly Wool
On Sat, Apr 3, 2021 at 12:00 PM Alex Ghiti wrote: > > Hi Vitaly, > > Le 4/1/21 à 7:10 AM, Alex Ghiti a écrit : > > Le 4/1/21 à 4:52 AM, Vitaly Wool a écrit : > >> Hi Alex, > >> > >> On Thu, Apr 1, 2021 at 10:11 AM Alex Ghiti wrote: > >>> > >>> Hi, > >>> > >>> Le 3/30/21 à 4:04 PM, Alex Ghiti a éc

[PATCH] drm/i915/sysfs: convert snprintf to sysfs_emit

2021-04-04 Thread Carlis
From: Xuezhi Zhang Fix the following coccicheck warning: drivers/gpu/drm/i915//i915_sysfs.c:266:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/i915//i915_sysfs.c:285:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/i915//i915_sysfs.c:276:8-16: WARNING: use scnprintf or sprintf

Re: [PATCH] net: openvswitch: Use 'skb_push_rcsum()' instead of hand coding it

2021-04-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 4 Apr 2021 09:11:03 +0200 you wrote: > 'skb_push()'/'skb_postpush_rcsum()' can be replaced by an equivalent > 'skb_push_rcsum()' which is less verbose. > > Signed-off-by: Christophe JAILLET > --- > net/openvswit

vdpa.c:undefined reference to `atomic64_add_386'

2021-04-04 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 2023a53bdf41b7646b1d384b6816af06309f73a5 commit: ad89653f79f1882d55d9df76c9b2b94f008c4e27 vhost-vdpa: fix page pinning leakage in error path (rework) date: 4 months ago config: um-randconfig-r016-20210404

[PATCH] ibmvnic: Use 'skb_frag_address()' instead of hand coding it

2021-04-04 Thread Christophe JAILLET
'page_address(skb_frag_page()) + skb_frag_off()' can be replaced by an equivalent 'skb_frag_address()' which is less verbose. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/ibm/ibmvnic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ibm

[BUG]: usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-04-04 Thread H. Nikolaus Schaller
it seems as if the patch 9de47c37 ("usb: dwc3: gadget: Prevent EP queuing while stopping transfers") in v5.11.y f09ddcfcb8c5 ("usb: dwc3: gadget: Prevent EP queuing while stopping transfers") in v5.12-rc5 reproducible breaks dwc3 RNDIS gadget, at least on the Pyra Handheld (

[PATCH] sfc: Use 'skb_add_rx_frag()' instead of hand coding it

2021-04-04 Thread Christophe JAILLET
Some lines of code can be merged into an equivalent 'skb_add_rx_frag()' call which is less verbose. Signed-off-by: Christophe JAILLET --- UNTESTED. Compile tested only The 'skb->truesize' computation is likely to be slightly slower (n additions hidden in 'skb_add_rx_frag' instead of 1 multiplica

Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: replace goto with direct return

2021-04-04 Thread Julia Lawall
On Sat, 3 Apr 2021, Deborah Brouwer wrote: > To conform with Linux kernel coding style, replace goto statement that > does no cleanup with a direct return. To preserve meaning, copy comments > from the original goto statement to the return statement. Identified by > the checkpatch warning: WA

Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: core: add comma within a comment

2021-04-04 Thread Julia Lawall
On Sat, 3 Apr 2021, Deborah Brouwer wrote: > On Sat, Apr 03, 2021 at 11:16:16PM +0200, Julia Lawall wrote: > > > > > > On Sat, 3 Apr 2021, Deborah Brouwer wrote: > > > > > Add a comma to separate repeated words in a comment. The comma preserves > > > the meaning of the comment while also stoppi

Re: [PATCH] staging: rtl8188eu: replace goto with direct return

2021-04-04 Thread Greg KH
On Sat, Apr 03, 2021 at 10:40:08PM -0700, Deborah Brouwer wrote: > To conform with Linux kernel coding style, replace goto statement that > does no cleanup with a direct return. To preserve meaning, copy comments > from the original goto statement to the return statement. Identified by > the chec

Re: [PATCH 0/7] staging: media: zoran: Eliminate camelcase

2021-04-04 Thread Greg KH
On Sun, Apr 04, 2021 at 12:08:57AM +0600, Zhansaya Bagdauletkyzy wrote: > This patchset fixes 'avoid camelcase' warning by converting local variables > to lowercase and separating words using '_'. > Renaming of each variable is implemented in separate patches. > > Zhansaya Bagdauletkyzy (7): >

Re: [PATCH 2/2] staging:r8188eu: remove dummy handlers from OnAction()

2021-04-04 Thread Greg Kroah-Hartman
On Sun, Apr 04, 2021 at 12:30:41AM +0300, Ivan Safonov wrote: > On 4/2/21 4:04 PM, Greg Kroah-Hartman wrote: > > On Sun, Mar 28, 2021 at 07:33:25PM +0300, Ivan Safonov wrote: > > > on_action_spct() do nothing, because rtw_get_stainfo() has no side > > > effects. Other action handlers are trivial. >

Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements coding style issue.

2021-04-04 Thread Greg KH
On Sun, Apr 04, 2021 at 08:15:00AM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Signed-off-by: Dmitrii Wolf > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Hi, This is the friendly patch-bot of Greg K

Re: [BUG]: usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-04-04 Thread Greg KH
On Sun, Apr 04, 2021 at 11:29:00AM +0200, H. Nikolaus Schaller wrote: > it seems as if the patch > > 9de47c37 ("usb: dwc3: gadget: Prevent EP queuing while stopping > transfers") in v5.11.y > f09ddcfcb8c5 ("usb: dwc3: gadget: Prevent EP queuing while stopping > transfers") in v5.

Re: [PATCH] debugfs: Fix use-after-free in debugfs_create_devm_seqfile()

2021-04-04 Thread Greg Kroah-Hartman
On Sat, Apr 03, 2021 at 07:45:04PM -0500, Samuel Holland wrote: > This function uses devres to clean up its allocation, but it never removes the > file referencing that allocation. This causes a use-after-free and an oops if > the file is accessed after the owning device is removed. What in-kernel

[PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-04 Thread Joakim Zhang
commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut off PHY power") invokes phy_init_hw() when MDIO bus resume, it will soft reset PHY if PHY driver implements soft_reset callback. commit 764d31cacfe4 ("net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081") adds

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-04 Thread Greg KH
On Sat, Apr 03, 2021 at 06:08:34PM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide support

Something is leaking RCU holds from interrupt context

2021-04-04 Thread Matthew Wilcox
On Sat, Apr 03, 2021 at 09:15:17PM -0700, syzbot wrote: > HEAD commit:2bb25b3a Merge tag 'mips-fixes_5.12_3' of git://git.kernel.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1284cc31d0 > kernel config: https://syzkaller.appspot.com/x/.config?x=78

Re: [PATCH] RDMA/addr: potential uninitialized variable in ib_nl_process_good_ip_rsep()

2021-04-04 Thread Leon Romanovsky
On Fri, Apr 02, 2021 at 02:47:23PM +0300, Dan Carpenter wrote: > The nla_len() is less than or equal to 16. If it's less than 16 then > end of the "gid" buffer is uninitialized. > > Fixes: ae43f8286730 ("IB/core: Add IP to GID netlink offload") > Signed-off-by: Dan Carpenter > --- > I just spott

Re: [PATCH v3] IB/mlx5: Reduce max order of memory allocated for xlt update

2021-04-04 Thread Leon Romanovsky
On Sat, Apr 03, 2021 at 04:53:55AM +, Praveen Kumar Kannoju wrote: > To update xlt (during mlx5_ib_reg_user_mr()), the driver can request up to > 1 MB (order-8) memory, depending on the size of the MR. This costly > allocation can sometimes take very long to return (a few seconds). This > cause

Re: [BUG]: usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-04-04 Thread H. Nikolaus Schaller
> Am 04.04.2021 um 12:01 schrieb Greg KH : > > On Sun, Apr 04, 2021 at 11:29:00AM +0200, H. Nikolaus Schaller wrote: >> it seems as if the patch >> >> 9de47c37 ("usb: dwc3: gadget: Prevent EP queuing while stopping >> transfers") in v5.11.y >> f09ddcfcb8c5 ("usb: dwc3: gadget: Pr

[Outreachy kernel][PATCH] staging: sm750fb: Remove unnecessary blank line

2021-04-04 Thread Zhansaya Bagdauletkyzy
Remove unnecessary extra blank line to improve readability. Reported by checkpatch. Signed-off-by: Zhansaya Bagdauletkyzy --- drivers/staging/sm750fb/sm750.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 1b3f5f649c52..2

Re: [syzbot] WARNING in mntput_no_expire (2)

2021-04-04 Thread Christian Brauner
On Sun, Apr 04, 2021 at 02:34:08AM +, Al Viro wrote: > On Thu, Apr 01, 2021 at 07:11:12PM +, Al Viro wrote: > > > > I _think_ I see what the issue is. It seems that an assumption made in > > > this commit might be wrong and we're missing a mnt_add_count() bump that > > > we would otherwise

Re: [PATCH] kfence: unpoison pool region before use

2021-04-04 Thread Andrey Konovalov
On Sun, Apr 4, 2021 at 1:52 AM Andrey Konovalov wrote: > > On Sun, Apr 4, 2021 at 12:31 AM Marco Elver wrote: > > > > However, given the above, I think we need to explain this in the > > commit message (which also makes the dependency between these 2 > > patches clear) and add a comment above the

Re: [PATCH v3] coccinelle: misc: add swap script

2021-04-04 Thread Julia Lawall
On Sun, 28 Mar 2021, Denis Efremov wrote: > Ping? Applied. Thanks. > > On 3/5/21 1:09 PM, Denis Efremov wrote: > > Check for opencoded swap() implementation. > > > > Signed-off-by: Denis Efremov > > --- > > Changes in v2: > > - additional patch rule to drop excessive {} > > - fix indent

[PATCH 1/2] qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()'

2021-04-04 Thread Christophe JAILLET
This ++ is confusing. It looks duplicated with the one already performed in 'skb_fill_page_desc()'. In fact, it is harmless. 'nr_frags' is written twice with the same value. Once, because of the nr_frags++, and once because of the 'nr_frags = i + 1' in 'skb_fill_page_desc()'. So axe this post-inc

[PATCH 2/2] qede: Use 'skb_add_rx_frag()' instead of hand coding it

2021-04-04 Thread Christophe JAILLET
Some lines of code can be merged into an equivalent 'skb_add_rx_frag()' call which is less verbose. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/qlogic/qede/qede_fp.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp

[PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM

2021-04-04 Thread Dinh Nguyen
From: Krzysztof Kozlowski The Stratix10 service layer and RCU drivers are useful only on Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM fails: drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback': include/linux/compiler_types.h:320:38: error: call to '_

Re: [PATCH net-next v1 1/9] net: dsa: add rcv_post call back

2021-04-04 Thread Vladimir Oltean
On Sun, Apr 04, 2021 at 07:49:03AM +0200, Oleksij Rempel wrote: > Am 04.04.21 um 01:21 schrieb Vladimir Oltean: > > On Sat, Apr 03, 2021 at 05:05:34PM +0300, Vladimir Oltean wrote: > >> On Sat, Apr 03, 2021 at 01:48:40PM +0200, Oleksij Rempel wrote: > >>> Some switches (for example ar9331) do not p

[PATCH v2] thermal/drivers/tsens: fix missing put_device error

2021-04-04 Thread zhuguangqing83
From: Guangqing Zhu Fixes coccicheck error: drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call of_find_device_by_node on line 715, but without a corresponding object release within this function. Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into tsens.

Re: [PATCH net-next v1 2/9] net: dsa: tag_ar9331: detect IGMP and MLD packets

2021-04-04 Thread Vladimir Oltean
On Sun, Apr 04, 2021 at 07:35:26AM +0200, Oleksij Rempel wrote: > Am 04.04.21 um 02:02 schrieb Vladimir Oltean: > > On Sat, Apr 03, 2021 at 07:14:56PM +0200, Oleksij Rempel wrote: > >> Am 03.04.21 um 16:49 schrieb Andrew Lunn: > @@ -31,6 +96,13 @@ static struct sk_buff *ar9331_tag_xmit(struct

[PATCH V3 0/2] Add virtual hardware module

2021-04-04 Thread Sumera Priyadarsini
This patchset adds support for emulating virtual hardware with VKMS. The virtual hardware mode can be enabled by using the following command while loading the module: sudo modprobe vkms enable_virtual_hw=1 The first patch is prep work for adding virtual_hw mode and refactors the plane comp

[PATCH V3 1/2] drm/vkms: Refactor vkms_composer_worker() to prep for virtual_hw mode

2021-04-04 Thread Sumera Priyadarsini
Add two new functions vkms_composer_common() and vkms_crtc_composer(). The actual plane composition work has been moved to the helper function, vkms_composer_common() which is called by both vkms_composer_worker() and vkms_crtc_composer(). vkms_crtc_composer() can be used when we implement virtual_

[PATCH V3 2/2] drm/vkms: Add support for virtual hardware mode

2021-04-04 Thread Sumera Priyadarsini
Add a virtual hardware or vblank-less mode as a module to enable VKMS to emulate virtual graphic drivers. Add a new drm_crtc_helper_funcs struct, vkms_virtual_crtc_helper_funcs() which holds the atomic helpers for virtual hardware mode. Change the existing vkms_crtc_helper_funcs struct to vkms_vbl

Re: [PATCH] RDMA/addr: potential uninitialized variable in ib_nl_process_good_ip_rsep()

2021-04-04 Thread Mark Bloch
On 4/4/21 1:33 PM, Leon Romanovsky wrote: > On Fri, Apr 02, 2021 at 02:47:23PM +0300, Dan Carpenter wrote: >> The nla_len() is less than or equal to 16. If it's less than 16 then >> end of the "gid" buffer is uninitialized. >> >> Fixes: ae43f8286730 ("IB/core: Add IP to GID netlink offload") >> Si

Re: [PATCH] RDMA/addr: potential uninitialized variable in ib_nl_process_good_ip_rsep()

2021-04-04 Thread Leon Romanovsky
On Sun, Apr 04, 2021 at 04:13:17PM +0300, Mark Bloch wrote: > On 4/4/21 1:33 PM, Leon Romanovsky wrote: > > On Fri, Apr 02, 2021 at 02:47:23PM +0300, Dan Carpenter wrote: > >> The nla_len() is less than or equal to 16. If it's less than 16 then > >> end of the "gid" buffer is uninitialized. > >> >

Re: [PATCH v2 5/6] dt-bindings: memory: tegra20: emc: Convert to schema

2021-04-04 Thread Dmitry Osipenko
02.04.2021 17:45, Dmitry Osipenko пишет: > 01.04.2021 18:55, Rob Herring пишет: >> On Wed, Mar 31, 2021 at 05:59:39PM +0300, Dmitry Osipenko wrote: >>> 31.03.2021 16:40, Rob Herring пишет: On Wed, 31 Mar 2021 02:04:44 +0300, Dmitry Osipenko wrote: > Convert Tegra20 External Memory Controll

Re: [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX

2021-04-04 Thread Péter Ujfalusi
Hi Pratyush, On 3/30/21 8:33 PM, Pratyush Yadav wrote: > The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory. It can > have up to 32 threads but the current driver only supports using one. So > add an entry for that one thread. If you are absolutely sure that the other threads are no

[PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements of condition.

2021-04-04 Thread dev . dragon
From: Dmitrii Wolf Fixed a coding style issue. Signed-off-by: Dmitrii Wolf --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/i

Re: [PATCH 13/16] media: ti-vpe: csi2rx: Add CSI2RX support

2021-04-04 Thread Péter Ujfalusi
Hi Pratyush, +1 from me also to the points Tomi raised. few minor comments on the DMAengie side. On 3/30/21 8:33 PM, Pratyush Yadav wrote: > TI's J721E uses the Cadence CSI2RX and DPHY peripherals to facilitate > capture over a CSI-2 bus. > > The Cadence CSI2RX IP acts as a bridge between the T

Re: CFI violation in drivers/infiniband/core/sysfs.c

2021-04-04 Thread Jason Gunthorpe
On Fri, Apr 02, 2021 at 06:29:55PM -0700, Kees Cook wrote: > On Fri, Apr 02, 2021 at 08:30:18PM -0300, Jason Gunthorpe wrote: > > On Fri, Apr 02, 2021 at 04:03:30PM -0700, Kees Cook wrote: > > > > > > relevant. It seems to me that the hw_counters 'struct attribute_group' > > > > should probably be

Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM

2021-04-04 Thread Greg KH
On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote: > From: Krzysztof Kozlowski > > The Stratix10 service layer and RCU drivers are useful only on > Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM > fails: > > drivers/firmware/stratix10-rsu.c: In function 'rsu_st

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-04 Thread Heiner Kallweit
On 04.04.2021 12:07, Joakim Zhang wrote: > commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut > off PHY power") invokes phy_init_hw() when MDIO bus resume, it will > soft reset PHY if PHY driver implements soft_reset callback. > commit 764d31cacfe4 ("net: phy: micrel: set soft_reset

[PATCH v4 02/30] staging: rtl8723bs: fix condition in if statement in core/rtw_xmit.c

2021-04-04 Thread Fabio Aiuto
fix post-commit hook checkpatch issue: CHECK: Using comparison to true is error prone 71: FILE: drivers/staging/rtl8723bs/core/rtw_xmit.c:565: + ((padapter->securitypriv.sw_encrypt == true) || (psecuritypriv->hw_decrypted == false))) Signed-off-by: Fabio Aiuto ---

[PATCH v4 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_xmit.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overrides t

[PATCH v4 03/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_security.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overrid

[PATCH v4 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/*

2021-04-04 Thread Fabio Aiuto
This patchset removes all RT_TRACE usages in core/ files. This is the first of a series aimed at removing RT_TRACE macro. The whole private tracing system is not tied to a configuration symbol and the default behaviour is _trace nothing_. It's verbose and relies on a private log level tracing doo

[PATCH v4 04/30] staging: rtl8723bs: fix line exceed warning in core/rtw_security.c

2021-04-04 Thread Fabio Aiuto
fix the following post-commit hook checkpatch issue: WARNING: line length of 149 exceeds 100 columns 61: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:729: + if (crc[3] != payload[length-1] || crc[2] != payload[length-2] || crc[1] != payload[length-3] ||

[PATCH v4 06/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_eeprom.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overrides

[PATCH v4 05/30] staging: rtl8723bs: fix spaces around operator issues in core/rtw_security.c

2021-04-04 Thread Fabio Aiuto
fix the following post commit hook checkpatch issues: CHECK: spaces preferred around that '-' (ctx:VxV) 25: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:729: + if (crc[3] != payload[length-1] || crc[2] != payload[length-2] ||

[PATCH v4 07/30] staging: rtl8723bs: fix error prone if conditions in core/rtw_eeprom.c

2021-04-04 Thread Fabio Aiuto
fix the following post-commit hook checkpatch issues: CHECK: Using comparison to true is error prone 21: FILE: drivers/staging/rtl8723bs/core/rtw_eeprom.c:38: + if (padapter->bSurpriseRemoved == true) CHECK: Using comparison to true is error prone 36: FILE: drivers/staging/rtl8723bs/core/rt

[PATCH v4 08/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_pwrctrl.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which override

[PATCH v4 09/30] staging: rtl8723bs: fix logical continuation issue in core/rtw_pwrctrl.c

2021-04-04 Thread Fabio Aiuto
fix following post-commit hook checkpatch issue: CHECK: Logical continuations should be on the previous line 22: FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:270: if ((pwrpriv->rpwm == pslv) + || ((pwrpriv->rpwm >= PS_STATE_S2) && (pslv

[PATCH v4 10/30] staging: rtl8723bs: remove unnecessary parentheses in if-condition in core/rtw_pwrctrl.c

2021-04-04 Thread Fabio Aiuto
fix following post-commit hook checkpatch issues: CHECK: Unnecessary parentheses around 'pwrpriv->rpwm == pslv' 26: FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:269: + if ((pwrpriv->rpwm == pslv) || + ((pwrpriv->rpwm >= PS_STATE_S2) && (pslv >= PS_STAT

[PATCH v4 11/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_cmd.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overrides th

[PATCH v4 12/30] staging: rtl8723bs: fix null check conditions in core/rtw_cmd.c

2021-04-04 Thread Fabio Aiuto
fix post-commit hook checkpatch issues: CHECK: Comparison to NULL could be written "!psta" 178: FILE: drivers/staging/rtl8723bs/core/rtw_cmd.c:2012: + if (psta == NULL) CHECK: Comparison to NULL could be written "!psta" 198: FILE: drivers/staging/rtl8723bs/core/rtw_cmd.c:206

[PATCH v4 13/30] staging: rtl8723bs: remove unnecessary parentheses in if condition in core/rtw_cmd.c

2021-04-04 Thread Fabio Aiuto
fix post-commit hook checkpatch issue: WARNING: Unnecessary parentheses 166: FILE: drivers/staging/rtl8723bs/core/rtw_cmd.c:2000: + if ((pcmd->res != H2C_SUCCESS)) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v4 14/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c

2021-04-04 Thread Fabio Aiuto
Remove commented RT_TRACE calls in core/rtw_mlme.c Remove all of the RT_TRACE logs in the core/rtw_mlme.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an

[PATCH v4 15/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_mlme.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overrides t

[PATCH v4 16/30] staging: rtl8723bs: tidy up some error handling in core/rtw_mlme.c

2021-04-04 Thread Fabio Aiuto
the RT_TRACE() output is not useful so we want to delete it. In this case there is no cleanup for rtw_cleanbss_cmd() required or even possible. I've deleted the RT_TRACE() output and added a goto unlock to show that we can't continue if rtw_createbss_cmd() fails. Suggested-by: Dan Carpenter Signe

[PATCH v4 17/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_mlme_ext.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overrid

[PATCH v4 18/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c

2021-04-04 Thread Fabio Aiuto
Remove commented RT_TRACE calls Remove all of the RT_TRACE logs in the core/rtw_recv.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private lo

[PATCH v4 19/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_recv.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_recv.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overrides t

[PATCH v4 20/30] staging: rtl8723bs: added spaces around operator in core/rtw_recv.c

2021-04-04 Thread Fabio Aiuto
fix post-commit hook checkpatch issue: CHECK: spaces preferred around that '+' (ctx:VxV) 60: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:359: + if (miccode[i] != *(pframemic+i)) ^ Signed-off-by: Fabio A

[PATCH v4 23/30] staging: rtl8723bs: fix comparison in if condition in core/rtw_recv.c

2021-04-04 Thread Fabio Aiuto
fix post-commit checkpatch issue: CHECK: Using comparison to false is error prone 27: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381: + if (psecuritypriv-> bcheck_grpkey == false && and fix the same issue in second comparison to true insi

[PATCH v4 22/30] staging: rtl8723bs: remove unnecessary parentheses in core/rtw_recv.c

2021-04-04 Thread Fabio Aiuto
fix post-commit checkpatch issue: CHECK: Unnecessary parentheses around 'psecuritypriv->bcheck_grpkey == false' 24: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381: + if ((psecuritypriv-> bcheck_grpkey == false) && +

[PATCH v4 21/30] staging: rtl8723bs: split long line in core/rtw_recv.c

2021-04-04 Thread Fabio Aiuto
fix post-commit hook checkpatch issue: WARNING: line length of 113 exceeds 100 columns 110: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381: + if ((psecuritypriv->bcheck_grpkey == false) && (IS_MCAST(prxattrib->ra) == true)) Signed-off-by: Fabio Aiuto -

[PATCH v4 25/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ioctl_set.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_ioctl_set.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overri

[PATCH v4 24/30] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c

2021-04-04 Thread Fabio Aiuto
Remove commented RT_TRACE call in core/rtw_ioctl_set.c Remove all of the RT_TRACE logs in the core/rtw_ioctl_set.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it reli

[PATCH v4 26/30] staging: rtl8723bs: place constant on the right side of the test in core/rtw_ioctl_set.c

2021-04-04 Thread Fabio Aiuto
fix posst-commit hook checkpatch issues: WARNING: Comparisons should place the constant on the right side of the test 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:71: + if (_SUCCESS != ret) WARNING: Comparisons should place the constant on the right side of the t

[PATCH v4 27/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_wlan_util.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overri

[PATCH v4 29/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_ieee80211.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which overri

[PATCH v4 30/30] staging: rtl8723bs: add spaces around operators in core/rtw_ieee80211.c

2021-04-04 Thread Fabio Aiuto
fix post-commit hook checkpatch issues: CHECK: spaces preferred around that '+' (ctx:VxV) 161: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:648: + *wpa_len = in_ie[cnt+1]+2; ^ CHECK: spaces preferred around that '+' (ctx:Vx

[PATCH v4 28/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c

2021-04-04 Thread Fabio Aiuto
Remove all of the RT_TRACE logs in the core/rtw_sta_mgt.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged. Moreover it relies on an unneeded private log level tracing which override

[PATCH] mm: page_poison: print page owner info when corruption is caught

2021-04-04 Thread Sergei Trofimovich
When page_poison detects page corruption it's useful to see who freed a page recently to have a guess where write-after-free corruption happens. After this change corruption report has extra page_owner data. Example report from real corruption: pagealloc: memory corruption e0014cd61d1

Re: [PATCH v2] mfd: max8997: Replace 8998 with 8997

2021-04-04 Thread Timon Baetz
On Wed, 27 Jan 2021 07:32:42 +, Timon Baetz wrote: > The max8997 header is using "max8998" in some identifiers. > Fix it by replacing 8998 with 8997 in enum and macro. > > Signed-off-by: Timon Baetz > --- > v2: Fix commit message. > > include/linux/mfd/max8997.h | 8 > 1 file changed

Re: [PATCH v2] thermal/drivers/tsens: fix missing put_device error

2021-04-04 Thread Bjorn Andersson
On Sun 04 Apr 07:54 CDT 2021, zhuguangqin...@gmail.com wrote: > From: Guangqing Zhu > > Fixes coccicheck error: > > drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call > of_find_device_by_node on line 715, but without a corresponding object > release within this function. >

Usage of CXX in tools directory

2021-04-04 Thread Sedat Dilek
[ Please CC me I am not subscribed to all mailing-lists ] [ Please CC some more folks if you like ] Hi, when dealing/experimenting with BPF together with pahole/dwarves and dwarf-v5 and clang-lto I fell over that there is usage of CXX in tools directory. Especially, I wanted to build and run tes

Re: [RFC v1 00/26] Add TDX Guest Support

2021-04-04 Thread Dave Hansen
It occurred to me that I've been doing a lot of digging in the TDX spec lately. I think we can all agree that the "Architecture Specification" is not the world's easiest, most disgestable reading. It's hard to figure out what the Linux relation to the spec is. One bit of Documentation we need fo

[syzbot] WARNING: suspicious RCU usage in list_lru_destroy

2021-04-04 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5e46d1b7 reiserfs: update reiserfs_xattrs_initialized() co.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15556cced0 kernel config: https://syzkaller.appspot.com/x/.config?x=71a75beb62b62a34 das

Re: Usage of CXX in tools directory

2021-04-04 Thread Sedat Dilek
> So you need to pass CXX=clang++ manually when playing in tools directory: > > MAKE="make V=1 > MAKE_OPTS="HOSTCC=clang HOSTCXX=clang++ HOSTLD=ld.lld CC=clang > CXX=clang++ LD=ld.lld LLVM=1 LLVM_IAS=1" > MAKE_OPTS="MAKE_OPTS $PAHOLE=/opt/pahole/bin/pahole" > > $ LC_ALL=C $MAKE $MAKE_OPTS -C tools/

Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM

2021-04-04 Thread Dinh Nguyen
On 4/4/21 9:08 AM, Greg KH wrote: On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote: From: Krzysztof Kozlowski The Stratix10 service layer and RCU drivers are useful only on Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM fails: drivers/firmware/stratix10

[PATCH] iommu: dart: fix call_kern.cocci warnings

2021-04-04 Thread Julia Lawall
From: kernel test robot Function apple_dart_attach_stream called on line 519 inside lock on line 509 but uses GFP_KERNEL Generated by: scripts/coccinelle/locks/call_kern.cocci Fixes: ce67d3b3ef37 ("iommu: dart: Add DART iommu driver") CC: Sven Peter Reported-by: kernel test robot Signed-off-b

Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver (fwd)

2021-04-04 Thread Julia Lawall
There is a clear use after free on line 213. julia -- Forwarded message -- Date: Sat, 3 Apr 2021 04:42:45 +0800 From: kernel test robot To: kbu...@lists.01.org Cc: l...@intel.com, Julia Lawall Subject: Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver CC: kbuild-...

[PATCH 0/2] mm: khugepaged: cleanup and a minor tuning in THP

2021-04-04 Thread yanfei . xu
From: Yanfei Xu Yanfei Xu (2): mm: khugepaged: use macro to align addresses mm: khugepaged: check MMF_DISABLE_THP ahead of iterating over vmas mm/khugepaged.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) -- 2.27.0

[PATCH 1/2] mm: khugepaged: use macro to align addresses

2021-04-04 Thread yanfei . xu
From: Yanfei Xu We could use macro to deal with the addresses which need to be aligned to improve readability of codes. Signed-off-by: Yanfei Xu --- mm/khugepaged.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/mm/khugepaged.c b/mm/khugepage

[PATCH 2/2] mm: khugepaged: check MMF_DISABLE_THP ahead of iterating over vmas

2021-04-04 Thread yanfei . xu
From: Yanfei Xu We could check MMF_DISABLE_THP ahead of iterating over all of vma. Otherwise if some mm_struct contain a large number of vma, there will be amounts meaningless cpu cycles cost. BTW, drop an unnecessary cond_resched(), because there is a another cond_resched() followed it and no c

Re: [RFC PATCH v3 4/7] regulator: add property parsing and callbacks to set protection limits

2021-04-04 Thread Vaittinen, Matti
Hi Mark, Thanks for the review(s)! On Fri, 2021-04-02 at 18:18 +0100, Mark Brown wrote: > On Thu, Mar 11, 2021 at 12:23:02PM +0200, Matti Vaittinen wrote: > > > + /* > > +* Existing logic does not warn if over_current_protection is > > given as > > +* a constraint but driver does not su

  1   2   3   >