Re: [PATCH] i2c-stm32f4: Mundane typo fix

2021-03-24 Thread Randy Dunlap
On 3/24/21 7:06 AM, Bhaskar Chowdhury wrote: > > s/postion/position/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/i2c/busses/i2c-stm32f4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f4.c > b/drivers/i2

Re: [PATCH] static_call: fix function type mismatch

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 18.33, Peter Zijlstra wrote: > On Wed, Mar 24, 2021 at 05:45:52PM +0100, Rasmus Villemoes wrote: >> Sorry, I think I misread the code. The static calls are indeed >> initialized with a function with the right prototype. Try adding >> "preempt=full" on the command line so that we exerc

Re: [PATCH] media: cx88: Fix a typo

2021-03-24 Thread Randy Dunlap
On 3/24/21 7:17 AM, Bhaskar Chowdhury wrote: > > s/sillicon/silicon/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/media/pci/cx88/cx88-cards.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/cx88/cx88-cards.c > b/driv

Re: [PATCH] media: entity: A typo fix

2021-03-24 Thread Randy Dunlap
On 3/24/21 6:21 AM, Bhaskar Chowdhury wrote: > > s/cariers/carriers/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > include/media/media-entity.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/media/media-entity.h b/include/media/media-e

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Minchan Kim
On Thu, Mar 25, 2021 at 12:31:51AM +0300, Dmitry Osipenko wrote: > 24.03.2021 23:55, Minchan Kim пишет: > > Since CMA is getting used more widely, it's more important to > > keep monitoring CMA statistics for system health since it's > > directly related to user experience. > > > > This patch intr

Re: [PATCH V2 3/3] scsi: ufs-qcom: configure VCC voltage level in vendor file

2021-03-24 Thread nitirawa
On 2021-03-23 20:58, Bjorn Andersson wrote: On Sun 21 Mar 16:57 CDT 2021, Nitin Rawat wrote: As a part of vops handler, VCC voltage is updated as per the ufs device probed after reading the device descriptor. We follow below steps to configure voltage level. 1. Set the device to SLEEP state. 2

Re: [PATCH] scsi: esp_scsi: Trivial typo fixes

2021-03-24 Thread Randy Dunlap
On 3/23/21 11:13 PM, Bhaskar Chowdhury wrote: > > s/conditon/condition/ > s/pecularity/peculiarity/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/scsi/esp_scsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/esp_scsi.

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-24 Thread Michal Hocko
On Wed 24-03-21 13:53:34, Shakeel Butt wrote: [...] > > Given that's the case, the options seem to be: > > 1) Use a page flag - with the downside that they are a severely > > limited resource, > > 2) Use some bits inside page->memcg_data - this I believe Johannes had > > reasons against, and it isn

Re: [PATCH v4 14/22] x86/fpu/xstate: Expand the xstate buffer on the first use of dynamic user state

2021-03-24 Thread Dave Hansen
On 3/24/21 2:42 PM, Andy Lutomirski wrote: 3. user space always uses fully uncompacted XSAVE buffers. >>> There is no reason we have to do this for new states. Arguably we >>> shouldn’t for AMX to avoid yet another altstack explosion. >> The thing that's worried me is that the list of OS-

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-24 Thread James Bottomley
On Wed, 2021-03-24 at 16:49 -0400, Mimi Zohar wrote: > On Wed, 2021-03-24 at 09:14 -0700, James Bottomley wrote: > > On Tue, 2021-03-23 at 14:07 -0400, Mimi Zohar wrote: > > > On Tue, 2021-03-23 at 17:35 +0100, Ahmad Fatoum wrote: > > > > Hello Horia, > > > > > > > > On 21.03.21 21:48, Horia Geant

Re: [PATCH v6 00/12] SVM cleanup and INVPCID feature support

2021-03-24 Thread Paolo Bonzini
On 24/03/21 22:21, Borislav Petkov wrote: if (kaiser_enabled) invpcid_flush_one(X86_CR3_PCID_ASID_USER, addr); + else + asm volatile("invlpg (%0)" ::"r" (addr) : "memory"); + invpcid_flush_one(X86_CR3_PCID_ASID_KERN, addr); } I think the ker

Re: [PATCH] drm/vkms: fix misuse of WARN_ON

2021-03-24 Thread Melissa Wen
On 03/20, Dmitry Vyukov wrote: > vkms_vblank_simulate() uses WARN_ON for timing-dependent condition > (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used > to denote kernel bugs. Use pr_warn() instead. > > Signed-off-by: Dmitry Vyukov > Reported-by: syzbot+4fc21a003c8332eb0...@syz

Re: [PATCH] media: entity: A typo fix

2021-03-24 Thread Laurent Pinchart
Hi Bhaskar, Thank you for the patch. On Wed, Mar 24, 2021 at 06:51:00PM +0530, Bhaskar Chowdhury wrote: > > s/cariers/carriers/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Laurent Pinchart > --- > include/media/media-entity.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread John Hubbard
On 3/24/21 2:31 PM, Dmitry Osipenko wrote: ... +#include + +struct cma_kobject { + struct cma *cma; + struct kobject kobj; If you'll place the kobj as the first member of the struct, then container_of will be a no-op. However, *this does not matter*. Let's not get carried away.

Re: [PATCH net-next 1/2] net: phy: add genphy_c45_loopback

2021-03-24 Thread Andrew Lunn
On Wed, Mar 24, 2021 at 12:46:40AM +0800, Wong Vee Khee wrote: > Add generic code to enable C45 PHY loopback into the common phy-c45.c > file. This will allow C45 PHY drivers aceess this by setting > .set_loopback. > > Suggested-by: Heiner Kallweit > Signed-off-by: Wong Vee Khee Reviewed-by: An

Re: [PATCH net-next 2/2] net: phy: marvell10g: Add PHY loopback support

2021-03-24 Thread Andrew Lunn
On Wed, Mar 24, 2021 at 12:46:41AM +0800, Wong Vee Khee wrote: > Add support for PHY loopback for Marvell 88x2110 and Marvell 88x3310. > > This allow user to perform PHY loopback test using ethtool selftest. > > Signed-off-by: Wong Vee Khee Reviewed-by: Andrew Lunn Andrew

[PATCH] spi: fsi: Remove multiple sequenced ops for restricted chips

2021-03-24 Thread Eddie James
Updated restricted chips have trouble processing multiple sequenced operations. So remove the capability to sequence multiple operations and reduce the maximum transfer size to 8 bytes. Signed-off-by: Eddie James --- drivers/spi/spi-fsi.c | 27 +++ 1 file changed, 7 inser

Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-03-24 Thread Jacob Pan
Hi Jason, On Wed, 24 Mar 2021 14:03:38 -0300, Jason Gunthorpe wrote: > On Wed, Mar 24, 2021 at 10:02:46AM -0700, Jacob Pan wrote: > > > Also wondering about device driver allocating auxiliary domains for > > > their private use, to do iommu_map/unmap on private PASIDs (a clean > > > replacement

Re: [Patch v3 1/2] cgroup: sev: Add misc cgroup controller

2021-03-24 Thread Vipin Sharma
On Wed, Mar 24, 2021 at 09:17:01AM -0700, Jacob Pan wrote: > I didn't mean the users of misc_cgroup will use css directly. I meant if I > want to use misc cgruop in ioasid.c, I have to do the following to avoid > undefined css: > #include > #include > > So it might be simpler if you do #include

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 01:01, John Hubbard пишет: > On 3/24/21 2:31 PM, Dmitry Osipenko wrote: >> ... >>> +#include >>> + >>> +struct cma_kobject { >>> +    struct cma *cma; >>> +    struct kobject kobj; >> >> If you'll place the kobj as the first member of the struct, then >> container_of will be a no-op. >>

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 00:55, Minchan Kim пишет: >> There are no dereferences fixed by this patch. > Let me add this: > https://lore.kernel.org/linux-mm/20210316100433.17665-1-colin.k...@canonical.com/ > The tag is invalid now, since you squashed the fix. I think you may add "Co-developed-by: Colin Ian King

Re: [PATCH v4 14/22] x86/fpu/xstate: Expand the xstate buffer on the first use of dynamic user state

2021-03-24 Thread Andy Lutomirski
> On Mar 24, 2021, at 2:58 PM, Dave Hansen wrote: > > On 3/24/21 2:42 PM, Andy Lutomirski wrote: > 3. user space always uses fully uncompacted XSAVE buffers. > There is no reason we have to do this for new states. Arguably we shouldn’t for AMX to avoid yet another altstack e

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 01:10, Dmitry Osipenko пишет: > 25.03.2021 00:55, Minchan Kim пишет: >>> There are no dereferences fixed by this patch. >> Let me add this: >> https://lore.kernel.org/linux-mm/20210316100433.17665-1-colin.k...@canonical.com/ >> > > The tag is invalid now, since you squashed the fix. I t

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 00:55, Minchan Kim пишет: >>> +static ssize_t alloc_pages_success_show(struct kobject *kobj, >>> + struct kobj_attribute *attr, char *buf) >>> +{ >>> + struct cma *cma = cma_from_kobj(kobj); >>> + >>> + return sysfs_emit(buf, "%llu\n", >>> +

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 22:27 +0100, Rasmus Villemoes wrote: > On 24/03/2021 20.24, Joe Perches wrote: > > On Wed, 2021-03-24 at 18:33 +0100, Rasmus Villemoes wrote: > > > On 24/03/2021 18.20, Joe Perches wrote: > > > > > > > > > > > Maybe it's better to output non PTR_ERR %pe uses as decimal so th

Re: [PATCH][next] net/mlx5: Fix spelling mistakes in mlx5_core_info message

2021-03-24 Thread Saeed Mahameed
On Mon, 2021-03-15 at 12:30 +, Colin King wrote: > From: Colin Ian King > > There are two spelling mistakes in a mlx5_core_info message. Fix > them. > > Signed-off-by: Colin Ian King > --- >  drivers/net/ethernet/mellanox/mlx5/core/health.c | 2 +- >  1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH] rhashtable: avoid -Wrestrict warning on overlapping sprintf output

2021-03-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 23 Mar 2021 14:03:32 +0100 you wrote: > From: Arnd Bergmann > > sprintf() is declared with a restrict keyword to not allow input and > output to point to the same buffer: > > lib/test_rhashtable.c: In function 'p

Re: [PATCH] sfc-falcon: Fix a typo

2021-03-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 24 Mar 2021 13:22:04 +0530 you wrote: > s/maintaning/maintaining/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/net/ethernet/sfc/falcon/net_driver.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH net-next 1/1] net: stmmac: Add hardware supported cross-timestamp

2021-03-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 23 Mar 2021 19:07:34 +0800 you wrote: > From: Tan Tee Min > > Cross timestamping is supported on Integrated Ethernet Controller in > Intel SoC such as EHL and TGL with Always Running Timer. > > The hardware cross

Re: [PATCH net-next] octeontx2: fix -Wnonnull warning

2021-03-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 23 Mar 2021 13:53:29 +0100 you wrote: > From: Arnd Bergmann > > When compile testing this driver on a platform on which probe() is > known to fail at compile time, gcc warns about the cgx_lmactype_string[] > array

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-24 Thread Arjun Roy
On Wed, Mar 24, 2021 at 11:26 AM Shakeel Butt wrote: > > On Tue, Mar 23, 2021 at 11:42 AM Arjun Roy wrote: > > > [...] > > > > To summarize then, it seems to me that we're on the same page now. > > I'll put together a tentative v3 such that: > > 1. It uses pre-charging, as previously discussed. >

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 20.11, Stephen Boyd wrote: > Quoting Rasmus Villemoes (2021-03-24 02:57:13) >> >> Is there any reason you didn't just make b an optional flag that could >> be specified with or without R? I suppose the parsing is more difficult >> with several orthogonal flags (see escaped_string()),

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 00:55, Minchan Kim пишет: >> The tags are incorrect, I haven't suggested this change. > During the development, you have suggested many things > to make it clean. That suggested-by couldn't represent > all the detail but wanted to give credit for you, too > since you spent the time to ma

Re: [PATCH v2 07/12] scripts/decode_stacktrace.sh: Support debuginfod

2021-03-24 Thread Stephen Boyd
Quoting Andy Shevchenko (2021-03-24 04:27:53) > On Tue, Mar 23, 2021 at 07:04:38PM -0700, Stephen Boyd wrote: > > Now that stacktraces contain the build ID information we can update this > > script to use debuginfod-find to locate the debuginfo for the vmlinux > > and modules automatically. This ca

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread John Hubbard
On 3/24/21 3:11 PM, Dmitry Osipenko wrote: 25.03.2021 01:01, John Hubbard пишет: On 3/24/21 2:31 PM, Dmitry Osipenko wrote: ... +#include + +struct cma_kobject { +    struct cma *cma; +    struct kobject kobj; If you'll place the kobj as the first member of the struct, then container_of wil

[PATCH] ARM: dts: am335x-boneblack.dts: unique gpio-line-names

2021-03-24 Thread Drew Fustini
Based on linux-gpio discussion [1], it is best practice to make the gpio-line-names unique. Generic names like "[ethernet]" are replaced with the name of the unique signal on the AM3358 SoC ball corresponding to the gpio line. "[NC]" is also renamed to the standard "NC" name to represent "not conne

linux-next: build warning after merge of the drm-intel-fixes tree

2021-03-24 Thread Stephen Rothwell
Hi all, After merging the drm-intel-fixes tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/i915:22: /home/sfr/next/next/drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. Introduced by commit 8840e3bd981f ("

Re: [PATCH] spi: ensure timely release of driver-allocated resources

2021-03-24 Thread Dmitry Torokhov
On Wed, Mar 24, 2021 at 09:32:26PM +, Mark Brown wrote: > On Tue, Mar 23, 2021 at 12:04:34PM -0700, Dmitry Torokhov wrote: > > On Tue, Mar 23, 2021 at 05:36:06PM +, Mark Brown wrote: > > > No it is ordering issue. I do not have a proven real-life example for > > SPI, but we do have one for

[tip:x86/sgx] BUILD SUCCESS f33dece70e11ce82a09cb1ea2d7c32347b82c67e

2021-03-24 Thread kernel test robot
randconfig-a001-20210323 i386 randconfig-a002-20210323 i386 randconfig-a006-20210323 i386 randconfig-a005-20210323 i386 randconfig-a004-20210324 i386 randconfig-a003-20210324 i386 randconfig-a001

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-24 Thread Stephen Boyd
Quoting Rasmus Villemoes (2021-03-24 15:21:34) > On 24/03/2021 20.11, Stephen Boyd wrote: > > Quoting Rasmus Villemoes (2021-03-24 02:57:13) > > >> > >> Is there any reason you didn't just make b an optional flag that could > >> be specified with or without R? I suppose the parsing is more difficu

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

2021-03-24 Thread Drew Fustini
On Wed, Mar 24, 2021 at 02:00:52PM +0200, Tony Lindgren wrote: > Hi, > > * Drew Fustini [210127 02:04]: > > Based on linux-gpio discussion [1], it is best practice to make the > > gpio-line-names unique. Generic names like "[ethernet]" are replaced > > with the name of the unique signal on the AM

Re: [PATCH] static_call: fix function type mismatch

2021-03-24 Thread Sami Tolvanen
On Wed, Mar 24, 2021 at 2:51 PM Rasmus Villemoes wrote: > > On 24/03/2021 18.33, Peter Zijlstra wrote: > > On Wed, Mar 24, 2021 at 05:45:52PM +0100, Rasmus Villemoes wrote: > >> Sorry, I think I misread the code. The static calls are indeed > >> initialized with a function with the right prototype

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 23.18, Joe Perches wrote: > On Wed, 2021-03-24 at 22:27 +0100, Rasmus Villemoes wrote: >> On 24/03/2021 20.24, Joe Perches wrote: >>> On Wed, 2021-03-24 at 18:33 +0100, Rasmus Villemoes wrote: On 24/03/2021 18.20, Joe Perches wrote: > > Maybe it's better to output no

[PATCH 1/1] of: unittest: rename overlay source files from .dts to .dtso

2021-03-24 Thread frowand . list
From: Frank Rowand Add Makefile rule to build .dtbo.o assembly file from overlay .dtso source file. Rename unittest .dts overlay source files to use .dtso suffix. Update Makefile to build .dtbo.o objects instead of .dtb.o from unittest overlay source files. Modify unitest.c to use .dtbo.o base

Re: [PATCH] ia64: mca: allocate early mca with GFP_ATOMIC

2021-03-24 Thread Andrew Morton
On Wed, 24 Mar 2021 11:20:45 +0100 John Paul Adrian Glaubitz wrote: > >> #NEXT_PATCHES_START mainline-later (next week, approximately) > >> ia64-mca-allocate-early-mca-with-gfp_atomic.patch > > Great, thanks. We're still missing Valentin's patch for the NUMA enumeration > issue > though. Shoul

Re: [PATCH] Fix fnic driver to remove bogus ratelimit messages.

2021-03-24 Thread Joe Perches
On Tue, 2021-03-23 at 10:27 -0700, ldun...@suse.com wrote: > From: Lee Duncan > > Commit b43abcbbd5b1 ("scsi: fnic: Ratelimit printks to avoid > looding when vlan is not set by the switch.i") added > printk_ratelimit() in front of a couple of debug-mode > messages, to reduce logging overrun when

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 01:23, John Hubbard пишет: > On 3/24/21 3:11 PM, Dmitry Osipenko wrote: >> 25.03.2021 01:01, John Hubbard пишет: >>> On 3/24/21 2:31 PM, Dmitry Osipenko wrote: ... > +#include > + > +struct cma_kobject { > +    struct cma *cma; > +    struct kobject kobj; >

Re: [PATCH] arm64: dts: qcom: c630: Add no-hpd to DSI bridge node

2021-03-24 Thread Doug Anderson
Hi, On Wed, Mar 24, 2021 at 12:15 PM Stephen Boyd wrote: > > We should indicate that we're not using the HPD pin on this device, per > the binding document. Otherwise if code in the future wants to enable > HPD in the bridge when this property is absent we'll be wasting power > powering hpd when

Re: [PATCH] Revert "f2fs: give a warning only for readonly partition"

2021-03-24 Thread Jaegeuk Kim
On 03/24, Chao Yu wrote: > On 2021/3/24 12:22, Jaegeuk Kim wrote: > > On 03/24, Chao Yu wrote: > > > On 2021/3/24 2:39, Jaegeuk Kim wrote: > > > > On 03/23, Chao Yu wrote: > > > > > This reverts commit 938a184265d75ea474f1c6fe1da96a5196163789. > > > > > > > > > > Because that commit fails generic/

Re: [PATCH V11 3/5] kbuild: Allow .dtso format for overlay source files

2021-03-24 Thread Frank Rowand
Hi Viresh, On 3/24/21 2:34 AM, Frank Rowand wrote: > On 3/16/21 12:42 AM, Viresh Kumar wrote: >> On 16-03-21, 00:36, Frank Rowand wrote: >>> I should have looked at patch 3/5 more carefully instead of counting on >>> Masahiro to check it out and simply build testing. >>> >>> Patch 3/5 does not see

Re: [PATCH] kbuild: Merge module sections if and only if CONFIG_LTO_CLANG is enabled

2021-03-24 Thread Sean Christopherson
On Tue, Mar 23, 2021, Sami Tolvanen wrote: > On Tue, Mar 23, 2021 at 9:36 AM Sean Christopherson wrote: > > > > On Tue, Mar 23, 2021, Sami Tolvanen wrote: > > > On Mon, Mar 22, 2021 at 4:44 PM Sean Christopherson > > > wrote: > > > > > > > > Merge module sections only when using Clang LTO. With

Re: [PATCH v2] dt-bindings: media: video-interfaces: Drop the example

2021-03-24 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Wed, Mar 24, 2021 at 02:22:53PM -0600, Rob Herring wrote: > The example in video-interfaces.yaml uses a bunch of undocumented > bindings which will cause warnings when undocumented compatible checks > are enabled. The example could be fixed to use documented bi

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 23:36 +0100, Rasmus Villemoes wrote: > On 24/03/2021 23.18, Joe Perches wrote: > > There's no silly game here. %pe would either print a string or a value. > > A hashed value, that is, never the raw value. There is value in printing the raw value. As discussed, it can simpli

Re: [PATCH] kasan: fix hwasan build for gcc

2021-03-24 Thread Andrew Morton
On Tue, 23 Mar 2021 13:51:32 +0100 Marco Elver wrote: > On Tue, 23 Mar 2021 at 13:41, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > gcc-11 adds support for -fsanitize=kernel-hwaddress, so it becomes > > possible to enable CONFIG_KASAN_SW_TAGS. > > > > Unfortunately this fails to buil

Re: [PATCH -next] x86/kprobes: Fix old-style-declaration warning

2021-03-24 Thread Masami Hiramatsu
On Wed, 24 Mar 2021 14:45:02 + 'Wei Yongjun wrote: > From: Wei Yongjun > > Gcc reports build warning as follows: > > arch/x86/kernel/kprobes/core.c:940:1: > warning: 'inline' is not at beginning of declaration > [-Wold-style-declaration] > 940 | static int nokprobe_inline kprobe_is_ss(

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-24 Thread Arjun Roy
On Wed, Mar 24, 2021 at 2:24 PM Johannes Weiner wrote: > > On Wed, Mar 24, 2021 at 10:12:46AM +0100, Michal Hocko wrote: > > On Tue 23-03-21 11:47:54, Arjun Roy wrote: > > > On Tue, Mar 23, 2021 at 7:34 AM Michal Hocko wrote: > > > > > > > > On Wed 17-03-21 18:12:55, Johannes Weiner wrote: > > >

s390-linux-ld: xilinx_emaclite.c:undefined reference to `of_address_to_resource'

2021-03-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4ee998b0ef8b6d7b1267cd4d953182224929abba commit: 18af77c50fede5b3fc22aa9f0a9b255a5c5285c9 drivers: net: xilinx_emaclite: remove arch limitation date: 5 weeks ago config: s390-randconfig-m031-20210325 (atta

Re: [PATCH] static_call: fix function type mismatch

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 23.34, Sami Tolvanen wrote: > On Wed, Mar 24, 2021 at 2:51 PM Rasmus Villemoes > wrote: >> >> On 24/03/2021 18.33, Peter Zijlstra wrote: >>> On Wed, Mar 24, 2021 at 05:45:52PM +0100, Rasmus Villemoes wrote: Sorry, I think I misread the code. The static calls are indeed init

Re: [PATCH] x86/kprobes: Remove dead code

2021-03-24 Thread Masami Hiramatsu
On Wed, 24 Mar 2021 17:50:16 + Colin Ian King wrote: > On 24/03/2021 17:36, Muhammad Usama Anjum wrote: > > The condition in switch statement `opcode & 0xf0` cannot evaluate to > > 0xff. So this case statement will never execute. Remove it. > > > > Fixes: 6256e668b7 ("x86/kprobes: Use int3 i

Re: [PATCH] ia64: mca: allocate early mca with GFP_ATOMIC

2021-03-24 Thread John Paul Adrian Glaubitz
Hi Andrew! On 3/24/21 11:39 PM, Andrew Morton wrote: > On Wed, 24 Mar 2021 11:20:45 +0100 John Paul Adrian Glaubitz > wrote: > #NEXT_PATCHES_START mainline-later (next week, approximately) ia64-mca-allocate-early-mca-with-gfp_atomic.patch >> >> Great, thanks. We're still missing Valen

Re: [PATCH v1 0/3] drivers/char: remove /dev/kmem for good

2021-03-24 Thread Balbir Singh
On Wed, Mar 24, 2021 at 12:24:12PM -0700, Andrew Morton wrote: > > > Let's remove /dev/kmem, which is unused and obsolete. > > I grabbed these. Silently - the cc list is amazing ;) > > I was wondering if it would be better to permanently disable /dev/kmem > in Kconfig along with a comment "if y

Re: x86/kprobes: Use int3 instead of debug trap for single-step

2021-03-24 Thread Masami Hiramatsu
On Wed, 24 Mar 2021 15:48:34 + Colin Ian King wrote: > Hi, > > Static analysis on linux-next using Coverity has detected an issue in > the following commit: > > commit 6256e668b7af9d81472e03c6a171630c08f8858a > Author: Masami Hiramatsu > Date: Wed Mar 3 00:25:46 2021 +0900 > > x86/k

Re: [PATCH] kernel: kcov: fix a typo in comment

2021-03-24 Thread Andrew Morton
On Tue, 23 Mar 2021 23:32:57 +0100 Marco Elver wrote: > On Tue, 23 Mar 2021 at 07:45, 'Dmitry Vyukov' via kasan-dev > wrote: > > On Tue, Mar 23, 2021 at 7:24 AM tl455047 wrote: > > > > > > Fixed a typo in comment. > > > > > > Signed-off-by: tl455047 > > > > Reviewed-by: Dmitry Vyukov > > > >

[PATCH V2] ARM: xen/mm.c: A mundane typo fix

2021-03-24 Thread Bhaskar Chowdhury
s/acrros/across/ Plus some words need prural version...so did it.(page->pages) Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Randy's findings incorporated. arch/arm/xen/mm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c

Re: [PATCH] tools: testing: Remove duplicate include of string.h

2021-03-24 Thread Andrew Morton
On Tue, 23 Mar 2021 11:29:56 +0800 Wan Jiabing wrote: > string.h has been included at line 15.So we remove the > duplicate one at line 17. Thanks. But we already have https://lkml.kernel.org/r/20210316073336.426255-1-zhang.yun...@zte.com.cn.

[PATCH] usbip: vhci_hcd fix shift out-of-bounds in vhci_hub_control()

2021-03-24 Thread Shuah Khan
Fix shift out-of-bounds in vhci_hub_control() SetPortFeature handling. UBSAN: shift-out-of-bounds in drivers/usb/usbip/vhci_hcd.c:605:42 shift exponent 768 is too large for 32-bit type 'int' Reported-by: syzbot+3dea30b047f41084d...@syzkaller.appspotmail.com Cc: sta...@vger.kernel.org Signed-off-b

Re: [PATCH] ARM: xen/mm.c: A mundane typo fix

2021-03-24 Thread Bhaskar Chowdhury
On 11:59 Wed 24 Mar 2021, Randy Dunlap wrote: On 3/24/21 11:55 AM, Stefano Stabellini wrote: On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: s/acrros/across/ Signed-off-by: Bhaskar Chowdhury Reviewed-by: Stefano Stabellini Hi, It seems to me like some of those "page" should be "pages".

[PATCH v8] mm: cma: support sysfs

2021-03-24 Thread Minchan Kim
Since CMA is getting used more widely, it's more important to keep monitoring CMA statistics for system health since it's directly related to user experience. This patch introduces sysfs statistics for CMA, in order to provide some basic monitoring of the CMA allocator. * the number of CMA page

Re: [PATCH] mm/slub.c: Trivial typo fixes

2021-03-24 Thread Bhaskar Chowdhury
On 11:49 Wed 24 Mar 2021, David Rientjes wrote: On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: diff --git a/mm/slub.c b/mm/slub.c index 3021ce9bf1b3..cd3c7be33f69 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3,7 +3,7 @@ * SLUB: A slab allocator that limits cache line use instead of queuing * o

Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369

2021-03-24 Thread Boris Ostrovsky
On 3/24/21 8:24 AM, Roger Pau Monne wrote: > Hello, > > This is a proposal for an alternative fix for XSA-369 that instead of > special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making > XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG > option rather than XEN_BA

RE: [PATCH] pinctrl: qcom: fix unintentional string concatenation

2021-03-24 Thread David Laight
From: Arnd Bergmann > Sent: 23 March 2021 13:17 > clang is clearly correct to point out a typo in a silly > array of strings: > > drivers/pinctrl/qcom/pinctrl-sdx55.c:426:61: error: suspicious concatenation > of string literals in an > array initialization; did you mean to separate the elements w

Re: [PATCH] kernel: kcov: fix a typo in comment

2021-03-24 Thread Marco Elver
On Thu, 25 Mar 2021 at 00:04, Andrew Morton wrote: > On Tue, 23 Mar 2021 23:32:57 +0100 Marco Elver wrote: > > On Tue, 23 Mar 2021 at 07:45, 'Dmitry Vyukov' via kasan-dev > > wrote: > > > On Tue, Mar 23, 2021 at 7:24 AM tl455047 wrote: > > > > > > > > Fixed a typo in comment. > > > > > > > > Si

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Jason Gunthorpe
On Wed, Mar 24, 2021 at 09:07:53PM +0100, Thomas Hellström (Intel) wrote: > > On 3/24/21 7:31 PM, Christian König wrote: > > > > > > Am 24.03.21 um 17:38 schrieb Jason Gunthorpe: > > > On Wed, Mar 24, 2021 at 04:50:14PM +0100, Thomas Hellström (Intel) > > > wrote: > > > > On 3/24/21 2:48 PM, Jas

[PATCH v2] arm64: dts: qcom: c630: Add no-hpd to DSI bridge node

2021-03-24 Thread Stephen Boyd
We should indicate that we're not using the HPD pin on this device, per the binding document. Otherwise if code in the future wants to enable HPD in the bridge when this property is absent we'll be enabling HPD when it isn't supposed to be used. Presumably this board isn't using hpd on the bridge.

RE: [PATCH] ARM: delay: avoid clang -Wtautological-constant warning

2021-03-24 Thread David Laight
From: Arnd Bergmann > Sent: 23 March 2021 13:20 > Passing an 8-bit constant into delay() triggers a warning when building > with 'make W=1' using clang: > > drivers/clk/actions/owl-pll.c:182:2: error: result of comparison of constant > 2000 with expression of > type 'u8' (aka 'unsigned char') is

Re: [PATCH, -v2] perf tools: Fix various typos in comments

2021-03-24 Thread Randy Dunlap
On 3/23/21 9:09 AM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > >> Fix ~81 single-word typos in the perf tooling code - accumulated over the >> years. > > Found a few more: > > => > From: Ingo Molnar > Date: Sun, 21 Mar 2021 12:37:34 +0100 > Subject: [PATCH] perf tools: Fix var

Re: [PATCH v2] arm64: dts: qcom: c630: Add no-hpd to DSI bridge node

2021-03-24 Thread Doug Anderson
Hi, On Wed, Mar 24, 2021 at 4:14 PM Stephen Boyd wrote: > > We should indicate that we're not using the HPD pin on this device, per > the binding document. Otherwise if code in the future wants to enable > HPD in the bridge when this property is absent we'll be enabling HPD > when it isn't suppos

[PATCH V2] mm/slub.c: Trivial typo fixes

2021-03-24 Thread Bhaskar Chowdhury
s/operatios/operations/ s/Mininum/Minimum/ s/mininum/minimum/ ..two different places. Signed-off-by: Bhaskar Chowdhury --- Changes from V1: David's finding incorporated.i.e operation->operations mm/slub.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/slub

Re: [Nouveau] [PATCH -next] drm/nouveau/core/client: Mark nvkm_uclient_sclass with static keyword

2021-03-24 Thread Ben Skeggs
On Tue, 23 Mar 2021 at 17:03, Zou Wei wrote: > > Fix the following sparse warning: > > drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol > 'nvkm_uclient_sclass' was not declared. Should it be static? > > Signed-off-by: Zou Wei Applied, thanks. > --- > drivers/gpu/drm/nouveau/nvk

Re: [PATCH] userfaultfd/shmem: fix minor fault page leak

2021-03-24 Thread Andrew Morton
On Mon, 22 Mar 2021 13:48:35 -0700 Axel Rasmussen wrote: > This fix is analogous to Peter Xu's fix for hugetlb [0]. If we don't > put_page() after getting the page out of the page cache, we leak the > reference. > > The fix can be verified by checking /proc/meminfo and running the > userfaultfd

Re: [PATCH v3 03/25] x86/sgx: Wipe out EREMOVE from sgx_free_epc_page()

2021-03-24 Thread Kai Huang
> > > +/* Error message for EREMOVE failure, when kernel is about to leak EPC > > page */ > > +#define EREMOVE_ERROR_MESSAGE \ > > + "EREMOVE returned %d (0x%x), kernel bug likely. EPC page leaked, > > SGX may become > > unusuable. Please refer to Documentation/x86/sgx.rst for more inf

Re: [PATCH v2] drm/nouveau/kms/nv50-: Correct size checks for cursors

2021-03-24 Thread Ben Skeggs
On Fri, 19 Mar 2021 at 09:04, Lyude Paul wrote: > > Found this while trying to make some changes to the kms_cursor_crc test. > curs507a_acquire checks that the width and height of the cursor framebuffer > are equal (asyw->image.{w,h}). This isn't entirely correct though, as the > height of the cur

Re: [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable

2021-03-24 Thread Ben Skeggs
On Wed, 17 Mar 2021 at 19:51, ChunyouTang wrote: > > From: tangchunyou > > disable,delete disable and return 0 > > Signed-off-by: tangchunyou Thanks! > --- > drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/g

Re: [PATCH net-next 0/2] Add support for Clause-45 PHY Loopback

2021-03-24 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 24 Mar 2021 00:46:39 +0800 you wrote: > This patch series add support for Clause-45 PHY loopback. > > It involves adding a generic API in the PHY framework, which can be > accessed by all C45 PHY drivers using the

Re: [PATCH] net: decnet: Fixed multiple Coding Style issues

2021-03-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 23 Mar 2021 23:14:19 +0530 you wrote: > Made changes to coding style as suggested by checkpatch.pl > changes are of the type: > space required before the open parenthesis '(' > space requ

[PATCH V2] drm/radeon/r600_cs: Few typo fixes

2021-03-24 Thread Bhaskar Chowdhury
s/miror/mirror/ s/needind/needing/ s/informations/information/ Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Randy's finding incorporated ,i.e in one place,informations->information Adjusted the subject line accordingly drivers/gpu/drm/radeon/r600_cs.c | 6 +++--- 1 file changed, 3

Re: [PATCH] drm/radeon/r600_cs: Couple of typo fixes

2021-03-24 Thread Bhaskar Chowdhury
On 14:48 Wed 24 Mar 2021, Randy Dunlap wrote: On 3/24/21 6:50 AM, Bhaskar Chowdhury wrote: s/miror/mirror/ s/needind/needing/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/radeon/r600_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r

Re: [PATCH] tools: usbip: list.h: fix kernel-doc for list_del()

2021-03-24 Thread Shuah Khan
On 3/23/21 6:02 PM, Randy Dunlap wrote: In list.h, the kernel-doc for list_del() should be immediately preceding the implementation and not separated from it by another function implementation. Eliminates this kernel-doc error: list.h:1: warning: 'list_del' not found Signed-off-by: Randy Dunlap

linux-next: manual merge of the fscache tree with Linus' tree

2021-03-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the fscache tree got a conflict in: fs/afs/write.c between commit: 75b69799610c ("afs: Use wait_on_page_writeback_killable") from Linus' tree and commit: 721597fd1aa6 ("afs: Prepare for use of THPs") from the fscache tree. I fixed it up (see below)

Re: [PATCH v3 03/25] x86/sgx: Wipe out EREMOVE from sgx_free_epc_page()

2021-03-24 Thread Paolo Bonzini
On 25/03/21 00:23, Kai Huang wrote: I changed to below (with slight modification on Paolo's): /* Error message for EREMOVE failure, when kernel is about to leak EPC page */ #define EREMOVE_ERROR_MESSAGE \ "EREMOVE returned %d (0x%x) and an EPC page was leaked. SGX may become unusuable

Re: [PATCH] spi: ensure timely release of driver-allocated resources

2021-03-24 Thread Mark Brown
On Wed, Mar 24, 2021 at 03:27:23PM -0700, Dmitry Torokhov wrote: > On Wed, Mar 24, 2021 at 09:32:26PM +, Mark Brown wrote: > > TBH that looks like a fairly standard case where you probably don't want > > to be using devm for the interrupts in the first place. Leaving the > > interrupts live a

Re: [RESEND] regulator: mt6360: remove redundant error print

2021-03-24 Thread Mark Brown
On Wed, 24 Mar 2021 11:11:14 +0800, Jian Dong wrote: > fixes coccicheck warning: > > drivers/regulator/mt6360-regulator.c:384:3-10: line 384 is > redundant because platform_get_irq() already prints an error > > in fact it is not platform_get_irq but platform_get_irq_byname print error Applied to

Re: [PATCH 0/6] ASoC: fsl: Don't use devm_regmap_init_mmio_clk

2021-03-24 Thread Mark Brown
On Wed, 24 Mar 2021 17:58:42 +0800, Shengjiu Wang wrote: > When there is power domain bind with ipg clock, > > The call flow: > devm_regmap_init_mmio_clk > - clk_prepare() > - clk_pm_runtime_get() > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.

Re: [PATCH] regulator: mt6360: remove redundant error print

2021-03-24 Thread Mark Brown
On Tue, 23 Mar 2021 20:22:41 +0800, Jian Dong wrote: > fixes coccicheck warning: > > drivers/regulator/mt6360-regulator.c:384:3-10: line 384 is > redundant because platform_get_irq() already prints an error > > in fact, it is not platform_get_irq but platform_get_irq_byname print error Applied t

Re: (subset) [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-03-24 Thread Mark Brown
On Sun, 7 Mar 2021 16:17:54 +0100, Hans de Goede wrote: > Here is v4 of my series to rework the arizona codec jack-detect support > to use the snd_soc_jack helpers instead of direct extcon reporting. > > As discussed before here is a resend rebased on 5.12-rc2, making sure that > all patches this

Re: [PATCH] static_call: fix function type mismatch

2021-03-24 Thread Sami Tolvanen
On Wed, Mar 24, 2021 at 3:53 PM Rasmus Villemoes wrote: > > On 24/03/2021 23.34, Sami Tolvanen wrote: > > On Wed, Mar 24, 2021 at 2:51 PM Rasmus Villemoes > > wrote: > >> > >> On 24/03/2021 18.33, Peter Zijlstra wrote: > >>> On Wed, Mar 24, 2021 at 05:45:52PM +0100, Rasmus Villemoes wrote: >

Re: [PATCH v3 03/25] x86/sgx: Wipe out EREMOVE from sgx_free_epc_page()

2021-03-24 Thread Kai Huang
On Thu, 25 Mar 2021 00:39:01 +0100 Paolo Bonzini wrote: > On 25/03/21 00:23, Kai Huang wrote: > > I changed to below (with slight modification on Paolo's): > > > > /* Error message for EREMOVE failure, when kernel is about to leak EPC page > > */ > > #define EREMOVE_ERROR_MESSAGE \ > > "

Re: [PATCH V2] drm/radeon/r600_cs: Few typo fixes

2021-03-24 Thread Randy Dunlap
On 3/24/21 4:29 PM, Bhaskar Chowdhury wrote: > s/miror/mirror/ > s/needind/needing/ > s/informations/information/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap Thanks. > --- > Changes from V1: > Randy's finding incorporated ,i.e in one place,informations->information > Adjus

Re: [PATCH V2] mm/slub.c: Trivial typo fixes

2021-03-24 Thread Randy Dunlap
On 3/24/21 9:49 PM, Bhaskar Chowdhury wrote: > s/operatios/operations/ > s/Mininum/Minimum/ > s/mininum/minimum/ ..two different places. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Changes from V1: > David's finding incorporated.i.e operation->operations > mm/s

Re: [PATCH -tip v4 10/12] x86/kprobes: Push a fake return address at kretprobe_trampoline

2021-03-24 Thread Masami Hiramatsu
On Wed, 24 Mar 2021 11:01:43 -0500 Josh Poimboeuf wrote: > On Wed, Mar 24, 2021 at 10:40:58AM +0900, Masami Hiramatsu wrote: > > On Tue, 23 Mar 2021 23:30:07 +0100 > > Peter Zijlstra wrote: > > > > > On Mon, Mar 22, 2021 at 03:41:40PM +0900, Masami Hiramatsu wrote: > > > > ".global kret

<    5   6   7   8   9   10   11   12   13   14   >