Re: [PATCH] clk: tegra: fix old-style declaration

2021-03-23 Thread Thierry Reding
On Mon, Mar 22, 2021 at 10:50:41PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > With extra warnings enabled, gcc complains about a slightly odd > prototype: > > drivers/clk/tegra/clk-dfll.c:1380:1: error: 'inline' is not at beginning of > declaration [-Werror=old-style-declaration] >

[PATCH v2 3/3] soc: rockchip: power-domain: add rk3568 powerdomains

2021-03-23 Thread Elaine Zhang
Add power-domains found on rk3568 socs. Signed-off-by: Elaine Zhang --- drivers/soc/rockchip/pm_domains.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domains.c index 54eb6cfc5d5b..a2c19c845cf2 1

[PATCH v2 1/3] dt-bindings: add power-domain header for RK3568 SoCs

2021-03-23 Thread Elaine Zhang
According to a description from TRM, add all the power domains Signed-off-by: Elaine Zhang --- include/dt-bindings/power/rk3568-power.h | 32 1 file changed, 32 insertions(+) create mode 100644 include/dt-bindings/power/rk3568-power.h diff --git a/include/dt-bindings/p

[PATCH v2 0/3] soc: rockchip: power-domain: add rk3568 powerdomains

2021-03-23 Thread Elaine Zhang
Support power domain function for RK3568 Soc. Change in V2: [PATCH v2 1/3]: No change. [PATCH v2 2/3]: Fix up yaml code styles. [PATCH v2 3/3]: No change. Elaine Zhang (3): dt-bindings: add power-domain header for RK3568 SoCs dt-bindings: Convert the rockchip power_domain to YAML and extend

[PATCH v2 2/3] dt-bindings: Convert the rockchip power_domain to YAML and extend

2021-03-23 Thread Elaine Zhang
This converts the rockchip power domain family bindings to YAML schema, and add binding documentation for the power domains found on Rockchip RK3568 SoCs. Signed-off-by: Elaine Zhang --- .../bindings/soc/rockchip/power_domain.txt| 136 - .../rockchip/rockchip,power-controller.yaml

RE: [PATCH v3] exfat: speed up iterate/lookup by fixing start point of traversing cluster chain

2021-03-23 Thread Namjae Jeon
> > When directory iterate and lookup is called, there's a buggy rewinding > > of start point for traversing cluster chain to the parent directory > > entry's first cluster. This caused repeated cluster chain traversing > > from the first entry of the parent directory that would show worse > > perf

Re: [PATCH v4 1/4] userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs

2021-03-23 Thread Mike Rapoport
On Mon, Mar 22, 2021 at 06:08:45PM -0400, Peter Xu wrote: > UFFD_FEATURE_THREAD_ID is supported since Linux 4.14. > > Signed-off-by: Peter Xu > --- > man2/userfaultfd.2 | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2 > index e7dc9f

Re: [PATCH] Introduced new tracing mode KCOV_MODE_UNIQUE.

2021-03-23 Thread Alexander Lochmann
On 23.03.21 08:23, Dmitry Vyukov wrote: >> diff --git a/kernel/kcov.c b/kernel/kcov.c >> index 80bfe71bbe13..1f727043146a 100644 >> --- a/kernel/kcov.c >> +++ b/kernel/kcov.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include > > Is this for __always_inline? > __always

Re: [PATCH 11/17] auxdisplay: ht16k33: Convert to simple i2c probe function

2021-03-23 Thread robin
On 2021-03-22 15:48, Geert Uytterhoeven wrote: ht16k33_probe() does not use the passed i2c_device_id, so the driver can be converted trivially to the new-style of i2c probing. Signed-off-by: Geert Uytterhoeven --- drivers/auxdisplay/ht16k33.c | 5 ++--- 1 file changed, 2 insertions(+), 3 dele

Re: [PATCH v4 0/4] man2: udpate mm/userfaultfd manpages to latest

2021-03-23 Thread Mike Rapoport
On Mon, Mar 22, 2021 at 06:08:44PM -0400, Peter Xu wrote: > v4: > - Fixed a few "subordinate clauses" (SC) cases [Alex] > - Reword in ioctl_userfaultfd.2 to use bold font for the two modes referenced, > so as to be clear on what is "both" referring to [Alex] > > v3: > - Don't use "Currently", in

[PATCH v2] Bluetooth: check for zapped sk before connecting

2021-03-23 Thread Archie Pusaka
From: Archie Pusaka There is a possibility of receiving a zapped sock on l2cap_sock_connect(). This could lead to interesting crashes, one such case is tearing down an already tore l2cap_sock as is happened with this call trace: __dump_stack lib/dump_stack.c:15 [inline] dump_stack+0xc4/0x118 lib

Re: [kbuild-all] Re: include/linux/compiler_types.h:315:38: error: call to '__compiletime_assert_536' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct can_frame, len) != offsetof(st

2021-03-23 Thread Oliver Hartkopp
Answering myself ... On 23.03.21 08:45, Oliver Hartkopp wrote: On 23.03.21 08:34, Marc Kleine-Budde wrote: On 23.03.2021 10:54:40, Rong Chen wrote: I tried arm-linux-gnueabi (gcc version 10.2.0) and the problem still exists, btw we prefer to not use the latest gcc compiler to avoid false posit

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-03-23 Thread Jie Deng
On 2021/3/23 15:27, Viresh Kumar wrote: On 23-03-21, 22:19, Jie Deng wrote: +static int __maybe_unused virtio_i2c_freeze(struct virtio_device *vdev) +{ + virtio_i2c_del_vqs(vdev); + return 0; +} + +static int __maybe_unused virtio_i2c_restore(struct virtio_device *vdev) +{ + r

Re: [PATCH v3 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-23 Thread Cristian Ciocaltea
On Tue, Mar 23, 2021 at 12:38:10AM +0100, Andrew Lunn wrote: > > +static void owl_emac_set_multicast(struct net_device *netdev, int count) > > +{ > > + struct owl_emac_priv *priv = netdev_priv(netdev); > > + struct netdev_hw_addr *ha; > > + int index = 0; > > + > > + if (count <= 0) { > > +

Re: linux-next: build failure after merge of the tip tree

2021-03-23 Thread Sedat Dilek
On Mon, Mar 22, 2021 at 4:39 AM Stephen Rothwell wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > arch/x86/net/bpf_jit_comp.c: In function 'arch_prepare_bpf_trampoline': > arch/x86/net/bpf_jit_comp.c:2015:16: error: 'ideal_no

[PATCH net-next 1/2] bridge: mrp: Disable roles before deleting the MRP instance

2021-03-23 Thread Horatiu Vultur
When an MRP instance was created, the driver was notified that the instance is created and then in a different callback about role of the instance. But when the instance was deleted the driver was notified only that the MRP instance is deleted and not also that the role is disabled. This patch mak

[PATCH net-next 0/2] bridge: mrp: Disable roles before deleting

2021-03-23 Thread Horatiu Vultur
The first patch in this series make sures that the driver is notified that the role is disabled before the MRP instance is deleted. The second patch uses this so it can simplify the driver. Horatiu Vultur (2): bridge: mrp: Disable roles before deleting the MRP instance net: ocelot: Simplify MR

[PATCH] init/Kconfig: Support sign module with SM3 hash algorithm

2021-03-23 Thread Tianjia Zhang
The kernel module signature supports the option to use the SM3 secure hash (OSCCA GM/T 0004-2012 SM3). Signed-off-by: Tianjia Zhang --- Documentation/admin-guide/module-signing.rst | 5 +++-- crypto/asymmetric_keys/pkcs7_parser.c| 7 +++ init/Kconfig |

[PATCH net-next 2/2] net: ocelot: Simplify MRP deletion

2021-03-23 Thread Horatiu Vultur
Now that the driver will always be notified that the role is deleted before the ring is deleted, then we don't need to duplicate the logic of cleaning the resources also in the delete function. Signed-off-by: Horatiu Vultur --- drivers/net/ethernet/mscc/ocelot_mrp.c | 16 1 file

Re: [PATCH v2 00/10] Rid W=1 warnings from OF

2021-03-23 Thread Lee Jones
On Mon, 22 Mar 2021, Rob Herring wrote: > On Thu, Mar 18, 2021 at 4:40 AM Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > v2: > > - Provided some descrip

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-03-23 Thread Viresh Kumar
On 23-03-21, 16:33, Jie Deng wrote: > On 2021/3/23 15:27, Viresh Kumar wrote: > > > On 23-03-21, 22:19, Jie Deng wrote: > > > +static int __maybe_unused virtio_i2c_freeze(struct virtio_device *vdev) > > > +{ > > > + virtio_i2c_del_vqs(vdev); > > > + return 0; > > > +} > > > + > > > +static int __m

Re: [PATCH v2 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support

2021-03-23 Thread Robert Foss
Hey Konrad, Thanks for the review! On Mon, 22 Mar 2021 at 18:27, Konrad Dybcio wrote: > > Hi! > > > > + tsens0: thermal-sensor@c222000 { > > + compatible = "qcom,sm8350-tsens", "qcom,tsens-v2"; > > + reg = <0 0x0C263000 0 0x1ff>, /* TM */ > >

ERROR: modpost: "ioremap" undefined!

2021-03-23 Thread kernel test robot
Hi Nick, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 84196390620ac0e5070ae36af84c137c6216a7dc commit: 1e1b6d63d6340764e00356873e5794225a2a03ea lib/string.c: implement stpcpy date: 6 months ago config: s390-ra

Re: [PATCH 1/1] nvme-pci: add the DISABLE_WRITE_ZEROES quirk for a Samsung PM1725a

2021-03-23 Thread Javier González
On 11.03.2021 11:47, Christoph Hellwig wrote: On Wed, Mar 10, 2021 at 12:00:30PM -0800, Keith Busch wrote: On Wed, Mar 10, 2021 at 02:41:10PM +0100, Christoph Hellwig wrote: > On Wed, Mar 10, 2021 at 02:21:56PM +0100, Christoph Hellwig wrote: > > Can you try this patch instead? > > > > http://li

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-23 Thread Lee Jones
On Mon, 22 Mar 2021, Daniel Thompson wrote: > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > > Signed-off-by: Konrad Dybcio > > Reviewed-by: Daniel Thompson Why are you Reviewing/Acking a patch that was ap

Re: [PATCH] Bluetooth: check for zapped sk before connecting

2021-03-23 Thread Archie Pusaka
Hi Marcel, Thanks for your suggestion. I implemented it in v2, please take another look. On Mon, 22 Mar 2021 at 23:53, Marcel Holtmann wrote: > > Hi Archie, > > > There is a possibility of receiving a zapped sock on > > l2cap_sock_connect(). This could lead to interesting crashes, one > > such

Re: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support

2021-03-23 Thread Lee Jones
On Mon, 22 Mar 2021, Min Li wrote: > > > > I'm pretty confused. This has been sent ~6 times already. What is the v1 > > of? > > Is this a different driver? If so, why does it have the same $SUBJECT line? > > > > If this is not actually v1. Please provide a change-log. > > > > > Hi Lee >

[PATCH net-next 1/1] net: phy: marvell10g: Add PHY loopback support for 88E2110 PHY

2021-03-23 Thread Wong Vee Khee
From: Tan Tee Min Add support for PHY loopback for the Marvell 88E2110 PHY. This allow user to perform selftest using ethtool. Signed-off-by: Tan Tee Min Signed-off-by: Wong Vee Khee --- drivers/net/phy/marvell10g.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/ne

Re: [RFC PATCH] autofs: find_autofs_mount overmounted parent support

2021-03-23 Thread Ian Kent
On Tue, 2021-03-09 at 13:43 +0300, Alexander Mikhalitsyn wrote: > On Sat, 06 Mar 2021 17:13:32 +0800 > Ian Kent wrote: > > > On Fri, 2021-03-05 at 14:55 +0300, Alexander Mikhalitsyn wrote: > > > On Fri, 05 Mar 2021 18:10:02 +0800 > > > Ian Kent wrote: > > > > > > > On Thu, 2021-03-04 at 13:11 +

[PATCH] KVM: x86/vPMU: Forbid writing to MSR_F15H_PERF MSRs when guest doesn't have X86_FEATURE_PERFCTR_CORE

2021-03-23 Thread Vitaly Kuznetsov
MSR_F15H_PERF_CTL0-5, MSR_F15H_PERF_CTR0-5 MSRs are only available when X86_FEATURE_PERFCTR_CORE CPUID bit was exposed to the guest. KVM, however, allows these MSRs unconditionally because kvm_pmu_is_valid_msr() -> amd_msr_idx_to_pmc() check always passes and because kvm_pmu_set_msr() -> amd_pmu_se

Re: [PATCH 5.10 000/156] 5.10.26-rc2 review

2021-03-23 Thread Naresh Kamboju
On Mon, 22 Mar 2021 at 20:49, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.10.26 release. > There are 156 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Re

Re: linux-next: build warning in Linus' tree

2021-03-23 Thread Peter Zijlstra
On Tue, Mar 23, 2021 at 04:51:45PM +1100, Stephen Rothwell wrote: > Hi all, > > Building Linus' tree, today's linux-next build (x86_64 allnoconfig) > produced this warning: > > kernel/static_call.c: In function '__static_call_update': > kernel/static_call.c:153:18: warning: unused variable 'mod'

Re: [PATCH] net/mlx5: Fix a potential use after free in mlx5e_ktls_del_rx

2021-03-23 Thread Maxim Mikityanskiy
On 2021-03-22 16:21, Lv Yunlong wrote: My static analyzer tool reported a potential uaf in mlx5e_ktls_del_rx. In this function, if the condition cancel_work_sync(&resync->work) is true, and then priv_rx could be freed. But priv_rx is used later. I'm unfamiliar with how this function works. Maybe

[PATCH] block: clear GD_NEED_PART_SCAN later in bdev_disk_changed

2021-03-23 Thread chris . chiu
From: Chris Chiu The GD_NEED_PART_SCAN is set by bdev_check_media_change to initiate a partition scan while removing a block device. It should be cleared after blk_drop_paritions because blk_drop_paritions could return -EBUSY and then the consequence __blkdev_get has no chance to do delete_partit

Re: [PATCH 06/17] auxdisplay: Extract character line display core support

2021-03-23 Thread Geert Uytterhoeven
Hi Robin, On Tue, Mar 23, 2021 at 9:18 AM robin wrote: > On 2021-03-22 15:48, Geert Uytterhoeven wrote: > > Extract the character line display core support from the simple ASCII > > LCD driver for the MIPS Boston, Malta & SEAD3 development boards into > > its own subdriver, so it can be reused fo

[PATCH] selftests: kvm: make hardware_disable_test less verbose

2021-03-23 Thread Vitaly Kuznetsov
hardware_disable_test produces 512 snippets like ... main: [511] waiting semaphore run_test: [511] start vcpus run_test: [511] all threads launched main: [511] waiting 368us main: [511] killing child and this doesn't have much value, let's just drop these fprintf(). Restoring them for debuggi

Re: [PATCH] drm/i915: A typo fix

2021-03-23 Thread Jani Nikula
On Tue, 23 Mar 2021, Bhaskar Chowdhury wrote: > s/nothign/nothing/ > > Signed-off-by: Bhaskar Chowdhury You've sent the same patch before? I've already pushed it. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [kbuild-all] Re: include/linux/compiler_types.h:315:38: error: call to '__compiletime_assert_536' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct can_frame, len) != offsetof(st

2021-03-23 Thread Marc Kleine-Budde
On 23.03.2021 09:32:10, Oliver Hartkopp wrote: > I wonder if the compiler configurations (gcc -v) or the options used at > kernel build time are identical. I tested several compilers and with my .config never triggered a problem, but with Rong Chen it does. I'm trying to figure out which option it

[GIT PULL] Immutable branch between MFD and Power due for the v5.13 merge window

2021-03-23 Thread Lee Jones
Enjoy! The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-power-v5.13 for you to fetch changes up to ee0975c3089e1c3

Re: [PATCH 12/17] auxdisplay: ht16k33: Add helper variable dev

2021-03-23 Thread robin
On 2021-03-22 15:48, Geert Uytterhoeven wrote: This driver has many users of "client->dev". Add shorthands to simplify the code. Signed-off-by: Geert Uytterhoeven --- drivers/auxdisplay/ht16k33.c | 43 ++-- 1 file changed, 22 insertions(+), 21 deletions(-) di

Re: [Ksummit-discuss] RFC: create mailing list "linux-issues" focussed on issues/bugs and regressions

2021-03-23 Thread Thorsten Leemhuis
On 22.03.21 22:56, Theodore Ts'o wrote: > On Mon, Mar 22, 2021 at 08:25:15PM +0100, Thorsten Leemhuis wrote: >> I agree to the last point and yeah, maybe regressions are the more >> important problem we should work on – at least from the perspective of >> kernel development. But from the users per

[PATCH] sound:ppc: fix spelling typo of values

2021-03-23 Thread caizhichao
From: caizhichao vaules -> values Signed-off-by: caizhichao --- sound/ppc/snd_ps3_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/ppc/snd_ps3_reg.h b/sound/ppc/snd_ps3_reg.h index 566a318..e2212b7 100644 --- a/sound/ppc/snd_ps3_reg.h +++ b/sound/ppc/snd_ps3_reg.

Re: [PATCH] kernel/signal: Modify the comment of function check_kill_permission

2021-03-23 Thread Christian Brauner
On Tue, Mar 23, 2021 at 01:03:56AM -0700, zhouchuangao wrote: > Maybe it's easier for us to understand the function of > check_kill_permission. > > Signed-off-by: zhouchuangao > --- > kernel/signal.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/kernel/signal.c

Re: [PATCH] kernel/sys.c: Fix a typo

2021-03-23 Thread Christian Brauner
On Tue, Mar 23, 2021 at 06:49:09AM +0530, Bhaskar Chowdhury wrote: > > s/concurent/concurrent/ > > Signed-off-by: Bhaskar Chowdhury > --- Looks good, Reviewed-by: Christian Brauner

Re: [kbuild-all] Re: include/linux/compiler_types.h:315:38: error: call to '__compiletime_assert_536' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct can_frame, len) != offsetof(st

2021-03-23 Thread Rong Chen
On 3/23/21 4:54 PM, Marc Kleine-Budde wrote: On 23.03.2021 09:32:10, Oliver Hartkopp wrote: I wonder if the compiler configurations (gcc -v) or the options used at kernel build time are identical. I tested several compilers and with my .config never triggered a problem, but with Rong Chen it

Re: [PATCH V3] exit: trigger panic when global init has exited

2021-03-23 Thread Oleg Nesterov
On 03/23, qianli zhao wrote: > > Hi,Oleg > > > No, there is at least one alive init thread. If they all have exited, we > > have > > the thread which calls panic() above. > > By current logic, setting PF_EXITING(exit_signals()) is before the > panic(), You certainly don't understand me :/ Please

Re: [PATCH] hfs/hfsplus: use WARN_ON for sanity check

2021-03-23 Thread Christian Brauner
On Mon, Mar 22, 2021 at 11:32:40PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc warns about a couple of instances in which a sanity check > exists but the author wasn't sure how to react to it failing, > which makes it look like a possible bug: > > fs/hfsplus/inode.c: In function 'h

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-03-23 Thread Viresh Kumar
On 23-03-21, 22:19, Jie Deng wrote: > +static int virtio_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, > int num) > +{ > + struct virtio_i2c *vi = i2c_get_adapdata(adap); > + struct virtqueue *vq = vi->vq; > + struct virtio_i2c_req *reqs; > + unsigned long time_left; > +

Re: [PATCH net-next] page_pool: let the compiler optimize and inline core functions

2021-03-23 Thread Jesper Dangaard Brouer
On Mon, 22 Mar 2021 18:30:55 + Alexander Lobakin wrote: > As per disscussion in Page Pool bulk allocator thread [0], > there are two functions in Page Pool core code that are marked as > 'noinline'. The reason for this is not so clear, and even if it > was made to reduce hotpath overhead, in

[tip:locking/core] BUILD SUCCESS ebdbd41bf2536ac57bf315ce9690245e08c5e506

2021-03-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/core branch HEAD: ebdbd41bf2536ac57bf315ce9690245e08c5e506 locking/mutex: Fix non debug version of mutex_lock_io_nested() elapsed time: 724m configs tested: 116 configs skipped: 3 The following configs have

Re: GTE - The hardware timestamping engine

2021-03-23 Thread Thierry Reding
On Mon, Mar 22, 2021 at 01:33:38PM -0700, Dipen Patel wrote: > Hi Richard, > > Thanks for your input and time. Please see below follow up. > > On 3/20/21 8:38 AM, Richard Cochran wrote: > > On Sat, Mar 20, 2021 at 01:44:20PM +0100, Arnd Bergmann wrote: > >> Adding Richard Cochran as well, for dri

[rcu:rcu/next] BUILD SUCCESS f4d010298f01aac657191629d6e9e11d978cc64d

2021-03-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next branch HEAD: f4d010298f01aac657191629d6e9e11d978cc64d doc: Fix statement of RCU's memory-ordering requirements elapsed time: 726m configs tested: 122 configs skipped: 3 The following configs have been

Re: [PATCH] serial: imx: drop workaround for forced irq threading

2021-03-23 Thread Sebastian Andrzej Siewior
On 2021-03-23 08:34:47 [+0100], Uwe Kleine-König wrote: > Hello Sebastian, Hi Uwe, > On Mon, Mar 22, 2021 at 09:48:36PM +0100, Sebastian Andrzej Siewior wrote: > > On 2021-03-22 14:40:32 [+0100], Uwe Kleine-König wrote: > > > From a strictly logically point of view you indeed cannot. But if you go

Re: [LTP] [f2fs] 02eb84b96b: ltp.swapon03.fail

2021-03-23 Thread Chao Yu
On 2021/3/11 4:49, Jaegeuk Kim wrote: On 03/10, Huang Jianan wrote: Hi Richard, On 2021/3/9 12:01, Matthew Wilcox wrote: On Tue, Mar 09, 2021 at 10:23:35AM +0800, Weichao Guo wrote: Hi Richard, On 2021/3/8 19:53, Richard Palethorpe wrote: Hello, kern :err : [ 187.461914] F2FS-fs (sda1

Re: [PATCH 3/7] mfd: mt6397: Drop of_compatible for regulator

2021-03-23 Thread Lee Jones
On Fri, 12 Mar 2021, matthias@kernel.org wrote: > From: Matthias Brugger > > For regulators a compatible string is superfluous. Drop the string. > > Signed-off-by: Matthias Brugger > --- > drivers/mfd/mt6397-core.c | 3 --- > 1 file changed, 3 deletions(-) Acked-by: Lee Jones -- Lee J

Re: [PATCH] staging: rtl8723bs: Trivial typo fix

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 06:38:35AM +0530, Bhaskar Chowdhury wrote: > > s/netowrk/network/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c >

Re: [PATCH] mfd: ABX500_CORE should depend on ARCH_U8500

2021-03-23 Thread Lee Jones
On Tue, 16 Mar 2021, Geert Uytterhoeven wrote: > The ST-Ericsson ABX500 Mixed Signal IC family chips are only present on > ST-Ericsson U8500 Series platforms. Hence add a dependency on > ARCH_U8500, to prevent asking the user about this driver when > configuring a kernel without U8500 support. >

Re: [PATCH v2 01/13] dt-bindings: usb: mtk-xhci: support property usb2-lpm-disable

2021-03-23 Thread Sergei Shtylyov
Hello! On 23.03.2021 10:02, Chunfeng Yun wrote: Add support common property usb2-lpm-disable ^ for Signed-off-by: Chunfeng Yun [...] MBR, Sergei

Re: GTE - The hardware timestamping engine

2021-03-23 Thread Linus Walleij
On Mon, Mar 22, 2021 at 9:17 PM Dipen Patel wrote: > My follow-up concerns on both Linus's and Kent's feedback: > > 1. Please correct me if I am wrong, lineevent in the gpiolib* is only > serves the userspace clients. > 1.a What about kernel drivers wanting to use this feature for monitoring

Re: [PATCH 06/13] usb: xhci-mtk: support ip-sleep wakeup for MT8183

2021-03-23 Thread kernel test robot
Hi Chunfeng, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next linus/master v5.12-rc4 next-20210323] [cannot apply to mediatek/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: Re: [PATCH] usb: Add data checks in usbtmc_disconnect

2021-03-23 Thread lyl2019
> -原始邮件- > 发件人: "Greg KH" > 发送时间: 2021-03-23 15:16:55 (星期二) > 收件人: "Lv Yunlong" > 抄送: linux-...@vger.kernel.org, linux-kernel@vger.kernel.org > 主题: Re: [PATCH] usb: Add data checks in usbtmc_disconnect > > On Mon, Mar 22, 2021 at 08:47:17PM -0700, Lv Yunlong wrote: > > In usbtmc_disco

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Robert Foss
Hey Adrien, Sorry about the slow reply, but I just received the documentation from the vendor. So let's dig in to the HPD issue. > +static enum drm_connector_status lt8912_check_cable_status(struct lt8912 *lt) > +{ > + int ret; > + unsigned int reg_val; > + > + ret = regmap_read

Re: [PATCH] staging: rtl8723bs: Trivial typo fix

2021-03-23 Thread Bhaskar Chowdhury
On 10:05 Tue 23 Mar 2021, Greg KH wrote: On Tue, Mar 23, 2021 at 06:38:35AM +0530, Bhaskar Chowdhury wrote: s/netowrk/network/ Signed-off-by: Bhaskar Chowdhury --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rt

Re: [GIT PULL] Immutable branch between MFD and Power due for the v5.13 merge window

2021-03-23 Thread Linus Walleij
On Tue, Mar 23, 2021 at 9:57 AM Lee Jones wrote: > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-power-v5.13 Thanks so much for fixing this Lee! Sebastian: if you decide to pull this in I can iterate some more patches to the AB8500 BM code this merge window, else I will jus

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-23 Thread Liu Ying
On Tue, 2021-03-23 at 01:03 +, Marcel Ziswiler wrote: > Hi Liu > > Some further discrepancy with them binding examples: > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi:335.9-36: Warning (reg_format): > /dpu@5618:reg: property has > invalid length (8 bytes) (#address-cells == 2, #size-cell

Re: [PATCH 02/17] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays

2021-03-23 Thread robin
On 2021-03-22 15:48, Geert Uytterhoeven wrote: The Holtek HT16K33 LED controller is not only used for driving dot-matrix displays, but also for driving segment displays. Document compatible values for the Adafruit 7-segment[1] and 14-segment[2] FeatherWing expansion boards with red displays. A

[PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread He Ying
We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should it be static? warning: symbol 'dtl_consumer' was not declared. Should it be static? Declare 'decrementer_ma

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-23 Thread Sedat Dilek
On Mon, Mar 22, 2021 at 1:13 PM Jiri Kosina wrote: > > On Sat, 13 Mar 2021, Luca Coelho wrote: > > > > > > > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with > > > > > > > > > hard IRQs > > > > > > > > > disabled (e.g. from LED core). We can't enable BHs in such a > > > > > > >

Re: [PATCH] drm/i915: A typo fix

2021-03-23 Thread Bhaskar Chowdhury
On 10:53 Tue 23 Mar 2021, Jani Nikula wrote: On Tue, 23 Mar 2021, Bhaskar Chowdhury wrote: s/nothign/nothing/ Signed-off-by: Bhaskar Chowdhury You've sent the same patch before? I've already pushed it. Apologies and thanks. BR, Jani. --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c

Re: [linuxwifi] [PATCH] net: iwlwifi: remove trailing semicolon in macro definition

2021-03-23 Thread Coelho, Luciano
On Fri, 2020-11-27 at 10:07 -0800, t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > --- Thank you. I applied this now to our internal tree and this will reach the mainline following our usual process. -- Cheers, Luca.

Re: [PATCH v1 1/5] mfd: intel_quark_i2c_gpio: revert "Constify static struct resources"

2021-03-23 Thread Lee Jones
On Tue, 02 Mar 2021, Andy Shevchenko wrote: > The structures are used as place holders, so they are modified at run-time. > Obviously they may not be constants. > > BUG: unable to handle page fault for address: d0643220 > ... > CPU: 0 PID: 110 Comm: modprobe Not tainted 5.11.0+ #1 > Hardw

Re: [PATCH 10/13] usb: mtu3: support ip-sleep wakeup for MT8183

2021-03-23 Thread kernel test robot
Hi Chunfeng, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next linus/master v5.12-rc4 next-20210323] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH v4 05/19] kvm: arm64: Disable guest access to trace filter controls

2021-03-23 Thread Marc Zyngier
Hi Suzuki, On 2021-03-22 22:24, Suzuki K Poulose wrote: Hi Marc, On 25/02/2021 19:35, Suzuki K Poulose wrote: Disable guest access to the Trace Filter control registers. We do not advertise the Trace filter feature to the guest (ID_AA64DFR0_EL1: TRACE_FILT is cleared) already, but the guest ca

Re: [Linux-stm32] [PATCH v10 22/33] counter: Internalize sysfs interface code

2021-03-23 Thread William Breathitt Gray
On Mon, Mar 22, 2021 at 05:44:01PM +0100, Fabrice Gasnier wrote: > On 3/19/21 12:00 PM, William Breathitt Gray wrote: > > static const struct atmel_tcb_config tcb_rm9200_config = { > > diff --git a/drivers/counter/stm32-lptimer-cnt.c > > b/drivers/counter/stm32-lptimer-cnt.c > > index 13656957c45

Re: [PATCH] docs/kokr: make sections on bug reporting match practice

2021-03-23 Thread sj38 . park
Hello Jon, could I ask you a review for this patch? Thanks, SeongJae Park

Re: [External] Re: [PATCH v5 1/7] mm: memcontrol: slab: fix obtain a reference to a freeing memcg

2021-03-23 Thread Muchun Song
On Mon, Mar 22, 2021 at 10:46 PM Johannes Weiner wrote: > > On Sat, Mar 20, 2021 at 12:38:14AM +0800, Muchun Song wrote: > > The rcu_read_lock/unlock only can guarantee that the memcg will not be > > freed, but it cannot guarantee the success of css_get (which is in the > > refill_stock when cache

Re: [PATCH v2 -next] intel: iwlwifi: use DEFINE_MUTEX() for mutex lock

2021-03-23 Thread Coelho, Luciano
On Thu, 2020-12-24 at 21:25 +0800, Zheng Yongjun wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Signed-off-by: Zheng Yongjun > --- Thanks! I have now applied this internally and it will reach the mainline following our

Re: [PATCH v1 5/5] mfd: intel_quark_i2c_gpio: Reuse BAR definitions for MFD cell indexing

2021-03-23 Thread Lee Jones
On Tue, 02 Mar 2021, Andy Shevchenko wrote: > It's convenient and less error prone to use definitions to address > different cells in an array. For this purpose we may reuse existing > BAR definitions. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel_quark_i2c_gpio.c | 20 ++

Re: [PATCH -next] x86: Fix intel cpu unsed variable ‘l2’ warning

2021-03-23 Thread Borislav Petkov
On Tue, Mar 23, 2021 at 10:59:01AM +0800, Xu Yihang wrote: > Fixes the following W=1 kernel build warning(s): > ../arch/x86/kernel/cpu/intel.c: In function ‘init_intel’: > ../arch/x86/kernel/cpu/intel.c:644:20: warning: variable ‘l2’ set but not > used [-Wunused-but-set-variable] >unsigned int

[PATCH][next] media: imx-jpeg: Fix spelling mistake "Canot" -> "Cannot"

2021-03-23 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/media/platform/imx-jpeg/mxc-jpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/i

Re: [PATCH v1 2/5] mfd: intel_quark_i2c_gpio: Unregister resources in reversed order

2021-03-23 Thread Lee Jones
On Tue, 02 Mar 2021, Andy Shevchenko wrote: > In ->remove() unregister resources in reversed order, i.e. MFD devices first > followed by I²C clock. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel_quark_i2c_gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, tha

Re: [PATCH v1 3/5] mfd: intel_quark_i2c_gpio: Remove unused struct device member

2021-03-23 Thread Lee Jones
On Tue, 02 Mar 2021, Andy Shevchenko wrote: > The device pointer in the custom structure is not used anywhere, > remove it for good. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel_quark_i2c_gpio.c | 2 -- > 1 file changed, 2 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Seni

[PATCH] drm/i915: Use tasklet_unlock_spin_wait() in __tasklet_disable_sync_once()

2021-03-23 Thread Sebastian Andrzej Siewior
The i915 driver has its own tasklet interface which was overseen in the tasklet rework. __tasklet_disable_sync_once() is a wrapper around tasklet_unlock_wait(). tasklet_unlock_wait() might sleep, but the i915 wrappers invoke it from non-preemtible contexts with bottom halves disabled. Use tasklet_

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

2021-03-23 Thread Greg Kroah-Hartman
On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote: > From: Jason Li > > This driver supports Cortina Access UART IP integrated > in most all CA line of SoCs. Earlycom is also supported > > Signed-off-by: Jason Li > Reviewed-by: Alex Nemirovsky > --- > MAINTAINERS

Re: [PATCH v1 4/5] mfd: intel_quark_i2c_gpio: Replace I²C speeds with descriptive definitions

2021-03-23 Thread Lee Jones
On Tue, 02 Mar 2021, Andy Shevchenko wrote: > I²C header provides a descriptive definitions for standard bus speeds. > Use them instead of plain numbers. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel_quark_i2c_gpio.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-

[PATCH V2]staging: rtl8723bs: Trivial typo fix

2021-03-23 Thread Bhaskar Chowdhury
s/netowrk/network/ ..and an extra space has removed from the sentence. Signed-off-by: Bhaskar Chowdhury --- Changes from V1: I have missed to remove an extra space in the sentence, corrected,Greg pointed out,thanks. drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 inse

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

2021-03-23 Thread Greg Kroah-Hartman
On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote: > +static struct cortina_uart_port *cortina_uart_ports; Why is this not a per-device pointer? > +static void __exit cortina_uart_exit(void) > +{ > + platform_driver_unregister(&serial_cortina_driver); > + uart_unregister_dri

drivers/net/wan/fsl_ucc_hdlc.c:305:57: sparse: sparse: incorrect type in argument 2 (different address spaces)

2021-03-23 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 84196390620ac0e5070ae36af84c137c6216a7dc commit: 894fa235eb4ca0bfa692dbe4932c2f940cdc8c1e powerpc: inline iomap accessors date: 4 months ago config: powerpc64-randconfig-s032-20210323 (attached as .config

Re: drivers/net/ethernet/chelsio/cxgb4/sge.c:2396:13: warning: stack frame size of 1168 bytes in function 'ethofld_xmit'

2021-03-23 Thread Arnd Bergmann
On Tue, Mar 23, 2021 at 7:37 AM kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 84196390620ac0e5070ae36af84c137c6216a7dc > commit: 97e4910232fa1f81e806aa60c25a0450276d99a2 linux/compiler-clang.h: > define HAVE_BUILTIN_BSW

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-23 Thread Jiri Kosina
On Tue, 23 Mar 2021, Sedat Dilek wrote: > > > > > > > > Johannes is telling me that he merged this patch internally, > > > > > > > > but I have no > > > > > > > > idea what is happening to it ... ? > > > > > > > > > > > > > > > > The reported splat is a clear bug, so it should be fixed one > > >

[PATCH] khugepaged: Raplace barrier() with READ_ONCE() for a selective variable

2021-03-23 Thread yanfei . xu
From: Yanfei Xu READ_ONCE() is more selective and lightweight. It is more appropriate that using a READ_ONCE() for the certain variable to prevent the compiler from reordering. Signed-off-by: Yanfei Xu --- mm/khugepaged.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/m

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-03-23 Thread Arnd Bergmann
On Tue, Mar 23, 2021 at 9:33 AM Jie Deng wrote: > > On 2021/3/23 15:27, Viresh Kumar wrote: > > > On 23-03-21, 22:19, Jie Deng wrote: > >> +static int __maybe_unused virtio_i2c_freeze(struct virtio_device *vdev) > >> +{ > >> +virtio_i2c_del_vqs(vdev); > >> +return 0; > >> +} > >> + > >> +s

Re: [PATCH 3/4] powerpc/rust: Add target.json for ppc64le

2021-03-23 Thread Miguel Ojeda
On Tue, Mar 23, 2021 at 4:27 AM Michael Ellerman wrote: > > ppc64le only for now. We'll eventually need to come up with some way to > change the target.json that's used based on more than just $(ARCH). Indeed, it is one reason I didn't tackle e.g. x86 32-bit, because I wanted to figure out how to

Re: [PATCH] ASoC: Intel: Handle device properties with software node API

2021-03-23 Thread Heikki Krogerus
On Mon, Mar 22, 2021 at 10:02:40AM -0500, Pierre-Louis Bossart wrote: > > > On 3/22/21 6:06 AM, Heikki Krogerus wrote: > > The function device_add_properties() is going to be removed. > > Replacing it with software node API equivalents. > > > > Signed-off-by: Heikki Krogerus > > --- > > Hi, > >

[PATCH v2] usb: Add a lock when freeing data in usbtmc_disconnect

2021-03-23 Thread Lv Yunlong
In usbtmc_disconnect, data is got from intf with the initial reference. There is no refcount inc operation before usbmc_free_int(data). In usbmc_free_int(data), the data may be freed. But later in usbtmc_disconnect, there is another put function of data. It could cause errors in race. My patch ad

[PATCH] tty:serial: fix spelling typo of values

2021-03-23 Thread caizhichao
From: caizhichao vaules -> values Signed-off-by: caizhichao --- drivers/tty/serial/8250/8250_mtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c index f7d3023..c6633dc 100644 --- a/drivers/tty/serial

Re: [PATCH v8 0/3] CPUFreq: Add support for opp-sharing cpus

2021-03-23 Thread Sudeep Holla
On Thu, 18 Feb 2021 22:23:23 +, Nicola Mazzucato wrote: > In this V8 I have addressed your comments: > - correct the goto in patch 1/3 > - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() > > Many thanks, > Nicola > > [...] (New commit info after rebase to v5.12-rc2 for obvious re

Re: [PATCH 1/2] arm64: dts: juno: Describe PCI dma-ranges

2021-03-23 Thread Sudeep Holla
On Fri, 5 Mar 2021 17:33:17 +, Robin Murphy wrote: > The PLDA root complex on Juno relies on an address-based lookup table to > generate AXI attributes for inbound PCI transactions, and as such will > not pass any transaction not matching any programmed address range. The > standard firmware co

Re: [PATCH V3 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 04:34:28PM +0530, Roja Rani Yarubandi wrote: > This reverts commit 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect > support to fix earlycon crash") > > ICC core and platforms drivers supports sync_state feature with > commit 7d3b0b0d8184 ("interconnect: qcom: Use icc_sy

[tip:perf/urgent] BUILD SUCCESS 6d48b7912cc72275dc7c59ff961c8bac7ef66a92

2021-03-23 Thread kernel test robot
i386 randconfig-a015-20210322 i386 randconfig-a016-20210322 i386 randconfig-a012-20210322 i386 randconfig-a013-20210322 i386 randconfig-a014-20210323 i386 randconfig-a011-20210323 i386

<    1   2   3   4   5   6   7   8   9   10   >