[PATCH v3 13/19] media: i2c: rdacm21: Power up OV10640 before OV490

2021-03-19 Thread Jacopo Mondi
The current RDACM21 initialization routine powers up the OV10640 image sensor after the OV490 ISP. The ISP is programmed with a firmware loaded from an embedded EEPROM that (most probably) tries to interact and program also the image sensor connected to the ISP. As described in commit ccb26c5742f5

[PATCH v3 16/19] media: i2c: rdacm20: Replace goto with a loop

2021-03-19 Thread Jacopo Mondi
During the camera module initialization the image sensor PID is read to verify it can correctly be identified. The current implementation is rather confused and uses a loop implemented with a label and a goto. Replace it with a more compact for() loop. No functional changes intended. Reviewed-by

[PATCH v3 17/19] media: i2c: rdacm20: Report camera module name

2021-03-19 Thread Jacopo Mondi
When the device is identified the driver currently reports the names of the chips embedded in the camera module. Report the name of the camera module itself instead. Cosmetic change only. Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/media/i

[PATCH v3 19/19] media: i2c: rdacm20: Re-work ov10635 reset

2021-03-19 Thread Jacopo Mondi
The OV10635 image sensor embedded in the camera module is currently reset after the MAX9271 initialization with two long delays that were most probably not correctly characterized. Re-work the image sensor reset procedure by holding the chip in reset during the MAX9271 configuration, removing the

[PATCH v3 15/19] media: i2c: rdacm20: Embed 'serializer' field

2021-03-19 Thread Jacopo Mondi
There's no reason to allocate dynamically the 'serializer' field in the driver structure. Embed the field and adjust all its users in the driver. Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/media/i2c/rdacm20.c | 40

[PATCH v3 18/19] media: i2c: rdacm20: Check return values

2021-03-19 Thread Jacopo Mondi
The camera module initialization routine does not check the return value of a few functions. Fix that. Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/media/i2c/rdacm20.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff

[PATCH v3 14/19] media: i2c: rdacm20: Enable noise immunity

2021-03-19 Thread Jacopo Mondi
Enable the noise immunity threshold at the end of the rdacm20 initialization routine. The rdacm20 camera module has been so far tested with a startup delay that allowed the embedded MCU to program the serializer. If the initialization routine is run before the MCU programs the serializer and the i

Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

2021-03-19 Thread Rafael J. Wysocki
On Sat, Mar 13, 2021 at 11:27 AM Pavel Machek wrote: > > On Fri 2021-03-12 11:24:30, chris.c...@canonical.com wrote: > > From: Chris Chiu > > > > The .callback of the quirk for Sony VPCEH3U1E was unintetionally > > removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk > > for GIGABYTE G

Re: [mm] 8fd8d23ab1: WARNING:at_fs/buffer.c:#__brelse

2021-03-19 Thread Minchan Kim
On Fri, Mar 19, 2021 at 10:05:28PM +0800, Oliver Sang wrote: > Hi Minchan, > > On Wed, Mar 17, 2021 at 09:29:38AM -0700, Minchan Kim wrote: > > On Wed, Mar 17, 2021 at 10:37:57AM +0800, kernel test robot wrote: > > > > > > > > > Greeting, > > > > > > FYI, we noticed the following commit (built

Re: [PATCH] ACPI: fix various typos in comments

2021-03-19 Thread Rafael J. Wysocki
On Sat, Mar 13, 2021 at 4:17 AM Randy Dunlap wrote: > > On 3/12/21 5:55 PM, Tom Saeger wrote: > > Fix trivial ACPI driver comment typos. > > > > s/notifcations/notifications/ > > s/Ajust/Adjust/ > > s/preform/perform/ > > s/atrributes/attributes/ > > s/Souce/Source/ > > s/Evalutes/Evaluates/ > > s

Re: remove the legacy ide driver

2021-03-19 Thread Maciej W. Rozycki
On Thu, 18 Mar 2021, Christoph Hellwig wrote: > we've been trying to get rid of the legacy ide driver for a while now, > and finally scheduled a removal for 2021, which is three month old now. Hmm, there's still a regression in that pata_legacy unconditionally pokes at random I/O port locations

Re: [PATCH] net/rds: correct socket tunable error in rds_tcp_tune()

2021-03-19 Thread Matthew Wilcox
On Wed, Mar 17, 2021 at 08:52:04AM -0600, William Kucharski wrote: > Correct an error where setting /proc/sys/net/rds/tcp/rds_tcp_rcvbuf would > instead modify the socket's sk_sndbuf and would leave sk_rcvbuf untouched. > > Signed-off-by: William Kucharski Looks like a pretty clear copy-n-paste

Re: [PATCH v3 11/19] media: i2c: rdacm21: Add dealy after OV490 reset

2021-03-19 Thread Kieran Bingham
Hi Jacopo, s/dealy/delay/ in $SUBJECT On 19/03/2021 16:41, Jacopo Mondi wrote: > Add a delay after the OV490 chip is put in reset state. The reset > signal shall be held for at least 250 useconds. > > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/rdacm21.c | 6 +- > 1 file changed,

Re: [PATCH v7 3/3] mtd: rawnand: Add support for secure regions in NAND memory

2021-03-19 Thread Boris Brezillon
On Fri, 19 Mar 2021 20:30:10 +0530 Manivannan Sadhasivam wrote: > On a typical end product, a vendor may choose to secure some regions in > the NAND memory which are supposed to stay intact between FW upgrades. > The access to those regions will be blocked by a secure element like > Trustzone. So

Re: [PATCH v1 1/1] x86/tdx: Add tdcall() and tdvmcall() helper functions

2021-03-19 Thread Sean Christopherson
On Thu, Mar 18, 2021, Kuppuswamy Sathyanarayanan wrote: > diff --git a/arch/x86/kernel/tdx.c b/arch/x86/kernel/tdx.c > index e44e55d1e519..7ae1d25e272b 100644 > --- a/arch/x86/kernel/tdx.c > +++ b/arch/x86/kernel/tdx.c > @@ -4,6 +4,58 @@ > #include > #include > > +void tdcall(u64 leafid, stru

Re: [PATCH] HID: ft260: fix an error message in ft260_i2c_write_read()

2021-03-19 Thread Michael Zaidman
On Fri, Mar 19, 2021 at 02:26:43PM +0100, Jiri Kosina wrote: > On Thu, 18 Mar 2021, Dan Carpenter wrote: > > > The "len" variable is uninitialize. > > > > Fixes: 6a82582d9fa4 ("HID: ft260: add usb hid to i2c host bridge driver") > > Signed-off-by: Dan Carpenter > > --- > > drivers/hid/hid-ft260

Re: [PATCH v7 3/3] mtd: rawnand: Add support for secure regions in NAND memory

2021-03-19 Thread Boris Brezillon
On Fri, 19 Mar 2021 20:30:10 +0530 Manivannan Sadhasivam wrote: > @@ -2737,6 +2783,11 @@ static int nand_read_page_swecc(struct nand_chip > *chip, uint8_t *buf, > uint8_t *ecc_code = chip->ecc.code_buf; > unsigned int max_bitflips = 0; > > + /* Check if the region is secured */

Re: [PATCH v3 3/7] ASoC: codecs: wcd938x: add basic driver

2021-03-19 Thread Pierre-Louis Bossart
On 3/19/21 4:29 AM, Srinivas Kandagatla wrote: This patch adds basic SoundWire codec driver to support for WCD938X TX and RX devices. It took me a while to figure out that you are adding support for a codec that has 2 Slave interfaces internally, one for TX and one for RX dais. Each of th

Re: [PATCH v3 2/7] ASoC: codecs: wcd-clsh: add new version support

2021-03-19 Thread Pierre-Louis Bossart
+static void wcd_clsh_v3_set_hph_mode(struct snd_soc_component *component, + int mode) +{ + u8 val = 0; initialization not needed. + + switch (mode) { + case CLS_H_NORMAL: + val = 0x00; + break; + case CLS_A

Re: [PATCH v3 4/7] ASoC: codecs: wcd938x: add basic controls

2021-03-19 Thread Pierre-Louis Bossart
+static int wcd938x_ear_pa_put_gain(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); + struct wcd938x_sdw_priv *wcd = snd_soc_component_get_drvdata

Re: [PATCH v3 0/7] ASoC: codecs: add wcd938x support

2021-03-19 Thread Pierre-Louis Bossart
On 3/19/21 4:29 AM, Srinivas Kandagatla wrote: This patchset adds support for Qualcomm WCD938X codec. Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC connected over SoundWire. This device has two SoundWire devices, RX and TX respectively supporting 4 x ADCs, ClassH, Ear, A

Re: [PATCH v3 7/7] ASoC: codecs: wcd938x: add audio routing

2021-03-19 Thread Pierre-Louis Bossart
On 3/19/21 4:29 AM, Srinivas Kandagatla wrote: This patch adds audio routing for both playback and capture. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wcd938x.c | 97 ++ 1 file changed, 97 insertions(+) diff --git a/sound/soc/codecs/wcd938

Re: [PATCH 5/6] dma-mapping/iommu: Add dma_set_max_opt_size()

2021-03-19 Thread Robin Murphy
On 2021-03-19 13:25, John Garry wrote: Add a function to allow the max size which we want to optimise DMA mappings for. It seems neat in theory - particularly for packet-based interfaces that might have a known fixed size of data unit that they're working on at any given time - but aren't the

Re: [PATCH v1 1/1] ACPI: scan: Use unique number for instance_no

2021-03-19 Thread Rafael J. Wysocki
On Fri, Mar 12, 2021 at 5:02 PM Andy Shevchenko wrote: > > Current mechanism of incrementing and decrementing plain integer > to get a next free instance_no when creating an ACPI device is fragile. > > In case of hot plug event or namespace removal of the device instances > with the low numbers th

Re: [PATCH 1/6] iommu: Move IOVA power-of-2 roundup into allocator

2021-03-19 Thread John Garry
On 19/03/2021 16:13, Robin Murphy wrote: On 2021-03-19 13:25, John Garry wrote: Move the IOVA size power-of-2 rcache roundup into the IOVA allocator. This is to eventually make it possible to be able to configure the upper limit of the IOVA rcache range. Signed-off-by: John Garry ---   driver

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-19 Thread Jyoti Bhayana
iio/scmi: port driver to the new scmi_sensor_proto_ops interface Port driver to the new SCMI Sensor interface based on protocol handles and common devm_get_ops(). Cc: Jyoti Bhayana Cc: Jonathan Cameron Acked-by: Jyoti Bhayana Signed-off-by: Cristian Marussi On Thu,

arch/powerpc/kernel/optprobes.c:34:1: error: unused function 'is_kprobe_ppc_optinsn_slot'

2021-03-19 Thread kernel test robot
Hi Cédric, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8b12a62a4e3ed4ae99c715034f557eb391d6b196 commit: bb21e1b6c5352d62d866e9236ed427f632cd537b powerpc/optprobes: Make patch_imm64_load_insns() static date: 7

Re: Clang: powerpc: kvm/book3s_hv_nested.c:264:6: error: stack frame size of 2480 bytes in function 'kvmhv_enter_nested_guest'

2021-03-19 Thread Nathan Chancellor
Hi Naresh, Thank you for the testing and report. On Fri, Mar 19, 2021 at 12:50:42PM +0530, Naresh Kamboju wrote: > Linux mainline master build breaks for powerpc defconfig. > There are multiple errors / warnings with clang-12 and clang-11 and 10. > - powerpc (defconfig) with clang-12 > - powerp

Re: [PATCH v2 01/17] add support for Clang CFI

2021-03-19 Thread Paul E. McKenney
On Fri, Mar 19, 2021 at 09:17:14AM -0700, Sami Tolvanen wrote: > On Fri, Mar 19, 2021 at 6:52 AM Paul E. McKenney wrote: > > > > On Fri, Mar 19, 2021 at 01:26:59PM +0100, Peter Zijlstra wrote: > > > On Thu, Mar 18, 2021 at 04:48:43PM -0700, Sami Tolvanen wrote: > > > > On Thu, Mar 18, 2021 at 3:29

Re: [PATCH] md/raid6: Couple of typo fixes

2021-03-19 Thread Randy Dunlap
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: s/boudary/boundary/ s/compliled/compiled/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- crypto/async_tx/raid6test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/async_tx/raid6test.c b/crypto/

Re: [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig

2021-03-19 Thread Russell King - ARM Linux admin
On Thu, Mar 18, 2021 at 05:56:58AM +0100, Christoph Hellwig wrote: > footbridge_defconfig enables CONFIG_IDE but no actual host controller > driver, so just drop it. I have been using the Cypress 82C693 IDE driver on Footbridge for a CD ROM drive, and I know it doesn't work with the PATA driver -

[PATCH v8 00/19] uvcvideo: Fix v4l2-compliance errors

2021-03-19 Thread Ricardo Ribalda
v4l2-compliance -m /dev/media0 -a -f Total for uvcvideo device /dev/media0: 8, Succeeded: 6, Failed: 2, Warnings: 0 Total for uvcvideo device /dev/video0: 54, Succeeded: 50, Failed: 4, Warnings: 2 Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0 Grand Total for uvcvi

[PATCH v8 01/19] media: v4l2-ioctl: Fix check_ext_ctrls

2021-03-19 Thread Ricardo Ribalda
Drivers that do not use the ctrl-framework use this function instead. Fix the following issues: - Do not check for multiple classes when getting the DEF_VAL. - Return -EINVAL for request_api calls - Default value cannot be changed, return EINVAL as soon as possible. - Return the right error_idx [

[PATCH v8 02/19] media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL

2021-03-19 Thread Ricardo Ribalda
The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is written. Cc: Mike Isely Signed-off-by: Ricardo Ribalda Reviewed-by: Hans Verkuil --- drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/dri

[PATCH v8 04/19] media: v4l2-ioctl: S_CTRL output the right value

2021-03-19 Thread Ricardo Ribalda
If the driver does not implement s_ctrl, but it does implement s_ext_ctrls, we convert the call. When that happens we have also to convert back the response from s_ext_ctrls. Fixes v4l2_compliance: Control ioctls (Input 0): fail: v4l2-test-controls.cpp(411): returned control value

[PATCH v8 10/19] media: uvcvideo: Use dev->name for querycap()

2021-03-19 Thread Ricardo Ribalda
Use the device name for the card name instead of vdev->name. Signed-off-by: Hans Verkuil Suggested-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_metadata.c | 2 +- drivers/media/usb/uvc/uvc_v4l2.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)

[PATCH v8 05/19] media: uvcvideo: Remove s_ctrl and g_ctrl

2021-03-19 Thread Ricardo Ribalda
If we do not implement these callback the framework will call the ext_ctrl callbaks instead, which are a superset of this functions. Suggested-by: Hans Verkuil Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_v4l2.c | 56 1 file changed, 56 deletions

[PATCH v8 06/19] media: uvcvideo: Set capability in s_param

2021-03-19 Thread Ricardo Ribalda
Fixes v4l2-compliance: Format ioctls (Input 0): warn: v4l2-test-formats.cpp(1339): S_PARM is supported but doesn't report V4L2_CAP_TIMEPERFRAME fail: v4l2-test-formats.cpp(1241): node->has_frmintervals && !cap->capability Reviewed-by: Laurent Pinchart Reviewed-b

[PATCH v8 07/19] media: uvcvideo: Return -EIO for control errors

2021-03-19 Thread Ricardo Ribalda
The device is doing something unspected with the control. Either because the protocol is not properly implemented or there has been a HW error. Fixes v4l2-compliance: Control ioctls (Input 0): fail: v4l2-test-controls.cpp(448): s_ctrl returned an error (22) test VIDIOC_G/S

[PATCH v8 03/19] media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL

2021-03-19 Thread Ricardo Ribalda
The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is written. Reviewed-by: Hans Verkuil Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_v4l2.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c ind

[PATCH v8 08/19] media: uvcvideo: refactor __uvc_ctrl_add_mapping

2021-03-19 Thread Ricardo Ribalda
Pass the chain instead of the device. We want to keep the reference to the chain that controls belong to. We need to delay the initialization of the controls after the chains have been initialized. This is a cleanup needed for the next patches. Reviewed-by: Laurent Pinchart Reviewed-by: Hans Ve

[PATCH v8 09/19] media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS

2021-03-19 Thread Ricardo Ribalda
Create all the class controls for the device defined controls. Fixes v4l2-compliance: Control ioctls (Input 0): fail: v4l2-test-controls.cpp(216): missing control class for class 0098 fail: v4l2-test-controls.cpp(216): missing control tclass for class 009a

[PATCH v8 13/19] media: uvcvideo: Use control names from framework

2021-03-19 Thread Ricardo Ribalda
The framework already contains a map of IDs to names, lets use it when possible. Signed-off-by: Ricardo Ribalda Reviewed-by: Hans Verkuil Suggested-by: Hans Verkuil --- drivers/media/usb/uvc/uvc_ctrl.c | 57 drivers/media/usb/uvc/uvc_v4l2.c | 8 - drivers/

[PATCH v8 12/19] media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE

2021-03-19 Thread Ricardo Ribalda
Hans has discovered that in his test device, for the H264 format bytesused goes up to about 570, for YUYV it will actually go up to a bit over 5000 bytes, and for MJPG up to about 2706 bytes. We should also, according to V4L2_META_FMT_UVC docs, drop headers when the buffer is full. Credit-to: Han

[PATCH v8 11/19] media: uvcvideo: Set unique vdev name based in type

2021-03-19 Thread Ricardo Ribalda
All the entities must have a unique name. We can have a descriptive and unique name by appending the function and the entity->id. This is even resilent to multi chain devices. Fixes v4l2-compliance: Media Controller ioctls: fail: v4l2-test-media.cpp(205): v2_entity_names_set.find(

[PATCH v8 14/19] media: uvcvideo: Check controls flags before accessing them

2021-03-19 Thread Ricardo Ribalda
We can figure out if reading/writing a set of controls can fail without accessing them by checking their flags. This way we can honor the API closer: If an error is found when validating the list of controls passed with VIDIOC_G_EXT_CTRLS, then error_idx shall be set to ctrls->count to indicate t

[PATCH v8 17/19] media: docs: Document the behaviour of uvcdriver

2021-03-19 Thread Ricardo Ribalda
The uvc driver relies on the camera firmware to keep the control states and therefore is not capable of changing an inactive control. Allow returning -EACESS in those cases. Signed-off-by: Ricardo Ribalda --- Documentation/userspace-api/media/v4l/vidioc-g-ctrl.rst | 5 + Documentation/

[PATCH v8 15/19] media: uvcvideo: Set error_idx during ctrl_commit errors

2021-03-19 Thread Ricardo Ribalda
If we have an error setting a control, return the affected control in the error_idx field. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 42 ++-- drivers/media/usb/uvc/uvc_v4l2.c | 2 +- drivers/media/usb/uvc/uvcvideo.h | 10 +++- 3 files

[PATCH v8 19/19] uvc: use vb2 ioctl and fop helpers

2021-03-19 Thread Ricardo Ribalda
From: Hans Verkuil When uvc was written the vb2 ioctl and file operation helpers didn't exist. This patch switches uvc over to those helpers, which removes a lot of boilerplate code and simplifies VIDIOC_G/S_PRIORITY handling and allows us to drop the 'privileges' scheme, since that's now handl

[PATCH v8 16/19] media: uvcvideo: Return -EACCES to inactive controls

2021-03-19 Thread Ricardo Ribalda
If a control is inactive return -EACCES to let the userspace know that the value will not be applied automatically when the control is active again. Suggested-by: Hans Verkuil Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 71 +--- 1 file chang

[PATCH v8 18/19] media: uvcvideo: Downgrade control error messages

2021-03-19 Thread Ricardo Ribalda
Convert the error into a debug message, so they are still valid for debugging but do not fill dmesg. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc

Re: [PATCH 2/5] mm/page_alloc: Add a bulk page allocator

2021-03-19 Thread Jesper Dangaard Brouer
On Sun, 14 Mar 2021 12:52:32 + Mel Gorman wrote: > mm/page_alloc: Add an array-based interface to the bulk page allocator > > The existing callers for the bulk allocator are storing the pages in > arrays. This patch adds an array-based interface to the API to avoid > multiple list iterations

Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-03-19 Thread Jacob Pan
Hi Jean-Philippe, On Fri, 19 Mar 2021 10:58:41 +0100, Jean-Philippe Brucker wrote: > > Slightly off the title. As we are moving to use cgroup to limit PASID > > allocations, it would be much simpler if we enforce on the current > > task. > > Yes I think we should do that. Is there a problem w

Re: [PATCH] kdb: Refactor kdb_defcmd implementation

2021-03-19 Thread Daniel Thompson
On Tue, Mar 09, 2021 at 05:47:47PM +0530, Sumit Garg wrote: > Switch to use kdbtab_t instead of separate struct defcmd_set since > now we have kdb_register_table() to register pre-allocated kdb commands. This needs rewriting. I've been struggling for some time to figure out what it actually means

RE: [PATCH v2 03/14] x86/retpoline: Simplify retpolines

2021-03-19 Thread David Laight
From: Peter Zijlstra > Sent: 18 March 2021 17:11 > > Due to commit c9c324dc22aa ("objtool: Support stack layout changes > in alternatives"), it is possible to simplify the retpolines. > ... > Notice that since the longest alternative sequence is now: > >0: e8 07 00 00 00 callq c

Re: [PATCH RFC 0/3] drivers/char: remove /dev/kmem for good

2021-03-19 Thread Linus Torvalds
On Fri, Mar 19, 2021 at 7:35 AM David Hildenbrand wrote: > > Let's start a discussion if /dev/kmem is worth keeping around and > fixing/maintaining or if we should just remove it now for good. I'll happily do this for the next merge window, but would really want distros to confirm that they don't

Re: [syzbot] KCSAN: data-race in start_this_handle / start_this_handle

2021-03-19 Thread Paul E. McKenney
On Fri, Mar 19, 2021 at 11:15:42PM +0900, Tetsuo Handa wrote: > On 2021/03/12 0:54, Marco Elver wrote: > >> But the more we could have the compiler automatically figure out > >> things without needing an explicit tag, it would seem to me that this > >> would be better, since manual tagging is going

[PATCH 2/2] soc: qcom: Add Qualcomm Memshare QMI service

2021-03-19 Thread nikitos . tr
From: Nikita Travkin This QMI service provides memory region for remote processors (like modem) on request. It is known to be used in GPS service in modem firmware for some (most) of msm8916 devices. This commit implements "guaranteed allocation" of memory using reserved-memory regions because g

[PATCH 0/2] soc: qcom: Add Qualcomm Memshare QMI service

2021-03-19 Thread nikitos . tr
From: Nikita Travkin This series adds memshare QMI service. It receives messages from other subsystems (like modem subsystem) and answers with a message that contains the memory address of the allocated region. This is used on many msm8916 based devices for location service which requests 2 MB re

Re: [PATCH v30 05/12] LSM: Infrastructure management of the superblock

2021-03-19 Thread Kees Cook
On Tue, Mar 16, 2021 at 09:42:45PM +0100, Mickaël Salaün wrote: > From: Casey Schaufler > > Move management of the superblock->sb_security blob out of the > individual security modules and into the security infrastructure. > Instead of allocating the blobs from within the modules, the modules > t

[PATCH 1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm Memshare service

2021-03-19 Thread nikitos . tr
From: Nikita Travkin Add DT bindings for memshare: QMI service that allocates memory per remote processor request. Signed-off-by: Nikita Travkin --- .../bindings/soc/qcom/qcom,memshare.yaml | 109 ++ include/dt-bindings/soc/qcom,memshare.h | 10 ++ 2 files changed,

Re: [PATCH v30 06/12] fs,security: Add sb_delete hook

2021-03-19 Thread Kees Cook
On Tue, Mar 16, 2021 at 09:42:46PM +0100, Mickaël Salaün wrote: > From: Mickaël Salaün > > The sb_delete security hook is called when shutting down a superblock, > which may be useful to release kernel objects tied to the superblock's > lifetime (e.g. inodes). > > This new hook is needed by Land

Re: [PATCH 1/3] gcov: combine common code

2021-03-19 Thread Peter Oberparleiter
On 15.03.2021 23:54, Johannes Berg wrote: > From: Johannes Berg > > There's a lot of duplicated code between gcc and clang > implementations, move it over to fs.c to simplify the > code, there's no reason to believe that for small data > like this one would not just implement the simple > convert

Re: [PATCH v30 11/12] samples/landlock: Add a sandbox manager example

2021-03-19 Thread Kees Cook
On Tue, Mar 16, 2021 at 09:42:51PM +0100, Mickaël Salaün wrote: > From: Mickaël Salaün > > Add a basic sandbox tool to launch a command which can only access a > list of file hierarchies in a read-only or read-write way. > > Cc: James Morris > Cc: Kees Cook > Cc: Serge E. Hallyn > Signed-off-

Re: [PATCH 3/6] iova: Allow rcache range upper limit to be configurable

2021-03-19 Thread John Garry
On 19/03/2021 16:25, Robin Murphy wrote: On 2021-03-19 13:25, John Garry wrote: Some LLDs may request DMA mappings whose IOVA length exceeds that of the current rcache upper limit. This means that allocations for those IOVAs will never be cached, and always must be allocated and freed from the

Re: [PATCH] mm/page_alloc: try oom if reclaim is unable to make forward progress

2021-03-19 Thread Aaron Tomlin
Hi Michal, On Thu 2021-03-18 17:16 +0100, Michal Hocko wrote: > On Mon 15-03-21 16:58:37, Aaron Tomlin wrote: > > In the situation where direct reclaim is required to make progress for > > compaction but no_progress_loops is already over the limit of > > MAX_RECLAIM_RETRIES consider invoking the o

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 19:30, Minchan Kim пишет: > On Fri, Mar 19, 2021 at 07:24:05PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 18:50, Greg Kroah-Hartman пишет: Then initialization order won't be a problem. >>> I don't understand the problem here, what is wrong with the patch as-is? >> >> The cma->stat

Re: [PATCH RFC 0/3] drivers/char: remove /dev/kmem for good

2021-03-19 Thread Sebastian Andrzej Siewior
On 2021-03-19 10:14:02 [-0700], Linus Torvalds wrote: > On Fri, Mar 19, 2021 at 7:35 AM David Hildenbrand wrote: > > > > Let's start a discussion if /dev/kmem is worth keeping around and > > fixing/maintaining or if we should just remove it now for good. > > I'll happily do this for the next merg

Re: [PATCH v2] kdb: Get rid of custom debug heap allocator

2021-03-19 Thread Daniel Thompson
On Mon, Mar 01, 2021 at 11:33:00AM +0530, Sumit Garg wrote: > On Fri, 26 Feb 2021 at 23:07, Daniel Thompson > wrote: > > > > On Fri, Feb 26, 2021 at 06:12:13PM +0530, Sumit Garg wrote: > > > On Fri, 26 Feb 2021 at 16:29, Daniel Thompson > > > wrote: > > > > > > > > On Fri, Feb 26, 2021 at 03:23:0

Re: [PATCH 2/2] mm: memcontrol: deprecate swapaccounting=0 mode

2021-03-19 Thread Johannes Weiner
On Fri, Mar 19, 2021 at 06:49:55AM -0700, Shakeel Butt wrote: > On Thu, Mar 18, 2021 at 10:49 PM Johannes Weiner wrote: > > > > The swapaccounting= commandline option already does very little > > today. To close a trivial containment failure case, the swap ownership > > tracking part of the swap c

Re: [PATCH 8/9] vfio/pci: export nvlink2 support into vendor vfio_pci drivers

2021-03-19 Thread Alex Williamson
On Fri, 19 Mar 2021 17:34:49 +0100 Christoph Hellwig wrote: > On Fri, Mar 19, 2021 at 01:28:48PM -0300, Jason Gunthorpe wrote: > > The wrinkle I don't yet have an easy answer to is how to load vfio_pci > > as a universal "default" within the driver core lazy bind scheme and > > still have working

Re: [PATCH v14 07/13] iommu/smmuv3: Implement cache_invalidate

2021-03-19 Thread Auger Eric
Hi Chenxiang, On 3/4/21 8:55 AM, chenxiang (M) wrote: > Hi Eric, > > > 在 2021/2/24 4:56, Eric Auger 写道: >> Implement domain-selective, pasid selective and page-selective >> IOTLB invalidations. >> >> Signed-off-by: Eric Auger >> >> --- >> >> v13 -> v14: >> - Add domain invalidation >> - do glob

Re: [PATCH 14/19] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-03-19 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2021-03-19 at 08:24 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > >  drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous > prototype for ‘headc57d_olut’ [-Wmissing-prototypes] > > Cc: Ben Skeggs > Cc: David Airl

Re: [PATCH v3 1/5] arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC

2021-03-19 Thread Catalin Marinas
On Sat, Feb 06, 2021 at 04:35:48PM +0800, Lecopzer Chen wrote: > Linux support KAsan for VMALLOC since commit 3c5c3cfb9ef4da9 > ("kasan: support backing vmalloc space with real shadow memory") > > Like how the MODULES_VADDR does now, just not to early populate > the VMALLOC_START between VMALLOC_E

[PATCH] x86/mce: Add Xeon Sapphire Rapids to list of CPUs that support PPIN

2021-03-19 Thread Tony Luck
New CPU model, same MSRs to control and read the inventory number. Signed-off-by: Tony Luck --- arch/x86/kernel/cpu/mce/intel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/cpu/mce/intel.c b/arch/x86/kernel/cpu/mce/intel.c index e309476743b7..acfd5d9f93c6 100644 --- a/arch

Re: [PATCH v3 0/5] arm64: kasan: support CONFIG_KASAN_VMALLOC

2021-03-19 Thread Catalin Marinas
Hi Lecopzer, On Sat, Feb 06, 2021 at 04:35:47PM +0800, Lecopzer Chen wrote: > Linux supports KAsan for VMALLOC since commit 3c5c3cfb9ef4da9 > ("kasan: support backing vmalloc space with real shadow memory") > > Acroding to how x86 ported it [1], they early allocated p4d and pgd, > but in arm64 I

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 20:29, Dmitry Osipenko пишет: > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count) > +{ > + atomic64_add(count, &cma->nr_pages_succeeded); > +} > + > +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count) > +{ > + atomic64_add(count, &cma->nr_pages_failed);

Re: [PATCH v1 1/1] x86/tdx: Add tdcall() and tdvmcall() helper functions

2021-03-19 Thread Kuppuswamy, Sathyanarayanan
Hi Sean, Thanks for the review. On 3/19/21 9:55 AM, Sean Christopherson wrote: On Thu, Mar 18, 2021, Kuppuswamy Sathyanarayanan wrote: diff --git a/arch/x86/kernel/tdx.c b/arch/x86/kernel/tdx.c index e44e55d1e519..7ae1d25e272b 100644 --- a/arch/x86/kernel/tdx.c +++ b/arch/x86/kernel/tdx.c @@ -

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-19 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 4:45 PM Oleksij Rempel wrote: > > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized for > the touchscreen use case. By implementing it as an IIO ADC device, we can > make use of resistive-adc-touch and iio-hwmon drivers. > > So far, this driver was

Re: [PATCH] ARM: Qualify enabling of swiotlb_init()

2021-03-19 Thread Florian Fainelli
On 3/19/2021 6:07 AM, Christoph Hellwig wrote: > On Thu, Mar 18, 2021 at 09:03:33PM -0700, Florian Fainelli wrote: >> #ifdef CONFIG_ARM_LPAE >> +if (swiotlb_force == SWIOTLB_FORCE || >> +max_pfn > arm_dma_pfn_limit) > > Does arm_dma_pfn_limit do the right thing even with the weirde

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 20:41, Dmitry Osipenko пишет: > 19.03.2021 20:29, Dmitry Osipenko пишет: >> +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count) >> +{ >> +atomic64_add(count, &cma->nr_pages_succeeded); >> +} >> + >> +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count) >> +{ >>

Re: [PATCH v4] hwmon: corsair-psu: add support for critical values

2021-03-19 Thread Guenter Roeck
On 3/19/21 1:58 AM, Wilken Gottwalt wrote: > On Thu, 18 Mar 2021 12:01:50 -0700 > Guenter Roeck wrote: > >> On Thu, Mar 18, 2021 at 03:17:14PM +0100, Wilken Gottwalt wrote: >>> Adds support for reading the critical values of the temperature sensors >>> and the rail sensors (voltage and current) o

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-19 Thread Ben Levinsky
-Original Message- From: Mathieu Poirier Date: Wednesday, March 17, 2021 at 9:27 AM To: Ben Levinsky Cc: "devicet...@vger.kernel.org" , "linux-remotep...@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-ker...@lists.infradead.org" , Michal Simek , "Ed T. Mooring" Sub

Re: [PATCH v12 1/2] scsi: ufs: Enable power management for wlun

2021-03-19 Thread Adrian Hunter
On 19/03/21 2:35 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU to wlun during its runtime-suspend. > During the process blk_queue_enter checks if the queue is not in > su

Re: [PATCH 1/7] mm/page_alloc: Move gfp_allowed_mask enforcement to prepare_alloc_pages

2021-03-19 Thread Mel Gorman
On Fri, Mar 19, 2021 at 05:11:39PM +0100, Vlastimil Babka wrote: > On 3/12/21 4:43 PM, Mel Gorman wrote: > > __alloc_pages updates GFP flags to enforce what flags are allowed > > during a global context such as booting or suspend. This patch moves the > > enforcement from __alloc_pages to prepare_a

Re: [PATCH tip/core/rcu 1/3] rcu: Provide polling interfaces for Tree RCU grace periods

2021-03-19 Thread Paul E. McKenney
On Fri, Mar 19, 2021 at 02:58:54PM +0100, Frederic Weisbecker wrote: > On Wed, Mar 03, 2021 at 04:26:30PM -0800, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There is a need for a non-blocking polling interface for RCU grace > > periods, so this commit supplies start_poll_synchr

[PATCH v4 1/3] mm: disable LRU pagevec during the migration temporarily

2021-03-19 Thread Minchan Kim
LRU pagevec holds refcount of pages until the pagevec are drained. It could prevent migration since the refcount of the page is greater than the expection in migration logic. To mitigate the issue, callers of migrate_pages drains LRU pagevec via migrate_prep or lru_add_drain_all before migrate_page

[PATCH v4 3/3] mm: fs: Invalidate BH LRU during page migration

2021-03-19 Thread Minchan Kim
Pages containing buffer_heads that are in one of the per-CPU buffer_head LRU caches will be pinned and thus cannot be migrated. This can prevent CMA allocations from succeeding, which are often used on platforms with co-processors (such as a DSP) that can only use physically contiguous memory. It c

[PATCH v4 2/3] mm: replace migrate_[prep|finish] with lru_cache_[disable|enable]

2021-03-19 Thread Minchan Kim
Currently, migrate_[prep|finish] is merely a wrapper of lru_cache_[disable|enable]. There is not much to gain from having additional abstraction. Use lru_cache_[disable|enable] instead of migrate_[prep|finish], which would be more descriptive. note: migrate_prep_local in compaction.c changed into

Re: [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig

2021-03-19 Thread Russell King - ARM Linux admin
On Fri, Mar 19, 2021 at 05:07:53PM +, Russell King - ARM Linux admin wrote: > On Thu, Mar 18, 2021 at 05:56:58AM +0100, Christoph Hellwig wrote: > > footbridge_defconfig enables CONFIG_IDE but no actual host controller > > driver, so just drop it. > > I have been using the Cypress 82C693 IDE d

Re: [PATCH] fs/inode.c: Fix a rudimentary typo

2021-03-19 Thread Randy Dunlap
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: s/funtion/function/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- fs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/inode.c b/fs/inode.c index a047ab306f9a..38c2e6b58dc4 100644 --- a/fs/inode.c

Re: arm64: compiler_types.h:320:38: error: call to __compiletime_assert_417

2021-03-19 Thread Catalin Marinas
On Fri, Mar 19, 2021 at 08:49:07PM +0530, Naresh Kamboju wrote: > [This email landed to Spam for some reason, sending it again with modified > subject] > > While building arm64 kernel modules the following kernel warnings / > errors noticed on linux next 20210318 tag the gcc version is 7.3.0. > Bu

Re: [RESEND 00/53] Rid GPU from W=1 warnings

2021-03-19 Thread Daniel Vetter
On Fri, Mar 19, 2021 at 08:24:07AM +, Lee Jones wrote: > On Thu, 18 Mar 2021, Daniel Vetter wrote: > > > On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote: > > > > > > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote: > > > > > > > > On Thu, 11 Mar 2021, Lee Jones wrote: > > > > > > > > > O

Re: [PATCH] average: Mundane typo fix

2021-03-19 Thread Randy Dunlap
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: s/funtions/functions/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- include/linux/average.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/average.h b/include/linux/average.h index a1a8f09631

Re: [RESEND PATCH] Kconfig: Move CONFIG_DEBUG_KMEMLEAK_TEST to samples/Kconfig

2021-03-19 Thread Catalin Marinas
On Thu, Mar 18, 2021 at 02:51:07PM +, chenjun (AM) wrote: > From: Chen Jun > > commit 1abbef4f51724fb11f09adf0e75275f7cb422a8a > ("mm,kmemleak-test.c: move kmemleak-test.c to samples dir") > make CONFIG_DEBUG_KMEMLEAK_TEST depend on CONFIG_SAMPLES implicitly. > And the dependency cannot be gu

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 19:30, Minchan Kim пишет: > +static void cma_kobj_release(struct kobject *kobj) > +{ > + struct cma_kobject *cma_kobj = container_of(kobj, struct cma_kobject, > kobj); > + > + kfree(cma_kobj); > +} Oh, wait.. I think this kfree wrong since cma_kobj belongs to the array.

Re: [PATCH v30 10/12] selftests/landlock: Add user space tests

2021-03-19 Thread Kees Cook
On Tue, Mar 16, 2021 at 09:42:50PM +0100, Mickaël Salaün wrote: > From: Mickaël Salaün > > Test all Landlock system calls, ptrace hooks semantic and filesystem > access-control with multiple layouts. > > Test coverage for security/landlock/ is 93.6% of lines. The code not > covered only deals w

Re: [PATCH] dm: ebs: Several typo fixes

2021-03-19 Thread Randy Dunlap
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: s/retrievd/retrieved/ s/misalignement/misalignment/ s/funtion/function/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- drivers/md/dm-ebs-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH v2 2/2] gpio: Add Realtek Otto GPIO support

2021-03-19 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 5:51 PM Sander Vanheule wrote: > On Wed, 2021-03-17 at 15:08 +0200, Andy Shevchenko wrote: > > On Mon, Mar 15, 2021 at 11:11 PM Sander Vanheule < > > san...@svanheule.net> wrote: ... > > > +#include > > > > Not sure why you need this? See below. > > > + return swa

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-19 Thread Mathieu Poirier
On Thu, Feb 25, 2021 at 07:35:42PM +, Suzuki K Poulose wrote: > From: Anshuman Khandual > > Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is > accessible via the system registers. The TRBE supports different addressing > modes including CPU virtual address and buffer m

<    5   6   7   8   9   10   11   12   13   14   >