Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-03-02 Thread Dave Chinner
On Mon, Mar 01, 2021 at 07:33:28PM -0800, Dan Williams wrote: > On Mon, Mar 1, 2021 at 6:42 PM Dave Chinner wrote: > [..] > > We do not need a DAX specific mechanism to tell us "DAX device > > gone", we need a generic block device interface that tells us "range > > of block device is gone". > > T

[PATCH v9 0/4] pinctrl: pinmux: Add pinmux-select debugfs file

2021-03-02 Thread Drew Fustini
This series first converts the debugfs files in the pinctrl subsystem to octal permissions and then adds a new debugfs file "pinmux-select". Group name and function name can be written to "pinmux-select" which will cause the pin function for the specified group to be activated on the pin controlle

[PATCH v9 1/4] pinctrl: use to octal permissions for debugfs files

2021-03-02 Thread Drew Fustini
Switch over pinctrl debugfs files to use octal permissions as they are preferred over symbolic permissions. Refer to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead"). Note: S_IFREG flag is added to the mode by __debugfs_create_file() in fs/debugfs/inode.c

[PATCH] f2fs: expose # of overprivision segments

2021-03-02 Thread Jaegeuk Kim
This is useful when checking conditions during checkpoint=disable in Android. Signed-off-by: Jaegeuk Kim --- fs/f2fs/sysfs.c | 8 1 file changed, 8 insertions(+) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index e38a7f6921dd..254b6fa17406 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/s

Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-03-02 Thread Dan Williams
On Mon, Mar 1, 2021 at 7:28 PM Darrick J. Wong wrote: > > On Mon, Mar 01, 2021 at 12:55:53PM -0800, Dan Williams wrote: > > On Sun, Feb 28, 2021 at 2:39 PM Dave Chinner wrote: > > > > > > On Sat, Feb 27, 2021 at 03:40:24PM -0800, Dan Williams wrote: > > > > On Sat, Feb 27, 2021 at 2:36 PM Dave Ch

Re: [perf] perf_fuzzer causes crash in intel_pmu_drain_pebs_nhm()

2021-03-02 Thread Vince Weaver
On Mon, 1 Mar 2021, Liang, Kan wrote: > https://lore.kernel.org/lkml/tip-01330d7288e0050c5aaabc558059ff91589e6...@git.kernel.org/ > The patch is an SW workaround for some old CPUs (HSW and earlier), which may > set 0 to the PEBS status. It adds a check in the intel_pmu_drain_pebs_nhm(). > It tries

Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver

2021-03-02 Thread Jason Wang
On 2021/3/2 1:16 下午, Viresh Kumar wrote: On 02-03-21, 13:06, Jie Deng wrote: Yeah. Actually, the backend only needs "struct virtio_i2c_out_hdr out_hdr" and "struct virtio_i2c_in_hdr in_hdr" for communication. So we only need to keep the first two in uapi and move "struct virtio_i2c_req" into t

Re: [PATCH V2] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE

2021-03-02 Thread Christophe Leroy
Le 02/03/2021 à 06:13, Anshuman Khandual a écrit : HUGETLB_PAGE_SIZE_VARIABLE need not be defined for each individual platform subscribing it. Instead just make it generic. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Andrew Morton Cc: Christoph Hellwig Cc: linu

Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-03-02 Thread Dan Williams
On Mon, Mar 1, 2021 at 9:38 PM Dave Chinner wrote: > > On Mon, Mar 01, 2021 at 07:33:28PM -0800, Dan Williams wrote: > > On Mon, Mar 1, 2021 at 6:42 PM Dave Chinner wrote: > > [..] > > > We do not need a DAX specific mechanism to tell us "DAX device > > > gone", we need a generic block device int

[PATCH 2/2] soc: qcom: rpmhpd: Add sc7280 powerdomains

2021-03-02 Thread Rajendra Nayak
Add the power domains exposed by RPMH in the Qualcomm Technologies Inc sc7280 platform Signed-off-by: Rajendra Nayak --- drivers/soc/qcom/rpmhpd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c index 7ce0635..2a0c55f

Re: [PATCH v2 1/2] optee: fix tee out of memory failure seen during kexec reboot

2021-03-02 Thread Allen Pais
From: Allen Pais The following out of memory errors are seen on kexec reboot from the optee core. [0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed [0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22 tee_shm_release() is not invoked on dma shm buffer. Implement

[PATCH 1/2] dt-bindings: power: rpmpd: Add sc7280 to rpmpd binding

2021-03-02 Thread Rajendra Nayak
Add compatible and constants for the power domains exposed by the RPMH in the Qualcomm Technologies Inc sc7280 platform. Signed-off-by: Rajendra Nayak --- Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + include/dt-bindings/power/qcom-rpmpd.h | 11 +++ 2 f

dsa_master_find_slave()'s time complexity and potential performance hit

2021-03-02 Thread DENG Qingfang
Since commit 7b9a2f4bac68 ("net: dsa: use ports list to find slave"), dsa_master_find_slave() has been iterating over a linked list instead of accessing arrays, making its time complexity O(n). The said function is called frequently in DSA RX path, so it may cause a performance hit, especially for

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-02 Thread Andy Lutomirski
On Mon, Mar 1, 2021 at 9:06 PM Tianjia Zhang wrote: > > > > On 3/1/21 5:54 PM, Jarkko Sakkinen wrote: > > On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote: > >> q2 is not always 384-byte length. Sometimes it only has 383-byte. > > > > What does determine this? > > > >> In this case, t

Re: [PATCH v2 3/3] mm/slub: Use percpu partial free counter

2021-03-02 Thread Shu Ming
On Mon, Aug 10, 2020 at 8:22 PM Xunlei Pang wrote: > static inline void > @@ -2429,12 +2439,12 @@ static unsigned long partial_counter(struct > kmem_cache_node *n, > unsigned long ret = 0; > > if (item == PARTIAL_FREE) { > - ret = atomic_long_read(&n->partial_free_

Re: [PATCH v2 3/3] kernel/smp: add more data to CSD lock debugging

2021-03-02 Thread Jürgen Groß
On 01.03.21 18:07, Peter Zijlstra wrote: On Mon, Mar 01, 2021 at 11:13:36AM +0100, Juergen Gross wrote: In order to help identifying problems with IPI handling and remote function execution add some more data to IPI debugging code. There have been multiple reports of cpus looping long times (ma

Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings

2021-03-02 Thread Kalle Valo
Pierre-Louis Bossart writes: > An unsigned long variable should rely on '%lu' format strings, not '%zd' > > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") > Signed-off-by: Pierre-Louis Bossart > --- > warnings found with v5.12-rc1 and next-20210301 Luca, can I take thi

[PATCH v2 3/4] mm: /proc/sys/vm/stat_refresh skip checking known negative stats

2021-03-02 Thread Hugh Dickins
vmstat_refresh() can occasionally catch nr_zone_write_pending and nr_writeback when they are transiently negative. The reason is partly that the interrupt which decrements them in test_clear_page_writeback() can come in before __test_set_page_writeback() got to increment them; but transient negati

[PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-02 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/scsi/ufs/ufshcd.c:1538:8-16: WARNING: use scnprintf or sprintf. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/dr

Re: [PATCH v13 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions

2021-03-02 Thread Gene Chen
Pavel Machek 於 2021年2月19日 週五 下午6:47寫道: > > Hi! > > > From: Gene Chen > > > > Add LED_FUNCTION_MOONLIGHT definitions > > > > Signed-off-by: Gene Chen > > Acked-by: Jacek Anaszewski > > Acked-by: Rob Herring > > No, sorry, I don't believe we need another define for flash/torch. > As previous di

Re: [PATCH] fs: fat: fix spelling typo of values

2021-03-02 Thread OGAWA Hirofumi
dingsen...@163.com writes: > From: dingsenjie > > vaules -> values > > Signed-off-by: dingsenjie Thanks. Acked-by: OGAWA Hirofumi > --- > fs/fat/fatent.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c > index f7e3304..860e884 10064

Re: [f2fs-dev] [PATCH] f2fs: expose # of overprivision segments

2021-03-02 Thread Chao Yu
On 2021/3/2 13:42, Jaegeuk Kim wrote: This is useful when checking conditions during checkpoint=disable in Android. This sysfs entry is readonly, how about putting this at /sys/fs/f2fs//stat/? Signed-off-by: Jaegeuk Kim --- fs/f2fs/sysfs.c | 8 1 file changed, 8 insertions(+) d

[PATCH] w1: ds2708 and ds2781 use the new API kobj_to_dev()

2021-03-02 Thread Tian Tao
fix the below warnning which reported by coccicheck. /drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity for kobj_to_dev(). /drivers/w1/slaves/w1_ds2781.c:90:60-61: WARNING opportunity for kobj_to_dev(). Signed-off-by: Tian Tao --- drivers/w1/slaves/w1_ds2780.c | 2 +- drivers/w1/slaves

linux-next-20210302: build problems with certs

2021-03-02 Thread Randy Dunlap
I'm just guessing here, but I think that some of the certs build infrastructure doesn't handle O=subdir, which is what I use all of the time. $ mkdir build64 $ make ARCH=x86_64 O=build64 all EXTRACT_CERTS ../ At main.c:154: - SSL error:0909006C:PEM routines:get_name:no start line: crypto/pem

[PATCH] hwmon: (nct6883) Support NCT6886d

2021-03-02 Thread Jiqi Li
Add support for NCT6886d chip used in the Lenovo P620. Signed-off-by: Jiqi Li Reviewed-by: Mark Pearson --- drivers/hwmon/nct6683.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c index a23047a3bfe2..3de7bd146965 1006

回复: [PATCH] hwmon: (nct6883) Support NCT6886d

2021-03-02 Thread Jiqi JQ9 Li
Sorry, Please ignore this email as some typos. -邮件原件- 发件人: Jiqi JQ9 Li 发送时间: 2021年3月2日 14:12 收件人: jdelv...@suse.com; li...@roeck-us.net; linux-hw...@vger.kernel.org; linux-kernel@vger.kernel.org 抄送: Mark RH Pearson ; Jiqi JQ9 Li 主题: [PATCH] hwmon: (nct6883) Support NCT6886d Add suppo

[PATCH 04/44] vgacon: comment on vga_rolled_over

2021-03-02 Thread Jiri Slaby
Long time ago, I figured out what this number is good for and documented that locally. But never submitted, so do it now. Signed-off-by: Jiri Slaby Cc: dri-de...@lists.freedesktop.org Cc: linux-fb...@vger.kernel.org --- drivers/video/console/vgacon.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 02/44] MAINTAINERS: drop cyclades.com reference

2021-03-02 Thread Jiri Slaby
cyclades.com is a dead domain. Signed-off-by: Jiri Slaby --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 24abc010d177..7bfca0e2d5ab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4885,7 +4885,6 @@ F:include/uapi/linux/cyclades.h CYCLA

[PATCH 03/44] PCI: remove synclink entries from pci_ids

2021-03-02 Thread Jiri Slaby
The drivers were removed in a1f714b44e34 (tty: Remove redundant synclink driver) and 3d608a591b2b (tty: Remove redundant synclinkmp driver). So remove also the PCI ID entries. Signed-off-by: Jiri Slaby Cc: Bjorn Helgaas Cc: linux-...@vger.kernel.org --- include/linux/pci_ids.h | 2 -- 1 file c

[PATCH 01/44] MAINTAINERS: orphan mxser

2021-03-02 Thread Jiri Slaby
I cannot maintain this driver for years due to missing HW. Let's orphan the entry in MAINTAINERS. And likely drop the driver later as these devices are likely gone from this world. Mxser provides different (out-of-tree) drivers for their current devices. Signed-off-by: Jiri Slaby --- MAINTAINERS

[PATCH 09/44] tty: n_tty, set tty_ldisc_ops::owner

2021-03-02 Thread Jiri Slaby
Set tty_ldisc_ops::owner to THIS_MODULE. This has no effect currently as n_tty cannot be built as a module. If someone ever tries to modularize tty, we wouldn't manage module's reference count as in other ldiscs. So fix this just in case. Signed-off-by: Jiri Slaby --- drivers/tty/n_tty.c | 1 +

[PATCH 10/44] tty: imx, use ms_to_ktime

2021-03-02 Thread Jiri Slaby
This really eliminates multiplications from the assembly. I would have thought they are optimized by inlining ktime_set, but not on x86_64 with gcc 10. Signed-off-by: Jiri Slaby Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team --- drivers/tty/s

[PATCH 13/44] tty: 8250/serial_cs, propagate errors in simple_config

2021-03-02 Thread Jiri Slaby
The caller expects from the others (pfc_config and multi_config) to return standard error values. So do the same for simple_config too. We invert the if condition to handle the error case. Signed-off-by: Jiri Slaby --- drivers/tty/serial/8250/serial_cs.c | 12 ++-- 1 file changed, 6 ins

[PATCH 11/44] tty: 8250, use ms_to_ktime

2021-03-02 Thread Jiri Slaby
This really eliminates multiplications from the assembly. I would have thought they are optimized by inlining ktime_set, but not on x86_64 with gcc 10. Signed-off-by: Jiri Slaby --- drivers/tty/serial/8250/8250_port.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drive

[PATCH 14/44] net: caif: inline register_ldisc

2021-03-02 Thread Jiri Slaby
register_ldisc only calls tty_register_ldisc. Inline register_ldisc into the only caller of register_ldisc, i.e. caif_ser_init. Now, caif_ser_init is symmetric to caif_ser_exit in this regard. Signed-off-by: Jiri Slaby Cc: "David S. Miller" Cc: Jakub Kicinski Cc: net...@vger.kernel.org --- dri

[PATCH 08/44] tty: remove TTY_LDISC_MAGIC

2021-03-02 Thread Jiri Slaby
First, it is never checked. Second, use of it as a debugging aid is at least questionable. With the current tools, I don't think anyone used this kind of thing for debugging purposes for years. On the top of that, e.g. serdev does not set this field of tty_ldisc_ops at all. So get rid of this leg

[PATCH 12/44] tty: 8250, cleanup em485 timers

2021-03-02 Thread Jiri Slaby
Initialize the variables directly by initializers in definitions. This is expected/usual for these kind of callback. Signed-off-by: Jiri Slaby --- drivers/tty/serial/8250/8250_port.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/8250/8

[PATCH 15/44] net: nfc: nci: remove memset of nci_uart_drivers

2021-03-02 Thread Jiri Slaby
nci_uart_drivers is a global definition, so there is no need to initialize its memory to zero during module load. Signed-off-by: Jiri Slaby Cc: "David S. Miller" Cc: Jakub Kicinski Cc: net...@vger.kernel.org --- net/nfc/nci/uart.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/nfc/nci/

[PATCH 06/44] tty: isicom, remove this orphan

2021-03-02 Thread Jiri Slaby
The Isicom driver was orphaned by commit d86b3001a1a6 (MAINTAINERS: orphan isicom) 10 years ago. Noone stepped up to take care of them and to fix all the issues the driver has. So it's time to drop the driver with all its traces. Signed-off-by: Jiri Slaby --- Documentation/admin-guide/devices.t

[PATCH 23/44] tty: nozomi, remove init/exit messages

2021-03-02 Thread Jiri Slaby
Remove useless prints from init and exit functions. The version is artificial anyway. Signed-off-by: Jiri Slaby --- drivers/tty/nozomi.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index 83490925a3e2..1ec975d66528 100644

[PATCH 21/44] tty: jsm_tty, make char+error handling readable

2021-03-02 Thread Jiri Slaby
The code for char+error handling in jsm_input was complete mess of letters. Introduce 3 new local variables and use them with care. Signed-off-by: Jiri Slaby --- drivers/tty/serial/jsm/jsm_tty.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/driver

[PATCH 18/44] tty: con3215, remove tasklet for tty_wakeup

2021-03-02 Thread Jiri Slaby
tty_wakeup is safe to be called from all contexts. No need to schedule a tasklet for that. Let us call it directly like in other drivers. And delete the tasklet completely. Signed-off-by: Jiri Slaby Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux...@de.ibm.com Cc: linux-s...@vger.kernel.or

[PATCH 31/44] tty: xtensa/iss, remove stale comments

2021-03-02 Thread Jiri Slaby
These are likely taken over from amiserial. iss doesn't do anything of that. Signed-off-by: Jiri Slaby Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org --- arch/xtensa/platforms/iss/console.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/arch/xtensa/

[PATCH 33/44] tty: xtensa/iss, make rs_init static

2021-03-02 Thread Jiri Slaby
To fix the warning: warning: no previous prototype for 'rs_init' Signed-off-by: Jiri Slaby Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org --- arch/xtensa/platforms/iss/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/xtensa/platforms/iss/c

[PATCH 25/44] tty: vcc, make globals static

2021-03-02 Thread Jiri Slaby
These are used only in this unit, so make them static. Signed-off-by: Jiri Slaby --- drivers/tty/vcc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index e2d6205f83ce..50bf9011a0c4 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty

[PATCH 26/44] tty: vcc, drop version dump

2021-03-02 Thread Jiri Slaby
The version number is artificial, no need to dump it to logs during initialization. Signed-off-by: Jiri Slaby Cc: "David S. Miller" Cc: --- drivers/tty/vcc.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index 50bf9011a0c4

[PATCH 20/44] tty: con3215, remove tty->driver_data casts

2021-03-02 Thread Jiri Slaby
Casts of 'void *' pointer are superfluous. So remove them. Signed-off-by: Jiri Slaby Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux...@de.ibm.com Cc: linux-s...@vger.kernel.org --- drivers/s390/char/con3215.c | 32 +++- 1 file changed, 11 insertions(+), 21 dele

[PATCH 16/44] net: nfc: nci: drop nci_uart_ops::recv_buf

2021-03-02 Thread Jiri Slaby
There is noone setting nci_uart_ops::recv_buf, so the default one (nci_uart_default_recv_buf) is always used. So drop this hook, move nci_uart_default_recv_buf before the use in nci_uart_tty_receive and remove unused parameter flags. Signed-off-by: Jiri Slaby Cc: "David S. Miller" Cc: Jakub Kici

[PATCH] hwmon: (nct6883) Support NCT6686d

2021-03-02 Thread Jiqi Li
Add support for NCT6686d chip used in the Lenovo P620. Signed-off-by: Jiqi Li Reviewed-by: Mark Pearson --- drivers/hwmon/nct6683.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c index a23047a3bfe2..3de7bd146965 1006

[PATCH 17/44] net: nfc: nci: drop nci_uart_default_recv

2021-03-02 Thread Jiri Slaby
nci_uart_register returns -EINVAL immediately when nu->ops.recv is not set. So the same 'if' later never triggers so nci_uart_default_recv is never used. Drop it. Signed-off-by: Jiri Slaby Cc: "David S. Miller" Cc: Jakub Kicinski Cc: net...@vger.kernel.org --- net/nfc/nci/uart.c | 10 -

[PATCH 29/44] tty: xtensa/iss, drop serial_version & serial_name

2021-03-02 Thread Jiri Slaby
There is no need to print the information during module load. Neither to print some artificial version. So drop these strings and a print. Signed-off-by: Jiri Slaby Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org --- arch/xtensa/platforms/iss/console.c | 7 +-- 1 file c

[PATCH 19/44] tty: con3215, remove unneeded tty checks

2021-03-02 Thread Jiri Slaby
There is no need to check tty in these functions as it's always non-NULL. So remove the tests. Signed-off-by: Jiri Slaby Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux...@de.ibm.com Cc: linux-s...@vger.kernel.org --- drivers/s390/char/con3215.c | 4 1 file changed, 4 deletions(-) di

[PATCH 34/44] tty: do not check tty_unregister_driver's return value

2021-03-02 Thread Jiri Slaby
These drivers check tty_unregister_driver return value. But they don't handle a failure correctly (they free the driver in any case). So stop checking tty_unregister_driver return value and remove also the prints. In the next patch, tty_unregister_driver's return type will be switched to void. Si

[PATCH 28/44] tty: vcc, remove useless tty checks

2021-03-02 Thread Jiri Slaby
All these functions are called with a valid tty pointer, no need to check that. Signed-off-by: Jiri Slaby Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- drivers/tty/vcc.c | 45 - 1 file changed, 45 deletions(-) diff --git a/drivers/tty/vcc.

[PATCH 22/44] tty: nozomi, remove struct buffer

2021-03-02 Thread Jiri Slaby
It is unused. Signed-off-by: Jiri Slaby --- drivers/tty/nozomi.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index 861e95043191..83490925a3e2 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c @@ -359,12 +359,6 @@ struct nozomi {

[PATCH 27/44] tty: vcc, use name strings directly

2021-03-02 Thread Jiri Slaby
Do not define global variables for driver/device names, use the strings directly. Signed-off-by: Jiri Slaby Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- drivers/tty/vcc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c

[PATCH 32/44] tty: xtensa/iss, setup the timer statically

2021-03-02 Thread Jiri Slaby
Use DEFINE_TIMER and avoid runtime initialization of the serial_timer. Signed-off-by: Jiri Slaby Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org --- arch/xtensa/platforms/iss/console.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/xten

[PATCH 30/44] tty: xtensa/iss, don't reassign to tty->port

2021-03-02 Thread Jiri Slaby
We already do tty_port_link_device in rs_init, so we don't need to reassign a port to tty->port. It would be too late in tty::ops::open anyway. Signed-off-by: Jiri Slaby Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org --- arch/xtensa/platforms/iss/console.c | 1 - 1 file ch

[PATCH 24/44] tty: nozomi, remove useless debug prints

2021-03-02 Thread Jiri Slaby
These are either commented out or can be printed by tracing mechanisms. Signed-off-by: Jiri Slaby --- drivers/tty/nozomi.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index 1ec975d66528..9a2d78ace49b 100644 --- a/drivers/tty/nozomi.

[PATCH 35/44] tty: let tty_unregister_driver return void

2021-03-02 Thread Jiri Slaby
Now that noone checks the return value, switch the return type of tty_unregister_driver to void. We can do that as we always return zero. Generally, drivers are not allowed to call tty_unregister_driver while there are open devices. Signed-off-by: Jiri Slaby --- drivers/tty/tty_io.c | 9 +--

[PATCH 37/44] USB: serial/keyspan, drop unneeded forward declarations

2021-03-02 Thread Jiri Slaby
Forward declarations make the code larger, harder to follow and rewrite. Harder as the declarations are often omitted from global changes. Remove forward declarations which are not really needed, i.e. when the definition of the function is before its first use. Signed-off-by: Jiri Slaby Cc: Johan

[PATCH 39/44] tty: synclink_gt, drop unneeded forward declarations

2021-03-02 Thread Jiri Slaby
Forward declarations make the code larger and rewrites harder. Harder as they are often omitted from global changes. Remove forward declarations which are not really needed, i.e. the definition of the function is before its first use. Signed-off-by: Jiri Slaby --- drivers/tty/synclink_gt.c | 57

[PATCH 44/44] tty: make everyone's write_room return >= 0

2021-03-02 Thread Jiri Slaby
The tty line disciplines don't expect tty_operations::write_room to return negative values. Fix the five drivers which violate this. Signed-off-by: Jiri Slaby --- drivers/staging/gdm724x/gdm_tty.c | 2 +- drivers/tty/ipwireless/tty.c | 4 ++-- drivers/tty/n_gsm.c | 2 +- drive

[PATCH 43/44] tty: make everyone's chars_in_buffer return >= 0

2021-03-02 Thread Jiri Slaby
The tty line disciplines don't expect tty_operations::chars_in_buffer to return negative values. Fix the two drivers which violate this. Signed-off-by: Jiri Slaby --- drivers/tty/n_gsm.c | 2 +- drivers/tty/vcc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tt

[PATCH 38/44] USB: serial/io_edgeport, drop unneeded forward declarations

2021-03-02 Thread Jiri Slaby
Forward declarations make the code larger and rewrites harder. Harder as they are often omitted from global changes. Remove forward declarations which are not really needed, i.e. the definition of the function is before its first use. Signed-off-by: Jiri Slaby Cc: Johan Hovold --- drivers/usb/s

[PATCH 40/44] tty: hvc, drop unneeded forward declarations

2021-03-02 Thread Jiri Slaby
Forward declarations make the code larger and rewrites harder. Harder as they are often omitted from global changes. Remove forward declarations which are not really needed, i.e. the definition of the function is before its first use. Signed-off-by: Jiri Slaby Cc: linuxppc-...@lists.ozlabs.org --

[PATCH 36/44] tty: localise ptychar and make it const

2021-03-02 Thread Jiri Slaby
ptychar was not const, so mark it as such. And move this variable to the only place where it's used. Signed-off-by: Jiri Slaby --- drivers/tty/tty_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index c8cbf08b6dcf..7cf57e6cad

Re: [PATCH] w1: ds2708 and ds2781 use the new API kobj_to_dev()

2021-03-02 Thread Greg KH
On Tue, Mar 02, 2021 at 02:17:02PM +0800, Tian Tao wrote: > fix the below warnning which reported by coccicheck. > /drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity for > kobj_to_dev(). > /drivers/w1/slaves/w1_ds2781.c:90:60-61: WARNING opportunity for > kobj_to_dev(). > > Signed-off-by

[PATCH 41/44] tty: n_gsm, remove duplicates of parameters

2021-03-02 Thread Jiri Slaby
dp, f, and i are only duplicates of gsmld_receive_buf's parameters. Use the parameters directly (cp, fp, and count) and delete these local variables. Signed-off-by: Jiri Slaby --- drivers/tty/n_gsm.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/tty/n_

[PATCH 42/44] tty: cleanup tty_chars_in_buffer

2021-03-02 Thread Jiri Slaby
There is no need for 'else' when the 'if' part already returned. This makes tty_chars_in_buffer similar to tty_write_room too. Signed-off-by: Jiri Slaby --- drivers/tty/tty_ioctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioc

[PATCH v3 4/4] kernel/smp: fix flush_smp_call_function_queue() cpu offline detection

2021-03-02 Thread Juergen Gross
The warnings for flushing a logically offline cpu's call_single_queue are gated by a wrong if statement. It should trigger when there have been new requests before dequeueing them, not afterwards. Signed-off-by: Juergen Gross --- V3: - new patch --- kernel/smp.c | 2 +- 1 file changed, 1 inserti

Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver

2021-03-02 Thread Jie Deng
On 2021/3/2 11:43, Viresh Kumar wrote: On 02-03-21, 10:21, Jie Deng wrote: On 2021/3/1 19:54, Viresh Kumar wrote: That's my original proposal. I used to mirror this interface with "struct i2c_msg". But the design philosophy of virtio TC is that VIRTIO devices are not specific to Linux so the

[PATCH v3 1/4] kernel/smp: add boot parameter for controlling CSD lock debugging

2021-03-02 Thread Juergen Gross
Currently CSD lock debugging can be switched on and off via a kernel config option only. Unfortunately there is at least one problem with CSD lock handling pending for about 2 years now, which has been seen in different environments (mostly when running virtualized under KVM or Xen, at least once o

[PATCH v3 2/4] kernel/smp: prepare more CSD lock debugging

2021-03-02 Thread Juergen Gross
In order to be able to easily add more CSD lock debugging data to struct call_function_data->csd move the call_single_data_t element into a sub-structure. Signed-off-by: Juergen Gross --- kernel/smp.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/kernel/sm

[PATCH v3 0/4] kernel/smp.c: add more CSD lock debugging

2021-03-02 Thread Juergen Gross
This patch series was created to help catching a rather long standing problem with smp_call_function_any() and friends. Very rarely a remote cpu seems not to execute a queued function and the cpu queueing that function request will wait forever for the CSD lock to be released by the remote cpu. T

[PATCH v3 3/4] kernel/smp: add more data to CSD lock debugging

2021-03-02 Thread Juergen Gross
In order to help identifying problems with IPI handling and remote function execution add some more data to IPI debugging code. There have been multiple reports of cpus looping long times (many seconds) in smp_call_function_many() waiting for another cpu executing a function like tlb flushing. Mos

Re: [PATCH] exfat: fix erroneous discard when clear cluster bit

2021-03-02 Thread Hyeongseok Kim
On 3/2/21 11:41 AM, Sungjong Seo wrote: Subject: [PATCH] exfat: fix erroneous discard when clear cluster bit If mounted with discard option, exFAT issues discard command when clear cluster bit to remove file. But the input parameter of cluster-to-sector calculation is abnormally adds reserved cl

Re: [PATCH] net/mlx5e: fix mlx5e_tc_tun_update_header_ipv6 dummy definition

2021-03-02 Thread Saeed Mahameed
On Mon, 2021-03-01 at 11:57 +0200, Vlad Buslov wrote: > On Thu 25 Feb 2021 at 14:54, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The alternative implementation of this function in a header file > > is declared as a global symbol, and gets added to every .c file > > that includes it, whi

Re: [PATCH v6 9/9] ALSA: virtio: introduce device suspend/resume support

2021-03-02 Thread Anton Yakovlev
On 28.02.2021 13:05, Takashi Iwai wrote: On Sat, 27 Feb 2021 09:59:56 +0100, Anton Yakovlev wrote: [snip] --- a/sound/virtio/virtio_pcm.c +++ b/sound/virtio/virtio_pcm.c @@ -109,6 +109,7 @@ static int virtsnd_pcm_build_hw(struct virtio_pcm_substream *vss, SNDRV_PCM_INFO_BATC

[PATCH] xattr: switch to vmemdup_user()

2021-03-02 Thread Yang Li
Replace opencoded alloc and copy with vmemdup_user() fixed the following coccicheck: ./fs/xattr.c:561:11-19: WARNING opportunity for vmemdup_user Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/xattr.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/xattr

[PATCH] riscv: kasan: remove unneeded semicolon

2021-03-02 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./arch/riscv/mm/kasan_init.c:217:2-3: Unneeded semicolon. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- arch/riscv/mm/kasan_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/mm/kasan_init.c b/arch/riscv/mm/k

Re: [PATCH V2] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE

2021-03-02 Thread Anshuman Khandual
On 3/2/21 11:13 AM, Christophe Leroy wrote: > > > Le 02/03/2021 à 06:13, Anshuman Khandual a écrit : >> HUGETLB_PAGE_SIZE_VARIABLE need not be defined for each individual >> platform subscribing it. Instead just make it generic. >> >> Cc: Michael Ellerman >> Cc: Benjamin Herrenschmidt >> Cc:

Re: [PATCH 5.4 000/340] 5.4.102-rc1 review

2021-03-02 Thread Hanjun Guo
Hi Greg, On 2021/3/2 0:09, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.102 release. There are 340 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should

Re: [PATCHv2 3/4] coresight: etm4x: Add support to exclude kernel mode tracing

2021-03-02 Thread Sai Prakash Ranjan
On 2021-03-02 04:13, Doug Anderson wrote: Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: On production systems with ETMs enabled, it is preferred to exclude kernel mode(NS EL1) tracing for security concerns and support only userspace(NS EL0) tracing. Perf subsystem interface us

Re: [PATCHv2 2/4] perf evsel: Print warning for excluding kernel mode instruction tracing

2021-03-02 Thread Sai Prakash Ranjan
Hi On 2021-03-02 04:13, Doug Anderson wrote: Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: Add a warning message to check CONFIG_EXCLUDE_KERNEL_HW_ITRACE kernel config which excludes kernel mode instruction tracing to help perf tool users identify the perf event open failure

Re: [RFC PATCH 1/8] RISC-V: Enable CPU_IDLE drivers

2021-03-02 Thread Anup Patel
On Fri, Feb 26, 2021 at 6:46 PM Alex Ghiti wrote: > > Hi Anup, > > Le 2/21/21 à 4:37 AM, Anup Patel a écrit : > > We force select CPU_PM and provide asm/cpuidle.h so that we can > > use CPU IDLE drivers for Linux RISC-V kernel. > > > > Signed-off-by: Anup Patel > > --- > > arch/riscv/Kconfig

Re: [PATCHv2 4/4] coresight: etm3x: Add support to exclude kernel mode tracing

2021-03-02 Thread Sai Prakash Ranjan
On 2021-03-02 04:13, Doug Anderson wrote: Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: On production systems with ETMs enabled, it is preferred to exclude kernel mode(NS EL1) tracing for security concerns and support only userspace(NS EL0) tracing. Perf subsystem interface us

Re: [PATCH 29/44] tty: xtensa/iss, drop serial_version & serial_name

2021-03-02 Thread Max Filippov
On Mon, Mar 1, 2021 at 10:22 PM Jiri Slaby wrote: > > There is no need to print the information during module load. Neither to > print some artificial version. So drop these strings and a print. > > Signed-off-by: Jiri Slaby > Cc: Chris Zankel > Cc: Max Filippov > Cc: linux-xte...@linux-xtensa.

[PATCH v8 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-03-02 Thread Liu Ying
Hi, This is the v8 series to introduce i.MX8qm/qxp Display Processing Unit(DPU) DRM support. DPU is comprised of a blit engine for 2D graphics, a display controller and a command sequencer. Outside of DPU, optional prefetch engines can fetch data from memory prior to some DPU fetchunits of blit

[PATCH v8 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2021-03-02 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * Fix commit message typo - s/Artifically/Artif

[PATCH v8 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2021-03-02 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob)

[PATCH v8 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2021-03-02 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema. So, drop Rob's R-b tag as review is needed. v4->v5: * No change. v3->v4: * Improve compati

[PATCH v8 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2021-03-02 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob

[PATCH v8 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2021-03-02 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAINTAINERS | 9 + 1 file changed, 9 insertio

Re: [PATCH 32/44] tty: xtensa/iss, setup the timer statically

2021-03-02 Thread Max Filippov
On Mon, Mar 1, 2021 at 10:22 PM Jiri Slaby wrote: > > Use DEFINE_TIMER and avoid runtime initialization of the serial_timer. > > Signed-off-by: Jiri Slaby > Cc: Chris Zankel > Cc: Max Filippov > Cc: linux-xte...@linux-xtensa.org > --- > arch/xtensa/platforms/iss/console.c | 11 --- > 1

Re: [PATCH 5.4 000/340] 5.4.102-rc1 review

2021-03-02 Thread Greg Kroah-Hartman
On Tue, Mar 02, 2021 at 02:42:15PM +0800, Hanjun Guo wrote: > Hi Greg, > > On 2021/3/2 0:09, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.102 release. > > There are 340 patches in this series, all will be posted as a response > > to this one. If anyone ha

Re: [PATCH] perf stat: improve readability of shadow stats

2021-03-02 Thread kajoljain
On 3/1/21 10:54 PM, Changbin Du wrote: > This does follow two changes: > 1) Select appropriate unit between K/M/G. > 2) Use 'cpu-sec' instead of 'sec' to state this is not the wall-time. > > $ sudo ./perf stat -a -- sleep 1 > > Before: Unit 'M' is selected even the number is very small. >

Re: [PATCH 33/44] tty: xtensa/iss, make rs_init static

2021-03-02 Thread Max Filippov
On Mon, Mar 1, 2021 at 10:22 PM Jiri Slaby wrote: > > To fix the warning: > warning: no previous prototype for 'rs_init' > > Signed-off-by: Jiri Slaby > Cc: Chris Zankel > Cc: Max Filippov > Cc: linux-xte...@linux-xtensa.org > --- > arch/xtensa/platforms/iss/console.c | 2 +- > 1 file changed,

RE: [PATCH v4 1/2] exfat: introduce bitmap_lock for cluster bitmap access

2021-03-02 Thread Sungjong Seo
> s_lock which is for protecting concurrent access of file operations is too > huge for cluster bitmap protection, so introduce a new bitmap_lock to > narrow the lock range if only need to access cluster bitmap. > > Signed-off-by: Hyeongseok Kim Looks good. Thanks for your work! Acked-by: Sungj

Re: [PATCH v6 9/9] ALSA: virtio: introduce device suspend/resume support

2021-03-02 Thread Takashi Iwai
On Tue, 02 Mar 2021 07:29:20 +0100, Anton Yakovlev wrote: > > On 28.02.2021 13:05, Takashi Iwai wrote: > > On Sat, 27 Feb 2021 09:59:56 +0100, > > Anton Yakovlev wrote: > >> > > [snip] > > >> --- a/sound/virtio/virtio_pcm.c > >> +++ b/sound/virtio/virtio_pcm.c > >> @@ -109,6 +109,7 @@ static int

<    1   2   3   4   5   6   7   8   9   10   >