Re: [PATCH 25/41] arm64: dts: qcom: sdm660: Make the DTS an overlay on top of 630

2021-02-26 Thread Konrad Dybcio
Ditto, AngeloGioacchino Del Regno Konrad Dybcio Martin Botka

Re: [PATCH 20/41] arm64: dts: qcom: sdm630: Add Adreno 508 GPU configuration

2021-02-26 Thread Konrad Dybcio
Ditto, AngeloGioacchino Del Regno Konrad Dybcio

Re: [PATCH 26/41] arm64: dts: qcom: Add device tree for SDM636

2021-02-26 Thread Konrad Dybcio
Ditto, AngeloGioacchino Del Regno Konrad Dybcio Martin Botka

Re: [PATCH] [RFC] arm64: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION

2021-02-26 Thread Fangrui Song
On 2021-02-25, Arnd Bergmann wrote: From: Arnd Bergmann When looking at kernel size optimizations, I found that arm64 does not currently support HAVE_LD_DEAD_CODE_DATA_ELIMINATION, which enables the --gc-sections flag to the linker. I see that for a defconfig build with llvm, there are some no

Re: [PATCH] kunit: tool: Fix a python tuple typing error

2021-02-26 Thread Brendan Higgins
On Mon, Feb 22, 2021 at 9:49 PM 'David Gow' via KUnit Development wrote: > > The first argument to namedtuple() should match the name of the type, > which wasn't the case for KconfigEntryBase. > > Fixing this is enough to make mypy show no python typing errors again. > > Fixes 97752c39bd ("kunit:

Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
On 2/26/21 2:07 PM, Peter Zijlstra wrote: On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote: + /* avoid false negative lockdep_assert_not_held() +* and lockdep_assert_held() +*/ That's a coding style fail. Checkpatch didn't complain. Wh

Re: [PATCH] ASoC: Intel: boards: sof-wm8804: add check for PLL setting

2021-02-26 Thread Pierre-Louis Bossart
On 2/26/21 12:56 PM, Colin King wrote: From: Colin Ian King Currently the return from snd_soc_dai_set_pll is not checking for failure, this is the only driver in the kernel that ignores this, so it probably should be added for sake of completeness. Fix this by adding an error return check.

[PATCH v2] cxl: Make loop variable be 'i' instead of 'j'

2021-02-26 Thread Konrad Rzeszutek Wilk
.. otherwise people spend extra cycles looking for the inner loop and wondering 'why j'? This was an oversight when initial work was rebased so let's fix it here. Signed-off-by: Konrad Rzeszutek Wilk --- v1: Initial posting v2: Fix per Dan's request --- drivers/cxl/mem.c | 6 +++--- 1 file chan

Re: [PATCH v1 01/12] gna: add driver module

2021-02-26 Thread Jianxun Zhang
> On Feb 26, 2021, at 10:29 AM, Maciej Kwapulinski > wrote: > > > Andy Shevchenko writes: > >> On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski >> wrote: >>> > >>> +#define GNA_DRV_VER"1.2.0" >> >> Nowadays the version is the Git SHA sum. >> > > right, "version" is present

Re: [PATCH V3 XRT Alveo 03/18] fpga: xrt: xclbin file helper functions

2021-02-26 Thread Lizhi Hou
Hi Tom, On 02/21/2021 09:12 AM, Tom Rix wrote: On 2/17/21 10:40 PM, Lizhi Hou wrote: Alveo FPGA firmware and partial reconfigure file are in xclbin format. This code enumerates and extracts Will change this to Alveo FPGA firmware and partial reconfigure file are in xclbin format. This code

[PATCH 1/2] use usb headers rather than define structs locally

2021-02-26 Thread George Harker
Use struct definitions from linux/usb/midi.h rather than locally define the structs in sound/usb/midi.c . Signed-off-by: George Harker --- sound/usb/midi.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/sound/usb/midi.c b/sound/usb/midi.c index 0c23fa6d

Re: [PATCH] copy_file_range.2: Kernel v5.12 updates

2021-02-26 Thread Alejandro Colomar (man-pages)
Hello Jeff, On 2/26/21 2:59 PM, Jeff Layton wrote: Here's a link that should work. I'm probably breaking the rules a bit as a subscriber, but hopefully Jon won't mind too much. FWIW, I've found it to be worthwhile to subscribe to LWN if you're doing a lot of kernel development: https://lwn

[PATCH 2/2] midi streaming substream names from jack names A number of devices have named substreams which are hard to remember / decypher from MIDI n names. Eg. Korg puts a pass through on

2021-02-26 Thread George Harker
This makes it easier to connect to the correct device. Devices which handle naming through quirks are unaffected by this change. Addresses TODO comment in sound/usb/midi.c Signed-off-by: George Harker --- sound/usb/midi.c | 103 --- sound/usb/midi.h

Re: [PATCH] drm/amd/pm/swsmu: Remove unnecessary conversion to bool

2021-02-26 Thread Alex Deucher
On Fri, Feb 26, 2021 at 4:17 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:924:47-52: > WARNING: conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks!

Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-02-26 Thread Dave Chinner
On Fri, Feb 26, 2021 at 12:59:53PM -0800, Dan Williams wrote: > On Fri, Feb 26, 2021 at 12:51 PM Dave Chinner wrote: > > > > On Fri, Feb 26, 2021 at 11:24:53AM -0800, Dan Williams wrote: > > > On Fri, Feb 26, 2021 at 11:05 AM Darrick J. Wong > > > wrote: > > > > > > > > On Fri, Feb 26, 2021 at 0

Re: [PATCH] swiotlb: swiotlb_tbl_map_single() kernel BUG in iommu-helper.h:30

2021-02-26 Thread Konrad Rzeszutek Wilk
_slots = get_max_slots(boundary_mask); > > Could you double-check please? > > > Yes this is squashed in the snippet you are showing. The bug was introduced > in > next-20210222 and is still there when I updated to next-20210226 today. Duh! It should be fixed now for the next one. Thank you!

Re: [PATCH] drm/amd/display/dc/dce/dmub_psr: Remove unnecessary conversion to bool

2021-02-26 Thread Alex Deucher
On Fri, Feb 26, 2021 at 4:42 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c:273:16-21: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex > --

Re: [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency

2021-02-26 Thread Vladimir Oltean
On Thu, Feb 25, 2021 at 03:38:32PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When the ocelot driver code is in a library, the dsa tag > code cannot be built-in: > > ld.lld: error: undefined symbol: ocelot_can_inject > >>> referenced by tag_ocelot_8021q.c > >>> dsa/tag_o

Re: [PATCH/v3] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-02-26 Thread Willem de Bruijn
On Fri, Feb 26, 2021 at 3:15 PM Cong Wang wrote: > > On Thu, Feb 25, 2021 at 7:59 PM Xuesen Huang wrote: > > v3: > > - Fix the code format. > > > > v2: > > Suggested-by: Willem de Bruijn > > - Add a new flag to specify the type of the inner packet. > > These need to be moved after '---', otherwi

Re: KASAN: use-after-free Read in __cpuhp_state_remove_instance

2021-02-26 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:d01f2f7e Add linux-next specific files for 20210226 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=114fa9ccd0 kernel config: https://syzkaller.appspot.com/x/.config?x

Re: [PATCH 2/2] midi streaming substream names from jack names A number of devices have named substreams which are hard to remember / decypher from MIDI n names. Eg. Korg puts a pass through

2021-02-26 Thread George Harker
Thanks for the feedback, addressed in the two patches. I’m not sure why it pulled the body up into the title.I’m sorry about that. I can resubmit if that needs fixing. George

Re: [PATCH] iommu/amd: Fix event counter availability check

2021-02-26 Thread Paul Menzel
[cc: +suravee, +jörg] Dear Alex, dear Shuah, dear Suravee, dear Jörg, Am 03.06.20 um 08:54 schrieb Alexander Monakov: On Tue, 2 Jun 2020, Shuah Khan wrote: I changed the logic to read config to get max banks and counters before checking if counters are writable and tried writing to all. The

fs/xfs/xfs_rtalloc.c:898:1: warning: stack frame size of 1048 bytes in function 'xfs_growfs_rt'

2021-02-26 Thread kernel test robot
volume date: 5 months ago config: mips-randconfig-r034-20210226 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project b889ef4214bc6dc8880fdd4badc0dcd9a3197753) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests

Re: #pragma once (was Re: incoming)

2021-02-26 Thread Linus Torvalds
On Fri, Feb 26, 2021 at 12:17 PM Alexey Dobriyan wrote: > > I want to sent treewide "#pragma once" conversion: Are there *any* advantages to it? It's non-standard, and the historical argument for it ("it can reduce compile times because the preprocessor doesn't open the file twice" is pure and u

Re: [PATCH 1/2] gpio: fix NULL-deref-on-deregistration regression

2021-02-26 Thread Saravana Kannan
On Fri, Feb 26, 2021 at 6:55 AM Johan Hovold wrote: > > Fix a NULL-pointer deference when deregistering the gpio character > device that was introduced by the recent stub-driver hack. When the new > "driver" is unbound as part of deregistration, driver core clears the > driver-data pointer which i

[GIT PULL] OpenRISC updates for 5.12

2021-02-26 Thread Stafford Horne
Hi Linus, Please consider for pull. Note the starting point shows up a bit strange as I had to merge in 5.11 fixes to resolve some conflicts pointed out by linux-next. The below are the changes since v5.11. The following changes since commit 031c7a8cd6fc565e90320bf08f22ee6e70f9d969: openrisc

Re: [PATCH] iommu/amd: Fix event counter availability check

2021-02-26 Thread Shuah Khan
On 2/26/21 2:44 PM, Paul Menzel wrote: [cc: +suravee, +jörg] Dear Alex, dear Shuah, dear Suravee, dear Jörg, Am 03.06.20 um 08:54 schrieb Alexander Monakov: On Tue, 2 Jun 2020, Shuah Khan wrote: I changed the logic to read config to get max banks and counters before checking if counters are

Re: [PATCH] tpm/ppi: Constify static struct attribute_group

2021-02-26 Thread Rikard Falkeborn
On Fri, Feb 05, 2021 at 04:04:18AM +0200, Jarkko Sakkinen wrote: > On Thu, Feb 04, 2021 at 10:54:27PM +0100, Rikard Falkeborn wrote: > > The only usage of ppi_attr_grp is to put its address in an array of > > pointers to const struct attribute_group. Make it const to allow the > > compiler to put i

Re: [PATCH V3 XRT Alveo 05/18] fpga: xrt: group platform driver

2021-02-26 Thread Max Zhen
Hi Tom, On 2/22/21 10:50 AM, Tom Rix wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. On 2/17/21 10:40 PM, Lizhi Hou wrote: group driver that manages life cycle

Re: KASAN: use-after-free Read in __cpuhp_state_remove_instance

2021-02-26 Thread Jens Axboe
On 2/26/21 2:33 PM, syzbot wrote: > syzbot has found a reproducer for the following issue on: > > HEAD commit:d01f2f7e Add linux-next specific files for 20210226 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=114fa9ccd0 > ker

Re: [PATCH v6 1/4] bus: mhi: core: Destroy SBL devices when moving to mission mode

2021-02-26 Thread Hemant Kumar
On 2/24/21 3:23 PM, Bhaumik Bhatt wrote: Currently, client devices are created in SBL or AMSS (mission mode) and only destroyed after power down or SYS ERROR. When moving between certain execution environments, such as from SBL to AMSS, no clean-up is required. This presents an issue where SBL

[PATCH] ext4: Add xattr commands to compat ioctl handler

2021-02-26 Thread Sarthak Kukreti
This allows 32-bit userspace utils to use FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR on a 64-bit kernel. Signed-off-by: Sarthak Kukreti --- fs/ext4/ioctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index f0381876a7e5b..055c26296ab46 100644 --- a/fs/ext

[PATCH] perf trace: Ensure read cmdlines are null terminated.

2021-02-26 Thread Ian Rogers
Issue detected by address sanitizer. Fixes: cd4ceb63438e (perf util: Save pid-cmdline mapping into tracing header) Signed-off-by: Ian Rogers --- tools/perf/util/trace-event-read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-even

Re: [PATCH] copy_file_range.2: Kernel v5.12 updates

2021-02-26 Thread Alejandro Colomar (man-pages)
Hello Amir, Luis, On 2/24/21 5:10 PM, Amir Goldstein wrote: On Wed, Feb 24, 2021 at 4:22 PM Luis Henriques wrote: Update man-page with recent changes to this syscall. Signed-off-by: Luis Henriques --- Hi! Here's a suggestion for fixing the manpage for copy_file_range(). Note that I've ass

Re: [PATCH] ext4: Add xattr commands to compat ioctl handler

2021-02-26 Thread Eric Biggers
On Fri, Feb 26, 2021 at 02:14:41PM -0800, Sarthak Kukreti wrote: > This allows 32-bit userspace utils to use FS_IOC_FSGETXATTR and > FS_IOC_FSSETXATTR on a 64-bit kernel. > > Signed-off-by: Sarthak Kukreti > --- > fs/ext4/ioctl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/ex

[PATCH v8] pgo: add clang's Profile Guided Optimization infrastructure

2021-02-26 Thread Bill Wendling
From: Sami Tolvanen Enable the use of clang's Profile-Guided Optimization[1]. To generate a profile, the kernel is instrumented with PGO counters, a representative workload is run, and the raw profile data is collected from /sys/kernel/debug/pgo/profraw. The raw profile data must be processed by

Re: [PATCH 0/2] tracing: Detect unsafe dereferencing of pointers from trace events

2021-02-26 Thread Linus Torvalds
On Fri, Feb 26, 2021 at 11:07 AM Steven Rostedt wrote: > > The first patch scans the print fmts of the trace events looking for > dereferencing pointers from %p*, and making sure that they refer back > to the trace event itself. > > The second patch handles strings "%s" [..] Doing this at runtime

Re: [PATCH v8 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-26 Thread Drew Fustini
On Sat, Feb 20, 2021 at 12:27:47PM -0800, Drew Fustini wrote: > This series first converts the debugfs files in the pinctrl subsystem to > octal permissions and then adds a new debugfs file "pinmux-select". > > Group name and function name can be written to "pinmux-select" which > will cause the p

[PATCH v3] cxl: Make loop variable be 'i' instead of 'j'

2021-02-26 Thread Konrad Rzeszutek Wilk
.. otherwise people spend extra cycles looking for the inner loop and wondering 'why j'? This was an oversight when initial work was rebased so let's fix it here. Signed-off-by: Konrad Rzeszutek Wilk --- v1: Initial posting v2: Fix per Dan's request v3: Duh, don't initialize i in the loop, but d

Re: [GIT PULL] Documentation fixes for 5.12

2021-02-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Feb 2021 11:54:04 -0700: > git://git.lwn.net/linux.git tags/docs-5.12-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3fb6d0e00efc958d01c2f109c8453033a2d96796 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org

Re: [GIT PULL] s390 patches for the 5.12 merge window #2

2021-02-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Feb 2021 21:02:08 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git tags/s390-5.12-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e7270e47a09e83051da7b2bee71be00741860ec4 Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] CIFS/SMB3 Fixes

2021-02-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Feb 2021 00:24:14 -0600: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-smb3-part1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c19798af2e66d9d3eb1060873bb435ea8bf4ad2e Thank you! -- Deet-doot-dot, I am a bot. https://kor

Re: [GIT PULL] LEDs changes for 5.12-rc1

2021-02-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Feb 2021 13:18:48 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/ > tags/leds-5.12-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fecfd015394e9151f535d675e115fba967bddb3f Thank you! -- Deet-doot-

Re: [GIT PULL] pcmcia updates for v5.12

2021-02-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Feb 2021 06:50:29 +0100: > https://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git pcmcia-next has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/360db2b422f16305e5b8523b4b730521fbc8fb5d Thank you! -- Deet-doot-dot, I am a bo

Re: [GIT PULL] OpenRISC updates for 5.12

2021-02-26 Thread pr-tracker-bot
The pull request you sent on Sat, 27 Feb 2021 06:56:19 +0900: > g...@github.com:openrisc/linux.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a3905af5be36b9aa9f17657a02eeb2a08e939c13 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kerne

Re: [GIT PULL] (swiotlb) stable/for-linus-5.12

2021-02-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Feb 2021 11:00:08 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git > stable/for-linus-5.12 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ef9856a734af9bc71e5a8554374380e200fe7fc4 Thank you! -- Deet-doot-

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-02-26 Thread Andrew Lunn
On Mon, Feb 15, 2021 at 11:38:21AM -0800, Don Bollinger wrote: > optoe is an i2c based driver that supports read/write access to all > the pages (tables) of MSA standard SFP and similar devices (conforming > to the SFF-8472 spec), MSA standard QSFP and similar devices (conforming > to the SFF-8636

Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-02-26 Thread Dan Williams
On Fri, Feb 26, 2021 at 1:28 PM Dave Chinner wrote: > > On Fri, Feb 26, 2021 at 12:59:53PM -0800, Dan Williams wrote: > > On Fri, Feb 26, 2021 at 12:51 PM Dave Chinner wrote: > > > > > > On Fri, Feb 26, 2021 at 11:24:53AM -0800, Dan Williams wrote: > > > > On Fri, Feb 26, 2021 at 11:05 AM Darrick

Re: possible deadlock in sk_clone_lock

2021-02-26 Thread Shakeel Butt
On Fri, Feb 26, 2021 at 2:09 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:577c2835 Add linux-next specific files for 20210224 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=137cef82d0 > kernel config: https:

Re: [PATCH 1/2] KVM: vmx/pmu: Fix dummy check if lbr_desc->event is created

2021-02-26 Thread Sean Christopherson
On Wed, Feb 24, 2021, Xu, Like wrote: > On 2021/2/24 1:15, Sean Christopherson wrote: > > On Tue, Feb 23, 2021, Like Xu wrote: > > > If lbr_desc->event is successfully created, the intel_pmu_create_ > > > guest_lbr_event() will return 0, otherwise it will return -ENOENT, > > > and then jump to LBR

[PATCH 1/2] list: Add list_is_null() to check if a list_head has been initialized

2021-02-26 Thread Laurent Pinchart
From: Laurent Pinchart The new function checks if the list_head prev and next pointers are NULL, in order to see if a list_head that has been zeroed when allocated has been initialized with INIT_LIST_HEAD() or added to a list. This can be used in cleanup functions that want to support being safe

[PATCH 2/2] media: v4l2-async: Safely unregister an non-registered async subdev

2021-02-26 Thread Laurent Pinchart
From: Laurent Pinchart Make the V4L2 async framework a bit more robust by allowing to unregister a non-registered async subdev. Otherwise the v4l2_async_cleanup() will attempt to delete the async subdev from the subdev_list with the corresponding list_head not initialized. Signed-off-by: Laurent

Re: KASAN: use-after-free Read in __cpuhp_state_remove_instance

2021-02-26 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:d01f2f7e Add linux-next specific files for 20210226 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17208f22d0 kernel config: https://syzkaller.appspot.com/x/.config?x

Re: [PATCH v2] block: Add bio_max_segs

2021-02-26 Thread Jens Axboe
On 2/26/21 1:38 PM, Matthew Wilcox wrote: > > This seems to have missed the merge window ;-( It ain't over yet, and I haven't shipped my final bits for 5.12 for block yet... I'll queue it up. -- Jens Axboe

Re: [PATCH v8] pgo: add clang's Profile Guided Optimization infrastructure

2021-02-26 Thread Bill Wendling
On Fri, Feb 26, 2021 at 2:20 PM Bill Wendling wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data is collected from > /sys/k

Re: #pragma once (was Re: incoming)

2021-02-26 Thread Alexey Dobriyan
On Fri, Feb 26, 2021 at 01:53:48PM -0800, Linus Torvalds wrote: > On Fri, Feb 26, 2021 at 12:17 PM Alexey Dobriyan wrote: > > > > I want to sent treewide "#pragma once" conversion: > > Are there *any* advantages to it? > > It's non-standard, It is effectively standard: https://en.wikipedia.org/

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-26 Thread Xie He
On Fri, Feb 26, 2021 at 6:21 AM Martin Schiller wrote: > > I have now had a look at it. It works as expected. > I just wonder if it would not be more appropriate to call > the lapb_register() already in x25_hdlc_open(), so that the layer2 > (lapb) can already "work" before the hdlc_x25 interface i

Re: [RFC 00/19] Rework support for i.MX8MQ interconnect with devfreq

2021-02-26 Thread Chanwoo Choi
Hi, You missed sending the patches to linux-pm mailing list. On next version, please send it linux-pm. Thanks, Chanwoo Choi On 21. 2. 20. 오전 12:59, Abel Vesa wrote: This has been on my queue for quite some time now. It is more of a proof-of-concept. This rework is done with the compatibility

Re: possible deadlock in sk_clone_lock

2021-02-26 Thread Mike Kravetz
Cc: Michal On 2/26/21 2:44 PM, Shakeel Butt wrote: > On Fri, Feb 26, 2021 at 2:09 PM syzbot > wrote: >> other info that might help us debug this: >> >> Possible interrupt unsafe locking scenario: >> >>CPU0CPU1 >> >> lock(hugetlb_

[PATCH] media: i2c: adp1653: fix error handling from a call to adp1653_get_fault

2021-02-26 Thread Colin King
From: Colin Ian King The error check on rval from the call to adp1653_get_fault currently returns if rval is non-zero. This appears to be incorrect as the following if statement checks for various bit settings in rval so clearly rval is expected to be non-zero at that point. Coverity flagged the

Re: [PATCH 0/2] tracing: Detect unsafe dereferencing of pointers from trace events

2021-02-26 Thread Steven Rostedt
On Fri, 26 Feb 2021 14:21:00 -0800 Linus Torvalds wrote: > > The second patch handles strings "%s" [..] > > Doing this at runtime really feels like the wrong thing to do. > > It won't even protect us from what happened - people like me and > Andrew won't even run those tracepoints in the firs

[PATCH] drivers/media/usb/gspca/stv06xx: fix memory leak

2021-02-26 Thread Pavel Skripkin
Syzbot reported memory leak in hdcs_probe_1x00()[1]. hdcs_probe_1x00() allocates memory for struct hdcs, but if hdcs_init() fails in gspca_dev_probe2() this memory becomes leaked. int gspca_dev_probe2(struct usb_interface *intf, const struct usb_device_id *id, cons

Re: [PATCH 1/3] net: mscc: ocelot: select NET_DEVLINK

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 15:38:31 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > Without this option, the driver fails to link: > > ld.lld: error: undefined symbol: devlink_sb_register > [...] > > Fixes: f59fd9cab730 ("net: mscc: ocelot: configure watermarks using > devlink-sb") > Signed-o

[PATCH] drivers/media/usb/gspca/stv06xx: fix memory leak

2021-02-26 Thread Pavel Skripkin
Syzbot reported memory leak in hdcs_probe_1x00()[1]. hdcs_probe_1x00() allocates memory for struct hdcs, but if hdcs_init() fails in gspca_dev_probe2() this memory becomes leaked. int gspca_dev_probe2(struct usb_interface *intf, const struct usb_device_id *id, cons

Re: [PATCH net] net: dsa: mt7530: don't build GPIO support if !GPIOLIB

2021-02-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 26 Feb 2021 14:32:26 +0800 you wrote: > The new GPIO support may be optional at runtime, but it requires > building against gpiolib: > > ERROR: modpost: "gpiochip_get_data" [drivers/net/dsa/mt7530.ko] > undefined! > ERR

Re: [PATCH] perf tools: Move feature cleanup under tools/build

2021-02-26 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2021 at 04:08:31PM +0100, Jiri Olsa escreveu: > Arnaldo reported issue for following build command: > > $ rm -rf /tmp/krava; mkdir /tmp/krava; make O=/tmp/krava clean > CLEANconfig > /bin/sh: line 0: cd: /tmp/krava/feature/: No such file or directory > ../../scripts/M

Re: [PATCH] net: phy: make mdio_bus_phy_suspend/resume as __maybe_unused

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 23:53:20 +0100 Andrew Lunn wrote: > On Thu, Feb 25, 2021 at 03:57:27PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When CONFIG_PM_SLEEP is disabled, the compiler warns about unused > > functions: > > > > drivers/net/phy/phy_device.c:273:12: error: unused funct

Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 07:23:31 -0800 Richard Cochran wrote: > On Thu, Feb 25, 2021 at 10:15:16PM +0100, Heiko Thiery wrote: > > When accessing the timecounter register on an i.MX8MQ the kernel hangs. > > This is only the case when the interface is down. This can be reproduced > > by reading with 'phc

Re: [PATCH] perf buildid-cache: Add test for PE executable

2021-02-26 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 25, 2021 at 09:35:04PM +0100, Jiri Olsa escreveu: > On Wed, Feb 24, 2021 at 02:59:16PM -0500, Nicholas Fraser wrote: > > From 9fd0b3889f00ad13662879767d833309d8a035b6 Mon Sep 17 00:00:00 2001 > > From: Nicholas Fraser > > Date: Thu, 18 Feb 2021 13:24:03 -0500 > > Subject: [PATCH] perf

Re: [PATCH v2 0/3] Add some perf support for mips

2021-02-26 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2021 at 09:11:17AM +0800, Tiezhu Yang escreveu: > On 02/25/2021 09:12 PM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 25, 2021 at 10:10:12AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Feb 25, 2021 at 09:49:56AM -0300, Arnaldo Carvalho de Melo > > > escreveu: > > >

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 15:44:42 +0800 Huazhong Tan wrote: > From: Guangbin Huang > > If phy uses generic driver and autoneg is on, enter command > "ethtool -s eth0 speed 50" will not change phy speed actually, but > command "ethtool eth0" shows speed is 50Mb/s because phydev->speed > has been set to

[PATCH] scsi: vmw_pvscsi: Update maintainer

2021-02-26 Thread Vishal Bhakta
The entries in the source files are removed as well. Signed-off-by: Vishal Bhakta --- MAINTAINERS | 2 +- drivers/scsi/vmw_pvscsi.c | 2 -- drivers/scsi/vmw_pvscsi.h | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 97c8f2bb8de2..

Re: possible deadlock in sk_clone_lock

2021-02-26 Thread Shakeel Butt
On Fri, Feb 26, 2021 at 3:14 PM Mike Kravetz wrote: > > Cc: Michal > > On 2/26/21 2:44 PM, Shakeel Butt wrote: > > On Fri, Feb 26, 2021 at 2:09 PM syzbot > > wrote: > > >> other info that might help us debug this: > >> > >> Possible interrupt unsafe locking scenario: > >> > >>CPU0

[PATCH v3 0/3] Add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
Some kernel functions must not be called holding a specific lock. Doing so could lead to locking problems. Currently these routines call lock_is_held() to check for lock hold followed by WARN_ON. Adding a common lockdep interface will help reduce the duplication of this logic in the rest of the ke

[PATCH v3 2/3] lockdep: add lockdep lock state defines

2021-02-26 Thread Shuah Khan
Adds defines for lock state returns from lock_is_held_type() based on Johannes Berg's suggestions as it make it easier to read and maintain the lock states. These are defines and a enum to avoid changes to lock_is_held_type() and lockdep_is_held() return types. Updates to lock_is_held_type() and

[PATCH v3 1/3] lockdep: add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
Some kernel functions must be called without holding a specific lock. Add lockdep_assert_not_held() to be used in these functions to detect incorrect calls while holding a lock. lockdep_assert_not_held() provides the opposite functionality of lockdep_assert_held() which is used to assert calls tha

[PATCH v3 3/3] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-26 Thread Shuah Khan
ath10k_drain_tx() must not be called with conf_mutex held as workers can use that also. Add call to lockdep_assert_not_held() on conf_mutex to detect if conf_mutex is held by the caller. The idea for this patch stemmed from coming across the comment block above the ath10k_drain_tx() while reviewin

Re: [PATCH v8 20/22] counter: Implement events_queue_size sysfs attribute

2021-02-26 Thread David Lechner
On 2/25/21 6:03 PM, William Breathitt Gray wrote: On Sun, Feb 21, 2021 at 03:51:40PM +, Jonathan Cameron wrote: On Thu, 18 Feb 2021 19:32:16 +0900 William Breathitt Gray wrote: On Sun, Feb 14, 2021 at 06:11:46PM +, Jonathan Cameron wrote: On Fri, 12 Feb 2021 21:13:44 +0900 William Br

[PATCH] ALSA: ctxfi: cthw20k2: fix mask on conf to allow 4 bits

2021-02-26 Thread Colin King
From: Colin Ian King Currently the mask operation on variable conf is just 3 bits so the switch statement case value of 8 is unreachable dead code. The function daio_mgr_dao_init can be passed a 4 bit value, function dao_rsc_init calls it with conf set to: conf = (desc->msr & 0x7) | (desc->

Re: [PATCH v8 20/22] counter: Implement events_queue_size sysfs attribute

2021-02-26 Thread William Breathitt Gray
On Fri, Feb 26, 2021 at 06:14:12PM -0600, David Lechner wrote: > On 2/25/21 6:03 PM, William Breathitt Gray wrote: > > On Sun, Feb 21, 2021 at 03:51:40PM +, Jonathan Cameron wrote: > >> On Thu, 18 Feb 2021 19:32:16 +0900 > >> William Breathitt Gray wrote: > >> > >>> On Sun, Feb 14, 2021 at 06:

Re: [PATCH v2] media: add a subsystem profile documentation

2021-02-26 Thread Randy Dunlap
Hi Mauro- On 2/25/21 5:41 AM, Mauro Carvalho Chehab wrote: > Document the basic policies of the media subsystem profile. > > Signed-off-by: Mauro Carvalho Chehab > --- > > v2: fix the Documentation/*/media directories > > > Documentation/driver-api/media/index.rst | 2 + > .../media/

[PATCH 3/3] nvmem: core: nvmem_cell_read() should return the true size

2021-02-26 Thread Douglas Anderson
If we look at the gpu speed bin currently in sc7180.dtsi: gpu_speed_bin: gpu_speed_bin@1d2 { reg = <0x1d2 0x2>; bits = <5 8>; }; We can see that this is an 8-bit value. However we had to specify the "reg" as 16 bits because the value was spread out over two bytes. It doesn't make sen

[PATCH 2/3] nvmem: core: Allow nvmem_cell_read_u16/32/64 to read smaller cells

2021-02-26 Thread Douglas Anderson
The current way that cell "length" is specified for nvmem cells is a little fuzzy. For instance, let's look at the gpu speed bin currently in sc7180.dtsi: gpu_speed_bin: gpu_speed_bin@1d2 { reg = <0x1d2 0x2>; bits = <5 8>; }; This is an 8-bit value (as specified by the "bits" field).

[PATCH 1/3] drm/msm: Fix speed-bin support not to access outside valid memory

2021-02-26 Thread Douglas Anderson
When running the latest kernel on an sc7180 with KASAN I got this splat: BUG: KASAN: slab-out-of-bounds in a6xx_gpu_init+0x618/0x644 Read of size 4 at addr ff8088f36100 by task kworker/7:1/58 CPU: 7 PID: 58 Comm: kworker/7:1 Not tainted 5.11.0+ #3 Hardware name: Google Lazor (rev1 - 2)

[PATCH 0/3] nvmem: Bring a tiny bit of sanity to reading 16/32/64 bits from nvmem

2021-02-26 Thread Douglas Anderson
This series was inspried by a KASAN warning that I got at bootup caused by the GPU driver on my system interfacing with the nvmem API incorrectly. I have posted a fix for the GPU driver but looking at this nvmem entry made me question how the nvmem API was supposed to work. I've proposed some impr

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Andrew Lunn
On Fri, Feb 26, 2021 at 03:44:42PM +0800, Huazhong Tan wrote: > From: Guangbin Huang > > If phy uses generic driver and autoneg is on, enter command > "ethtool -s eth0 speed 50" will not change phy speed actually, but > command "ethtool eth0" shows speed is 50Mb/s because phydev->speed > has been

Re: [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus

2021-02-26 Thread Doug Anderson
Hi, On Fri, Feb 26, 2021 at 10:45 AM Stephen Boyd wrote: > > Quoting Douglas Anderson (2021-02-25 14:13:10) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > > b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > > new file mode 100644 > > index ..5def9953d82b

Re: [PATCH v2 2/3] mm: Force update of mem cgroup soft limit tree on usage excess

2021-02-26 Thread Tim Chen
On 2/26/21 12:52 AM, Michal Hocko wrote: >> >> Michal, >> >> Let's take an extreme case where memcg 1 always generate the >> first event and memcg 2 generates the rest of 128*8-1 events >> and the pattern repeat. > > I do not follow. Events are per-memcg, aren't they? > __this_cpu_read(m

Re: [PATCH] RISC-V: Make NUMA depend on SMP

2021-02-26 Thread Kefeng Wang
On 2021/2/27 4:25, Palmer Dabbelt wrote: From: Palmer Dabbelt In theory these are orthogonal, but in practice all NUMA systems are SMP. NUMA && !SMP doesn't build, everyone else is coupling them, and I don't really see any value in supporting that configuration. Fixes: 4f0e8eef772e ("riscv:

Re: [f2fs-dev] [PATCH v3] f2fs: compress: Allow modular (de)compression algorithms

2021-02-26 Thread Chao Yu
On 2021/2/26 23:51, Geert Uytterhoeven wrote: If F2FS_FS is modular, enabling the compressions options F2FS_FS_{LZ4,LZ4HZ,LZO,LZORLE,ZSTD} will make the (de)compression algorithms {LZ4,LZ4HC,LZO,ZSTD}_{,DE}COMPRESS builtin instead of modular, as the former depend on an intermediate boolean F2FS_F

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Huazhong Tan
On 2021/2/27 7:56, Jakub Kicinski wrote: On Fri, 26 Feb 2021 15:44:42 +0800 Huazhong Tan wrote: From: Guangbin Huang If phy uses generic driver and autoneg is on, enter command "ethtool -s eth0 speed 50" will not change phy speed actually, but command "ethtool eth0" shows speed is 50Mb/s bec

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Huazhong Tan
On 2021/2/27 8:53, Andrew Lunn wrote: On Fri, Feb 26, 2021 at 03:44:42PM +0800, Huazhong Tan wrote: From: Guangbin Huang If phy uses generic driver and autoneg is on, enter command "ethtool -s eth0 speed 50" will not change phy speed actually, but command "ethtool eth0" shows speed is 50Mb/s

Re: [PATCH 1/2] mm: Guard a use of node_reclaim_distance with CONFIFG_NUMA

2021-02-26 Thread Hugh Dickins
On Fri, 26 Feb 2021, Andrew Morton wrote: > On Fri, 26 Feb 2021 12:17:20 -0800 Palmer Dabbelt wrote: > > From: Palmer Dabbelt > > > > This is only useful under CONFIG_NUMA. IIUC skipping the check is the > > right thing to do here, as without CONFIG_NUMA there will never be any > > large node d

Re: [PATCH 5.10 00/23] 5.10.19-rc1 review

2021-02-26 Thread Hanjun Guo
On 2021/2/26 14:44, Hanjun Guo wrote: Hi Greg, On 2021/2/25 17:53, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.19 release. There are 23 patches in this series, all will be posted as a response to this one.  If anyone has any issues with these being applie

Current mainline

2021-02-26 Thread Steve French
Has anyone seen this? I was running some xfstests today on current mainline (ran same tests yesterday and multiple times last week on 5.11 and did not see this) and hit this multiple times [ 287.702292] [ cut here ] [ 287.702296] WARNING: CPU: 5 PID: 8223 at drivers/gpu/

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-26 Thread Kefeng Wang
On 2021/2/27 4:19, Cong Wang wrote: On Thu, Feb 25, 2021 at 5:39 PM Kefeng Wang wrote: On 2021/2/26 5:22, Cong Wang wrote: On Wed, Feb 24, 2021 at 8:03 AM Kefeng Wang wrote: HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig"), use CONF

arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for function 'fdt_check_mem_start'

2021-02-26 Thread kernel test robot
passed DTB date: 4 weeks ago config: arm-randconfig-r003-20210226 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project b889ef4214bc6dc8880fdd4badc0dcd9a3197753) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests

RE: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-02-26 Thread Don Bollinger
On Fri, Feb 26, 2021 at 2:35 PM -0800, Andrew Lunn wrote: > On Mon, Feb 15, 2021 at 11:38:21AM -0800, Don Bollinger wrote: > > optoe is an i2c based driver that supports read/write access to all > > the pages (tables) of MSA standard SFP and similar devices (conforming > > to the SFF-8472 spec), MS

Re: [PATCH 1/2] mm: Guard a use of node_reclaim_distance with CONFIFG_NUMA

2021-02-26 Thread Palmer Dabbelt
On Fri, 26 Feb 2021 17:31:40 PST (-0800), hu...@google.com wrote: On Fri, 26 Feb 2021, Andrew Morton wrote: On Fri, 26 Feb 2021 12:17:20 -0800 Palmer Dabbelt wrote: > From: Palmer Dabbelt > > This is only useful under CONFIG_NUMA. IIUC skipping the check is the > right thing to do here, as wi

[PATCH V2 net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Huazhong Tan
From: Guangbin Huang If phy uses generic driver and autoneg is on, enter command "ethtool -s eth0 speed 50" will not change phy speed actually, but command "ethtool eth0" shows speed is 50Mb/s because phydev->speed has been set to 50 and no update later. And duplex setting has same problem too.

<    3   4   5   6   7   8   9   >