Re: [PATCH v2 1/4] hmm: Device exclusive memory access

2021-02-18 Thread kernel test robot
Hi Alistair, Thank you for the patch! Yet something to improve: [auto build test ERROR on kselftest/next] [also build test ERROR on linus/master v5.11 next-20210218] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Viresh Kumar
On 19-02-21, 11:38, Yue Hu wrote: > There's a possibility: we will use the previous freq to update if next_f > is reduced for busy CPU if need_freq_update is set in > sugov_update_next_freq(). Right. > This possibility would happen now? And this > update is what we want if it happens? This is ex

Re: [PATCH] fs: export kern_path_locked

2021-02-18 Thread Al Viro
On Tue, Feb 16, 2021 at 06:00:34PM +, Al Viro wrote: > Sigh... OK, so we want something like > user_path_create() > vfs_mknod() > created = true > grab bindlock > > drop bindlock > if failed && created > vfs_unlink() > done_pa

[GIT PULL] xfs: new code for 5.12

2021-02-18 Thread Darrick J. Wong
Hi Linus, Please pull the following branch containing all the new xfs code for 5.12. There's a lot going on this time, which seems about right for this drama-filled year. Community developers added some code to speed up freezing when read-only workloads are still running, refactored the logging

[PATCH] scsi: arcmsr: catch bounds error earlier and dont panic

2021-02-18 Thread Tong Zhang
pARCMSR_CDB is calculated from a base address + a value read from controller with some bit shifting, the value is not checked and could possibly overflow the buffer and cause panic. The buffer is allocated using dma_alloc_coherent and the size is acb->uncache_size. Instead of crashing the system, w

Re: [PATCH v8 0/3] CPUFreq: Add support for opp-sharing cpus

2021-02-18 Thread Viresh Kumar
On 18-02-21, 22:23, Nicola Mazzucato wrote: > Hi Viresh, > > In this V8 I have addressed your comments: > - correct the goto in patch 1/3 > - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() LGTM. I will apply them after the merge window is over. Thanks. -- viresh

[PATCH 1/8] af_unix: take address assignment/hash insertion into a new helper

2021-02-18 Thread Al Viro
Duplicated logics in all bind variants (autobind, bind-to-path, bind-to-abstract) gets taken into a common helper. Signed-off-by: Al Viro --- net/unix/af_unix.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_u

[PATCH 2/8] unix_bind(): allocate addr earlier

2021-02-18 Thread Al Viro
>From 24439dbb7b78cb301c73254b364020e6a3f31902 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Thu, 18 Feb 2021 15:52:53 -0500 Subject: [PATCH 2/8] unix_bind(): allocate addr earlier makes it easier to massage; we do pay for that by extra work (kmalloc+memcpy+kfree) in some error cases, but those ar

[PATCH 3/8] unix_bind(): separate BSD and abstract cases

2021-02-18 Thread Al Viro
We do get some duplication that way, but it's minor compared to parts that are different. What we get is an ability to change locking in BSD case without making failure exits very hard to follow. Signed-off-by: Al Viro --- net/unix/af_unix.c | 52

[PATCH 4/8] unix_bind(): take BSD and abstract address cases into new helpers

2021-02-18 Thread Al Viro
unix_bind_bsd() and unix_bind_abstract() respectively. Signed-off-by: Al Viro --- net/unix/af_unix.c | 144 +++-- 1 file changed, 74 insertions(+), 70 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 11e18b0efbc6..d7aeb48277

[PATCH 5/8] fold unix_mknod() into unix_bind_bsd()

2021-02-18 Thread Al Viro
Signed-off-by: Al Viro --- net/unix/af_unix.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index d7aeb4827747..36b88c8c438b 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -984,45

[PATCH 7/8] unix_bind_bsd(): unlink if we fail after successful mknod

2021-02-18 Thread Al Viro
We can do that more or less safely, since the parent is held locked all along. Yes, somebody might observe the object via dcache, only to have it disappear afterwards, but there's really no good way to prevent that. It won't race with other bind(2) or attempts to move the sucker elsewhere, or put

[PATCH 6/8] unix_bind_bsd(): move done_path_create() call after dealing with ->bindlock

2021-02-18 Thread Al Viro
Final preparations for doing unlink on failure past the successful mknod. We can't hold ->bindlock over ->mknod() or ->unlink(), since either might do sb_start_write() (e.g. on overlayfs). However, we can do it while holding filesystem and VFS locks - doing kern_path_create() vfs_

[PATCH 8/8] __unix_find_socket_byname(): don't pass hash and type separately

2021-02-18 Thread Al Viro
We only care about exclusive or of those, so pass that directly. Makes life simpler for callers as well... Signed-off-by: Al Viro --- net/unix/af_unix.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index bb4

amdgpu, 5.11.0, suicide when input of monitor is switched

2021-02-18 Thread Norbert Preining
Hi all After switching inputs of the display I use (two computers are connected, one via DP and the current one via HDMI), the AMD GPU I use stopped sending signals to the display. The kernel log showed the following: [ 262.300879] [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *E

Re: [PATCH v2 1/4] hmm: Device exclusive memory access

2021-02-18 Thread Alistair Popple
9 February 2021 3:04:07 PM AEDT kernel test robot wrote: > External email: Use caution opening links or attachments > > > Hi Alistair, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on kselftest/next] > [also build test ERRO

Re: [PATCH v8 2/6] arm64: hyperv: Add Hyper-V clocksource/clockevent support

2021-02-18 Thread kernel test robot
Hi Michael, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on tip/timers/core efi/next linus/master v5.11 next-20210218] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH V3 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-02-18 Thread Viresh Kumar
On 18-02-21, 16:36, Ionela Voinescu wrote: > Yes, we don't care if there is no cpufreq driver, as the use of AMUs won't > get initialised either. But we do care if there is a cpufreq driver that > does not support frequency invariance, which is the example above. > > The intention with the patches

Re: [PATCH v2 1/4] hmm: Device exclusive memory access

2021-02-18 Thread kernel test robot
Hi Alistair, Thank you for the patch! Yet something to improve: [auto build test ERROR on kselftest/next] [also build test ERROR on linus/master v5.11 next-20210218] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices

2021-02-18 Thread Srinivasan Raju
Hi, Please find a few responses to the comments , We will fix rest of the comments and submit v14 of the patch. > Also, you *really* need some validation here, rather than blindly > trusting that the file is well-formed, otherwise you immediately have a > security issue here. The firmware is si

Re: [PATCH V3 XRT Alveo 00/18] XRT Alveo driver overview

2021-02-18 Thread Lizhi Hou
On 02/18/2021 05:52 AM, Tom Rix wrote: On 2/17/21 10:40 PM, Lizhi Hou wrote: Hello, This is V3 of patch series which adds management physical function driver for Xilinx Alveo PCIe accelerator cards, https://www.xilinx.com/products/boards-and-kits/alveo.html This driver is part of Xilinx Ru

Re: Re: [PATCH] ASoC: Intel: Skylake: Fix missing check in skl_pcm_trigger

2021-02-18 Thread dinghao . liu
> > On 2/15/21 7:13 AM, Dinghao Liu wrote: > > When cmd == SNDRV_PCM_TRIGGER_STOP, we should also check > > the return value of skl_decoupled_trigger() just like what > > we have done in case SNDRV_PCM_TRIGGER_PAUSE_RELEASE. > > > > Signed-off-by: Dinghao Liu > > --- > > sound/soc/intel/skylake/

Re: [PATCH V7 5/6] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi

2021-02-18 Thread Frank Rowand
Hi Viresh, I am in the wrong version with the comments below. You are at version 8 now. -Frank On 2/18/21 3:02 PM, Frank Rowand wrote: > On 1/29/21 1:24 AM, Viresh Kumar wrote: >> In order to build-test the same unit-test files using fdtoverlay tool, >> move the device nodes from the existing o

Re: [PATCH V7 5/6] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi

2021-02-18 Thread Viresh Kumar
On 18-02-21, 23:20, Frank Rowand wrote: > Hi Viresh, > > I am in the wrong version with the comments below. You are at version 8 now. Yeah, it is fine. I have updated the patches already based on your comments. -- viresh

[PATCH 2/4] iommu/vt-d: Enable write protect propagation from guest

2021-02-18 Thread Jacob Pan
Write protect bit, when set, inhibits supervisor writes to the read-only pages. In guest supervisor shared virtual addressing (SVA), write-protect should be honored upon guest bind supervisor PASID request. This patch extends the VT-d portion of the IOMMU UAPI to include WP bit. WPE bit of the su

Re: [PATCH] staging: emxx_udc: remove unused variable driver_desc

2021-02-18 Thread Greg Kroah-Hartman
On Thu, Feb 18, 2021 at 10:41:07PM -0500, Sean Behan wrote: > Signed-off-by: Sean Behan > --- > drivers/staging/emxx_udc/emxx_udc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > b/drivers/staging/emxx_udc/emxx_udc.c > index 3536c03ff523..741147a4f

[PATCH 0/4] Misc vSVA fixes for VT-d

2021-02-18 Thread Jacob Pan
Hi Baolu et al, This is a collection of SVA-related fixes. Thanks, Jacob Jacob Pan (4): iommu/vt-d: Enable write protect for supervisor SVM iommu/vt-d: Enable write protect propagation from guest iommu/vt-d: Reject unsupported page request modes iommu/vt-d: Calculate and set flags for h

[PATCH 1/4] iommu/vt-d: Enable write protect for supervisor SVM

2021-02-18 Thread Jacob Pan
Write protect bit, when set, inhibits supervisor writes to the read-only pages. In supervisor shared virtual addressing (SVA), where page tables are shared between CPU and DMA, IOMMU PASID entry WPE bit should match CR0.WP bit in the CPU. This patch sets WPE bit for supervisor PASIDs if CR0.WP is s

[PATCH 3/4] iommu/vt-d: Reject unsupported page request modes

2021-02-18 Thread Jacob Pan
When supervisor/privilige mode SVM is used, we bind init_mm.pgd with a supervisor PASID. There should not be any page fault for init_mm. Execution request with DMA read is also not supported. This patch checks PRQ descriptor for both unsupported configurations, reject them both with invalid respon

[PATCH 4/4] iommu/vt-d: Calculate and set flags for handle_mm_fault

2021-02-18 Thread Jacob Pan
Page requests are originated from the user page fault. Therefore, we shall set FAULT_FLAG_USER.  FAULT_FLAG_REMOTE indicates that we are walking an mm which is not guaranteed to be the same as the current->mm and should not be subject to protection key enforcement. Therefore, we should set FAULT_F

Re: [PATCH v2 1/2] mm: Make alloc_contig_range handle free hugetlb pages

2021-02-18 Thread Oscar Salvador
On 2021-02-19 03:10, Mike Kravetz wrote: Those counts will be wrong as there are no huge pages on the node. I'll think about this more tomorrow. Pretty sure this is an issue, but I could be wrong. Just wanted to give a heads up. Yes, this is a problem, although the fixup would be to check w

Re: [PATCH] perf machine: Use true and false for bool variable

2021-02-18 Thread kajoljain
On 2/18/21 2:54 PM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./tools/perf/util/machine.c:2000:9-10: WARNING: return of 0/1 in > function 'symbol__match_regex' with return type bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > tools/perf/util/

RE: [PATCH 2/4] iommu/vt-d: Enable write protect propagation from guest

2021-02-18 Thread Tian, Kevin
> From: Jacob Pan > Sent: Friday, February 19, 2021 5:31 AM > > Write protect bit, when set, inhibits supervisor writes to the read-only > pages. In guest supervisor shared virtual addressing (SVA), write-protect > should be honored upon guest bind supervisor PASID request. > > This patch extend

[PATCH] btrfs: Remove unused variable ret

2021-02-18 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./fs/btrfs/disk-io.c:4403:5-8: Unneeded variable: "ret". Return "0" on line 4411. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- fs/btrfs/disk-io.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/disk-io.c

Re: [PATCH] staging: i2400m: use explicit host byte-order types in comparison

2021-02-18 Thread Greg Kroah-Hartman
On Fri, Feb 19, 2021 at 06:00:47AM +0530, karthik alapati wrote: > convert le32 types to host byte-order types before > comparison That says what you did, but not _why_ you did it. Please fix up and resend. thanks, greg k-h

Re: [PATCH ghak124 v3] audit: log nftables configuration change events

2021-02-18 Thread Richard Guy Briggs
On 2021-02-18 23:42, Florian Westphal wrote: > Richard Guy Briggs wrote: > > > If they appear in a batch tehy will be ignored, if the batch consists of > > > such non-modifying ops only then nf_tables_commit() returns early > > > because the transaction list is empty (nothing to do/change). > > >

Re: [PATCH] kthread: add kthread_mod_pending_delayed_work api

2021-02-18 Thread Yiwei Zhang‎
> 2. User triggered clean up races with the clean up triggered by > timeout. You try to handle this scenario by this patch. Yes, exactly. > 3. User does clean up after the clean up has already been done > by the timeout. This case is well handled. So only (2) has a potential race. Let me clar

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Yue Hu
On Fri, 19 Feb 2021 09:39:33 +0530 Viresh Kumar wrote: > On 19-02-21, 11:38, Yue Hu wrote: > > There's a possibility: we will use the previous freq to update if > > next_f is reduced for busy CPU if need_freq_update is set in > > sugov_update_next_freq(). > > Right. > > > This possibility wou

[PATCH] btrfs: ref-verify: use 'inline void' keyword ordering

2021-02-18 Thread Randy Dunlap
Fix build warnings of function signature when CONFIG_STACKTRACE is not enabled by reordering the 'inline' and 'void' keywords. ../fs/btrfs/ref-verify.c:221:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] static void inline __save_stack_trace(struct ref_action *r

Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type

2021-02-18 Thread Dan Carpenter
No problem. These days I have fibre to my house, but I still remember trying to clone the kernel when I could only buy 20MB of data at a time. :P regards, dan carpenter

Re: [PATCH] Staging: rtl8723bs: code-style fix

2021-02-18 Thread Dan Carpenter
The subject is too vague. On Thu, Feb 18, 2021 at 04:33:10PM +, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > Checkpatch complains the constant needs to be on the right side of the > comparison. The preferred way is: > The commit message isn't complete and it has to go a

[PATCH] perf report: Create option to disable raw event ordering

2021-02-18 Thread Jin Yao
Warning "dso not found" is reported when using "perf report -D". 66702781413407 0x32c0 [0x30]: PERF_RECORD_SAMPLE(IP, 0x2): 28177/28177: 0x55e493e00563 period: 106578 addr: 0 ... thread: perf:28177 .. dso: 66702727832429 0x9dd8 [0x38]: PERF_RECORD_COMM exec: triad_loop:28177/28177 Th

Re: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform

2021-02-18 Thread Dan Carpenter
On Thu, Feb 18, 2021 at 07:50:27PM +, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > The preferred coding style is: > if (!StaAddr) > return; Above the Signed-off-by line. Also indenting is wrong. And it's hard to understand what you're saying. > > thank you

Re: [PATCH RESEND V12 3/8] fuse: Definitions and ioctl for passthrough

2021-02-18 Thread Peng Tao
On Wed, Feb 17, 2021 at 9:41 PM Miklos Szeredi wrote: > > On Mon, Jan 25, 2021 at 4:31 PM Alessio Balsini wrote: > > > > Expose the FUSE_PASSTHROUGH interface to user space and declare all the > > basic data structures and functions as the skeleton on top of which the > > FUSE passthrough functio

Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip

2021-02-18 Thread Jarkko Sakkinen
On Wed, Feb 17, 2021 at 09:27:02PM -0400, Jason Gunthorpe wrote: > On Thu, Feb 18, 2021 at 12:14:11AM +0200, Jarkko Sakkinen wrote: > > On Tue, Feb 16, 2021 at 04:31:26PM +, David Laight wrote: > > > ... > > > > > > + get_device(&chip->dev); > > > > > > + chip->devs.release = tpm_devs_relea

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Jari Ruusu
On Thursday, February 18, 2021 7:44 PM, Greg Kroah-Hartman wrote: > > It was the other way around. Fine working in-tree driver got > > broken by backported "fixes". I did mention bit-rot. > > It did? Please let us stable maintainers know about, we will always > gladly revert problems patches. Wha

Re: [PATCH] RISC-V: Enable CPU Hotplug in defconfigs

2021-02-18 Thread Palmer Dabbelt
On Mon, 08 Feb 2021 21:46:20 PST (-0800), Anup Patel wrote: The CPU hotplug support has been tested on QEMU, Spike, and SiFive Unleashed so let's enable it by default in RV32 and RV64 defconfigs. Signed-off-by: Anup Patel --- arch/riscv/configs/defconfig | 1 + arch/riscv/configs/rv32_def

Re: [RFC][PATCH 2/2] x86/retpoline: Compress retpolines

2021-02-18 Thread Borislav Petkov
On Thu, Feb 18, 2021 at 05:59:40PM +0100, Peter Zijlstra wrote: > By using int3 as a speculation fence instead of lfence, we can shrink > the longest alternative to just 15 bytes: > > 0: e8 05 00 00 00 callq a <.altinstr_replacement+0xa> > 5: f3 90 pause > 7

[PATCH] drm/radeon/dpm: fix non-restricted types with le16_to_cpu()

2021-02-18 Thread Yang Li
Fix the following sparse warnings: drivers/gpu/drm/radeon/rv6xx_dpm.c:1798:21: warning: cast to restricted __le32 drivers/gpu/drm/radeon/rv6xx_dpm.c:1799:22: warning: cast to restricted __le16 drivers/gpu/drm/radeon/rv6xx_dpm.c:1800:23: warning: cast to restricted __le16 Reported-by: Abaci Robot

Re: [PATCH] staging: wlan-ng: Fixed incorrect type warning in p80211netdev.c

2021-02-18 Thread Ivan Safonov
On 2/17/21 6:42 PM, pritthijit.nath at icloud.com (Pritthijit Nath) wrote: This change fixes a sparse warning "incorrect type in argument 1 (different address spaces)". Signed-off-by: Pritthijit Nath --- drivers/staging/wlan-ng/p80211netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type

2021-02-18 Thread Atul Gopinathan
On Fri, Feb 19, 2021 at 09:55:14AM +0300, Dan Carpenter wrote: > No problem. These days I have fibre to my house, but I still remember > trying to clone the kernel when I could only buy 20MB of data at a > time. :P Whoaa, that's tough! Respect to you for still trying to contribute to the kernel.

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Viresh Kumar
On 19-02-21, 14:41, Yue Hu wrote: > On Fri, 19 Feb 2021 09:39:33 +0530 > Viresh Kumar wrote: > > > On 19-02-21, 11:38, Yue Hu wrote: > > > There's a possibility: we will use the previous freq to update if > > > next_f is reduced for busy CPU if need_freq_update is set in > > > sugov_update_next_f

[PATCH] Revert "driver core: Set fw_devlink=on by default"

2021-02-18 Thread Greg Kroah-Hartman
This reverts commit e590474768f1cc04852190b61dec692411b22e2a. While things are _almost_ there and working for almost all systems, there are still reported regressions happening, so let's revert this default for 5.12. We can bring it back in linux-next after 5.12-rc1 is out to get more testing and

Re: [PATCH v12 13/14] mm/vmalloc: Hugepage vmalloc mappings

2021-02-18 Thread Nicholas Piggin
Excerpts from Ding Tianhong's message of February 19, 2021 1:45 pm: > Hi Nicholas: > > I met some problem for this patch, like this: > > kva = vmalloc(3*1024k); > > remap_vmalloc_range(xxx, kva, xxx) > > It failed because that the check for page_count(page) is null so return, it > break the so

Re: [PATCH] mtd: spi-nor: sfdp: Fix out of bound array access

2021-02-18 Thread Mathieu Dubois-Briand
Hi, I just came across this commit (9166f4af32db) in spi-nor/for-5.12: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=spi-nor/for-5.12&id=9166f4af32db74e1544a2149aef231ff24515ea3. So I believe this patch isn't needed anymore. Thanks, Mathieu

<    5   6   7   8   9   10