Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-18 Thread Xie He
On Thu, Feb 18, 2021 at 12:06 PM Xie He wrote: > > On Thu, Feb 18, 2021 at 11:55 AM Leon Romanovsky wrote: > > > > This is how we write code, we use defines instead of constant numbers, > > comments to describe tricky parts and assign already preprocessed result. > > > > There is nothing I can do

Re: [PATCH RESEND] mm, kasan: don't poison boot memory

2021-02-18 Thread Andrey Konovalov
On Thu, Feb 18, 2021 at 11:46 AM Catalin Marinas wrote: > > The approach looks fine to me. If you don't like the trade-off, I think > you could still leave the kasan poisoning in if CONFIG_DEBUG_KERNEL. This won't work, Android enables CONFIG_DEBUG_KERNEL in GKI as it turns out :) > Reviewed-by:

Re: [PATCH] mm, kasan: don't poison boot memory

2021-02-18 Thread Andrey Konovalov
On Thu, Feb 18, 2021 at 8:46 PM David Hildenbrand wrote: > > > 1. For KASAN_GENERIC: leave everything as is to be able to detect > > these boot-time bugs. > > > > 2. For KASAN_SW_TAGS: remove boot-time poisoning via > > kasan_free_pages(), but use the "invalid" tag as the default shadow > > value.

[PATCH] staging: kpc2000: code style: fix alignment issues

2021-02-18 Thread Nikolay Kyx
kpc2000_i2c.c: fix WARNING: line length of 124 exceeds 100 columns fix CHECK: Alignment should match open parenthesis kpc2000_spi.c: fix CHECK: Alignment should match open parenthesis Signed-off-by: Nikolay Kyx --- drivers/staging/kpc2000/kpc2000_i2c.c | 6 -- drivers/staging/kpc2000/kpc200

[PATCH][V2] drivers/base/cpu: remove redundant assignment of variable retval

2021-02-18 Thread Colin King
From: Colin Ian King The variable retval is being initialized with a value that is never read and it is being updated later with a new value. Clean this up by initializing retval to -ENOMEM and remove the assignment to retval on the !dev failure path. Kudos to Rafael for the improved fix sugges

[PATCH v6] tpm: fix reference counting for struct tpm_chip

2021-02-18 Thread Lino Sanfilippo
From: Lino Sanfilippo The following sequence of operations results in a refcount warning: 1. Open device /dev/tpmrm. 2. Remove module tpm_tis_spi. 3. Write a TPM command to the file descriptor opened at step 1. [ cut here ] WARNING: CPU: 3 PID: 1161 at lib/refcount.c:25

Re: linux-next: manual merge of the devicetree tree with the powerpc tree

2021-02-18 Thread Stephen Rothwell
Hi all, On Thu, 18 Feb 2021 07:52:52 -0600 Rob Herring wrote: > > On Thu, Feb 18, 2021 at 5:34 AM Stephen Rothwell > wrote: > > > > On Thu, 18 Feb 2021 21:44:37 +1100 Michael Ellerman > > wrote: > > > > > > I think it just needs this? > > > > > > diff --git a/arch/powerpc/kexec/elf_64.c b/a

Re: [PATCH v2 4/4] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp

2021-02-18 Thread Peter Xu
On Thu, Feb 18, 2021 at 10:32:00AM -0800, Axel Rasmussen wrote: > > @@ -1448,6 +1449,9 @@ static int userfaultfd_register(struct > > userfaultfd_ctx *ctx, > > vma->vm_flags = new_flags; > > vma->vm_userfaultfd_ctx.ctx = ctx; > > > > + if (is_vm_hugetlb

[PATCH v6] TPM fixes

2021-02-18 Thread Lino Sanfilippo
This patch fixes a reference count issue in the TPM core code. Changes in v6: - rename function tpm2_add_device() to tpm_devs_add() as requested by Jarko - add function descriptions - fix source code formatting Changes in v5: - move function tpm_add_tpm2_char_device() to tpm2-space.c and rename i

Re: pstore: fix compression

2021-02-18 Thread Kees Cook
On Thu, 18 Feb 2021 12:15:47 +0100, Jiri Bohac wrote: > pstore_compress() and decompress_record() use a mistyped config option > name ("PSTORE_COMPRESSION" instead of "PSTORE_COMPRESS"). > As a result compression and decompressionm of pstore records is always > disabled. > > Use the correct config

Re: [PATCH v2 0/4] hugetlb: Disable huge pmd unshare for uffd-wp

2021-02-18 Thread Peter Xu
On Thu, Feb 18, 2021 at 10:54:41AM -0800, Axel Rasmussen wrote: > I reviewed these patches, rebased my minor fault handling series on > top of this series, and then ran some stress tests of minor fault > handling. Other than the one comment I left about !CONFIG_CMA, I > didn't spot any issues. So:

[GIT PULL] pstore update for v5.12-rc1

2021-02-18 Thread Kees Cook
Hi Linus, Please pull this tiny pstore update for v5.12-rc1 to fix a CONFIG typo. Thanks! -Kees The following changes since commit f40ddce88593482919761f74910f42f4b84c004b: Linux 5.11 (2021-02-14 14:32:24 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/lin

Re: [PATCH v2 4/4] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp

2021-02-18 Thread Axel Rasmussen
On Thu, Feb 18, 2021 at 12:32 PM Peter Xu wrote: > > On Thu, Feb 18, 2021 at 10:32:00AM -0800, Axel Rasmussen wrote: > > > @@ -1448,6 +1449,9 @@ static int userfaultfd_register(struct > > > userfaultfd_ctx *ctx, > > > vma->vm_flags = new_flags; > > > vma->vm_userfa

Re: [PATCH v2 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

2021-02-18 Thread Adrien Grassein
Hey Robert, Thank you for your time and for your review. Le mer. 17 févr. 2021 à 18:32, Robert Foss a écrit : > > Hey Adrien, > > Thanks for submitting this! > > On Mon, 15 Feb 2021 at 00:31, Adrien Grassein > wrote: > > > > Lontium Lt8912 is a DSI to HDMI bridge. > > > > Signed-off-by: Adrien

Re: [PATCH RESEND v2 4/5] iommu/tegra-smmu: Rework tegra_smmu_probe_device()

2021-02-18 Thread Guillaume Tucker
a recent change in iommu core, I feel it safer to revert my > previous change, not necessarily being a complete revert though. > > I attached my partial reverting change in this email. Would it be > possible for you to run one more test for me to confirm it? It'd > keep the test

Re: [PATCH v6 0/2] fix a NULL pointer bug and simplify the code

2021-02-18 Thread Josef Bacik
On 2/18/21 7:26 AM, Sun Ke wrote: fix a NULL pointer bug and simplify the code v6: Just add if (nbd->recv_workq) to nbd_disconnect_and_put(). v5: Adjust the title and add “Suggested-by”. v4: Share exception handling code for if branches and move put_nbd adjustment to a separate patch. v3

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-18 Thread Steve French
On Thu, Feb 18, 2021 at 4:03 AM Amir Goldstein wrote: > > On Thu, Feb 18, 2021 at 9:42 AM Christoph Hellwig wrote: > > > > Looks good: > > > > Reviewed-by: Christoph Hellwig > > > > This whole idea of cross-device copie has always been a horrible idea, > > and I've been arguing against it since

Re: [PATCH v2 4/4] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp

2021-02-18 Thread Peter Xu
On Thu, Feb 18, 2021 at 12:34:55PM -0800, Axel Rasmussen wrote: > On Thu, Feb 18, 2021 at 12:32 PM Peter Xu wrote: > > > > On Thu, Feb 18, 2021 at 10:32:00AM -0800, Axel Rasmussen wrote: > > > > @@ -1448,6 +1449,9 @@ static int userfaultfd_register(struct > > > > userfaultfd_ctx *ctx, > > > >

[PATCH v8 bpf-next 0/5] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-18 Thread Alexander Lobakin
This series introduces XSK generic zerocopy xmit by adding XSK umem pages as skb frags instead of copying data to linear space. The only requirement for this for drivers is to be able to xmit skbs with skb_headlen(skb) == 0, i.e. all data including hard headers starts from frag 0. To indicate wheth

[PATCH v8 bpf-next 1/5] netdevice: add missing IFF_PHONY_HEADROOM self-definition

2021-02-18 Thread Alexander Lobakin
This is harmless for now, but can be fatal for future refactors. Fixes: 871b642adebe3 ("netdev: introduce ndo_set_rx_headroom") Signed-off-by: Alexander Lobakin Acked-by: John Fastabend --- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/netdevice.h b

[PATCH v8 bpf-next 2/5] net: add priv_flags for allow tx skb without linear

2021-02-18 Thread Alexander Lobakin
From: Xuan Zhuo In some cases, we hope to construct skb directly based on the existing memory without copying data. In this case, the page will be placed directly in the skb, and the linear space of skb is empty. But unfortunately, many the network card does not support this operation. For exampl

[PATCH v8 bpf-next 3/5] virtio-net: support IFF_TX_SKB_NO_LINEAR

2021-02-18 Thread Alexander Lobakin
From: Xuan Zhuo Virtio net supports the case where the skb linear space is empty, so add priv_flags. Signed-off-by: Xuan Zhuo Acked-by: Michael S. Tsirkin Signed-off-by: Alexander Lobakin Acked-by: John Fastabend --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 delet

[PATCH v8 bpf-next 4/5] xsk: respect device's headroom and tailroom on generic xmit path

2021-02-18 Thread Alexander Lobakin
xsk_generic_xmit() allocates a new skb and then queues it for xmitting. The size of new skb's headroom is desc->len, so it comes to the driver/device with no reserved headroom and/or tailroom. Lots of drivers need some headroom (and sometimes tailroom) to prepend (and/or append) some headers or dat

[PATCH v8 bpf-next 5/5] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-18 Thread Alexander Lobakin
From: Xuan Zhuo This patch is used to construct skb based on page to save memory copy overhead. This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the network card priv_flags supports IFF_TX_SKB_NO_LINEAR will use page to directly construct skb. If this feature is not supported, it

Re: [PATCH] staging: kpc2000: code style: fix alignment issues

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 11:28:14PM +0300, Nikolay Kyx wrote: > kpc2000_i2c.c: > fix WARNING: line length of 124 exceeds 100 columns > fix CHECK: Alignment should match open parenthesis > > kpc2000_spi.c: > fix CHECK: Alignment should match open parenthesis This changelog is a bit odd. Please rea

linux-next: build warnings after merge of the net-next tree

2021-02-18 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (htmldocs) produced these warnings: Documentation/networking/filter.rst:1053: WARNING: Inline emphasis start-string without end-string. Documentation/networking/filter.rst:1053: WARNING: Inline emphasis start-string without end-s

[PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-18 Thread Kuogee Hsieh
Allow supported link rate to be limited to the value specified at dtsi. If it is not specified, then link rate is derived from dpcd directly. Below are examples, link-rate = <162000> for max link rate limited at 1.62G link-rate = <27> for max link rate limited at 2.7G link-rate = <54> for m

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Pavel Machek
Hi! > > For me > > only way to get properly working WiFi on my laptop computer is to > > compile that Intel out-of-tree version. Sad, but true. > > Why use 4.19.y on a laptop in the firstplace? That feels very wrong and > is not the recommended thing to use the LTS kernels for. Well, that's act

linux-next: build warning in Linus' tree

2021-02-18 Thread Stephen Rothwell
Hi all, Building Linus' tree, today's linux-next build (htmldocs) produced this warning: Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation. Introduced by commit c159376490ee ("x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/") Or maybe an

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Willy Tarreau
On Thu, Feb 18, 2021 at 12:16:50PM -0800, Scott Branden wrote: > On 2021-02-18 10:36 a.m., Greg Kroah-Hartman wrote: > > On Thu, Feb 18, 2021 at 07:20:50PM +0100, Willy Tarreau wrote: > >> On Thu, Feb 18, 2021 at 06:53:56PM +0100, Greg Kroah-Hartman wrote: > >>> On Thu, Feb 18, 2021 at 09:21:13AM -

[PATCH 1/1] scsi: storvsc: Enable scatterlist entry lengths > 4Kbytes

2021-02-18 Thread Michael Kelley
storvsc currently sets .dma_boundary to limit scatterlist entries to 4 Kbytes, which is less efficient with huge pages that offer large chunks of contiguous physical memory. Improve the algorithm for creating the Hyper-V guest physical address PFN array so that scatterlist entries with lengths > 4K

linux-next: build warnings after merge of the origin tree

2021-02-18 Thread Stephen Rothwell
Hi all, Building Linus' tree, today's linux-next build (htmldocs) produced these warnings: Documentation/virt/kvm/api.rst:4537: WARNING: Unexpected indentation. Documentation/virt/kvm/api.rst:4539: WARNING: Block quote ends without a blank line; unexpected unindent. Introduced by commit c21d

Re: [PATCH V7 5/6] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi

2021-02-18 Thread Frank Rowand
On 1/29/21 1:24 AM, Viresh Kumar wrote: > In order to build-test the same unit-test files using fdtoverlay tool, > move the device nodes from the existing overlay_base.dts and > testcases_common.dts files to .dtsi counterparts. The .dts files now > include the new .dtsi files, resulting in exactly

[PATCH v3 1/2] dt-bindings: display: bridge: Add documentation for LT8912

2021-02-18 Thread Adrien Grassein
Lontium LT8912 is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein Reviewed-by: Rob Herring --- .../display/bridge/lontium,lt8912.yaml| 102 ++ MAINTAINERS | 5 + 2 files changed, 107 insertions(+) create mode 100644 Documentatio

[PATCH v3 0/2] Add support of Lontium lt8912 MIPI to HDMI bridge

2021-02-18 Thread Adrien Grassein
this patch set adds the support of the Lontium lt8912 MIPI to HDMI bridge in the kernel. It's only support the video part, not the audio part yet since I don't have the datasheet of this component. I get the current i2c configuration from Digi and Boundary drivers. Developed using the DB_DSIHD boa

[PATCH v3 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

2021-02-18 Thread Adrien Grassein
Lontium Lt8912 is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein --- MAINTAINERS | 1 + drivers/gpu/drm/bridge/Kconfig | 14 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/lontium-lt8912.c | 760 4

Re: [PATCH v6 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

2021-02-18 Thread Jassi Brar
On Thu, Feb 18, 2021 at 6:02 AM Alessandrelli, Daniele wrote: > > Hi Jassi, > > Thank you very much for your feedback. > > On Sun, 2021-02-14 at 22:54 -0600, Jassi Brar wrote: > > IIUIC, maybe the solution is simpler What if we set txdone_poll. > > Always return success in send_data(). And ch

Re: [PATCH net-next v2 0/2] net: phy: at803x: paging support

2021-02-18 Thread David Miller
From: Michael Walle Date: Thu, 18 Feb 2021 20:46:10 +0100 > Am 2021-02-18 20:26, schrieb Vladimir Oltean: >> On Thu, Feb 18, 2021 at 07:52:38PM +0100, Michael Walle wrote: >>> Add paging support to the QCA AR8031/33 PHY. This will be needed if we >>> add support for the .config_inband_aneg callba

Re: [PATCH v11] leds: trigger: implement a tty trigger

2021-02-18 Thread Uwe Kleine-König
Hello Pavel, On Thu, Feb 18, 2021 at 02:33:52PM +0100, Pavel Machek wrote: > > > > so that I can queue it up? > > > > > > Oh, so you are LED maintainer now? My congratulations. > > > (Honestly, do you plan to apply this without their ack? Not that I'm > > > against you doing that, I'm happy if I

Re: [PATCH ghak124 v3] audit: log nftables configuration change events

2021-02-18 Thread Richard Guy Briggs
On 2021-02-18 13:52, Florian Westphal wrote: > Richard Guy Briggs wrote: > > On 2021-02-18 09:22, Florian Westphal wrote: > > > > It seems I'd need to filter out the NFT_MSG_GET_* ops. > > > > > > No need, the GET ops do not cause changes and will not trigger a > > > generation id change. > > >

Re: [PATCH v11] leds: trigger: implement a tty trigger

2021-02-18 Thread Greg Kroah-Hartman
On Thu, Feb 18, 2021 at 10:19:48PM +0100, Uwe Kleine-König wrote: > Hello Pavel, > > On Thu, Feb 18, 2021 at 02:33:52PM +0100, Pavel Machek wrote: > > > > > so that I can queue it up? > > > > > > > > Oh, so you are LED maintainer now? My congratulations. > > > > (Honestly, do you plan to apply th

Re: [PATCH v15 0/4] Adding the Sparx5 Serdes driver

2021-02-18 Thread David Miller
From: Steen Hegelund Date: Thu, 18 Feb 2021 17:14:47 +0100 > Adding the Sparx5 Serdes driver > The net-next tree is closed so this will have to wait until the next merge window. Thanks.

Re: [PATCH v2 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

2021-02-18 Thread Robert Foss
On Thu, 18 Feb 2021 at 21:36, Adrien Grassein wrote: > > Hey Robert, > > Thank you for your time and for your review. > > Le mer. 17 févr. 2021 à 18:32, Robert Foss a écrit : > > > > Hey Adrien, > > > > Thanks for submitting this! > > > > On Mon, 15 Feb 2021 at 00:31, Adrien Grassein > > wrote:

[PATCH] lib: genalloc: fix warning generated by checkpatch

2021-02-18 Thread Hassan Shahbazi
Add missing blank line after declarations. Signed-off-by: Hassan Shahbazi --- lib/genalloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/genalloc.c b/lib/genalloc.c index dab97bb69df6..3e901fd93b00 100644 --- a/lib/genalloc.c +++ b/lib/genalloc.c @@ -757,6 +757,7 @@ unsigned long gen

Re: [PATCH v4 10/10] coresight: docs: Add documentation for CoreSight config

2021-02-18 Thread Mathieu Poirier
Good day, I have started to review this set and as usual comments will come over several days. On Thu, Jan 28, 2021 at 05:09:36PM +, Mike Leach wrote: > Adds documentation for the CoreSight System configuration manager. > > Signed-off-by: Mike Leach > --- > .../trace/coresight/coresight-co

RE: [PATCH v7 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-18 Thread Gustavo Pimentel
On Thu, Feb 18, 2021 at 19:27:30, Bjorn Helgaas wrote: > On Thu, Feb 18, 2021 at 08:03:58PM +0100, Gustavo Pimentel wrote: > > Add pci_find_vsec_capability() to locate a Vendor-Specific Extended > > Capability with the specified VSEC ID. > > > > The Vendor-Specific Extended Capability (VSEC) al

Re: [PATCH v2 4/9] media: uapi: Add a control for HANTRO driver

2021-02-18 Thread Jernej Škrabec
Hi! Dne četrtek, 18. februar 2021 ob 20:18:39 CET je Benjamin Gaignard napisal(a): > The HEVC HANTRO driver needs to know the number of bits to skip at > the beginning of the slice header. > That is a hardware specific requirement so create a dedicated control > that this purpose. > > Signed-off-

[PATCH] percpu_counter: increase batch count

2021-02-18 Thread Jens Axboe
Currently we cap the batch count at max(32, 2*nr_online_cpus), which these days is kind of silly as systems have gotten much bigger than in 2009 when this heuristic was introduced. Bump it to capping it at 256 instead. This has a noticeable improvement for certain io_uring workloads, as io_uring t

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Sasha Levin
On Thu, Feb 18, 2021 at 12:16:50PM -0800, Scott Branden wrote: On 2021-02-18 10:36 a.m., Greg Kroah-Hartman wrote: On Thu, Feb 18, 2021 at 07:20:50PM +0100, Willy Tarreau wrote: On Thu, Feb 18, 2021 at 06:53:56PM +0100, Greg Kroah-Hartman wrote: On Thu, Feb 18, 2021 at 09:21:13AM -0800, Floria

Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-18 Thread Mike Kravetz
On 2/18/21 9:34 AM, Mike Kravetz wrote: > On 2/18/21 9:25 AM, Jason Gunthorpe wrote: >> On Thu, Feb 18, 2021 at 02:45:54PM +, Matthew Wilcox wrote: >>> On Wed, Feb 17, 2021 at 11:02:52AM -0800, Andrew Morton wrote: On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz wrote: > page st

Re: [PATCH v2 1/9] media: hevc: Modify structures to follow H265 ITU spec

2021-02-18 Thread Jernej Škrabec
Hi! Dne četrtek, 18. februar 2021 ob 20:18:36 CET je Benjamin Gaignard napisal(a): > The H.265 ITU specification (section 7.4) define the general > slice segment header semantics. > Modified/added fields are: > - video_parameter_set_id: (7.4.3.1) identifies the VPS for > reference by other syntax

[PATCH v3 0/4] hugetlb: Disable huge pmd unshare for uffd-wp

2021-02-18 Thread Peter Xu
v3: - patch 4: - fix build failure for !CMA and/or !HUGETLBFS [Axel] - Fix mmu notifier range to use start/end [Mike] - add more r-bs v2: - patch 4: move hugetlb_unshare_all_pmds() into mm/hugetlb.c, so it can be used even outside userfaultfd.c This series tries to disable huge pmd unshare

[PATCH v3 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share()

2021-02-18 Thread Peter Xu
It is a preparation work to be able to behave differently in the per architecture huge_pte_alloc() according to different VMA attributes. Pass it deeper into huge_pmd_share() so that we can avoid the find_vma() call. Suggested-by: Mike Kravetz Reviewed-by: Mike Kravetz Reviewed-by: Axel Rasmuss

[PATCH v3 4/4] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp

2021-02-18 Thread Peter Xu
Huge pmd sharing for hugetlbfs is racy with userfaultfd-wp because userfaultfd-wp is always based on pgtable entries, so they cannot be shared. Walk the hugetlb range and unshare all such mappings if there is, right before UFFDIO_REGISTER will succeed and return to userspace. This will pair with

[PATCH v3 3/4] mm/hugetlb: Move flush_hugetlb_tlb_range() into hugetlb.h

2021-02-18 Thread Peter Xu
Prepare for it to be called outside of mm/hugetlb.c. Reviewed-by: Mike Kravetz Reviewed-by: Axel Rasmussen Signed-off-by: Peter Xu --- include/linux/hugetlb.h | 8 mm/hugetlb.c| 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/hugetl

[PATCH v3 2/4] hugetlb/userfaultfd: Forbid huge pmd sharing when uffd enabled

2021-02-18 Thread Peter Xu
Huge pmd sharing could bring problem to userfaultfd. The thing is that userfaultfd is running its logic based on the special bits on page table entries, however the huge pmd sharing could potentially share page table entries for different address ranges. That could cause issues on either: - Wh

Re: [PATCH 1/3] vfio: Introduce vma ops registration and notifier

2021-02-18 Thread Alex Williamson
On Wed, 17 Feb 2021 21:12:09 -0400 Jason Gunthorpe wrote: > On Fri, Feb 12, 2021 at 05:20:57PM -0400, Jason Gunthorpe wrote: > > On Fri, Feb 12, 2021 at 12:27:39PM -0700, Alex Williamson wrote: > > > Create an interface through vfio-core where a vfio bus driver (ex. > > > vfio-pci) can register

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
On 2/18/2021 1:39 PM, Sasha Levin wrote: > On Thu, Feb 18, 2021 at 12:16:50PM -0800, Scott Branden wrote: >> On 2021-02-18 10:36 a.m., Greg Kroah-Hartman wrote: >>> On Thu, Feb 18, 2021 at 07:20:50PM +0100, Willy Tarreau wrote: On Thu, Feb 18, 2021 at 06:53:56PM +0100, Greg Kroah-Hartman wr

[PATCH v2 1/5] keys: cleanup build time module signing keys

2021-02-18 Thread Nayna Jain
The "mrproper" target is still looking for build time generated keys in the old path instead of certs/ directory. Fix the path and remove the names of the files which are no longer generated. Fixes: fb1179499134 ("modsign: Use single PEM file for autogenerated key") Signed-off-by: Nayna Jain ---

[PATCH v2 0/5] ima: kernel build support for loading the kernel module signing key

2021-02-18 Thread Nayna Jain
Kernel modules are currently only signed when CONFIG_MODULE_SIG is enabled. The kernel module signing key is a self-signed CA only loaded onto the .builtin_trusted_key keyring. On secure boot enabled systems with an arch specific IMA policy enabled, but without MODULE_SIG enabled, kernel modules a

[PATCH v2 2/5] keys: generate self-signed module signing key using CSR

2021-02-18 Thread Nayna Jain
Loading a key on the IMA trusted keyring requires the key be signed by an existing key on the builtin or secondary trusted keyring. Creating a Certificate Signing Request (CSR) allows the certificate to be self-signed or signed by a CA. Generate a self-signed module signing key using CSR. Signed-

[PATCH v2 4/5] keys: define build time generated ephemeral kernel CA key

2021-02-18 Thread Nayna Jain
Certificates being loaded onto the IMA trusted keyring must be signed by a key on either the builtin or secondary trusted keyring. Create and include in the kernel image an ephemeral CA key at build time when IMA_APPRAISE_MODSIG is enabled. Reported-by: kernel test robot (redirect openssl stderr)

[PATCH v2 3/5] ima: update kernel module signing process during build

2021-02-18 Thread Nayna Jain
The kernel build process currently only signs kernel modules when MODULE_SIG is enabled. Also, sign the kernel modules at build time when IMA_APPRAISE_MODSIG is enabled. Signed-off-by: Nayna Jain --- certs/Kconfig | 2 +- init/Kconfig | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH v2 5/5] ima: enable loading of build time generated key on .ima keyring

2021-02-18 Thread Nayna Jain
The kernel currently only loads the kernel module signing key onto the builtin trusted keyring. To support IMA, load the module signing key selectively either onto the builtin or IMA keyring based on MODULE_SIG or MODULE_APPRAISE_MODSIG config respectively; and loads the CA kernel key onto the buil

Re: [PATCH 2/5] keys: generate self-signed module signing key using CSR

2021-02-18 Thread Nayna
On 2/11/21 5:01 PM, Stefan Berger wrote: On 2/11/21 2:54 PM, Nayna Jain wrote: Loading a key on the IMA trusted keyring requires the key be signed by an existing key on the builtin or secondary trusted keyring. Creating a Certificate Signing Request (CSR) allows the certificate to be self-sign

Re: [PATCH v2] IMA: support for duplicate data measurement

2021-02-18 Thread Tushar Sugandhi
Hi Mimi, On 2021-02-17 12:49 p.m., Tushar Sugandhi wrote: On 2021-02-17 12:39 p.m., Mimi Zohar wrote: On Wed, 2021-02-17 at 10:53 -0800, Tushar Sugandhi wrote: Thanks for the feedback Mimi. Appreciate it. On 2021-02-17 7:03 a.m., Mimi Zohar wrote: Hi Tushar, The Subject line could be impr

[PATCH] iommu/tegra-smmu: Fix mc errors on tegra124-nyan

2021-02-18 Thread Nicolin Chen
Commit 25938c73cd79 ("iommu/tegra-smmu: Rework tegra_smmu_probe_device()") removed certain hack in the tegra_smmu_probe() by relying on IOMMU core to of_xlate SMMU's SID per device, so as to get rid of tegra_smmu_find() and tegra_smmu_configure() that are typically done in the IOMMU core also. Thi

Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices

2021-02-18 Thread 'Krzysztof Wilczyński'
[+cc Bjorn as we talked about RCiEP briefly on IRC] Hello Qiuxu, [...] > Sorry, just back from Chinese New Year holiday. Welcome back! I hope you had a nice rest, and also Happy New Year! [...] > > Would this only affect error injection or would this be also a generic > > problem > > with the

RE: [Linuxarm] Re: [PATCH v2] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2

2021-02-18 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Valentin Schneider [mailto:valentin.schnei...@arm.com] > Sent: Friday, February 19, 2021 1:41 AM > To: Song Bao Hua (Barry Song) ; Peter Zijlstra > > Cc: vincent.guit...@linaro.org; mgor...@suse.de; mi...@kernel.org; > dietmar.eggem...@arm.com; morten.rasmus.

Re: [RFC] IRQ handlers run with some high-priority interrupts(not NMI) enabled on some platform

2021-02-18 Thread Michael Schmitz
On 19/02/21 12:19 am, Arnd Bergmann wrote: drivers/net/ethernet/8390/apne.c drivers/net/ethernet/8390/ax88796.c drivers/net/ethernet/8390/hydra.c drivers/net/ethernet/8390/mac8390.c drivers/net/ethernet/8390/ne.c drivers/net/ethernet/8390/zorro8390.c [...] Most of these are normal short-lived

Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices

2021-02-18 Thread 'Krzysztof Wilczyński'
Hi Qiuxu, [...] > > Agree to simplify the commit message. How about the following subject and > > commit message? > > > > Subject: > > Use device number to check RCiEPBitmap of RCEC > > > > Commit message: > > rcec_assoc_rciep() used the combination of device number and function > > number '

Re: [PATCH v3 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share()

2021-02-18 Thread Mike Kravetz
On 2/18/21 1:54 PM, Peter Xu wrote: > It is a preparation work to be able to behave differently in the per > architecture huge_pte_alloc() according to different VMA attributes. > diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c > index ad4b42f04988..97e0824fdbe7 100644 > ---

lttng-trace: a new strace-alike LTTng command

2021-02-18 Thread Mathieu Desnoyers
clone https://git.lttng.org/lttng-trace.git For instance, tracing the command "date" is as simple as: lttng-trace date The tracing session can be optionally configured by using the usual lttng control interfaces after this message appears: [lttng-trace] Tracing session `date-20210

Re: [PATCH v3 4/4] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp

2021-02-18 Thread Mike Kravetz
On 2/18/21 1:55 PM, Peter Xu wrote: > Huge pmd sharing for hugetlbfs is racy with userfaultfd-wp because > userfaultfd-wp is always based on pgtable entries, so they cannot be shared. > > Walk the hugetlb range and unshare all such mappings if there is, right before > UFFDIO_REGISTER will succeed

[PATCH v8 0/3] CPUFreq: Add support for opp-sharing cpus

2021-02-18 Thread Nicola Mazzucato
Hi Viresh, In this V8 I have addressed your comments: - correct the goto in patch 1/3 - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() Many thanks, Nicola [v8] * Correct "goto" in patch 1/3 * Improve comment in patch 2/3 for dev_pm_opp_get_opp_count() This v8 is rebased on v5.1

[PATCH v8 3/3] cpufreq: blacklist Arm Vexpress platforms in cpufreq-dt-platdev

2021-02-18 Thread Nicola Mazzucato
From: Sudeep Holla Add "arm,vexpress" to cpufreq-dt-platdev blacklist since the actual scaling is handled by the firmware cpufreq drivers(scpi, scmi and vexpress-spc). Signed-off-by: Sudeep Holla --- drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dri

[PATCH v8 2/3] scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM

2021-02-18 Thread Nicola Mazzucato
By design, SCMI performance domains define the granularity of performance controls, they do not describe any underlying hardware dependencies (although they may match in many cases). It is therefore possible to have some platforms where hardware may have the ability to control CPU performance at d

[RFC PATCH 1/6] tracing: introduce faultable tracepoints (v2)

2021-02-18 Thread Michael Jeanson
When invoked from system call enter/exit instrumentation, accessing user-space data is a common use-case for tracers. However, tracepoints currently disable preemption around iteration on the registered tracepoint probes and invocation of the probe callbacks, which prevents tracers from handling pa

[RFC PATCH 0/6] [RFC] Faultable tracepoints (v2)

2021-02-18 Thread Michael Jeanson
Formerly known as “Sleepable tracepoints”. When invoked from system call enter/exit instrumentation, accessing user-space data is a common use-case for tracers. However, tracepoints currently disable preemption around iteration on the registered tracepoint probes and invocation of the probe callba

[PATCH v8 1/3] scmi-cpufreq: Remove deferred probe

2021-02-18 Thread Nicola Mazzucato
The current implementation of the scmi_cpufreq_init() function returns -EPROBE_DEFER when the OPP table is not populated. In practice the cpufreq core cannot handle this error code. Therefore, fix the return value and clarify the error message. Signed-off-by: Nicola Mazzucato --- drivers/cpufreq

[RFC PATCH 3/6] tracing: bpf-trace: add support for faultable tracepoints

2021-02-18 Thread Michael Jeanson
In preparation for converting system call enter/exit instrumentation into faultable tracepoints, make sure that bpf can handle registering to such tracepoints by explicitly disabling preemption within the bpf tracepoint probes to respect the current expectations within bpf tracing code. This chang

[RFC PATCH 2/6] tracing: ftrace: add support for faultable tracepoints

2021-02-18 Thread Michael Jeanson
In preparation for converting system call enter/exit instrumentation into faultable tracepoints, make sure that ftrace can handle registering to such tracepoints by explicitly disabling preemption within the ftrace tracepoint probes to respect the current expectations within ftrace ring buffer code

[RFC PATCH 4/6] tracing: perf: add support for faultable tracepoints

2021-02-18 Thread Michael Jeanson
In preparation for converting system call enter/exit instrumentation into faultable tracepoints, make sure that perf can handle registering to such tracepoints by explicitly disabling preemption within the perf tracepoint probes to respect the current expectations within perf ring buffer code. Thi

[RFC PATCH 6/6] tracing: use Tasks Trace RCU instead of SRCU for rcuidle tracepoints

2021-02-18 Thread Michael Jeanson
From: Mathieu Desnoyers Similarly to SRCU, Tasks Trace RCU can be used for rcuidle tracepoints. It has the advantage to provide faster RCU read-side. Similarly to SRCU, Tasks Trace RCU grace periods are ready after core_initcall. Now that Tasks Trace RCU is used for faultable tracepoints, using

[RFC PATCH 5/6] tracing: convert sys_enter/exit to faultable tracepoints

2021-02-18 Thread Michael Jeanson
Convert the definition of the system call enter/exit tracepoints to faultable tracepoints now that all upstream tracers handle it. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra Cc: Alexei Staro

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Scott Branden
On 2021-02-18 1:39 p.m., Sasha Levin wrote: > On Thu, Feb 18, 2021 at 12:16:50PM -0800, Scott Branden wrote: >> On 2021-02-18 10:36 a.m., Greg Kroah-Hartman wrote: >>> On Thu, Feb 18, 2021 at 07:20:50PM +0100, Willy Tarreau wrote: On Thu, Feb 18, 2021 at 06:53:56PM +0100, Greg Kroah-Hartman wr

Re: [PATCH v3 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share()

2021-02-18 Thread Peter Xu
On Thu, Feb 18, 2021 at 02:13:52PM -0800, Mike Kravetz wrote: > On 2/18/21 1:54 PM, Peter Xu wrote: > > It is a preparation work to be able to behave differently in the per > > architecture huge_pte_alloc() according to different VMA attributes. > > > diff --git a/arch/sparc/mm/hugetlbpage.c b/arc

Re: [PATCH 05/14] KVM: x86/mmu: Consult max mapping level when zapping collapsible SPTEs

2021-02-18 Thread Mike Kravetz
On 2/18/21 8:23 AM, Sean Christopherson wrote: > On Thu, Feb 18, 2021, Paolo Bonzini wrote: >> On 13/02/21 01:50, Sean Christopherson wrote: >>> >>> pfn = spte_to_pfn(iter.old_spte); >>> if (kvm_is_reserved_pfn(pfn) || >>> - (!PageTransCompoundMap(pfn_to_page(p

[PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-18 Thread Lakshmi Ramasubramanian
of_kexec_alloc_and_setup_fdt() defined in drivers/of/kexec.c builds a new device tree object that includes architecture specific data for kexec system call. This should be defined only if the architecture being built defines kexec architecture structure "struct kimage_arch". Define a new boolean

Re: [PATCH v3 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share()

2021-02-18 Thread Mike Kravetz
On 2/18/21 2:27 PM, Peter Xu wrote: > On Thu, Feb 18, 2021 at 02:13:52PM -0800, Mike Kravetz wrote: >> On 2/18/21 1:54 PM, Peter Xu wrote: >>> It is a preparation work to be able to behave differently in the per >>> architecture huge_pte_alloc() according to different VMA attributes. >> >>> diff --

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Scott Branden
Hi Willy, On 2021-02-18 1:00 p.m., Willy Tarreau wrote: > On Thu, Feb 18, 2021 at 12:16:50PM -0800, Scott Branden wrote: >> On 2021-02-18 10:36 a.m., Greg Kroah-Hartman wrote: >>> On Thu, Feb 18, 2021 at 07:20:50PM +0100, Willy Tarreau wrote: On Thu, Feb 18, 2021 at 06:53:56PM +0100, Greg Kro

Re: [PATCH v6 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

2021-02-18 Thread mark gross
On Thu, Feb 18, 2021 at 03:09:55PM -0600, Jassi Brar wrote: > On Thu, Feb 18, 2021 at 6:02 AM Alessandrelli, Daniele > wrote: > > > > Hi Jassi, > > > > Thank you very much for your feedback. > > > > On Sun, 2021-02-14 at 22:54 -0600, Jassi Brar wrote: > > > IIUIC, maybe the solution is simpler ...

Re: [PATCH ghak124 v3] audit: log nftables configuration change events

2021-02-18 Thread Florian Westphal
Richard Guy Briggs wrote: > > If they appear in a batch tehy will be ignored, if the batch consists of > > such non-modifying ops only then nf_tables_commit() returns early > > because the transaction list is empty (nothing to do/change). > > Ok, one little inconvenient question: what about GETOB

Re: [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-18 Thread Bjorn Andersson
On Thu 18 Feb 14:55 CST 2021, Kuogee Hsieh wrote: > Allow supported link rate to be limited to the value specified at > dtsi. If it is not specified, then link rate is derived from dpcd > directly. Below are examples, > link-rate = <162000> for max link rate limited at 1.62G > link-rate = <27>

RE: linux-next: build warning in Linus' tree

2021-02-18 Thread Ernst, Justin
Hi, We made a special effort to squash the unexpected indentation warnings in c159376490ee (https://lore.kernel.org/lkml/20201130214304.369348-1-justin.er...@hpe.com/), so I was surprised to see this again. Commit: c9624cb7db1c ("x86/platform/uv: Update sysfs documentation") is the cul

[PATCH] drm/amd/pm/swsmu: Avoid using structure_size uninitialized in smu_cmn_init_soft_gpu_metrics

2021-02-18 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:764:2: warning: variable 'structure_size' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~ drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:770:23: note: uninitialized u

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Ondrej Zary
On Thursday 18 February 2021 21:55:34 Pavel Machek wrote: > Hi! > > > > For me > > > only way to get properly working WiFi on my laptop computer is to > > > compile that Intel out-of-tree version. Sad, but true. > > > > Why use 4.19.y on a laptop in the firstplace? That feels very wrong and > >

Re: [PATCH] platform/x86: dell-wmi-sysman: correct an initialization failure

2021-02-18 Thread mark gross
On Thu, Feb 18, 2021 at 01:17:23PM -0600, Mario Limonciello wrote: > On Dell systems that don't support this interface the module is > mistakingly returning error code "0", when it should be returning > -ENODEV. Correct a logic error to guarantee the correct return code. > > Cc: Divya Bharathi >

Re: [PATCH 04/14] lib: introduce BITS_{FIRST,LAST} macro

2021-02-18 Thread Rasmus Villemoes
On 18/02/2021 05.05, Yury Norov wrote: > BITMAP_{LAST,FIRST}_WORD_MASK() in linux/bitmap.h duplicates the > functionality of GENMASK(). The scope of there macros is wider > than just bitmap. This patch defines 4 new macros: BITS_FIRST(), > BITS_LAST(), BITS_FIRST_MASK() and BITS_LAST_MASK() in linu

Re: [PATCH V3 06/14] dts: bindings: Document device tree bindings for ETE

2021-02-18 Thread Suzuki K Poulose
On 2/18/21 6:33 PM, Rob Herring wrote: On Wed, Feb 10, 2021 at 12:33:44PM +, Suzuki K Poulose wrote: Hi Rob On 2/9/21 7:00 PM, Rob Herring wrote: On Wed, Jan 27, 2021 at 02:25:30PM +0530, Anshuman Khandual wrote: From: Suzuki K Poulose Document the device tree bindings for Embedded Trac

<    3   4   5   6   7   8   9   10   >