Re: [PATCH] platform/x86: fix typo in Kconfig

2021-02-18 Thread mark gross
On Tue, Feb 16, 2021 at 10:36:13PM +0100, Petr Vaněk wrote: > uses by -> used by > > Signed-off-by: Petr Vaněk Reviewed-by: Mark Gross Thanks for the clean up! -mark > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform

Re: [PATCH 05/14] KVM: x86/mmu: Consult max mapping level when zapping collapsible SPTEs

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Paolo Bonzini wrote: > On 13/02/21 01:50, Sean Christopherson wrote: > > > > pfn = spte_to_pfn(iter.old_spte); > > if (kvm_is_reserved_pfn(pfn) || > > - (!PageTransCompoundMap(pfn_to_page(pfn)) && > > -!kvm_is_zone_device_

Re: [PATCH 17/18] certs: Fix blacklist flag type confusion

2021-02-18 Thread David Howells
Hi Mickaël, Jarkko, Can I transfer your acks from: https://lore.kernel.org/lkml/20210121155513.539519-5-...@digikod.net/ to here? David

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread David Hildenbrand
On 18.02.21 17:19, Minchan Kim wrote: On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: On 18.02.21 10:35, Michal Hocko wrote: On Thu 18-02-21 10:02:43, David Hildenbrand wrote: On 18.02.21 09:56, Michal Hocko wrote: On Wed 17-02-21 08:36:03, Minchan Kim wrote: alloc_contig_

Re: [PATCH v3] vfs: fix copy_file_range regression in cross-fs copies

2021-02-18 Thread Olga Kornievskaia
On Thu, Feb 18, 2021 at 1:48 AM Amir Goldstein wrote: > > On Thu, Feb 18, 2021 at 7:33 AM Olga Kornievskaia wrote: > > > > On Wed, Feb 17, 2021 at 3:30 PM Luis Henriques wrote: > > > > > > A regression has been reported by Nicolas Boichat, found while using the > > > copy_file_range syscall to c

[PATCH] KVM: nSVM: prepare guest save area while is_guest_mode is true

2021-02-18 Thread Paolo Bonzini
Right now, enter_svm_guest_mode is calling nested_prepare_vmcb_save and nested_prepare_vmcb_control. This results in is_guest_mode being false until the end of nested_prepare_vmcb_control. This is a problem because nested_prepare_vmcb_save can in turn cause changes to the intercepts and these hav

Re: [RFC PATCH 0/7] Add managed version of delayed work init

2021-02-18 Thread mark gross
On Sat, Feb 13, 2021 at 01:58:17PM +0200, Matti Vaittinen wrote: > It's not rare that device drivers need delayed work. > It's not rare that this work needs driver's data. > > Often this means that driver must ensure the work is not queued when > driver exits. Usually this is done by ensuring new

Re: [PATCH] mtd: rawnand: qcom: update last code word register

2021-02-18 Thread mdalam
On 2021-02-18 14:50, Miquel Raynal wrote: Hello, >> >> +/* helper to configure location register values */ >> +static void nandc_set_read_loc(struct nand_chip *chip, int cw, int >> reg, >> + int offset, int size, int is_last) > > You know cw, you have access to chip-

[PATCH v1] watchdog: wdat: add param. to start wdog on module insertion

2021-02-18 Thread Flavio Suligoi
Add the parameter "start_enable" to start the watchdog directly on module insertion. In an embedded system, for some applications, the watchdog must be activated as soon as possible. In some embedded x86 boards the watchdog can be activated directly by the BIOS (with an appropriate setting of the

[PATCH] Staging: rtl8723bs: code-style fix

2021-02-18 Thread Kurt Manucredo
Signed-off-by: Kurt Manucredo --- Checkpatch complains the constant needs to be on the right side of the comparison. The preferred way is: drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_

Re: [PATCH V3 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-02-18 Thread Ionela Voinescu
Hey, On Thursday 18 Feb 2021 at 15:03:04 (+0530), Viresh Kumar wrote: > On 17-02-21, 00:24, Ionela Voinescu wrote: > > > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c > > > index 1e47dfd465f8..47fca7376c93 100644 > > > --- a/arch/arm64/kernel/topology.c > > > +++ b/arch/

Re: [PATCH v5] vfs: fix copy_file_range regression in cross-fs copies

2021-02-18 Thread Luis Henriques
Amir Goldstein writes: > On Thu, Feb 18, 2021 at 5:16 PM Luis Henriques wrote: >> >> A regression has been reported by Nicolas Boichat, found while using the >> copy_file_range syscall to copy a tracefs file. Before commit >> 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") th

Re: [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-02-18 Thread 黄学森
Thanks Daniel and Willem! So sorry to reply to you late for I just took the Chinese Spring Festival vacation. I will resubmit this patch. Thanks again! > 2021年2月11日 下午11:26,Daniel Borkmann 写道: > > On 2/10/21 3:50 PM, Willem de Bruijn wrote: >> On Wed, Feb 10, 2021 at 1:59 AM huangxuesen wro

[PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-02-18 Thread Xuesen Huang
From: Xuesen Huang bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets encapsulation. But that is not appropriate when pushing Ethernet header. Add an option to further specify encap L2 type and set the inner_protocol as ETH_P_TEB. Suggested-by: Willem de Bruijn Signed-off

Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type

2021-02-18 Thread Atul Gopinathan
On Thu, Feb 18, 2021 at 06:51:59PM +0300, Dan Carpenter wrote: > On Thu, Feb 18, 2021 at 06:22:20PM +0530, Atul Gopinathan wrote: > > On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote: > > > On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote: > > > > On Thu, Feb 18, 2021 at 10:31

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Kalra, Ashish wrote: > From: Sean Christopherson > > On Wed, Feb 17, 2021, Kalra, Ashish wrote: > >> From: Sean Christopherson On Thu, Feb 04, 2021, > >> Ashish Kalra wrote: > >> > From: Brijesh Singh > >> > > >> > The ioctl is used to retrieve a guest's shared pages li

Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Paolo Bonzini wrote: > On 18/02/21 13:56, David Edmondson wrote: > > On Thursday, 2021-02-18 at 12:54:52 +01, Paolo Bonzini wrote: > > > > > On 18/02/21 11:04, David Edmondson wrote: > > > > When dumping the VMCS, retrieve the current guest value of EFER from > > > > the kvm_

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread Minchan Kim
On Thu, Feb 18, 2021 at 05:26:08PM +0100, David Hildenbrand wrote: > On 18.02.21 17:19, Minchan Kim wrote: > > On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: > > > On 18.02.21 10:35, Michal Hocko wrote: > > > > On Thu 18-02-21 10:02:43, David Hildenbrand wrote: > > > > > On 18.0

Re: [PATCH 00/11] HID: playstation: revert LED class exposure

2021-02-18 Thread Benjamin Tissoires
On Wed, Feb 17, 2021 at 6:32 PM Benjamin Tissoires wrote: > > [sending those patches on behalf of Roderick] > > There is a current thread on LED LKML which basically means that > we have to revert the LED class exposure until things are settled. > > I am sending here the full series that will end

Re: [PATCH V3 2/2] cpufreq: cppc: Add support for frequency invariance

2021-02-18 Thread Ionela Voinescu
Hi, On Thursday 28 Jan 2021 at 16:18:56 (+0530), Viresh Kumar wrote: > The Frequency Invariance Engine (FIE) is providing a frequency scaling > correction factor that helps achieve more accurate load-tracking. > > Normally, this scaling factor can be obtained directly with the help of > the cpufr

Re: [v4] PCI: Avoid unsync of LTR mechanism configuration

2021-02-18 Thread Bjorn Helgaas
On Thu, Feb 04, 2021 at 05:51:25PM +0800, mingchuang.q...@mediatek.com wrote: > From: Mingchuang Qiao > > In bus scan flow, the "LTR Mechanism Enable" bit of DEVCTL2 register is > configured in pci_configure_ltr(). If device and bridge both support LTR > mechanism, the "LTR Mechanism Enable" bit

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread David Hildenbrand
On 18.02.21 17:47, Minchan Kim wrote: On Thu, Feb 18, 2021 at 05:26:08PM +0100, David Hildenbrand wrote: On 18.02.21 17:19, Minchan Kim wrote: On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: On 18.02.21 10:35, Michal Hocko wrote: On Thu 18-02-21 10:02:43, David Hildenbrand

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Sasha Levin
On Wed, Feb 17, 2021 at 11:48:21AM -0800, Scott Branden wrote: On 2021-02-17 1:40 a.m., Greg Kroah-Hartman wrote: Following up on this as I did not hear back from you. Are you and/or your company willing to help out with the testing of 5.10 to ensure that it is a LTS kernel? So far I have not

Re: [PATCH] Staging: comedi: Replaced strlcpy to strscpy

2021-02-18 Thread Ian Abbott
On 18/02/2021 14:31, chakravarthikulkarni wrote: > Warning found by checkpath.pl script. > > Signed-off-by: chakravarthikulkarni > --- > drivers/staging/comedi/comedi_fops.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/comedi_fops.c > b/dr

Re: [PATCH 10/14] KVM: x86: Further clarify the logic and comments for toggling log dirty

2021-02-18 Thread Paolo Bonzini
On 18/02/21 17:15, Sean Christopherson wrote: On Thu, Feb 18, 2021, Paolo Bonzini wrote: On 13/02/21 01:50, Sean Christopherson wrote: -* Nothing to do for RO slots or CREATE/MOVE/DELETE of a slot. -* See comments below. +* Nothing to do for RO slots (which can't be dir

Re: [PATCH 1/2] mm: Make alloc_contig_range handle free hugetlb pages

2021-02-18 Thread Oscar Salvador
On 2021-02-18 14:59, Michal Hocko wrote: As I've said. Page allocator can cope with NULL nodemask just fine. I have checked the code and now remember the tricky part. It is alloc_gigantic_page which cannot work with NULL nodemask because it relies on for_each_node_mask and that, unlike zonelist i

[PATCH v2 1/2] phy/qualcomm: add hbr3_hbr2 voltage and premphasis swing table

2021-02-18 Thread Kuogee Hsieh
Add hbr3_hbr2 voltage and premphasis swing table to support HBR3 link rate. Changes in V2: -- replaced upper case with lower case at hbr3_hbr2 table Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-qmp.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-)

RE: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-18 Thread Kalra, Ashish
[AMD Public Use] -Original Message- From: Sean Christopherson Sent: Thursday, February 18, 2021 10:39 AM To: Kalra, Ashish Cc: pbonz...@redhat.com; t...@linutronix.de; mi...@redhat.com; h...@zytor.com; rkrc...@redhat.com; j...@8bytes.org; b...@suse.de; Lendacky, Thomas ; x...@kernel.

Re: [PATCH v3 4/8] cgroup: rstat: support cgroup1

2021-02-18 Thread Johannes Weiner
On Thu, Feb 18, 2021 at 04:45:11PM +0100, Michal Koutný wrote: > On Wed, Feb 17, 2021 at 03:52:59PM -0500, Johannes Weiner > wrote: > > In this case, we're talking about a relatively small data structure > > and the overhead is per mountpoint. > IIUC, it is per each mountpoint's number of cgroups

Re: [PATCH 12/14] KVM: x86/mmu: Don't set dirty bits when disabling dirty logging w/ PML

2021-02-18 Thread Paolo Bonzini
On 13/02/21 01:50, Sean Christopherson wrote: This means that spurious PML entries will be created for memslots with dirty logging disabled if at least one other memslot has dirty logging enabled, but for all known use cases, dirty logging is a global VMM control. This is not true. For examp

'perf probe' and symbols from .text.

2021-02-18 Thread Evgenii Shatokhin
Hi, It seems, 'perf probe' can only see functions from .text section in the kernel modules, but not from .text.unlikely or other .text.* sections. For example, with kernel 5.11 and nf_conntrack.ko with debug info, 'perf probe' succeeds for nf_conntrack_attach() from .text and fails for nf_ct

Re: [PATCH] net: hsr: add support for EntryForgetTime

2021-02-18 Thread George McCollister
On Thu, Feb 18, 2021 at 9:01 AM Marco Wenzel wrote: > > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When a > node does not send any frame within this time, the sequence number check > for can be ignored. This solves communication issues with Cisco IE 2000 > in Redbox mode. >

Re: [PATCH] perf record: Fix continue profiling after draining the buffer

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 18, 2021 at 10:20:53AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 05, 2021 at 11:46:12AM +0100, Jiri Olsa escreveu: > > On Fri, Feb 05, 2021 at 07:35:22PM +0900, Namhyung Kim wrote: > > > Hello, > > > > > > On Fri, Feb 5, 2021 at 3:50 PM Yang Jihong wrote: > > > > > > > >

[RFC 1/2] capability: Introduce CAP_FIRMWARE_UPGRADE

2021-02-18 Thread Mario Limonciello
Split out permissions specifically for firmware upgrades from CAP_SYS_ADMIN to a new separate capability. This will allow userspace applications that would traditionally have needed CAP_SYS_ADMIN to perform firmware upgrades to have a reduced permission set. Signed-off-by: Mario Limonciello ---

Re: [PATCH] ARM: dts: nuvoton: Fix flash layout

2021-02-18 Thread Benjamin Fair
On Thu, 18 Feb 2021 at 04:42, wrote: > > From: "Anton D. Kachalov" > > This change satisfy OpenBMC requirements for flash layout. > > Signed-off-by: Anton D. Kachalov > --- > arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++ > 1 file changed, 8 insertions(+), 20 deletions(

[RFC 2/2] nvme: Use CAP_FIRMWARE_UPGRADE to check user commands

2021-02-18 Thread Mario Limonciello
Software that is running with CAP_FIRMWARE_UPGRADE needs a limited set of opcode access: * Identify the disk * Download firmware to the disk * Commit the firmwware to the disk Signed-off-by: Mario Limonciello --- drivers/nvme/host/core.c | 28 1 file changed, 24 inse

Re: [PATCH] staging: vc04_services: Fixed address type mismatch in vchiq_arm.c

2021-02-18 Thread Arnd Bergmann
On Thu, Feb 18, 2021 at 10:39 AM Greg KH wrote: > > On Thu, Feb 18, 2021 at 02:40:15PM +0530, Pritthijit Nath wrote: > > This change fixes a sparse address type mismatch warning "incorrect type > > in assignment (different address spaces)". > > > > Signed-off-by: Pritthijit Nath > > --- > > .../

Re: [PATCH v2 1/3] v4l: common: v4l2_get_link_freq: add printing a warning

2021-02-18 Thread Andrey Konovalov
Hi Jacopo, On 18.02.2021 10:55, Jacopo Mondi wrote: Hi Andrey, On Thu, Feb 18, 2021 at 01:11:32AM +0300, Andrey Konovalov wrote: Print a warning if V4L2_CID_LINK_FREQ control is not implemented. Signed-off-by: Andrey Konovalov --- drivers/media/v4l2-core/v4l2-common.c | 2 ++ 1 file chang

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
On 2/18/2021 3:31 AM, Willy Tarreau wrote: > On Thu, Feb 18, 2021 at 08:43:48AM +0100, Greg Kroah-Hartman wrote: >> On Wed, Feb 17, 2021 at 11:48:21AM -0800, Scott Branden wrote: >>> Other difficulty with the LTS version is the frequency it is updated. > > What a stange statement! So basically

Re: [PATCH v4 11/16] rpmsg: virtio: register the rpmsg_ctrl device

2021-02-18 Thread Arnaud POULIQUEN
Hi Dan, On 2/18/21 1:27 PM, Dan Carpenter wrote: > Hi Arnaud, > > url: > https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/introduce-a-generic-IOCTL-interface-for-RPMsg-channels-management/20210217-214044 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >

[PATCH v2.1 1/3] v4l: common: v4l2_get_link_freq: add printing a warning

2021-02-18 Thread Andrey Konovalov
Print a warning if V4L2_CID_LINK_FREQ control is not implemented. Signed-off-by: Andrey Konovalov Reviewed-by: Jacopo Mondi --- drivers/media/v4l2-core/v4l2-common.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-co

[RFC 0/2] Split out firmware upgrade from CAP_SYS_ADMIN

2021-02-18 Thread Mario Limonciello
Currently NVME (and probably other drivers) require CAP_SYS_ADMIN to send all commands to the device. This means that software running in userspace needs the stronger CAP_SYS_ADMIN permission when realistically a more limited subset of functionality is actually needed. To allow software that perf

[PATCH v6] vfs: fix copy_file_range regression in cross-fs copies

2021-02-18 Thread Luis Henriques
A regression has been reported by Nicolas Boichat, found while using the copy_file_range syscall to copy a tracefs file. Before commit 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") the kernel would return -EXDEV to userspace when trying to copy a file across different filesyst

Re: [PATCH] driver core: Avoid pointless deferred probe attempts

2021-02-18 Thread Rafael J. Wysocki
On Thu, Feb 18, 2021 at 12:51 AM Saravana Kannan wrote: > > There's no point in adding a device to the deferred probe list if we > know for sure that it doesn't have a matching driver. So, check if a > device can match with a driver before adding it to the deferred probe > list. What if a matchin

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Jari Ruusu
On Thursday, February 18, 2021 4:33 PM, Willy Tarreau wrote: > Usually you pick an LTS kernel for a specific hardware. If it > works that's great. But you cannot expect hardware to suddenly start to > work in the middle of a stable kernel. Sometimes it happens (PCI IDs) but > that's basically all

general protection fault in nl802154_del_llsec_dev

2021-02-18 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:57baf8cc net: axienet: Handle deferred probe on clock prop.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=16d83be2d0 kernel config: https://syzkaller.appspot.com/x/.config?x=8cb23303ddb9411f dashboar

Re: [PATCH] drivers/base/cpu: remove redundant initialization of variable retval

2021-02-18 Thread Rafael J. Wysocki
On Wed, Feb 17, 2021 at 8:51 PM Colin King wrote: > > From: Colin Ian King > > The variable retval is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value")

Re: [PATCH] driver core: Avoid pointless deferred probe attempts

2021-02-18 Thread Saravana Kannan
On Thu, Feb 18, 2021 at 9:18 AM Rafael J. Wysocki wrote: > > On Thu, Feb 18, 2021 at 12:51 AM Saravana Kannan wrote: > > > > There's no point in adding a device to the deferred probe list if we > > know for sure that it doesn't have a matching driver. So, check if a > > device can match with a dr

[PATCH 1/1] mm: proof-of-concept for balancing node zones occupancy

2021-02-18 Thread Charan Teja Reddy
This is a Proof-of-concept code for balancing the node zones occupancy whose imbalance may be caused by the memory hotplug. Signed-off-by: Charan Teja Reddy --- include/linux/migrate.h | 8 +- include/linux/mm.h | 3 + include/linux/mmzone.h | 2 + kernel/sysctl.c | 11 ++ m

Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-18 Thread Jason Gunthorpe
On Thu, Feb 18, 2021 at 02:45:54PM +, Matthew Wilcox wrote: > On Wed, Feb 17, 2021 at 11:02:52AM -0800, Andrew Morton wrote: > > On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz > > wrote: > > > page structs are not guaranteed to be contiguous for gigantic pages. The > > > > June 2014. That'

[RFC][PATCH 0/2] x86/retpoline: Retpoline on a diet

2021-02-18 Thread Peter Zijlstra
Hi! The first patch rearranges the implementation and consolidates unused bytes. The second patch uses INT3 over LFENCE to shrink the retpoline to 15 bytes, by which 4 can live in a cacheline. Patches have been boot tested on my IVB.

[RFC][PATCH 1/2] x86/retpoline: Simplify retpolines

2021-02-18 Thread Peter Zijlstra
Currently out retpolines consist of 2 symbols, __x86_indirect_thunk_\reg, which is the compiler target, and __x86_retpoline_\reg, which is the actual retpoline. Both are consecutive in code and aligned such that for any one register they both live in the same cacheline: <__x86_i

Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-18 Thread Zi Yan
On 18 Feb 2021, at 12:25, Jason Gunthorpe wrote: > On Thu, Feb 18, 2021 at 02:45:54PM +, Matthew Wilcox wrote: >> On Wed, Feb 17, 2021 at 11:02:52AM -0800, Andrew Morton wrote: >>> On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz >>> wrote: page structs are not guaranteed to be contiguou

[RFC][PATCH 2/2] x86/retpoline: Compress retpolines

2021-02-18 Thread Peter Zijlstra
By using int3 as a speculation fence instead of lfence, we can shrink the longest alternative to just 15 bytes: 0: e8 05 00 00 00 callq a <.altinstr_replacement+0xa> 5: f3 90 pause 7: cc int3 8: eb fb jmp5

Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-18 Thread Jason Gunthorpe
On Thu, Feb 18, 2021 at 12:27:58PM -0500, Zi Yan wrote: > On 18 Feb 2021, at 12:25, Jason Gunthorpe wrote: > > > On Thu, Feb 18, 2021 at 02:45:54PM +, Matthew Wilcox wrote: > >> On Wed, Feb 17, 2021 at 11:02:52AM -0800, Andrew Morton wrote: > >>> On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Russell King - ARM Linux admin
On Thu, Feb 18, 2021 at 05:19:54PM +, Jari Ruusu wrote: > In-tree iwlwifi worked half-ok on early 4.9.y stable. If > connection somehow de-autheticated (out of radio range or > whatever) it crashed the kernel spectacularly. Eventually that was > fixed and in-tree iwlwifi worked fine on 4.9.y an

[PATCH RFC 0/1] mm: balancing the node zones occupancy

2021-02-18 Thread Charan Teja Reddy
I would like to start discussion about balancing the occupancy of memory zones in a node in the system whose imabalance may be caused by migration of pages to other zones during hotremove and then hotadding same memory. In this case there is a lot of free memory in newly hotadd memory which can be

[PATCH] kcov: Remove kcov include from sched.h and move it to its users.

2021-02-18 Thread Sebastian Andrzej Siewior
The recent addition of in_serving_softirq() to kconv.h results in compile failure on PREEMPT_RT because it requires task_struct::softirq_disable_cnt. This is not available if kconv.h is included from sched.h. It is not needed to include kconv.h from sched.h. All but the net/ user already include t

[PATCH v2] bus: mhi: core: Wait for ready state after reset

2021-02-18 Thread Jeffrey Hugo
After the device has signaled the end of reset by clearing the reset bit, it will automatically reinit MHI and the internal device structures. Once That is done, the device will signal it has entered the ready state. Signaling the ready state involves sending an interrupt (MSI) to the host which

Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie

2021-02-18 Thread Krzysztof Wilczyński
[...] > > Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"), > > i.MX6QP PCIe has the similar issue. > > Define the length of the DBI registers and limit config space to its > > length for i.MX6QP PCIe too. > > You could probably flip these two sentences around to make the comm

Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-18 Thread Mike Kravetz
On 2/18/21 9:25 AM, Jason Gunthorpe wrote: > On Thu, Feb 18, 2021 at 02:45:54PM +, Matthew Wilcox wrote: >> On Wed, Feb 17, 2021 at 11:02:52AM -0800, Andrew Morton wrote: >>> On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz >>> wrote: page structs are not guaranteed to be contiguous for g

UBSAN: shift-out-of-bounds in netlink_recvmsg

2021-02-18 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b646acd5 net: re-solve some conflicts after net -> net-nex.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=129fbe04d0 kernel config: https://syzkaller.appspot.com/x/.config?x=dbc1ca9e55dc1f9f das

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
On 2/18/2021 8:51 AM, Sasha Levin wrote: > On Wed, Feb 17, 2021 at 11:48:21AM -0800, Scott Branden wrote: >> On 2021-02-17 1:40 a.m., Greg Kroah-Hartman wrote: >>> Following up on this as I did not hear back from you.  Are you and/or >>> your company willing to help out with the testing of 5.10

[PATCH] staging: rtl8188eu: Align block comments

2021-02-18 Thread Suryashankar Das
This patch fixes the checkpatch.pl warnings: WARNING: Block comments use * on subsequent lines WARNING: Block comments should align the * on each line Signed-off-by: Suryashankar Das --- drivers/staging/rtl8188eu/core/rtw_security.c | 82 +-- 1 file changed, 41 insertions(+), 41

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-18 Thread Xie He
On Thu, Feb 18, 2021 at 2:37 AM Leon Romanovsky wrote: > > It is not me who didn't explain, it is you who didn't want to write clear > comment that describes the headroom size without need of "3 - 1". Why do I need to write unnecessary comments when "3 - 1" and the current comment already explain

Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-18 Thread Zi Yan
On 18 Feb 2021, at 12:32, Jason Gunthorpe wrote: > On Thu, Feb 18, 2021 at 12:27:58PM -0500, Zi Yan wrote: >> On 18 Feb 2021, at 12:25, Jason Gunthorpe wrote: >> >>> On Thu, Feb 18, 2021 at 02:45:54PM +, Matthew Wilcox wrote: On Wed, Feb 17, 2021 at 11:02:52AM -0800, Andrew Morton wrote:

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
On 2/17/2021 11:48 AM, Scott Branden wrote: > Hi Greg, > > On 2021-02-17 1:40 a.m., Greg Kroah-Hartman wrote: >> On Tue, Jan 26, 2021 at 07:51:18PM +0100, Greg Kroah-Hartman wrote: >>> On Tue, Jan 26, 2021 at 10:30:16AM -0800, Scott Branden wrote: Hi Greg, On 2021-01-25 11:2

Re: [PATCH] mm, compaction: make fast_isolate_freepages() stay within zone

2021-02-18 Thread Vlastimil Babka
On 2/17/21 6:33 PM, Vlastimil Babka wrote: > Compaction always operates on pages from a single given zone when isolating > both pages to migrate and freepages. Pageblock boundaries are intersected with > zone boundaries to be safe in case zone starts or ends in the middle of > pageblock. The use of

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Greg Kroah-Hartman
On Thu, Feb 18, 2021 at 05:19:54PM +, Jari Ruusu wrote: > On Thursday, February 18, 2021 4:33 PM, Willy Tarreau wrote: > > Usually you pick an LTS kernel for a specific hardware. If it > > works that's great. But you cannot expect hardware to suddenly start to > > work in the middle of a stabl

Re: [PATCH] KVM: nSVM: prepare guest save area while is_guest_mode is true

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Paolo Bonzini wrote: > Right now, enter_svm_guest_mode is calling nested_prepare_vmcb_save and > nested_prepare_vmcb_control. This results in is_guest_mode being false > until the end of nested_prepare_vmcb_control. > > This is a problem because nested_prepare_vmcb_save can

Re: [PATCH] Staging: rtl8723bs: code-style fix

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 04:33:10PM +, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > Checkpatch complains the constant needs to be on the right side of the > comparison. The preferred way is: > > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 in

Re: [PATCH] staging: rtl8188eu: Align block comments

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 10:50:43PM +0530, Suryashankar Das wrote: > This patch fixes the checkpatch.pl warnings: > WARNING: Block comments use * on subsequent lines > WARNING: Block comments should align the * on each line > > Signed-off-by: Suryashankar Das > --- > drivers/staging/rtl8188eu/cor

Re: [PATCH 03/33] mm: Implement readahead_control pageset expansion

2021-02-18 Thread David Howells
Matthew Wilcox wrote: > So readahead_expand() needs to adjust the file's f_ra so that when the > application gets to 64kB, it kicks off the readahead of 4MB-8MB chunk (and > then when we get to 4MB+256kB, it kicks off the readahead of 8MB-12MB, > and so on). Ummm... Two questions: Firstly, how

Re: [PATCH 2/3] x86/sev-es: Check if regs->sp is trusted before adjusting #VC IST stack

2021-02-18 Thread Andy Lutomirski
On Thu, Feb 18, 2021 at 3:25 AM Joerg Roedel wrote: > > Hi Andy, > > On Wed, Feb 17, 2021 at 10:09:46AM -0800, Andy Lutomirski wrote: > > Can you get rid of the linked list hack while you're at it? This code > > is unnecessarily convoluted right now, and it seems to be just asking > > for weird b

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Kalra, Ashish wrote: > From: Sean Christopherson > > On Thu, Feb 18, 2021, Kalra, Ashish wrote: > > From: Sean Christopherson > > > > On Wed, Feb 17, 2021, Kalra, Ashish wrote: > > >> From: Sean Christopherson On Thu, Feb 04, 2021, > > >> Ashish Kalra wrote: > > >> > Fr

Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-18 Thread Mike Kravetz
On 2/18/21 9:40 AM, Zi Yan wrote: > On 18 Feb 2021, at 12:32, Jason Gunthorpe wrote: > >> On Thu, Feb 18, 2021 at 12:27:58PM -0500, Zi Yan wrote: >>> On 18 Feb 2021, at 12:25, Jason Gunthorpe wrote: >>> On Thu, Feb 18, 2021 at 02:45:54PM +, Matthew Wilcox wrote: > On Wed, Feb 17, 2021

Re: [PATCH v4 14/16] rpmsg: char: introduce a RPMsg driver for the RPMsg char device

2021-02-18 Thread Arnaud POULIQUEN
Hi Dan, On 2/18/21 1:33 PM, Dan Carpenter wrote: > Hi Arnaud, > > url: > https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/introduce-a-generic-IOCTL-interface-for-RPMsg-channels-management/20210217-214044 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Greg Kroah-Hartman
On Thu, Feb 18, 2021 at 09:21:13AM -0800, Florian Fainelli wrote: > As a company, we are most likely shooting ourselves in the foot by not > having a point of coordination with the Linux Foundation and key people > like you, Greg and other participants in the stable kernel. What does the LF have t

Re: [PATCH] objtool: Fix stack-swizzle for FRAME_POINTER=y

2021-02-18 Thread Josh Poimboeuf
On Thu, Feb 18, 2021 at 05:21:31PM +0100, Peter Zijlstra wrote: > On Wed, Feb 10, 2021 at 08:01:23PM -, tip-bot2 for Peter Zijlstra wrote: > > objtool: Support stack-swizzle > > --- > Subject: objtool: Fix stack-swizzle for FRAME_POINTER=y > From: Peter Zijlstra > Date: Thu Feb 18 17:14:10 CE

Re: [PATCH v10 14/16] KVM: x86: Add guest support for detecting and enabling SEV Live Migration feature.

2021-02-18 Thread Sean Christopherson
On Thu, Feb 04, 2021, Ashish Kalra wrote: > From: Ashish Kalra ... > arch/x86/include/asm/mem_encrypt.h | 8 + > arch/x86/kernel/kvm.c | 52 ++ > arch/x86/mm/mem_encrypt.c | 41 +++ > 3 files changed, 101 insertions(+)

Re: [PATCH v2 4/4] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp

2021-02-18 Thread Peter Xu
On Wed, Feb 17, 2021 at 05:46:30PM -0800, Mike Kravetz wrote: > On 2/17/21 12:46 PM, Peter Xu wrote: > > Huge pmd sharing for hugetlbfs is racy with userfaultfd-wp because > > userfaultfd-wp is always based on pgtable entries, so they cannot be shared. > > > > Walk the hugetlb range and unshare al

Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread Jim Mattson
On Thu, Feb 18, 2021 at 8:35 AM Sean Christopherson wrote: > > On Thu, Feb 18, 2021, Paolo Bonzini wrote: > > On 18/02/21 13:56, David Edmondson wrote: > > > On Thursday, 2021-02-18 at 12:54:52 +01, Paolo Bonzini wrote: > > > > > > > On 18/02/21 11:04, David Edmondson wrote: > > > > > When dumping

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
On 2/18/2021 9:53 AM, Greg Kroah-Hartman wrote: > On Thu, Feb 18, 2021 at 09:21:13AM -0800, Florian Fainelli wrote: >> As a company, we are most likely shooting ourselves in the foot by not >> having a point of coordination with the Linux Foundation and key people >> like you, Greg and other par

Re: [PATCH] driver core: Avoid pointless deferred probe attempts

2021-02-18 Thread Saravana Kannan
On Thu, Feb 18, 2021 at 9:24 AM Saravana Kannan wrote: > > On Thu, Feb 18, 2021 at 9:18 AM Rafael J. Wysocki wrote: > > > > On Thu, Feb 18, 2021 at 12:51 AM Saravana Kannan > > wrote: > > > > > > There's no point in adding a device to the deferred probe list if we > > > know for sure that it do

Re: [PATCH] kcov: Remove kcov include from sched.h and move it to its users.

2021-02-18 Thread Johannes Berg
On Thu, 2021-02-18 at 18:31 +0100, Sebastian Andrzej Siewior wrote: > The recent addition of in_serving_softirq() to kconv.h results in You typo'ed "kconv.h" pretty consistently ;-) But yes, that makes sense. Acked-by: Johannes Berg johannes

Re: [PATCH] KVM: nSVM: prepare guest save area while is_guest_mode is true

2021-02-18 Thread Paolo Bonzini
On 18/02/21 18:42, Sean Christopherson wrote: The bug is present since commit 06fc7772690d ("KVM: SVM: Activate nested state only when guest state is complete", 2010-04-25). Unfortunately, it is not clear from the commit message what issue exactly led to the change back then. It was probably re

Re: possible deadlock in inet_stream_connect

2021-02-18 Thread syzbot
syzbot has bisected this issue to: commit 40947e13997a1cba4e875893ca6e5d5e61a0689d Author: Florian Westphal Date: Fri Feb 12 23:59:56 2021 + mptcp: schedule worker when subflow is closed bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=109b88f2d0 start commit: 9ec5ee

Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread Paolo Bonzini
On 18/02/21 18:55, Jim Mattson wrote: Got it now. It would sort of help, because while dumping the MSR load/store area you could get hold of the real EFER, and use it to decide whether to dump the PDPTRs. EFER isn't guaranteed to be in the load list, either, e.g. if guest and host have the same

Re: [PATCH] sched/fair: Use true and false for bool variable

2021-02-18 Thread Steven Rostedt
On Thu, 18 Feb 2021 18:10:11 +0800 Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./kernel/sched/fair.c:9504:9-10: WARNING: return of 0/1 in function > 'voluntary_active_balance' with return type bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > ker

[PATCH 0/2] optee: fix OOM seen due to tee_shm_free()

2021-02-18 Thread Dhananjay Phadke
From: Allen Pais On Wed, 17 Feb 2021 14:57:12 +0530, Allen Pais wrote: > The following out of memory errors are seen on kexec reboot > from the optee core. > > [0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed > [0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -2

Re: [PATCH] KVM: nSVM: prepare guest save area while is_guest_mode is true

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Paolo Bonzini wrote: > On 18/02/21 18:42, Sean Christopherson wrote: > > > The bug is present since commit 06fc7772690d ("KVM: SVM: Activate nested > > > state only when guest state is complete", 2010-04-25). Unfortunately, > > > it is not clear from the commit message what i

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Willy Tarreau
Hi Florian! On Thu, Feb 18, 2021 at 09:42:00AM -0800, Florian Fainelli wrote: > > Other difficulty with the LTS version is the frequency it is updated. We > > would not > > pickup the changes that frequently to test. A quarterly, bi-annually, or > > when a critical fix > > is identified would

Re: [PATCH v3 1/1] process_madvise.2: Add process_madvise man page

2021-02-18 Thread Suren Baghdasaryan
On Wed, Feb 17, 2021 at 11:55 PM Michael Kerrisk (man-pages) wrote: > > Hello Suren, > > >> Thanks. I added a few words to clarify this.> > > Any link where I can see the final version? > > Sure: > https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/man2/process_madvise.2 > > Also ren

Re: [PATCH RFC 0/1] mm: balancing the node zones occupancy

2021-02-18 Thread David Hildenbrand
On 18.02.21 18:24, Charan Teja Reddy wrote: I would like to start discussion about balancing the occupancy of memory zones in a node in the system whose imabalance may be caused by migration of pages to other zones during hotremove and then hotadding same memory. In this case there is a lot of f

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Willy Tarreau
On Thu, Feb 18, 2021 at 06:53:56PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 18, 2021 at 09:21:13AM -0800, Florian Fainelli wrote: > > As a company, we are most likely shooting ourselves in the foot by not > > having a point of coordination with the Linux Foundation and key people > > like you

Re: [PATCH] sparc: make copy_thread honor pid namespaces

2021-02-18 Thread Eric W. Biederman
"Dmitry V. Levin" writes: > On sparc, fork and clone syscalls have an unusual semantics of > returning the pid of the parent process to the child process. > > Apparently, the implementation did not honor pid namespaces at all, > so the child used to get the pid of its parent in the init namespace

[PATCH] staging: rtl8188eu: Format comments

2021-02-18 Thread Suryashankar Das
This patch fixes the checkpatch.pl warnings: WARNING: Block comments use * on subsequent lines WARNING: Block comments should align the * on each line Signed-off-by: Suryashankar Das --- drivers/staging/rtl8188eu/core/rtw_security.c | 72 --- 1 file changed, 29 insertions(+), 43

Re: [PATCH] KVM: nSVM: prepare guest save area while is_guest_mode is true

2021-02-18 Thread Paolo Bonzini
On 18/02/21 19:12, Sean Christopherson wrote: Yeah, the problem is I don't understand why 06fc7772690d fixed things in 11 year old KVM instead of breaking them, because effectively this patch is reverting it. 11 year old KVM didn't grab a different VMCB when updating the intercepts, it had alre

Re: [PATCH 00/11] perf intel-pt: Add limited support for tracing guest kernels

2021-02-18 Thread Andi Kleen
On Thu, Feb 18, 2021 at 11:57:50AM +0200, Adrian Hunter wrote: > Hi > > Currently, only kernel tracing is supported and only with "timeless" decoding > i.e. no TSC timestamps Patches look good to me. That will be quite useful. Acked-by: Andi Kleen Thanks, -Andi

Re: [PATCH] staging: wimax/i2400m: don't change the endianness of one byte variable

2021-02-18 Thread Arnd Bergmann
On Thu, Feb 18, 2021 at 10:54 AM Muhammad Usama Anjum wrote: > > On Thu, 2021-02-18 at 10:40 +0100, Greg KH wrote: > > On Thu, Feb 18, 2021 at 02:21:54PM +0500, Muhammad Usama Anjum wrote: > > > It is wrong to change the endianness of a variable which has just one > > > byte size. > > > > > > Spar

<    1   2   3   4   5   6   7   8   9   10   >