[PATCH 0/4] btrfs: Convert more kmaps to kmap_local_page()

2021-02-16 Thread ira . weiny
From: Ira Weiny I am submitting these for 5.13. Further work to remove more kmap() calls in favor of the kmap_local_page() this series converts those calls which required more than a common pattern which were covered in my previous series[1]. This is the second of what I hope to be 3 series to

[PATCH 4/4] fs/btrfs: Convert block context kmap's to kmap_local_page()

2021-02-16 Thread ira . weiny
From: Ira Weiny btrfsic_read_block() (which calls kmap()) and btrfsic_release_block_ctx() (which calls kunmap()) are always called within a single thread of execution. Therefore the mappings created within these calls can be a thread local mapping. Convert the kmap() of bloc_ctx->pagev to kmap_

[PATCH 3/4] fs/btrfs: Use kmap_local_page() in __btrfsic_submit_bio()

2021-02-16 Thread ira . weiny
From: Ira Weiny Again there is an array of pointers which must be unmapped in the correct order. Convert the kmap()'s to kmap_local_page() and adjust the unmapping to work backwards through the unmapping loop. Signed-off-by: Ira Weiny --- fs/btrfs/check-integrity.c | 8 1 file change

Re: mlx5 HW crypto offload support

2021-02-16 Thread James Spader
Hi Saeed Thank you so much for the response!! It helped me a lot. The guide is very helpful. It is detailed and well written. Thank you Best regards - James On Wed, Feb 17, 2021 at 3:26 AM Saeed Mahameed wrote: > > On Mon, 2021-02-15 at 23:17 +0530, James Spader wrote: > > Hi All, > > > > D

[PATCH v3 1/2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-16 Thread Lyude Paul
From: Tejas Upadhyay For Legacy S3 suspend/resume GEN9 BC needs to enable and setup TGP PCH. v2: * Move Wa_14010685332 into it's own function - vsyrjala * Add TODO comment about figuring out if we can move this workaround - imre v3: * Rename cnp_irq_post_reset() to cnp_display_clock_wa() * Add T

[PATCH v3 2/2] drm/i915/icp+: Use icp_hpd_irq_setup() instead of spt_hpd_irq_setup()

2021-02-16 Thread Lyude Paul
While reviewing patches for handling workarounds related to gen9 bc, Imre from Intel discovered that we're using spt_hpd_irq_setup() on ICP+ PCHs despite it being almost the same as icp_hpd_irq_setup(). Since we need to be calling icp_hpd_irq_setup() to ensure that CML-S/TGP platforms function corr

Re: [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping

2021-02-16 Thread Ruan Shiyang
On 2021/2/10 下午9:33, Christoph Hellwig wrote: +extern int mf_dax_mapping_kill_procs(struct address_space *mapping, pgoff_t index, int flags); No nee for the extern, please avoid the overly long line. OK. I'd like to confirm one thing... I have checked all of this patchset by checkpatch

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-02-16 Thread Guenter Roeck
too. So it > > > should be easier if you choose to test. > > > > > >> Given the number of problems observed, I personally think that it is way > > >> too early for this patch. We'll have no end of problems if it is applied > > >> to

Re: [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-16 Thread Rob Clark
On Tue, Feb 16, 2021 at 12:10 PM Jonathan Marek wrote: > > Ignore nvmem_cell_get() EOPNOTSUPP error in the same way as a ENOENT error, > to fix the case where the kernel was compiled without CONFIG_NVMEM. > > Fixes: fe7952c629da ("drm/msm: Add speed-bin support to a618 gpu") > Signed-off-by: Jonat

Re: [PATCH 0/2] block: avoid to drop & re-add partitions if partitions aren't changed

2021-02-16 Thread Ming Lei
On Tue, Feb 16, 2021 at 09:44:30AM +0100, Christoph Hellwig wrote: > On Mon, Feb 15, 2021 at 12:03:41PM +0800, Ming Lei wrote: > > Hello, > > I think this is a fundamentally bad idea. We should not keep the > parsed partition state around forever just to work around some buggy > user space softwa

Re: [PATCH 4/7] fsdax: Replace mmap entry in case of CoW

2021-02-16 Thread Ruan Shiyang
On 2021/2/16 下午9:11, David Sterba wrote: On Mon, Feb 08, 2021 at 01:09:21AM +0800, Shiyang Ruan wrote: We replace the existing entry to the newly allocated one in case of CoW. Also, we mark the entry as PAGECACHE_TAG_TOWRITE so writeback marks this entry as writeprotected. This helps us snaps

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-02-16 Thread Saravana Kannan
ots of reviews to complete before the end of > > > >> the week, > > > >> with the 5.12 commit window coming up. > > > > > > > > Ok. By next week, all the fixes should be in linux-next too. So it > > > > should be easier if you choose to

Re: [PATCH 5/7] fsdax: Dedup file range to use a compare function

2021-02-16 Thread Ruan Shiyang
On 2021/2/10 下午9:19, Christoph Hellwig wrote: On Tue, Feb 09, 2021 at 05:46:13PM +0800, Ruan Shiyang wrote: On 2021/2/9 下午5:34, Christoph Hellwig wrote: On Tue, Feb 09, 2021 at 05:15:13PM +0800, Ruan Shiyang wrote: The dax dedupe comparison need the iomap_ops pointer as argument, so my un

Re: [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full

2021-02-16 Thread Manivannan Sadhasivam
On Tue, Feb 16, 2021 at 11:48:34AM -0700, Jeffrey Hugo wrote: > From: Fan Wu > > Currently ENOMEM is returned when MHI ring is full. This error code is > very misleading. Change to EBUSY instead. > Please use the subject prefix: "bus: mhi: ..." Thanks, Mani > Signed-off-by: Fan Wu > Signed-

Re: [PATCH] mhi_bus: core: Check state before processing power_down

2021-02-16 Thread Manivannan Sadhasivam
On Tue, Feb 16, 2021 at 02:38:16PM -0700, Jeffrey Hugo wrote: > We cannot process a power_down if the power state is DISABLED. There is > no valid mhi_ctxt in that case, so attepting to process the power_down > will likely result in a null pointer dereference. If the power state is > DISABLED, th

Re: [PATCH v2] drm/nouveau/pmu: fix timeout on GP108

2021-02-16 Thread Alexandre Courbot
On Wed, Feb 17, 2021 at 1:20 AM Diego Viola wrote: > > This code times out on GP108, probably because the BIOS puts it into a > bad state. > > Since we reset the PMU on driver load anyway, we are at no risk from > missing a response from it since we are not waiting for one to begin > with. This l

Re: [PATCH 2/2] libnvdimm: Make remove callback return void

2021-02-16 Thread Dan Williams
On Fri, Feb 12, 2021 at 9:21 AM Uwe Kleine-König wrote: > > All drivers return 0 in their remove callback and the driver core ignores > the return value of nvdimm_bus_remove() anyhow. So simplify by changing > the driver remove callback to return void and return 0 unconditionally > to the upper la

Re: [PATCH v2 0/5] dax-device: Some cleanups

2021-02-16 Thread Dan Williams
On Fri, Feb 5, 2021 at 2:29 PM Uwe Kleine-König wrote: > > Hello, > > I didn't get any feedback for the (implicit) v1 of this series that > started with Message-Id: 20210127230124.109522-1-...@kleine-koenig.org, > but I identified a few improvements myself: > > - Use "dax-device" consistently as

Re: [PATCH v2 0/5] dax-device: Some cleanups

2021-02-16 Thread Dan Williams
On Tue, Feb 16, 2021 at 7:48 PM Dan Williams wrote: > > On Fri, Feb 5, 2021 at 2:29 PM Uwe Kleine-König > wrote: > > > > Hello, > > > > I didn't get any feedback for the (implicit) v1 of this series that > > started with Message-Id: 20210127230124.109522-1-...@kleine-koenig.org, > > but I identi

Re: [PATCH 1/2] ext4: Handle casefolding with encryption

2021-02-16 Thread Daniel Rosenberg
I'm not sure what the conflict is, at least format-wise. Naturally, there would need to be some work to reconcile the two patches, but my patch only alters the format for directories which are encrypted and casefolded, which always must have the additional hash field. In the case of dirdata along w

Re: [PATCH] arm64: dts: qcom: sm8250: Fix epss_l3 unit address

2021-02-16 Thread Sibi Sankar
On 2021-02-12 01:06, Georgi Djakov wrote: The unit address of the epss_l3 node is incorrect and does not match the address of its "reg" property. Let's fix it. Signed-off-by: Georgi Djakov Thanks for catching it :) Reviewed-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-

[PATCH v5 0/9] CXL 2.0 Support

2021-02-16 Thread Ben Widawsky
# Changes since v4 [1] * Use vmemdup_user instead of open-coded (Al Viro) * Fix when kernel docs get introduced (Ben) * Fix unhappy sphinx '%-*' (sfr) * Remove redundant initialization (Colin, Dan C) * Make cxl_mem_mbox_send_cmd enforce size (Dan, Jonathan) * Except for variable sized output (

[PATCH v5 1/9] cxl/mem: Introduce a driver for CXL-2.0-Type-3 endpoints

2021-02-16 Thread Ben Widawsky
From: Dan Williams The CXL.mem protocol allows a device to act as a provider of "System RAM" and/or "Persistent Memory" that is fully coherent as if the memory was attached to the typical CPU memory controller. With the CXL-2.0 specification a PCI endpoint can implement a "Type-3" device interfa

[PATCH v5 2/9] cxl/mem: Find device capabilities

2021-02-16 Thread Ben Widawsky
Provide enough functionality to utilize the mailbox of a memory device. The mailbox is used to interact with the firmware running on the memory device. The flow is proven with one implemented command, "identify". Because the class code has already told the driver this is a memory device and the ide

[PATCH v5 3/9] cxl/mem: Register CXL memX devices

2021-02-16 Thread Ben Widawsky
From: Dan Williams Create the /sys/bus/cxl hierarchy to enumerate: * Memory Devices (per-endpoint control devices) * Memory Address Space Devices (platform address ranges with interleaving, performance, and persistence attributes) * Memory Regions (active provisioned memory from an address s

[PATCH v5 4/9] cxl/mem: Add basic IOCTL interface

2021-02-16 Thread Ben Widawsky
Add a straightforward IOCTL that provides a mechanism for userspace to query the supported memory device commands. CXL commands as they appear to userspace are described as part of the UAPI kerneldoc. The command list returned via this IOCTL will contain the full set of commands that the driver sup

[PATCH v5 5/9] cxl/mem: Add a "RAW" send command

2021-02-16 Thread Ben Widawsky
The CXL memory device send interface will have a number of supported commands. The raw command is not such a command. Raw commands allow userspace to send a specified opcode to the underlying hardware and bypass all driver checks on the command. The primary use for this command is to [begrudgingly]

[PATCH v5 6/9] cxl/mem: Enable commands via CEL

2021-02-16 Thread Ben Widawsky
CXL devices identified by the memory-device class code must implement the Device Command Interface (described in 8.2.9 of the CXL 2.0 spec). While the driver already maintains a list of commands it supports, there is still a need to be able to distinguish between commands that the driver knows abou

[PATCH v5 8/9] MAINTAINERS: Add maintainers of the CXL driver

2021-02-16 Thread Ben Widawsky
Cc: Dan Williams Cc: Vishal Verma Cc: Ira Weiny Cc: Alison Schofield Signed-off-by: Ben Widawsky --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6eff4f720c72..93c8694a8f04 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -,6 +4

[PATCH v5 7/9] cxl/mem: Add set of informational commands

2021-02-16 Thread Ben Widawsky
Add initial set of formal commands beyond basic identify and command enumeration. Signed-off-by: Ben Widawsky Reviewed-by: Dan Williams Reviewed-by: Jonathan Cameron (v2) --- drivers/cxl/mem.c| 9 + include/uapi/linux/cxl_mem.h | 5 + 2 files changed, 14 insertions(+)

[PATCH] remove unused variable driver_desc

2021-02-16 Thread Sean Behan
--- drivers/staging/emxx_udc/emxx_udc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index 3536c03ff523..741147a4f0fe 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -38,7

[RFC PATCH v5 9/9] cxl/mem: Add payload dumping for debug

2021-02-16 Thread Ben Widawsky
It's often useful in debug scenarios to see what the hardware has dumped out. As it stands today, any device error will result in the payload not being copied out, so there is no way to triage commands which weren't expected to fail (and sometimes the payload may have that information). The functi

[PATCH net-next v2 2/5] net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check

2021-02-16 Thread Samuel Holland
sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered, so there is no need to do it again here. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a

[PATCH net-next v2 4/5] net: stmmac: dwmac-sun8i: Minor probe function cleanup

2021-02-16 Thread Samuel Holland
Adjust the spacing and use an explicit "return 0" in the success path to make the function easier to parse. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH net-next v2 0/5] dwmac-sun8i cleanup and shutdown hook

2021-02-16 Thread Samuel Holland
These patches clean up some things I noticed while fixing suspend/resume behavior. The first four are minor code improvements. The last one adds a shutdown hook to minimize power consumption on boards without a PMIC. Changes v1 to v2: - Note the assumption of exclusive reset controller access in

[PATCH net-next v2 3/5] net: stmmac: dwmac-sun8i: Use reset_control_reset

2021-02-16 Thread Samuel Holland
Use the appropriate function instead of reimplementing it, and update the error message to match the code. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH net-next v2 1/5] net: stmmac: dwmac-sun8i: Return void from PHY unpower

2021-02-16 Thread Samuel Holland
This is a deinitialization function that always returned zero, and that return value was always ignored. Have it return void instead. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++--- 1 file changed, 2 insertions(+), 3 delet

[PATCH net-next v2 5/5] net: stmmac: dwmac-sun8i: Add a shutdown callback

2021-02-16 Thread Samuel Holland
The Ethernet MAC and PHY are usually major consumers of power on boards which may not be able to fully power off (those with no PMIC). Powering down the MAC and internal PHY saves power while these boards are "off". Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/etherne

Re: [PATCH V3 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-02-16 Thread Viresh Kumar
On 17-02-21, 00:24, Ionela Voinescu wrote: > I think it could be merged in patch 1/2 as it's part of enabling the use > of multiple sources of information for FIE. Up to you! Sure. > > static void amu_fie_setup(const struct cpumask *cpus) > > { > > - bool invariant; > > int cpu; > > > >

Re: [PATCH v9 0/7] FPGA Security Manager Class Driver

2021-02-16 Thread Moritz Fischer
Hi Russ, On Tue, Feb 16, 2021 at 09:46:53AM -0800, Russ Weight wrote: > I believe all of the dependencies have been accepted now. > > - Russ Sorry for dropping the ball on this, I'll get to this ASAP after -rc1 is tagged. > > On 2/15/21 6:56 AM, Tom Rix wrote: > > Russ, Moritz > > > > This pat

[tip:master] BUILD SUCCESS 74b68949724a504c579e0073e23beba7a71602ba

2021-02-16 Thread kernel test robot
ig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a003-20210216 i386 randconfig-a005-20210216 i386 randconfig-a002-20210216 i386 randc

[tip:x86/entry] BUILD SUCCESS 3aac798a917be3b8f2f647b834bb06bf2f8df4f1

2021-02-16 Thread kernel test robot
powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a003-20210216 x86_64 randconfig-a002-20210216 x86_64 randconfig-a004-20210216 x86_64 randconfig-a001-20210216 x86_64

Re: riscv+KASAN does not boot

2021-02-16 Thread Dmitry Vyukov
On Tue, Feb 16, 2021 at 9:42 PM Alex Ghiti wrote: > > Hi Dmitry, > > Le 2/16/21 à 6:25 AM, Dmitry Vyukov a écrit : > > On Tue, Feb 16, 2021 at 12:17 PM Dmitry Vyukov wrote: > >> > >> On Fri, Jan 29, 2021 at 9:11 AM Dmitry Vyukov wrote: > I was fixing KASAN support for my sv48 patchset so I

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Nicolas Boichat
On Mon, Feb 15, 2021 at 11:42 PM Luis Henriques wrote: > > Nicolas Boichat reported an issue when trying to use the copy_file_range > syscall on a tracefs file. It failed silently because the file content is > generated on-the-fly (reporting a size of zero) and copy_file_range needs > to know in

Re: [PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Document SM8350 CPUfreq compatible

2021-02-16 Thread Viresh Kumar
On 16-02-21, 16:42, Vinod Koul wrote: > Add the CPUfreq compatible for SM8350 SoC along with note for using the > specific compatible for SoCs > > Signed-off-by: Vinod Koul > --- > Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deleti

Re: [PATCH] opp: fix dev_pm_opp_set_rate for different frequency at the same opp level

2021-02-16 Thread Viresh Kumar
On 16-02-21, 15:10, Jonathan Marek wrote: > There is not "nothing to do" when the opp is the same. The frequency can > be different from opp->rate. I am sorry but I am not sure what are you trying to fix here and what exactly is broken here. Can you provide a usecase for your platform where this d

Re: [SPAM?]Re: arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared

2021-02-16 Thread Greg Ungerer
Hi Arnd, On 12/2/21 8:05 pm, Arnd Bergmann wrote: On Fri, Feb 12, 2021 at 6:48 AM kernel test robot wrote: FYI, the error/warning still remains. | ^~~~ arch/m68k/68000/dragen2.c: In function 'init_dragen2': arch/m68k/68000/dragen2.c:73:16: error: 'screen_

linux-next: manual merge of the tip tree with the pm tree

2021-02-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in: arch/x86/platform/intel-mid/device_libs/platform_bt.c between commit: 4590d98f5a4f ("sfi: Remove framework for deprecated firmware") from the pm tree and commit: bdb154f074a6 ("x86/platform/intel-mid: Convert comma to s

Re: [External] Re: [PATCH] psi: Optimize task switch inside shared cgroups

2021-02-16 Thread Chengming Zhou
Hello Johannes, 在 2021/2/17 上午4:00, Johannes Weiner 写道: > Hello Chengming, > > This patch looks useful to me. A couple of comments below: > > On Tue, Feb 09, 2021 at 03:14:13PM +0800, Chengming Zhou wrote: >> The commit 36b238d57172 ("psi: Optimize switching tasks inside shared >> cgroups") only u

Re: [External] Re: [PATCH 4/4] mm: memcontrol: fix swap uncharge on cgroup v2

2021-02-16 Thread Muchun Song
On Wed, Feb 17, 2021 at 12:59 AM Johannes Weiner wrote: > > Hello Muchun, > > On Sat, Feb 13, 2021 at 01:01:59AM +0800, Muchun Song wrote: > > The swap charges the actual number of swap entries on cgroup v2. > > If a swap cache page is charged successful, and then we uncharge > > the swap counter.

Re: [External] Re: [PATCH 4/4] mm: memcontrol: fix swap uncharge on cgroup v2

2021-02-16 Thread Muchun Song
On Wed, Feb 17, 2021 at 1:28 AM Johannes Weiner wrote: > > On Tue, Feb 16, 2021 at 11:59:01AM -0500, Johannes Weiner wrote: > > Hello Muchun, > > > > On Sat, Feb 13, 2021 at 01:01:59AM +0800, Muchun Song wrote: > > > The swap charges the actual number of swap entries on cgroup v2. > > > If a swap

memory leak in path_openat (2)

2021-02-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:dcc0b490 Merge tag 'powerpc-5.11-8' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1316c614d0 kernel config: https://syzkaller.appspot.com/x/.config?x=a2fbb1a71525e1d5 das

[PATCH 0/2] mmc: core: add a new property

2021-02-16 Thread DooHyun Hwang
Add an optional property to not retry multiple block read error with several single block reads. DooHyun Hwang (2): dt-bindings: mmc: Add no-single-read-retry property mmc: core: Add no single read retries Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 6 ++ drivers/mmc/core

[PATCH 2/2] mmc: core: Add no single read retries

2021-02-16 Thread DooHyun Hwang
This makes to handle read errors faster by not retrying multiple block read(CMD18) errors with single block reads(CMD17). On some bad SD Cards that have problem with read operations, it is not helpful to retry multiple block read errors with several single block reads, and it is delayed to treat r

[PATCH 1/2] dt-bindings: mmc: Add no-single-read-retry property

2021-02-16 Thread DooHyun Hwang
Add an optional property to not retry multiple block read error with several single block reads. This property makes to handle read errors faster by not retrying multiple block read errors with single block reads. Signed-off-by: DooHyun Hwang --- Documentation/devicetree/bindings/mmc/mmc-contro

Re: DT overlay applied via pinctrl description

2021-02-16 Thread Frank Rowand
+Frank, Rob, devicetree list On 2/16/21 9:35 AM, Michal Simek wrote: > Hi, > > I have a question about expectations when pinctrl setting is applied. In > DTS all nodes are described in the order available in DT. > > uart-default { > mux { > ... > }; > > conf { >

[PATCH 0/2] mmc: core: add a new property

2021-02-16 Thread DooHyun Hwang
Add an optional property to not retry multiple block read error with several single block reads. DooHyun Hwang (2): dt-bindings: mmc: Add no-single-read-retry property mmc: core: Add no single read retries Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 6 ++ drivers/mmc/core

[PATCH 1/2] dt-bindings: mmc: Add no-single-read-retry property

2021-02-16 Thread DooHyun Hwang
Add an optional property to not retry multiple block read error with several single block reads. This property makes to handle read errors faster by not retrying multiple block read errors with single block reads. Signed-off-by: DooHyun Hwang --- Documentation/devicetree/bindings/mmc/mmc-contro

[PATCH 2/2] mmc: core: Add no single read retries

2021-02-16 Thread DooHyun Hwang
This makes to handle read errors faster by not retrying multiple block read(CMD18) errors with single block reads(CMD17). On some bad SD Cards that have problem with read operations, it is not helpful to retry multiple block read errors with several single block reads, and it is delayed to treat r

Re: [PATCH v2 1/2] exfat: add initial ioctl function

2021-02-16 Thread Namjae Jeon
2021-02-17 9:33 GMT+09:00, Hyeongseok Kim : > On 2/17/21 9:17 AM, Chaitanya Kulkarni wrote: >> On 2/16/21 16:13, Hyeongseok Kim wrote: >>> Sorry, I don't understand exactly. >>> You're saying that these 2 patch should be merged to a single patch? >>> Would it be better? >> I think so unless there i

Re: memory leak in path_openat (2)

2021-02-16 Thread Al Viro
On Tue, Feb 16, 2021 at 09:21:14PM -0800, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:dcc0b490 Merge tag 'powerpc-5.11-8' of git://git.kernel.or.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1316c614d0 > kernel

Re: {standard input}:577: Error: unsupported relocation against base

2021-02-16 Thread Michael Ellerman
Segher Boessenkool writes: > Hi! > > On Tue, Feb 16, 2021 at 08:36:02PM +1100, Michael Ellerman wrote: >> Feng Tang writes: >> > {standard input}:577: Error: unsupported relocation against base >> > {standard input}:580: Error: unsupported relocation against base >> > {standard input}:583:

Re: [PATCH 2/2] mmc: core: Add no single read retries

2021-02-16 Thread Adrian Hunter
On 17/02/21 7:22 am, DooHyun Hwang wrote: > This makes to handle read errors faster by not retrying > multiple block read(CMD18) errors with single block reads(CMD17). > > On some bad SD Cards that have problem with read operations, > it is not helpful to retry multiple block read errors with > se

[PATCH v2] psi: Optimize task switch inside shared cgroups

2021-02-16 Thread Chengming Zhou
The commit 36b238d57172 ("psi: Optimize switching tasks inside shared cgroups") only update cgroups whose state actually changes during a task switch only in task preempt case, not in task sleep case. We actually don't need to clear and set TSK_ONCPU state for common cgroups of next and prev task

[PATCH] thermal: cpufreq_cooling: freq_qos_update_request() returns < 0 on error

2021-02-16 Thread Viresh Kumar
freq_qos_update_request() returns 1 if the effective constraint value has changed, 0 if the effective constraint value has not changed, or a negative error code on failures. The frequency constraints for CPUs can be set by different parts of the kernel. If the maximum frequency constraint set by o

Re: [PATCH] cpufreq: exclude boost frequencies from valid count if not enabled

2021-02-16 Thread Viresh Kumar
Hi Thara, On 16-02-21, 19:00, Thara Gopinath wrote: > This is a fix for a regression observed on db845 platforms with 5.7-rc11 > kernel. On these platforms running stress tests with 5.11-rc7 kernel > causes big cpus to overheat and ultimately shutdown the system due to > hitting critical temperat

Re: [PATCH 2/2] mmc: core: Add no single read retries

2021-02-16 Thread Adrian Hunter
On 17/02/21 7:46 am, Adrian Hunter wrote: > On 17/02/21 7:22 am, DooHyun Hwang wrote: >> This makes to handle read errors faster by not retrying >> multiple block read(CMD18) errors with single block reads(CMD17). >> >> On some bad SD Cards that have problem with read operations, >> it is not helpf

[PATCH v3 net-next 7/7] ptp: ptp_clockmatrix: clean-up - parenthesis around a == b are unnecessary

2021-02-16 Thread vincent.cheng.xh
From: Vincent Cheng Code clean-up. Signed-off-by: Vincent Cheng --- drivers/ptp/ptp_clockmatrix.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c index dc42c36..75463c2 100644 --- a/drivers/pt

[PATCH v3 net-next 3/7] ptp: ptp_clockmatrix: Remove unused header declarations.

2021-02-16 Thread vincent.cheng.xh
From: Vincent Cheng Removed unused header declarations. Signed-off-by: Vincent Cheng --- drivers/ptp/ptp_clockmatrix.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ptp/ptp_clockmatrix.h b/drivers/ptp/ptp_clockmatrix.h index 0233236..fb32327 100644 --- a/drivers/ptp/ptp_clockmat

[PATCH v3 net-next 1/7] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-16 Thread vincent.cheng.xh
From: Vincent Cheng Part of the device initialization aligns the rising edge of the output clock to the internal 1 PPS clock. If the system APLL and DPLL is not locked, then the alignment will fail and there will be a fixed offset between the internal 1 PPS clock and the output clock. After load

[PATCH v3 1/1] exfat: add support ioctl and FITRIM function

2021-02-16 Thread Hyeongseok Kim
Add FITRIM ioctl to enable discarding unused blocks while mounted. As current exFAT doesn't have generic ioctl handler, add empty ioctl function first, and add FITRIM handler. Signed-off-by: Hyeongseok Kim --- fs/exfat/balloc.c | 81 + fs/exfat/dir.c

[PATCH v3 0/1] Add FITRIM ioctl support for exFAT filesystem

2021-02-16 Thread Hyeongseok Kim
This is for adding FITRIM ioctl functionality to exFAT filesystem. To do that, add generic ioctl function and FITRIM handler. Changelog = v2->v3: - Remove unnecessary local variable - Merge all changes to a single patch v1->v2: - Change variable declaration order as reverse tree style. -

Re: [PATCH v2 1/2] exfat: add initial ioctl function

2021-02-16 Thread Hyeongseok Kim
On 2/17/21 2:39 PM, Namjae Jeon wrote: Hi Hyeongseok, Do you have any other opinion about this? I also think this patch should be combined with the 2/2 patch. If you agree, I'll merge these as one. Yep, Agreed. Please do that:) Thanks! Thank you for the opinion. I sent out v3.

[PATCH v3 net-next 5/7] ptp: ptp_clockmatrix: Coding style - tighten vertical spacing.

2021-02-16 Thread vincent.cheng.xh
From: Vincent Cheng Code clean-up. * Remove blank line between variable declarations. * Remove blank line between: err = blah(...) if (err) ... * Remove unnecessary blank line before/after loop constructs. Signed-off-by: Vincent Cheng --- drivers/ptp/ptp_clock

[PATCH v3 net-next 4/7] ptp: ptp_clockmatrix: Clean-up dev_*() messages.

2021-02-16 Thread vincent.cheng.xh
From: Vincent Cheng Code clean-up. * Remove unnecessary \n termination from dev_*() messages. * Remove 'char *fmt' to define strings to stay within 80 column limit. Not needed since coding guidelines increased to 100 columns limit. Keeping format in place allows static code checkers to

[PATCH v3 net-next 2/7] ptp: ptp_clockmatrix: Add alignment of 1 PPS to idtcm_perout_enable.

2021-02-16 Thread vincent.cheng.xh
From: Vincent Cheng When enabling output using PTP_CLK_REQ_PEROUT, need to align the output clock to the internal 1 PPS clock. Signed-off-by: Vincent Cheng Acked-by: Richard Cochran --- drivers/ptp/ptp_clockmatrix.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff

[PATCH v3 net-next 0/7] ptp: ptp_clockmatrix: Fix output 1 PPS alignment.

2021-02-16 Thread vincent.cheng.xh
From: Vincent Cheng This series fixes a race condition that may result in the output clock not aligned to internal 1 PPS clock. Part of device initialization is to align the rising edge of output clocks to the internal rising edge of the 1 PPS clock. If the system APLL and DPLL are not locked w

[PATCH v3 net-next 6/7] ptp: ptp_clockmatrix: Simplify code - remove unnecessary `err` variable.

2021-02-16 Thread vincent.cheng.xh
From: Vincent Cheng Code clean-up. Signed-off-by: Vincent Cheng --- drivers/ptp/ptp_clockmatrix.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c index 241bff0..dc42c36 100644 --- a/drivers/ptp/ptp_clockmatri

arch/sh/kernel/ftrace.c:368:17: sparse: sparse: incorrect type in argument 1 (different address spaces)

2021-02-16 Thread kernel test robot
Hi Luc, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f40ddce88593482919761f74910f42f4b84c004b commit: e5fc436f06eef54ef512ea55a9db8eb9f2e76959 sparse: use static inline for __chk_{user,io}_ptr() date: 6 month

Re: [PATCH] remove unused variable driver_desc

2021-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 10:59:51PM -0500, Sean Behan wrote: > --- > drivers/staging/emxx_udc/emxx_udc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > b/drivers/staging/emxx_udc/emxx_udc.c > index 3536c03ff523..741147a4f0fe 100644 > --- a/drivers/st

Re: [v8 PATCH 05/13] mm: vmscan: use kvfree_rcu instead of call_rcu

2021-02-16 Thread Kirill Tkhai
On 17.02.2021 03:13, Yang Shi wrote: > Using kvfree_rcu() to free the old shrinker_maps instead of call_rcu(). > We don't have to define a dedicated callback for call_rcu() anymore. > > Signed-off-by: Yang Shi Acked-by: Kirill Tkhai > --- > mm/vmscan.c | 7 +-- > 1 file changed, 1 inserti

Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute

2021-02-16 Thread Faiyaz Mohammed
Hi Matthew, On 1/12/2021 5:52 PM, Matthew Wilcox wrote: > On Tue, Jan 12, 2021 at 02:51:27PM +0530, Faiyaz Mohammed wrote: >> @@ -5180,6 +5187,7 @@ static int any_slab_objects(struct kmem_cache *s) >> >> struct slab_attribute { >> struct attribute attr; >> +struct bin_attribute bin_att

Re: [v8 PATCH 09/13] mm: vmscan: add per memcg shrinker nr_deferred

2021-02-16 Thread Kirill Tkhai
On 17.02.2021 03:13, Yang Shi wrote: > Currently the number of deferred objects are per shrinker, but some slabs, > for example, > vfs inode/dentry cache are per memcg, this would result in poor isolation > among memcgs. > > The deferred objects typically are generated by __GFP_NOFS allocations,

Re: KASAN: invalid-access Write in enqueue_timer

2021-02-16 Thread Dmitry Vyukov
On Tue, Feb 16, 2021 at 7:15 PM Dmitry Vyukov wrote: > > On Tue, Feb 16, 2021 at 06:50:20PM +0100, Jason A. Donenfeld wrote: > > > On Tue, Feb 16, 2021 at 6:46 PM Jason A. Donenfeld > > > wrote: > > > > On Tue, Feb 16, 2021 at 6:28 PM Catalin Marinas > > > > wrote: > > > > > > hlist_add_head

Re: [PATCH v2 0/5] dax-device: Some cleanups

2021-02-16 Thread Uwe Kleine-König
Hello Dan, On 2/17/21 4:55 AM, Dan Williams wrote: One small comment on patch5, otherwise looks good. I take it back, patch5 looks good. I was going to ask about the return value removal for dax_bus_remove(), but that would need struct bus_type to change prototypes. Changing struct bus_type:

Re: [v8 PATCH 10/13] mm: vmscan: use per memcg nr_deferred of shrinker

2021-02-16 Thread Kirill Tkhai
On 17.02.2021 03:13, Yang Shi wrote: > Use per memcg's nr_deferred for memcg aware shrinkers. The shrinker's > nr_deferred > will be used in the following cases: > 1. Non memcg aware shrinkers > 2. !CONFIG_MEMCG > 3. memcg is disabled by boot parameter > > Signed-off-by: Yang Shi A

Re: [RESEND PATCH] drm/tilcdc: fix raster control register setting

2021-02-16 Thread Tomi Valkeinen
On 16/02/2021 22:22, Dario Binacchi wrote: > The fdd property of the tilcdc_panel_info structure must set the reqdly > bit field (bit 12 to 19) of the raster control register. The previous > statement set the least significant bit instead. > > Signed-off-by: Dario Binacchi > > --- > > drivers

Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute

2021-02-16 Thread Faiyaz Mohammed
Hi Vlastimil, On 1/13/2021 9:35 PM, Vlastimil Babka wrote: > On 1/12/21 10:21 AM, Faiyaz Mohammed wrote: >> Reading the sys slab alloc_calls, free_calls returns the available object >> owners, but the size of this file is limited to PAGE_SIZE >> because of the limitation of sysfs attributes, it is

[PATCH V0 1/6] dt-bindings: Added the yaml bindings for DCC

2021-02-16 Thread Souradeep Chowdhury
Documentation for Data Capture and Compare(DCC) device tree bindings in yaml format. Signed-off-by: Souradeep Chowdhury --- .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 49 ++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/m

[PATCH V0 4/6] soc: qcom: dcc:Add the sysfs variables to the Data Capture and Compare driver(DCC)

2021-02-16 Thread Souradeep Chowdhury
Added the sysfs variables to expose the user space functionalities like DCC enable,disable,configure addresses and software triggers. Also added the necessary methods along with the same. Signed-off-by: Souradeep Chowdhury --- drivers/soc/qcom/dcc.c | 519

[PATCH V0 0/6] Add driver support for Data Capture and Compare Engine(DCC) for SM8150

2021-02-16 Thread Souradeep Chowdhury
DCC(Data Capture and Compare) is a DMA engine designed for debugging purposes.In case of a system crash or manual software triggers by the user the DCC hardware stores the value at the register addresses which can be used for debugging purposes.The DCC driver provides the user with sysfs interfa

[PATCH V0 2/6] arm64: dts: qcom: sm8150: Add Data Capture and Compare(DCC) support node

2021-02-16 Thread Souradeep Chowdhury
Add the DCC(Data Capture and Compare) device tree node entry along with the addresses for register regions. Signed-off-by: Souradeep Chowdhury --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/bo

[PATCH V0 3/6] soc: qcom: dcc:Add driver support for Data Capture and Compare unit(DCC)

2021-02-16 Thread Souradeep Chowdhury
The DCC is a DMA Engine designed to capture and store data during system crash or software triggers.The DCC operates based on link list entries which provides it with data and addresses and the function it needs to perform.These functions are read,write and loop.Added the basic driver in this patch

[PATCH V0 5/6] DCC:Added the sysfs entries for DCC(Data Capture and Compare) driver

2021-02-16 Thread Souradeep Chowdhury
The DCC is a DMA engine designed to store register values either in case of a system crash or in case of software triggers manually done by the user.Using DCC hardware and the sysfs interface of the driver the user can exploit various functionalities of DCC.The user can specify the register address

[PATCH V0 6/6] MAINTAINERS:Added the entry for DCC(Data Capture and Compare) driver support

2021-02-16 Thread Souradeep Chowdhury
Added the entries for all the files added as a part of driver support for DCC(Data Capture and Compare). Signed-off-by: Souradeep Chowdhury --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 546aa66..f0d208a 100644 --- a/MAINTAINERS +++ b/

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-16 Thread Eli Cohen
On Tue, Feb 16, 2021 at 04:25:20PM -0800, Si-Wei Liu wrote: > > > > The saved mvq->avail_idx will be used to recreate hardware virtq object > > > and > > > the used index in create_virtqueue(), once status DRIVER_OK is set. I > > > suspect we should pass the index to mvq->used_idx in > > > mlx5_v

[PATCH] Staging: mt7621-pci: pci-mt7621: fixed a blank line coding style issue

2021-02-16 Thread Selvakumar Elangovan
Removed an unecessary blank line before closing brace reported by checkpatch.pl Signed-off-by: Selvakumar Elangovan --- drivers/staging/mt7621-pci/pci-mt7621.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c in

[PATCH v4 net-next] net: socket: use BIT() for MSG_*

2021-02-16 Thread menglong8 . dong
From: Menglong Dong The bit mask for MSG_* seems a little confused here. Replace it with BIT() to make it clear to understand. Signed-off-by: Menglong Dong --- v4: - CC netdev v3: - move changelog here v2: - use BIT() instead of BIT_MASK() --- include/linux/socket.h | 71 ++

RE: [Intel-gfx] [drm/i915] 04ff178484: phoronix-test-suite.supertuxkart.1024x768.Fullscreen.Ultimate.1.GranParadisoIsland.frames_per_second -30.4% regression

2021-02-16 Thread Chiou, Cooper
Hi upstream committee, Please consider to merge this patch which resolved VP8 hardware encoding GPU hang critical issue on Gen9 sku, and there is no performance regression on this fix. Best Regards, Cooper -Original Message- From: kernel test robot Sent: Monday, February 8, 2021 8:4

Re: [PATCH] Staging: mt7621-pci: pci-mt7621: fixed a blank line coding style issue

2021-02-16 Thread Sergio Paracuellos
Hi Selvakumar, On Wed, Feb 17, 2021 at 7:53 AM Selvakumar Elangovan wrote: > > Removed an unecessary blank line before closing brace reported by > checkpatch.pl Typo: s/unecessary/unnecessary/g > > Signed-off-by: Selvakumar Elangovan > --- > drivers/staging/mt7621-pci/pci-mt7621.c | 1 - > 1

<    4   5   6   7   8   9   10   >