Re: [PATCH v8 21/22] counter: 104-quad-8: Replace mutex with spinlock

2021-02-16 Thread Jonathan Cameron
On Tue, 16 Feb 2021 11:16:03 +0900 William Breathitt Gray wrote: > On Sun, Feb 14, 2021 at 06:19:46PM +, Jonathan Cameron wrote: > > On Fri, 12 Feb 2021 21:13:45 +0900 > > William Breathitt Gray wrote: > > > > > This patch replaces the mutex I/O lock with a spinlock. This is in > > > prep

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Anna Schumaker
On Tue, Feb 16, 2021 at 2:22 PM Amir Goldstein wrote: > > On Tue, Feb 16, 2021 at 8:54 PM Luis Henriques wrote: > > > > Amir Goldstein writes: > > > > > On Tue, Feb 16, 2021 at 6:41 PM Luis Henriques wrote: > > >> > > >> Amir Goldstein writes: > > >> > > >> >> Ugh. And I guess overlayfs may h

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Steve French
On Tue, Feb 16, 2021 at 1:29 PM Anna Schumaker wrote: > > On Tue, Feb 16, 2021 at 2:22 PM Amir Goldstein wrote: > > > > On Tue, Feb 16, 2021 at 8:54 PM Luis Henriques wrote: > > > > > > Amir Goldstein writes: > > > > > > > On Tue, Feb 16, 2021 at 6:41 PM Luis Henriques > > > > wrote: > > > >>

Re: [PATCH] drivers: habanalabs: remove unused dentry pointer for debugfs files

2021-02-16 Thread Oded Gabbay
On Tue, Feb 16, 2021 at 5:08 PM Greg Kroah-Hartman wrote: > > The dentry for the created debugfs file was being saved, but never used > anywhere. As the pointer isn't needed for anything, and the debugfs > files are being properly removed by removing the parent directory, > remove the saved point

[PATCH] bpf: fix a warning message in mark_ptr_not_null_reg()

2021-02-16 Thread Dan Carpenter
The WARN_ON() argument is a condition, and it generates a stack trace but it doesn't print the warning. Fixes: 4ddb74165ae5 ("bpf: Extract nullable reg type conversion into a helper function") Signed-off-by: Dan Carpenter --- kernel/bpf/verifier.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] iio: adis16400: Fix an error code in adis16400_initial_setup()

2021-02-16 Thread Dan Carpenter
This is to silence a new Smatch warning: drivers/iio/imu/adis16400.c:492 adis16400_initial_setup() warn: sscanf doesn't return error codes If the condition "if (st->variant->flags & ADIS16400_HAS_SLOW_MODE) {" is false then we return 1 instead of returning 0 and probe will fail. Fixes: 7

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Amir Goldstein
On Tue, Feb 16, 2021 at 9:31 PM Steve French wrote: > > On Tue, Feb 16, 2021 at 1:29 PM Anna Schumaker > wrote: > > > > On Tue, Feb 16, 2021 at 2:22 PM Amir Goldstein wrote: > > > > > > On Tue, Feb 16, 2021 at 8:54 PM Luis Henriques wrote: > > > > > > > > Amir Goldstein writes: > > > > > > > >

[PATCH v5] TPM fixes

2021-02-16 Thread Lino Sanfilippo
This patch fixes a reference count issue in the TPM core code. Changes in v5 - move function tpm_add_tpm2_char_device() to tpm2-space.c and rename it to tpm2_add_device() as requested by Jarko - put "cc" tag before all other tags - ensure that the error path in tpm2_add_device() always calls the

[PATCH v5] The following sequence of operations results in a refcount warning:

2021-02-16 Thread Lino Sanfilippo
From: Lino Sanfilippo 1. Open device /dev/tpmrm. 2. Remove module tpm_tis_spi. 3. Write a TPM command to the file descriptor opened at step 1. [ cut here ] WARNING: CPU: 3 PID: 1161 at lib/refcount.c:25 kobject_get+0xa0/0xa4 refcount_t: addition on 0; use-after-free. Modu

Re: [PATCH v3 5/5] tools: iio: add example for high-speed buffer support

2021-02-16 Thread Jonathan Cameron
On Mon, 15 Feb 2021 16:32:34 +0200 Alexandru Ardelean wrote: > Following a recent update to the IIO buffer infrastructure, this change > adds a basic example on how to access an IIO buffer via the new mmap() > interface. > > The ioctl() for the high-speed mode needs to be enabled right from the

Re: [External] Re: [PATCH v15 4/8] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page

2021-02-16 Thread Mike Kravetz
On 2/15/21 8:27 AM, Michal Hocko wrote: > On Mon 15-02-21 23:36:49, Muchun Song wrote: > [...] >>> There shouldn't be any real reason why the memory allocation for >>> vmemmaps, or handling vmemmap in general, has to be done from within the >>> hugetlb lock and therefore requiring a non-sleeping se

Re: [PATCH v5] The following sequence of operations results in a refcount warning:

2021-02-16 Thread Lino Sanfilippo
Please ignore this patch, I somehow managed to cut off the head line. I will resend it shorty. Regards, Lino

epoll: different edge-triggered behavior bewteen pipe and socketpair

2021-02-16 Thread Francesco Ruggeri
pipe() and socketpair() have different behavior wrt edge-triggered read epoll, in that no event is generated when data is written into a non-empty pipe, but an event is generated if socketpair() is used instead. This simple modification of the epoll2 testlet from tools/testing/selftests/filesystem

[PATCH] habanalabs: mark hl_eq_inc_ptr() as static

2021-02-16 Thread Oded Gabbay
hl_eq_inc_ptr() is not called from anywhere outside irq.c so mark it as static Reported-by: kernel test robot Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/common/irq.c b/drivers/m

RE: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-16 Thread Min Li
> > Yes, that line. > > The documentation should tell you how to do that, as per my patch bot: > > - This looks like a new version of a previously submitted patch, but you > did not list below the --- line any changes from the previous version. > Please read the section entitled "The canonic

Re: [PATCH] x86, sched: Allow NUMA nodes to share an LLC on Intel platforms

2021-02-16 Thread Alison Schofield
On Tue, Feb 16, 2021 at 12:29:02PM +0100, Peter Zijlstra wrote: > On Wed, Feb 10, 2021 at 02:11:34PM -0800, Alison Schofield wrote: > > > This is equivalent to determining if x86_has_numa_in_package. > > Do you think there is an opportunity to set x86_has_numa_in_package > > earlier, and use it he

[PATCH RESEND v5] TPM fixes

2021-02-16 Thread Lino Sanfilippo
This patch fixes a reference count issue in the TPM core code. Changes in v5 - move function tpm_add_tpm2_char_device() to tpm2-space.c and rename it to tpm2_add_device() as requested by Jarko - put "cc" tag before all other tags - ensure that the error path in tpm2_add_device() always calls the

[PATCH RESEND v5] tpm: fix reference counting for struct tpm_chip

2021-02-16 Thread Lino Sanfilippo
From: Lino Sanfilippo The following sequence of operations results in a refcount warning: 1. Open device /dev/tpmrm. 2. Remove module tpm_tis_spi. 3. Write a TPM command to the file descriptor opened at step 1. [ cut here ] WARNING: CPU: 3 PID: 1161 at lib/refcount.c:25

Re: [PATCH mips-next] vmlinux.lds.h: catch more UBSAN symbols into .data

2021-02-16 Thread Thomas Bogendoerfer
On Tue, Feb 16, 2021 at 08:55:25AM +, Alexander Lobakin wrote: > LKP triggered lots of LD orphan warnings [0]: > > mipsel-linux-ld: warning: orphan section `.data.$Lubsan_data299' from > `init/do_mounts_rd.o' being placed in section `.data.$Lubsan_data299' > mipsel-linux-ld: warning: orphan se

[PATCH 0/3] Implement nvmem support for mtd

2021-02-16 Thread Ansuel Smith
The mtd support for the nvmem api has been stalled from 2018 with a patch half pushed hoping that a scheme is found for the mtd name later. This patchset try to address this. The solution is simple. New partitions scheme should always have the partitions {} structure and declare subnodes as parti

[PATCH 2/3] mtd: core: add nvmem-partitions compatible to parse mtd as nvmem cells

2021-02-16 Thread Ansuel Smith
Partitions that contains the nvmem-partitions compatible will register their direct subonodes as nvmem cells and the node will be treated as a nvmem provider. Signed-off-by: Ansuel Smith --- drivers/mtd/mtdcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtd

[PATCH 1/3] mtd: partitions: ofpart: skip subnodes parse with compatible

2021-02-16 Thread Ansuel Smith
If a partitions structure is not used, parse direct subnodes as fixed-partitions only if a compatible is not found or is of type fixed-partition. A parser can be used directly on the subnode and subnodes should not be parsed as fixed-partitions by default. Signed-off-by: Ansuel Smith --- drivers

[PATCH v2] x86,sched: Update the Intel SNC CPU list that allows shared LLCs

2021-02-16 Thread Alison Schofield
Commit 1340ccfa9a9a ("x86,sched: Allow topologies where NUMA nodes share an LLC") added a vendor and model specific check to never call topology_sane() for systems where NUMA nodes share an LLC. Intel's Ice Lake and Sapphire Rapids CPUs exhibit this same topology. They enumerate an LLC that is sha

[PATCH 3/3] dt-bindings: mtd: Document use of nvmem-partitions compatible

2021-02-16 Thread Ansuel Smith
Document nvmem-partitions compatible used to treat mtd partitions as a nvmem provider. Signed-off-by: Ansuel Smith --- .../mtd/partitions/nvmem-partitions.yaml | 105 ++ 1 file changed, 105 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/partitions/n

Re: [PATCH v3 0/5] iio: core: Add mmap interface infrastructure

2021-02-16 Thread Jonathan Cameron
On Mon, 15 Feb 2021 16:32:29 +0200 Alexandru Ardelean wrote: Hi Alex, I'm a little nervous about adding the userspace interface used in this series, but it seems reasonable and as you say below, is close to what Analog have been using for years. So I've applied it to the togreg branch of iio.g

Re: [PATCH] psi: Optimize task switch inside shared cgroups

2021-02-16 Thread Johannes Weiner
Hello Chengming, This patch looks useful to me. A couple of comments below: On Tue, Feb 09, 2021 at 03:14:13PM +0800, Chengming Zhou wrote: > The commit 36b238d57172 ("psi: Optimize switching tasks inside shared > cgroups") only update cgroups whose state actually changes during a > task switch o

Re: [reiser4 SFRN 5.1.3] kernel [5.10.x] read not supported for file /test-exec \(pid: 10094 comm: debootstrap\)

2021-02-16 Thread Edward Shishkin
On 02/16/2021 04:56 PM, Jose R Rodriguez wrote: On Mon, 2021-02-08 at 17:03 +0100, Edward Shishkin wrote: On 02/08/2021 01:54 PM, Metztli Information Technology wrote: On Wed, Dec 23, 2020 at 3:40 PM Edward Shishkin < edward.shish...@gmail.com> wrote: On 12/23/2020 05:01 PM, Metztli Inform

Re: [PATCH v5 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-02-16 Thread Jonathan Cameron
On Tue, 16 Feb 2021 10:20:59 + Cristian Marussi wrote: > Hi Jyoti, > > On Mon, Feb 15, 2021 at 04:14:57PM -0800, Jyoti Bhayana wrote: > > Hi Jonathan/Cristian, > > > > I have uploaded v6 of the IIO SCMI patch. Not sure if you got a chance to > > review that version and if any further change

[PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-16 Thread Jonathan Marek
Ignore nvmem_cell_get() EOPNOTSUPP error in the same way as a ENOENT error, to fix the case where the kernel was compiled without CONFIG_NVMEM. Fixes: fe7952c629da ("drm/msm: Add speed-bin support to a618 gpu") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +++--- 1

[PATCH] opp: fix dev_pm_opp_set_rate for different frequency at the same opp level

2021-02-16 Thread Jonathan Marek
There is not "nothing to do" when the opp is the same. The frequency can be different from opp->rate. Fixes: 81c4d8a3c414 ("opp: Keep track of currently programmed OPP") Signed-off-by: Jonathan Marek --- drivers/opp/core.c | 7 +-- drivers/opp/opp.h | 1 + 2 files changed, 6 insertions(+),

Re: [PATCH 0/5] docs: iio: misc fixes and improvements

2021-02-16 Thread Jonathan Cameron
On Mon, 15 Feb 2021 15:35:06 +0100 Luca Ceresoli wrote: > Here are a few minor fixes and improvements to the IIO documentation. > > Luca Ceresoli (5): > docs: iio: fix example formatting > docs: iio: fix directory naming > docs: iio: document the 'index' attribute too > docs: iio: fix bu

Re: [PATCH 4/5] docs: iio: fix bullet list formatting

2021-02-16 Thread Jonathan Cameron
On Mon, 15 Feb 2021 15:35:10 +0100 Luca Ceresoli wrote: > This 2nd-level bullet list is not properly ReST-formatted and thus it gets > rendered as a unique paragraph quite unreadable. Fix by adding spaces as > needed. > > While there also swap "shift" and "repeat" so they are in the correct > o

[RESEND PATCH] drm/tilcdc: fix raster control register setting

2021-02-16 Thread Dario Binacchi
The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 inser

[PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-16 Thread Xie He
When sending packets, we will first hand over the (L3) packets to the LAPB module. The LAPB module will then hand over the corresponding LAPB (L2) frames back to us for us to transmit. The LAPB module can also emit LAPB (L2) frames at any time, even without an (L3) packet currently being sent on t

Re: [PATCH v3] auxdisplay: Remove in_interrupt() usage.

2021-02-16 Thread Miguel Ojeda
On Tue, Feb 16, 2021 at 7:26 PM Sebastian Andrzej Siewior wrote: > > That should be part of the commit message. You can always rewind to the > commit message that introduce something and check if the commit message > made sense or ignored a detail which made it wrong (or so). No, it shouldn't. Co

Re: [PATCH] of: property: fw_devlink: Ignore interrupts property for some configs

2021-02-16 Thread Saravana Kannan
On Tue, Feb 16, 2021 at 12:20 PM Enrico Weigelt, metux IT consult wrote: > > On 15.02.21 23:42, Saravana Kannan wrote: > > Hi, > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > index 79b68519fe30..5036a362f52e 100644 > > --- a/drivers/of/property.c > > +++ b/drivers/of/property.

Re: [PATCH] of: property: fw_devlink: Ignore interrupts property for some configs

2021-02-16 Thread Enrico Weigelt, metux IT consult
On 15.02.21 23:42, Saravana Kannan wrote: Hi, diff --git a/drivers/of/property.c b/drivers/of/property.c index 79b68519fe30..5036a362f52e 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1300,6 +1300,9 @@ static struct device_node *parse_interrupts(struct device_node *np, {

[RESEND PATCH] drm/tilcdc: fix raster control register setting

2021-02-16 Thread Dario Binacchi
The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 inser

Re: [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full

2021-02-16 Thread Bhaumik Bhatt
On 2021-02-16 10:48 AM, Jeffrey Hugo wrote: From: Fan Wu Currently ENOMEM is returned when MHI ring is full. This error code is very misleading. Change to EBUSY instead. Signed-off-by: Fan Wu Signed-off-by: Jeffrey Hugo --- drivers/bus/mhi/core/main.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v2 1/2] x86/stackprotector/32: Make the canary into a regular percpu variable

2021-02-16 Thread Sedat Dilek
On Tue, Feb 16, 2021 at 5:21 PM Sean Christopherson wrote: > > On Sat, Feb 13, 2021, Andy Lutomirski wrote: > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > > index f923e14e87df..ec39073b4897 100644 > > --- a/arch/x86/kvm/svm/svm.c > > +++ b/arch/x86/kvm/svm/svm.c > > @@ -1467,12

Re: [PATCH v2 1/2] x86/stackprotector/32: Make the canary into a regular percpu variable

2021-02-16 Thread Sedat Dilek
On Tue, Feb 16, 2021 at 7:45 PM Nick Desaulniers wrote: > > On Sat, Feb 13, 2021 at 11:19 AM Andy Lutomirski wrote: > > > > On 32-bit kernels, the stackprotector canary is quite nasty -- it is > > stored at %gs:(20), which is nasty because 32-bit kernels use %fs for > > percpu storage. It's even

Re: [PATCH V3 08/14] coresight: core: Add support for dedicated percpu sinks

2021-02-16 Thread Mathieu Poirier
On Mon, Feb 15, 2021 at 05:58:37PM +, Mike Leach wrote: > Hi Mathieu, > > On Mon, 15 Feb 2021 at 16:56, Mathieu Poirier > wrote: > > > > On Mon, Feb 15, 2021 at 04:27:26PM +, Mike Leach wrote: > > > HI Anshuman > > > > > > On Wed, 27 Jan 2021 at 08:55, Anshuman Khandual > > > wrote: > >

Re: [PATCH v4 0/8] Make fw_devlink=on more forgiving

2021-02-16 Thread Geert Uytterhoeven
Hi Saravana, On Tue, Feb 16, 2021 at 7:49 PM Saravana Kannan wrote: > On Tue, Feb 16, 2021 at 12:05 AM Geert Uytterhoeven > wrote: > > On Mon, Feb 15, 2021 at 10:27 PM Saravana Kannan > > wrote: > > > On Mon, Feb 15, 2021 at 4:38 AM Geert Uytterhoeven > > > wrote: > > > > On Fri, Feb 12, 202

Re: [PATCH] RTIC: selinux: ARM64: Move selinux_state to a separate page

2021-02-16 Thread Miguel Ojeda
On Tue, Feb 16, 2021 at 11:22 AM Preeti Nagar wrote: > > The changes introduce a new security feature, RunTime Integrity Check > (RTIC), designed to protect Linux Kernel at runtime. The motivation > behind these changes is: > 1. The system protection offered by Security Enhancements(SE) for > Andr

Re: [PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when PM domain is added

2021-02-16 Thread Geert Uytterhoeven
Hi Saravana, On Tue, Feb 16, 2021 at 7:26 PM Saravana Kannan wrote: > On Tue, Feb 16, 2021 at 4:40 AM Geert Uytterhoeven > wrote: > > Currently, there are two drivers binding to the R-Mobile System > > Controller (SYSC): > > - The rmobile-sysc driver registers PM domains from a core_initcall()

[GIT PULL] clang-lto for v5.12-rc1

2021-02-16 Thread Kees Cook
Hi Linus, Please pull this Clang Link Time Optimization series for v5.12-rc1. This has been in linux-next for the entire last development cycle, and is built on the work done preparing[0] for LTO by arm64 folks, tracing folks, etc. This series includes the core changes as well as the remaining pie

[PATCH 1/2] perf report: Remove redundant libbfd checks

2021-02-16 Thread Nicholas Fraser
This removes the redundant checks bfd_check_format() and bfd_target_elf_flavour. They were previously checking different files. --- tools/perf/util/symbol.c | 9 - 1 file changed, 9 deletions(-) diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 492c873713cc..08f6f57c8

[PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id

2021-02-16 Thread Nicholas Fraser
tests/shell/buildid.sh added an ELF executable with an MD5 build-id to the perf debug cache but did not check whether the object was printed by a subsequent call to "perf buildid-cache -l". It was being omitted from the list. A previous commit fixed the bug that left it out of the list. This adds

Re: [PATCH v5 05/14] vfio/mdev: idxd: add basic mdev registration and helper functions

2021-02-16 Thread Dan Williams
On Tue, Feb 16, 2021 at 11:05 AM Dave Jiang wrote: > > > On 2/10/2021 4:59 PM, Jason Gunthorpe wrote: > > On Fri, Feb 05, 2021 at 01:53:24PM -0700, Dave Jiang wrote: > > > >> +static int check_vma(struct idxd_wq *wq, struct vm_area_struct *vma) > >> { > >> -/* FIXME: Fill in later */ > >> +

Re: riscv+KASAN does not boot

2021-02-16 Thread Alex Ghiti
Hi Dmitry, Le 2/16/21 à 6:25 AM, Dmitry Vyukov a écrit : On Tue, Feb 16, 2021 at 12:17 PM Dmitry Vyukov wrote: On Fri, Jan 29, 2021 at 9:11 AM Dmitry Vyukov wrote: I was fixing KASAN support for my sv48 patchset so I took a look at your issue: I built a kernel on top of the branch riscv/fix

Re: [PATCH] drivers: vmw_balloon: remove dentry pointer for debugfs

2021-02-16 Thread Nadav Amit
> On Feb 16, 2021, at 7:12 AM, Greg Kroah-Hartman > wrote: > > There is no need to keep the dentry pointer around for the created > debugfs file, as it is only needed when removing it from the system. > When it is to be removed, ask debugfs itself for the pointer, to save on > storage and make t

Re: [PATCH V3 08/14] coresight: core: Add support for dedicated percpu sinks

2021-02-16 Thread Mathieu Poirier
On Tue, Feb 16, 2021 at 04:10:18PM +0530, Anshuman Khandual wrote: > > > On 2/5/21 12:04 AM, Mathieu Poirier wrote: > > On Thu, Jan 28, 2021 at 09:16:34AM +, Suzuki K Poulose wrote: > >> On 1/27/21 8:55 AM, Anshuman Khandual wrote: > >>> Add support for dedicated sinks that are bound to indiv

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-16 Thread Arnd Bergmann
On Tue, Feb 16, 2021 at 6:10 PM Min Li wrote: > > > If I come up with a new file and move all the abstraction code there, > > > does that work? > > > > I think so, but it's more important to figure out a good user space > > interface > > first. The ioctl interfaces should be written on a higher-l

possible deadlock in skb_queue_tail (2)

2021-02-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:dcc0b490 Merge tag 'powerpc-5.11-8' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11a2fe9cd0 kernel config: https://syzkaller.appspot.com/x/.config?x=8cb23303ddb9411f das

RE: [PATCH net-next v3 2/5] lan743x: sync only the received area of an rx ring buffer

2021-02-16 Thread Bryan.Whitehead
> From: Sven Van Asbroeck > > On cpu architectures w/o dma cache snooping, dma_unmap() is a is a very > expensive operation, because its resulting sync needs to invalidate cpu > caches. > > Increase efficiency/performance by syncing only those sections of the > lan743x's rx ring buffers that are

[PATCH] mhi_bus: core: Wait for ready state after reset

2021-02-16 Thread Jeffrey Hugo
After the device has signaled the end of reset by clearing the reset bit, it will automatically reinit MHI and the internal device structures. Once That is done, the device will signal it has entered the ready state. Signaling the ready state involves sending an interrupt (MSI) to the host which

Re: [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full

2021-02-16 Thread Jeffrey Hugo
On 2/16/2021 1:22 PM, Bhaumik Bhatt wrote: On 2021-02-16 10:48 AM, Jeffrey Hugo wrote: From: Fan Wu Currently ENOMEM is returned when MHI ring is full. This error code is very misleading. Change to EBUSY instead. Signed-off-by: Fan Wu Signed-off-by: Jeffrey Hugo ---  drivers/bus/mhi/core/ma

Re: [PATCH] cxl/mem: Fix an error code in cxl_mem_mbox_get()

2021-02-16 Thread Dan Williams
On Tue, Feb 16, 2021 at 11:17 AM Dan Carpenter wrote: > > Smatch complains that sometimes when we return success we are holding > the mutex and sometimes we have released the mutex. It turns out that > the bug is a missing error code if the mbox is not ready. It should > return -EBUSY instead of

Re: code style: Re: [PATCH v4] printk: Userspace format enumeration support

2021-02-16 Thread Johannes Weiner
On Tue, Feb 16, 2021 at 05:27:08PM +, Chris Down wrote: > Petr Mladek writes: > > I wonder if we could find a better name for the configure switch. > > I have troubles to imagine what printk enumeration might mean. > > Well, it might be because I am not a native speaker. > > > > Anyway, the wo

[PATCH v2] mhi_bus: core: Return EAGAIN if MHI ring is full

2021-02-16 Thread Jeffrey Hugo
From: Fan Wu Currently ENOMEM is returned when MHI ring is full. This error code is very misleading. Change to EAGAIN instead. Signed-off-by: Fan Wu Signed-off-by: Jeffrey Hugo --- v2: Change from EBUSY to EAGAIN drivers/bus/mhi/core/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id

2021-02-16 Thread Nicholas Fraser
Sorry, I just realized I forgot to run checkpatch.pl on these; they're missing the --signoff. I'll re-send. On 2021-02-16 3:38 p.m., Nicholas Fraser wrote: > tests/shell/buildid.sh added an ELF executable with an MD5 build-id to > the perf debug cache but did not check whether the object was print

Re: code style: Re: [PATCH v4] printk: Userspace format enumeration support

2021-02-16 Thread Chris Down
Johannes Weiner writes: On Tue, Feb 16, 2021 at 05:27:08PM +, Chris Down wrote: Petr Mladek writes: > I wonder if we could find a better name for the configure switch. > I have troubles to imagine what printk enumeration might mean. > Well, it might be because I am not a native speaker. > >

[PATCH] habanalabs: set max asid to 2

2021-02-16 Thread Oded Gabbay
From: farah kassabri currently we support only 2 asids in all asics. asid 0 for driver, and asic 1 for user. no need to setup 1024 asids configurations at init phase. Signed-off-by: farah kassabri Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/include/gaudi/g

[PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id

2021-02-16 Thread Nicholas Fraser
tests/shell/buildid.sh added an ELF executable with an MD5 build-id to the perf debug cache but did not check whether the object was printed by a subsequent call to "perf buildid-cache -l". It was being omitted from the list. A previous commit fixed the bug that left it out of the list. This adds

[PATCH 1/2] perf report: Remove redundant libbfd checks

2021-02-16 Thread Nicholas Fraser
This removes the redundant checks bfd_check_format() and bfd_target_elf_flavour. They were previously checking different files. Signed-off-by: Nicholas Fraser --- tools/perf/util/symbol.c | 9 - 1 file changed, 9 deletions(-) diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbo

Re: [PATCH] bpf: fix a warning message in mark_ptr_not_null_reg()

2021-02-16 Thread KP Singh
On Tue, Feb 16, 2021 at 8:37 PM Dan Carpenter wrote: > > The WARN_ON() argument is a condition, and it generates a stack trace > but it doesn't print the warning. > > Fixes: 4ddb74165ae5 ("bpf: Extract nullable reg type conversion into a helper > function") > Signed-off-by: Dan Carpenter > --- >

Re: [PATCH 2/3] mtd: core: add nvmem-partitions compatible to parse mtd as nvmem cells

2021-02-16 Thread kernel test robot
Hi Ansuel, Thank you for the patch! Yet something to improve: [auto build test ERROR on mtd/mtd/next] [also build test ERROR on mtd/mtd/fixes robh/for-next v5.11 next-20210216] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v3 2/2] arm64: dts: qcom: sm8250: fix display nodes

2021-02-16 Thread Dmitry Baryshkov
Except for the compatible value changes: Reviewed-by: Dmitry Baryshkov May I suggest to split the compatibility name changes into a separate series from this patch (without it the patch stands a chance of being accepted into the stable tree, if I'm not mistaken). On Mon, 15 Feb 2021 at 19:27, J

Re: [PATCH v2 1/2] drm/msm: add compatibles for sm8150/sm8250 display

2021-02-16 Thread Dmitry Baryshkov
On Tue, 16 Feb 2021 at 21:06, Jonathan Marek wrote: > > On 2/16/21 11:54 AM, Dmitry Baryshkov wrote: > > On Mon, 15 Feb 2021 at 19:25, Jonathan Marek wrote: > >> > >> The driver already has support for sm8150/sm8250, but the compatibles were > >> never added. > >> > >> Also inverse the non-mdp4 c

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Steve French
On Tue, Feb 16, 2021 at 1:40 PM Amir Goldstein wrote: > > On Tue, Feb 16, 2021 at 9:31 PM Steve French wrote: > > > > On Tue, Feb 16, 2021 at 1:29 PM Anna Schumaker > > wrote: > > > > > > On Tue, Feb 16, 2021 at 2:22 PM Amir Goldstein wrote: > > > > > > > > On Tue, Feb 16, 2021 at 8:54 PM Luis

Re: linux-next: manual merge of the net-next tree with the arm-soc tree

2021-02-16 Thread Stephen Rothwell
ot;okay"; > > + clocks = <&wdt_clk>; > > +}; > > + > > +&gpio { > > + status = "okay"; > > ++};` > > This ` causes the following build error on the next-20210216. > > DTC arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.d

Re: [PATCH 0/2] media: qcom: camss: V4L2_CID_PIXEL_RATE/LINK_FREQ fixes

2021-02-16 Thread Vladimir Lypak
Hello, Andrey! Thank you for including my patch, i'm glad you did it. This patchset works fine for me.

Re: [PATCH] use x86 cpu park to speedup smp_init in kexec situation

2021-02-16 Thread David Woodhouse
On Tue, 2021-02-16 at 15:10 +, David Woodhouse wrote: > Actually it breaks before that, in rcu_cpu_starting(). A spinlock > around that, an atomic_t to let the APs do their TSC sync one at a time > (both in the above tree now), and I have a 75% saving on CPU bringup > time for my 28-thread Hasw

Re: [PATCH 1/4] add generic builtin command line

2021-02-16 Thread Daniel Gimpelevich
On Tue, 2021-02-16 at 18:42 +0100, Christophe Leroy wrote: > I'd suggest also to find the good arguments to convince us that this > series has a real added value, not just "cisco use it in its kernels > so it is good". Well, IIRC, this series was endorsed by the device tree maintainers as the

Re: [PATCH] ionic: Remove unused function pointer typedef ionic_reset_cb

2021-02-16 Thread Shannon Nelson
On 2/15/21 8:05 PM, Chen Lin wrote: From: Chen Lin Remove the 'ionic_reset_cb' typedef as it is not used. Signed-off-by: Chen Lin --- drivers/net/ethernet/pensando/ionic/ionic_lif.h |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.h b/d

Re: linux-next: manual merge of the net-next tree with the net tree

2021-02-16 Thread Saeed Mahameed
On Mon, 2021-02-15 at 11:52 +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got conflicts in: > >   drivers/net/ethernet/mellanox/mlx5/core/en_main.c >   drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > > between commit: > >   e4484d9df500 ("net/mlx5e

[PATCH v2 0/3] Implement nvmem support for mtd

2021-02-16 Thread Ansuel Smith
The mtd support for the nvmem api has been stalled from 2018 with a patch half pushed hoping that a scheme is found for the mtd name later. This patchset try to address this. The solution is simple. New partitions scheme should always have the partitions {} structure and declare subnodes as parti

[PATCH v2 1/3] mtd: partitions: ofpart: skip subnodes parse with compatible

2021-02-16 Thread Ansuel Smith
If a partitions structure is not used, parse direct subnodes as fixed-partitions only if a compatible is not found or is of type fixed-partition. A parser can be used directly on the subnode and subnodes should not be parsed as fixed-partitions by default. Signed-off-by: Ansuel Smith --- drivers

[PATCH v2 3/3] dt-bindings: mtd: Document use of nvmem-partitions compatible

2021-02-16 Thread Ansuel Smith
Document nvmem-partitions compatible used to treat mtd partitions as a nvmem provider. Signed-off-by: Ansuel Smith --- .../mtd/partitions/nvmem-partitions.yaml | 105 ++ 1 file changed, 105 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/partitions/n

[PATCH v2 2/3] mtd: core: add nvmem-partitions compatible to parse mtd as nvmem cells

2021-02-16 Thread Ansuel Smith
Partitions that contains the nvmem-partitions compatible will register their direct subonodes as nvmem cells and the node will be treated as a nvmem provider. Signed-off-by: Ansuel Smith --- drivers/mtd/mtdcore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/m

Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily

2021-02-16 Thread Minchan Kim
On Tue, Feb 16, 2021 at 06:22:42PM +, Matthew Wilcox wrote: > On Tue, Feb 16, 2021 at 09:03:47AM -0800, Minchan Kim wrote: > > LRU pagevec holds refcount of pages until the pagevec are drained. > > It could prevent migration since the refcount of the page is greater > > than the expection in mi

Re: [PATCH net-next v3 2/5] lan743x: sync only the received area of an rx ring buffer

2021-02-16 Thread Sven Van Asbroeck
Hi Bryan, On Tue, Feb 16, 2021 at 3:50 PM wrote: > > Looks Good, Thanks Sven > Our testing is in progress, We will let you know our results soon. > > Reviewed-by: Bryan Whitehead > Thank you Bryan, I really appreciate your help and expertise.

[PATCH] drm/i915: Enable -Wuninitialized

2021-02-16 Thread Nathan Chancellor
-Wunintialized was disabled in commit c5627461490e ("drm/i915: Disable -Wuninitialized") because there were two warnings that were false positives. The first was due to DECLARE_WAIT_QUEUE_HEAD_ONSTACK, which was fixed in LLVM 9.0.0. The second was in busywait_stop, which was fixed in LLVM 10.0.0 (i

Re: [PATCH v5 05/14] vfio/mdev: idxd: add basic mdev registration and helper functions

2021-02-16 Thread Jason Gunthorpe
On Tue, Feb 16, 2021 at 12:39:56PM -0800, Dan Williams wrote: > > >> +/* > > >> + * Check and see if the guest wants to map to the limited or > > >> unlimited portal. > > >> + * The driver will allow mapping to unlimited portal only if the > > >> the wq is a > > >> + * dedicated w

[PATCH] Makefile: Remove # characters from compiler string

2021-02-16 Thread Nathan Chancellor
When using AMD's Optimizing C/C++ Compiler (AOCC), the build fails due to a # character in the version string, which is interpreted as a comment: $ make CC=clang defconfig init/main.o include/config/auto.conf.cmd:1374: *** invalid syntax in conditional. Stop. $ sed -n 1374p include/config/auto.co

Re: [PATCH 5.10 098/104] switchdev: mrp: Remove SWITCHDEV_ATTR_ID_MRP_PORT_STAT

2021-02-16 Thread Pavel Machek
Hi! > From: Horatiu Vultur > > commit 059d2a1004981dce19f0127dabc1b4ec927d202a upstream. > > Now that MRP started to use also SWITCHDEV_ATTR_ID_PORT_STP_STATE to > notify HW, then SWITCHDEV_ATTR_ID_MRP_PORT_STAT is not used anywhere > else, therefore we can remove it. Are you sure this is suit

Re: [PATCH v5 05/14] vfio/mdev: idxd: add basic mdev registration and helper functions

2021-02-16 Thread Jason Gunthorpe
On Tue, Feb 16, 2021 at 12:04:55PM -0700, Dave Jiang wrote: > > > + return remap_pfn_range(vma, vma->vm_start, pgoff, req_size, pg_prot); > > Nothing validated req_size - did you copy this from the Intel RDMA > > driver? It had a huge security bug just like this. > Thanks. Will add. Some of the c

Local execution of ipi_sync_rq_state() on sync_runqueues_membarrier_state()

2021-02-16 Thread Nadav Amit
Hello Mathieu, While trying to find some unrelated by, something in sync_runqueues_membarrier_state() caught my eye: static int sync_runqueues_membarrier_state(struct mm_struct *mm) { if (atomic_read(&mm->mm_users) == 1 || num_online_cpus() == 1) { this_cpu_write(runq

[PATCH] mhi_bus: core: Check state before processing power_down

2021-02-16 Thread Jeffrey Hugo
We cannot process a power_down if the power state is DISABLED. There is no valid mhi_ctxt in that case, so attepting to process the power_down will likely result in a null pointer dereference. If the power state is DISABLED, there is nothing to do anyways, so just bail early. Signed-off-by: Jeff

[PATCH] platform/x86: fix typo in Kconfig

2021-02-16 Thread Petr Vaněk
uses by -> used by Signed-off-by: Petr Vaněk --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 91e6176cdfbd..94f2f05bc133 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/p

[PATCH net-next v4 0/8] bridge: mrp: Extend br_mrp_switchdev_*

2021-02-16 Thread Horatiu Vultur
This patch series extends MRP switchdev to allow the SW to have a better understanding if the HW can implement the MRP functionality or it needs to help the HW to run it. There are 3 cases: - when HW can't implement at all the functionality. - when HW can implement a part of the functionality but n

[PATCH net-next v4 2/8] switchdev: mrp: Extend ring_role_mrp and in_role_mrp

2021-02-16 Thread Horatiu Vultur
Add the member sw_backup to the structures switchdev_obj_ring_role_mrp and switchdev_obj_in_role_mrp. In this way the SW can call the driver in 2 ways, once when sw_backup is set to false, meaning that the driver should implement this completely in HW. And if that is not supported the SW will call

[PATCH net-next v4 3/8] bridge: mrp: Add 'enum br_mrp_hw_support'

2021-02-16 Thread Horatiu Vultur
Add the enum br_mrp_hw_support that is used by the br_mrp_switchdev functions to allow the SW to detect the cases where HW can't implement the functionality or when SW is used as a backup. Signed-off-by: Horatiu Vultur --- net/bridge/br_private_mrp.h | 14 ++ 1 file changed, 14 inser

[PATCH net-next v4 6/8] net: mscc: ocelot: Add support for MRP

2021-02-16 Thread Horatiu Vultur
Add basic support for MRP. The HW will just trap all MRP frames on the ring ports to CPU and allow the SW to process them. In this way it is possible to for this node to behave both as MRM and MRC. Current limitations are: - it doesn't support Interconnect roles. - it supports only a single ring.

[PATCH net-next v4 5/8] bridge: mrp: Update br_mrp to use new return values of br_mrp_switchdev

2021-02-16 Thread Horatiu Vultur
Check the return values of the br_mrp_switchdev function. In case of: - BR_MRP_NONE, return the error to userspace, - BR_MRP_SW, continue with SW implementation, - BR_MRP_HW, continue without SW implementation, Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp.c | 43 ++

[PATCH net-next v4 1/8] switchdev: mrp: Remove CONFIG_BRIDGE_MRP

2021-02-16 Thread Horatiu Vultur
Remove #IS_ENABLED(CONFIG_BRIDGE_MRP) from switchdev.h. This will simplify the code implements MRP callbacks and will be similar with the vlan filtering. Signed-off-by: Horatiu Vultur --- include/net/switchdev.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/net/switchdev

[PATCH net-next v4 8/8] net: dsa: felix: Add support for MRP

2021-02-16 Thread Horatiu Vultur
Implement functions 'port_mrp_add', 'port_mrp_del', 'port_mrp_add_ring_role' and 'port_mrp_del_ring_role' to call the mrp functions from ocelot. Also all MRP frames that arrive to CPU on queue number OCELOT_MRP_CPUQ will be forward by the SW. Signed-off-by: Horatiu Vultur --- drivers/net/dsa/oc

[PATCH net-next v4 7/8] net: dsa: add MRP support

2021-02-16 Thread Horatiu Vultur
Add support for offloading MRP in HW. Currently implement the switchdev calls 'SWITCHDEV_OBJ_ID_MRP', 'SWITCHDEV_OBJ_ID_RING_ROLE_MRP', to allow to create MRP instances and to set the role of these instances. Add DSA_NOTIFIER_MRP_ADD/DEL and DSA_NOTIFIER_MRP_ADD/DEL_RING_ROLE which calls to .port_

[PATCH net-next v4 4/8] bridge: mrp: Extend br_mrp_switchdev to detect better the errors

2021-02-16 Thread Horatiu Vultur
This patch extends the br_mrp_switchdev functions to be able to have a better understanding what cause the issue and if the SW needs to be used as a backup. There are the following cases: - when the code is compiled without CONFIG_NET_SWITCHDEV. In this case return success so the SW can continue

Re: [RFC PATCH] mm, oom: introduce vm.sacrifice_hugepage_on_oom

2021-02-16 Thread David Rientjes
On Tue, 16 Feb 2021, Michal Hocko wrote: > > Hugepages can be preallocated to avoid unpredictable allocation latency. > > If we run into 4k page shortage, the kernel can trigger OOM even though > > there were free hugepages. When OOM is triggered by user address page > > fault handler, we can use

<    2   3   4   5   6   7   8   9   10   >