[PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors()

2021-02-16 Thread Dejin Zheng
Add pcim_alloc_irq_vectors(), a device-managed version of pci_alloc_irq_vectors(). introducing this function can simplify the error handling path in many drivers. Signed-off-by: Dejin Zheng --- v2 -> v3: - No change v1 -> v2: - Modify some commit messages. Documentation/driver-ap

[PATCH] coccinelle: misc: add minmax script

2021-02-16 Thread Denis Efremov
Check for opencoded min(), max() implementations. Signed-off-by: Denis Efremov --- scripts/coccinelle/misc/minmax.cocci | 198 +++ 1 file changed, 198 insertions(+) create mode 100644 scripts/coccinelle/misc/minmax.cocci diff --git a/scripts/coccinelle/misc/minmax.cocci

phy-tegra-usb.c:undefined reference to `clk_get_parent'

2021-02-16 Thread kernel test robot
year, 2 months ago config: mips-randconfig-r015-20210216 (attached as .config) compiler: mipsel-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

[PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function

2021-02-16 Thread Dejin Zheng
Use the new function pcim_alloc_irq_vectors() to allocate IRQ vectors, the pcim_alloc_irq_vectors() function, an explicit device-managed version of pci_alloc_irq_vectors(). If pcim_enable_device() has been called before, then pci_alloc_irq_vectors() is actually a device-managed function. It is used

Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip

2021-02-16 Thread Jarkko Sakkinen
On Tue, Feb 16, 2021 at 08:53:42AM -0400, Jason Gunthorpe wrote: > On Tue, Feb 16, 2021 at 01:31:00AM +0100, Lino Sanfilippo wrote: > > > > +static int tpm_add_tpm2_char_device(struct tpm_chip *chip) BTW, this naming is crap. - 2x tpm - char is useless -> tpm2_add_device > > +{ > > + int r

Re: [PATCH] mtd: spi-nor: gigadevice: Add support for gd25lb256e

2021-02-16 Thread Tudor.Ambarus
Hi, On 2/16/21 5:10 PM, mda...@codeaurora.org wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 2021-02-09 16:41, Md Sadre Alam wrote: >> Add support for gd25lb256e. This device tested on IPQ5018 >> platform with dd from/to the flash for

[PATCH v2] USB: serial: cp210x: add IDs for nLight Air Adapter, Acuity Brands, Inc.

2021-02-16 Thread Karan Singhal
IDs of nLight Air Adapter, Acuity Brands, Inc.: vid: 10c4 pid: 88d8 Signed-off-by: Karan Singhal --- drivers/usb/serial/cp210x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 7bec1e730b20..b82bb130710d 100644 --- a/drivers/usb

[PATCH v1 00/12] Driver of Intel(R) Gaussian & Neural Accelerator

2021-02-16 Thread Maciej Kwapulinski
Dear kernel maintainers, This submission is a kernel driver to support Intel(R) Gaussian & Neural Accelerator (Intel(R) GNA). Intel(R) GNA is a PCI-based neural co-processor available on multiple Intel platforms. AI developers and users can offload continuous inference workloads to an Intel(R)

[PATCH v1 01/12] gna: add driver module

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator with basic support like module loading and unloading. The full function of the driver will be added by further changes. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhan

[PATCH v1 12/12] gna: add a char device

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski The new char device is the node for applications in user space to interact with the driver. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej

Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip

2021-02-16 Thread Jarkko Sakkinen
On Tue, Feb 16, 2021 at 06:04:42PM +0200, Jarkko Sakkinen wrote: > On Tue, Feb 16, 2021 at 08:53:42AM -0400, Jason Gunthorpe wrote: > > On Tue, Feb 16, 2021 at 01:31:00AM +0100, Lino Sanfilippo wrote: > > > > > > +static int tpm_add_tpm2_char_device(struct tpm_chip *chip) > > BTW, this naming is

[PATCH v1 02/12] gna: add component of hardware operation

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski Add definitions and utilities to interact with the hardware device. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- driver

[PATCH v1 03/12] gna: read hardware info in the driver

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski Get the hardware information from register MMIO_IBUFFS Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/gna_device.c | 6 ++ 1 file changed

[PATCH v1 04/12] gna: add memory handling

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski Patch adds memory handling - mapping, DMA, pinning. The GNA driver maps and unmaps the physical pages for 64-byte aligned buffer allocated by user space program. The pages of mapped memory are being locked only during actual computation. Patch adds configuration of the DMA

[PATCH v1 05/12] gna: initialize mmu

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski Setup mmu in the driver with a new memory component. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/gna_device.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/misc/gna/gna_devi

Re: [PATCH v2 3/4] i2c: designware: Use the correct name of device-managed function

2021-02-16 Thread Dejin Zheng
On Tue, Feb 16, 2021 at 04:39:09PM +0200, Andy Shevchenko wrote: > On Tue, Feb 16, 2021 at 10:18:09PM +0800, Dejin Zheng wrote: > > Use the new function pcim_alloc_irq_vectors() to allocate IRQ vectors, > > the pcim_alloc_irq_vectors() function, an explicit device-managed version > > of pci_alloc_i

Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip

2021-02-16 Thread Jarkko Sakkinen
On Tue, Feb 16, 2021 at 06:09:50PM +0200, Jarkko Sakkinen wrote: > On Tue, Feb 16, 2021 at 06:04:42PM +0200, Jarkko Sakkinen wrote: > > On Tue, Feb 16, 2021 at 08:53:42AM -0400, Jason Gunthorpe wrote: > > > On Tue, Feb 16, 2021 at 01:31:00AM +0100, Lino Sanfilippo wrote: > > > > > > > > +static i

[PATCH v1 06/12] gna: add hardware ids

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski Add PCI ids of Intel(R) Gaussian & Neural Accelerator on supported platforms. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/gna_device.c | 7

[PATCH v1 07/12] gna: add request component

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski The scoring work submitted to the GNA driver is implemented as a list of requests that will be processed by the hardware. Signed-off-by: Tomasz Jankowski Co-developed-by: Anisha Dattatraya Kulkarni Signed-off-by: Anisha Dattatraya Kulkarni Tested-by: Savo Novakovic Co

[PATCH v1 08/12] gna: implement scoring

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski Add a new component for scoring logic such as configuring and kicking off the hardware. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwap

Re: KASAN: null-ptr-deref Read in tcf_idrinfo_destroy

2021-02-16 Thread Vlad Buslov
On Tue 16 Feb 2021 at 01:22, Cong Wang wrote: > On Wed, Feb 10, 2021 at 9:53 PM syzbot > wrote: >> >> syzbot has found a reproducer for the following issue on: >> >> HEAD commit:291009f6 Merge tag 'pm-5.11-rc8' of git://git.kernel.org/p.. >> git tree: upstream >> console output: https:/

[PATCH v1 09/12] gna: add a work queue to process scoring requests

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski The new workqueue is responsible to process the list of requests in a FIFO manner. It waits for the hardware to complete on every request until it is woken up by an interrupt that will be addressed in following changes. Signed-off-by: Tomasz Jankowski Co-developed-by: Ani

[PATCH v1 10/12] gna: add interrupt handler

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski An interrupt is generated by the hardware when a scoring job is done. The interrupt handler wakes up the work queue to resume the processing on the current request. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: J

[PATCH v1 11/12] gna: add ioctl handler

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski Add ioctl handler into GNA driver. The ioctl interface provides the ability to do the following: - Map and unmap memory buffers for GNA computation requests. - Retrieve capabilities of the underlying GNA IP. - Submit GNA computation requests. - Request notification of s

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-16 Thread Rob Clark
On Tue, Feb 16, 2021 at 7:21 AM wrote: > > On 2021-02-12 23:19, Rob Clark wrote: > > On Thu, Feb 11, 2021 at 7:31 AM wrote: > >> > >> On 2021-02-11 01:56, Rob Clark wrote: > >> > On Wed, Feb 10, 2021 at 3:41 AM wrote: > >> >> > >> >> On 2021-02-01 00:46, Rob Clark wrote: > >> >> > On Fri, Dec 18

WARNING in iov_iter_revert (2)

2021-02-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:dcc0b490 Merge tag 'powerpc-5.11-8' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=162f2d02d0 kernel config: https://syzkaller.appspot.com/x/.config?x=1106b4b91e8dfab8 das

[PATCH v2] drm/nouveau/pmu: fix timeout on GP108

2021-02-16 Thread Diego Viola
This code times out on GP108, probably because the BIOS puts it into a bad state. Since we reset the PMU on driver load anyway, we are at no risk from missing a response from it since we are not waiting for one to begin with. Signed-off-by: Diego Viola --- drivers/gpu/drm/nouveau/nvkm/subdev/pm

[PATCH 2/2] vdpa/mlx5: Enable user to add/delete vdpa device

2021-02-16 Thread Eli Cohen
Allow to control vdpa device creation and destruction using the vdpa management tool. Examples: 1. List the management devices $ vdpa mgmtdev show pci/:3b:00.1: supported_classes net 2. Create vdpa instance $ vdpa dev add mgmtdev pci/:3b:00.1 name vdpa0 3. Show vdpa devices $ vdpa dev

Re: [PATCH v2 1/2] x86/stackprotector/32: Make the canary into a regular percpu variable

2021-02-16 Thread Sean Christopherson
On Sat, Feb 13, 2021, Andy Lutomirski wrote: > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index f923e14e87df..ec39073b4897 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -1467,12 +1467,8 @@ static void svm_vcpu_put(struct kvm_vcpu *vcpu) > #ifdef CONF

[PATCH 1/2] vdpa/mlx5: Fix suspend/resume index restoration

2021-02-16 Thread Eli Cohen
When we suspend the VM, the VDPA interface will be reset. When the VM is resumed again, clear_virtqueues() will clear the available and used indices resulting in hardware virqtqueue objects becoming out of sync. We can avoid this function alltogether since qemu will clear them if required, e.g. whe

[PATCH net] net: sched: fix police ext initialization

2021-02-16 Thread Vlad Buslov
When police action is created by cls API tcf_exts_validate() first conditional that calls tcf_action_init_1() directly, the action idr is not updated according to latest changes in action API that require caller to commit newly created action to idr with tcf_idr_insert_many(). This results such act

Re: [PATCH] ntfs: move check for valid resident attribute offset and length

2021-02-16 Thread Rustam Kovhaev
On Tue, Feb 16, 2021 at 02:40:37AM +, Anton Altaparmakov wrote: > Hi Rustam, > > Thank you for the patch but it is not quite correct: > > 1) The first delta: yes that is a good idea to add this check but the error > message is incorrect. It should say "Corrupt standard information attribute

Re: [EXTERNAL] [PATCH][next][V3] tracing/tools: fix a couple of spelling mistakes

2021-02-16 Thread Viktor.Rosendahl
This looks good to me. best regards, Viktor On Tue, 2021-02-16 at 15:30 +, Colin King wrote: > EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments. > EXTERNER Absender - Bitte VORSICHT beim Öffnen von Links und Anhängen. >

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-16 Thread James Bottomley
On Mon, 2021-02-15 at 20:20 +0100, Michal Hocko wrote: [...] > > > What kind of flags are we talking about and why would that be a > > > problem with memfd_create interface? Could you be more specific > > > please? > > > > You mean what were the ioctl flags in the patch series linked > > above?

Re: [PATCH mvebu v2 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz

2021-02-16 Thread nnet
> Therefore I'm thinking if the correct way is instead to use L1 := L0 voltage > value for 1/1.2 GHz mode. This latest 04/10 works fine for me going 600MHz <-> 1.2GHz under with and without load.

[PATCH v3 0/2] mtd: spi-nor: OTP support

2021-02-16 Thread Michael Walle
The first version of this patchset was posted over a year ago and since then, there was not a single comment. I have to admit, this is rather frustrating. I've now stripped down the patchset to only two patches and moved the code into an own module otp.c. If you like, I can also add myself to a rev

[PATCH v3 1/2] mtd: spi-nor: add OTP support

2021-02-16 Thread Michael Walle
SPI flashes sometimes have a special OTP area, which can (and is) used to store immutable properties like board serial number or vendor assigned network hardware addresses. The MTD subsystem already supports accessing such areas and some (non SPI-NOR) flashes already implement support for it. It d

[PATCH v3 2/2] mtd: spi-nor: implement OTP support for Winbond and similar flashes

2021-02-16 Thread Michael Walle
Use the new OTP ops to implement OTP access on Winbond flashes. Most Winbond flashes provides up to four different OTP regions ("Security Registers"). Winbond devices use a special opcode to read and write to the OTP regions, just like the RDSFDP opcode. In fact, it seems that the (undocumented) f

RE: [PATCH v4] tpm: fix reference counting for struct tpm_chip

2021-02-16 Thread David Laight
... > > > + get_device(&chip->dev); > > > + chip->devs.release = tpm_devs_release; > > > + chip->devs.devt = > > > + MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES); > > Isn't this less than 100 chars? Still best kept under 80 if 'reasonable'? Really it is just split in the wrong

Re: [PATCH v5 1/8] smp: Run functions concurrently in smp_call_function_many_cond()

2021-02-16 Thread Peter Zijlstra
On Tue, Feb 09, 2021 at 02:16:46PM -0800, Nadav Amit wrote: > From: Nadav Amit > > Currently, on_each_cpu() and similar functions do not exploit the > potential of concurrency: the function is first executed remotely and > only then it is executed locally. Functions such as TLB flush can take > c

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-16 Thread David Hildenbrand
On 16.02.21 17:25, James Bottomley wrote: On Mon, 2021-02-15 at 20:20 +0100, Michal Hocko wrote: [...] What kind of flags are we talking about and why would that be a problem with memfd_create interface? Could you be more specific please? You mean what were the ioctl flags in the patch seri

Re: [PATCH 1/4] perf buildid-cache: Don't skip 16-byte build-ids

2021-02-16 Thread Nicholas Fraser
No problem, I've added a call to "perf buildid-cache -l" in check() to make sure the added IDs are reported. The MD5 test fails without the previous patch to allow 16-byte build-ids. Do you also want PE files tested by this test script? This would make the script depend on a number of things: - W

[PATCH v5 1/2] dt-bindings: input/touchscreen: add bindings for msg2638

2021-02-16 Thread Vincent Knecht
This adds dts bindings for the mstar msg2638 touchscreen. Signed-off-by: Vincent Knecht --- Changed in v5: nothing Changed in v4: - don't use wildcards in compatible strings (Rob H) - rename from msg26xx to msg2638 - rename example pinctrl-0 to &ts_int_reset_default for consistency Changed in v3:

[PATCH v5 2/2] Input: add MStar MSG2638 touchscreen driver

2021-02-16 Thread Vincent Knecht
Add support for the msg2638 touchscreen IC from MStar. This driver reuses zinitix.c structure, while the checksum and irq handler functions are based on out-of-tree driver for Alcatel Idol 3 (4.7"). Signed-off-by: Vincent Knecht --- Changed in v5: - use gpiod_set_value_cansleep() (Stephan G) - us

Re: [PATCH v5 1/1] mm: refactor initialization of struct page for holes in memory layout

2021-02-16 Thread Vlastimil Babka
On 2/16/21 2:11 PM, Michal Hocko wrote: > On Tue 16-02-21 13:34:56, Vlastimil Babka wrote: >> On 2/16/21 12:01 PM, Mike Rapoport wrote: >> >> >> >> I do understand that. And I am not objecting to the patch. I have to >> >> confess I haven't digested it yet. Any changes to early memory >> >> inti

Re: [PATCH v2] gpio: pca953x: add support for open drain pins on PCAL6524

2021-02-16 Thread Bedel, Alban
On Mon, 2021-02-15 at 14:53 +0200, Andy Shevchenko wrote: > Hint: don't forget to include reviewers from previous version I added you to the CC list for the new patch, did I miss someone else? > On Thu, Feb 11, 2021 at 7:52 PM Alban Bedel > wrote: > > From a quick glance at various datasheets th

[PATCH] sched/pelt: Fix task util_est update filtering

2021-02-16 Thread vincent . donnefort
From: Vincent Donnefort Being called for each dequeue, util_est reduces the number of its updates by filtering out when the EWMA signal is different from the task util_avg by less than 1%. It is a problem for a sudden util_avg ramp-up. Due to the decay from a previous high util_avg, EWMA might no

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Luis Henriques
Amir Goldstein writes: >> Ugh. And I guess overlayfs may have a similar problem. > > Not exactly. > Generally speaking, overlayfs should call vfs_copy_file_range() > with the flags it got from layer above, so if called from nfsd it > will allow cross fs copy and when called from syscall it won't

Re: [PATCH v4 2/9] cxl/mem: Find device capabilities

2021-02-16 Thread Ben Widawsky
On 21-02-16 14:51:48, Jonathan Cameron wrote: > On Mon, 15 Feb 2021 17:45:31 -0800 > Ben Widawsky wrote: > > > Provide enough functionality to utilize the mailbox of a memory device. > > The mailbox is used to interact with the firmware running on the memory > > device. The flow is proven with on

[GIT PULL] MFD for v5.12

2021-02-16 Thread Lee Jones
Good afternoon Linus, The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-next-5.12 for you to fetch changes up to

[PATCH] phy: rockchip-typec: add missing of_node_put

2021-02-16 Thread angkery
From: Junlin Yang Fix OF node leaks by calling of_node_put in for_each_available_child_of_node when the cycle returns. Generated by: scripts/coccinelle/iterators/for_each_child.cocci Signed-off-by: Junlin Yang --- drivers/phy/rockchip/phy-rockchip-typec.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-16 Thread James Bottomley
On Tue, 2021-02-16 at 17:34 +0100, David Hildenbrand wrote: > On 16.02.21 17:25, James Bottomley wrote: > > On Mon, 2021-02-15 at 20:20 +0100, Michal Hocko wrote: > > [...] > > > > >What kind of flags are we talking about and why would that > > > > > be a problem with memfd_create interface? Co

[GIT PULL] Backlight for v5.12

2021-02-16 Thread Lee Jones
Good afternoon Linus, The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git backlight-next-5.12 for you to fetch change

Re: [PATCH v4 9/9] cxl/mem: Add payload dumping for debug

2021-02-16 Thread Dan Williams
On Tue, Feb 16, 2021 at 7:50 AM Jonathan Cameron wrote: > > On Mon, 15 Feb 2021 17:45:38 -0800 > Ben Widawsky wrote: > > > It's often useful in debug scenarios to see what the hardware has dumped > > out. As it stands today, any device error will result in the payload not > > being copied out, so

Re: anonymous enums in kernel doc

2021-02-16 Thread Jonathan Corbet
Andy Shevchenko writes: > Mauro, can you do some test cases in your workflow against anonymous > enum in ernel doc, please? > > They are broken again, please fix the script! > > drivers/pinctrl/intel/pinctrl-intel.c:204: warning: wrong kernel-doc > identifier on line: > * enum - Locking variants

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-16 Thread Michal Hocko
On Tue 16-02-21 08:25:39, James Bottomley wrote: > On Mon, 2021-02-15 at 20:20 +0100, Michal Hocko wrote: > [...] > > > > What kind of flags are we talking about and why would that be a > > > > problem with memfd_create interface? Could you be more specific > > > > please? > > > > > > You mean w

Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip

2021-02-16 Thread Stefan Berger
On 2/15/21 7:31 PM, Lino Sanfilippo wrote: From: Lino Sanfilippo The following sequence of operations results in a refcount warning: 1. Open device /dev/tpmrm 2. Remove module tpm_tis_spi 3. Write a TPM command to the file descriptor opened at step 1. [ cut here ] WARN

Re: output: was: Re: [PATCH v4] printk: Userspace format enumeration support

2021-02-16 Thread Chris Down
Hey Petr, Petr Mladek writes: This produces something like: 3Warning: unable to open an initial console. 3Failed to execute %s (error %d) 6Kernel memory protection disabled. 3Starting init: %s exists but couldn't execute it (error %d) 6Run %s as init process 7initcall %pS returned %d after %lld

Re: [PATCH v2 1/2] drm/msm: add compatibles for sm8150/sm8250 display

2021-02-16 Thread Dmitry Baryshkov
On Mon, 15 Feb 2021 at 19:25, Jonathan Marek wrote: > > The driver already has support for sm8150/sm8250, but the compatibles were > never added. > > Also inverse the non-mdp4 condition in add_display_components() to avoid > having to check every new compatible in the condition. > > Signed-off-by:

Re: [PATCH v1 01/12] gna: add driver module

2021-02-16 Thread Andy Shevchenko
On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski wrote: > > From: Tomasz Jankowski > > Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator > with basic support like module loading and unloading. The full > function of the driver will be added by further changes. ... > +config INTE

WARNING in slave_kobj_release

2021-02-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f40ddce8 Linux 5.11 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15e8b204d0 kernel config: https://syzkaller.appspot.com/x/.config?x=4b919ebed7b4902 dashboard link: https://syzkaller.appspot.com

INFO: task hung in disconnect_work

2021-02-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f40ddce8 Linux 5.11 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1644919cd0 kernel config: https://syzkaller.appspot.com/x/.config?x=51ab7ccac30c dashboard link: https://syzkaller.appspot.co

Re: [PATCH 4/4] mm: memcontrol: fix swap uncharge on cgroup v2

2021-02-16 Thread Johannes Weiner
Hello Muchun, On Sat, Feb 13, 2021 at 01:01:59AM +0800, Muchun Song wrote: > The swap charges the actual number of swap entries on cgroup v2. > If a swap cache page is charged successful, and then we uncharge > the swap counter. It is wrong on cgroup v2. Because the swap > entry is not freed. The

Re: anonymous enums in kernel doc

2021-02-16 Thread Andy Shevchenko
On Tue, Feb 16, 2021 at 6:51 PM Jonathan Corbet wrote: > > > Mauro, can you do some test cases in your workflow against anonymous > > enum in ernel doc, please? > > > > They are broken again, please fix the script! > > > > drivers/pinctrl/intel/pinctrl-intel.c:204: warning: wrong kernel-doc > > id

[RFC 1/2] mm: disable LRU pagevec during the migration temporarily

2021-02-16 Thread Minchan Kim
LRU pagevec holds refcount of pages until the pagevec are drained. It could prevent migration since the refcount of the page is greater than the expection in migration logic. To mitigate the issue, callers of migrate_pages drains LRU pagevec via migrate_prep or lru_add_drain_all before migrate_page

Re: anonymous enums in kernel doc

2021-02-16 Thread Jonathan Corbet
Andy Shevchenko writes: > On Tue, Feb 16, 2021 at 6:51 PM Jonathan Corbet wrote: >> >> > Mauro, can you do some test cases in your workflow against anonymous >> > enum in ernel doc, please? >> > >> > They are broken again, please fix the script! >> > >> > drivers/pinctrl/intel/pinctrl-intel.c:20

[RFC 2/2] mm: fs: Invalidate BH LRU during page migration

2021-02-16 Thread Minchan Kim
Pages containing buffer_heads that are in one of the per-CPU buffer_head LRU caches will be pinned and thus cannot be migrated. This can prevent CMA allocations from succeeding, which are often used on platforms with co-processors (such as a DSP) that can only use physically contiguous memory. It c

Re: [PATCH] driver core: Fix double failed probing with fw_devlink=on

2021-02-16 Thread Saravana Kannan
On Mon, Feb 15, 2021 at 12:59 PM Saravana Kannan wrote: > > On Mon, Feb 15, 2021 at 11:08 AM Geert Uytterhoeven > wrote: > > > > Hi Saravana, > > > > On Mon, Feb 15, 2021 at 7:27 PM Saravana Kannan > > wrote: > > > On Mon, Feb 15, 2021 at 6:59 AM Rafael J. Wysocki > > > wrote: > > > > On Mon,

[PATCH RESEND v3 0/2] Add support for Topwise A721 tablet

2021-02-16 Thread Pascal Roeleven
On request I'm resending the last two patches from the Topwise A721 tablet series from a year ago as they weren't picked up. The other patches are already merged, so I didn't resend them. They still apply as-is, so no changes are made. Changes from v2: * Collected acked-by. Original cover letter:

[PATCH RESEND v3 2/2] ARM: dts: sun4i: Add support for Topwise A721 tablet

2021-02-16 Thread Pascal Roeleven
The Topwise A721/LY-F1 tablet is a tablet sold around 2012 under different brands. The mainboard mentions A721 clearly, so this tablet is best known under this name. Signed-off-by: Pascal Roeleven --- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/sun4i-a10-topwise-a721

RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-16 Thread Min Li
> > > > If I come up with a new file and move all the abstraction code there, > > does that work? > > I think so, but it's more important to figure out a good user space interface > first. The ioctl interfaces should be written on a higher-level abstraction, > to > ensure they can work with any h

[PATCH RESEND v3 1/2] dt-bindings: arm: Add Topwise A721

2021-02-16 Thread Pascal Roeleven
Add the bindings for Topwise A721 tablet Signed-off-by: Pascal Roeleven Acked-by: Rob Herring --- Documentation/devicetree/bindings/arm/sunxi.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/s

Re: [PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors()

2021-02-16 Thread Krzysztof Wilczyński
Hi Dejin, Thank you again for all the work here! > Add pcim_alloc_irq_vectors(), a device-managed version of > pci_alloc_irq_vectors(). introducing this function can simplify > the error handling path in many drivers. The second sentence should most likely start with a capital letter. Having sa

Re: [PATCH v5 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
From: Alexander Lobakin Date: Tue, 16 Feb 2021 14:35:02 + > From: Xuan Zhuo > > This patch is used to construct skb based on page to save memory copy > overhead. > > This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the > network card priv_flags supports IFF_TX_SKB_NO_LINEAR

[ANNOUNCE] v5.11-rt5

2021-02-16 Thread Sebastian Andrzej Siewior
Dear RT folks! I'm pleased to announce the v5.11-rt5 patch set. Changes since v5.11-rt4: - Lazy preemption fix for 64bit PowerPC. It was broken since v5.9-rc2-rt1. Reported by John Ogness. - Two patches for chelsio/cxgb network driver to avoid tasklet_disable() usage in atomic cont

Re: anonymous enums in kernel doc

2021-02-16 Thread Andy Shevchenko
On Tue, Feb 16, 2021 at 7:05 PM Jonathan Corbet wrote: > > Andy Shevchenko writes: > > > On Tue, Feb 16, 2021 at 6:51 PM Jonathan Corbet wrote: > >> > >> > Mauro, can you do some test cases in your workflow against anonymous > >> > enum in ernel doc, please? > >> > > >> > They are broken again,

Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-16 Thread Nicolas Saenz Julienne
On Fri, 2021-02-12 at 11:11 -0800, Florian Fainelli wrote: > As Dave reported: > > This seems to have unintended side effects. GIC interrupt 117 is shared > between the standard I2C controllers (i2c-bcm2835) and the l2-intc block > handling the HDMI I2C interrupts. > > There is not a great way t

code style: Re: [PATCH v4] printk: Userspace format enumeration support

2021-02-16 Thread Petr Mladek
Hi, this is from Nitpicker's department. On Fri 2021-02-12 15:30:16, Chris Down wrote: > We have a number of systems industry-wide that have a subset of their > functionality that works as follows: > > 1. Receive a message from local kmsg, serial console, or netconsole; > 2. Apply a set of rules

Re: [External] Re: [PATCH 4/4] mm: memcontrol: fix swap uncharge on cgroup v2

2021-02-16 Thread Shakeel Butt
On Fri, Feb 12, 2021 at 10:48 PM Muchun Song wrote: > > On Sat, Feb 13, 2021 at 2:57 AM Shakeel Butt wrote: > > > > CCing more folks. > > > > On Fri, Feb 12, 2021 at 9:14 AM Muchun Song > > wrote: > > > > > > The swap charges the actual number of swap entries on cgroup v2. > > > If a swap cache

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-16 Thread David Hildenbrand
For the other parts, the question is what we actually want to let user space configure. Being able to specify "Very secure" "maximum secure" "average secure" all doesn't really make sense to me. Well, it doesn't to me either unless the user feels a cost/benefit, so if max cost $100 per invoc

Re: debugfs: was: Re: [PATCH v4] printk: Userspace format enumeration support

2021-02-16 Thread Chris Down
Petr Mladek writes: +static size_t printk_fmt_size(const char *fmt) +{ + size_t sz = strlen(fmt) + 1; + + /* +* Some printk formats don't start with KERN_SOH + level. We will add +* it later when rendering the output. +*/ + if (unlikely(fmt[0] != KERN_SOH

Re: [PATCH 4/4] mm: memcontrol: fix swap uncharge on cgroup v2

2021-02-16 Thread Michal Hocko
On Tue 16-02-21 11:59:00, Johannes Weiner wrote: > Hello Muchun, > > On Sat, Feb 13, 2021 at 01:01:59AM +0800, Muchun Song wrote: > > The swap charges the actual number of swap entries on cgroup v2. > > If a swap cache page is charged successful, and then we uncharge > > the swap counter. It is wr

Re: [PATCH 4/4] mm: memcontrol: fix swap uncharge on cgroup v2

2021-02-16 Thread Shakeel Butt
On Tue, Feb 16, 2021 at 9:05 AM Johannes Weiner wrote: > > Hello Muchun, > > On Sat, Feb 13, 2021 at 01:01:59AM +0800, Muchun Song wrote: > > The swap charges the actual number of swap entries on cgroup v2. > > If a swap cache page is charged successful, and then we uncharge > > the swap counter.

Re: [PATCH v4 2/9] cxl/mem: Find device capabilities

2021-02-16 Thread Jonathan Cameron
On Tue, 16 Feb 2021 08:43:03 -0800 Ben Widawsky wrote: > On 21-02-16 14:51:48, Jonathan Cameron wrote: > > On Mon, 15 Feb 2021 17:45:31 -0800 > > Ben Widawsky wrote: > > > > > Provide enough functionality to utilize the mailbox of a memory device. > > > The mailbox is used to interact with th

[PATCH v6 bpf-next 0/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
This series introduces XSK generic zerocopy xmit by adding XSK umem pages as skb frags instead of copying data to linear space. The only requirement for this for drivers is to be able to xmit skbs with skb_headlen(skb) == 0, i.e. all data including hard headers starts from frag 0. To indicate wheth

Re: code style: Re: [PATCH v4] printk: Userspace format enumeration support

2021-02-16 Thread Chris Down
Petr Mladek writes: I wonder if we could find a better name for the configure switch. I have troubles to imagine what printk enumeration might mean. Well, it might be because I am not a native speaker. Anyway, the word "enumeration" is used only in the configure option. Everything else is "print

[PATCH v6 bpf-next 1/6] netdev_priv_flags: add missing IFF_PHONY_HEADROOM self-definition

2021-02-16 Thread Alexander Lobakin
This is harmless for now, but comes fatal for the subsequent patch. Fixes: 871b642adebe3 ("netdev: introduce ndo_set_rx_headroom") Signed-off-by: Alexander Lobakin --- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevic

[PATCH v6 bpf-next 2/6] netdevice: check for net_device::priv_flags bitfield overflow

2021-02-16 Thread Alexander Lobakin
We almost ran out of unsigned int bitwidth. Define priv flags and check for potential overflow in the fashion of netdev_features_t. Defined this way, priv_flags can be easily expanded later with just changing its typedef. Signed-off-by: Alexander Lobakin Reported-by: kernel test robot # Inverted

[PATCH v6 bpf-next 3/6] net: add priv_flags for allow tx skb without linear

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo In some cases, we hope to construct skb directly based on the existing memory without copying data. In this case, the page will be placed directly in the skb, and the linear space of skb is empty. But unfortunately, many the network card does not support this operation. For exampl

[PATCH v6 bpf-next 4/6] virtio-net: support IFF_TX_SKB_NO_LINEAR

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo Virtio net supports the case where the skb linear space is empty, so add priv_flags. Signed-off-by: Xuan Zhuo Acked-by: Michael S. Tsirkin Signed-off-by: Alexander Lobakin --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

Re: [PATCH 4/4] mm: memcontrol: fix swap uncharge on cgroup v2

2021-02-16 Thread Johannes Weiner
On Tue, Feb 16, 2021 at 11:59:01AM -0500, Johannes Weiner wrote: > Hello Muchun, > > On Sat, Feb 13, 2021 at 01:01:59AM +0800, Muchun Song wrote: > > The swap charges the actual number of swap entries on cgroup v2. > > If a swap cache page is charged successful, and then we uncharge > > the swap c

Re: [PATCH v1 00/12] Driver of Intel(R) Gaussian & Neural Accelerator

2021-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 05:05:13PM +0100, Maciej Kwapulinski wrote: > Dear kernel maintainers, > > This submission is a kernel driver to support Intel(R) Gaussian & Neural > Accelerator (Intel(R) GNA). Intel(R) GNA is a PCI-based neural co-processor > available on multiple Intel platforms. AI de

[PATCH v6 bpf-next 5/6] xsk: respect device's headroom and tailroom on generic xmit path

2021-02-16 Thread Alexander Lobakin
xsk_generic_xmit() allocates a new skb and then queues it for xmitting. The size of new skb's headroom is desc->len, so it comes to the driver/device with no reserved headroom and/or tailroom. Lots of drivers need some headroom (and sometimes tailroom) to prepend (and/or append) some headers or dat

[PATCH v6 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo This patch is used to construct skb based on page to save memory copy overhead. This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the network card priv_flags supports IFF_TX_SKB_NO_LINEAR will use page to directly construct skb. If this feature is not supported, it

Re: [PATCH 2/2] rcu-tasks: add RCU-tasks self tests

2021-02-16 Thread Paul E. McKenney
On Mon, Feb 15, 2021 at 12:28:26PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-02-13 08:45:54 [-0800], Paul E. McKenney wrote: > > Glad you like it! But let's see which (if any) of these patches solves > > the problem for Sebastian. > > Looking at that, is there any reason for doing this th

Re: KASAN: invalid-access Write in enqueue_timer

2021-02-16 Thread Catalin Marinas
Adding Jason and Ard. It may be a use-after-free in the wireguard driver. Catalin On Mon, Feb 15, 2021 at 04:06:16PM -0800, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:f40ddce8 Linux 5.11 > git tree: upstream > console output: https://syzkaller.apps

[GIT PULL] fsverity updates for 5.12

2021-02-16 Thread Eric Biggers
The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04: Linux 5.11-rc5 (2021-01-24 16:47:14 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git tags/fsverity-for-linus for you to fetch changes up to 07c99001312cbf90a357d4

Re: [RFC][PATCH] sched: Fix affine_move_task()

2021-02-16 Thread Valentin Schneider
On 13/02/21 13:50, Peter Zijlstra wrote: > When affine_move_task(p) is called on a running task @p, which is not > otherwise already changing affinity, we'll first set > p->migration_pending and then do: > >stop_one_cpu(cpu_of_rq(rq), migration_cpu_stop, &arg); > > This then gets us to migr

Re: [PATCH 1/2] rcuscale: add kfree_rcu() single-argument scale test

2021-02-16 Thread Paul E. McKenney
On Mon, Feb 15, 2021 at 05:27:05PM +0100, Uladzislau Rezki wrote: > On Tue, Feb 09, 2021 at 05:00:52PM -0800, Paul E. McKenney wrote: > > On Tue, Feb 09, 2021 at 09:13:43PM +0100, Uladzislau Rezki wrote: > > > On Thu, Feb 04, 2021 at 01:46:48PM -0800, Paul E. McKenney wrote: > > > > On Fri, Jan 29,

Re: riscv+KASAN does not boot

2021-02-16 Thread Tobias Klauser
On 2021-02-16 at 12:17:30 +0100, Dmitry Vyukov wrote: > On Fri, Jan 29, 2021 at 9:11 AM Dmitry Vyukov wrote: > > > I was fixing KASAN support for my sv48 patchset so I took a look at your > > > issue: I built a kernel on top of the branch riscv/fixes using > > > https://github.com/google/syzkalle

<    1   2   3   4   5   6   7   8   9   10   >