Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote: > This change fixes a checkpatch CHECK style issue for "Alignment should match > open parenthesis". > > Signed-off-by: Pritthijit Nath > --- > drivers/staging/vt6656/rf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] staging: greybus: Fixed misspelling and alignment issue in hid.c

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 09:00:01PM +0530, Pritthijit Nath wrote: > This change fixes a checkpatch CHECK style issue for "Alignment should match > open parenthesis". > In addition the misspelling of "transferred" also has been fixed. When you say "also" or "in addition" in a changelog, that is a h

Re: [PATCH] staging: wimax: Fix some coding style problems

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 10:43:20PM +0530, Hemansh Agnihotri wrote: > This fixes checkpatch errors :- "else should follow close brace '}'", > "space required before the open parenthesis '('" and "spaces required > around that '?' (ctx:VxW)" in drivers/staging/wimax/i2400m/rx.c file. > > Signed-off-

Re: linux-next: Tree for Feb 11

2021-02-11 Thread Heiko Carstens
On Thu, Feb 11, 2021 at 10:26:04PM +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20210210: > > The powerpc tree still had its build failure in the allyesconfig for > which I applied a supplied patch. > > The v4l-dvb tree lost its build failure. > > The drm-misc tree lost its build

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-02-11 Thread Pavel Machek
On Thu 2021-02-11 13:36:16, Heiner Kallweit wrote: > On 11.02.2021 13:17, Pavel Machek wrote: > > On Thu 2021-01-14 12:05:21, Heiner Kallweit wrote: > >> On 14.01.2021 11:41, claudiu.bez...@microchip.com wrote: > >>> > >>> > >>> On 14.01.2021 12:25, Russell King - ARM Linux admin wrote: > > >>

Re: [PATCH] staging: wimax/i2400m: fix some byte order issues found by sparse

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 01:59:08AM +0530, Anirudh Rayabharam wrote: > Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare() > function: > > wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer > wimax/i2400m/fw.c:195:34: warning: invalid assignment: += > wimax/i2400m/fw

Re: [PATCH v2] clk: aspeed: Fix APLL calculate formula from ast2600-A2

2021-02-11 Thread Stephen Boyd
Quoting Ryan Chen (2021-01-18 22:17:15) > Starting from A2, the A-PLL calculation has changed. Use the > existing formula for A0/A1 and the new formula for A2 onwards. > > Fixes: d3d04f6c330a ("clk: Add support for AST2600 SoC") > Signed-off-by: Ryan Chen > --- Applied to clk-next

Re: [PATCH v2 6/8] cxl/mem: Enable commands via CEL

2021-02-11 Thread Dan Williams
On Thu, Feb 11, 2021 at 9:45 AM Ben Widawsky wrote: [..] > > > + if (mbox_cmd.size_out > sizeof(gsl)) { > > > + dev_warn(dev, "%zu excess logs\n", > > > +(mbox_cmd.size_out - sizeof(gsl)) / > > > +sizeof(struct gsl_entry)); > > > > This c

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Matthias Kaehlcke
Hi Stephen, On Thu, Feb 11, 2021 at 11:14:39AM -0800, Stephen Boyd wrote: > Quoting Matthias Kaehlcke (2021-02-10 14:20:18) > > > > On Wed, Feb 10, 2021 at 10:06:45PM +0100, Krzysztof Kozlowski wrote: > > > > > > This looks hackish... what if later we have something else than hub? > > > Another

[PATCH] spi: dw: Avoid stack content exposure

2021-02-11 Thread Kees Cook
Since "data" is u32, &data is a "u32 *" type, which means pointer math will move in u32-sized steps. This was meant to be a byte offset, so cast &data to "char *" to aim the copy into the correct location. Seen with -Warray-bounds (and found by Coverity): In file included from ./include/linux/str

Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Pritthijit Nath
On 12/02/21 1:59 am, Greg KH wrote: > On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote: >> This change fixes a checkpatch CHECK style issue for "Alignment should match >> open parenthesis". >> >> Signed-off-by: Pritthijit Nath >> --- >> drivers/staging/vt6656/rf.c | 2 +- >> 1 fil

Re: [PATCH v2 3/8] cxl/mem: Register CXL memX devices

2021-02-11 Thread Dan Williams
On Thu, Feb 11, 2021 at 2:19 AM Jonathan Cameron wrote: > > On Wed, 10 Feb 2021 18:17:25 + > Jonathan Cameron wrote: > > > On Tue, 9 Feb 2021 16:02:54 -0800 > > Ben Widawsky wrote: > > > > > From: Dan Williams > > > > > > Create the /sys/bus/cxl hierarchy to enumerate: > > > > > > * Memory

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-02-11 Thread Sami Tolvanen
Hi Nathan, On Thu, Feb 11, 2021 at 11:43 AM Nathan Chancellor wrote: > > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > which violates clang's CFI checking because fw_cfg_showrev()'s second > parameter is 'struct attribute', whereas the ->show() member of 'struct > kobj_str

Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote: > On 12/02/21 1:59 am, Greg KH wrote: > > On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote: > >> This change fixes a checkpatch CHECK style issue for "Alignment should > >> match open parenthesis". > >> > >> Signed-off

[PATCH] staging: wimax/i2400m: fix some byte order issues found by sparse

2021-02-11 Thread Anirudh Rayabharam
Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare() function: wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer wimax/i2400m/fw.c:195:34: warning: invalid assignment: += wimax/i2400m/fw.c:195:34:left side has type unsigned int wimax/i2400m/fw.c:195:34:right

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Stephen Boyd
Quoting Matthias Kaehlcke (2021-02-11 12:36:35) > Hi Stephen, > > On Thu, Feb 11, 2021 at 11:14:39AM -0800, Stephen Boyd wrote: > > > > Is it possible to use the graph binding to connect the USB controller on > > the SoC to the port on the hub? Then the hub would be a standalone node > > at the r

Re: [PATCH v2 2/2] mm/hugetlb: refactor subpage recording

2021-02-11 Thread Zi Yan
On 28 Jan 2021, at 16:53, Mike Kravetz wrote: > On 1/28/21 10:26 AM, Joao Martins wrote: >> For a given hugepage backing a VA, there's a rather ineficient >> loop which is solely responsible for storing subpages in GUP >> @pages/@vmas array. For each subpage we check whether it's within >> range o

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-11 Thread Stephen Boyd
Quoting Lee Jones (2021-01-26 04:45:19) > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > This is the last set. Clock is clean after this. Is it possible to slam in some patch that makes

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-11 Thread Shuah Khan
On 2/11/21 4:20 AM, Kalle Valo wrote: Shuah Khan writes: On 2/10/21 1:25 AM, Kalle Valo wrote: Shuah Khan writes: ath10k_drain_tx() must not be called with conf_mutex held as workers can use that also. Add check to detect conf_mutex held calls. Signed-off-by: Shuah Khan The commit log

linux-next: Fixes tag needs some work in the ftrace tree

2021-02-11 Thread Stephen Rothwell
Hi all, In commit b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors") Fixes tag Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for synthetic has these problem(s): - Subject has leading but no trailing parentheses Please do not split Fixes tags over more than o

Re: [PATCH v3 1/2] kunit: support failure from dynamic analysis tools

2021-02-11 Thread Daniel Latypov
On Thu, Feb 11, 2021 at 7:40 AM Alan Maguire wrote: > > On Thu, 11 Feb 2021, David Gow wrote: > > > On Wed, Feb 10, 2021 at 6:14 AM Daniel Latypov wrote: > > > > > > From: Uriel Guajardo > > > > > > Add a kunit_fail_current_test() function to fail the currently running > > > test, if any, with a

Re: [PATCH v5 05/10] userfaultfd: add minor fault registration mode

2021-02-11 Thread Axel Rasmussen
On Thu, Feb 11, 2021 at 11:28 AM Axel Rasmussen wrote: > > On Wed, Feb 10, 2021 at 1:22 PM Axel Rasmussen > wrote: > > > > This feature allows userspace to intercept "minor" faults. By "minor" > > faults, I mean the following situation: > > > > Let there exist two mappings (i.e., VMAs) to the sa

Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Pritthijit Nath
On 12/02/21 2:14 am, Greg KH wrote: > On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote: >> On 12/02/21 1:59 am, Greg KH wrote: >>> On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote: This change fixes a checkpatch CHECK style issue for "Alignment should match

Re: [PATCH ghak124 v3] audit: log nftables configuration change events

2021-02-11 Thread Steve Grubb
On Thursday, February 11, 2021 11:29:34 AM EST Paul Moore wrote: > > If I'm not mistaken, iptables emits a single audit log per table, ipset > > doesn't support audit at all. So I wonder how much audit logging is > > required at all (for certification or whatever reason). How much > > granularity i

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-11 Thread Lee Jones
On Thu, 11 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-01-26 04:45:19) > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > This is the last set. Clock is clean after

Re: [PATCH v3 3/7] mfd: max8997: Add of_compatible to extcon and charger mfd_cell

2021-02-11 Thread Timon Baetz
On Tue, 22 Dec 2020 09:55:22 +, Lee Jones wrote: > On Tue, 22 Dec 2020, Timon Baetz wrote: > > > Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a > > of_node set in the extcon driver. > > > > Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure > > the cha

Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 02:32:51AM +0530, Pritthijit Nath wrote: > On 12/02/21 2:14 am, Greg KH wrote: > > On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote: > >> On 12/02/21 1:59 am, Greg KH wrote: > >>> On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote: > This cha

Re: include/linux/compiler_types.h:315:38: error: call to '__compiletime_assert_498' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct can_frame, len) != offsetof(struct canfd_frame,

2021-02-11 Thread Oliver Hartkopp
Hello, On 11.02.21 17:51, kernel test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 291009f656e8eaebbdfd3a8d99f6b190a9ce9deb commit: c7b74967799b1af52b3045d69d4c26836b2d41de can: replace can_dlc as variable/element for payload length dat

[PATCH v2 net-next 0/5] net: ipa: some more cleanup

2021-02-11 Thread Alex Elder
Version 2 of this series has been rebased onto the current state of net-next/master. In addition, copyrights have been updated on files touched. The original introduction is below. -Alex This is another fairly innocuous set of cleanup patches. The first

[PATCH v2 net-next 2/5] net: ipa: don't report EPROBE_DEFER error

2021-02-11 Thread Alex Elder
When initializing the IPA core clock and interconnects, it's possible we'll get an EPROBE_DEFER error. This isn't really an error, it's just means we need to be re-probed later. Check the return code when initializing these, and if it's EPROBE_DEFER, skip printing the error message. Signed-off-b

[PATCH v2 net-next 3/5] net: ipa: fix register write command validation

2021-02-11 Thread Alex Elder
In ipa_cmd_register_write_valid() we verify that values we will supply to a REGISTER_WRITE IPA immediate command will fit in the fields that need to hold them. This patch fixes some issues in that function and ipa_cmd_register_write_offset_valid(). The dev_err() call in ipa_cmd_register_write_off

[PATCH v2 net-next 5/5] net: ipa: introduce gsi_channel_initialized()

2021-02-11 Thread Alex Elder
Create a simple helper function that indicates whether a channel has been initialized. This abstacts/hides the details of how this is determined. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH v2 net-next 4/5] net: ipa: introduce ipa_table_hash_support()

2021-02-11 Thread Alex Elder
Introduce a new function to abstract the knowledge of whether hashed routing and filter tables are supported for a given IPA instance. IPA v4.2 is the only one that doesn't support hashed tables (now and for the foreseeable future), but the name of the helper function is better for explaining what

[PATCH v2 net-next 1/5] net: ipa: use a separate pointer for adjusted GSI memory

2021-02-11 Thread Alex Elder
This patch actually fixes a bug, though it doesn't affect the two platforms supported currently. The fix implements GSI memory pointers a bit differently. For IPA version 4.5 and above, the address space for almost all GSI registers is adjusted downward by a fixed amount. This is currently handl

Re: linux-next: Fixes tag needs some work in the ftrace tree

2021-02-11 Thread Steven Rostedt
On Fri, 12 Feb 2021 07:57:28 +1100 Stephen Rothwell wrote: > Hi all, > > In commit > > b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors") > > Fixes tag > > Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for synthetic > > has these problem(s): > > - Subject h

Re: [PATCH v1 1/4] usb: typec: tps6598x: Add trace event for IRQ events

2021-02-11 Thread kernel test robot
Hi "Guido, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '

Re: [PATCH] platform/chrome: cros_ec_typec: Flush pending work

2021-02-11 Thread Benson Leung
On Thu, 11 Feb 2021 11:32:21 -0800, Prashant Malani wrote: > When a PD notifier event arrives, a new work event won't be enqueued if > the current one hasn't completed. This could lead to dropped events. > > So, flush any pending work before scheduling the new instance. Applied, thanks! [1/1] pl

Re: [PATCH v2 1/3] x86/vmemmap: Drop handling of 4K unaligned vmemmap range

2021-02-11 Thread Oscar Salvador
On Wed, Feb 03, 2021 at 11:47:48AM +0100, Oscar Salvador wrote: > remove_pte_table() is prepared to handle the case where either the > start or the end of the range is not PAGE aligned. > This cannot actually happen: > > __populate_section_memmap enforces the range to be PMD aligned, > so as long

Re: [PATCH] mm: workingset: clarify eviction order and distance calculation

2021-02-11 Thread Oscar Salvador
On Mon, Feb 01, 2021 at 07:06:51AM +0100, Oscar Salvador wrote: > The premise of the refault distance is that it can be seen as a deficit > of the inactive list space, so that if the inactive list would have had > (R - E) more slots, the page would not have been evicted but promoted > to the active

[PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Pritthijit Nath
This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis". Signed-off-by: Pritthijit Nath --- drivers/staging/vt6656/rf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c index 5b8da

Re: linux-next: Fixes tag needs some work in the ftrace tree

2021-02-11 Thread Tom Zanussi
On Thu, 2021-02-11 at 16:21 -0500, Steven Rostedt wrote: > On Fri, 12 Feb 2021 07:57:28 +1100 > Stephen Rothwell wrote: > > > Hi all, > > > > In commit > > > > b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax > > errors") > > > > Fixes tag > > > > Fixes: 81ff92a93d95 (selfte

Re: [PATCH] mm: workingset: clarify eviction order and distance calculation

2021-02-11 Thread Oscar Salvador
On Thu, Feb 11, 2021 at 10:26:45PM +0100, Oscar Salvador wrote: > Hi Andrew, > > is this on your radar? Please, disregard this, I was obviously blind as I did not spot it in mmotm. > > Thanks! > > -- > Oscar Salvador > SUSE L3 > -- Oscar Salvador SUSE L3

Re: [PATCH V2 0/8] btrfs: convert kmaps to core page calls

2021-02-11 Thread Ira Weiny
On Thu, Feb 11, 2021 at 08:38:03PM +0100, David Sterba wrote: > On Tue, Feb 09, 2021 at 10:22:13PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Per the conversation on V1 it looks like Andrew would like this to go > > through > > the btrfs tree. I think that is fine. The other

Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 02:56:47AM +0530, Pritthijit Nath wrote: > This change fixes a checkpatch CHECK style issue for "Alignment should > match open parenthesis". > > Signed-off-by: Pritthijit Nath > --- > drivers/staging/vt6656/rf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH v3 1/2] kunit: support failure from dynamic analysis tools

2021-02-11 Thread Brendan Higgins
On Thu, Feb 11, 2021 at 12:58 PM Daniel Latypov wrote: > > On Thu, Feb 11, 2021 at 7:40 AM Alan Maguire wrote: > > > > On Thu, 11 Feb 2021, David Gow wrote: > > > > > On Wed, Feb 10, 2021 at 6:14 AM Daniel Latypov > > > wrote: > > > > > > > > From: Uriel Guajardo > > > > > > > > Add a kunit_fa

[PATCH 0/3]net:qualcomm:rmnet:Enable Mapv5.

2021-02-11 Thread Sharath Chandra Vurukala
This series introduces the MAPv5 packet format. Patch 0 documents the MAPv5. Patch 1 introduces the Mapv5 and the Inline checksum offload for RX. Patch 2 introduces the Mapv5 and the Inline checksum offload for TX. A new checksum header format is used as part of MAPv5. For RX checksum offload, th

[PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-11 Thread Sharath Chandra Vurukala
Adding support for processing of Mapv5 downlink packets. It involves parsing the Mapv5 packet and checking the csum header to know whether the hardware has validated the checksum and is valid or not. Based on the checksum valid bit the corresponding stats are incremented and skb->ip_summed is mark

[PATCH 3/3] net:ethernet:rmnet: Add support for Mapv5 Uplink packet

2021-02-11 Thread Sharath Chandra Vurukala
Adding Support for Mapv5 uplink packet. Based on the configuration Request HW for csum offload by setting the csum_valid_required of Mapv5 packet. Signed-off-by: Sharath Chandra Vurukala --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 3 +- .../net/ethernet/qualcomm/rmnet/rmnet_handler

[PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Pritthijit Nath
This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis". Signed-off-by: Pritthijit Nath --- Fixed trailing space in changelog. drivers/staging/vt6656/rf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/rf.c b/dr

[PATCH 1/3] docs:networking: Add documentation for MAP v5

2021-02-11 Thread Sharath Chandra Vurukala
Adding documentation explaining the new MAPv5 packet format and the corresponding checksum offload header. Signed-off-by: Sharath Chandra Vurukala --- .../device_drivers/cellular/qualcomm/rmnet.rst | 53 -- 1 file changed, 49 insertions(+), 4 deletions(-) diff --git a/D

Re: [perf] perf_fuzzer causes crash in intel_pmu_drain_pebs_nhm()

2021-02-11 Thread Liang, Kan
On 2/11/2021 9:53 AM, Peter Zijlstra wrote: Kan, do you have time to look at this? On Thu, Jan 28, 2021 at 02:49:47PM -0500, Vince Weaver wrote: On Thu, 28 Jan 2021, Vince Weaver wrote: the perf_fuzzer has turned up a repeatable crash on my haswell system. addr2line is not being very hel

Re: [RFC PATCH 2/2] mm,page_alloc: Make alloc_contig_range handle free hugetlb pages

2021-02-11 Thread Oscar Salvador
On Wed, Feb 10, 2021 at 05:16:29PM -0800, Mike Kravetz wrote: > Should probably check for -EBUSY as this means someone started using > the page while we were allocating a new one. It would complicate the > code to try and do the 'right thing'. Right thing might be getting > dissolving the new poo

h8300-linux-ld: section .init.text LMA overlaps section .data LMA

2021-02-11 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 291009f656e8eaebbdfd3a8d99f6b190a9ce9deb commit: a30d8a39f0571425a459816ed8680e987a2ff279 usr: Add support for zstd compressed initramfs date: 7 months ago config: h8300-randconfig-r005-20210209 (attached

Re: [PATCH v2 5/9] clk: qcom: rcg2: Stop hardcoding gfx3d pingpong parent numbers

2021-02-11 Thread AngeloGioacchino Del Regno
Il 11/02/21 21:19, Stephen Boyd ha scritto: Quoting AngeloGioacchino Del Regno (2021-01-13 10:38:13) The function clk_gfx3d_determine_rate is selecting different PLLs to manage the GFX3D clock source in a special way: this one needs to be ping-pong'ed on different PLLs to ensure stability during

Re: possible deadlock in dquot_commit

2021-02-11 Thread Theodore Ts'o
On Thu, Feb 11, 2021 at 12:47:18PM +0100, Dmitry Vyukov wrote: > > This actually looks problematic: We acquired &ei->i_data_sem/2 (i.e., > > I_DATA_SEM_QUOTA subclass) in ext4_map_blocks() called from > > ext4_block_write_begin(). This suggests that the write has been happening > > directly to the

[PATCH] RFC: x86/jump_label: Mark arguments as const to satisfy asm constraints

2021-02-11 Thread Jason Gerecke
When compiling an external kernel module with `-O0` or `-O1`, the following compile error may be reported: ./arch/x86/include/asm/jump_label.h:25:2: error: impossible constraint in ‘asm’ 25 | asm_volatile_goto("1:" | ^ It appears that these lower optimizati

Re: [PATCH] spi: dw: Avoid stack content exposure

2021-02-11 Thread Serge Semin
On Thu, Feb 11, 2021 at 12:37:14PM -0800, Kees Cook wrote: > Since "data" is u32, &data is a "u32 *" type, which means pointer math > will move in u32-sized steps. This was meant to be a byte offset, so > cast &data to "char *" to aim the copy into the correct location. > > Seen with -Warray-bound

Re: [PATCH v1 0/7] Add support for IPA v3.1, GSI v1.0, MSM8998 IPA

2021-02-11 Thread AngeloGioacchino Del Regno
Il 11/02/21 21:27, Alex Elder ha scritto: On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote: Hey all! This time around I thought that it would be nice to get some modem action going on. We have it, it's working (ish), so just.. why not. Thank you for the patches! I would like to review t

Re: [PATCH 1/5] keys: cleanup build time module signing keys

2021-02-11 Thread Stefan Berger
On 2/11/21 2:54 PM, Nayna Jain wrote: The "mrproper" target is still looking for build time generated keys in the old path instead of certs/ directory. This patch fixes the path as well removes the names of the files which are no longer generated. Signed-off-by: Nayna Jain Fixes: 28a68f828266 (

Re: [PATCH 2/5] keys: generate self-signed module signing key using CSR

2021-02-11 Thread Stefan Berger
On 2/11/21 2:54 PM, Nayna Jain wrote: Loading a key on the IMA trusted keyring requires the key be signed by an existing key on the builtin or secondary trusted keyring. Creating a Certificate Signing Request (CSR) allows the certificate to be self-signed or signed by a CA. This patch generates

Re: [PATCH v1 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-11 Thread kernel test robot
Hi "Guido, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' a

[PATCH V3 mtd/next 1/3] dt-bindings: mtd: move partition binding to its own file

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki Single partition binding is quite common and may be: 1. Used by multiple parsers 2. Extended for more specific cases Move it to separated file to avoid code duplication. Signed-off-by: Rafał Miłecki Reviewed-by: Rob Herring --- .../mtd/partitions/fixed-partitions.yaml

[PATCH V3 mtd/next 3/3] mtd: parsers: ofpart: support BCM4908 fixed partitions

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 partitioning is based on fixed layout but allows specifying multiple firmware partitions. It requires detecting which firmware partition was used for booting current kernel. To support such cases without duplicating a lot of code (without copying most of the ofpart.c

[PATCH V3 mtd/next 2/3] dt-bindings: mtd: add binding for BCM4908 partitions

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 uses fixed partitions layout but function of some partitions may vary. Some devices use multiple firmware partitions and those partitions should be marked to let system discover their purpose. Signed-off-by: Rafał Miłecki --- V2: Use enum: [ 1, 2 ] for address & size

Re: [PATCH ghak124 v3] audit: log nftables configuration change events

2021-02-11 Thread Florian Westphal
Richard Guy Briggs wrote: > > > I personally would notify once per transaction. This is easy and quick. > > This was the goal. iptables was atomic. nftables appears to no longer > be so. If I have this wrong, please show how that works. nftables transactions are atomic, either the entire batc

Re: [PATCH v2 net-next 2/5] net: ipa: don't report EPROBE_DEFER error

2021-02-11 Thread Heiner Kallweit
On 11.02.2021 22:19, Alex Elder wrote: > When initializing the IPA core clock and interconnects, it's > possible we'll get an EPROBE_DEFER error. This isn't really an > error, it's just means we need to be re-probed later. > > Check the return code when initializing these, and if it's > EPROBE_DE

Re: [PATCH net-next v4 0/9] net: phy: icplus: cleanups and new features

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Feb 2021 08:47:41 +0100 you wrote: > Cleanup the PHY drivers for IPplus devices and add PHY counters and MDIX > support for the IP101A/G. > > Patch 5 adds a model detection based on the behavior of the PHY. > U

Re: [PATCH v2 net-next 2/5] net: ipa: don't report EPROBE_DEFER error

2021-02-11 Thread Alex Elder
On 2/11/21 4:11 PM, Heiner Kallweit wrote: On 11.02.2021 22:19, Alex Elder wrote: When initializing the IPA core clock and interconnects, it's possible we'll get an EPROBE_DEFER error. This isn't really an error, it's just means we need to be re-probed later. Check the return code when initial

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-11 Thread David Miller
From: Nobuhiro Iwamatsu Date: Thu, 11 Feb 2021 01:29:52 +0900 > +static int visconti_eth_init_hw(struct platform_device *pdev, struct > plat_stmmacenet_data *plat_dat) > +{ > + struct visconti_eth *dwmac; > + unsigned int reg_val, clk_sel_val; Please use reverse christmas tree ordering

Re: [PATCH 4/5] keys: define build time generated ephemeral kernel CA key

2021-02-11 Thread Stefan Berger
On 2/11/21 2:54 PM, Nayna Jain wrote: Certificates being loaded onto the IMA trusted keyring must be signed by a key on either the builtin and secondary trusted keyring. This patch creates and includes in the kernel image an ephemeral CA key, at build time when IMA_APPRAISE_MODSIG is enabled. S

Re: [perf] perf_fuzzer causes crash in intel_pmu_drain_pebs_nhm()

2021-02-11 Thread Vince Weaver
On Thu, 11 Feb 2021, Liang, Kan wrote: > > On Thu, Jan 28, 2021 at 02:49:47PM -0500, Vince Weaver wrote: > I'd like to reproduce it on my machine. > Is this issue only found in a Haswell client machine? > > To reproduce the issue, can I use ./perf_fuzzer under perf_event_tests/fuzzer? > Do I need

Re: [PATCH v2] [RFC] mm: fs: Invalidate BH LRU during page migration

2021-02-11 Thread Minchan Kim
On Wed, Feb 10, 2021 at 09:35:40PM -0800, Chris Goldsworthy wrote: > Pages containing buffer_heads that are in one of the per-CPU > buffer_head LRU caches will be pinned and thus cannot be migrated. > This can prevent CMA allocations from succeeding, which are often used > on platforms with co-proc

Re: [PATCH v3 1/2] thermal: armada: ap806: use firmware SiP services for thermal operations

2021-02-11 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on clk/clk-next] [also build test ERROR on linus/master v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

[PATCH 0/2] tiny fixes to watch_queue

2021-02-11 Thread Gabriel Krisman Bertazi
Hi David, You'll find here a couple of misc improvements to watch_queue documentation and code. Gabriel Krisman Bertazi (2): watch_queue: Fold info_id initialization into init_watch docs: watch_queue: Fix unit of the notification size field Documentation/watch_queue.rst | 7 --- include

Re: [PATCH v2 net-next 04/11] net: bridge: offload initial and final port flags through switchdev

2021-02-11 Thread Ido Schimmel
On Thu, Feb 11, 2021 at 11:35:27AM +0200, Vladimir Oltean wrote: > On Thu, Feb 11, 2021 at 09:44:43AM +0200, Ido Schimmel wrote: > > On Thu, Feb 11, 2021 at 01:23:52AM +0200, Vladimir Oltean wrote: > > > On Wed, Feb 10, 2021 at 12:59:49PM +0200, Ido Schimmel wrote: > > > > > > The reverse, during u

[PATCH 1/2] watch_queue: Fold info_id initialization into init_watch

2021-02-11 Thread Gabriel Krisman Bertazi
info_id needs to be or'ed when initializing a struct watch. That's an internal detail to the watch_queue api, so fold that logic into the watch_queue implementation, instead of replicating it on multiple callers. Signed-off-by: Gabriel Krisman Bertazi --- Documentation/watch_queue.rst | 5 +++--

[PATCH 2/2] docs: watch_queue: Fix unit of the notification size field

2021-02-11 Thread Gabriel Krisman Bertazi
Looking at the code and other documentation, the unit of size is bytes. Previously, the same documentation says bytes. Signed-off-by: Gabriel Krisman Bertazi --- Documentation/watch_queue.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/watch_queue.rst b/Doc

[PATCH 1/2] of: Remove of_dev_{get,put}()

2021-02-11 Thread Rob Herring
of_dev_get() and of_dev_put are just wrappers for get_device()/put_device() on a platform_device. There's also already platform_device_{get,put}() wrappers for this purpose. Let's update the few users and remove of_dev_{get,put}(). Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerr

[PATCH 0/2] of: of_device.h cleanups

2021-02-11 Thread Rob Herring
This is a couple of cleanups for of_device.h. They fell out from my attempt at decoupling of_device.h and of_platform.h which is a mess and I haven't finished, but there's no reason to wait on these. Rob Rob Herring (2): of: Remove of_dev_{get,put}() driver core: platform: Drop of_device_node

Re: [RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-02-11 Thread Lukasz Luba
On 2/11/21 11:07 AM, Lukasz Luba wrote: Hi Chanwoo, On 2/3/21 10:21 AM, Lukasz Luba wrote: Hi Chanwoo, Thank you for looking at this. On 2/3/21 10:11 AM, Chanwoo Choi wrote: Hi Lukasz, When accessing the max_freq and min_freq at devfreq-cooling.c, even if can access 'user_max_freq' and '

[PATCH 2/2] driver core: platform: Drop of_device_node_put() wrapper

2021-02-11 Thread Rob Herring
of_device_node_put() is just a wrapper for of_node_put(). The platform driver core is already polluted with of_node pointers and the only 'get' already uses of_node_get() (though typically the get would happen in of_device_alloc()). Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Frank Rowand

Re: [PATCH 5/5] ima: enable loading of build time generated key to .ima keyring

2021-02-11 Thread Stefan Berger
On 2/11/21 2:54 PM, Nayna Jain wrote: The kernel currently only loads the kernel module signing key onto the builtin trusted keyring. To support IMA, load the module signing key selectively either onto builtin or ima keyring based on MODULE_SIG or MODULE_APPRAISE_MODSIG config respectively; and l

Re: [GIT PULL] fscache: I/O API modernisation and netfs helper library

2021-02-11 Thread David Howells
Linus Torvalds wrote: > ... > IOW, I'm not against "wait_on_page_fscache()" as a function, but I > *am* against the odd _mixing_ of things without a big explanation, > where the code itself looks very odd and questionable. > > And I think the "fscache" waiting functions should not be visible to

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Rob Herring
On Thu, Feb 11, 2021 at 1:14 PM Stephen Boyd wrote: > > Quoting Matthias Kaehlcke (2021-02-10 14:20:18) > > > > On Wed, Feb 10, 2021 at 10:06:45PM +0100, Krzysztof Kozlowski wrote: > > > > > > This looks hackish... what if later we have something else than hub? > > > Another if()? > > > > > > What

[PATCH] drm/msm/kms: Use nested locking for crtc lock instead of custom classes

2021-02-11 Thread Stephen Boyd
We don't need to make up custom lock classes here, we can simply use mutex_lock_nested() and pass in the index of the crtc to the locking APIs instead. This helps lockdep understand that these are really different locks while avoiding having to allocate custom lockdep classes. Cc: Krishna Manikand

Re: [PATCH v4 2/2] KVM: SVM: Add support for Virtual SPEC_CTRL

2021-02-11 Thread Babu Moger
On 2/11/21 2:56 AM, Paolo Bonzini wrote: > On 29/01/21 01:43, Babu Moger wrote: >> This support also fixes an issue where a guest may sometimes see an >> inconsistent value for the SPEC_CTRL MSR on processors that support this >> feature. With the current SPEC_CTRL support, the first write to >>

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Rob Herring
On Thu, Feb 11, 2021 at 2:45 PM Stephen Boyd wrote: > > Quoting Matthias Kaehlcke (2021-02-11 12:36:35) > > Hi Stephen, > > > > On Thu, Feb 11, 2021 at 11:14:39AM -0800, Stephen Boyd wrote: > > > > > > Is it possible to use the graph binding to connect the USB controller on > > > the SoC to the po

Re: [PATCH] powerpc/bug: Remove specific powerpc BUG_ON()

2021-02-11 Thread Nicholas Piggin
Excerpts from Segher Boessenkool's message of February 11, 2021 9:50 pm: > On Thu, Feb 11, 2021 at 08:04:55PM +1000, Nicholas Piggin wrote: >> It would be nice if we could have a __builtin_trap_if that gcc would use >> conditional traps with, (and which never assumes following code is >> unreacha

Re: [PATCH 06/24] perf daemon: Add config file support

2021-02-11 Thread Jiri Olsa
On Thu, Feb 11, 2021 at 02:10:48PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Feb 11, 2021 at 05:45:38PM +0100, Jiri Olsa escreveu: > > On Thu, Feb 11, 2021 at 03:01:12PM +0900, Namhyung Kim wrote: > > > Hi Jiri, > > > > > > On Tue, Feb 9, 2021 at 5:09 AM Jiri Olsa wrote: > > > > +static in

[PATCH v5 1/5] block: keyslot-manager: Introduce passthrough keyslot manager

2021-02-11 Thread Satya Tangirala
The device mapper may map over devices that have inline encryption capabilities, and to make use of those capabilities, the DM device must itself advertise those inline encryption capabilities. One way to do this would be to have the DM device set up a keyslot manager with a "sufficiently large" nu

[PATCH v5 0/5] add support for inline encryption to device mapper

2021-02-11 Thread Satya Tangirala
This patch series adds support for inline encryption to the device mapper. Patch 1 introduces the "passthrough" keyslot manager. The regular keyslot manager is designed for inline encryption hardware that have only a small fixed number of keyslots. A DM device itself does not actually have only a

[PATCH v5 2/5] block: keyslot-manager: Introduce functions for device mapper support

2021-02-11 Thread Satya Tangirala
Introduce blk_ksm_update_capabilities() to update the capabilities of a keyslot manager (ksm) in-place. The pointer to a ksm in a device's request queue may not be easily replaced, because upper layers like the filesystem might access it (e.g. for programming keys/checking capabilities) at the same

Re: [PATCH v2] [RFC] mm: fs: Invalidate BH LRU during page migration

2021-02-11 Thread Minchan Kim
On Thu, Feb 11, 2021 at 11:39:05AM -0800, Chris Goldsworthy wrote: > On 2021-02-11 06:09, Matthew Wilcox wrote: > > On Wed, Feb 10, 2021 at 09:35:40PM -0800, Chris Goldsworthy wrote: > > > +/* These are used to control the BH LRU invalidation during page > > > migration */ > > > +static struct cpum

[PATCH v5 5/5] dm: set DM_TARGET_PASSES_CRYPTO feature for some targets

2021-02-11 Thread Satya Tangirala
dm-linear and dm-flakey obviously can pass through inline crypto support. Co-developed-by: Eric Biggers Signed-off-by: Eric Biggers Signed-off-by: Satya Tangirala Reviewed-by: Eric Biggers --- drivers/md/dm-flakey.c | 4 +++- drivers/md/dm-linear.c | 5 +++-- 2 files changed, 6 insertions(+),

[PATCH v5 3/5] dm: add support for passing through inline crypto support

2021-02-11 Thread Satya Tangirala
Update the device-mapper core to support exposing the inline crypto support of the underlying device(s) through the device-mapper device. This works by creating a "passthrough keyslot manager" for the dm device, which declares support for encryption settings which all underlying devices support.

[PATCH v5 4/5] dm: support key eviction from keyslot managers of underlying devices

2021-02-11 Thread Satya Tangirala
Now that device mapper supports inline encryption, add the ability to evict keys from all underlying devices. When an upper layer requests a key eviction, we simply iterate through all underlying devices and evict that key from each device. Co-developed-by: Eric Biggers Signed-off-by: Eric Bigger

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-11 Thread Mike Rapoport
On Thu, Feb 11, 2021 at 01:30:42PM +0100, Michal Hocko wrote: > On Thu 11-02-21 13:20:08, Mike Rapoport wrote: > [...] > > Sealing is anyway controlled via fcntl() and I don't think > > MFD_ALLOW_SEALING makes much sense for the secretmem because it is there to > > prevent rogue file sealing in tmp

Re: [PATCH v4 3/5] dm: add support for passing through inline crypto support

2021-02-11 Thread Satya Tangirala
On Wed, Feb 10, 2021 at 12:17:30PM -0800, Eric Biggers wrote: > On Mon, Feb 01, 2021 at 05:10:17AM +, Satya Tangirala wrote: > > Update the device-mapper core to support exposing the inline crypto > > support of the underlying device(s) through the device-mapper device. > > > > This works by c

Re: [PATCH v13 net-next 00/15] net: mvpp2: Add TX Flow Control support

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Feb 2021 12:48:47 +0200 you wrote: > From: Stefan Chulski > > Armada hardware has a pause generation mechanism in GOP (MAC). > The GOP generate flow control frames based on an indication programmed in > Ports

Re: [PATCH v1 3/4] usb: typec: tps6598x: Add trace event for power status register

2021-02-11 Thread kernel test robot
Hi "Guido, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' a

<    1   2   3   4   5   6   7   8   9   10   >