Re: [PATCH 1/9] mm/migrate.c: Always allow device private pages to migrate

2021-02-09 Thread Alistair Popple
On Wednesday, 10 February 2021 12:39:32 AM AEDT Jason Gunthorpe wrote: > On Tue, Feb 09, 2021 at 12:07:14PM +1100, Alistair Popple wrote: > > Device private pages are used to represent device memory that is not > > directly accessible from the CPU. Extra references to a device private > > page are

Re: [Linuxarm] [PATCH for next v1 0/2] gpio: few clean up patches to replace spin_lock_irqsave with spin_lock

2021-02-09 Thread luojiaxing
On 2021/2/9 17:42, Andy Shevchenko wrote: On Tue, Feb 9, 2021 at 11:24 AM luojiaxing wrote: On 2021/2/8 21:28, Andy Shevchenko wrote: On Mon, Feb 8, 2021 at 11:11 AM luojiaxing wrote: Sorry, my operation error causes a patch missing from this patch set. I re-send the patch set. Please chec

[PATCH] sched/autogroup: Use true and false for bool variable

2021-02-09 Thread Jiapeng Chong
Fix the following coccicheck warning: kernel/sched/autogroup.h:46:8-9: WARNING: return of 0/1 in function 'task_group_is_autogroup' with return type bool. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- kernel/sched/autogroup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v1] media: atomisp: fix compiler warning

2021-02-09 Thread Tong Zhang
should use %zu for size_t type, otherwise compiler will complain drivers/staging/media/atomisp/pci/hmm/hmm.c:272:3: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘size_t’ {aka ‘unsigned int’} [-Wformat=] 272 | "%s: pages: 0x%08x (%ld bytes), type: %d from

[PATCH v3] printk: fix deadlock when kernel panic

2021-02-09 Thread Muchun Song
printk_safe_flush_on_panic() caused the following deadlock on our server: CPU0: CPU1: panic rcu_dump_cpu_stacks kdump_nmi_shootdown_cpus nmi_trigger_cpumask_backtrace register_nmi_handler(cra

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-09 Thread Jason Wang
On 2021/2/10 上午10:30, Si-Wei Liu wrote: On 2/8/2021 10:37 PM, Jason Wang wrote: On 2021/2/9 下午2:12, Eli Cohen wrote: On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote: On 2021/2/8 下午6:04, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote: On 2021/2/8 下

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-09 Thread Jason Wang
On 2021/2/10 上午8:26, Si-Wei Liu wrote: On 2/8/2021 7:37 PM, Jason Wang wrote: On 2021/2/6 下午8:29, Si-Wei Liu wrote: While virtq is stopped,  get_vq_state() is supposed to be  called to  get  sync'ed  with  the latest internal avail_index from device. The saved avail_index is used to restat

Re: [PATCH 1/2] ext4: Handle casefolding with encryption

2021-02-09 Thread Theodore Ts'o
On Tue, Feb 09, 2021 at 08:03:10PM -0700, Andreas Dilger wrote: > Depending on the size of the "escape", it probably makes sense to move > toward having e2fsck migrate from the current mechanism to using dirdata > for all deployments. In the current implementation, tools don't really > know for su

[PATCH] psi: Use ONCPU state tracking machinery to detect reclaim

2021-02-09 Thread Chengming Zhou
Move the reclaim detection from the timer tick to the task state tracking machinery using the recently added ONCPU state. And we also add memstall state changes checking in the psi_task_switch() optimization to update the parents properly. Thanks to Johannes Weiner for pointing out the psi_task_sw

Re: [PATCH v4] checkpatch: do not apply "initialise globals to 0" check to BPF progs

2021-02-09 Thread Song Liu
> On Feb 9, 2021, at 6:10 PM, Joe Perches wrote: > > On Tue, 2021-02-09 at 13:19 -0800, Song Liu wrote: >> BPF programs explicitly initialise global variables to 0 to make sure >> clang (v10 or older) do not put the variables in the common section. > > Acked-by: Joe Perches > > So the patch

[PATCH v1] media: ti-vpe: cal: fix ce

2021-02-09 Thread Tong Zhang
FIELD_GET require mask field to be constant, however it is wrapped by a function which will cause error ././include/linux/compiler_types.h:320:38: error: call to ‘__compiletime_assert_270’ declared with attribute error: FIELD_GET: mask is not constant 320 | _compiletime_assert(condition, msg,

Re: [PATCH RFC 4/6] btrfs: Check if the filesystem is has mixed type of devices

2021-02-09 Thread Michał Mirosław
On Tue, Feb 09, 2021 at 09:30:38PM +0100, Michal Rostecki wrote: > From: Michal Rostecki > > Add the btrfs_check_mixed() function which checks if the filesystem has > the mixed type of devices (non-rotational and rotational). This > information is going to be used in roundrobin raid1 read policy.

Re: [RFC PATCH 1/2] KVM: selftests: Add a macro to get string of vm_mem_backing_src_type

2021-02-09 Thread wangyanan (Y)
On 2021/2/10 1:35, Sean Christopherson wrote: On Tue, Feb 09, 2021, Ben Gardon wrote: On Tue, Feb 9, 2021 at 3:21 AM wangyanan (Y) wrote: On 2021/2/9 2:13, Ben Gardon wrote: On Mon, Feb 8, 2021 at 1:08 AM Yanan Wang wrote: Add a macro to get string of the backing source memory type, so t

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-09 Thread Anshuman Khandual
On 2/9/21 11:09 PM, Mathieu Poirier wrote: > On Fri, Feb 05, 2021 at 10:53:30AM -0700, Mathieu Poirier wrote: >> On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: >>> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is >>> accessible via the system registers

Re: [PATCH v4] checkpatch: do not apply "initialise globals to 0" check to BPF progs

2021-02-09 Thread Joe Perches
On Wed, 2021-02-10 at 04:07 +, Song Liu wrote: > > On Feb 9, 2021, at 6:10 PM, Joe Perches wrote: > > On Tue, 2021-02-09 at 13:19 -0800, Song Liu wrote: > > > BPF programs explicitly initialise global variables to 0 to make sure > > > clang (v10 or older) do not put the variables in the common

RE: [Linuxarm] Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers

2021-02-09 Thread Finn Thain
On Wed, 10 Feb 2021, Song Bao Hua (Barry Song) wrote: > > On Tue, 9 Feb 2021, Song Bao Hua (Barry Song) wrote: > > > > > > On Tue, 9 Feb 2021, Song Bao Hua (Barry Song) wrote: > > > > > > > > > > On Sun, 7 Feb 2021, Xiaofei Tan wrote: > > > > > > > > > > > > > Replace spin_lock_irqsave with spin_

RE: [Linuxarm] Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers

2021-02-09 Thread Finn Thain
On Tue, 9 Feb 2021, Song Bao Hua (Barry Song) wrote: > > > sonic_interrupt() uses an irq lock within an interrupt handler to > > > avoid issues relating to this. This kind of locking may be needed in > > > the drivers you are trying to patch. Or it might not. Apparently, > > > no-one has looked

Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

2021-02-09 Thread Jason Wang
On 2021/2/9 下午5:00, Stefano Garzarella wrote: On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote: It's legal to have 'offset + len' equal to sizeof(struct virtio_net_config), since 'ndev->config' is a 'struct virtio_ne

[PATCH 2/2] Docs: add fs/eventpoll to docbooks

2021-02-09 Thread Randy Dunlap
Add fs/eventpoll.c to the filesystem api-summary book. Signed-off-by: Randy Dunlap Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Andrew Morton Cc: Alexander Viro --- Documentation/filesystems/api-summary.rst |6 ++ 1 file changed, 6 insertions(+) --- linux-next-20210205.orig/

[PATCH 1/2] fs: eventpoll: fix comments & kernel-doc notation

2021-02-09 Thread Randy Dunlap
Use the documented kernel-doc format for function Return: descriptions. Begin constant values in kernel-doc comments with '%'. Remove kernel-doc "/**" from 2 functions that are not documented with kernel-doc notation. Fix typos, punctuation, & grammar. Also fix a few kernel-doc warnings: ../fs/

Re: [PATCH RFC 6/6] btrfs: Add roundrobin raid1 read policy

2021-02-09 Thread Michał Mirosław
On Tue, Feb 09, 2021 at 09:30:40PM +0100, Michal Rostecki wrote: [...] > For the array with 3 HDDs, not adding any penalty resulted in 409MiB/s > (429MB/s) performance. Adding the penalty value 1 resulted in a > performance drop to 404MiB/s (424MB/s). Increasing the value towards 10 > was making th

Re: [PATCH] kswapd: no need reclaim cma pages triggered by unmovable allocation

2021-02-09 Thread zhou xianrong
On 2021/2/9 下午5:23, Michal Hocko wrote: On Tue 09-02-21 16:23:13, zhou wrote: From: zhou xianrong For purpose of better migration cma pages are allocated after failure movalbe allocations and are used normally for file pages or anonymous pages. In reclaim path so many cma pages if configura

Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices

2021-02-09 Thread Kelley, Sean V
> On Feb 9, 2021, at 6:05 PM, Qiuxu Zhuo wrote: > > On a Sapphire Rapids server, it failed to inject correctable errors > to the RCiEP device e8:02.0 which was associated with the RCEC device > e8:00.4. See the following error log before applying the patch: > > aer-inject -s e8:02.0 examples/

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-09 Thread Jason Wang
On 2021/2/9 下午6:15, Naresh Kamboju wrote: Hi Jason, On Mon, 4 Jan 2021 at 12:28, Jason Wang wrote: Signed-off-by: Jason Wang --- drivers/virtio/Kconfig | 10 +- drivers/virtio/Makefile| 1 + drivers/virtio/virtio_pci_common.h | 27 +- drivers/vir

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-09 Thread Jason Wang
On 2021/2/9 下午10:20, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang --- drivers/virtio/Kconfig | 10 +- drivers/virtio/Makefile| 1 + drivers/virtio/virtio_pci_common.h | 27 +- drive

RE: [ANNOUNCE] exfatprogs-1.1.0 version released

2021-02-09 Thread Namjae Jeon
> On Wed, Feb 10, 2021 at 12:50 AM Namjae Jeon wrote: > > > > Hi folk, > > > > We have released exfatprogs 1.1.0 version. In this release, exfatlabel > > has been added to print or re-write volume label and volume serial value. > > Also, A new dump.exfat util has been added to display statistics f

[next] [arm] ERROR: modpost: "udp_sock_create6" [net/rxrpc/rxrpc.ko] undefined!

2021-02-09 Thread Naresh Kamboju
Linux next tag 20210209 arm omap2plus_defconfig make modules failed. - arm (omap2plus_defconfig) with gcc-10 - FAILED - arm (omap2plus_defconfig) with gcc-9 - FAILED - arm (omap2plus_defconfig) with gcc-8 - FAILED make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds

Re: linux-next: qemu boot failure after merge of the tip tree

2021-02-09 Thread Stephen Rothwell
Hi Peter, On Mon, 1 Feb 2021 15:40:12 +0100 Peter Zijlstra wrote: > > On Mon, Feb 01, 2021 at 01:04:30PM +, Valentin Schneider wrote: > > On 01/02/21 20:09, Stephen Rothwell wrote: > > > Hi all, > > > > > > > Hi Stephen, > > > > > After merging the tip tree, today's linux-next qemu bo

Re: [PATCH v8 7/9] crypto: hisilicon/hpre - add 'ECDH' algorithm

2021-02-09 Thread Herbert Xu
On Mon, Feb 08, 2021 at 05:38:55PM +0800, Meng Yu wrote: > 1. Enable 'ECDH' algorithm in Kunpeng 930; > 2. HPRE ECDH Support: ecdh-nist-p192, ecdh-nist-p224, >ecdh-nist-p256, ecdh-nist-p384, ecdh-nist-p521. Where is the patch that adds the generic ecdh-nist-p384? Thanks, -- Email: Herbert Xu

Re: [PATCH v8 3/9] crypto: atmel-ecc - move curve_id of ECDH from the key to algorithm name

2021-02-09 Thread Herbert Xu
On Mon, Feb 08, 2021 at 05:38:51PM +0800, Meng Yu wrote: > As curve id of ECDH will be moved from its key into algorithm name, > we cannot use 'curve_id' in 'struct ecdh', so we should modify ECDH > driver in atmel, and make ECDH algorithm name be the same as crypto > (like 'ecdh-nist-pxxx'); > >

Re: [PATCH 4.4 00/38] 4.4.257-rc1 review

2021-02-09 Thread Naresh Kamboju
On Mon, 8 Feb 2021 at 20:33, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.4.257 release. > There are 38 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

[PATCH 0/3] add support for never printing hashed addresses

2021-02-09 Thread Timur Tabi
[The list of email addresses on CC: is getting quite lengthy, so I hope I've included everyone.] Although hashing addresses printed via printk does make the kernel more secure, it interferes with debugging, especially with some functions like print_hex_dump() which always uses hashed addresses. T

[PATCH 2/3] kselftest: add support for skipped tests

2021-02-09 Thread Timur Tabi
Update the kselftest framework to all testing clients to specify that some tests were skipped. Signed-off-by: Timur Tabi --- tools/testing/selftests/kselftest_module.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/kselftest_module

[PATCH 1/3] lib/test_printf: use KSTM_MODULE_GLOBALS macro

2021-02-09 Thread Timur Tabi
Instead of defining the total/failed test counters manually, test_printf should use the kselftest macro created for this purpose. Signed-off-by: Timur Tabi --- lib/test_printf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/test_printf.c b/lib/test_printf.c index 7a

[PATCH 3/3] [v2] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-09 Thread Timur Tabi
From: Timur Tabi If the make-printk-non-secret command line parameter is set, then printk("%p") will print pointers as unhashed. This is useful for debugging purposes. A large warning message is displayed if this option is enabled. Unhashed pointers, while useful for debugging, expose kernel ad

[PATCH] mmc: core: add a power cycle when CMD11 fails

2021-02-09 Thread DooHyun Hwang
A power cycle is required if CMD11 fails. CMD11 failure should be handled as no response. If there is a timeout error that means no response to the CMD11, do not send the CMD11 again and the power cycle is required. Any other errors for CMD11 are the same because CMD11 failed. On some bad SD Card

Re: [RFC PATCH 2/2] KVM: selftests: Add a test for kvm page table code

2021-02-09 Thread wangyanan (Y)
On 2021/2/10 1:38, Ben Gardon wrote: On Mon, Feb 8, 2021 at 11:22 PM wangyanan (Y) wrote: Hi Ben, On 2021/2/9 4:29, Ben Gardon wrote: On Mon, Feb 8, 2021 at 1:08 AM Yanan Wang wrote: This test serves as a performance tester and a bug reproducer for kvm page table code (GPA->HPA mappings),

Re: [PATCH v4 5/7] cpufreq: qcom-hw: Implement CPRh aware OSM programming

2021-02-09 Thread Viresh Kumar
On 20-01-21, 13:05, Bjorn Andersson wrote: > On Wed 20 Jan 12:25 CST 2021, Taniya Das wrote: > > > The CPUFREQ-HW driver is intended to be used only for CPUFREQ HW designs > > where the firmware programs the look up tables. > > > > It's obvious that this is the intended target for the current ve

RE: [Linuxarm] Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers

2021-02-09 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Finn Thain [mailto:fth...@telegraphics.com.au] > Sent: Wednesday, February 10, 2021 5:16 PM > To: Song Bao Hua (Barry Song) > Cc: tanxiaofei ; j...@linux.ibm.com; > martin.peter...@oracle.com; linux-s...@vger.kernel.org; > linux-kernel@vger.kernel.org; linux.

Re: [PATCH] mm: page-writeback: simplify memcg handling in test_clear_page_writeback()

2021-02-09 Thread Hugh Dickins
On Tue, 9 Feb 2021, Johannes Weiner wrote: > Page writeback doesn't hold a page reference, which allows truncate to > free a page the second PageWriteback is cleared. This used to require > special attention in test_clear_page_writeback(), where we had to be > careful not to rely on the unstable p

[PATCH 0/3][RESEND] add support for never printing hashed addresses

2021-02-09 Thread Timur Tabi
[accidentally sent from the wrong email address, so resending] [The list of email addresses on CC: is getting quite lengthy, so I hope I've included everyone.] Although hashing addresses printed via printk does make the kernel more secure, it interferes with debugging, especially with some functi

[PATCH 1/3] lib/test_printf: use KSTM_MODULE_GLOBALS macro

2021-02-09 Thread Timur Tabi
Instead of defining the total/failed test counters manually, test_printf should use the kselftest macro created for this purpose. Signed-off-by: Timur Tabi --- lib/test_printf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/test_printf.c b/lib/test_printf.c index 7a

Re: WARNING: suspicious RCU usage (5.11.0-rc7+ #1812 Tainted: G)

2021-02-09 Thread Kalle Valo
"Rafael J. Wysocki" writes: >> > AFAICT that's a simple 'use RCU without holding rcu_read_lock' warning. >> > I've not dug through ath10k to see who should be doing rcu_read_lock, >> > but the few places I did look at don't seem to have changed recently. >> >> Just this morning I applied a patch

[PATCH 3/3] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-09 Thread Timur Tabi
If the make-printk-non-secret command line parameter is set, then printk("%p") will print pointers as unhashed. This is useful for debugging purposes. A large warning message is displayed if this option is enabled. Unhashed pointers, while useful for debugging, expose kernel addresses which can b

[PATCH 2/3] kselftest: add support for skipped tests

2021-02-09 Thread Timur Tabi
Update the kselftest framework to all testing clients to specify that some tests were skipped. Signed-off-by: Timur Tabi --- tools/testing/selftests/kselftest_module.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/kselftest_module

[next] [s390 ] net: mlx5: tc_tun.h:24:29: error: field 'match_level' has incomplete type

2021-02-09 Thread Naresh Kamboju
While building Linux next tag 20210209 s390 (defconfig) with gcc-9 make modules failed. - s390 (defconfig) with gcc-8 - FAILED - s390 (defconfig) with gcc-9 - FAILED - s390 (defconfig) with gcc-10 - FAILED make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH

Re: [PATCH 1/3] lib/test_printf: use KSTM_MODULE_GLOBALS macro

2021-02-09 Thread Timur Tabi
On 2/9/21 11:18 PM, Timur Tabi wrote: Instead of defining the total/failed test counters manually, test_printf should use the kselftest macro created for this purpose. Signed-off-by: Timur Tabi Ugh, I really need to stop sending patches late at night. This is again the wrong email address.

[next] [mips] spinlock.h:17:28: error: redefinition of 'queued_spin_unlock'

2021-02-09 Thread Naresh Kamboju
While building Linux next tag 20210209 mips uImage.gz failed with below configs - mips (cavium_octeon_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED - mips (malta_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED - mips (nlm_xlp_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED - mips

Re: [PATCH v19 3/3] scsi: ufs: Prepare HPB read for cached sub-region

2021-02-09 Thread Can Guo
On 2021-02-09 22:21, Bean Huo wrote: On Tue, 2021-02-09 at 13:25 +, Avri Altman wrote: > > > > > > + put_unaligned_be64(ppn, &cdb[6]); > > > > > > You are assuming the HPB entries read out by "HPB Read Buffer" > > > cmd > > > are > > > in Little > > > Endian, which is why you are using p

drivers/hsi/clients/ssi_protocol.c:630:33: sparse: sparse: cast to restricted __be16

2021-02-09 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e0756cfc7d7cd08c98a53b6009c091a3f6a50be6 commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable date: 9 months ago config: arm-randconfig-s032-20210209

Re: [next] [s390 ] net: mlx5: tc_tun.h:24:29: error: field 'match_level' has incomplete type

2021-02-09 Thread Saeed Mahameed
On Wed, 2021-02-10 at 10:50 +0530, Naresh Kamboju wrote: > While building Linux next tag 20210209 s390 (defconfig) with gcc-9 > make modules failed. > ... > Reported-by: Naresh Kamboju > Thanks for the report a patch was already posted earlier today https://patchwork.ker

RE: linux-next: manual merge of the gpio-brgl tree with the arm-soc tree

2021-02-09 Thread nobuhiro1.iwamatsu
Hi all, > -Original Message- > From: Arnd Bergmann [mailto:a...@kernel.org] > Sent: Tuesday, February 9, 2021 8:36 PM > To: Geert Uytterhoeven > Cc: Stephen Rothwell ; Bartosz Golaszewski > ; Olof Johansson ; > Arnd Bergmann ; ARM ; > Bartosz Golaszewski > ; Linux Kernel Mailing List >

Re: [PATCH] net/mlx5: docs: correct section reference in table of contents

2021-02-09 Thread Saeed Mahameed
On Fri, 2021-02-05 at 10:55 +0100, Lukas Bulwahn wrote: > Commit 142d93d12dc1 ("net/mlx5: Add devlink subfunction port > documentation") refers to a section 'mlx5 port function' in the table > of > contents, but includes a section 'mlx5 function attributes' instead. > > Hence, make htmldocs warns:

Re: [PATCH] ext4: add .kunitconfig fragment to enable ext4-specific tests

2021-02-09 Thread Daniel Latypov
On Tue, Feb 9, 2021 at 6:33 PM Theodore Ts'o wrote: > > On Tue, Feb 09, 2021 at 05:32:06PM -0800, Daniel Latypov wrote: > > > > After [2]: > > $ ./tools/testing/kunit.py run --kunitconfig=fs/ext4/.kunitconfig > > Any chance that in the future this might become: > > $ ./tools/testing/kunit.py run

[PATCH] docs: reporting-issues.rst: explain how to decode stack traces

2021-02-09 Thread Thorsten Leemhuis
Replace placeholder text about decoding stack traces with a section that properly describes what a typical user should do these days. To make it works for them, add a paragraph in an earlier section to ensure people build their kernels with everything that's needed to decode stack traces later. Si

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-02-09 Thread Guenter Roeck
ng this patch fixes the problem. Bisect log is attached. It may also break a variety of other boot tests, but with 115 of 430 boot tests failing in -next it is difficult to identify all culprits. Guenter --- Bisect log: # bad: [a4bfd8d46ac357c12529e4eebb6c89502b03ecc9] Add linux-next specific fi

Re: [PATCH] bpf_lru_list: Read double-checked variable once without lock

2021-02-09 Thread Martin KaFai Lau
On Tue, Feb 09, 2021 at 12:27:01PM +0100, Marco Elver wrote: > For double-checked locking in bpf_common_lru_push_free(), node->type is > read outside the critical section and then re-checked under the lock. > However, concurrent writes to node->type result in data races. > > For example, the follo

Re: [PATCH v2 06/28] locking/rwlocks: Add contention detection for rwlocks

2021-02-09 Thread Guenter Roeck
On 2/9/21 4:27 PM, Waiman Long wrote: [ ... ] > > It is because in arch/mips/include/asm/spinlock.h, asm/qrwlock.h is included > before asm/qspinlock.h. The compilation error should be gone if the > asm/qrwlock.h is removed or moved after asm/qspinlock.h. > > I did a x86 build and there was no

Re: [PATCH v2 08/14] x86/fault: Skip erratum #93 workaround on new CPUs

2021-02-09 Thread Andy Lutomirski
On Tue, Feb 9, 2021 at 6:33 PM Andy Lutomirski wrote: > > Erratum #93 applies to the first generation of AMD K8 CPUs. Skip the > workaround on newer CPUs. Whoops, this breaks the !CPU_SUP_AMD build. It needs a fixup like this: https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/comm

Re: [PATCH v7 2/6] mfd: Support ROHM BD9576MUF and BD9573MUF

2021-02-09 Thread Matti Vaittinen
Hello Lee, On Tue, 2021-02-09 at 14:55 +, Lee Jones wrote: > On Fri, 22 Jan 2021, Matti Vaittinen wrote: > > > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are > > mainly used to power the R-Car series processors. > > > > Signed-off-by: Matti Vaittinen > > --- > > + > > +st

[PATCH V2 1/8] mm/highmem: Lift memcpy_[to|from]_page to core

2021-02-09 Thread ira . weiny
From: Ira Weiny Working through a conversion to a call kmap_local_page() instead of kmap() revealed many places where the pattern kmap/memcpy/kunmap occurred. Eric Biggers, Matthew Wilcox, Christoph Hellwig, Dan Williams, and Al Viro all suggested putting this code into helper functions. Al Vir

[PATCH V2 2/8] mm/highmem: Convert memcpy_[to|from]_page() to kmap_local_page()

2021-02-09 Thread ira . weiny
From: Ira Weiny kmap_local_page() is more efficient and is well suited for these calls. Convert the kmap() to kmap_local_page() Cc: Andrew Morton Cc: Christoph Hellwig Signed-off-by: Ira Weiny --- New for V2 --- include/linux/highmem.h | 8 1 file changed, 4 insertions(+), 4 deletio

[PATCH V2 5/8] iov_iter: Remove memzero_page() in favor of zero_user()

2021-02-09 Thread ira . weiny
From: Ira Weiny zero_user() is already defined with the same interface and contains the same code pattern as memzero_page(). Remove memzero_page() and use the already defined common function zero_user() To: Alexander Viro Cc: Andrew Morton Cc: Christoph Hellwig Signed-off-by: Ira Weiny ---

[PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-09 Thread ira . weiny
From: Ira Weiny Add VM_BUG_ON bounds checks to ensure the newly lifted and created page memory operations do not result in corrupted data in neighbor pages and to make them consistent with zero_user().[1][2] [1] https://lore.kernel.org/lkml/20201210053502.gs1563...@iweiny-desk2.sc.intel.com/ [2

[PATCH V2 0/8] btrfs: convert kmaps to core page calls

2021-02-09 Thread ira . weiny
From: Ira Weiny Changes from V1: Rework commit messages because they were very weak Change 'fs/btrfs: X' to 'btrfs: x' https://lore.kernel.org/lkml/20210209151442.gu1...@suse.cz/ Per Andrew Split out changes to highmem.h

[PATCH V2 3/8] mm/highmem: Introduce memcpy_page(), memmove_page(), and memset_page()

2021-02-09 Thread ira . weiny
From: Ira Weiny 3 more common kmap patterns are kmap/memcpy/kunmap, kmap/memmove/kunmap. and kmap/memset/kunmap. Add helper functions for those patterns which use kmap_local_page(). Cc: Andrew Morton Cc: Christoph Hellwig Signed-off-by: Ira Weiny --- New for V2 --- include/linux/highmem.h

[PATCH V2 6/8] btrfs: use memcpy_[to|from]_page() and kmap_local_page()

2021-02-09 Thread ira . weiny
From: Ira Weiny There are many places where the pattern kmap/memcpy/kunmap occurs. This pattern was lifted to the core common functions memcpy_[to|from]_page(). Use these new functions to reduce the code, eliminate direct uses of kmap, and leverage the new core functions use of kmap_local_page(

[PATCH V2 7/8] btrfs: use copy_highpage() instead of 2 kmaps()

2021-02-09 Thread ira . weiny
From: Ira Weiny There are many places where kmap/memove/kunmap patterns occur. This pattern exists in the core common function copy_highpage(). Use copy_highpage to avoid open coding the use of kmap and leverages the core functions use of kmap_local_page(). Development of this patch was aided

[PATCH V2 8/8] btrfs: convert to zero_user()

2021-02-09 Thread ira . weiny
From: Ira Weiny There are many places where kmap/memset/kunmap patterns occur. This pattern exists in the core as zero_user() Use zero_user() to eliminate direct uses of kmap and leverage the new core functions use of kmap_local_page(). The development of this patch was aided by the following

Re: [PATCH] crypto: picoxcell - convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-09 Thread Herbert Xu
On Thu, Feb 04, 2021 at 03:24:13PM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/crypto/picoxcell_crypto.c:1201:8-16: WARNING: use scnprintf > or sprintf. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/crypto/picoxcell_crypto.c |

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-09 Thread Manivannan Sadhasivam
On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > This may be a stupid suggestion, but would the integration look less a > > backdoor if it would have been named "mhi_wwan" and it exposed already > > all the AT+DIAG+QMI

Re: [PATCH Resend] mailbox: arm_mhuv2: Fix sparse warnings

2021-02-09 Thread Jassi Brar
On Tue, Feb 9, 2021 at 5:18 AM Viresh Kumar wrote: > > This patch fixes a bunch of sparse warnings in the newly added arm_mhuv2 > driver. > > drivers/mailbox/arm_mhuv2.c:506:24: warning: incorrect type in argument 1 > (different address spaces) > drivers/mailbox/arm_mhuv2.c:506:24:expected vo

[PATCH v2] perf probe: fix kretprobe issue caused by GCC bug

2021-02-09 Thread Jianlin Lv
Perf failed to add kretprobe event with debuginfo of vmlinux which is compiled by gcc with -fpatchable-function-entry option enabled. The same issue with kernel module. Issue: # perf probe -v 'kernel_clone%return $retval' .. Writing event: r:probe/kernel_clone__return _text+599624 $ret

Re: [PATCH Resend] mailbox: arm_mhuv2: Fix sparse warnings

2021-02-09 Thread Viresh Kumar
On 10-02-21, 00:25, Jassi Brar wrote: > Yup any bug fix should be sent in rc. But this, imo, lies on the > boundary of code and cosmetic issues, so I practiced discretion to > keep it for the next pull request lest I won't have much to send ;) Fair enough, would have been better though if you coul

Re: [GIT PULL] memblock: remove return value of memblock_free_all()

2021-02-09 Thread Mike Rapoport
On Tue, Feb 09, 2021 at 05:17:30PM -0800, Linus Torvalds wrote: > On Tue, Feb 9, 2021 at 1:43 AM Mike Rapoport wrote: > > > > This a small cleanup in memblock for 5.12 merge window. > > If it's going to make Andrew's patches easier to apply during the 5.12 > timeframe, I'm happy to pull this earl

Re: [PATCH v3] printk: fix deadlock when kernel panic

2021-02-09 Thread Sergey Senozhatsky
On (21/02/10 11:48), Muchun Song wrote: > printk_safe_flush_on_panic() caused the following deadlock on our > server: > > CPU0: CPU1: > panic rcu_dump_cpu_stacks > kdump_nmi_shootdown_cpus nmi_tr

Re: [PATCH V2 1/8] mm/highmem: Lift memcpy_[to|from]_page to core

2021-02-09 Thread Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote: > From: Ira Weiny > > Working through a conversion to a call kmap_local_page() instead of > kmap() revealed many places where the pattern kmap/memcpy/kunmap > occurred. > > Eric Biggers, Matthew Wilcox, Christoph Hellwig, Dan Williams, and Al > Viro all

Re: [kbuild-all] Re: [PATCH v12 7/7] kasan: don't run tests in async mode

2021-02-09 Thread Rong Chen
ps://github.com/0day-ci/linux/commits/Vincenzo-Frascino/arm64-ARMv8-5-A-MTE-Add-async-mode-support/20210209-080907 base:59fa6a163ffabc1bf25c5e0e33899e268a96d3cc config: powerpc64-randconfig-r033-20210209 (attached as .config) compiler: powerpc-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build)

Re: [PATCH v2 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg

2021-02-09 Thread Shengjiu Wang
On Wed, Feb 10, 2021 at 6:30 AM Mark Brown wrote: > > On Tue, Feb 09, 2021 at 05:16:16PM +0800, Shengjiu Wang wrote: > > On Mon, Feb 8, 2021 at 7:53 PM Mark Brown wrote: > > > > hw_params() can be called multiple times and there's no need for it to > > > be balanced with hw_free(), I'd move this

Re: [PATCH v2 6/7] ASoC: codec: lpass-tx-macro: add support for lpass tx macro

2021-02-09 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/ASoC-codecs-add-support-for-LPASS-Codec-TX-and-RX-macros/20210209-084643 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: ia64-

Re: [PATCH V2 2/8] mm/highmem: Convert memcpy_[to|from]_page() to kmap_local_page()

2021-02-09 Thread Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote: > From: Ira Weiny > > kmap_local_page() is more efficient and is well suited for these calls. > Convert the kmap() to kmap_local_page() > > Cc: Andrew Morton > Cc: Christoph Hellwig > Signed-off-by: Ira Weiny Looks good. Reviewed-by: Chaitanya Kulkar

Re: [PATCH v2] mm: cma: support sysfs

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 01:13:17PM -0800, Minchan Kim wrote: > On Tue, Feb 09, 2021 at 12:11:20PM -0800, John Hubbard wrote: > > On 2/9/21 9:49 AM, Greg KH wrote: > > > > > That's fine if you want to add it to the parent. If so, then the > > > > > kobject controls the lifetime of the structure, no

Re: [PATCH v2 3/3] crypto: hisilicon/sec - fixes shash test error

2021-02-09 Thread Herbert Xu
On Sun, Feb 07, 2021 at 06:04:40PM +0800, Longfang Liu wrote: > If the header file "crypto/internal/hash.h" not > added, the allocation of crypto_tfm will fail when > the shash algorithm calculates the hash > through the software. > > Signed-off-by: Longfang Liu > --- > drivers/crypto/hisilicon/

[PATCH 0/3] Use clocks property in a device node

2021-02-09 Thread Sameer Pujar
It is recommended to not specifiy clocks property in an endpoint subnode. This series moves clocks to device node. However after moving the clocks to device node, the audio playback or capture fails. The specified clock is not actually getting enabled and hence the failure is seen. There seems to

[PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-02-09 Thread Sameer Pujar
If "clocks = <&xxx>" is specified from the CPU or Codec component device node, the clock is not getting enabled. Thus audio playback or capture fails. Fix this by populating "simple_dai->clk" field when clocks property is specified from device node as well. Also tidy up by re-organising conditiona

Re: [PATCH v2] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 03:17:00PM -0700, Dave Jiang wrote: > When the auxiliary device code is built into the kernel, it can be executed > before the auxiliary bus is registered. This causes bus->p to be not > allocated and triggers a NULL pointer dereference when the auxiliary bus > device gets a

[PATCH 2/3] Revert "ASoC: audio-graph-card: Add clocks property to endpoint node"

2021-02-09 Thread Sameer Pujar
An endpoint is not a device and it is recommended to use clocks property in the device node. Hence reverting the original change. Fixes: 531e5b7abbde ("ASoC: audio-graph-card: Add clocks property to endpoint node") Suggested-by: Rob Herring Cc: Kuninori Morimoto Signed-off-by: Sameer Pujar ---

[PATCH 3/3] arm64: tegra: Move clocks from RT5658 endpoint to device node

2021-02-09 Thread Sameer Pujar
An endpoint is not a device and it is recommended to use clocks property in device node. RT5658 Codec binding already specifies the usage of clocks property. Thus move the clocks from endpoint to device node. Fixes: 5b4f6323096a ("arm64: tegra: Audio graph sound card for Jetson AGX Xavier") Sugge

[PATCH] tee: optee: add invoke_fn tracepoints

2021-02-09 Thread Jisheng Zhang
Add tracepoints to retrieve information about the invoke_fn. This would help to measure how many invoke_fn are triggered and how long it takes to complete one invoke_fn call. Signed-off-by: Jisheng Zhang --- Since v1: - add BUILD_BUG_ON() macro usage to make sure that the size of what is being

Re: [PATCH] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 12:01:06PM -0800, Dan Williams wrote: > On Tue, Feb 9, 2021 at 11:16 AM Greg KH wrote: > [..] > > > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c > > > index 8336535f1e11..53f93a506626 100644 > > > --- a/drivers/base/auxiliary.c > > > +++ b/drivers/base/a

Re: [PATCH V2 3/8] mm/highmem: Introduce memcpy_page(), memmove_page(), and memset_page()

2021-02-09 Thread Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote: > From: Ira Weiny > > 3 more common kmap patterns are kmap/memcpy/kunmap, kmap/memmove/kunmap. > and kmap/memset/kunmap. > > Add helper functions for those patterns which use kmap_local_page(). > > Cc: Andrew Morton > Cc: Christoph Hellwig > Signed-off

Re: [PATCH v2 16/24] net: stmmac: Use optional reset control API to work with stmmaceth

2021-02-09 Thread Jisheng Zhang
Hi, On Mon, 8 Feb 2021 16:56:00 +0300 Serge Semin wrote: > > Since commit bb3222f71b57 ("net: stmmac: platform: use optional clk/reset > get APIs") a manual implementation of the optional device reset control > functionality has been replaced with using the > devm_reset_control_get_optional() m

Re: [PATCH RFC 0/6] Add roundrobin raid1 read policy

2021-02-09 Thread Anand Jain
On 10/02/2021 04:30, Michal Rostecki wrote: From: Michal Rostecki This patch series adds a new raid1 read policy - roundrobin. For each request, it selects the mirror which has lower load than queue depth. Load is defined as the number of inflight requests + a penalty value (if the scheduled r

Re: [PATCH 00/20] Rid W=1 warnings in Crypto

2021-02-09 Thread Herbert Xu
On Thu, Feb 04, 2021 at 11:09:40AM +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > This is set 1 of 2 sets required to fully clean Crypto. > > Lee Jones (20): >

[PATCH] mm/hugetlb: use some helper functions to cleanup code

2021-02-09 Thread Miaohe Lin
We could use pages_per_huge_page to get the number of pages per hugepage, use get_hstate_idx to calculate hstate index, and use hstate_is_gigantic to check if a hstate is gigantic to make code more succinct. Signed-off-by: Miaohe Lin --- fs/hugetlbfs/inode.c | 2 +- mm/hugetlb.c | 6 +++-

Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-09 Thread Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote: > From: Ira Weiny > > Add VM_BUG_ON bounds checks to ensure the newly lifted and created page > memory operations do not result in corrupted data in neighbor pages and > to make them consistent with zero_user().[1][2] > I did not understand this, in my t

[PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-02-09 Thread huangxuesen
From: huangxuesen bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets encapsulation. But that is not appropriate when pushing Ethernet header. Add an option to further specify encap L2 type and set the inner_protocol as ETH_P_TEB. Suggested-by: Willem de Bruijn Signed-off-

Re: [PATCH v7 3/6] mfd: bd9576: Add IRQ support

2021-02-09 Thread Matti Vaittinen
Hello Lee, I appreciate your thorough reviews :) Thanks. On Tue, 2021-02-09 at 15:25 +, Lee Jones wrote: > On Fri, 22 Jan 2021, Matti Vaittinen wrote: > > > BD9573 and BD9576 support set of "protection" interrupts for > > "fatal" > > issues. Those lead to SOC reset as PMIC shuts the power ou

RE: How can a userspace program tell if the system supports the ACPI S4 state (Suspend-to-Disk)?

2021-02-09 Thread Dexuan Cui
> From: James Morse > Sent: Tuesday, February 9, 2021 10:15 AM > To: Dexuan Cui > Cc: Rafael J. Wysocki ; linux-a...@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-hyp...@vger.kernel.org; Michael Kelley > ; Leandro Pereira > Subject: Re: How can a userspace program tell if the system sup

Re: [patch V2 11/13] softirq: Move __ARCH_HAS_DO_SOFTIRQ to Kconfig

2021-02-09 Thread Kees Cook
On Wed, Feb 10, 2021 at 12:40:52AM +0100, Thomas Gleixner wrote: > To prepare for inlining do_softirq_own_stack() replace > __ARCH_HAS_DO_SOFTIRQ with a Kconfig switch and select it in the affected > architectures. > > This allows in the next step to move the function prototype and the inline > st

<    1   2   3   4   5   6   7   8   9   10   >