Re: [PATCH v4 00/10] Enable root to update the blacklist keyring

2021-01-28 Thread Mickaël Salaün
I noticed that commits in your branch are not up to date with latest Jarkoo reviews on my patches (see changes since v2). There is no conflict if you replace conflicting patches from your branch by patches from this series. Could you replace your duplicate commits with this patch series? On 28/01

Re: [PATCH 3/3] Adding device_dma_parameters->offset_preserve_mask to NVMe driver.

2021-01-28 Thread Robin Murphy
On 2021-01-28 00:38, Jianxiong Gao wrote: NVMe driver relies on the address offset to function properly. This patch adds the offset preserve mask to NVMe driver when mapping via dma_map_sg_attrs and unmapping via nvme_unmap_sg. The mask depends on the page size defined by CC.MPS register of NVMe

[PATCH 1/2] speakup ABI: Advertise synth parameters for all synths

2021-01-28 Thread Samuel Thibault
The parameters were advertised for the "soft" synth, but they are available for all synths. Signed-off-by: Samuel Thibault --- Documentation/ABI/stable/sysfs-driver-speakup | 30 +-- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/Documentation/ABI/stable/sysfs-dr

[PATCH 2/2] speakup: Make dectlk flush timeout configurable

2021-01-28 Thread Samuel Thibault
In case the serial port or cable got faulty, we may not be getting acknowledgements any more. The driver then currently waits for 4s to avoid jamming the device. This makes this delay configurable. Signed-off-by: Samuel Thibault --- Documentation/ABI/stable/sysfs-driver-speakup | 7 +++ dr

[PATCH 04/20] ata: libata-sata: Fix function names in header comments

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/libata-sata.c:1085: warning: expecting prototype for port_alloc(). Prototype was for ata_sas_port_alloc() instead drivers/ata/libata-sata.c:1140: warning: expecting prototype for ata_port_stop(). Prototype was for ata_sas_port_stop()

[PATCH 02/20] ata: libata-transport: Fix some potential doc-rot issues

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/libata-transport.c:258: warning: Function parameter or member 'ap' not described in 'ata_tport_delete' drivers/ata/libata-transport.c:258: warning: Excess function parameter 'port' description in 'ata_tport_delete' drivers/ata/libat

[PATCH 00/20] [Set 1] Rid W=1 warnings from ATA

2021-01-28 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is set 1 out of 3 sets required. Lee Jones (20): ata: ahci_dm816: Ignore -Woverride-init ata: libata-transport: Fix some potential doc-rot

[PATCH 03/20] ata: ahci_platform: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In

Re: [PATCH net-next 2/8] net: dsa: tag_ksz: add tag handling for Microchip LAN937x

2021-01-28 Thread Andrew Lunn
On Thu, Jan 28, 2021 at 12:11:06PM +0530, Prasanna Vengateshan wrote: > The Microchip LAN937X switches have a tagging protocol which is > very similar to KSZ tagging. So that the implementation is added to > tag_ksz.c and reused common APIs > > Signed-off-by: Prasanna Vengateshan > --- > include

[PATCH 05/20] ata: libata-pmp: Fix misspelling of 'val'

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/libata-pmp.c:76: warning: Function parameter or member 'val' not described in 'sata_pmp_write' drivers/ata/libata-pmp.c:76: warning: Excess function parameter 'r_val' description in 'sata_pmp_write' Cc: Jens Axboe Cc: Tejun Heo Cc

[PATCH 08/20] ata: pata_artop: Fix a function name and parameter description

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/pata_artop.c:278: warning: expecting prototype for artop_6210_qc_defer(). Prototype was for artop6210_qc_defer() instead drivers/ata/pata_artop.c:359: warning: Function parameter or member 'id' not described in 'artop_init_one' driv

[PATCH 09/20] ata: acard-ahci: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In

[PATCH 07/20] ata: pata_ali: Repair some misnamed kernel-doc issues

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter' drivers/ata/pata_ali.c:119: warning: Excess function parameter 'ap' description in 'ali_20_filter' drivers/ata/pata_ali.c:322: warning: Fu

[PATCH 11/20] ata: pata_amd: Remove superfluous, add missing and fix broken params

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/pata_amd.c:179: warning: Excess function parameter 'adev' description in 'amd_fifo_setup' drivers/ata/pata_amd.c:331: warning: Function parameter or member 'link' not described in 'nv_pre_reset' drivers/ata/pata_amd.c:331: warning:

[PATCH 06/20] ata: ahci_mtk: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In

[PATCH 12/20] ata: pata_hpt366: Provide missing description for 'hpt366_filter()'s 'mask' param

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/pata_hpt366.c:200: warning: Function parameter or member 'mask' not described in 'hpt366_filter' Cc: Jens Axboe Cc: Andre Hedrick Cc: linux-...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_hpt366.c | 1 + 1 file c

[PATCH 10/20] ata: ahci_ceva: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In

[PATCH 16/20] ata: ahci_brcm: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In

[PATCH 18/20] ata: sata_mv: Fix worthy headers and demote others

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'ap' not described in 'mv_start_edma' drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'port_mmio' not described in 'mv_start_edma' drivers/ata/sata_mv.c:1162: w

[PATCH 13/20] ata: pata_hpt37x: Fix some function misnaming and missing param issues

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/pata_hpt37x.c:283: warning: Function parameter or member 'mask' not described in 'hpt370_filter' drivers/ata/pata_hpt37x.c:301: warning: Function parameter or member 'mask' not described in 'hpt370a_filter' drivers/ata/pata_hpt37x.c

Re: [PATCH v2] kretprobe: avoid re-registration of the same kretprobe earlier

2021-01-28 Thread Steven Rostedt
Masami, Care to review? Thanks! -- Steve On Thu, 28 Jan 2021 20:44:27 +0800 Wang ShaoBo wrote: > Our system encountered a re-init error when re-registering same kretprobe, > where the kretprobe_instance in rp->free_instances is illegally accessed > after re-init. > > Implementation to avo

Re: [PATCH v14 00/13] Introduce support for guest CET feature

2021-01-28 Thread Paolo Bonzini
On 28/01/21 19:04, Sean Christopherson wrote: On Thu, Jan 28, 2021, Paolo Bonzini wrote: On 06/11/20 02:16, Yang Weijiang wrote: Control-flow Enforcement Technology (CET) provides protection against Return/Jump-Oriented Programming (ROP/JOP) attack. There're two CET sub-features: Shadow Stack (

Re: [next] mm/nommu.c:1671:6: error: conflicting types for 'filemap_map_pages'

2021-01-28 Thread Will Deacon
On Thu, Jan 28, 2021 at 04:26:09PM +0100, Geert Uytterhoeven wrote: > Hi Naresh, > > On Thu, Jan 28, 2021 at 3:25 PM Naresh Kamboju > wrote: > > arm, sh and riscv architecture build failed on today's Linux next tag > > 20210128. > > > > FYI, > >

Re: [PATCH v14 00/13] Introduce support for guest CET feature

2021-01-28 Thread Sean Christopherson
On Thu, Jan 28, 2021, Paolo Bonzini wrote: > On 06/11/20 02:16, Yang Weijiang wrote: > > Control-flow Enforcement Technology (CET) provides protection against > > Return/Jump-Oriented Programming (ROP/JOP) attack. There're two CET > > sub-features: Shadow Stack (SHSTK) and Indirect Branch Tracking

Re: [workqueue] d5bff968ea: WARNING:at_kernel/workqueue.c:#process_one_work

2021-01-28 Thread Paul E. McKenney
On Thu, Jan 28, 2021 at 05:09:05PM +0800, Hillf Danton wrote: > On Thu, 28 Jan 2021 15:52:40 +0800 Xing Zhengjun wrote: [ . . . ] > >I test the patch 4 times, no warning appears in the kernel log. > > Thank you so much Zhengjun! > > And the overall brain dump so far is > > 1/ before and after

Re: [PATCH v14 11/13] KVM: VMX: Pass through CET MSRs to the guest when supported

2021-01-28 Thread Paolo Bonzini
On 28/01/21 18:54, Paolo Bonzini wrote: On 06/11/20 02:16, Yang Weijiang wrote: Pass through all CET MSRs when the associated CET component (kernel vs. user) is enabled to improve guest performance.  All CET MSRs are context switched, either via dedicated VMCS fields or XSAVES. Co-developed-by:

Re: [PATCH 2/3] kvfree_rcu: Use __GFP_NOMEMALLOC for single-argument kvfree_rcu()

2021-01-28 Thread Uladzislau Rezki
On Wed, Jan 20, 2021 at 05:21:47PM +0100, Uladzislau Rezki (Sony) wrote: > From: "Paul E. McKenney" > > This commit applies the __GFP_NOMEMALLOC gfp flag to memory allocations > carried out by the single-argument variant of kvfree_rcu(), thus avoiding > this can-sleep code path from dipping into

[PATCH 20/20] ata: ahci: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In

[PATCH 19/20] ata: pata_ali: Supply description for 'ali_20_filter()'s 'mask' param

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter' Cc: Jens Axboe Cc: CJ Cc: Andre Hedrick Cc: Alan Cox Cc: Clear Zhang Cc: linux-...@vger.kernel.org Cc: and cc Signed-off-by: Lee Jones

[PATCH 0/2] speakup update

2021-01-28 Thread Samuel Thibault
Samuel Thibault (2): speakup ABI: Advertise synth parameters for all synths speakup: Make dectlk flush timeout configurable Documentation/ABI/stable/sysfs-driver-speakup | 37 +++ .../accessibility/speakup/speakup_dectlk.c| 11 +- drivers/accessibility/speakup/spk_type

[PATCH 14/20] ata: sata_sil24: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In

[PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In

[PATCH 15/20] ata: sata_highbank: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-28 Thread Uladzislau Rezki
On Thu, Jan 28, 2021 at 04:30:17PM +0100, Uladzislau Rezki wrote: > On Thu, Jan 28, 2021 at 04:17:01PM +0100, Michal Hocko wrote: > > On Thu 28-01-21 16:11:52, Uladzislau Rezki wrote: > > > On Mon, Jan 25, 2021 at 05:25:59PM +0100, Uladzislau Rezki wrote: > > > > On Mon, Jan 25, 2021 at 04:39:43PM

[PATCH 17/20] ata: ahci_xgene: Fix incorrect naming of 'xgene_ahci_handle_broken_edge_irq()'s 'host' param

2021-01-28 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/ata/ahci_xgene.c:564: warning: Function parameter or member 'host' not described in 'xgene_ahci_handle_broken_edge_irq' drivers/ata/ahci_xgene.c:564: warning: Excess function parameter 'ata_host' description in 'xgene_ahci_handle_broken_

[PATCH 03/13] module: unexport find_module and module_mutex

2021-01-28 Thread Christoph Hellwig
find_module is not used by modular code any more, and random driver code has no business calling it to start with. Signed-off-by: Christoph Hellwig --- kernel/module.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 4bf30e4b3eaaa1..981302f616b411 1006

[PATCH 01/13] powerpc/powernv: remove get_cxl_module

2021-01-28 Thread Christoph Hellwig
The static inline get_cxl_module function is entirely unused since commit 8bf6b91a5125a ("Revert "powerpc/powernv: Add support for the cxl kernel api on the real phb"), so remove it. Signed-off-by: Christoph Hellwig Reviewed-by: Andrew Donnellan --- arch/powerpc/platforms/powernv/pci-cxl.c | 22

module loader dead code removal and cleanups v2

2021-01-28 Thread Christoph Hellwig
Hi all, this series removes support for long term unused export types and cleans up various loose ends in the module loader. Changes since v1: - move struct symsearch to module.c - rework drm to not call find_module at all - llow RCU-sched locking for find_module - keep find_module as a publi

[PATCH 04/13] module: use RCU to synchronize find_module

2021-01-28 Thread Christoph Hellwig
Allow for a RCU-sched critical section around find_module, following the lower level find_module_all helper, and switch the two callers outside of module.c to use such a RCU-sched critical section instead of module_mutex. Signed-off-by: Christoph Hellwig --- include/linux/module.h | 2 +- k

Re: [PATCH 2/3] Add swiotlb offset preserving mapping when dma_dma_parameters->page_offset_mask is non zero.

2021-01-28 Thread Christoph Hellwig
On Wed, Jan 27, 2021 at 04:38:28PM -0800, Jianxiong Gao wrote: > For devices that need to preserve address offset on mapping through > swiotlb, this patch adds offset preserving based on page_offset_mask > and keeps the offset if the mask is non zero. This is needed for > device drivers like NVMe.

Re: [PATCH 1/3] Adding page_offset_mask to device_dma_parameters

2021-01-28 Thread Christoph Hellwig
On Thu, Jan 28, 2021 at 05:27:25PM +, Robin Murphy wrote: > On 2021-01-28 00:38, Jianxiong Gao wrote: >> Some devices rely on the address offset in a page to function >> correctly (NVMe driver as an example). These devices may use >> a different page size than the Linux kernel. The address offs

[PATCH 12/13] module: remove EXPORT_SYMBOL_GPL_FUTURE

2021-01-28 Thread Christoph Hellwig
As far as I can tell this has never been used at all, and certainly not any time recently. Signed-off-by: Christoph Hellwig --- arch/x86/tools/relocs.c | 4 ++-- include/asm-generic/vmlinux.lds.h | 14 -- include/linux/export.h| 1 - include/linux/module.h

[PATCH 10/13] module: pass struct find_symbol_args to find_symbol

2021-01-28 Thread Christoph Hellwig
Simplify the calling convention by passing the find_symbol_args structure to find_symbol instead of initializing it inside the function. Signed-off-by: Christoph Hellwig --- kernel/module.c | 113 ++-- 1 file changed, 52 insertions(+), 61 deletions(-)

[PATCH 11/13] module: move struct symsearch to module.c

2021-01-28 Thread Christoph Hellwig
struct symsearch is only used inside of module.h, so move the definition out of module.h. Signed-off-by: Christoph Hellwig --- include/linux/module.h | 11 --- kernel/module.c| 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/linux/module.h

[PATCH 07/13] module: mark module_mutex static

2021-01-28 Thread Christoph Hellwig
Except for two lockdep asserts module_mutex is only used in module.c. Remove the two asserts given that the functions they are in are not exported and just called from the module code, and mark module_mutex static. Signed-off-by: Christoph Hellwig --- include/linux/module.h | 2 -- kernel/module

Re: [PATCH] KVM: x86: Allow guests to see MSR_IA32_TSX_CTRL even if tsx=off

2021-01-28 Thread Sean Christopherson
On Thu, Jan 28, 2021, Paolo Bonzini wrote: > On 28/01/21 18:56, Sean Christopherson wrote: > > On Thu, Jan 28, 2021, Paolo Bonzini wrote: > > > - vmx->guest_uret_msrs[j].mask = > > > ~(u64)TSX_CTRL_CPUID_CLEAR; > > > + if (boot_cpu_has(X86_FEATURE_RTM)) > > > +

Re: [GIT PULL for v5.11-rc6] media fixes

2021-01-28 Thread pr-tracker-bot
The pull request you sent on Thu, 28 Jan 2021 11:27:38 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media > tags/media/v5.11-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fc856f1df788dc9ad13f154167ae0b442e167950 Thank you! -- Deet-doot-do

Re: [PATCH 1/1] dma-buf: heaps: Map system heap pages as managed by linux vm

2021-01-28 Thread Minchan Kim
On Thu, Jan 28, 2021 at 09:52:59AM -0800, Suren Baghdasaryan wrote: > On Thu, Jan 28, 2021 at 1:13 AM Christoph Hellwig wrote: > > > > On Thu, Jan 28, 2021 at 12:38:17AM -0800, Suren Baghdasaryan wrote: > > > Currently system heap maps its buffers with VM_PFNMAP flag using > > > remap_pfn_range. T

Re: [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init

2021-01-28 Thread Christoph Hellwig
On Thu, Jan 28, 2021 at 06:02:20PM +, Lee Jones wrote: > Some ATA drivers use the SCSI host template, a series of interwoven > macros, to aid with initialisation. Some of these macros conflict, > resulting in the over-writing of previously set values. Please just disable this warning globally

[PATCH] x86/debug: 'Fix' ptrace dr6 output

2021-01-28 Thread Peter Zijlstra
Tom reported that one of the GDB test-cases failed, and Boris bisected it to commit: d53d9bc0cf78 ("x86/debug: Change thread.debugreg6 to thread.virtual_dr6") The debugging session led us to commit: 6c0aca288e72 ("x86: Ignore trap bits on single step exceptions") Which describes a nice Wi

Re: [GIT PULL] HID fixes

2021-01-28 Thread pr-tracker-bot
The pull request you sent on Thu, 28 Jan 2021 09:38:19 +0100 (CET): > git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/25221c99c593bf888bd8faa67ca25b40f046e9f8 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] asm-generic/ia64 fixes, mark as orphaned

2021-01-28 Thread pr-tracker-bot
The pull request you sent on Thu, 28 Jan 2021 16:35:55 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git > tags/asm-generic-fixes-v5.11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/228345bf98cd78f91d007478a51f9a471489e44a Thank you! -- D

Re: kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")

2021-01-28 Thread Peter Zijlstra
On Thu, Jan 28, 2021 at 06:45:56PM +0200, Nikolay Borisov wrote: > it would be placed on the __fentry__ (and not endbr64) hence it works. > So perhaps a workaround outside of bpf could essentially detect this > scenario and adjust the probe to be on the __fentry__ and not preceding > instruction if

[PATCH 2/2] dmabuf: Add dmabuf inode no to fdinfo

2021-01-28 Thread Kalesh Singh
The dmabuf inode number allows userspace to uniquely identify the buffer and avoids a dependency on /proc//fd/* when accounting per-process DMA buffer sizes. Signed-off-by: Kalesh Singh --- drivers/dma-buf/dma-buf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma-buf/dma-buf.c b/

Re: [PATCH v14 00/13] Introduce support for guest CET feature

2021-01-28 Thread Sean Christopherson
On Thu, Jan 28, 2021, Paolo Bonzini wrote: > On 28/01/21 19:04, Sean Christopherson wrote: > > On Thu, Jan 28, 2021, Paolo Bonzini wrote: > > > On 06/11/20 02:16, Yang Weijiang wrote: > > > > Control-flow Enforcement Technology (CET) provides protection against > > > > Return/Jump-Oriented Programm

[PATCH 1/2] procfs: Allow reading fdinfo with PTRACE_MODE_READ

2021-01-28 Thread Kalesh Singh
Since fdinfo doesn't permit reading process memory and manipulating process state, allow accessing fdinfo under PTRACE_MODE_READ_FSCRED. Suggested-by: Jann Horn Signed-off-by: Kalesh Singh --- fs/proc/base.c | 4 ++-- fs/proc/fd.c | 15 ++- 2 files changed, 16 insertions(+), 3 de

[PATCH v2 1/2] mm/hugetlb: grab head page refcount once for group of subpages

2021-01-28 Thread Joao Martins
follow_hugetlb_page() once it locks the pmd/pud, checks all its N subpages in a huge page and grabs a reference for each one. Similar to gup-fast, have follow_hugetlb_page() grab the head page refcount only after counting all its subpages that are part of the just faulted huge page. Consequently w

[PATCH v2 2/2] mm/hugetlb: refactor subpage recording

2021-01-28 Thread Joao Martins
For a given hugepage backing a VA, there's a rather ineficient loop which is solely responsible for storing subpages in GUP @pages/@vmas array. For each subpage we check whether it's within range or size of @pages and keep increment @pfn_offset and a couple other variables per subpage iteration. S

Re: [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init

2021-01-28 Thread Lee Jones
On Thu, 28 Jan 2021, Christoph Hellwig wrote: > On Thu, Jan 28, 2021 at 06:02:20PM +, Lee Jones wrote: > > Some ATA drivers use the SCSI host template, a series of interwoven > > macros, to aid with initialisation. Some of these macros conflict, > > resulting in the over-writing of previously

[BUG] incorrect scaling_max_freq with intel_pstate after offline/online

2021-01-28 Thread Guillaume Morin
Hello Rafael, I am chasing an issue on 5.4.x+ where scaling_max_freq is decreased to the first entry in the _PSS table after doing an offline/online of the cpu (to be 100% clear: scaling_max_freq is fine right after booting). During intel_pstate_cpu_init(), acpi_processor_get_platform_limit() is

[PATCH v2 0/2] mm/hugetlb: follow_hugetlb_page() improvements

2021-01-28 Thread Joao Martins
Hey, While looking at ZONE_DEVICE struct page reuse particularly the last patch[0], I found two possible improvements for follow_hugetlb_page() which is solely used for get_user_pages()/pin_user_pages(). The first patch batches page refcount updates while the second tidies up storing the subpages

Re: [PATCH -next] mm/nommu: Fix return type of filemap_map_pages()

2021-01-28 Thread Will Deacon
On Thu, 28 Jan 2021 11:06:26 +0100, Geert Uytterhoeven wrote: > If CONFIG_MMU is not set (e.g. m68k/m5272c3_defconfig): > > mm/nommu.c:1671:6: error: conflicting types for ‘filemap_map_pages’ > 1671 | void filemap_map_pages(struct vm_fault *vmf, > | ^ > In

Re: [PATCH v3 7/7] gpiod: ep93xx: refactor base IRQ number

2021-01-28 Thread Alexander Sverdlin
Hi! On Thu, 2021-01-28 at 15:21 +0300, Nikita Shubin wrote: > - use predefined constants instead of plain numbers > - use provided bank IRQ number instead of defined constant >   for port F > > Signed-off-by: Nikita Shubin Acked-by: Alexander Sverdlin > --- >  drivers/gpio/gpio-ep93xx.c | 12

Re: [PATCH v3] lkdtm: fix memory copy size for WRITE_KERN

2021-01-28 Thread Nick Desaulniers
On Wed, Jan 27, 2021 at 10:58 PM Candle Sun wrote: > > From: Candle Sun > > Though do_overwritten() follows do_nothing() in source code, the final > memory address order is determined by the compiler. We can't always > assume address of do_overwritten() is bigger than do_nothing(). At least > the

[PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-01-28 Thread Valentin Schneider
During load-balance, groups classified as group_misfit_task are filtered out if they do not pass group_smaller_max_cpu_capacity(, ); which itself employs fits_capacity() to compare the sgc->max_capacity of both groups. Due to the underlying margin, fits_capacity(X, 1024) will return false for

[PATCH 1/8] sched/fair: Clean up active balance nr_balance_failed trickery

2021-01-28 Thread Valentin Schneider
When triggering an active load balance, sd->nr_balance_failed is set to such a value that any further can_migrate_task() using said sd will ignore the output of task_hot(). This behaviour makes sense, as active load balance intentionally preempts a rq's running task to migrate it right away, but t

[PATCH 4/8] sched/fair: Use dst_cpu's capacity rather than group {min, max} capacity

2021-01-28 Thread Valentin Schneider
Comparing capacity extrema of local and source sched_group's doesn't make much sense when at the day of the day the imbalance will be pulled by a known env->dst_cpu, whose capacity can be anywhere within the local group's capacity extrema. Replace group_smaller_{min, max}_cpu_capacity() with compa

[PATCH 2/8] sched/fair: Add more sched_asym_cpucapacity static branch checks

2021-01-28 Thread Valentin Schneider
Rik noted a while back that a handful of sd->flags & SD_ASYM_CPUCAPACITY & family in the CFS load-balancer code aren't guarded by the sched_asym_cpucapacity static branch. The load-balancer is already doing a humongous amount of work, but turning those checks into NOPs for those who don't need

[PATCH 0/8] sched/fair: misfit task load-balance tweaks

2021-01-28 Thread Valentin Schneider
Hi folks, Here is this year's series of misfit changes. On the menu: o Patch 1 is an independent active balance cleanup o Patch 2 adds some more sched_asym_cpucapacity static branches o Patch 3 introduces yet another margin for capacity to capacity comparisons o Patches 4-6 build on top of patc

[PATCH v5 net-next 04/18] doc: marvell: add PPv2.3 description to marvell-pp2.txt

2021-01-28 Thread stefanc
From: Stefan Chulski Signed-off-by: Stefan Chulski --- Documentation/devicetree/bindings/net/marvell-pp2.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/marvell-pp2.txt b/Documentation/devicetree/bindings/net/marvell-pp2.txt index

[PATCH v5 net-next 06/18] net: mvpp2: always compare hw-version vs MVPP21

2021-01-28 Thread stefanc
From: Stefan Chulski Currently we have PP2v1 and PP2v2 hw-versions, with some different handlers depending upon condition hw_version = MVPP21/MVPP22. In a future there will be also PP2v3. Let's use now the generic "if equal/notEqual MVPP21" for all cases instead of "if MVPP22". This patch does n

[PATCH v5 net-next 17/18] net: mvpp2: limit minimum ring size to 1024 descriptors

2021-01-28 Thread stefanc
From: Stefan Chulski To support Flow Control ring size should be at least 1024 descriptors. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/eth

Re: [PATCH] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem

2021-01-28 Thread Pavel Machek
Hi! > Motorola is using a custom TS 27.010 based serial port line discipline > for various devices on the modem. These devices can be accessed on > dedicated channels using Linux kernel serdev-ngsm driver. > > For the GNSS on these devices, we need to kick the GNSS device at a > desired rate. Oth

Re: [PATCH v3 3/7] gpio: gpio-ep93xx: Fix wrong irq numbers in port F

2021-01-28 Thread Alexander Sverdlin
Hi! On Thu, 2021-01-28 at 15:21 +0300, Nikita Shubin wrote: > Port F irq's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE. > > So we need to specify girq->first otherwise: > > "If device tree is used, then first_irq will be 0 and > irqs get mapped dynamically on the fly" > > And that's n

[PATCH v5 net-next 09/18] net: mvpp2: add FCA periodic timer configurations

2021-01-28 Thread stefanc
From: Stefan Chulski Flow Control periodic timer would be used if port in XOFF to transmit periodic XOFF frames. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 13 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 45 2 files cha

[PATCH v5 net-next 08/18] net: mvpp2: increase RXQ size to 1024 descriptors

2021-01-28 Thread stefanc
From: Stefan Chulski RXQ size increased to support Firmware Flow Control. Minimum depletion thresholds to support FC is 1024 buffers. Default set to 1024 descriptors and maximum size to 2048. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 4 ++-- 1 file changed,

[PATCH v5 net-next 18/18] net: mvpp2: add TX FC firmware check

2021-01-28 Thread stefanc
From: Stefan Chulski Patch check that TX FC firmware is running in CM3. If not, global TX FC would be disabled. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 42 2 files changed,

[PATCH v5 net-next 16/18] net: mvpp2: set 802.3x GoP Flow Control mode

2021-01-28 Thread stefanc
From: Stefan Chulski This patch fix GMAC TX flow control autoneg. Flow control autoneg wrongly were disabled with enabled TX flow control. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH 6/8] sched/fair: Filter out locally-unsolvable misfit imbalances

2021-01-28 Thread Valentin Schneider
Consider the following (hypothetical) asymmetric CPU capacity topology, with some amount of capacity pressure (RT | DL | IRQ | thermal): DIE [ ] MC [][] 0 1 2 3 | CPU | capacity_orig | capacity | |-+---+--| | 0 | 870 |

[PATCH v5 net-next 15/18] net: mvpp2: add PPv23 RX FIFO flow control

2021-01-28 Thread stefanc
From: Stefan Chulski New FIFO flow control feature were added in PPv23. PPv2 FIFO polled by HW and trigger pause frame if FIFO fill level is below threshold. FIFO HW flow control enabled with CM3 RXQ&BM flow control with ethtool. Current FIFO thresholds is: 9KB for port with maximum speed 10Gb/s

[PATCH 7/8] sched/fair: Attempt misfit active balance when migration_type != migrate_misfit

2021-01-28 Thread Valentin Schneider
Consider a 4-CPU big.LITTLE system with CPUs 0-1 as LITTLEs and CPUs 2-3 as bigs. The resulting sched_domain hierarchy is: DIE [ ] MC [][] 0 1 2 3 When running a multithreaded CPU-bound workload (i.e. 1 hog per CPU), the expected behaviour is to have the about-to-i

[PATCH 8/8] sched/fair: Relax task_hot() for misfit tasks

2021-01-28 Thread Valentin Schneider
Misfit tasks can and will be preempted by the stopper to migrate them over to a higher-capacity CPU. However, when runnable but not current misfit tasks are scanned by the load balancer (i.e. detach_tasks()), the task_hot() ratelimiting logic may prevent us from enqueuing said task onto a higher-ca

[PATCH v5 net-next 12/18] net: mvpp2: add RXQ flow control configurations

2021-01-28 Thread stefanc
From: Stefan Chulski This patch add RXQ flow control configurations. Patch do not enable flow control itself, flow control disabled by default. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 35 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 114

[PATCH v5 net-next 14/18] net: mvpp2: add BM protection underrun feature support

2021-01-28 Thread stefanc
From: Stefan Chulski Feature double size of BPPI by decreasing number of pools from 16 to 8. Increasing of BPPI size protect BM drop from BPPI underrun. Underrun could occurred due to stress on DDR and as result slow buffer transition from BPPE to BPPI. New BPPI threshold recommended by spec is:

[PATCH v5 net-next 13/18] net: mvpp2: add ethtool flow control configuration support

2021-01-28 Thread stefanc
From: Stefan Chulski This patch add ethtool flow control configuration support. Tx flow control retrieved correctly by ethtool get function. FW per port ethtool configuration capability added. Patch also takes care about mtu change procedure, if PPv2 switch BM pools during mtu change. Signed-o

[PATCH 5/8] sched/fair: Make check_misfit_status() only compare dynamic capacities

2021-01-28 Thread Valentin Schneider
check_misfit_status() checks for both capacity pressure & available CPUs with higher capacity. Now that we have a sane(ish) capacity comparison margin which is used throughout load-balance, this can be condensed into a single check: capacity_greater(, ); This has the added benefit of returning

Re: [PATCH v3 6/7] gpio: ep93xx: refactor ep93xx_gpio_add_bank

2021-01-28 Thread Alexander Sverdlin
On Thu, 2021-01-28 at 15:21 +0300, Nikita Shubin wrote: > - replace plain numbers with girq->num_parents in devm_kcalloc > - replace plain numbers with girq->num_parents for port F > - refactor i - 1 to i + 1 to make loop more readable > - combine getting IRQ's loop and setting handler's into singl

[PATCH v5 net-next 11/18] net: mvpp2: enable global flow control

2021-01-28 Thread stefanc
From: Stefan Chulski This patch enables global flow control in FW and in the phylink validate mask. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 13 ++--- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 30 +++- 2 files changed, 38 i

[PATCH v5 net-next 10/18] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-01-28 Thread stefanc
From: Stefan Chulski The firmware needs to monitor the RX Non-occupied descriptor bits for flow control to move to XOFF mode. These bits need to be unmasked to be functional, but they will not raise interrupts as we leave the RX exception summary bit in MVPP2_ISR_RX_TX_MASK_REG clear. Signed-off

Re: [PATCH v3 4/7] gpio: ep93xx: drop to_irq binding

2021-01-28 Thread Alexander Sverdlin
Hi! On Thu, 2021-01-28 at 15:21 +0300, Nikita Shubin wrote: > As ->to_irq is redefined in gpiochip_add_irqchip, having it defined > in > driver is useless, so let's drop it. > > Signed-off-by: Nikita Shubin Acked-by: Alexander Sverdlin > --- >  drivers/gpio/gpio-ep93xx.c | 6 -- >  1 file

Re: [PATCH v4] fs/buffer.c: Revoke LRU when trying to drop buffers

2021-01-28 Thread Chris Goldsworthy
On 2021-01-28 09:08, Minchan Kim wrote: On Thu, Jan 28, 2021 at 12:28:37AM -0800, Chris Goldsworthy wrote: On 2021-01-26 18:59, Matthew Wilcox wrote: > On Tue, Jan 26, 2021 at 02:59:17PM -0800, Minchan Kim wrote: > > The release buffer_head in LRU is great improvement for migration > > point of

Re: [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus

2021-01-28 Thread Willem de Bruijn
On Thu, Jan 28, 2021 at 12:15 PM Colin King wrote: > > From: Colin Ian King > > The variable rtstatu is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value

[patch 3/3] nohz: tick_nohz_kick_task: only IPI if remote task is running

2021-01-28 Thread Marcelo Tosatti
If the task is not running, run_posix_cpu_timers has nothing to elapsed, so spare IPI in that case. Suggested-by: Peter Zijlstra Signed-off-by: Marcelo Tosatti Index: linux-2.6/kernel/sched/core.c === --- linux-2.6.orig/kernel/sche

[patch 1/3] nohz: only wakeup a single target cpu when kicking a task

2021-01-28 Thread Marcelo Tosatti
When adding a tick dependency to a task, its necessary to wakeup the CPU where the task resides to reevaluate tick dependencies on that CPU. However the current code wakes up all nohz_full CPUs, which is unnecessary. Switch to waking up a single CPU, by using ordering of writes to task->cpu and

[patch 2/3] nohz: change signal tick dependency to wakeup CPUs of member tasks

2021-01-28 Thread Marcelo Tosatti
Rather than waking up all nohz_full CPUs on the system, only wakeup the target CPUs of member threads of the signal. Reduces interruptions to nohz_full CPUs. Signed-off-by: Marcelo Tosatti Index: linux-2.6/kernel/time/tick-sched.c ===

[patch 0/3] nohz_full: only wakeup target CPUs when notifying new tick dependency (v4)

2021-01-28 Thread Marcelo Tosatti
When enabling per-CPU posix timers, an IPI to nohz_full CPUs might be performed (to re-read the dependencies and possibly not re-enter nohz_full on a given CPU). A common case is for applications that run on nohz_full= CPUs to not use POSIX timers (eg DPDK). This patch changes the notification to

[PATCH v9 4/4] remoteproc: qcom: wcss: explicitly request exclusive reset control

2021-01-28 Thread Gokul Sriram Palanisamy
From: Govind Singh Use request exclusive reset control for wcss reset controls. Signed-off-by: Govind Singh Signed-off-by: Gokul Sriram Palanisamy --- drivers/remoteproc/qcom_q6v5_wcss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_wcs

Re: regression in drm_blank.c?

2021-01-28 Thread Ville Syrjälä
On Thu, Jan 28, 2021 at 11:12:50AM -0600, Steve French wrote: > For the last month my logs have been flooded many times a second with: > > "nouveau :01:00.0: [drm] *ERROR* crtc 50: Can't calculate > constants, dotclock = 0!" Would indicate someone has a bogus adjusted_mode in their state stru

Re: [PATCH] x86/debug: 'Fix' ptrace dr6 output

2021-01-28 Thread Andrew Cooper
On 28/01/2021 18:20, Peter Zijlstra wrote: > --- a/arch/x86/kernel/hw_breakpoint.c > +++ b/arch/x86/kernel/hw_breakpoint.c > @@ -496,9 +496,32 @@ static int hw_breakpoint_handler(struct > dr6_p = (unsigned long *)ERR_PTR(args->err); > dr6 = *dr6_p; > > - /* If it's a single step,

Re: [PATCH][next] nfsd: fix check of statid returned from call to find_stateid_by_type

2021-01-28 Thread Bruce Fields
On Thu, Jan 28, 2021 at 03:53:36PM +, Chuck Lever wrote: > > On Jan 28, 2021, at 10:34 AM, Dan Carpenter > > wrote: > > Fixes tags are used for a lot of different things: > > 1) If there is a fixes tag, then you can tell it does *NOT* have to > >be back ported because the original commit

<    1   2   3   4   5   6   7   8   9   10   >