Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-19 Thread John Garry
On 19/01/2021 10:56, Joakim Zhang wrote: It seems have other issue compared to 5.10 kernel after switching to this framework, below metric can't work. "MetricExpr": "(( imx8_ddr0@read\\-cycles@ + imx8_ddr0@write\\-cycles@ ) * 4 * 4 / duration_time) / (750 * 100 * 4 * 4)" After change to: "M

Re: [PATCH] tracing: precise log info for kretprobe addr err

2021-01-19 Thread Steven Rostedt
Masami, Looks fine to me. What do you think? -- Steve On Tue, 19 Jan 2021 23:10:14 +0800 Jianlin Lv wrote: > When trying to create kretprobe with the wrong function symbol in tracefs; > The error is triggered in the register_trace_kprobe() and recorded as > FAIL_REG_PROBE issue, > > Example:

Re: [PATCH v3 bpf-next 2/2] selftests: bpf: Add a new test for bare tracepoints

2021-01-19 Thread Yonghong Song
On 1/19/21 4:22 AM, Qais Yousef wrote: Reuse module_attach infrastructure to add a new bare tracepoint to check we can attach to it as a raw tracepoint. Signed-off-by: Qais Yousef Acked-by: Yonghong Song

[PATCH v2 2/2] arm64: dts: fsl-ls1012a-frdm: add spi-uart device

2021-01-19 Thread Pawel Dembicki
This patch adds spi-uart controller to LS1012A-FRDM board dts. Device is equipped in SC16IS740 from NXP. Signed-off-by: Pawel Dembicki --- Changes in v2: - reordered property list - change clock name to "clock-sc16is7xx" .../boot/dts/freescale/fsl-ls1012a-frdm.dts | 21 +++ 1

Re: [PATCH net] net: mrp: use stp state as substitute for unimplemented mrp state

2021-01-19 Thread Andrew Lunn
On Tue, Jan 19, 2021 at 09:32:40AM +0100, Horatiu Vultur wrote: > The 01/18/2021 21:27, Vladimir Oltean wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Mon, Jan 18, 2021 at 09:20:36PM +0100, Horatiu Vultur wrote: > > > The 01/18

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

2021-01-19 Thread Jiri Kosina
On Mon, 25 Jul 2016, Jens Axboe wrote: > > From: Jiri Kosina > > > > Commit 09954bad4 ("floppy: refactor open() flags handling"), as a > > side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that > > this is being used setfdprm userspace for ioctl-only open(). > > > > Reintroduce

Re: [PATCH 1/2 v2] dma-iommu: use static-key to minimize the impact in the fast-path

2021-01-19 Thread Robin Murphy
On 2021-01-19 15:26, Christoph Hellwig wrote: On Tue, Jan 19, 2021 at 07:16:15PM +0800, Lianbo Jiang wrote: +static DEFINE_STATIC_KEY_FALSE(__deferred_attach); Why the strange underscores? Wouldn't iommu_deferred_attach_enabled be a better name? - if (unlikely(iommu_dma_deferred_attac

[PATCH v2 1/2] arm64: dts: fsl-ls1012a-rdb: add i2c devices

2021-01-19 Thread Pawel Dembicki
LS1012A-RDB equipped in some i2c devices: - 3x GPIO Expander: PCAL9555A (NXP) - Gyro: FXAS21002 (NXP) - Accelerometer: FXOS8700 (NXP) - Current & Power Monitor: INA220 (TI) This patch add listed devices to dts. Signed-off-by: Pawel Dembicki --- Changes in v2: - resend only .../boot/dts

Re: [Patch v4 1/2] cgroup: svm: Add Encryption ID controller

2021-01-19 Thread Tejun Heo
Hello, On Fri, Jan 15, 2021 at 08:32:19PM -0800, Vipin Sharma wrote: > SEV-ES has stronger memory encryption gurantees compared to SEV, apart > from encrypting the application memory it also encrypts register state > among other things. In a single host ASIDs can be distributed between > these two

Re: [PATCH 3/3] mtd: parsers: ofpart: support BCM4908 fixed partitions

2021-01-19 Thread Miquel Raynal
Hi Rafał, Rafał Miłecki wrote on Fri, 15 Jan 2021 16:39:01 +0100: > From: Rafał Miłecki > > BCM4908 partitioning is based on fixed layout but allows specifying > multiple firmware partitions. It requires detecting which firmware > partition was used for booting current kernel. > > To support

Re: IOMMU Maintainership

2021-01-19 Thread Joerg Roedel
On Tue, Nov 17, 2020 at 11:09:53AM +0100, Joerg Roedel wrote: > Hi, > > last week I spent in the hospital and had an unplanned surgery from > which I am recovering now. The recovery will take a few weeks, which > unfortunatly does not allow me to fulfill my IOMMU maintainer duties or > do any othe

Re: [PATCH v3 05/21] x86/fpu/xstate: Add a new variable to indicate dynamic user states

2021-01-19 Thread Borislav Petkov
On Fri, Jan 15, 2021 at 07:47:38PM +, Bae, Chang Seok wrote: > On Jan 15, 2021, at 05:39, Borislav Petkov wrote: > > On Wed, Dec 23, 2020 at 07:57:01AM -0800, Chang S. Bae wrote: > >> The perf has a buffer that is allocated on demand. The states saved in the > > > > What's "the perf"? I hope

[PATCH bpf-next v5 2/4] bpf: Expose bpf_get_socket_cookie to tracing programs

2021-01-19 Thread Florent Revest
This needs a new helper that: - can work in a sleepable context (using sock_gen_cookie) - takes a struct sock pointer and checks that it's not NULL Signed-off-by: Florent Revest --- include/linux/bpf.h| 1 + include/uapi/linux/bpf.h | 8 kernel/trace/bpf_trace.c

[PATCH bpf-next v5 4/4] selftests/bpf: Add a selftest for the tracing bpf_get_socket_cookie

2021-01-19 Thread Florent Revest
This builds up on the existing socket cookie test which checks whether the bpf_get_socket_cookie helpers provide the same value in cgroup/connect6 and sockops programs for a socket created by the userspace part of the test. Adding a tracing program to the existing objects requires a different atta

[PATCH bpf-next v5 1/4] bpf: Be less specific about socket cookies guarantees

2021-01-19 Thread Florent Revest
Since "92acdc58ab11 bpf, net: Rework cookie generator as per-cpu one" socket cookies are not guaranteed to be non-decreasing. The bpf_get_socket_cookie helper descriptions are currently specifying that cookies are non-decreasing but we don't want users to rely on that. Reported-by: Daniel Borkmann

[PATCH bpf-next v5 3/4] selftests/bpf: Integrate the socket_cookie test to test_progs

2021-01-19 Thread Florent Revest
Currently, the selftest for the BPF socket_cookie helpers is built and run independently from test_progs. It's easy to forget and hard to maintain. This patch moves the socket cookies test into prog_tests/ and vastly simplifies its logic by: - rewriting the loading code with BPF skeletons - rewrit

Re: [PATCH bpf-next v4 2/4] bpf: Expose bpf_get_socket_cookie to tracing programs

2021-01-19 Thread Florent Revest
On Wed, Dec 9, 2020 at 5:35 PM Daniel Borkmann wrote: > > On 12/9/20 2:26 PM, Florent Revest wrote: > > This needs two new helpers, one that works in a sleepable context (using > > sock_gen_cookie which disables/enables preemption) and one that does not > > (for performance reasons). Both take a s

Re: [RFC PATCH 4/5] arm64: fpsimd: run kernel mode NEON with softirqs disabled

2021-01-19 Thread Dave Martin
On Fri, Dec 18, 2020 at 06:01:05PM +0100, Ard Biesheuvel wrote: > Kernel mode NEON can be used in task or softirq context, but only in > a non-nesting manner, i.e., softirq context is only permitted if the > interrupt was not taken at a point where the kernel was using the NEON > in task context. >

Re: [PATCH v7 12/17] PCI: Revoke mappings like devmem

2021-01-19 Thread Daniel Vetter
On Tue, Jan 19, 2021 at 4:20 PM Greg Kroah-Hartman wrote: > > On Tue, Jan 19, 2021 at 03:34:47PM +0100, Daniel Vetter wrote: > > On Tue, Jan 19, 2021 at 3:32 PM Greg Kroah-Hartman > > wrote: > > > > > > On Tue, Jan 19, 2021 at 09:17:55AM +0100, Daniel Vetter wrote: > > > > On Fri, Nov 27, 2020 at

Re: [PATCH] workqueue: tracing the name of the workqueue instead of it's address

2021-01-19 Thread Tejun Heo
On Mon, Jan 04, 2021 at 08:43:06PM +0800, qiang.zh...@windriver.com wrote: > From: Zqiang > > This patch tracing workqueue name instead of it's address, the > new format is as follows. > > workqueue_queue_work: work struct=84e3df56 function= > drm_fb_helper_dirty_work workqueue=events re

Re: [Linux-stm32] [PATCH] rpmsg: char: return an error if device already open

2021-01-19 Thread Mathieu Poirier
On Fri, Jan 15, 2021 at 10:13:35AM +0100, Arnaud POULIQUEN wrote: > Hi Mathieu, > > > On 1/14/21 8:05 PM, Mathieu Poirier wrote: > > On Wed, Jan 06, 2021 at 02:37:14PM +0100, Arnaud Pouliquen wrote: > >> The rpmsg_create_ept function is invoked when the device is opened. > >> As only one endpoint

Re: [PATCH] soundwire: debugfs: use controller id instead of link_id

2021-01-19 Thread Pierre-Louis Bossart
On 1/19/21 8:52 AM, Vinod Koul wrote: On 15-01-21, 16:25, Srinivas Kandagatla wrote: link_id can be zero and if we have multiple controller instances in a system like Qualcomm debugfs will end-up with duplicate namespace resulting in incorrect debugfs entries. Using id should give a unique d

Re: [PATCH] x86: PM: Register syscore_ops for scale invariance

2021-01-19 Thread Peter Zijlstra
On Tue, Jan 19, 2021 at 04:12:20PM +0100, Rafael J. Wysocki wrote: > On Tue, Jan 12, 2021 at 4:10 PM Rafael J. Wysocki wrote: > > > > On Tue, Jan 12, 2021 at 4:02 PM Peter Zijlstra wrote: > > > > > > On Fri, Jan 08, 2021 at 07:05:59PM +0100, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysock

Re: [PATCH] workqueue: keep unbound rescuer's cpumask to be default cpumask

2021-01-19 Thread Tejun Heo
On Sat, Jan 16, 2021 at 02:57:53PM +0800, Lai Jiangshan wrote: > From: Lai Jiangshan > > When we attach a rescuer to a pool, we will set the rescuer's cpumask > to the pool's cpumask. If there is hotplug ongoing, it may cause > the rescuer running on the dying CPU and cause bug or it may cause >

Re: [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes

2021-01-19 Thread Ville Syrjälä
On Mon, Jan 18, 2021 at 08:54:12PM -0500, Lyude Paul wrote: > Nvidia hardware doesn't actually support using tiling formats with the > cursor plane, only linear is allowed. In the future, we should write a > testcase for this. There are a couple of old modifier/format sanity tests here: https://pa

Re: [PATCH] remoteproc: qcom_q6v5_mss: Validate p_filesz in ELF loader

2021-01-19 Thread Mathieu Poirier
On Wed, Jan 13, 2021 at 04:03:59PM -0600, Bjorn Andersson wrote: > On Wed 13 Jan 15:22 CST 2021, Mathieu Poirier wrote: > > > Hi Bjorn, > > > > On Thu, Jan 07, 2021 at 03:50:53PM -0800, Bjorn Andersson wrote: > > > Analog to the issue in the common mdt_loader code the MSS ELF loader > > > does no

Re: [PATCH v3 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

2021-01-19 Thread Minchan Kim
On Tue, Jan 12, 2021 at 05:21:43PM -0800, Minchan Kim wrote: > From: Hyesoo Yu > > This patch supports chunk heap that allocates the buffers that > arranged into a list a fixed size chunks taken from CMA. > > The chunk heap driver is bound directly to a reserved_memory > node by following Rob He

Re: [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes

2021-01-19 Thread James Jones
Gah, yes, good catch. Reviewed-by: James Jones On 1/18/21 5:54 PM, Lyude Paul wrote: Nvidia hardware doesn't actually support using tiling formats with the cursor plane, only linear is allowed. In the future, we should write a testcase for this. Fixes: c586f30bf74c ("drm/nouveau/kms: Add form

[tip: sched/urgent] x86: PM: Register syscore_ops for scale invariance

2021-01-19 Thread tip-bot2 for Rafael J. Wysocki
The following commit has been merged into the sched/urgent branch of tip: Commit-ID: 9c7d9017a49fb8516c13b7bff59b7da2abed23e1 Gitweb: https://git.kernel.org/tip/9c7d9017a49fb8516c13b7bff59b7da2abed23e1 Author:Rafael J. Wysocki AuthorDate:Fri, 08 Jan 2021 19:05:59 +01:00 Co

[PATCH v4 02/21] staging: hikey9xx: hisilicon,hi6421-spmi-pmic.yaml: simplify props

2021-01-19 Thread Mauro Carvalho Chehab
As all regulator-specific properties got moved to be part of the driver, remove them from the DT spec. Signed-off-by: Mauro Carvalho Chehab --- .../hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 106 +++--- 1 file changed, 40 insertions(+), 66 deletions(-) diff --git a/drivers/staging/

[PATCH v4 06/21] staging: hikey9xx: hi6421v600-regulator: cleanup debug msgs

2021-01-19 Thread Mauro Carvalho Chehab
While those were useful during port time from downstream version, let's get rid of them for good, as it is possible to get about the same things by enabling regulator debugging code. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/hi6421v600-regulator.c | 47 ++-

[PATCH v4 03/21] staging: hikey9xx: hisi-spmi-controller: clean sparse warnings

2021-01-19 Thread Mauro Carvalho Chehab
Sparse complains about __be32 conversions: drivers/spmi/hisi-spmi-controller.c drivers/spmi/hisi-spmi-controller.c:164:24: warning: cast to restricted __be32 drivers/spmi/hisi-spmi-controller.c drivers/spmi/hisi-spmi-controller.c:164:24: warning: cast to restricted __be32

[PATCH v4 07/21] staging: hikey9xx: hi6421v600-regulator: get rid of an static data

2021-01-19 Thread Mauro Carvalho Chehab
Move it to be inside the private data struct. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/hi6421v600-regulator.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/hikey9xx/hi6421v600-regulator.c b/drivers/staging/hikey9xx/hi6421

[PATCH v4 10/21] staging: hikey9xx: hi6421v600-regulator: fix delay logic

2021-01-19 Thread Mauro Carvalho Chehab
The original driver, which can be seen at commit 42f24d9d446a ("staging: regulator: add a regulator driver for HiSilicon 6421v600 SPMI PMIC") had a complex logic to ensure that there won't be multiple power enable/disable commands running at the same time. At the original logic, it were ensured th

[PATCH v4 08/21] staging: hikey9xx: hi6421v600-regulator: do some cleanups

2021-01-19 Thread Mauro Carvalho Chehab
In preparation for de-staging, do some cleanups: - Return error codes from hi6421_spmi_pmic_rmw(); - Remove a debug message; - Change the module description; - a few minor coding style adjustments. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/hi6421v600-regulator.c | 37 +

[PATCH v4 11/21] staging: hikey9xx: hi6421v600-regulator: cleanup comments

2021-01-19 Thread Mauro Carvalho Chehab
Remove obvious comments and fix the comment for the HI6421V600_LDO() macro. While on it, use kernel-doc notation for HI6421V600_LDO(), as kernel-doc can check if the arguments match its description. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/hi6421v600-regulator.c | 27

[PATCH v4 21/21] dts: hisilicon: add support for the PMIC found on Hikey 970

2021-01-19 Thread Mauro Carvalho Chehab
Add a device tree for the HiSilicon 6421v600 SPMI PMIC, used on HiKey970 board. As we now have support for it, change the fixed regulators used by the SD I/O to use the proper LDO supplies. Signed-off-by: Mauro Carvalho Chehab --- .../boot/dts/hisilicon/hi3670-hikey970.dts| 22 + .../bo

[PATCH v4 19/21] regulator: hi6421v600-regulator: move it from staging

2021-01-19 Thread Mauro Carvalho Chehab
This driver is ready for mainstream. Move it out of staging. Signed-off-by: Mauro Carvalho Chehab --- MAINTAINERS | 7 +- drivers/regulator/Kconfig | 8 + drivers/regulator/Makefile| 1 + drivers/regulator/hi6421v600

[PATCH v4 17/21] spmi: hisi-spmi-controller: move driver from staging

2021-01-19 Thread Mauro Carvalho Chehab
The Hisilicon 6421v600 SPMI driver is ready for mainstream. So, move it from staging. Signed-off-by: Mauro Carvalho Chehab --- .../spmi/hisilicon,hisi-spmi-controller.yaml | 75 MAINTAINERS | 7 + drivers/spmi/Kconfig | 9 +

[PATCH v4 16/21] staging: hikey9xx: simplify includes

2021-01-19 Thread Mauro Carvalho Chehab
There are several uneeded includes. Remove them. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c index 9310a9

Re: [PATCH 1/2] net: wireless: intel: iwlwifi: mvm: tt: Replace thermal_notify_framework

2021-01-19 Thread Kalle Valo
Thara Gopinath writes: > thermal_notify_framework just updates for a single trip point where as > thermal_zone_device_update does other bookkeeping like updating the > temperature of the thermal zone and setting the next trip point etc. > Replace thermal_notify_framework with thermal_zone_device_

Re: rcutorture initrd/nolibc build on ARMv8?

2021-01-19 Thread Willy Tarreau
Hi Paul, On Tue, Jan 19, 2021 at 07:31:47AM -0800, Paul E. McKenney wrote: > Hello, Willy, > > Some people are having trouble running rcutorture on ARMv8. They > get things like this from the nolibc build of initrd: > > https://paste.debian.net/1181762/ > > The nolibc.h file says this: > > /*

Re: [PATCH 1/2] s390: uv: Fix sysfs max number of VCPUs reporting

2021-01-19 Thread Cornelia Huck
On Tue, 19 Jan 2021 05:04:01 -0500 Janosch Frank wrote: > The number reported by the query is N-1 and I think people reading the > sysfs file would expect N instead. For users creating VMs there's no > actual difference because KVM's limit is currently below the UV's > limit. > > The naming of t

Re: [PATCH V2 1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE

2021-01-19 Thread Frank Rowand
On 1/6/21 11:15 PM, Viresh Kumar wrote: > We will start building overlays for platforms soon in the kernel and > would need these tools going forward. Lets start fetching them. > > Note that a copy of fdtdump.c was already copied back in the year 2012, > but was never updated or built for some rea

[PATCH 2/2] security.capability: fix conversions on getxattr

2021-01-19 Thread Miklos Szeredi
If a capability is stored on disk in v2 format cap_inode_getsecurity() will currently return in v2 format unconditionally. This is wrong: v2 cap should be equivalent to a v3 cap with zero rootid, and so the same conversions performed on it. If the rootid cannot be mapped v3 is returned unconverte

Re: [PATCH] x86/sev: Add AMD_SEV_ES_GUEST Kconfig for including SEV-ES support

2021-01-19 Thread Sean Christopherson
On Mon, Jan 18, 2021, Borislav Petkov wrote: > On Mon, Jan 18, 2021 at 09:32:07PM +0100, Paolo Bonzini wrote: > > I think it makes sense because AMD_SEV_ES_GUEST's #VC handling is quite a > > bit of code that you may not want or need. > > Quite a bit of code which ends up practically enabled on th

[PATCH 1/2] ecryptfs: fix uid translation for setxattr on security.capability

2021-01-19 Thread Miklos Szeredi
Prior to commit 7c03e2cda4a5 ("vfs: move cap_convert_nscap() call into vfs_setxattr()") the translation of nscap->rootid did not take stacked filesystems (overlayfs and ecryptfs) into account. That patch fixed the overlay case, but made the ecryptfs case worse. Restore old the behavior for ecrypt

Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-19 Thread Cornelia Huck
On Tue, 19 Jan 2021 11:38:10 +0100 Janosch Frank wrote: > On 1/19/21 11:25 AM, Christian Borntraeger wrote: > > > > > > On 19.01.21 11:04, Janosch Frank wrote: > >> Turns out that the bit 61 in the TEID is not always 1 and if that's > >> the case the address space ID and the address are > >>

arch/mips/sgi-ip27/ip27-hubio.c:30:15: warning: no previous prototype for 'hub_pio_map'

2021-01-19 Thread kernel test robot
stuff date: 1 year ago config: mips-randconfig-r022-20210119 (attached as .config) compiler: mips64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

[PATCH 0/2] capability conversion fixes

2021-01-19 Thread Miklos Szeredi
It turns out overlayfs is actually okay wrt. mutliple conversions, because it uses the right context for lower operations. I.e. before calling vfs_{set,get}xattr() on underlying fs, it overrides creds with that of the mounter, so the current user ns will now match that of overlay_sb->s_user_ns, me

Re: [PATCH V2 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools

2021-01-19 Thread Frank Rowand
On 1/6/21 11:15 PM, Viresh Kumar wrote: > We will start building overlays for platforms soon in the kernel and > would need these tools going forward. Lets start building them. > > Signed-off-by: Viresh Kumar > --- > scripts/dtc/Makefile | 8 +++- > 1 file changed, 7 insertions(+), 1 deletio

[PATCH v4 14/21] staging: hikey9xx: spmi driver: convert to regmap

2021-01-19 Thread Mauro Carvalho Chehab
Instead of doing its own SPMI I/O implementation, use the already-existing regmap one. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 115 ++ .../staging/hikey9xx/hi6421v600-regulator.c | 26 ++-- include/linux/mfd/hi6421-spmi-pmic.h

[PATCH v4 20/21] dts: hisilicon: add support for USB3 on Hikey 970

2021-01-19 Thread Mauro Carvalho Chehab
Add the USB3 bindings for Kirin 970 phy and Hikey 970 board. Signed-off-by: Mauro Carvalho Chehab --- .../boot/dts/hisilicon/hi3670-hikey970.dts| 102 ++ arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 58 ++ 2 files changed, 160 insertions(+) diff --git a/arch/arm6

Re: [PATCH V2 1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE

2021-01-19 Thread Frank Rowand
On 1/19/21 10:21 AM, Frank Rowand wrote: > On 1/6/21 11:15 PM, Viresh Kumar wrote: >> We will start building overlays for platforms soon in the kernel and >> would need these tools going forward. Lets start fetching them. >> >> Note that a copy of fdtdump.c was already copied back in the year 2012,

Re: [PATCH v6 1/6] scsi: ufs: Add "wb_on" sysfs node to control WB on/off

2021-01-19 Thread Bean Huo
On Tue, 2021-01-19 at 12:00 +0200, Adrian Hunter wrote: > > > Is it so, that after a full reset, WB is always enabled again? > > > Is > > > that > > > intended? > > > > Hello Adrian > > Good questions. yes, after a full reset, the UFS device side by > > default > > is wb disabled, then WB will b

Re: [PATCH V4 1/3] scripts: dtc: Add fdtoverlay.c to DTC_SOURCE

2021-01-19 Thread Frank Rowand
On 1/12/21 2:29 AM, Viresh Kumar wrote: > We will start building overlays for platforms soon in the kernel and > would need fdtoverlay tool going forward. Lets start fetching it. > > Signed-off-by: Viresh Kumar > --- > scripts/dtc/update-dtc-source.sh | 6 +++--- > 1 file changed, 3 insertions(+

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-19 Thread Laurent Pinchart
Hi Daniel, On Tue, Jan 19, 2021 at 08:43:43AM +, Daniel Scally wrote: > On 19/01/2021 06:19, Laurent Pinchart wrote: > > On Mon, Jan 18, 2021 at 08:46:34PM +, Daniel Scally wrote: > >> Hi Laurent, thanks for the comments - really appreciate the detail. > >> > >> Some specific responses bel

RE: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-19 Thread Limonciello, Mario
> >> -Original Message- > >> From: Yuan, Perry > >> Sent: Tuesday, January 12, 2021 11:18 > >> To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; > >> hdego...@redhat.com; mgr...@linux.intel.com > >> Cc: lgirdw...@gmail.com; broo...@kernel.org; alsa-de...@alsa-project.org; > >> li

Re: [PATCH V2 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools

2021-01-19 Thread Frank Rowand
On 1/19/21 10:28 AM, Frank Rowand wrote: > On 1/6/21 11:15 PM, Viresh Kumar wrote: >> We will start building overlays for platforms soon in the kernel and >> would need these tools going forward. Lets start building them. >> >> Signed-off-by: Viresh Kumar >> --- >> scripts/dtc/Makefile | 8 ++

Re: [PATCH V4 2/3] scripts: dtc: Build fdtoverlay tool

2021-01-19 Thread Frank Rowand
Hi Viresh, I made these comments in the v2 patch series. I am copying them here since this is the current version. On 1/12/21 2:29 AM, Viresh Kumar wrote: > We will start building overlays for platforms soon in the kernel and > would need fdtoverlay going forward. Lets start building it. > > Th

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-19 Thread Laurent Pinchart
Hi Andy, On Tue, Jan 19, 2021 at 11:33:58AM +0200, Andy Shevchenko wrote: > On Tue, Jan 19, 2021 at 12:11:40AM +, Daniel Scally wrote: > > On 18/01/2021 21:19, Daniel Scally wrote: > > > > I'm more and more confident that this will work, but it has some > > knock-on effects: > > > > The both

[PATCH v7 2/6] docs: ABI: Add wb_on documentation for new entry wb_on

2021-01-19 Thread Bean Huo
From: Bean Huo Adds UFS sysfs documentation for new entry wb_on. Signed-off-by: Bean Huo --- Documentation/ABI/testing/sysfs-driver-ufs | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs inde

[PATCH v7 3/6] scsi: ufs: Changes comment in the function ufshcd_wb_probe()

2021-01-19 Thread Bean Huo
From: Bean Huo USFHCD supports WriteBooster "LU dedicated buffer” mode and “shared buffer” mode both, so changes the comment in the function ufshcd_wb_probe(). Reviewed-by: Can Guo Reviewed-by: Stanley Chu Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufshcd.c | 7 +++ 1 file changed, 3 i

Re: [PATCH v2] mm: page_counter: relayout structure to reduce false sharing

2021-01-19 Thread Shakeel Butt
On Mon, Jan 18, 2021 at 11:20 PM Feng Tang wrote: > > When checking a memory cgroup related performance regression [1], > from the perf c2c profiling data, we found high false sharing for > accessing 'usage' and 'parent'. > > On 64 bit system, the 'usage' and 'parent' are close to each other, > an

Re: [PATCH V8 10/10] remoteproc: imx_proc: enable virtio/mailbox

2021-01-19 Thread Mathieu Poirier
On Tue, Jan 19, 2021 at 03:35:11PM +0800, peng@nxp.com wrote: > From: Peng Fan > > Use virtio/mailbox to build connection between Remote Proccessors > and Linux. Add work queue to handle incoming messages. > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/i

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-01-19 Thread Michael Grzeschik
On Mon, Jan 18, 2021 at 05:24:38PM +0200, Felipe Balbi wrote: Hi, Michael Grzeschik writes: On Tue, Dec 15, 2020 at 12:24:51PM +0530, Manish Narani wrote: Add a new driver for supporting Xilinx platforms. This driver is used for some sequence of operations required for Xilinx USB controllers

[PATCH] kasan, mm: fix resetting page_alloc tags for HW_TAGS

2021-01-19 Thread Andrey Konovalov
A previous commit added resetting KASAN page tags to kernel_init_free_pages() to avoid false-positives due to accesses to metadata with the hardware tag-based mode. That commit did reset page tags before the metadata access, but didn't restore them after. As the result, KASAN fails to detect bad a

Re: [PATCH] sched/eas: Don't update misfit status if the task is pinned

2021-01-19 Thread Qais Yousef
On 01/19/21 15:35, Quentin Perret wrote: > On Tuesday 19 Jan 2021 at 12:07:55 (+), Qais Yousef wrote: > > If the task is pinned to a cpu, setting the misfit status means that > > we'll unnecessarily continuously attempt to migrate the task but fail. > > > > This continuous failure will cause t

[PATCH] EDAC/amd64: Issue probing messages only on properly detected hardware

2021-01-19 Thread Borislav Petkov
From: Borislav Petkov amd64_edac was converted to CPU family autoprobing (from PCI device IDs) to not have to add a new PCI device ID a new platform is shipped but to support the whole family directly. However, this caused a lot of noise in dmesg even when the machine doesn't have ECC DIMMs or E

Re: [PATCH net v2] net: mscc: ocelot: Fix multicast to the CPU port

2021-01-19 Thread Vladimir Oltean
On Tue, Jan 19, 2021 at 03:06:38PM +0100, Alban Bedel wrote: > Multicast entries in the MAC table use the high bits of the MAC > address to encode the ports that should get the packets. But this port > mask does not work for the CPU port, to receive these packets on the > CPU port the MAC_CPU_COPY

Re: BUG: sleeping function called from invalid context at kernel/stop_machine.c:135

2021-01-19 Thread Waiman Long
On 1/19/21 6:13 AM, Daniel Bristot de Oliveira wrote: Hi Waiman, Are you aware of this issue: - %< - [ 88.307857] BUG: sleeping function called from invalid context at kernel/stop_machine.c:135 [ 88.308796] in_atomic(): 0, irqs_disabled(): 0, non_block: 0, pid: 801, name: sh [ 88

[PATCH v7 6/6] scsi: ufs: Cleanup WB buffer flush toggle implementation

2021-01-19 Thread Bean Huo
From: Bean Huo Delete ufshcd_wb_buf_flush_enable() and ufshcd_wb_buf_flush_disable(), move the implementation into ufshcd_wb_toggle_flush(). Signed-off-by: Bean Huo Reviewed-by: Stanley Chu Reviewed-by: Can Guo Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufshcd.c | 66 +

Re: [PATCH] mm: memcontrol: prevent starvation when writing memory.high

2021-01-19 Thread Johannes Weiner
On Fri, Jan 15, 2021 at 01:27:23PM -0800, Roman Gushchin wrote: > On Fri, Jan 15, 2021 at 03:55:36PM -0500, Johannes Weiner wrote: > > On Fri, Jan 15, 2021 at 09:03:41AM -0800, Roman Gushchin wrote: > > > On Fri, Jan 15, 2021 at 11:20:50AM -0500, Johannes Weiner wrote: > > > > On Wed, Jan 13, 2021

[PATCH v7 5/6] scsi: ufs: Group UFS WB related flags to struct ufs_dev_info

2021-01-19 Thread Bean Huo
From: Bean Huo UFS device-related flags should be grouped in ufs_dev_info. Take wb_enabled and wb_buf_flush_enabled out from the struct ufs_hba, group them to struct ufs_dev_info, and align the names of the structure members vertically. Acked-by: Stanley Chu Reviewed-by: Can Guo Signed-off-by:

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-19 Thread Laurent Pinchart
On Tue, Jan 19, 2021 at 01:08:37PM +0200, Andy Shevchenko wrote: > On Tue, Jan 19, 2021 at 10:40:42AM +, Daniel Scally wrote: > > On 19/01/2021 09:24, Andy Shevchenko wrote: > > > +static struct i2c_driver int3472_tps68470 = { > > > + .driver = { > > > + .name = "int

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-19 Thread Laurent Pinchart
On Tue, Jan 19, 2021 at 11:35:42AM +0200, Andy Shevchenko wrote: > On Tue, Jan 19, 2021 at 08:21:23AM +0200, Laurent Pinchart wrote: > > On Tue, Jan 19, 2021 at 12:11:40AM +, Daniel Scally wrote: > > > On 18/01/2021 21:19, Daniel Scally wrote: > > ... > > > > (also, Laurent, if we did it this

Re: BUG: sleeping function called from invalid context at kernel/stop_machine.c:135

2021-01-19 Thread Peter Zijlstra
On Tue, Jan 19, 2021 at 11:45:02AM -0500, Waiman Long wrote: > On 1/19/21 6:13 AM, Daniel Bristot de Oliveira wrote: > > Hi Waiman, > > > > Are you aware of this issue: > > - %< - > > [ 88.307857] BUG: sleeping function called from invalid context at > > kernel/stop_machine.c:135 > > [

Re: [PATCH v2 0/2] cgroup: fix psi monitor for root cgroup

2021-01-19 Thread Dan Schatzberg
> This patchset fixes PSI monitors on the root cgroup, as they currently > only works on the non-root cgroups. Reading works for all, since that > was fixed when adding support for the root PSI files. It also contains > a doc update to reflect the current implementation. > > Changes since v1: > -

Re: [PATCH v2 1/2] cgroup: fix psi monitor for root cgroup

2021-01-19 Thread Johannes Weiner
On Sat, Jan 16, 2021 at 06:36:33PM +0100, Odin Ugedal wrote: > Fix NULL pointer dereference when adding new psi monitor to the root > cgroup. PSI files for root cgroup was introduced in df5ba5be742 by using > system wide psi struct when reading, but file write/monitor was not > properly fixed. Sinc

[RFC PATCH 0/2] Tracing bursts of latencies

2021-01-19 Thread Viktor Rosendahl
Hello all, This series contains two things: 1. A fix for a bug in the Ftrace latency tracers that appeared with Linux 5.7. 2. The latency-collector, a tool that is designed to work around the limitations in the ftrace latency tracers. It needs the bug fix in order to work properly. I have

[RFC PATCH 2/2] Add the latency-collector to tools

2021-01-19 Thread Viktor Rosendahl
This is a tool that is intended to work around the fact that the preemptoff, irqsoff, and preemptirqsoff tracers only work in overwrite mode. The idea is to act randomly in such a way that we do not systematically lose any latencies, so that if enough testing is done, all latencies will be captured

[PATCH 1/1] bsg: free the request before return error code

2021-01-19 Thread Pan Bian
Free the request rq before returning error code. Fixes: 972248e9111e ("scsi: bsg-lib: handle bidi requests without block layer help") Signed-off-by: Pan Bian --- block/bsg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/bsg.c b/block/bsg.c index d7bae94b64d9..3d78

Re: [RFC][PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu online

2021-01-19 Thread Alexey Klimov
On Fri, Jan 15, 2021 at 6:54 AM Daniel Jordan wrote: > > Daniel Jordan writes: > > Peter Zijlstra writes: > >>> The nature of this bug is also described here (with different > >>> consequences): > >>> https://lore.kernel.org/lkml/20200211141554.24181-1-qais.you...@arm.com/ > >> > >> Yeah, pesky

Re: [PATCH] sched/eas: Don't update misfit status if the task is pinned

2021-01-19 Thread Quentin Perret
On Tuesday 19 Jan 2021 at 16:40:27 (+), Qais Yousef wrote: > On 01/19/21 15:35, Quentin Perret wrote: > > Do you mean failing the sched_setaffinity syscall if e.g. the task > > has a min clamp that is higher than the capacity of the CPUs to which it > > will be pinned? If so, I'm not sure if we

Re: BUG: sleeping function called from invalid context at kernel/stop_machine.c:135

2021-01-19 Thread Waiman Long
On 1/19/21 11:49 AM, Peter Zijlstra wrote: On Tue, Jan 19, 2021 at 11:45:02AM -0500, Waiman Long wrote: On 1/19/21 6:13 AM, Daniel Bristot de Oliveira wrote: Hi Waiman, Are you aware of this issue: - %< - [ 88.307857] BUG: sleeping function called from invalid context at kernel/stop

Re: [PATCH v2 2/2] cgroup: update PSI file description in docs

2021-01-19 Thread Johannes Weiner
On Sat, Jan 16, 2021 at 06:36:34PM +0100, Odin Ugedal wrote: > Update PSI file description in cgroup-v2 docs to reflect the current > implementation. > > Signed-off-by: Odin Ugedal > --- > Documentation/admin-guide/cgroup-v2.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH] mm: memcontrol: skip propagate percpu vmstat values to current memcg

2021-01-19 Thread Johannes Weiner
On Tue, Jan 19, 2021 at 01:27:44PM +0800, Muchun Song wrote: > The current memcg will be freed soon, so updating it's vmstat and > vmevent values is pointless. Just skip updating it. > > Signed-off-by: Muchun Song Oof, that's pretty subtle! Somebody trying to refactor that code for other purpose

Re: [PATCH] dt-bindings: soc: ti: Update TI PRUSS bindings about schemas to include

2021-01-19 Thread santosh . shilimkar
On 1/15/21 8:38 AM, Suman Anna wrote: Hi Santosh, On 12/21/20 3:32 PM, Rob Herring wrote: On Wed, 16 Dec 2020 23:50:27 +0100, Grzegorz Jaszczyk wrote: Now after ti,pruss-intc.yaml and ti,pru-rproc.yaml are merged, include them in proper property and extend the examples section. At the occasio

Re: [PATCH] sched/eas: Don't update misfit status if the task is pinned

2021-01-19 Thread Valentin Schneider
On 19/01/21 15:19, Vincent Guittot wrote: > On Tue, 19 Jan 2021 at 14:54, Valentin Schneider > wrote: >> On 19/01/21 14:34, Vincent Guittot wrote: >> >> - if (!p) { >> >> + if (!p || p->nr_cpus_allowed == 1) { >> > >> > Side question: What happens if there is 2 misfit tasks and the cur

Re: [PATCH v2] mm: page_counter: relayout structure to reduce false sharing

2021-01-19 Thread Johannes Weiner
On Tue, Jan 19, 2021 at 03:20:14PM +0800, Feng Tang wrote: > When checking a memory cgroup related performance regression [1], > from the perf c2c profiling data, we found high false sharing for > accessing 'usage' and 'parent'. > > On 64 bit system, the 'usage' and 'parent' are close to each othe

[RFC PATCH 1/2] Use pause-on-trace with the latency tracers

2021-01-19 Thread Viktor Rosendahl
Eaerlier, tracing was disabled when reading the trace file. This behavior was changed with: commit 06e0a548bad0 ("tracing: Do not disable tracing when reading the trace file"). This doesn't seem to work with the latency tracers. The above mentioned commit dit not only change the behavior but als

Re: [PATCH v2 0/2] cgroup: fix psi monitor for root cgroup

2021-01-19 Thread Tejun Heo
On Sat, Jan 16, 2021 at 06:36:32PM +0100, Odin Ugedal wrote: > This patchset fixes PSI monitors on the root cgroup, as they currently > only works on the non-root cgroups. Reading works for all, since that > was fixed when adding support for the root PSI files. It also contains > a doc update to re

[PATCH v7 4/6] scsi: ufs: Remove two WB related fields from struct ufs_dev_info

2021-01-19 Thread Bean Huo
From: Bean Huo d_wb_alloc_units and d_ext_ufs_feature_sup only be used while WB probe. They are just used to confirm the condition that "if bWriteBoosterBufferType is set to 01h but dNumSharedWriteBoosterBufferAllocUnits is set to zero, the WriteBooster feature is disabled", and if UFS device sup

[PATCH v7 1/6] scsi: ufs: Add "wb_on" sysfs node to control WB on/off

2021-01-19 Thread Bean Huo
From: Bean Huo Currently UFS WriteBooster driver uses clock scaling up/down to set WB on/off, for the platform which doesn't support UFSHCD_CAP_CLK_SCALING, WB will be always on. Provide a sysfs attribute to enable/disable WB during runtime. Write 1/0 to "wb_on" sysfs node to enable/disable UFS W

[PATCH v7 0/6] Several changes for UFS WriteBooster

2021-01-19 Thread Bean Huo
From: Bean Huo Changelog: v6--v7: 1. Change wb_on sysfs documentation and add information that WriteBooster is already enabled after power-on/reset(Incorporate Adrian Hunter's suggestion) v5--v6: 1. Remove original patch 7/7: "scsi: ufs: Keep device active mode only fWriteBoosterBufferFlus

Re: [PATCH v2 2/2] cgroup: update PSI file description in docs

2021-01-19 Thread Tejun Heo
On Tue, Jan 19, 2021 at 11:56:18AM -0500, Johannes Weiner wrote: > On Sat, Jan 16, 2021 at 06:36:34PM +0100, Odin Ugedal wrote: > > Update PSI file description in cgroup-v2 docs to reflect the current > > implementation. > > > > Signed-off-by: Odin Ugedal > > --- > > Documentation/admin-guide/cg

Re: rcutorture initrd/nolibc build on ARMv8?

2021-01-19 Thread Mark Rutland
Hi Willy, On Tue, Jan 19, 2021 at 05:19:01PM +0100, Willy Tarreau wrote: > On Tue, Jan 19, 2021 at 07:31:47AM -0800, Paul E. McKenney wrote: > > Some people are having trouble running rcutorture on ARMv8. They > > get things like this from the nolibc build of initrd: > > > > https://paste.debian

RE: panel: panel-raydium68200 driver fails to write MIPI DSI init commands

2021-01-19 Thread Philippe CORNU
Dear Aleksandr, We use the raydium68200 ic driver in a dsi 720p 2dl panel module mounted on the MB1230 board [1], mounted on the STM32MP157 eval board [2]. According to your email, you are using the EDT ETML0500F3DHA panel module, probably composed of a raydium68200+a touchscreen+a glass+backli

Re: [PATCH] sched/eas: Don't update misfit status if the task is pinned

2021-01-19 Thread Vincent Guittot
On Tue, 19 Jan 2021 at 17:55, Valentin Schneider wrote: > > On 19/01/21 15:19, Vincent Guittot wrote: > > On Tue, 19 Jan 2021 at 14:54, Valentin Schneider > > wrote: > >> On 19/01/21 14:34, Vincent Guittot wrote: > >> >> - if (!p) { > >> >> + if (!p || p->nr_cpus_allowed == 1) { > >>

Re: [PATCH] x86/sev: Add AMD_SEV_ES_GUEST Kconfig for including SEV-ES support

2021-01-19 Thread Borislav Petkov
On Tue, Jan 19, 2021 at 08:23:20AM -0800, Sean Christopherson wrote: > It was the AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT dependency that tripped me up. > To > get KVM to enable SEV/SEV-ES by default, By default? What would be the use case for that? > Agreed, I'll send a KVM patch to remove the > AMD

<    1   2   3   4   5   6   7   8   9   10   >