Re: [RFC PATCH 6/8] sched: Report local wake up on resched blind zone within idle loop

2021-01-14 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 11:46:06AM +, Chris Wilson wrote: > Quoting Frederic Weisbecker (2021-01-09 02:05:34) > > +void noinstr sched_resched_local_assert_allowed(void) > > +{ > > + if (this_rq()->resched_local_allow) > > + return; > > + > > + /* > > +* Idle in

[PATCH v3 03/10] PKCS#7: Fix missing include

2021-01-14 Thread Mickaël Salaün
From: Mickaël Salaün Add missing linux/types.h for size_t. [DH: Changed from stddef.h] Signed-off-by: Mickaël Salaün Signed-off-by: David Howells Reviewed-by: Ben Boeckel --- Changes since v2: * Cherry-pick v1 patch from https://lore.kernel.org/lkml/2659836.1607940...@warthog.procyon.org.

[PATCH v3 01/10] certs/blacklist: fix kernel doc interface issue

2021-01-14 Thread Mickaël Salaün
From: Alex Shi certs/blacklist.c:84: warning: Function parameter or member 'hash' not described in 'mark_hash_blacklisted' Cc: David Woodhouse Cc: keyri...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Alex Shi Signed-off-by: David Howells Reviewed-by: Ben Boeckel Signed-of

[PATCH v3 05/10] certs: Replace K{U,G}IDT_INIT() with GLOBAL_ROOT_{U,G}ID

2021-01-14 Thread Mickaël Salaün
From: Mickaël Salaün Align with the new macros and add appropriate include files. Cc: David Woodhouse Signed-off-by: Mickaël Salaün Signed-off-by: David Howells --- Changes since v2: * Cherry-pick v1 patch from https://lore.kernel.org/lkml/2659836.1607940...@warthog.procyon.org.uk/ to re

[PATCH v3 00/10] Enable root to update the blacklist keyring

2021-01-14 Thread Mickaël Salaün
This third patch series includes back three fix patches taken from the first series (and cherry-picked from David Howells's tree [1]), and one cosmetic fix from Alex Shi which helps avoid future conflicts. I also added some Acked-by and improved comments. As requested, this series is based on v5.

[PATCH v3 09/10] certs: Allow root user to append signed hashes to the blacklist keyring

2021-01-14 Thread Mickaël Salaün
From: Mickaël Salaün Add a kernel option SYSTEM_BLACKLIST_AUTH_UPDATE to enable the root user to dynamically add new keys to the blacklist keyring. This enables to invalidate new certificates, either from being loaded in a keyring, or from being trusted in a PKCS#7 certificate chain. This also

Re: RFC: printk: kmsg_dump_get_line_nolock() buffer overflow

2021-01-14 Thread Petr Mladek
On Wed 2021-01-13 21:06:28, John Ogness wrote: > Hello, > > I have discovered that kmsg_dump_get_line_nolock() is not allowed to > fill the full buffer that it is provided. It should leave at least 1 > byte free so that callers can append a terminator. > > Example from arch/powerpc/xmon/xmon.c: >

Re: [PATCH] sched/core: Print out straggler tasks in sched_cpu_dying()

2021-01-14 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 10:37:35AM +, Valentin Schneider wrote: > On 13/01/21 16:36, Paul E. McKenney wrote: > > On Thu, Jan 14, 2021 at 12:15:24AM +, Valentin Schneider wrote: > >> On 13/01/21 14:02, Paul E. McKenney wrote: > >> Thanks for giving it a spin! I think with the current series

[PATCH 1/5] input: mouse: synaptics: Replace NOOP with suitable commentary

2021-01-14 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’: drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Peter Ost

[PATCH v3 0/5] (Set 2/2) Rid W=1 issues from Input

2021-01-14 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is the second (and last) of 2 sets. v3: - Make use of 'ret' instead of removing it - Use __always_unused instead of removing unused variable

[PATCH 2/5] input: touchscreen: melfas_mip4: Mark a bunch of variables as __always_unused

2021-01-14 Thread Lee Jones
Dmitry requested to keep these around for the purposes of documentation. Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’: drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused

Re: Fw:Re:[RFC,v1,1/1] audit: speed up syscall rule match while exiting syscall

2021-01-14 Thread Paul Moore
On Thu, Jan 14, 2021 at 8:25 AM wrote: > > Performance measurements: > 1.Environment > CPU: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz > Linux kernel version: 5.11-rc3 > Audit version: 2.8.4 > > 2.Result > 2.1 Syscall invocations > Test method: > Run command "top" with no-load. > Add rule lik

[PATCH 4/5] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'

2021-01-14 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’: drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Henrik Rydber

[PATCH 3/5] input: touchscreen: usbtouchscreen: Actually check return value of usb_submit_urb()

2021-01-14 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’: drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Jame

[PATCH 5/5] input: touchscreen: stmpe-ts: Add description for 'prop' struct member

2021-01-14 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/stmpe-ts.c:82: warning: Function parameter or member 'prop' not described in 'stmpe_touch' Cc: Dmitry Torokhov Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: Stefan Riedmueller Cc: Luotao Fu Cc: linux-in...@vger.kerne

[PATCH v3 02/10] certs: Fix blacklisted hexadecimal hash string check

2021-01-14 Thread Mickaël Salaün
From: Mickaël Salaün When looking for a blacklisted hash, bin2hex() is used to transform a binary hash to an ascii (lowercase) hexadecimal string. This string is then search for in the description of the keys from the blacklist keyring. When adding a key to the blacklist keyring, blacklist_vet_

[PATCH v1 0/9] mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC

2021-01-14 Thread Muhammad Husaini Zulkifli
Hi, This patch series adds Ultra High Speed(UHS-1) Bus Speed Mode Support for Keem Bay SoC SD Card. Summary of each patches as per below: Patch 1: Use of_device_get_match_data() helper to get the match-data. Patch 2: Convert to use np pointer instead of using pdev->dev.of_node. Patch 3: Add stru

[PATCH v3 10/10] tools/certs: Add print-cert-tbs-hash.sh

2021-01-14 Thread Mickaël Salaün
From: Mickaël Salaün Add a new helper print-cert-tbs-hash.sh to generate a TBSCertificate hash from a given certificate. This is useful to generate a blacklist key description used to forbid loading a specific certificate in a keyring, or to invalidate a certificate provided by a PKCS#7 file. C

[PATCH v1 1/9] mmc: sdhci-of-arasan: use of_device_get_match_data()

2021-01-14 Thread Muhammad Husaini Zulkifli
Use of_device_get_match_data() helper to get the match-data. Signed-off-by: Muhammad Husaini Zulkifli Suggested-by: Andy Shevchenko Acked-by: Adrian Hunter Acked-by: Andy Shevchenko --- drivers/mmc/host/sdhci-of-arasan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/d

[PATCH v1 2/9] mmc: sdhci-of-arasan: Convert to use np instead of pdev->dev.of_node

2021-01-14 Thread Muhammad Husaini Zulkifli
Use np pointer to simplify code and improve readability. Signed-off-by: Muhammad Husaini Zulkifli Suggested-by: Andy Shevchenko Acked-by: Adrian Hunter Acked-by: Andy Shevchenko --- drivers/mmc/host/sdhci-of-arasan.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/

[PATCH v1 5/9] firmware: keembay: Add support for Trusted Firmware Service call

2021-01-14 Thread Muhammad Husaini Zulkifli
Export inline function to encapsulate AON_CFG1 for controling the I/O Rail supplied voltage levels which communicate with Trusted Firmware. Signed-off-by: Muhammad Husaini Zulkifli Acked-by: Andy Shevchenko --- include/linux/firmware/intel/keembay.h | 82 ++ 1 file chang

[PATCH v1 4/9] mmc: sdhci-of-arasan: Use dev_err_probe() to avoid spamming logs

2021-01-14 Thread Muhammad Husaini Zulkifli
Using dev_err_probe() can avoid spamming logs when probe is deferred. This function can also help to reduce code the size, uniform error handling and simplify the code. Signed-off-by: Muhammad Husaini Zulkifli Acked-by: Adrian Hunter Acked-by: Andy Shevchenko --- drivers/mmc/host/sdhci-of-aras

[PATCH v1 7/9] dt-bindings: regulator: keembay: Add DT binding documentation

2021-01-14 Thread Muhammad Husaini Zulkifli
Add DT Binding Documentation for Keem Bay SD Regulator. Signed-off-by: Muhammad Husaini Zulkifli --- .../bindings/regulator/keembay-regulator.yaml | 36 +++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/keembay-regulator.yaml d

[PATCH v1 6/9] dt-bindings: mmc: Update phy and regulator supply for Keem Bay SOC

2021-01-14 Thread Muhammad Husaini Zulkifli
Add DT bindings of vmmc, vqmmc and sdvrail supplies of regulator and phys for the phandle of sd0_phy which contain additional property for otap delay and sel_clk_buffer. Signed-off-by: Muhammad Husaini Zulkifli Acked-by: Adrian Hunter --- Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml

[PATCH v1 8/9] regulator: keembay: Add regulator for Keem Bay SoC

2021-01-14 Thread Muhammad Husaini Zulkifli
Keem Bay SD regulator driver module is added to encapsulate ARM Secure Monitor Call Calling Convention (SMCCC) during set voltage operations to control I/O Rail supplied voltage levels which communicate with Trusted Firmware. I/O Rail voltage need to be configure through AON_CFG1 Register by setti

[PATCH v1 3/9] mmc: sdhci-of-arasan: Add structure device pointer in probe function

2021-01-14 Thread Muhammad Husaini Zulkifli
Add struct device *dev in probe func() so that it can widely use in probe to make code more readable. Signed-off-by: Muhammad Husaini Zulkifli Acked-by: Adrian Hunter Acked-by: Andy Shevchenko --- drivers/mmc/host/sdhci-of-arasan.c | 34 +++--- 1 file changed, 17 insert

[PATCH v1 9/9] mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC

2021-01-14 Thread Muhammad Husaini Zulkifli
Keem Bay SOC can support dual voltage operations for GPIO SD pins to either 1.8V or 3.3V for bus IO line power. In order to operate the GPIOs line for Clk, Cmd and Data on Keem Bay hardware, it is important to configure the supplied voltage applied to their I/O Rail and the output of the I²C expand

Re: [PATCH v2 14/14] kasan: don't run tests when KASAN is not enabled

2021-01-14 Thread Andrey Konovalov
On Wed, Jan 13, 2021 at 5:39 PM Marco Elver wrote: > > On Wed, 13 Jan 2021 at 17:22, Andrey Konovalov wrote: > > > > Don't run KASAN tests when it's disabled with kasan.mode=off to avoid > > corrupting kernel memory. > > > > Link: > > https://linux-review.googlesource.com/id/I6447af436a69a94bfc3

Re: [PATCH v2 13/14] kasan: add a test for kmem_cache_alloc/free_bulk

2021-01-14 Thread Andrey Konovalov
On Wed, Jan 13, 2021 at 5:38 PM Marco Elver wrote: > > On Wed, 13 Jan 2021 at 17:22, Andrey Konovalov wrote: > > > > Add a test for kmem_cache_alloc/free_bulk to make sure there are now > > false-positives when these functions are used. > > s/now/no/ (but by itself doesn't necessarily demand a v3

Re: [PATCH 1/2] kasan, mm: fix conflicts with init_on_alloc/free

2021-01-14 Thread Andrey Konovalov
On Wed, Jan 13, 2021 at 6:25 PM Vlastimil Babka wrote: > > On 1/13/21 5:03 PM, Andrey Konovalov wrote: > > A few places where SLUB accesses object's data or metadata were missed in > > a previous patch. This leads to false positives with hardware tag-based > > KASAN when bulk allocations are used

Re: [PATCH] bcache: consider the fragmentation when update the writeback rate

2021-01-14 Thread Dongdong Tao
Hi Coly, Apologies for any confusion that I might have caused, and thanks a lot for your patience and your help ! On Thu, Jan 14, 2021 at 9:31 PM Coly Li wrote: > > On 1/14/21 8:22 PM, Dongdong Tao wrote: > > Hi Coly, > > > > Why you limit the iodeph to 8 and iops to 150 on cache device? > > For

Re: [PATCH 3/4] workqueue: Tag bound workers with KTHREAD_IS_PER_CPU

2021-01-14 Thread Peter Zijlstra
On Thu, Jan 14, 2021 at 01:21:26PM +, Valentin Schneider wrote: > On 14/01/21 14:12, Peter Zijlstra wrote: > > - WARN_ON_ONCE(set_cpus_allowed_ptr(worker->task, > > - pool->attrs->cpumask) < 0); > > + kthread_park(worker->task); >

Re: [External] Re: [PATCH v5 3/5] mm: hugetlb: fix a race between freeing and dissolving the page

2021-01-14 Thread Michal Hocko
On Thu 14-01-21 21:47:36, Muchun Song wrote: > On Thu, Jan 14, 2021 at 9:20 PM Michal Hocko wrote: [...] > > > @@ -1770,6 +1789,28 @@ int dissolve_free_huge_page(struct page *page) > > > int nid = page_to_nid(head); > > > if (h->free_huge_pages - h->resv_huge_pages == 0

[PATCH] spi: cadence: cache reference clock rate during probe

2021-01-14 Thread Alexandru Ardelean
From: Michael Hennerich The issue is that using SPI from a callback under the CCF lock will deadlock, since this code uses clk_get_rate(). Fixes: c474b38665463 ("spi: Add driver for Cadence SPI controller") Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- drivers/spi/spi

Re: [RFC PATCH bpf-next 1/2] bpf: share BTF "show" implementation between kernel and libbpf

2021-01-14 Thread Alan Maguire
On Mon, 11 Jan 2021, Andrii Nakryiko wrote: > On Mon, Jan 11, 2021 at 9:34 AM Alan Maguire wrote: > > Currently the only "show" function for userspace is to write the > > representation of the typed data to a string via > > > > LIBBPF_API int > > btf__snprintf(struct btf *btf, char *buf, int len,

Re: [PATCH net-next] net: mvpp2: extend mib-fragments name to mib-fragments-err

2021-01-14 Thread Andrew Lunn
On Thu, Jan 14, 2021 at 12:07:38PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > This patch doesn't change any functionality, but just extend > MIB counter register and ethtool-statistic names with "err". > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter. > Extend

hppa64-linux-ld: arch/parisc/kernel/setup.o(.text.unlikely+0x20): cannot reach __bitmap_weight

2021-01-14 Thread kernel test robot
-r023-20210114 (attached as .config) compiler: hppa64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux

Re: [PATCH 5/5] sched/fair: Merge select_idle_core/cpu()

2021-01-14 Thread Vincent Guittot
On Thu, 14 Jan 2021 at 14:53, Mel Gorman wrote: > > On Thu, Jan 14, 2021 at 02:25:32PM +0100, Vincent Guittot wrote: > > On Thu, 14 Jan 2021 at 10:35, Mel Gorman > > wrote: > > > > > > On Wed, Jan 13, 2021 at 06:03:00PM +0100, Vincent Guittot wrote: > > > > > @@ -6159,16 +6171,29 @@ static int s

Re: [dm-crypt] [PATCH] dm crypt: defer the decryption to a tasklet, when being called with interrupts disabled

2021-01-14 Thread Maciej S. Szmigiero
Hi Ignat, On 13.01.2021 20:17, Ignat Korchagin wrote: On some specific hardware on early boot we occasionally get [ 1193.920255][T0] BUG: sleeping function called from invalid context at mm/mempool.c:381 [ 1193.936616][T0] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 0, name

[PATCH v4 0/6] perf c2c: Code refactoring

2021-01-14 Thread Leo Yan
This patch series is for several minor code refactoring, which is extracted from the patch series "perf c2c: Sort cacheline with all loads" [1]. There has a known issue for Arm SPE store operations and Arm SPE is the only consumer for soring with all loads, this is the reason in this series drops

[PATCH v4 1/6] perf c2c: Rename for shared cache line stats

2021-01-14 Thread Leo Yan
For shared cache line statistics, it relies on HITM. We can use more general naming rather than only binding to HITM, so replace "hitm_stats" with "shared_clines_stats" in structure perf_c2c, and rename function resort_hitm_cb() to resort_shared_cl_cb(). Signed-off-by: Leo Yan Acked-by: Jiri Ols

[PATCH v4 3/6] perf c2c: Refactor display filter

2021-01-14 Thread Leo Yan
When sort on the respective metrics (lcl_hitm, rmt_hitm, tot_hitm), macro FILTER_HITM is to filter out the cache line entries if its overhead is less than 1%. This patch introduces static function filter_display() to replace macro; and refines its parameter with more flexbile way, rather than pass

[PATCH v4 5/6] perf c2c: Refactor node display

2021-01-14 Thread Leo Yan
The macro DISPLAY_HITM() is used to calculate HITM percentage introduced by every node and it's shown for the node info. This patch introduces the static function display_metrics() to replace the macro, and the parameters are refined for passing the metric's statistic value and the sum value. Sig

[PATCH v4 4/6] perf c2c: Fix argument type for percent()

2021-01-14 Thread Leo Yan
For percent(), its arguments are defined as integer type; this is not consistent with its consumers which pass arguments with u32 type. Thus this patch makes argument type as u32 for percent(). Signed-off-by: Leo Yan --- tools/perf/builtin-c2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v4 6/6] perf c2c: Add local variables for output metrics

2021-01-14 Thread Leo Yan
This patch adds several local variables: "cl_output": pointer for outputting single cache line metrics; "output_str": pointer for outputting cache line metrics; "sort_str": pointer to the sorting metrics. This can improve readability for the code and it's more flexible when later extend to

[PATCH 2/7] block: blk-crypto: Introduce blk_crypto_bio_sectors_alignment()

2021-01-14 Thread Satya Tangirala
The size of any bio must be aligned to the data unit size of the bio crypt context (if it exists) of that bio. This must also be ensured whenever a bio is split. Introduce blk_crypto_bio_sectors_alignment() that returns the required alignment in sectors. The number of sectors passed to any call of

[PATCH 1/7] block: make blk_bio_segment_split() able to fail and return error

2021-01-14 Thread Satya Tangirala
Till now, blk_bio_segment_split() always succeeded and returned a split bio if necessary. Instead, allow it to return an error code to indicate errors (and pass a pointer to the split bio as an argument instead). blk_bio_segment_split() is only called by __blk_queue_split(), which has been updated

[PATCH 0/7] ensure bios aren't split in middle of crypto data unit

2021-01-14 Thread Satya Tangirala
When a bio has an encryption context, its size must be aligned to its crypto data unit size. A bio must not be split in the middle of a data unit. Currently, bios are split at logical block boundaries, but a crypto data unit size might be larger than the logical block size - e.g. a machine could be

[PATCH 3/7] block: respect blk_crypto_bio_sectors_alignment() in bounce.c

2021-01-14 Thread Satya Tangirala
Make __blk_queue_bounce respect blk_crypto_bio_sectors_alignment() when calling bio_split(). Signed-off-by: Satya Tangirala --- block/bounce.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/bounce.c b/block/bounce.c index d3f51acd6e3b..7800e2a5a0f8 100644 --- a/block/bounce.c +++ b

[PATCH 7/7] block: compute nsegs more accurately in blk_bio_segment_split()

2021-01-14 Thread Satya Tangirala
Previously, we rounded down the number of sectors just before calling bio_split() in blk_bio_segment_split(). While this ensures that bios are not split in the middle of a data unit, it makes it possible for nsegs to be overestimated. This patch calculates nsegs accurately (it calculates the smalle

Re: [PATCH v2] mtd: rawnand: intel: check the mtd name only after setting the variable

2021-01-14 Thread Miquel Raynal
On Wed, 2021-01-06 at 14:09:43 UTC, Martin Blumenstingl wrote: > Move the check for mtd->name after the mtd variable has actually been > initialized. > > While here, also drop the NULL assignment to the mtd variable as it's > overwritten later on anyways and the NULL value is never read. > > Fixe

[PATCH v4 2/6] perf c2c: Refactor hist entry validation

2021-01-14 Thread Leo Yan
This patch has no any functionality changes but refactors hist entry validation for cache line resorting. It renames function "valid_hitm_or_store()" to "is_valid_hist_entry()", changes return type from integer type to bool type. In the function, it uses switch-case instead of ternary operators,

[PATCH 4/7] block: respect blk_crypto_bio_sectors_alignment() in blk-crypto-fallback

2021-01-14 Thread Satya Tangirala
Make blk_crypto_split_bio_if_needed() respect blk_crypto_bio_sectors_alignment() when calling bio_split(). Signed-off-by: Satya Tangirala --- block/blk-crypto-fallback.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c index c162b754

[PATCH 6/7] block: add WARN() in bio_split() for sector alignment

2021-01-14 Thread Satya Tangirala
The number of sectors passed to bio_split() should be aligned to blk_crypto_bio_sectors_alignment(). All callers have been updated to ensure this, so add a WARN() if the number of sectors is not aligned. Signed-off-by: Satya Tangirala --- block/bio.c | 1 + 1 file changed, 1 insertion(+) diff -

[PATCH 5/7] block: respect blk_crypto_bio_sectors_alignment() in blk-merge

2021-01-14 Thread Satya Tangirala
Make blk_bio_segment_split() respect blk_crypto_bio_sectors_alignment() when calling bio_split(). The number of sectors is rounded down to the required alignment just before the call to bio_split(). This makes it possible for nsegs to be overestimated, but this solution is a lot simpler than trying

Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-14 Thread Sergei Shtylyov
On 1/12/21 2:15 PM, Sergei Shtylyov wrote: [...] >> From: Menglong Dong >> >> Coccinelle reports a redundant error print in rb532_pata_driver_probe. >> As 'platform_get_irq' already prints the error message, error print >> here is redundant and can be removed. >> >> Signed-off-by: Menglong Dong

Re: [PATCH] printk: kmsg_dump: revert msg_print_text() workaround

2021-01-14 Thread Petr Mladek
On Thu 2021-01-14 10:11:11, John Ogness wrote: > The old msg_print_text() function only filled up to size-1 bytes of > the buffer. A workaround for this quirky behavior was implemented > with commit c9dccacfccc7 ("printk: Do not lose last line in kmsg > buffer dump"). > > However, with commit 896f

Re: [PATCH v2 02/14] KVM: SVM: Free sev_asid_bitmap during init if SEV setup fails

2021-01-14 Thread Tom Lendacky
On 1/13/21 6:36 PM, Sean Christopherson wrote: Free sev_asid_bitmap if the reclaim bitmap allocation fails, othwerise KVM will unnecessarily keep the bitmap when SEV is not fully enabled. Freeing the page is also necessary to avoid introducing a bug when a future patch eliminates svm_sev_enabled

Re: [RFC 1/1] s390/pci: expose UID checking state in sysfs

2021-01-14 Thread Niklas Schnelle
On 1/14/21 4:17 PM, Greg Kroah-Hartman wrote: > On Thu, Jan 14, 2021 at 04:06:11PM +0100, Niklas Schnelle wrote: >> >> >> On 1/14/21 2:58 PM, Greg Kroah-Hartman wrote: >>> On Thu, Jan 14, 2021 at 02:44:53PM +0100, Christian Brauner wrote: On Thu, Jan 14, 2021 at 02:20:10PM +0100, Niklas Sch

Re: [PATCH 4/6] sched/deadline: Block DL tasks on non-exclusive cpuset if bandwitdh control is enable

2021-01-14 Thread Dietmar Eggemann
On 12/01/2021 16:53, Daniel Bristot de Oliveira wrote: > The current SCHED_DEADLINE design supports only global scheduler, > or variants of it, i.e., clustered and partitioned, via cpuset config. > To enable the partitioning of a system with clusters of CPUs, the > documentation advises the usage o

Re: [PATCH V3] mtd: rawnand: qcom: update last code word register

2021-01-14 Thread Miquel Raynal
Hello, Md Sadre Alam wrote on Sun, 10 Jan 2021 09:31:45 +0530: > From QPIC version 2.0 onwards new register got added to a > read last codeword. This change will update the same. the? Pleas

Re: [PATCH] sched/core: Print out straggler tasks in sched_cpu_dying()

2021-01-14 Thread Valentin Schneider
On 14/01/21 07:22, Paul E. McKenney wrote: > If someone can identify Lai's series to me, I would be happy to give it > a try as well. All I see are workqueue-specific patches and patches > contributing to the discussion of possible fixes to the splats from > Peter's series. (I figured that I woul

Re: [PATCH v2 -next] mtd: st_spi_fsm: convert comma to semicolon

2021-01-14 Thread Miquel Raynal
On Fri, 2021-01-08 at 09:23:25 UTC, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel

Re: [PATCH v2 -next] mtd: rawnand: marvell: convert comma to semicolon

2021-01-14 Thread Miquel Raynal
On Fri, 2021-01-08 at 09:23:14 UTC, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel

Re: [PATCH v2 -next] mtd: convert comma to semicolon

2021-01-14 Thread Miquel Raynal
On Fri, 2021-01-08 at 09:23:00 UTC, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel

Re: [PATCH] x86/entry: Remove put_ret_addr_in_rdi THUNK macro argument

2021-01-14 Thread Peter Zijlstra
On Thu, Jan 14, 2021 at 02:28:09PM +0100, Borislav Petkov wrote: > On Thu, Jan 14, 2021 at 12:36:45PM +0100, Peter Zijlstra wrote: > > And while looking, I suppose we can delete the put_ret_addr_in_rdi crud, > > but that's another patch. > > --- > From: Borislav Petkov > Date: Thu, 14 Jan 2021 14

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-01-14 Thread Geert Uytterhoeven
Hi Daniel, CC linux-fbdev On Tue, Jan 12, 2021 at 5:00 PM Daniel Vetter wrote: > On Sat, Jan 9, 2021 at 12:11 AM Linus Torvalds > wrote: > > On Fri, Jan 8, 2021 at 11:13 AM Phillip Susi wrote: > > > > Could we pause this madness? Scrollback is still useful. I needed it > > > > today... it was

Re: [PATCH v2 01/14] KVM: SVM: Zero out the VMCB array used to track SEV ASID association

2021-01-14 Thread Tom Lendacky
On 1/13/21 6:36 PM, Sean Christopherson wrote: Zero out the array of VMCB pointers so that pre_sev_run() won't see garbage when querying the array to detect when an SEV ASID is being associated with a new VMCB. In practice, reading random values is all but guaranteed to be benign as a false nega

[PATCH] x86 mmiotrace: remove definition of DEBUG

2021-01-14 Thread trix
From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- arch/x86/mm/mmio-mod.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c index bd7aff5c51f7..cd768dafca9e 100644 --- a/arch/x86/mm/mmi

Re: [PATCH v6 12/16] net: tip: fix a couple kernel-doc markups

2021-01-14 Thread Jon Maloy
On 1/14/21 3:04 AM, Mauro Carvalho Chehab wrote: A function has a different name between their prototype and its kernel-doc markup: ../net/tipc/link.c:2551: warning: expecting prototype for link_reset_stats(). Prototype was for tipc_link_reset_stats() instead ../net/tipc/node

Re: RFC: printk: kmsg_dump_get_line_nolock() buffer overflow

2021-01-14 Thread John Ogness
On 2021-01-14, Petr Mladek wrote: > It is pitty that I have missed this. I remember that I discussed > exactly this problem before, see > https://lore.kernel.org/lkml/20190710080402.ab3f4qfnvez6d...@axis.com/ > > And I did exactly the same mistake. I have missed the two users in > "arch/powerpc" a

Re: [PATCH 4/5] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'

2021-01-14 Thread Benjamin Tissoires
On Thu, Jan 14, 2021 at 4:23 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/input/touchscreen/surface3_spi.c: In function > ‘surface3_spi_process_touch’: > drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ > set but not used [-Wu

Re: [PATCH v3 2/6] block: keyslot-manager: Introduce functions for device mapper support

2021-01-14 Thread Mike Snitzer
On Tue, Dec 29 2020 at 3:55am -0500, Satya Tangirala wrote: > Introduce blk_ksm_update_capabilities() to update the capabilities of > a keyslot manager (ksm) in-place. The pointer to a ksm in a device's > request queue may not be easily replaced, because upper layers like > the filesystem might

Re: [PATCH v9 3/4] ARM: dts: stm32: Fix schema warnings for pwm-leds

2021-01-14 Thread Alexandre TORGUE
Hi Alexander On 12/28/20 5:32 PM, Alexander Dahl wrote: The node names for devices using the pwm-leds driver follow a certain naming scheme (now). Parent node name is not enforced, but recommended by DT project. DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml CHECK arch/arm/boot/

RE: [PATCH 04/10] ABI: sysfs-firmware-sgi_uv

2021-01-14 Thread Ernst, Justin
> From: Mauro Carvalho Chehab [mailto:mche...@kernel.org] On Behalf Of Mauro > Carvalho Chehab > Sent: Thursday, January 14, 2021 1:54 AM > Subject: [PATCH 04/10] ABI: sysfs-firmware-sgi_uv > > Add a missing blank line required to identify a literal block, > fixing this warning: > > .../Do

Re: [PATCH v1 0/5] Enable fw_devlink=on by default

2021-01-14 Thread Jon Hunter
On 13/01/2021 21:26, Saravana Kannan wrote: > On Wed, Jan 13, 2021 at 3:30 AM Jon Hunter wrote: >> >> >> On 18/12/2020 03:16, Saravana Kannan wrote: >>> As discussed in LPC 2020, cyclic dependencies in firmware that couldn't >>> be broken using logic was one of the last remaining reasons >>> fw_

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 4:56 PM Geert Uytterhoeven wrote: > > Hi Daniel, > > CC linux-fbdev > > On Tue, Jan 12, 2021 at 5:00 PM Daniel Vetter wrote: > > On Sat, Jan 9, 2021 at 12:11 AM Linus Torvalds > > wrote: > > > On Fri, Jan 8, 2021 at 11:13 AM Phillip Susi wrote: > > > > > Could we pause t

Re: [RFC 1/1] s390/pci: expose UID checking state in sysfs

2021-01-14 Thread Greg Kroah-Hartman
On Thu, Jan 14, 2021 at 04:51:17PM +0100, Niklas Schnelle wrote: > > > On 1/14/21 4:17 PM, Greg Kroah-Hartman wrote: > > On Thu, Jan 14, 2021 at 04:06:11PM +0100, Niklas Schnelle wrote: > >> > >> > >> On 1/14/21 2:58 PM, Greg Kroah-Hartman wrote: > >>> On Thu, Jan 14, 2021 at 02:44:53PM +0100, Ch

WARNING in memdup_user_nul

2021-01-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:65f0d241 Merge tag 'sound-5.11-rc4' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11753ee0d0 kernel config: https://syzkaller.appspot.com/x/.config?x=ee2266946ed36986 das

KMSAN: uninit-value in nf_conntrack_udplite_packet (2)

2021-01-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=11eb6ce750 kernel config: https://syzkaller.appspot.co

RE: [EXT] Re: [PATCH net-next] net: mvpp2: extend mib-fragments name to mib-fragments-err

2021-01-14 Thread Stefan Chulski
> > From: Stefan Chulski > > > > This patch doesn't change any functionality, but just extend MIB > > counter register and ethtool-statistic names with "err". > > > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter. > > Extend REG name and appropriated ethtool statistic reg-name with

Re: [External] Re: [PATCH v5 3/5] mm: hugetlb: fix a race between freeing and dissolving the page

2021-01-14 Thread Muchun Song
On Thu, Jan 14, 2021 at 11:38 PM Michal Hocko wrote: > > On Thu 14-01-21 21:47:36, Muchun Song wrote: > > On Thu, Jan 14, 2021 at 9:20 PM Michal Hocko wrote: > [...] > > > > @@ -1770,6 +1789,28 @@ int dissolve_free_huge_page(struct page *page) > > > > int nid = page_to_nid(head); >

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2021-01-14 Thread Sebastian Andrzej Siewior
On 2020-12-20 08:21:37 [+0100], Vitaly Wool wrote: > Not really because bit spinlock leaves preemption disabled. It leaves it disabled for a reason. Now you just spin until the original context gets back on the CPU. On UP with preemption, if the "lock owner" gets preempted, the next lock attempt w

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2021-01-14 Thread Sebastian Andrzej Siewior
On 2020-12-23 19:25:02 [+0100], Vitaly Wool wrote: > > write the following patch according to your idea, what do you think ? > > Yep, that is basically what I was thinking of. Some nitpicks below: Did this go somewhere? The thread just ends here on my end. Mike, is this patch fixing / helping you

Re: Redesigning and modernising fscache

2021-01-14 Thread Matthew Wilcox
On Thu, Jan 14, 2021 at 10:45:06AM +, David Howells wrote: > However, there've been some objections to the approach I've taken to > implementing this. The way I've done it is to disable the use of fscache by > the five network filesystems that use it, remove much of the old code, put in > the

Re: [RFC PATCH v3 09/16] cxl/mem: Add basic IOCTL interface

2021-01-14 Thread Jonathan Cameron
On Mon, 11 Jan 2021 14:51:13 -0800 Ben Widawsky wrote: > Add a straightforward IOCTL that provides a mechanism for userspace to > query the supported memory device commands. CXL commands as they appear > to userspace are described as part of the UAPI kerneldoc. The command > list returned via thi

Re: [PATCH 2/2] phy: stm32: register usbphyc as clock provider of ck_usbo_48m clock

2021-01-14 Thread kernel test robot
Hi Amelie, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20210114] [cannot apply to robh/for-next stm32/stm32-next phy/next v5.11-rc3 v5.11-rc2 v5.11-rc1 v5.11-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v10 8/8] selinux: include a consumer of the new IMA critical data hook

2021-01-14 Thread Lakshmi Ramasubramanian
On 1/13/21 6:49 PM, Mimi Zohar wrote: Hi Mimi, I remain concerned about the possibility of bypassing a measurement by tampering with the time, but I appear to be the only one who is worried about this so I'm not going to block this patch on those grounds. Acked-by: Paul Moore Thanks, Paul.

[PATCH v3 0/3] Adding the Sparx5 Switch Reset Driver

2021-01-14 Thread Steen Hegelund
This series provides the Microchip Sparx5 Switch Reset Driver The Sparx5 Switch SoC has a number of components that can be reset individually, but at least the Switch Core needs to be in a well defined state at power on, when any of the Sparx5 drivers starts to access the Switch Core, this reset d

[PATCH v3 2/3] reset: mchp: sparx5: add switch reset driver

2021-01-14 Thread Steen Hegelund
Signed-off-by: Steen Hegelund --- drivers/reset/Kconfig | 8 ++ drivers/reset/Makefile | 1 + drivers/reset/reset-microchip-sparx5.c | 120 + 3 files changed, 129 insertions(+) create mode 100644 drivers/reset/reset-microchip-sparx5.c

[PATCH v3 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver

2021-01-14 Thread Steen Hegelund
Signed-off-by: Steen Hegelund --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi index 380281f312d8..4edbb9fcdce0 100644 --- a/arch

[PATCH v3 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings

2021-01-14 Thread Steen Hegelund
Signed-off-by: Steen Hegelund --- .../bindings/reset/microchip,rst.yaml | 59 +++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/reset/microchip,rst.yaml diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Doc

[PATCH] x86/mm/mtrr: remove definition of DEBUG

2021-01-14 Thread trix
From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- arch/x86/kernel/cpu/mtrr/generic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index a29997e6cf9e..b90f3f

Re: [RFC PATCH v3 08/16] cxl/mem: Register CXL memX devices

2021-01-14 Thread Jonathan Cameron
On Mon, 11 Jan 2021 14:51:12 -0800 Ben Widawsky wrote: > From: Dan Williams > > Create the /sys/bus/cxl hierarchy to enumerate memory devices > (per-endpoint control devices), memory address space devices (platform > address ranges with interleaving, performance, and persistence > attributes),

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2021-01-14 Thread Vitaly Wool
On Thu, 14 Jan 2021, 17:18 Sebastian Andrzej Siewior, wrote: > > On 2020-12-23 19:25:02 [+0100], Vitaly Wool wrote: > > > write the following patch according to your idea, what do you think ? > > > > Yep, that is basically what I was thinking of. Some nitpicks below: > > Did this go somewhere? The

Re: [PATCH 0/3] usb: dwc2: Fixes and improvements

2021-01-14 Thread Guenter Roeck
On Thu, Jan 14, 2021 at 10:26:25AM +0100, Nicolas Saenz Julienne wrote: > Hi Guenter, Doug, thanks for having a look at this. > > On Wed, 2021-01-13 at 19:07 -0800, Guenter Roeck wrote: > > On Wed, Jan 13, 2021 at 03:20:55PM -0800, Doug Anderson wrote: > > > Hi, > > > > > [ ... ] > > > > > > It'

Re: [PATCH] iommu/arm-smmu-v3: Handle duplicated Stream IDs from other masters

2021-01-14 Thread Robin Murphy
On 2021-01-12 20:29, Ajay Kumar wrote: On Tue, Jan 12, 2021 at 12:57 AM Robin Murphy wrote: On 2021-01-07 13:03, Will Deacon wrote: On Thu, Jan 07, 2021 at 03:03:40PM +0530, Ajay Kumar wrote: When PCI function drivers(ex:pci-endpoint-test) are probed for already initialized PCIe-RC(Root Comp

Re: [PATCH] x86/lib: don't use MMX before FPU initialization

2021-01-14 Thread Andy Lutomirski
On Thu, Jan 14, 2021 at 6:51 AM Krzysztof Mazur wrote: > > On Thu, Jan 14, 2021 at 03:07:37PM +0100, Borislav Petkov wrote: > > On Thu, Jan 14, 2021 at 01:36:57PM +0100, Krzysztof Mazur wrote: > > > The OSFXSR must be set only on CPUs with SSE. There > > > are some CPUs with 3DNow!, but without SS

Re: [PATCH v2 3/6] perf stat: Basic support for iiostat in perf

2021-01-14 Thread Alexander Antonov
On 1/14/2021 6:34 AM, Namhyung Kim wrote: Hello, On Wed, Jan 13, 2021 at 8:34 PM Alexander Antonov wrote: On 1/6/2021 11:56 AM, Namhyung Kim wrote: On Wed, Dec 23, 2020 at 10:03 PM Alexander Antonov wrote: Add basic flow for a new iiostat mode in perf. Mode is intended to provide four I/

Re: [PATCH v5 1/4] pinctrl: qcom: Allow SoCs to specify a GPIO function that's not 0

2021-01-14 Thread Bjorn Andersson
On Fri 08 Jan 11:35 CST 2021, Douglas Anderson wrote: > There's currently a comment in the code saying function 0 is GPIO. > Instead of hardcoding it, let's add a member where an SoC can specify > it. No known SoCs use a number other than 0, but this just makes the > code clearer. NOTE: no SoC c

<    1   2   3   4   5   6   7   8   9   10   >