[PATCH v6 0/4] Introduce perf-stat -b for BPF programs

2020-12-28 Thread Song Liu
This set introduces perf-stat -b option to count events for BPF programs. This is similar to bpftool-prog-profile. But perf-stat makes it much more flexible. Changes v5 => v6 1. Update the name for bootstrap bpftool. (Jiri) Changes v4 => v5: 1. Add documentation. (Jiri) 2. Silent make outpu

[PATCH v6 3/4] perf-stat: enable counting events for BPF programs

2020-12-28 Thread Song Liu
Introduce perf-stat -b option, which counts events for BPF programs, like: [root@localhost ~]# ~/perf stat -e ref-cycles,cycles -b 254 -I 1000 1.487903822115,200 ref-cycles 1.487903822 86,012 cycles 2.489147029 80,560 ref-cycles

[PATCH v6 1/4] bpftool: add Makefile target bootstrap

2020-12-28 Thread Song Liu
This target is used to only build the bootstrap bpftool, which will be used to generate bpf skeletons for other tools, like perf. Signed-off-by: Song Liu --- tools/bpf/bpftool/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile i

[PATCH v6 4/4] perf-stat: add documentation for -b option

2020-12-28 Thread Song Liu
Add documentation to perf-stat -b option, which stats event for BPF programs. Signed-off-by: Song Liu --- tools/perf/Documentation/perf-stat.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt in

[PATCH v6 2/4] perf: support build BPF skeletons with perf

2020-12-28 Thread Song Liu
BPF programs are useful in perf to profile BPF programs. BPF skeleton is by far the easiest way to write BPF tools. Enable building BPF skeletons in util/bpf_skel. A dummy bpf skeleton is added. More bpf skeletons will be added for different use cases. Acked-by: Jiri Olsa Signed-off-by: Song Liu

[GIT PULL] cgroup changes for v5.11-rc1

2020-12-28 Thread Tejun Heo
Hello, Linus. These three patches were scheduled for the merge window but I forgot to send them out. Sorry about that. None of them are significant and they fit well in a fix pull request too - two are cosmetic and one fixes a memory leak in the mount option parsing path. Thanks and happy holiday

Re: [PATCH v3 05/14] software_node: unregister software_nodes in reverse order

2020-12-28 Thread Andy Shevchenko
On Mon, Dec 28, 2020 at 06:34:10PM +0200, Sakari Ailus wrote: > On Thu, Dec 24, 2020 at 01:08:58AM +, Daniel Scally wrote: ... > > void software_node_unregister_node_group(const struct software_node > > **node_group) > > With this line wrapped, Why? It's only one character behind 80 and w

[GIT PULL] workqueue changes for v5.11-rc1

2020-12-28 Thread Tejun Heo
Hello, again. The same as the cgroup tree - one commit which was scheduled for the 5.11 merge window. All the commit does is avoding spurious worker wakeups from workqueue allocation / config change path to help cpuisol use cases. Thank you. The following changes since commit 127c501a03d5db8b833

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-28 Thread Bjorn Andersson
On Tue 22 Dec 07:49 CST 2020, Ziqi Chen wrote: > As per specs, e.g, JESD220E chapter 7.2, while powering > off/on the ufs device, RST_N signal and REF_CLK signal > should be between VSS(Ground) and VCCQ/VCCQ2. > > To flexibly control device reset line, refactor the function > ufschd_vops_device_r

Re: [PATCH 2/2] arm64: dts: imx8mm: Add Gateworks IMX8MM Development Kits

2020-12-28 Thread Tim Harvey
On Thu, Dec 24, 2020 at 7:34 AM Sven Van Asbroeck wrote: > > Tim, Anders, > > On Wed, Dec 23, 2020 at 5:45 PM Tim Harvey wrote: > > > > - 2x RJ45 GbE (IMX8MM FEC and LAN743x) > > I noticed that you are users of the LAN743x PCIe ethernet chip. > > On non-cache snooping architectures such as ARM,

Re: [PATCH v23 02/23] LSM: Create and manage the lsmblob data structure.

2020-12-28 Thread Mimi Zohar
Hi Casey, On Fri, 2020-11-20 at 12:14 -0800, Casey Schaufler wrote: > When more than one security module is exporting data to > audit and networking sub-systems a single 32 bit integer > is no longer sufficient to represent the data. Add a > structure to be used instead. > > The lsmblob structure

Re: [PATCH] Documentation/submitting-patches: Add blurb about backtraces in commit messages

2020-12-28 Thread Sean Christopherson
On Tue, Dec 22, 2020, Borislav Petkov wrote: > On Tue, Dec 22, 2020 at 10:59:22AM -0800, Sean Christopherson wrote: > > On Tue, Dec 22, 2020, Borislav Petkov wrote: > > > +Backtraces help document the call chain leading to a problem. However, > > > +not all backtraces are helpful. For example, earl

Re: [PATCH 2/3] arm64: dts: qcom: sm8150: Add PSCI idle states

2020-12-28 Thread Bjorn Andersson
On Tue 22 Dec 20:00 CST 2020, Danny Lin wrote: > On Sun, Dec 20, 2020 at 7:48 PM, Bjorn Andersson wrote: > > On Sun 20 Dec 16:29 PST 2020, Danny Lin wrote: > > > > > Like other Qualcomm SoCs, sm8150 exposes CPU and cluster idle states > > > through PSCI. Define the idle states to save power when

Re: [PATCH 3/6] mremap: Don't allow MREMAP_DONTUNMAP on special_mappings and aio

2020-12-28 Thread Brian Geffon
I don't think this situation can ever happen MREMAP_DONTUNMAP is already restricted to anonymous mappings (defined as not having vm_ops) and vma_to_resize checks that the mapping is anonymous before move_vma is called. On Mon, Oct 12, 2020 at 6:34 PM Dmitry Safonov wrote: > > As kernel expect t

Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-28 Thread Andy Lutomirski
On Mon, Dec 28, 2020 at 9:23 AM Russell King - ARM Linux admin wrote: > > On Mon, Dec 28, 2020 at 09:14:23AM -0800, Andy Lutomirski wrote: > > On Mon, Dec 28, 2020 at 2:25 AM Russell King - ARM Linux admin > > wrote: > > > > > > On Sun, Dec 27, 2020 at 01:36:13PM -0800, Andy Lutomirski wrote: > >

Re: [PATCH] Documentation/submitting-patches: Add blurb about backtraces in commit messages

2020-12-28 Thread Borislav Petkov
On Mon, Dec 28, 2020 at 09:59:48AM -0800, Sean Christopherson wrote: > Obvious and superfluous for people that are intimately familiar with the code, > but explicit call stacks are extremely helpful when (re)learning code. Here's an example: [2.649874] x86/mm: Checked W+X mappings: passed, no

Re: [PATCH 2/6] mm/mremap: For MREMAP_DONTUNMAP check security_vm_enough_memory_mm()

2020-12-28 Thread Brian Geffon
This looks good to me with a small comment. > if (do_munmap(mm, old_addr, old_len, uf_unmap) < 0) { > /* OOM: unable to split vma, just get accounts right */ > - if (vm_flags & VM_ACCOUNT) > + if (vm_flags & VM_ACCOUNT && !(flags & MREMAP_DONTUNM

Re: + proc-wchan-use-printk-format-instead-of-lookup_symbol_name-fix.patch added to -mm tree

2020-12-28 Thread Alexey Dobriyan
On Tue, Dec 22, 2020 at 06:18:34PM -0800, a...@linux-foundation.org wrote: > > proc-wchan-use-printk-format-instead-of-lookup_symbol_name-fix.patch > --- > a/fs/proc/base.c~proc-wchan-use-printk-format-instead-of-lookup_symbol_name-fix > +++ a/fs/proc/base.c > @@ -384,15 +384,8 @@ static con

Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-28 Thread Jann Horn
On Mon, Dec 28, 2020 at 6:14 PM Andy Lutomirski wrote: > On Mon, Dec 28, 2020 at 2:25 AM Russell King - ARM Linux admin > wrote: > > > > On Sun, Dec 27, 2020 at 01:36:13PM -0800, Andy Lutomirski wrote: > > > On Sun, Dec 27, 2020 at 12:18 PM Mathieu Desnoyers > > > wrote: > > > > > > > > - On

Re: [PATCH] EDAC/amd64: Tone down messages about missing PCI IDs

2020-12-28 Thread Borislav Petkov
On Tue, Dec 15, 2020 at 05:01:31PM +, Yazen Ghannam wrote: > From: Yazen Ghannam > > Give these messages a debug severity as they are really only useful to > the module developers. > > Also, drop the "(broken BIOS?)" phrase, since this can cause churn for > BIOS folks. The PCI IDs needed by

[PATCH v1] misc: pvpanic: Check devm_ioport_map() for NULL

2020-12-28 Thread Andy Shevchenko
Inconveniently devm_ioport_map() and devm_ioremap_resource() return errors differently, i.e. former uses simply NULL pointer, while the latter an error pointer. Due to this, we have to check each of them separately. Fixes: f104060813fe ("misc: pvpanic: Combine ACPI and platform drivers") Signed-o

ERROR: ".of_device_get_match_data" undefined!

2020-12-28 Thread kernel test robot
Hi Shengjiu, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5c8fe583cce542aa0b84adc939ce85293de36e5e commit: c05f10f28ef697aae8f1d82012d660af3cfc8cf9 ASoC: fsl_asrc: Add support for imx8qm & imx8qxp date: 12 mo

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-28 Thread Linus Torvalds
On Mon, Dec 28, 2020 at 4:53 AM Kirill A. Shutemov wrote: > > So far I only found one more pin leak and always-true check. I don't see > how can it lead to crash or corruption. Keep looking. Well, I noticed that the nommu.c version of filemap_map_pages() needs fixing, but that's obviously not the

Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-28 Thread Andy Lutomirski
On Mon, Dec 28, 2020 at 10:30 AM Jann Horn wrote: > > On Mon, Dec 28, 2020 at 6:14 PM Andy Lutomirski wrote: > > On Mon, Dec 28, 2020 at 2:25 AM Russell King - ARM Linux admin > > wrote: > > > > > > On Sun, Dec 27, 2020 at 01:36:13PM -0800, Andy Lutomirski wrote: > > > > On Sun, Dec 27, 2020 at

Re: [PATCH 5.10 098/717] net: evaluate net.ipvX.conf.all.ignore_routes_with_linkdown

2020-12-28 Thread Jakub Kicinski
On Mon, 28 Dec 2020 13:41:36 +0100 Greg Kroah-Hartman wrote: > From: Vincent Bernat > > [ Upstream commit c0c5a60f0f1311bcf08bbe735122096d6326fb5b ] > > Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl > ignores a route whose interface is down. It is provided as a > per-inter

Re: [PATCH v1 04/19] x86/insn-eval: Handle return values from the decoder

2020-12-28 Thread Sean Christopherson
On Wed, Dec 23, 2020, Borislav Petkov wrote: > From: Borislav Petkov > > Now that the different instruction-inspecting functions return a value, > test that and return early from callers if error has been encountered. > > While at it, do not call insn_get_modrm() when calling > insn_get_displacem

Re: [PATCH 5.10 462/717] ice, xsk: clear the status bits for the next_to_use descriptor

2020-12-28 Thread Jakub Kicinski
On Mon, 28 Dec 2020 13:47:40 +0100 Greg Kroah-Hartman wrote: > From: Björn Töpel > > [ Upstream commit 8d14768a7972b92c73259f0c9c45b969d85e3a60 ] > > On the Rx side, the next_to_use index points to the next item in the > HW ring to be refilled/allocated, and next_to_clean points to the next > it

Re: Linux 5.11-rc1

2020-12-28 Thread Linus Torvalds
On Mon, Dec 28, 2020 at 7:51 AM Guenter Roeck wrote: > > Build results: > total: 153 pass: 151 fail: 2 Thanks for doing these for the mainline rc's too. I've seen them for the stable kernels, but it's lovely to see it for rc1. > ERROR: modpost: "irq_check_status_bit" [drivers/perf/arm_sp

Re: [PATCH] Documentation/submitting-patches: Add blurb about backtraces in commit messages

2020-12-28 Thread Sean Christopherson
On Mon, Dec 28, 2020, Borislav Petkov wrote: > On Mon, Dec 28, 2020 at 09:59:48AM -0800, Sean Christopherson wrote: > > Obvious and superfluous for people that are intimately familiar with the > > code, > > but explicit call stacks are extremely helpful when (re)learning code. > > Here's an examp

Re: [PATCH 2/2] arm64: dts: imx8mm: Add Gateworks IMX8MM Development Kits

2020-12-28 Thread Tim Harvey
On Thu, Dec 24, 2020 at 3:37 AM Krzysztof Kozlowski wrote: > Thanks for the review! > On Wed, Dec 23, 2020 at 02:23:16PM -0800, Tim Harvey wrote: > > The Gateworks Venice GW71xx-0x/GW72xx-0x/GW73xx-0x are development > > kits comprised of a GW700x SoM and a Baseboard. > > > > The GW700x SoM cont

Re: [PATCH] mm, slub: Consider rest of partial list if acquire_slab() fails

2020-12-28 Thread David Rientjes
On Mon, 28 Dec 2020, Jann Horn wrote: > acquire_slab() fails if there is contention on the freelist of the page > (probably because some other CPU is concurrently freeing an object from the > page). In that case, it might make sense to look for a different page > (since there might be more remote

Re: [PATCH v1 04/19] x86/insn-eval: Handle return values from the decoder

2020-12-28 Thread Borislav Petkov
On Mon, Dec 28, 2020 at 10:51:15AM -0800, Sean Christopherson wrote: > This patch is incomplete/inconsistent, and arguably wrong. > > - get_eff_addr_reg() and get_eff_addr_modrm() still ignore the return of > insn_get_modrm() after this patch. Ah, will fix, thx. > - Calling insn_get_modr

Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-28 Thread Russell King - ARM Linux admin
On Mon, Dec 28, 2020 at 07:29:34PM +0100, Jann Horn wrote: > After chatting with rmk about this (but without claiming that any of > this is his opinion), based on the manpage, I think membarrier() > currently doesn't really claim to be synchronizing caches? It just > serializes cores. So arguably i

[ANNOUNCE] Git v2.30.0

2020-12-28 Thread Junio C Hamano
The latest feature release Git v2.30.0 is now available at the usual places. It comprises 495 non-merge commits since v2.29.0, contributed by 83 people, 29 of which are new faces. The tarballs are found at: https://www.kernel.org/pub/software/scm/git/ The following public repositories all h

Re: [RFC V1 0/7] Introduce AVX512 optimized crypto algorithms

2020-12-28 Thread Dey, Megha
Hi Eric, On 12/21/2020 3:20 PM, Eric Biggers wrote: On Fri, Dec 18, 2020 at 01:10:57PM -0800, Megha Dey wrote: Optimize crypto algorithms using VPCLMULQDQ and VAES AVX512 instructions (first implemented on Intel's Icelake client and Xeon CPUs). These algorithms take advantage of the AVX512 reg

Re: [PATCH v2 0/3] cpufreq: Allow drivers to receive more information from the governor

2020-12-28 Thread Rafael J. Wysocki
On Wed, Dec 23, 2020 at 2:08 PM Giovanni Gherdovich wrote: > > On Mon, 2020-12-21 at 17:11 +0100, Rafael J. Wysocki wrote: > > Hi, > > > > On Fri, Dec 18, 2020 at 5:22 PM Giovanni Gherdovich wrote: > > > > > > Gitsource: this test show the most compelling case against the > > > sugov-HWP.desir

Re: [PATCH 2/6] mm/mremap: For MREMAP_DONTUNMAP check security_vm_enough_memory_mm()

2020-12-28 Thread Dmitry Safonov
On 12/28/20 6:21 PM, Brian Geffon wrote: > This looks good to me with a small comment. > >> if (do_munmap(mm, old_addr, old_len, uf_unmap) < 0) { >> /* OOM: unable to split vma, just get accounts right */ >> - if (vm_flags & VM_ACCOUNT) >> + if (

Re: [PATCH v1 11/19] x86/sev-es: Convert to insn_decode()

2020-12-28 Thread Sean Christopherson
On Fri, Dec 25, 2020, Borislav Petkov wrote: > On Fri, Dec 25, 2020 at 06:50:33PM +0800, kernel test robot wrote: > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >> arch/x86/kernel/sev-es

Re: [PATCH 2/2] arm64: dts: imx8mm: Add Gateworks IMX8MM Development Kits

2020-12-28 Thread Krzysztof Kozlowski
On Mon, Dec 28, 2020 at 11:02:40AM -0800, Tim Harvey wrote: > > + > > > +&i2c1 { > > > + clock-frequency = <10>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_i2c1>; > > > + status = "okay"; > > > + > > > + gsc: gsc@20 { > > > > Node name should describe

Re: [PATCH v23 02/23] LSM: Create and manage the lsmblob data structure.

2020-12-28 Thread Casey Schaufler
On 12/28/2020 9:54 AM, Mimi Zohar wrote: > Hi Casey, > > On Fri, 2020-11-20 at 12:14 -0800, Casey Schaufler wrote: >> When more than one security module is exporting data to >> audit and networking sub-systems a single 32 bit integer >> is no longer sufficient to represent the data. Add a >> struct

Re: [PATCH v23 02/23] LSM: Create and manage the lsmblob data structure.

2020-12-28 Thread Mimi Zohar
Hi Casey, On Fri, 2020-11-20 at 12:14 -0800, Casey Schaufler wrote: > diff --git a/security/security.c b/security/security.c > index 5da8b3643680..d01363cb0082 100644 > --- a/security/security.c > +++ b/security/security.c > > @@ -2510,7 +2526,24 @@ int security_key_getsecurity(struct key *key, c

Re: [PATCH 3/3] overlayfs: Report writeback errors on upper

2020-12-28 Thread Sargun Dhillon
On Mon, Dec 28, 2020 at 9:26 AM Jeff Layton wrote: > > On Mon, 2020-12-28 at 15:56 +, Matthew Wilcox wrote: > > On Mon, Dec 28, 2020 at 08:25:50AM -0500, Jeff Layton wrote: > > > To be clear, the main thing you'll lose with the method above is the > > > ability to see an unseen error on a newl

[PATCH] block: add debugfs stanza for QUEUE_FLAG_NOWAIT.

2020-12-28 Thread Andres Freund
This was missed in 021a24460dc2. Leads to the numeric value of QUEUE_FLAG_NOWAIT (i.e. 29) showing up in /sys/kernel/debug/block/*/state. Fixes: 021a24460dc28e7412aecfae89f60e1847e685c0 Cc: Konstantin Khlebnikov Cc: Mike Snitzer Cc: Christoph Hellwig Cc: Jens Axboe Signed-off-by: Andres Freund

[PATCH] dt-bindings: mfd: gateworks-gsc: Add fan-tach mode

2020-12-28 Thread Tim Harvey
In 7497d4a66c59 ("hwmon: (gsc-hwmon) add fan sensor") a mode was added to report RPM's from a fan tach input. Add this mode to the dt-bindings for the Gateworks System Controller. Signed-off-by: Tim Harvey --- Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml | 3 ++- 1 file changed, 2 i

Re: [PATCH AUTOSEL 5.7 03/30] ima: extend boot_aggregate with kernel measurements

2020-12-28 Thread Ken Goldman
On 12/12/2020 9:22 PM, Mimi Zohar wrote: Ok. Going forward, it sounds like we need to define a new "boot_aggregate" record. One that contains a version number and PCR mask. Just BTW, there is a TCG standard for a TPM 2.0 PCR mask that works well. There is also a standard for an event log ve

Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-28 Thread Andy Shevchenko
On Mon, Dec 28, 2020 at 10:37:38PM +, Daniel Scally wrote: > On 28/12/2020 17:05, Sakari Ailus wrote: > > On Thu, Dec 24, 2020 at 02:54:44PM +0200, Andy Shevchenko wrote: ... > >>> +#include > >>> + > >>> +#define CIO2_HID "INT343E" > >>> +#define CIO2_NUM_PORTS

Re: [PATCH] arch: mips: Remove unused BOARD_INGENIC Kconfig option

2020-12-28 Thread Thomas Bogendoerfer
On Tue, Dec 22, 2020 at 09:32:39PM +0100, Bert Vermeulen wrote: > Board support depends on MACH_INGENIC, not BOARD_INGENIC. you are missing the point here. BOARD_INGENIC is for enabling Ingenic boards in a generic kernel, while MACH_INGENIC is for building a Ingenic only kernel (usually for size/p

Re: [PATCH v4] net: neighbor: fix a crash caused by mod zero

2020-12-28 Thread David Miller
From: weichenchen Date: Fri, 25 Dec 2020 13:44:45 +0800 > pneigh_enqueue() tries to obtain a random delay by mod > NEIGH_VAR(p, PROXY_DELAY). However, NEIGH_VAR(p, PROXY_DELAY) > migth be zero at that point because someone could write zero > to /proc/sys/net/ipv4/neigh/[device]/proxy_delay after

Re: [PATCH] MIPS: No need to check CPU 0 in cps_cpu_disable()

2020-12-28 Thread Thomas Bogendoerfer
On Tue, Dec 15, 2020 at 01:07:26PM +0800, Tiezhu Yang wrote: > After commit 9cce844abf07 ("MIPS: CPU#0 is not hotpluggable"), > c->hotpluggable is 0 for CPU 0 and it will not generate a control > file in sysfs for this CPU: > > [root@linux loongson]# cat /sys/devices/system/cpu/cpu0/online > cat:

Re: [PATCH -next] mips: kernel: convert comma to semicolon

2020-12-28 Thread Thomas Bogendoerfer
On Wed, Dec 16, 2020 at 09:08:51PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > arch/mips/kernel/cevt-txx9.c | 2 +- > arch/mips/kernel/vpe-mt.c| 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-)

Re: [Aspeed, v2 2/2] net: ftgmac100: Change the order of getting MAC address

2020-12-28 Thread Jakub Kicinski
On Tue, 22 Dec 2020 22:00:34 +0100 Andrew Lunn wrote: > On Tue, Dec 22, 2020 at 09:46:52PM +0100, Heiner Kallweit wrote: > > On 22.12.2020 21:14, Hongwei Zhang wrote: > > > Dear Reviewer, > > > > > > Use native MAC address is preferred over other choices, thus change the > > > order > > > of re

Re: [PATCH -next] mips: pci: convert comma to semicolon

2020-12-28 Thread Thomas Bogendoerfer
On Wed, Dec 16, 2020 at 09:10:04PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > arch/mips/kernel/vpe-cmp.c | 4 ++-- > arch/mips/pci/pci-ar2315.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-28 Thread Linus Torvalds
On Mon, Dec 28, 2020 at 10:47 AM Linus Torvalds wrote: > > I personally think it's wrong to update vmf->pte at all. We should > just have a local 'ptep' pointer that we update as we walk along. But > that requires another change to the calling convention, namely to > "do_set_pte()". Actually, I t

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-28 Thread Kirill A. Shutemov
On Tue, Dec 29, 2020 at 01:05:48AM +0300, Kirill A. Shutemov wrote: > On Mon, Dec 28, 2020 at 10:47:36AM -0800, Linus Torvalds wrote: > > On Mon, Dec 28, 2020 at 4:53 AM Kirill A. Shutemov > > wrote: > > > > > > So far I only found one more pin leak and always-true check. I don't see > > > how ca

Re: [PATCH net 0/2] net: ipa: fix some new build warnings

2020-12-28 Thread Jakub Kicinski
On Sat, 26 Dec 2020 15:37:35 -0600 Alex Elder wrote: > I got a super friendly message from the Intel kernel test robot that > pointed out that two patches I posted last week caused new build > warnings. I already had these problems fixed in my own tree but > the fix was not included in what I sent

Re: [PATCH v23 02/23] LSM: Create and manage the lsmblob data structure.

2020-12-28 Thread Mimi Zohar
On Mon, 2020-12-28 at 12:06 -0800, Casey Schaufler wrote: > On 12/28/2020 11:24 AM, Mimi Zohar wrote: > > Hi Casey, > > > > On Fri, 2020-11-20 at 12:14 -0800, Casey Schaufler wrote: > >> diff --git a/security/security.c b/security/security.c > >> index 5da8b3643680..d01363cb0082 100644 > >> --- a/s

Re: [PATCH net 0/2] net: ipa: fix some new build warnings

2020-12-28 Thread Alex Elder
On 12/28/20 4:14 PM, Jakub Kicinski wrote: If only it could have been caught with COMPILE_TEST.. ;) I know, I know!!! I've had a branch that's half done for a long time. It has other dependencies that are not set up for COMPILE_TEST so it's harder than I'd like. Let me see if I can make some

Re: [PATCH net 1/2] net: mrp: fix definitions of MRP test packets

2020-12-28 Thread Jakub Kicinski
On Wed, 23 Dec 2020 15:45:32 +0100 Rasmus Villemoes wrote: > Wireshark says that the MRP test packets cannot be decoded - and the > reason for that is that there's a two-byte hole filled with garbage > between the "transitions" and "timestamp" members. > > So Wireshark decodes the two garbage byte

Re: [PATCH net 2/2] net: switchdev: don't set port_obj_info->handled true when -EOPNOTSUPP

2020-12-28 Thread Jakub Kicinski
On Wed, 23 Dec 2020 15:45:33 +0100 Rasmus Villemoes wrote: > It's not true that switchdev_port_obj_notify() only inspects the > ->handled field of "struct switchdev_notifier_port_obj_info" if > call_switchdev_blocking_notifiers() returns 0 - there's a WARN_ON() > triggering for a non-zero return

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-28 Thread Kirill A. Shutemov
On Mon, Dec 28, 2020 at 10:47:36AM -0800, Linus Torvalds wrote: > On Mon, Dec 28, 2020 at 4:53 AM Kirill A. Shutemov > wrote: > > > > So far I only found one more pin leak and always-true check. I don't see > > how can it lead to crash or corruption. Keep looking. > > Well, I noticed that the no

Re: [PATCH] MIPS: boot: Fix unaligned access with CONFIG_MIPS_RAW_APPENDED_DTB

2020-12-28 Thread Thomas Bogendoerfer
On Wed, Dec 16, 2020 at 11:39:56PM +, Paul Cercueil wrote: > The compressed payload is not necesarily 4-byte aligned, at least when > compiling with Clang. In that case, the 4-byte value appended to the > compressed payload that corresponds to the uncompressed kernel image > size must be read u

Re: [PATCH 5.10 462/717] ice, xsk: clear the status bits for the next_to_use descriptor

2020-12-28 Thread Sasha Levin
On Mon, Dec 28, 2020 at 10:54:23AM -0800, Jakub Kicinski wrote: On Mon, 28 Dec 2020 13:47:40 +0100 Greg Kroah-Hartman wrote: From: Björn Töpel [ Upstream commit 8d14768a7972b92c73259f0c9c45b969d85e3a60 ] On the Rx side, the next_to_use index points to the next item in the HW ring to be refill

Re: [PATCH] MIPS: boot: Fix unaligned access with CONFIG_MIPS_RAW_APPENDED_DTB

2020-12-28 Thread Paul Cercueil
Hi Thomas, Le lun. 28 déc. 2020 à 23:25, Thomas Bogendoerfer a écrit : On Wed, Dec 16, 2020 at 11:39:56PM +, Paul Cercueil wrote: The compressed payload is not necesarily 4-byte aligned, at least when compiling with Clang. In that case, the 4-byte value appended to the compressed payl

Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-28 Thread Daniel Scally
Hi Sakari, thanks for comments On 28/12/2020 17:05, Sakari Ailus wrote: > Hi Andy, Daniel, > > On Thu, Dec 24, 2020 at 02:54:44PM +0200, Andy Shevchenko wrote: >>> +static void cio2_bridge_init_swnode_names(struct cio2_sensor *sensor) >>> +{ >>> + snprintf(sensor->node_names.remote_port, >

Re: [PATCH] x86/sev-es: Fix SEV-ES OUT/IN immediate opcode vc handling

2020-12-28 Thread Borislav Petkov
On Thu, Dec 17, 2020 at 09:19:13AM -0800, Sean Christopherson wrote: > On Wed, Dec 16, 2020, Peter Gonda wrote: > > > > The IN and OUT immediate instructions only use an 8-bit immediate. The > > current VC handler uses the entire 32-bit immediate value. These > > instructions only set the first by

Re: [PATCH 5.10 462/717] ice, xsk: clear the status bits for the next_to_use descriptor

2020-12-28 Thread Jakub Kicinski
On Mon, 28 Dec 2020 17:29:07 -0500 Sasha Levin wrote: > On Mon, Dec 28, 2020 at 10:54:23AM -0800, Jakub Kicinski wrote: > >On Mon, 28 Dec 2020 13:47:40 +0100 Greg Kroah-Hartman wrote: > >> From: Björn Töpel > >> > >> [ Upstream commit 8d14768a7972b92c73259f0c9c45b969d85e3a60 ] > >> > >> On the R

Re: [PATCH net] net: mvpp2: fix pkt coalescing int-threshold configuration

2020-12-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 23 Dec 2020 20:35:21 +0200 you wrote: > From: Stefan Chulski > > The packet coalescing interrupt threshold has separated registers > for different aggregated/cpu (sw-thread). The required value should > be loaded for e

Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-28 Thread Andy Shevchenko
On Tue, Dec 29, 2020 at 12:55:45AM +0200, Andy Shevchenko wrote: > On Mon, Dec 28, 2020 at 10:37:38PM +, Daniel Scally wrote: > > On 28/12/2020 17:05, Sakari Ailus wrote: > > > On Thu, Dec 24, 2020 at 02:54:44PM +0200, Andy Shevchenko wrote: > > ... > > > >>> +#include > > >>> + > > >>> +#de

Re: [PATCH -net] net: sched: prevent invalid Scell_log shift count

2020-12-28 Thread David Miller
From: Randy Dunlap Date: Thu, 24 Dec 2020 22:23:44 -0800 > Check Scell_log shift size in red_check_params() and modify all callers > of red_check_params() to pass Scell_log. > > This prevents a shift out-of-bounds as detected by UBSAN: > UBSAN: shift-out-of-bounds in ./include/net/red.h:252:22

[PATCH v2 7/8] Documentation: HID: hid-transport editing & corrections

2020-12-28 Thread Randy Dunlap
Do basic editing & correction to hid-transport.rst: - s/responsible of/responsible for/ - fix grammar & punctuation Signed-off-by: Randy Dunlap Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Cc: David Herrmann Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jo

[PATCH v2 8/8] Documentation: HID: uhid editing & corrections

2020-12-28 Thread Randy Dunlap
Do basic editing & correction to hid-alps.rst: - correct a file name (.txt -> .rst) - use less hyphenation when not needed - fix grammar & punctuation - fix article adjectives - fix typos/spellos - use HID instead of hid consistently Signed-off-by: Randy Dunlap Cc: Jiri Kosina Cc: Benjamin Ti

Re: [PATCH v3 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay

2020-12-28 Thread Florian Fainelli
On 12/23/2020 3:29 PM, Martin Blumenstingl wrote: > Amlogic Meson G12A, G12B and SM1 SoCs have a more advanced RGMII RX > delay register which allows picoseconds precision. Deprecate the old > "amlogic,rx-delay-ns" in favour of the generic "rx-internal-delay-ps" > property. > > For older SoCs t

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-28 Thread Florian Fainelli
On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: Konstantin, would you be willing to mod the kernel.org instance of patchwork to populate Fixes tags in the generated mboxes? >>> >>> I'd really rather not -- we try n

Re: [PATCH 2/2] arm64: dts: imx8mm: Add Gateworks IMX8MM Development Kits

2020-12-28 Thread Sven Van Asbroeck
On Mon, Dec 28, 2020 at 12:55 PM Tim Harvey wrote: > > I'm happy to test your patches for lan743x. > That's awesome ! I'll post them early in the new year, so that test + review can happen in parallel.

Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-28 Thread Andy Lutomirski
On Mon, Dec 28, 2020 at 12:32 PM Mathieu Desnoyers wrote: > > - On Dec 28, 2020, at 2:44 PM, Andy Lutomirski l...@kernel.org wrote: > > > On Mon, Dec 28, 2020 at 11:09 AM Russell King - ARM Linux admin > > wrote: > >> > >> On Mon, Dec 28, 2020 at 07:29:34PM +0100, Jann Horn wrote: > >> > Afte

[PATCH] mfd: gateworks-gsc: fix interrupt type

2020-12-28 Thread Tim Harvey
The Gateworks System Controller has an active-low interrupt. Fix the interrupt request type. Fixes: d85234994b2f ("mfd: Add Gateworks System Controller core driver") Cc: Signed-off-by: Tim Harvey --- drivers/mfd/gateworks-gsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-28 Thread Mathieu Desnoyers
- On Dec 27, 2020, at 4:36 PM, Andy Lutomirski l...@kernel.org wrote: [...] >> You seem to have noticed odd cases on arm64 where this guarantee does not >> match reality. Where exactly can we find this in the code, and which part >> of the architecture manual can you point us to which support

Re: [PATCH net-next] nfc: Add a virtual nci device driver

2020-12-28 Thread Jakub Kicinski
On Mon, 28 Dec 2020 18:45:07 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon > > A NCI virtual device can be made to simulate a NCI device in user space. > Using the virtual NCI device, The NCI module and application can be > validated. This driver supports to communicate between the virtual NCI > d

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-28 Thread Konstantin Ryabitsev
On Mon, Dec 28, 2020 at 01:05:26PM -0800, Florian Fainelli wrote: > On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: > Konstantin, would you be willing to mod the kernel.org instance of > patchwork to populate Fixes

Re: [PATCH net-next] net: nfc: nci: Change the NCI close sequence

2020-12-28 Thread Jakub Kicinski
On Mon, 28 Dec 2020 10:46:31 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon > > Change the NCI close sequence because the NCI Command timer should be > deleted after flushing the NCI command work queue. The commit message should describe the reason - why new order is better than the old one. The e

[PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks

2020-12-28 Thread Adam Ford
The AVB driver assumes there is an external clock, but it could be driven by an external clock. In order to enable a programmable clock, it needs to be added to the clocks list and enabled in the driver. Since there currently only one clock, there is no clock-names list either. Update bindings t

[PATCH 2/4] ARM: dts: renesas: Add fck to etheravb-rcar-gen2 clock-names list

2020-12-28 Thread Adam Ford
The bindings have been updated to support two clocks, but the original clock now requires the name fck. Add a clock-names list in the device tree with fck in it. Signed-off-by: Adam Ford --- arch/arm/boot/dts/r8a7742.dtsi | 1 + arch/arm/boot/dts/r8a7743.dtsi | 1 + arch/arm/boot/dts/r8a7744.

Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-28 Thread Mathieu Desnoyers
- On Dec 28, 2020, at 4:06 PM, Andy Lutomirski l...@kernel.org wrote: > On Mon, Dec 28, 2020 at 12:32 PM Mathieu Desnoyers > wrote: >> >> - On Dec 28, 2020, at 2:44 PM, Andy Lutomirski l...@kernel.org wrote: >> >> > On Mon, Dec 28, 2020 at 11:09 AM Russell King - ARM Linux admin >> > wro

[PATCH 3/4] arm64: dts: renesas: Add fck to etheravb-rcar-gen3 clock-names list

2020-12-28 Thread Adam Ford
The bindings have been updated to support two clocks, but the original clock now requires the name fck. Add a clock-names list in the device tree with fck in it. Signed-off-by: Adam Ford --- arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 1 + arch/a

[PATCH 4/4] net: ethernet: ravb: Name the AVB functional clock fck

2020-12-28 Thread Adam Ford
The bindings have been updated to support two clocks, but the original clock now requires the name fck to distinguish it from the other. Signed-off-by: Adam Ford --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/

[PATCH 2/2] drm/msm: Ensure get_pages is called when locked

2020-12-28 Thread Iskren Chernev
get_pages is only called in a locked context. Add a WARN_ON to make sure it stays that way. Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/msm_gem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index

Re: [PATCH v3 05/14] software_node: unregister software_nodes in reverse order

2020-12-28 Thread Daniel Scally
On 28/12/2020 10:15, Andy Shevchenko wrote: > On Thu, Dec 24, 2020 at 06:36:10PM +, David Laight wrote: >> From: Daniel Scally >>> Sent: 24 December 2020 14:14 >> ... > The array will be unwound in reverse order (i.e. last entry first). If > any member of the array is a child of ano

Re: [PATCH net] net: ethernet: ti: cpts: fix ethtool output when no ptp_clock registered

2020-12-28 Thread Jakub Kicinski
On Thu, 24 Dec 2020 13:21:36 -0800 Richard Cochran wrote: > On Thu, Dec 24, 2020 at 06:24:05PM +0200, Grygorii Strashko wrote: > > The CPTS driver registers PTP PHC clock when first netif is going up and > > unregister it when all netif are down. Now ethtool will show: > > - PTP PHC clock index 0

Re: [PATCH v3 06/14] include: fwnode.h: Define format macros for ports and endpoints

2020-12-28 Thread Daniel Scally
Hi Sakari On 28/12/2020 17:11, Sakari Ailus wrote: > On Mon, Dec 28, 2020 at 06:30:24PM +0200, Sakari Ailus wrote: >> Hi Daniel, Andy, >> >> On Thu, Dec 24, 2020 at 01:08:59AM +, Daniel Scally wrote: >>> OF, ACPI and software_nodes all implement graphs including nodes for ports >>> and endpoin

Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions

2020-12-28 Thread Daniel Scally
Hi Sakari On 28/12/2020 16:41, Sakari Ailus wrote: > Hi Daniel, > > On Thu, Dec 24, 2020 at 02:21:15PM +, Daniel Scally wrote: >> Hi Andy, Laurent >> >>> On Thu, Dec 24, 2020 at 2:55 PM Laurent Pinchart >>> wrote: On Thu, Dec 24, 2020 at 02:24:12PM +0200, Andy Shevchenko wrote: > On

[PATCH 1/2] drm/msm: Fix null dereference in _msm_gem_new

2020-12-28 Thread Iskren Chernev
The crash was caused by locking an uninitialized lock during init of drm_gem_object. The lock changed in the breaking commit, but the init was not moved accordingly. 8<--- cut here --- Unable to handle kernel NULL pointer dereference at virtual address pgd = (ptrval) [] *pgd=0

[PATCH] regmap: irq: do not allow setting irq bits during ack

2020-12-28 Thread Tim Harvey
Some interrupt controllers may not de-assert their interrupt if bits are set when acknowledging the bits that caused the interrupt. Take care to not apply the mask to the status until we are done acknowledging the interrupt and take care to mask the bits according for the ack_invert state. This i

Re: [PATCH v1] kernel.h: Drop unneeded inclusion from other headers

2020-12-28 Thread Andy Shevchenko
On Fri, Oct 30, 2020 at 01:06:06PM +0200, Andy Shevchenko wrote: > On Fri, Oct 30, 2020 at 08:33:56AM +, Will Deacon wrote: > > On Wed, Oct 28, 2020 at 07:28:26PM +0200, Andy Shevchenko wrote: > > > There is no evidence we need kernel.h inclusion in certain headers. > > > > Did you run some to

[PATCH] timens: delete no-op time_ns_init()

2020-12-28 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan --- kernel/time/namespace.c |6 -- 1 file changed, 6 deletions(-) --- a/kernel/time/namespace.c +++ b/kernel/time/namespace.c @@ -465,9 +465,3 @@ struct time_namespace init_time_ns = { .ns.ops = &timens_operations, .frozen_offsets =

Re: [PATCH 15/15] perf record: Add --buildid-mmap option to enable mmap's build id

2020-12-28 Thread Jiri Olsa
On Mon, Dec 28, 2020 at 10:44:37AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Dec 14, 2020 at 11:54:57AM +0100, Jiri Olsa escreveu: > > Adding --buildid-mmap option to enable build id in mmap2 events. > > It will only work if there's kernel support for that and it disables > > build id cache

Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options

2020-12-28 Thread David Miller
From: Defang Bo Date: Sun, 27 Dec 2020 22:11:35 +0800 > Similar to commit<2423496af35>, the fragmentation code tries to parse the > header options in order > to figure out where to insert the fragment option. Since nexthdr points > to an invalid option, the calculation of the size of the networ

[PATCH v2 6/8] Documentation: HID: hid-sensor editing & corrections

2020-12-28 Thread Randy Dunlap
Do basic editing & correction to hid-sensor.rst: - use HID consistently instead of hid - drop a duplicate word - change article adjective an -> a - fix grammar & punctuation - spell out RW -> read-write - hyphenate multi-word adjectives Signed-off-by: Randy Dunlap Cc: Jiri Kosina Cc: Jonathan C

[PATCH v2 4/8] Documentation: HID: intel-ish-hid editing & corrections

2020-12-28 Thread Randy Dunlap
Do basic editing & correction to intel-ish-hid.rst: - fix grammar, verb tense, punctutation, and word phrasing - fix spellos - hyphenate multi-word adjectives - collapse 2 spaces to one space in the middle of sentences - use "I2C" instead of lower-case letters (as Linux I2C does) - change space i

[PATCH v2 5/8] Documentation: HID: hidraw editing & corrections

2020-12-28 Thread Randy Dunlap
Do basic editing & correction to hidraw.rst: - use "hidraw" consistently except at the beginning of a sentence - add archive.org URL for signal11.us since the latter seems to be MIA - use a list for 2 URLs so that they don't run together Signed-off-by: Randy Dunlap Cc: Jiri Kosina Cc: Benjami

[PATCH v2 2/8] Documentation: HID: amd-sfh-hid editing & corrections

2020-12-28 Thread Randy Dunlap
Do basic editing & correction to amd-sfh-hid.rst: - fix punctuation - use HID instead of hid consistently - fix grammar, verb tense - fix Block Diagram heading Signed-off-by: Randy Dunlap Cc: Jiri Kosina Cc: Jonathan Cameron Cc: Srinivas Pandruvada Cc: linux-in...@vger.kernel.org Cc: linux-.

<    5   6   7   8   9   10   11   12   13   14   >