Re: [Intel-wired-lan] [PATCH 1/1] fix possible array overflow on receiving too many fragments for a packet

2020-12-09 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xiaohui-Zhang/fix-possible-array-overflow-on-receiving-too-many-fragments-for-a-packet/20201209-010457 base: https://git.kernel.org/pub

Re: [PATCH 1/2] if_enabled.h: Add IF_ENABLED_OR_ELSE() and IF_ENABLED() macros

2020-12-09 Thread Linus Walleij
On Tue, Dec 8, 2020 at 5:48 PM Paul Cercueil wrote: > Introduce a new header , that brings two new macros: > IF_ENABLED_OR_ELSE() and IF_ENABLED(). I understand what the patch is trying to do, but when we already have IS_ENABLED() in this syntax becomes a big cognitive confusion for the mind.

Re: [RFC] fpga: dfl: a prototype uio driver

2020-12-09 Thread Xu Yilun
Hi Tom: On Mon, Dec 07, 2020 at 05:07:05AM -0800, Tom Rix wrote: > > On 12/7/20 12:02 AM, Greg KH wrote: > > On Sun, Dec 06, 2020 at 01:55:54PM -0800, t...@redhat.com wrote: > >> From: Tom Rix > >> > >> >From [PATCH 0/2] UIO support for dfl devices > >> https://lore.kernel.org/linux-fpga/1602828

Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling

2020-12-09 Thread Xie He
On Wed, Nov 25, 2020 at 10:36 PM Martin Schiller wrote: > > We have to take the actual link state into account to handle > restart requests/confirms well. > > @@ -214,8 +241,6 @@ void x25_link_established(struct x25_neigh *nb) > { > switch (nb->state) { > case X25_LINK_STATE_0: >

KMSAN: uninit-value in smsc75xx_read_eeprom (2)

2020-12-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=1256cc1350 kernel config: https://syzkaller.appspot.co

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Vinod Koul
On 09-12-20, 09:31, Heiner Kallweit wrote: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of > pci_set_mwi() have a comment that it's an optional feature. I don't > think there's much sense in this separat

Re: [RESEND PATCH v3 2/4] iommu/iova: Avoid double-negatives in magazine helpers

2020-12-09 Thread Leizhen (ThunderTown)
On 2020/11/17 18:25, John Garry wrote: > A similar crash to the following could be observed if initial CPU rcache > magazine allocations fail in init_iova_rcaches(): > > Unable to handle kernel NULL pointer dereference at virtual address > > Mem abort info: >ESR = 0x96

KASAN: null-ptr-deref Write in bdi_put

2020-12-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:15ac8fdb Add linux-next specific files for 20201207 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1735927b50 kernel config: https://syzkaller.appspot.com/x/.config?x=3696b8138207d24d dashboard

Re: [PATCH v1 1/3] gpio: gpio-hisi: Add HiSilicon GPIO support

2020-12-09 Thread Linus Walleij
Hi Jiaxing, thanks! waiting for the new patch! On Wed, Dec 9, 2020 at 9:19 AM luojiaxing wrote: > >> +static void hisi_gpio_irq_disable(struct irq_data *d) > >> +{ > >> + struct gpio_chip *chip = irq_data_get_irq_chip_data(d); > >> + > >> + hisi_gpio_irq_set_mask(d); > >> + hi

Re: [PATCH 1/2] iov: introduce ITER_BVEC_FLAG_FIXED

2020-12-09 Thread Christoph Hellwig
On Wed, Dec 09, 2020 at 08:36:45AM +, Christoph Hellwig wrote: > This is making the iter type even more of a mess than it already is. > I think we at least need placeholders for 0/1 here and an explicit > flags namespace, preferably after the types. > > Then again I'd much prefer if we didn't

Re: [PATCH 1/3] powerpc/smp: Parse ibm,thread-groups with multiple properties

2020-12-09 Thread Gautham R Shenoy
On Wed, Dec 09, 2020 at 02:05:41PM +0530, Srikar Dronamraju wrote: > * Gautham R Shenoy [2020-12-08 22:55:40]: > > > > > > > NIT: > > > tglx mentions in one of his recent comments to try keep a reverse fir tree > > > ordering of variables where possible. > > > > I suppose you mean moving the lo

Re: [PATCH 2/4] sched/fair: Move avg_scan_cost calculations under SIS_PROP

2020-12-09 Thread Mel Gorman
On Wed, Dec 09, 2020 at 01:28:11PM +0800, Li, Aubrey wrote: > >> nr = div_u64(span_avg, avg_cost); > >> else > >> nr = 4; > >> - } > >> - > >> - time = cpu_clock(this); > >> > >> - cpumask_and(cpus, sched_domain_span(

Re: [PATCH] fs: quota: fix array-index-out-of-bounds bug by passing correct argument to vfs_cleanup_quota_inode()

2020-12-09 Thread Jan Kara
On Wed 09-12-20 01:13:38, Anant Thazhemadam wrote: > When dquot_resume() was last updated, the argument that got passed > to vfs_cleanup_quota_inode was incorrectly set. > > If type = -1 and dquot_load_quota_sb() returns a negative value, > then vfs_cleanup_quota_inode() gets called with -1 passed

Re: [PATCH v8 00/16] Add support for Clang LTO

2020-12-09 Thread Arnd Bergmann
On Wed, Dec 9, 2020 at 6:23 AM 'Fāng-ruì Sòng' via Clang Built Linux wrote: > > On Tue, Dec 8, 2020 at 1:02 PM Arnd Bergmann wrote: > > > > On Tue, Dec 8, 2020 at 9:59 PM Arnd Bergmann wrote: > > > > > > Attaching the config for "ld.lld: error: Never resolved function from > > > blockaddress (

Re: [PATCH 3/3] powerpc/cacheinfo: Print correct cache-sibling map/list for L2 cache

2020-12-09 Thread Gautham R Shenoy
On Wed, Dec 09, 2020 at 02:09:21PM +0530, Srikar Dronamraju wrote: > * Gautham R Shenoy [2020-12-08 23:26:47]: > > > > The drawback of this is even if cpus 0,2,4,6 are released L1 cache will > > > not > > > be released. Is this as expected? > > > > cacheinfo populates the cache->shared_cpu_map

Re: [PATCH] KVM: mmu: Fix SPTE encoding of MMIO generation upper half

2020-12-09 Thread Paolo Bonzini
On 08/12/20 22:12, Sean Christopherson wrote: #define MMIO_SPTE_GEN_MASK GENMASK_ULL(MMIO_SPTE_GEN_LOW_BITS + MMIO_SPTE_GEN_HIGH_BITS - 1, 0) What if we leave MMIO_SPTE_GEN_MASK as is, GENMASK_ULL(17, 0), and instead add a BUILD_BUG_ON() to assert that it matches the above logic?

RE: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-09 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 08 December 2020 16:56 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > net...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main resource > region reservation >

Re: [RESEND PATCH v3 3/4] iommu/iova: Flush CPU rcache for when a depot fills

2020-12-09 Thread Leizhen (ThunderTown)
On 2020/11/17 18:25, John Garry wrote: > Leizhen reported some time ago that IOVA performance may degrade over time > [0], but unfortunately his solution to fix this problem was not given > attention. > > To summarize, the issue is that as time goes by, the CPU rcache and depot > rcache continu

From Esther Gabriel

2020-12-09 Thread Esther Gabriel
Greeting to you my Dearest, Please I need your help and Assistance. Permit me to inform you of my desire of going into business relationship with you. I am Miss. Esther Gabriel, the only Daughter of late Mr. and Mrs. Gabriel Kadjo. My father was a very wealthy cocoa merchant in Abidjan; the econom

Re: [PATCH 2/3] powerpc/smp: Add support detecting thread-groups sharing L2 cache

2020-12-09 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-12-08 23:12:37]: > > > For L2 we have thread_group_l2_cache_map to store the tasks from the thread > > group. but cpu_l2_cache_map for keeping track of tasks. > > > > > I think we should do some renaming to keep the names consistent. > > I would say probably say move

Re: [RFC PATCH v2 0/2] add simple copy support

2020-12-09 Thread Javier González
On 08.12.2020 13:24, Johannes Thumshirn wrote: On 08/12/2020 14:13, Javier González wrote: On 08.12.2020 12:37, Johannes Thumshirn wrote: On 08/12/2020 13:22, Javier González wrote: Good idea. Are you thinking of a sysfs entry to select the backend? Not sure on this one, initially I thought

Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling

2020-12-09 Thread Xie He
On Wed, Dec 9, 2020 at 1:01 AM Xie He wrote: > > On Wed, Nov 25, 2020 at 10:36 PM Martin Schiller wrote: > > > > switch (nb->state) { > > case X25_LINK_STATE_0: > > - nb->state = X25_LINK_STATE_2; > > - break; > > case X25_LINK_STATE_1: > >

[PATCH net-next] net: marvell: prestera: simplify the return expression of prestera_port_close()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/marvell/prestera/prestera_main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera

[PATCH net-next] net: marvell: octeontx2: simplify the return expression of rvu_npa_init()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_np

Re: [PATCH v3] checkpatch: add --fix option to include linux checks

2020-12-09 Thread Lukas Bulwahn
On Sun, Dec 6, 2020 at 4:24 PM Dwaipayan Ray wrote: > > Add fix option to INCLUDE_LINUX and ARCH_INCLUDE_LINUX > checks to replace asm includes. > > Macros of type: > #include > #include > > are corrected to: > #include > #include > > Signed-off-by: Dwaipayan Ray Dwaipayan, can you run t

Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch

2020-12-09 Thread Geert Uytterhoeven
On Wed, Dec 9, 2020 at 9:45 AM Vlastimil Babka wrote: > On 12/9/20 8:58 AM, Dan Carpenter wrote: > > On Tue, Dec 08, 2020 at 09:01:49PM -0800, Joe Perches wrote: > >> On Tue, 2020-12-08 at 16:34 -0800, Kees Cook wrote: > >> > >> > If not "Adjusted-by", what about "Tweaked-by", "Helped-by", > >> >

[PATCH net-next] net: emulex: benet: simplify the return expression of be_if_create()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/emulex/benet/be_main.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 676e437d78f6..d

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-09 Thread Nicola Mazzucato
Hi both, thanks for looking into this. On 12/9/20 5:45 AM, Viresh Kumar wrote: > On 08-12-20, 11:20, Sudeep Holla wrote: >> It is because of per-CPU vs per domain drama here. Imagine a system with >> 4 CPUs which the firmware puts in individual domains while they all are >> in the same perf domai

[PATCH net-next] net: cisco: enic: simplify the return vnic_cq_alloc()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/cisco/enic/vnic_cq.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/vnic_cq.c b/drivers/net/ethernet/cisco/enic/vnic_cq.c index 9c682aff3834..5193234

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Peter Chen
On 20-12-09 09:31:21, Heiner Kallweit wrote: > drivers/usb/chipidea/ci_hdrc_pci.c| 2 +- For chipidea changes: Acked-by: Peter Chen Peter > drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +- > drivers/usb/gadget/udc/net2280.c | 2 +- > drivers/usb/gadget/udc/pc

Re: [PATCH v8 00/16] Add support for Clang LTO

2020-12-09 Thread Arnd Bergmann
On Wed, Dec 9, 2020 at 5:56 AM 'Fangrui Song' via Clang Built Linux wrote: > On 2020-12-08, 'Sami Tolvanen' via Clang Built Linux wrote: > >On Tue, Dec 8, 2020 at 4:15 AM Arnd Bergmann wrote: > >> So far I have > >> not managed to get a working build out of it, the main problem so far being > >>

[PATCH net-next] net: freescale: dpaa: simplify the return dpaa_eth_refill_bpools()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index cb7c028b

Re: [PATCH 0/4] USB: ftdio_sio: GPIO validity fixes

2020-12-09 Thread Linus Walleij
On Mon, Dec 7, 2020 at 4:48 PM Johan Hovold wrote: > On Mon, Dec 07, 2020 at 03:34:23PM +, Marc Zyngier wrote: > > If they claim that their lines are available, and then refuse to > > let the user play with it, that's just a bug willing to be fixed. > > My point was that this is how *all* gpi

[PATCH net-next] net: hinic: simplify the return hinic_configure_max_qnum()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/huawei/hinic/hinic_main.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c index 350225

[PATCH net-next] net: stmmac: simplify the return dwmac5_rxp_disable()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac5.c b/drivers/net/ethernet/stmicro/stmmac/dwmac5.c index 67ba67ed0cb9..

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Lee Jones
On Wed, 09 Dec 2020, Heiner Kallweit wrote: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of > pci_set_mwi() have a comment that it's an optional feature. I don't > think there's much sense in this separ

Re: [PATCH next v2 2/3] printk: change @clear_seq to atomic64_t

2020-12-09 Thread Sergey Senozhatsky
On (20/12/09 09:16), Peter Zijlstra wrote: > On Tue, Dec 08, 2020 at 11:36:44PM +0106, John Ogness wrote: > > For the state variable we chose atomic_long_t instead of atomic64_t for > > this reason. atomic_long_t operations are available atomically on all > > architectures. > > Please put on your

Re: UBSAN: shift-out-of-bounds in option_probe

2020-12-09 Thread Johan Hovold
On Tue, Dec 08, 2020 at 11:33:11PM -0800, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:15ac8fdb Add linux-next specific files for 20201207 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=17dc6adf50 > kernel config

[PATCH 1/1] crypto: Fix possible buffer overflows in pkey_protkey_aes_attr_read

2020-12-09 Thread Xiaohui Zhang
From: Zhang Xiaohui pkey_protkey_aes_attr_read() calls memcpy() without checking the destination size may trigger a buffer overflower. Signed-off-by: Zhang Xiaohui --- drivers/s390/crypto/pkey_api.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/s390/crypto/pkey_api.c b/driver

[PATCH net-next] net: sja1105: simplify the return sja1105_cls_flower_stats()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/dsa/sja1105/sja1105_flower.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/dsa/sja1105/sja1105_flower.c b/drivers/net/dsa/sja1105/sja1105_flower.c index 12e76020bea3..e9617782e0d

drivers/staging/media/atomisp//pci/ia_css_firmware.h:52:29: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration

2020-12-09 Thread kernel test robot
Hi Ingo, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a68a0262abdaa251e12c53715f48e698a18ef402 commit: 13c01139b17163c9b2aa543a9c39f8bbc875b625 x86/headers: Remove APIC headers from date: 4 months ago config:

Re: [PATCH 1/4] gpiolib: cdev: Flag invalid GPIOs as used

2020-12-09 Thread Linus Walleij
On Fri, Dec 4, 2020 at 5:47 PM Marc Zyngier wrote: > When reporting the state of a GPIO to userspace, we never check > for the actual validity of the line, meaning we report invalid > lines as being usable. A subsequent request will fail though, > which is an inconsistent behaviour from a userspa

RE: [PATCH net-next] net: freescale: dpaa: simplify the return dpaa_eth_refill_bpools()

2020-12-09 Thread Madalin Bucur (OSS)
> -Original Message- > From: Zheng Yongjun > Sent: 09 December 2020 11:21 > To: da...@davemloft.net; net...@vger.kernel.org > Cc: k...@kernel.org; linux-kernel@vger.kernel.org; Madalin Bucur > ; Zheng Yongjun > Subject: [PATCH net-next] net: freescale: dpaa: simplify the return > dpaa_eth

Re: [External] Re: [PATCH v7 05/15] mm/bootmem_info: Introduce {free,prepare}_vmemmap_page()

2020-12-09 Thread Muchun Song
On Wed, Dec 9, 2020 at 4:50 PM David Hildenbrand wrote: > > On 09.12.20 08:36, Muchun Song wrote: > > On Mon, Dec 7, 2020 at 8:39 PM David Hildenbrand wrote: > >> > >> On 30.11.20 16:18, Muchun Song wrote: > >>> In the later patch, we can use the free_vmemmap_page() to free the > >>> unused vmemm

[PATCH net-next] net: dsa: simplify the return rtl8366_vlan_prepare()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/dsa/rtl8366.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c index 307466b90489..83d481ef9273 100644 --- a/drivers/net/dsa/rtl8366.c +++ b

Re: [PATCH] pinctrl: remove the blank line in pinctrl_register()

2020-12-09 Thread Linus Walleij
On Mon, Dec 7, 2020 at 7:20 PM Andy Shevchenko wrote: > On Mon, Dec 7, 2020 at 6:13 PM Zhaoyu Liu wrote: > > > > Remove the blank line in pinctrl_register() to keep the code neat. > > Probably you want to apply the same for other drivers at once? > > % git grep -n -B1 -w ^} -- drivers/pinctrl/ |

[PATCH net-next] net: marvell: octeontx2: simplify the otx2_ptp_adjfine()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx

[PATCH wireless] iwlwifi: fw: simplify the iwl_fw_dbg_collect_trig()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index ab4a8b942c81.

[PATCH] mm,hwpoison: Return -EBUSY when migration fails

2020-12-09 Thread Oscar Salvador
Currently, we return -EIO when we fail to migrate the page. Migrations' failures are rather transient as they can happen due to several reasons, e.g: high page refcount bump, mapping->migrate_page failing etc. All meaning that at that time the page could not be migrated, but that has nothing to do

[PATCH -next] usb: serial: simplify the ark3116_write_reg()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/usb/serial/ark3116.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c index 71a9206ea1e2..0f9fa0e7c50e 100644 --- a/drivers/usb/se

Re: [External] Re: [PATCH v7 04/15] mm/hugetlb: Introduce nr_free_vmemmap_pages in the struct hstate

2020-12-09 Thread Muchun Song
On Wed, Dec 9, 2020 at 4:54 PM David Hildenbrand wrote: > > On 07.12.20 14:11, Muchun Song wrote: > > On Mon, Dec 7, 2020 at 8:36 PM David Hildenbrand wrote: > >> > >> On 30.11.20 16:18, Muchun Song wrote: > >>> Every HugeTLB has more than one struct page structure. The 2M HugeTLB > >>> has 512 s

Re: [PATCH 2/4] USB: serial: ftdi_sio: Report the valid GPIO lines to gpiolib

2020-12-09 Thread Linus Walleij
On Fri, Dec 4, 2020 at 5:47 PM Marc Zyngier wrote: > Since it is pretty common for only some of the CBUS lines to be > valid as GPIO lines, let's report such validity to the rest of > the kernel. > > Signed-off-by: Marc Zyngier Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-12-09 Thread Daniel Lezcano
On 07/12/2020 06:36, Kai-Heng Feng wrote: > > >> On Dec 1, 2020, at 02:39, Srinivas Pandruvada >> wrote: >> >> On Tue, 2020-12-01 at 02:22 +0800, Kai-Heng Feng wrote: On Dec 1, 2020, at 02:13, Srinivas Pandruvada < srinivas.pandruv...@linux.intel.com> wrote: >>> >>> [snipped] >>> >>>

linux-next: build warning after merge of the kbuild tree

2020-12-09 Thread Stephen Rothwell
Hi all, After merging the kbuild tree, today's linux-next build (x86_64 modules_install) produced this warning: Warning: 'make modules_install' requires depmod. Please install it. This is probably in the kmod package. Introduced by commit 330029209513 ("kbuild: don't hardcode depmod path") U

[PATCH -next] mtd: rawnand: simplify the cs553x_write_ctrl_byte()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/mtd/nand/raw/cs553x_nand.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/raw/cs553x_nand.c b/drivers/mtd/nand/raw/cs553x_nand.c index 282203debd0c..a616aaa2e3dc 100644 ---

Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-09 Thread Jason Wang
On 2020/12/8 下午3:02, Enrico Weigelt, metux IT consult wrote: On 08.12.20 03:36, Jason Wang wrote: Hi, So we endup with two solutions (without a prompt): 1) using select, user may end up with driver without transport IMHO not an entirely unusual situation in other places of the kernel, eg.

[PATCH v2, 2/2] soc: mediatek: mmsys: Use function call for setting the routing registers

2020-12-09 Thread Yongqiang Niu
Actually, setting the registers for routing, use multiple 'if-else' for different routes, but this code would be more and more complicated while we support more and more SoCs. Change that and use a function call per SoC so the code will be more portable and clear. Signed-off-by: Yongqiang Niu --

[PATCH v2, 1/2] soc: mediatek: mmsys: create mmsys folder

2020-12-09 Thread Yongqiang Niu
the mmsys will more and more complicated after support more and more SoCs, add an independent folder will be more clear Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/Makefile | 2 +- drivers/soc/mediatek/mmsys/Makefile| 2 + drivers/soc/mediatek/mmsys/mtk-mmsys.c | 380 +

Re: [External] Re: [PATCH v7 05/15] mm/bootmem_info: Introduce {free,prepare}_vmemmap_page()

2020-12-09 Thread David Hildenbrand
On 09.12.20 10:25, Muchun Song wrote: > On Wed, Dec 9, 2020 at 4:50 PM David Hildenbrand wrote: >> >> On 09.12.20 08:36, Muchun Song wrote: >>> On Mon, Dec 7, 2020 at 8:39 PM David Hildenbrand wrote: On 30.11.20 16:18, Muchun Song wrote: > In the later patch, we can use the free_vme

[PATCH v2, 0/2] soc: mediatek: Prepare MMSYS for DDP routing using function call

2020-12-09 Thread Yongqiang Niu
The following series are intended to prepare the mtk-mmsys driver to allow different DDP (Data Display Path) function call per SoC. base change: https://patchwork.kernel.org/project/linux-mediatek/patch/20201006193320.405529-4-enric.balle...@collabora.com/ Yongqiang Niu (2): soc: mediatek: mms

Re: [PATCH 3/4] USB: serial: ftdi_sio: Log the CBUS GPIO validity

2020-12-09 Thread Linus Walleij
On Mon, Dec 7, 2020 at 4:19 PM Johan Hovold wrote: > On Mon, Dec 07, 2020 at 03:00:37PM +, Marc Zyngier wrote: > > On 2020-12-07 14:29, Johan Hovold wrote: > > > On Fri, Dec 04, 2020 at 04:47:38PM +, Marc Zyngier wrote: > > > >> + if (!bitmap_full(valid_mask, ngpios)) > > >> + de

Re: [RFC PATCH v3 1/4] mm,memory_hotplug: Add mhp_supports_memmap_on_memory

2020-12-09 Thread Oscar Salvador
On Wed, Dec 02, 2020 at 10:36:54AM +0100, David Hildenbrand wrote: > Instead of adding these arch callbacks, what about a config option > > ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > > that gets selected by the archs with CONFIG_SPARSEMEM_VMEMMAP ? > > The mhp_supports_memmap_on_memory() becomes even mo

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-09 Thread Eli Cohen
On Wed, Dec 09, 2020 at 03:05:42AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 09, 2020 at 08:58:46AM +0200, Eli Cohen wrote: > > On Wed, Dec 09, 2020 at 01:46:22AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 09, 2020 at 08:02:30AM +0200, Eli Cohen wrote: > > > > On Tue, Dec 08, 2020 at 0

Re: [RFC PATCH v3 3/4] mm,memory_hotplug: Enable MHP_MEMMAP_ON_MEMORY when supported

2020-12-09 Thread Oscar Salvador
On Wed, Dec 02, 2020 at 10:37:23AM +0100, David Hildenbrand wrote: > Please split that patch into two parts, one for each subsystem. I did not feel the need but if it eases the review, why not :-) -- Oscar Salvador SUSE L3

Re: [PATCH 1/2] if_enabled.h: Add IF_ENABLED_OR_ELSE() and IF_ENABLED() macros

2020-12-09 Thread Ard Biesheuvel
On Tue, 8 Dec 2020 at 17:49, Paul Cercueil wrote: > > Introduce a new header , that brings two new macros: > IF_ENABLED_OR_ELSE() and IF_ENABLED(). > > IF_ENABLED_OR_ELSE(CONFIG_FOO, a, b) evaluates to (a) if CONFIG_FOO is set > to 'y' or 'm', (b) otherwise. It is used internally to define the > I

Re: [RFC PATCH v3 1/4] mm,memory_hotplug: Add mhp_supports_memmap_on_memory

2020-12-09 Thread David Hildenbrand
On 09.12.20 10:36, Oscar Salvador wrote: > On Wed, Dec 02, 2020 at 10:36:54AM +0100, David Hildenbrand wrote: >> Instead of adding these arch callbacks, what about a config option >> >> ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE >> >> that gets selected by the archs with CONFIG_SPARSEMEM_VMEMMAP ? >> >> The

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Christian Brauner
On Wed, Dec 09, 2020 at 09:50:38AM +0100, Michael Kerrisk (man-pages) wrote: > Hello Stephen > > Thank you for writing this page! Some comments/questions below. > > On Tue, 8 Dec 2020 at 22:51, Stephen Kitt wrote: > > > > This documents close_range(2) based on information in > > 278a5fbaed89dacd

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-09 Thread Sudeep Holla
On Wed, Dec 09, 2020 at 11:15:02AM +0530, Viresh Kumar wrote: > On 08-12-20, 11:20, Sudeep Holla wrote: > > It is because of per-CPU vs per domain drama here. Imagine a system with > > 4 CPUs which the firmware puts in individual domains while they all are > > in the same perf domain and hence OPP

Hi

2020-12-09 Thread Sunie Wendy
Hello I sent a letter to your mail but got no reply from you. Did you receive my previous mail please i wait to read your mail soon on my email address at ( suniew...@gmail.com ) respond to me

Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling

2020-12-09 Thread Martin Schiller
On 2020-12-09 10:17, Xie He wrote: On Wed, Dec 9, 2020 at 1:01 AM Xie He wrote: On Wed, Nov 25, 2020 at 10:36 PM Martin Schiller wrote: > > switch (nb->state) { > case X25_LINK_STATE_0: > - nb->state = X25_LINK_STATE_2; > - break; > case X

Re: [RFC PATCH v3 1/4] mm,memory_hotplug: Add mhp_supports_memmap_on_memory

2020-12-09 Thread Oscar Salvador
On Wed, Dec 09, 2020 at 10:40:13AM +0100, David Hildenbrand wrote: > Sorry if I was unclear, s390x will simply not set > ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE. Bleh, that makes sense now. I'm in a monday.. Thanks David -- Oscar Salvador SUSE L3

Re: [RFC][PATCH 0/4] arm64:kvm: teach guest sched that VCPUs can be preempted

2020-12-09 Thread Marc Zyngier
Hi all, On 2020-12-08 20:02, Joel Fernandes wrote: On Fri, Sep 11, 2020 at 4:58 AM Sergey Senozhatsky wrote: My apologies for the slow reply. On (20/08/17 13:25), Marc Zyngier wrote: > > It really isn't the same thing at all. You are exposing PV spinlocks, > while Sergey exposes preemption t

Re: [External] Re: [PATCH v7 05/15] mm/bootmem_info: Introduce {free,prepare}_vmemmap_page()

2020-12-09 Thread Muchun Song
On Wed, Dec 9, 2020 at 5:33 PM David Hildenbrand wrote: > > On 09.12.20 10:25, Muchun Song wrote: > > On Wed, Dec 9, 2020 at 4:50 PM David Hildenbrand wrote: > >> > >> On 09.12.20 08:36, Muchun Song wrote: > >>> On Mon, Dec 7, 2020 at 8:39 PM David Hildenbrand wrote: > > On 30.11.20 16

Re: [PATCH wireless] iwlwifi: fw: simplify the iwl_fw_dbg_collect_trig()

2020-12-09 Thread Kalle Valo
Zheng Yongjun writes: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun > --- > drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c > b/drivers/net/wireless/in

Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling

2020-12-09 Thread Xie He
On Wed, Dec 9, 2020 at 1:41 AM Martin Schiller wrote: > > Right. > By the way: A "Restart Collision" is in practice a very common event to > establish the Layer 3. Oh, I see. Thanks!

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Alejandro Colomar (man-pages)
Hello Stephen and Michael, Thanks for the page! A few more comments below. Thanks, Alex On 12/9/20 9:50 AM, Michael Kerrisk (man-pages) wrote: > Hello Stephen > > Thank you for writing this page! Some comments/questions below. > > On Tue, 8 Dec 2020 at 22:51, Stephen Kitt wrote: >> >> This

[PATCH v7 0/5] clk: add driver for the SiFive FU740

2020-12-09 Thread Zong Li
Add a driver for the SiFive FU740 PRCI IP block, which handles more clocks than FU540. These patches also refactor the original implementation by spliting the dependent-code of fu540 and fu740 respectively. We also add a separate patch for DT binding documentation of FU740 PRCI: https://patchwork.

[PATCH v7 1/5] clk: sifive: Extract prci core to common base

2020-12-09 Thread Zong Li
Extract common core of prci driver to an independent file, it could allow other chips to reuse it. Separate SoCs-dependent code 'fu540' from prci core, then we can easily add 'fu740' later. Almost these changes are code movement. The different is adding the private data for each SoC use, so it nee

[PATCH v7 2/5] clk: sifive: Use common name for prci configuration

2020-12-09 Thread Zong Li
Use generic name CLK_SIFIVE_PRCI instead of CLK_SIFIVE_FU540_PRCI. This patch is prepared for fu740 support. Signed-off-by: Zong Li Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Reviewed-by: Pragnesh Patel --- arch/riscv/Kconfig.socs | 2 +- drivers/clk/sifive/Kconfig | 6 +++---

[PATCH v7 4/5] clk: sifive: Fix the wrong bit field shift

2020-12-09 Thread Zong Li
The clk enable bit should be 31 instead of 24. Signed-off-by: Zong Li Reported-by: Pragnesh Patel --- drivers/clk/sifive/sifive-prci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/sifive/sifive-prci.h b/drivers/clk/sifive/sifive-prci.h index 7e509dfb72d1..

[PATCH v7 3/5] clk: sifive: Add a driver for the SiFive FU740 PRCI IP block

2020-12-09 Thread Zong Li
Add driver code for the SiFive FU740 PRCI IP block. This IP block handles reset and clock control for the SiFive FU740 device and implements SoC-level clock tree controls and dividers. The link of unmatched as follow, and the U740-C000 manual would be present in the same page as soon. https://www.

[PATCH v7 5/5] clk: sifive: Add clock enable and disable ops

2020-12-09 Thread Zong Li
From: Pragnesh Patel Add new functions "sifive_prci_clock_enable(), sifive_prci_clock_disable() and sifive_clk_is_enabled()" to enable or disable the PRCI clock Signed-off-by: Pragnesh Patel Tested-by: Zong Li --- drivers/clk/sifive/fu540-prci.c | 6 +++ drivers/clk/sifive/fu740-prci.c |

Re: [PATCH net-next] net: x25: Fix handling of Restart Request and Restart Confirmation

2020-12-09 Thread Martin Schiller
On 2020-12-09 09:16, Xie He wrote: 1. When the x25 module gets loaded, layer 2 may already be running and connected. In this case, although we are in X25_LINK_STATE_0, we still need to handle the Restart Request received, rather than ignore it. Hmm... I've never loaded the X.25 module after the

Re: [RFC PATCH] blk-mq: Clean up references when freeing rqs

2020-12-09 Thread John Garry
On 09/12/2020 01:01, Ming Lei wrote: blk_mq_queue_tag_busy_iter() can be run on another request queue just between one driver tag is allocated and updating the request map, so one extra request reference still can be grabbed. So looks only holding one queue's usage_counter doesn't help this issu

linux-next: build failure after merge of the pm tree

2020-12-09 Thread Stephen Rothwell
Hi all, After merging the pm tree, today's linux-next build (htmldocs) failed like this: Sphinx parallel build error: docutils.utils.SystemMessage: /home/sfr/next/next/Documentation/ABI/testing/sysfs-platform_profile.rst:1: (SEVERE/4) Missing matching underline for section title overline.

Re: [PATCH v3 1/2] media: i2c: Add driver for the Sony Exmor-RS IMX300 camera sensor

2020-12-09 Thread Jacopo Mondi
Hello, On Fri, Nov 27, 2020 at 11:30:46PM +0100, khol...@gmail.com wrote: > From: AngeloGioacchino Del Regno > > This is a custom multi-aspect 25MegaPixels sensor from Sony, > found in many Sony Xperia smartphones from various eras. > > The camera assembly for this sensor usually (at least in Xpe

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Christian Brauner
On Tue, Dec 08, 2020 at 10:51:33PM +0100, Stephen Kitt wrote: > This documents close_range(2) based on information in > 278a5fbaed89dacd04e9d052f4594ffd0e0585de and > 60997c3d45d9a67daf01c56d805ae4fec37e0bd8. > > Signed-off-by: Stephen Kitt > --- Hey Stephen, Thanks for working on this that's a

Re: [PATCH v7 06/15] mm/hugetlb: Disable freeing vmemmap if struct page size is not power of two

2020-12-09 Thread David Hildenbrand
On 30.11.20 16:18, Muchun Song wrote: > We only can free the tail vmemmap pages of HugeTLB to the buddy allocator > when the size of struct page is a power of two. > > Signed-off-by: Muchun Song > --- > mm/hugetlb_vmemmap.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/mm/hugetl

Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails

2020-12-09 Thread 堀口 直也
On Wed, Dec 09, 2020 at 10:28:18AM +0100, Oscar Salvador wrote: > Currently, we return -EIO when we fail to migrate the page. > > Migrations' failures are rather transient as they can happen due to > several reasons, e.g: high page refcount bump, mapping->migrate_page > failing etc. > All meaning

[PATCH] kcov: don't instrument with UBSAN

2020-12-09 Thread Dmitry Vyukov
Both KCOV and UBSAN use compiler instrumentation. If UBSAN detects a bug in KCOV, it may cause infinite recursion via printk and other common functions. We already don't instrument KCOV with KASAN/KCSAN for this reason, don't instrument it with UBSAN as well. As a side effect this also resolves th

Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails

2020-12-09 Thread David Hildenbrand
On 09.12.20 10:28, Oscar Salvador wrote: > Currently, we return -EIO when we fail to migrate the page. > > Migrations' failures are rather transient as they can happen due to > several reasons, e.g: high page refcount bump, mapping->migrate_page > failing etc. > All meaning that at that time the p

linux-next: build warning after merge of the drm-misc tree

2020-12-09 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/drm/gpu_scheduler.h:201: warning: Function parameter or member 'list' not described in 'drm_sched_job' Introduced by commit 8935ff00e3b1 ("drm/scheduler: "node" --> "list"") -- Cheer

Re: [RFC PATCH v3 4/4] mm,memory_hotplug: Add mhp_memmap_on_memory boot option

2020-12-09 Thread Oscar Salvador
On Wed, Dec 02, 2020 at 10:42:18AM +0100, David Hildenbrand wrote: > I have another memhp tunable in the works. I suggest doing it like > page_shuffling and using, module parameters instead. Makes this > a bit nicer IMHO. Does that have any impact? > diff --git a/mm/Makefile b/mm/Makefile > index

[PATCH] spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors

2020-12-09 Thread H. Nikolaus Schaller
Behavior of CS signal in combination of spi-cs-high and gpio descriptors is not clearly defined and documented. So clarify the documentation Cc: linus.wall...@linaro.org Cc: linux-g...@vger.kernel.org Signed-off-by: H. Nikolaus Schaller --- .../bindings/spi/spi-controller.yaml | 27

Re: [External] Re: [PATCH v7 06/15] mm/hugetlb: Disable freeing vmemmap if struct page size is not power of two

2020-12-09 Thread Muchun Song
On Wed, Dec 9, 2020 at 5:57 PM David Hildenbrand wrote: > > On 30.11.20 16:18, Muchun Song wrote: > > We only can free the tail vmemmap pages of HugeTLB to the buddy allocator > > when the size of struct page is a power of two. > > > > Signed-off-by: Muchun Song > > --- > > mm/hugetlb_vmemmap.c

Re: [RT] 5.9-rt14 softirq_ctrl.lock vs listening_hash[i].lock lockdep splat

2020-12-09 Thread Peter Zijlstra
On Sat, Oct 10, 2020 at 06:31:57AM +0200, Mike Galbraith wrote: > > [ 47.844511] == > [ 47.844511] WARNING: possible circular locking dependency detected > [ 47.844512] 5.9.0.gc85fb28-rt14-rt #1 Tainted: GE > [ 47.844513]

Re: [RFC PATCH v3 4/4] mm,memory_hotplug: Add mhp_memmap_on_memory boot option

2020-12-09 Thread David Hildenbrand
On 09.12.20 11:02, Oscar Salvador wrote: > On Wed, Dec 02, 2020 at 10:42:18AM +0100, David Hildenbrand wrote: >> I have another memhp tunable in the works. I suggest doing it like >> page_shuffling and using, module parameters instead. Makes this >> a bit nicer IMHO. > > Does that have any impact?

Re: linux-next: build warning after merge of the akpm tree

2020-12-09 Thread Dmitry Vyukov
On Mon, Dec 7, 2020 at 1:52 PM Marco Elver wrote: > > On Mon, 7 Dec 2020 at 13:38, 'Dmitry Vyukov' via kasan-dev > wrote: > > On Mon, Dec 7, 2020 at 1:08 PM Dmitry Vyukov wrote: > > > > > Hi all, > > > > > > > > > > After merging the akpm tree, today's linux-next build (powerpc > > > > > allyesc

Re: [PATCH] erofs: force inplace I/O under low memory scenario

2020-12-09 Thread Chao Yu
On 2020/12/8 13:46, Gao Xiang wrote: From: Gao Xiang Try to forcely switch to inplace I/O under low memory scenario in order to avoid direct memory reclaim due to cached page allocation. Signed-off-by: Gao Xiang --- This was commercially used internally for years, but due to customized page->

Re: [External] Re: [PATCH v7 06/15] mm/hugetlb: Disable freeing vmemmap if struct page size is not power of two

2020-12-09 Thread David Hildenbrand
On 09.12.20 11:03, Muchun Song wrote: > On Wed, Dec 9, 2020 at 5:57 PM David Hildenbrand wrote: >> >> On 30.11.20 16:18, Muchun Song wrote: >>> We only can free the tail vmemmap pages of HugeTLB to the buddy allocator >>> when the size of struct page is a power of two. >>> >>> Signed-off-by: Muchu

<    1   2   3   4   5   6   7   8   9   10   >