Re: [PATCH v3 3/4] tpm_tis: Disable interrupts if interrupt storm detected

2020-12-08 Thread Jarkko Sakkinen
On Mon, Dec 07, 2020 at 11:58:44AM -0800, James Bottomley wrote: > On Mon, 2020-12-07 at 15:28 -0400, Jason Gunthorpe wrote: > > On Sun, Dec 06, 2020 at 08:26:16PM +0100, Thomas Gleixner wrote: > > > Just as a side note. I was looking at tpm_tis_probe_irq_single() > > > and that function is leaking

Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

2020-12-08 Thread Andy Lutomirski
On Tue, Dec 8, 2020 at 6:23 AM Marcelo Tosatti wrote: > > On Mon, Dec 07, 2020 at 10:04:45AM -0800, Andy Lutomirski wrote: > > > > > > I do have a feature request, though: IMO it would be quite nifty if the new > > kvmclock structure could also expose NTP corrections. In other words, if > > you

Re: [PATCH v4 0/3] New documentation text describing how to report issues (aka "reporting-bugs rewritten")

2020-12-08 Thread Jonathan Corbet
On Fri, 4 Dec 2020 07:43:47 +0100 Thorsten Leemhuis wrote: > This series adds a new and mostly finished document describing how to report > issues with the Linux kernel to its developers. OK, I have applied this series. Thanks to Thorsten for doing all of this work and sticking with it, and th

Re: [PATCH v8 3/4] doc: trusted-encrypted: updates with TEE as a new trust source

2020-12-08 Thread Jarkko Sakkinen
On Tue, Dec 08, 2020 at 10:02:57AM -0500, Mimi Zohar wrote: > Hi Jarkko, > > On Fri, 2020-12-04 at 17:30 +0200, Jarkko Sakkinen wrote: > > On Wed, Dec 02, 2020 at 02:34:07PM -0500, gmail Elaine Palmer wrote: > > > Hi Sumit, > > > > > > Thank you for the detailed descriptions and examples of tru

Re: [PATCH v15 08/26] x86/mm: Introduce _PAGE_COW

2020-12-08 Thread Borislav Petkov
On Tue, Nov 10, 2020 at 08:21:53AM -0800, Yu-cheng Yu wrote: > There is essentially no room left in the x86 hardware PTEs on some OSes > (not Linux). That left the hardware architects looking for a way to > represent a new memory type (shadow stack) within the existing bits. > They chose to repurp

Re: [PATCH v2] docs: add a reset controller chapter to the driver API docs

2020-12-08 Thread Jonathan Corbet
On Tue, 1 Dec 2020 12:57:54 +0100 Philipp Zabel wrote: > Add initial reset controller API documentation. This is mostly intended > to describe the concepts to users of the consumer API, and to tie the > kerneldoc comments we already have into the driver API documentation. > > Signed-off-by: Phi

Re: One potential issue with concurrent execution of RCU callbacks...

2020-12-08 Thread Frederic Weisbecker
On Tue, Dec 08, 2020 at 09:19:27AM -0800, Paul E. McKenney wrote: > On Tue, Dec 08, 2020 at 04:54:57PM +0100, Frederic Weisbecker wrote: > > On Tue, Dec 08, 2020 at 06:58:10AM -0800, Paul E. McKenney wrote: > > > Hello, Frederic, > > > > > > Boqun just asked if RCU callbacks ran in BH-disabled con

RE: [PATCH 1/1] scsi: Fix possible buffer overflows in storvsc_queuecommand

2020-12-08 Thread Michael Kelley
From: Xiaohui Zhang Sent: Tuesday, December 8, 2020 5:19 AM > > From: Zhang Xiaohui > > storvsc_queuecommand() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service > or the execution of arbitrary code

Re: [PATCH v3 3/5] tracing: Update synth command errors

2020-12-08 Thread Steven Rostedt
On Tue, 08 Dec 2020 11:34:41 -0600 Tom Zanussi wrote: > Unfortunately, you're correct, if you have a script that creates a > synthetic event without semicolons, this patchset will break it, as I > myself found out and fixed in patch 4 ([PATCH v3 4/5] selftests/ftrace: > Add synthetic event field

Re: [PATCH] Update documentation to reflect what TAINT_CPU_OUT_OF_SPEC means nowadays

2020-12-08 Thread Jonathan Corbet
On Wed, 2 Dec 2020 16:32:43 +0100 Mathieu Chouquet-Stringer wrote: > Hello Jonathan, > > Here's a patch updating the meaning of TAINT_CPU_OUT_OF_SPEC after > Borislav introduced changes in a7e1f67ed29f and upcoming patches in tip. > > TAINT_CPU_OUT_OF_SPEC now means a bit more what it im

[PATCH net-next] vrf: handle CONFIG_IPV6 not set for vrf_add_mac_header_if_unset()

2020-12-08 Thread Andrea Mayer
The vrf_add_mac_header_if_unset() is defined within a conditional compilation block which depends on the CONFIG_IPV6 macro. However, the vrf_add_mac_header_if_unset() needs to be called also by IPv4 related code and when the CONFIG_IPV6 is not set, this function is missing. As a consequence, the bu

Re: linux-next: build failure after merge of the scsi-mkp tree

2020-12-08 Thread Alan Stern
On Tue, Dec 08, 2020 at 08:38:59PM +1100, Stephen Rothwell wrote: > Hi all, > > On Tue, 8 Dec 2020 20:28:53 +1100 Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the scsi-mkp tree, today's linux-next build (sparc64 > > defconfig) failed like this: > > > > drivers/mtd/nand/raw/i

Re: [PATCH 3/3] powerpc/cacheinfo: Print correct cache-sibling map/list for L2 cache

2020-12-08 Thread Gautham R Shenoy
On Mon, Dec 07, 2020 at 06:41:38PM +0530, Srikar Dronamraju wrote: > * Gautham R. Shenoy [2020-12-04 10:18:47]: > > > From: "Gautham R. Shenoy" > > > > > > Signed-off-by: Gautham R. Shenoy > > --- > > > > +extern bool thread_group_shares_l2; > > /* > > * On big-core systems, each core has

Re: [PATCH] Update documentation to reflect what TAINT_CPU_OUT_OF_SPEC means nowadays

2020-12-08 Thread Randy Dunlap
On 12/8/20 9:54 AM, Jonathan Corbet wrote: > On Wed, 2 Dec 2020 16:32:43 +0100 > Mathieu Chouquet-Stringer wrote: > >> Hello Jonathan, >> >> Here's a patch updating the meaning of TAINT_CPU_OUT_OF_SPEC after >> Borislav introduced changes in a7e1f67ed29f and upcoming patches in tip. >> >> T

Re: problem booting 5.10

2020-12-08 Thread Julia Lawall
On Tue, 8 Dec 2020, Julia Lawall wrote: > Hello, > > We have not succeeded to boot 5.10 on our Intel(R) Xeon(R) CPU E7-8870 v4 @ > 2.10GHz server. Previous versions (eg 4.19 - 5.9) boot fine. We have > tried various rcs. The backtrace for rc7 is shown below. Some more information, from earl

Re: [PATCH v2] firmware_loader: Align .builtin_fw to 8

2020-12-08 Thread Nick Desaulniers
On Mon, Dec 7, 2020 at 9:46 PM Fangrui Song wrote: > > arm64 references the start address of .builtin_fw (__start_builtin_fw) > with a pair of R_AARCH64_ADR_PREL_PG_HI21/R_AARCH64_LDST64_ABS_LO12_NC > relocations. The compiler is allowed to emit the > R_AARCH64_LDST64_ABS_LO12_NC relocation becaus

Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for ARCHOS Cesium 140

2020-12-08 Thread Pierre-Louis Bossart
On 12/8/20 12:04 AM, Chris Chiu wrote: Tha ARCHOS Cesium 140 tablet has problem with the jack-sensing, thus the heaset functions are not working. Add quirk for this model to select the correct input map, jack-detect options and channel map to enable jack sensing and headset microphone. This d

Re: [PATCH/RFC] dt-bindings: pci: rcar-pci-ep: Document missing interrupts property

2020-12-08 Thread Rob Herring
On Thu, Nov 26, 2020 at 12:59:27PM +0100, Geert Uytterhoeven wrote: > The R-Car PCIe controller does not use interrupts when configured > for endpoint mode, hence the bindings do not document the interrupt > property. However, all DTS files provide interrupts properties, and > thus fail to validat

Re: [PATCH v2 1/2] dt-bindings: clk: g12a-clkc: add DSI Pixel clock bindings

2020-12-08 Thread Rob Herring
On Thu, 26 Nov 2020 15:15:59 +0100, Neil Armstrong wrote: > This adds the MIPI DSI Host Pixel Clock bindings. > > Signed-off-by: Neil Armstrong > --- > include/dt-bindings/clock/g12a-clkc.h | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring

Re: Pass modules to Linux kernel without initrd

2020-12-08 Thread Ben Hutchings
On Tue, 2020-12-08 at 10:24 +0100, Paul Menzel wrote: Dear Linux folks, Trying to reduce the boot time of standard distributions, I would like to get rid of the initrd. The initrd is for mounting the root file system and on most end user systems with standard distributions that means loading t

Re: [PATCH 1/1] hisi_sas: Fix possible buffer overflows in prep_ssp_v3_hw

2020-12-08 Thread John Garry
On 08/12/2020 16:40, Xiaohui Zhang wrote: From: Zhang Xiaohui prep_ssp_v3_hw() calls memcpy() without checking the destination size may trigger a buffer overflower, which a local user could use to cause denial of service or the execution of arbitrary code. Fix it by putting the length check bef

Re: [PATCH v3 1/3] UBI: Do not zero out EC and VID on ECC-ed NOR flashes

2020-12-08 Thread Pratyush Yadav
Richard, On 01/12/20 03:57PM, Pratyush Yadav wrote: > For NOR flashes EC and VID are zeroed out before an erase is issued to > make sure UBI does not mistakenly treat the PEB as used and associate it > with an LEB. > > But on some flashes, like the Cypress Semper S28 SPI NOR flash family, > multi

Re: [PATCH 13/13] dt-bindings: cpufreq: qcom-hw: Add bindings for 8998

2020-12-08 Thread Rob Herring
On Thu, Nov 26, 2020 at 07:45:59PM +0100, AngeloGioacchino Del Regno wrote: > The OSM programming addition has been done under the > qcom,cpufreq-hw-8998 compatible name: specify the requirement > of two additional register spaces for this functionality. > > Signed-off-by: AngeloGioacchino Del Reg

[tip: x86/cpu] x86/cpu/amd: Remove dead code for TSEG region remapping

2020-12-08 Thread tip-bot2 for Arvind Sankar
The following commit has been merged into the x86/cpu branch of tip: Commit-ID: 262bd5724afdefd4c48a260d6100e78cc43ee06b Gitweb: https://git.kernel.org/tip/262bd5724afdefd4c48a260d6100e78cc43ee06b Author:Arvind Sankar AuthorDate:Fri, 27 Nov 2020 12:13:24 -05:00 Committer:

Re: [PATCH v3 4/4] dt-bindings: add ADP5585/ADP5589 entries to trivial-devices

2020-12-08 Thread Rob Herring
On Fri, 27 Nov 2020 13:14:20 +0200, Alexandru Ardelean wrote: > This change adds the device-tree entries for the Analog Devices ADP5585 and > ADP5589 devices to the trivial devices list. > > Signed-off-by: Alexandru Ardelean > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 6

[PATCH v3 1/2] perf: support build BPF skeletons with perf

2020-12-08 Thread Song Liu
BPF programs are useful in perf to profile BPF programs. BPF skeleton is by far the easiest way to write BPF tools. Enable building BPF skeletons in util/bpf_skel. A dummy bpf skeleton is added. More bpf skeletons will be added for different use cases. Signed-off-by: Song Liu --- tools/bpf/bpfto

[PATCH v3 0/2] Introduce perf-stat -b for BPF programs

2020-12-08 Thread Song Liu
This set introduces perf-stat -b option to count events for BPF programs. This is similar to bpftool-prog-profile. But perf-stat makes it much more flexible. Changes v2 => v3: 1. Small fixes in Makefile.perf and bpf_counter.c (Jiri) 2. Rebased on top of bpf-next. This is because 1/2 conflicts

[PATCH v3 2/2] perf-stat: enable counting events for BPF programs

2020-12-08 Thread Song Liu
Introduce perf-stat -b option, which counts events for BPF programs, like: [root@localhost ~]# ~/perf stat -e ref-cycles,cycles -b 254 -I 1000 1.487903822115,200 ref-cycles 1.487903822 86,012 cycles 2.489147029 80,560 ref-cycles

Re: [PATCH v4 1/4] pwm: pca9685: Switch to atomic API

2020-12-08 Thread Sven Van Asbroeck
On Tue, Dec 8, 2020 at 11:57 AM Thierry Reding wrote: > > Is this really that complicated? I sounds to me like the only thing that > you need is to have some sort of usage count for the prescaler. Whenever > you want to use the prescaler you check that usage count. If it is zero, > then you can ju

Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

2020-12-08 Thread Marcelo Tosatti
On Tue, Dec 08, 2020 at 05:02:07PM +0100, Thomas Gleixner wrote: > On Tue, Dec 08 2020 at 16:50, Maxim Levitsky wrote: > > On Mon, 2020-12-07 at 20:29 -0300, Marcelo Tosatti wrote: > >> > +This ioctl allows to reconstruct the guest's IA32_TSC and TSC_ADJUST > >> > value > >> > +from the state obta

Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

2020-12-08 Thread Marcelo Tosatti
On Tue, Dec 08, 2020 at 06:25:13PM +0200, Maxim Levitsky wrote: > On Tue, 2020-12-08 at 17:02 +0100, Thomas Gleixner wrote: > > On Tue, Dec 08 2020 at 16:50, Maxim Levitsky wrote: > > > On Mon, 2020-12-07 at 20:29 -0300, Marcelo Tosatti wrote: > > > > > +This ioctl allows to reconstruct the guest's

Re: [PATCH v6] coresight: etm4x: Modify core-commit of cpu to avoid the overflow of HiSilicon ETM

2020-12-08 Thread Mathieu Poirier
On Tue, Dec 08, 2020 at 03:19:20PM +0800, Qi Liu wrote: > The ETM device can't keep up with the core pipeline when cpu core > is at full speed. This may cause overflow within core and its ETM. > This is a common phenomenon on ETM devices. > > On HiSilicon Hip08 platform, a specific feature is adde

Re: [PATCH bpf-next v4 10/11] bpf: Add tests for new BPF atomic operations

2020-12-08 Thread Yonghong Song
On 12/8/20 8:59 AM, Brendan Jackman wrote: On Tue, Dec 08, 2020 at 08:38:04AM -0800, Yonghong Song wrote: On 12/8/20 4:41 AM, Brendan Jackman wrote: On Mon, Dec 07, 2020 at 07:18:57PM -0800, Yonghong Song wrote: On 12/7/20 8:07 AM, Brendan Jackman wrote: The prog_test that's added depe

Re: [PATCH v2 2/2] perf-stat: enable counting events for BPF programs

2020-12-08 Thread Song Liu
> On Dec 8, 2020, at 2:24 AM, Jiri Olsa wrote: > > On Tue, Dec 08, 2020 at 01:36:57AM +, Song Liu wrote: > > SNIP > >>> >>> I'm still getting >>> >>> [root@dell-r440-01 perf]# ./perf stat -b 38 >>> libbpf: elf: skipping unrecognized data section(9) .eh_frame >>> libbpf: elf: skipping r

Re: [PATCH v3 1/7] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-08 Thread Jakub Kicinski
On Tue, 8 Dec 2020 11:24:17 -0600 Mario Limonciello wrote: > On 12/4/20 2:09 PM, Mario Limonciello wrote: > > From: Vitaly Lifshits > > > > Changed a configuration in the flows to align with > > architecture requirements to achieve S0i3.2 substate. > > > > Also fixed a typo in the previous commit

Re: [PATCH v2] mm: memcontrol: optimize per-lruvec stats counter memory usage

2020-12-08 Thread Shakeel Butt
On Tue, Dec 8, 2020 at 1:53 AM Muchun Song wrote: > > The vmstat threshold is 32 (MEMCG_CHARGE_BATCH), so the type of s32 > of lruvec_stat_cpu is enough. And introduce struct per_cpu_lruvec_stat > to optimize memory usage. > > The size of struct lruvec_stat is 304 bytes on 64 bits system. As it >

Re: [PATCH v5 0/2] MTE support for KVM guest

2020-12-08 Thread Marc Zyngier
On 2020-12-08 17:21, Catalin Marinas wrote: On Mon, Dec 07, 2020 at 07:03:13PM +, Marc Zyngier wrote: On Mon, 07 Dec 2020 16:34:05 +, Catalin Marinas wrote: > On Mon, Dec 07, 2020 at 04:05:55PM +, Marc Zyngier wrote: > > What I'd really like to see is a description of how shared mem

Re: [PATCH] drm/amdgpu: make DRM_AMD_DC x86-only again

2020-12-08 Thread Nick Desaulniers
I've been having to teach it about various relocation types for non-x86_64 architectures; I'm sure the failure from that scenario is...gnarly. I don't know if my latest aarch64 fixes have been deployed (and it depends on how the library is distributed). > > > > Can

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-08 Thread Paraschiv, Andra-Irina
On 07/12/2020 23:29, Jakub Kicinski wrote: On Fri, 4 Dec 2020 19:02:32 +0200 Andra Paraschiv wrote: diff --git a/include/uapi/linux/vm_sockets.h b/include/uapi/linux/vm_sockets.h index fd0ed7221645d..46735376a57a8 100644 --- a/include/uapi/linux/vm_sockets.h +++ b/include/uapi/linux/vm_sockets

Re: One potential issue with concurrent execution of RCU callbacks...

2020-12-08 Thread Paul E. McKenney
On Tue, Dec 08, 2020 at 06:52:30PM +0100, Frederic Weisbecker wrote: > On Tue, Dec 08, 2020 at 09:19:27AM -0800, Paul E. McKenney wrote: > > On Tue, Dec 08, 2020 at 04:54:57PM +0100, Frederic Weisbecker wrote: > > > On Tue, Dec 08, 2020 at 06:58:10AM -0800, Paul E. McKenney wrote: > > > > Hello, Fr

Re: [PATCH v15 08/26] x86/mm: Introduce _PAGE_COW

2020-12-08 Thread Yu, Yu-cheng
On 12/8/2020 9:50 AM, Borislav Petkov wrote: On Tue, Nov 10, 2020 at 08:21:53AM -0800, Yu-cheng Yu wrote: There is essentially no room left in the x86 hardware PTEs on some OSes (not Linux). That left the hardware architects looking for a way to represent a new memory type (shadow stack) within

[PATCH 0/3] coresight: Patches for v5.11 (part 2)

2020-12-08 Thread Mathieu Poirier
Good morning, As expected a few more fixes came late in the cycle - please see if you can include them in the v5.11 cycle. Applies cleanly on today's char-misc-next (ee64ed8153ab). Thanks, Mathieu Arnd Bergmann (1): coresight: remove broken __exit annotations Qi Liu (1): coresight: etm4x:

Re: [PATCH v4 1/4] pwm: pca9685: Switch to atomic API

2020-12-08 Thread Uwe Kleine-König
Hello Thierry, hello Sven, On Tue, Dec 08, 2020 at 05:57:12PM +0100, Thierry Reding wrote: > On Tue, Dec 08, 2020 at 09:44:42AM -0500, Sven Van Asbroeck wrote: > > On Tue, Dec 8, 2020 at 4:10 AM Uwe Kleine-König > > wrote: > > > > > > If this is already in the old code, this probably warrants a s

[PATCH 2/3] coresight: remove broken __exit annotations

2020-12-08 Thread Mathieu Poirier
From: Arnd Bergmann Functions that are annotated __exit are discarded for built-in drivers, but the .remove callback in a device driver must still be kept around to allow bind/unbind operations. There is now a linker warning for the discarded symbol references: `tmc_remove' referenced in sectio

[PATCH 1/3] coresight: tmc-etr: Fix barrier packet insertion for perf buffer

2020-12-08 Thread Mathieu Poirier
From: Suzuki K Poulose When the ETR is used in perf mode with a larger buffer (configured via sysfs or the default size of 1M) than the perf aux buffer size, we end up inserting the barrier packet at the wrong offset, while moving the offset forward. i.e, instead of the "new moved offset", we ins

[PATCH 3/3] coresight: etm4x: Modify core-commit to avoid HiSilicon ETM overflow

2020-12-08 Thread Mathieu Poirier
From: Qi Liu The ETM device can't keep up with the core pipeline when cpu core is at full speed. This may cause overflow within core and its ETM. This is a common phenomenon on ETM devices. On HiSilicon Hip08 platform, a specific feature is added to set core pipeline. So commit rate can be reduc

Re: [PATCH 2/3] rwsem: Implement down_read_interruptible

2020-12-08 Thread Eric W. Biederman
Peter Zijlstra writes: > On Mon, Dec 07, 2020 at 09:56:34AM -0600, Eric W. Biederman wrote: > >> Do you want to pull these two into a topic branch in the tip tree >> based on v10-rc1? > > I'll go do that. I'll let the robots chew on it before pushing it out > though, I'll reply once it's in tip.g

[RFC PATCH 0/1] "Bad page state" while freeing gigantic pages

2020-12-08 Thread Gerald Schaefer
81637] CPU: 6 PID: 616 Comm: bash Not tainted 5.10.0-rc7-next-20201208 #1 [ 276.681639] Hardware name: IBM 3906 M03 703 (LPAR) [ 276.681641] Call Trace: [ 276.681648] [<000458c252b6>] show_stack+0x6e/0xe8 [ 276.681652] [<00045971cf60>] dump_stack+0x90/0xc8 [ 276.68165

[RFC PATCH 1/1] mm/hugetlb: clear compound_nr before freeing gigantic pages

2020-12-08 Thread Gerald Schaefer
ash Not tainted 5.10.0-rc7-next-20201208 #1 [ 276.681639] Hardware name: IBM 3906 M03 703 (LPAR) [ 276.681641] Call Trace: [ 276.681648] [<000458c252b6>] show_stack+0x6e/0xe8 [ 276.681652] [<00045971cf60>] dump_stack+0x90/0xc8 [ 276.681656] [<000458e

Re: [PATCH bpf-next v3 12/14] bpf: Pull tools/build/feature biz into selftests Makefile

2020-12-08 Thread Andrii Nakryiko
On Tue, Dec 8, 2020 at 9:04 AM Brendan Jackman wrote: > > On Mon, Dec 07, 2020 at 06:19:12PM -0800, Andrii Nakryiko wrote: > > On Mon, Dec 7, 2020 at 3:00 AM Brendan Jackman wrote: > > > > > > On Fri, Dec 04, 2020 at 11:00:24AM -0800, Andrii Nakryiko wrote: > > > > On Fri, Dec 4, 2020 at 1:41 AM

Re: [PATCH v3 3/5] tracing: Update synth command errors

2020-12-08 Thread Tom Zanussi
Hi Steve, On Tue, 2020-12-08 at 12:53 -0500, Steven Rostedt wrote: > On Tue, 08 Dec 2020 11:34:41 -0600 > Tom Zanussi wrote: > > > Unfortunately, you're correct, if you have a script that creates a > > synthetic event without semicolons, this patchset will break it, as > > I > > myself found out

Re: problem booting 5.10

2020-12-08 Thread Linus Torvalds
On Tue, Dec 8, 2020 at 9:37 AM Julia Lawall wrote: > > We have not succeeded to boot 5.10 on our Intel(R) Xeon(R) CPU E7-8870 v4 @ > 2.10GHz server. Previous versions (eg 4.19 - 5.9) boot fine. We have > tried various rcs. So the problem started with rc1? Could you try bisecting - even partial

Re: [PATCH 1/6] seq_file: add seq_read_iter

2020-12-08 Thread Linus Torvalds
On Tue, Dec 8, 2020 at 8:35 AM Christoph Hellwig wrote: > > > > Shouldn't this go to Linus before v5.10 is released? > > ping? So by now I'm a bit worried about this series, because the early fixes caused more problems than the current state. So considering the timing and Al having been spotty,

Re: [RFC PATCH 0/1] "Bad page state" while freeing gigantic pages

2020-12-08 Thread Christian Borntraeger
00 > [ 276.681630] page dumped because: non-NULL mapping > [ 276.681632] Modules linked in: > [ 276.681637] CPU: 6 PID: 616 Comm: bash Not tainted > 5.10.0-rc7-next-20201208 #1 > [ 276.681639] Hardware name: IBM 3906 M03 703 (LPAR) > [ 276.681641] Call Trace: > [ 276.68

Re: [PATCH v3 09/15] remoteproc: Introduce function rproc_detach()

2020-12-08 Thread Arnaud POULIQUEN
Hi Mathieu, On 11/26/20 10:06 PM, Mathieu Poirier wrote: > Introduce function rproc_detach() to enable the remoteproc > core to release the resources associated with a remote processor > without stopping its operation. > > Signed-off-by: Mathieu Poirier > Reviewed-by: Peng Fan > --- > drivers

Re: problem booting 5.10

2020-12-08 Thread Julia Lawall
On Tue, 8 Dec 2020, Linus Torvalds wrote: > On Tue, Dec 8, 2020 at 9:37 AM Julia Lawall wrote: > > > > We have not succeeded to boot 5.10 on our Intel(R) Xeon(R) CPU E7-8870 v4 @ > > 2.10GHz server. Previous versions (eg 4.19 - 5.9) boot fine. We have > > tried various rcs. > > So the proble

[PATCH v2 3/3] ALSA: hda/ca0132 - Unmute surround when speaker output is selected.

2020-12-08 Thread Connor McAdams
Make sure GPIO pin for surround channel mute is set to 0 when speaker output is selected. Fixes: def3f0a5c7007 ("ALSA: hda/ca0132 - Add quirk output selection structures.") Cc: Signed-off-by: Connor McAdams --- sound/pci/hda/patch_ca0132.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH bpf-next v3 4/4] selftests/bpf: Add a selftest for the tracing bpf_get_socket_cookie

2020-12-08 Thread Florent Revest
This builds up on the existing socket cookie test which checks whether the bpf_get_socket_cookie helpers provide the same value in cgroup/connect6 and sockops programs for a socket created by the userspace part of the test. Adding a tracing program to the existing objects requires a different atta

Re: [PATCH 1/6] seq_file: add seq_read_iter

2020-12-08 Thread Al Viro
On Tue, Dec 08, 2020 at 10:34:45AM -0800, Linus Torvalds wrote: > On Tue, Dec 8, 2020 at 8:35 AM Christoph Hellwig wrote: > > > > > > Shouldn't this go to Linus before v5.10 is released? > > > > ping? > > So by now I'm a bit worried about this series, because the early fixes > caused more problem

Re: WARNING in sk_stream_kill_queues (5)

2020-12-08 Thread Marco Elver
On Thu, 3 Dec 2020 at 19:01, Eric Dumazet wrote: > On 12/3/20 6:41 PM, Marco Elver wrote: > > > One more experiment -- simply adding > > > > --- a/net/core/skbuff.c > > +++ b/net/core/skbuff.c > > @@ -207,7 +207,21 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t > > gfp_mask, > >*

[PATCH bpf-next v3 3/4] selftests/bpf: Integrate the socket_cookie test to test_progs

2020-12-08 Thread Florent Revest
Currently, the selftest for the BPF socket_cookie helpers is built and run independently from test_progs. It's easy to forget and hard to maintain. This patch moves the socket cookies test into prog_tests/ and vastly simplifies its logic by: - rewriting the loading code with BPF skeletons - rewrit

Re: [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support

2020-12-08 Thread Jaegeuk Kim
Hi Robin, I found some bugs and want to suggest a fix. I'll apply this on your patch and let me know, if you want to modify more on top of this. --- a/fsck/segment.c +++ b/fsck/segment.c @@ -115,6 +115,8 @@ int new_data_block(struct f2fs_sb_info *sbi, void *block, get_node_info(sbi, dn->

Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

2020-12-08 Thread Jakub Kicinski
On Tue, 8 Dec 2020 21:56:25 +0800 Zheng Yongjun wrote: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Please make sure to CC maintainers on your patches

Re: [PATCH 02/20] ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram

2020-12-08 Thread Li Yang
On Sat, Dec 5, 2020 at 1:21 PM Rasmus Villemoes wrote: > > Table 8-53 in the QUICC Engine Reference manual shows definitions of > fields up to a size of 192 bytes, not just 128. But in table 8-111, > one does find the text > > Base Address of the Global Transmitter Parameter RAM Page. [...] >

Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-08 Thread Jakub Kicinski
On Sat, 5 Dec 2020 22:44:08 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > To support jumbo frames, each rx ring dma buffer is 9K in size. > But the chip only stores a single frame per dma buffer. > > When the chip is working with the default 1500 byte MTU, a 9K > dma buffer goes

Re: [PATCH bpf-next v3] bpf: Only provide bpf_sock_from_file with CONFIG_NET

2020-12-08 Thread Florent Revest
On Tue, 2020-12-08 at 12:06 -0800, Randy Dunlap wrote: > On 12/8/20 9:36 AM, Florent Revest wrote: > > Acked-by: Randy Dunlap > > I would say that I didn't ack this version of the patch (hey, > it's 3x the size of the v1/v2 patches), but I have just > rebuilt with v3, so the Ack is OK. :) Oops!

[PATCH bpf-next v3 1/4] bpf: Be less specific about socket cookies guarantees

2020-12-08 Thread Florent Revest
Since "92acdc58ab11 bpf, net: Rework cookie generator as per-cpu one" socket cookies are not guaranteed to be non-decreasing. The bpf_get_socket_cookie helper descriptions are currently specifying that cookies are non-decreasing but we don't want users to rely on that. Reported-by: Daniel Borkmann

[PATCH v2 2/3] ALSA: hda/ca0132 - Change Input Source enum strings.

2020-12-08 Thread Connor McAdams
Change the Input Source enumerated control's strings to make it play nice with pulseaudio. Fixes: 7cb9d94c05de9 ("ALSA: hda/ca0132: add alt_select_in/out for R3Di + SBZ") Cc: Signed-off-by: Connor McAdams --- sound/pci/hda/patch_ca0132.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH net-next] vrf: handle CONFIG_IPV6 not set for vrf_add_mac_header_if_unset()

2020-12-08 Thread David Ahern
On 12/8/20 10:52 AM, Andrea Mayer wrote: > The vrf_add_mac_header_if_unset() is defined within a conditional > compilation block which depends on the CONFIG_IPV6 macro. > However, the vrf_add_mac_header_if_unset() needs to be called also by IPv4 > related code and when the CONFIG_IPV6 is not set, t

[PATCH bpf-next v3 2/4] bpf: Expose bpf_get_socket_cookie to tracing programs

2020-12-08 Thread Florent Revest
This needs two new helpers, one that works in a sleepable context (using sock_gen_cookie which disables/enables preemption) and one that does not (for performance reasons). Both take a struct sock pointer and need to check it for NULLness. This helper could also be useful to other BPF program type

Re: [RFC PATCH v2] checkpatch: rewrite Kconfig parsing

2020-12-08 Thread Joe Perches
On Tue, 2020-12-08 at 18:18 +0100, Nicolai Fischer wrote: > Checkpatch currently only warns if the help text is too short. > To determine this the diff gets parsed for keywords starting > a new entry, but several kinds of false positives can occur with > the current implementation, especially when

Re: [PATCH v2] media: atomisp: Fixed error handling path

2020-12-08 Thread Souptick Joarder
On Thu, Nov 19, 2020 at 1:06 AM Souptick Joarder wrote: > > On Wed, Nov 4, 2020 at 7:32 AM Souptick Joarder wrote: > > > > Inside alloc_user_pages() based on flag value either pin_user_pages() > > or get_user_pages_fast() will be called. However, these API might fail. > > > > But free_user_pages(

Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

2020-12-08 Thread Thomas Gleixner
On Tue, Dec 08 2020 at 09:43, Andy Lutomirski wrote: > On Tue, Dec 8, 2020 at 6:23 AM Marcelo Tosatti wrote: > It looks like it tries to accomplish the right goal, but in a rather > roundabout way. The host knows how to convert from TSC to > CLOCK_REALTIME, and ptp_kvm.c exposes this data to the

Re: [PATCH v3 10/13] media: v4l2-fwnode: Update V4L2_FWNODE_CSI2_MAX_DATA_LANES to 8

2020-12-08 Thread Sakari Ailus
Hi Hans, On Mon, Dec 07, 2020 at 11:47:38AM +0100, Hans Verkuil wrote: > On 03/12/2020 19:59, Sowjanya Komatineni wrote: > > Some CSI2 receivers support 8 data lanes. > > > > So, this patch updates CSI2 maximum data lanes to be 8. > > > > Signed-off-by: Sowjanya Komatineni > > --- > > drivers/

Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding

2020-12-08 Thread Rob Herring
On Fri, 27 Nov 2020 12:14:41 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > BCM4908 was built using older PCIe hardware block that requires using > external reset block controlling PERST# signals. > > Signed-off-by: Rafał Miłecki > --- > .../reset/brcm,bcm4908-misc-pcie-reset.yaml | 3

Re: [PATCH net-next] net/mlx4: simplify the return expression of mlx4_init_cq_table()

2020-12-08 Thread Jakub Kicinski
On Tue, 8 Dec 2020 21:55:43 +0800 Zheng Yongjun wrote: > diff --git a/drivers/net/ethernet/mellanox/mlx4/cq.c > b/drivers/net/ethernet/mellanox/mlx4/cq.c > index 3b8576b9c2f9..68bd18ee6ee3 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/cq.c > +++ b/drivers/net/ethernet/mellanox/mlx4/cq.c > @@ -

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-08 Thread Jakub Kicinski
On Sat, 5 Dec 2020 18:43:54 -0500 Jarod Wilson wrote: > I'm seeing a system get stuck unable to bring a downed interface back up > when it's got an updelay value set, behavior which ceased when logging > spew was removed from bond_miimon_inspect(). I'm monitoring logs on this > system over another

Re: [PATCH 1/3] dt-bindings: msm: Add LLCC for SM8250

2020-12-08 Thread Rob Herring
On Fri, 27 Nov 2020 17:41:25 +0530, Manivannan Sadhasivam wrote: > Add LLCC compatible for SM8250 SoC. > > Signed-off-by: Manivannan Sadhasivam > --- > Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

Re: [PATCH v15 08/26] x86/mm: Introduce _PAGE_COW

2020-12-08 Thread Borislav Petkov
On Tue, Dec 08, 2020 at 10:25:15AM -0800, Yu, Yu-cheng wrote: > > Both are "R/O + _PAGE_COW". Where's the difference? The dirty bit? > > The PTEs are the same for both (a) and (b), but come from different routes. Do not be afraid to go into detail and explain to me what those routes are please.

Re: [PATCH v2 3/3] usb: typec: tcpci_maxim: Enable VSAFE0V signalling

2020-12-08 Thread Guenter Roeck
On Tue, Dec 01, 2020 at 08:08:40PM -0800, Badhri Jagan Sridharan wrote: > Unmask EXTENDED_STATUS_MASK.vSafe0V, ALERT.Extended_Status > and set vbus_vsafe0v to enable VSAFE0V signalling. > > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck > --- > Changes since v1: > - Setting a

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

2020-12-08 Thread Brian Norris
On Tue, Dec 8, 2020 at 7:14 AM Xiaohui Zhang wrote: > > From: Zhang Xiaohui > > mwifiex_config_scan() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service > or the execution of arbitrary code. > Fix it by

[RFC PATCH 05/11] mm: Add unlock_folio

2020-12-08 Thread Matthew Wilcox (Oracle)
Convert unlock_page() to call unlock_folio(). By using a folio we avoid doing a repeated compound_head() This shortens the function from 120 bytes to 76 bytes. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 16 +++- mm/filemap.c| 27 ++--

[RFC PATCH 10/11] mm/filemap: Add folio_add_to_page_cache

2020-12-08 Thread Matthew Wilcox (Oracle)
Pages being added to the page cache should already be folios, so turn add_to_page_cache_lru() into a wrapper. Saves hundreds of bytes of text. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 13 +++-- mm/filemap.c| 62

[RFC PATCH 08/11] mm/filemap: Convert end_page_writeback to use a folio

2020-12-08 Thread Matthew Wilcox (Oracle)
With my config, this function shrinks from 480 bytes to 240 bytes due to elimination of repeated calls to compound_head(). Signed-off-by: Matthew Wilcox (Oracle) --- mm/filemap.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/mm/filemap.c b/mm/filema

Re: [PATCH v2 1/3] usb: typec: tcpm: Introduce vsafe0v for vbus

2020-12-08 Thread Guenter Roeck
On Tue, Dec 01, 2020 at 08:08:38PM -0800, Badhri Jagan Sridharan wrote: > TCPM at present lacks the notion of VSAFE0V. There > are three vbus threshold levels that are critical to track: > a. vSafe5V - VBUS “5 volts” as defined by the USB > PD specification. > b. vSinkD

[RFC PATCH 09/11] mm/filemap: Convert mapping_get_entry and pagecache_get_page to folio

2020-12-08 Thread Matthew Wilcox (Oracle)
Convert mapping_get_entry() to return a folio and convert pagecache_get_page() to use the folio where possible. The seemingly dangerous cast of a page pointer to a folio pointer is safe because __page_cache_alloc() allocates an order-0 page, which is a folio by definition. Signed-off-by: Matthew

[RFC PATCH 04/11] mm: Create FolioFlags

2020-12-08 Thread Matthew Wilcox (Oracle)
These new functions are the folio analogues of the PageFlags functions. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/page-flags.h | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/include/linux/page-flags.h b/include/linux/page-

[RFC PATCH 06/11] mm: Add lock_folio

2020-12-08 Thread Matthew Wilcox (Oracle)
This is like lock_page() but for use by callers who know they have a folio. Convert __lock_page() to be __lock_folio(). This saves one call to compound_head() per contended call to lock_page(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 21 +++-- mm/fil

[RFC PATCH 01/11] mm: Introduce struct folio

2020-12-08 Thread Matthew Wilcox (Oracle)
We have trouble keeping track of whether we've already called compound_head() to ensure we're not operating on a tail page. Further, it's never clear whether we intend a struct page to refer to PAGE_SIZE bytes or page_size(compound_head(page)). Introduce a new type 'struct folio' that always refe

[RFC PATCH 02/11] mm: Add put_folio

2020-12-08 Thread Matthew Wilcox (Oracle)
If we know we have a folio, we can call put_folio() instead of put_page() and save the overhead of calling compound_head(). Also skips the devmap checks. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/mm.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --

Re: [RFC PATCH 1/1] mm/hugetlb: clear compound_nr before freeing gigantic pages

2020-12-08 Thread Matthew Wilcox
On Tue, Dec 08, 2020 at 07:28:13PM +0100, Gerald Schaefer wrote: > This is because only the compound_order is cleared in > destroy_compound_gigantic_page(), and compound_nr is set to 1U << order == 1 > for order 0 in set_compound_order(page, 0). I didn't realise there was a separate destroy path f

[RFC PATCH 11/11] mm/swap: Convert rotate_reclaimable_page to folio

2020-12-08 Thread Matthew Wilcox (Oracle)
Move the declaration into mm/internal.h and rename the function to rotate_reclaimable_folio(). This eliminates all five of the calls to compound_head() in this function. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/swap.h | 1 - mm/filemap.c | 2 +- mm/internal.h|

Re: [PATCH v3 2/2] media: dt-bindings: media: i2c: Add IMX300 CMOS sensor binding

2020-12-08 Thread Rob Herring
On Fri, 27 Nov 2020 23:30:47 +0100, khol...@gmail.com wrote: > From: AngeloGioacchino Del Regno > > Add YAML device tree binding for IMX300 CMOS image sensor, and > the relevant MAINTAINERS entries. > > Signed-off-by: AngeloGioacchino Del Regno > --- > .../bindings/media/i2c/sony,imx300.yaml

[RFC PATCH 00/11] Page folios

2020-12-08 Thread Matthew Wilcox (Oracle)
One of the great things about compound pages is that when you try to do various operations on a tail page, it redirects to the head page and everything Just Works. One of the awful things is how much we pay for that simplicity. Here's an example, end_page_writeback(): if (PageReclaim(pag

Re: [PATCH] riscv: Fixed kernel test robot warning

2020-12-08 Thread Souptick Joarder
On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab wrote: > > On Dez 09 2020, Souptick Joarder wrote: > > > Kernel test robot throws below warning - > > > >arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype > > for 'asm_offsets' [-Wmissing-prototypes] > > 14 | void asm_offse

Re: [PATCH] riscv: Fixed kernel test robot warning

2020-12-08 Thread Andreas Schwab
On Dez 09 2020, Souptick Joarder wrote: > On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab wrote: >> >> On Dez 09 2020, Souptick Joarder wrote: >> >> > Kernel test robot throws below warning - >> > >> >arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype >> > for 'asm_offsets' [-

[PATCH v2 1/3] ALSA: hda/ca0132 - Fix AE-5 rear headphone pincfg.

2020-12-08 Thread Connor McAdams
The Windows driver sets the pincfg for the AE-5's rear-headphone to report as a microphone. This causes issues with Pulseaudio mistakenly believing there is no headphone plugged in. In Linux, we should instead set it to be a headphone. Fixes: a6b0961b39896 ("ALSA: hda/ca0132 - fix AE-5 pincfg") Cc

Re: Potential Issue in Tracing Ring Buffer

2020-12-08 Thread Steven Rostedt
On Tue, 8 Dec 2020 11:37:13 -0800 "J. Avila" wrote: > Hello Steven, > > Thank you once again for all of your support. We saw that you also recently > merged a change[1] which adds some validation for the timestamps in > ring_buffer.c. Would you have any recommendations on how to add a more > lig

[RFC PATCH 03/11] mm: Add get_folio

2020-12-08 Thread Matthew Wilcox (Oracle)
If we know we have a folio, we can call get_folio() instead of get_page() and save the overhead of calling compound_head(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/mm.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h b/incl

[RFC PATCH 07/11] mm: Add lock_folio_killable

2020-12-08 Thread Matthew Wilcox (Oracle)
This is like lock_page_killable() but for use by callers who know they have a folio. Convert __lock_page_killable() to be __lock_folio_killable(). This saves one call to compound_head() per contended call to lock_page_killable(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap

<    3   4   5   6   7   8   9   10   11   12   >