Re: [PATCH v7 14/47] dt-bindings: memory: tegra124: emc: Document OPP table and voltage regulator

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:48:50PM +0300, Dmitry Osipenko wrote: > Document new OPP table and voltage regulator properties which are needed > for supporting dynamic voltage-frequency scaling of the memory controller. > Some boards may have a fixed core voltage regulator, hence it's optional > becau

Re: [PATCH v5 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API

2020-11-06 Thread Nick Terrell
> On Nov 6, 2020, at 9:10 AM, Josef Bacik wrote: > > On 11/3/20 1:05 AM, Nick Terrell wrote: >> From: Nick Terrell >> Move away from the compatibility wrapper to the zstd-1.4.6 API. This >> code is functionally equivalent. >> Signed-off-by: Nick Terrell >> --- >> fs/btrfs/zstd.c | 48 +++

Re: [PATCH v5 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread Marco Elver
On Fri, 6 Nov 2020 at 19:28, Arpitha Raghunandan <98.a...@gmail.com> wrote: > Implementation of support for parameterized testing in KUnit. > This approach requires the creation of a test case using the > KUNIT_CASE_PARAM macro that accepts a generator function as input. > This generator function s

Re: [PATCH v7 17/47] dt-bindings: memory: tegra20: Add memory client IDs

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:48:53PM +0300, Dmitry Osipenko wrote: > Each memory client has unique hardware ID, add these IDs. > > Acked-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > include/dt-bindings/memory/tegra20-mc.h | 53 + > 1 file changed, 53 insertions

Re: [PATCH v5 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature

2020-11-06 Thread Marco Elver
On Fri, 6 Nov 2020 at 19:29, Arpitha Raghunandan <98.a...@gmail.com> wrote: > Modify fs/ext4/inode-test.c to use the parameterized testing > feature of KUnit. > > Signed-off-by: Arpitha Raghunandan <98.a...@gmail.com> > --- [...] > fs/ext4/inode-test.c | 314 ++-

Re: [PATCH v7 19/47] dt-bindings: memory: tegra124: Add memory client IDs

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:48:55PM +0300, Dmitry Osipenko wrote: > Each memory client has unique hardware ID, add these IDs. > > Reviewed-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > include/dt-bindings/memory/tegra124-mc.h | 68 > 1 file changed, 68 inserti

Re: [PATCH v7 18/47] dt-bindings: memory: tegra30: Add memory client IDs

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:48:54PM +0300, Dmitry Osipenko wrote: > Each memory client has unique hardware ID, add these IDs. > > Acked-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > include/dt-bindings/memory/tegra30-mc.h | 67 + > 1 file changed, 67 insertions

Re: [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-06 Thread Christoph Hellwig
You just keep resedning this crap, don't you? Haven't you been told multiple times to provide a proper kernel API by now? On Mon, Nov 02, 2020 at 10:05:27PM -0800, Nick Terrell wrote: > From: Nick Terrell > > Adds zstd_compat.h which provides the necessary functions from the > current zstd.h AP

[PATCH v1] arm64: dts: sc7180: Add camera clock controller node

2020-11-06 Thread Taniya Das
Add the camera clock controller node supported on SC7180. Signed-off-by: Taniya Das --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index f5ef2cb..e795dba 1006

[PATCH v1] video: hyperv_fb: include vmalloc.h

2020-11-06 Thread Olaf Hering
hvfb_getmem uses vzalloc, therefore vmalloc.h should be included. Fixes commit d21987d709e807ba7bbf47044deb56a3c02e8be4 ("video: hyperv: hyperv_fb: Support deferred IO for Hyper-V frame buffer driver") Signed-off-by: Olaf Hering --- drivers/video/fbdev/hyperv_fb.c | 1 + 1 file changed, 1 inser

[PATCH v2 1/6] platform/chrome: cros_ec_typec: Make disc_done flag partner-only

2020-11-06 Thread Prashant Malani
Change the disc_done flag, which indicates whether PD discovery is complete, to sop_disc_done instead, since we will process SOP and SOP' discovery data separately. Signed-off-by: Prashant Malani --- Changes in v2: - No changes. drivers/platform/chrome/cros_ec_typec.c | 19 +++

[PATCH v2 3/6] platform/chrome: cros_ec_typec: Rename discovery struct

2020-11-06 Thread Prashant Malani
Rename the sop_disc data struct which is used to store PD discovery data to the more generic name of disc_data. It can then be re-used to store and process cable discovery data. Signed-off-by: Prashant Malani --- Changes in v2: - No changes. drivers/platform/chrome/cros_ec_typec.c | 10 +--

[PATCH v2 0/6] platform/chrome: cros_ec_typec: Add cable

2020-11-06 Thread Prashant Malani
The following series adds Type C cable registration to the cros-ec-typec port driver using the Type C connector class framework. The first few patches perform a few minor re-organizations to prepare for the cable registration patch. The last couple of CLs update the USB PD VDO header file to add a

[PATCH v2 4/6] platform/chrome: cros_ec_typec: Register cable

2020-11-06 Thread Prashant Malani
When the Chrome Embedded Controller notifies the driver that SOP' discovery is complete, retrieve the PD discovery data and register a cable object with the Type C connector class framework. Cc: Heikki Krogerus Signed-off-by: Prashant Malani --- Changes in v2: - No changes. drivers/platform/c

[PATCH v2 6/6] platform/chrome: cros_ec_typec: Store cable plug type

2020-11-06 Thread Prashant Malani
Use the PD VDO Type C cable plug type macro to retrieve and store the cable plug type in the cable descriptor. Cc: Heikki Krogerus Cc: Greg Kroah-Hartman Signed-off-by: Prashant Malani --- Changes in v2: - Changed local variable from uint32_to u32. drivers/platform/chrome/cros_ec_typec.c | 2

[PATCH v2 2/6] platform/chrome: cros_ec_typec: Factor out PD identity parsing

2020-11-06 Thread Prashant Malani
Factor out the PD identity parsing code into a separate function. This way it can be re-used for Cable PD identity parsing in future patches. No functional changes are introduced by this patch. Signed-off-by: Prashant Malani --- Changes in v2: - No changes. drivers/platform/chrome/cros_ec_typ

[PATCH v2 5/6] usb: pd: Add captive Type C cable type

2020-11-06 Thread Prashant Malani
The USB Power Delivery Specification R3.0 adds a captive cable type to the "USB Type-C plug to USB Type-C/Captive" field (Bits 19-18, Passive/Active Cable VDO, Table 6-38 & 6-39). Add the corresponding definition to the Cable VDO header. Also add a helper macro to get the Type C cable connector ty

Re: [PATCH] mm/memcg: update page struct member in comments

2020-11-06 Thread Ira Weiny
On Fri, Nov 06, 2020 at 07:33:33PM +0800, Alex Shi wrote: > The page->mem_cgroup member is replaced by memcg_data, and add a helper > page_memcg() for it. Need to update comments to avoid confusing. I'm not an expert in this code but IMO the pointer manipulation of page->mem_cgroup could be though

Re: [PATCH v6 1/7] arm64: mm: Move reserve_crashkernel() into mem_init()

2020-11-06 Thread Nicolas Saenz Julienne
Hi James, thanks for the review. Some comments/questions below. On Thu, 2020-11-05 at 16:11 +, James Morse wrote: > Hi! > > On 03/11/2020 17:31, Nicolas Saenz Julienne wrote: > > crashkernel might reserve memory located in ZONE_DMA. We plan to delay > > ZONE_DMA's initialization after unflatt

Re: [PATCH v5 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread Marco Elver
On Fri, 6 Nov 2020 at 19:28, Arpitha Raghunandan <98.a...@gmail.com> wrote: > > Implementation of support for parameterized testing in KUnit. > This approach requires the creation of a test case using the > KUNIT_CASE_PARAM macro that accepts a generator function as input. > This generator function

Re: [PATCH v14 02/26] x86/cpufeatures: Add CET CPU feature flags for Control-flow Enforcement Technology (CET)

2020-11-06 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 08:38:26AM -0700, Yu-cheng Yu wrote: > Add CPU feature flags for Control-flow Enforcement Technology (CET). > > CPUID.(EAX=7,ECX=0):ECX[bit 7] Shadow stack > CPUID.(EAX=7,ECX=0):EDX[bit 20] Indirect Branch Tracking > > Signed-off-by: Yu-cheng Yu > Reviewed-by: Borislav Pe

Re: [GIT PULL][PATCH v5 0/9] Update to zstd-1.4.6

2020-11-06 Thread Nick Terrell
> On Nov 6, 2020, at 9:15 AM, Josef Bacik wrote: > > On 11/3/20 1:05 AM, Nick Terrell wrote: >> From: Nick Terrell >> Please pull from >> g...@github.com:terrelln/linux.git tags/v5-zstd-1.4.6 >> to get these changes. Alternatively the patchset is included. > > Where did we come down on the co

Re: [PATCH] drm: Use IS_ERR() instead of null pointer check

2020-11-06 Thread Sam Ravnborg
Hi Wang. Thanks for the fix. On Fri, Nov 06, 2020 at 10:31:19AM +0800, Wang Qing wrote: > a6xx_gmu_get_mmio() never return null in case of error, but ERR_PTR(), > so we should use IS_ERR() instead of null pointer check > > Signed-off-by: Wang Qing In the future please put "drm/:" in the subjec

Re: [PATCH v3 18/26] coresight: etm4x: Clean up exception level masks

2020-11-06 Thread Mathieu Poirier
Good morning, On Wed, Oct 28, 2020 at 10:09:37PM +, Suzuki K Poulose wrote: > etm4_get_access_type() calculates the exception level bits > for use in address comparator registers. This is also used > by the TRCVICTLR register by shifting to the required position. > > This patch cleans up the

Re: [PATCH v3 0/2] Add a seqcount between gup_fast and copy_page_range()

2020-11-06 Thread Ahmed S. Darwish
On Fri, Nov 06, 2020 at 11:55:12AM -0400, Jason Gunthorpe wrote: ... > > arch/x86/kernel/tboot.c| 1 + > drivers/firmware/efi/efi.c | 1 + > include/linux/mm_types.h | 8 +++ > kernel/fork.c | 1 + > mm/gup.c | 118 +++--

Re: [PATCH v2 5/6] usb: pd: Add captive Type C cable type

2020-11-06 Thread Benson Leung
Hi Prashant, On Fri, Nov 06, 2020 at 10:41:08AM -0800, Prashant Malani wrote: > The USB Power Delivery Specification R3.0 adds a captive cable type > to the "USB Type-C plug to USB Type-C/Captive" field (Bits 19-18, > Passive/Active Cable VDO, Table 6-38 & 6-39). > > Add the corresponding defini

Re: [PATCH] compiler-clang: remove version check for BPF Tracing

2020-11-06 Thread Nick Desaulniers
On Thu, Nov 5, 2020 at 8:16 PM Alexei Starovoitov wrote: > > I can take it through the bpf tree if no one objects. Doesn't matter to me. You'll need to coordinate with Andrew though, since I got the email that this was picked up into -mm: >> This patch should soon appear at >> >> https://oz

Re: [lib/strncpy_from_user.c] 00a4ef91e8: BUG:KASAN:slab-out-of-bounds_in_s

2020-11-06 Thread Daniel Xu
On Thu Nov 5, 2020 at 8:32 PM PST, Alexei Starovoitov wrote: > Daniel, > > the kasan complains about the previous version of your patch, > but your v4 version looks equivalent. > Could you try to repro this issue? > The code looks correct, but kasan complain is concerning. > > On Thu, Nov 5, 2020 a

Re: [PATCH v5 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread Arpitha Raghunandan
On 07/11/20 12:15 am, Marco Elver wrote: > On Fri, 6 Nov 2020 at 19:28, Arpitha Raghunandan <98.a...@gmail.com> wrote: >> >> Implementation of support for parameterized testing in KUnit. >> This approach requires the creation of a test case using the >> KUNIT_CASE_PARAM macro that accepts a generat

Re: [PATCH v7 28/47] memory: tegra: Add and use devm_tegra_memory_controller_get()

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:49:04PM +0300, Dmitry Osipenko wrote: > Multiple Tegra drivers need to retrieve Memory Controller and there is > duplication of the retrieval code among the drivers. > > Add new devm_tegra_memory_controller_get() helper to remove the code's > duplication and to fix put_d

Re: [PATCH v7 29/47] memory: tegra: Use devm_platform_ioremap_resource()

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:49:05PM +0300, Dmitry Osipenko wrote: > Use devm_platform_ioremap_resource() helper which makes code a bit > cleaner. > > Acked-by: Thierry Reding > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra124-emc.c | 4 +--- > drivers/memory/tegra/tegra20-emc

Re: [PATCH v5 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread Marco Elver
On Fri, 6 Nov 2020 at 20:00, Arpitha Raghunandan <98.a...@gmail.com> wrote: > > On 07/11/20 12:15 am, Marco Elver wrote: > > On Fri, 6 Nov 2020 at 19:28, Arpitha Raghunandan <98.a...@gmail.com> wrote: > >> > >> Implementation of support for parameterized testing in KUnit. > >> This approach require

Re: [PATCH v7 30/47] memory: tegra: Remove superfluous error messages around platform_get_irq()

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:49:06PM +0300, Dmitry Osipenko wrote: > The platform_get_irq() prints error message telling that interrupt is > missing, hence there is no need to duplicated that message in the drivers. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/mc.c | 4

Re: [PATCH v7 31/47] memory: tegra: Add missing latency allowness entry for Page Table Cache

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:49:07PM +0300, Dmitry Osipenko wrote: > Add missing PTC memory client latency allowness entry to the Tegra MC > drivers. > > This prevents erroneous clearing of MC_INTSTATUS 0x0 register during > of the LA programming in tegra_mc_setup_latency_allowance() due to the > mi

Re: [PATCH v7 32/47] memory: tegra-mc: Add interconnect framework

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:49:08PM +0300, Dmitry Osipenko wrote: > Add common SoC-agnostic ICC framework which turns Tegra Memory Controller > into a memory interconnection provider. This allows us to use interconnect > API for tuning of memory configurations. > > Tested-by: Peter Geis > Tested-b

Re: [PATCH v7 33/47] memory: tegra20-emc: Make driver modular

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:49:09PM +0300, Dmitry Osipenko wrote: > Add modularization support to the Tegra20 EMC driver, which now can be > compiled as a loadable kernel module. > > Acked-by: Thierry Reding > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/Kconfig | 2 +- > d

Re: [PATCH v4 2/5] arm64, numa: Change the numa init functions name to be generic

2020-11-06 Thread Catalin Marinas
On Fri, Nov 06, 2020 at 09:33:14AM -0800, Atish Patra wrote: > On Fri, Nov 6, 2020 at 9:14 AM Catalin Marinas > wrote: > > On Mon, Oct 05, 2020 at 05:17:49PM -0700, Atish Patra wrote: > > > diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c > > > index 7ff800045434..96502f

Re: [PATCH v7 34/47] memory: tegra20-emc: Continue probing if timings are missing in device-tree

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:49:10PM +0300, Dmitry Osipenko wrote: > EMC driver will become mandatory after turning it into interconnect > provider because interconnect users, like display controller driver, will > fail to probe using newer device-trees that have interconnect properties. > Thus make

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-06 Thread Saravana Kannan
+Rob and Frank On Fri, Nov 6, 2020 at 7:09 AM Mark Brown wrote: > > Currently the fwnode API and things that rely on it like fw_devlink will > not reliably work for devices created from DT since each subsystem that > creates devices must individually set dev->fwnode in addition to setting > dev->

Re: [PATCH v7 35/47] memory: tegra20: Support interconnect framework

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:49:11PM +0300, Dmitry Osipenko wrote: > Now Internal and External Memory Controllers are memory interconnection > providers. This allows us to use interconnect API for tuning of memory > configuration. EMC driver now supports OPPs and DVFS. > > Signed-off-by: Dmitry Osip

Re: [PATCH memory-model 3/8] tools/memory-model: Document categories of ordering primitives

2020-11-06 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 11:56:54AM -0500, Alan Stern wrote: > On Thu, Nov 05, 2020 at 02:00:12PM -0800, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > The Linux kernel has a number of categories of ordering primitives, which > > are recorded in the LKMM implementation and hinted a

Re: [PATCH tip/core/rcu 03/28] locktorture: Track time of last ->writeunlock()

2020-11-06 Thread Paul E. McKenney
On Thu, Nov 05, 2020 at 10:56:42PM -0800, Davidlohr Bueso wrote: > On Thu, 05 Nov 2020, paul...@kernel.org wrote: > > > From: "Paul E. McKenney" > > > > This commit adds a last_lock_release variable that tracks the time of > > the last ->writeunlock() call, which allows easier diagnosing of lock

Re: [PATCH v1 2/2] spi: Populate fwnode in of_register_spi_device()

2020-11-06 Thread Saravana Kannan
On Fri, Nov 6, 2020 at 7:10 AM Mark Brown wrote: > > On Thu, Nov 05, 2020 at 11:26:44AM -0800, Saravana Kannan wrote: > > On Thu, Nov 5, 2020 at 9:12 AM Mark Brown wrote: > > > > > of_node_get(nc); > > > > spi->dev.of_node = nc; > > > > + spi->dev.fwnode = of_fwnode_handle(nc); >

Re: [PATCH v7 36/47] memory: tegra20-emc: Add devfreq support

2020-11-06 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 07:49:12PM +0300, Dmitry Osipenko wrote: > Add devfreq support to the Tegra20 EMC driver. Memory utilization > statistics will be periodically polled from the memory controller and > appropriate minimum clock rate will be selected by the devfreq governor. > > Signed-off-by:

Re: [PATCH] drm/panel: simple: Add flags to boe_nv133fhm_n61

2020-11-06 Thread Doug Anderson
Hi, On Fri, Nov 6, 2020 at 10:23 AM Stephen Boyd wrote: > > Reading the EDID of this panel shows that these flags should be set. Set > them so that we match what is in the EDID. > > Cc: Douglas Anderson > Cc: Bjorn Andersson > Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61") > Signed

Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap

2020-11-06 Thread Lyude Paul
On Thu, 2020-11-05 at 14:45 +, Lee Jones wrote: > The stack is too full. > > Fixes the following W=1 kernel build warning(s): > >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function > ‘sideband_msg_req_encode_decode’: >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: w

[PATCH v2 1/2] reset: brcmstb rescal: implement {de}assert() instead of reset()

2020-11-06 Thread Jim Quinlan
Before, only control_reset() was implemented. However, the reset core only invokes control_reset() once in its lifetime. Because we need it to invoke control_reset() again after resume out of S2 or S3, we have switched to putting the reset functionality into the control_deassert() method and havi

[PATCH v2 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller

2020-11-06 Thread Jim Quinlan
v2 -- refactor rescal-reset driver to implement assert/deassert rather than reset because the reset call only fires once per lifetime and we need to reset after every resume from S2 or S3. -- Split the use of "ahci" and "rescal" controllers in separate fields to keep things sim

[PATCH v2 2/2] ata: ahci_brcm: Fix use of BCM7216 reset controller

2020-11-06 Thread Jim Quinlan
From: Jim Quinlan This driver may use one of two resets controllers. Keep them in separate variables to keep things simple. The reset controller "rescal" is shared between the AHCI driver and the PCIe driver for the BrcmSTB 7216 chip. Use devm_reset_control_get_optional_shared() to handle this

[PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread Arpitha Raghunandan
Implementation of support for parameterized testing in KUnit. This approach requires the creation of a test case using the KUNIT_CASE_PARAM macro that accepts a generator function as input. This generator function should return the next parameter given the previous parameter in parameterized tests.

[PATCH v6 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature

2020-11-06 Thread Arpitha Raghunandan
Modify fs/ext4/inode-test.c to use the parameterized testing feature of KUnit. Signed-off-by: Arpitha Raghunandan <98.a...@gmail.com> --- Changes v5->v6: - No change to this patch of the patch series Changes v4->v5: - No change to this patch of the patch series Changes v3->v4: - Modification based

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-06 Thread Mark Brown
On Fri, Nov 06, 2020 at 11:09:17AM -0800, Saravana Kannan wrote: > If you want to do this in "one common place", then I think the way to > do this is have include/linux/of.h provide something like: > void of_set_device_of_node(dev, of_node) > { > dev->of_node = of_node; > dev->fw_node = &

Re: [PATCH memory-model 5/8] tools/memory-model: Add a glossary of LKMM terms

2020-11-06 Thread Alan Stern
On Fri, Nov 06, 2020 at 10:04:46AM -0800, Paul E. McKenney wrote: > On Fri, Nov 06, 2020 at 11:59:30AM -0500, Alan Stern wrote: > > > + See also "Control Dependency". > > > > There should also be an entry for "Data Dependency", linked from here > > and from Control Dependency. > > > > > +Marked

Re: [PATCH V2 1/3] dt-bindings: arm: fsl: Add beacon,imx8mn-beacon-kit

2020-11-06 Thread Krzysztof Kozlowski
On Fri, Nov 06, 2020 at 06:12:35AM -0600, Adam Ford wrote: > Add beacon,imx8mn-beacon-kit to list of compatible options. > > Signed-off-by: Adam Ford > --- > V2: New to series > > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documenta

[PATCH] auxdisplay: fix use after free in lcd2s_i2c_remove()

2020-11-06 Thread Dan Carpenter
The kfree() needs to be moved down a line to prevent a use after free. Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display") Signed-off-by: Dan Carpenter --- drivers/auxdisplay/lcd2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/auxdisplay/l

Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap

2020-11-06 Thread Lee Jones
On Fri, 06 Nov 2020, Lyude Paul wrote: > On Thu, 2020-11-05 at 14:45 +, Lee Jones wrote: > > The stack is too full. > > > > Fixes the following W=1 kernel build warning(s): > > > >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function > > ‘sideband_msg_req_encode_decode’: > >  dri

Re: [PATCH v8 17/18] scsi: megaraid_sas: Added support for shared host tagset for cpuhotplug

2020-11-06 Thread Sumit Saxena
On Wed, Nov 4, 2020 at 11:38 PM John Garry wrote: > > On 04/11/2020 16:07, Kashyap Desai wrote: > >>> > >>> v5.10-rc2 is also broken here. > >> > >> John, Kashyap, any update on this? If this is going to take a while to fix > >> it > >> proper, should I send a patch to revert this or at least disa

[GIT PULL] Ceph fix for 5.10-rc3

2020-11-06 Thread Ilya Dryomov
Hi Linus, The following changes since commit 3cea11cd5e3b00d91caf0b4730194039b45c5891: Linux 5.10-rc2 (2020-11-01 14:43:51 -0800) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-5.10-rc3 for you to fetch changes up to 62575e270f661aba64778cbc5f

Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem()

2020-11-06 Thread Jason Gunthorpe
On Fri, Nov 06, 2020 at 11:20:05AM -0700, Logan Gunthorpe wrote: > > > On 2020-11-06 11:09 a.m., Jason Gunthorpe wrote: > >> Ah, hmm, yes. I guess the pages have to be hooked and returned to the > >> genalloc through free_devmap_managed_page(). > > > > That sounds about right, but in this case

Re: [PATCH V2 2/3] arm64: dts: imx: Add Beacon i.MX8M Nano development kit

2020-11-06 Thread Krzysztof Kozlowski
On Fri, Nov 06, 2020 at 06:12:36AM -0600, Adam Ford wrote: > Beacon Embeddedworks is launching a development kit based on the > i.MX8M Nano SoC. The kit consists of a System on Module (SOM) > + baseboard. The SOM has the SoC, eMMC, and Ethernet. The baseboard > has an wm8962 audio CODEC, a PDM mi

Re: [RFC PATCH 0/4] EDAC/ghes: Add EDAC device for recording the CPU error count

2020-11-06 Thread James Morse
Hi Shiju, On 05/11/2020 17:42, Shiju Jose wrote: > For the firmware-first error handling on ARM64 hardware platforms, > CPU cache corrected error count is not recorded. > Create an CPU EDAC device and device blocks for the CPU caches > for this purpose. The EDAC device blocks are created based on

Re: [RFC PATCH 1/4] ACPI: PPTT: Fix for a high level cache node detected in the low level

2020-11-06 Thread James Morse
Hi Shiju, Jonathan, On 05/11/2020 17:42, Shiju Jose wrote: > From: Jonathan Cameron > > According to the following sections of the PPTT definition in the > ACPI specification(V6.3), a high level cache node( For example L2 cache) > could be represented simultaneously both in the private resource

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-06 Thread Mark Brown
On Thu, Nov 05, 2020 at 08:37:14PM +, Parav Pandit wrote: > > > This example describes the mlx5 PCI subfunction use case. > > > I didn't follow your question about 'explicit example'. > > > What part is missing to identify it as explicit example? > > Specifically listing "mlx5" so if someone

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread Marco Elver
On Fri, 6 Nov 2020 at 20:22, Arpitha Raghunandan <98.a...@gmail.com> wrote: > Implementation of support for parameterized testing in KUnit. > This approach requires the creation of a test case using the > KUNIT_CASE_PARAM macro that accepts a generator function as input. > This generator function s

Re: [PATCH v5 4/5] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-11-06 Thread Krzysztof Kozlowski
On Tue, Nov 03, 2020 at 04:15:35PM +0100, Łukasz Stelmach wrote: > Add node for ax88796c ethernet chip. > > Signed-off-by: Łukasz Stelmach > --- > arch/arm/boot/dts/exynos3250-artik5-eval.dts | 29 > 1 file changed, 29 insertions(+) Thanks, applied. Best regards, Krzysztof

Re: [PATCH v5 5/5] ARM: defconfig: Enable ax88796c driver

2020-11-06 Thread Krzysztof Kozlowski
On Tue, Nov 03, 2020 at 04:15:36PM +0100, Łukasz Stelmach wrote: > Enable ax88796c driver for the ethernet chip on Exynos3250-based > ARTIK5 boards. > > Signed-off-by: Łukasz Stelmach > --- > arch/arm/configs/exynos_defconfig | 2 ++ > arch/arm/configs/multi_v7_defconfig | 2 ++ Thanks, applie

Re: [PATCH v5 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-11-06 Thread Krzysztof Kozlowski
On Tue, Nov 03, 2020 at 04:15:33PM +0100, Łukasz Stelmach wrote: > Add bindings for AX88796C SPI Ethernet Adapter. > > Signed-off-by: Łukasz Stelmach > --- > .../bindings/net/asix,ax88796c.yaml | 73 +++ > 1 file changed, 73 insertions(+) > create mode 100644 Documenta

[GIT PULL] mtd: Fixes for v5.10-rc3

2020-11-06 Thread Miquel Raynal
Hello Linus, This is an MTD fixes PR for the next -rc. Thanks, Miquèl The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git

Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem()

2020-11-06 Thread Logan Gunthorpe
On 2020-11-06 12:30 p.m., Jason Gunthorpe wrote: >> I certainly can't make decisions for code that isn't currently >> upstream. > > The rdma drivers are all upstream, what are you thinking about? Really? I feel like you should know what I mean here... I mean upstream code that actually uses t

Re: [PATCH v14 02/26] x86/cpufeatures: Add CET CPU feature flags for Control-flow Enforcement Technology (CET)

2020-11-06 Thread Yu, Yu-cheng
On 11/6/2020 10:49 AM, Borislav Petkov wrote: On Mon, Oct 12, 2020 at 08:38:26AM -0700, Yu-cheng Yu wrote: Add CPU feature flags for Control-flow Enforcement Technology (CET). CPUID.(EAX=7,ECX=0):ECX[bit 7] Shadow stack CPUID.(EAX=7,ECX=0):EDX[bit 20] Indirect Branch Tracking Signed-off-by: Yu

Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization

2020-11-06 Thread Nick Desaulniers
On Fri, Nov 6, 2020 at 3:50 AM Adrian Ratiu wrote: > > Hi Nathan, > > On Fri, 06 Nov 2020, Nathan Chancellor > wrote: > > + Ard, who wrote this code. > > > > On Fri, Nov 06, 2020 at 07:14:36AM +0200, Adrian Ratiu wrote: > >> Due to a Clang bug [1] neon autoloop vectorization does not > >> happen

Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem()

2020-11-06 Thread Jason Gunthorpe
On Fri, Nov 06, 2020 at 12:44:59PM -0700, Logan Gunthorpe wrote: > > > On 2020-11-06 12:30 p.m., Jason Gunthorpe wrote: > >> I certainly can't make decisions for code that isn't currently > >> upstream. > > > > The rdma drivers are all upstream, what are you thinking about? > > Really? I feel l

Re: [PATCH memory-model 5/8] tools/memory-model: Add a glossary of LKMM terms

2020-11-06 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 02:23:51PM -0500, Alan Stern wrote: > On Fri, Nov 06, 2020 at 10:04:46AM -0800, Paul E. McKenney wrote: > > On Fri, Nov 06, 2020 at 11:59:30AM -0500, Alan Stern wrote: > > > > +See also "Control Dependency". > > > > > > There should also be an entry for "Data Depend

Re: [PATCH] applesmc: Re-work SMC comms v2

2020-11-06 Thread Henrik Rydberg
So as it stands, it does not work at all. I will continue to check another machine, and see if I can get something working. On the MacBookAir3,1 the situation is somewhat better. The first three tree positions result in zero failures and 10 reads per second. The fourth yields zero failues and

Re: [PATCH 2/5] mm: migrate: simplify the logic for handling permanent failure

2020-11-06 Thread Zi Yan
On 3 Nov 2020, at 8:03, Yang Shi wrote: > When unmap_and_move{_huge_page}() returns !-EAGAIN and !MIGRATEPAGE_SUCCESS, > the page would be put back to LRU or proper list if it is non-LRU movable > page. But, the callers always call putback_movable_pages() to put the > failed pages back later on,

Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem()

2020-11-06 Thread Logan Gunthorpe
On 2020-11-06 12:53 p.m., Jason Gunthorpe wrote: > On Fri, Nov 06, 2020 at 12:44:59PM -0700, Logan Gunthorpe wrote: >> >> >> On 2020-11-06 12:30 p.m., Jason Gunthorpe wrote: I certainly can't make decisions for code that isn't currently upstream. >>> >>> The rdma drivers are all upstr

[PATCH 2/5] bonding: replace use of the term master where possible

2020-11-06 Thread Jarod Wilson
Simply refer to what was the bonding "master" as the "bond" or bonding device, depending on context. However, do retain compat code for the bonding_masters sysfs interface to avoid breaking userspace. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kic

[PATCH net-next v4 0/5] bonding: rename bond components

2020-11-06 Thread Jarod Wilson
The bonding driver's use of master and slave, while largely understood in technical circles, poses a barrier for inclusion to some potential members of the development and user community, due to the historical context of masters and slaves, particularly in the United States. This is a first full pa

[PATCH 5/5] bonding: update Documentation for port/bond terminology

2020-11-06 Thread Jarod Wilson
Swap in port/bond terminology where appropriate, leaving all legacy sysfs and procfs interface mentions in place, but marked as deprecated. Additionally, add more netlink/iproute2 documentation, and note that this is the preferred method of interfacing with the bonding driver. While we're at it, al

[PATCH 1/5] bonding: rename 802.3ad's struct port to ad_port

2020-11-06 Thread Jarod Wilson
The intention is to reuse "port" in place of "slave" in the bonding driver after making this change, as port is consistent with the bridge and team drivers, and allows us to remove socially problematic language from the bonding driver. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek C

[PATCH 4/5] bonding: rename bonding_sysfs_slave.c to _port.c

2020-11-06 Thread Jarod Wilson
Now that use of "slave" has been replaced by "port", rename this file too. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/Makefile

Re: [PATCH 4/5] mm: migrate: clean up migrate_prep{_local}

2020-11-06 Thread Zi Yan
On 3 Nov 2020, at 8:03, Yang Shi wrote: > The migrate_prep{_local} never fails, so it is pointless to have return > value and check the return value. > > Signed-off-by: Yang Shi > --- > include/linux/migrate.h | 4 ++-- > mm/mempolicy.c | 8 ++-- > mm/migrate.c| 8 ++

[PATCH v2] reboot: allow to specify reboot mode via sysfs

2020-11-06 Thread Matteo Croce
From: Matteo Croce The kernel cmdline reboot= option offers some sort of control on how the reboot is issued. Add handles in sysfs to allow setting these reboot options, so they can be changed when the system is booted, other than at boot time. The handlers are under /kernel/reboot, can be read

Re: [EXT] Re: [PATCH v2 4/4] soc: imx8m: change to use platform driver

2020-11-06 Thread Krzysztof Kozlowski
On Fri, Nov 06, 2020 at 10:35:35AM +, Alice Guo wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年11月5日 17:06 > > To: Alice Guo > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.de; > > dl-linux-imx ; Peng Fan ; > > devicet...@vger.ker

Re: [PATCH v14 02/26] x86/cpufeatures: Add CET CPU feature flags for Control-flow Enforcement Technology (CET)

2020-11-06 Thread Borislav Petkov
On Fri, Nov 06, 2020 at 11:48:26AM -0800, Yu, Yu-cheng wrote: > I will drop it. It has been re-based many times, and probably I > accidentally introduced something else? Yah, I think I added my tag to this version: https://lkml.kernel.org/lkml/20181119214809.6086-3-yu-cheng...@intel.com/ Do you

Re: [PATCH 4.19 107/191] ARM: dts: s5pv210: move PMU node out of clock controller

2020-11-06 Thread Krzysztof Kozlowski
On Thu, Nov 05, 2020 at 08:55:08PM +0100, Pavel Machek wrote: > Hi! > > > > > The Power Management Unit (PMU) is a separate device which has little > > > > common with clock controller. Moving it to one level up (from clock > > > > controller child to SoC) allows to remove fake simple-bus compati

Re: [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m

2020-11-06 Thread Randy Dunlap
On 11/6/20 8:11 AM, Vadym Kochan wrote: > With CONFIG_BRIDGE=m the compilation fails: > > ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in > function `prestera_bridge_port_event': > prestera_switchdev.c:(.text+0x2ebd): undefined reference to > `br_vlan_enabled' > > in

[PATCH] x86/resctrl: Fix AMD L3 QOS CDP enable/disable

2020-11-06 Thread Babu Moger
When the AMD QoS feature CDP(code and data prioritization) is enabled or disabled, the CDP bit in MSR _0C81 is written on one of the cpus in L3 domain(core complex). That is not correct. The CDP bit needs to be updated all the logical cpus in the domain. This was not spelled out clearly in the

Re: [PATCH v14 02/26] x86/cpufeatures: Add CET CPU feature flags for Control-flow Enforcement Technology (CET)

2020-11-06 Thread Yu, Yu-cheng
On 11/6/2020 12:11 PM, Borislav Petkov wrote: On Fri, Nov 06, 2020 at 11:48:26AM -0800, Yu, Yu-cheng wrote: I will drop it. It has been re-based many times, and probably I accidentally introduced something else? Yah, I think I added my tag to this version: https://lkml.kernel.org/lkml/201811

Re: [PATCH 5/5] mm: migrate: return -ENOSYS if THP migration is unsupported

2020-11-06 Thread Zi Yan
On 3 Nov 2020, at 8:03, Yang Shi wrote: > In the current implementation unmap_and_move() would return -ENOMEM if > THP migration is unsupported, then the THP will be split. If split is > failed just exit without trying to migrate other pages. It doesn't make > too much sense since there may be e

Re: linux-next: manual merge of the net-next tree with the net tree

2020-11-06 Thread ljp
On 2020-11-03 18:43, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/ibm/ibmvnic.c between commit: 1d8504937478 ("powerpc/vnic: Extend "failover pending" window") from the net tree and commit: 16b5f5ce351f ("ibmvnic

Re: [PATCH] Revert "ARC: entry: fix potential EFA clobber when TIF_SYSCALL_TRACE"

2020-11-06 Thread Vineet Gupta
Hi Stable Team, On 10/19/20 7:19 PM, Vineet Gupta wrote: > This reverts commit 00fdec98d9881bf5173af09aebd353ab3b9ac729. > (but only from 5.2 and prior kernels) > > The original commit was a preventive fix based on code-review and was > auto-picked for stable back-port (for better or worse). > It

[PATCH] mm, kvm: account kvm_vcpu_mmap to kmemcg

2020-11-06 Thread Shakeel Butt
A VCPU of a VM can allocate couple of pages which can be mmap'ed by the user space application. At the moment this memory is not charged to the memcg of the VMM. On a large machine running large number of VMs or small number of VMs having large number of VCPUs, this unaccounted memory can be very s

Re: [PATCH RFC v3 2/4] x86/bus_lock: Handle warn and fatal in #DB for bus lock

2020-11-06 Thread Fenghua Yu
Hi, Xiaoyao, On Tue, Nov 03, 2020 at 08:15:27PM +0800, Xiaoyao Li wrote: > On 10/31/2020 8:27 AM, Fenghua Yu wrote: > > diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c > > index 3c70fb34028b..1c3442000972 100644 > > --- a/arch/x86/kernel/traps.c > > +++ b/arch/x86/kernel/traps.c > >

[PATCH] mm: introduce oom_kill_disable sysctl knob

2020-11-06 Thread Minchan Kim
It's hard to have some tests to be supposed to work under heavy memory pressure(e.g., injecting some memory hogger) because out-of-memory killer easily kicks out one of processes so system is broken or system loses the memory pressure state since it has plenty of free memory soon so. Even though we

Re: [PATCH v3 19/26] coresight: etm4x: Detect access early on the target CPU

2020-11-06 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:38PM +, Suzuki K Poulose wrote: > In preparation to detect the support for system instruction > support, move the detection of the device access to the target > CPU. > > Signed-off-by: Suzuki K Poulose > --- > .../coresight/coresight-etm4x-core.c | 45 +

Re: [PATCH v3 1/6] mm/thp: add prep_transhuge_device_private_page()

2020-11-06 Thread Ralph Campbell
On 11/6/20 4:14 AM, Matthew Wilcox wrote: On Thu, Nov 05, 2020 at 04:51:42PM -0800, Ralph Campbell wrote: Add a helper function to allow device drivers to create device private transparent huge pages. This is intended to help support device private THP migrations. I think you'd be better off

Re: [PATCH v40 10/24] mm: Add 'mprotect' hook to struct vm_operations_struct

2020-11-06 Thread Borislav Petkov
On Fri, Nov 06, 2020 at 06:51:07PM +0200, Jarkko Sakkinen wrote: > Both comments make sense to me. I'll refine this patch on Monday and And while you're at it, I'd suggest you refine the whole patchset and send a full v41 instead: - please audit all your Reviewed-by, Acked-by tags as to for what

Re: [PATCH] docs: trace: fix event state structure name

2020-11-06 Thread Steven Rostedt
On Wed, 4 Nov 2020 14:21:13 +0200 Artem Bityutskiy wrote: > From: Artem Bityutskiy > > The documentation refers to a non-existent 'struct synth_trace_state' > structure. The correct name is 'struct synth_event_trace_state'. > > In other words, this patch is a mechanical substitution: > s/synt

Re: [PATCH memory-model 5/8] tools/memory-model: Add a glossary of LKMM terms

2020-11-06 Thread Alan Stern
On Fri, Nov 06, 2020 at 11:59:12AM -0800, Paul E. McKenney wrote: > On Fri, Nov 06, 2020 at 02:23:51PM -0500, Alan Stern wrote: > > On Fri, Nov 06, 2020 at 10:04:46AM -0800, Paul E. McKenney wrote: > > > On Fri, Nov 06, 2020 at 11:59:30AM -0500, Alan Stern wrote: > > > > > + See also "Control

<    3   4   5   6   7   8   9   10   11   12   >