Re: [PATCH v1 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-04 Thread Krzysztof Kozlowski
On Wed, 4 Nov 2020 at 04:12, Alice Guo wrote: > > Add DT Binding doc for the Unique ID of i.MX 8M series. You sent twice patches labeled v1. Which one is v1 and which is v2? Which should be reviewed? What are the differences? Best regards, Krzysztof

Re: [PATCH v1 1/4] LF-2571-1: dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-04 Thread Krzysztof Kozlowski
On Wed, 4 Nov 2020 at 08:58, Krzysztof Kozlowski wrote: > > On Wed, 4 Nov 2020 at 04:09, Alice Guo wrote: > > > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > > > Signed-off-by: Alice Guo > > --- > > .../bindings/soc/imx/imx8m-unique-id.yaml | 32 +++ > > 1 fi

Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-11-04 Thread Christian König
If nobody comes up with an objections I'm going to merge that through drm-misc-next. Thanks, Christian. Am 12.10.20 um 10:52 schrieb Christian König: Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." adds a workaround for a bug in mmap_region. As the comment states ->mmap() callback can

Re: [PATCH V4 1/2] scsi: ufs: Add DeepSleep feature

2020-11-04 Thread Can Guo
On 2020-11-03 22:14, Adrian Hunter wrote: DeepSleep is a UFS v3.1 feature that achieves the lowest power consumption of the device, apart from power off. In DeepSleep mode, no commands are accepted, and the only way to exit is using a hardware reset or power cycle. This patch assumes that if

RE: [PATCH v1 1/4] LF-2571-1: dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-04 Thread Peng Fan
> Subject: Re: [PATCH v1 1/4] LF-2571-1: dt-bindings: soc: imx8m: add DT > Binding doc for soc unique ID > > On Wed, 4 Nov 2020 at 04:09, Alice Guo wrote: > > > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > > > Signed-off-by: Alice Guo > > --- > > .../bindings/soc/imx/imx8m-uniq

Re: [PATCH V4 2/2] scsi: ufs: Allow an error return value from ->device_reset()

2020-11-04 Thread Can Guo
On 2020-11-03 22:14, Adrian Hunter wrote: It is simpler for drivers to provide a ->device_reset() callback irrespective of whether the GPIO, or firmware interface necessary to do the reset, is discovered during probe. Change ->device_reset() to return an error code. Drivers that provide the c

Re: [PATCH v2] checkpatch: improve email parsing

2020-11-04 Thread Lukas Bulwahn
On Tue, 3 Nov 2020, Joe Perches wrote: > On Tue, 2020-11-03 at 09:10 +0100, Lukas Bulwahn wrote: > > Maybe you can coordinate among each other who would want to create > > suitable fix rules here? > > Yes please. > > > Also, start with the class of the most frequent mistakes for > > unexpecte

Re: [PATCH v1 3/4] LF-2571-3 arm64: dts: imx8m: add nvmem-cell related stuff

2020-11-04 Thread Krzysztof Kozlowski
On Wed, 4 Nov 2020 at 04:12, Alice Guo wrote: > > Add nvmem-cell related stuff for the soc unique ID. Subject and commit msg: please do not add "stuff" but describe what are you adding and why (what is the purpose, feature, benefit). "Stuff" is too generic. > > Signed-off-by: Alice Guo > --- >

Re: [PATCH v1 1/1] ARM: dts: sun8i: h3: Add initial NanoPi R1 support

2020-11-04 Thread Yu-Tung Chang
Maxime Ripard 于2020年11月3日周二 下午7:37写道: > > Hi! > > On Mon, Nov 02, 2020 at 06:01:57PM +0800, Yu-Tung Chang wrote: > > The NanoPi R1 is a complete open source board developed > > by FriendlyElec for makers, hobbyists, fans and etc. > > > > NanoPi R1 key features > > - Allwinner H3, Quad-core Cortex-

Re: [PATCH v1 1/4] LF-2571-1: dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-04 Thread Krzysztof Kozlowski
On Wed, 4 Nov 2020 at 09:04, Peng Fan wrote: > > > +ed=0 > > > + > > > +title: NXP i.MX8M Platforms Device Tree Bindings > > > > This is not a title for these bindings. Please describe the bindings for > > this > > device. Based on description, this might could go to bindings/nvmem > > directory.

Re: use of dma_direct_set_offset in (allwinner) drivers

2020-11-04 Thread Maxime Ripard
Hi Christoph, On Tue, Nov 03, 2020 at 10:55:38AM +0100, Christoph Hellwig wrote: > Linux 5.10-rc1 switched from having a single dma offset in struct device > to a set of DMA ranges, and introduced a new helper to set them, > dma_direct_set_offset. > > This in fact surfaced that a bunch of drivers

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-04 Thread Michal Hocko
On Wed 04-11-20 09:20:04, Xing Zhengjun wrote: > > > On 11/2/2020 6:02 PM, Michal Hocko wrote: > > On Mon 02-11-20 17:53:14, Rong Chen wrote: > > > > > > > > > On 11/2/20 5:27 PM, Michal Hocko wrote: > > > > On Mon 02-11-20 17:15:43, kernel test robot wrote: > > > > > Greeting, > > > > > > > >

[PATCH] iommu/vt-d: avoid unnecessory panic if iommu init fail in tboot

2020-11-04 Thread Zhenzhong Duan
"intel_iommu=off" command line is used to disable iommu and iommu is force enabled in a tboot system. Meanwhile "intel_iommu=tboot_noforce,off" could be used to force disable iommu in tboot for better performance. By default kernel should panic if iommu init fail in tboot for security reason, but

Re: [PATCH] sound/core/seq: remove useless function

2020-11-04 Thread Takashi Iwai
On Tue, 03 Nov 2020 23:33:35 +0100, Yu Hao wrote: > > The function snd_seq_queue_client_termination() is only called from > the function seq_free_client1(). The function seq_free_client1() calls > the function snd_seq_queue_client_leave() and the function > snd_seq_queue_client_termination() toget

[PATCH v2 2/3] arm64: smp: Register IPI_CPU_CRASH_STOP IPI as pseudo-NMI

2020-11-04 Thread Yuichi Ito
Register IPI_CPU_CRASH_STOP IPI as pseudo-NMI. For systems that do not support pseudo-NMI, register as a normal IRQ. Signed-off-by: Yuichi Ito --- arch/arm64/kernel/smp.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/arch/arm64/kern

[PATCH v2 3/3] arm64: smp: Disable priority masking when NMI is enable on PSR.I section

2020-11-04 Thread Yuichi Ito
It should be prohibitted to use priority masking in NMI context. Using local_irq_disable() under the above conditions causes a WARNING. Then, there will be also a mismatch between the PSR.I values and PMR GIC_PRIO_PSR_I_SET. Signed-off-by: Yuichi Ito --- arch/arm64/kernel/smp.c | 4 +++- 1 fil

[PATCH v2 0/3] Enable support IPI_CPU_CRASH_STOP to be pseudo-NMI

2020-11-04 Thread Yuichi Ito
This patchset enables IPI_CPU_CRASH_STOP IPI to be pseudo-NMI. This allows kdump to collect system information even when the CPU is in a HARDLOCKUP state. Only IPI_CPU_CRASH_STOP uses NMI and the other IPIs remain normal IRQs. The patch has been tested on FX1000. It also uses some of Sumit's IPI

[PATCH v2 1/3] irqchip/gic-v3: Enable support for SGIs to act as NMIs

2020-11-04 Thread Yuichi Ito
From: From: Sumit Garg Add support to handle SGIs as pseudo NMIs. As SGIs or IPIs default to a special flow handler: handle_percpu_devid_fasteoi_ipi(), so skip NMI handler update in case of SGIs. Also, enable NMI support prior to gic_smp_init() as allocation of SGIs as IRQs/NMIs happen as part o

Re: [PATCH v3] lib: Convert test_printf.c to KUnit

2020-11-04 Thread Rasmus Villemoes
On 03/11/2020 17.11, Petr Mladek wrote: > On Tue 2020-11-03 12:52:23, Greg KH wrote: >> On Tue, Nov 03, 2020 at 01:33:53PM +0200, Andy Shevchenko wrote: >>> On Tue, Nov 03, 2020 at 04:40:49PM +0530, Arpitha Raghunandan wrote: Convert test lib/test_printf.c to KUnit. More information about

[Regression]: Commit 74d905d2 breaks the touchpad and touchscreen of Google Chromebook "samus"

2020-11-04 Thread Andre
Hi, commit 74d905d2: Input: atmel_mxt_ts - only read messages in mxt_acquire_irq() when necessary breaks the touchpad and touchscreen of the 2015 Chromebook Pixel "Samus". Reverting the commit from the current git tree gets them to work again. I am not at all shure what info to include, but I

[PATCH] iommu/vt-d: remove redundant variable no_platform_optin

2020-11-04 Thread Zhenzhong Duan
no_platform_optin is redundant with dmar_disabled and it's only used in platform_optin_force_iommu(), remove it and use dmar_disabled instead. Meanwhile remove all the dead code in platform_optin_force_iommu(). Signed-off-by: Zhenzhong Duan --- drivers/iommu/intel/iommu.c | 14 ++ 1

[PATCH] scsi: qla2xxx: use the dma_pool_zalloc() instead of dma_pool_alloc/memset

2020-11-04 Thread xiakaixu1987
From: Kaixu Xia Here we could use the dma_pool_zalloc() function instead of dma_pool_alloc/memset. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- drivers/scsi/qla2xxx/qla_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/s

Re: Patch "powerpc/powernv/dump: Fix race while processing OPAL dump" has been added to the 4.4-stable tree

2020-11-04 Thread yangerkun
Hi, This will lead a compile error. arch/powerpc/platforms/powernv/opal-dump.c: In function ‘process_dump’: arch/powerpc/platforms/powernv/opal-dump.c:409:7: error: void value not ignored as it ought to be dump = create_dump_obj(dump_id, dump_size, dump_type); ^ make[2]: *** [arch/po

support splice reads on seq_file based procfs files v2

2020-11-04 Thread Christoph Hellwig
Hi Al, Greg reported a problem due to the fact that Android tests use procfs files to test splice, which stopped working with 5.10-rc1. This series adds read_iter support for seq_file, and uses those for various seq_files in procfs to restore splice read support. Chances since v1: - only switch

Re: [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-11-04 Thread Leo Yan
On Tue, Nov 03, 2020 at 12:13:04PM +, Dave Martin wrote: > On Tue, Nov 03, 2020 at 10:13:49AM +, André Przywara wrote: > > On 03/11/2020 06:40, Leo Yan wrote: > > > > Hi Dave, Leo, > > > > > On Mon, Nov 02, 2020 at 05:06:53PM +, Dave Martin wrote: > > >> On Fri, Oct 30, 2020 at 02:57:

Re: [PATCH V4 1/2] scsi: ufs: Add DeepSleep feature

2020-11-04 Thread Can Guo
Hi Adrian, On 2020-11-03 22:14, Adrian Hunter wrote: DeepSleep is a UFS v3.1 feature that achieves the lowest power consumption of the device, apart from power off. In DeepSleep mode, no commands are accepted, and the only way to exit is using a hardware reset or power cycle. This patch ass

[PATCH] perf test: Omit test 68 for s390.

2020-11-04 Thread Thomas Richter
Commit ed21d6d7c48e6e ("perf tests: Add test for PE binary format support") adds a WINDOWS EXE file named tests/pe-file.exe, which is examined by the test case 'PE file support'. This test reads the buildid from the file tests/pe-file.exe, which is a Portable Executable (PE) binary file used by th

Re: [PATCH v2 3/4] iommu/iova: Flush CPU rcache for when a depot fills

2020-11-04 Thread John Garry
Hi Robin, - then cpu3, cpu4, and so on. - We can do this for all CPUs in the system, so total CPU rcache grows from zero -> #CPUs * 128 * 2. Yet no DMA mapping leaks. I get that. That's the initial warm-up phase I alluded to below. In an even simpler example, allocating on CPU A and freeing

Re: [PATCH v2] media: atomisp: Fix error handling path

2020-11-04 Thread Dan Carpenter
On Wed, Nov 04, 2020 at 08:15:58AM +0100, Markus Elfring wrote: > > Fixes: 14a638ab96c5 ("media: atomisp: use pin_user_pages() for memory > > allocation") > > Please delete a line break for this tag. Markus, the thing is that we all saw the line break and we just thought it didn't matter at all..

[PATCH 1/6] seq_file: add seq_read_iter

2020-11-04 Thread Christoph Hellwig
iov_iter based variant for reading a seq_file. seq_read is reimplemented on top of the iter variant. Signed-off-by: Christoph Hellwig Tested-by: Greg Kroah-Hartman --- fs/seq_file.c| 45 include/linux/seq_file.h | 1 + 2 files changed, 33 i

[PATCH 2/6] proc: wire up generic_file_splice_read for iter ops

2020-11-04 Thread Christoph Hellwig
Wire up generic_file_splice_read for the iter based proxy ops, so that splice reads from them work. Signed-off-by: Christoph Hellwig Tested-by: Greg Kroah-Hartman --- fs/proc/inode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/proc/inode.c b/fs/proc/inode.c index 58c075e2a452d6..bd

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

2020-11-04 Thread Ard Biesheuvel
On Sat, 31 Oct 2020 at 18:44, Max Filippov wrote: > > On Sat, Oct 31, 2020 at 10:16 AM Mike Rapoport wrote: > > > > On Sat, Oct 31, 2020 at 09:37:09AM -0700, Max Filippov wrote: > > > On Sat, Oct 31, 2020 at 2:43 AM Mike Rapoport wrote: > > > > Please let me know how do you prefer to take it ups

[PATCH] habanalabs/gaudi: remove unreachable code

2020-11-04 Thread Oded Gabbay
From: Ofir Bitton Remove unreachable code in gaudi collective flow. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/habanalabs/gaudi/ga

[PATCH] habanalabs: make sure cs type is valid in cs_ioctl_signal_wait

2020-11-04 Thread Oded Gabbay
Although we get a valid cs type from the callee, in case new values will be added in the future, it is best to check the expected values in that function. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/command_submission.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH 2/2] habanalabs/gaudi: add support for FW security

2020-11-04 Thread Oded Gabbay
From: Ofir Bitton Skip relevant HW configurations once FW security is enabled because these configurations are being performed by FW. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 123 -- ...

[PATCH] habanalabs/gaudi: monitor device memory usage

2020-11-04 Thread Oded Gabbay
In GAUDI we don't have an MMU towards the HBM device memory. Therefore, the user access that memory directly through physical address (via the different engines) without the need to go through the driver to allocate/free memory on the HBM. For system monitoring purposes, the driver will keep track

[PATCH] habanalabs: initialize variable before use

2020-11-04 Thread Oded Gabbay
GCC 7.3.1 20180303 (Red Hat 7.3.1-5) complains that collective_engine_id might be used uninitialized. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/command_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/common/command_subm

[PATCH] habanalabs: advanced FW loading

2020-11-04 Thread Oded Gabbay
From: Ofir Bitton Today driver is able to load a whole FW binary into a specific location on ASIC. We add support for loading sections from the same FW binary into different loactions. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/

[PATCH] habanalabs: fix cs counters structure

2020-11-04 Thread Oded Gabbay
From: farah kassabri Fix cs counters structure in uapi to be one flat structure instead of two instances of the same other structure. use atomic read/increment for context counters so we could use one structure for both aggregated and context counters. Signed-off-by: farah kassabri Reviewed-by:

[PATCH 3/6] proc/cpuinfo: switch to ->read_iter

2020-11-04 Thread Christoph Hellwig
Implement ->read_iter so that the Android bionic test suite can use this random proc file for its splice test case. Signed-off-by: Christoph Hellwig --- fs/proc/cpuinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/cpuinfo.c b/fs/proc/cpuinfo.c index d0989a443c77d

[PATCH 1/2] habanalabs: fetch security indication from FW

2020-11-04 Thread Oded Gabbay
From: Ofir Bitton Add support for fetching security indication from FW. This indication is needed in order to skip unnecessary initializations done by FW. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/firmware_if.c | 60 +++

Re: [PATCH rfc 1/3] mm: memcg: deprecate the non-hierarchical mode

2020-11-04 Thread Michal Hocko
On Tue 03-11-20 13:27:23, Roman Gushchin wrote: > The non-hierarchical cgroup v1 mode is a legacy of early days > of the memory controller and doesn't bring any value today. This is a bold statement ;) All that we know today is that we have a warning in place to complain loudly when somebody relie

Re: [PATCH V4 1/2] scsi: ufs: Add DeepSleep feature

2020-11-04 Thread Adrian Hunter
On 4/11/20 10:29 am, Can Guo wrote: > Hi Adrian, > > On 2020-11-03 22:14, Adrian Hunter wrote: >> DeepSleep is a UFS v3.1 feature that achieves the lowest power consumption >> of the device, apart from power off. >> >> In DeepSleep mode, no commands are accepted, and the only way to exit is >> usi

[PATCH 4/6] proc/stat: switch to ->read_iter

2020-11-04 Thread Christoph Hellwig
Implement ->read_iter so that splice can be used on this file. Suggested-by: Linus Torvalds Signed-off-by: Christoph Hellwig --- fs/proc/stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/stat.c b/fs/proc/stat.c index 46b3293015fe61..4695b6de315129 100644 --- a/f

Re: [PATCH rfc 2/3] docs: cgroup-v1: reflect the deprecation of the non-hierarchical mode

2020-11-04 Thread Michal Hocko
On Tue 03-11-20 13:27:24, Roman Gushchin wrote: > Update cgroup v1 docs after the deprecation of the non-hierarchical > mode of the memory controller. > > Signed-off-by: Roman Gushchin Acked-by: Michal Hocko > --- > .../admin-guide/cgroup-v1/memcg_test.rst | 8 ++-- > .../admin-guide/cg

Re: [RFC PATCH 0/2] mm: fix OOMs for binding workloads to movable zone only node

2020-11-04 Thread Feng Tang
On Wed, Nov 04, 2020 at 08:58:19AM +0100, Michal Hocko wrote: > On Wed 04-11-20 15:38:26, Feng Tang wrote: > [...] > > > Could you be more specific about the usecase here? Why do you need a > > > binding to a pure movable node? > > > > One common configuration for a platform is small size of DRAM

[PATCH 5/6] proc "single files": switch to ->read_iter

2020-11-04 Thread Christoph Hellwig
From: Greg Kroah-Hartman Implement ->read_iter for all proc "single files" so that more bionic tests cases can pass when they call splice() on other fun files like /proc/version Signed-off-by: Greg Kroah-Hartman Signed-off-by: Christoph Hellwig --- fs/proc/generic.c | 2 +- 1 file changed, 1

[PATCH 6/6] proc "seq files": switch to ->read_iter

2020-11-04 Thread Christoph Hellwig
Implement ->read_iter for all proc "seq files" so that splice works on them. Suggested-by: Linus Torvalds Signed-off-by: Christoph Hellwig --- fs/proc/generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index f81327673f4901..b84663

Re: [PATCH v5 11/15] PCI: Obey iomem restrictions for procfs mmap

2020-11-04 Thread Daniel Vetter
On Tue, Nov 3, 2020 at 11:09 PM Dan Williams wrote: > On Tue, Nov 3, 2020 at 1:28 PM Bjorn Helgaas wrote: > > On Fri, Oct 30, 2020 at 11:08:11AM +0100, Daniel Vetter wrote: > > > There's three ways to access PCI BARs from userspace: /dev/mem, sysfs > > > files, and the old proc interface. Two che

Re: [PATCH V4 2/2] scsi: ufs: Allow an error return value from ->device_reset()

2020-11-04 Thread Bean Huo
On Tue, 2020-11-03 at 16:14 +0200, Adrian Hunter wrote: > It is simpler for drivers to provide a ->device_reset() callback > irrespective of whether the GPIO, or firmware interface necessary to > do the > reset, is discovered during probe. > > Change ->device_reset() to return an error code. Driv

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

2020-11-04 Thread Mike Rapoport
On Wed, Nov 04, 2020 at 09:35:14AM +0100, Ard Biesheuvel wrote: > On Sat, 31 Oct 2020 at 18:44, Max Filippov wrote: > > > > On Sat, Oct 31, 2020 at 10:16 AM Mike Rapoport wrote: > > > > > > On Sat, Oct 31, 2020 at 09:37:09AM -0700, Max Filippov wrote: > > > > On Sat, Oct 31, 2020 at 2:43 AM Mike

Re: [PATCH 1/1] mm: avoid re-using pfmemalloc page in page_frag_alloc()

2020-11-04 Thread Eric Dumazet
On 11/4/20 2:16 AM, Rama Nichanamatlu wrote: >> Thanks for providing the numbers.  Do you think that dropping (up to) >> 7 packets is acceptable? > > net.ipv4.tcp_syn_retries = 6 > > tcp clients wouldn't even get that far leading to connect establish issues. This does not really matter. If ho

Re: [PATCH v2] checkpatch: improve email parsing

2020-11-04 Thread Dwaipayan Ray
> I agree with them as well. Let us try to establish one common way from > comments. > > Dwaipayan, if you code this into checkpatch.pl, maybe you can also add > some hints on conventions for tags in the kernel (process) documentation > to explain the rules and conventions we think make sense. > S

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

2020-11-04 Thread Mike Rapoport
Hi Russell, On Sat, Oct 31, 2020 at 05:45:35PM +0200, Mike Rapoport wrote: > On Sat, Oct 31, 2020 at 12:21:24PM +0100, Ard Biesheuvel wrote: > > On Sat, 31 Oct 2020 at 12:04, Russell King - ARM Linux admin > > wrote: > > > > > > Clearly, I wasn't blunt and stroppy enough to be properly understood

[PATCH V3 5/5] PCI: tegra: Check return value of tegra_pcie_init_controller()

2020-11-04 Thread Vidya Sagar
The return value of tegra_pcie_init_controller() must be checked before PCIe link up check and registering debugfs entries subsequently as it doesn't make sense to do these when the controller initialization itself has failed. Signed-off-by: Vidya Sagar --- V3: * New patch in this series driver

[PATCH V3 3/5] PCI: tegra: Set DesignWare IP version

2020-11-04 Thread Vidya Sagar
Set the DesignWare IP version for Tegra194 to 0x490A. This would be used by the DesigWare sub-system to do any version specific configuration (Ex:- TD bit programming for ECRC). Signed-off-by: Vidya Sagar --- V3: * None V2: * None drivers/pci/controller/dwc/pcie-tegra194.c | 1 + 1 file change

Re: [PATCH V2 4/4] PCI: tegra: Handle error conditions properly

2020-11-04 Thread Vidya Sagar
On 11/4/2020 2:18 AM, Bjorn Helgaas wrote: External email: Use caution opening links or attachments Hi Vidya, Can you update the subject to replace "properly" with more details about what the patch is doing? "Properly" is really meaningless in usages like this -- nobody writes patches to d

[PATCH V3 0/5] Enhancements to Tegra194 PCIe driver

2020-11-04 Thread Vidya Sagar
This series of patches do some enhancements and some bug fixes to the Tegra194 PCIe platform driver like - Fix Vendor-ID corruption - Map DBI space correctly - Update DWC IP version - Continue with uninitialization sequence even if parts fail - Check return value of tegra_pcie_init_controller() V3

[PATCH V3 4/5] PCI: tegra: Continue unconfig sequence even if parts fail

2020-11-04 Thread Vidya Sagar
Currently the driver checks for error value of different APIs during the uninitialization sequence. It just returns from there if there is any error observed for one of those calls. Comparatively it is better to continue the uninitialization sequence irrespective of whether some of them are returni

[PATCH V3 2/5] PCI: tegra: Map configuration space as nGnRnE

2020-11-04 Thread Vidya Sagar
As specified in the comment for pci_remap_cfgspace() define in arch/arm64/include/asm/io.h file, PCIe configuration space should be mapped as nGnRnE. Hence changing to dev_pci_remap_cfgspace() from devm_ioremap_resource() for mapping DBI space as that is nothing but the root port's own configuratio

[PATCH V3 1/5] PCI: tegra: Fix ASPM-L1SS advertisement disable code

2020-11-04 Thread Vidya Sagar
If the absence of CLKREQ# signal is indicated by the absence of "supports-clkreq" in the device-tree node, current driver is disabling the advertisement of ASPM-L1 Sub-States *before* the ASPM-L1 Sub-States offset is correctly initialized. Since default value of the ASPM-L1SS offset is zero, this i

Re: [RFC PATCH 0/2] mm: fix OOMs for binding workloads to movable zone only node

2020-11-04 Thread Michal Hocko
On Wed 04-11-20 16:40:21, Feng Tang wrote: > On Wed, Nov 04, 2020 at 08:58:19AM +0100, Michal Hocko wrote: > > On Wed 04-11-20 15:38:26, Feng Tang wrote: > > [...] > > > > Could you be more specific about the usecase here? Why do you need a > > > > binding to a pure movable node? > > > > > > One

Re: [PATCH 0/4] aarch64: avoid mprotect(PROT_BTI|PROT_EXEC) [BZ #26831]

2020-11-04 Thread Szabolcs Nagy
The 11/03/2020 23:41, Jeremy Linton wrote: > On 11/3/20 11:34 AM, Mark Brown wrote: > > On Tue, Nov 03, 2020 at 10:25:37AM +, Szabolcs Nagy wrote: > > > > > Re-mmap executable segments instead of mprotecting them in > > > case mprotect is seccomp filtered. > > > > > For the kernel mapped main

Re: [PATCH 8/8] clk: scpi: mark scpi_clk_match as maybe unused

2020-11-04 Thread Sudeep Holla
On Tue, Nov 03, 2020 at 05:24:35PM +0100, Krzysztof Kozlowski wrote: > The scpi_clk_match (struct of_device_id) is referenced only with > CONFIG_OF builds thus mark it as __maybe_unused: > > drivers/clk/clk-scpi.c:132:34: warning: > ‘scpi_clk_match’ defined but not used [-Wunused-const-

Re: [PATCH 0/4] aarch64: avoid mprotect(PROT_BTI|PROT_EXEC) [BZ #26831]

2020-11-04 Thread Topi Miettinen
On 3.11.2020 19.34, Mark Brown wrote: On Tue, Nov 03, 2020 at 10:25:37AM +, Szabolcs Nagy wrote: Re-mmap executable segments instead of mprotecting them in case mprotect is seccomp filtered. For the kernel mapped main executable we don't have the fd for re-mmap so linux needs to be updat

Re: [PATCH V4 1/2] scsi: ufs: Add DeepSleep feature

2020-11-04 Thread Can Guo
On 2020-11-04 16:37, Adrian Hunter wrote: On 4/11/20 10:29 am, Can Guo wrote: Hi Adrian, On 2020-11-03 22:14, Adrian Hunter wrote: DeepSleep is a UFS v3.1 feature that achieves the lowest power consumption of the device, apart from power off. In DeepSleep mode, no commands are accepted, and

Re: [PATCH 4.19] mm: fix exec activate_mm vs TLB shootdown and lazy tlb switching race

2020-11-04 Thread Greg KH
On Wed, Nov 04, 2020 at 12:14:06PM +1100, Michael Ellerman wrote: > From: Nicholas Piggin > > commit d53c3dfb23c45f7d4f910c3a3ca84bf0a99c6143 upstream. > > Reading and modifying current->mm and current->active_mm and switching > mm should be done with irqs off, to prevent races seeing an interme

Re: [PATCH 4.19 056/191] powerpc: select ARCH_WANT_IRQS_OFF_ACTIVATE_MM

2020-11-04 Thread Greg Kroah-Hartman
On Wed, Nov 04, 2020 at 12:19:45PM +1100, Michael Ellerman wrote: > Michael Ellerman writes: > > Greg Kroah-Hartman writes: > >> From: Nicholas Piggin > >> > >> [ Upstream commit 66acd46080bd9e5ad2be4b0eb1d498d5145d058e ] > >> > >> powerpc uses IPIs in some situations to switch a kernel thread a

[PATCH 00/12] [Set 2] Rid W=1 warnings in Net

2020-11-04 Thread Lee Jones
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is the last set. Lee Jones (12): net: usb: lan78x

[PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/xen-netfront.c: In function ‘store_rxbuf’: drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not

[PATCH 10/12] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'irq' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'ptr' not described i

[PATCH 11/12] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/spider_net.c:263: warning: Function parameter or member 'hwdescr' not described in 'spider_net_get_descr_status' drivers/net/ethernet/toshiba/spider_net.c:263: warning: Excess function parameter 'descr' description i

[PATCH] fs/binfmt_elf: free interpreter in load_elf_binary

2020-11-04 Thread Liu Shixin
The file interpreter is allocated in load_elf_binary, but not freed in the case interp_elf_ex is NULL. Add a label “out_allow_write_access” so that the interpreter will be appropriately released in this case. This memory leak is catched when kmemleak is enabled in kernel, the report looks like bel

[PATCH 12/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data'

[PATCH 05/12] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'dev' not described in 'frontend_changed' drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'frontend_state' not described in 'frontend_changed

[PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused

2020-11-04 Thread Lee Jones
'status' is used to interact with a hardware register. It might not be safe to remove it entirely. Mark it as __maybe_unused instead. Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_phy_configure’: drivers/net/ethernet/smsc/smc911x.c:

[PATCH v2] fs/binfmt_elf: free interpreter in load_elf_binary

2020-11-04 Thread Liu Shixin
The file interpreter is allocated in load_elf_binary, but not freed in the case interp_elf_ex is NULL. Add a label “out_allow_write_access” so that the interpreter will be appropriately released in this case. This memory leak is catched when kmemleak is enabled in kernel, the report looks like bel

[PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpts.c:736: warning: Function parameter or member 'en' not described in 'am65_cpts_rx_enable' drivers/net/ethernet/ti/am65-cpts.c:736: warning: Excess function parameter 'skb' description in 'am65_cpts_rx_enable' Cc

[PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data'

[PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_

Re: [PATCH 4.19 034/191] fscrypt: fix race where ->lookup() marks plaintext dentry as ciphertext

2020-11-04 Thread Greg Kroah-Hartman
On Tue, Nov 03, 2020 at 01:35:52PM -0800, Eric Biggers wrote: > Looks like something went wrong with formatting the email addresses that > receive > these emails. The Cc line has: > > Cc: Greg Kroah-Hartman , > "linux-fscr...@vger.kernel.org, linux-e...@vger.kernel.org, > linux-f2fs-de.

[PATCH 03/12] net: ethernet: xilinx: xilinx_emaclite: Document 'txqueue' even if it is unused

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/xilinx/xilinx_emaclite.c:525: warning: Function parameter or member 'txqueue' not described in 'xemaclite_tx_timeout' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michal Simek Cc: Shannon Nelson Cc: Martin Habets Cc: "Mi

[PATCH 04/12] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'desc' not described in 'try_toggle_co

[PATCH 01/12] net: usb: lan78xx: Remove lots of set but unused 'ret' variables

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/usb/lan78xx.c: In function ‘lan78xx_read_raw_otp’: drivers/net/usb/lan78xx.c:825:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_write_raw_otp’: drivers/net/usb

Re: [PATCH 5.9 374/391] null_blk: synchronization fix for zoned device

2020-11-04 Thread Greg Kroah-Hartman
On Tue, Nov 03, 2020 at 11:36:35PM +, Damien Le Moal wrote: > On 2020/11/04 5:52, Greg Kroah-Hartman wrote: > > From: Kanchan Joshi > > > > commit 35bc10b2eafbb701064b94f283b77c54d3304842 upstream. > > > > Parallel write,read,zone-mgmt operations accessing/altering zone state > > and write-p

Re: [PATCH 1/1] x86/tools: Use tools headers for instruction decoder selftests

2020-11-04 Thread kernel test robot
d in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vasily-Gorbik/x86-tools-Use-tools-headers-for-instruction-decoder-selftests/20201104-043600 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 238c91115cd05c71447ea071624a4c9fe661f

Re: [git pull] habanalabs fixes for 5.10-rc3

2020-11-04 Thread Greg KH
On Wed, Nov 04, 2020 at 09:37:01AM +0200, Oded Gabbay wrote: > Hello Greg, > > This pull request contains three small fixes for 5.10-rc3. Details are in > the tag. > > Thanks, > Oded > > The following changes since commit bcbc0b2e275f0a797de11a10eff495b4571863fc: > > mei: protect mei_cl_mtu f

get_maintainer.pl bug? (was: Re: [PATCH 0/8] linker-section array fix and clean ups)

2020-11-04 Thread Johan Hovold
Hi Joe, Running scrips/get_maintainer.pl on this series [1] gave the wrong address for Nick Desaulniers: Nick Desaulniers (commit_signer:1/2=50%,commit_signer:1/8=12%) It seems he recently misspelled his address in a reviewed-by tag to commit 33def8498fdd ("treewide: Convert macro and

Re: [PATCH v6 2/6] spi: cadence-quadspi: Disable the DAC for Intel LGM SoC

2020-11-04 Thread Ramuthevar, Vadivel MuruganX
Hi Pratyush, Thank you for the review comments... On 4/11/2020 12:09 am, Pratyush Yadav wrote: On 30/10/20 01:31PM, Ramuthevar,Vadivel MuruganX wrote: From: Ramuthevar Vadivel Murugan On Intel Lightning Mountain(LGM) SoCs QSPI controller do not use Direct Access Controller(DAC). This patch

Re: [PATCH 1/1] x86/tools: Use tools headers for instruction decoder selftests

2020-11-04 Thread Vasily Gorbik
ree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/0day-ci/linux/commits/Vasily-Gorbik/x86-tools-Use-tools-headers-for-instruction-dec

Re: [PATCH 0/4] aarch64: avoid mprotect(PROT_BTI|PROT_EXEC) [BZ #26831]

2020-11-04 Thread Will Deacon
On Tue, Nov 03, 2020 at 05:34:38PM +, Mark Brown wrote: > On Tue, Nov 03, 2020 at 10:25:37AM +, Szabolcs Nagy wrote: > > > Re-mmap executable segments instead of mprotecting them in > > case mprotect is seccomp filtered. > > > For the kernel mapped main executable we don't have the fd > >

[PATCH V2] drm/tegra: sor: Don't warn on probe deferral

2020-11-04 Thread Jon Hunter
Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users. Signed-off-by: Jon Hunter --- Changes since V1: - This time, I actually validated it! drivers/gpu/drm/tegra

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

2020-11-04 Thread Serge Belyshev
>> To be sure we are not in front of a long lasting bug, could you try >> CONFIG_KASAN=y on v5.9 ? > > Indeed it started to fail somewhere between v5.6 and v5.7. > > v5.7 fails early with few messages on the console with reboot, v5.8 and > later hang right at bootloader. > > I'm bisecting now. (si

Re: [PATCH 0/4] aarch64: avoid mprotect(PROT_BTI|PROT_EXEC) [BZ #26831]

2020-11-04 Thread Florian Weimer
* Will Deacon: > Is there real value in this seccomp filter if it only looks at mprotect(), > or was it just implemented because it's easy to do and sounds like a good > idea? It seems bogus to me. Everyone will just create alias mappings instead, just like they did for the similar SELinux featu

[PATCH] media: i2c: mt9p031: Remove redundant null check before clk_disable_unprepare

2020-11-04 Thread Xu Wang
Because clk_disable_unprepare() already checked NULL clock parameter, so the additional check is unnecessary, just remove it. Signed-off-by: Xu Wang --- drivers/media/i2c/mt9p031.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i

Re: [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks

2020-11-04 Thread Jürgen Groß
On 04.11.20 10:06, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/net/xen-netfront.c: In function ‘store_rxbuf’: drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] Those two warnings are not fixed by the p

Re: [PATCH] cpufreq: tegra186: Fix get frequency callback

2020-11-04 Thread Viresh Kumar
On 03-11-20, 11:55, Jon Hunter wrote: > Commit b89c01c96051 ("cpufreq: tegra186: Fix initial frequency") > implemented the CPUFREQ 'get' callback to determine the current > operating frequency for each CPU. This implementation used a simple > looked up to determine the current operating frequency.

Re: [PATCH] vhost/vsock: add IOTLB API support

2020-11-04 Thread Stefano Garzarella
On Tue, Nov 03, 2020 at 02:46:13PM -0500, Peter Xu wrote: On Tue, Nov 03, 2020 at 05:04:23PM +0800, Jason Wang wrote: On 2020/11/3 上午1:11, Stefano Garzarella wrote: > On Fri, Oct 30, 2020 at 07:44:43PM +0800, Jason Wang wrote: > > > > On 2020/10/30 下午6:54, Stefano Garzarella wrote: > > > On Fri

Re: [PATCH v2 1/2] sched/wait: Add add_wait_queue_priority()

2020-11-04 Thread David Woodhouse
On Wed, 2020-10-28 at 15:35 +0100, Peter Zijlstra wrote: > On Tue, Oct 27, 2020 at 02:39:43PM +, David Woodhouse wrote: > > From: David Woodhouse > > > > This allows an exclusive wait_queue_entry to be added at the head of the > > queue, instead of the tail as normal. Thus, it gets to consume

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 12:25:22PM +0100, Maxime Ripard wrote: > Hi! > > On Tue, Nov 03, 2020 at 11:55:08AM +0100, Daniel Vetter wrote: > > On Tue, Nov 03, 2020 at 11:38:32AM +0100, Maxime Ripard wrote: > > > On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: > > > > Hi > > > > >

  1   2   3   4   5   6   7   8   9   10   >