Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

2020-10-31 Thread Max Filippov
On Sat, Oct 31, 2020 at 10:16 AM Mike Rapoport wrote: > > On Sat, Oct 31, 2020 at 09:37:09AM -0700, Max Filippov wrote: > > On Sat, Oct 31, 2020 at 2:43 AM Mike Rapoport wrote: > > > Please let me know how do you prefer to take it upstream. > > > If needed this can go via memblock tree. > > > > G

Re: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done

2020-10-31 Thread Christoph Hellwig
On Sat, Oct 31, 2020 at 09:01:45AM -0600, Jens Axboe wrote: > On 10/31/20 9:00 AM, Jens Axboe wrote: > > On 10/31/20 4:41 AM, Sebastian Andrzej Siewior wrote: > >> On 2020-10-29 14:07:59 [-0700], Sagi Grimberg wrote: > in which context? > >>> > >>> Not sure what is the question. > >> > >> The

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 19:45:46 -0700 Hemant Kumar wrote: > +/* .driver_data stores max mtu */ > +static const struct mhi_device_id mhi_uci_match_table[] = { > + { .chan = "LOOPBACK", .driver_data = 0x1000}, > + {}, > +}; > +MODULE_DEVICE_TABLE(mhi, mhi_uci_match_table); I forgot to follow up

[PATCH net-next v7 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-31 Thread Xie He
When the fr_rx function drops a received frame (because the protocol type is not supported, or because the PVC virtual device that corresponds to the DLCI number and the protocol type doesn't exist), the function frees the skb and returns. The code for freeing the skb and returning is repeated sev

[PATCH net-next v7 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-31 Thread Xie He
The main purpose of this series is the last patch. The previous 4 patches are just code clean-ups so that the last patch will not make the code too messy. The patches must be applied in sequence. The receiving code of this driver doesn't support arbitrary Ethertype values. It only recognizes a few

[PATCH net-next v7 2/5] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner

2020-10-31 Thread Xie He
The eth_type_trans function is called when we receive frames carrying Ethernet frames. This function expects a non-NULL pointer as an argument, and assigns it directly to skb->dev. However, the code handling other types of frames first assigns the pointer to "dev", and then at the end checks wheth

[PATCH net-next v7 4/5] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-31 Thread Xie He
1. Change the skb->len check from "<= 4" to "< 4". At first we only need to ensure a 4-byte header is present. We indeed normally need the 5th byte, too, but it'd be more logical and cleaner to check its existence when we actually need it. 2. Add an fh->ea2 check to the initial checks in fr_rx. fh

[PATCH net-next v7 3/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

2020-10-31 Thread Xie He
When an skb is received on a normal (non-Ethernet-emulating) PVC device, call skb_reset_mac_header before we pass it to upper layers. This is because normal PVC devices don't have header_ops, so any header we have would not be visible to upper layer code when sending, so the header shouldn't be vi

[PATCH net-next v7 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-31 Thread Xie He
Change the fr_rx function to make this driver support any Ethertype when receiving skbs on normal (non-Ethernet-emulating) PVC devices. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only recogniz

[PATCH 6/9] ARM: dts: sun8i-v3s: Add the V3s NMI IRQ controller

2020-10-31 Thread Paul Kocialkowski
The V3s/V3 has a NMI interrupt controller, mainly used for the AXP209. Its address follows the sytsem controller block, which was previously incorrectly described as spanning over 0x1000 address bytes. This reduces the system controller address span up to the NMI controller and adds a node for the

[PATCH 5/9] irqchip/sunxi-nmi: Add support for the V3s NMI

2020-10-31 Thread Paul Kocialkowski
The V3s/V3 has a NMI IRQ controller, which is mainly used for the AXP209 interrupt. In great wisdom, Allwinner decided to invert the enable and pending register offsets, compared to the A20. As a result, a specific compatible and register description is required for the V3s. This was tested with a

[PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179 bindings

2020-10-31 Thread Paul Kocialkowski
Document the compatible strings for the SL631 Action Camera with IMX179. Signed-off-by: Paul Kocialkowski --- Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bi

[PATCH 7/9] ARM: dts: sun8i: Cleanup the Pinecube AXP209 node

2020-10-31 Thread Paul Kocialkowski
This fixes a few things with the Pinecube AXP209 node: - No compatible is required since it is using an AXP209 (not AXP203) according to the schematics and this is what the included axp209.dtsi already has; - The interrupt-controller and #interrupt-cells properties are already described in th

[PATCH 9/9] ARM: dts: sun8i-v3: Add support for the SL631 Action Camera with IMX179

2020-10-31 Thread Paul Kocialkowski
The SL631 is a family of Allwinner V3 action cameras sold under various names, such as SJCAM SJ4000 Air or F60 Action Camera. Devices in this family share a common board design but can be found with different image sensors, including the IMX179 and the OV4689. This adds support for a common dtsi

[PATCH 4/9] dt-bindings: irq: sun7i-nmi: Add binding for the V3s NMI

2020-10-31 Thread Paul Kocialkowski
The NMI interrupt controller takes a specific compatible for the V3s. Add it to the device-tree bindings documentation. Signed-off-by: Paul Kocialkowski --- .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicet

[PATCH 1/9] ARM: sunxi: Add machine match for the Allwinner V3 SoC

2020-10-31 Thread Paul Kocialkowski
The Allwinner V3 SoC shares the same base as the V3s but comes with extra pins and features available. As a result, it has its dedicated compatible string (already used in device trees), which is added here. Signed-off-by: Paul Kocialkowski --- arch/arm/mach-sunxi/sunxi.c | 1 + 1 file changed,

[PATCH 3/9] ARM: dts: sun8i-v3s: Add I2C1 PB pins description

2020-10-31 Thread Paul Kocialkowski
I2C1 can be exposed through PB pins in addition to PE pins on the V3s. Add the device-tree description for these pins. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/

[PATCH 0/9] Allwinner V3 SL631 Action Camera Support and Related Fixes

2020-10-31 Thread Paul Kocialkowski
This series adds support for the Allwinner V3-based SL631 family of Action Cameras, starting with the IMX179 fashion. A few fixes to V3 support are added along the way, most notably support for the NMI IRQ controller which is necessary for the AXP209 IRQ. Note that some patches in this series may

[PATCH 2/9] ARM: dts: sun8i-v3: Add UART1 PG pins description

2020-10-31 Thread Paul Kocialkowski
UART1 is often exposed through the PG pins (usually for the debug console) on the V3. They are not available on V3s. Describe these pins in device-tree. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-v3.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/d

Re: [PATCH] s390/smp: Move rcu_cpu_starting() earlier

2020-10-31 Thread Heiko Carstens
On Wed, Oct 28, 2020 at 02:27:42PM -0400, Qian Cai wrote: > The call to rcu_cpu_starting() in smp_init_secondary() is not early > enough in the CPU-hotplug onlining process, which results in lockdep > splats as follows: > > WARNING: suspicious RCU usage > - > kernel/

Re: [PATCH] net: ethernet: ti: cpsw: disable PTPv1 hw timestamping advertisement

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 21:09:10 +0200 Grygorii Strashko wrote: > The TI CPTS does not natively support PTPv1, only PTPv2. But, as it > happens, the CPTS can provide HW timestamp for PTPv1 Sync messages, because > CPTS HW parser looks for PTP messageType id in PTP message octet 0 which > value is 0 for

Re: [PATCH net-next] selftests/net: timestamping: add ptp v2 support

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 21:09:31 +0200 Grygorii Strashko wrote: > The timestamping tool is supporting now only PTPv1 (IEEE-1588 2002) while > modern HW often supports also/only PTPv2. > > Hence timestamping tool is still useful for sanity testing of PTP drivers > HW timestamping capabilities it's reas

Re: [PATCH v4 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature

2020-10-31 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Arpitha-Raghunandan/kunit-Support-for-Parameterized-Testing/20201028-015018 base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev config: x86_64-randconfig-a00

[RFC PATCH] bpf: bpf_get_current_task_btf_proto can be static

2020-10-31 Thread kernel test robot
Signed-off-by: kernel test robot --- bpf_trace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 7b48aa1c695ab8..e4515b0f62a8d3 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -1029,7 +1029,

Re: [PATCH bpf-next 2/5] bpf: Implement get_current_task_btf and RET_PTR_TO_BTF_ID

2020-10-31 Thread kernel test robot
: i386-randconfig-s002-20201031 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-68-g49c98aa3-dirty # https://github.com/0day-ci/linux/commit/238fab90058acf3437ecf912b49b4fc11249fdef git remote add

Re: [PATCH] sfp: Fix error handing in sfp_probe()

2020-10-31 Thread Andrew Lunn
On Sat, Oct 31, 2020 at 11:10:53AM +0800, YueHaibing wrote: > gpiod_to_irq() never return 0, but returns negative in > case of error, check it and set gpio_irq to 0. > > Fixes: 73970055450e ("sfp: add SFP module support") > Signed-off-by: YueHaibing Reviewed-by: Andrew Lunn Andrew

dmaengine: pl330 rare NULL pointer dereference in pl330_tasklet

2020-10-31 Thread Krzysztof Kozlowski
Hi all, I hit quite rare issue with pl330 DMA driver, difficult to reproduce (actually failed to do so): Happened during early reboot [ OK ] Stopped target Graphical Interface. [ OK ] Stopped target Multi-User System. [ OK ] Stopped target RPC Port Mapper. Stopping OpenSSH Daemont

Re: [PATCH] net: atm: fix update of position index in lec_seq_next

2020-10-31 Thread Jakub Kicinski
On Tue, 27 Oct 2020 11:49:25 + Colin King wrote: > From: Colin Ian King > > The position index in leq_seq_next is not updated when the next > entry is fetched an no more entries are available. This causes > seq_file to report the following error: > > "seq_file: buggy .next function lec_seq_n

Re: [PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-31 Thread Willem de Bruijn
On Sat, Oct 31, 2020 at 12:02 PM Xie He wrote: > > On Sat, Oct 31, 2020 at 8:18 AM Xie He wrote: > > > > > Especially without that, I'm not sure this and the follow-on patch add > > > much value. Minor code cleanups complicate backports of fixes. > > > > To me this is necessary, because I feel ha

[PATCH] erofs: derive atime instead of leaving it empty

2020-10-31 Thread Gao Xiang
From: Gao Xiang EROFS has _only one_ ondisk timestamp (ctime is currently documented and recorded, we might also record mtime instead with a new compat feature if needed) for each extended inode since EROFS isn't mainly for archival purposes so no need to keep all timestamps on disk especially fo

Re: [GIT PULL] dma-mapping fix for 5.10

2020-10-31 Thread Linus Torvalds
On Sat, Oct 31, 2020 at 2:40 AM Christoph Hellwig wrote: > > dma-mapping fix for 5.10: > > - fix an integer overflow on 32-bit platforms in the new DMA range code >(Geert Uytterhoeven) So this is just a stylistic nit, and has no impact on this pull (which I've done). But looking at the patch

Re: [GIT PULL] dma-mapping fix for 5.10

2020-10-31 Thread pr-tracker-bot
The pull request you sent on Sat, 31 Oct 2020 10:38:23 +0100: > git://git.infradead.org/users/hch/dma-mapping.git tags/dma-mapping-5.10-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/bb3540be73ca1e483aa977d859960895fe85372d Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v6 08/52] dt-bindings: memory: tegra20: emc: Document mfd-simple compatible and statistics sub-device

2020-10-31 Thread Dmitry Osipenko
28.10.2020 18:26, Rob Herring пишет: > On Tue, Oct 27, 2020 at 11:18:34PM +0300, Dmitry Osipenko wrote: >> 27.10.2020 22:44, Krzysztof Kozlowski пишет: >>> On Tue, Oct 27, 2020 at 10:22:19PM +0300, Dmitry Osipenko wrote: 27.10.2020 12:02, Krzysztof Kozlowski пишет: >> @@ -31,17 +32,34 @@ E

Re: [GIT PULL] SCSI fixes for 5.10-rc1

2020-10-31 Thread pr-tracker-bot
The pull request you sent on Fri, 30 Oct 2020 10:28:38 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/67ff377bc30cd4eb91f0454adb9dcb1f4de280f2 Thank you! -- Deet-doot-dot, I am a bot. ht

[GIT PULL] vhost,vdpa: fixes

2020-10-31 Thread Michael S. Tsirkin
The following changes since commit 88a0d60c6445f315fbcfff3db792021bb3a67b28: MAINTAINERS: add URL for virtio-mem (2020-10-21 10:48:11 -0400) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 0c

Re: [PATCH 4.4 010/149] f2fs: check memory boundary by insane namelen

2020-10-31 Thread Eric Biggers
On Thu, Aug 20, 2020 at 11:21:27AM +0200, Greg Kroah-Hartman wrote: > From: Jaegeuk Kim > > [ Upstream commit 4e240d1bab1ead280ddf5eb05058dba6bbd57d10 ] > > If namelen is corrupted to have very long value, fill_dentries can copy > wrong memory area. > > Reviewed-by: Chao Yu > Signed-off-by: Ja

[PATCH v2 0/3] module: refactor module_sig_check()

2020-10-31 Thread Sergey Shtylyov
Here are 3 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo. I'm doing some refactoring in module_sig_check()... [1/3] module: merge repetitive strings in module_sig_check() [2/3] module: avoid *goto*s in module_sig_check() [3/3] module: only handle errors with the *swit

Re: [PATCH] proc: Provide details on indirect branch speculation

2020-10-31 Thread Andrew Morton
On Fri, 30 Oct 2020 17:27:54 +1100 Anand K Mistry wrote: > Similar to speculation store bypass, show information about the indirect > branch speculation mode of a task in /proc/$pid/status. Why is this considered useful?

[PATCH v2 1/3] module: merge repetitive strings in module_sig_check()

2020-10-31 Thread Sergey Shtylyov
The 'reason' variable in module_sig_check() points to 3 strings across the *switch* statement, all needlessly starting with the same text. Let's put the starting text into the pr_notice() call -- it saves 21 bytes of the object code (x86 gcc 10.2.1). Suggested-by: Joe Perches Signed-off-by: Serge

Re: [PATCH 5.4 00/48] 5.4.74-rc2 review

2020-10-31 Thread Guenter Roeck
On Sat, Oct 31, 2020 at 12:51:00PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.74 release. > There are 48 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know.

Re: [PATCH 5.8 00/70] 5.8.18-rc1 review

2020-10-31 Thread Guenter Roeck
On Sat, Oct 31, 2020 at 12:35:32PM +0100, Greg Kroah-Hartman wrote: > - > Note, this is going to be the LAST 5.8.y kernel release. After this > one, this branch is now end-of-life. Please move to the 5.9.y branch at > this point in time. > - > > Th

Re: [PATCH 5.9 00/74] 5.9.3-rc1 review

2020-10-31 Thread Guenter Roeck
On Sat, Oct 31, 2020 at 12:35:42PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.9.3 release. > There are 74 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know.

[PATCH v2 2/3] module: avoid *goto*s in module_sig_check()

2020-10-31 Thread Sergey Shtylyov
Let's move the common handling of the non-fatal errors after the *switch* statement -- this avoids *goto*s inside that *switch*... Suggested-by: Joe Perches Signed-off-by: Sergey Shtylyov --- Changes in version 2: - new patch. kernel/module.c | 20 ++-- 1 file changed, 10 in

[PATCH v2 3/3] module: only handle errors with the *switch* statement in module_sig_check()

2020-10-31 Thread Sergey Shtylyov
Let's handle the successful call of mod_verify_sig() right after that call, making the *switch* statement only handle the real errors, and then move the comment from the first *case* before *switch* itself and the comment before *default* after it. Fix the comment style, add article/comma/dash, sp

Re: [PATCH v6 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-10-31 Thread Lubomir Rintel
Hello Sam, thanks for your response. On Sat, Oct 31, 2020 at 09:01:37AM +0100, Sam Ravnborg wrote: > Hi Lubomir. > > On Fri, Oct 30, 2020 at 04:08:00AM +0100, Lubomir Rintel wrote: > > Himax HX8837 is used to drive the LCD panel on OLPC platforms. > > > > It controls the panel backlight and is

Re: [PATCH v3 6/9] perf c2c: Support AUX trace

2020-10-31 Thread Jiri Olsa
On Wed, Oct 28, 2020 at 02:38:10PM +0800, Leo Yan wrote: > This patches adds the AUX callbacks in session structure, so support > AUX trace for "perf c2c" tool. > > Signed-off-by: Leo Yan > --- > tools/perf/builtin-c2c.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/bu

Re: [PATCH v3 3/9] perf mem: Support new memory event PERF_MEM_EVENTS__LOAD_STORE

2020-10-31 Thread Jiri Olsa
On Wed, Oct 28, 2020 at 02:38:07PM +0800, Leo Yan wrote: SNIP > struct stat st; > > + /* > + * If the event entry isn't valid, skip initialization > + * and "e->supported" will keep false. > + */ > + if (!e->tag) > +

Re: [PATCH net-next] net: ipa: avoid a bogus warning

2020-10-31 Thread Jakub Kicinski
On Sat, 31 Oct 2020 10:15:24 -0500 Alex Elder wrote: > The previous commit added support for IPA having up to six source > and destination resources. But currently nothing uses more than > four. (Five of each are used in a newer version of the hardware.) > > I find that in one of my build enviro

Re: [PATCH] perf: increase size of buf in perf_evsel__hists_browse()

2020-10-31 Thread Jiri Olsa
On Fri, Oct 30, 2020 at 04:54:31PM -0700, Song Liu wrote: > Making perf with gcc-9.1.1 generates the following warning: > > CC ui/browsers/hists.o > ui/browsers/hists.c: In function 'perf_evsel__hists_browse': > ui/browsers/hists.c:3078:61: error: '%d' directive output may be \ > truncated

Re: [PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-31 Thread Jakub Kicinski
On Sat, 31 Oct 2020 15:47:28 -0400 Willem de Bruijn wrote: > On Sat, Oct 31, 2020 at 12:02 PM Xie He wrote: > > On Sat, Oct 31, 2020 at 8:18 AM Xie He wrote: > > > > Especially without that, I'm not sure this and the follow-on patch add > > > > much value. Minor code cleanups complicate backpor

Re: [PATCH net-next] net: ipa: avoid a bogus warning

2020-10-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 31 Oct 2020 10:15:24 -0500 you wrote: > The previous commit added support for IPA having up to six source > and destination resources. But currently nothing uses more than > four. (Five of each are used in a newer

Re: INFO: rcu detected stall in sys_mount (5)

2020-10-31 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 Author: David Howells Date: Fri Oct 16 12:21:14 2020 + afs: Fix cell removal bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=132fe91450 start commit: 02de58b2 Merge tag '

Re: [PATCH v2] ubifs: Fix the printing type of c->big_lpt

2020-10-31 Thread Richard Weinberger
On Sat, Oct 31, 2020 at 9:56 AM Chengsong Ke wrote: > > Ubifs uses %d to print c->big_lpt, but c->big_lpt is a variable > of type unsigned int and should be printed with %u. Well, it is: unsigned int big_lpt:1; So, either 0 or 1. Does changing it to %u silence some static checker or is there som

Re: [PATCH v6 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-10-31 Thread Sam Ravnborg
Hi Lubomir. > > > > > + select BACKLIGHT_CLASS_DEVICE > > Please use a depends - using select on a symbol with a prompt is always > > wrong. Yeah, I know you then need to enable backlight to see this > > driver. Sorry, but this is the best we can do now. > > Many other drivers can cope with depen

[PATCH] ARM: dts: imx50-kobo-aura: Add 'grp' suffix to pinctrl node names

2020-10-31 Thread Jonathan Neuschäfer
i.MX pinctrl group nodes should have names that ends with 'grp'. Reported-by: Krzysztof Kozlowski Signed-off-by: Jonathan Neuschäfer --- arch/arm/boot/dts/imx50-kobo-aura.dts | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm/boot/dts/imx50-k

Re: [PATCH] checkpatch: improve handling of email comments

2020-10-31 Thread Dwaipayan Ray
Try this git log grep: $ git log --format=email -10 | \ grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \ grep -v 'stable\@' | \ grep -P '\>.+' This finds any signature/cc line with content after an email address that end with a close angle bracket that doesn't go to the stable address.

Re: [PATCH v2] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 18:52:56 +0530 Anant Thazhemadam wrote: > + return usb_control_msg_recv(dev->udev, 0, > + cmd, reqtype, value, index, data, size, > + USB_CTRL_GET_TIMEOUT, GFP_KERNEL); Please align continuation lines after the opening bra

Re: [linux-sunxi] [PATCH v2] arm64: dts: allwinner: h6: PineH64 model B: Add wifi

2020-10-31 Thread Corentin Labbe
On Fri, Oct 30, 2020 at 06:25:30PM +0100, Jernej Skrabec wrote: > PineH64 model B contains RTL8723CS wifi+bt combo module. > > Since bluetooth support is not yet squared away, only wifi is enabled > for now. > > Acked-by: Chen-Yu Tsai > Signed-off-by: Jernej Skrabec > --- > Changes from v1: > -

Re: [PATCH RFC 0/5] ubifs: Prevent memory oob accessing while dumping node

2020-10-31 Thread Richard Weinberger
On Mon, Oct 19, 2020 at 5:13 AM Zhihao Cheng wrote: > > 在 2020/6/16 15:11, Zhihao Cheng 写道: > > We use function ubifs_dump_node() to dump bad node caused by some > > reasons (Such as bit flipping caused by hardware error, writing bypass > > ubifs or unknown bugs in ubifs). The node content can not

[PATCH] thermal: armada: hwmon support for new DT binding.

2020-10-31 Thread Jonathan Ben-Avraham
For legacy DT binding the armada driver calls thermal_zone_device_register(), which registers the hwmon device. For new DT bindings, devm_thermal_add_hwmon_sysfs() must be called explicitly. Fixes: c9899c183921f (thermal: armada: use the resource managed registration helper alternative) Signed-of

Re: [GIT PULL] perf tools changes for v5.10: 2nd batch

2020-10-31 Thread Linus Torvalds
On Fri, Oct 30, 2020 at 11:59 AM Arnaldo Carvalho de Melo wrote: > > Please consider pulling, Malformed pull request, and this doesn't even seem to be fixes. Linus

Re: [PATCH v2] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

2020-10-31 Thread Anant Thazhemadam
On 01/11/20 2:41 am, Jakub Kicinski wrote: > On Thu, 29 Oct 2020 18:52:56 +0530 Anant Thazhemadam wrote: >> +return usb_control_msg_recv(dev->udev, 0, >> + cmd, reqtype, value, index, data, size, >> + USB_CTRL_GET_TIMEOUT, GFP_KERNEL); > Pleas

[PATCH] media: dvbdev: Switch to new kerneldoc syntax for named variable macro argument

2020-10-31 Thread Jonathan Neuschäfer
The syntax without dots is available since commit 43756e347f21 ("scripts/kernel-doc: Add support for named variable macro arguments"). The same HTML output is produced with and without this patch. Signed-off-by: Jonathan Neuschäfer --- include/media/dvbdev.h | 2 +- 1 file changed, 1 insertion(

Re: [patch V2 00/18] mm/highmem: Preemptible variant of kmap_atomic & friends

2020-10-31 Thread Arnd Bergmann
On Sat, Oct 31, 2020 at 4:04 PM Christophe Leroy wrote: > > There are also some users on 10+ year old 32-bit netbooks or > > business laptops, both x86 and Apple G4. > > The longest-lived 32-bit embedded systems with large memory > > (other than Arm) are probably NXP QorIQ P20xx/P40xx used in > >

Re: [GIT PULL] flexible array conversions for 5.10-rc2

2020-10-31 Thread Linus Torvalds
On Fri, Oct 30, 2020 at 4:14 PM Gustavo A. R. Silva wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git > tags/flexible-array-conversions-5.10-rc2 So I really don't like getting these outside the merge window. These kinds of patches _can_ introduce bugs, and I see noi

[PATCH v3] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

2020-10-31 Thread Anant Thazhemadam
Currently, __usbnet_{read|write}_cmd() use usb_control_msg(). However, this could lead to potential partial reads/writes being considered valid, and since most of the callers of usbnet_{read|write}_cmd() don't take partial reads/writes into account (only checking for negative error number is done),

Re: [PATCH v8 -tip 08/26] sched/fair: Snapshot the min_vruntime of CPUs on force idle

2020-10-31 Thread Joel Fernandes
On Fri, Oct 30, 2020 at 09:41:12AM +0100, Peter Zijlstra wrote: > On Thu, Oct 29, 2020 at 10:42:29PM -0400, Joel Fernandes wrote: > > > Forgot to ask, do you also need to do the task_vruntime_update() for > > the unconstrained pick? > > Humm.. interesting case. > > Yes, however... since in that

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-31 Thread Arnd Bergmann
On Sat, Oct 31, 2020 at 5:53 PM Jakub Kicinski wrote: > > On Fri, 30 Oct 2020 22:10:42 -0700 Xie He wrote: > > > The usual way of getting rid of old code is to move it to staging/ > > > for a few releases then delete it, like Arnd just did with wimax. > > > > Oh. OK. But I see "include/linux/if_fr

Re: [PATCH] MIPS: Kconfig: fix a few trivial spelling mistakes

2020-10-31 Thread Philippe Mathieu-Daudé
On Wed, Oct 28, 2020 at 9:01 PM Colin King wrote: > > From: Colin Ian King > > There are a few spelling mistakes in the Kconfig, fix these. > > Signed-off-by: Colin Ian King > --- > arch/mips/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Da

Re: [PATCH 0/3] mtd: Make sure UBIFS does not do multi-pass page programming on flashes that don't support it

2020-10-31 Thread Richard Weinberger
On Tue, Oct 27, 2020 at 12:24 PM Pratyush Yadav wrote: > > [0] https://lore.kernel.org/linux-mtd/20201005153138.6437-1-p.ya...@ti.com/ > > Ping. Any comments on the series? >From the UBIFS point of view I'd like to avoid as many device specific settings as possible. We check already for NOR flash

Re: [GIT PULL] vhost,vdpa: fixes

2020-10-31 Thread pr-tracker-bot
The pull request you sent on Sat, 31 Oct 2020 15:59:40 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c2dc4c073fb71b50904493657a7622b481b346e3 Thank you! -- Deet-doot-dot, I am a b

Re: [GIT PULL] flexible array conversions for 5.10-rc2

2020-10-31 Thread pr-tracker-bot
The pull request you sent on Fri, 30 Oct 2020 17:13:42 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git > tags/flexible-array-conversions-5.10-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/53760f9b74a3412c1b67a20b0e8dbf7c3cebfc45 Thank

Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-10-31 Thread Thomas Gleixner
Frank, On Sat, Oct 31 2020 at 15:03, Frank Wunderlich wrote: > From: Frank Wunderlich > > 5.10 shows these warnings on bootup while enabling pcie > at least on bananapi-r2: > > [6.161730] WARNING: CPU: 2 PID: 73 at include/linux/msi.h:213 > pci_msi_setup_ > msi_irqs.constprop.0+0x78/0x80 > .

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-31 Thread Jakub Kicinski
On Sat, 31 Oct 2020 22:41:30 +0100 Arnd Bergmann wrote: > On Sat, Oct 31, 2020 at 5:53 PM Jakub Kicinski wrote: > > > > On Fri, 30 Oct 2020 22:10:42 -0700 Xie He wrote: > > > > The usual way of getting rid of old code is to move it to staging/ > > > > for a few releases then delete it, like Arnd

Re: [PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-31 Thread Xie He
On Sat, Oct 31, 2020 at 12:48 PM Willem de Bruijn wrote: > > Returning code in branches vs an error jump label seems more of a > personal preference, and to me does not pass the benefit/cost threshold. This patch is necessary for the 2nd and 5th patch in this series, because the 2nd and 5th patch

Re: [PATCH net-next] net: add in_softirq() debug checking in napi_consume_skb()

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 19:34:48 +0800 Yunsheng Lin wrote: > The current semantic for napi_consume_skb() is that caller need > to provide non-zero budget when calling from NAPI context, and > breaking this semantic will cause hard to debug problem, because > _kfree_skb_defer() need to run in atomic con

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

2020-10-31 Thread Coiby Xu
On Sat, Oct 31, 2020 at 11:05:11AM +, Jonathan Cameron wrote: On Fri, 30 Oct 2020 22:34:10 +0800 Coiby Xu wrote: On Thu, Oct 29, 2020 at 07:06:40PM +0200, Andy Shevchenko wrote: >On Thu, Oct 29, 2020 at 4:42 PM Jonathan Cameron wrote: >> On Thu, 29 Oct 2020 15:48:56 +0800 >> Coiby Xu wro

Re: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-10-31 Thread Jakub Kicinski
On Fri, 30 Oct 2020 11:23:08 +0800 Hayes Wang wrote: > Support ECM mode based on cdc_ether with relative mii functions, > when CONFIG_USB_RTL8152 is not set, or the device is not supported > by r8152 driver. > > Signed-off-by: Hayes Wang Can you describe the use case in more detail? AFAICT r815

Re: [RESEND PATCH v5] net: macb: add support for high speed interface

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 13:47:07 +0100 Parshuram Thombare wrote: > This patch adds support for 10GBASE-R interface to the linux driver for > Cadence's ethernet controller. > This controller has separate MAC's and PCS'es for low and high speed paths. > High speed PCS supports 100M, 1G, 2.5G, 5G and 10G

Re: [PATCH v2] x86: Fix x32 System V message queue syscalls

2020-10-31 Thread Andy Lutomirski
cc: some libc folks On Mon, Oct 12, 2020 at 6:45 AM Jessica Clarke wrote: > > POSIX specifies that the first field of the supplied msgp, namely mtype, > is a long, not a __kernel_long_t, and it's a user-defined struct due to > the variable-length mtext field so we can't even bend the spec and mak

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-31 Thread Xie He
On Sat, Oct 31, 2020 at 2:41 PM Arnd Bergmann wrote: > > I think it can just go in the bin directly. I actually submitted a couple of > patches to clean up drivers/net/wan last year but didn't follow up > with a new version after we decided that x.25 is still needed, see > https://lore.kernel.org/

Re: [PATCH] s390/smp: Move rcu_cpu_starting() earlier

2020-10-31 Thread Qian Cai
On Sat, 2020-10-31 at 19:37 +0100, Heiko Carstens wrote: > On Wed, Oct 28, 2020 at 02:27:42PM -0400, Qian Cai wrote: > > The call to rcu_cpu_starting() in smp_init_secondary() is not early > > enough in the CPU-hotplug onlining process, which results in lockdep > > splats as follows: > > > > WARN

Re: [PATCH v2 0/4] perf: Fix perf_event_attr::exclusive rotation

2020-10-31 Thread Jiri Olsa
On Thu, Oct 29, 2020 at 05:27:19PM +0100, Peter Zijlstra wrote: > Hi, > > Andi recently added exclusive event group support to tools/perf: > > https://lkml.kernel.org/r/20201014144255.22699-1-a...@firstfloor.org > > and promptly found that they didn't work as specified. > > (sorry for the res

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-31 Thread Raj, Ashok
Hi Thomas, On Sat, Oct 31, 2020 at 03:50:43AM +0100, Thomas Gleixner wrote: > Ashok, > > < skip a lot of non-sensical arguments> Ouch!.. Didn't mean to awaken you like this :-).. apologies.. profusely! > > Just because there is historical precendence which does not care about > the differenti

arch/powerpc/lib/sstep.c:1172:21: error: variable 'suffix' set but not used

2020-10-31 Thread kernel test robot
Hi Jordan, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c2dc4c073fb71b50904493657a7622b481b346e3 commit: 650b55b707fdfa764e9f2b81314d3eb4216fb962 powerpc: Add prefixed instructions to instruction data type date:

[PATCH net-next] net: bridge: mcast: fix stub definition of br_multicast_querier_exists

2020-10-31 Thread Vladimir Oltean
The commit cited below has changed only the functional prototype of br_multicast_querier_exists, but forgot to do that for the stub prototype (the one where CONFIG_BRIDGE_IGMP_SNOOPING is disabled). Fixes: 955062b03fa6 ("net: bridge: mcast: add support for raw L2 multicast groups") Reported-by: k

Re: [PATCH v2] x86: Fix x32 System V message queue syscalls

2020-10-31 Thread Jessica Clarke
On 31 Oct 2020, at 23:30, Andy Lutomirski wrote: > > cc: some libc folks > > On Mon, Oct 12, 2020 at 6:45 AM Jessica Clarke wrote: >> >> POSIX specifies that the first field of the supplied msgp, namely mtype, >> is a long, not a __kernel_long_t, and it's a user-defined struct due to >> the va

Re: possible deadlock in do_fcntl

2020-10-31 Thread syzbot
syzbot has bisected this issue to: commit e918188611f073063415f40fae568fa4d86d9044 Author: Boqun Feng Date: Fri Aug 7 07:42:20 2020 + locking: More accurate annotations for read_lock() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1292881a50 start commit: 4e78c578

[PATCH] staging: fbtft: fb_watterott: fix usleep_range is preferred over udelay

2020-10-31 Thread Hassan Shahbazi
Fix the checkpath.pl issue on fb_watterott.c. write_vmem and write_vmem_8bit functions are within non-atomic context and can safely use usleep_range. see Documentation/timers/timers-howto.txt Signed-off-by: Hassan Shahbazi --- drivers/staging/fbtft/fb_watterott.c | 4 ++-- 1 file changed, 2 inse

Re: [PATCH net-next] net: bridge: mcast: fix stub definition of br_multicast_querier_exists

2020-10-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 1 Nov 2020 02:08:45 +0200 you wrote: > The commit cited below has changed only the functional prototype of > br_multicast_querier_exists, but forgot to do that for the stub > prototype (the one where CONFIG_BRIDGE_

[PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator

2020-10-31 Thread Pablo Greco
DCDC1 regulator powers many different subsystems. While some of them can work at 3.0 V, some of them can not. For example, VCC-HDMI can only work between 3.24 V and 3.36 V. According to OS images provided by the board manufacturer this regulator should be set to 3.3 V. Set DCDC1 and DCDC1SW to 3.3

[PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY

2020-10-31 Thread Pablo Greco
The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. Fix the phy-mode description to correct reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy

[PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node

2020-10-31 Thread Pablo Greco
Ethernet PHY on BananaPi M2 Berry provides RX and TX delays. Fix ethernet node to reflect that fact. Fixes: 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller") Signed-off-by: Pablo Greco --- arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 2 +- 1 file c

[PATCH 2/2] extcon: fsa9480: Support TI TSU6111 variant

2020-10-31 Thread Linus Walleij
The Texas Instruments TSU6111 is compatible to the FSA880/FSA9480. Signed-off-by: Linus Walleij --- drivers/extcon/extcon-fsa9480.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c index 8405512f5199..08bdedbcdb0d 100644 --- a/

[PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend

2020-10-31 Thread Linus Walleij
This rewrites the FSA9480 DT bindings using YAML and extends them with the compatible TI TSU6111. I chose to name the file fcs,fsa880 since this is the first switch, later versions are improvements. Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- .../bindings/extcon/extcon-fsa94

Re: [PATCH 2/5] arm64: defconfig: Enable ASRC and EASRC

2020-10-31 Thread Shawn Guo
On Mon, Oct 19, 2020 at 12:45:25PM -0500, Adam Ford wrote: > The i.MX8M Nano supports the EASRC driver, and it requires ASRC. > Enable both of them as modules. > > Signed-off-by: Adam Ford Applied, thanks.

Re: [PATCH v2] x86: Fix x32 System V message queue syscalls

2020-10-31 Thread Rich Felker
On Sat, Oct 31, 2020 at 04:30:44PM -0700, Andy Lutomirski wrote: > cc: some libc folks > > On Mon, Oct 12, 2020 at 6:45 AM Jessica Clarke wrote: > > > > POSIX specifies that the first field of the supplied msgp, namely mtype, > > is a long, not a __kernel_long_t, and it's a user-defined struct du

Re: [PATCH v2] x86: Fix x32 System V message queue syscalls

2020-10-31 Thread Jessica Clarke
On 1 Nov 2020, at 01:22, Rich Felker wrote: > On Sat, Oct 31, 2020 at 04:30:44PM -0700, Andy Lutomirski wrote: >> cc: some libc folks >> >> On Mon, Oct 12, 2020 at 6:45 AM Jessica Clarke wrote: >>> >>> POSIX specifies that the first field of the supplied msgp, namely mtype, >>> is a long, not a

Re: [BUG] Error applying setting, reverse things back on lot of devices

2020-10-31 Thread Ondřej Jirman
Hello Michał, On Sat, Oct 24, 2020 at 01:53:07PM +0200, Michał Mirosław wrote: > On Fri, Oct 23, 2020 at 10:39:43PM +0200, Corentin Labbe wrote: > > On Fri, Oct 23, 2020 at 03:42:01PM +0200, Corentin Labbe wrote: > > > On Wed, Oct 21, 2020 at 08:31:49PM +0200, Corentin Labbe wrote: > > > > [5.

Re: KASAN: use-after-free Read in do_set_interface

2020-10-31 Thread Alan Stern
On Wed, Oct 28, 2020 at 04:51:09PM -0400, Kyungtae Kim wrote: > We report a bug (in linux-5.8.13) found by FuzzUSB (a modified version > of syzkaller). > > The bug happened when accessing a freed instance of struct fsg_dev > (i.e., fsg->bulk_in) in do_set_interface() (line 2245). > >

<    1   2   3   4   5   6   >