Re: [PATCH 4/4] bus: ti-sysc: Fix bogus resetdone warning for cpsw

* Grygorii Strashko [201030 18:15]: > Hi Tony, > > On 26/10/2020 12:58, Tony Lindgren wrote: > > The cpsw SOFT_RESET register is cleard when out of reset so let's > > add SYSS_QUIRK_RESETDONE_INVERTED flag for cpsw. Otherwise we will > > get bogus "OCP softreset timed out" warnings on boot. > >

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

Hi YueHaibing Thanks for the fix. Appreciated but please update as per comments below. On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote: > gpiod_to_irq() return negative value in case of error, > the existing code handle negative error codes wrongly. > > Fixes: cff5e6f7e83f ("drm/bridg

[PATCH 1/2] console: Remove dummy con_font_op() callback implementations

`struct console_font` is a UAPI structure, thus ideally should not be used for kernel internal abstraction. Remove some dummy .con_font_set, .con_font_default and .con_font_copy `struct consw` callback implementations, to make it cleaner. Patch "fbcon: Prevent global-out-of-bounds read in fbcon_co

[PATCH 2/2] fbcon: Prevent global-out-of-bounds read in fbcon_copy_font()

fbcon_copy_font() is using a signed int, `con`, as an index into `fb_display[MAX_NR_CONSOLES]`, without bounds checking. In con_font_copy(), `con` is being silently casted from the unsigned `op->height`. Let con_font_copy() and fbcon_copy_font() pass `op->height` directly, and add a range check in

Greetings,

Greetings, I am Mrs Ruby Tan an aging widow suffering from long time illness.I have some funds I inherited from my late husband, I needed a very honest and sincere Individual or cooperate organization that will use the fund for humanitarian and charities works, I found your email address from the

[PATCH v13 7/8] arm64: kdump: add memory for devices by DT property linux,usable-memory-range

When reserving crashkernel in high memory, some low memory is reserved for crash dump kernel devices and never mapped by the first kernel. This memory range is advertised to crash dump kernel via DT property under /chosen, linux,usable-memory-range = We reused the DT property linux,usable

[PATCH v13 3/8] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel()

To make the functions reserve_crashkernel() as generic, replace some hard-coded numbers with macro CRASH_ADDR_LOW_MAX. Signed-off-by: Chen Zhou Tested-by: John Donnelly --- arch/x86/kernel/setup.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/setup.c

[PATCH v13 5/8] arm64: kdump: introduce some macroes for crash kernel reservation

Introduce macro CRASH_ALIGN for alignment, macro CRASH_ADDR_LOW_MAX for upper bound of low crash memory, macro CRASH_ADDR_HIGH_MAX for upper bound of high crash memory, use macroes instead. Besides, keep consistent with x86, use CRASH_ALIGN as the lower bound of crash kernel reservation. Signed-o

[PATCH v13 6/8] arm64: kdump: reimplement crashkernel=X

There are following issues in arm64 kdump: 1. We use crashkernel=X to reserve crashkernel below 4G, which will fail when there is no enough low memory. 2. If reserving crashkernel above 4G, in this case, crash dump kernel will boot failure because there is no low memory available for allocation. 3.

[PATCH v13 2/8] x86: kdump: make the lower bound of crash kernel reservation consistent

The lower bounds of crash kernel reservation and crash kernel low reservation are different, use the consistent value CRASH_ALIGN. Suggested-by: Dave Young Signed-off-by: Chen Zhou Tested-by: John Donnelly --- arch/x86/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v13 1/8] x86: kdump: replace the hard-coded alignment with macro CRASH_ALIGN

Move CRASH_ALIGN to header asm/kexec.h and replace the hard-coded alignment with macro CRASH_ALIGN in function reserve_crashkernel(). Suggested-by: Dave Young Signed-off-by: Chen Zhou Tested-by: John Donnelly --- arch/x86/include/asm/kexec.h | 3 +++ arch/x86/kernel/setup.c | 5 + 2 f

[PATCH v13 0/8] support reserving crashkernel above 4G on arm64 kdump

There are following issues in arm64 kdump: 1. We use crashkernel=X to reserve crashkernel below 4G, which will fail when there is no enough low memory. 2. If reserving crashkernel above 4G, in this case, crash dump kernel will boot failure because there is no low memory available for allocation. 3.

[PATCH v13 8/8] kdump: update Documentation about crashkernel

For arm64, the behavior of crashkernel=X has been changed, which tries low allocation in DMA zone or DMA32 zone if CONFIG_ZONE_DMA is disabled, and fall back to high allocation if it fails. We can also use "crashkernel=X,high" to select a high region above DMA zone, which also tries to allocate at

[PATCH v13 4/8] x86: kdump: move reserve_crashkernel[_low]() into crash_core.c

Make the functions reserve_crashkernel[_low]() as generic. Arm64 will use these to reimplement crashkernel=X. Signed-off-by: Chen Zhou Tested-by: John Donnelly --- arch/x86/include/asm/kexec.h | 25 ++ arch/x86/kernel/setup.c | 151 +--- include/linux/crash

Re: [PATCH] stop_machine: Mark functions as notrace

On Sat, Oct 31, 2020 at 8:28 AM Steven Rostedt wrote: > > On Fri, 30 Oct 2020 14:47:56 -0700 > Atish Patra wrote: > > > > Look at arm64, they __kprobes flag and I guess it would also prevent > > > ftrace call site. > > > > > > > Are you sure about that ? __kprobes puts the code in .kprobes.text s

Re: [PATCH] ARM: dts: imx: add usb alias

On Wed, Oct 14, 2020 at 09:27:41AM +0800, peng@nxp.com wrote: > From: Peng Fan > > Add usb alias for bootloader emulator the controller in correct order. emulator? Not sure what that means. Shawn > > Signed-off-by: Peng Fan > --- > arch/arm/boot/dts/imx6qdl.dtsi | 4 > arch/arm/bo

[PATCH] ubifs: Fix the printing type of c->big_lpt

Ubifs uses %d to print c->big_lpt, but c->big_lpt is a variable of type unsigned int and should be printed with %u. Reviewed-by: Fangpeng Wang Signed-off-by: Chengsong Ke --- fs/ubifs/debug.c | 2 +- fs/ubifs/lpt.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ub

Urgent Responses

God will bless you as you fulfilled my wish Good day My name is Mrs. Margret Nelson. I am a dying woman who has decided to donate what I have to the Charities. I am 85 years old and was diagnosed with cancer about four years ago, immediately after the death of my husband; I have been touche

Re: [PATCH v6 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

Hi Lubomir. On Fri, Oct 30, 2020 at 04:08:00AM +0100, Lubomir Rintel wrote: > Himax HX8837 is used to drive the LCD panel on OLPC platforms. > > It controls the panel backlight and is able to refresh it when the LCD > controller (and the rest of the plaform) is powered off. > > It also converts

[PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function

It has been observed that resetting force in the detect function can result in the PHY being powered down in response to hot-plug detect being asserted, even when the HDMI connector is forced on. Enabling debug messages and adding a call to dump_stack() in dw_hdmi_phy_power_off() shows the followi

[PATCH] xfs: fix the comment of function xfs_buf_free_maps

Fix the inappropriate comment to help people to understad the code Signed-off-by: Fengfei Xi --- fs/xfs/xfs_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 4e4cf91..f8bf00b 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@

Re: [PATCH v1] ARM: dts: imx6/7: sync fsl,stop-mode with current flexcan driver

On Fri, Oct 16, 2020 at 09:51:58AM +0200, Oleksij Rempel wrote: > After this patch we need 2 arguments less for the fsl,stop-mode > property: > > | commit d9b081e3fc4bdc33e672dcb7bb256394909432fc > | Author: Marc Kleine-Budde > | Date: Sun Jun 14 21:09:20 2020 +0200 > | > | can: flexcan: remove

Re: For review: seccomp_user_notif(2) manual page [v2]

On 10/30/20 8:14 PM, Jann Horn wrote: > On Thu, Oct 29, 2020 at 3:19 PM Michael Kerrisk (man-pages) > wrote: >> On 10/29/20 2:42 AM, Jann Horn wrote: >>> On Mon, Oct 26, 2020 at 10:55 AM Michael Kerrisk (man-pages) >>> wrote: static bool getTargetPathname(struct seccomp_no

Re: [PATCH] xfs: fix the comment of function xfs_buf_free_maps

On Sat, Oct 31, 2020 at 03:55:15PM +0800, Fengfei Xi wrote: > Fix the inappropriate comment to help people to understad the code > > Signed-off-by: Fengfei Xi I think we can just drop the comment entirely as it isn't very useful to start with.

Re: [PATCH v2 3/5] scsi: qla2xxx: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs

Hi Luo, Thank you for the patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on scsi/for-next linus/master v5.10-rc1 next-20201030] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

On Fri, Oct 30, 2020 at 05:41:22PM +0100, Pali Rohár wrote: > I would like to open discussion about two ntfs kernel drivers. Do we > really need two drivers (one read only - current version and one > read/write - this new version)? > > What other people think? > > I remember that Christoph (added

Re: [PATCH 02/18] block: open code kobj_map into in block/genhd.c

On Fri, Oct 30, 2020 at 11:40:33AM +0100, Greg Kroah-Hartman wrote: > On Thu, Oct 29, 2020 at 08:32:42PM +0100, Christoph Hellwig wrote: > > On Thu, Oct 29, 2020 at 08:22:36PM +0100, Greg Kroah-Hartman wrote: > > > After this, you want me to get rid of kobj_map, right? Or you don't > > > care as b

[PATCH v2] ubifs: Fix the printing type of c->big_lpt

Ubifs uses %d to print c->big_lpt, but c->big_lpt is a variable of type unsigned int and should be printed with %u. Signed-off-by: Chengsong Ke --- fs/ubifs/debug.c | 2 +- fs/ubifs/lpt.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug

Re: For review: seccomp_user_notif(2) manual page [v2]

On 10/30/20 8:20 PM, Jann Horn wrote: > On Thu, Oct 29, 2020 at 8:14 PM Michael Kerrisk (man-pages) > wrote: >> On 10/29/20 2:42 AM, Jann Horn wrote: >>> As discussed at >>> , >>> we need to re-check c

[PATCH] tracing: Fix the checking of stackidx in __ftrace_trace_stack

The array size is FTRACE_KSTACK_NESTING, so the index FTRACE_KSTACK_NESTING is illegal too. And fix two typos by the way. Signed-off-by: Qiujun Huang --- kernel/trace/trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index

Re: [PATCH V2 1/3] arm64: dts: imx8mm: Add support for micfil

On Mon, Oct 19, 2020 at 11:50:36AM -0500, Adam Ford wrote: > The i.MX8M Mini has supports the MICFIL digital interface. > It's a 16-bit audio signal from a PDM microphone bitstream. > The driver is already in the kernel, but the node is missing. > > This patch adds the micfil node. > > Signed-off

[PATCH 6/8] crypto: hisilicon/qm - split 'qm_qp_ctx_cfg' into smaller pieces

'qm_qp_ctx_cfg' initializes configuration of SQ and CQ, split it into two pieces to improve code readability. Signed-off-by: Weili Qian Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/qm.c | 36 1 file changed, 28 insertions(+), 8 deletions(-) diff --gi

Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

On Fri, Oct 30, 2020 at 06:16:31PM -0700, Jakub Kicinski wrote: > On Thu, 29 Oct 2020 04:27:37 +0200 Vladimir Oltean wrote: > > + mc = devm_kzalloc(ocelot->dev, sizeof(*mc), GFP_KERNEL); > > + if (!mc) > > + return -ENOMEM; > > + > > + mc->entry_type

[PATCH 5/8] crypto: hisilicon/qm - replace 'sprintf' with 'scnprintf'

Replace 'sprintf' with 'scnprintf' to avoid overrun. Signed-off-by: Weili Qian Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/qm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 17f84db..25c5414 1006

[PATCH 0/8] crypto: hisilicon/qm - misc clean up

This patchset makes some clean up, please see comments in each patch. Weili Qian (8): crypto: hisilicon/qm - numbers are replaced by macros crypto: hisilicon/qm - modify the return type of function crypto: hisilicon/qm - modify the return type of debugfs interface crypto: hisilicon/qm - mo

[PATCH 8/8] crypto: hisilicon/qm - split 'hisi_qm_init' into smaller pieces

'hisi_qm_init' initializes configuration of QM. To improve code readability, split it into two pieces. Signed-off-by: Weili Qian Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/qm.c | 86 ++- 1 file changed, 53 insertions(+), 33 deletions(-) diff --g

[PATCH 3/8] crypto: hisilicon/qm - modify the return type of debugfs interface

Since 'qm_create_debugfs_file' always returns 0, change it as 'void'. Signed-off-by: Weili Qian Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 4 +--- drivers/crypto/hisilicon/qm.c | 19 --- drivers/crypto/hisilicon/qm.h | 2 +-

[PATCH 2/8] crypto: hisilicon/qm - modify the return type of function

The returns of 'qm_get_hw_error_status' and 'qm_get_dev_err_status' are values from the hardware registers, which should not be defined as 'int', so update as 'u32'. Signed-off-by: Weili Qian Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/qm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

Re: [PATCH] pwm: tiehrpwm: handle deferred probe with dev_err_probe()

On 10/31/20 1:42 AM, Grygorii Strashko wrote: > The devm_clk_get() may return -EPROBE_DEFER which is not handled properly > by TI EHRPWM driver and causes unnecessary boot log messages. > > Hence, add proper deferred probe handling with new dev_err_probe() API. > > Signed-off-by: Grygorii Stra

[PATCH 4/8] crypto: hisilicon/qm - modify return type of 'qm_set_sqctype'

Since 'qm_set_sqctype' always returns 0, change it as 'void'. Signed-off-by: Weili Qian Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/qm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 627479f..17

[PATCH 1/8] crypto: hisilicon/qm - numbers are replaced by macros

Some numbers are replaced by macros to avoid incomprehension. Signed-off-by: Weili Qian Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/qm.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c

[PATCH 7/8] crypto: hisilicon/qm - split 'qm_eq_ctx_cfg' into smaller pieces

'qm_eq_ctx_cfg' initializes configuration of EQ and AEQ, split it into two pieces to improve code readability. Signed-off-by: Weili Qian Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/qm.c | 44 +++ 1 file changed, 32 insertions(+), 12 deletions(-)

Re: WARNING in xfrm_alloc_compat

syzbot has found a reproducer for the following issue on: HEAD commit:4e78c578 Add linux-next specific files for 20201030 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1328449250 kernel config: https://syzkaller.appspot.com/x/.config?x=83318758268dc3

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

On Fri, Oct 30, 2020 at 12:29:50PM -0500, Dan Murphy wrote: > The DP83TD510E is an ultra-low power Ethernet physical layer transceiver > that supports 10M single pair cable. > > The device supports both 2.4-V p2p and 1-V p2p output voltage as defined > by IEEE 802.3cg 10Base-T1L specfications. The

Re: mm/memblock: export memblock_{start/end}_of_DRAM

On Fri, Oct 30, 2020 at 10:38:42AM +0200, Mike Rapoport wrote: > > What do you mean by "system memory block"? There could be a lot of > interpretations if you take into account memory hotplug, "mem=" option, > reserved and firmware memory. > > I'd suggest you to describe the entire use case in m

Re: [PATCH v5 23/25] auxdisplay: charlcd: Do not print chars at end of line

Hi Lars, A few extra typos in this commit message. On Thu, Oct 29, 2020 at 10:58 AM wrote: > > Skip printing characters at the end of a display line. This fits to the > behaviour we already had, that the cursor is nailed to last position of to last -> to the last > a line. > This might slightl

Re: [PATCH v4 11/14] clk: imx: Add blk-ctl driver for i.MX8MP

On 20-10-31 00:21:01, Adam Ford wrote: > On Mon, Oct 26, 2020 at 2:33 PM Abel Vesa wrote: > > > > This driver is intended to work with the following BLK_CTL IPs found in > > i.MX8MP: > > - Audio > > - Media > > - HDMI > > > > Signed-off-by: Abel Vesa > > --- > > drivers/clk/imx/Makefile

Re: [PATCH v5 02/25] auxdisplay: Introduce hd44780_common.[ch]

Hi Lars, On Thu, Oct 29, 2020 at 10:57 AM wrote: > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index 81757eeded68..a56171d1a1ba 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -14,12 +14,31 @@ menuconfig AUXDISPLAY > > If yo

Re: [PATCH net-next v3 3/4] dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY

On Fri, Oct 30, 2020 at 12:29:49PM -0500, Dan Murphy wrote: > The DP83TD510 is a 10M single twisted pair Ethernet PHY > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/net/ti,dp83td510.yaml | 62 +++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentati

Re: [PATCH 00/25] Make charlcd device independent

Hi Lars, On Thu, Oct 29, 2020 at 10:52 AM wrote: > > Changes in v5: > - patch 1: Fix a commit message typo: of -> on > - patch 2: Remove some unnecessary newlines > - patch 8: Fix some typos > - patch 14: Fix commit message typo: it's -> its > - patch 15: this patch is squashed together from the

[GIT PULL] dma-mapping fix for 5.10

The following changes since commit ed8780e3f2ecc82645342d070c6b4e530532e680: Merge tag 'x86-urgent-2020-10-27' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2020-10-27 14:39:29 -0700) are available in the Git repository at: git://git.infradead.org/users/hch/dma-mapping.git tags

[PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

From: Ard Biesheuvel free_highpages() iterates over the free memblock regions in high memory, and marks each page as available for the memory management system. Until commit cddb5ddf2b76 ("arm, xtensa: simplify initialization of high memory pages") it rounded beginning of each region upwards and

Re: [PATCH 4.19 000/264] 4.19.153-rc1 review

Hi Greg, On Wed, Oct 28, 2020 at 12:56:19PM -0700, Guenter Roeck wrote: > Retry. > > On Wed, Oct 28, 2020 at 10:10:35AM -0700, Guenter Roeck wrote: > > On Tue, Oct 27, 2020 at 02:50:58PM +0100, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.19.153 release.

Re: [PATCH v3] coresight: etm4x: Modify core-commit of cpu to avoid the overflow of HiSilicon ETM

Hi Suzuki, On 2020/10/23 18:40, Suzuki Poulose wrote: > On 10/23/20 11:23 AM, Qi Liu wrote: >> The ETM device can't keep up with the core pipeline when cpu core >> is at full speed. This may cause overflow within core and its ETM. >> This is a common phenomenon on ETM devices. >> >> On HiSilicon H

Re: [PATCH v2] perf tools: Support -x for perf stat report

On Tue, Oct 27, 2020 at 10:15:10PM -0700, Andi Kleen wrote: > Add support for the -x, option to enable CSV output with perf stat > report. Useful to parse the information with other programs. > > % perf stat record --quiet -a -I 1000 sleep 5 > % perf stat report -x, > 1.000838672,4003.55,msec

Re: Using fixed LPI number for some Device ID

Dongjiu, On Sat, 31 Oct 2020 02:19:19 +, Dongjiu Geng wrote: > > Hi Marc, > Sorry to disturb you, Currently the LPI number is not fixed for the > device. The LPI number is dynamically allocated start from 8092. > For two OS which shares the ITS, One OS needs to configure the > device interru

[PATCH] Description: coresight: funnel: Remove unnecessary .owner of static funnel driver

As driver.owner has been set in platform_driver_register(), it is unnecessary to set it in static funnel driver, so remove it from struct static_funnel_driver. Signed-off-by: Qi Liu --- drivers/hwtracing/coresight/coresight-funnel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hwtr

Re: Using fixed LPI number for some Device ID

On Sat, 31 Oct 2020 03:10:24 +, Dongjiu Geng wrote: [...] > Sorry for the noise, Because Marc rarely uses the ARM email address, > so I replace to use Marc's kernel.org address instead of ARM email address. Rarely is quite the understatement. I left ARM over a year ago, so the likelihoo

2 MILLIONEN EURO GEWINNEN

-- Hallo und Glückwunsch! Sie sind der glückliche Gewinner von 2 Millionen Euro. Bitte senden Sie Ihre IBAN an die unten stehende E-Mail, um einen Anspruch geltend zu machen. E-Mail: mfrancofoundatio...@gmail.com === Hello and Congratulations! You are the lucky

Re: mm/memblock: export memblock_{start/end}_of_DRAM

On 31.10.20 10:18, Christoph Hellwig wrote: On Fri, Oct 30, 2020 at 10:38:42AM +0200, Mike Rapoport wrote: What do you mean by "system memory block"? There could be a lot of interpretations if you take into account memory hotplug, "mem=" option, reserved and firmware memory. I'd suggest you

[PATCH] coresight: funnel: Remove unnecessary .owner of static funnel driver

As driver.owner has been set in platform_driver_register(), it is unnecessary to set it in static funnel driver, so remove it from struct static_funnel_driver. Signed-off-by: Qi Liu --- drivers/hwtracing/coresight/coresight-funnel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hwtr

Re: [PATCH 4.19 000/264] 4.19.153-rc1 review

On Sat, Oct 31, 2020 at 10:45:00AM +0100, Salvatore Bonaccorso wrote: > Hi Greg, > > On Wed, Oct 28, 2020 at 12:56:19PM -0700, Guenter Roeck wrote: > > Retry. > > > > On Wed, Oct 28, 2020 at 10:10:35AM -0700, Guenter Roeck wrote: > > > On Tue, Oct 27, 2020 at 02:50:58PM +0100, Greg Kroah-Hartman

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

On 31.10.2020 00:36, Andrew Lunn wrote: >>> - Every PHY driver gains a .handle_interrupt() implementation that, for >>> the most part, would look like below: >>> >>> irq_status = phy_read(phydev, INTR_STATUS); >>> if (irq_status < 0) { >>> phy_error(phydev); >>> re

[PATCH] Documentation: PM: correct path name

cpu/ is needed before cpu/ Signed-off-by: Julia Lawall --- Documentation/admin-guide/pm/cpuidle.rst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/admin-guide/pm/cpuidle.rst b/Documentation/admin-guide/pm/cpuidle.rst index 37940a0584ec..26a9d648b88c 100644

[PATCH] Documentation: PM: correct typo

cerainly -> certainly Signed-off-by: Julia Lawall --- Documentation/admin-guide/pm/cpuidle.rst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/admin-guide/pm/cpuidle.rst b/Documentation/admin-guide/pm/cpuidle.rst index 37940a0584ec..a26a94bc0071 100644 ---

Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier

On Fri, Oct 30, 2020 at 06:18:22PM +, Lee Jones wrote: > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for Your commit ID does not exist in mainline kernels, which makes this confusing. The commit ID you should be using is 6735b4632def. -- RMK's Patch system: https://www.armli

[PATCH net-next 6/7] net: mscc: ocelot: deny changing the native VLAN from the prepare phase

Put the preparation phase of switchdev VLAN objects to some good use, and move the check we already had, for preventing the existence of more than one egress-untagged VLAN per port, to the preparation phase of the addition. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/felix.c

[PATCH net-next 3/7] net: mscc: ocelot: transform the pvid and native vlan values into a structure

This is a mechanical patch only. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot.c | 55 -- drivers/net/ethernet/mscc/ocelot_net.c | 16 include/soc/mscc/ocelot.h | 14 --- 3 files changed, 50 insertions(+), 35 deletions(-

[PATCH net-next 7/7] net: dsa: felix: improve the workaround for multiple native VLANs on NPI port

After the good discussion with Florian from here: https://lore.kernel.org/netdev/20200911000337.htwr366ng3nc3a7d@skbuf/ I realized that the VLAN settings on the NPI port (the hardware "CPU port", in DSA parlance) don't actually make any difference, because that port is hardcoded in hardware to use

[PATCH net-next 1/7] net: mscc: ocelot: use the pvid of zero when bridged with vlan_filtering=0

Currently, mscc_ocelot ports configure pvid=0 in standalone mode, and inherit the pvid from the bridge when one is present. When the bridge has vlan_filtering=0, the software semantics are that packets should be received regardless of whether there's a pvid configured on the ingress port or not. H

[PATCH net-next 2/7] net: mscc: ocelot: don't reset the pvid to 0 when deleting it

I have no idea why this code is here, but I have 2 hypotheses: 1. A desperate attempt to keep untagged traffic working when the bridge deletes the pvid on a port. There was a fairly okay discussion here: https://lore.kernel.org/netdev/ca+h21hrrmrlh-rjbghejstzd6_qprsd3rkvrqf-wnkkrgkc...@mail.gmail

[PATCH net-next 5/7] net: mscc: ocelot: move the logic to drop 802.1p traffic to the pvid deletion

Currently, the ocelot_port_set_native_vlan() function starts dropping untagged and prio-tagged traffic when the native VLAN is removed? What is the native VLAN? It is the only egress-untagged VLAN that ocelot supports on a port. If the port is a trunk with 100 VLANs, one of those VLANs can be tran

[PATCH net-next 0/7] VLAN improvements for Ocelot switch

The main reason why I started this work is that deleting the bridge mdb entries fails when the bridge is deleted, as described here: https://lore.kernel.org/netdev/20201015173355.564934-1-vladimir.olt...@nxp.com/ In short, that happens because the bridge mdb entries are added with a vid of 1, but

[PATCH net-next 4/7] net: mscc: ocelot: add a "valid" boolean to struct ocelot_vlan

Currently we are checking in some places whether the port has a native VLAN on egress or not, by comparing the ocelot_port->vid value with zero. That works, because VID 0 can never be a native VLAN configured by the bridge, but now we want to make similar checks for the pvid. That won't work, beca

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

On Saturday, 31 October 2020, 2:12, Willem de Bruijn wrote: Hi Willem, > On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: > > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a support > > for fraglist UDP L4 and fraglist GSO not only for local traffic,

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

On Sat, Oct 31, 2020 at 11:43:45AM +0200, Mike Rapoport wrote: > From: Ard Biesheuvel > > free_highpages() iterates over the free memblock regions in high > memory, and marks each page as available for the memory management > system. > > Until commit cddb5ddf2b76 ("arm, xtensa: simplify initiali

Re: [PATCH] misc: rtsx: do not setting OC_POWER_DOWN reg in rtsx_pci_init_ocp()

On Thu, Oct 15, 2020 at 07:20:34PM +0100, Chris Clayton wrote: > Hi Greg, > > On 18/09/2020 15:35, Chris Clayton wrote: > > Mmm, gmail on android seems to have snuck some html into my reply, so here > > goes again... > > > > On 14/09/2020 16:58, Greg KH wrote: > >> On Sun, Sep 13, 2020 at 09:40:

Re: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done

On 2020-10-29 14:07:59 [-0700], Sagi Grimberg wrote: > > in which context? > > Not sure what is the question. The question is in which context do you complete your requests. My guess by now is "usually softirq/NAPI and context in rare error case". > > But this is probably nr_hw_queues > 1? > >

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

On Sat, 31 Oct 2020 at 11:33, Russell King - ARM Linux admin wrote: > > On Sat, Oct 31, 2020 at 11:43:45AM +0200, Mike Rapoport wrote: > > From: Ard Biesheuvel > > > > free_highpages() iterates over the free memblock regions in high > > memory, and marks each page as available for the memory mana

[PATCH] memory: tegra: add missing put_devcie() call in tegra_emc_probe()

if of_find_device_by_node() succeed, tegra_emc_probe() doesn't have a corresponding put_device(). Thus add jump target to fix the exception handling for this function implementation. Fixes: 73a7f0a90641("memory: tegra: Add EMC (external memory controller) driver") Signed-off-by: Yu Kuai --- dri

[PATCH] mtd: rawnand: ingenic: remove redundant get_device() in ingenic_ecc_get()

of_find_device_by_node() already takes a reference to the device, and ingenic_ecc_release() will drop the reference. So, the get_device() in ingenic_ecc_get() is redundand. Fixes: 15de8c6efd0e("mtd: rawnand: ingenic: Separate top-level and SoC specific code") Signed-off-by: Yu Kuai --- drivers/

[PATCH] fsl/fman: add missing put_devcie() call in fman_port_probe()

if of_find_device_by_node() succeed, fman_port_probe() doesn't have a corresponding put_device(). Thus add jump target to fix the exception handling for this function implementation. Fixes: 0572054617f3 ("fsl/fman: fix dereference null return value") Signed-off-by: Yu Kuai --- drivers/net/ethern

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

On Sat, Oct 31, 2020 at 11:18:18AM +0100, Heiner Kallweit wrote: > On 31.10.2020 00:36, Andrew Lunn wrote: > >>> - Every PHY driver gains a .handle_interrupt() implementation that, for > >>> the most part, would look like below: > >>> > >>> irq_status = phy_read(phydev, INTR_STATUS); > >>> if

ERROR: modpost: "clk_set_min_rate" undefined!

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5fc6b075e165f641fbc366b58b578055762d5f8c commit: ef265c55c1ac0f02c74a33d8e054547f7eafc81b ASoC: mchp-spdifrx: add driver for SPDIF RX date: 4 weeks ago config: sh-allmodconfig (attached as .config) compile

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

On Sat, Oct 31, 2020 at 11:47:42AM +0100, Ard Biesheuvel wrote: > On Sat, 31 Oct 2020 at 11:33, Russell King - ARM Linux admin > wrote: > > > > On Sat, Oct 31, 2020 at 11:43:45AM +0200, Mike Rapoport wrote: > > > From: Ard Biesheuvel > > > > > > free_highpages() iterates over the free memblock re

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

On Fri, 30 Oct 2020 22:34:10 +0800 Coiby Xu wrote: > On Thu, Oct 29, 2020 at 07:06:40PM +0200, Andy Shevchenko wrote: > >On Thu, Oct 29, 2020 at 4:42 PM Jonathan Cameron wrote: > >> On Thu, 29 Oct 2020 15:48:56 +0800 > >> Coiby Xu wrote: > > > >> Please put a cover letter on your next ser

Re: [PATCH v2 5/5] drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs

Hi Luo, Thank you for the patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on scsi/for-next linus/master v5.10-rc1 next-20201030] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH 4/5] iio: adc: xilinx: use devres for irq handling

On Fri, 30 Oct 2020 11:52:00 +0100 Bartosz Golaszewski wrote: > On Thu, Oct 29, 2020 at 4:41 PM Jonathan Cameron wrote: > > > > On Mon, 26 Oct 2020 14:36:08 +0100 > > Bartosz Golaszewski wrote: > > > > > From: Bartosz Golaszewski > > > > > > Further simplify the remove() callback and error p

Re: [PATCH] checkpatch: improve handling of email comments

On Sat, 2020-10-31 at 11:41 +0530, Dwaipayan Ray wrote: > Names which have must quote characters without any comments are > not warned about right now: > > D. Ray doesn't throw any warning, while > D. Ray (Dwai) does. I agree that a comment in parentheses after the name and before the email add

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

On Sat, 31 Oct 2020 at 12:04, Russell King - ARM Linux admin wrote: > > On Sat, Oct 31, 2020 at 11:47:42AM +0100, Ard Biesheuvel wrote: > > On Sat, 31 Oct 2020 at 11:33, Russell King - ARM Linux admin > > wrote: > > > > > > On Sat, Oct 31, 2020 at 11:43:45AM +0200, Mike Rapoport wrote: > > > > Fr

Re: [PATCH 4/6] perf: Optimize get_recursion_context()

On Fri, Oct 30, 2020 at 07:31:24PM -0400, Steven Rostedt wrote: > Note, I thought that in_nmi() and friends was in interrupt.h, but is > really in preempt.h. All the values used in Peter's code is also > defined in preempt.h, so why not have something like that there? > > I take back adding it to

Re: ltp::mmap05 --> BUG: using __this_cpu_read() in preemptible

Hi Mike, good to see you're enjoying retirement ;-) On Sat, Oct 31, 2020 at 06:52:40AM +0100, Mike Galbraith wrote: > [ 138.620544] BUG: using __this_cpu_read() in preemptible [] code: > mmap05/4858 > [ 138.620737] caller is lockdep_hardirqs_on_prepare+0x2f/0x1b0 Fix should already b

KASAN: vmalloc-out-of-bounds Write in drm_fb_helper_dirty_work (3)

Hello, syzbot found the following issue on: HEAD commit:4525c878 scsi: qla2xxx: remove incorrect sparse #ifdef git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1411f30850 kernel config: https://syzkaller.appspot.com/x/.config?x=a5c844e56cc50cdb dashboard

RE: [PATCH] perf: increase size of buf in perf_evsel__hists_browse()

From: Song Liu > Sent: 30 October 2020 23:55 > > Making perf with gcc-9.1.1 generates the following warning: > > CC ui/browsers/hists.o > ui/browsers/hists.c: In function 'perf_evsel__hists_browse': > ui/browsers/hists.c:3078:61: error: '%d' directive output may be \ > truncated writing b

[tip: locking/urgent] lockdep: Fix nr_unused_locks accounting

The following commit has been merged into the locking/urgent branch of tip: Commit-ID: 1a39340865ce505a029b37aeb47a3e4c8db5f6c6 Gitweb: https://git.kernel.org/tip/1a39340865ce505a029b37aeb47a3e4c8db5f6c6 Author:Peter Zijlstra AuthorDate:Tue, 27 Oct 2020 13:48:34 +01:00 Com

[tip: locking/urgent] locking/lockdep: Remove more raw_cpu_read() usage

The following commit has been merged into the locking/urgent branch of tip: Commit-ID: d48e3850030623e1c20785bceaaf78f916d0b1a3 Gitweb: https://git.kernel.org/tip/d48e3850030623e1c20785bceaaf78f916d0b1a3 Author:Peter Zijlstra AuthorDate:Mon, 26 Oct 2020 16:22:56 +01:00 Com

[PATCH 5.4 13/49] chelsio/chtls: fix memory leaks in CPL handlers

From: Vinay Kumar Yadav [ Upstream commit 6daa1da4e262b0cd52ef0acc1989ff22b5540264 ] CPL handler functions chtls_pass_open_rpl() and chtls_close_listsrv_rpl() should return CPL_RET_BUF_DONE so that caller function will do skb free to avoid leak. Fixes: cc35c88ae4db ("crypto : chtls - CPL handle

[PATCH 5.4 16/49] gtp: fix an use-before-init in gtp_newlink()

From: Masahiro Fujiwara [ Upstream commit 51467431200b91682b89d31317e35dcbca1469ce ] *_pdp_find() from gtp_encap_recv() would trigger a crash when a peer sends GTP packets while creating new GTP device. RIP: 0010:gtp1_pdp_find.isra.0+0x68/0x90 [gtp] Call Trace: gtp_encap_recv+0xc2/0x2e0 [gt

[PATCH 5.4 12/49] chelsio/chtls: fix deadlock issue

From: Vinay Kumar Yadav [ Upstream commit 28e9dcd9172028263c8225c15c4e329e08475e89 ] In chtls_pass_establish() we hold child socket lock using bh_lock_sock and we are again trying bh_lock_sock in add_to_reap_list, causing deadlock. Remove bh_lock_sock in add_to_reap_list() as lock is already hel

[PATCH 5.4 24/49] tipc: fix memory leak caused by tipc_buf_append()

From: Tung Nguyen [ Upstream commit ceb1eb2fb609c88363e06618b8d4bbf7815a4e03 ] Commit ed42989eab57 ("tipc: fix the skb_unshare() in tipc_buf_append()") replaced skb_unshare() with skb_copy() to not reduce the data reference counter of the original skb intentionally. This is not the correct way t

  1   2   3   4   5   6   >