[patch V2 12/13] usb: core: Replace in_interrupt() in comments

2020-10-19 Thread Thomas Gleixner
From: Ahmed S. Darwish The usage of in_interrupt() in drivers is phased out for various reasons. Various comments use !in_interrupt() to describe calling context for functions which might sleep. That's wrong because the calling context has to be preemptible task context, which is not what !in_in

[patch V2 07/13] usbip: Remove in_interrupt() check

2020-10-19 Thread Thomas Gleixner
From: Ahmed S. Darwish The usage of in_interrupt() in drivers is phased out and Linus clearly requested that code which changes behaviour depending on context should either be separated or the context be conveyed in an argument passed by the caller, which usually knows the context. usbip_recv()

[patch V2 04/13] USB: serial: digi_acceleport: Remove in_interrupt() usage

2020-10-19 Thread Thomas Gleixner
From: Ahmed S. Darwish The usage of in_interrupt() in drivers is phased out and Linus clearly requested that code which changes behaviour depending on context should either be separated or the context be conveyed in an argument passed by the caller, which usually knows the context. The debug pri

[patch V2 03/13] USB: serial: keyspan_pda: Consolidate room query

2020-10-19 Thread Thomas Gleixner
From: Sebastian Andrzej Siewior Having two copies of the same code doesn't make the code more readable and allocating a buffer of 1 byte for a synchronous operation is a pointless exercise. Allocate a byte buffer at init which can be used instead. The buffer is only used in open() and tty->write

[patch V2 01/13] USB: sisusbvga: Make console support depend on BROKEN

2020-10-19 Thread Thomas Gleixner
The console part of sisusbvga is broken vs. printk(). It uses in_atomic() to detect contexts in which it cannot sleep despite the big fat comment in preempt.h which says: Do not use in_atomic() in driver code. in_atomic() does not work on kernels with CONFIG_PREEMPT_COUNT=n which means that spin/r

[patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage

2020-10-19 Thread Thomas Gleixner
keyspan_pda_write() uses in_interrupt() to check whether it is safe to invoke functions which might sleep. The usage of in_interrupt() in drivers is phased out and Linus clearly requested that code which changes behaviour depending on context should either be seperated or the context be conveyed i

[patch V2 05/13] usb: xhci: Remove in_interrupt() checks

2020-10-19 Thread Thomas Gleixner
From: Ahmed S. Darwish The usage of in_interrupt() in drivers is phased out for various reasons. xhci_set_hc_event_deq() has an !in_interrupt() check which is pointless because the function is only invoked from xhci_mem_init() which is clearly task context as it does GFP_KERNEL allocations. Remo

Re: [PATCH 2/6] Documetation: dt-bindings: add the samsung,exynos-pcie binding

2020-10-19 Thread Krzysztof Kozlowski
On Mon, 19 Oct 2020 at 12:12, Krzysztof Kozlowski wrote: > > On Mon, Oct 19, 2020 at 11:47:11AM +0200, Marek Szyprowski wrote: > > From: Jaehoon Chung > > > > Add dt-bindings for the Samsung Exynos PCIe controller (Exynos5433 > > variant). > > The title has typo and actually entire "Doc" should b

[patch V2 11/13] usb: gadget: udc: Remove in_interrupt()/in_irq() from comments

2020-10-19 Thread Thomas Gleixner
From: Ahmed S. Darwish The usage of in_irq()/in_interrupt() in drivers is phased out for various reasons. The context description for usb_gadget_giveback_request() is misleading as in_interupt() means: hard interrupt or soft interrupt or bottom half disabled regions. But it's also invoked from t

Re: [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value

2020-10-19 Thread Matthias Brugger
On 18/10/2020 21:42, Fabien Parent wrote: The binding documentation says: - #mbox-cells: Should be 2. <&phandle channel priority> phandle: Label name of a gce node. channel: Channel of mailbox. Be equal to the thread id of GCE. priority: Priority of GCE thread.

Re: [PATCH] media: stm32-dcmi: add support of BT656 bus

2020-10-19 Thread Hugues FRUCHET
Hi Sakari, I have questions about "bus-type" handling below. On 10/15/20 5:41 PM, Hugues FRUCHET wrote: > Hi Sakari, > > Thanks for reviewing, > > On 10/13/20 11:07 AM, Sakari Ailus wrote: >> Hi Hugues, >> >> On Wed, Oct 07, 2020 at 06:14:50PM +0200, Hugues Fruchet wrote: >>> Add support of BT6

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

2020-10-19 Thread Matthias Brugger
On 12/10/2020 22:52, Fabien Parent wrote: Add node for the auxadc IP. The IP is compatible with the one found in MT8173 SoC. Signed-off-by: Fabien Parent Applied to v5.10-tmp/dts64 Thanks! --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++ 1 file changed, 10 insertions(+)

Re: [PATCH 5/6] pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant

2020-10-19 Thread Krzysztof Kozlowski
On Mon, Oct 19, 2020 at 11:47:14AM +0200, Marek Szyprowski wrote: > From: Jaehoon Chung > > Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM: > dts: exynos: Remove Exynos5440"). Rework this driver to support DWC PCIe > variant found in the Exynos5433 SoCs. > > The main dif

sched: system doesn't boot since "sched: Add new migrate_disable() implementation"

2020-10-19 Thread Christian Eggers
I have problems with the latest 5.9-rt releases on i.MX6ULL (!CONFIG_SMP): -rc8-rt13 works fine -rc8-rt14 doesn't compile (due to CONFIG_FRACE, already fixed in -rt16) -rt15 dito. -rt16 compiles, but doesn't boot (no console output at all) After reverting (on -rt16) de1c0755e6f9 ("tracing: fix c

Re: [PATCH v1 21/29] virtio-mem: memory notifier callbacks are specific to Sub Block Mode (SBM)

2020-10-19 Thread David Hildenbrand
On 19.10.20 03:57, Wei Yang wrote: > On Mon, Oct 12, 2020 at 02:53:15PM +0200, David Hildenbrand wrote: >> Let's rename accordingly. >> >> Cc: "Michael S. Tsirkin" >> Cc: Jason Wang >> Cc: Pankaj Gupta >> Signed-off-by: David Hildenbrand >> --- >> drivers/virtio/virtio_mem.c | 29 ++

[MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

2020-10-19 Thread Geliang Tang
This patchset deals with initializations of mptcp_options_received's two fields, ahmac and port. Geliang Tang (2): mptcp: initialize mptcp_options_received's ahmac mptcp: move mptcp_options_received's port initialization net/mptcp/options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

[MPTCP][PATCH net-next 1/2] mptcp: initialize mptcp_options_received's ahmac

2020-10-19 Thread Geliang Tang
This patch initialize mptcp_options_received's ahmac to zero, otherwise it will be a random number when receiving ADD_ADDR suboption with echo-flag=1. Fixes: 3df523ab582c5 ("mptcp: Add ADD_ADDR handling") Signed-off-by: Geliang Tang --- net/mptcp/options.c | 1 + 1 file changed, 1 insertion(+)

[MPTCP][PATCH net-next 2/2] mptcp: move mptcp_options_received's port initialization

2020-10-19 Thread Geliang Tang
This patch moved mptcp_options_received's port initialization from mptcp_parse_option to mptcp_get_options, put it together with the other fields initializations of mptcp_options_received. Fixes: 3df523ab582c5 ("mptcp: Add ADD_ADDR handling") Signed-off-by: Geliang Tang --- net/mptcp/options.c |

Re: [PATCH 1/2] dt-bindings: dma: mtk-apdma: add bindings for MT8516 SOC

2020-10-19 Thread Matthias Brugger
On 15/10/2020 14:33, Fabien Parent wrote: Add bindings to APDMA for MT8516 SoC. MT8516 is compatible with MT6577. Signed-off-by: Fabien Parent Reviewed-by: Matthias Brugger --- Documentation/devicetree/bindings/dma/mtk-uart-apdma.txt | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add usb1 node

2020-10-19 Thread Matthias Brugger
On 14/10/2020 18:24, Fabien Parent wrote: The MT8516 has 2 USB instances. Add support for the second USB instance. usb1 can only work in host mode. Signed-off-by: Fabien Parent Applied to v5.10-tmp/dts64 Thanks! --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 21 +

Re: [PATCH 1/2] arm64: dts: mediatek: mt8516: rename usb phy

2020-10-19 Thread Matthias Brugger
On 14/10/2020 18:24, Fabien Parent wrote: The USB phy node is named usb0_phy but there is only one phy with 2 ports on MT8516. Rename the phy to make it more obvious it can also support the usb1 node. The usb1 node will be added in a follow-up commit. Signed-off-by: Fabien Parent Applied t

Re: [PATCH v6 02/14] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-10-19 Thread Maxime Ripard
Hi Samuel, On Mon, Oct 12, 2020 at 08:15:30PM -0500, Samuel Holland wrote: > On 10/12/20 7:15 AM, Maxime Ripard wrote: > > Hi, > > > > On Mon, Oct 05, 2020 at 03:23:12PM +0200, Clément Péron wrote: > >> On Mon, 5 Oct 2020 at 14:13, Maxime Ripard wrote: > >>> > >>> On Sat, Oct 03, 2020 at 04:19:3

[PATCH v2 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC

2020-10-19 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano --- .../testing/selftests/core/close_range_test.c | 74 +++ 1 file changed, 74 insertions(+) diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c index c99b98b0d461..c9db282158bb 100644 --

Re: [PATCH v3 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

2020-10-19 Thread Chanwoo Choi
On 10/19/20 1:11 PM, Chanwoo Choi wrote: > On 10/19/20 9:39 AM, Dmitry Osipenko wrote: >> ... >>> @@ -1361,6 +1373,9 @@ static ssize_t governor_store(struct device *dev, >>> struct device_attribute *attr, >>> goto out; >>> } >>> >>> + remove_sysfs_files(df, df->governor); >>> +

[PATCH v2 0/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-10-19 Thread Giuseppe Scrivano
When the new flag is used, close_range will set the close-on-exec bit for the file descriptors instead of close()-ing them. It is useful for e.g. container runtimes that want to minimize the number of syscalls used after a seccomp profile is installed but want to keep some fds open until the conta

[PATCH v2 1/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-10-19 Thread Giuseppe Scrivano
When the flag CLOSE_RANGE_CLOEXEC is set, close_range doesn't immediately close the files but it sets the close-on-exec bit. It is useful for e.g. container runtimes that usually install a seccomp profile "as late as possible" before execv'ing the container process itself. The container runtime c

Re: [PATCH 2/6] Documetation: dt-bindings: add the samsung,exynos-pcie binding

2020-10-19 Thread Krzysztof Kozlowski
On Mon, Oct 19, 2020 at 11:47:11AM +0200, Marek Szyprowski wrote: > From: Jaehoon Chung > > Add dt-bindings for the Samsung Exynos PCIe controller (Exynos5433 > variant). > > Signed-off-by: Jaehoon Chung > [mszyprow: updated the binding to latest driver changes, rewrote it in yaml, > r

Re: [patch V2 13/13] usb: atm: Replace in_interrupt() usage in comment

2020-10-19 Thread Duncan Sands
On 10/19/20 12:06 PM, Thomas Gleixner wrote: in_interrupt() is a pretty vague context description as it means: hard interrupt, soft interrupt or bottom half disabled regions. Replace the vague comment with a proper reasoning why spin_lock_irqsave() needs to be used. Signed-off-by: Ahmed S. Darw

Re: [PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread Xu, Yanfei
On 10/19/20 5:40 PM, Vlastimil Babka wrote: On 10/19/20 10:36 AM, yanfei...@windriver.com wrote: From: Yanfei Xu There are two 'start_pfn' declared in compact_zone() which have different meaning. Rename the second one to 'iteration_start_pfn' to prevent trace_mm_compaction_end() from tracin

Re: [PATCH 6/6] arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards

2020-10-19 Thread Krzysztof Kozlowski
On Mon, Oct 19, 2020 at 11:47:15AM +0200, Marek Szyprowski wrote: > From: Jaehoon Chung > > Add the nodes relevant to PCIe PHY and PCIe support. PCIe is used for the > WiFi interface (Broadcom Limited BCM4358 802.11ac Wireless LAN SoC). > > Signed-off-by: Jaehoon Chung > [mszyprow: rewrote comm

Re: Remove __napi_schedule_irqoff?

2020-10-19 Thread Thomas Gleixner
On Sun, Oct 18 2020 at 10:19, Jakub Kicinski wrote: > On Sun, 18 Oct 2020 10:20:41 +0200 Heiner Kallweit wrote: >> >> Otherwise a non-solution could be to make IRQ_FORCED_THREADING >> >> configurable. >> > >> > I have to say I do not understand why we want to defer to a thread the >> > hard IRQ

Re: [PATCH v2] arm64: dts: allwinner: beelink-gs1: Update LED power node

2020-10-19 Thread Maxime Ripard
On Sun, Oct 18, 2020 at 07:25:10PM +0200, Clément Péron wrote: > HI Maxime, > > On Mon, 12 Oct 2020 at 13:22, Maxime Ripard wrote: > > > > Hi! > > > > On Sun, Oct 11, 2020 at 11:22:37PM +0200, Clément Péron wrote: > > > Beelink GS1 LED trigger a warning when running dtbs_check. > > > > > > Update

Re: [PATCH v2 0/3] Clarify abstract scale usage for power values in Energy Model, EAS and IPA

2020-10-19 Thread Lukasz Luba
On 10/16/20 5:02 PM, Quentin Perret wrote: On Friday 16 Oct 2020 at 15:42:57 (+0100), Lukasz Luba wrote: Do you mean a new entry in DT which will be always below 'dynamic-power-coefficient' and/or 'sustainable-power' saying the unit of above value? Yes, something like that. There was disc

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Peter Zijlstra
On Fri, Oct 16, 2020 at 11:27:02PM +0800, Jonathan Cameron wrote: > Both ACPI and DT provide the ability to describe additional layers of > topology between that of individual cores and higher level constructs > such as the level at which the last level cache is shared. > In ACPI this can be repres

Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER

2020-10-19 Thread Viresh Kumar
On 19-10-20, 11:12, Sudeep Holla wrote: > Yes it has clocks property but used by SCMI(for CPUFreq/DevFreq) and not > by any clock provider driver. E.g. the issue you will see if "clocks" > property is used instead of "qcom,freq-domain" on Qcom parts. Okay, I understand. But what I still don't unde

Re: [PATCH] mm: fix page_owner initializing issue for arm32

2020-10-19 Thread Zhenhua Huang
Fri, Oct 16, 2020 at 06:41:04PM +0800, Vlastimil Babka wrote: > On 10/16/20 11:14 AM, Zhenhua Huang wrote: > >Page owner of pages used by page owner itself used is missing on arm32 > >targets. > >The reason is dummy_handle and failure_handle is not initialized > >correctly. > >Buddy allocator is us

[PATCH] drm/amd/display: fix a possible NULL pointer dereference in bios_parser_get_src_obj()

2020-10-19 Thread Defang Bo
From: estherbdf <603571...@qq.com> [Why] the func bios_parser_get_src_obj () is similar to bios_parser_get_dst_obj () which is fixed by the commit("drm/amd/display: Banch of smatch error and warning fixes in DC"). the symbol 'id' is uninitialized and it is not checked before dereference it,m

Re: [PATCH v2 07/14] perf arm-spe: Refactor address packet handling

2020-10-19 Thread Leo Yan
Hi Andre, On Mon, Oct 19, 2020 at 10:01:28AM +0100, André Przywara wrote: [...] > > diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c > > b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c > > index cc18a1e8c212..9d3de163d47c 100644 > > --- a/tools/perf/util/arm-spe-decoder/arm-sp

Re: [PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread Vlastimil Babka
On 10/19/20 12:29 PM, Xu, Yanfei wrote: On 10/19/20 5:40 PM, Vlastimil Babka wrote: On 10/19/20 10:36 AM, yanfei...@windriver.com wrote: From: Yanfei Xu There are two 'start_pfn' declared in compact_zone() which have different meaning. Rename the second one to 'iteration_start_pfn' to preve

[PATCH v2] mm: fix page_owner initializing issue for arm32

2020-10-19 Thread Zhenhua Huang
Page owner of pages used by page owner itself used is missing on arm32 targets. The reason is dummy_handle and failure_handle is not initialized correctly. Buddy allocator is used to initialize these two handles. However, buddy allocator is not ready when page owner calls it. This change fixed that

Re: [PATCH v9 12/15] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-10-19 Thread Ethan Zhao
On Sat, Oct 17, 2020 at 6:29 AM Bjorn Helgaas wrote: > > [+cc Christoph, Ethan, Sinan, Keith; sorry should have cc'd you to > begin with since you're looking at this code too. Particularly > interested in your thoughts about whether we should be touching > PCI_ERR_ROOT_COMMAND and PCI_ERR_ROOT_ST

[PATCH net] drivers/net/wan/hdlc: In hdlc_rcv, check to make sure dev is an HDLC device

2020-10-19 Thread Xie He
The hdlc_rcv function is used as hdlc_packet_type.func to process any skb received in the kernel with skb->protocol == htons(ETH_P_HDLC). The purpose of this function is to provide second-stage processing for skbs not assigned a "real" L3 skb->protocol value in the first stage. This function assum

Re: [PATCH] mm: mempolicy: fix potential pte_unmap_unlock pte error

2020-10-19 Thread Oscar Salvador
On Mon, Oct 19, 2020 at 03:48:53AM -0400, Shijie Luo wrote: > When flags in queue_pages_pte_range don't have MPOL_MF_MOVE or > MPOL_MF_MOVE_ALL > bits, code breaks and passing origin pte - 1 to pte_unmap_unlock seems like > not a good idea. I think the above is already explained below? > queue_

[PATCH] ASoC: adau1977: remove platform data and move micbias bindings include

2020-10-19 Thread Alexandru Ardelean
The change removes the platform_data include/definition. It only contains some values for the MICBIAS. These are moved into 'dt-bindings/sound/adi,adau1977.h' so that they can be used inside device-trees. When moving then, they need to be converted to pre-compiler defines, so that the DT compiler c

Re: [PATCH 0/3] PM / devfreq: Add devfreq_frequency tracepoint to track frequency change

2020-10-19 Thread Chanwoo Choi
On 10/8/20 4:54 PM, Chanwoo Choi wrote: > Add devfreq_tracepoint to track the correct timing of frequency change > with following information: > - device name > - current frequency > - previous frequency > - load when change frequency > - tracepoint path : /sys/kernel/debug/tracing/events/devfreq_f

[PATCH v2] mm: fix page_owner initializing issue for arm32

2020-10-19 Thread Zhenhua Huang
Page owner of pages used by page owner itself used is missing on arm32 targets. The reason is dummy_handle and failure_handle is not initialized correctly. Buddy allocator is used to initialize these two handles. However, buddy allocator is not ready when page owner calls it. This change fixed that

Re: [PATCH v7 3/3] iommu/tegra-smmu: Add PCI support

2020-10-19 Thread Robin Murphy
On 2020-10-17 02:56, Nicolin Chen wrote: On Fri, Oct 16, 2020 at 03:10:26PM +0100, Robin Murphy wrote: On 2020-10-16 04:53, Nicolin Chen wrote: On Thu, Oct 15, 2020 at 10:55:52AM +0100, Robin Murphy wrote: On 2020-10-15 05:13, Nicolin Chen wrote: On Wed, Oct 14, 2020 at 06:42:36PM +0100, Robi

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-19 Thread Marek Behún
On Mon, 19 Oct 2020 10:35:12 +0200 Udo van den Heuvel wrote: > People, > > At https://www.kernel.org/doc/html/latest/leds/leds-class.html we can > read that the LEDS code supposedly optimizes away when certain > conditions are met. > Especially the Realtek HDA driver *unconditionally* (as found

Re: [PATCH v4 9/9] riscv: Fixup lockdep_assert_held(&text_mutex) in patch_insn_write

2020-10-19 Thread Guo Ren
Good Idea! I'll try :P On Mon, Oct 19, 2020 at 4:36 PM Masami Hiramatsu wrote: > > On Sat, 17 Oct 2020 07:06:17 + > guo...@kernel.org wrote: > > > From: Guo Ren > > > > It will cause warning messages: > > echo function_graph > /sys/kernel/debug/tracing/current_tracer > > [ 47.691397] -

Re: [PATCH 2/2] thermal: cpufreq_cooling: Reuse effective_cpu_util()

2020-10-19 Thread Lukasz Luba
On 10/19/20 8:40 AM, Viresh Kumar wrote: On 30-07-20, 12:16, Lukasz Luba wrote: Hi Viresh, On 7/30/20 7:24 AM, Viresh Kumar wrote: On 17-07-20, 11:46, Vincent Guittot wrote: On Thu, 16 Jul 2020 at 16:24, Lukasz Luba wrote: On 7/16/20 12:56 PM, Peter Zijlstra wrote: Currently cpufreq_coo

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-19 Thread Peter Zijlstra
On Sun, Oct 18, 2020 at 02:14:46PM -0400, Nitesh Narayan Lal wrote: > >> + hk_cpus = housekeeping_num_online_cpus(HK_FLAG_MANAGED_IRQ); > >> + > >> + /* > >> + * If we have isolated CPUs for use by real-time tasks, to keep the > >> + * latency overhead to a minimum, device-specific IRQ vector

[PATCH 2/2] clk: axi-clkgen: move the OF table at the bottom of the file

2020-10-19 Thread Alexandru Ardelean
The change is mostly cosmetic. No functional changes. Since the driver now uses device_get_match_data() to obtain the driver specific info, there is no need to define the OF table before the probe function. Signed-off-by: Alexandru Ardelean --- drivers/clk/clk-axi-clkgen.c | 18 +

[PATCH 1/2] clk: axi-clkgen: wrap limits in a struct and keep copy on the state object

2020-10-19 Thread Alexandru Ardelean
Up until now the these limits were global/hard-coded, since they are typically limits of the fabric. However, since this is an FPGA generated clock, this may run on setups where one clock is on a fabric, and another one synthesized on another fabric connected via PCIe (or some other inter-connect)

[PATCH] cifs : fix memory leak on error path

2020-10-19 Thread Defang Bo
In SMB2_open_init() , if smb2_plain_req_init() fails, then the memory assigned to req will be leaked. It's similar to SMB2_open() which is fixed by the commit ("cifs: fix memory leak in SMB2_open()"). Signed-off-by: Defang Bo --- fs/cifs/smb2pdu.c | 5 +++-- 1 file changed, 3 insertions(+),

Re: [PATCH v2 4/4] scatterlist: add sgl_memset()

2020-10-19 Thread Bodo Stroesser
AFAICS, there are 2 unneeded lines in the new implementation of sgl_memset. Please see details below. Am 18.10.20 um 19:13 schrieb Douglas Gilbert: The existing sg_zero_buffer() function is a bit restrictive. For example protection information (PI) blocks are usually initialized to 0xff bytes.

Re: [PATCH v4] KVM: Check the allocation of pv cpu mask

2020-10-19 Thread Vitaly Kuznetsov
lihaiwei.ker...@gmail.com writes: > From: Haiwei Li > > check the allocation of per-cpu __pv_cpu_mask. Init > 'send_IPI_mask_allbutself' only when successful and check the allocation > of __pv_cpu_mask in 'kvm_flush_tlb_others'. > > Suggested-by: Vitaly Kuznetsov > Signed-off-by: Haiwei Li > --

Re: [PATCH] arm64/mm: Validate hotplug range before creating linear mapping

2020-10-19 Thread Anshuman Khandual
On 10/07/2020 02:09 PM, David Hildenbrand wrote: >>> We do have __add_pages()->check_hotplug_memory_addressable() where we >>> already check against MAX_PHYSMEM_BITS. >> >> Initially, I thought about check_hotplug_memory_addressable() but the >> existing check that asserts end of hotplug wrt MAX

Re: [PATCH] mm: mempolicy: fix potential pte_unmap_unlock pte error

2020-10-19 Thread Michal Hocko
On Mon 19-10-20 12:50:34, Oscar Salvador wrote: > On Mon, Oct 19, 2020 at 03:48:53AM -0400, Shijie Luo wrote: > > When flags in queue_pages_pte_range don't have MPOL_MF_MOVE or > > MPOL_MF_MOVE_ALL > > bits, code breaks and passing origin pte - 1 to pte_unmap_unlock seems like > > not a good idea

[PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-19 Thread Geert Uytterhoeven
MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead. Fixes: a00a582203dbc43e ("mptcp: move crypto test to KUNIT") Signed-off-by: Geert Uytterhoeven --- net/mptcp/Kconfig | 4 +--- 1 file changed,

[PATCH 2/4] iommu/mediatek: Add iotlb_sync_range() support

2020-10-19 Thread Chao Hao
MTK_IOMMU driver writes one page entry and does tlb flush at a time currently. More optimal would be to aggregate the writes and flush BUS buffer in the end. For 50MB buffer mapping, if mtk_iommu driver use iotlb_sync_range() instead of tlb_add_range() and tlb_flush_walk/leaf(), it can increase 50%

[PATCH 0/4] MTK_IOMMU: Optimize mapping / unmapping performance

2020-10-19 Thread Chao Hao
For MTK platforms, mtk_iommu is using iotlb_sync(), tlb_add_range() and tlb_flush_walk/leaf() to do tlb sync when iommu driver runs iova mapping/unmapping. But if buffer size is large, it maybe consist of many pages(4K/8K/64K/1MB..). So iommu driver maybe run many times tlb sync in mappi

[PATCH 3/4] iommu/mediatek: Remove unnecessary tlb sync

2020-10-19 Thread Chao Hao
As is "[PATCH 2/4]" described, we will use iotlb_sync_range() to replace iotlb_sync(), tlb_add_range() and tlb_flush_walk/leaf() to enhance performance. So we will remove the implementation of iotlb_sync(), tlb_add_range() and tlb_flush_walk/leaf(). Signed-off-by: Chao Hao --- drivers/iommu/mtk_

Re: [PATCH 00/15] dmaengine: dw-axi-dmac: support Intel KeemBay AxiDMA

2020-10-19 Thread andriy.shevche...@linux.intel.com
On Mon, Oct 19, 2020 at 01:22:03AM +, Sia, Jee Heng wrote: > > From: Eugeniy Paltsev > > Sent: 16 October 2020 10:51 PM > > Hi Sia, > > > > Is this patch series available in some public git repo? > [>>] We do not have public git repo, but the patch series are tested on > kernel v5.9 Sia, c

[PATCH 1/4] iommu: Introduce iotlb_sync_range callback

2020-10-19 Thread Chao Hao
Add iotlb_sync_range callback to support that driver can appoint iova and size to do tlb sync. Iommu will call iotlb_sync_range() after the whole mapping/unmapping is completed, and the iova and size of iotlb_sync_range() are start_iova and buffer total_size respectively. At the same time, iotlb_sy

Re: [PATCH v5 1/5] arm64: Add framework to turn IPI as NMI

2020-10-19 Thread Marc Zyngier
On 2020-10-14 12:12, Sumit Garg wrote: Introduce framework to turn an IPI as NMI using pseudo NMIs. In case a particular platform doesn't support pseudo NMIs, then request IPI as a regular IRQ. The main motivation for this feature is to have an IPI that can be leveraged to invoke NMI functions o

[PATCH 4/4] iommu/mediatek: Adjust iotlb_sync_range

2020-10-19 Thread Chao Hao
As is title, the patch only adjusts the architecture of iotlb_sync_range(). No functional change. Signed-off-by: Chao Hao --- drivers/iommu/mtk_iommu.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index

Re: [PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread Xu, Yanfei
On 10/19/20 6:48 PM, Vlastimil Babka wrote: On 10/19/20 12:29 PM, Xu, Yanfei wrote: On 10/19/20 5:40 PM, Vlastimil Babka wrote: On 10/19/20 10:36 AM, yanfei...@windriver.com wrote: From: Yanfei Xu There are two 'start_pfn' declared in compact_zone() which have different meaning. Rename

Re: [PATCH] blk-mq: remove the calling of local_memory_node()

2020-10-19 Thread Michal Hocko
On Mon 19-10-20 16:20:47, Xianting Tian wrote: > We don't need to check whether the node is memoryless numa node before > calling allocator interface. SLUB(and SLAB,SLOB) relies on the page > allocator to pick a node. Page allocator should deal with memoryless > nodes just fine. It has zonelists co

Re: [PATCH v4 0/4] Add system mmu support for Armada-806

2020-10-19 Thread Denis Odintsov
> Am 13.10.2020 um 15:08 schrieb Robin Murphy : > > On 2020-10-06 16:16, Denis Odintsov wrote: >> Hi, >>> Am 15.07.2020 um 09:06 schrieb Tomasz Nowicki : >>> >>> The series is meant to support SMMU for AP806 and a workaround >>> for accessing ARM SMMU 64bit registers is the gist of it. >>> >>

Re: [perf metricgroup] fcc9c5243c: perf-sanity-tests.Parse_and_process_metrics.fail

2020-10-19 Thread Jin, Yao
Hi Garry, Hi Ian, On 10/19/2020 5:48 PM, John Garry wrote: On 19/10/2020 00:30, Ian Rogers wrote: On Sun, Oct 18, 2020 at 1:51 AM kernel test robot wrote: Greeting, FYI, we noticed the following commit (built with gcc-9): commit: fcc9c5243c478f104014daf4d23db86098d2aef0 ("perf metricgroup:

[PATCH v3] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread yanfei . xu
From: Yanfei Xu There are two 'start_pfn' declared in compact_zone() which have different meaning. Rename the second one to 'iteration_start_pfn' to prevent confusion. BTW, remove an useless semicolon. Signed-off-by: Yanfei Xu Acked-by: David Hildenbrand Acked-by: Vlastimil Babka Acked-by: P

Re: [PATCH v2 2/2] irqchip/ti-sci-inta: Add support for unmapped event handling

2020-10-19 Thread Peter Ujfalusi
Marc, On 30/09/2020 11.33, Marc Zyngier wrote: > On 2020-09-30 08:45, Peter Ujfalusi wrote: >> The DMA (BCDMA/PKTDMA and their rings/flows) events are under the INTA's >> supervision as unmapped events in AM64. > > What does "unmapped event" mean? An event that doesn't require a mapping? > Or an

Re: [PATCH AUTOSEL 5.9 035/111] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)

2020-10-19 Thread Sasha Levin
On Sun, Oct 18, 2020 at 07:40:12PM -0600, David Ahern wrote: On 10/18/20 1:40 PM, Jakub Kicinski wrote: This one got applied a few days ago, and the urgency is low so it may be worth letting it see at least one -rc release ;) agreed Definitely - AUTOSEL patches get extra soaking time before

[PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-19 Thread Martijn de Gouw
When the passed token is longer than 4032 bytes, the remaining part of the token must be copied from the rqstp->rq_arg.pages. But the copy must make sure it happens in a consecutive way. Signed-off-by: Martijn de Gouw --- net/sunrpc/auth_gss/svcauth_gss.c | 27 +-- 1 file

[PATCH v16 4/4] overlayfs: inode_owner_or_capable called during execv

2020-10-19 Thread Mark Salyzyn
From: John Stultz Using old_creds as an indication that we are not overriding the credentials, bypass call to inode_owner_or_capable. This solves a problem with all execv calls being blocked when using the caller's credentials. Signed-off-by: John Stultz Signed-off-by: Mark Salyzyn Fixes: 05a

[PATCH v16 2/4] overlayfs: handle XATTR_NOSECURITY flag for get xattr method

2020-10-19 Thread Mark Salyzyn
Because of the overlayfs getxattr recursion, the incoming inode fails to update the selinux sid resulting in avc denials being reported against a target context of u:object_r:unlabeled:s0. Solution is to respond to the XATTR_NOSECURITY flag in get xattr method that calls the __vfs_getxattr handler

[PATCH v16 1/4] Add flags option to get xattr method paired to __vfs_getxattr

2020-10-19 Thread Mark Salyzyn
Add a flag option to get xattr method that could have a bit flag of XATTR_NOSECURITY passed to it. XATTR_NOSECURITY is generally then set in the __vfs_getxattr path when called by security infrastructure. This handles the case of a union filesystem driver that is being requested by the security l

[PATCH v16 3/4] overlayfs: override_creds=off option bypass creator_cred

2020-10-19 Thread Mark Salyzyn
By default, all access to the upper, lower and work directories is the recorded mounter's MAC and DAC credentials. The incoming accesses are checked against the caller's credentials. If the principles of least privilege are applied, the mounter's credentials might not overlap the credentials of t

[PATCH v15 0/4] overlayfs override_creds=off & nested get xattr fix

2020-10-19 Thread Mark Salyzyn
Mark Salyzyn (3): Add flags option to get xattr method paired to __vfs_getxattr overlayfs: handle XATTR_NOSECURITY flag for get xattr method overlayfs: override_creds=off option bypass creator_cred Mark Salyzyn + John Stultz (1): overlayfs: inode_owner_or_capable called during execv The f

Re: [PATCH v3] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread David Hildenbrand
On 19.10.20 13:50, yanfei...@windriver.com wrote: > From: Yanfei Xu > > There are two 'start_pfn' declared in compact_zone() which have > different meaning. Rename the second one to 'iteration_start_pfn' > to prevent confusion. > > BTW, remove an useless semicolon. > > Signed-off-by: Yanfei Xu

[PATCH] media: v4l2-compat-ioctl32: check for max size

2020-10-19 Thread Defang Bo
Similar to commit("media: v4l2-compat-ioctl32: prevent go past max size"} ,add max size check for count variable. Signed-off-by: Defang Bo --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-compat-io

Re: [PATCH v5 1/5] arm64: Add framework to turn IPI as NMI

2020-10-19 Thread Marc Zyngier
On 2020-10-14 12:12, Sumit Garg wrote: Introduce framework to turn an IPI as NMI using pseudo NMIs. In case a particular platform doesn't support pseudo NMIs, then request IPI as a regular IRQ. The main motivation for this feature is to have an IPI that can be leveraged to invoke NMI functions o

[PATCH] tg3: Avoid NULL pointer dereference in netif_device_attach()

2020-10-19 Thread Defang Bo
Similar to commit<1b0ff89852d7>("tg3: Avoid NULL pointer dereference in tg3_io_error_detected()") This patch avoids NULL pointer dereference add a check for netdev being NULL on tg3_resume(). Signed-off-by: Defang Bo --- drivers/net/ethernet/broadcom/tg3.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH v1 20/29] virtio-mem: nb_sb_per_mb and subblock_size are specific to Sub Block Mode (SBM)

2020-10-19 Thread David Hildenbrand
On 18.10.20 14:41, Wei Yang wrote: > On Fri, Oct 16, 2020 at 03:17:06PM +0200, David Hildenbrand wrote: >> On 16.10.20 10:53, Wei Yang wrote: >>> On Mon, Oct 12, 2020 at 02:53:14PM +0200, David Hildenbrand wrote: Let's rename to "sbs_per_mb" and "sb_size" and move accordingly. Cc: "M

[PATCH] thermal: sun8i: Use bitmap API instead of open code

2020-10-19 Thread Frank Lee
From: Yangtao Li Thw bitmap_* API is the standard way to access data in the bitfield. Signed-off-by: Yangtao Li --- drivers/thermal/sun8i_thermal.c | 35 + 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/

Re: [PATCH v5 3/5] arm64: smp: Allocate and setup IPI as NMI

2020-10-19 Thread Marc Zyngier
On 2020-10-14 12:12, Sumit Garg wrote: Allocate an unused IPI that can be turned as NMI using ipi_nmi framework. This doesn't do any allocation, as far as I can see. It relies on the initial grant from the interrupt controller to be larger than what the kernel currently uses. Also, invoke cor

[PATCH v3] net: mii: Report advertised link capabilities when autonegotiation is off

2020-10-19 Thread Łukasz Stelmach
Unify the set of information returned by mii_ethtool_get_link_ksettings(), mii_ethtool_gset() and phy_ethtool_ksettings_get(). Make the mii_*() functions report advertised settings when autonegotiation if disabled. Suggested-by: Andrew Lunn Signed-off-by: Łukasz Stelmach --- This is the third ve

Re: [PATCH next] iommu: intel: don't dereference iommu_device if IOMMU_API is not built

2020-10-19 Thread Joerg Roedel
On Tue, Oct 13, 2020 at 09:30:55AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Since commit c40c1018 ("iommu/vt-d: Gracefully handle DMAR units > with no supported address widths") dmar.c needs struct iommu_device to > be selected. We can drop this dependency by not dere

Re: [PATCH v5 2/5] irqchip/gic-v3: Enable support for SGIs to act as NMIs

2020-10-19 Thread Marc Zyngier
On 2020-10-14 12:12, Sumit Garg wrote: Add support to handle SGIs as regular NMIs. As SGIs or IPIs defaults to a There is nothing "regular" about NMIs. Drop "or IPIs". s/defaults/default/ special flow handler: handle_percpu_devid_fasteoi_ipi(), so skip NMI handler update in case of SGIs. A

[PATCH] can: mcp251xfd: fix semicolon.cocci warnings

2020-10-19 Thread kernel test robot
From: kernel test robot drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:176:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: f4f77366f21d ("can: mcp251xfd: rename all user facing strings to mcp251xfd") Signed-off-by: kernel tes

drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:176:2-3: Unneeded semicolon

2020-10-19 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 7cf726a59435301046250c42131554d9ccc566b8 commit: f4f77366f21dfd6ac69a902313367d638b328ba1 can: mcp251xfd: rename all user facing strings to mcp251xfd date: 3 weeks ago config: c6x-randconfig-c004-20201019

[PATCH] nfc: Ensure presence of NFC_ATTR_FIRMWARE_NAME attribute in nfc_genl_fw_download()

2020-10-19 Thread Defang Bo
check that the NFC_ATTR_FIRMWARE_NAME attributes are provided by the netlink client prior to accessing them.This prevents potential unhandled NULL pointer dereference exceptions which can be triggered by malicious user-mode programs, if they omit one or both of these attributes. Just similar to c

[PATCH 1/3] powerpc/uaccess: Don't use "m<>" constraint with GCC 4.9

2020-10-19 Thread Christophe Leroy
GCC 4.9 sometimes fails to build with "m<>" constraint in inline assembly. CC lib/iov_iter.o In file included from ./arch/powerpc/include/asm/cmpxchg.h:6:0, from ./arch/powerpc/include/asm/atomic.h:11, from ./include/linux/atomic.h:7, from

[PATCH 3/3] powerpc: Fix pre-update addressing in inline assembly

2020-10-19 Thread Christophe Leroy
In several places, inline assembly uses the "%Un" modifier to enable the use of instruction with pre-update addressing, but the associated "<>" constraint is missing. As mentioned in previous patch, this fails with gcc 4.9, so "<>" can't be used directly. Use UPD_CONSTR macro everywhere %Un modif

Re: LPC 2020 Hackroom Session: summary and next steps for isolated user namespaces

2020-10-19 Thread Giuseppe Scrivano
"Serge E. Hallyn" writes: > On Tue, Oct 13, 2020 at 05:17:36PM +0200, Giuseppe Scrivano wrote: >> "Serge E. Hallyn" writes: >> >> > On Mon, Oct 12, 2020 at 07:05:10PM +0200, Giuseppe Scrivano wrote: >> >> Josh Triplett writes: >> >> >> >> > On Fri, Oct 09, 2020 at 11:26:06PM -0500, Serge E. H

[PATCH 2/3] powerpc: Fix incorrect stw{, ux, u, x} instructions in __set_pte_at

2020-10-19 Thread Christophe Leroy
From: Mathieu Desnoyers The placeholder for instruction selection should use the second argument's operand, which is %1, not %0. This could generate incorrect assembly code if the instruction selection for argument %0 ever differs from argument %1. Fixes: 9bf2b5cdc5fe ("powerpc: Fixes for CONFIG

Re: [PATCH v5 4/5] arm64: kgdb: Round up cpus using IPI as NMI

2020-10-19 Thread Marc Zyngier
On 2020-10-14 12:12, Sumit Garg wrote: arm64 platforms with GICv3 or later supports pseudo NMIs which can be leveraged to round up CPUs which are stuck in hard lockup state with interrupts disabled that wouldn't be possible with a normal IPI. So instead switch to round up CPUs using IPI turned a

Re: [PATCH v5 5/5] arm64: ipi_nmi: Add support for NMI backtrace

2020-10-19 Thread Marc Zyngier
On 2020-10-14 12:12, Sumit Garg wrote: Enable NMI backtrace support on arm64 using IPI turned as an NMI leveraging pseudo NMIs support. It is now possible for users to get a backtrace of a CPU stuck in hard-lockup using magic SYSRQ. Signed-off-by: Sumit Garg --- arch/arm64/include/asm/irq.h |

Re: [PATCH RFC 0/8] kasan: hardware tag-based mode for production use on arm64

2020-10-19 Thread Marco Elver
On Wed, 14 Oct 2020 at 22:44, Andrey Konovalov wrote: [...] > A question to KASAN maintainers: what would be the best way to support the > "off" mode? I see two potential approaches: add a check into each kasan > callback (easier to implement, but we still call kasan callbacks, even > though they

Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2

2020-10-19 Thread Andrew Lunn
On Mon, Oct 19, 2020 at 10:04:08AM +0200, Pali Rohár wrote: > Hello! Gregory, I would like to remind you following patch. Hi Pali Since the merge window is open at the moment, no new patches will be accepted until it closes. You should resend once -rc1 is out. Andrew

<    4   5   6   7   8   9   10   11   12   >