[PATCH v2] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Coly Li
In mmc_queue_setup_discard() the mmc driver queue's discard_granularity might be set as 0 (when card->pref_erase > max_discard) while the mmc device still declares to support discard operation. This is buggy and triggered the following kernel warning message, WARNING: CPU: 0 PID: 135 at __blkdev_i

Re: [PATCH v6 01/17] dt-bindings: mfd: syscon: add some compatible strings for Hisilicon

2020-10-01 Thread Lee Jones
On Wed, 30 Sep 2020, Leizhen (ThunderTown) wrote: > > > On 2020/9/30 15:11, Lee Jones wrote: > > On Wed, 30 Sep 2020, Zhen Lei wrote: > > > >> Add some compatible strings for Hisilicon controllers: > >> hisilicon,hi6220-sramctrl --> Hi6220 SRAM controller > >> hisilicon,pcie-sas-subctrl --> Hi

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-10-01 Thread Tony Lindgren
* Trent Piepho [200930 18:50]: > On Wed, Sep 30, 2020 at 2:47 AM Tony Lindgren wrote: > > > > * Trent Piepho [200930 09:34]: > > > > > > > Where do these flags go? In pinctrl-single,pins? Like: > > > > > > pinctrl-single,pins = ; > > > > > > But PIN_INPUT_PULLUP is a generic flag? Which is t

RE: [Intel-wired-lan] [PATCH] e1000: do not panic on malformed rx_desc

2020-10-01 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of Tong > Zhang > Sent: Tuesday, September 8, 2020 9:23 AM > To: Kirsher, Jeffrey T ; David S. Miller > ; Jakub Kicinski ; intel-wired- > l...@lists.osuosl.org; net...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: ztong0...@gmail.com > Subject: [Intel-wired-

Re: [PATCH] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Adrian Hunter
On 1/10/20 9:29 am, Coly Li wrote: > On 2020/10/1 14:14, Adrian Hunter wrote: >> On 1/10/20 7:36 am, Coly Li wrote: >>> On 2020/10/1 01:23, Adrian Hunter wrote: On 30/09/20 7:08 pm, Coly Li wrote: > In mmc_queue_setup_discard() the mmc driver queue's discard_granularity > might be set

Re: [Intel-wired-lan] [PATCH] e1000: do not panic on malformed rx_desc

2020-10-01 Thread Paul Menzel
Dear Tong, Thank you for your patch. Am 08.09.20 um 18:22 schrieb Tong Zhang: length may be corrupted in rx_desc How can that be? and lead to panic, so check the sanity before passing it to skb_put [ 167.667701] skbuff: skb_over_panic: text:b1e32cc1 len:60224 put:60224 head:

Re: [PATCH] Bluetooth: btqca: Add valid le states quirk

2020-10-01 Thread Marcel Holtmann
Hi Abhishek, > WCN3991 supports connectable advertisements so we need to add the valid > le states quirk so the 'central-peripheral' role is exposed in > userspace. > > Signed-off-by: Abhishek Pandit-Subedi > --- > Example result showing the central-peripheral role correctly. > > localhost # bl

Re: [PATCH v2] pipe: Fix memory leaks in create_pipe_files()

2020-10-01 Thread kernel test robot
umented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Qian-Cai/pipe-Fix-memory-leaks-in-create_pipe_files/20201001-105501 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 60e720931556fc1034d0981460164dcf02697679 conf

Re: [PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet()

2020-10-01 Thread Marcel Holtmann
Hi Anmol, > AMP_MGR is getting derefernced in hci_phy_link_complete_evt(), when called > from hci_event_packet() and there is a possibility, that hcon->amp_mgr may > not be found when accessing after initialization of hcon. > > - net/bluetooth/hci_event.c:4945 > The bug seems to get triggered i

Re: [Intel-wired-lan] [PATCH] e1000: do not panic on malformed rx_desc

2020-10-01 Thread Paul Menzel
Dear Tong, Am 01.10.20 um 09:03 schrieb Paul Menzel: Am 08.09.20 um 18:22 schrieb Tong Zhang: length may be corrupted in rx_desc How can that be? and lead to panic, so check the sanity before passing it to skb_put [  167.667701] skbuff: skb_over_panic: text:b1e32cc1 len:60224 pu

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

2020-10-01 Thread Tudor.Ambarus
On 10/1/20 1:38 AM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Tudor, Hi, Michael, > >>> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c >>> index cc68ea84318e..fd1c36d70a13 100644 >>> --- a/dr

Re: [Linux-kernel-mentees][PATCH] bluetooth: hci_h5: close serdev device and free hu in h5_close

2020-10-01 Thread Marcel Holtmann
Hi Anant, > When h5_close() gets called, the memory allocated for the hu gets > freed only if hu->serdev doesn't exist. This leads to a memory leak. > So when h5_close() is requested, close the serdev device instance and > free the memory allocated to the hu entirely instead. > > Fixes: https://

Re: [PATCH 11/11] soc: ti: k3-socinfo: Add entry for AM64 SoC family

2020-10-01 Thread Vignesh Raghavendra
On 10/1/20 12:12 PM, Peter Ujfalusi wrote: > Hi Grygorii, > > On 30/09/2020 16.56, Grygorii Strashko wrote: >> >> >> On 28/09/2020 11:34, Peter Ujfalusi wrote: >>> It's JTAG PARTNO is 0xBB38. >>> >>> Signed-off-by: Peter Ujfalusi >>> --- >>>   drivers/soc/ti/k3-socinfo.c | 1 + >>>   1 file cha

[PATCH] phy: qcom-qmp: initialize the pointer to NULL

2020-10-01 Thread Vinod Koul
Smatch complains: drivers/phy/qualcomm/phy-qcom-qmp.c:3899 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_cfg'. drivers/phy/qualcomm/phy-qcom-qmp.c:3900 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_serdes'. drivers/phy/qualcomm/phy-qcom-qmp.c:3902 qcom_qmp_phy_probe() error: uninit

Re: [PATCH v2] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Adrian Hunter
On 1/10/20 9:59 am, Coly Li wrote: > In mmc_queue_setup_discard() the mmc driver queue's discard_granularity > might be set as 0 (when card->pref_erase > max_discard) while the mmc > device still declares to support discard operation. This is buggy and > triggered the following kernel warning messa

Re: [PATCH v3] Bluetooth: Check for encryption key size on connect

2020-10-01 Thread Marcel Holtmann
Hi Archie, > When receiving connection, we only check whether the link has been > encrypted, but not the encryption key size of the link. > > This patch adds check for encryption key size, and reject L2CAP > connection which size is below the specified thre

RE: [PATCH net] ravb: Fix bit fields checking in ravb_hwtstamp_get()

2020-10-01 Thread Andrew Gabbasov
Hi Sergei, > -Original Message- > From: Gabbasov, Andrew > Sent: Wednesday, September 30, 2020 10:21 PM > To: linux-renesas-...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Sergei Shtylyov ; David > S. Miller ; geert+rene...@glider.be; Julia Lawall > ; Behme, D

Re: [Linux-kernel-mentees][PATCH] bluetooth: hci_h5: close serdev device and free hu in h5_close

2020-10-01 Thread Anant Thazhemadam
On 01/10/20 12:38 pm, Marcel Holtmann wrote: > Hi Anant, > >> When h5_close() gets called, the memory allocated for the hu gets >> freed only if hu->serdev doesn't exist. This leads to a memory leak. >> So when h5_close() is requested, close the serdev device instance and >> free the memory allo

Re: [PATCH printk 3/5] printk: use buffer pool for sprint buffers

2020-10-01 Thread Rasmus Villemoes
On 30/09/2020 15.35, Steven Rostedt wrote: > On Wed, 30 Sep 2020 10:06:24 +0200 > Rasmus Villemoes wrote: > >> True. But remember that printk is called from _everywhere_, with all >> sorts of locks held and/or preemption disabled or whatnot, and every >> cycle spent in printk makes those windows

Re: [Linux-kernel-mentees] [PATCH] Fix uninit-value in hci_chan_lookup_handle

2020-10-01 Thread Anant Thazhemadam
On 26/09/20 1:16 pm, Marcel Holtmann wrote: > Hi Anant, > >> When the amount of data stored in the location corresponding to >> iov_iter *from is less then 4, some data seems to go uninitialized. >> >> Updating this condition accordingly, makes sense both intuitively and >> logically as well, si

Re: [PATCH v2 12/12] mm/filemap: Return only head pages from find_get_entries

2020-10-01 Thread Jan Kara
On Wed 30-09-20 18:23:21, Matthew Wilcox wrote: > On Wed, Sep 30, 2020 at 07:08:07PM +0200, Jan Kara wrote: > > On Wed 30-09-20 13:36:37, Matthew Wilcox wrote: > > > On Wed, Sep 30, 2020 at 02:15:12PM +0200, Jan Kara wrote: > > > > On Mon 14-09-20 14:00:42, Matthew Wilcox (Oracle) wrote: > > > > >

Re: [PATCH v2] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Coly Li
On 2020/10/1 15:13, Adrian Hunter wrote: > On 1/10/20 9:59 am, Coly Li wrote: >> In mmc_queue_setup_discard() the mmc driver queue's discard_granularity >> might be set as 0 (when card->pref_erase > max_discard) while the mmc >> device still declares to support discard operation. This is buggy and

Re: [PATCH tip/core/rcu 11/15] drm/i915: Cleanup PREEMPT_COUNT leftovers

2020-10-01 Thread Joonas Lahtinen
Quoting paul...@kernel.org (2020-09-29 02:30:58) > From: Thomas Gleixner > > CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be > removed. Cleanup the leftovers before doing so. Change looks fine: Reviewed-by: Joonas Lahtinen Are you looking for us to merge or merge through anoth

Re: [PATCH] sched/fair: tweak pick_next_entity

2020-10-01 Thread Vincent Guittot
On Wed, 30 Sep 2020 at 19:35, Peter Oskolkov wrote: > > Currently, pick_next_entity(...) has the following structure > (simplified): > > [...] > if (last_buddy_ok()) > result = last_buddy; > if (next_buddy_ok()) > result = next_buddy; > [...] > > The intended behavior is to prefer next buddy o

[PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Coly Li
In mmc_queue_setup_discard() the mmc driver queue's discard_granularity might be set as 0 (when card->pref_erase > max_discard) while the mmc device still declares to support discard operation. This is buggy and triggered the following kernel warning message, WARNING: CPU: 0 PID: 135 at __blkdev_i

Re: [PATCH v14 01/15] mtd: spi-nor: core: use EOPNOTSUPP instead of ENOTSUPP

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > ENOTSUPP is not a SUSV4 error code. Using EOPNOTSUPP is preferred > in its stead. > > Reviewed-by: Tudor Ambarus The R-b tag should be after your S-o-b.

Re: [PATCH v14 02/15] mtd: spi-nor: add spi_nor_controller_ops_{read_reg,write_reg,erase}()

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > They are thin wrappers around > nor->controller_ops->{read_reg,write_reg,erase}(). In a future commit > DTR support will be added. These ops can not be supp

Re: [PATCH] ARM: dts: exynos: Add a placeholder for a MAC address

2020-10-01 Thread Krzysztof Kozlowski
On Wed, Sep 30, 2020 at 04:31:51PM +0200, Łukasz Stelmach wrote: > Add a placeholder for a MAC address. A bootloader may fill it > to set the MAC address and override EEPROM settings. > > Signed-off-by: Łukasz Stelmach > --- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 18 ++ >

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-01 Thread Ahmad Fatoum
Hello Krzysztof, On 9/30/20 9:01 PM, Krzysztof Kozlowski wrote: > There are four flavors of TechNexion PICO-IMX6 boards. They have their > own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. > They also have their own bindings so adjust the compatibles to match the > bindings. >

Re: [PATCH] phy: qcom-qmp: initialize the pointer to NULL

2020-10-01 Thread Stephen Boyd
Quoting Vinod Koul (2020-10-01 00:09:11) > Smatch complains: > drivers/phy/qualcomm/phy-qcom-qmp.c:3899 qcom_qmp_phy_probe() error: > uninitialized symbol 'dp_cfg'. > drivers/phy/qualcomm/phy-qcom-qmp.c:3900 qcom_qmp_phy_probe() error: > uninitialized symbol 'dp_serdes'. > drivers/phy/qualcomm/ph

Re: [PATCH bpf-next v2 2/4] selftests: bpf: Add helper to compare socket cookies

2020-10-01 Thread Alexei Starovoitov
On Wed, Sep 30, 2020 at 10:28:33AM +0100, Lorenz Bauer wrote: > On Tue, 29 Sep 2020 at 16:48, Alexei Starovoitov > wrote: > > ... > > > There was a warning. I noticed it while applying and fixed it up. > > Lorenz, please upgrade your compiler. This is not the first time such > > warning has been

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-01 Thread Daniel Vetter
On Wed, Sep 30, 2020 at 11:16 PM Rob Clark wrote: > > From: Rob Clark > > The android userspace treats the display pipeline as a realtime problem. > And arguably, if your goal is to not miss frame deadlines (ie. vblank), > it is. (See https://lwn.net/Articles/809545/ for the best explaination >

Re: [PATCH 1/5] kselftests: vm: Add mremap tests

2020-10-01 Thread John Hubbard
On 9/30/20 3:21 PM, Kalesh Singh wrote: Test mremap on regions of various sizes and alignments and validate data after remapping. Also provide total time for remapping the region which is useful for performance comparison of the mremap optimizations that move pages at the PMD/PUD levels if HAVE_M

[PATCH 1/2] RDMA/rtrs: remove unnecessary argument dir of rtrs_iu_free

2020-10-01 Thread Gioh Kim
From: Gioh Kim The direction of DMA operation is already in the rtrs_iu. Signed-off-by: Gioh Kim --- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 14 ++ drivers/infiniband/ulp/rtrs/rtrs-pri.h | 3 +-- drivers/infiniband/ulp/rtrs/rtrs-srv.c | 14 ++ drivers/infiniband/ulp/r

[PATCH 3/4] media: vidtv: avoid data copy when initializing the multiplexer

2020-10-01 Thread Mauro Carvalho Chehab
Initialize the fields of the arguments directly when declaring it, and pass the args as a pointer, instead of copying them. Signed-off-by: Mauro Carvalho Chehab --- .../media/test-drivers/vidtv/vidtv_bridge.c | 24 ++- drivers/media/test-drivers/vidtv/vidtv_mux.c | 24

[PATCH 1/4] media: vidtv: reorganize includes

2020-10-01 Thread Mauro Carvalho Chehab
- Place the includes on alphabetical order; - get rid of asm/byteorder.h; - add bug.h at vidtv_s302m.c, as it is needed by inux/fixp-arith.h Signed-off-by: Mauro Carvalho Chehab --- .../media/test-drivers/vidtv/vidtv_bridge.c | 8 +++ .../media/test-drivers/vidtv/vidtv_bridge.h | 2 +

Re: [PATCH next v2 1/2] printk: avoid and/or handle record truncation

2020-10-01 Thread Petr Mladek
On Wed 2020-09-30 08:25:24, Joe Perches wrote: > On Wed, 2020-09-30 at 11:07 +0206, John Ogness wrote: > > If a reader provides a buffer that is smaller than the message text, > > the @text_len field of @info will have a value larger than the buffer > > size. If readers blindly read @text_len bytes

[PATCH 4/4] media: vidtv: avoid copying data for PES structs

2020-10-01 Thread Mauro Carvalho Chehab
Minimize the number of data copies and initialization at the code, passing them as pointers instead of duplicating the data. The only case where we're keeping the data copy is at vidtv_pes_write_h(), as it needs a copy of the passed arguments. On such case, we're being more explicit. Signed-off-b

[PATCH 2/2] RDMA/rtrs: check before free

2020-10-01 Thread Gioh Kim
From: Gioh Kim If rtrs_iu_alloc failed to allocate buffer or map dma, there are some allocated addresses and some NULL addresses in the array. rtrs_iu_free should check data before free. Signed-off-by: Gioh Kim --- drivers/infiniband/ulp/rtrs/rtrs.c | 8 ++-- 1 file changed, 6 insertions(+

[PATCH 2/4] media: vidtv: add error checks

2020-10-01 Thread Mauro Carvalho Chehab
Currently, there are not checks if something gets bad during memory allocation: it will simply use NULL pointers and crash. Add error path at the logic which allocates memory for the MPEG-TS generator code, propagating the errors up to the vidtv_bridge. Now, if something wents bad, start_streaming

Re: [PATCH v6 0/5] Add shared workqueue support for idxd driver

2020-10-01 Thread Borislav Petkov
On Thu, Oct 01, 2020 at 09:59:08AM +0530, Vinod Koul wrote: > I was out for last few days, so haven't checked on this yet, but given > that we are very close to merge widow I fear it is bit late to merge > this late. There is time because we will have -rc8 so you have an additional week. > I will

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-01 Thread Krzysztof Kozlowski
On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote: > Hello Krzysztof, > > On 9/30/20 9:01 PM, Krzysztof Kozlowski wrote: > > There are four flavors of TechNexion PICO-IMX6 boards. They have their > > own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. > > They also have

Re: [PATCH v2] pinctrl: single: fix pinctrl_spec.args_count bounds check

2020-10-01 Thread Tony Lindgren
* Drew Fustini [200930 17:51]: > The property #pinctrl-cells can either be 1 or 2: > > - if #pinctrl-cells = <1>, then pinctrl_spec.args_count = 2 > - if #pinctrl-cells = <2>, then pinctrl_spec.args_count = 3 > > All other values of pinctrl_spec.args_count are incorrect. This fix > checks the u

Re: [PATCH] sched/fair: tweak pick_next_entity

2020-10-01 Thread Peter Zijlstra
On Thu, Oct 01, 2020 at 09:17:43AM +0200, Vincent Guittot wrote: > On Wed, 30 Sep 2020 at 19:35, Peter Oskolkov wrote: > > > > Currently, pick_next_entity(...) has the following structure > > (simplified): > > > > [...] > > if (last_buddy_ok()) > > result = last_buddy; > > if (next_buddy_ok()) >

[Linux-kernel-mentees][PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address

2020-10-01 Thread Anant Thazhemadam
When get_registers() fails (which happens when usb_control_msg() fails) in set_ethernet_addr(), the uninitialized value of node_id gets copied as the address. Checking for the return values appropriately, and handling the case wherein set_ethernet_addr() fails like this, helps in avoiding the mac

Re: [PATCH v14 01/15] mtd: spi-nor: core: use EOPNOTSUPP instead of ENOTSUPP

2020-10-01 Thread Pratyush Yadav
On 01/10/20 07:19AM, tudor.amba...@microchip.com wrote: > On 9/30/20 9:57 PM, Pratyush Yadav wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > ENOTSUPP is not a SUSV4 error code. Using EOPNOTSUPP is preferred > > in its stead. > > >

Re: [PATCH] phy: qcom-qmp: initialize the pointer to NULL

2020-10-01 Thread Vinod Koul
On 01-10-20, 00:23, Stephen Boyd wrote: > Quoting Vinod Koul (2020-10-01 00:09:11) > > Smatch complains: > > drivers/phy/qualcomm/phy-qcom-qmp.c:3899 qcom_qmp_phy_probe() error: > > uninitialized symbol 'dp_cfg'. > > drivers/phy/qualcomm/phy-qcom-qmp.c:3900 qcom_qmp_phy_probe() error: > > uniniti

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

2020-10-01 Thread Michael Walle
Hi Tudor, Am 2020-10-01 09:07, schrieb tudor.amba...@microchip.com: diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index cc68ea84318e..fd1c36d70a13 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2916,20 +2916,38 @@ static int spi_nor_quad_enabl

[gustavoars-linux:testing/stackdepot] BUILD SUCCESS 75cf7f288660efb0b85e4b699cc9e55ae8c42360

2020-10-01 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/stackdepot branch HEAD: 75cf7f288660efb0b85e4b699cc9e55ae8c42360 lib/stackdepot.c: Replace one-element array with flexible-array member elapsed time: 721m configs tested: 147 configs skipped: 3 The fol

Re: [PATCH next v2 1/2] printk: avoid and/or handle record truncation

2020-10-01 Thread Joe Perches
On Thu, 2020-10-01 at 09:26 +0200, Petr Mladek wrote: > On Wed 2020-09-30 08:25:24, Joe Perches wrote: > > On Wed, 2020-09-30 at 11:07 +0206, John Ogness wrote: > > > If a reader provides a buffer that is smaller than the message text, > > > the @text_len field of @info will have a value larger tha

Re: [PATCH 1/3] media: uapi: mpeg2: Cleanup flags

2020-10-01 Thread kernel test robot
Hi Ezequiel, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on linus/master v5.9-rc7 next-20200930] [cannot apply to sunxi/sunxi/for-next linux/master] [If your patch is applied to the wrong git tree, kindly drop us a no

[PATCH 1/2] PCI: dwc: armada-8k driver needs OF support

2020-10-01 Thread Thomas Petazzoni
Fixes the following build warning when CONFIG_OF is disabled: drivers/pci/controller/dwc/pcie-armada8k.c:344:34: warning: ‘armada8k_pcie_of_match’ defined but not used [-Wunused-const-variable=] 344 | static const struct of_device_id armada8k_pcie_of_match[] = { |

[PATCH 2/2] PCI: dwc: spear13xx driver needs OF

2020-10-01 Thread Thomas Petazzoni
Fixes the following build warning when CONFIG_OF is disabled: drivers/pci/controller/dwc/pcie-spear13xx.c:297:34: warning: ‘spear13xx_pcie_of_match’ defined but not used [-Wunused-const-variable=] 297 | static const struct of_device_id spear13xx_pcie_of_match[] = { |

[PATCH v2] serial: max310x: rework RX interrupt handling

2020-10-01 Thread Thomas Petazzoni
Currently, the RX interrupt logic uses the RXEMPTY interrupt, with the RXEMPTYINV bit set, which means we get an RX interrupt as soon as the RX FIFO is non-empty. However, with the MAX310X having a FIFO of 128 bytes, this makes very poor use of the FIFO: we trigger an interrupt as soon as the RX F

Re: [PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet()

2020-10-01 Thread Anmol Karn
On Thu, Oct 01, 2020 at 09:06:42AM +0200, Marcel Holtmann wrote: > Hi Anmol, > > > AMP_MGR is getting derefernced in hci_phy_link_complete_evt(), when called > > from hci_event_packet() and there is a possibility, that hcon->amp_mgr may > > not be found when accessing after initialization of hco

Re: For review: seccomp_user_notif(2) manual page

2020-10-01 Thread Michael Kerrisk (man-pages)
On 10/1/20 1:03 AM, Tycho Andersen wrote: > On Wed, Sep 30, 2020 at 10:34:51PM +0200, Michael Kerrisk (man-pages) wrote: >> Hi Tycho, >> >> Thanks for taking time to look at the page! >> >> On 9/30/20 5:03 PM, Tycho Andersen wrote: >>> On Wed, Sep 30, 2020 at 01:07:38PM +0200, Michael Kerrisk (man-

Re: [PATCH v14 05/15] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > This table is indication that the flash is xSPI compliant and hence > supports octal DTR mode. Extract information like the fast read opcode, > dummy cycles

Re: [PATCH v14 01/15] mtd: spi-nor: core: use EOPNOTSUPP instead of ENOTSUPP

2020-10-01 Thread Miquel Raynal
Hello, Pratyush Yadav wrote on Thu, 1 Oct 2020 13:04:27 +0530: > On 01/10/20 07:19AM, tudor.amba...@microchip.com wrote: > > On 9/30/20 9:57 PM, Pratyush Yadav wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > the content is safe It seems that your mai

Re: For review: seccomp_user_notif(2) manual page

2020-10-01 Thread Michael Kerrisk (man-pages)
On 10/1/20 3:52 AM, Jann Horn wrote: [...] > I guess this is a nice point in favor of Michael's usual complaint > that if there are no man pages for a feature by the time the feature > lands upstream, there's a higher chance that the UAPI will suck > forever... Thanks for saving me the trouble o

Re: [PATCH v14 06/15] mtd: spi-nor: core: use dummy cycle and address width info from SFDP

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > The xSPI Profile 1.0 table specifies how many dummy cycles and address > bytes are needed for the Read Status Register command in octal DTR mode. > Use that

Re: [PATCH v14 07/15] mtd: spi-nor: core: do 2 byte reads for SR and FSR in DTR mode

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Some controllers, like the cadence qspi controller, have trouble reading > only 1 byte in DTR mode. So, do 2 byte reads for SR and FSR commands in > DTR mod

[PATCH v9 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-10-01 Thread Coly Li
This series was original by a bug fix in nvme-over-tcp driver which only checked whether a page was allocated from slab allcoator, but forgot to check its page_count: The page handled by sendpage should be neither a Slab page nor 0 page_count page. As Sagi Grimberg suggested, the original fix is r

[PATCH v9 1/7] net: introduce helper sendpage_ok() in include/linux/net.h

2020-10-01 Thread Coly Li
The original problem was from nvme-over-tcp code, who mistakenly uses kernel_sendpage() to send pages allocated by __get_free_pages() without __GFP_COMP flag. Such pages don't have refcount (page_count is 0) on tail pages, sending them by kernel_sendpage() may trigger a kernel panic from a corrupte

Re: [PATCH RFT/RFC v2 28/47] staging: media: zoran: convert mdelay to udelay

2020-10-01 Thread Mauro Carvalho Chehab
Em Fri, 25 Sep 2020 18:30:38 + Corentin Labbe escreveu: > As asked by checkpath, let's use udelay. > > Signed-off-by: Corentin Labbe > --- > drivers/staging/media/zoran/zoran_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/zoran/

[PATCH v9 2/7] net: add WARN_ONCE in kernel_sendpage() for improper zero-copy send

2020-10-01 Thread Coly Li
If a page sent into kernel_sendpage() is a slab page or it doesn't have ref_count, this page is improper to send by the zero copy sendpage() method. Otherwise such page might be unexpected released in network code path and causes impredictable panic due to kernel memory management data structure co

[PATCH v9 4/7] tcp: use sendpage_ok() to detect misused .sendpage

2020-10-01 Thread Coly Li
commit a10674bf2406 ("tcp: detecting the misuse of .sendpage for Slab objects") adds the checks for Slab pages, but the pages don't have page_count are still missing from the check. Network layer's sendpage method is not designed to send page_count 0 pages neither, therefore both PageSlab() and pa

Re: [PATCH 1/3] mfd: intel_pmt: Add OOBMSM device ID

2020-10-01 Thread Lee Jones
On Wed, 30 Sep 2020, David E. Box wrote: > On Wed, 2020-09-30 at 08:12 +0100, Lee Jones wrote: > > On Tue, 29 Sep 2020, David E. Box wrote: > > > > > On Tue, 2020-09-29 at 10:51 +0100, Lee Jones wrote: > > > > On Fri, 11 Sep 2020, David E. Box wrote: > > > > > > > > > Add Out of Band Management

[PATCH v9 5/7] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()

2020-10-01 Thread Coly Li
In _drbd_send_page() a page is checked by following code before sending it by kernel_sendpage(), (page_count(page) < 1) || PageSlab(page) If the check is true, this page won't be send by kernel_sendpage() and handled by sock_no_sendpage(). This kind of check is exactly what macro sendpage_

[PATCH v9 7/7] libceph: use sendpage_ok() in ceph_tcp_sendpage()

2020-10-01 Thread Coly Li
In libceph, ceph_tcp_sendpage() does the following checks before handle the page by network layer's zero copy sendpage method, if (page_count(page) >= 1 && !PageSlab(page)) This check is exactly what sendpage_ok() does. This patch replace the open coded checks by sendpage_ok() as a code cl

[PATCH v9 6/7] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()

2020-10-01 Thread Coly Li
In iscsci driver, iscsi_tcp_segment_map() uses the following code to check whether the page should or not be handled by sendpage: if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg))) The "page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)" part is to make sure the page can b

[PATCH v9 3/7] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()

2020-10-01 Thread Coly Li
Currently nvme_tcp_try_send_data() doesn't use kernel_sendpage() to send slab pages. But for pages allocated by __get_free_pages() without __GFP_COMP, which also have refcount as 0, they are still sent by kernel_sendpage() to remote end, this is problematic. The new introduced helper sendpage_ok()

Re: [PATCH next v2 1/2] printk: avoid and/or handle record truncation

2020-10-01 Thread Petr Mladek
On Thu 2020-10-01 00:39:31, Joe Perches wrote: > On Thu, 2020-10-01 at 09:26 +0200, Petr Mladek wrote: > > On Wed 2020-09-30 08:25:24, Joe Perches wrote: > > > On Wed, 2020-09-30 at 11:07 +0206, John Ogness wrote: > > > > If a reader provides a buffer that is smaller than the message text, > > > >

[PATCH] kbuild: doc: describe proper script invocation

2020-10-01 Thread Lukas Bulwahn
During an investigation to fix up the execute bits of scripts in the kernel repository, Andrew Morton and Kees Cook pointed out that the execute bit should not matter, and that build scripts cannot rely on that. Kees could not point to any documentation, though. Masahiro Yamada explained the conve

Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-10-01 Thread Linus Walleij
On Wed, Sep 30, 2020 at 6:33 PM Sean Wang wrote: > On Wed, Sep 30, 2020 at 1:47 AM Linus Walleij > wrote: > > On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote: > > > > > v2 seems the same with v1 or I was missing something. > > > > > > I just thought we call devm_ioremap_release to explicitly to

Re: [PATCH v3 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev

2020-10-01 Thread Thierry Reding
On Thu, Oct 01, 2020 at 05:11:30AM +0300, Dmitry Osipenko wrote: > 30.09.2020 19:47, Thierry Reding пишет: > > On Wed, Sep 30, 2020 at 07:25:41PM +0300, Dmitry Osipenko wrote: > >> 30.09.2020 19:06, Thierry Reding пишет: > >>> On Wed, Sep 30, 2020 at 06:36:52PM +0300, Dmitry Osipenko wrote: >

Re: [PATCH printk 3/5] printk: use buffer pool for sprint buffers

2020-10-01 Thread Petr Mladek
On Thu 2020-10-01 09:15:39, Rasmus Villemoes wrote: > On 30/09/2020 15.35, Steven Rostedt wrote: > > On Wed, 30 Sep 2020 10:06:24 +0200 > > Rasmus Villemoes wrote: > > > >> True. But remember that printk is called from _everywhere_, with all > >> sorts of locks held and/or preemption disabled or

Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-10-01 Thread Enric Balletbo i Serra
Hi, On 1/10/20 9:58, Linus Walleij wrote: > On Wed, Sep 30, 2020 at 6:33 PM Sean Wang wrote: >> On Wed, Sep 30, 2020 at 1:47 AM Linus Walleij >> wrote: >>> On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote: >>> v2 seems the same with v1 or I was missing something. I just thought w

Re: [PATCH v3 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev

2020-10-01 Thread Thierry Reding
On Wed, Sep 30, 2020 at 07:29:12PM +0300, Dmitry Osipenko wrote: > ... > >> Secondly, I'm already about to use the new tegra_get_memory_controller() > >> API for all the T20/30/124/210 EMC and devfreq drivers. > > > > Also, this really proves the point I was trying to make about how this > > is go

Re: [PATCH v2] pinctrl: single: fix pinctrl_spec.args_count bounds check

2020-10-01 Thread Linus Walleij
On Wed, Sep 30, 2020 at 7:51 PM Drew Fustini wrote: > The property #pinctrl-cells can either be 1 or 2: > > - if #pinctrl-cells = <1>, then pinctrl_spec.args_count = 2 > - if #pinctrl-cells = <2>, then pinctrl_spec.args_count = 3 > > All other values of pinctrl_spec.args_count are incorrect. Thi

Re: [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2

2020-10-01 Thread Linus Walleij
On Mon, Sep 14, 2020 at 1:04 AM Drew Fustini wrote: > The debug output in pcs_parse_one_pinctrl_entry() needs to be updated > to print the correct pinctrl register value when #pinctrl-cells is 2. > > Fixes: a1339541 ("pinctrl: single: parse #pinctrl-cells = 2") > Reported-by: Trent Piepho >

[PATCH v15 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC

2020-10-01 Thread Ramuthevar,Vadivel MuruganX
From: Ramuthevar Vadivel Murugan Add YAML file for dt-bindings to support NAND Flash Controller on Intel's Lightning Mountain SoC. Signed-off-by: Ramuthevar Vadivel Murugan Reviewed-by: Rob Herring --- .../devicetree/bindings/mtd/intel,lgm-nand.yaml| 99 ++ 1 file cha

[PATCH v15 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC

2020-10-01 Thread Ramuthevar,Vadivel MuruganX
From: Ramuthevar Vadivel Murugan This patch adds the new IP of Nand Flash Controller(NFC) support on Intel's Lightning Mountain(LGM) SoC. DMA is used for burst data transfer operation, also DMA HW supports aligned 32bit memory address and aligned data access by default. DMA burst of 8 supported.

[PATCH v15 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC

2020-10-01 Thread Ramuthevar,Vadivel MuruganX
This patch adds the new IP of Nand Flash Controller(NFC) support on Intel's Lightning Mountain(LGM) SoC. DMA is used for burst data transfer operation, also DMA HW supports aligned 32bit memory address and aligned data access by default. DMA burst of 8 supported. Data register used to support the

Re: [PATCH] ARM: dts: am33xx: modify AM33XX_IOPAD for #pinctrl-cells = 2

2020-10-01 Thread Linus Walleij
On Tue, Sep 22, 2020 at 12:57 AM Drew Fustini wrote: > Modify the AM33XX_IOPAD macro so that it works now that #pinctrl-cells = > <2>. The third parameter is just a zero and the pinctrl-single driver > will just OR this with the second parameter so it has no actual effect. > > There are no longer

Re: [PATCH v14 08/15] mtd: spi-nor: core: enable octal DTR mode when possible

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Allow flashes to specify a hook to enable octal DTR mode. Use this hook > whenever possible to get optimal transfer speeds. > > Signed-off-by: Pratyush Yad

Re: [PATCH] ARM: dts: am33xx: modify AM33XX_IOPAD for #pinctrl-cells = 2

2020-10-01 Thread Tony Lindgren
* Linus Walleij [201001 08:08]: > On Tue, Sep 22, 2020 at 12:57 AM Drew Fustini wrote: > > > Modify the AM33XX_IOPAD macro so that it works now that #pinctrl-cells = > > <2>. The third parameter is just a zero and the pinctrl-single driver > > will just OR this with the second parameter so it ha

Re: [PATCH][next] mtd: rawnand: Replace one-element array with flexible-array member

2020-10-01 Thread Miquel Raynal
Hi Jann, Jann Horn wrote on Thu, 1 Oct 2020 00:32:24 +0200: > On Wed, Sep 30, 2020 at 11:30 PM Gustavo A. R. Silva > wrote: > > On Wed, Sep 30, 2020 at 11:10:43PM +0200, Jann Horn wrote: > > > On Wed, Sep 30, 2020 at 11:02 PM Gustavo A. R. Silva > > > wrote: > > > > There is a regular need

[tip: timers/core] clocksource/drivers/mps2-timer: Use semicolons rather than commas to separate statements

2020-10-01 Thread tip-bot2 for Julia Lawall
The following commit has been merged into the timers/core branch of tip: Commit-ID: 0d555b3ac49b40f94c270681b697d45dcae9faa6 Gitweb: https://git.kernel.org/tip/0d555b3ac49b40f94c270681b697d45dcae9faa6 Author:Julia Lawall AuthorDate:Sun, 27 Sep 2020 21:12:21 +02:00 Committe

Re: [PATCH v6 0/6] irqchip: qcom: pdc: Introduce irq_set_wake call

2020-10-01 Thread Stephen Boyd
Quoting Maulik Shah (2020-09-27 21:31:58) > Changes in v6: > - Update commit message more descriptive in v5 patch 1 > - Symmetrically enable/disable wakeirqs during suspend/resume in v5 patch 3 > - Include Acked-by and Reviewed-by tags from v5 series > Thanks. I tested this series and it is worki

Re: [PATCH v6 5/6] mm: secretmem: use PMD-size pages to amortize direct map fragmentation

2020-10-01 Thread Mike Rapoport
On Wed, Sep 30, 2020 at 04:09:28PM +0100, Matthew Wilcox wrote: > On Wed, Sep 30, 2020 at 01:27:45PM +0300, Mike Rapoport wrote: > > On Tue, Sep 29, 2020 at 05:15:52PM +0200, Peter Zijlstra wrote: > > > On Tue, Sep 29, 2020 at 05:58:13PM +0300, Mike Rapoport wrote: > > > > On Tue, Sep 29, 2020 at 0

Re: [PATCH v3 4/5] arm64: dts: qcom: sc7180: Use pdc interrupts for USB instead of GIC interrupts

2020-10-01 Thread Sergei Shtylyov
On 01.10.2020 4:05, Stephen Boyd wrote: [...] Using pdc interrupts for USB instead of GIC interrupts to support wake up in case xo shutdown. s/xo/of/? No it is xo. If anything it could be capitalized because it's the pin name and usually stands for "crystal oscillator". In this cas

Re: [PATCH -next for tip:x86/pti] x86/tlb: drop unneeded local vars in enable_l1d_flush_for_task()

2020-10-01 Thread Thomas Gleixner
On Thu, Oct 01 2020 at 10:48, Balbir Singh wrote: > On 1/10/20 9:49 am, Singh, Balbir wrote: >> >> +static void l1d_flush_kill(struct callback_head *ch) >> +{ >> +clear_ti_thread_flag(¤t->thread_info, TIF_SPEC_L1D_FLUSH); >> +force_signal(SIGBUS); >> +} >> + >> void switch_mm(struct mm_s

Re: [PATCH v14 01/15] mtd: spi-nor: core: use EOPNOTSUPP instead of ENOTSUPP

2020-10-01 Thread Tudor.Ambarus
On 10/1/20 10:50 AM, Miquel Raynal wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > It seems that your mailer/server introduced that line automatically, > can you do something to avoid it? > I don't know any plugin that removes tags au

Re: [PATCH v14 03/15] mtd: spi-nor: add support for DTR protocol

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Double Transfer Rate (DTR) is SPI protocol in which data is transferred > on each clock edge as opposed to on each clock cycle. Make > framework-level chang

Re: [PATCH -next for tip:x86/pti] x86/tlb: drop unneeded local vars in enable_l1d_flush_for_task()

2020-10-01 Thread Peter Zijlstra
Your MUA is having trouble wrapping text at 78 chars. On Thu, Oct 01, 2020 at 09:49:30AM +1000, Singh, Balbir wrote: > So this is the change I am playing with, I don't like the idea of > killing the task, but it's better than silently not flushing, I guess > system administrators will learn wit

Re: [PATCH v14 10/15] mtd: spi-nor: Parse SFDP SCCR Map

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > From: Tudor Ambarus > > Parse just the 22nd dword and look for the 'DTR Octal Mode Enable > Volatile bit'. > > SPI_NOR_IO_MODE_EN_VOLATILE should be set

Re: [PATCH v14 11/15] mtd: spi-nor: sfdp: detect Soft Reset sequence support from BFPT

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > A Soft Reset sequence will return the flash to Power-on-Reset (POR) > state. It consists of two commands: Soft Reset Enable and Soft Reset. > Find out if th

Re: [PATCH v14 12/15] mtd: spi-nor: core: perform a Soft Reset on shutdown

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Perform a Soft Reset on shutdown on flashes that support it so that the > flash can be reset to its initial state and any configurations made by > spi-nor (

Re: [PATCH tip/core/rcu 11/15] drm/i915: Cleanup PREEMPT_COUNT leftovers

2020-10-01 Thread Thomas Gleixner
On Thu, Oct 01 2020 at 10:17, Joonas Lahtinen wrote: > Quoting paul...@kernel.org (2020-09-29 02:30:58) >> CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be >> removed. Cleanup the leftovers before doing so. > > Change looks fine: > > Reviewed-by: Joonas Lahtinen > > Are you looking

Re: [PATCH v14 13/15] mtd: spi-nor: core: disable Octal DTR mode on suspend.

2020-10-01 Thread Tudor.Ambarus
On 9/30/20 9:57 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On resume, the init procedure will be run that will re-enable it. > > Signed-off-by: Pratyush Yadav Reviewed-by: Tudor Ambarus > --- > drivers/mtd/spi

  1   2   3   4   5   6   7   8   9   10   >