Re: [PATCH 1/9] lib: string_helpers: provide kfree_strarray()

2020-09-25 Thread Andy Shevchenko
On Fri, Sep 25, 2020 at 01:32:01PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 25, 2020 at 11:01 AM Andy Shevchenko > wrote: > > > > On Thu, Sep 24, 2020 at 01:38:34PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > There's a common pattern of dynamically allocat

Re: [PATCH 8/9] gpio: mockup: use the generic 'gpio-line-names' property

2020-09-25 Thread Andy Shevchenko
On Fri, Sep 25, 2020 at 01:40:10PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 25, 2020 at 11:03 AM Andy Shevchenko > wrote: > > On Thu, Sep 24, 2020 at 01:38:41PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > GPIO line names are currently created by the driver

Re: [PATCH 2/3] ASoC: cs4234: Add support for Cirrus Logic CS4234 codec

2020-09-25 Thread Mark Brown
On Fri, Sep 25, 2020 at 11:59:07AM +0100, Richard Fitzgerald wrote: This looks very good, a couple of small nits below which should be easy to address: > @@ -282,7 +283,6 @@ config SND_SOC_ALL_CODECS > uses them is also built since they are only usable with a machine > driver. Se

[PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST

2020-09-25 Thread Randy Dunlap
by: Randy Dunlap Cc: Kevin Hilman Cc: linux-amlo...@lists.infradead.org Cc: linux-arm-ker...@lists.infradead.org Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Cc: Krzysztof Kozlowski --- drivers/mmc/host/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux-next-20200925.orig/drivers/mmc/hos

Re: [PATCH v4 2/2] ovl: introduce new "uuid=off" option for inodes index feature

2020-09-25 Thread Amir Goldstein
On Fri, Sep 25, 2020 at 11:35 AM Pavel Tikhomirov wrote: > > This replaces uuid with null in overelayfs file handles and thus relaxes typo: overelayfs > uuid checks for overlay index feature. It is only possible in case there > is only one filesystem for all the work/upper/lower directories and

[PATCH][next] net/mlx5e: Fix potential null pointer dereference

2020-09-25 Thread Gustavo A. R. Silva
Calls to kzalloc() and kvzalloc() should be null-checked in order to avoid any potential failures. In this case, a potential null pointer dereference. Fix this by adding null checks for _parse_attr_ and _flow_ right after allocation. Addresses-Coverity-ID: 1497154 ("Dereference before null check"

Re: [RFC PATCH v2] sched/fair: select idle cpu from idle cpumask in sched domain

2020-09-25 Thread Vincent Guittot
Le vendredi 25 sept. 2020 à 17:21:46 (+0800), Li, Aubrey a écrit : > Hi Vicent, > > On 2020/9/24 21:09, Vincent Guittot wrote: > > Would you mind share uperf(netperf load) result on your side? That's the > workload I have seen the most benefit this patch contributed under heavy > >>

Re: [PATCH v2 seccomp 3/6] seccomp/cache: Add "emulator" to check if filter is arg-dependent

2020-09-25 Thread YiFei Zhu
On Thu, Sep 24, 2020 at 10:04 PM YiFei Zhu wrote: > > Why do the prepare here instead of during attach? (And note that it > > should not be written to fail.) > > Right. During attach a spinlock (current->sighand->siglock) is held. Do we really want to put the emulator in the "atomic section"? Yi

Re: [PATCH 2/5] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC

2020-09-25 Thread Andy Shevchenko
On Thu, Sep 24, 2020 at 10:34:20PM -0400, Ethan Zhao wrote: > When root port has DPC capability and it is enabled, then triggered by > errors, DPC > DLLSC and PDC interrupts will be sent to DPC driver, pciehp driver at the > same time. > That will cause following result: > > 1. Link and device a

Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Eric Biggers
On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote: > On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: > > Hi, > > > > I don't see any problem here, thanks for your report. :) > > > > Thanks, > > What about if max_depth == 0 in __f2fs_find_entry()? Then __f2fs_find_entry() > w

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Shakeel Butt
On Fri, Sep 25, 2020 at 9:32 AM Shakeel Butt wrote: > > On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > > > On Fri, Sep 25, 2020 at 03:31:45PM +0800, Ming Lei wrote: > > > On Thu, Sep 24, 2020 at 09:13:11PM -0400, Theodore Y. Ts'o wrote: > > > > On Thu, Sep 24, 2020 at 10:33:45AM -0400, Theod

Re: [PATCH v13 8/8] x86/vsyscall/64: Fixup Shadow Stack and Indirect Branch Tracking for vsyscall emulation

2020-09-25 Thread Yu, Yu-cheng
On 9/25/2020 9:31 AM, Andy Lutomirski wrote: On Fri, Sep 25, 2020 at 7:58 AM Yu-cheng Yu wrote: [...] @@ -286,6 +289,37 @@ bool emulate_vsyscall(unsigned long error_code, /* Emulate a ret instruction. */ regs->ip = caller; regs->sp += 8; + +#ifdef CONFIG_X86_CET

[PATCH v2 0/2] regmap: add support to regmap_field_bulk_alloc/free

2020-09-25 Thread Srinivas Kandagatla
Usage of regmap_field_alloc becomes much overhead when number of fields exceed more than 3. Most of driver seems to totally covered up with these allocs/free making to very hard to read the code! On such driver is QCOM LPASS driver has extensively converted to use regmap_fields. This patchset add

[PATCH v2 1/2] regmap: add support to regmap_field_bulk_alloc/free apis

2020-09-25 Thread Srinivas Kandagatla
Usage of regmap_field_alloc becomes much overhead when number of fields exceed more than 3. QCOM LPASS driver has extensively converted to use regmap_fields. Using new bulk api to allocate fields makes it much more cleaner code to read! Signed-off-by: Srinivas Kandagatla Tested-by: Srinivasa Rao

[PATCH v2 2/2] ASoC: lpass-platform: use devm_regmap_field_bulk_alloc

2020-09-25 Thread Srinivas Kandagatla
use new devm_regmap_field_bulk_alloc to allocate fields as it make the code more readable! Signed-off-by: Srinivas Kandagatla Tested-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-platform.c | 31 +++ 1 file changed, 7 insertions(+), 24 deletions(-) diff --git

Re: [PATCH v3 2/3] misc: bcm-vk: add Broadcom VK driver

2020-09-25 Thread Scott Branden
Hi Greg, On 2020-09-24 10:10 p.m., Greg Kroah-Hartman wrote: > On Thu, Sep 24, 2020 at 02:40:08PM -0700, Scott Branden wrote: >>> Ugh, yes, it is uncommon because those are two different things. Why do >>> you need/want a misc driver to control a tty device? Why do you need a >>> tty device? Wh

Re: [PATCH 7/9] sched: Add migrate_disable()

2020-09-25 Thread Sebastian Andrzej Siewior
On 2020-09-21 18:36:04 [+0200], Peter Zijlstra wrote: > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1700,6 +1700,68 @@ void check_preempt_curr(struct rq *rq, s > > #ifdef CONFIG_SMP > > +#ifdef CONFIG_PREEMPT_RT … > +static inline bool is_migration_disabled(struct task_struct *

Re: [PATCH v13 8/8] x86/vsyscall/64: Fixup Shadow Stack and Indirect Branch Tracking for vsyscall emulation

2020-09-25 Thread Andy Lutomirski
> On Sep 25, 2020, at 9:48 AM, Yu, Yu-cheng wrote: > > On 9/25/2020 9:31 AM, Andy Lutomirski wrote: >>> On Fri, Sep 25, 2020 at 7:58 AM Yu-cheng Yu wrote: >>> > > [...] > >>> @@ -286,6 +289,37 @@ bool emulate_vsyscall(unsigned long error_code, >>> /* Emulate a ret instruction. */

Re: [PATCH 4.19 23/37] ipv4: Update exception handling for multipath routes via same device

2020-09-25 Thread Pavel Machek
Hi! > [ Upstream commit 2fbc6e89b2f1403189e624cabaf73e189c5e50c6 ] > > Kfir reported that pmtu exceptions are not created properly for > deployments where multipath routes use the same device. This is mismerged (in a way that does not affect functionality): > @@ -779,6 +779,8 @@ static void __

Re: [PATCH] ALSA: rockchip: fix a possible divide-by-zero bug in rockchip_i2s_hw_params()

2020-09-25 Thread Mark Brown
On Sun, Aug 30, 2020 at 05:51:06PM +0800, Tuo Li wrote: > The variable bclk_rate is checked in: > if (bclk_rate && mclk_rate % bclk_rate) Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what e

Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-25 Thread Lyude Paul
On Thu, 2020-09-24 at 17:46 -0600, Kevin Chowski wrote: > cc back a few others who were unintentionally dropped from the thread > earlier. > > Someone (at Google) helped me dig into this a little more and they > found a document titled "eDP Backlight Brightness bit alignment" sent > out for review

[GIT PULL] Power management fixes for v5.9-rc7

2020-09-25 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-5.9-rc7 with top-most commit 6040723009060ed356dc93dd9a27e80b2206e59b Merge branch 'pm-cpuidle' on top of commit ba4f184e126b751d1bffad5897f263108befc780 Linux 5.9-rc6 to receive pow

Re: [RFC] mm: Allow 64-bit mmap syscalls to access higher addresses.

2020-09-25 Thread Derek Lesho
For some reason, git send-email cut off the first paragprah in my first email, so I'm resending it now: Hello everyone, I am sending this mostly as a discussion starter/curiosity. I would like to be able to use the 48-bit address range while in long mode on an IA32 process. However, these two

Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

2020-09-25 Thread Sinan Kaya
On 9/25/2020 1:11 AM, Kuppuswamy, Sathyanarayanan wrote: > > > On 9/24/20 1:52 PM, Sinan Kaya wrote: >> On 9/24/2020 12:06 AM, Kuppuswamy, Sathyanarayanan wrote: >> >> So, this is a matter of moving the save/restore logic from the hotplug >> driver into common code so that DPC slot reset takes a

Can we credibly make vdso_sgx_enter_enclave() pleasant to use?

2020-09-25 Thread Andy Lutomirski
vdso_sgx_enter_enclave() sucks. I don't think anyone seriously likes it, but maybe it's the best we can do. I'm wondering if it's worth trying to do better. Here's what I'd like if I could wave a magic wand: struct sgx_enclave_run { __u64 tcs; __u32 flags; __u32 exit_reason;

[PATCH][next] dpaa2-mac: Fix potential null pointer dereference

2020-09-25 Thread Gustavo A. R. Silva
There is a null-check for _pcs_, but it is being dereferenced prior to this null-check. So, if _pcs_ can actually be null, then there is a potential null pointer dereference that should be fixed by null-checking _pcs_ before being dereferenced. Addresses-Coverity-ID: 1497159 ("Dereference before n

[PATCH v13 04/26] x86/cet: Add control-protection fault handler

2020-09-25 Thread Yu-cheng Yu
A control-protection fault is triggered when a control-flow transfer attempt violates Shadow Stack or Indirect Branch Tracking constraints. For example, the return address for a RET instruction differs from the copy on the Shadow Stack; or an indirect JMP instruction, without the NOTRACK prefix, ar

Re: [RFC PATCH 0/3] KVM: Introduce "VM bugged" concept

2020-09-25 Thread Sean Christopherson
On Fri, Sep 25, 2020 at 05:32:53PM +0100, Marc Zyngier wrote: > Hi Sean, > > On Wed, 23 Sep 2020 23:45:27 +0100, > Sean Christopherson wrote: > > > > This series introduces a concept we've discussed a few times in x86 land. > > The crux of the problem is that x86 has a few cases where KVM could

Re: [PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST

2020-09-25 Thread Krzysztof Kozlowski
> Cc: Krzysztof Kozlowski > --- > drivers/mmc/host/Kconfig |1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200925.orig/drivers/mmc/host/Kconfig > +++ linux-next-20200925/drivers/mmc/host/Kconfig > @@ -425,6 +425,7 @@ config MMC_SDHCI_IPROC > config

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-25 Thread Mathieu Desnoyers
- On Sep 25, 2020, at 12:26 PM, rostedt rost...@goodmis.org wrote: > On Fri, 25 Sep 2020 11:30:06 -0400 (EDT) > Mathieu Desnoyers wrote: > >> > Anyway, I don't see any issues with the current patch set as is >> > (besides the documentation fix, which I already updated locally). And >> > will

Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon)

2020-09-25 Thread Julia Lawall
On Thu, 24 Sep 2020, Joe Perches wrote: > On Thu, 2020-09-24 at 23:53 +0200, Thomas Gleixner wrote: > > On Thu, Sep 24 2020 at 13:33, Joe Perches wrote: > > > On Thu, 2020-09-24 at 22:19 +0200, Thomas Gleixner wrote: > > > > On Sat, Aug 22 2020 at 09:07, Julia Lawall wrote: > > > > > On Fri, 21

Re: [PATCH v2 2/2] locktorture: call percpu_free_rwsem() to do percpu-rwsem cleanup

2020-09-25 Thread Paul E. McKenney
On Thu, Sep 24, 2020 at 10:18:54PM +0800, Hou Tao wrote: > When do percpu-rwsem writer lock torture, the RCU callback > rcu_sync_func() may still be pending after locktorture module > is removed, and it will lead to the following Oops: > > BUG: unable to handle page fault for address: c0

[PATCH v13 26/26] mm: Introduce PROT_SHSTK for shadow stack

2020-09-25 Thread Yu-cheng Yu
There are three possible options to create a shadow stack allocation API: an arch_prctl, a new syscall, or adding PROT_SHSTK to mmap()/mprotect(). Each has its advantages and compromises. An arch_prctl() is the least intrusive. However, the existing x86 arch_prctl() takes only two parameters. Mu

Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

2020-09-25 Thread Kuppuswamy, Sathyanarayanan
On 9/25/20 9:55 AM, Sinan Kaya wrote: On 9/25/2020 1:11 AM, Kuppuswamy, Sathyanarayanan wrote: On 9/24/20 1:52 PM, Sinan Kaya wrote: On 9/24/2020 12:06 AM, Kuppuswamy, Sathyanarayanan wrote: So, this is a matter of moving the save/restore logic from the hotplug driver into common code

[PATCH] habanalabs/gaudi: use correct define for qman init

2020-09-25 Thread Oded Gabbay
There was a copy-paste error, and the wrong define was used for initializing the QMAN. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/g

Re: [f2fs-dev] [PATCH] f2fs: fix uninit-value in f2fs_lookup

2020-09-25 Thread Eric Biggers
On Fri, Sep 25, 2020 at 11:19:26PM +0800, Chao Yu wrote: > From: Chao Yu > > As syzbot reported: > > Call Trace: > __dump_stack lib/dump_stack.c:77 [inline] > dump_stack+0x21c/0x280 lib/dump_stack.c:118 > kmsan_report+0xf7/0x1e0 mm/kmsan/kmsan_report.c:122 > __msan_warning+0x58/0xa0 mm/kmsan

[PATCH] bus: mhi: core: debugfs: Use correct format specifiers for addresses

2020-09-25 Thread Manivannan Sadhasivam
For exposing the addresses of read/write pointers and doorbell register, let's use the correct format specifiers. This fixes the following issues generated using W=1 build in ARM32 and reported by Kbuild bot: All warnings (new ones prefixed by >>): >> drivers/bus/mhi/core/debugfs.c:75:7: warning:

Re: [PATCH v7 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-09-25 Thread Joe Perches
(adding cc's to Anton Altaparmakov and linux-ntfs-dev) On Fri, 2020-09-25 at 18:55 +0300, Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. This code should eventually supplant the existing NTFS implementation right? Unless there is some specific reason you have not

Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features

2020-09-25 Thread Borislav Petkov
On Wed, Sep 23, 2020 at 10:45:29AM +0800, Feng Tang wrote: > > Rather than a tool, would additional file(s) in, say, > > /sys/devices/system/cpu/cpu be nicer? They could show the raw CPUID > > features, one file per leaf or sub-leaf, maybe even along with whether > > they were disabled at boot-time

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Linus Torvalds
On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > git bisect shows the first bad commit: > > [10befea91b61c4e2c2d1df06a2e978d182fcf792] mm: memcg/slab: use a > single set of > kmem_caches for all allocations > > And I have double checked that the above commit is really t

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Shakeel Butt
On Fri, Sep 25, 2020 at 10:17 AM Linus Torvalds wrote: > > On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > > > git bisect shows the first bad commit: > > > > [10befea91b61c4e2c2d1df06a2e978d182fcf792] mm: memcg/slab: use a > > single set of > > kmem_caches for all all

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Roman Gushchin
On Fri, Sep 25, 2020 at 09:47:43AM -0700, Shakeel Butt wrote: > On Fri, Sep 25, 2020 at 9:32 AM Shakeel Butt wrote: > > > > On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > > > > > On Fri, Sep 25, 2020 at 03:31:45PM +0800, Ming Lei wrote: > > > > On Thu, Sep 24, 2020 at 09:13:11PM -0400, Theod

Re: [PATCH v38 10/24] mm: Add vm_ops->mprotect()

2020-09-25 Thread Dave Hansen
Thanks for the walkthrough. The thing that clicked for me seeing those examples was how the earlier ioctl(ADD_PAGE) is "bound" to later enforcement actions at enclave PTE creation time. On 9/24/20 5:00 PM, Sean Christopherson wrote: > My concern is that if we merge this > > ioctl(sgx_fd,

Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features

2020-09-25 Thread Borislav Petkov
On Tue, Sep 22, 2020 at 01:27:50PM +0800, Feng Tang wrote: > +++ b/tools/arch/x86/kcpuid/cpuid.txt > @@ -0,0 +1,58 @@ > +# Leaf 00H > + > +LEAF[],SUBLEAF[00],EAX[ 31:0],max_basic_leafs, Max input value for > supported subleafs > + > + > +# Leaf 01H > + > +LEAF[0001],SUBLEAF[00],EAX[ 3

Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon)

2020-09-25 Thread Joe Perches
On Fri, 2020-09-25 at 19:06 +0200, Julia Lawall wrote: > On Thu, 24 Sep 2020, Joe Perches wrote: > > On Thu, 2020-09-24 at 23:53 +0200, Thomas Gleixner wrote: > > > On Thu, Sep 24 2020 at 13:33, Joe Perches wrote: > > > > On Thu, 2020-09-24 at 22:19 +0200, Thomas Gleixner wrote: > > > > > On Sat, A

Re: [RFC PATCH 3/3] KVM: x86: Use KVM_BUG/KVM_BUG_ON to handle bugs that are fatal to the VM

2020-09-25 Thread Sean Christopherson
On Fri, Sep 25, 2020 at 11:50:38AM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > On Thu, Sep 24, 2020 at 02:34:14PM +0200, Vitaly Kuznetsov wrote: > >> Sean Christopherson writes: > >> > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > >> > index 6f9a0c6d5dc5..

Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features

2020-09-25 Thread Dave Hansen
On 9/25/20 10:24 AM, Borislav Petkov wrote: > # LEAF,SUBLEAF,register, bits,short name, long name > 1,0, EBX, 7:0,brand,Brand Index > 1,0, EBX, 15:8,clflush_size,CLFLUSH line size (value * 8) > in bytes >1, 0, EBX, 23:16,max_cpu_id,Maxim n

Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features

2020-09-25 Thread Borislav Petkov
On Tue, Sep 22, 2020 at 12:38:30PM -0700, Dave Hansen wrote: > or something. It also needs a "-f" argument to override this default > location. Yah, the -f thing is almost mandatory. I can imagine simply downloading the latest cpuid.leafs or so and then running kcpuid on it. Can't get any better

Re: [RFC V2 0/9] x86/mmu:Introduce parallel memory virtualization to boost performance

2020-09-25 Thread Ben Gardon
On Fri, Sep 25, 2020 at 5:04 AM yulei zhang wrote: > > On Fri, Sep 25, 2020 at 1:14 AM Ben Gardon wrote: > > > > On Wed, Sep 23, 2020 at 11:28 PM Wanpeng Li wrote: > > > > > > Any comments? Paolo! :) > > > > Hi, sorry to be so late in replying! I wanted to post the first part > > of the TDP MMU

Re: [PATCH v2 0/2] INVD intercept change to skip instruction

2020-09-25 Thread Paolo Bonzini
On 24/09/20 23:20, Jim Mattson wrote: > On Thu, Sep 24, 2020 at 11:42 AM Tom Lendacky wrote: >> >> From: Tom Lendacky >> >> This series updates the INVD intercept support for both SVM and VMX to >> skip the instruction rather than emulating it, since emulation of this >> instruction is just a NOP

Re: [PATCH] Bluetooth: Fix the vulnerable issue on enc key size

2020-09-25 Thread Marcel Holtmann
Hi Alex, >>> When someone attacks the service provider, it creates connection, >>> authenticates. Then it requests key size of one byte and it identifies >>> the key with brute force methods. >>> >>> After l2cap info req/resp exchange is complete. the attacker sends l2cap >>> connect with specifi

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Shakeel Butt
On Fri, Sep 25, 2020 at 10:22 AM Shakeel Butt wrote: > > On Fri, Sep 25, 2020 at 10:17 AM Linus Torvalds > wrote: > > > > On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > > > > > git bisect shows the first bad commit: > > > > > > [10befea91b61c4e2c2d1df06a2e978d182fcf792] mm: memcg/sl

Re: [PATCH v5 4/4] Bluetooth: Add toggle to switch off interleave scan

2020-09-25 Thread Marcel Holtmann
Hi Howard, > This patch add a configurable parameter to switch off the interleave > scan feature. > > Signed-off-by: Howard Chung > Reviewed-by: Alain Michaud > --- > > (no changes since v4) > > Changes in v4: > - Set EnableAdvMonInterleaveScan default to Disable > - Fix 80 chars limit in mgm

Re: [PATCH v6 bpf-next 4/6] selftests/bpf: add bpf_snprintf_btf helper tests

2020-09-25 Thread Andrii Nakryiko
On Thu, Sep 24, 2020 at 5:51 PM Alexei Starovoitov wrote: > > On Wed, Sep 23, 2020 at 06:46:26PM +0100, Alan Maguire wrote: > > +static int __strncmp(const void *m1, const void *m2, size_t len) > > +{ > > + const unsigned char *s1 = m1; > > + const unsigned char *s2 = m2; > > + int i,

Re: [PATCH 4.19 00/37] 4.19.148-rc1 review

2020-09-25 Thread Pavel Machek
Hi! > This is the start of the stable review cycle for the 4.19.148 release. > There are 37 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. CIP testing did not detect any problems. https://gitlab.co

Re: [PATCH v2] : Add nitems() and snitems() macros

2020-09-25 Thread Jonathan Wakely
On 25/09/20 18:30 +0200, Alejandro Colomar via Libstdc++ wrote: Hello Jonathan, On 2020-09-25 16:48, Jonathan Wakely wrote: Do you really need to provide snitems? Users can use (ptrdiff_t)nitems if needed, can't they? They can, but that adds casts in the code, which makes longer lines that a

Re: [PATCH v1 1/4] mm: memcontrol: use helpers to access page's memcg data

2020-09-25 Thread Johannes Weiner
On Thu, Sep 24, 2020 at 01:27:00PM -0700, Roman Gushchin wrote: > On Thu, Sep 24, 2020 at 03:45:08PM -0400, Johannes Weiner wrote: > > On Tue, Sep 22, 2020 at 01:36:57PM -0700, Roman Gushchin wrote: > > > Currently there are many open-coded reads and writes of the > > > page->mem_cgroup pointer, as

Re: [PATCH v2] : Add nitems() and snitems() macros

2020-09-25 Thread Jonathan Wakely
On 25/09/20 18:30 +0200, Alejandro Colomar via Libstdc++ wrote: I have a similar number of ARRAY_SIZE() and ARRAY_SSIZE(). I could have '#define snitems(arr) ((ptrdiff_t)nitems(arr))' in my projects, but is it really necessary? The barrier for adding something to glibc headers should be a LOT h

Re: [PATCH v2] : Add nitems() and snitems() macros

2020-09-25 Thread Alejandro Colomar
On 2020-09-25 19:39, Jonathan Wakely wrote: > Yes, I'm aware of all the rationale. I already said that it makes > sense in C++ where you have generic code. I am not convinced that it's > necessary to add to when all it does is a cast from > size_t to ptrdiff_t. > While I would prefer a signed

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Roman Gushchin
On Fri, Sep 25, 2020 at 10:35:03AM -0700, Shakeel Butt wrote: > On Fri, Sep 25, 2020 at 10:22 AM Shakeel Butt wrote: > > > > On Fri, Sep 25, 2020 at 10:17 AM Linus Torvalds > > wrote: > > > > > > On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > > > > > > > git bisect shows the first bad commi

Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

2020-09-25 Thread Sinan Kaya
On 9/25/2020 1:11 PM, Kuppuswamy, Sathyanarayanan wrote: >> Why? Isn't DPC slot reset enough? > It will do the reset at hardware level. But driver state is not > cleaned up. So doing bus reset will restore both driver and > hardware states. I really don't like this. If hotplug driver is restoring

Re: [git pull] drm fixes for 5.9-rc7

2020-09-25 Thread pr-tracker-bot
The pull request you sent on Fri, 25 Sep 2020 11:45:04 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2020-09-25 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/574ec42e1a9c4bfb8b2eef8d801a77e92bcea76a Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [GIT PULL] Power management fixes for v5.9-rc7

2020-09-25 Thread pr-tracker-bot
The pull request you sent on Fri, 25 Sep 2020 18:53:13 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git pm-5.9-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/15083aa02561f6f208a253132c9d3b72af8c2b40 Thank you! -- Deet-doot-dot, I am a b

Re: [PATCH 0/9] sched: Migrate disable support

2020-09-25 Thread Valentin Schneider
On 25/09/20 13:19, Valentin Schneider wrote: > On 25/09/20 12:58, Dietmar Eggemann wrote: >> With Valentin's print_rq() inspired test snippet I always see one of the >> RT user tasks as the second guy? BTW, it has to be RT tasks, never >> triggered with CFS tasks. >> >> [ 57.849268] CPU2 nr_run

Re: [GIT PULL] Please pull RDMA subsystem changes

2020-09-25 Thread pr-tracker-bot
The pull request you sent on Fri, 25 Sep 2020 09:57:29 -0300: > git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/33d04c66f5799befa7c0c618be387541d0c311a3 Thank you! -- Deet-doot-dot, I am a bot

Re: [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA

2020-09-25 Thread Doug Anderson
Hi, On Fri, Sep 25, 2020 at 9:26 AM Stephen Boyd wrote: > > On newer keyboards this key is in a different place. Add both options to > the keymap so that both new and old keyboards work. > > Cc: Douglas Anderson > Signed-off-by: Stephen Boyd > --- > arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1

Re: [PATCH v12 07/29] media: v4l2-mem2mem: add v4l2_m2m_suspend, v4l2_m2m_resume

2020-09-25 Thread Adrian Ratiu
Hi, I'm having a problem with this patch which landed in linux-next. On Fri, 14 Aug 2020, Xia Jiang wrote: From: Pi-Hsun Shih Add two functions that can be used to stop new jobs from being queued / continue running queued job. This can be used while a driver using m2m helper is going to su

Re: [PATCH v12 07/29] media: v4l2-mem2mem: add v4l2_m2m_suspend, v4l2_m2m_resume

2020-09-25 Thread Tomasz Figa
On Fri, Sep 25, 2020 at 08:53:09PM +0300, Adrian Ratiu wrote: > Hi, > > I'm having a problem with this patch which landed in linux-next. > > On Fri, 14 Aug 2020, Xia Jiang wrote: > > From: Pi-Hsun Shih > > > > Add two functions that can be used to stop new jobs from being queued / > > continue

Re: [RFC-PATCH 2/4] mm: Add __rcu_alloc_page_lockless() func.

2020-09-25 Thread Uladzislau Rezki
On Fri, Sep 25, 2020 at 05:17:12PM +0100, Mel Gorman wrote: > On Fri, Sep 25, 2020 at 05:31:29PM +0200, Uladzislau Rezki wrote: > > > > > > > > > > > > All good points! > > > > > > > > > > > > On the other hand, duplicating a portion of the allocator > > > > > > functionality > > > > > > within

Re: [stable 5.8] rcu: INFO: rcu_sched self-detected stall on CPU - RIP: 0010:trace_graph_return

2020-09-25 Thread Paul E. McKenney
On Fri, Sep 25, 2020 at 12:40:43PM +0530, Naresh Kamboju wrote: > While running LTP trace test case on qemu_x86_64, qemu_i386 and i386 > the following kernel rcu: INFO reported. > > Easily reproducible on qemu_x86_64, qemu_i386 and i386 devices. > > steps to reproduce: > # Boot qemu_x86_64 or

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Shakeel Butt
On Fri, Sep 25, 2020 at 10:48 AM Roman Gushchin wrote: > > On Fri, Sep 25, 2020 at 10:35:03AM -0700, Shakeel Butt wrote: > > On Fri, Sep 25, 2020 at 10:22 AM Shakeel Butt wrote: > > > > > > On Fri, Sep 25, 2020 at 10:17 AM Linus Torvalds > > > wrote: > > > > > > > > On Fri, Sep 25, 2020 at 9:19

Re: [Linux-kernel-mentees] [PATCH] Fix uninit-value in hci_chan_lookup_handle

2020-09-25 Thread Anant Thazhemadam
On 05/09/20 7:34 am, Anant Thazhemadam wrote: > When the amount of data stored in the location corresponding to > iov_iter *from is less then 4, some data seems to go uninitialized. > > Updating this condition accordingly, makes sense both intuitively and > logically as well, since the other che

Re: [PATCH] bus: mhi: core: debugfs: Use correct format specifiers for addresses

2020-09-25 Thread Jeffrey Hugo
On 9/25/2020 11:16 AM, Manivannan Sadhasivam wrote: For exposing the addresses of read/write pointers and doorbell register, let's use the correct format specifiers. This fixes the following issues generated using W=1 build in ARM32 and reported by Kbuild bot: All warnings (new ones prefixed by

Re: [PATCH v2 1/2] perf vendor events: Update CascadelakeX events to v1.08

2020-09-25 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 23, 2020 at 09:25:06AM +0800, Jin, Yao escreveu: > On 9/23/2020 3:42 AM, Arnaldo Carvalho de Melo wrote: > > Em Tue, Sep 22, 2020 at 11:19:17AM +0800, Jin Yao escreveu: > > > - Update CascadelakeX events to v1.08. > > > - Update CascadelakeX JSON metrics from TMAM 4.0. > > > Other fixe

[PATCH v3] KVM: Check the allocation of pv cpu mask

2020-09-25 Thread lihaiwei . kernel
From: Haiwei Li check the allocation of per-cpu __pv_cpu_mask. Suggested-by: Vitaly Kuznetsov Signed-off-by: Haiwei Li --- v1 -> v2: * add CONFIG_SMP for kvm_send_ipi_mask_allbutself to prevent build error v2 -> v3: * always check the allocation of __pv_cpu_mask in kvm_flush_tlb_others arc

[PATCH v13 06/26] x86/mm: Change _PAGE_DIRTY to _PAGE_DIRTY_HW

2020-09-25 Thread Yu-cheng Yu
Before introducing _PAGE_COW for non-hardware memory management purposes in the next patch, rename _PAGE_DIRTY to _PAGE_DIRTY_HW and _PAGE_BIT_DIRTY to _PAGE_BIT_DIRTY_HW to make meanings more clear. There are no functional changes from this patch. Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Co

Re: [PATCH v1 3/4] mm: introduce page memcg flags

2020-09-25 Thread Johannes Weiner
On Thu, Sep 24, 2020 at 01:39:05PM -0700, Roman Gushchin wrote: > On Thu, Sep 24, 2020 at 04:01:22PM -0400, Johannes Weiner wrote: > > On Tue, Sep 22, 2020 at 01:36:59PM -0700, Roman Gushchin wrote: > > > The lowest bit in page->memcg_data is used to distinguish between > > > struct memory_cgroup p

[PATCH v13 14/26] x86/mm: Update maybe_mkwrite() for shadow stack

2020-09-25 Thread Yu-cheng Yu
Shadow stack memory is writable, but its VMA has VM_SHSTK instead of VM_WRITE. Update maybe_mkwrite() to include the shadow stack. Signed-off-by: Yu-cheng Yu --- arch/x86/Kconfig| 4 arch/x86/mm/pgtable.c | 18 ++ include/linux/mm.h | 2 ++ include/linux/pg

Re: WARNING: at kernel/workqueue.c:1473 __queue_work+0x3b8/0x3d0

2020-09-25 Thread Corentin Labbe
On Tue, Mar 03, 2020 at 04:31:11PM -0500, Daniel Jordan wrote: > On Tue, Mar 03, 2020 at 08:48:19AM +0100, Corentin Labbe wrote: > > The patch fix the issue. Thanks! > > Thanks for trying it! > > > So you could add: > > Reported-by: Corentin Labbe > > Tested-by: Corentin Labbe > > Tested-on: su

[RFC PATCH 2/2] selftests/rseq: Adapt x86-64 rseq selftest to rseq KTLS prototype

2020-09-25 Thread Mathieu Desnoyers
The rseq KTLS ABI only requires a single SET_KTLS_OFFSET system call at library init for the entire thread group. There is no more need for per-thread registration. The only architecture-specific part of this patch is rseq_get_thread_pointer, which is only implemented for x86-64 so far. Other arch

[RFC PATCH 1/2] rseq: Implement KTLS prototype for x86-64

2020-09-25 Thread Mathieu Desnoyers
Upstreaming efforts aiming to integrate rseq support into glibc led to interesting discussions, where we identified a clear need to extend the size of the per-thread structure shared between kernel and user-space (struct rseq). This is something that is not possible with the current rseq ABI. The

Re: [PATCH v4] Introduce support for Systems Management Driver over WMI for Dell Systems

2020-09-25 Thread Hans de Goede
Hi, On 9/25/20 5:32 PM, Limonciello, Mario wrote: So I do want to preface this response by mentioning that Dell's implementation is based off the PLDM specification from the DMTF. https://www.dmtf.org/sites/default/files/standards/documents/DSP0247_1.0.0.pdf A lot of the nomenclature that has b

Re: [PATCH 0/9] sched: Migrate disable support

2020-09-25 Thread Sebastian Andrzej Siewior
On 2020-09-21 18:35:57 [+0200], Peter Zijlstra wrote: > Hi, Hi, > Here's my take on migrate_disable(). It avoids growing a second means of I have here: |005: numa_remove_cpu cpu 5 node 0: mask now 0,3-4,6-7 |007: smpboot: CPU 5 is now offline |006: [ cut here ] |006: rq->

[PATCH v13 19/26] mm: Re-introduce do_mmap_pgoff()

2020-09-25 Thread Yu-cheng Yu
There was no more caller passing vm_flags to do_mmap(), and vm_flags was removed from the function's input by: commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()"). There is a new user now. Shadow stack allocation passes VM_SHSTK to do_mmap(). Re-introduce the vm

Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

2020-09-25 Thread Kuppuswamy, Sathyanarayanan
On 9/25/20 10:47 AM, Sinan Kaya wrote: On 9/25/2020 1:11 PM, Kuppuswamy, Sathyanarayanan wrote: Why? Isn't DPC slot reset enough? It will do the reset at hardware level. But driver state is not cleaned up. So doing bus reset will restore both driver and hardware states. I really don't like

Re: [PATCH 1/2] mips: Add strong UC ordering config

2020-09-25 Thread Serge Semin
On Fri, Sep 25, 2020 at 11:54:20AM +0800, Jiaxun Yang wrote: > > > 在 2020/9/20 19:00, Serge Semin 写道: > > In accordance with [1, 2] memory transactions using CCA=2 (Uncached > > Cacheability and Coherency Attribute) are always strongly ordered. This > > means the younger memory accesses using CCA

Re: [PATCH v3 3/4] of_net: add mac-address-increment support

2020-09-25 Thread Rob Herring
On Sun, Sep 20, 2020 at 3:57 AM Ansuel Smith wrote: > > Lots of embedded devices use the mac-address of other interface > extracted from nvmem cells and increments it by one or two. Add two > bindings to integrate this and directly use the right mac-address for > the interface. Some example are so

[tip: ras/core] RAS/CEC: Convert to DEFINE_SHOW_ATTRIBUTE()

2020-09-25 Thread tip-bot2 for Qinglang Miao
The following commit has been merged into the ras/core branch of tip: Commit-ID: 4bd442e9a8388e8ec4ba7cf23a4774989d93b78e Gitweb: https://git.kernel.org/tip/4bd442e9a8388e8ec4ba7cf23a4774989d93b78e Author:Qinglang Miao AuthorDate:Sat, 19 Sep 2020 09:22:52 +08:00 Committer:

[PATCH v3 3/4] i40e: Limit msix vectors to housekeeping CPUs

2020-09-25 Thread Nitesh Narayan Lal
If we have isolated CPUs designated to perform real-time tasks, to keep the latency overhead to a minimum for real-time CPUs IRQ vectors are moved to housekeeping CPUs from the userspace. Creating MSIX vectors only based on the online CPUs could lead to exhaustion of housekeeping CPU IRQ vectors in

[PATCH v3 2/4] sched/isolation: Extend nohz_full to isolate managed IRQs

2020-09-25 Thread Nitesh Narayan Lal
Extend nohz_full feature set to include isolation from managed IRQS. This is required specifically for setups that only uses nohz_full and still requires isolation for maintaining lower latency for the listed CPUs. Suggested-by: Frederic Weisbecker Signed-off-by: Nitesh Narayan Lal --- kernel/s

[PATCH v3 1/4] sched/isolation: API to get number of housekeeping CPUs

2020-09-25 Thread Nitesh Narayan Lal
Introduce a new API housekeeping_num_online_cpus(), that can be used to retrieve the number of online housekeeping CPUs based on the housekeeping flag passed by the caller. Some of the consumers for this API are the device drivers that were previously relying only on num_online_cpus() to determine

[PATCH v3 0/4] isolation: limit msix vectors to housekeeping CPUs

2020-09-25 Thread Nitesh Narayan Lal
This is a follow-up posting for "[PATCH v2 0/4] isolation: limit msix vectors based on housekeeping CPUs". Issue = With the current implementation device drivers while creating their MSIX         vectors only take num_online_cpus() into consideration which works quite well   for a non-RT envir

[PATCH v3 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-09-25 Thread Nitesh Narayan Lal
If we have isolated CPUs dedicated for use by real-time tasks, we try to move IRQs to housekeeping CPUs from the userspace to reduce latency overhead on the isolated CPUs. If we allocate too many IRQ vectors, moving them all to housekeeping CPUs may exceed per-CPU vector limits. When we have isol

[PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-09-25 Thread Amit Pundir
There are firmware versions which do not support host capability QMI request. We suspect either the host cap is not implemented or there may be firmware specific issues, but apparently there seem to be a generation of firmware that has this particular behavior. For example, firmware build on Xiaom

Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

2020-09-25 Thread Sinan Kaya
On 9/25/2020 2:16 PM, Kuppuswamy, Sathyanarayanan wrote: >> >> If this is a too involved change, DPC driver should restore state >> when hotplug is not supported. > Yes. we can add a condition for hotplug capability check. >> >> DPC driver should be self-sufficient by itself. >> Sounds good. >>>

Re: [PATCH v38 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call

2020-09-25 Thread Andrew Cooper
On 15/09/2020 12:28, Jarkko Sakkinen wrote: > diff --git a/arch/x86/entry/vdso/vsgx_enter_enclave.S > b/arch/x86/entry/vdso/vsgx_enter_enclave.S > new file mode 100644 > index ..adbd59d41517 > --- /dev/null > +++ b/arch/x86/entry/vdso/vsgx_enter_enclave.S > @@ -0,0 +1,157 @@ > +SYM_FUN

[PATCH RFT/RFC v2 02/47] MAINTAINERS: change maintainer of the zoran driver

2020-09-25 Thread Corentin Labbe
Add myself as maintainer. Signed-off-by: Corentin Labbe --- Documentation/media/v4l-drivers/zoran.rst | 22 +++--- MAINTAINERS| 10 ++ drivers/staging/media/zoran/zoran_card.c | 5 - drivers/staging/media/zoran/zoran_card.h | 5 -

[PATCH RFT/RFC v2 03/47] staging: media: zoran: datasheet is no longer available from zoran.com

2020-09-25 Thread Corentin Labbe
Simply remove this broken reference Signed-off-by: Corentin Labbe --- drivers/staging/media/zoran/zoran_device.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c index 04162be80420..79da964c678b 100644

[PATCH RFT/RFC v2 00/47] staging: media: bring back zoran driver

2020-09-25 Thread Corentin Labbe
Hello The zoran driver was removed in 5.3 The main reason of the removing was lack of motivation to convert it to VB2 Since I need it, I worked on bringing it back. So the plan to achieve it was: - clean up the coding style. - convert old usage/API - clean unused code - convert to VB2 I have tri

[PATCH RFT/RFC v2 06/47] staging: media: zoran: do not forward declare zr36057_init_vfe

2020-09-25 Thread Corentin Labbe
move function for avoiding forward declaration Signed-off-by: Corentin Labbe --- drivers/staging/media/zoran/zoran_device.c | 44 +++--- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran

<    3   4   5   6   7   8   9   10   11   12   >